{"action":"created","comment":{"url":"https://api.github.com/repos/sonicaj/iocage/pulls/comments/239606855","pull_request_review_id":182427509,"id":239606855,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTYwNjg1NQ==","diff_hunk":"@@ -21,30 +21,235 @@\n # STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING\n # IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE\n # POSSIBILITY OF SUCH DAMAGE.\n-import re\n+import os\n+import json\n+import subprocess\n+import tempfile\n+import uuid\n \n import pytest\n-from click.testing import CliRunner\n \n-import iocage_cli as ioc\n \n require_root = pytest.mark.require_root\n require_zpool = pytest.mark.require_zpool\n+require_dhcp = pytest.mark.require_dhcp\n+require_networking = pytest.mark.require_networking\n+\n+# LIST OF FLAGS in create TO TEST\n+# [c, C , r, t, p, n, u, b, T, e, s, f]\n+\n+# TODO: Test different jail props as well\n+\n+\n+@require_root\n+@require_zpool\n+def test_01_create_jail_with_uuid(release, jails, invoke_cli):\n+    u_flag = str(uuid.uuid4())\n+\n+    invoke_cli(\n+        ['create', '-r', release, '-u', u_flag]\n+    )\n+\n+    jails[u_flag] = {'release': release}\n+\n+\n+@require_root\n+@require_zpool\n+def test_02_create_jail_with_name(release, jails, invoke_cli):\n+    invoke_cli(\n+        ['create', '-r', release, '-n', 'name_jail']\n+    )\n+\n+    jails['name_jail'] = {'release': release}\n+\n+\n+@require_root\n+@require_zpool\n+def test_03_create_jail_with_uuid_and_short(release, jails, invoke_cli):\n+    u_flag = str(uuid.uuid4())","path":"tests/functional_tests/0003_create_test.py","position":52,"original_position":52,"commit_id":"4bf4d1ade5abc2d59bec968608b4d29e2a0f3dcc","original_commit_id":"4bf4d1ade5abc2d59bec968608b4d29e2a0f3dcc","user":{"login":"skarekrow","id":1589047,"node_id":"MDQ6VXNlcjE1ODkwNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1589047?v=4","gravatar_id":"","url":"https://api.github.com/users/skarekrow","html_url":"https://github.com/skarekrow","followers_url":"https://api.github.com/users/skarekrow/followers","following_url":"https://api.github.com/users/skarekrow/following{/other_user}","gists_url":"https://api.github.com/users/skarekrow/gists{/gist_id}","starred_url":"https://api.github.com/users/skarekrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skarekrow/subscriptions","organizations_url":"https://api.github.com/users/skarekrow/orgs","repos_url":"https://api.github.com/users/skarekrow/repos","events_url":"https://api.github.com/users/skarekrow/events{/privacy}","received_events_url":"https://api.github.com/users/skarekrow/received_events","type":"User","site_admin":false},"body":"We should catch this and return a descriptive exception","created_at":"2018-12-06T20:42:27Z","updated_at":"2018-12-06T20:59:29Z","html_url":"https://github.com/sonicaj/iocage/pull/1#discussion_r239606855","pull_request_url":"https://api.github.com/repos/sonicaj/iocage/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/sonicaj/iocage/pulls/comments/239606855"},"html":{"href":"https://github.com/sonicaj/iocage/pull/1#discussion_r239606855"},"pull_request":{"href":"https://api.github.com/repos/sonicaj/iocage/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/sonicaj/iocage/pulls/1","id":235600847,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NjAwODQ3","html_url":"https://github.com/sonicaj/iocage/pull/1","diff_url":"https://github.com/sonicaj/iocage/pull/1.diff","patch_url":"https://github.com/sonicaj/iocage/pull/1.patch","issue_url":"https://api.github.com/repos/sonicaj/iocage/issues/1","number":1,"state":"open","locked":false,"title":"Adding more tests to iocage","user":{"login":"sonicaj","id":17968138,"node_id":"MDQ6VXNlcjE3OTY4MTM4","avatar_url":"https://avatars2.githubusercontent.com/u/17968138?v=4","gravatar_id":"","url":"https://api.github.com/users/sonicaj","html_url":"https://github.com/sonicaj","followers_url":"https://api.github.com/users/sonicaj/followers","following_url":"https://api.github.com/users/sonicaj/following{/other_user}","gists_url":"https://api.github.com/users/sonicaj/gists{/gist_id}","starred_url":"https://api.github.com/users/sonicaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonicaj/subscriptions","organizations_url":"https://api.github.com/users/sonicaj/orgs","repos_url":"https://api.github.com/users/sonicaj/repos","events_url":"https://api.github.com/users/sonicaj/events{/privacy}","received_events_url":"https://api.github.com/users/sonicaj/received_events","type":"User","site_admin":false},"body":"This PR aims to add more tests to iocage testing as many flags as possible and covering commands/subcommands which we don't currently test","created_at":"2018-12-03T21:37:06Z","updated_at":"2018-12-06T20:59:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92f10308fa26c9b8e9b0ca155fe443dde6e25426","assignee":{"login":"sonicaj","id":17968138,"node_id":"MDQ6VXNlcjE3OTY4MTM4","avatar_url":"https://avatars2.githubusercontent.com/u/17968138?v=4","gravatar_id":"","url":"https://api.github.com/users/sonicaj","html_url":"https://github.com/sonicaj","followers_url":"https://api.github.com/users/sonicaj/followers","following_url":"https://api.github.com/users/sonicaj/following{/other_user}","gists_url":"https://api.github.com/users/sonicaj/gists{/gist_id}","starred_url":"https://api.github.com/users/sonicaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonicaj/subscriptions","organizations_url":"https://api.github.com/users/sonicaj/orgs","repos_url":"https://api.github.com/users/sonicaj/repos","events_url":"https://api.github.com/users/sonicaj/events{/privacy}","received_events_url":"https://api.github.com/users/sonicaj/received_events","type":"User","site_admin":false},"assignees":[{"login":"sonicaj","id":17968138,"node_id":"MDQ6VXNlcjE3OTY4MTM4","avatar_url":"https://avatars2.githubusercontent.com/u/17968138?v=4","gravatar_id":"","url":"https://api.github.com/users/sonicaj","html_url":"https://github.com/sonicaj","followers_url":"https://api.github.com/users/sonicaj/followers","following_url":"https://api.github.com/users/sonicaj/following{/other_user}","gists_url":"https://api.github.com/users/sonicaj/gists{/gist_id}","starred_url":"https://api.github.com/users/sonicaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonicaj/subscriptions","organizations_url":"https://api.github.com/users/sonicaj/orgs","repos_url":"https://api.github.com/users/sonicaj/repos","events_url":"https://api.github.com/users/sonicaj/events{/privacy}","received_events_url":"https://api.github.com/users/sonicaj/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1149205923,"node_id":"MDU6TGFiZWwxMTQ5MjA1OTIz","url":"https://api.github.com/repos/sonicaj/iocage/labels/WIP","name":"WIP","color":"f9f8b1","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sonicaj/iocage/pulls/1/commits","review_comments_url":"https://api.github.com/repos/sonicaj/iocage/pulls/1/comments","review_comment_url":"https://api.github.com/repos/sonicaj/iocage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonicaj/iocage/issues/1/comments","statuses_url":"https://api.github.com/repos/sonicaj/iocage/statuses/4bf4d1ade5abc2d59bec968608b4d29e2a0f3dcc","head":{"label":"sonicaj:ticket-59247","ref":"ticket-59247","sha":"4bf4d1ade5abc2d59bec968608b4d29e2a0f3dcc","user":{"login":"sonicaj","id":17968138,"node_id":"MDQ6VXNlcjE3OTY4MTM4","avatar_url":"https://avatars2.githubusercontent.com/u/17968138?v=4","gravatar_id":"","url":"https://api.github.com/users/sonicaj","html_url":"https://github.com/sonicaj","followers_url":"https://api.github.com/users/sonicaj/followers","following_url":"https://api.github.com/users/sonicaj/following{/other_user}","gists_url":"https://api.github.com/users/sonicaj/gists{/gist_id}","starred_url":"https://api.github.com/users/sonicaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonicaj/subscriptions","organizations_url":"https://api.github.com/users/sonicaj/orgs","repos_url":"https://api.github.com/users/sonicaj/repos","events_url":"https://api.github.com/users/sonicaj/events{/privacy}","received_events_url":"https://api.github.com/users/sonicaj/received_events","type":"User","site_admin":false},"repo":{"id":147712310,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc3MTIzMTA=","name":"iocage","full_name":"sonicaj/iocage","private":false,"owner":{"login":"sonicaj","id":17968138,"node_id":"MDQ6VXNlcjE3OTY4MTM4","avatar_url":"https://avatars2.githubusercontent.com/u/17968138?v=4","gravatar_id":"","url":"https://api.github.com/users/sonicaj","html_url":"https://github.com/sonicaj","followers_url":"https://api.github.com/users/sonicaj/followers","following_url":"https://api.github.com/users/sonicaj/following{/other_user}","gists_url":"https://api.github.com/users/sonicaj/gists{/gist_id}","starred_url":"https://api.github.com/users/sonicaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonicaj/subscriptions","organizations_url":"https://api.github.com/users/sonicaj/orgs","repos_url":"https://api.github.com/users/sonicaj/repos","events_url":"https://api.github.com/users/sonicaj/events{/privacy}","received_events_url":"https://api.github.com/users/sonicaj/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sonicaj/iocage","description":"A FreeBSD jail manager written in Python 3","fork":true,"url":"https://api.github.com/repos/sonicaj/iocage","forks_url":"https://api.github.com/repos/sonicaj/iocage/forks","keys_url":"https://api.github.com/repos/sonicaj/iocage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonicaj/iocage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonicaj/iocage/teams","hooks_url":"https://api.github.com/repos/sonicaj/iocage/hooks","issue_events_url":"https://api.github.com/repos/sonicaj/iocage/issues/events{/number}","events_url":"https://api.github.com/repos/sonicaj/iocage/events","assignees_url":"https://api.github.com/repos/sonicaj/iocage/assignees{/user}","branches_url":"https://api.github.com/repos/sonicaj/iocage/branches{/branch}","tags_url":"https://api.github.com/repos/sonicaj/iocage/tags","blobs_url":"https://api.github.com/repos/sonicaj/iocage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonicaj/iocage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonicaj/iocage/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonicaj/iocage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonicaj/iocage/statuses/{sha}","languages_url":"https://api.github.com/repos/sonicaj/iocage/languages","stargazers_url":"https://api.github.com/repos/sonicaj/iocage/stargazers","contributors_url":"https://api.github.com/repos/sonicaj/iocage/contributors","subscribers_url":"https://api.github.com/repos/sonicaj/iocage/subscribers","subscription_url":"https://api.github.com/repos/sonicaj/iocage/subscription","commits_url":"https://api.github.com/repos/sonicaj/iocage/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonicaj/iocage/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonicaj/iocage/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonicaj/iocage/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonicaj/iocage/contents/{+path}","compare_url":"https://api.github.com/repos/sonicaj/iocage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonicaj/iocage/merges","archive_url":"https://api.github.com/repos/sonicaj/iocage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonicaj/iocage/downloads","issues_url":"https://api.github.com/repos/sonicaj/iocage/issues{/number}","pulls_url":"https://api.github.com/repos/sonicaj/iocage/pulls{/number}","milestones_url":"https://api.github.com/repos/sonicaj/iocage/milestones{/number}","notifications_url":"https://api.github.com/repos/sonicaj/iocage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonicaj/iocage/labels{/name}","releases_url":"https://api.github.com/repos/sonicaj/iocage/releases{/id}","deployments_url":"https://api.github.com/repos/sonicaj/iocage/deployments","created_at":"2018-09-06T17:54:30Z","updated_at":"2018-12-05T17:38:39Z","pushed_at":"2018-12-06T17:42:27Z","git_url":"git://github.com/sonicaj/iocage.git","ssh_url":"git@github.com:sonicaj/iocage.git","clone_url":"https://github.com/sonicaj/iocage.git","svn_url":"https://github.com/sonicaj/iocage","homepage":"","size":3602,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"sonicaj:master","ref":"master","sha":"1256dcb3833468dc7e0b1f7afeebbb192e3693d6","user":{"login":"sonicaj","id":17968138,"node_id":"MDQ6VXNlcjE3OTY4MTM4","avatar_url":"https://avatars2.githubusercontent.com/u/17968138?v=4","gravatar_id":"","url":"https://api.github.com/users/sonicaj","html_url":"https://github.com/sonicaj","followers_url":"https://api.github.com/users/sonicaj/followers","following_url":"https://api.github.com/users/sonicaj/following{/other_user}","gists_url":"https://api.github.com/users/sonicaj/gists{/gist_id}","starred_url":"https://api.github.com/users/sonicaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonicaj/subscriptions","organizations_url":"https://api.github.com/users/sonicaj/orgs","repos_url":"https://api.github.com/users/sonicaj/repos","events_url":"https://api.github.com/users/sonicaj/events{/privacy}","received_events_url":"https://api.github.com/users/sonicaj/received_events","type":"User","site_admin":false},"repo":{"id":147712310,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc3MTIzMTA=","name":"iocage","full_name":"sonicaj/iocage","private":false,"owner":{"login":"sonicaj","id":17968138,"node_id":"MDQ6VXNlcjE3OTY4MTM4","avatar_url":"https://avatars2.githubusercontent.com/u/17968138?v=4","gravatar_id":"","url":"https://api.github.com/users/sonicaj","html_url":"https://github.com/sonicaj","followers_url":"https://api.github.com/users/sonicaj/followers","following_url":"https://api.github.com/users/sonicaj/following{/other_user}","gists_url":"https://api.github.com/users/sonicaj/gists{/gist_id}","starred_url":"https://api.github.com/users/sonicaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonicaj/subscriptions","organizations_url":"https://api.github.com/users/sonicaj/orgs","repos_url":"https://api.github.com/users/sonicaj/repos","events_url":"https://api.github.com/users/sonicaj/events{/privacy}","received_events_url":"https://api.github.com/users/sonicaj/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sonicaj/iocage","description":"A FreeBSD jail manager written in Python 3","fork":true,"url":"https://api.github.com/repos/sonicaj/iocage","forks_url":"https://api.github.com/repos/sonicaj/iocage/forks","keys_url":"https://api.github.com/repos/sonicaj/iocage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonicaj/iocage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonicaj/iocage/teams","hooks_url":"https://api.github.com/repos/sonicaj/iocage/hooks","issue_events_url":"https://api.github.com/repos/sonicaj/iocage/issues/events{/number}","events_url":"https://api.github.com/repos/sonicaj/iocage/events","assignees_url":"https://api.github.com/repos/sonicaj/iocage/assignees{/user}","branches_url":"https://api.github.com/repos/sonicaj/iocage/branches{/branch}","tags_url":"https://api.github.com/repos/sonicaj/iocage/tags","blobs_url":"https://api.github.com/repos/sonicaj/iocage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonicaj/iocage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonicaj/iocage/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonicaj/iocage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonicaj/iocage/statuses/{sha}","languages_url":"https://api.github.com/repos/sonicaj/iocage/languages","stargazers_url":"https://api.github.com/repos/sonicaj/iocage/stargazers","contributors_url":"https://api.github.com/repos/sonicaj/iocage/contributors","subscribers_url":"https://api.github.com/repos/sonicaj/iocage/subscribers","subscription_url":"https://api.github.com/repos/sonicaj/iocage/subscription","commits_url":"https://api.github.com/repos/sonicaj/iocage/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonicaj/iocage/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonicaj/iocage/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonicaj/iocage/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonicaj/iocage/contents/{+path}","compare_url":"https://api.github.com/repos/sonicaj/iocage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonicaj/iocage/merges","archive_url":"https://api.github.com/repos/sonicaj/iocage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonicaj/iocage/downloads","issues_url":"https://api.github.com/repos/sonicaj/iocage/issues{/number}","pulls_url":"https://api.github.com/repos/sonicaj/iocage/pulls{/number}","milestones_url":"https://api.github.com/repos/sonicaj/iocage/milestones{/number}","notifications_url":"https://api.github.com/repos/sonicaj/iocage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonicaj/iocage/labels{/name}","releases_url":"https://api.github.com/repos/sonicaj/iocage/releases{/id}","deployments_url":"https://api.github.com/repos/sonicaj/iocage/deployments","created_at":"2018-09-06T17:54:30Z","updated_at":"2018-12-05T17:38:39Z","pushed_at":"2018-12-06T17:42:27Z","git_url":"git://github.com/sonicaj/iocage.git","ssh_url":"git@github.com:sonicaj/iocage.git","clone_url":"https://github.com/sonicaj/iocage.git","svn_url":"https://github.com/sonicaj/iocage","homepage":"","size":3602,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sonicaj/iocage/pulls/1"},"html":{"href":"https://github.com/sonicaj/iocage/pull/1"},"issue":{"href":"https://api.github.com/repos/sonicaj/iocage/issues/1"},"comments":{"href":"https://api.github.com/repos/sonicaj/iocage/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/sonicaj/iocage/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/sonicaj/iocage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonicaj/iocage/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/sonicaj/iocage/statuses/4bf4d1ade5abc2d59bec968608b4d29e2a0f3dcc"}},"author_association":"OWNER"}}
{"actor":{"display_login":"skarekrow"}}