{"action":"created","issue":{"url":"https://api.github.com/repos/NPBruce/valkyrie/issues/934","repository_url":"https://api.github.com/repos/NPBruce/valkyrie","labels_url":"https://api.github.com/repos/NPBruce/valkyrie/issues/934/labels{/name}","comments_url":"https://api.github.com/repos/NPBruce/valkyrie/issues/934/comments","events_url":"https://api.github.com/repos/NPBruce/valkyrie/issues/934/events","html_url":"https://github.com/NPBruce/valkyrie/issues/934","id":374351956,"node_id":"MDU6SXNzdWUzNzQzNTE5NTY=","number":934,"title":"Test variable: add OR condition","user":{"login":"antontimmermans","id":42072372,"node_id":"MDQ6VXNlcjQyMDcyMzcy","avatar_url":"https://avatars3.githubusercontent.com/u/42072372?v=4","gravatar_id":"","url":"https://api.github.com/users/antontimmermans","html_url":"https://github.com/antontimmermans","followers_url":"https://api.github.com/users/antontimmermans/followers","following_url":"https://api.github.com/users/antontimmermans/following{/other_user}","gists_url":"https://api.github.com/users/antontimmermans/gists{/gist_id}","starred_url":"https://api.github.com/users/antontimmermans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antontimmermans/subscriptions","organizations_url":"https://api.github.com/users/antontimmermans/orgs","repos_url":"https://api.github.com/users/antontimmermans/repos","events_url":"https://api.github.com/users/antontimmermans/events{/privacy}","received_events_url":"https://api.github.com/users/antontimmermans/received_events","type":"User","site_admin":false},"labels":[{"id":536373156,"node_id":"MDU6TGFiZWw1MzYzNzMxNTY=","url":"https://api.github.com/repos/NPBruce/valkyrie/labels/D2E","name":"D2E","color":"0052cc","default":false},{"id":536373241,"node_id":"MDU6TGFiZWw1MzYzNzMyNDE=","url":"https://api.github.com/repos/NPBruce/valkyrie/labels/MoM2E","name":"MoM2E","color":"006b75","default":false},{"id":425409039,"node_id":"MDU6TGFiZWw0MjU0MDkwMzk=","url":"https://api.github.com/repos/NPBruce/valkyrie/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"closed","locked":false,"assignee":{"login":"BenRQ","id":40794717,"node_id":"MDQ6VXNlcjQwNzk0NzE3","avatar_url":"https://avatars0.githubusercontent.com/u/40794717?v=4","gravatar_id":"","url":"https://api.github.com/users/BenRQ","html_url":"https://github.com/BenRQ","followers_url":"https://api.github.com/users/BenRQ/followers","following_url":"https://api.github.com/users/BenRQ/following{/other_user}","gists_url":"https://api.github.com/users/BenRQ/gists{/gist_id}","starred_url":"https://api.github.com/users/BenRQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenRQ/subscriptions","organizations_url":"https://api.github.com/users/BenRQ/orgs","repos_url":"https://api.github.com/users/BenRQ/repos","events_url":"https://api.github.com/users/BenRQ/events{/privacy}","received_events_url":"https://api.github.com/users/BenRQ/received_events","type":"User","site_admin":false},"assignees":[{"login":"BenRQ","id":40794717,"node_id":"MDQ6VXNlcjQwNzk0NzE3","avatar_url":"https://avatars0.githubusercontent.com/u/40794717?v=4","gravatar_id":"","url":"https://api.github.com/users/BenRQ","html_url":"https://github.com/BenRQ","followers_url":"https://api.github.com/users/BenRQ/followers","following_url":"https://api.github.com/users/BenRQ/following{/other_user}","gists_url":"https://api.github.com/users/BenRQ/gists{/gist_id}","starred_url":"https://api.github.com/users/BenRQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenRQ/subscriptions","organizations_url":"https://api.github.com/users/BenRQ/orgs","repos_url":"https://api.github.com/users/BenRQ/repos","events_url":"https://api.github.com/users/BenRQ/events{/privacy}","received_events_url":"https://api.github.com/users/BenRQ/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/NPBruce/valkyrie/milestones/25","html_url":"https://github.com/NPBruce/valkyrie/milestone/25","labels_url":"https://api.github.com/repos/NPBruce/valkyrie/milestones/25/labels","id":3716143,"node_id":"MDk6TWlsZXN0b25lMzcxNjE0Mw==","number":25,"title":"2.2","description":"","creator":{"login":"redwolf2","id":4141621,"node_id":"MDQ6VXNlcjQxNDE2MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/4141621?v=4","gravatar_id":"","url":"https://api.github.com/users/redwolf2","html_url":"https://github.com/redwolf2","followers_url":"https://api.github.com/users/redwolf2/followers","following_url":"https://api.github.com/users/redwolf2/following{/other_user}","gists_url":"https://api.github.com/users/redwolf2/gists{/gist_id}","starred_url":"https://api.github.com/users/redwolf2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redwolf2/subscriptions","organizations_url":"https://api.github.com/users/redwolf2/orgs","repos_url":"https://api.github.com/users/redwolf2/repos","events_url":"https://api.github.com/users/redwolf2/events{/privacy}","received_events_url":"https://api.github.com/users/redwolf2/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":8,"state":"open","created_at":"2018-10-05T21:55:47Z","updated_at":"2018-11-23T19:52:03Z","due_on":null,"closed_at":null},"comments":49,"created_at":"2018-10-26T11:58:51Z","updated_at":"2018-11-24T18:43:06Z","closed_at":"2018-11-22T21:36:50Z","author_association":"NONE","body":"### Description of Problem or Question\r\nFollowing request is an enhancement request for creating scenarios in Valkyrie.\r\n\r\nFor my new scenario I am thinking about one story with different board layouts (selected random at start) and a random selected correct outcome. To complicated for me to just start building in Valkyrie, so I actually started designing it first on paper before I put it in Valkyrie.... Crazy world eh ;-)? \r\nBut while making the design I found out that programming the scenario could be less complicated if the variable test in an event have the option to add an OR condition.\r\n\r\nCurrently you can test multiple variables but they are interpreted as: \"Condition1 == TRUE\" AND \"round == 3\".. then process the actions of the event. If I want also another combination of conditions to trigger the same actions I have to create a new event with the same actions but different test conditions. This could lead to a large number of events with same actions but different conditions.\r\n\r\nI know this could be solved with \"silent\" tests events all calling the same action event for more consistent behavior and less chance of programming bugs. But it would be nice if there was an option to combine this in one event (for ease of programming, testing and maintenance). \r\n\r\nA typical use-case could be that I only want the actions to happen in certain rounds, depending if other conditions are met:\r\nIF (\"tileXrevealed == TRUE\" AND \"Hint1Discovered == TRUE\" AND \" Round == 2\" ) OR\r\n(\"tileYrevealed == TRUE\" AND \"Hint1Discovered == TRUE\" AND \" Round == 4\" ) OR\r\n(\"tileYrevealed == TRUE\" AND \"Hint1Discovered == TRUE\" AND \" Round == 7\" )\r\nTHEN\r\n Action: Spawn something\r\n\r\nSo yes, there is a workaround but with this option some scenarios could be written less in a complicated way."},"comment":{"url":"https://api.github.com/repos/NPBruce/valkyrie/issues/comments/441387563","html_url":"https://github.com/NPBruce/valkyrie/issues/934#issuecomment-441387563","issue_url":"https://api.github.com/repos/NPBruce/valkyrie/issues/934","id":441387563,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTM4NzU2Mw==","user":{"login":"antontimmermans","id":42072372,"node_id":"MDQ6VXNlcjQyMDcyMzcy","avatar_url":"https://avatars3.githubusercontent.com/u/42072372?v=4","gravatar_id":"","url":"https://api.github.com/users/antontimmermans","html_url":"https://github.com/antontimmermans","followers_url":"https://api.github.com/users/antontimmermans/followers","following_url":"https://api.github.com/users/antontimmermans/following{/other_user}","gists_url":"https://api.github.com/users/antontimmermans/gists{/gist_id}","starred_url":"https://api.github.com/users/antontimmermans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antontimmermans/subscriptions","organizations_url":"https://api.github.com/users/antontimmermans/orgs","repos_url":"https://api.github.com/users/antontimmermans/repos","events_url":"https://api.github.com/users/antontimmermans/events{/privacy}","received_events_url":"https://api.github.com/users/antontimmermans/received_events","type":"User","site_admin":false},"created_at":"2018-11-24T18:43:06Z","updated_at":"2018-11-24T18:43:06Z","author_association":"NONE","body":"It looks as if the tests in OLD scenarios disappear and have to re-programmed"}}
{"actor":{"display_login":"antontimmermans"}}