{"action":"created","comment":{"url":"https://api.github.com/repos/chocolatey/choco/pulls/comments/230692597","pull_request_review_id":171483851,"id":230692597,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDY5MjU5Nw==","diff_hunk":"@@ -290,34 +286,6 @@ private void get_msi_information(RegistryApplicationKey appKey, RegistryKey key)\n                      appKey.Version = set_if_empty(appKey.Version, msiProductKey.get_value_as_string(\"Version\"));\r\n                      appKey.VersionMajor = set_if_empty(appKey.VersionMajor, msiProductKey.get_value_as_string(\"VersionMajor\"));\r\n                      appKey.VersionMinor = set_if_empty(appKey.VersionMinor, msiProductKey.get_value_as_string(\"VersionMinor\"));\r\n-\r\n-                     // search components for install location if still empty\r\n-                     // the performance of this is very bad - without this the query is sub-second\r\n-                     // with this it takes about 15 seconds with around 200 apps installed\r\n-                     //if (string.IsNullOrWhiteSpace(appKey.InstallLocation) && !appKey.Publisher.contains(\"Microsoft\"))\r\n-                     //{\r\n-                     //    var msiComponentsKey = FaultTolerance.try_catch_with_logging_exception(\r\n-                     //       () => msiRegistryKey.OpenSubKey(\"{0}\\\\Components\".format_with(subKeyName), RegistryKeyPermissionCheck.ReadSubTree, RegistryRights.ReadKey),\r\n-                     //       \"Failed to open subkey named '{0}' for '{1}', likely due to permissions\".format_with(subKeyName, msiRegistryKey.Name),\r\n-                     //       logWarningInsteadOfError: true);\r\n-                     //    if (msiComponentsKey == null) continue;\r\n-\r\n-                     //    foreach (var msiComponentKeyName in msiComponentsKey.GetSubKeyNames())\r\n-                     //    {\r\n-                     //        var msiComponentKey = FaultTolerance.try_catch_with_logging_exception(\r\n-                     //           () => msiComponentsKey.OpenSubKey(msiComponentKeyName, RegistryKeyPermissionCheck.ReadSubTree, RegistryRights.ReadKey),\r\n-                     //           \"Failed to open subkey named '{0}' for '{1}', likely due to permissions\".format_with(subKeyName, msiRegistryKey.Name),\r\n-                     //           logWarningInsteadOfError: true);\r\n-\r\n-                     //        if (msiComponentKey.GetValueNames().Contains(userDataProductKeyId, StringComparer.OrdinalIgnoreCase))\r\n-                     //        {\r\n-                     //            _componentLoopCount++;\r\n-                     //            appKey.InstallLocation = set_if_empty(appKey.InstallLocation, get_install_location_estimate(msiComponentKey.get_value(userDataProductKeyId)));\r\n-                     //            if (!string.IsNullOrWhiteSpace(appKey.InstallLocation)) break;\r\n-                     //            if (_componentLoopCount >= 10) break;\r\n-                     //        }\r\n-                     //    }\r\n-                     //}\r","path":"src/chocolatey/infrastructure.app/services/RegistryService.cs","position":44,"original_position":44,"commit_id":"6b7009eec96afbca253d75e2bc17ca380f120762","original_commit_id":"6b7009eec96afbca253d75e2bc17ca380f120762","user":{"login":"TraGicCode","id":6224270,"node_id":"MDQ6VXNlcjYyMjQyNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6224270?v=4","gravatar_id":"","url":"https://api.github.com/users/TraGicCode","html_url":"https://github.com/TraGicCode","followers_url":"https://api.github.com/users/TraGicCode/followers","following_url":"https://api.github.com/users/TraGicCode/following{/other_user}","gists_url":"https://api.github.com/users/TraGicCode/gists{/gist_id}","starred_url":"https://api.github.com/users/TraGicCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TraGicCode/subscriptions","organizations_url":"https://api.github.com/users/TraGicCode/orgs","repos_url":"https://api.github.com/users/TraGicCode/repos","events_url":"https://api.github.com/users/TraGicCode/events{/privacy}","received_events_url":"https://api.github.com/users/TraGicCode/received_events","type":"User","site_admin":false},"body":"Hey @ferventcoder,\r\n\r\nWould u like me to add this code back for now?","created_at":"2018-11-05T10:06:11Z","updated_at":"2018-11-05T10:06:12Z","html_url":"https://github.com/chocolatey/choco/pull/1653#discussion_r230692597","pull_request_url":"https://api.github.com/repos/chocolatey/choco/pulls/1653","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/chocolatey/choco/pulls/comments/230692597"},"html":{"href":"https://github.com/chocolatey/choco/pull/1653#discussion_r230692597"},"pull_request":{"href":"https://api.github.com/repos/chocolatey/choco/pulls/1653"}},"in_reply_to_id":222020852},"pull_request":{"url":"https://api.github.com/repos/chocolatey/choco/pulls/1653","id":219740057,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NzQwMDU3","html_url":"https://github.com/chocolatey/choco/pull/1653","diff_url":"https://github.com/chocolatey/choco/pull/1653.diff","patch_url":"https://github.com/chocolatey/choco/pull/1653.patch","issue_url":"https://api.github.com/repos/chocolatey/choco/issues/1653","number":1653,"state":"open","locked":false,"title":"(maint) Fix unused local variable msbuild warnings","user":{"login":"TraGicCode","id":6224270,"node_id":"MDQ6VXNlcjYyMjQyNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6224270?v=4","gravatar_id":"","url":"https://api.github.com/users/TraGicCode","html_url":"https://github.com/TraGicCode","followers_url":"https://api.github.com/users/TraGicCode/followers","following_url":"https://api.github.com/users/TraGicCode/following{/other_user}","gists_url":"https://api.github.com/users/TraGicCode/gists{/gist_id}","starred_url":"https://api.github.com/users/TraGicCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TraGicCode/subscriptions","organizations_url":"https://api.github.com/users/TraGicCode/orgs","repos_url":"https://api.github.com/users/TraGicCode/repos","events_url":"https://api.github.com/users/TraGicCode/events{/privacy}","received_events_url":"https://api.github.com/users/TraGicCode/received_events","type":"User","site_admin":false},"body":"This removes all warnings that are not chocolatey deprecation specific.  One test could have used an empty lambda instead of an unused local variable and another unused variable was from code that got commented out.\r\n\r\nCloses #1652 ","created_at":"2018-10-02T15:09:26Z","updated_at":"2018-11-05T10:06:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"909a2660fda881baecc8d5179ae6e1c675f9f331","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/chocolatey/choco/pulls/1653/commits","review_comments_url":"https://api.github.com/repos/chocolatey/choco/pulls/1653/comments","review_comment_url":"https://api.github.com/repos/chocolatey/choco/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chocolatey/choco/issues/1653/comments","statuses_url":"https://api.github.com/repos/chocolatey/choco/statuses/6b7009eec96afbca253d75e2bc17ca380f120762","head":{"label":"TraGicCode:maint/remove-msbuild-unused-variable-warnings","ref":"maint/remove-msbuild-unused-variable-warnings","sha":"6b7009eec96afbca253d75e2bc17ca380f120762","user":{"login":"TraGicCode","id":6224270,"node_id":"MDQ6VXNlcjYyMjQyNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6224270?v=4","gravatar_id":"","url":"https://api.github.com/users/TraGicCode","html_url":"https://github.com/TraGicCode","followers_url":"https://api.github.com/users/TraGicCode/followers","following_url":"https://api.github.com/users/TraGicCode/following{/other_user}","gists_url":"https://api.github.com/users/TraGicCode/gists{/gist_id}","starred_url":"https://api.github.com/users/TraGicCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TraGicCode/subscriptions","organizations_url":"https://api.github.com/users/TraGicCode/orgs","repos_url":"https://api.github.com/users/TraGicCode/repos","events_url":"https://api.github.com/users/TraGicCode/events{/privacy}","received_events_url":"https://api.github.com/users/TraGicCode/received_events","type":"User","site_admin":false},"repo":{"id":151250961,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEyNTA5NjE=","name":"choco","full_name":"TraGicCode/choco","private":false,"owner":{"login":"TraGicCode","id":6224270,"node_id":"MDQ6VXNlcjYyMjQyNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6224270?v=4","gravatar_id":"","url":"https://api.github.com/users/TraGicCode","html_url":"https://github.com/TraGicCode","followers_url":"https://api.github.com/users/TraGicCode/followers","following_url":"https://api.github.com/users/TraGicCode/following{/other_user}","gists_url":"https://api.github.com/users/TraGicCode/gists{/gist_id}","starred_url":"https://api.github.com/users/TraGicCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TraGicCode/subscriptions","organizations_url":"https://api.github.com/users/TraGicCode/orgs","repos_url":"https://api.github.com/users/TraGicCode/repos","events_url":"https://api.github.com/users/TraGicCode/events{/privacy}","received_events_url":"https://api.github.com/users/TraGicCode/received_events","type":"User","site_admin":false},"html_url":"https://github.com/TraGicCode/choco","description":"Chocolatey - the package manager for Windows","fork":true,"url":"https://api.github.com/repos/TraGicCode/choco","forks_url":"https://api.github.com/repos/TraGicCode/choco/forks","keys_url":"https://api.github.com/repos/TraGicCode/choco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TraGicCode/choco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TraGicCode/choco/teams","hooks_url":"https://api.github.com/repos/TraGicCode/choco/hooks","issue_events_url":"https://api.github.com/repos/TraGicCode/choco/issues/events{/number}","events_url":"https://api.github.com/repos/TraGicCode/choco/events","assignees_url":"https://api.github.com/repos/TraGicCode/choco/assignees{/user}","branches_url":"https://api.github.com/repos/TraGicCode/choco/branches{/branch}","tags_url":"https://api.github.com/repos/TraGicCode/choco/tags","blobs_url":"https://api.github.com/repos/TraGicCode/choco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TraGicCode/choco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TraGicCode/choco/git/refs{/sha}","trees_url":"https://api.github.com/repos/TraGicCode/choco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TraGicCode/choco/statuses/{sha}","languages_url":"https://api.github.com/repos/TraGicCode/choco/languages","stargazers_url":"https://api.github.com/repos/TraGicCode/choco/stargazers","contributors_url":"https://api.github.com/repos/TraGicCode/choco/contributors","subscribers_url":"https://api.github.com/repos/TraGicCode/choco/subscribers","subscription_url":"https://api.github.com/repos/TraGicCode/choco/subscription","commits_url":"https://api.github.com/repos/TraGicCode/choco/commits{/sha}","git_commits_url":"https://api.github.com/repos/TraGicCode/choco/git/commits{/sha}","comments_url":"https://api.github.com/repos/TraGicCode/choco/comments{/number}","issue_comment_url":"https://api.github.com/repos/TraGicCode/choco/issues/comments{/number}","contents_url":"https://api.github.com/repos/TraGicCode/choco/contents/{+path}","compare_url":"https://api.github.com/repos/TraGicCode/choco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TraGicCode/choco/merges","archive_url":"https://api.github.com/repos/TraGicCode/choco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TraGicCode/choco/downloads","issues_url":"https://api.github.com/repos/TraGicCode/choco/issues{/number}","pulls_url":"https://api.github.com/repos/TraGicCode/choco/pulls{/number}","milestones_url":"https://api.github.com/repos/TraGicCode/choco/milestones{/number}","notifications_url":"https://api.github.com/repos/TraGicCode/choco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TraGicCode/choco/labels{/name}","releases_url":"https://api.github.com/repos/TraGicCode/choco/releases{/id}","deployments_url":"https://api.github.com/repos/TraGicCode/choco/deployments","created_at":"2018-10-02T12:30:40Z","updated_at":"2018-10-02T12:30:44Z","pushed_at":"2018-10-02T14:29:15Z","git_url":"git://github.com/TraGicCode/choco.git","ssh_url":"git@github.com:TraGicCode/choco.git","clone_url":"https://github.com/TraGicCode/choco.git","svn_url":"https://github.com/TraGicCode/choco","homepage":"https://chocolatey.org","size":21254,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chocolatey:master","ref":"master","sha":"bfe351b7d10c798014efe4bfbb100b171db25099","user":{"login":"chocolatey","id":811025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMTAyNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/811025?v=4","gravatar_id":"","url":"https://api.github.com/users/chocolatey","html_url":"https://github.com/chocolatey","followers_url":"https://api.github.com/users/chocolatey/followers","following_url":"https://api.github.com/users/chocolatey/following{/other_user}","gists_url":"https://api.github.com/users/chocolatey/gists{/gist_id}","starred_url":"https://api.github.com/users/chocolatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chocolatey/subscriptions","organizations_url":"https://api.github.com/users/chocolatey/orgs","repos_url":"https://api.github.com/users/chocolatey/repos","events_url":"https://api.github.com/users/chocolatey/events{/privacy}","received_events_url":"https://api.github.com/users/chocolatey/received_events","type":"Organization","site_admin":false},"repo":{"id":28647218,"node_id":"MDEwOlJlcG9zaXRvcnkyODY0NzIxOA==","name":"choco","full_name":"chocolatey/choco","private":false,"owner":{"login":"chocolatey","id":811025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMTAyNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/811025?v=4","gravatar_id":"","url":"https://api.github.com/users/chocolatey","html_url":"https://github.com/chocolatey","followers_url":"https://api.github.com/users/chocolatey/followers","following_url":"https://api.github.com/users/chocolatey/following{/other_user}","gists_url":"https://api.github.com/users/chocolatey/gists{/gist_id}","starred_url":"https://api.github.com/users/chocolatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chocolatey/subscriptions","organizations_url":"https://api.github.com/users/chocolatey/orgs","repos_url":"https://api.github.com/users/chocolatey/repos","events_url":"https://api.github.com/users/chocolatey/events{/privacy}","received_events_url":"https://api.github.com/users/chocolatey/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chocolatey/choco","description":"Chocolatey - the package manager for Windows","fork":false,"url":"https://api.github.com/repos/chocolatey/choco","forks_url":"https://api.github.com/repos/chocolatey/choco/forks","keys_url":"https://api.github.com/repos/chocolatey/choco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chocolatey/choco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chocolatey/choco/teams","hooks_url":"https://api.github.com/repos/chocolatey/choco/hooks","issue_events_url":"https://api.github.com/repos/chocolatey/choco/issues/events{/number}","events_url":"https://api.github.com/repos/chocolatey/choco/events","assignees_url":"https://api.github.com/repos/chocolatey/choco/assignees{/user}","branches_url":"https://api.github.com/repos/chocolatey/choco/branches{/branch}","tags_url":"https://api.github.com/repos/chocolatey/choco/tags","blobs_url":"https://api.github.com/repos/chocolatey/choco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chocolatey/choco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chocolatey/choco/git/refs{/sha}","trees_url":"https://api.github.com/repos/chocolatey/choco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chocolatey/choco/statuses/{sha}","languages_url":"https://api.github.com/repos/chocolatey/choco/languages","stargazers_url":"https://api.github.com/repos/chocolatey/choco/stargazers","contributors_url":"https://api.github.com/repos/chocolatey/choco/contributors","subscribers_url":"https://api.github.com/repos/chocolatey/choco/subscribers","subscription_url":"https://api.github.com/repos/chocolatey/choco/subscription","commits_url":"https://api.github.com/repos/chocolatey/choco/commits{/sha}","git_commits_url":"https://api.github.com/repos/chocolatey/choco/git/commits{/sha}","comments_url":"https://api.github.com/repos/chocolatey/choco/comments{/number}","issue_comment_url":"https://api.github.com/repos/chocolatey/choco/issues/comments{/number}","contents_url":"https://api.github.com/repos/chocolatey/choco/contents/{+path}","compare_url":"https://api.github.com/repos/chocolatey/choco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chocolatey/choco/merges","archive_url":"https://api.github.com/repos/chocolatey/choco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chocolatey/choco/downloads","issues_url":"https://api.github.com/repos/chocolatey/choco/issues{/number}","pulls_url":"https://api.github.com/repos/chocolatey/choco/pulls{/number}","milestones_url":"https://api.github.com/repos/chocolatey/choco/milestones{/number}","notifications_url":"https://api.github.com/repos/chocolatey/choco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chocolatey/choco/labels{/name}","releases_url":"https://api.github.com/repos/chocolatey/choco/releases{/id}","deployments_url":"https://api.github.com/repos/chocolatey/choco/deployments","created_at":"2014-12-30T22:12:11Z","updated_at":"2018-11-05T08:22:47Z","pushed_at":"2018-10-17T19:42:19Z","git_url":"git://github.com/chocolatey/choco.git","ssh_url":"git@github.com:chocolatey/choco.git","clone_url":"https://github.com/chocolatey/choco.git","svn_url":"https://github.com/chocolatey/choco","homepage":"https://chocolatey.org","size":21294,"stargazers_count":4708,"watchers_count":4708,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":487,"mirror_url":null,"archived":false,"open_issues_count":553,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":487,"open_issues":553,"watchers":4708,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chocolatey/choco/pulls/1653"},"html":{"href":"https://github.com/chocolatey/choco/pull/1653"},"issue":{"href":"https://api.github.com/repos/chocolatey/choco/issues/1653"},"comments":{"href":"https://api.github.com/repos/chocolatey/choco/issues/1653/comments"},"review_comments":{"href":"https://api.github.com/repos/chocolatey/choco/pulls/1653/comments"},"review_comment":{"href":"https://api.github.com/repos/chocolatey/choco/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chocolatey/choco/pulls/1653/commits"},"statuses":{"href":"https://api.github.com/repos/chocolatey/choco/statuses/6b7009eec96afbca253d75e2bc17ca380f120762"}},"author_association":"NONE"}}
{"actor":{"display_login":"TraGicCode"}}