{"action":"created","comment":{"url":"https://api.github.com/repos/conversationai/conversationai-models/pulls/comments/196520499","pull_request_review_id":130089194,"id":196520499,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjUyMDQ5OQ==","diff_hunk":"@@ -30,7 +30,7 @@ class TextPreprocessor():\n   may include fixing a max word length.\n   \"\"\"\n \n-  def __init__(self, embeddings_path: types.Path) -> None:\n+  def __init__(self, embeddings_path: str) -> None:","path":"experiments/tf_trainer/common/text_preprocessor.py","position":5,"original_position":5,"commit_id":"7bfe6f0160f6008243cd4ea16bb1dee9cf3818be","original_commit_id":"7bfe6f0160f6008243cd4ea16bb1dee9cf3818be","user":{"login":"nthain","id":30469739,"node_id":"MDQ6VXNlcjMwNDY5NzM5","avatar_url":"https://avatars2.githubusercontent.com/u/30469739?v=4","gravatar_id":"","url":"https://api.github.com/users/nthain","html_url":"https://github.com/nthain","followers_url":"https://api.github.com/users/nthain/followers","following_url":"https://api.github.com/users/nthain/following{/other_user}","gists_url":"https://api.github.com/users/nthain/gists{/gist_id}","starred_url":"https://api.github.com/users/nthain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nthain/subscriptions","organizations_url":"https://api.github.com/users/nthain/orgs","repos_url":"https://api.github.com/users/nthain/repos","events_url":"https://api.github.com/users/nthain/events{/privacy}","received_events_url":"https://api.github.com/users/nthain/received_events","type":"User","site_admin":false},"body":"Why did we decide to get rid of the Path type? (not that I mind)","created_at":"2018-06-19T17:50:53Z","updated_at":"2018-06-19T17:58:05Z","html_url":"https://github.com/conversationai/conversationai-models/pull/93#discussion_r196520499","pull_request_url":"https://api.github.com/repos/conversationai/conversationai-models/pulls/93","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/conversationai/conversationai-models/pulls/comments/196520499"},"html":{"href":"https://github.com/conversationai/conversationai-models/pull/93#discussion_r196520499"},"pull_request":{"href":"https://api.github.com/repos/conversationai/conversationai-models/pulls/93"}}},"pull_request":{"url":"https://api.github.com/repos/conversationai/conversationai-models/pulls/93","id":195624694,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NjI0Njk0","html_url":"https://github.com/conversationai/conversationai-models/pull/93","diff_url":"https://github.com/conversationai/conversationai-models/pull/93.diff","patch_url":"https://github.com/conversationai/conversationai-models/pull/93.patch","issue_url":"https://api.github.com/repos/conversationai/conversationai-models/issues/93","number":93,"state":"open","locked":false,"title":"Common code + Comet ml","user":{"login":"jjtan","id":1111780,"node_id":"MDQ6VXNlcjExMTE3ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/1111780?v=4","gravatar_id":"","url":"https://api.github.com/users/jjtan","html_url":"https://github.com/jjtan","followers_url":"https://api.github.com/users/jjtan/followers","following_url":"https://api.github.com/users/jjtan/following{/other_user}","gists_url":"https://api.github.com/users/jjtan/gists{/gist_id}","starred_url":"https://api.github.com/users/jjtan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjtan/subscriptions","organizations_url":"https://api.github.com/users/jjtan/orgs","repos_url":"https://api.github.com/users/jjtan/repos","events_url":"https://api.github.com/users/jjtan/events{/privacy}","received_events_url":"https://api.github.com/users/jjtan/received_events","type":"User","site_admin":false},"body":"Consolidate common code and introduce comet.ml\r\n\r\nI wonder if this is a rather opinionated way to structure the code. If it isn't immediately clear whats going on let me know.","created_at":"2018-06-18T19:28:41Z","updated_at":"2018-06-19T17:58:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1778ec673d90a1691b8b5277c5b6853d8f59eeee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/conversationai/conversationai-models/pulls/93/commits","review_comments_url":"https://api.github.com/repos/conversationai/conversationai-models/pulls/93/comments","review_comment_url":"https://api.github.com/repos/conversationai/conversationai-models/pulls/comments{/number}","comments_url":"https://api.github.com/repos/conversationai/conversationai-models/issues/93/comments","statuses_url":"https://api.github.com/repos/conversationai/conversationai-models/statuses/7bfe6f0160f6008243cd4ea16bb1dee9cf3818be","head":{"label":"conversationai:comet-ml","ref":"comet-ml","sha":"7bfe6f0160f6008243cd4ea16bb1dee9cf3818be","user":{"login":"conversationai","id":23317692,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzE3Njky","avatar_url":"https://avatars1.githubusercontent.com/u/23317692?v=4","gravatar_id":"","url":"https://api.github.com/users/conversationai","html_url":"https://github.com/conversationai","followers_url":"https://api.github.com/users/conversationai/followers","following_url":"https://api.github.com/users/conversationai/following{/other_user}","gists_url":"https://api.github.com/users/conversationai/gists{/gist_id}","starred_url":"https://api.github.com/users/conversationai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conversationai/subscriptions","organizations_url":"https://api.github.com/users/conversationai/orgs","repos_url":"https://api.github.com/users/conversationai/repos","events_url":"https://api.github.com/users/conversationai/events{/privacy}","received_events_url":"https://api.github.com/users/conversationai/received_events","type":"Organization","site_admin":false},"repo":{"id":123941779,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM5NDE3Nzk=","name":"conversationai-models","full_name":"conversationai/conversationai-models","owner":{"login":"conversationai","id":23317692,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzE3Njky","avatar_url":"https://avatars1.githubusercontent.com/u/23317692?v=4","gravatar_id":"","url":"https://api.github.com/users/conversationai","html_url":"https://github.com/conversationai","followers_url":"https://api.github.com/users/conversationai/followers","following_url":"https://api.github.com/users/conversationai/following{/other_user}","gists_url":"https://api.github.com/users/conversationai/gists{/gist_id}","starred_url":"https://api.github.com/users/conversationai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conversationai/subscriptions","organizations_url":"https://api.github.com/users/conversationai/orgs","repos_url":"https://api.github.com/users/conversationai/repos","events_url":"https://api.github.com/users/conversationai/events{/privacy}","received_events_url":"https://api.github.com/users/conversationai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conversationai/conversationai-models","description":"A repository to house model building experiments and tools that are part of the Conversation AI effort.","fork":false,"url":"https://api.github.com/repos/conversationai/conversationai-models","forks_url":"https://api.github.com/repos/conversationai/conversationai-models/forks","keys_url":"https://api.github.com/repos/conversationai/conversationai-models/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conversationai/conversationai-models/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conversationai/conversationai-models/teams","hooks_url":"https://api.github.com/repos/conversationai/conversationai-models/hooks","issue_events_url":"https://api.github.com/repos/conversationai/conversationai-models/issues/events{/number}","events_url":"https://api.github.com/repos/conversationai/conversationai-models/events","assignees_url":"https://api.github.com/repos/conversationai/conversationai-models/assignees{/user}","branches_url":"https://api.github.com/repos/conversationai/conversationai-models/branches{/branch}","tags_url":"https://api.github.com/repos/conversationai/conversationai-models/tags","blobs_url":"https://api.github.com/repos/conversationai/conversationai-models/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conversationai/conversationai-models/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conversationai/conversationai-models/git/refs{/sha}","trees_url":"https://api.github.com/repos/conversationai/conversationai-models/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conversationai/conversationai-models/statuses/{sha}","languages_url":"https://api.github.com/repos/conversationai/conversationai-models/languages","stargazers_url":"https://api.github.com/repos/conversationai/conversationai-models/stargazers","contributors_url":"https://api.github.com/repos/conversationai/conversationai-models/contributors","subscribers_url":"https://api.github.com/repos/conversationai/conversationai-models/subscribers","subscription_url":"https://api.github.com/repos/conversationai/conversationai-models/subscription","commits_url":"https://api.github.com/repos/conversationai/conversationai-models/commits{/sha}","git_commits_url":"https://api.github.com/repos/conversationai/conversationai-models/git/commits{/sha}","comments_url":"https://api.github.com/repos/conversationai/conversationai-models/comments{/number}","issue_comment_url":"https://api.github.com/repos/conversationai/conversationai-models/issues/comments{/number}","contents_url":"https://api.github.com/repos/conversationai/conversationai-models/contents/{+path}","compare_url":"https://api.github.com/repos/conversationai/conversationai-models/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conversationai/conversationai-models/merges","archive_url":"https://api.github.com/repos/conversationai/conversationai-models/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conversationai/conversationai-models/downloads","issues_url":"https://api.github.com/repos/conversationai/conversationai-models/issues{/number}","pulls_url":"https://api.github.com/repos/conversationai/conversationai-models/pulls{/number}","milestones_url":"https://api.github.com/repos/conversationai/conversationai-models/milestones{/number}","notifications_url":"https://api.github.com/repos/conversationai/conversationai-models/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conversationai/conversationai-models/labels{/name}","releases_url":"https://api.github.com/repos/conversationai/conversationai-models/releases{/id}","deployments_url":"https://api.github.com/repos/conversationai/conversationai-models/deployments","created_at":"2018-03-05T15:46:21Z","updated_at":"2018-06-18T18:11:38Z","pushed_at":"2018-06-18T19:33:20Z","git_url":"git://github.com/conversationai/conversationai-models.git","ssh_url":"git@github.com:conversationai/conversationai-models.git","clone_url":"https://github.com/conversationai/conversationai-models.git","svn_url":"https://github.com/conversationai/conversationai-models","homepage":null,"size":3030,"stargazers_count":13,"watchers_count":13,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":21,"watchers":13,"default_branch":"master"}},"base":{"label":"conversationai:master","ref":"master","sha":"5017655e6e7ed379cd66ebfe682b85a4b2813a07","user":{"login":"conversationai","id":23317692,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzE3Njky","avatar_url":"https://avatars1.githubusercontent.com/u/23317692?v=4","gravatar_id":"","url":"https://api.github.com/users/conversationai","html_url":"https://github.com/conversationai","followers_url":"https://api.github.com/users/conversationai/followers","following_url":"https://api.github.com/users/conversationai/following{/other_user}","gists_url":"https://api.github.com/users/conversationai/gists{/gist_id}","starred_url":"https://api.github.com/users/conversationai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conversationai/subscriptions","organizations_url":"https://api.github.com/users/conversationai/orgs","repos_url":"https://api.github.com/users/conversationai/repos","events_url":"https://api.github.com/users/conversationai/events{/privacy}","received_events_url":"https://api.github.com/users/conversationai/received_events","type":"Organization","site_admin":false},"repo":{"id":123941779,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM5NDE3Nzk=","name":"conversationai-models","full_name":"conversationai/conversationai-models","owner":{"login":"conversationai","id":23317692,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzE3Njky","avatar_url":"https://avatars1.githubusercontent.com/u/23317692?v=4","gravatar_id":"","url":"https://api.github.com/users/conversationai","html_url":"https://github.com/conversationai","followers_url":"https://api.github.com/users/conversationai/followers","following_url":"https://api.github.com/users/conversationai/following{/other_user}","gists_url":"https://api.github.com/users/conversationai/gists{/gist_id}","starred_url":"https://api.github.com/users/conversationai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conversationai/subscriptions","organizations_url":"https://api.github.com/users/conversationai/orgs","repos_url":"https://api.github.com/users/conversationai/repos","events_url":"https://api.github.com/users/conversationai/events{/privacy}","received_events_url":"https://api.github.com/users/conversationai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conversationai/conversationai-models","description":"A repository to house model building experiments and tools that are part of the Conversation AI effort.","fork":false,"url":"https://api.github.com/repos/conversationai/conversationai-models","forks_url":"https://api.github.com/repos/conversationai/conversationai-models/forks","keys_url":"https://api.github.com/repos/conversationai/conversationai-models/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conversationai/conversationai-models/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conversationai/conversationai-models/teams","hooks_url":"https://api.github.com/repos/conversationai/conversationai-models/hooks","issue_events_url":"https://api.github.com/repos/conversationai/conversationai-models/issues/events{/number}","events_url":"https://api.github.com/repos/conversationai/conversationai-models/events","assignees_url":"https://api.github.com/repos/conversationai/conversationai-models/assignees{/user}","branches_url":"https://api.github.com/repos/conversationai/conversationai-models/branches{/branch}","tags_url":"https://api.github.com/repos/conversationai/conversationai-models/tags","blobs_url":"https://api.github.com/repos/conversationai/conversationai-models/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conversationai/conversationai-models/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conversationai/conversationai-models/git/refs{/sha}","trees_url":"https://api.github.com/repos/conversationai/conversationai-models/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conversationai/conversationai-models/statuses/{sha}","languages_url":"https://api.github.com/repos/conversationai/conversationai-models/languages","stargazers_url":"https://api.github.com/repos/conversationai/conversationai-models/stargazers","contributors_url":"https://api.github.com/repos/conversationai/conversationai-models/contributors","subscribers_url":"https://api.github.com/repos/conversationai/conversationai-models/subscribers","subscription_url":"https://api.github.com/repos/conversationai/conversationai-models/subscription","commits_url":"https://api.github.com/repos/conversationai/conversationai-models/commits{/sha}","git_commits_url":"https://api.github.com/repos/conversationai/conversationai-models/git/commits{/sha}","comments_url":"https://api.github.com/repos/conversationai/conversationai-models/comments{/number}","issue_comment_url":"https://api.github.com/repos/conversationai/conversationai-models/issues/comments{/number}","contents_url":"https://api.github.com/repos/conversationai/conversationai-models/contents/{+path}","compare_url":"https://api.github.com/repos/conversationai/conversationai-models/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conversationai/conversationai-models/merges","archive_url":"https://api.github.com/repos/conversationai/conversationai-models/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conversationai/conversationai-models/downloads","issues_url":"https://api.github.com/repos/conversationai/conversationai-models/issues{/number}","pulls_url":"https://api.github.com/repos/conversationai/conversationai-models/pulls{/number}","milestones_url":"https://api.github.com/repos/conversationai/conversationai-models/milestones{/number}","notifications_url":"https://api.github.com/repos/conversationai/conversationai-models/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conversationai/conversationai-models/labels{/name}","releases_url":"https://api.github.com/repos/conversationai/conversationai-models/releases{/id}","deployments_url":"https://api.github.com/repos/conversationai/conversationai-models/deployments","created_at":"2018-03-05T15:46:21Z","updated_at":"2018-06-18T18:11:38Z","pushed_at":"2018-06-18T19:33:20Z","git_url":"git://github.com/conversationai/conversationai-models.git","ssh_url":"git@github.com:conversationai/conversationai-models.git","clone_url":"https://github.com/conversationai/conversationai-models.git","svn_url":"https://github.com/conversationai/conversationai-models","homepage":null,"size":3030,"stargazers_count":13,"watchers_count":13,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":21,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/conversationai/conversationai-models/pulls/93"},"html":{"href":"https://github.com/conversationai/conversationai-models/pull/93"},"issue":{"href":"https://api.github.com/repos/conversationai/conversationai-models/issues/93"},"comments":{"href":"https://api.github.com/repos/conversationai/conversationai-models/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/conversationai/conversationai-models/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/conversationai/conversationai-models/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/conversationai/conversationai-models/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/conversationai/conversationai-models/statuses/7bfe6f0160f6008243cd4ea16bb1dee9cf3818be"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"nthain"}}