{"action":"created","comment":{"url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/comments/204993108","pull_request_review_id":140173388,"id":204993108,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDk5MzEwOA==","diff_hunk":"@@ -71,3 +76,82 @@ func (h *harness) createService(ctx context.Context) {\n \t\th.config,\n \t)\n }\n+\n+func nonLeaderPublicKey() primitives.Ed25519Pkey {\n+\treturn []byte{0x99}\n+}\n+\n+func (h *harness) expectHandlerRegistrations() {\n+\th.gossip.Reset().When(\"RegisterBenchmarkConsensusHandler\", mock.Any).Return().Times(1)\n+\th.blockStorage.Reset().When(\"RegisterConsensusBlocksHandler\", mock.Any).Return().Times(1)\n+}\n+\n+func (h *harness) verifyHandlerRegistrations(t *testing.T) {\n+\tok, err := h.gossip.Verify()\n+\tif !ok {\n+\t\tt.Fatal(\"Did not register with Gossip:\", err)\n+\t}\n+\tok, err = h.blockStorage.Verify()\n+\tif !ok {\n+\t\tt.Fatal(\"Did not register with BlockStorage:\", err)\n+\t}\n+}\n+\n+func (h *harness) expectBlockCreation() {\n+\th.consensusContext.Reset().When(\"RequestNewTransactionsBlock\", mock.Any).Return(nil, nil).AtLeast(1)","path":"services/consensusalgo/benchmarkconsensus/test/harness.go","position":42,"original_position":42,"commit_id":"6190a049e9172c35748e52f84f139f23dc2683aa","original_commit_id":"6190a049e9172c35748e52f84f139f23dc2683aa","user":{"login":"electricmonk","id":912517,"node_id":"MDQ6VXNlcjkxMjUxNw==","avatar_url":"https://avatars1.githubusercontent.com/u/912517?v=4","gravatar_id":"","url":"https://api.github.com/users/electricmonk","html_url":"https://github.com/electricmonk","followers_url":"https://api.github.com/users/electricmonk/followers","following_url":"https://api.github.com/users/electricmonk/following{/other_user}","gists_url":"https://api.github.com/users/electricmonk/gists{/gist_id}","starred_url":"https://api.github.com/users/electricmonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electricmonk/subscriptions","organizations_url":"https://api.github.com/users/electricmonk/orgs","repos_url":"https://api.github.com/users/electricmonk/repos","events_url":"https://api.github.com/users/electricmonk/events{/privacy}","received_events_url":"https://api.github.com/users/electricmonk/received_events","type":"User","site_admin":false},"body":"the name of the function doesn't reflect what it does. It doesn't actually expect that a block was created, right? it expects the algo to ask for a new transaction block... I'd name it `expectRequestNewTransactionBlock()`.\r\n\r\nin addition, maybe return the `MockFunction` so that I could do:\r\n```golang\r\nh.expectRequestNewTransactionBlock().AtLeast(1)\r\nh.expectRequestNewTransactionBlock().Times(0)\r\n\r\n// etc\r\n```","created_at":"2018-07-25T06:26:07Z","updated_at":"2018-07-25T06:46:18Z","html_url":"https://github.com/orbs-network/orbs-network-go/pull/31#discussion_r204993108","pull_request_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/31","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/comments/204993108"},"html":{"href":"https://github.com/orbs-network/orbs-network-go/pull/31#discussion_r204993108"},"pull_request":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/31","id":203640576,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNjQwNTc2","html_url":"https://github.com/orbs-network/orbs-network-go/pull/31","diff_url":"https://github.com/orbs-network/orbs-network-go/pull/31.diff","patch_url":"https://github.com/orbs-network/orbs-network-go/pull/31.patch","issue_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/31","number":31,"state":"open","locked":false,"title":"Feature/talkol/benchmark consensus continued","user":{"login":"talkol","id":6762255,"node_id":"MDQ6VXNlcjY3NjIyNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6762255?v=4","gravatar_id":"","url":"https://api.github.com/users/talkol","html_url":"https://github.com/talkol","followers_url":"https://api.github.com/users/talkol/followers","following_url":"https://api.github.com/users/talkol/following{/other_user}","gists_url":"https://api.github.com/users/talkol/gists{/gist_id}","starred_url":"https://api.github.com/users/talkol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talkol/subscriptions","organizations_url":"https://api.github.com/users/talkol/orgs","repos_url":"https://api.github.com/users/talkol/repos","events_url":"https://api.github.com/users/talkol/events{/privacy}","received_events_url":"https://api.github.com/users/talkol/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-24T20:09:52Z","updated_at":"2018-07-25T06:46:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ac0c7239a32b49379a5fb380b92fea6d07c7691","assignee":null,"assignees":[],"requested_reviewers":[{"login":"erankirsh","id":13403972,"node_id":"MDQ6VXNlcjEzNDAzOTcy","avatar_url":"https://avatars0.githubusercontent.com/u/13403972?v=4","gravatar_id":"","url":"https://api.github.com/users/erankirsh","html_url":"https://github.com/erankirsh","followers_url":"https://api.github.com/users/erankirsh/followers","following_url":"https://api.github.com/users/erankirsh/following{/other_user}","gists_url":"https://api.github.com/users/erankirsh/gists{/gist_id}","starred_url":"https://api.github.com/users/erankirsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erankirsh/subscriptions","organizations_url":"https://api.github.com/users/erankirsh/orgs","repos_url":"https://api.github.com/users/erankirsh/repos","events_url":"https://api.github.com/users/erankirsh/events{/privacy}","received_events_url":"https://api.github.com/users/erankirsh/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/31/commits","review_comments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/31/comments","review_comment_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/31/comments","statuses_url":"https://api.github.com/repos/orbs-network/orbs-network-go/statuses/6190a049e9172c35748e52f84f139f23dc2683aa","head":{"label":"orbs-network:feature/talkol/benchmark-consensus-continued","ref":"feature/talkol/benchmark-consensus-continued","sha":"6190a049e9172c35748e52f84f139f23dc2683aa","user":{"login":"orbs-network","id":33665977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjY1OTc3","avatar_url":"https://avatars3.githubusercontent.com/u/33665977?v=4","gravatar_id":"","url":"https://api.github.com/users/orbs-network","html_url":"https://github.com/orbs-network","followers_url":"https://api.github.com/users/orbs-network/followers","following_url":"https://api.github.com/users/orbs-network/following{/other_user}","gists_url":"https://api.github.com/users/orbs-network/gists{/gist_id}","starred_url":"https://api.github.com/users/orbs-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbs-network/subscriptions","organizations_url":"https://api.github.com/users/orbs-network/orgs","repos_url":"https://api.github.com/users/orbs-network/repos","events_url":"https://api.github.com/users/orbs-network/events{/privacy}","received_events_url":"https://api.github.com/users/orbs-network/received_events","type":"Organization","site_admin":false},"repo":{"id":138470435,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg0NzA0MzU=","name":"orbs-network-go","full_name":"orbs-network/orbs-network-go","owner":{"login":"orbs-network","id":33665977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjY1OTc3","avatar_url":"https://avatars3.githubusercontent.com/u/33665977?v=4","gravatar_id":"","url":"https://api.github.com/users/orbs-network","html_url":"https://github.com/orbs-network","followers_url":"https://api.github.com/users/orbs-network/followers","following_url":"https://api.github.com/users/orbs-network/following{/other_user}","gists_url":"https://api.github.com/users/orbs-network/gists{/gist_id}","starred_url":"https://api.github.com/users/orbs-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbs-network/subscriptions","organizations_url":"https://api.github.com/users/orbs-network/orgs","repos_url":"https://api.github.com/users/orbs-network/repos","events_url":"https://api.github.com/users/orbs-network/events{/privacy}","received_events_url":"https://api.github.com/users/orbs-network/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/orbs-network/orbs-network-go","description":"Orbs platform reference implementation in Go","fork":false,"url":"https://api.github.com/repos/orbs-network/orbs-network-go","forks_url":"https://api.github.com/repos/orbs-network/orbs-network-go/forks","keys_url":"https://api.github.com/repos/orbs-network/orbs-network-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orbs-network/orbs-network-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orbs-network/orbs-network-go/teams","hooks_url":"https://api.github.com/repos/orbs-network/orbs-network-go/hooks","issue_events_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/events{/number}","events_url":"https://api.github.com/repos/orbs-network/orbs-network-go/events","assignees_url":"https://api.github.com/repos/orbs-network/orbs-network-go/assignees{/user}","branches_url":"https://api.github.com/repos/orbs-network/orbs-network-go/branches{/branch}","tags_url":"https://api.github.com/repos/orbs-network/orbs-network-go/tags","blobs_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orbs-network/orbs-network-go/statuses/{sha}","languages_url":"https://api.github.com/repos/orbs-network/orbs-network-go/languages","stargazers_url":"https://api.github.com/repos/orbs-network/orbs-network-go/stargazers","contributors_url":"https://api.github.com/repos/orbs-network/orbs-network-go/contributors","subscribers_url":"https://api.github.com/repos/orbs-network/orbs-network-go/subscribers","subscription_url":"https://api.github.com/repos/orbs-network/orbs-network-go/subscription","commits_url":"https://api.github.com/repos/orbs-network/orbs-network-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/orbs-network/orbs-network-go/contents/{+path}","compare_url":"https://api.github.com/repos/orbs-network/orbs-network-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orbs-network/orbs-network-go/merges","archive_url":"https://api.github.com/repos/orbs-network/orbs-network-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orbs-network/orbs-network-go/downloads","issues_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues{/number}","pulls_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls{/number}","milestones_url":"https://api.github.com/repos/orbs-network/orbs-network-go/milestones{/number}","notifications_url":"https://api.github.com/repos/orbs-network/orbs-network-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orbs-network/orbs-network-go/labels{/name}","releases_url":"https://api.github.com/repos/orbs-network/orbs-network-go/releases{/id}","deployments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/deployments","created_at":"2018-06-24T09:47:23Z","updated_at":"2018-07-24T08:33:05Z","pushed_at":"2018-07-25T06:44:43Z","git_url":"git://github.com/orbs-network/orbs-network-go.git","ssh_url":"git@github.com:orbs-network/orbs-network-go.git","clone_url":"https://github.com/orbs-network/orbs-network-go.git","svn_url":"https://github.com/orbs-network/orbs-network-go","homepage":"","size":776,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":8,"watchers":2,"default_branch":"master"}},"base":{"label":"orbs-network:master","ref":"master","sha":"271aa1b27c88cb67530800dec21ee12968ebd259","user":{"login":"orbs-network","id":33665977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjY1OTc3","avatar_url":"https://avatars3.githubusercontent.com/u/33665977?v=4","gravatar_id":"","url":"https://api.github.com/users/orbs-network","html_url":"https://github.com/orbs-network","followers_url":"https://api.github.com/users/orbs-network/followers","following_url":"https://api.github.com/users/orbs-network/following{/other_user}","gists_url":"https://api.github.com/users/orbs-network/gists{/gist_id}","starred_url":"https://api.github.com/users/orbs-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbs-network/subscriptions","organizations_url":"https://api.github.com/users/orbs-network/orgs","repos_url":"https://api.github.com/users/orbs-network/repos","events_url":"https://api.github.com/users/orbs-network/events{/privacy}","received_events_url":"https://api.github.com/users/orbs-network/received_events","type":"Organization","site_admin":false},"repo":{"id":138470435,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg0NzA0MzU=","name":"orbs-network-go","full_name":"orbs-network/orbs-network-go","owner":{"login":"orbs-network","id":33665977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjY1OTc3","avatar_url":"https://avatars3.githubusercontent.com/u/33665977?v=4","gravatar_id":"","url":"https://api.github.com/users/orbs-network","html_url":"https://github.com/orbs-network","followers_url":"https://api.github.com/users/orbs-network/followers","following_url":"https://api.github.com/users/orbs-network/following{/other_user}","gists_url":"https://api.github.com/users/orbs-network/gists{/gist_id}","starred_url":"https://api.github.com/users/orbs-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbs-network/subscriptions","organizations_url":"https://api.github.com/users/orbs-network/orgs","repos_url":"https://api.github.com/users/orbs-network/repos","events_url":"https://api.github.com/users/orbs-network/events{/privacy}","received_events_url":"https://api.github.com/users/orbs-network/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/orbs-network/orbs-network-go","description":"Orbs platform reference implementation in Go","fork":false,"url":"https://api.github.com/repos/orbs-network/orbs-network-go","forks_url":"https://api.github.com/repos/orbs-network/orbs-network-go/forks","keys_url":"https://api.github.com/repos/orbs-network/orbs-network-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/orbs-network/orbs-network-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/orbs-network/orbs-network-go/teams","hooks_url":"https://api.github.com/repos/orbs-network/orbs-network-go/hooks","issue_events_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/events{/number}","events_url":"https://api.github.com/repos/orbs-network/orbs-network-go/events","assignees_url":"https://api.github.com/repos/orbs-network/orbs-network-go/assignees{/user}","branches_url":"https://api.github.com/repos/orbs-network/orbs-network-go/branches{/branch}","tags_url":"https://api.github.com/repos/orbs-network/orbs-network-go/tags","blobs_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/orbs-network/orbs-network-go/statuses/{sha}","languages_url":"https://api.github.com/repos/orbs-network/orbs-network-go/languages","stargazers_url":"https://api.github.com/repos/orbs-network/orbs-network-go/stargazers","contributors_url":"https://api.github.com/repos/orbs-network/orbs-network-go/contributors","subscribers_url":"https://api.github.com/repos/orbs-network/orbs-network-go/subscribers","subscription_url":"https://api.github.com/repos/orbs-network/orbs-network-go/subscription","commits_url":"https://api.github.com/repos/orbs-network/orbs-network-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/orbs-network/orbs-network-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/orbs-network/orbs-network-go/contents/{+path}","compare_url":"https://api.github.com/repos/orbs-network/orbs-network-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/orbs-network/orbs-network-go/merges","archive_url":"https://api.github.com/repos/orbs-network/orbs-network-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/orbs-network/orbs-network-go/downloads","issues_url":"https://api.github.com/repos/orbs-network/orbs-network-go/issues{/number}","pulls_url":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls{/number}","milestones_url":"https://api.github.com/repos/orbs-network/orbs-network-go/milestones{/number}","notifications_url":"https://api.github.com/repos/orbs-network/orbs-network-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/orbs-network/orbs-network-go/labels{/name}","releases_url":"https://api.github.com/repos/orbs-network/orbs-network-go/releases{/id}","deployments_url":"https://api.github.com/repos/orbs-network/orbs-network-go/deployments","created_at":"2018-06-24T09:47:23Z","updated_at":"2018-07-24T08:33:05Z","pushed_at":"2018-07-25T06:44:43Z","git_url":"git://github.com/orbs-network/orbs-network-go.git","ssh_url":"git@github.com:orbs-network/orbs-network-go.git","clone_url":"https://github.com/orbs-network/orbs-network-go.git","svn_url":"https://github.com/orbs-network/orbs-network-go","homepage":"","size":776,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":8,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/31"},"html":{"href":"https://github.com/orbs-network/orbs-network-go/pull/31"},"issue":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/31"},"comments":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/orbs-network/orbs-network-go/statuses/6190a049e9172c35748e52f84f139f23dc2683aa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"electricmonk"}}