{"action":"created","comment":{"url":"https://api.github.com/repos/openucx/ucx/pulls/comments/169980782","pull_request_review_id":98591438,"id":169980782,"diff_hunk":"@@ -448,10 +448,13 @@ UCS_TEST_P(test_dc_flow_control, soft_request)\n     EXPECT_EQ(get_fc_ptr(m_e1)->fc_wnd, s_thresh - 1);\n }\n \n-/* Check that flush returns UCS_OK even if there is an outgoing grant request */\n+/* Check that:\n+ * 1) flush returns UCS_OK even if there is an outgoing grant request\n+ * 2) No crash when grant for destroyed ep arrives */","path":"test/gtest/uct/ib/test_dc.cc","position":7,"original_position":7,"commit_id":"bbb3ce7084e148c6ca68a06b2fef03a6f764038e","original_commit_id":"bbb3ce7084e148c6ca68a06b2fef03a6f764038e","user":{"login":"yosefe","id":2255631,"avatar_url":"https://avatars0.githubusercontent.com/u/2255631?v=4","gravatar_id":"","url":"https://api.github.com/users/yosefe","html_url":"https://github.com/yosefe","followers_url":"https://api.github.com/users/yosefe/followers","following_url":"https://api.github.com/users/yosefe/following{/other_user}","gists_url":"https://api.github.com/users/yosefe/gists{/gist_id}","starred_url":"https://api.github.com/users/yosefe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yosefe/subscriptions","organizations_url":"https://api.github.com/users/yosefe/orgs","repos_url":"https://api.github.com/users/yosefe/repos","events_url":"https://api.github.com/users/yosefe/events{/privacy}","received_events_url":"https://api.github.com/users/yosefe/received_events","type":"User","site_admin":false},"body":"how is this checked?","created_at":"2018-02-22T14:50:21Z","updated_at":"2018-02-22T14:51:23Z","html_url":"https://github.com/openucx/ucx/pull/2335#discussion_r169980782","pull_request_url":"https://api.github.com/repos/openucx/ucx/pulls/2335","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments/169980782"},"html":{"href":"https://github.com/openucx/ucx/pull/2335#discussion_r169980782"},"pull_request":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2335"}}},"pull_request":{"url":"https://api.github.com/repos/openucx/ucx/pulls/2335","id":170441632,"html_url":"https://github.com/openucx/ucx/pull/2335","diff_url":"https://github.com/openucx/ucx/pull/2335.diff","patch_url":"https://github.com/openucx/ucx/pull/2335.patch","issue_url":"https://api.github.com/repos/openucx/ucx/issues/2335","number":2335,"state":"open","locked":false,"title":"GTEST/UCT/DC: Fix DC flow control test","user":{"login":"brminich","id":14221180,"avatar_url":"https://avatars1.githubusercontent.com/u/14221180?v=4","gravatar_id":"","url":"https://api.github.com/users/brminich","html_url":"https://github.com/brminich","followers_url":"https://api.github.com/users/brminich/followers","following_url":"https://api.github.com/users/brminich/following{/other_user}","gists_url":"https://api.github.com/users/brminich/gists{/gist_id}","starred_url":"https://api.github.com/users/brminich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brminich/subscriptions","organizations_url":"https://api.github.com/users/brminich/orgs","repos_url":"https://api.github.com/users/brminich/repos","events_url":"https://api.github.com/users/brminich/events{/privacy}","received_events_url":"https://api.github.com/users/brminich/received_events","type":"User","site_admin":false},"body":"- Need to make sure that ep_flush returns OK, before to destroy ep\r\n- Removed misleading comment from uct_dc_ep_flush\r\n\r\nfixes #2263","created_at":"2018-02-21T11:22:51Z","updated_at":"2018-02-22T14:51:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81189b0a86e3a4a9dfe1ce5df334eb04b6e52684","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openucx/ucx/pulls/2335/commits","review_comments_url":"https://api.github.com/repos/openucx/ucx/pulls/2335/comments","review_comment_url":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openucx/ucx/issues/2335/comments","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/bbb3ce7084e148c6ca68a06b2fef03a6f764038e","head":{"label":"brminich:topic/uct_dc_fc_fix","ref":"topic/uct_dc_fc_fix","sha":"bbb3ce7084e148c6ca68a06b2fef03a6f764038e","user":{"login":"brminich","id":14221180,"avatar_url":"https://avatars1.githubusercontent.com/u/14221180?v=4","gravatar_id":"","url":"https://api.github.com/users/brminich","html_url":"https://github.com/brminich","followers_url":"https://api.github.com/users/brminich/followers","following_url":"https://api.github.com/users/brminich/following{/other_user}","gists_url":"https://api.github.com/users/brminich/gists{/gist_id}","starred_url":"https://api.github.com/users/brminich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brminich/subscriptions","organizations_url":"https://api.github.com/users/brminich/orgs","repos_url":"https://api.github.com/users/brminich/repos","events_url":"https://api.github.com/users/brminich/events{/privacy}","received_events_url":"https://api.github.com/users/brminich/received_events","type":"User","site_admin":false},"repo":{"id":51351462,"name":"ucx","full_name":"brminich/ucx","owner":{"login":"brminich","id":14221180,"avatar_url":"https://avatars1.githubusercontent.com/u/14221180?v=4","gravatar_id":"","url":"https://api.github.com/users/brminich","html_url":"https://github.com/brminich","followers_url":"https://api.github.com/users/brminich/followers","following_url":"https://api.github.com/users/brminich/following{/other_user}","gists_url":"https://api.github.com/users/brminich/gists{/gist_id}","starred_url":"https://api.github.com/users/brminich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brminich/subscriptions","organizations_url":"https://api.github.com/users/brminich/orgs","repos_url":"https://api.github.com/users/brminich/repos","events_url":"https://api.github.com/users/brminich/events{/privacy}","received_events_url":"https://api.github.com/users/brminich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brminich/ucx","description":"Unified Communication X  (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":true,"url":"https://api.github.com/repos/brminich/ucx","forks_url":"https://api.github.com/repos/brminich/ucx/forks","keys_url":"https://api.github.com/repos/brminich/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brminich/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brminich/ucx/teams","hooks_url":"https://api.github.com/repos/brminich/ucx/hooks","issue_events_url":"https://api.github.com/repos/brminich/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/brminich/ucx/events","assignees_url":"https://api.github.com/repos/brminich/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/brminich/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/brminich/ucx/tags","blobs_url":"https://api.github.com/repos/brminich/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brminich/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brminich/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/brminich/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brminich/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/brminich/ucx/languages","stargazers_url":"https://api.github.com/repos/brminich/ucx/stargazers","contributors_url":"https://api.github.com/repos/brminich/ucx/contributors","subscribers_url":"https://api.github.com/repos/brminich/ucx/subscribers","subscription_url":"https://api.github.com/repos/brminich/ucx/subscription","commits_url":"https://api.github.com/repos/brminich/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/brminich/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/brminich/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/brminich/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/brminich/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/brminich/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brminich/ucx/merges","archive_url":"https://api.github.com/repos/brminich/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brminich/ucx/downloads","issues_url":"https://api.github.com/repos/brminich/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/brminich/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/brminich/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/brminich/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brminich/ucx/labels{/name}","releases_url":"https://api.github.com/repos/brminich/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/brminich/ucx/deployments","created_at":"2016-02-09T06:56:33Z","updated_at":"2016-02-09T06:56:35Z","pushed_at":"2018-02-21T11:21:10Z","git_url":"git://github.com/brminich/ucx.git","ssh_url":"git@github.com:brminich/ucx.git","clone_url":"https://github.com/brminich/ucx.git","svn_url":"https://github.com/brminich/ucx","homepage":" http://www.openucx.org","size":11704,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openucx:master","ref":"master","sha":"ed55f8a6a05dd8c0b0c8df20ed8582cf626c5758","user":{"login":"openucx","id":13118737,"avatar_url":"https://avatars2.githubusercontent.com/u/13118737?v=4","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"repo":{"id":25379390,"name":"ucx","full_name":"openucx/ucx","owner":{"login":"openucx","id":13118737,"avatar_url":"https://avatars2.githubusercontent.com/u/13118737?v=4","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openucx/ucx","description":"Unified Communication X  (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":false,"url":"https://api.github.com/repos/openucx/ucx","forks_url":"https://api.github.com/repos/openucx/ucx/forks","keys_url":"https://api.github.com/repos/openucx/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openucx/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openucx/ucx/teams","hooks_url":"https://api.github.com/repos/openucx/ucx/hooks","issue_events_url":"https://api.github.com/repos/openucx/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/openucx/ucx/events","assignees_url":"https://api.github.com/repos/openucx/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/openucx/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/openucx/ucx/tags","blobs_url":"https://api.github.com/repos/openucx/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openucx/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openucx/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/openucx/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/openucx/ucx/languages","stargazers_url":"https://api.github.com/repos/openucx/ucx/stargazers","contributors_url":"https://api.github.com/repos/openucx/ucx/contributors","subscribers_url":"https://api.github.com/repos/openucx/ucx/subscribers","subscription_url":"https://api.github.com/repos/openucx/ucx/subscription","commits_url":"https://api.github.com/repos/openucx/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/openucx/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/openucx/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/openucx/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/openucx/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/openucx/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openucx/ucx/merges","archive_url":"https://api.github.com/repos/openucx/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openucx/ucx/downloads","issues_url":"https://api.github.com/repos/openucx/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/openucx/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/openucx/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/openucx/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openucx/ucx/labels{/name}","releases_url":"https://api.github.com/repos/openucx/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/openucx/ucx/deployments","created_at":"2014-10-17T22:17:24Z","updated_at":"2018-02-22T13:00:45Z","pushed_at":"2018-02-22T13:14:18Z","git_url":"git://github.com/openucx/ucx.git","ssh_url":"git@github.com:openucx/ucx.git","clone_url":"https://github.com/openucx/ucx.git","svn_url":"https://github.com/openucx/ucx","homepage":"http://www.openucx.org","size":11760,"stargazers_count":100,"watchers_count":100,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":125,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":65,"open_issues":125,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2335"},"html":{"href":"https://github.com/openucx/ucx/pull/2335"},"issue":{"href":"https://api.github.com/repos/openucx/ucx/issues/2335"},"comments":{"href":"https://api.github.com/repos/openucx/ucx/issues/2335/comments"},"review_comments":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2335/comments"},"review_comment":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2335/commits"},"statuses":{"href":"https://api.github.com/repos/openucx/ucx/statuses/bbb3ce7084e148c6ca68a06b2fef03a6f764038e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yosefe"}}