{"action":"created","issue":{"url":"https://api.github.com/repos/blushiemagic/tModLoader/issues/332","repository_url":"https://api.github.com/repos/blushiemagic/tModLoader","labels_url":"https://api.github.com/repos/blushiemagic/tModLoader/issues/332/labels{/name}","comments_url":"https://api.github.com/repos/blushiemagic/tModLoader/issues/332/comments","events_url":"https://api.github.com/repos/blushiemagic/tModLoader/issues/332/events","html_url":"https://github.com/blushiemagic/tModLoader/pull/332","id":316783486,"number":332,"title":"Offset buff tooltip properly, fixes #318","user":{"login":"Leemyy","id":12375682,"avatar_url":"https://avatars3.githubusercontent.com/u/12375682?v=4","gravatar_id":"","url":"https://api.github.com/users/Leemyy","html_url":"https://github.com/Leemyy","followers_url":"https://api.github.com/users/Leemyy/followers","following_url":"https://api.github.com/users/Leemyy/following{/other_user}","gists_url":"https://api.github.com/users/Leemyy/gists{/gist_id}","starred_url":"https://api.github.com/users/Leemyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leemyy/subscriptions","organizations_url":"https://api.github.com/users/Leemyy/orgs","repos_url":"https://api.github.com/users/Leemyy/repos","events_url":"https://api.github.com/users/Leemyy/events{/privacy}","received_events_url":"https://api.github.com/users/Leemyy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-23T12:06:53Z","updated_at":"2018-04-23T21:50:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/blushiemagic/tModLoader/pulls/332","html_url":"https://github.com/blushiemagic/tModLoader/pull/332","diff_url":"https://github.com/blushiemagic/tModLoader/pull/332.diff","patch_url":"https://github.com/blushiemagic/tModLoader/pull/332.patch"},"body":"### Description of the Change\r\n\r\nThe buff tooltip needs to be offset by the height of the buff name, not by its own height.\r\nThis is technically a vanilla bug, but vanilla does not have multiline buff tooltips, so it never has a visual impact.\r\n\r\n### Alternate designs\r\n\r\nThe buff name could be passed, instead of just its height, but this would just result in more code without any real benefit. It would also mean that the dimensions of the buff name will have to be calculated twice.\r\n\r\n### Benefits\r\n\r\nMultiline buff tooltips will get drawn properly. (See linked Issue for details)\r\n\r\n### Possible drawbacks\r\n\r\nNone, as far as I can tell.\r\n\r\n### Applicable Issues\r\n\r\n#318 \r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/blushiemagic/tModLoader/issues/comments/383734606","html_url":"https://github.com/blushiemagic/tModLoader/pull/332#issuecomment-383734606","issue_url":"https://api.github.com/repos/blushiemagic/tModLoader/issues/332","id":383734606,"user":{"login":"Jofairden","id":4968151,"avatar_url":"https://avatars3.githubusercontent.com/u/4968151?v=4","gravatar_id":"","url":"https://api.github.com/users/Jofairden","html_url":"https://github.com/Jofairden","followers_url":"https://api.github.com/users/Jofairden/followers","following_url":"https://api.github.com/users/Jofairden/following{/other_user}","gists_url":"https://api.github.com/users/Jofairden/gists{/gist_id}","starred_url":"https://api.github.com/users/Jofairden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jofairden/subscriptions","organizations_url":"https://api.github.com/users/Jofairden/orgs","repos_url":"https://api.github.com/users/Jofairden/repos","events_url":"https://api.github.com/users/Jofairden/events{/privacy}","received_events_url":"https://api.github.com/users/Jofairden/received_events","type":"User","site_admin":false},"created_at":"2018-04-23T21:50:22Z","updated_at":"2018-04-23T21:50:22Z","author_association":"COLLABORATOR","body":"Thank you for another contribution."}}
{"actor":{"display_login":"Jofairden"}}