{"action":"created","comment":{"url":"https://api.github.com/repos/ChilliCream/hotchocolate/pulls/comments/232767372","pull_request_review_id":174037959,"id":232767372,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjc2NzM3Mg==","diff_hunk":"@@ -18,6 +18,11 @@ public DateTimeType()\n \n         protected override string Serialize(DateTime value)\n         {\n+            if (value.Kind == DateTimeKind.Utc)\n+            {\n+                return value.ToString(\"yyyy-MM-ddTHH\\\\:mm\\\\:ss.fffZ\");","path":"src/Types/Types/Scalars/DateTimeType.cs","position":6,"original_position":6,"commit_id":"b0bb6b05c95464df08fd36536ee5308500d9660e","original_commit_id":"b0bb6b05c95464df08fd36536ee5308500d9660e","user":{"login":"michaelstaib","id":9714350,"node_id":"MDQ6VXNlcjk3MTQzNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/9714350?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelstaib","html_url":"https://github.com/michaelstaib","followers_url":"https://api.github.com/users/michaelstaib/followers","following_url":"https://api.github.com/users/michaelstaib/following{/other_user}","gists_url":"https://api.github.com/users/michaelstaib/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelstaib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelstaib/subscriptions","organizations_url":"https://api.github.com/users/michaelstaib/orgs","repos_url":"https://api.github.com/users/michaelstaib/repos","events_url":"https://api.github.com/users/michaelstaib/events{/privacy}","received_events_url":"https://api.github.com/users/michaelstaib/received_events","type":"User","site_admin":false},"body":"We should align the outputs. The else clause is without fff. So, either we include in both serialization formats the milliseconds or in none of the outputs. Can you fix that?","created_at":"2018-11-12T18:33:14Z","updated_at":"2018-11-12T18:38:45Z","html_url":"https://github.com/ChilliCream/hotchocolate/pull/339#discussion_r232767372","pull_request_url":"https://api.github.com/repos/ChilliCream/hotchocolate/pulls/339","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ChilliCream/hotchocolate/pulls/comments/232767372"},"html":{"href":"https://github.com/ChilliCream/hotchocolate/pull/339#discussion_r232767372"},"pull_request":{"href":"https://api.github.com/repos/ChilliCream/hotchocolate/pulls/339"}}},"pull_request":{"url":"https://api.github.com/repos/ChilliCream/hotchocolate/pulls/339","id":230211312,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMjExMzEy","html_url":"https://github.com/ChilliCream/hotchocolate/pull/339","diff_url":"https://github.com/ChilliCream/hotchocolate/pull/339.diff","patch_url":"https://github.com/ChilliCream/hotchocolate/pull/339.patch","issue_url":"https://api.github.com/repos/ChilliCream/hotchocolate/issues/339","number":339,"state":"open","locked":false,"title":"Serialize UTC DateTime as Zulu-Time","user":{"login":"tsinghammer","id":7204007,"node_id":"MDQ6VXNlcjcyMDQwMDc=","avatar_url":"https://avatars3.githubusercontent.com/u/7204007?v=4","gravatar_id":"","url":"https://api.github.com/users/tsinghammer","html_url":"https://github.com/tsinghammer","followers_url":"https://api.github.com/users/tsinghammer/followers","following_url":"https://api.github.com/users/tsinghammer/following{/other_user}","gists_url":"https://api.github.com/users/tsinghammer/gists{/gist_id}","starred_url":"https://api.github.com/users/tsinghammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsinghammer/subscriptions","organizations_url":"https://api.github.com/users/tsinghammer/orgs","repos_url":"https://api.github.com/users/tsinghammer/repos","events_url":"https://api.github.com/users/tsinghammer/events{/privacy}","received_events_url":"https://api.github.com/users/tsinghammer/received_events","type":"User","site_admin":false},"body":"What do you think of this change?","created_at":"2018-11-12T17:22:59Z","updated_at":"2018-11-12T18:38:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"095337c761b5e1aa39dd7f42076c10e391180bd0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ChilliCream/hotchocolate/pulls/339/commits","review_comments_url":"https://api.github.com/repos/ChilliCream/hotchocolate/pulls/339/comments","review_comment_url":"https://api.github.com/repos/ChilliCream/hotchocolate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ChilliCream/hotchocolate/issues/339/comments","statuses_url":"https://api.github.com/repos/ChilliCream/hotchocolate/statuses/b0bb6b05c95464df08fd36536ee5308500d9660e","head":{"label":"tsinghammer:utc","ref":"utc","sha":"b0bb6b05c95464df08fd36536ee5308500d9660e","user":{"login":"tsinghammer","id":7204007,"node_id":"MDQ6VXNlcjcyMDQwMDc=","avatar_url":"https://avatars3.githubusercontent.com/u/7204007?v=4","gravatar_id":"","url":"https://api.github.com/users/tsinghammer","html_url":"https://github.com/tsinghammer","followers_url":"https://api.github.com/users/tsinghammer/followers","following_url":"https://api.github.com/users/tsinghammer/following{/other_user}","gists_url":"https://api.github.com/users/tsinghammer/gists{/gist_id}","starred_url":"https://api.github.com/users/tsinghammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsinghammer/subscriptions","organizations_url":"https://api.github.com/users/tsinghammer/orgs","repos_url":"https://api.github.com/users/tsinghammer/repos","events_url":"https://api.github.com/users/tsinghammer/events{/privacy}","received_events_url":"https://api.github.com/users/tsinghammer/received_events","type":"User","site_admin":false},"repo":{"id":157249426,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcyNDk0MjY=","name":"hotchocolate","full_name":"tsinghammer/hotchocolate","private":false,"owner":{"login":"tsinghammer","id":7204007,"node_id":"MDQ6VXNlcjcyMDQwMDc=","avatar_url":"https://avatars3.githubusercontent.com/u/7204007?v=4","gravatar_id":"","url":"https://api.github.com/users/tsinghammer","html_url":"https://github.com/tsinghammer","followers_url":"https://api.github.com/users/tsinghammer/followers","following_url":"https://api.github.com/users/tsinghammer/following{/other_user}","gists_url":"https://api.github.com/users/tsinghammer/gists{/gist_id}","starred_url":"https://api.github.com/users/tsinghammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsinghammer/subscriptions","organizations_url":"https://api.github.com/users/tsinghammer/orgs","repos_url":"https://api.github.com/users/tsinghammer/repos","events_url":"https://api.github.com/users/tsinghammer/events{/privacy}","received_events_url":"https://api.github.com/users/tsinghammer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tsinghammer/hotchocolate","description":"Hot Chocolate is a GraphQL server for .net core and .net classic","fork":true,"url":"https://api.github.com/repos/tsinghammer/hotchocolate","forks_url":"https://api.github.com/repos/tsinghammer/hotchocolate/forks","keys_url":"https://api.github.com/repos/tsinghammer/hotchocolate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsinghammer/hotchocolate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsinghammer/hotchocolate/teams","hooks_url":"https://api.github.com/repos/tsinghammer/hotchocolate/hooks","issue_events_url":"https://api.github.com/repos/tsinghammer/hotchocolate/issues/events{/number}","events_url":"https://api.github.com/repos/tsinghammer/hotchocolate/events","assignees_url":"https://api.github.com/repos/tsinghammer/hotchocolate/assignees{/user}","branches_url":"https://api.github.com/repos/tsinghammer/hotchocolate/branches{/branch}","tags_url":"https://api.github.com/repos/tsinghammer/hotchocolate/tags","blobs_url":"https://api.github.com/repos/tsinghammer/hotchocolate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsinghammer/hotchocolate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsinghammer/hotchocolate/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsinghammer/hotchocolate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsinghammer/hotchocolate/statuses/{sha}","languages_url":"https://api.github.com/repos/tsinghammer/hotchocolate/languages","stargazers_url":"https://api.github.com/repos/tsinghammer/hotchocolate/stargazers","contributors_url":"https://api.github.com/repos/tsinghammer/hotchocolate/contributors","subscribers_url":"https://api.github.com/repos/tsinghammer/hotchocolate/subscribers","subscription_url":"https://api.github.com/repos/tsinghammer/hotchocolate/subscription","commits_url":"https://api.github.com/repos/tsinghammer/hotchocolate/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsinghammer/hotchocolate/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsinghammer/hotchocolate/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsinghammer/hotchocolate/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsinghammer/hotchocolate/contents/{+path}","compare_url":"https://api.github.com/repos/tsinghammer/hotchocolate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsinghammer/hotchocolate/merges","archive_url":"https://api.github.com/repos/tsinghammer/hotchocolate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsinghammer/hotchocolate/downloads","issues_url":"https://api.github.com/repos/tsinghammer/hotchocolate/issues{/number}","pulls_url":"https://api.github.com/repos/tsinghammer/hotchocolate/pulls{/number}","milestones_url":"https://api.github.com/repos/tsinghammer/hotchocolate/milestones{/number}","notifications_url":"https://api.github.com/repos/tsinghammer/hotchocolate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsinghammer/hotchocolate/labels{/name}","releases_url":"https://api.github.com/repos/tsinghammer/hotchocolate/releases{/id}","deployments_url":"https://api.github.com/repos/tsinghammer/hotchocolate/deployments","created_at":"2018-11-12T17:17:12Z","updated_at":"2018-11-12T17:17:16Z","pushed_at":"2018-11-12T17:21:32Z","git_url":"git://github.com/tsinghammer/hotchocolate.git","ssh_url":"git@github.com:tsinghammer/hotchocolate.git","clone_url":"https://github.com/tsinghammer/hotchocolate.git","svn_url":"https://github.com/tsinghammer/hotchocolate","homepage":"https://hotchocolate.io","size":2054,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ChilliCream:master","ref":"master","sha":"f128a898c7e599f093434e6febd8de824114cc8f","user":{"login":"ChilliCream","id":16239022,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjM5MDIy","avatar_url":"https://avatars0.githubusercontent.com/u/16239022?v=4","gravatar_id":"","url":"https://api.github.com/users/ChilliCream","html_url":"https://github.com/ChilliCream","followers_url":"https://api.github.com/users/ChilliCream/followers","following_url":"https://api.github.com/users/ChilliCream/following{/other_user}","gists_url":"https://api.github.com/users/ChilliCream/gists{/gist_id}","starred_url":"https://api.github.com/users/ChilliCream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChilliCream/subscriptions","organizations_url":"https://api.github.com/users/ChilliCream/orgs","repos_url":"https://api.github.com/users/ChilliCream/repos","events_url":"https://api.github.com/users/ChilliCream/events{/privacy}","received_events_url":"https://api.github.com/users/ChilliCream/received_events","type":"Organization","site_admin":false},"repo":{"id":117102183,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcxMDIxODM=","name":"hotchocolate","full_name":"ChilliCream/hotchocolate","private":false,"owner":{"login":"ChilliCream","id":16239022,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MjM5MDIy","avatar_url":"https://avatars0.githubusercontent.com/u/16239022?v=4","gravatar_id":"","url":"https://api.github.com/users/ChilliCream","html_url":"https://github.com/ChilliCream","followers_url":"https://api.github.com/users/ChilliCream/followers","following_url":"https://api.github.com/users/ChilliCream/following{/other_user}","gists_url":"https://api.github.com/users/ChilliCream/gists{/gist_id}","starred_url":"https://api.github.com/users/ChilliCream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChilliCream/subscriptions","organizations_url":"https://api.github.com/users/ChilliCream/orgs","repos_url":"https://api.github.com/users/ChilliCream/repos","events_url":"https://api.github.com/users/ChilliCream/events{/privacy}","received_events_url":"https://api.github.com/users/ChilliCream/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ChilliCream/hotchocolate","description":"Hot Chocolate is a GraphQL server for .net core and .net classic","fork":false,"url":"https://api.github.com/repos/ChilliCream/hotchocolate","forks_url":"https://api.github.com/repos/ChilliCream/hotchocolate/forks","keys_url":"https://api.github.com/repos/ChilliCream/hotchocolate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChilliCream/hotchocolate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChilliCream/hotchocolate/teams","hooks_url":"https://api.github.com/repos/ChilliCream/hotchocolate/hooks","issue_events_url":"https://api.github.com/repos/ChilliCream/hotchocolate/issues/events{/number}","events_url":"https://api.github.com/repos/ChilliCream/hotchocolate/events","assignees_url":"https://api.github.com/repos/ChilliCream/hotchocolate/assignees{/user}","branches_url":"https://api.github.com/repos/ChilliCream/hotchocolate/branches{/branch}","tags_url":"https://api.github.com/repos/ChilliCream/hotchocolate/tags","blobs_url":"https://api.github.com/repos/ChilliCream/hotchocolate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChilliCream/hotchocolate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChilliCream/hotchocolate/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChilliCream/hotchocolate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChilliCream/hotchocolate/statuses/{sha}","languages_url":"https://api.github.com/repos/ChilliCream/hotchocolate/languages","stargazers_url":"https://api.github.com/repos/ChilliCream/hotchocolate/stargazers","contributors_url":"https://api.github.com/repos/ChilliCream/hotchocolate/contributors","subscribers_url":"https://api.github.com/repos/ChilliCream/hotchocolate/subscribers","subscription_url":"https://api.github.com/repos/ChilliCream/hotchocolate/subscription","commits_url":"https://api.github.com/repos/ChilliCream/hotchocolate/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChilliCream/hotchocolate/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChilliCream/hotchocolate/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChilliCream/hotchocolate/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChilliCream/hotchocolate/contents/{+path}","compare_url":"https://api.github.com/repos/ChilliCream/hotchocolate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChilliCream/hotchocolate/merges","archive_url":"https://api.github.com/repos/ChilliCream/hotchocolate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChilliCream/hotchocolate/downloads","issues_url":"https://api.github.com/repos/ChilliCream/hotchocolate/issues{/number}","pulls_url":"https://api.github.com/repos/ChilliCream/hotchocolate/pulls{/number}","milestones_url":"https://api.github.com/repos/ChilliCream/hotchocolate/milestones{/number}","notifications_url":"https://api.github.com/repos/ChilliCream/hotchocolate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChilliCream/hotchocolate/labels{/name}","releases_url":"https://api.github.com/repos/ChilliCream/hotchocolate/releases{/id}","deployments_url":"https://api.github.com/repos/ChilliCream/hotchocolate/deployments","created_at":"2018-01-11T13:12:21Z","updated_at":"2018-11-12T15:29:24Z","pushed_at":"2018-11-12T17:23:00Z","git_url":"git://github.com/ChilliCream/hotchocolate.git","ssh_url":"git@github.com:ChilliCream/hotchocolate.git","clone_url":"https://github.com/ChilliCream/hotchocolate.git","svn_url":"https://github.com/ChilliCream/hotchocolate","homepage":"https://hotchocolate.io","size":2049,"stargazers_count":128,"watchers_count":128,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":18,"open_issues":66,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ChilliCream/hotchocolate/pulls/339"},"html":{"href":"https://github.com/ChilliCream/hotchocolate/pull/339"},"issue":{"href":"https://api.github.com/repos/ChilliCream/hotchocolate/issues/339"},"comments":{"href":"https://api.github.com/repos/ChilliCream/hotchocolate/issues/339/comments"},"review_comments":{"href":"https://api.github.com/repos/ChilliCream/hotchocolate/pulls/339/comments"},"review_comment":{"href":"https://api.github.com/repos/ChilliCream/hotchocolate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ChilliCream/hotchocolate/pulls/339/commits"},"statuses":{"href":"https://api.github.com/repos/ChilliCream/hotchocolate/statuses/b0bb6b05c95464df08fd36536ee5308500d9660e"}},"author_association":"NONE"}}
{"actor":{"display_login":"michaelstaib"}}