{"action":"created","issue":{"url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/issues/994","repository_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa","labels_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/issues/994/labels{/name}","comments_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/issues/994/comments","events_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/issues/994/events","html_url":"https://github.com/ibpsa/modelica-ibpsa/pull/994","id":345213227,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NDIxODU2","number":994,"title":"Trying to solve Issue842 multiyear","user":{"login":"AnaConstantin","id":8265208,"node_id":"MDQ6VXNlcjgyNjUyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/8265208?v=4","gravatar_id":"","url":"https://api.github.com/users/AnaConstantin","html_url":"https://github.com/AnaConstantin","followers_url":"https://api.github.com/users/AnaConstantin/followers","following_url":"https://api.github.com/users/AnaConstantin/following{/other_user}","gists_url":"https://api.github.com/users/AnaConstantin/gists{/gist_id}","starred_url":"https://api.github.com/users/AnaConstantin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnaConstantin/subscriptions","organizations_url":"https://api.github.com/users/AnaConstantin/orgs","repos_url":"https://api.github.com/users/AnaConstantin/repos","events_url":"https://api.github.com/users/AnaConstantin/events{/privacy}","received_events_url":"https://api.github.com/users/AnaConstantin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-27T12:48:07Z","updated_at":"2018-08-24T14:30:22Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/pulls/994","html_url":"https://github.com/ibpsa/modelica-ibpsa/pull/994","diff_url":"https://github.com/ibpsa/modelica-ibpsa/pull/994.diff","patch_url":"https://github.com/ibpsa/modelica-ibpsa/pull/994.patch"},"body":"For solving #842.\r\nFirst of all sorry for taking so long to work on this issue. It has been really challenging to get any free time, let alone IBPSA free time.\r\nAnyways I have done a new implementation focusing only on the ConvertTime.mo block\r\nIf the simulation time goes over the time span of the weather file, the weather file is repeated only if the time span is a year or a multiple of a year. By time span I mean: end time stamp - beginning time stamp + average increment. To my mind positive and negative time stamps are treated correctly in this manner.\r\nI did add the condition regarding the shift for the solar radiation, I'm not really sure however that it is absolutely necessary. In my implementation it required an additional parameter, an additonal variable and a pair of equations. \r\nI have used the ReaderTMY3.mo file from the master, as the one in the branch was not updated to the changes from December 2017 regarding the absolute file name.\r\nSo please update the branch for the issue, and ideally there should be no more merge conflicts. "},"comment":{"url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/issues/comments/415776719","html_url":"https://github.com/ibpsa/modelica-ibpsa/pull/994#issuecomment-415776719","issue_url":"https://api.github.com/repos/ibpsa/modelica-ibpsa/issues/994","id":415776719,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTc3NjcxOQ==","user":{"login":"mwetter","id":1329080,"node_id":"MDQ6VXNlcjEzMjkwODA=","avatar_url":"https://avatars0.githubusercontent.com/u/1329080?v=4","gravatar_id":"","url":"https://api.github.com/users/mwetter","html_url":"https://github.com/mwetter","followers_url":"https://api.github.com/users/mwetter/followers","following_url":"https://api.github.com/users/mwetter/following{/other_user}","gists_url":"https://api.github.com/users/mwetter/gists{/gist_id}","starred_url":"https://api.github.com/users/mwetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwetter/subscriptions","organizations_url":"https://api.github.com/users/mwetter/orgs","repos_url":"https://api.github.com/users/mwetter/repos","events_url":"https://api.github.com/users/mwetter/events{/privacy}","received_events_url":"https://api.github.com/users/mwetter/received_events","type":"User","site_admin":false},"created_at":"2018-08-24T14:30:22Z","updated_at":"2018-08-24T14:30:22Z","author_association":"CONTRIBUTOR","body":"Todo:\r\n- [ ] Add test cases that show that the new code correctly handles the problems that it ought to fix.\r\n- [ ] See if \"average increment of weather data\" is really needed, which was introduced in this revision. What if data are not equidistant? This new data makes it backward incompatible."}}
{"actor":{"display_login":"mwetter"}}