{"action":"closed","number":29084,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/29084","id":211003921,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMDAzOTIx","html_url":"https://github.com/cockroachdb/cockroach/pull/29084","diff_url":"https://github.com/cockroachdb/cockroach/pull/29084.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/29084.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/29084","number":29084,"state":"closed","locked":false,"title":"storage: deflake TestStoreRangeMergeReadoptedBothFollowers","user":{"login":"benesch","id":882976,"node_id":"MDQ6VXNlcjg4Mjk3Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/882976?v=4","gravatar_id":"","url":"https://api.github.com/users/benesch","html_url":"https://github.com/benesch","followers_url":"https://api.github.com/users/benesch/followers","following_url":"https://api.github.com/users/benesch/following{/other_user}","gists_url":"https://api.github.com/users/benesch/gists{/gist_id}","starred_url":"https://api.github.com/users/benesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benesch/subscriptions","organizations_url":"https://api.github.com/users/benesch/orgs","repos_url":"https://api.github.com/users/benesch/repos","events_url":"https://api.github.com/users/benesch/events{/privacy}","received_events_url":"https://api.github.com/users/benesch/received_events","type":"User","site_admin":false},"body":"TestStoreRangeMergeReadoptedBothFollowers expects that attempting to\r\nplace merged range [a, c) onto a store that has orphaned pre-merge\r\nreplicas [a, b) and [b, c) fails with the following message:\r\n\r\n    cannot apply snapshot: snapshot intersects existing range\r\n\r\nIn rare cases, the snapshot application could instead fail with:\r\n\r\n    remote failed to apply snapshot for reason failed to apply snapshot: snapshot intersects existing range\r\n\r\nThe first message is generated by the canApplySnapshot check that occurs\r\nwhen the reservation is made. The second message is generated by the\r\ncanApplySnapshot check that occurs after the snapshot is received.\r\n\r\nThe test, not unfairly, expects to only see the first message; it has\r\norphaned two intersecting replicas onto the receiving store, and those\r\nintersecting replicas should fail the snapshot in the first check! It\r\nturns out that, in rare cases, the snapshot could arrive at the\r\nreceiving store before the replicas were initialized. The snapshot would\r\nslip through the first check, but receiving the snapshot would take some\r\ntime, and so the replicas would be initialized by the second check.\r\n\r\nTeach the test to properly wait for the replicas on the receiving store\r\nto be fully initialized before sending any snapshots.\r\n\r\nFix #29078.\r\n\r\nRelease note: None","created_at":"2018-08-27T04:41:57Z","updated_at":"2018-08-27T13:32:13Z","closed_at":"2018-08-27T13:32:13Z","merged_at":"2018-08-27T13:32:13Z","merge_commit_sha":"a77edbff218d15b5b1a3910bfa574ca9d9446089","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"core-prs","id":2437977,"node_id":"MDQ6VGVhbTI0Mzc5Nzc=","slug":"core-prs","description":"Join this team for notifications about core PRs","privacy":"closed","url":"https://api.github.com/teams/2437977","members_url":"https://api.github.com/teams/2437977/members{/member}","repositories_url":"https://api.github.com/teams/2437977/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/29084/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/29084/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/29084/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/a77edbff218d15b5b1a3910bfa574ca9d9446089","head":{"label":"benesch:29078","ref":"29078","sha":"a77edbff218d15b5b1a3910bfa574ca9d9446089","user":{"login":"benesch","id":882976,"node_id":"MDQ6VXNlcjg4Mjk3Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/882976?v=4","gravatar_id":"","url":"https://api.github.com/users/benesch","html_url":"https://github.com/benesch","followers_url":"https://api.github.com/users/benesch/followers","following_url":"https://api.github.com/users/benesch/following{/other_user}","gists_url":"https://api.github.com/users/benesch/gists{/gist_id}","starred_url":"https://api.github.com/users/benesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benesch/subscriptions","organizations_url":"https://api.github.com/users/benesch/orgs","repos_url":"https://api.github.com/users/benesch/repos","events_url":"https://api.github.com/users/benesch/events{/privacy}","received_events_url":"https://api.github.com/users/benesch/received_events","type":"User","site_admin":false},"repo":{"id":78508291,"node_id":"MDEwOlJlcG9zaXRvcnk3ODUwODI5MQ==","name":"cockroach","full_name":"benesch/cockroach","owner":{"login":"benesch","id":882976,"node_id":"MDQ6VXNlcjg4Mjk3Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/882976?v=4","gravatar_id":"","url":"https://api.github.com/users/benesch","html_url":"https://github.com/benesch","followers_url":"https://api.github.com/users/benesch/followers","following_url":"https://api.github.com/users/benesch/following{/other_user}","gists_url":"https://api.github.com/users/benesch/gists{/gist_id}","starred_url":"https://api.github.com/users/benesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benesch/subscriptions","organizations_url":"https://api.github.com/users/benesch/orgs","repos_url":"https://api.github.com/users/benesch/repos","events_url":"https://api.github.com/users/benesch/events{/privacy}","received_events_url":"https://api.github.com/users/benesch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benesch/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":true,"url":"https://api.github.com/repos/benesch/cockroach","forks_url":"https://api.github.com/repos/benesch/cockroach/forks","keys_url":"https://api.github.com/repos/benesch/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benesch/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benesch/cockroach/teams","hooks_url":"https://api.github.com/repos/benesch/cockroach/hooks","issue_events_url":"https://api.github.com/repos/benesch/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/benesch/cockroach/events","assignees_url":"https://api.github.com/repos/benesch/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/benesch/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/benesch/cockroach/tags","blobs_url":"https://api.github.com/repos/benesch/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benesch/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benesch/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/benesch/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benesch/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/benesch/cockroach/languages","stargazers_url":"https://api.github.com/repos/benesch/cockroach/stargazers","contributors_url":"https://api.github.com/repos/benesch/cockroach/contributors","subscribers_url":"https://api.github.com/repos/benesch/cockroach/subscribers","subscription_url":"https://api.github.com/repos/benesch/cockroach/subscription","commits_url":"https://api.github.com/repos/benesch/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/benesch/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/benesch/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/benesch/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/benesch/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/benesch/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benesch/cockroach/merges","archive_url":"https://api.github.com/repos/benesch/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benesch/cockroach/downloads","issues_url":"https://api.github.com/repos/benesch/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/benesch/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/benesch/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/benesch/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benesch/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/benesch/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/benesch/cockroach/deployments","created_at":"2017-01-10T07:21:31Z","updated_at":"2018-08-05T17:11:19Z","pushed_at":"2018-08-27T04:41:32Z","git_url":"git://github.com/benesch/cockroach.git","ssh_url":"git@github.com:benesch/cockroach.git","clone_url":"https://github.com/benesch/cockroach.git","svn_url":"https://github.com/benesch/cockroach","homepage":"https://www.cockroachlabs.com","size":555816,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"3cdd221e01048154f705e1efb130afb42338b462","user":{"login":"cockroachdb","id":6748139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NDgxMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU2MzU4Nw==","name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NDgxMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"CockroachDB - the open source, cloud-native SQL database.","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2018-08-27T12:29:44Z","pushed_at":"2018-08-27T13:32:09Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":1044713,"stargazers_count":14136,"watchers_count":14136,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1478,"mirror_url":null,"archived":false,"open_issues_count":1876,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1478,"open_issues":1876,"watchers":14136,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/29084"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/29084"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/29084"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/29084/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/29084/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/29084/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/a77edbff218d15b5b1a3910bfa574ca9d9446089"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"craig[bot]","id":37807150,"node_id":"MDM6Qm90Mzc4MDcxNTA=","avatar_url":"https://avatars0.githubusercontent.com/in/10419?v=4","gravatar_id":"","url":"https://api.github.com/users/craig%5Bbot%5D","html_url":"https://github.com/apps/craig","followers_url":"https://api.github.com/users/craig%5Bbot%5D/followers","following_url":"https://api.github.com/users/craig%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/craig%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/craig%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craig%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/craig%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/craig%5Bbot%5D/repos","events_url":"https://api.github.com/users/craig%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/craig%5Bbot%5D/received_events","type":"Bot","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":22,"deletions":16,"changed_files":1}}
{"actor":{"display_login":"craig"}}