{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/comments/219395513","pull_request_review_id":157558834,"id":219395513,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTM5NTUxMw==","diff_hunk":"@@ -105,7 +105,7 @@ func (pe *projectionEliminater) optimize(lp LogicalPlan) (LogicalPlan, error) {\n \treturn root, nil\n }\n \n-// eliminate eliminates the redundant projection in a logical plan.\n+// eliminate eliminates the redundant projection in a logical planner.","path":"planner/core/rule_eliminate_projection.go","position":14,"original_position":14,"commit_id":"1d743e4a4c6e71b1ec66695507d986c963d24c72","original_commit_id":"1d743e4a4c6e71b1ec66695507d986c963d24c72","user":{"login":"eurekaka","id":6261973,"node_id":"MDQ6VXNlcjYyNjE5NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/6261973?v=4","gravatar_id":"","url":"https://api.github.com/users/eurekaka","html_url":"https://github.com/eurekaka","followers_url":"https://api.github.com/users/eurekaka/followers","following_url":"https://api.github.com/users/eurekaka/following{/other_user}","gists_url":"https://api.github.com/users/eurekaka/gists{/gist_id}","starred_url":"https://api.github.com/users/eurekaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eurekaka/subscriptions","organizations_url":"https://api.github.com/users/eurekaka/orgs","repos_url":"https://api.github.com/users/eurekaka/repos","events_url":"https://api.github.com/users/eurekaka/events{/privacy}","received_events_url":"https://api.github.com/users/eurekaka/received_events","type":"User","site_admin":false},"body":"ditto","created_at":"2018-09-21T06:33:42Z","updated_at":"2018-09-21T06:36:53Z","html_url":"https://github.com/pingcap/tidb/pull/7760#discussion_r219395513","pull_request_url":"https://api.github.com/repos/pingcap/tidb/pulls/7760","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments/219395513"},"html":{"href":"https://github.com/pingcap/tidb/pull/7760#discussion_r219395513"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7760"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/7760","id":217162297,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MTYyMjk3","html_url":"https://github.com/pingcap/tidb/pull/7760","diff_url":"https://github.com/pingcap/tidb/pull/7760.diff","patch_url":"https://github.com/pingcap/tidb/pull/7760.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/7760","number":7760,"state":"open","locked":false,"title":"*: change package name from `plan` to `planner`","user":{"login":"zz-jason","id":5268763,"node_id":"MDQ6VXNlcjUyNjg3NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5268763?v=4","gravatar_id":"","url":"https://api.github.com/users/zz-jason","html_url":"https://github.com/zz-jason","followers_url":"https://api.github.com/users/zz-jason/followers","following_url":"https://api.github.com/users/zz-jason/following{/other_user}","gists_url":"https://api.github.com/users/zz-jason/gists{/gist_id}","starred_url":"https://api.github.com/users/zz-jason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zz-jason/subscriptions","organizations_url":"https://api.github.com/users/zz-jason/orgs","repos_url":"https://api.github.com/users/zz-jason/repos","events_url":"https://api.github.com/users/zz-jason/events{/privacy}","received_events_url":"https://api.github.com/users/zz-jason/received_events","type":"User","site_admin":false},"body":"### What problem does this PR solve? <!--add issue link with summary if exists-->\r\n\r\nThis PR makes the following two package changes:\r\n1. change the \"plan\" package to \"planner\"\r\n2. move all the source files inside the \"planner\" package to the \"planner/core\" package\r\n\r\nThe propose of this PR is to:\r\n1. modularize the \"planner\" package\r\n2. prevent the chaos to implement the cascades planner.\r\n\r\n### What is changed and how it works?\r\n\r\nalmost all the code changes are made by the shell scripts\r\n\r\n### Check List <!--REMOVE the items that are not applicable-->\r\n\r\nTests <!-- At least one of them must be included. -->\r\n\r\n - Unit test\r\n - Integration test\r\n","created_at":"2018-09-21T03:30:39Z","updated_at":"2018-09-21T06:36:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4630879aaa98918d298acf14185e875e42fbc8c2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":667671533,"node_id":"MDU6TGFiZWw2Njc2NzE1MzM=","url":"https://api.github.com/repos/pingcap/tidb/labels/component/planner","name":"component/planner","color":"1d76db","default":false},{"id":660753991,"node_id":"MDU6TGFiZWw2NjA3NTM5OTE=","url":"https://api.github.com/repos/pingcap/tidb/labels/priority/release-blocker","name":"priority/release-blocker","color":"b60205","default":false},{"id":256872088,"node_id":"MDU6TGFiZWwyNTY4NzIwODg=","url":"https://api.github.com/repos/pingcap/tidb/labels/type/enhancement","name":"type/enhancement","color":"84b6eb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/7760/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/7760/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/7760/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/1d743e4a4c6e71b1ec66695507d986c963d24c72","head":{"label":"zz-jason:dev/plan-changeto-planner","ref":"dev/plan-changeto-planner","sha":"1d743e4a4c6e71b1ec66695507d986c963d24c72","user":{"login":"zz-jason","id":5268763,"node_id":"MDQ6VXNlcjUyNjg3NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5268763?v=4","gravatar_id":"","url":"https://api.github.com/users/zz-jason","html_url":"https://github.com/zz-jason","followers_url":"https://api.github.com/users/zz-jason/followers","following_url":"https://api.github.com/users/zz-jason/following{/other_user}","gists_url":"https://api.github.com/users/zz-jason/gists{/gist_id}","starred_url":"https://api.github.com/users/zz-jason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zz-jason/subscriptions","organizations_url":"https://api.github.com/users/zz-jason/orgs","repos_url":"https://api.github.com/users/zz-jason/repos","events_url":"https://api.github.com/users/zz-jason/events{/privacy}","received_events_url":"https://api.github.com/users/zz-jason/received_events","type":"User","site_admin":false},"repo":{"id":107492543,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc0OTI1NDM=","name":"tidb","full_name":"zz-jason/tidb","private":false,"owner":{"login":"zz-jason","id":5268763,"node_id":"MDQ6VXNlcjUyNjg3NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5268763?v=4","gravatar_id":"","url":"https://api.github.com/users/zz-jason","html_url":"https://github.com/zz-jason","followers_url":"https://api.github.com/users/zz-jason/followers","following_url":"https://api.github.com/users/zz-jason/following{/other_user}","gists_url":"https://api.github.com/users/zz-jason/gists{/gist_id}","starred_url":"https://api.github.com/users/zz-jason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zz-jason/subscriptions","organizations_url":"https://api.github.com/users/zz-jason/orgs","repos_url":"https://api.github.com/users/zz-jason/repos","events_url":"https://api.github.com/users/zz-jason/events{/privacy}","received_events_url":"https://api.github.com/users/zz-jason/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zz-jason/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":true,"url":"https://api.github.com/repos/zz-jason/tidb","forks_url":"https://api.github.com/repos/zz-jason/tidb/forks","keys_url":"https://api.github.com/repos/zz-jason/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zz-jason/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zz-jason/tidb/teams","hooks_url":"https://api.github.com/repos/zz-jason/tidb/hooks","issue_events_url":"https://api.github.com/repos/zz-jason/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/zz-jason/tidb/events","assignees_url":"https://api.github.com/repos/zz-jason/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/zz-jason/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/zz-jason/tidb/tags","blobs_url":"https://api.github.com/repos/zz-jason/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zz-jason/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zz-jason/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/zz-jason/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zz-jason/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/zz-jason/tidb/languages","stargazers_url":"https://api.github.com/repos/zz-jason/tidb/stargazers","contributors_url":"https://api.github.com/repos/zz-jason/tidb/contributors","subscribers_url":"https://api.github.com/repos/zz-jason/tidb/subscribers","subscription_url":"https://api.github.com/repos/zz-jason/tidb/subscription","commits_url":"https://api.github.com/repos/zz-jason/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/zz-jason/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/zz-jason/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/zz-jason/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/zz-jason/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/zz-jason/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zz-jason/tidb/merges","archive_url":"https://api.github.com/repos/zz-jason/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zz-jason/tidb/downloads","issues_url":"https://api.github.com/repos/zz-jason/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/zz-jason/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/zz-jason/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/zz-jason/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zz-jason/tidb/labels{/name}","releases_url":"https://api.github.com/repos/zz-jason/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/zz-jason/tidb/deployments","created_at":"2017-10-19T03:14:19Z","updated_at":"2017-10-19T03:14:23Z","pushed_at":"2018-09-21T03:31:13Z","git_url":"git://github.com/zz-jason/tidb.git","ssh_url":"git@github.com:zz-jason/tidb.git","clone_url":"https://github.com/zz-jason/tidb.git","svn_url":"https://github.com/zz-jason/tidb","homepage":"https://pingcap.com","size":56486,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"334e9254d3ccf4d12d53e97c96c00d12bbf3f073","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"node_id":"MDEwOlJlcG9zaXRvcnk0MTk4NjM2OQ==","name":"tidb","full_name":"pingcap/tidb","private":false,"owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed HTAP database compatible with the MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2018-09-21T06:26:07Z","pushed_at":"2018-09-21T06:17:42Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"https://pingcap.com","size":82628,"stargazers_count":15028,"watchers_count":15028,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2120,"mirror_url":null,"archived":false,"open_issues_count":562,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2120,"open_issues":562,"watchers":15028,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7760"},"html":{"href":"https://github.com/pingcap/tidb/pull/7760"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/7760"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/7760/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7760/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/7760/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/1d743e4a4c6e71b1ec66695507d986c963d24c72"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"eurekaka"}}