{"action":"opened","issue":{"url":"https://api.github.com/repos/containerd/containerd/issues/2835","repository_url":"https://api.github.com/repos/containerd/containerd","labels_url":"https://api.github.com/repos/containerd/containerd/issues/2835/labels{/name}","comments_url":"https://api.github.com/repos/containerd/containerd/issues/2835/comments","events_url":"https://api.github.com/repos/containerd/containerd/issues/2835/events","html_url":"https://github.com/containerd/containerd/issues/2835","id":384243348,"node_id":"MDU6SXNzdWUzODQyNDMzNDg=","number":2835,"title":"[question] is that flaky case in windows?","user":{"login":"fuweid","id":17510957,"node_id":"MDQ6VXNlcjE3NTEwOTU3","avatar_url":"https://avatars3.githubusercontent.com/u/17510957?v=4","gravatar_id":"","url":"https://api.github.com/users/fuweid","html_url":"https://github.com/fuweid","followers_url":"https://api.github.com/users/fuweid/followers","following_url":"https://api.github.com/users/fuweid/following{/other_user}","gists_url":"https://api.github.com/users/fuweid/gists{/gist_id}","starred_url":"https://api.github.com/users/fuweid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuweid/subscriptions","organizations_url":"https://api.github.com/users/fuweid/orgs","repos_url":"https://api.github.com/users/fuweid/repos","events_url":"https://api.github.com/users/fuweid/events{/privacy}","received_events_url":"https://api.github.com/users/fuweid/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-26T09:33:46Z","updated_at":"2018-11-26T09:33:46Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"<!--\r\nIf you are reporting a new issue, make sure that we do not have any duplicates\r\nalready open. You can ensure this by searching the issue list for this\r\nrepository. If there is a duplicate, please close your issue and add a comment\r\nto the existing issue instead.\r\n\r\nIf you suspect your issue is a bug, please edit your issue description to\r\ninclude the BUG REPORT INFORMATION shown below. If you fail to provide this\r\ninformation within 7 days, we cannot debug your issue and will close it. We\r\nwill, however, reopen it if you later provide the information.\r\n\r\n---------------------------------------------------\r\nBUG REPORT INFORMATION\r\n---------------------------------------------------\r\nUse the commands below to provide key information from your environment:\r\nYou do NOT have to include this information if this is a FEATURE REQUEST\r\n-->\r\n\r\n**Description**\r\n\r\n<!--\r\nBriefly describe the problem you are having in a few paragraphs.\r\n-->\r\n\r\nI see that one case related to content store failed because the test binary removes the file which hold by containerd process.\r\n\r\n```\r\n--- FAIL: TestContentClient/CommitErrorState (4.95s)\r\n        testsuite.go:101: Cleanup failed: unknown\r\n            github.com/containerd/containerd/errdefs.init\r\n            \tC:/gopath/src/github.com/containerd/containerd/errdefs/errors.go:39\r\n            github.com/containerd/containerd/content.init\r\n            \t<autogenerated>:1\r\n            github.com/containerd/containerd.init\r\n            \t<autogenerated>:1\r\n            main.init\r\n            \t<autogenerated>:1\r\n            runtime.main\r\n            \tC:/go/src/runtime/proc.go:189\r\n            runtime.goexit\r\n            \tC:/go/src/runtime/asm_amd64.s:1333\r\n            remove C:\\Program Files\\containerd\\root-test\\io.containerd.content.v1.content\\ingest\\9101c5f249b4cb38a50dddda86a787c09f31099573c87c525fc50774ac21d05d\\.tmp-updatedat542245581: The process cannot access the file because it is being used by another process.\r\n            github.com/containerd/containerd/errdefs.FromGRPC\r\n            \tC:/gopath/src/github.com/containerd/containerd/errdefs/grpc.go:98\r\n            github.com/containerd/containerd/content/proxy.(*proxyContentStore).Abort\r\n            \tC:/gopath/src/github.com/containerd/containerd/content/proxy/content_store.go:187\r\n            github.com/containerd/containerd.newContentStore.func2\r\n            \tC:/gopath/src/github.com/containerd/containerd/content_test.go:60\r\n            github.com/containerd/containerd/content/testsuite.makeTest.func1.1\r\n            \tC:/gopath/src/github.com/containerd/containerd/content/testsuite/testsuite.go:100\r\n            github.com/containerd/containerd/content/testsuite.makeTest.func1\r\n            \tC:/gopath/src/github.com/containerd/containerd/content/testsuite/testsuite.go:121\r\n            testing.tRunner\r\n            \tC:/go/src/testing/testing.go:827\r\n            runtime.goexit\r\n            \tC:/go/src/runtime/asm_amd64.s:1333\r\n            failed to abort c1-commiterror-state\r\n            github.com/containerd/containerd.newContentStore.func2\r\n            \tC:/gopath/src/github.com/containerd/containerd/content_test.go:61\r\n            github.com/containerd/containerd/content/testsuite.makeTest.func1.1\r\n            \tC:/gopath/src/github.com/containerd/containerd/content/testsuite/testsuite.go:100\r\n            github.com/containerd/containerd/content/testsuite.makeTest.func1\r\n            \tC:/gopath/src/github.com/containerd/containerd/content/testsuite/testsuite.go:121\r\n            testing.tRunner\r\n            \tC:/go/src/testing/testing.go:827\r\n            runtime.goexit\r\n            \tC:/go/src/runtime/asm_amd64.s:1333\r\n```\r\n\r\nThe case will [close](https://github.com/containerd/containerd/blob/master/content/testsuite/testsuite.go#L484) the grpc stream. However, the content service doesn't close file descriptor synchronously. Before the file is closed, the cleanup will call `Abort` to remove the file. But it failed in windows. I am not sure that it is related to windows kernel. I can not reproduce `The process cannot access the file because it is being used by another process.` in linux kernel. \r\n\r\nFrom https://github.com/containerd/containerd/pull/2823\r\n"}}
{"actor":{"display_login":"fuweid"}}