{"action":"opened","number":6485,"pull_request":{"url":"https://api.github.com/repos/certbot/certbot/pulls/6485","id":229358944,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MzU4OTQ0","html_url":"https://github.com/certbot/certbot/pull/6485","diff_url":"https://github.com/certbot/certbot/pull/6485.diff","patch_url":"https://github.com/certbot/certbot/pull/6485.patch","issue_url":"https://api.github.com/repos/certbot/certbot/issues/6485","number":6485,"state":"open","locked":false,"title":"[URGENT] Repair the CI system","user":{"login":"adferrand","id":9728851,"node_id":"MDQ6VXNlcjk3Mjg4NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/9728851?v=4","gravatar_id":"","url":"https://api.github.com/users/adferrand","html_url":"https://github.com/adferrand","followers_url":"https://api.github.com/users/adferrand/followers","following_url":"https://api.github.com/users/adferrand/following{/other_user}","gists_url":"https://api.github.com/users/adferrand/gists{/gist_id}","starred_url":"https://api.github.com/users/adferrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adferrand/subscriptions","organizations_url":"https://api.github.com/users/adferrand/orgs","repos_url":"https://api.github.com/users/adferrand/repos","events_url":"https://api.github.com/users/adferrand/events{/privacy}","received_events_url":"https://api.github.com/users/adferrand/received_events","type":"User","site_admin":false},"body":"Ok. I broke the CI system of Certbot with #6435.\r\n\r\nIt is about the exit codes that are returned from the various scripts in `tools` during `tox` execution.\r\nIndeed, `tox` relies on the non-zero exit code from a given script to know that something failed during the execution.\r\n\r\nPreviously, theses scripts were in bash, and a bash script returns an exit code that is the higher code returned from any of the command executed by the script. So if any command return a non-zero (in particular `pylint` or `pytest`, then the script return also non-zero.\r\n\r\nNow that theses scripts are converted into python, `pylint` and `pytest` are executed via `subprocess`, that return the exit code. But if theses codes are not handled explicitly, the python script itself will return zero. As a consequence currently, Certbot CI system is unable to detect any test error or lint error.\r\n\r\nThis PR fixes that, by handling correctly the exit code from the most critical scripts, `install_and_test.py` and `tox.cover.py`, but also all the scripts that I converted into Python and that could be executed in the context of a shell (via `tox` or directly for instance).\r\n\r\nThis PR should be merged as soon as possible.\r\n\r\nReally sorry for the regression.","created_at":"2018-11-08T13:09:28Z","updated_at":"2018-11-08T13:09:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/certbot/certbot/pulls/6485/commits","review_comments_url":"https://api.github.com/repos/certbot/certbot/pulls/6485/comments","review_comment_url":"https://api.github.com/repos/certbot/certbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/certbot/certbot/issues/6485/comments","statuses_url":"https://api.github.com/repos/certbot/certbot/statuses/f215322184c9a91ac560cf9787e4e4bc725ba2c6","head":{"label":"adferrand:exit-code-on-python-scripts","ref":"exit-code-on-python-scripts","sha":"f215322184c9a91ac560cf9787e4e4bc725ba2c6","user":{"login":"adferrand","id":9728851,"node_id":"MDQ6VXNlcjk3Mjg4NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/9728851?v=4","gravatar_id":"","url":"https://api.github.com/users/adferrand","html_url":"https://github.com/adferrand","followers_url":"https://api.github.com/users/adferrand/followers","following_url":"https://api.github.com/users/adferrand/following{/other_user}","gists_url":"https://api.github.com/users/adferrand/gists{/gist_id}","starred_url":"https://api.github.com/users/adferrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adferrand/subscriptions","organizations_url":"https://api.github.com/users/adferrand/orgs","repos_url":"https://api.github.com/users/adferrand/repos","events_url":"https://api.github.com/users/adferrand/events{/privacy}","received_events_url":"https://api.github.com/users/adferrand/received_events","type":"User","site_admin":false},"repo":{"id":144460400,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ0NjA0MDA=","name":"certbot","full_name":"adferrand/certbot","private":false,"owner":{"login":"adferrand","id":9728851,"node_id":"MDQ6VXNlcjk3Mjg4NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/9728851?v=4","gravatar_id":"","url":"https://api.github.com/users/adferrand","html_url":"https://github.com/adferrand","followers_url":"https://api.github.com/users/adferrand/followers","following_url":"https://api.github.com/users/adferrand/following{/other_user}","gists_url":"https://api.github.com/users/adferrand/gists{/gist_id}","starred_url":"https://api.github.com/users/adferrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adferrand/subscriptions","organizations_url":"https://api.github.com/users/adferrand/orgs","repos_url":"https://api.github.com/users/adferrand/repos","events_url":"https://api.github.com/users/adferrand/events{/privacy}","received_events_url":"https://api.github.com/users/adferrand/received_events","type":"User","site_admin":false},"html_url":"https://github.com/adferrand/certbot","description":"Certbot is EFF's tool to obtain certs from Let's Encrypt and (optionally) auto-enable HTTPS on your server.  It can also act as a client for any other CA that uses the ACME protocol.","fork":true,"url":"https://api.github.com/repos/adferrand/certbot","forks_url":"https://api.github.com/repos/adferrand/certbot/forks","keys_url":"https://api.github.com/repos/adferrand/certbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adferrand/certbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adferrand/certbot/teams","hooks_url":"https://api.github.com/repos/adferrand/certbot/hooks","issue_events_url":"https://api.github.com/repos/adferrand/certbot/issues/events{/number}","events_url":"https://api.github.com/repos/adferrand/certbot/events","assignees_url":"https://api.github.com/repos/adferrand/certbot/assignees{/user}","branches_url":"https://api.github.com/repos/adferrand/certbot/branches{/branch}","tags_url":"https://api.github.com/repos/adferrand/certbot/tags","blobs_url":"https://api.github.com/repos/adferrand/certbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adferrand/certbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adferrand/certbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/adferrand/certbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adferrand/certbot/statuses/{sha}","languages_url":"https://api.github.com/repos/adferrand/certbot/languages","stargazers_url":"https://api.github.com/repos/adferrand/certbot/stargazers","contributors_url":"https://api.github.com/repos/adferrand/certbot/contributors","subscribers_url":"https://api.github.com/repos/adferrand/certbot/subscribers","subscription_url":"https://api.github.com/repos/adferrand/certbot/subscription","commits_url":"https://api.github.com/repos/adferrand/certbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/adferrand/certbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/adferrand/certbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/adferrand/certbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/adferrand/certbot/contents/{+path}","compare_url":"https://api.github.com/repos/adferrand/certbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adferrand/certbot/merges","archive_url":"https://api.github.com/repos/adferrand/certbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adferrand/certbot/downloads","issues_url":"https://api.github.com/repos/adferrand/certbot/issues{/number}","pulls_url":"https://api.github.com/repos/adferrand/certbot/pulls{/number}","milestones_url":"https://api.github.com/repos/adferrand/certbot/milestones{/number}","notifications_url":"https://api.github.com/repos/adferrand/certbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adferrand/certbot/labels{/name}","releases_url":"https://api.github.com/repos/adferrand/certbot/releases{/id}","deployments_url":"https://api.github.com/repos/adferrand/certbot/deployments","created_at":"2018-08-12T11:17:30Z","updated_at":"2018-11-08T10:49:10Z","pushed_at":"2018-11-08T11:51:30Z","git_url":"git://github.com/adferrand/certbot.git","ssh_url":"git@github.com:adferrand/certbot.git","clone_url":"https://github.com/adferrand/certbot.git","svn_url":"https://github.com/adferrand/certbot","homepage":"","size":19800,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"certbot:master","ref":"master","sha":"3d0e16ece3762d5bfe345fde0af286e26c54bacb","user":{"login":"certbot","id":17889013,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODg5MDEz","avatar_url":"https://avatars2.githubusercontent.com/u/17889013?v=4","gravatar_id":"","url":"https://api.github.com/users/certbot","html_url":"https://github.com/certbot","followers_url":"https://api.github.com/users/certbot/followers","following_url":"https://api.github.com/users/certbot/following{/other_user}","gists_url":"https://api.github.com/users/certbot/gists{/gist_id}","starred_url":"https://api.github.com/users/certbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certbot/subscriptions","organizations_url":"https://api.github.com/users/certbot/orgs","repos_url":"https://api.github.com/users/certbot/repos","events_url":"https://api.github.com/users/certbot/events{/privacy}","received_events_url":"https://api.github.com/users/certbot/received_events","type":"Organization","site_admin":false},"repo":{"id":26516210,"node_id":"MDEwOlJlcG9zaXRvcnkyNjUxNjIxMA==","name":"certbot","full_name":"certbot/certbot","private":false,"owner":{"login":"certbot","id":17889013,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODg5MDEz","avatar_url":"https://avatars2.githubusercontent.com/u/17889013?v=4","gravatar_id":"","url":"https://api.github.com/users/certbot","html_url":"https://github.com/certbot","followers_url":"https://api.github.com/users/certbot/followers","following_url":"https://api.github.com/users/certbot/following{/other_user}","gists_url":"https://api.github.com/users/certbot/gists{/gist_id}","starred_url":"https://api.github.com/users/certbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certbot/subscriptions","organizations_url":"https://api.github.com/users/certbot/orgs","repos_url":"https://api.github.com/users/certbot/repos","events_url":"https://api.github.com/users/certbot/events{/privacy}","received_events_url":"https://api.github.com/users/certbot/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/certbot/certbot","description":"Certbot is EFF's tool to obtain certs from Let's Encrypt and (optionally) auto-enable HTTPS on your server.  It can also act as a client for any other CA that uses the ACME protocol.","fork":false,"url":"https://api.github.com/repos/certbot/certbot","forks_url":"https://api.github.com/repos/certbot/certbot/forks","keys_url":"https://api.github.com/repos/certbot/certbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/certbot/certbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/certbot/certbot/teams","hooks_url":"https://api.github.com/repos/certbot/certbot/hooks","issue_events_url":"https://api.github.com/repos/certbot/certbot/issues/events{/number}","events_url":"https://api.github.com/repos/certbot/certbot/events","assignees_url":"https://api.github.com/repos/certbot/certbot/assignees{/user}","branches_url":"https://api.github.com/repos/certbot/certbot/branches{/branch}","tags_url":"https://api.github.com/repos/certbot/certbot/tags","blobs_url":"https://api.github.com/repos/certbot/certbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/certbot/certbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/certbot/certbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/certbot/certbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/certbot/certbot/statuses/{sha}","languages_url":"https://api.github.com/repos/certbot/certbot/languages","stargazers_url":"https://api.github.com/repos/certbot/certbot/stargazers","contributors_url":"https://api.github.com/repos/certbot/certbot/contributors","subscribers_url":"https://api.github.com/repos/certbot/certbot/subscribers","subscription_url":"https://api.github.com/repos/certbot/certbot/subscription","commits_url":"https://api.github.com/repos/certbot/certbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/certbot/certbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/certbot/certbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/certbot/certbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/certbot/certbot/contents/{+path}","compare_url":"https://api.github.com/repos/certbot/certbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/certbot/certbot/merges","archive_url":"https://api.github.com/repos/certbot/certbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/certbot/certbot/downloads","issues_url":"https://api.github.com/repos/certbot/certbot/issues{/number}","pulls_url":"https://api.github.com/repos/certbot/certbot/pulls{/number}","milestones_url":"https://api.github.com/repos/certbot/certbot/milestones{/number}","notifications_url":"https://api.github.com/repos/certbot/certbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/certbot/certbot/labels{/name}","releases_url":"https://api.github.com/repos/certbot/certbot/releases{/id}","deployments_url":"https://api.github.com/repos/certbot/certbot/deployments","created_at":"2014-11-12T02:52:20Z","updated_at":"2018-11-08T11:21:49Z","pushed_at":"2018-11-08T10:55:14Z","git_url":"git://github.com/certbot/certbot.git","ssh_url":"git@github.com:certbot/certbot.git","clone_url":"https://github.com/certbot/certbot.git","svn_url":"https://github.com/certbot/certbot","homepage":"","size":20175,"stargazers_count":23563,"watchers_count":23563,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2336,"mirror_url":null,"archived":false,"open_issues_count":939,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2336,"open_issues":939,"watchers":23563,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/certbot/certbot/pulls/6485"},"html":{"href":"https://github.com/certbot/certbot/pull/6485"},"issue":{"href":"https://api.github.com/repos/certbot/certbot/issues/6485"},"comments":{"href":"https://api.github.com/repos/certbot/certbot/issues/6485/comments"},"review_comments":{"href":"https://api.github.com/repos/certbot/certbot/pulls/6485/comments"},"review_comment":{"href":"https://api.github.com/repos/certbot/certbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/certbot/certbot/pulls/6485/commits"},"statuses":{"href":"https://api.github.com/repos/certbot/certbot/statuses/f215322184c9a91ac560cf9787e4e4bc725ba2c6"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":41,"deletions":23,"changed_files":6}}
{"actor":{"display_login":"adferrand"}}