{"action":"created","issue":{"url":"https://api.github.com/repos/stan-dev/stan/issues/2481","repository_url":"https://api.github.com/repos/stan-dev/stan","labels_url":"https://api.github.com/repos/stan-dev/stan/issues/2481/labels{/name}","comments_url":"https://api.github.com/repos/stan-dev/stan/issues/2481/comments","events_url":"https://api.github.com/repos/stan-dev/stan/issues/2481/events","html_url":"https://github.com/stan-dev/stan/pull/2481","id":303226581,"number":2481,"title":"[Jenkins] Integration tests are always essentially make-only.","user":{"login":"seantalts","id":805356,"avatar_url":"https://avatars1.githubusercontent.com/u/805356?v=4","gravatar_id":"","url":"https://api.github.com/users/seantalts","html_url":"https://github.com/seantalts","followers_url":"https://api.github.com/users/seantalts/followers","following_url":"https://api.github.com/users/seantalts/following{/other_user}","gists_url":"https://api.github.com/users/seantalts/gists{/gist_id}","starred_url":"https://api.github.com/users/seantalts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seantalts/subscriptions","organizations_url":"https://api.github.com/users/seantalts/orgs","repos_url":"https://api.github.com/users/seantalts/repos","events_url":"https://api.github.com/users/seantalts/events{/privacy}","received_events_url":"https://api.github.com/users/seantalts/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-07T19:20:55Z","updated_at":"2018-03-07T20:44:15Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/stan-dev/stan/pulls/2481","html_url":"https://github.com/stan-dev/stan/pull/2481","diff_url":"https://github.com/stan-dev/stan/pull/2481.diff","patch_url":"https://github.com/stan-dev/stan/pull/2481.patch"},"body":"#### Copyright and Licensing\r\n\r\nPlease list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):\r\n\r\nColumbia University\r\n\r\nBy submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:\r\n- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)\r\n- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)\r\n"},"comment":{"url":"https://api.github.com/repos/stan-dev/stan/issues/comments/371278144","html_url":"https://github.com/stan-dev/stan/pull/2481#issuecomment-371278144","issue_url":"https://api.github.com/repos/stan-dev/stan/issues/2481","id":371278144,"user":{"login":"seantalts","id":805356,"avatar_url":"https://avatars1.githubusercontent.com/u/805356?v=4","gravatar_id":"","url":"https://api.github.com/users/seantalts","html_url":"https://github.com/seantalts","followers_url":"https://api.github.com/users/seantalts/followers","following_url":"https://api.github.com/users/seantalts/following{/other_user}","gists_url":"https://api.github.com/users/seantalts/gists{/gist_id}","starred_url":"https://api.github.com/users/seantalts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seantalts/subscriptions","organizations_url":"https://api.github.com/users/seantalts/orgs","repos_url":"https://api.github.com/users/seantalts/repos","events_url":"https://api.github.com/users/seantalts/events{/privacy}","received_events_url":"https://api.github.com/users/seantalts/received_events","type":"User","site_admin":false},"created_at":"2018-03-07T20:44:14Z","updated_at":"2018-03-07T20:44:14Z","author_association":"OWNER","body":"Hahahaha. Those were great. The hope was correct! But I realized that the\nintegration tests are both .PHONY targets that mostly just make sure the\nmodels can be compiled, so they don't need to have a separate `--make-only`\nstep (and the one I had added was causing things to take twice as long in\nthis stage because the target was .PHONY and always runs).\n\nOn Wed, Mar 7, 2018 at 3:41 PM, Daniel Lee <notifications@github.com> wrote:\n\n> My hope: it runs make without actually running the test executable.\n>\n> My fear: it just prints the output of make without running make.\n>\n> My third guess: it turns on a makerbot in the office.\n>\n> > On Mar 7, 2018, at 2:46 PM, seantalts <notifications@github.com> wrote:\n> >\n> > I will give you 3 guesses 😂\n> >\n> > On Wed, Mar 7, 2018 at 2:45 PM, Daniel Lee <notifications@github.com>\n> wrote:\n> >\n> > > What does the make only flag do?\n> > >\n> > > And yes, these will fail to compile when something is wrong. The\n> output of\n> > > google test just confirms that it has indeed compiled correctly.\n> > >\n> > >\n> > > > On Mar 7, 2018, at 2:20 PM, seantalts <notifications@github.com>\n> wrote:\n> > > >\n> > > > Copyright and Licensing\n> > > >\n> > > > Please list the copyright holder for the work you are submitting\n> (this\n> > > will be you or your assignee, such as a university or company):\n> > > >\n> > > > Columbia University\n> > > >\n> > > > By submitting this pull request, the copyright holder is agreeing to\n> > > license the submitted work under the following licenses:\n> > > >\n> > > > Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)\n> > > > Documentation: CC-BY 4.0 (https://creativecommons.org/\n> licenses/by/4.0/)\n> > > > You can view, comment on, or merge this pull request online at:\n> > > >\n> > > > https://github.com/stan-dev/stan/pull/2481\n> > > >\n> > > > Commit Summary\n> > > >\n> > > > Integration tests are always essentially make-only.\n> > > > File Changes\n> > > >\n> > > > M Jenkinsfile (9)\n> > > > Patch Links:\n> > > >\n> > > > https://github.com/stan-dev/stan/pull/2481.patch\n> > > > https://github.com/stan-dev/stan/pull/2481.diff\n> > > > —\n> > > > You are receiving this because you are subscribed to this thread.\n> > > > Reply to this email directly, view it on GitHub, or mute the thread.\n> > > >\n> > >\n> > > —\n> > > You are receiving this because you authored the thread.\n> > > Reply to this email directly, view it on GitHub\n> > > <https://github.com/stan-dev/stan/pull/2481#issuecomment-371260726>,\n> or mute\n> > > the thread\n> > > <https://github.com/notifications/unsubscribe-\n> auth/AAxJ7DAWI45GNsigvLMeR_hP2JZPE7Lkks5tcDi8gaJpZM4ShAzD>\n> > > .\n> > >\n> > —\n> > You are receiving this because you commented.\n> > Reply to this email directly, view it on GitHub, or mute the thread.\n> >\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/stan-dev/stan/pull/2481#issuecomment-371277356>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AAxJ7Ljf4rgLax4wsHoWckqyYNBxYRgnks5tcEYAgaJpZM4ShAzD>\n> .\n>\n"}}
{"actor":{"display_login":"seantalts"}}