{"action":"created","comment":{"url":"https://api.github.com/repos/jpan127/compiler/pulls/comments/192953381","pull_request_review_id":125826886,"id":192953381,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mjk1MzM4MQ==","diff_hunk":"@@ -65,47 +65,47 @@ namespace backend\n         j_file << TAB << \"invokevirtual java/io/PrintStream/println(Ljava/lang/String;)V\"            << endl;\n         j_file                                                                                       << endl;\n \n-        for (auto function : PassVisitor::variable_id_map)\n+        const intermediate::SymbolTablePtr global_table = store.lookup_symbol_table(\"global\");\n+        const intermediate::SymbolTablePtr main_table   = store.lookup_symbol_table(\"main\");\n+        const std::vector <intermediate::SymbolTablePtr> tables_to_print = { global_table , main_table };\n+\n+        for (auto table : tables_to_print)","path":"src/backend/pass2/Pass2Visitor.cpp","position":9,"original_position":9,"commit_id":"f54e1082986473ec6353434363bebbd2f8fa095c","original_commit_id":"f54e1082986473ec6353434363bebbd2f8fa095c","user":{"login":"jpan127","id":19752007,"node_id":"MDQ6VXNlcjE5NzUyMDA3","avatar_url":"https://avatars1.githubusercontent.com/u/19752007?v=4","gravatar_id":"","url":"https://api.github.com/users/jpan127","html_url":"https://github.com/jpan127","followers_url":"https://api.github.com/users/jpan127/followers","following_url":"https://api.github.com/users/jpan127/following{/other_user}","gists_url":"https://api.github.com/users/jpan127/gists{/gist_id}","starred_url":"https://api.github.com/users/jpan127/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpan127/subscriptions","organizations_url":"https://api.github.com/users/jpan127/orgs","repos_url":"https://api.github.com/users/jpan127/repos","events_url":"https://api.github.com/users/jpan127/events{/privacy}","received_events_url":"https://api.github.com/users/jpan127/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2018-06-05T05:55:47Z","updated_at":"2018-06-05T05:55:48Z","html_url":"https://github.com/jpan127/compiler/pull/30#discussion_r192953381","pull_request_url":"https://api.github.com/repos/jpan127/compiler/pulls/30","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jpan127/compiler/pulls/comments/192953381"},"html":{"href":"https://github.com/jpan127/compiler/pull/30#discussion_r192953381"},"pull_request":{"href":"https://api.github.com/repos/jpan127/compiler/pulls/30"}},"in_reply_to_id":192116393},"pull_request":{"url":"https://api.github.com/repos/jpan127/compiler/pulls/30","id":191769194,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNzY5MTk0","html_url":"https://github.com/jpan127/compiler/pull/30","diff_url":"https://github.com/jpan127/compiler/pull/30.diff","patch_url":"https://github.com/jpan127/compiler/pull/30.patch","issue_url":"https://api.github.com/repos/jpan127/compiler/issues/30","number":30,"state":"open","locked":false,"title":"[#21] Moving symbol access to a storage data structure","user":{"login":"jpan127","id":19752007,"node_id":"MDQ6VXNlcjE5NzUyMDA3","avatar_url":"https://avatars1.githubusercontent.com/u/19752007?v=4","gravatar_id":"","url":"https://api.github.com/users/jpan127","html_url":"https://github.com/jpan127","followers_url":"https://api.github.com/users/jpan127/followers","following_url":"https://api.github.com/users/jpan127/following{/other_user}","gists_url":"https://api.github.com/users/jpan127/gists{/gist_id}","starred_url":"https://api.github.com/users/jpan127/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpan127/subscriptions","organizations_url":"https://api.github.com/users/jpan127/orgs","repos_url":"https://api.github.com/users/jpan127/repos","events_url":"https://api.github.com/users/jpan127/events{/privacy}","received_events_url":"https://api.github.com/users/jpan127/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-31T14:19:25Z","updated_at":"2018-06-05T05:55:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3bb4a41bae00ffec685a92a5b1e8f069b1fbb9a","assignee":{"login":"jpan127","id":19752007,"node_id":"MDQ6VXNlcjE5NzUyMDA3","avatar_url":"https://avatars1.githubusercontent.com/u/19752007?v=4","gravatar_id":"","url":"https://api.github.com/users/jpan127","html_url":"https://github.com/jpan127","followers_url":"https://api.github.com/users/jpan127/followers","following_url":"https://api.github.com/users/jpan127/following{/other_user}","gists_url":"https://api.github.com/users/jpan127/gists{/gist_id}","starred_url":"https://api.github.com/users/jpan127/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpan127/subscriptions","organizations_url":"https://api.github.com/users/jpan127/orgs","repos_url":"https://api.github.com/users/jpan127/repos","events_url":"https://api.github.com/users/jpan127/events{/privacy}","received_events_url":"https://api.github.com/users/jpan127/received_events","type":"User","site_admin":false},"assignees":[{"login":"jpan127","id":19752007,"node_id":"MDQ6VXNlcjE5NzUyMDA3","avatar_url":"https://avatars1.githubusercontent.com/u/19752007?v=4","gravatar_id":"","url":"https://api.github.com/users/jpan127","html_url":"https://github.com/jpan127","followers_url":"https://api.github.com/users/jpan127/followers","following_url":"https://api.github.com/users/jpan127/following{/other_user}","gists_url":"https://api.github.com/users/jpan127/gists{/gist_id}","starred_url":"https://api.github.com/users/jpan127/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpan127/subscriptions","organizations_url":"https://api.github.com/users/jpan127/orgs","repos_url":"https://api.github.com/users/jpan127/repos","events_url":"https://api.github.com/users/jpan127/events{/privacy}","received_events_url":"https://api.github.com/users/jpan127/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jpan127/compiler/pulls/30/commits","review_comments_url":"https://api.github.com/repos/jpan127/compiler/pulls/30/comments","review_comment_url":"https://api.github.com/repos/jpan127/compiler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jpan127/compiler/issues/30/comments","statuses_url":"https://api.github.com/repos/jpan127/compiler/statuses/f54e1082986473ec6353434363bebbd2f8fa095c","head":{"label":"jpan127:dev/jp-21","ref":"dev/jp-21","sha":"f54e1082986473ec6353434363bebbd2f8fa095c","user":{"login":"jpan127","id":19752007,"node_id":"MDQ6VXNlcjE5NzUyMDA3","avatar_url":"https://avatars1.githubusercontent.com/u/19752007?v=4","gravatar_id":"","url":"https://api.github.com/users/jpan127","html_url":"https://github.com/jpan127","followers_url":"https://api.github.com/users/jpan127/followers","following_url":"https://api.github.com/users/jpan127/following{/other_user}","gists_url":"https://api.github.com/users/jpan127/gists{/gist_id}","starred_url":"https://api.github.com/users/jpan127/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpan127/subscriptions","organizations_url":"https://api.github.com/users/jpan127/orgs","repos_url":"https://api.github.com/users/jpan127/repos","events_url":"https://api.github.com/users/jpan127/events{/privacy}","received_events_url":"https://api.github.com/users/jpan127/received_events","type":"User","site_admin":false},"repo":{"id":120530627,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA1MzA2Mjc=","name":"compiler","full_name":"jpan127/compiler","owner":{"login":"jpan127","id":19752007,"node_id":"MDQ6VXNlcjE5NzUyMDA3","avatar_url":"https://avatars1.githubusercontent.com/u/19752007?v=4","gravatar_id":"","url":"https://api.github.com/users/jpan127","html_url":"https://github.com/jpan127","followers_url":"https://api.github.com/users/jpan127/followers","following_url":"https://api.github.com/users/jpan127/following{/other_user}","gists_url":"https://api.github.com/users/jpan127/gists{/gist_id}","starred_url":"https://api.github.com/users/jpan127/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpan127/subscriptions","organizations_url":"https://api.github.com/users/jpan127/orgs","repos_url":"https://api.github.com/users/jpan127/repos","events_url":"https://api.github.com/users/jpan127/events{/privacy}","received_events_url":"https://api.github.com/users/jpan127/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jpan127/compiler","description":"C-- Compiler using Antlr4","fork":false,"url":"https://api.github.com/repos/jpan127/compiler","forks_url":"https://api.github.com/repos/jpan127/compiler/forks","keys_url":"https://api.github.com/repos/jpan127/compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpan127/compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpan127/compiler/teams","hooks_url":"https://api.github.com/repos/jpan127/compiler/hooks","issue_events_url":"https://api.github.com/repos/jpan127/compiler/issues/events{/number}","events_url":"https://api.github.com/repos/jpan127/compiler/events","assignees_url":"https://api.github.com/repos/jpan127/compiler/assignees{/user}","branches_url":"https://api.github.com/repos/jpan127/compiler/branches{/branch}","tags_url":"https://api.github.com/repos/jpan127/compiler/tags","blobs_url":"https://api.github.com/repos/jpan127/compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpan127/compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpan127/compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpan127/compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpan127/compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/jpan127/compiler/languages","stargazers_url":"https://api.github.com/repos/jpan127/compiler/stargazers","contributors_url":"https://api.github.com/repos/jpan127/compiler/contributors","subscribers_url":"https://api.github.com/repos/jpan127/compiler/subscribers","subscription_url":"https://api.github.com/repos/jpan127/compiler/subscription","commits_url":"https://api.github.com/repos/jpan127/compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpan127/compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpan127/compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpan127/compiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/jpan127/compiler/contents/{+path}","compare_url":"https://api.github.com/repos/jpan127/compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpan127/compiler/merges","archive_url":"https://api.github.com/repos/jpan127/compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpan127/compiler/downloads","issues_url":"https://api.github.com/repos/jpan127/compiler/issues{/number}","pulls_url":"https://api.github.com/repos/jpan127/compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/jpan127/compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/jpan127/compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpan127/compiler/labels{/name}","releases_url":"https://api.github.com/repos/jpan127/compiler/releases{/id}","deployments_url":"https://api.github.com/repos/jpan127/compiler/deployments","created_at":"2018-02-06T22:22:39Z","updated_at":"2018-05-26T19:26:26Z","pushed_at":"2018-05-31T14:19:26Z","git_url":"git://github.com/jpan127/compiler.git","ssh_url":"git@github.com:jpan127/compiler.git","clone_url":"https://github.com/jpan127/compiler.git","svn_url":"https://github.com/jpan127/compiler","homepage":"","size":57961,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":0,"open_issues":11,"watchers":0,"default_branch":"master"}},"base":{"label":"jpan127:dev/jp","ref":"dev/jp","sha":"51d6ce6c3018369fd63fb424a7f15b5418404a7e","user":{"login":"jpan127","id":19752007,"node_id":"MDQ6VXNlcjE5NzUyMDA3","avatar_url":"https://avatars1.githubusercontent.com/u/19752007?v=4","gravatar_id":"","url":"https://api.github.com/users/jpan127","html_url":"https://github.com/jpan127","followers_url":"https://api.github.com/users/jpan127/followers","following_url":"https://api.github.com/users/jpan127/following{/other_user}","gists_url":"https://api.github.com/users/jpan127/gists{/gist_id}","starred_url":"https://api.github.com/users/jpan127/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpan127/subscriptions","organizations_url":"https://api.github.com/users/jpan127/orgs","repos_url":"https://api.github.com/users/jpan127/repos","events_url":"https://api.github.com/users/jpan127/events{/privacy}","received_events_url":"https://api.github.com/users/jpan127/received_events","type":"User","site_admin":false},"repo":{"id":120530627,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA1MzA2Mjc=","name":"compiler","full_name":"jpan127/compiler","owner":{"login":"jpan127","id":19752007,"node_id":"MDQ6VXNlcjE5NzUyMDA3","avatar_url":"https://avatars1.githubusercontent.com/u/19752007?v=4","gravatar_id":"","url":"https://api.github.com/users/jpan127","html_url":"https://github.com/jpan127","followers_url":"https://api.github.com/users/jpan127/followers","following_url":"https://api.github.com/users/jpan127/following{/other_user}","gists_url":"https://api.github.com/users/jpan127/gists{/gist_id}","starred_url":"https://api.github.com/users/jpan127/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpan127/subscriptions","organizations_url":"https://api.github.com/users/jpan127/orgs","repos_url":"https://api.github.com/users/jpan127/repos","events_url":"https://api.github.com/users/jpan127/events{/privacy}","received_events_url":"https://api.github.com/users/jpan127/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jpan127/compiler","description":"C-- Compiler using Antlr4","fork":false,"url":"https://api.github.com/repos/jpan127/compiler","forks_url":"https://api.github.com/repos/jpan127/compiler/forks","keys_url":"https://api.github.com/repos/jpan127/compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpan127/compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpan127/compiler/teams","hooks_url":"https://api.github.com/repos/jpan127/compiler/hooks","issue_events_url":"https://api.github.com/repos/jpan127/compiler/issues/events{/number}","events_url":"https://api.github.com/repos/jpan127/compiler/events","assignees_url":"https://api.github.com/repos/jpan127/compiler/assignees{/user}","branches_url":"https://api.github.com/repos/jpan127/compiler/branches{/branch}","tags_url":"https://api.github.com/repos/jpan127/compiler/tags","blobs_url":"https://api.github.com/repos/jpan127/compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpan127/compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpan127/compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpan127/compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpan127/compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/jpan127/compiler/languages","stargazers_url":"https://api.github.com/repos/jpan127/compiler/stargazers","contributors_url":"https://api.github.com/repos/jpan127/compiler/contributors","subscribers_url":"https://api.github.com/repos/jpan127/compiler/subscribers","subscription_url":"https://api.github.com/repos/jpan127/compiler/subscription","commits_url":"https://api.github.com/repos/jpan127/compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpan127/compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpan127/compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpan127/compiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/jpan127/compiler/contents/{+path}","compare_url":"https://api.github.com/repos/jpan127/compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpan127/compiler/merges","archive_url":"https://api.github.com/repos/jpan127/compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpan127/compiler/downloads","issues_url":"https://api.github.com/repos/jpan127/compiler/issues{/number}","pulls_url":"https://api.github.com/repos/jpan127/compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/jpan127/compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/jpan127/compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpan127/compiler/labels{/name}","releases_url":"https://api.github.com/repos/jpan127/compiler/releases{/id}","deployments_url":"https://api.github.com/repos/jpan127/compiler/deployments","created_at":"2018-02-06T22:22:39Z","updated_at":"2018-05-26T19:26:26Z","pushed_at":"2018-05-31T14:19:26Z","git_url":"git://github.com/jpan127/compiler.git","ssh_url":"git@github.com:jpan127/compiler.git","clone_url":"https://github.com/jpan127/compiler.git","svn_url":"https://github.com/jpan127/compiler","homepage":"","size":57961,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":0,"open_issues":11,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jpan127/compiler/pulls/30"},"html":{"href":"https://github.com/jpan127/compiler/pull/30"},"issue":{"href":"https://api.github.com/repos/jpan127/compiler/issues/30"},"comments":{"href":"https://api.github.com/repos/jpan127/compiler/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/jpan127/compiler/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/jpan127/compiler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jpan127/compiler/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/jpan127/compiler/statuses/f54e1082986473ec6353434363bebbd2f8fa095c"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jpan127"}}