{"action":"created","comment":{"url":"https://api.github.com/repos/jitsi/jibri/pulls/comments/174925845","pull_request_review_id":104372840,"id":174925845,"diff_hunk":"@@ -0,0 +1,25 @@\n+package org.jitsi.jibri.util\n+\n+import org.jitsi.jibri.CallUrlInfo\n+import org.jxmpp.jid.impl.JidCreate\n+import org.testng.annotations.Test\n+import kotlin.test.expect\n+\n+class XmppUtilsKtTest {\n+    val baseDomain = \"brian.jitsi.net\"\n+    @Test\n+    fun `test basic roomjid url conversion`() {\n+        val expected = CallUrlInfo(\"https://$baseDomain\", \"roomName\")\n+        val jid = JidCreate.entityBareFrom(\"${expected.callName}@$baseDomain\")\n+\n+        expect(expected) { getCallUrlInfoFromJid(jid, \"\", \"brian.jitsi.net\") }\n+    }\n+\n+    @Test\n+    fun `test roomjid with subdomain url conversion`() {\n+        val expected = CallUrlInfo(\"https://$baseDomain\", \"roomName\")\n+        val jid = JidCreate.entityBareFrom(\"${expected.callName}@mucdomain.$baseDomain\")\n+\n+        expect(expected) { getCallUrlInfoFromJid(jid, \"mucdomain.\", \"brian.jitsi.net\") }\n+    }\n+}","path":"src/test/java/org/jitsi/jibri/util/XmppUtilsKtTest.kt","position":25,"original_position":25,"commit_id":"f6cb7e48e493987740d34b157932976a8651e5b5","original_commit_id":"f6cb7e48e493987740d34b157932976a8651e5b5","user":{"login":"bbaldino","id":4016469,"avatar_url":"https://avatars2.githubusercontent.com/u/4016469?v=4","gravatar_id":"","url":"https://api.github.com/users/bbaldino","html_url":"https://github.com/bbaldino","followers_url":"https://api.github.com/users/bbaldino/followers","following_url":"https://api.github.com/users/bbaldino/following{/other_user}","gists_url":"https://api.github.com/users/bbaldino/gists{/gist_id}","starred_url":"https://api.github.com/users/bbaldino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbaldino/subscriptions","organizations_url":"https://api.github.com/users/bbaldino/orgs","repos_url":"https://api.github.com/users/bbaldino/repos","events_url":"https://api.github.com/users/bbaldino/events{/privacy}","received_events_url":"https://api.github.com/users/bbaldino/received_events","type":"User","site_admin":false},"body":"i don't think the linter is running on the test files actually.  i don't have it configured to skip them, so maybe it's a default setting. will have to look into it.","created_at":"2018-03-15T20:42:46Z","updated_at":"2018-03-15T20:42:46Z","html_url":"https://github.com/jitsi/jibri/pull/72#discussion_r174925845","pull_request_url":"https://api.github.com/repos/jitsi/jibri/pulls/72","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jitsi/jibri/pulls/comments/174925845"},"html":{"href":"https://github.com/jitsi/jibri/pull/72#discussion_r174925845"},"pull_request":{"href":"https://api.github.com/repos/jitsi/jibri/pulls/72"}},"in_reply_to_id":174673816},"pull_request":{"url":"https://api.github.com/repos/jitsi/jibri/pulls/72","id":174737622,"html_url":"https://github.com/jitsi/jibri/pull/72","diff_url":"https://github.com/jitsi/jibri/pull/72.diff","patch_url":"https://github.com/jitsi/jibri/pull/72.patch","issue_url":"https://api.github.com/repos/jitsi/jibri/issues/72","number":72,"state":"open","locked":false,"title":"new jibri","user":{"login":"bbaldino","id":4016469,"avatar_url":"https://avatars2.githubusercontent.com/u/4016469?v=4","gravatar_id":"","url":"https://api.github.com/users/bbaldino","html_url":"https://github.com/bbaldino","followers_url":"https://api.github.com/users/bbaldino/followers","following_url":"https://api.github.com/users/bbaldino/following{/other_user}","gists_url":"https://api.github.com/users/bbaldino/gists{/gist_id}","starred_url":"https://api.github.com/users/bbaldino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbaldino/subscriptions","organizations_url":"https://api.github.com/users/bbaldino/orgs","repos_url":"https://api.github.com/users/bbaldino/repos","events_url":"https://api.github.com/users/bbaldino/events{/privacy}","received_events_url":"https://api.github.com/users/bbaldino/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-13T17:40:15Z","updated_at":"2018-03-15T20:42:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"419d8a26d057934909af1ee0eb0105aa0851827f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jitsi/jibri/pulls/72/commits","review_comments_url":"https://api.github.com/repos/jitsi/jibri/pulls/72/comments","review_comment_url":"https://api.github.com/repos/jitsi/jibri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jitsi/jibri/issues/72/comments","statuses_url":"https://api.github.com/repos/jitsi/jibri/statuses/f6cb7e48e493987740d34b157932976a8651e5b5","head":{"label":"bbaldino:jibri_new","ref":"jibri_new","sha":"f6cb7e48e493987740d34b157932976a8651e5b5","user":{"login":"bbaldino","id":4016469,"avatar_url":"https://avatars2.githubusercontent.com/u/4016469?v=4","gravatar_id":"","url":"https://api.github.com/users/bbaldino","html_url":"https://github.com/bbaldino","followers_url":"https://api.github.com/users/bbaldino/followers","following_url":"https://api.github.com/users/bbaldino/following{/other_user}","gists_url":"https://api.github.com/users/bbaldino/gists{/gist_id}","starred_url":"https://api.github.com/users/bbaldino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbaldino/subscriptions","organizations_url":"https://api.github.com/users/bbaldino/orgs","repos_url":"https://api.github.com/users/bbaldino/repos","events_url":"https://api.github.com/users/bbaldino/events{/privacy}","received_events_url":"https://api.github.com/users/bbaldino/received_events","type":"User","site_admin":false},"repo":{"id":124580204,"name":"jibri","full_name":"bbaldino/jibri","owner":{"login":"bbaldino","id":4016469,"avatar_url":"https://avatars2.githubusercontent.com/u/4016469?v=4","gravatar_id":"","url":"https://api.github.com/users/bbaldino","html_url":"https://github.com/bbaldino","followers_url":"https://api.github.com/users/bbaldino/followers","following_url":"https://api.github.com/users/bbaldino/following{/other_user}","gists_url":"https://api.github.com/users/bbaldino/gists{/gist_id}","starred_url":"https://api.github.com/users/bbaldino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbaldino/subscriptions","organizations_url":"https://api.github.com/users/bbaldino/orgs","repos_url":"https://api.github.com/users/bbaldino/repos","events_url":"https://api.github.com/users/bbaldino/events{/privacy}","received_events_url":"https://api.github.com/users/bbaldino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbaldino/jibri","description":"Jitsi BRoadcasting Infrastructure","fork":true,"url":"https://api.github.com/repos/bbaldino/jibri","forks_url":"https://api.github.com/repos/bbaldino/jibri/forks","keys_url":"https://api.github.com/repos/bbaldino/jibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbaldino/jibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbaldino/jibri/teams","hooks_url":"https://api.github.com/repos/bbaldino/jibri/hooks","issue_events_url":"https://api.github.com/repos/bbaldino/jibri/issues/events{/number}","events_url":"https://api.github.com/repos/bbaldino/jibri/events","assignees_url":"https://api.github.com/repos/bbaldino/jibri/assignees{/user}","branches_url":"https://api.github.com/repos/bbaldino/jibri/branches{/branch}","tags_url":"https://api.github.com/repos/bbaldino/jibri/tags","blobs_url":"https://api.github.com/repos/bbaldino/jibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbaldino/jibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbaldino/jibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbaldino/jibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbaldino/jibri/statuses/{sha}","languages_url":"https://api.github.com/repos/bbaldino/jibri/languages","stargazers_url":"https://api.github.com/repos/bbaldino/jibri/stargazers","contributors_url":"https://api.github.com/repos/bbaldino/jibri/contributors","subscribers_url":"https://api.github.com/repos/bbaldino/jibri/subscribers","subscription_url":"https://api.github.com/repos/bbaldino/jibri/subscription","commits_url":"https://api.github.com/repos/bbaldino/jibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbaldino/jibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbaldino/jibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbaldino/jibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbaldino/jibri/contents/{+path}","compare_url":"https://api.github.com/repos/bbaldino/jibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbaldino/jibri/merges","archive_url":"https://api.github.com/repos/bbaldino/jibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbaldino/jibri/downloads","issues_url":"https://api.github.com/repos/bbaldino/jibri/issues{/number}","pulls_url":"https://api.github.com/repos/bbaldino/jibri/pulls{/number}","milestones_url":"https://api.github.com/repos/bbaldino/jibri/milestones{/number}","notifications_url":"https://api.github.com/repos/bbaldino/jibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbaldino/jibri/labels{/name}","releases_url":"https://api.github.com/repos/bbaldino/jibri/releases{/id}","deployments_url":"https://api.github.com/repos/bbaldino/jibri/deployments","created_at":"2018-03-09T18:47:05Z","updated_at":"2018-03-09T18:47:07Z","pushed_at":"2018-03-14T22:22:12Z","git_url":"git://github.com/bbaldino/jibri.git","ssh_url":"git@github.com:bbaldino/jibri.git","clone_url":"https://github.com/bbaldino/jibri.git","svn_url":"https://github.com/bbaldino/jibri","homepage":"","size":487,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jitsi:master","ref":"master","sha":"739ccbf73cf87716419dc60be626cf37290167f8","user":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars2.githubusercontent.com/u/3671647?v=4","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"repo":{"id":51473177,"name":"jibri","full_name":"jitsi/jibri","owner":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars2.githubusercontent.com/u/3671647?v=4","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jitsi/jibri","description":"Jitsi BRoadcasting Infrastructure","fork":false,"url":"https://api.github.com/repos/jitsi/jibri","forks_url":"https://api.github.com/repos/jitsi/jibri/forks","keys_url":"https://api.github.com/repos/jitsi/jibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitsi/jibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitsi/jibri/teams","hooks_url":"https://api.github.com/repos/jitsi/jibri/hooks","issue_events_url":"https://api.github.com/repos/jitsi/jibri/issues/events{/number}","events_url":"https://api.github.com/repos/jitsi/jibri/events","assignees_url":"https://api.github.com/repos/jitsi/jibri/assignees{/user}","branches_url":"https://api.github.com/repos/jitsi/jibri/branches{/branch}","tags_url":"https://api.github.com/repos/jitsi/jibri/tags","blobs_url":"https://api.github.com/repos/jitsi/jibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitsi/jibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitsi/jibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitsi/jibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitsi/jibri/statuses/{sha}","languages_url":"https://api.github.com/repos/jitsi/jibri/languages","stargazers_url":"https://api.github.com/repos/jitsi/jibri/stargazers","contributors_url":"https://api.github.com/repos/jitsi/jibri/contributors","subscribers_url":"https://api.github.com/repos/jitsi/jibri/subscribers","subscription_url":"https://api.github.com/repos/jitsi/jibri/subscription","commits_url":"https://api.github.com/repos/jitsi/jibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitsi/jibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitsi/jibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitsi/jibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitsi/jibri/contents/{+path}","compare_url":"https://api.github.com/repos/jitsi/jibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitsi/jibri/merges","archive_url":"https://api.github.com/repos/jitsi/jibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitsi/jibri/downloads","issues_url":"https://api.github.com/repos/jitsi/jibri/issues{/number}","pulls_url":"https://api.github.com/repos/jitsi/jibri/pulls{/number}","milestones_url":"https://api.github.com/repos/jitsi/jibri/milestones{/number}","notifications_url":"https://api.github.com/repos/jitsi/jibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitsi/jibri/labels{/name}","releases_url":"https://api.github.com/repos/jitsi/jibri/releases{/id}","deployments_url":"https://api.github.com/repos/jitsi/jibri/deployments","created_at":"2016-02-10T21:22:20Z","updated_at":"2018-03-12T12:09:01Z","pushed_at":"2018-03-14T22:22:14Z","git_url":"git://github.com/jitsi/jibri.git","ssh_url":"git@github.com:jitsi/jibri.git","clone_url":"https://github.com/jitsi/jibri.git","svn_url":"https://github.com/jitsi/jibri","homepage":"","size":218,"stargazers_count":47,"watchers_count":47,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":27,"open_issues":29,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jitsi/jibri/pulls/72"},"html":{"href":"https://github.com/jitsi/jibri/pull/72"},"issue":{"href":"https://api.github.com/repos/jitsi/jibri/issues/72"},"comments":{"href":"https://api.github.com/repos/jitsi/jibri/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/jitsi/jibri/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/jitsi/jibri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jitsi/jibri/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/jitsi/jibri/statuses/f6cb7e48e493987740d34b157932976a8651e5b5"}},"author_association":"NONE"}}
{"actor":{"display_login":"bbaldino"}}