{"action":"created","comment":{"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/pulls/comments/181692940","pull_request_review_id":112363582,"id":181692940,"diff_hunk":"@@ -0,0 +1,112 @@\n+import os\n+import pytest\n+import time\n+from cosmo_tester.framework.test_hosts import TestHosts\n+\n+\n+@pytest.fixture(scope='module')\n+def managers(\n+        cfy, ssh_key, module_tmpdir, attributes, logger):\n+    \"\"\"Creates a cloudify manager from an image in rackspace OpenStack.\"\"\"\n+    hosts = TestHosts(\n+        cfy, ssh_key, module_tmpdir, attributes, logger,\n+        number_of_instances=2)\n+\n+    hosts.instances[1].upload_plugins = False\n+\n+    try:\n+        hosts.create()\n+        yield hosts.instances\n+    finally:\n+        hosts.destroy()\n+\n+\n+def test_hidden_secrets(managers,\n+                        cfy,\n+                        logger, tmpdir):\n+\n+    snap_path = str(tmpdir / 'snap.zip')\n+\n+    manager1 = managers[0]\n+    manager2 = managers[1]\n+    agent_user_key = 'user'\n+    agent_user_value = 'centos'\n+    key_pair_key = 'key'\n+    key_pair_value = manager1.remote_private_key_path\n+    server_ip_key = 'ip'\n+    server_ip_value = manager1.ip_address\n+    user_name1 = 'user1'\n+    password = 'user123'\n+    tenant_name = 'default_tenant'\n+    tenant_role = 'user'\n+    blueprint_id = 'hello-world'","path":"cosmo_tester/test_suites/image_based_tests/hidden_secrets_test.py","position":42,"original_position":42,"commit_id":"4552fdf4f6705317fb66fd03d136926afafe993a","original_commit_id":"4552fdf4f6705317fb66fd03d136926afafe993a","user":{"login":"inbala","id":25413570,"avatar_url":"https://avatars0.githubusercontent.com/u/25413570?v=4","gravatar_id":"","url":"https://api.github.com/users/inbala","html_url":"https://github.com/inbala","followers_url":"https://api.github.com/users/inbala/followers","following_url":"https://api.github.com/users/inbala/following{/other_user}","gists_url":"https://api.github.com/users/inbala/gists{/gist_id}","starred_url":"https://api.github.com/users/inbala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inbala/subscriptions","organizations_url":"https://api.github.com/users/inbala/orgs","repos_url":"https://api.github.com/users/inbala/repos","events_url":"https://api.github.com/users/inbala/events{/privacy}","received_events_url":"https://api.github.com/users/inbala/received_events","type":"User","site_admin":false},"body":"I think you should use a configuration file for all those inputs","created_at":"2018-04-16T10:46:29Z","updated_at":"2018-04-16T10:46:29Z","html_url":"https://github.com/cloudify-cosmo/cloudify-system-tests/pull/661#discussion_r181692940","pull_request_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/pulls/661","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/pulls/comments/181692940"},"html":{"href":"https://github.com/cloudify-cosmo/cloudify-system-tests/pull/661#discussion_r181692940"},"pull_request":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/pulls/661"}}},"pull_request":{"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/pulls/661","id":181795703,"html_url":"https://github.com/cloudify-cosmo/cloudify-system-tests/pull/661","diff_url":"https://github.com/cloudify-cosmo/cloudify-system-tests/pull/661.diff","patch_url":"https://github.com/cloudify-cosmo/cloudify-system-tests/pull/661.patch","issue_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/issues/661","number":661,"state":"open","locked":false,"title":"Add hidden secret system test","user":{"login":"uriwygo","id":26067267,"avatar_url":"https://avatars3.githubusercontent.com/u/26067267?v=4","gravatar_id":"","url":"https://api.github.com/users/uriwygo","html_url":"https://github.com/uriwygo","followers_url":"https://api.github.com/users/uriwygo/followers","following_url":"https://api.github.com/users/uriwygo/following{/other_user}","gists_url":"https://api.github.com/users/uriwygo/gists{/gist_id}","starred_url":"https://api.github.com/users/uriwygo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uriwygo/subscriptions","organizations_url":"https://api.github.com/users/uriwygo/orgs","repos_url":"https://api.github.com/users/uriwygo/repos","events_url":"https://api.github.com/users/uriwygo/events{/privacy}","received_events_url":"https://api.github.com/users/uriwygo/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-16T09:08:24Z","updated_at":"2018-04-16T10:46:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40efa8db63de681b93d8b6b0e2b83ddc4a0c6cc9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/pulls/661/commits","review_comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/pulls/661/comments","review_comment_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/issues/661/comments","statuses_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/statuses/4552fdf4f6705317fb66fd03d136926afafe993a","head":{"label":"cloudify-cosmo:hidden-secret-test","ref":"hidden-secret-test","sha":"4552fdf4f6705317fb66fd03d136926afafe993a","user":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars3.githubusercontent.com/u/6260555?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"repo":{"id":18327506,"name":"cloudify-system-tests","full_name":"cloudify-cosmo/cloudify-system-tests","owner":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars3.githubusercontent.com/u/6260555?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudify-cosmo/cloudify-system-tests","description":"Cloudify System Tests","fork":false,"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests","forks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/forks","keys_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/teams","hooks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/hooks","issue_events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/issues/events{/number}","events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/events","assignees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/assignees{/user}","branches_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/branches{/branch}","tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/tags","blobs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/languages","stargazers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/stargazers","contributors_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/contributors","subscribers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/subscribers","subscription_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/subscription","commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/contents/{+path}","compare_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/merges","archive_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/downloads","issues_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/issues{/number}","pulls_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/labels{/name}","releases_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/releases{/id}","deployments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/deployments","created_at":"2014-04-01T11:44:17Z","updated_at":"2018-04-11T13:37:41Z","pushed_at":"2018-04-16T09:15:40Z","git_url":"git://github.com/cloudify-cosmo/cloudify-system-tests.git","ssh_url":"git@github.com:cloudify-cosmo/cloudify-system-tests.git","clone_url":"https://github.com/cloudify-cosmo/cloudify-system-tests.git","svn_url":"https://github.com/cloudify-cosmo/cloudify-system-tests","homepage":null,"size":3646,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":15,"open_issues":20,"watchers":4,"default_branch":"master"}},"base":{"label":"cloudify-cosmo:master","ref":"master","sha":"18775fa8181cc93267d3a31955a7faa4b6c222ae","user":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars3.githubusercontent.com/u/6260555?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"repo":{"id":18327506,"name":"cloudify-system-tests","full_name":"cloudify-cosmo/cloudify-system-tests","owner":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars3.githubusercontent.com/u/6260555?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudify-cosmo/cloudify-system-tests","description":"Cloudify System Tests","fork":false,"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests","forks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/forks","keys_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/teams","hooks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/hooks","issue_events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/issues/events{/number}","events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/events","assignees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/assignees{/user}","branches_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/branches{/branch}","tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/tags","blobs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/languages","stargazers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/stargazers","contributors_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/contributors","subscribers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/subscribers","subscription_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/subscription","commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/contents/{+path}","compare_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/merges","archive_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/downloads","issues_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/issues{/number}","pulls_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/labels{/name}","releases_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/releases{/id}","deployments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/deployments","created_at":"2014-04-01T11:44:17Z","updated_at":"2018-04-11T13:37:41Z","pushed_at":"2018-04-16T09:15:40Z","git_url":"git://github.com/cloudify-cosmo/cloudify-system-tests.git","ssh_url":"git@github.com:cloudify-cosmo/cloudify-system-tests.git","clone_url":"https://github.com/cloudify-cosmo/cloudify-system-tests.git","svn_url":"https://github.com/cloudify-cosmo/cloudify-system-tests","homepage":null,"size":3646,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":15,"open_issues":20,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/pulls/661"},"html":{"href":"https://github.com/cloudify-cosmo/cloudify-system-tests/pull/661"},"issue":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/issues/661"},"comments":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/issues/661/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/pulls/661/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/pulls/661/commits"},"statuses":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-system-tests/statuses/4552fdf4f6705317fb66fd03d136926afafe993a"}},"author_association":"NONE"}}
{"actor":{"display_login":"inbala"}}