{"action":"created","comment":{"url":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/comments/229459762","pull_request_review_id":169967137,"id":229459762,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTQ1OTc2Mg==","diff_hunk":"@@ -172,6 +175,9 @@ private static string GetAssemblyPath(string assembly)\n \n         public bool Run(TestInfo test, int pass, int testNumber, string dmpDir)\n         {\n+            if (TeamCityTestDecoration)","path":"pwiz_tools/Skyline/TestRunnerLib/RunTests.cs","position":28,"original_position":28,"commit_id":"34bbd6756628bb0bb18ab1e14538c49937afa230","original_commit_id":"34bbd6756628bb0bb18ab1e14538c49937afa230","user":{"login":"brendanx67","id":11541328,"node_id":"MDQ6VXNlcjExNTQxMzI4","avatar_url":"https://avatars2.githubusercontent.com/u/11541328?v=4","gravatar_id":"","url":"https://api.github.com/users/brendanx67","html_url":"https://github.com/brendanx67","followers_url":"https://api.github.com/users/brendanx67/followers","following_url":"https://api.github.com/users/brendanx67/following{/other_user}","gists_url":"https://api.github.com/users/brendanx67/gists{/gist_id}","starred_url":"https://api.github.com/users/brendanx67/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendanx67/subscriptions","organizations_url":"https://api.github.com/users/brendanx67/orgs","repos_url":"https://api.github.com/users/brendanx67/repos","events_url":"https://api.github.com/users/brendanx67/events{/privacy}","received_events_url":"https://api.github.com/users/brendanx67/received_events","type":"User","site_admin":false},"body":"Makes your impact on a 200-line function just 3 added lines, right?","created_at":"2018-10-30T19:48:49Z","updated_at":"2018-10-30T19:48:49Z","html_url":"https://github.com/ProteoWizard/pwiz/pull/301#discussion_r229459762","pull_request_url":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/301","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/comments/229459762"},"html":{"href":"https://github.com/ProteoWizard/pwiz/pull/301#discussion_r229459762"},"pull_request":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/301"}},"in_reply_to_id":229458047},"pull_request":{"url":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/301","id":226162363,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MTYyMzYz","html_url":"https://github.com/ProteoWizard/pwiz/pull/301","diff_url":"https://github.com/ProteoWizard/pwiz/pull/301.diff","patch_url":"https://github.com/ProteoWizard/pwiz/pull/301.patch","issue_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues/301","number":301,"state":"open","locked":false,"title":"Skyline Wine fixes","user":{"login":"chambm","id":5011937,"node_id":"MDQ6VXNlcjUwMTE5Mzc=","avatar_url":"https://avatars1.githubusercontent.com/u/5011937?v=4","gravatar_id":"","url":"https://api.github.com/users/chambm","html_url":"https://github.com/chambm","followers_url":"https://api.github.com/users/chambm/followers","following_url":"https://api.github.com/users/chambm/following{/other_user}","gists_url":"https://api.github.com/users/chambm/gists{/gist_id}","starred_url":"https://api.github.com/users/chambm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chambm/subscriptions","organizations_url":"https://api.github.com/users/chambm/orgs","repos_url":"https://api.github.com/users/chambm/repos","events_url":"https://api.github.com/users/chambm/events{/privacy}","received_events_url":"https://api.github.com/users/chambm/received_events","type":"User","site_admin":false},"body":"* fixed some issues that prevented some Skyline tests from executing under Wine\r\n* updated BuildMethod projects to .NET 4\r\n* added bindingRedirect for log4net\r\n* moved FormUtilTest to TestFunctional\r\n\r\nThis is a WIP; I want to see if it passes the Docker tests on TeamCity. If so I will find a way to disable the problematic BadRawFile test and UTF8/Japanese encoding only when running under Wine.","created_at":"2018-10-26T16:51:49Z","updated_at":"2018-10-30T19:48:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b6d7115e7a6fa300cc7e414de4ff582f6497efd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/301/commits","review_comments_url":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/301/comments","review_comment_url":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues/301/comments","statuses_url":"https://api.github.com/repos/ProteoWizard/pwiz/statuses/34bbd6756628bb0bb18ab1e14538c49937afa230","head":{"label":"ProteoWizard:bug/fix-Skyline-for-Wine","ref":"bug/fix-Skyline-for-Wine","sha":"34bbd6756628bb0bb18ab1e14538c49937afa230","user":{"login":"ProteoWizard","id":37312314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzEyMzE0","avatar_url":"https://avatars2.githubusercontent.com/u/37312314?v=4","gravatar_id":"","url":"https://api.github.com/users/ProteoWizard","html_url":"https://github.com/ProteoWizard","followers_url":"https://api.github.com/users/ProteoWizard/followers","following_url":"https://api.github.com/users/ProteoWizard/following{/other_user}","gists_url":"https://api.github.com/users/ProteoWizard/gists{/gist_id}","starred_url":"https://api.github.com/users/ProteoWizard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProteoWizard/subscriptions","organizations_url":"https://api.github.com/users/ProteoWizard/orgs","repos_url":"https://api.github.com/users/ProteoWizard/repos","events_url":"https://api.github.com/users/ProteoWizard/events{/privacy}","received_events_url":"https://api.github.com/users/ProteoWizard/received_events","type":"Organization","site_admin":false},"repo":{"id":124952577,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ5NTI1Nzc=","name":"pwiz","full_name":"ProteoWizard/pwiz","private":false,"owner":{"login":"ProteoWizard","id":37312314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzEyMzE0","avatar_url":"https://avatars2.githubusercontent.com/u/37312314?v=4","gravatar_id":"","url":"https://api.github.com/users/ProteoWizard","html_url":"https://github.com/ProteoWizard","followers_url":"https://api.github.com/users/ProteoWizard/followers","following_url":"https://api.github.com/users/ProteoWizard/following{/other_user}","gists_url":"https://api.github.com/users/ProteoWizard/gists{/gist_id}","starred_url":"https://api.github.com/users/ProteoWizard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProteoWizard/subscriptions","organizations_url":"https://api.github.com/users/ProteoWizard/orgs","repos_url":"https://api.github.com/users/ProteoWizard/repos","events_url":"https://api.github.com/users/ProteoWizard/events{/privacy}","received_events_url":"https://api.github.com/users/ProteoWizard/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ProteoWizard/pwiz","description":"The ProteoWizard Library is a set of software libraries and tools for rapid development of mass spectrometry and proteomic data analysis software. ","fork":false,"url":"https://api.github.com/repos/ProteoWizard/pwiz","forks_url":"https://api.github.com/repos/ProteoWizard/pwiz/forks","keys_url":"https://api.github.com/repos/ProteoWizard/pwiz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProteoWizard/pwiz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProteoWizard/pwiz/teams","hooks_url":"https://api.github.com/repos/ProteoWizard/pwiz/hooks","issue_events_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues/events{/number}","events_url":"https://api.github.com/repos/ProteoWizard/pwiz/events","assignees_url":"https://api.github.com/repos/ProteoWizard/pwiz/assignees{/user}","branches_url":"https://api.github.com/repos/ProteoWizard/pwiz/branches{/branch}","tags_url":"https://api.github.com/repos/ProteoWizard/pwiz/tags","blobs_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProteoWizard/pwiz/statuses/{sha}","languages_url":"https://api.github.com/repos/ProteoWizard/pwiz/languages","stargazers_url":"https://api.github.com/repos/ProteoWizard/pwiz/stargazers","contributors_url":"https://api.github.com/repos/ProteoWizard/pwiz/contributors","subscribers_url":"https://api.github.com/repos/ProteoWizard/pwiz/subscribers","subscription_url":"https://api.github.com/repos/ProteoWizard/pwiz/subscription","commits_url":"https://api.github.com/repos/ProteoWizard/pwiz/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProteoWizard/pwiz/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProteoWizard/pwiz/contents/{+path}","compare_url":"https://api.github.com/repos/ProteoWizard/pwiz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProteoWizard/pwiz/merges","archive_url":"https://api.github.com/repos/ProteoWizard/pwiz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProteoWizard/pwiz/downloads","issues_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues{/number}","pulls_url":"https://api.github.com/repos/ProteoWizard/pwiz/pulls{/number}","milestones_url":"https://api.github.com/repos/ProteoWizard/pwiz/milestones{/number}","notifications_url":"https://api.github.com/repos/ProteoWizard/pwiz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProteoWizard/pwiz/labels{/name}","releases_url":"https://api.github.com/repos/ProteoWizard/pwiz/releases{/id}","deployments_url":"https://api.github.com/repos/ProteoWizard/pwiz/deployments","created_at":"2018-03-12T21:16:01Z","updated_at":"2018-10-30T16:34:56Z","pushed_at":"2018-10-30T19:36:48Z","git_url":"git://github.com/ProteoWizard/pwiz.git","ssh_url":"git@github.com:ProteoWizard/pwiz.git","clone_url":"https://github.com/ProteoWizard/pwiz.git","svn_url":"https://github.com/ProteoWizard/pwiz","homepage":"http://proteowizard.sourceforge.net/","size":2941878,"stargazers_count":32,"watchers_count":32,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":11,"watchers":32,"default_branch":"master"}},"base":{"label":"ProteoWizard:master","ref":"master","sha":"8ea69e03284562e085a79e3b27e95e65a504fcd5","user":{"login":"ProteoWizard","id":37312314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzEyMzE0","avatar_url":"https://avatars2.githubusercontent.com/u/37312314?v=4","gravatar_id":"","url":"https://api.github.com/users/ProteoWizard","html_url":"https://github.com/ProteoWizard","followers_url":"https://api.github.com/users/ProteoWizard/followers","following_url":"https://api.github.com/users/ProteoWizard/following{/other_user}","gists_url":"https://api.github.com/users/ProteoWizard/gists{/gist_id}","starred_url":"https://api.github.com/users/ProteoWizard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProteoWizard/subscriptions","organizations_url":"https://api.github.com/users/ProteoWizard/orgs","repos_url":"https://api.github.com/users/ProteoWizard/repos","events_url":"https://api.github.com/users/ProteoWizard/events{/privacy}","received_events_url":"https://api.github.com/users/ProteoWizard/received_events","type":"Organization","site_admin":false},"repo":{"id":124952577,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ5NTI1Nzc=","name":"pwiz","full_name":"ProteoWizard/pwiz","private":false,"owner":{"login":"ProteoWizard","id":37312314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzEyMzE0","avatar_url":"https://avatars2.githubusercontent.com/u/37312314?v=4","gravatar_id":"","url":"https://api.github.com/users/ProteoWizard","html_url":"https://github.com/ProteoWizard","followers_url":"https://api.github.com/users/ProteoWizard/followers","following_url":"https://api.github.com/users/ProteoWizard/following{/other_user}","gists_url":"https://api.github.com/users/ProteoWizard/gists{/gist_id}","starred_url":"https://api.github.com/users/ProteoWizard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProteoWizard/subscriptions","organizations_url":"https://api.github.com/users/ProteoWizard/orgs","repos_url":"https://api.github.com/users/ProteoWizard/repos","events_url":"https://api.github.com/users/ProteoWizard/events{/privacy}","received_events_url":"https://api.github.com/users/ProteoWizard/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ProteoWizard/pwiz","description":"The ProteoWizard Library is a set of software libraries and tools for rapid development of mass spectrometry and proteomic data analysis software. ","fork":false,"url":"https://api.github.com/repos/ProteoWizard/pwiz","forks_url":"https://api.github.com/repos/ProteoWizard/pwiz/forks","keys_url":"https://api.github.com/repos/ProteoWizard/pwiz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProteoWizard/pwiz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProteoWizard/pwiz/teams","hooks_url":"https://api.github.com/repos/ProteoWizard/pwiz/hooks","issue_events_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues/events{/number}","events_url":"https://api.github.com/repos/ProteoWizard/pwiz/events","assignees_url":"https://api.github.com/repos/ProteoWizard/pwiz/assignees{/user}","branches_url":"https://api.github.com/repos/ProteoWizard/pwiz/branches{/branch}","tags_url":"https://api.github.com/repos/ProteoWizard/pwiz/tags","blobs_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProteoWizard/pwiz/statuses/{sha}","languages_url":"https://api.github.com/repos/ProteoWizard/pwiz/languages","stargazers_url":"https://api.github.com/repos/ProteoWizard/pwiz/stargazers","contributors_url":"https://api.github.com/repos/ProteoWizard/pwiz/contributors","subscribers_url":"https://api.github.com/repos/ProteoWizard/pwiz/subscribers","subscription_url":"https://api.github.com/repos/ProteoWizard/pwiz/subscription","commits_url":"https://api.github.com/repos/ProteoWizard/pwiz/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProteoWizard/pwiz/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProteoWizard/pwiz/contents/{+path}","compare_url":"https://api.github.com/repos/ProteoWizard/pwiz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProteoWizard/pwiz/merges","archive_url":"https://api.github.com/repos/ProteoWizard/pwiz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProteoWizard/pwiz/downloads","issues_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues{/number}","pulls_url":"https://api.github.com/repos/ProteoWizard/pwiz/pulls{/number}","milestones_url":"https://api.github.com/repos/ProteoWizard/pwiz/milestones{/number}","notifications_url":"https://api.github.com/repos/ProteoWizard/pwiz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProteoWizard/pwiz/labels{/name}","releases_url":"https://api.github.com/repos/ProteoWizard/pwiz/releases{/id}","deployments_url":"https://api.github.com/repos/ProteoWizard/pwiz/deployments","created_at":"2018-03-12T21:16:01Z","updated_at":"2018-10-30T16:34:56Z","pushed_at":"2018-10-30T19:36:48Z","git_url":"git://github.com/ProteoWizard/pwiz.git","ssh_url":"git@github.com:ProteoWizard/pwiz.git","clone_url":"https://github.com/ProteoWizard/pwiz.git","svn_url":"https://github.com/ProteoWizard/pwiz","homepage":"http://proteowizard.sourceforge.net/","size":2941878,"stargazers_count":32,"watchers_count":32,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":11,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/301"},"html":{"href":"https://github.com/ProteoWizard/pwiz/pull/301"},"issue":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/issues/301"},"comments":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/issues/301/comments"},"review_comments":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/301/comments"},"review_comment":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/301/commits"},"statuses":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/statuses/34bbd6756628bb0bb18ab1e14538c49937afa230"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"brendanx67"}}