{"action":"created","issue":{"url":"https://api.github.com/repos/tgstation/tgstation/issues/36514","repository_url":"https://api.github.com/repos/tgstation/tgstation","labels_url":"https://api.github.com/repos/tgstation/tgstation/issues/36514/labels{/name}","comments_url":"https://api.github.com/repos/tgstation/tgstation/issues/36514/comments","events_url":"https://api.github.com/repos/tgstation/tgstation/issues/36514/events","html_url":"https://github.com/tgstation/tgstation/pull/36514","id":306282060,"number":36514,"title":"Re-recorded the piano instrument to sound better! (hopefully)","user":{"login":"Polyphynx","id":18168689,"avatar_url":"https://avatars1.githubusercontent.com/u/18168689?v=4","gravatar_id":"","url":"https://api.github.com/users/Polyphynx","html_url":"https://github.com/Polyphynx","followers_url":"https://api.github.com/users/Polyphynx/followers","following_url":"https://api.github.com/users/Polyphynx/following{/other_user}","gists_url":"https://api.github.com/users/Polyphynx/gists{/gist_id}","starred_url":"https://api.github.com/users/Polyphynx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polyphynx/subscriptions","organizations_url":"https://api.github.com/users/Polyphynx/orgs","repos_url":"https://api.github.com/users/Polyphynx/repos","events_url":"https://api.github.com/users/Polyphynx/events{/privacy}","received_events_url":"https://api.github.com/users/Polyphynx/received_events","type":"User","site_admin":false},"labels":[{"id":31458015,"url":"https://api.github.com/repos/tgstation/tgstation/labels/Sound","name":"Sound","color":"f9a4f9","default":false},{"id":373745412,"url":"https://api.github.com/repos/tgstation/tgstation/labels/Tweak","name":"Tweak","color":"e99695","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-03-18T21:01:55Z","updated_at":"2018-03-19T13:08:58Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/36514","html_url":"https://github.com/tgstation/tgstation/pull/36514","diff_url":"https://github.com/tgstation/tgstation/pull/36514.diff","patch_url":"https://github.com/tgstation/tgstation/pull/36514.patch"},"body":":cl: Polyphynx\r\ntweak: The piano now sounds more like a piano!\r\n/:cl:\r\n\r\nThe current notes for the piano sounded a lot like a toy to me, so I went ahead and re-recorded all(most) of the notes on my own piano. There were 8 I didn't record since they're an octave lower than the standard 88-keys... and my piano is just standard. I don't think it's a problem. \r\nOverall, the file size of all the piano notes together is now about 100KB smaller.\r\n\r\nI also removed some (to my knowledge) unused instrument files that were left in the sound folder. \r\n\r\nWas this necessary? Probably not. But here, have some comparisons for your listening pleasure!\r\n\r\n[Comparison 1](https://vocaroo.com/i/s0FnaCMD3EzD)\r\n[Comparison 2](https://vocaroo.com/i/s1De1gABMWKw)\r\nIt starts with the old version, then switches between new and old occasionally.\r\n\r\nFrom my perspective, the old version's notes are a lot more distinct, but sound tinny and end abruptly. While the new version is softer and more natural sounding, but a bit more muddled.  \r\nI made the notes mono @ 16kHz sample rate to keep the file size low. \r\nLet me know what you think. I can easily re-record some more\r\n\r\nEdit: I might as well add an example of just the new recording, with everyone's favorite dwarf song: https://vocaroo.com/i/s1dGpohGXDeV\r\n"},"comment":{"url":"https://api.github.com/repos/tgstation/tgstation/issues/comments/374205443","html_url":"https://github.com/tgstation/tgstation/pull/36514#issuecomment-374205443","issue_url":"https://api.github.com/repos/tgstation/tgstation/issues/36514","id":374205443,"user":{"login":"Iatots","id":5155917,"avatar_url":"https://avatars2.githubusercontent.com/u/5155917?v=4","gravatar_id":"","url":"https://api.github.com/users/Iatots","html_url":"https://github.com/Iatots","followers_url":"https://api.github.com/users/Iatots/followers","following_url":"https://api.github.com/users/Iatots/following{/other_user}","gists_url":"https://api.github.com/users/Iatots/gists{/gist_id}","starred_url":"https://api.github.com/users/Iatots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iatots/subscriptions","organizations_url":"https://api.github.com/users/Iatots/orgs","repos_url":"https://api.github.com/users/Iatots/repos","events_url":"https://api.github.com/users/Iatots/events{/privacy}","received_events_url":"https://api.github.com/users/Iatots/received_events","type":"User","site_admin":false},"created_at":"2018-03-19T13:08:58Z","updated_at":"2018-03-19T13:08:58Z","author_association":"NONE","body":"The normal piano's high pitch reminds me of western saloons, and it's kinda grown on me as a game staple."}}
{"actor":{"display_login":"Iatots"}}