{"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/angular/pulls/comments/173318889","pull_request_review_id":102492015,"id":173318889,"diff_hunk":"@@ -128,3 +131,17 @@ bool isDomRenderDirty() => app_view.domRootRendererIsDirty;\n void resetDomRenderDirty() {\n   app_view.domRootRendererIsDirty = false;\n }\n+\n+class _ThrowingSlowComponentLoader implements SlowComponentLoader {\n+  @override\n+  Future<ComponentRef<T>> load<T>(Type type, Injector injector) {\n+    throw new UnimplementedError('Don\\'t use SlowComponentLoader');","path":"angular/lib/experimental.dart","position":28,"original_position":28,"commit_id":"01356c84407d32e6f323fc37aef396b268a0f7bb","original_commit_id":"01356c84407d32e6f323fc37aef396b268a0f7bb","user":{"login":"TedSander","id":5643740,"avatar_url":"https://avatars1.githubusercontent.com/u/5643740?v=4","gravatar_id":"","url":"https://api.github.com/users/TedSander","html_url":"https://github.com/TedSander","followers_url":"https://api.github.com/users/TedSander/followers","following_url":"https://api.github.com/users/TedSander/following{/other_user}","gists_url":"https://api.github.com/users/TedSander/gists{/gist_id}","starred_url":"https://api.github.com/users/TedSander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TedSander/subscriptions","organizations_url":"https://api.github.com/users/TedSander/orgs","repos_url":"https://api.github.com/users/TedSander/repos","events_url":"https://api.github.com/users/TedSander/events{/privacy}","received_events_url":"https://api.github.com/users/TedSander/received_events","type":"User","site_admin":false},"body":"I don't know if you are going to land this in this CL, but I'd like to see this as a constant since it is used in two places, and also a little more helpful error message.\r\n\r\nProbably too much sass but something like this would be cool:\r\n'You are using the faster, slimmer, improved angular. Sadly that means we don't support loading a component with SlowComponentLoader. Please migrate this code to use ComponentFactories or switch back to the X to continue using SlowComponentLoader if you must.'","created_at":"2018-03-08T22:55:39Z","updated_at":"2018-03-08T23:04:49Z","html_url":"https://github.com/dart-lang/angular/pull/1027#discussion_r173318889","pull_request_url":"https://api.github.com/repos/dart-lang/angular/pulls/1027","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/angular/pulls/comments/173318889"},"html":{"href":"https://github.com/dart-lang/angular/pull/1027#discussion_r173318889"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/angular/pulls/1027"}}},"pull_request":{"url":"https://api.github.com/repos/dart-lang/angular/pulls/1027","id":173316140,"html_url":"https://github.com/dart-lang/angular/pull/1027","diff_url":"https://github.com/dart-lang/angular/pull/1027.diff","patch_url":"https://github.com/dart-lang/angular/pull/1027.patch","issue_url":"https://api.github.com/repos/dart-lang/angular/issues/1027","number":1027,"state":"open","locked":false,"title":"Form example","user":{"login":"alorenzen","id":575967,"avatar_url":"https://avatars0.githubusercontent.com/u/575967?v=4","gravatar_id":"","url":"https://api.github.com/users/alorenzen","html_url":"https://github.com/alorenzen","followers_url":"https://api.github.com/users/alorenzen/followers","following_url":"https://api.github.com/users/alorenzen/following{/other_user}","gists_url":"https://api.github.com/users/alorenzen/gists{/gist_id}","starred_url":"https://api.github.com/users/alorenzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alorenzen/subscriptions","organizations_url":"https://api.github.com/users/alorenzen/orgs","repos_url":"https://api.github.com/users/alorenzen/repos","events_url":"https://api.github.com/users/alorenzen/events{/privacy}","received_events_url":"https://api.github.com/users/alorenzen/received_events","type":"User","site_admin":false},"body":"A simple form example using `angular_components` and `angular_forms`.","created_at":"2018-03-06T23:54:20Z","updated_at":"2018-03-08T23:04:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddf5cd7a5de12dcdd7e88e5fd23636db28adb5e5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":849559023,"url":"https://api.github.com/repos/dart-lang/angular/labels/area:%20examples","name":"area: examples","color":"fad8c7","default":false},{"id":623438033,"url":"https://api.github.com/repos/dart-lang/angular/labels/area:%20forms","name":"area: forms","color":"fad8c7","default":false},{"id":420145781,"url":"https://api.github.com/repos/dart-lang/angular/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dart-lang/angular/pulls/1027/commits","review_comments_url":"https://api.github.com/repos/dart-lang/angular/pulls/1027/comments","review_comment_url":"https://api.github.com/repos/dart-lang/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/angular/issues/1027/comments","statuses_url":"https://api.github.com/repos/dart-lang/angular/statuses/01356c84407d32e6f323fc37aef396b268a0f7bb","head":{"label":"alorenzen:form-example","ref":"form-example","sha":"01356c84407d32e6f323fc37aef396b268a0f7bb","user":{"login":"alorenzen","id":575967,"avatar_url":"https://avatars0.githubusercontent.com/u/575967?v=4","gravatar_id":"","url":"https://api.github.com/users/alorenzen","html_url":"https://github.com/alorenzen","followers_url":"https://api.github.com/users/alorenzen/followers","following_url":"https://api.github.com/users/alorenzen/following{/other_user}","gists_url":"https://api.github.com/users/alorenzen/gists{/gist_id}","starred_url":"https://api.github.com/users/alorenzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alorenzen/subscriptions","organizations_url":"https://api.github.com/users/alorenzen/orgs","repos_url":"https://api.github.com/users/alorenzen/repos","events_url":"https://api.github.com/users/alorenzen/events{/privacy}","received_events_url":"https://api.github.com/users/alorenzen/received_events","type":"User","site_admin":false},"repo":{"id":64188000,"name":"angular","full_name":"alorenzen/angular","owner":{"login":"alorenzen","id":575967,"avatar_url":"https://avatars0.githubusercontent.com/u/575967?v=4","gravatar_id":"","url":"https://api.github.com/users/alorenzen","html_url":"https://github.com/alorenzen","followers_url":"https://api.github.com/users/alorenzen/followers","following_url":"https://api.github.com/users/alorenzen/following{/other_user}","gists_url":"https://api.github.com/users/alorenzen/gists{/gist_id}","starred_url":"https://api.github.com/users/alorenzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alorenzen/subscriptions","organizations_url":"https://api.github.com/users/alorenzen/orgs","repos_url":"https://api.github.com/users/alorenzen/repos","events_url":"https://api.github.com/users/alorenzen/events{/privacy}","received_events_url":"https://api.github.com/users/alorenzen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alorenzen/angular","description":"Angular 2 Dart","fork":true,"url":"https://api.github.com/repos/alorenzen/angular","forks_url":"https://api.github.com/repos/alorenzen/angular/forks","keys_url":"https://api.github.com/repos/alorenzen/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alorenzen/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alorenzen/angular/teams","hooks_url":"https://api.github.com/repos/alorenzen/angular/hooks","issue_events_url":"https://api.github.com/repos/alorenzen/angular/issues/events{/number}","events_url":"https://api.github.com/repos/alorenzen/angular/events","assignees_url":"https://api.github.com/repos/alorenzen/angular/assignees{/user}","branches_url":"https://api.github.com/repos/alorenzen/angular/branches{/branch}","tags_url":"https://api.github.com/repos/alorenzen/angular/tags","blobs_url":"https://api.github.com/repos/alorenzen/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alorenzen/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alorenzen/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/alorenzen/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alorenzen/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/alorenzen/angular/languages","stargazers_url":"https://api.github.com/repos/alorenzen/angular/stargazers","contributors_url":"https://api.github.com/repos/alorenzen/angular/contributors","subscribers_url":"https://api.github.com/repos/alorenzen/angular/subscribers","subscription_url":"https://api.github.com/repos/alorenzen/angular/subscription","commits_url":"https://api.github.com/repos/alorenzen/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/alorenzen/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/alorenzen/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/alorenzen/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/alorenzen/angular/contents/{+path}","compare_url":"https://api.github.com/repos/alorenzen/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alorenzen/angular/merges","archive_url":"https://api.github.com/repos/alorenzen/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alorenzen/angular/downloads","issues_url":"https://api.github.com/repos/alorenzen/angular/issues{/number}","pulls_url":"https://api.github.com/repos/alorenzen/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/alorenzen/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/alorenzen/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alorenzen/angular/labels{/name}","releases_url":"https://api.github.com/repos/alorenzen/angular/releases{/id}","deployments_url":"https://api.github.com/repos/alorenzen/angular/deployments","created_at":"2016-07-26T03:48:52Z","updated_at":"2017-06-29T16:13:32Z","pushed_at":"2018-03-08T22:35:56Z","git_url":"git://github.com/alorenzen/angular.git","ssh_url":"git@github.com:alorenzen/angular.git","clone_url":"https://github.com/alorenzen/angular.git","svn_url":"https://github.com/alorenzen/angular","homepage":"https://pub.dartlang.org/packages/angular2","size":8029,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"55973e674554eda9cb5c646a0d30cba464bcdf83","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":60701086,"name":"angular","full_name":"dart-lang/angular","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/angular","description":"Fast and productive web framework provided by Dart","fork":false,"url":"https://api.github.com/repos/dart-lang/angular","forks_url":"https://api.github.com/repos/dart-lang/angular/forks","keys_url":"https://api.github.com/repos/dart-lang/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/angular/teams","hooks_url":"https://api.github.com/repos/dart-lang/angular/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/angular/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/angular/events","assignees_url":"https://api.github.com/repos/dart-lang/angular/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/angular/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/angular/tags","blobs_url":"https://api.github.com/repos/dart-lang/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/angular/languages","stargazers_url":"https://api.github.com/repos/dart-lang/angular/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/angular/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/angular/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/angular/subscription","commits_url":"https://api.github.com/repos/dart-lang/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/angular/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/angular/merges","archive_url":"https://api.github.com/repos/dart-lang/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/angular/downloads","issues_url":"https://api.github.com/repos/dart-lang/angular/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/angular/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/angular/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/angular/deployments","created_at":"2016-06-08T13:45:10Z","updated_at":"2018-03-08T09:38:55Z","pushed_at":"2018-03-08T22:35:58Z","git_url":"git://github.com/dart-lang/angular.git","ssh_url":"git@github.com:dart-lang/angular.git","clone_url":"https://github.com/dart-lang/angular.git","svn_url":"https://github.com/dart-lang/angular","homepage":"https://pub.dartlang.org/packages/angular","size":7850,"stargazers_count":549,"watchers_count":549,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":89,"mirror_url":null,"archived":false,"open_issues_count":146,"license":null,"forks":89,"open_issues":146,"watchers":549,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/angular/pulls/1027"},"html":{"href":"https://github.com/dart-lang/angular/pull/1027"},"issue":{"href":"https://api.github.com/repos/dart-lang/angular/issues/1027"},"comments":{"href":"https://api.github.com/repos/dart-lang/angular/issues/1027/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/angular/pulls/1027/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/angular/pulls/1027/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/angular/statuses/01356c84407d32e6f323fc37aef396b268a0f7bb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"TedSander"}}