{"action":"created","issue":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/1662","repository_url":"https://api.github.com/repos/nhibernate/nhibernate-core","labels_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/1662/labels{/name}","comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/1662/comments","events_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/1662/events","html_url":"https://github.com/nhibernate/nhibernate-core/pull/1662","id":314030213,"number":1662,"title":"Add support for SAP HANA","user":{"login":"breglerj","id":29888756,"avatar_url":"https://avatars2.githubusercontent.com/u/29888756?v=4","gravatar_id":"","url":"https://api.github.com/users/breglerj","html_url":"https://github.com/breglerj","followers_url":"https://api.github.com/users/breglerj/followers","following_url":"https://api.github.com/users/breglerj/following{/other_user}","gists_url":"https://api.github.com/users/breglerj/gists{/gist_id}","starred_url":"https://api.github.com/users/breglerj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breglerj/subscriptions","organizations_url":"https://api.github.com/users/breglerj/orgs","repos_url":"https://api.github.com/users/breglerj/repos","events_url":"https://api.github.com/users/breglerj/events{/privacy}","received_events_url":"https://api.github.com/users/breglerj/received_events","type":"User","site_admin":false},"labels":[{"id":717851462,"url":"https://api.github.com/repos/nhibernate/nhibernate-core/labels/c:%20DataProviders%20/%20Dialects","name":"c: DataProviders / Dialects","color":"ededed","default":false},{"id":717863290,"url":"https://api.github.com/repos/nhibernate/nhibernate-core/labels/p:%20Minor","name":"p: Minor","color":"f9d0c4","default":false},{"id":661468620,"url":"https://api.github.com/repos/nhibernate/nhibernate-core/labels/t:%20New%20Feature","name":"t: New Feature","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-04-13T09:17:18Z","updated_at":"2018-04-27T14:57:16Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1662","html_url":"https://github.com/nhibernate/nhibernate-core/pull/1662","diff_url":"https://github.com/nhibernate/nhibernate-core/pull/1662.diff","patch_url":"https://github.com/nhibernate/nhibernate-core/pull/1662.patch"},"body":"- add row and column store dialects\r\n- add driver\r\n- add batcher\r\n- add configuration template\r\n- exclude tests that are known not to run on SAP HANA"},"comment":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/comments/384995791","html_url":"https://github.com/nhibernate/nhibernate-core/pull/1662#issuecomment-384995791","issue_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/1662","id":384995791,"user":{"login":"breglerj","id":29888756,"avatar_url":"https://avatars2.githubusercontent.com/u/29888756?v=4","gravatar_id":"","url":"https://api.github.com/users/breglerj","html_url":"https://github.com/breglerj","followers_url":"https://api.github.com/users/breglerj/followers","following_url":"https://api.github.com/users/breglerj/following{/other_user}","gists_url":"https://api.github.com/users/breglerj/gists{/gist_id}","starred_url":"https://api.github.com/users/breglerj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breglerj/subscriptions","organizations_url":"https://api.github.com/users/breglerj/orgs","repos_url":"https://api.github.com/users/breglerj/repos","events_url":"https://api.github.com/users/breglerj/events{/privacy}","received_events_url":"https://api.github.com/users/breglerj/received_events","type":"User","site_admin":false},"created_at":"2018-04-27T14:57:16Z","updated_at":"2018-04-27T14:57:16Z","author_association":"NONE","body":"Here is an update regarding the failing tests:\r\n\r\n> Insertordering.FamilyModel.Fixture.CircularReferences\r\n\r\nThis failure only happens when using the HANA batcher. When using the `NonBatchingBatcher` the test succeeds. My guess is that something needs to be fixed in the HANA data provider. I'm waiting for feedback from the data provider developers.\r\n\r\n> Legacy.FooBarTest:\r\n> - CollectionsInSelect\r\n> - FindByCriteria\r\n> - UpdateFromTransient\r\n\r\n`CollectionsInSelect` passes with the latest commit.\r\n`FindByCriteria` fails because of a HANA bug. This will be fixed in one of the next revisions.\r\n`UpdateFromTransient` fails for the same reason as `Insertordering.FamilyModel.Fixture.CircularReferences`.\r\n\r\n>Linq:\r\n> - PropertyMethodMappingTests.CanExecuteCountInSelectClause\r\n> - SelectionTests.CanSelectWithAggregateSubQuery\r\n\r\nThese tests pass with the latest commit.\r\n\r\n> NH2192.HqlIsThreadsafe_UsingThreads\r\n\r\nThis seems to be a bug in the HANA data provider. I've filed a bug report for this.\r\n\r\n> NH2244.LinqComponentTypeEquality\r\n\r\nI still can't really explain this one. The failure originates in the SqlGenerator. The `PhoneNumberUserType` used in the test returns a column span of 2 which causes an `IEnumerable.Single()` to fail. So far I don't see how this is specific to HANA.\r\n\r\n> NH2394.LinqUserTypeEquality\r\n\r\nSame root cause as `NH2244.LinqComponentTypeEquality`\r\n\r\n> NH280.ConstInSelect\r\n\r\nThis seems to be a bug in the HANA data provider. I've filed a bug report for this.\r\n\r\n> Properties:\r\n> - CompositePropertyRefTest\r\n> - DynamicEntityTest\r\n\r\nThis is most likely a bug in HANA. The error happens when defining foreign key constraints to unique columns involving a `BOOLEAN` column. I've filed a bug report for this.\r\n"}}
{"actor":{"display_login":"breglerj"}}