{"action":"created","issue":{"url":"https://api.github.com/repos/dask/dask-ml/issues/419","repository_url":"https://api.github.com/repos/dask/dask-ml","labels_url":"https://api.github.com/repos/dask/dask-ml/issues/419/labels{/name}","comments_url":"https://api.github.com/repos/dask/dask-ml/issues/419/comments","events_url":"https://api.github.com/repos/dask/dask-ml/issues/419/events","html_url":"https://github.com/dask/dask-ml/pull/419","id":374198317,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1OTU1MDYy","number":419,"title":"BUG: properly store 'param_*' keys in incremental search","user":{"login":"stsievert","id":1320475,"node_id":"MDQ6VXNlcjEzMjA0NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/1320475?v=4","gravatar_id":"","url":"https://api.github.com/users/stsievert","html_url":"https://github.com/stsievert","followers_url":"https://api.github.com/users/stsievert/followers","following_url":"https://api.github.com/users/stsievert/following{/other_user}","gists_url":"https://api.github.com/users/stsievert/gists{/gist_id}","starred_url":"https://api.github.com/users/stsievert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stsievert/subscriptions","organizations_url":"https://api.github.com/users/stsievert/orgs","repos_url":"https://api.github.com/users/stsievert/repos","events_url":"https://api.github.com/users/stsievert/events{/privacy}","received_events_url":"https://api.github.com/users/stsievert/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-26T02:03:30Z","updated_at":"2018-12-28T23:16:54Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dask/dask-ml/pulls/419","html_url":"https://github.com/dask/dask-ml/pull/419","diff_url":"https://github.com/dask/dask-ml/pull/419.diff","patch_url":"https://github.com/dask/dask-ml/pull/419.patch"},"body":"This fixes a bug where each `param_*` key in `cv_results` was being overwritten by previous values.\r\n\r\nA quick illustration of the issue:\r\n\r\n``` python\r\n>>> search = IncrementalSearchCV(..., n_initial_parameters=3)\r\n>>> search.fit(X, y)\r\n>>> search.cv_results_[\"param_alpha\"]\r\narray(0.3)  # expected: array([0.1, 0.2, 0.3]) because 3 model ids\r\n>>> search.cv_results_[\"model_id\"]\r\narray([0, 1, 2])\r\n```\r\n\r\nThere are a couple lines added to cover the case when some parameter sets have different keys. I should probably test that -- I think it's a small but non-negligible corner case."},"comment":{"url":"https://api.github.com/repos/dask/dask-ml/issues/comments/450441831","html_url":"https://github.com/dask/dask-ml/pull/419#issuecomment-450441831","issue_url":"https://api.github.com/repos/dask/dask-ml/issues/419","id":450441831,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDQ0MTgzMQ==","user":{"login":"stsievert","id":1320475,"node_id":"MDQ6VXNlcjEzMjA0NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/1320475?v=4","gravatar_id":"","url":"https://api.github.com/users/stsievert","html_url":"https://github.com/stsievert","followers_url":"https://api.github.com/users/stsievert/followers","following_url":"https://api.github.com/users/stsievert/following{/other_user}","gists_url":"https://api.github.com/users/stsievert/gists{/gist_id}","starred_url":"https://api.github.com/users/stsievert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stsievert/subscriptions","organizations_url":"https://api.github.com/users/stsievert/orgs","repos_url":"https://api.github.com/users/stsievert/repos","events_url":"https://api.github.com/users/stsievert/events{/privacy}","received_events_url":"https://api.github.com/users/stsievert/received_events","type":"User","site_admin":false},"created_at":"2018-12-28T23:16:54Z","updated_at":"2018-12-28T23:16:54Z","author_association":"CONTRIBUTOR","body":"Yup, I expected an array of 3 number, not just a scalar. I've updated https://github.com/dask/dask-ml/pull/419#issue-225955062 to reflect that."}}
{"actor":{"display_login":"stsievert"}}