{"action":"created","issue":{"url":"https://api.github.com/repos/zaps166/QMPlay2/issues/137","repository_url":"https://api.github.com/repos/zaps166/QMPlay2","labels_url":"https://api.github.com/repos/zaps166/QMPlay2/issues/137/labels{/name}","comments_url":"https://api.github.com/repos/zaps166/QMPlay2/issues/137/comments","events_url":"https://api.github.com/repos/zaps166/QMPlay2/issues/137/events","html_url":"https://github.com/zaps166/QMPlay2/issues/137","id":288319848,"number":137,"title":"Weird crash and tentative fix","user":{"login":"RJVB","id":1756884,"avatar_url":"https://avatars0.githubusercontent.com/u/1756884?v=4","gravatar_id":"","url":"https://api.github.com/users/RJVB","html_url":"https://github.com/RJVB","followers_url":"https://api.github.com/users/RJVB/followers","following_url":"https://api.github.com/users/RJVB/following{/other_user}","gists_url":"https://api.github.com/users/RJVB/gists{/gist_id}","starred_url":"https://api.github.com/users/RJVB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RJVB/subscriptions","organizations_url":"https://api.github.com/users/RJVB/orgs","repos_url":"https://api.github.com/users/RJVB/repos","events_url":"https://api.github.com/users/RJVB/events{/privacy}","received_events_url":"https://api.github.com/users/RJVB/received_events","type":"User","site_admin":false},"labels":[{"id":132141474,"url":"https://api.github.com/repos/zaps166/QMPlay2/labels/help%20wanted","name":"help wanted","color":"159818","default":true},{"id":623407908,"url":"https://api.github.com/repos/zaps166/QMPlay2/labels/need%20more%20info","name":"need more info","color":"fb7610","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":20,"created_at":"2018-01-13T10:47:34Z","updated_at":"2018-02-04T20:34:27Z","closed_at":null,"author_association":"NONE","body":"\r\n[more-readable.diff.txt](https://github.com/zaps166/QMPlay2/files/1628240/more-readable.diff.txt)\r\nI've seen a couple of very strange crashes on Mac with the latest version from git, built with clang 5.0.1 .\r\n\r\nI didn't keep backtraces, unfortunately, but the strangeness started under `VideoFilters::clearBuffers()`  when `filtersThr.waitForFinished(true);` behaved like `filtersThr->waitForFinished(true);` with `filtersThr == NULL`.\r\n\r\nAfter staring a bit at the code I noticed this is actually not so very strange because filtersThr is initialised from a dynamically allocated instance.\r\n\r\nI didn't like that extra dereferencing and copying which just might give compilers the idea that they're dealing with a variable on the stack that can go out of scope. So I made the attached change hoping it woud help find where the nullptr came from.\r\n\r\nUntil now that hope hasn't come true: the crash doesn't happen anymore with this patch.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/zaps166/QMPlay2/issues/comments/362937295","html_url":"https://github.com/zaps166/QMPlay2/issues/137#issuecomment-362937295","issue_url":"https://api.github.com/repos/zaps166/QMPlay2/issues/137","id":362937295,"user":{"login":"zaps166","id":6239090,"avatar_url":"https://avatars3.githubusercontent.com/u/6239090?v=4","gravatar_id":"","url":"https://api.github.com/users/zaps166","html_url":"https://github.com/zaps166","followers_url":"https://api.github.com/users/zaps166/followers","following_url":"https://api.github.com/users/zaps166/following{/other_user}","gists_url":"https://api.github.com/users/zaps166/gists{/gist_id}","starred_url":"https://api.github.com/users/zaps166/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaps166/subscriptions","organizations_url":"https://api.github.com/users/zaps166/orgs","repos_url":"https://api.github.com/users/zaps166/repos","events_url":"https://api.github.com/users/zaps166/events{/privacy}","received_events_url":"https://api.github.com/users/zaps166/received_events","type":"User","site_admin":false},"created_at":"2018-02-04T20:34:27Z","updated_at":"2018-02-04T20:34:27Z","author_association":"OWNER","body":"> maybe you modified your build system to generate dylib files since?\r\n\r\nYes, maybe it was modified :) I don't remember, but probably yes.\r\n\r\n> You know better than I how QMPlay2 handles files with the wrong API version.\r\n\r\n`lib.setLoadHints(QLibrary::DeepBindHint);` maybe something is wrong with this (especially on macOS)? QMPlay2 loads a library and then checks for version. I didn't have problems on Linux (yet, not many tests, but it worked when mixing Qt4 and Qt5 libs - it shows error and it worked with another lib IIRC)."}}
{"actor":{"display_login":"zaps166"}}