{"action":"created","issue":{"url":"https://api.github.com/repos/joke2k/faker/issues/835","repository_url":"https://api.github.com/repos/joke2k/faker","labels_url":"https://api.github.com/repos/joke2k/faker/issues/835/labels{/name}","comments_url":"https://api.github.com/repos/joke2k/faker/issues/835/comments","events_url":"https://api.github.com/repos/joke2k/faker/issues/835/events","html_url":"https://github.com/joke2k/faker/pull/835","id":369324870,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjk0NzUz","number":835,"title":"Handle OSError: Closes #829","user":{"login":"BrodyUnderwood1","id":23390514,"node_id":"MDQ6VXNlcjIzMzkwNTE0","avatar_url":"https://avatars0.githubusercontent.com/u/23390514?v=4","gravatar_id":"","url":"https://api.github.com/users/BrodyUnderwood1","html_url":"https://github.com/BrodyUnderwood1","followers_url":"https://api.github.com/users/BrodyUnderwood1/followers","following_url":"https://api.github.com/users/BrodyUnderwood1/following{/other_user}","gists_url":"https://api.github.com/users/BrodyUnderwood1/gists{/gist_id}","starred_url":"https://api.github.com/users/BrodyUnderwood1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrodyUnderwood1/subscriptions","organizations_url":"https://api.github.com/users/BrodyUnderwood1/orgs","repos_url":"https://api.github.com/users/BrodyUnderwood1/repos","events_url":"https://api.github.com/users/BrodyUnderwood1/events{/privacy}","received_events_url":"https://api.github.com/users/BrodyUnderwood1/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-10-11T22:10:31Z","updated_at":"2018-10-17T16:07:36Z","closed_at":"2018-10-16T18:03:03Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/joke2k/faker/pulls/835","html_url":"https://github.com/joke2k/faker/pull/835","diff_url":"https://github.com/joke2k/faker/pull/835.diff","patch_url":"https://github.com/joke2k/faker/pull/835.patch"},"body":"Handles issue #829\r\n\r\n### What does this changes\r\n\r\nfaker/providers/date_time/__init__.py     date_time_between_dates()\r\n\r\n### What was wrong\r\n\r\nWindows unable to handle certain dates outside of range\r\n\r\n### How this fixes it\r\n\r\nReturns new date instead of out of range date.\r\n\r\nFixes #829\r\n"},"comment":{"url":"https://api.github.com/repos/joke2k/faker/issues/comments/430689814","html_url":"https://github.com/joke2k/faker/pull/835#issuecomment-430689814","issue_url":"https://api.github.com/repos/joke2k/faker/issues/835","id":430689814,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDY4OTgxNA==","user":{"login":"kungfu71186","id":421589,"node_id":"MDQ6VXNlcjQyMTU4OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/421589?v=4","gravatar_id":"","url":"https://api.github.com/users/kungfu71186","html_url":"https://github.com/kungfu71186","followers_url":"https://api.github.com/users/kungfu71186/followers","following_url":"https://api.github.com/users/kungfu71186/following{/other_user}","gists_url":"https://api.github.com/users/kungfu71186/gists{/gist_id}","starred_url":"https://api.github.com/users/kungfu71186/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kungfu71186/subscriptions","organizations_url":"https://api.github.com/users/kungfu71186/orgs","repos_url":"https://api.github.com/users/kungfu71186/repos","events_url":"https://api.github.com/users/kungfu71186/events{/privacy}","received_events_url":"https://api.github.com/users/kungfu71186/received_events","type":"User","site_admin":false},"created_at":"2018-10-17T16:07:36Z","updated_at":"2018-10-17T16:07:36Z","author_association":"CONTRIBUTOR","body":"@fcurella Yes, please see #563 for more information. It is a bug in the windows code. \r\n\r\nNow with that said, I do feel like the methods are duplicates of each other. I'd have to test again, but I think you can put in a date or even something like x days.\r\n\r\ndate_time_between and date_time_between_dates are basically the same function and if memory serves me right, these can be used interchangeably. \r\n\r\nFor instance,\r\n\r\n```\r\ndate_time_between(self, start_date='-30y', end_date='now', tzinfo=None):\r\n```\r\nor\r\n\r\n```\r\ndate_time_between(self, start_date=DateTime('1999-02-02 11:42:52'), end_date='now', tzinfo=None):\r\n```\r\nI'd have to test to verify, but I'm pretty sure you can do either or with that same function.\r\n\r\nIf that's the case, I would suggest merging the 2 and just have one call the other or get rid of one completely. But for compatibility with code, we could probably just call the `date_time_between` function from `date_time_between_dates`\r\n\r\n\r\n"}}
{"actor":{"display_login":"kungfu71186"}}