{"action":"closed","number":1040,"pull_request":{"url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/1040","id":235502020,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NTAyMDIw","html_url":"https://github.com/wxWidgets/wxWidgets/pull/1040","diff_url":"https://github.com/wxWidgets/wxWidgets/pull/1040.diff","patch_url":"https://github.com/wxWidgets/wxWidgets/pull/1040.patch","issue_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/1040","number":1040,"state":"closed","locked":false,"title":"Fix wxWindowQt::SetAcceleratorTable() crash","user":{"login":"liamtreacy","id":3380273,"node_id":"MDQ6VXNlcjMzODAyNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/3380273?v=4","gravatar_id":"","url":"https://api.github.com/users/liamtreacy","html_url":"https://github.com/liamtreacy","followers_url":"https://api.github.com/users/liamtreacy/followers","following_url":"https://api.github.com/users/liamtreacy/following{/other_user}","gists_url":"https://api.github.com/users/liamtreacy/gists{/gist_id}","starred_url":"https://api.github.com/users/liamtreacy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liamtreacy/subscriptions","organizations_url":"https://api.github.com/users/liamtreacy/orgs","repos_url":"https://api.github.com/users/liamtreacy/repos","events_url":"https://api.github.com/users/liamtreacy/events{/privacy}","received_events_url":"https://api.github.com/users/liamtreacy/received_events","type":"User","site_admin":false},"body":"The m_qtShortcuts member is initialised to null and this method is the only place it's assigned. So it makes sense to check whether the pointer is valid before deleting, and also this passes an existing (crashing) test.","created_at":"2018-12-03T16:07:08Z","updated_at":"2018-12-05T02:15:30Z","closed_at":"2018-12-05T02:15:30Z","merged_at":null,"merge_commit_sha":"277916deda29352e1e0784ac0967cdf00afeebf1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/1040/commits","review_comments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/1040/comments","review_comment_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/1040/comments","statuses_url":"https://api.github.com/repos/wxWidgets/wxWidgets/statuses/f8d48f83803235f67a815b50f850fd68a88d8a53","head":{"label":"GeoTeric:qt_window_accelerator_keys","ref":"qt_window_accelerator_keys","sha":"f8d48f83803235f67a815b50f850fd68a88d8a53","user":{"login":"GeoTeric","id":44053853,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MDUzODUz","avatar_url":"https://avatars1.githubusercontent.com/u/44053853?v=4","gravatar_id":"","url":"https://api.github.com/users/GeoTeric","html_url":"https://github.com/GeoTeric","followers_url":"https://api.github.com/users/GeoTeric/followers","following_url":"https://api.github.com/users/GeoTeric/following{/other_user}","gists_url":"https://api.github.com/users/GeoTeric/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoTeric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoTeric/subscriptions","organizations_url":"https://api.github.com/users/GeoTeric/orgs","repos_url":"https://api.github.com/users/GeoTeric/repos","events_url":"https://api.github.com/users/GeoTeric/events{/privacy}","received_events_url":"https://api.github.com/users/GeoTeric/received_events","type":"Organization","site_admin":false},"repo":{"id":153249480,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMyNDk0ODA=","name":"wxWidgets","full_name":"GeoTeric/wxWidgets","private":false,"owner":{"login":"GeoTeric","id":44053853,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MDUzODUz","avatar_url":"https://avatars1.githubusercontent.com/u/44053853?v=4","gravatar_id":"","url":"https://api.github.com/users/GeoTeric","html_url":"https://github.com/GeoTeric","followers_url":"https://api.github.com/users/GeoTeric/followers","following_url":"https://api.github.com/users/GeoTeric/following{/other_user}","gists_url":"https://api.github.com/users/GeoTeric/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoTeric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoTeric/subscriptions","organizations_url":"https://api.github.com/users/GeoTeric/orgs","repos_url":"https://api.github.com/users/GeoTeric/repos","events_url":"https://api.github.com/users/GeoTeric/events{/privacy}","received_events_url":"https://api.github.com/users/GeoTeric/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GeoTeric/wxWidgets","description":"Cross-Platform GUI Library - Report issues here: https://trac.wxwidgets.org/","fork":true,"url":"https://api.github.com/repos/GeoTeric/wxWidgets","forks_url":"https://api.github.com/repos/GeoTeric/wxWidgets/forks","keys_url":"https://api.github.com/repos/GeoTeric/wxWidgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GeoTeric/wxWidgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GeoTeric/wxWidgets/teams","hooks_url":"https://api.github.com/repos/GeoTeric/wxWidgets/hooks","issue_events_url":"https://api.github.com/repos/GeoTeric/wxWidgets/issues/events{/number}","events_url":"https://api.github.com/repos/GeoTeric/wxWidgets/events","assignees_url":"https://api.github.com/repos/GeoTeric/wxWidgets/assignees{/user}","branches_url":"https://api.github.com/repos/GeoTeric/wxWidgets/branches{/branch}","tags_url":"https://api.github.com/repos/GeoTeric/wxWidgets/tags","blobs_url":"https://api.github.com/repos/GeoTeric/wxWidgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GeoTeric/wxWidgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GeoTeric/wxWidgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/GeoTeric/wxWidgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GeoTeric/wxWidgets/statuses/{sha}","languages_url":"https://api.github.com/repos/GeoTeric/wxWidgets/languages","stargazers_url":"https://api.github.com/repos/GeoTeric/wxWidgets/stargazers","contributors_url":"https://api.github.com/repos/GeoTeric/wxWidgets/contributors","subscribers_url":"https://api.github.com/repos/GeoTeric/wxWidgets/subscribers","subscription_url":"https://api.github.com/repos/GeoTeric/wxWidgets/subscription","commits_url":"https://api.github.com/repos/GeoTeric/wxWidgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/GeoTeric/wxWidgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/GeoTeric/wxWidgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/GeoTeric/wxWidgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/GeoTeric/wxWidgets/contents/{+path}","compare_url":"https://api.github.com/repos/GeoTeric/wxWidgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GeoTeric/wxWidgets/merges","archive_url":"https://api.github.com/repos/GeoTeric/wxWidgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GeoTeric/wxWidgets/downloads","issues_url":"https://api.github.com/repos/GeoTeric/wxWidgets/issues{/number}","pulls_url":"https://api.github.com/repos/GeoTeric/wxWidgets/pulls{/number}","milestones_url":"https://api.github.com/repos/GeoTeric/wxWidgets/milestones{/number}","notifications_url":"https://api.github.com/repos/GeoTeric/wxWidgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GeoTeric/wxWidgets/labels{/name}","releases_url":"https://api.github.com/repos/GeoTeric/wxWidgets/releases{/id}","deployments_url":"https://api.github.com/repos/GeoTeric/wxWidgets/deployments","created_at":"2018-10-16T08:23:48Z","updated_at":"2018-11-30T10:03:47Z","pushed_at":"2018-12-04T12:04:57Z","git_url":"git://github.com/GeoTeric/wxWidgets.git","ssh_url":"git@github.com:GeoTeric/wxWidgets.git","clone_url":"https://github.com/GeoTeric/wxWidgets.git","svn_url":"https://github.com/GeoTeric/wxWidgets","homepage":"https://www.wxwidgets.org/","size":312264,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"wxWidgets:master","ref":"master","sha":"58f3dcf780400211e7064095f944617c68291a85","user":{"login":"wxWidgets","id":791023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTAyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/791023?v=4","gravatar_id":"","url":"https://api.github.com/users/wxWidgets","html_url":"https://github.com/wxWidgets","followers_url":"https://api.github.com/users/wxWidgets/followers","following_url":"https://api.github.com/users/wxWidgets/following{/other_user}","gists_url":"https://api.github.com/users/wxWidgets/gists{/gist_id}","starred_url":"https://api.github.com/users/wxWidgets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wxWidgets/subscriptions","organizations_url":"https://api.github.com/users/wxWidgets/orgs","repos_url":"https://api.github.com/users/wxWidgets/repos","events_url":"https://api.github.com/users/wxWidgets/events{/privacy}","received_events_url":"https://api.github.com/users/wxWidgets/received_events","type":"Organization","site_admin":false},"repo":{"id":1764646,"node_id":"MDEwOlJlcG9zaXRvcnkxNzY0NjQ2","name":"wxWidgets","full_name":"wxWidgets/wxWidgets","private":false,"owner":{"login":"wxWidgets","id":791023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTAyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/791023?v=4","gravatar_id":"","url":"https://api.github.com/users/wxWidgets","html_url":"https://github.com/wxWidgets","followers_url":"https://api.github.com/users/wxWidgets/followers","following_url":"https://api.github.com/users/wxWidgets/following{/other_user}","gists_url":"https://api.github.com/users/wxWidgets/gists{/gist_id}","starred_url":"https://api.github.com/users/wxWidgets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wxWidgets/subscriptions","organizations_url":"https://api.github.com/users/wxWidgets/orgs","repos_url":"https://api.github.com/users/wxWidgets/repos","events_url":"https://api.github.com/users/wxWidgets/events{/privacy}","received_events_url":"https://api.github.com/users/wxWidgets/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wxWidgets/wxWidgets","description":"Cross-Platform GUI Library - Report issues here: https://trac.wxwidgets.org/","fork":false,"url":"https://api.github.com/repos/wxWidgets/wxWidgets","forks_url":"https://api.github.com/repos/wxWidgets/wxWidgets/forks","keys_url":"https://api.github.com/repos/wxWidgets/wxWidgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wxWidgets/wxWidgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wxWidgets/wxWidgets/teams","hooks_url":"https://api.github.com/repos/wxWidgets/wxWidgets/hooks","issue_events_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/events{/number}","events_url":"https://api.github.com/repos/wxWidgets/wxWidgets/events","assignees_url":"https://api.github.com/repos/wxWidgets/wxWidgets/assignees{/user}","branches_url":"https://api.github.com/repos/wxWidgets/wxWidgets/branches{/branch}","tags_url":"https://api.github.com/repos/wxWidgets/wxWidgets/tags","blobs_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wxWidgets/wxWidgets/statuses/{sha}","languages_url":"https://api.github.com/repos/wxWidgets/wxWidgets/languages","stargazers_url":"https://api.github.com/repos/wxWidgets/wxWidgets/stargazers","contributors_url":"https://api.github.com/repos/wxWidgets/wxWidgets/contributors","subscribers_url":"https://api.github.com/repos/wxWidgets/wxWidgets/subscribers","subscription_url":"https://api.github.com/repos/wxWidgets/wxWidgets/subscription","commits_url":"https://api.github.com/repos/wxWidgets/wxWidgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/wxWidgets/wxWidgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/wxWidgets/wxWidgets/contents/{+path}","compare_url":"https://api.github.com/repos/wxWidgets/wxWidgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wxWidgets/wxWidgets/merges","archive_url":"https://api.github.com/repos/wxWidgets/wxWidgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wxWidgets/wxWidgets/downloads","issues_url":"https://api.github.com/repos/wxWidgets/wxWidgets/issues{/number}","pulls_url":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls{/number}","milestones_url":"https://api.github.com/repos/wxWidgets/wxWidgets/milestones{/number}","notifications_url":"https://api.github.com/repos/wxWidgets/wxWidgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wxWidgets/wxWidgets/labels{/name}","releases_url":"https://api.github.com/repos/wxWidgets/wxWidgets/releases{/id}","deployments_url":"https://api.github.com/repos/wxWidgets/wxWidgets/deployments","created_at":"2011-05-18T05:54:03Z","updated_at":"2018-12-04T20:00:15Z","pushed_at":"2018-12-05T02:15:21Z","git_url":"git://github.com/wxWidgets/wxWidgets.git","ssh_url":"git@github.com:wxWidgets/wxWidgets.git","clone_url":"https://github.com/wxWidgets/wxWidgets.git","svn_url":"https://github.com/wxWidgets/wxWidgets","homepage":"https://www.wxwidgets.org/","size":312553,"stargazers_count":2203,"watchers_count":2203,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":833,"mirror_url":null,"archived":false,"open_issues_count":34,"license":null,"forks":833,"open_issues":34,"watchers":2203,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/1040"},"html":{"href":"https://github.com/wxWidgets/wxWidgets/pull/1040"},"issue":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/1040"},"comments":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/issues/1040/comments"},"review_comments":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/1040/comments"},"review_comment":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/pulls/1040/commits"},"statuses":{"href":"https://api.github.com/repos/wxWidgets/wxWidgets/statuses/f8d48f83803235f67a815b50f850fd68a88d8a53"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":10,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"vadz"}}