{"action":"closed","number":12570,"pull_request":{"url":"https://api.github.com/repos/nextcloud/server/pulls/12570","id":232690151,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNjkwMTUx","html_url":"https://github.com/nextcloud/server/pull/12570","diff_url":"https://github.com/nextcloud/server/pull/12570.diff","patch_url":"https://github.com/nextcloud/server/pull/12570.patch","issue_url":"https://api.github.com/repos/nextcloud/server/issues/12570","number":12570,"state":"closed","locked":false,"title":"Do not show tab headers marked as hidden","user":{"login":"danxuliu","id":26858233,"node_id":"MDQ6VXNlcjI2ODU4MjMz","avatar_url":"https://avatars1.githubusercontent.com/u/26858233?v=4","gravatar_id":"","url":"https://api.github.com/users/danxuliu","html_url":"https://github.com/danxuliu","followers_url":"https://api.github.com/users/danxuliu/followers","following_url":"https://api.github.com/users/danxuliu/following{/other_user}","gists_url":"https://api.github.com/users/danxuliu/gists{/gist_id}","starred_url":"https://api.github.com/users/danxuliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danxuliu/subscriptions","organizations_url":"https://api.github.com/users/danxuliu/orgs","repos_url":"https://api.github.com/users/danxuliu/repos","events_url":"https://api.github.com/users/danxuliu/events{/privacy}","received_events_url":"https://api.github.com/users/danxuliu/received_events","type":"User","site_admin":false},"body":"This pull request fixes a regression introduced in #12180 \r\n\r\n[Tab headers that should not be shown are marked with the `hidden` CSS class](https://github.com/nextcloud/server/blob/838105877c7b426f5c0e75699df096a80198d39c/apps/files/js/detailsview.js#L174-L175). The CSS rules set `display: none` for `.hidden` elements, but as the rules for `.tabHeaders .tabHeader` are more specific than rules for `.hidden` [the `display` property is overriden and ends being `flex`](https://github.com/nextcloud/server/blob/e7d565178131510c5081fe7a54c92d59d4ea13c3/core/css/apps.scss#L796). Therefore, it is necessary to explicitly set a rule for `.tabHeaders .tabHeader.hidden` elements.\r\n\r\n**Before:**\r\n![sidebar-hidden-tab-before](https://user-images.githubusercontent.com/26858233/48848596-9846db00-eda4-11e8-9414-a2a1385369b9.png)\r\n\r\n**After:**\r\n![sidebar-hidden-tab-after](https://user-images.githubusercontent.com/26858233/48848600-9b41cb80-eda4-11e8-90bc-d27f8e8a6770.png)\r\n\r\n@nextcloud/designers\r\n","created_at":"2018-11-21T14:48:02Z","updated_at":"2018-11-21T21:34:44Z","closed_at":"2018-11-21T21:34:43Z","merged_at":"2018-11-21T21:34:43Z","merge_commit_sha":"8c9e78d8b17f72670ba02007e844a3ba6b021c1a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"juliushaertl","id":3404133,"node_id":"MDQ6VXNlcjM0MDQxMzM=","avatar_url":"https://avatars0.githubusercontent.com/u/3404133?v=4","gravatar_id":"","url":"https://api.github.com/users/juliushaertl","html_url":"https://github.com/juliushaertl","followers_url":"https://api.github.com/users/juliushaertl/followers","following_url":"https://api.github.com/users/juliushaertl/following{/other_user}","gists_url":"https://api.github.com/users/juliushaertl/gists{/gist_id}","starred_url":"https://api.github.com/users/juliushaertl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliushaertl/subscriptions","organizations_url":"https://api.github.com/users/juliushaertl/orgs","repos_url":"https://api.github.com/users/juliushaertl/repos","events_url":"https://api.github.com/users/juliushaertl/events{/privacy}","received_events_url":"https://api.github.com/users/juliushaertl/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":389003958,"node_id":"MDU6TGFiZWwzODkwMDM5NTg=","url":"https://api.github.com/repos/nextcloud/server/labels/4.%20to%20release","name":"4. to release","color":"0052cc","default":false},{"id":386379231,"node_id":"MDU6TGFiZWwzODYzNzkyMzE=","url":"https://api.github.com/repos/nextcloud/server/labels/bug","name":"bug","color":"ee0701","default":true},{"id":388630313,"node_id":"MDU6TGFiZWwzODg2MzAzMTM=","url":"https://api.github.com/repos/nextcloud/server/labels/design","name":"design","color":"cc317c","default":false},{"id":476699491,"node_id":"MDU6TGFiZWw0NzY2OTk0OTE=","url":"https://api.github.com/repos/nextcloud/server/labels/regression","name":"regression","color":"ee0701","default":false}],"milestone":{"url":"https://api.github.com/repos/nextcloud/server/milestones/48","html_url":"https://github.com/nextcloud/server/milestone/48","labels_url":"https://api.github.com/repos/nextcloud/server/milestones/48/labels","id":3436010,"node_id":"MDk6TWlsZXN0b25lMzQzNjAxMA==","number":48,"title":"Nextcloud 15","description":"","creator":{"login":"skjnldsv","id":14975046,"node_id":"MDQ6VXNlcjE0OTc1MDQ2","avatar_url":"https://avatars0.githubusercontent.com/u/14975046?v=4","gravatar_id":"","url":"https://api.github.com/users/skjnldsv","html_url":"https://github.com/skjnldsv","followers_url":"https://api.github.com/users/skjnldsv/followers","following_url":"https://api.github.com/users/skjnldsv/following{/other_user}","gists_url":"https://api.github.com/users/skjnldsv/gists{/gist_id}","starred_url":"https://api.github.com/users/skjnldsv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skjnldsv/subscriptions","organizations_url":"https://api.github.com/users/skjnldsv/orgs","repos_url":"https://api.github.com/users/skjnldsv/repos","events_url":"https://api.github.com/users/skjnldsv/events{/privacy}","received_events_url":"https://api.github.com/users/skjnldsv/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":622,"state":"open","created_at":"2018-06-19T13:57:28Z","updated_at":"2018-11-21T21:34:44Z","due_on":"2018-12-06T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/nextcloud/server/pulls/12570/commits","review_comments_url":"https://api.github.com/repos/nextcloud/server/pulls/12570/comments","review_comment_url":"https://api.github.com/repos/nextcloud/server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nextcloud/server/issues/12570/comments","statuses_url":"https://api.github.com/repos/nextcloud/server/statuses/7a57409f7d913a8a9c7d3e31779e4b6266777503","head":{"label":"nextcloud:do-not-show-tab-headers-marked-as-hidden","ref":"do-not-show-tab-headers-marked-as-hidden","sha":"7a57409f7d913a8a9c7d3e31779e4b6266777503","user":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":60243197,"node_id":"MDEwOlJlcG9zaXRvcnk2MDI0MzE5Nw==","name":"server","full_name":"nextcloud/server","private":false,"owner":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nextcloud/server","description":"☁️ Nextcloud server, a safe home for all your data","fork":false,"url":"https://api.github.com/repos/nextcloud/server","forks_url":"https://api.github.com/repos/nextcloud/server/forks","keys_url":"https://api.github.com/repos/nextcloud/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nextcloud/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nextcloud/server/teams","hooks_url":"https://api.github.com/repos/nextcloud/server/hooks","issue_events_url":"https://api.github.com/repos/nextcloud/server/issues/events{/number}","events_url":"https://api.github.com/repos/nextcloud/server/events","assignees_url":"https://api.github.com/repos/nextcloud/server/assignees{/user}","branches_url":"https://api.github.com/repos/nextcloud/server/branches{/branch}","tags_url":"https://api.github.com/repos/nextcloud/server/tags","blobs_url":"https://api.github.com/repos/nextcloud/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nextcloud/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nextcloud/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/nextcloud/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nextcloud/server/statuses/{sha}","languages_url":"https://api.github.com/repos/nextcloud/server/languages","stargazers_url":"https://api.github.com/repos/nextcloud/server/stargazers","contributors_url":"https://api.github.com/repos/nextcloud/server/contributors","subscribers_url":"https://api.github.com/repos/nextcloud/server/subscribers","subscription_url":"https://api.github.com/repos/nextcloud/server/subscription","commits_url":"https://api.github.com/repos/nextcloud/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/nextcloud/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/nextcloud/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/nextcloud/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/nextcloud/server/contents/{+path}","compare_url":"https://api.github.com/repos/nextcloud/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nextcloud/server/merges","archive_url":"https://api.github.com/repos/nextcloud/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nextcloud/server/downloads","issues_url":"https://api.github.com/repos/nextcloud/server/issues{/number}","pulls_url":"https://api.github.com/repos/nextcloud/server/pulls{/number}","milestones_url":"https://api.github.com/repos/nextcloud/server/milestones{/number}","notifications_url":"https://api.github.com/repos/nextcloud/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nextcloud/server/labels{/name}","releases_url":"https://api.github.com/repos/nextcloud/server/releases{/id}","deployments_url":"https://api.github.com/repos/nextcloud/server/deployments","created_at":"2016-06-02T07:44:14Z","updated_at":"2018-11-21T15:39:46Z","pushed_at":"2018-11-21T21:34:43Z","git_url":"git://github.com/nextcloud/server.git","ssh_url":"git@github.com:nextcloud/server.git","clone_url":"https://github.com/nextcloud/server.git","svn_url":"https://github.com/nextcloud/server","homepage":"https://nextcloud.com","size":333988,"stargazers_count":5793,"watchers_count":5793,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1022,"mirror_url":null,"archived":false,"open_issues_count":1595,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1022,"open_issues":1595,"watchers":5793,"default_branch":"master"}},"base":{"label":"nextcloud:master","ref":"master","sha":"b7767a51f140d3f588278f053f3a9e1eb84e4346","user":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"repo":{"id":60243197,"node_id":"MDEwOlJlcG9zaXRvcnk2MDI0MzE5Nw==","name":"server","full_name":"nextcloud/server","private":false,"owner":{"login":"nextcloud","id":19211038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjExMDM4","avatar_url":"https://avatars1.githubusercontent.com/u/19211038?v=4","gravatar_id":"","url":"https://api.github.com/users/nextcloud","html_url":"https://github.com/nextcloud","followers_url":"https://api.github.com/users/nextcloud/followers","following_url":"https://api.github.com/users/nextcloud/following{/other_user}","gists_url":"https://api.github.com/users/nextcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/nextcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextcloud/subscriptions","organizations_url":"https://api.github.com/users/nextcloud/orgs","repos_url":"https://api.github.com/users/nextcloud/repos","events_url":"https://api.github.com/users/nextcloud/events{/privacy}","received_events_url":"https://api.github.com/users/nextcloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nextcloud/server","description":"☁️ Nextcloud server, a safe home for all your data","fork":false,"url":"https://api.github.com/repos/nextcloud/server","forks_url":"https://api.github.com/repos/nextcloud/server/forks","keys_url":"https://api.github.com/repos/nextcloud/server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nextcloud/server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nextcloud/server/teams","hooks_url":"https://api.github.com/repos/nextcloud/server/hooks","issue_events_url":"https://api.github.com/repos/nextcloud/server/issues/events{/number}","events_url":"https://api.github.com/repos/nextcloud/server/events","assignees_url":"https://api.github.com/repos/nextcloud/server/assignees{/user}","branches_url":"https://api.github.com/repos/nextcloud/server/branches{/branch}","tags_url":"https://api.github.com/repos/nextcloud/server/tags","blobs_url":"https://api.github.com/repos/nextcloud/server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nextcloud/server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nextcloud/server/git/refs{/sha}","trees_url":"https://api.github.com/repos/nextcloud/server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nextcloud/server/statuses/{sha}","languages_url":"https://api.github.com/repos/nextcloud/server/languages","stargazers_url":"https://api.github.com/repos/nextcloud/server/stargazers","contributors_url":"https://api.github.com/repos/nextcloud/server/contributors","subscribers_url":"https://api.github.com/repos/nextcloud/server/subscribers","subscription_url":"https://api.github.com/repos/nextcloud/server/subscription","commits_url":"https://api.github.com/repos/nextcloud/server/commits{/sha}","git_commits_url":"https://api.github.com/repos/nextcloud/server/git/commits{/sha}","comments_url":"https://api.github.com/repos/nextcloud/server/comments{/number}","issue_comment_url":"https://api.github.com/repos/nextcloud/server/issues/comments{/number}","contents_url":"https://api.github.com/repos/nextcloud/server/contents/{+path}","compare_url":"https://api.github.com/repos/nextcloud/server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nextcloud/server/merges","archive_url":"https://api.github.com/repos/nextcloud/server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nextcloud/server/downloads","issues_url":"https://api.github.com/repos/nextcloud/server/issues{/number}","pulls_url":"https://api.github.com/repos/nextcloud/server/pulls{/number}","milestones_url":"https://api.github.com/repos/nextcloud/server/milestones{/number}","notifications_url":"https://api.github.com/repos/nextcloud/server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nextcloud/server/labels{/name}","releases_url":"https://api.github.com/repos/nextcloud/server/releases{/id}","deployments_url":"https://api.github.com/repos/nextcloud/server/deployments","created_at":"2016-06-02T07:44:14Z","updated_at":"2018-11-21T15:39:46Z","pushed_at":"2018-11-21T21:34:43Z","git_url":"git://github.com/nextcloud/server.git","ssh_url":"git@github.com:nextcloud/server.git","clone_url":"https://github.com/nextcloud/server.git","svn_url":"https://github.com/nextcloud/server","homepage":"https://nextcloud.com","size":333988,"stargazers_count":5793,"watchers_count":5793,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1022,"mirror_url":null,"archived":false,"open_issues_count":1595,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1022,"open_issues":1595,"watchers":5793,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nextcloud/server/pulls/12570"},"html":{"href":"https://github.com/nextcloud/server/pull/12570"},"issue":{"href":"https://api.github.com/repos/nextcloud/server/issues/12570"},"comments":{"href":"https://api.github.com/repos/nextcloud/server/issues/12570/comments"},"review_comments":{"href":"https://api.github.com/repos/nextcloud/server/pulls/12570/comments"},"review_comment":{"href":"https://api.github.com/repos/nextcloud/server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nextcloud/server/pulls/12570/commits"},"statuses":{"href":"https://api.github.com/repos/nextcloud/server/statuses/7a57409f7d913a8a9c7d3e31779e4b6266777503"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rullzer","id":45821,"node_id":"MDQ6VXNlcjQ1ODIx","avatar_url":"https://avatars2.githubusercontent.com/u/45821?v=4","gravatar_id":"","url":"https://api.github.com/users/rullzer","html_url":"https://github.com/rullzer","followers_url":"https://api.github.com/users/rullzer/followers","following_url":"https://api.github.com/users/rullzer/following{/other_user}","gists_url":"https://api.github.com/users/rullzer/gists{/gist_id}","starred_url":"https://api.github.com/users/rullzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rullzer/subscriptions","organizations_url":"https://api.github.com/users/rullzer/orgs","repos_url":"https://api.github.com/users/rullzer/repos","events_url":"https://api.github.com/users/rullzer/events{/privacy}","received_events_url":"https://api.github.com/users/rullzer/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"rullzer"}}