{"action":"created","comment":{"url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/comments/193757840","pull_request_review_id":126794535,"id":193757840,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mzc1Nzg0MA==","diff_hunk":"@@ -374,6 +371,40 @@ def add_css_file(self, filename, **kwargs):\n \n         self.css_files.append(Stylesheet(filename, **kwargs))  # type: ignore\n \n+    def init_js_files(self):\n+        # type: () -> None\n+        self.add_js_file('jquery.js')\n+        self.add_js_file('underscore.js')\n+        self.add_js_file('doctools.js')\n+\n+        for filename, attributes in self.app.registry.js_files:\n+            self.add_js_file(filename, **attributes)\n+\n+        for entry in self.get_builder_config('js_files', 'html'):\n+            if isinstance(entry, string_types):","path":"sphinx/builders/html.py","position":53,"original_position":53,"commit_id":"541b6fa2b22a6f4c2bd55dce485a2535c22c5913","original_commit_id":"541b6fa2b22a6f4c2bd55dce485a2535c22c5913","user":{"login":"tk0miya","id":748828,"node_id":"MDQ6VXNlcjc0ODgyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/748828?v=4","gravatar_id":"","url":"https://api.github.com/users/tk0miya","html_url":"https://github.com/tk0miya","followers_url":"https://api.github.com/users/tk0miya/followers","following_url":"https://api.github.com/users/tk0miya/following{/other_user}","gists_url":"https://api.github.com/users/tk0miya/gists{/gist_id}","starred_url":"https://api.github.com/users/tk0miya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tk0miya/subscriptions","organizations_url":"https://api.github.com/users/tk0miya/orgs","repos_url":"https://api.github.com/users/tk0miya/repos","events_url":"https://api.github.com/users/tk0miya/events{/privacy}","received_events_url":"https://api.github.com/users/tk0miya/received_events","type":"User","site_admin":false},"body":"This conversion should be moved config-inited event like `html_css_files`","created_at":"2018-06-07T14:02:55Z","updated_at":"2018-06-07T14:03:04Z","html_url":"https://github.com/sphinx-doc/sphinx/pull/5034#discussion_r193757840","pull_request_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/5034","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/comments/193757840"},"html":{"href":"https://github.com/sphinx-doc/sphinx/pull/5034#discussion_r193757840"},"pull_request":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/5034"}}},"pull_request":{"url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/5034","id":192179660,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMTc5NjYw","html_url":"https://github.com/sphinx-doc/sphinx/pull/5034","diff_url":"https://github.com/sphinx-doc/sphinx/pull/5034.diff","patch_url":"https://github.com/sphinx-doc/sphinx/pull/5034.patch","issue_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/5034","number":5034,"state":"open","locked":false,"title":"Add :confval:`html_js_files`","user":{"login":"tk0miya","id":748828,"node_id":"MDQ6VXNlcjc0ODgyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/748828?v=4","gravatar_id":"","url":"https://api.github.com/users/tk0miya","html_url":"https://github.com/tk0miya","followers_url":"https://api.github.com/users/tk0miya/followers","following_url":"https://api.github.com/users/tk0miya/following{/other_user}","gists_url":"https://api.github.com/users/tk0miya/gists{/gist_id}","starred_url":"https://api.github.com/users/tk0miya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tk0miya/subscriptions","organizations_url":"https://api.github.com/users/tk0miya/orgs","repos_url":"https://api.github.com/users/tk0miya/repos","events_url":"https://api.github.com/users/tk0miya/events{/privacy}","received_events_url":"https://api.github.com/users/tk0miya/received_events","type":"User","site_admin":false},"body":"### Feature or Bugfix\r\n- Feature\r\n\r\n### Purpose\r\n- Add new confval `html_js_files` to add user JS files through configuration (like `html_css_files`)\r\n","created_at":"2018-06-02T04:49:19Z","updated_at":"2018-06-07T14:03:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff6b3623224489a5f895374aaa5386c3239a2e59","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":162618661,"node_id":"MDU6TGFiZWwxNjI2MTg2NjE=","url":"https://api.github.com/repos/sphinx-doc/sphinx/labels/config","name":"config","color":"FFFFFF","default":false},{"id":162415728,"node_id":"MDU6TGFiZWwxNjI0MTU3Mjg=","url":"https://api.github.com/repos/sphinx-doc/sphinx/labels/html","name":"html","color":"FFFFFF","default":false},{"id":162429779,"node_id":"MDU6TGFiZWwxNjI0Mjk3Nzk=","url":"https://api.github.com/repos/sphinx-doc/sphinx/labels/proposal","name":"proposal","color":"207de5","default":false}],"milestone":{"url":"https://api.github.com/repos/sphinx-doc/sphinx/milestones/40","html_url":"https://github.com/sphinx-doc/sphinx/milestone/40","labels_url":"https://api.github.com/repos/sphinx-doc/sphinx/milestones/40/labels","id":3001856,"node_id":"MDk6TWlsZXN0b25lMzAwMTg1Ng==","number":40,"title":"1.8.0","description":"Not planned yet","creator":{"login":"tk0miya","id":748828,"node_id":"MDQ6VXNlcjc0ODgyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/748828?v=4","gravatar_id":"","url":"https://api.github.com/users/tk0miya","html_url":"https://github.com/tk0miya","followers_url":"https://api.github.com/users/tk0miya/followers","following_url":"https://api.github.com/users/tk0miya/following{/other_user}","gists_url":"https://api.github.com/users/tk0miya/gists{/gist_id}","starred_url":"https://api.github.com/users/tk0miya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tk0miya/subscriptions","organizations_url":"https://api.github.com/users/tk0miya/orgs","repos_url":"https://api.github.com/users/tk0miya/repos","events_url":"https://api.github.com/users/tk0miya/events{/privacy}","received_events_url":"https://api.github.com/users/tk0miya/received_events","type":"User","site_admin":false},"open_issues":93,"closed_issues":122,"state":"open","created_at":"2017-12-28T16:19:27Z","updated_at":"2018-06-07T05:55:05Z","due_on":"2018-09-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/5034/commits","review_comments_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/5034/comments","review_comment_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/5034/comments","statuses_url":"https://api.github.com/repos/sphinx-doc/sphinx/statuses/541b6fa2b22a6f4c2bd55dce485a2535c22c5913","head":{"label":"tk0miya:add_html_js_files","ref":"add_html_js_files","sha":"541b6fa2b22a6f4c2bd55dce485a2535c22c5913","user":{"login":"tk0miya","id":748828,"node_id":"MDQ6VXNlcjc0ODgyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/748828?v=4","gravatar_id":"","url":"https://api.github.com/users/tk0miya","html_url":"https://github.com/tk0miya","followers_url":"https://api.github.com/users/tk0miya/followers","following_url":"https://api.github.com/users/tk0miya/following{/other_user}","gists_url":"https://api.github.com/users/tk0miya/gists{/gist_id}","starred_url":"https://api.github.com/users/tk0miya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tk0miya/subscriptions","organizations_url":"https://api.github.com/users/tk0miya/orgs","repos_url":"https://api.github.com/users/tk0miya/repos","events_url":"https://api.github.com/users/tk0miya/events{/privacy}","received_events_url":"https://api.github.com/users/tk0miya/received_events","type":"User","site_admin":false},"repo":{"id":48524066,"node_id":"MDEwOlJlcG9zaXRvcnk0ODUyNDA2Ng==","name":"sphinx","full_name":"tk0miya/sphinx","owner":{"login":"tk0miya","id":748828,"node_id":"MDQ6VXNlcjc0ODgyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/748828?v=4","gravatar_id":"","url":"https://api.github.com/users/tk0miya","html_url":"https://github.com/tk0miya","followers_url":"https://api.github.com/users/tk0miya/followers","following_url":"https://api.github.com/users/tk0miya/following{/other_user}","gists_url":"https://api.github.com/users/tk0miya/gists{/gist_id}","starred_url":"https://api.github.com/users/tk0miya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tk0miya/subscriptions","organizations_url":"https://api.github.com/users/tk0miya/orgs","repos_url":"https://api.github.com/users/tk0miya/repos","events_url":"https://api.github.com/users/tk0miya/events{/privacy}","received_events_url":"https://api.github.com/users/tk0miya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tk0miya/sphinx","description":"Main repository for the Sphinx documentation builder","fork":true,"url":"https://api.github.com/repos/tk0miya/sphinx","forks_url":"https://api.github.com/repos/tk0miya/sphinx/forks","keys_url":"https://api.github.com/repos/tk0miya/sphinx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tk0miya/sphinx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tk0miya/sphinx/teams","hooks_url":"https://api.github.com/repos/tk0miya/sphinx/hooks","issue_events_url":"https://api.github.com/repos/tk0miya/sphinx/issues/events{/number}","events_url":"https://api.github.com/repos/tk0miya/sphinx/events","assignees_url":"https://api.github.com/repos/tk0miya/sphinx/assignees{/user}","branches_url":"https://api.github.com/repos/tk0miya/sphinx/branches{/branch}","tags_url":"https://api.github.com/repos/tk0miya/sphinx/tags","blobs_url":"https://api.github.com/repos/tk0miya/sphinx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tk0miya/sphinx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tk0miya/sphinx/git/refs{/sha}","trees_url":"https://api.github.com/repos/tk0miya/sphinx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tk0miya/sphinx/statuses/{sha}","languages_url":"https://api.github.com/repos/tk0miya/sphinx/languages","stargazers_url":"https://api.github.com/repos/tk0miya/sphinx/stargazers","contributors_url":"https://api.github.com/repos/tk0miya/sphinx/contributors","subscribers_url":"https://api.github.com/repos/tk0miya/sphinx/subscribers","subscription_url":"https://api.github.com/repos/tk0miya/sphinx/subscription","commits_url":"https://api.github.com/repos/tk0miya/sphinx/commits{/sha}","git_commits_url":"https://api.github.com/repos/tk0miya/sphinx/git/commits{/sha}","comments_url":"https://api.github.com/repos/tk0miya/sphinx/comments{/number}","issue_comment_url":"https://api.github.com/repos/tk0miya/sphinx/issues/comments{/number}","contents_url":"https://api.github.com/repos/tk0miya/sphinx/contents/{+path}","compare_url":"https://api.github.com/repos/tk0miya/sphinx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tk0miya/sphinx/merges","archive_url":"https://api.github.com/repos/tk0miya/sphinx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tk0miya/sphinx/downloads","issues_url":"https://api.github.com/repos/tk0miya/sphinx/issues{/number}","pulls_url":"https://api.github.com/repos/tk0miya/sphinx/pulls{/number}","milestones_url":"https://api.github.com/repos/tk0miya/sphinx/milestones{/number}","notifications_url":"https://api.github.com/repos/tk0miya/sphinx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tk0miya/sphinx/labels{/name}","releases_url":"https://api.github.com/repos/tk0miya/sphinx/releases{/id}","deployments_url":"https://api.github.com/repos/tk0miya/sphinx/deployments","created_at":"2015-12-24T04:03:04Z","updated_at":"2016-06-03T13:54:25Z","pushed_at":"2018-06-07T13:34:57Z","git_url":"git://github.com/tk0miya/sphinx.git","ssh_url":"git@github.com:tk0miya/sphinx.git","clone_url":"https://github.com/tk0miya/sphinx.git","svn_url":"https://github.com/tk0miya/sphinx","homepage":"http://sphinx-doc.org","size":27644,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sphinx-doc:master","ref":"master","sha":"f9e2a41a48d7ce7cf9e780bac2847c0d6d8d78f4","user":{"login":"sphinx-doc","id":9928167,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MjgxNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/9928167?v=4","gravatar_id":"","url":"https://api.github.com/users/sphinx-doc","html_url":"https://github.com/sphinx-doc","followers_url":"https://api.github.com/users/sphinx-doc/followers","following_url":"https://api.github.com/users/sphinx-doc/following{/other_user}","gists_url":"https://api.github.com/users/sphinx-doc/gists{/gist_id}","starred_url":"https://api.github.com/users/sphinx-doc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphinx-doc/subscriptions","organizations_url":"https://api.github.com/users/sphinx-doc/orgs","repos_url":"https://api.github.com/users/sphinx-doc/repos","events_url":"https://api.github.com/users/sphinx-doc/events{/privacy}","received_events_url":"https://api.github.com/users/sphinx-doc/received_events","type":"Organization","site_admin":false},"repo":{"id":28710753,"node_id":"MDEwOlJlcG9zaXRvcnkyODcxMDc1Mw==","name":"sphinx","full_name":"sphinx-doc/sphinx","owner":{"login":"sphinx-doc","id":9928167,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MjgxNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/9928167?v=4","gravatar_id":"","url":"https://api.github.com/users/sphinx-doc","html_url":"https://github.com/sphinx-doc","followers_url":"https://api.github.com/users/sphinx-doc/followers","following_url":"https://api.github.com/users/sphinx-doc/following{/other_user}","gists_url":"https://api.github.com/users/sphinx-doc/gists{/gist_id}","starred_url":"https://api.github.com/users/sphinx-doc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphinx-doc/subscriptions","organizations_url":"https://api.github.com/users/sphinx-doc/orgs","repos_url":"https://api.github.com/users/sphinx-doc/repos","events_url":"https://api.github.com/users/sphinx-doc/events{/privacy}","received_events_url":"https://api.github.com/users/sphinx-doc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sphinx-doc/sphinx","description":"Main repository for the Sphinx documentation builder","fork":false,"url":"https://api.github.com/repos/sphinx-doc/sphinx","forks_url":"https://api.github.com/repos/sphinx-doc/sphinx/forks","keys_url":"https://api.github.com/repos/sphinx-doc/sphinx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sphinx-doc/sphinx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sphinx-doc/sphinx/teams","hooks_url":"https://api.github.com/repos/sphinx-doc/sphinx/hooks","issue_events_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/events{/number}","events_url":"https://api.github.com/repos/sphinx-doc/sphinx/events","assignees_url":"https://api.github.com/repos/sphinx-doc/sphinx/assignees{/user}","branches_url":"https://api.github.com/repos/sphinx-doc/sphinx/branches{/branch}","tags_url":"https://api.github.com/repos/sphinx-doc/sphinx/tags","blobs_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/refs{/sha}","trees_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sphinx-doc/sphinx/statuses/{sha}","languages_url":"https://api.github.com/repos/sphinx-doc/sphinx/languages","stargazers_url":"https://api.github.com/repos/sphinx-doc/sphinx/stargazers","contributors_url":"https://api.github.com/repos/sphinx-doc/sphinx/contributors","subscribers_url":"https://api.github.com/repos/sphinx-doc/sphinx/subscribers","subscription_url":"https://api.github.com/repos/sphinx-doc/sphinx/subscription","commits_url":"https://api.github.com/repos/sphinx-doc/sphinx/commits{/sha}","git_commits_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/commits{/sha}","comments_url":"https://api.github.com/repos/sphinx-doc/sphinx/comments{/number}","issue_comment_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/comments{/number}","contents_url":"https://api.github.com/repos/sphinx-doc/sphinx/contents/{+path}","compare_url":"https://api.github.com/repos/sphinx-doc/sphinx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sphinx-doc/sphinx/merges","archive_url":"https://api.github.com/repos/sphinx-doc/sphinx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sphinx-doc/sphinx/downloads","issues_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues{/number}","pulls_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls{/number}","milestones_url":"https://api.github.com/repos/sphinx-doc/sphinx/milestones{/number}","notifications_url":"https://api.github.com/repos/sphinx-doc/sphinx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sphinx-doc/sphinx/labels{/name}","releases_url":"https://api.github.com/repos/sphinx-doc/sphinx/releases{/id}","deployments_url":"https://api.github.com/repos/sphinx-doc/sphinx/deployments","created_at":"2015-01-02T10:53:28Z","updated_at":"2018-06-07T03:22:06Z","pushed_at":"2018-06-07T13:34:53Z","git_url":"git://github.com/sphinx-doc/sphinx.git","ssh_url":"git@github.com:sphinx-doc/sphinx.git","clone_url":"https://github.com/sphinx-doc/sphinx.git","svn_url":"https://github.com/sphinx-doc/sphinx","homepage":"http://sphinx-doc.org","size":29842,"stargazers_count":1924,"watchers_count":1924,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":807,"mirror_url":null,"archived":false,"open_issues_count":686,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":807,"open_issues":686,"watchers":1924,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/5034"},"html":{"href":"https://github.com/sphinx-doc/sphinx/pull/5034"},"issue":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/issues/5034"},"comments":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/issues/5034/comments"},"review_comments":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/5034/comments"},"review_comment":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/5034/commits"},"statuses":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/statuses/541b6fa2b22a6f4c2bd55dce485a2535c22c5913"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tk0miya"}}