{"action":"created","comment":{"url":"https://api.github.com/repos/openshmem-org/specification/pulls/comments/166297628","pull_request_review_id":94342727,"id":166297628,"diff_hunk":"@@ -28,14 +28,19 @@\n     The \\FUNC{shmem\\_malloc} routine returns a pointer to a block of at least\n     \\VAR{size} bytes suitably aligned for any use.  This space is allocated from the\n     symmetric heap (in contrast to \\FUNC{malloc}, which allocates from the private\n-    heap).\n+    heap).  When \\VAR{size} is zero, the \\FUNC{shmem\\_malloc} routine performs\n+    no action and returns a null pointer.\n     \n     The \\FUNC{shmem\\_align} routine allocates a block in the symmetric heap that has\n-    a byte alignment specified by the \\VAR{alignment} argument.\n+    a byte alignment specified by the \\VAR{alignment} argument.  The value of\n+    \\VAR{alignment} shall be a multiple of \\CONST{sizeof(void *)}, that is also","path":"content/shmem_malloc.tex","position":22,"original_position":22,"commit_id":"b24a3880090423c36c2bc427c3f1a5be26137afd","original_commit_id":"b24a3880090423c36c2bc427c3f1a5be26137afd","user":{"login":"nspark","id":2961664,"avatar_url":"https://avatars3.githubusercontent.com/u/2961664?v=4","gravatar_id":"","url":"https://api.github.com/users/nspark","html_url":"https://github.com/nspark","followers_url":"https://api.github.com/users/nspark/followers","following_url":"https://api.github.com/users/nspark/following{/other_user}","gists_url":"https://api.github.com/users/nspark/gists{/gist_id}","starred_url":"https://api.github.com/users/nspark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nspark/subscriptions","organizations_url":"https://api.github.com/users/nspark/orgs","repos_url":"https://api.github.com/users/nspark/repos","events_url":"https://api.github.com/users/nspark/events{/privacy}","received_events_url":"https://api.github.com/users/nspark/received_events","type":"User","site_admin":false},"body":"Can you remove the comma? Then it will read:\r\n\r\n> The value of `alignment` shall be a multiple of `sizeof(void *)` that is also a power of two.\r\n\r\nWith the comma, it seems _possible_ that one could read the sentence as if it said:\r\n\r\n> The value of `alignment` shall be a multiple of `sizeof(void *)`; that is, also a power of two.\r\n\r\nwhich would not be correct.","created_at":"2018-02-06T13:33:08Z","updated_at":"2018-02-06T13:33:08Z","html_url":"https://github.com/openshmem-org/specification/pull/201#discussion_r166297628","pull_request_url":"https://api.github.com/repos/openshmem-org/specification/pulls/201","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshmem-org/specification/pulls/comments/166297628"},"html":{"href":"https://github.com/openshmem-org/specification/pull/201#discussion_r166297628"},"pull_request":{"href":"https://api.github.com/repos/openshmem-org/specification/pulls/201"}}},"pull_request":{"url":"https://api.github.com/repos/openshmem-org/specification/pulls/201","id":167274092,"html_url":"https://github.com/openshmem-org/specification/pull/201","diff_url":"https://github.com/openshmem-org/specification/pull/201.diff","patch_url":"https://github.com/openshmem-org/specification/pull/201.patch","issue_url":"https://api.github.com/repos/openshmem-org/specification/issues/201","number":201,"state":"open","locked":false,"title":"Symmetric Heap: Clarify size and alignment semantics","user":{"login":"jdinan","id":3397618,"avatar_url":"https://avatars1.githubusercontent.com/u/3397618?v=4","gravatar_id":"","url":"https://api.github.com/users/jdinan","html_url":"https://github.com/jdinan","followers_url":"https://api.github.com/users/jdinan/followers","following_url":"https://api.github.com/users/jdinan/following{/other_user}","gists_url":"https://api.github.com/users/jdinan/gists{/gist_id}","starred_url":"https://api.github.com/users/jdinan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdinan/subscriptions","organizations_url":"https://api.github.com/users/jdinan/orgs","repos_url":"https://api.github.com/users/jdinan/repos","events_url":"https://api.github.com/users/jdinan/events{/privacy}","received_events_url":"https://api.github.com/users/jdinan/received_events","type":"User","site_admin":false},"body":"In symmetric heap management routines, clarify requirements on size and alignment arguments and resulting behavior.\r\n\r\n * a `size` of zero results in no action and returns a null pointer\r\n * `alignment` must be a power-of-two multiple of `sizeof(void*)` or behavior is undefined\r\n * symmetric heap management routines that perform no action also perform no barriers\r\n\r\nCloses #76 \r\nCloses #78","created_at":"2018-02-05T22:39:26Z","updated_at":"2018-02-06T13:33:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3977c30fb334e8393a8be3db1198803f12ae9c73","assignee":{"login":"jdinan","id":3397618,"avatar_url":"https://avatars1.githubusercontent.com/u/3397618?v=4","gravatar_id":"","url":"https://api.github.com/users/jdinan","html_url":"https://github.com/jdinan","followers_url":"https://api.github.com/users/jdinan/followers","following_url":"https://api.github.com/users/jdinan/following{/other_user}","gists_url":"https://api.github.com/users/jdinan/gists{/gist_id}","starred_url":"https://api.github.com/users/jdinan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdinan/subscriptions","organizations_url":"https://api.github.com/users/jdinan/orgs","repos_url":"https://api.github.com/users/jdinan/repos","events_url":"https://api.github.com/users/jdinan/events{/privacy}","received_events_url":"https://api.github.com/users/jdinan/received_events","type":"User","site_admin":false},"assignees":[{"login":"jdinan","id":3397618,"avatar_url":"https://avatars1.githubusercontent.com/u/3397618?v=4","gravatar_id":"","url":"https://api.github.com/users/jdinan","html_url":"https://github.com/jdinan","followers_url":"https://api.github.com/users/jdinan/followers","following_url":"https://api.github.com/users/jdinan/following{/other_user}","gists_url":"https://api.github.com/users/jdinan/gists{/gist_id}","starred_url":"https://api.github.com/users/jdinan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdinan/subscriptions","organizations_url":"https://api.github.com/users/jdinan/orgs","repos_url":"https://api.github.com/users/jdinan/repos","events_url":"https://api.github.com/users/jdinan/events{/privacy}","received_events_url":"https://api.github.com/users/jdinan/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":{"url":"https://api.github.com/repos/openshmem-org/specification/milestones/2","html_url":"https://github.com/openshmem-org/specification/milestone/2","labels_url":"https://api.github.com/repos/openshmem-org/specification/milestones/2/labels","id":2750863,"number":2,"title":"OpenSHMEM 1.5","description":"","creator":{"login":"jdinan","id":3397618,"avatar_url":"https://avatars1.githubusercontent.com/u/3397618?v=4","gravatar_id":"","url":"https://api.github.com/users/jdinan","html_url":"https://github.com/jdinan","followers_url":"https://api.github.com/users/jdinan/followers","following_url":"https://api.github.com/users/jdinan/following{/other_user}","gists_url":"https://api.github.com/users/jdinan/gists{/gist_id}","starred_url":"https://api.github.com/users/jdinan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdinan/subscriptions","organizations_url":"https://api.github.com/users/jdinan/orgs","repos_url":"https://api.github.com/users/jdinan/repos","events_url":"https://api.github.com/users/jdinan/events{/privacy}","received_events_url":"https://api.github.com/users/jdinan/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":3,"state":"open","created_at":"2017-09-07T15:30:03Z","updated_at":"2018-02-06T01:16:33Z","due_on":"2018-11-05T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/openshmem-org/specification/pulls/201/commits","review_comments_url":"https://api.github.com/repos/openshmem-org/specification/pulls/201/comments","review_comment_url":"https://api.github.com/repos/openshmem-org/specification/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshmem-org/specification/issues/201/comments","statuses_url":"https://api.github.com/repos/openshmem-org/specification/statuses/b24a3880090423c36c2bc427c3f1a5be26137afd","head":{"label":"jdinan:pr/memalign","ref":"pr/memalign","sha":"b24a3880090423c36c2bc427c3f1a5be26137afd","user":{"login":"jdinan","id":3397618,"avatar_url":"https://avatars1.githubusercontent.com/u/3397618?v=4","gravatar_id":"","url":"https://api.github.com/users/jdinan","html_url":"https://github.com/jdinan","followers_url":"https://api.github.com/users/jdinan/followers","following_url":"https://api.github.com/users/jdinan/following{/other_user}","gists_url":"https://api.github.com/users/jdinan/gists{/gist_id}","starred_url":"https://api.github.com/users/jdinan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdinan/subscriptions","organizations_url":"https://api.github.com/users/jdinan/orgs","repos_url":"https://api.github.com/users/jdinan/repos","events_url":"https://api.github.com/users/jdinan/events{/privacy}","received_events_url":"https://api.github.com/users/jdinan/received_events","type":"User","site_admin":false},"repo":{"id":60200994,"name":"specification","full_name":"jdinan/specification","owner":{"login":"jdinan","id":3397618,"avatar_url":"https://avatars1.githubusercontent.com/u/3397618?v=4","gravatar_id":"","url":"https://api.github.com/users/jdinan","html_url":"https://github.com/jdinan","followers_url":"https://api.github.com/users/jdinan/followers","following_url":"https://api.github.com/users/jdinan/following{/other_user}","gists_url":"https://api.github.com/users/jdinan/gists{/gist_id}","starred_url":"https://api.github.com/users/jdinan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdinan/subscriptions","organizations_url":"https://api.github.com/users/jdinan/orgs","repos_url":"https://api.github.com/users/jdinan/repos","events_url":"https://api.github.com/users/jdinan/events{/privacy}","received_events_url":"https://api.github.com/users/jdinan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdinan/specification","description":"OpenSHMEM Specification Evolution","fork":true,"url":"https://api.github.com/repos/jdinan/specification","forks_url":"https://api.github.com/repos/jdinan/specification/forks","keys_url":"https://api.github.com/repos/jdinan/specification/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdinan/specification/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdinan/specification/teams","hooks_url":"https://api.github.com/repos/jdinan/specification/hooks","issue_events_url":"https://api.github.com/repos/jdinan/specification/issues/events{/number}","events_url":"https://api.github.com/repos/jdinan/specification/events","assignees_url":"https://api.github.com/repos/jdinan/specification/assignees{/user}","branches_url":"https://api.github.com/repos/jdinan/specification/branches{/branch}","tags_url":"https://api.github.com/repos/jdinan/specification/tags","blobs_url":"https://api.github.com/repos/jdinan/specification/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdinan/specification/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdinan/specification/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdinan/specification/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdinan/specification/statuses/{sha}","languages_url":"https://api.github.com/repos/jdinan/specification/languages","stargazers_url":"https://api.github.com/repos/jdinan/specification/stargazers","contributors_url":"https://api.github.com/repos/jdinan/specification/contributors","subscribers_url":"https://api.github.com/repos/jdinan/specification/subscribers","subscription_url":"https://api.github.com/repos/jdinan/specification/subscription","commits_url":"https://api.github.com/repos/jdinan/specification/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdinan/specification/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdinan/specification/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdinan/specification/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdinan/specification/contents/{+path}","compare_url":"https://api.github.com/repos/jdinan/specification/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdinan/specification/merges","archive_url":"https://api.github.com/repos/jdinan/specification/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdinan/specification/downloads","issues_url":"https://api.github.com/repos/jdinan/specification/issues{/number}","pulls_url":"https://api.github.com/repos/jdinan/specification/pulls{/number}","milestones_url":"https://api.github.com/repos/jdinan/specification/milestones{/number}","notifications_url":"https://api.github.com/repos/jdinan/specification/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdinan/specification/labels{/name}","releases_url":"https://api.github.com/repos/jdinan/specification/releases{/id}","deployments_url":"https://api.github.com/repos/jdinan/specification/deployments","created_at":"2016-06-01T18:24:06Z","updated_at":"2017-01-24T22:59:56Z","pushed_at":"2018-02-06T01:15:53Z","git_url":"git://github.com/jdinan/specification.git","ssh_url":"git@github.com:jdinan/specification.git","clone_url":"https://github.com/jdinan/specification.git","svn_url":"https://github.com/jdinan/specification","homepage":"","size":4377,"stargazers_count":1,"watchers_count":1,"language":"TeX","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"openshmem-org:master","ref":"master","sha":"d4f9e0e7fa011d771208503b23d0edaab7dec2e0","user":{"login":"openshmem-org","id":8379095,"avatar_url":"https://avatars3.githubusercontent.com/u/8379095?v=4","gravatar_id":"","url":"https://api.github.com/users/openshmem-org","html_url":"https://github.com/openshmem-org","followers_url":"https://api.github.com/users/openshmem-org/followers","following_url":"https://api.github.com/users/openshmem-org/following{/other_user}","gists_url":"https://api.github.com/users/openshmem-org/gists{/gist_id}","starred_url":"https://api.github.com/users/openshmem-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshmem-org/subscriptions","organizations_url":"https://api.github.com/users/openshmem-org/orgs","repos_url":"https://api.github.com/users/openshmem-org/repos","events_url":"https://api.github.com/users/openshmem-org/events{/privacy}","received_events_url":"https://api.github.com/users/openshmem-org/received_events","type":"Organization","site_admin":false},"repo":{"id":46451922,"name":"specification","full_name":"openshmem-org/specification","owner":{"login":"openshmem-org","id":8379095,"avatar_url":"https://avatars3.githubusercontent.com/u/8379095?v=4","gravatar_id":"","url":"https://api.github.com/users/openshmem-org","html_url":"https://github.com/openshmem-org","followers_url":"https://api.github.com/users/openshmem-org/followers","following_url":"https://api.github.com/users/openshmem-org/following{/other_user}","gists_url":"https://api.github.com/users/openshmem-org/gists{/gist_id}","starred_url":"https://api.github.com/users/openshmem-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshmem-org/subscriptions","organizations_url":"https://api.github.com/users/openshmem-org/orgs","repos_url":"https://api.github.com/users/openshmem-org/repos","events_url":"https://api.github.com/users/openshmem-org/events{/privacy}","received_events_url":"https://api.github.com/users/openshmem-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshmem-org/specification","description":"OpenSHMEM Application Programming Interface","fork":false,"url":"https://api.github.com/repos/openshmem-org/specification","forks_url":"https://api.github.com/repos/openshmem-org/specification/forks","keys_url":"https://api.github.com/repos/openshmem-org/specification/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshmem-org/specification/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshmem-org/specification/teams","hooks_url":"https://api.github.com/repos/openshmem-org/specification/hooks","issue_events_url":"https://api.github.com/repos/openshmem-org/specification/issues/events{/number}","events_url":"https://api.github.com/repos/openshmem-org/specification/events","assignees_url":"https://api.github.com/repos/openshmem-org/specification/assignees{/user}","branches_url":"https://api.github.com/repos/openshmem-org/specification/branches{/branch}","tags_url":"https://api.github.com/repos/openshmem-org/specification/tags","blobs_url":"https://api.github.com/repos/openshmem-org/specification/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshmem-org/specification/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshmem-org/specification/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshmem-org/specification/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshmem-org/specification/statuses/{sha}","languages_url":"https://api.github.com/repos/openshmem-org/specification/languages","stargazers_url":"https://api.github.com/repos/openshmem-org/specification/stargazers","contributors_url":"https://api.github.com/repos/openshmem-org/specification/contributors","subscribers_url":"https://api.github.com/repos/openshmem-org/specification/subscribers","subscription_url":"https://api.github.com/repos/openshmem-org/specification/subscription","commits_url":"https://api.github.com/repos/openshmem-org/specification/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshmem-org/specification/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshmem-org/specification/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshmem-org/specification/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshmem-org/specification/contents/{+path}","compare_url":"https://api.github.com/repos/openshmem-org/specification/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshmem-org/specification/merges","archive_url":"https://api.github.com/repos/openshmem-org/specification/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshmem-org/specification/downloads","issues_url":"https://api.github.com/repos/openshmem-org/specification/issues{/number}","pulls_url":"https://api.github.com/repos/openshmem-org/specification/pulls{/number}","milestones_url":"https://api.github.com/repos/openshmem-org/specification/milestones{/number}","notifications_url":"https://api.github.com/repos/openshmem-org/specification/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshmem-org/specification/labels{/name}","releases_url":"https://api.github.com/repos/openshmem-org/specification/releases{/id}","deployments_url":"https://api.github.com/repos/openshmem-org/specification/deployments","created_at":"2015-11-18T22:33:56Z","updated_at":"2018-01-22T17:13:35Z","pushed_at":"2018-02-06T01:16:33Z","git_url":"git://github.com/openshmem-org/specification.git","ssh_url":"git@github.com:openshmem-org/specification.git","clone_url":"https://github.com/openshmem-org/specification.git","svn_url":"https://github.com/openshmem-org/specification","homepage":"http://www.openshmem.org","size":3457,"stargazers_count":19,"watchers_count":19,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":52,"license":null,"forks":25,"open_issues":52,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshmem-org/specification/pulls/201"},"html":{"href":"https://github.com/openshmem-org/specification/pull/201"},"issue":{"href":"https://api.github.com/repos/openshmem-org/specification/issues/201"},"comments":{"href":"https://api.github.com/repos/openshmem-org/specification/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/openshmem-org/specification/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/openshmem-org/specification/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshmem-org/specification/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/openshmem-org/specification/statuses/b24a3880090423c36c2bc427c3f1a5be26137afd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nspark"}}