{"action":"created","comment":{"url":"https://api.github.com/repos/edx/course-discovery/pulls/comments/205833177","pull_request_review_id":141185729,"id":205833177,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTgzMzE3Nw==","diff_hunk":"@@ -1279,13 +1279,32 @@ def save(self, *args, **kwargs):  # pylint: disable=arguments-differ\n             super(Program, self).save(*args, **kwargs)\n \n \n-class Degree(TimeStampedModel):\n+class Degree(Program):\n     \"\"\"\n-    Degree 'master' model linking requirements and templates\n+    Marketing model for degree landing pages\n+    Program inheritance model\n+    \"\"\"\n+    application_deadline = models.CharField(\n+        help_text=_('String-based deadline field (e.g. FALL 2020)'),\n+        max_length=255,\n+    )\n+    apply_url = models.CharField(\n+        help_text=_('Callback URL to partner application flow'), max_length=255, blank=True)\n+\n+    class Meta(object):\n+        verbose_name_plural = \"degree marketing data\"\n+\n+    def __str__(self):\n+        return str('Marketing-specific fields for {}'.format(self.title))\n+\n+\n+class Curriculum(TimeStampedModel):\n+    \"\"\"\n+    Curriculum 'master' model linking degree requirements and templates","path":"course_discovery/apps/course_metadata/models.py","position":27,"original_position":27,"commit_id":"c096e38cb554f10a78bba868a0d6b2752cdbbf25","original_commit_id":"c096e38cb554f10a78bba868a0d6b2752cdbbf25","user":{"login":"iloveagent57","id":2307986,"node_id":"MDQ6VXNlcjIzMDc5ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/2307986?v=4","gravatar_id":"","url":"https://api.github.com/users/iloveagent57","html_url":"https://github.com/iloveagent57","followers_url":"https://api.github.com/users/iloveagent57/followers","following_url":"https://api.github.com/users/iloveagent57/following{/other_user}","gists_url":"https://api.github.com/users/iloveagent57/gists{/gist_id}","starred_url":"https://api.github.com/users/iloveagent57/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iloveagent57/subscriptions","organizations_url":"https://api.github.com/users/iloveagent57/orgs","repos_url":"https://api.github.com/users/iloveagent57/repos","events_url":"https://api.github.com/users/iloveagent57/events{/privacy}","received_events_url":"https://api.github.com/users/iloveagent57/received_events","type":"User","site_admin":false},"body":"This string could be better (e.g. what's a \"template\"?)","created_at":"2018-07-27T16:42:35Z","updated_at":"2018-07-27T16:43:15Z","html_url":"https://github.com/edx/course-discovery/pull/1474#discussion_r205833177","pull_request_url":"https://api.github.com/repos/edx/course-discovery/pulls/1474","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/edx/course-discovery/pulls/comments/205833177"},"html":{"href":"https://github.com/edx/course-discovery/pull/1474#discussion_r205833177"},"pull_request":{"href":"https://api.github.com/repos/edx/course-discovery/pulls/1474"}}},"pull_request":{"url":"https://api.github.com/repos/edx/course-discovery/pulls/1474","id":203610862,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNjEwODYy","html_url":"https://github.com/edx/course-discovery/pull/1474","diff_url":"https://github.com/edx/course-discovery/pull/1474.diff","patch_url":"https://github.com/edx/course-discovery/pull/1474.patch","issue_url":"https://api.github.com/repos/edx/course-discovery/issues/1474","number":1474,"state":"open","locked":false,"title":"Single admin page for DegreeMarketingData(Program) model","user":{"login":"yro","id":7050866,"node_id":"MDQ6VXNlcjcwNTA4NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/7050866?v=4","gravatar_id":"","url":"https://api.github.com/users/yro","html_url":"https://github.com/yro","followers_url":"https://api.github.com/users/yro/followers","following_url":"https://api.github.com/users/yro/following{/other_user}","gists_url":"https://api.github.com/users/yro/gists{/gist_id}","starred_url":"https://api.github.com/users/yro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yro/subscriptions","organizations_url":"https://api.github.com/users/yro/orgs","repos_url":"https://api.github.com/users/yro/repos","events_url":"https://api.github.com/users/yro/events{/privacy}","received_events_url":"https://api.github.com/users/yro/received_events","type":"User","site_admin":false},"body":"## [EDUCATOR-3111](https://openedx.atlassian.net/browse/EDUCATOR-3111)\r\n\r\n### Description\r\nImplement single inheritance model for `DegreeMarketingData` table in model -- add single marketing admin page / model (and inherited model) for `DegreeMarketingData` that's wholly separate from the `Degree` model.\r\n\r\n```\r\nProgram -- DegreeMarketing\r\n    |           |\r\nDegree--------- |\r\n```\r\n\r\nThis introduces a sort of circular 1:1 dependency (as `DegreeMarketingData` is, in fact, an augmented `Program` model), we wished to protect against creating DegreeMarketingData without an associated Degree model.\r\n\r\nThis drops the prior `DegreeMarketing` model/table and adds an inheritance model `DegreeMarketingData`, as well as migration adding `Masters` to the `ProgramType` model (as `XSeries` and `MicroMasters` are added)\r\n\r\n### Testing\r\n- [ ] Unit tests\r\n- [ ] Test Migrations\r\n\r\n### Reviewers\r\nIf you've been tagged for review, please check your corresponding box once you've given the :+1:.\r\n- [ ] Code review: @iloveagent57 @schenedx \r\n\r\nFYI: @edx/educator-neem\r\n\r\n### Post-review\r\n- [ ] Rebase and squash commits\r\n","created_at":"2018-07-24T18:10:52Z","updated_at":"2018-07-27T16:43:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d19ff22bd745d8cb49128e874e9366ee63911ecb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/course-discovery/pulls/1474/commits","review_comments_url":"https://api.github.com/repos/edx/course-discovery/pulls/1474/comments","review_comment_url":"https://api.github.com/repos/edx/course-discovery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/course-discovery/issues/1474/comments","statuses_url":"https://api.github.com/repos/edx/course-discovery/statuses/c096e38cb554f10a78bba868a0d6b2752cdbbf25","head":{"label":"edx:yro/EDUCATOR-3111","ref":"yro/EDUCATOR-3111","sha":"c096e38cb554f10a78bba868a0d6b2752cdbbf25","user":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":45866355,"node_id":"MDEwOlJlcG9zaXRvcnk0NTg2NjM1NQ==","name":"course-discovery","full_name":"edx/course-discovery","owner":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/course-discovery","description":"Service providing access to consolidated course and program metadata","fork":false,"url":"https://api.github.com/repos/edx/course-discovery","forks_url":"https://api.github.com/repos/edx/course-discovery/forks","keys_url":"https://api.github.com/repos/edx/course-discovery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/course-discovery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/course-discovery/teams","hooks_url":"https://api.github.com/repos/edx/course-discovery/hooks","issue_events_url":"https://api.github.com/repos/edx/course-discovery/issues/events{/number}","events_url":"https://api.github.com/repos/edx/course-discovery/events","assignees_url":"https://api.github.com/repos/edx/course-discovery/assignees{/user}","branches_url":"https://api.github.com/repos/edx/course-discovery/branches{/branch}","tags_url":"https://api.github.com/repos/edx/course-discovery/tags","blobs_url":"https://api.github.com/repos/edx/course-discovery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/course-discovery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/course-discovery/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/course-discovery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/course-discovery/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/course-discovery/languages","stargazers_url":"https://api.github.com/repos/edx/course-discovery/stargazers","contributors_url":"https://api.github.com/repos/edx/course-discovery/contributors","subscribers_url":"https://api.github.com/repos/edx/course-discovery/subscribers","subscription_url":"https://api.github.com/repos/edx/course-discovery/subscription","commits_url":"https://api.github.com/repos/edx/course-discovery/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/course-discovery/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/course-discovery/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/course-discovery/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/course-discovery/contents/{+path}","compare_url":"https://api.github.com/repos/edx/course-discovery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/course-discovery/merges","archive_url":"https://api.github.com/repos/edx/course-discovery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/course-discovery/downloads","issues_url":"https://api.github.com/repos/edx/course-discovery/issues{/number}","pulls_url":"https://api.github.com/repos/edx/course-discovery/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/course-discovery/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/course-discovery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/course-discovery/labels{/name}","releases_url":"https://api.github.com/repos/edx/course-discovery/releases{/id}","deployments_url":"https://api.github.com/repos/edx/course-discovery/deployments","created_at":"2015-11-09T20:57:54Z","updated_at":"2018-07-27T11:54:57Z","pushed_at":"2018-07-27T16:18:08Z","git_url":"git://github.com/edx/course-discovery.git","ssh_url":"git@github.com:edx/course-discovery.git","clone_url":"https://github.com/edx/course-discovery.git","svn_url":"https://github.com/edx/course-discovery","homepage":"https://edx-discovery.readthedocs.io/en/latest/","size":16311,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":18,"open_issues":10,"watchers":17,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"6aad00b5cdafd074261ca177ff7cac4854d1d1b0","user":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":45866355,"node_id":"MDEwOlJlcG9zaXRvcnk0NTg2NjM1NQ==","name":"course-discovery","full_name":"edx/course-discovery","owner":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/course-discovery","description":"Service providing access to consolidated course and program metadata","fork":false,"url":"https://api.github.com/repos/edx/course-discovery","forks_url":"https://api.github.com/repos/edx/course-discovery/forks","keys_url":"https://api.github.com/repos/edx/course-discovery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/course-discovery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/course-discovery/teams","hooks_url":"https://api.github.com/repos/edx/course-discovery/hooks","issue_events_url":"https://api.github.com/repos/edx/course-discovery/issues/events{/number}","events_url":"https://api.github.com/repos/edx/course-discovery/events","assignees_url":"https://api.github.com/repos/edx/course-discovery/assignees{/user}","branches_url":"https://api.github.com/repos/edx/course-discovery/branches{/branch}","tags_url":"https://api.github.com/repos/edx/course-discovery/tags","blobs_url":"https://api.github.com/repos/edx/course-discovery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/course-discovery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/course-discovery/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/course-discovery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/course-discovery/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/course-discovery/languages","stargazers_url":"https://api.github.com/repos/edx/course-discovery/stargazers","contributors_url":"https://api.github.com/repos/edx/course-discovery/contributors","subscribers_url":"https://api.github.com/repos/edx/course-discovery/subscribers","subscription_url":"https://api.github.com/repos/edx/course-discovery/subscription","commits_url":"https://api.github.com/repos/edx/course-discovery/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/course-discovery/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/course-discovery/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/course-discovery/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/course-discovery/contents/{+path}","compare_url":"https://api.github.com/repos/edx/course-discovery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/course-discovery/merges","archive_url":"https://api.github.com/repos/edx/course-discovery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/course-discovery/downloads","issues_url":"https://api.github.com/repos/edx/course-discovery/issues{/number}","pulls_url":"https://api.github.com/repos/edx/course-discovery/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/course-discovery/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/course-discovery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/course-discovery/labels{/name}","releases_url":"https://api.github.com/repos/edx/course-discovery/releases{/id}","deployments_url":"https://api.github.com/repos/edx/course-discovery/deployments","created_at":"2015-11-09T20:57:54Z","updated_at":"2018-07-27T11:54:57Z","pushed_at":"2018-07-27T16:18:08Z","git_url":"git://github.com/edx/course-discovery.git","ssh_url":"git@github.com:edx/course-discovery.git","clone_url":"https://github.com/edx/course-discovery.git","svn_url":"https://github.com/edx/course-discovery","homepage":"https://edx-discovery.readthedocs.io/en/latest/","size":16311,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":18,"open_issues":10,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/course-discovery/pulls/1474"},"html":{"href":"https://github.com/edx/course-discovery/pull/1474"},"issue":{"href":"https://api.github.com/repos/edx/course-discovery/issues/1474"},"comments":{"href":"https://api.github.com/repos/edx/course-discovery/issues/1474/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/course-discovery/pulls/1474/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/course-discovery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/course-discovery/pulls/1474/commits"},"statuses":{"href":"https://api.github.com/repos/edx/course-discovery/statuses/c096e38cb554f10a78bba868a0d6b2752cdbbf25"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"iloveagent57"}}