{"action":"created","comment":{"url":"https://api.github.com/repos/HuddleEng/octopose/pulls/comments/171330332","pull_request_review_id":100164056,"id":171330332,"diff_hunk":"@@ -22,17 +22,16 @@\n # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE\r\n # SOFTWARE.\r\n \r\n-import os\r\n-import subprocess\r\n-\r\n import config\r\n \r\n \r\n-def get_deployable(name, version, staging_location):\r\n-    \"\"\" Get deployables from pacakage sources for local deployment. \"\"\"\r\n-    for source in config.PACKAGE_SOURCES:\r\n-        FNULL = open(os.devnull, 'w')    #use this if you want to suppress output to stdout from the subprocess\r\n-        args = \"third_party\\\\NuGet.exe install {0} -Source {1} -OutputDirectory {2}\".format(name, source, staging_location)\r\n-        if version is not None:\r\n-            args = args + \" -Version {0}\".format(version)\r\n-        subprocess.call(args, stdout=FNULL, stderr=FNULL, shell=False)\r\n+class Nu:\r\n+    def __init__(self, subprocess_runner):\r","path":"nu.py","position":28,"original_position":28,"commit_id":"8e8688c7d5ae6f244d1bfb95e24d54e8229e27a0","original_commit_id":"8e8688c7d5ae6f244d1bfb95e24d54e8229e27a0","user":{"login":"domgreen","id":156558,"avatar_url":"https://avatars0.githubusercontent.com/u/156558?v=4","gravatar_id":"","url":"https://api.github.com/users/domgreen","html_url":"https://github.com/domgreen","followers_url":"https://api.github.com/users/domgreen/followers","following_url":"https://api.github.com/users/domgreen/following{/other_user}","gists_url":"https://api.github.com/users/domgreen/gists{/gist_id}","starred_url":"https://api.github.com/users/domgreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domgreen/subscriptions","organizations_url":"https://api.github.com/users/domgreen/orgs","repos_url":"https://api.github.com/users/domgreen/repos","events_url":"https://api.github.com/users/domgreen/events{/privacy}","received_events_url":"https://api.github.com/users/domgreen/received_events","type":"User","site_admin":false},"body":"Can you do ctor style comments on this?","created_at":"2018-02-28T17:55:04Z","updated_at":"2018-02-28T18:00:05Z","html_url":"https://github.com/HuddleEng/octopose/pull/18#discussion_r171330332","pull_request_url":"https://api.github.com/repos/HuddleEng/octopose/pulls/18","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/HuddleEng/octopose/pulls/comments/171330332"},"html":{"href":"https://github.com/HuddleEng/octopose/pull/18#discussion_r171330332"},"pull_request":{"href":"https://api.github.com/repos/HuddleEng/octopose/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/HuddleEng/octopose/pulls/18","id":171900154,"html_url":"https://github.com/HuddleEng/octopose/pull/18","diff_url":"https://github.com/HuddleEng/octopose/pull/18.diff","patch_url":"https://github.com/HuddleEng/octopose/pull/18.patch","issue_url":"https://api.github.com/repos/HuddleEng/octopose/issues/18","number":18,"state":"open","locked":false,"title":"Verbose logging","user":{"login":"george-ayris","id":9038126,"avatar_url":"https://avatars1.githubusercontent.com/u/9038126?v=4","gravatar_id":"","url":"https://api.github.com/users/george-ayris","html_url":"https://github.com/george-ayris","followers_url":"https://api.github.com/users/george-ayris/followers","following_url":"https://api.github.com/users/george-ayris/following{/other_user}","gists_url":"https://api.github.com/users/george-ayris/gists{/gist_id}","starred_url":"https://api.github.com/users/george-ayris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/george-ayris/subscriptions","organizations_url":"https://api.github.com/users/george-ayris/orgs","repos_url":"https://api.github.com/users/george-ayris/repos","events_url":"https://api.github.com/users/george-ayris/events{/privacy}","received_events_url":"https://api.github.com/users/george-ayris/received_events","type":"User","site_admin":false},"body":"By default octopose now only outputs logs for subprocceses when they return a non-zero exit code (to help with debugging). To get all logs you can use the `-v` or `--verbose` flag.\r\n\r\nSolves #14 and #13 ","created_at":"2018-02-28T09:40:01Z","updated_at":"2018-02-28T18:00:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d35e382bb693bfebc3959609a1472f12afaa1c2","assignee":{"login":"george-ayris","id":9038126,"avatar_url":"https://avatars1.githubusercontent.com/u/9038126?v=4","gravatar_id":"","url":"https://api.github.com/users/george-ayris","html_url":"https://github.com/george-ayris","followers_url":"https://api.github.com/users/george-ayris/followers","following_url":"https://api.github.com/users/george-ayris/following{/other_user}","gists_url":"https://api.github.com/users/george-ayris/gists{/gist_id}","starred_url":"https://api.github.com/users/george-ayris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/george-ayris/subscriptions","organizations_url":"https://api.github.com/users/george-ayris/orgs","repos_url":"https://api.github.com/users/george-ayris/repos","events_url":"https://api.github.com/users/george-ayris/events{/privacy}","received_events_url":"https://api.github.com/users/george-ayris/received_events","type":"User","site_admin":false},"assignees":[{"login":"george-ayris","id":9038126,"avatar_url":"https://avatars1.githubusercontent.com/u/9038126?v=4","gravatar_id":"","url":"https://api.github.com/users/george-ayris","html_url":"https://github.com/george-ayris","followers_url":"https://api.github.com/users/george-ayris/followers","following_url":"https://api.github.com/users/george-ayris/following{/other_user}","gists_url":"https://api.github.com/users/george-ayris/gists{/gist_id}","starred_url":"https://api.github.com/users/george-ayris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/george-ayris/subscriptions","organizations_url":"https://api.github.com/users/george-ayris/orgs","repos_url":"https://api.github.com/users/george-ayris/repos","events_url":"https://api.github.com/users/george-ayris/events{/privacy}","received_events_url":"https://api.github.com/users/george-ayris/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HuddleEng/octopose/pulls/18/commits","review_comments_url":"https://api.github.com/repos/HuddleEng/octopose/pulls/18/comments","review_comment_url":"https://api.github.com/repos/HuddleEng/octopose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HuddleEng/octopose/issues/18/comments","statuses_url":"https://api.github.com/repos/HuddleEng/octopose/statuses/8e8688c7d5ae6f244d1bfb95e24d54e8229e27a0","head":{"label":"HuddleEng:verbose_logging","ref":"verbose_logging","sha":"8e8688c7d5ae6f244d1bfb95e24d54e8229e27a0","user":{"login":"HuddleEng","id":35964367,"avatar_url":"https://avatars0.githubusercontent.com/u/35964367?v=4","gravatar_id":"","url":"https://api.github.com/users/HuddleEng","html_url":"https://github.com/HuddleEng","followers_url":"https://api.github.com/users/HuddleEng/followers","following_url":"https://api.github.com/users/HuddleEng/following{/other_user}","gists_url":"https://api.github.com/users/HuddleEng/gists{/gist_id}","starred_url":"https://api.github.com/users/HuddleEng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuddleEng/subscriptions","organizations_url":"https://api.github.com/users/HuddleEng/orgs","repos_url":"https://api.github.com/users/HuddleEng/repos","events_url":"https://api.github.com/users/HuddleEng/events{/privacy}","received_events_url":"https://api.github.com/users/HuddleEng/received_events","type":"Organization","site_admin":false},"repo":{"id":109125355,"name":"octopose","full_name":"HuddleEng/octopose","owner":{"login":"HuddleEng","id":35964367,"avatar_url":"https://avatars0.githubusercontent.com/u/35964367?v=4","gravatar_id":"","url":"https://api.github.com/users/HuddleEng","html_url":"https://github.com/HuddleEng","followers_url":"https://api.github.com/users/HuddleEng/followers","following_url":"https://api.github.com/users/HuddleEng/following{/other_user}","gists_url":"https://api.github.com/users/HuddleEng/gists{/gist_id}","starred_url":"https://api.github.com/users/HuddleEng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuddleEng/subscriptions","organizations_url":"https://api.github.com/users/HuddleEng/orgs","repos_url":"https://api.github.com/users/HuddleEng/repos","events_url":"https://api.github.com/users/HuddleEng/events{/privacy}","received_events_url":"https://api.github.com/users/HuddleEng/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HuddleEng/octopose","description":null,"fork":false,"url":"https://api.github.com/repos/HuddleEng/octopose","forks_url":"https://api.github.com/repos/HuddleEng/octopose/forks","keys_url":"https://api.github.com/repos/HuddleEng/octopose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HuddleEng/octopose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HuddleEng/octopose/teams","hooks_url":"https://api.github.com/repos/HuddleEng/octopose/hooks","issue_events_url":"https://api.github.com/repos/HuddleEng/octopose/issues/events{/number}","events_url":"https://api.github.com/repos/HuddleEng/octopose/events","assignees_url":"https://api.github.com/repos/HuddleEng/octopose/assignees{/user}","branches_url":"https://api.github.com/repos/HuddleEng/octopose/branches{/branch}","tags_url":"https://api.github.com/repos/HuddleEng/octopose/tags","blobs_url":"https://api.github.com/repos/HuddleEng/octopose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HuddleEng/octopose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HuddleEng/octopose/git/refs{/sha}","trees_url":"https://api.github.com/repos/HuddleEng/octopose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HuddleEng/octopose/statuses/{sha}","languages_url":"https://api.github.com/repos/HuddleEng/octopose/languages","stargazers_url":"https://api.github.com/repos/HuddleEng/octopose/stargazers","contributors_url":"https://api.github.com/repos/HuddleEng/octopose/contributors","subscribers_url":"https://api.github.com/repos/HuddleEng/octopose/subscribers","subscription_url":"https://api.github.com/repos/HuddleEng/octopose/subscription","commits_url":"https://api.github.com/repos/HuddleEng/octopose/commits{/sha}","git_commits_url":"https://api.github.com/repos/HuddleEng/octopose/git/commits{/sha}","comments_url":"https://api.github.com/repos/HuddleEng/octopose/comments{/number}","issue_comment_url":"https://api.github.com/repos/HuddleEng/octopose/issues/comments{/number}","contents_url":"https://api.github.com/repos/HuddleEng/octopose/contents/{+path}","compare_url":"https://api.github.com/repos/HuddleEng/octopose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HuddleEng/octopose/merges","archive_url":"https://api.github.com/repos/HuddleEng/octopose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HuddleEng/octopose/downloads","issues_url":"https://api.github.com/repos/HuddleEng/octopose/issues{/number}","pulls_url":"https://api.github.com/repos/HuddleEng/octopose/pulls{/number}","milestones_url":"https://api.github.com/repos/HuddleEng/octopose/milestones{/number}","notifications_url":"https://api.github.com/repos/HuddleEng/octopose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HuddleEng/octopose/labels{/name}","releases_url":"https://api.github.com/repos/HuddleEng/octopose/releases{/id}","deployments_url":"https://api.github.com/repos/HuddleEng/octopose/deployments","created_at":"2017-11-01T11:53:11Z","updated_at":"2018-02-14T15:42:52Z","pushed_at":"2018-02-28T15:03:20Z","git_url":"git://github.com/HuddleEng/octopose.git","ssh_url":"git@github.com:HuddleEng/octopose.git","clone_url":"https://github.com/HuddleEng/octopose.git","svn_url":"https://github.com/HuddleEng/octopose","homepage":null,"size":1160,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":10,"watchers":3,"default_branch":"master"}},"base":{"label":"HuddleEng:master","ref":"master","sha":"ecb0fdb21bb20f43b365194b8af438e72e47da10","user":{"login":"HuddleEng","id":35964367,"avatar_url":"https://avatars0.githubusercontent.com/u/35964367?v=4","gravatar_id":"","url":"https://api.github.com/users/HuddleEng","html_url":"https://github.com/HuddleEng","followers_url":"https://api.github.com/users/HuddleEng/followers","following_url":"https://api.github.com/users/HuddleEng/following{/other_user}","gists_url":"https://api.github.com/users/HuddleEng/gists{/gist_id}","starred_url":"https://api.github.com/users/HuddleEng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuddleEng/subscriptions","organizations_url":"https://api.github.com/users/HuddleEng/orgs","repos_url":"https://api.github.com/users/HuddleEng/repos","events_url":"https://api.github.com/users/HuddleEng/events{/privacy}","received_events_url":"https://api.github.com/users/HuddleEng/received_events","type":"Organization","site_admin":false},"repo":{"id":109125355,"name":"octopose","full_name":"HuddleEng/octopose","owner":{"login":"HuddleEng","id":35964367,"avatar_url":"https://avatars0.githubusercontent.com/u/35964367?v=4","gravatar_id":"","url":"https://api.github.com/users/HuddleEng","html_url":"https://github.com/HuddleEng","followers_url":"https://api.github.com/users/HuddleEng/followers","following_url":"https://api.github.com/users/HuddleEng/following{/other_user}","gists_url":"https://api.github.com/users/HuddleEng/gists{/gist_id}","starred_url":"https://api.github.com/users/HuddleEng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HuddleEng/subscriptions","organizations_url":"https://api.github.com/users/HuddleEng/orgs","repos_url":"https://api.github.com/users/HuddleEng/repos","events_url":"https://api.github.com/users/HuddleEng/events{/privacy}","received_events_url":"https://api.github.com/users/HuddleEng/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HuddleEng/octopose","description":null,"fork":false,"url":"https://api.github.com/repos/HuddleEng/octopose","forks_url":"https://api.github.com/repos/HuddleEng/octopose/forks","keys_url":"https://api.github.com/repos/HuddleEng/octopose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HuddleEng/octopose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HuddleEng/octopose/teams","hooks_url":"https://api.github.com/repos/HuddleEng/octopose/hooks","issue_events_url":"https://api.github.com/repos/HuddleEng/octopose/issues/events{/number}","events_url":"https://api.github.com/repos/HuddleEng/octopose/events","assignees_url":"https://api.github.com/repos/HuddleEng/octopose/assignees{/user}","branches_url":"https://api.github.com/repos/HuddleEng/octopose/branches{/branch}","tags_url":"https://api.github.com/repos/HuddleEng/octopose/tags","blobs_url":"https://api.github.com/repos/HuddleEng/octopose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HuddleEng/octopose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HuddleEng/octopose/git/refs{/sha}","trees_url":"https://api.github.com/repos/HuddleEng/octopose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HuddleEng/octopose/statuses/{sha}","languages_url":"https://api.github.com/repos/HuddleEng/octopose/languages","stargazers_url":"https://api.github.com/repos/HuddleEng/octopose/stargazers","contributors_url":"https://api.github.com/repos/HuddleEng/octopose/contributors","subscribers_url":"https://api.github.com/repos/HuddleEng/octopose/subscribers","subscription_url":"https://api.github.com/repos/HuddleEng/octopose/subscription","commits_url":"https://api.github.com/repos/HuddleEng/octopose/commits{/sha}","git_commits_url":"https://api.github.com/repos/HuddleEng/octopose/git/commits{/sha}","comments_url":"https://api.github.com/repos/HuddleEng/octopose/comments{/number}","issue_comment_url":"https://api.github.com/repos/HuddleEng/octopose/issues/comments{/number}","contents_url":"https://api.github.com/repos/HuddleEng/octopose/contents/{+path}","compare_url":"https://api.github.com/repos/HuddleEng/octopose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HuddleEng/octopose/merges","archive_url":"https://api.github.com/repos/HuddleEng/octopose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HuddleEng/octopose/downloads","issues_url":"https://api.github.com/repos/HuddleEng/octopose/issues{/number}","pulls_url":"https://api.github.com/repos/HuddleEng/octopose/pulls{/number}","milestones_url":"https://api.github.com/repos/HuddleEng/octopose/milestones{/number}","notifications_url":"https://api.github.com/repos/HuddleEng/octopose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HuddleEng/octopose/labels{/name}","releases_url":"https://api.github.com/repos/HuddleEng/octopose/releases{/id}","deployments_url":"https://api.github.com/repos/HuddleEng/octopose/deployments","created_at":"2017-11-01T11:53:11Z","updated_at":"2018-02-14T15:42:52Z","pushed_at":"2018-02-28T15:03:20Z","git_url":"git://github.com/HuddleEng/octopose.git","ssh_url":"git@github.com:HuddleEng/octopose.git","clone_url":"https://github.com/HuddleEng/octopose.git","svn_url":"https://github.com/HuddleEng/octopose","homepage":null,"size":1160,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":10,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HuddleEng/octopose/pulls/18"},"html":{"href":"https://github.com/HuddleEng/octopose/pull/18"},"issue":{"href":"https://api.github.com/repos/HuddleEng/octopose/issues/18"},"comments":{"href":"https://api.github.com/repos/HuddleEng/octopose/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/HuddleEng/octopose/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/HuddleEng/octopose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HuddleEng/octopose/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/HuddleEng/octopose/statuses/8e8688c7d5ae6f244d1bfb95e24d54e8229e27a0"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"domgreen"}}