{"action":"opened","number":18166,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/18166","id":203377301,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzc3MzAx","html_url":"https://github.com/apple/swift/pull/18166","diff_url":"https://github.com/apple/swift/pull/18166.diff","patch_url":"https://github.com/apple/swift/pull/18166.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/18166","number":18166,"state":"open","locked":false,"title":"[4.2][Lexer] Don't include backtick length into comment length","user":{"login":"rintaro","id":142081,"node_id":"MDQ6VXNlcjE0MjA4MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/142081?v=4","gravatar_id":"","url":"https://api.github.com/users/rintaro","html_url":"https://github.com/rintaro","followers_url":"https://api.github.com/users/rintaro/followers","following_url":"https://api.github.com/users/rintaro/following{/other_user}","gists_url":"https://api.github.com/users/rintaro/gists{/gist_id}","starred_url":"https://api.github.com/users/rintaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rintaro/subscriptions","organizations_url":"https://api.github.com/users/rintaro/orgs","repos_url":"https://api.github.com/users/rintaro/repos","events_url":"https://api.github.com/users/rintaro/events{/privacy}","received_events_url":"https://api.github.com/users/rintaro/received_events","type":"User","site_admin":false},"body":"Cherry-pick of #18144 reviewed by @nkcsgexi  \r\n\r\n- **Explaination**: Lexer tokenizes comments and whitespaces as libSyntax Trivia first. For compatibility, it calculates comment length from trivia for legacy Parser logic. Previously, the length included backslash length attached to escaped identifier as a trivia piece. However `Token::getCommentRange` assumes it does *not* contain comment backslash. This mismatch used to cause compiler crash.\r\n- **Scope**: Affect SourceKit  functionality for handling escaped identifier with comments.\r\n- **Issue**: rdar://problem/42492793 https://bugs.swift.org/browse/SR-8315\r\n- **Risk**: Low. Pre-fix logic was obviously incorrect, and fix is simple.\r\n- **Testing**: Added regression test cases.\r\n- **Reviewed By**: Xi Ge (https://github.com/apple/swift/pull/18144)","created_at":"2018-07-24T00:15:23Z","updated_at":"2018-07-24T00:15:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/18166/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/18166/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/18166/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/1d98e2de2b5bcd35e0c7d711acbffd4289dda32a","head":{"label":"rintaro:4.2-lexer-commentlength","ref":"4.2-lexer-commentlength","sha":"1d98e2de2b5bcd35e0c7d711acbffd4289dda32a","user":{"login":"rintaro","id":142081,"node_id":"MDQ6VXNlcjE0MjA4MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/142081?v=4","gravatar_id":"","url":"https://api.github.com/users/rintaro","html_url":"https://github.com/rintaro","followers_url":"https://api.github.com/users/rintaro/followers","following_url":"https://api.github.com/users/rintaro/following{/other_user}","gists_url":"https://api.github.com/users/rintaro/gists{/gist_id}","starred_url":"https://api.github.com/users/rintaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rintaro/subscriptions","organizations_url":"https://api.github.com/users/rintaro/orgs","repos_url":"https://api.github.com/users/rintaro/repos","events_url":"https://api.github.com/users/rintaro/events{/privacy}","received_events_url":"https://api.github.com/users/rintaro/received_events","type":"User","site_admin":false},"repo":{"id":53176184,"node_id":"MDEwOlJlcG9zaXRvcnk1MzE3NjE4NA==","name":"swift","full_name":"rintaro/swift","owner":{"login":"rintaro","id":142081,"node_id":"MDQ6VXNlcjE0MjA4MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/142081?v=4","gravatar_id":"","url":"https://api.github.com/users/rintaro","html_url":"https://github.com/rintaro","followers_url":"https://api.github.com/users/rintaro/followers","following_url":"https://api.github.com/users/rintaro/following{/other_user}","gists_url":"https://api.github.com/users/rintaro/gists{/gist_id}","starred_url":"https://api.github.com/users/rintaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rintaro/subscriptions","organizations_url":"https://api.github.com/users/rintaro/orgs","repos_url":"https://api.github.com/users/rintaro/repos","events_url":"https://api.github.com/users/rintaro/events{/privacy}","received_events_url":"https://api.github.com/users/rintaro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rintaro/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/rintaro/swift","forks_url":"https://api.github.com/repos/rintaro/swift/forks","keys_url":"https://api.github.com/repos/rintaro/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rintaro/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rintaro/swift/teams","hooks_url":"https://api.github.com/repos/rintaro/swift/hooks","issue_events_url":"https://api.github.com/repos/rintaro/swift/issues/events{/number}","events_url":"https://api.github.com/repos/rintaro/swift/events","assignees_url":"https://api.github.com/repos/rintaro/swift/assignees{/user}","branches_url":"https://api.github.com/repos/rintaro/swift/branches{/branch}","tags_url":"https://api.github.com/repos/rintaro/swift/tags","blobs_url":"https://api.github.com/repos/rintaro/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rintaro/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rintaro/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/rintaro/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rintaro/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/rintaro/swift/languages","stargazers_url":"https://api.github.com/repos/rintaro/swift/stargazers","contributors_url":"https://api.github.com/repos/rintaro/swift/contributors","subscribers_url":"https://api.github.com/repos/rintaro/swift/subscribers","subscription_url":"https://api.github.com/repos/rintaro/swift/subscription","commits_url":"https://api.github.com/repos/rintaro/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/rintaro/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/rintaro/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/rintaro/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/rintaro/swift/contents/{+path}","compare_url":"https://api.github.com/repos/rintaro/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rintaro/swift/merges","archive_url":"https://api.github.com/repos/rintaro/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rintaro/swift/downloads","issues_url":"https://api.github.com/repos/rintaro/swift/issues{/number}","pulls_url":"https://api.github.com/repos/rintaro/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/rintaro/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/rintaro/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rintaro/swift/labels{/name}","releases_url":"https://api.github.com/repos/rintaro/swift/releases{/id}","deployments_url":"https://api.github.com/repos/rintaro/swift/deployments","created_at":"2016-03-05T01:24:05Z","updated_at":"2016-11-12T08:40:05Z","pushed_at":"2018-07-24T00:05:23Z","git_url":"git://github.com/rintaro/swift.git","ssh_url":"git@github.com:rintaro/swift.git","clone_url":"https://github.com/rintaro/swift.git","svn_url":"https://github.com/rintaro/swift","homepage":"https://swift.org/","size":291740,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":2,"open_issues":0,"watchers":1,"default_branch":"empty"}},"base":{"label":"apple:swift-4.2-branch","ref":"swift-4.2-branch","sha":"18650bc69c231a4f792483b450446199e3549f18","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-07-23T22:58:40Z","pushed_at":"2018-07-24T00:13:41Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":315665,"stargazers_count":44624,"watchers_count":44624,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7038,"mirror_url":null,"archived":false,"open_issues_count":375,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7038,"open_issues":375,"watchers":44624,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/18166"},"html":{"href":"https://github.com/apple/swift/pull/18166"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/18166"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/18166/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/18166/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/18166/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/1d98e2de2b5bcd35e0c7d711acbffd4289dda32a"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":10,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"rintaro"}}