{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/201929875","pull_request_review_id":136526031,"id":201929875,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTkyOTg3NQ==","diff_hunk":"@@ -98,6 +98,11 @@ func (scope *RequestScope) AllowsStreamSchema(s string) bool {\n // ConnectResource returns a function that handles a connect request on a rest.Storage object.\n func ConnectResource(connecter rest.Connecter, scope RequestScope, admit admission.Interface, restPath string, isSubresource bool) http.HandlerFunc {\n \treturn func(w http.ResponseWriter, req *http.Request) {\n+\t\tif isDryRun(req.URL) {","path":"staging/src/k8s.io/apiserver/pkg/endpoints/handlers/rest.go","position":4,"original_position":4,"commit_id":"702937ac8614a05d3168c6565bea8a3347883dc0","original_commit_id":"702937ac8614a05d3168c6565bea8a3347883dc0","user":{"login":"yue9944882","id":12049380,"node_id":"MDQ6VXNlcjEyMDQ5Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/12049380?v=4","gravatar_id":"","url":"https://api.github.com/users/yue9944882","html_url":"https://github.com/yue9944882","followers_url":"https://api.github.com/users/yue9944882/followers","following_url":"https://api.github.com/users/yue9944882/following{/other_user}","gists_url":"https://api.github.com/users/yue9944882/gists{/gist_id}","starred_url":"https://api.github.com/users/yue9944882/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yue9944882/subscriptions","organizations_url":"https://api.github.com/users/yue9944882/orgs","repos_url":"https://api.github.com/users/yue9944882/repos","events_url":"https://api.github.com/users/yue9944882/events{/privacy}","received_events_url":"https://api.github.com/users/yue9944882/received_events","type":"User","site_admin":false},"body":"Hi @jennybuckley , if we were to forbid dryRun requests for all verbs, why not do this via an HTTP handler filter. 😃","created_at":"2018-07-12T07:11:10Z","updated_at":"2018-07-12T07:11:10Z","html_url":"https://github.com/kubernetes/kubernetes/pull/66083#discussion_r201929875","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66083","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/201929875"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/66083#discussion_r201929875"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66083"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66083","id":200792693,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNzkyNjkz","html_url":"https://github.com/kubernetes/kubernetes/pull/66083","diff_url":"https://github.com/kubernetes/kubernetes/pull/66083.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/66083.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66083","number":66083,"state":"open","locked":false,"title":"Explicitly disable dry run for connect","user":{"login":"jennybuckley","id":31416425,"node_id":"MDQ6VXNlcjMxNDE2NDI1","avatar_url":"https://avatars2.githubusercontent.com/u/31416425?v=4","gravatar_id":"","url":"https://api.github.com/users/jennybuckley","html_url":"https://github.com/jennybuckley","followers_url":"https://api.github.com/users/jennybuckley/followers","following_url":"https://api.github.com/users/jennybuckley/following{/other_user}","gists_url":"https://api.github.com/users/jennybuckley/gists{/gist_id}","starred_url":"https://api.github.com/users/jennybuckley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jennybuckley/subscriptions","organizations_url":"https://api.github.com/users/jennybuckley/orgs","repos_url":"https://api.github.com/users/jennybuckley/repos","events_url":"https://api.github.com/users/jennybuckley/events{/privacy}","received_events_url":"https://api.github.com/users/jennybuckley/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nIt isn't clear whether or not dry run would work on connect. I think we should explicitly disable it so no one can try to dry run a connect request and accidentally open a connection.\r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2018-07-11T18:47:47Z","updated_at":"2018-07-12T07:11:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1e0ea7a998ac564472b373cb45ec9497505c621","assignee":null,"assignees":[],"requested_reviewers":[{"login":"caesarxuchao","id":2823529,"node_id":"MDQ6VXNlcjI4MjM1Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/2823529?v=4","gravatar_id":"","url":"https://api.github.com/users/caesarxuchao","html_url":"https://github.com/caesarxuchao","followers_url":"https://api.github.com/users/caesarxuchao/followers","following_url":"https://api.github.com/users/caesarxuchao/following{/other_user}","gists_url":"https://api.github.com/users/caesarxuchao/gists{/gist_id}","starred_url":"https://api.github.com/users/caesarxuchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesarxuchao/subscriptions","organizations_url":"https://api.github.com/users/caesarxuchao/orgs","repos_url":"https://api.github.com/users/caesarxuchao/repos","events_url":"https://api.github.com/users/caesarxuchao/events{/privacy}","received_events_url":"https://api.github.com/users/caesarxuchao/received_events","type":"User","site_admin":false},{"login":"tallclair","id":29742491,"node_id":"MDQ6VXNlcjI5NzQyNDkx","avatar_url":"https://avatars1.githubusercontent.com/u/29742491?v=4","gravatar_id":"","url":"https://api.github.com/users/tallclair","html_url":"https://github.com/tallclair","followers_url":"https://api.github.com/users/tallclair/followers","following_url":"https://api.github.com/users/tallclair/following{/other_user}","gists_url":"https://api.github.com/users/tallclair/gists{/gist_id}","starred_url":"https://api.github.com/users/tallclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tallclair/subscriptions","organizations_url":"https://api.github.com/users/tallclair/orgs","repos_url":"https://api.github.com/users/tallclair/repos","events_url":"https://api.github.com/users/tallclair/events{/privacy}","received_events_url":"https://api.github.com/users/tallclair/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173493835,"node_id":"MDU6TGFiZWwxNzM0OTM4MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":253450793,"node_id":"MDU6TGFiZWwyNTM0NTA3OTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66083/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66083/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66083/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/702937ac8614a05d3168c6565bea8a3347883dc0","head":{"label":"jennybuckley:connect-dry-run","ref":"connect-dry-run","sha":"702937ac8614a05d3168c6565bea8a3347883dc0","user":{"login":"jennybuckley","id":31416425,"node_id":"MDQ6VXNlcjMxNDE2NDI1","avatar_url":"https://avatars2.githubusercontent.com/u/31416425?v=4","gravatar_id":"","url":"https://api.github.com/users/jennybuckley","html_url":"https://github.com/jennybuckley","followers_url":"https://api.github.com/users/jennybuckley/followers","following_url":"https://api.github.com/users/jennybuckley/following{/other_user}","gists_url":"https://api.github.com/users/jennybuckley/gists{/gist_id}","starred_url":"https://api.github.com/users/jennybuckley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jennybuckley/subscriptions","organizations_url":"https://api.github.com/users/jennybuckley/orgs","repos_url":"https://api.github.com/users/jennybuckley/repos","events_url":"https://api.github.com/users/jennybuckley/events{/privacy}","received_events_url":"https://api.github.com/users/jennybuckley/received_events","type":"User","site_admin":false},"repo":{"id":101671907,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE2NzE5MDc=","name":"kubernetes","full_name":"jennybuckley/kubernetes","owner":{"login":"jennybuckley","id":31416425,"node_id":"MDQ6VXNlcjMxNDE2NDI1","avatar_url":"https://avatars2.githubusercontent.com/u/31416425?v=4","gravatar_id":"","url":"https://api.github.com/users/jennybuckley","html_url":"https://github.com/jennybuckley","followers_url":"https://api.github.com/users/jennybuckley/followers","following_url":"https://api.github.com/users/jennybuckley/following{/other_user}","gists_url":"https://api.github.com/users/jennybuckley/gists{/gist_id}","starred_url":"https://api.github.com/users/jennybuckley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jennybuckley/subscriptions","organizations_url":"https://api.github.com/users/jennybuckley/orgs","repos_url":"https://api.github.com/users/jennybuckley/repos","events_url":"https://api.github.com/users/jennybuckley/events{/privacy}","received_events_url":"https://api.github.com/users/jennybuckley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jennybuckley/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/jennybuckley/kubernetes","forks_url":"https://api.github.com/repos/jennybuckley/kubernetes/forks","keys_url":"https://api.github.com/repos/jennybuckley/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jennybuckley/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jennybuckley/kubernetes/teams","hooks_url":"https://api.github.com/repos/jennybuckley/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/jennybuckley/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/jennybuckley/kubernetes/events","assignees_url":"https://api.github.com/repos/jennybuckley/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/jennybuckley/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/jennybuckley/kubernetes/tags","blobs_url":"https://api.github.com/repos/jennybuckley/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jennybuckley/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jennybuckley/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/jennybuckley/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jennybuckley/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/jennybuckley/kubernetes/languages","stargazers_url":"https://api.github.com/repos/jennybuckley/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/jennybuckley/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/jennybuckley/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/jennybuckley/kubernetes/subscription","commits_url":"https://api.github.com/repos/jennybuckley/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/jennybuckley/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/jennybuckley/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/jennybuckley/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/jennybuckley/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/jennybuckley/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jennybuckley/kubernetes/merges","archive_url":"https://api.github.com/repos/jennybuckley/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jennybuckley/kubernetes/downloads","issues_url":"https://api.github.com/repos/jennybuckley/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/jennybuckley/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/jennybuckley/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/jennybuckley/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jennybuckley/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/jennybuckley/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/jennybuckley/kubernetes/deployments","created_at":"2017-08-28T18:02:24Z","updated_at":"2018-05-31T23:27:49Z","pushed_at":"2018-07-11T18:45:54Z","git_url":"git://github.com/jennybuckley/kubernetes.git","ssh_url":"git@github.com:jennybuckley/kubernetes.git","clone_url":"https://github.com/jennybuckley/kubernetes.git","svn_url":"https://github.com/jennybuckley/kubernetes","homepage":"http://kubernetes.io","size":570021,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"82c986ecbcdf99a87cd12a7e2cf64f90057b9acd","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-07-12T06:41:20Z","pushed_at":"2018-07-12T07:04:22Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":792562,"stargazers_count":38617,"watchers_count":38617,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13511,"mirror_url":null,"archived":false,"open_issues_count":3091,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13511,"open_issues":3091,"watchers":38617,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66083"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/66083"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/66083"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/66083/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66083/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66083/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/702937ac8614a05d3168c6565bea8a3347883dc0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yue9944882"}}