{"action":"created","issue":{"url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/issues/221","repository_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile","labels_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/issues/221/labels{/name}","comments_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/issues/221/comments","events_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/issues/221/events","html_url":"https://github.com/wordpress-mobile/gutenberg-mobile/issues/221","id":377740886,"node_id":"MDU6SXNzdWUzNzc3NDA4ODY=","number":221,"title":"Support for links in RichText","user":{"login":"koke","id":8739,"node_id":"MDQ6VXNlcjg3Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/8739?v=4","gravatar_id":"","url":"https://api.github.com/users/koke","html_url":"https://github.com/koke","followers_url":"https://api.github.com/users/koke/followers","following_url":"https://api.github.com/users/koke/following{/other_user}","gists_url":"https://api.github.com/users/koke/gists{/gist_id}","starred_url":"https://api.github.com/users/koke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koke/subscriptions","organizations_url":"https://api.github.com/users/koke/orgs","repos_url":"https://api.github.com/users/koke/repos","events_url":"https://api.github.com/users/koke/events{/privacy}","received_events_url":"https://api.github.com/users/koke/received_events","type":"User","site_admin":false},"labels":[{"id":1091652407,"node_id":"MDU6TGFiZWwxMDkxNjUyNDA3","url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/labels/Blocks","name":"Blocks","color":"fbca04","default":false},{"id":1092865481,"node_id":"MDU6TGFiZWwxMDkyODY1NDgx","url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/labels/Needs%20Estimation","name":"Needs Estimation","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/milestones/4","html_url":"https://github.com/wordpress-mobile/gutenberg-mobile/milestone/4","labels_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/milestones/4/labels","id":3738550,"node_id":"MDk6TWlsZXN0b25lMzczODU1MA==","number":4,"title":"Alpha","description":"We will have an alpha release at the end of the year that will showcase the editing flow with some selected basic blocks. We will have a basic integration with the apps, enough to be able to experience Gutenberg (via secret opt-in or special builds), but won’t be showing this to users. Being able to use early versions of Gutenberg directly in the apps will make it easier to gather feedback and do user testing.","creator":{"login":"koke","id":8739,"node_id":"MDQ6VXNlcjg3Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/8739?v=4","gravatar_id":"","url":"https://api.github.com/users/koke","html_url":"https://github.com/koke","followers_url":"https://api.github.com/users/koke/followers","following_url":"https://api.github.com/users/koke/following{/other_user}","gists_url":"https://api.github.com/users/koke/gists{/gist_id}","starred_url":"https://api.github.com/users/koke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koke/subscriptions","organizations_url":"https://api.github.com/users/koke/orgs","repos_url":"https://api.github.com/users/koke/repos","events_url":"https://api.github.com/users/koke/events{/privacy}","received_events_url":"https://api.github.com/users/koke/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":15,"state":"open","created_at":"2018-10-15T08:59:36Z","updated_at":"2018-11-23T14:29:31Z","due_on":"2018-12-14T08:00:00Z","closed_at":null},"comments":2,"created_at":"2018-11-06T08:36:14Z","updated_at":"2018-11-26T11:03:43Z","closed_at":null,"author_association":"MEMBER","body":"We currently have basic styling options but we don't support adding and editing links yet.\r\n\r\nFor reference, here's how adding a link looks in Aztec:\r\n\r\n![screenshot_20181105-203619_wordpress](https://user-images.githubusercontent.com/8739/48051813-6f202b00-e1a6-11e8-8aa8-0f91816d2eed.jpg)\r\n![img_b0ad85e2b58f-1 1](https://user-images.githubusercontent.com/8739/48051815-70e9ee80-e1a6-11e8-826a-344e30b4a892.jpeg)\r\n\r\nAnd how the add/edit UI looks on the web:\r\n\r\n<img width=\"413\" alt=\"screen shot 2018-11-06 at 09 29 52\" src=\"https://user-images.githubusercontent.com/8739/48051875-9ecf3300-e1a6-11e8-8a34-66f23b834d50.png\">\r\n<img width=\"432\" alt=\"screen shot 2018-11-06 at 09 30 20\" src=\"https://user-images.githubusercontent.com/8739/48051878-a098f680-e1a6-11e8-9d3a-8111f806c446.png\">\r\n\r\nI think for the alpha we could do with the simpler approach we can implement (a dialog) but we should do some design explorations for the beta. I'm not sure the existing floating UI that we have on the web will work great on mobile. cc @iamthomasbishop "},"comment":{"url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/issues/comments/441600954","html_url":"https://github.com/wordpress-mobile/gutenberg-mobile/issues/221#issuecomment-441600954","issue_url":"https://api.github.com/repos/wordpress-mobile/gutenberg-mobile/issues/221","id":441600954,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTYwMDk1NA==","user":{"login":"koke","id":8739,"node_id":"MDQ6VXNlcjg3Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/8739?v=4","gravatar_id":"","url":"https://api.github.com/users/koke","html_url":"https://github.com/koke","followers_url":"https://api.github.com/users/koke/followers","following_url":"https://api.github.com/users/koke/following{/other_user}","gists_url":"https://api.github.com/users/koke/gists{/gist_id}","starred_url":"https://api.github.com/users/koke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koke/subscriptions","organizations_url":"https://api.github.com/users/koke/orgs","repos_url":"https://api.github.com/users/koke/repos","events_url":"https://api.github.com/users/koke/events{/privacy}","received_events_url":"https://api.github.com/users/koke/received_events","type":"User","site_admin":false},"created_at":"2018-11-26T11:03:43Z","updated_at":"2018-11-26T11:03:43Z","author_association":"MEMBER","body":"Another update. I managed to make the format-library work in #275, although it's not working great.\r\nI'm seeing some issues with `isSelected` where sometimes a button won't change the format and sometimes you'd see more than one button of each kind in the toolbar.\r\n\r\nWhen it works, it only does so for selected text, not for changing the format as you type. The reason for this is that `applyFormat` uses a `formatPlaceholder` for the typing formats, which doesn't directly translate into HTML. I tried to port `applyRecord` to native, but I was hitting an error with jsdom. One of the RichText DOM manipulation functions (`apply`) creates an empty DOM that it then places the new record into, then it both traverses the old and new DOM trees to decide what to change, using `replaceChild`, `appendChild`, and `removeChild`. The jsdom implementation of these functions will throw an exception if the nodes have different parent documents.\r\n\r\nI started thinking of an approach where we could just feed the changed record to aztec, but it sounds really hard an in the wrong direction, so I'm thinking the next goods step might be trying to make jsdom OK with that.\r\n\r\nOther than that, we still have to build the whole link editing UI: if you tap the link button now it'll crash\r\n\r\n"}}
{"actor":{"display_login":"koke"}}