{"action":"created","comment":{"url":"https://api.github.com/repos/gomods/athens/pulls/comments/212113889","pull_request_review_id":148678311,"id":212113889,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjExMzg4OQ==","diff_hunk":"@@ -120,6 +112,25 @@ func getSources(goBinaryName string, fs afero.Fs, gopath, repoRoot, module, vers\n \treturn nil\n }\n \n+func prepareEnv(gopath string) []string {\n+\tpathEnv := fmt.Sprintf(\"PATH=%s\", os.Getenv(\"PATH\"))\n+\tgopathEnv := fmt.Sprintf(\"GOPATH=%s\", gopath)\n+\tcacheEnv := fmt.Sprintf(\"GOCACHE=%s\", filepath.Join(gopath, \"cache\"))\n+\tdisableCgo := \"CGO_ENABLED=0\"\n+\tenableGoModules := \"GO111MODULE=on\"\n+\tcmdEnv := []string{pathEnv, gopathEnv, cacheEnv, disableCgo, enableGoModules}\n+\t// add Windows specific ENV VARS\n+\t// if this one is missing we will get an error from go\n+\tif val, ok := os.LookupEnv(\"USERPROFILE\"); ok {\n+\t\tcmdEnv = append(cmdEnv, fmt.Sprintf(\"USERPROFILE=%s\", val))\n+\t}\n+\t// if this one is missing go won't give any error but the pkg/mod dir will be empty","path":"pkg/module/go_get_fetcher.go","position":36,"original_position":36,"commit_id":"40e5bea11cc466b7f11ffff8d159c5e2c68466a2","original_commit_id":"40e5bea11cc466b7f11ffff8d159c5e2c68466a2","user":{"login":"michalpristas","id":1522652,"node_id":"MDQ6VXNlcjE1MjI2NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1522652?v=4","gravatar_id":"","url":"https://api.github.com/users/michalpristas","html_url":"https://github.com/michalpristas","followers_url":"https://api.github.com/users/michalpristas/followers","following_url":"https://api.github.com/users/michalpristas/following{/other_user}","gists_url":"https://api.github.com/users/michalpristas/gists{/gist_id}","starred_url":"https://api.github.com/users/michalpristas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalpristas/subscriptions","organizations_url":"https://api.github.com/users/michalpristas/orgs","repos_url":"https://api.github.com/users/michalpristas/repos","events_url":"https://api.github.com/users/michalpristas/events{/privacy}","received_events_url":"https://api.github.com/users/michalpristas/received_events","type":"User","site_admin":false},"body":"let end up with an error then, with empty packages proxy is not fulfilling its purpose","created_at":"2018-08-22T21:19:14Z","updated_at":"2018-08-22T21:19:14Z","html_url":"https://github.com/gomods/athens/pull/554#discussion_r212113889","pull_request_url":"https://api.github.com/repos/gomods/athens/pulls/554","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gomods/athens/pulls/comments/212113889"},"html":{"href":"https://github.com/gomods/athens/pull/554#discussion_r212113889"},"pull_request":{"href":"https://api.github.com/repos/gomods/athens/pulls/554"}}},"pull_request":{"url":"https://api.github.com/repos/gomods/athens/pulls/554","id":210081044,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMDgxMDQ0","html_url":"https://github.com/gomods/athens/pull/554","diff_url":"https://github.com/gomods/athens/pull/554.diff","patch_url":"https://github.com/gomods/athens/pull/554.patch","issue_url":"https://api.github.com/repos/gomods/athens/issues/554","number":554,"state":"open","locked":false,"title":"Fix running the athens proxy on windows","user":{"login":"marpio","id":1334824,"node_id":"MDQ6VXNlcjEzMzQ4MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1334824?v=4","gravatar_id":"","url":"https://api.github.com/users/marpio","html_url":"https://github.com/marpio","followers_url":"https://api.github.com/users/marpio/followers","following_url":"https://api.github.com/users/marpio/following{/other_user}","gists_url":"https://api.github.com/users/marpio/gists{/gist_id}","starred_url":"https://api.github.com/users/marpio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marpio/subscriptions","organizations_url":"https://api.github.com/users/marpio/orgs","repos_url":"https://api.github.com/users/marpio/repos","events_url":"https://api.github.com/users/marpio/events{/privacy}","received_events_url":"https://api.github.com/users/marpio/received_events","type":"User","site_admin":false},"body":"Fixes #532 \r\nApparently on Windows `go mod` requires some additional ENV vars which we didn't pass so I'm using the parent environment and overriding the relevant ones.","created_at":"2018-08-22T10:02:22Z","updated_at":"2018-08-22T21:19:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bbde60782293fb2e9b6f9c8f874cbe389113726","assignee":null,"assignees":[],"requested_reviewers":[{"login":"carolynvs","id":1368985,"node_id":"MDQ6VXNlcjEzNjg5ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/1368985?v=4","gravatar_id":"","url":"https://api.github.com/users/carolynvs","html_url":"https://github.com/carolynvs","followers_url":"https://api.github.com/users/carolynvs/followers","following_url":"https://api.github.com/users/carolynvs/following{/other_user}","gists_url":"https://api.github.com/users/carolynvs/gists{/gist_id}","starred_url":"https://api.github.com/users/carolynvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carolynvs/subscriptions","organizations_url":"https://api.github.com/users/carolynvs/orgs","repos_url":"https://api.github.com/users/carolynvs/repos","events_url":"https://api.github.com/users/carolynvs/events{/privacy}","received_events_url":"https://api.github.com/users/carolynvs/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gomods/athens/pulls/554/commits","review_comments_url":"https://api.github.com/repos/gomods/athens/pulls/554/comments","review_comment_url":"https://api.github.com/repos/gomods/athens/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gomods/athens/issues/554/comments","statuses_url":"https://api.github.com/repos/gomods/athens/statuses/40e5bea11cc466b7f11ffff8d159c5e2c68466a2","head":{"label":"marpio:fix_win","ref":"fix_win","sha":"40e5bea11cc466b7f11ffff8d159c5e2c68466a2","user":{"login":"marpio","id":1334824,"node_id":"MDQ6VXNlcjEzMzQ4MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1334824?v=4","gravatar_id":"","url":"https://api.github.com/users/marpio","html_url":"https://github.com/marpio","followers_url":"https://api.github.com/users/marpio/followers","following_url":"https://api.github.com/users/marpio/following{/other_user}","gists_url":"https://api.github.com/users/marpio/gists{/gist_id}","starred_url":"https://api.github.com/users/marpio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marpio/subscriptions","organizations_url":"https://api.github.com/users/marpio/orgs","repos_url":"https://api.github.com/users/marpio/repos","events_url":"https://api.github.com/users/marpio/events{/privacy}","received_events_url":"https://api.github.com/users/marpio/received_events","type":"User","site_admin":false},"repo":{"id":126237724,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYyMzc3MjQ=","name":"athens","full_name":"marpio/athens","owner":{"login":"marpio","id":1334824,"node_id":"MDQ6VXNlcjEzMzQ4MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1334824?v=4","gravatar_id":"","url":"https://api.github.com/users/marpio","html_url":"https://github.com/marpio","followers_url":"https://api.github.com/users/marpio/followers","following_url":"https://api.github.com/users/marpio/following{/other_user}","gists_url":"https://api.github.com/users/marpio/gists{/gist_id}","starred_url":"https://api.github.com/users/marpio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marpio/subscriptions","organizations_url":"https://api.github.com/users/marpio/orgs","repos_url":"https://api.github.com/users/marpio/repos","events_url":"https://api.github.com/users/marpio/events{/privacy}","received_events_url":"https://api.github.com/users/marpio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marpio/athens","description":"A proxy server and registry for vgo","fork":true,"url":"https://api.github.com/repos/marpio/athens","forks_url":"https://api.github.com/repos/marpio/athens/forks","keys_url":"https://api.github.com/repos/marpio/athens/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marpio/athens/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marpio/athens/teams","hooks_url":"https://api.github.com/repos/marpio/athens/hooks","issue_events_url":"https://api.github.com/repos/marpio/athens/issues/events{/number}","events_url":"https://api.github.com/repos/marpio/athens/events","assignees_url":"https://api.github.com/repos/marpio/athens/assignees{/user}","branches_url":"https://api.github.com/repos/marpio/athens/branches{/branch}","tags_url":"https://api.github.com/repos/marpio/athens/tags","blobs_url":"https://api.github.com/repos/marpio/athens/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marpio/athens/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marpio/athens/git/refs{/sha}","trees_url":"https://api.github.com/repos/marpio/athens/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marpio/athens/statuses/{sha}","languages_url":"https://api.github.com/repos/marpio/athens/languages","stargazers_url":"https://api.github.com/repos/marpio/athens/stargazers","contributors_url":"https://api.github.com/repos/marpio/athens/contributors","subscribers_url":"https://api.github.com/repos/marpio/athens/subscribers","subscription_url":"https://api.github.com/repos/marpio/athens/subscription","commits_url":"https://api.github.com/repos/marpio/athens/commits{/sha}","git_commits_url":"https://api.github.com/repos/marpio/athens/git/commits{/sha}","comments_url":"https://api.github.com/repos/marpio/athens/comments{/number}","issue_comment_url":"https://api.github.com/repos/marpio/athens/issues/comments{/number}","contents_url":"https://api.github.com/repos/marpio/athens/contents/{+path}","compare_url":"https://api.github.com/repos/marpio/athens/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marpio/athens/merges","archive_url":"https://api.github.com/repos/marpio/athens/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marpio/athens/downloads","issues_url":"https://api.github.com/repos/marpio/athens/issues{/number}","pulls_url":"https://api.github.com/repos/marpio/athens/pulls{/number}","milestones_url":"https://api.github.com/repos/marpio/athens/milestones{/number}","notifications_url":"https://api.github.com/repos/marpio/athens/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marpio/athens/labels{/name}","releases_url":"https://api.github.com/repos/marpio/athens/releases{/id}","deployments_url":"https://api.github.com/repos/marpio/athens/deployments","created_at":"2018-03-21T20:39:00Z","updated_at":"2018-05-15T20:23:28Z","pushed_at":"2018-08-22T21:07:49Z","git_url":"git://github.com/marpio/athens.git","ssh_url":"git@github.com:marpio/athens.git","clone_url":"https://github.com/marpio/athens.git","svn_url":"https://github.com/marpio/athens","homepage":"https://research.swtch.com/vgo-module","size":57127,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gomods:master","ref":"master","sha":"e4659ecea53ace7dd8b9fa09760281046506e1c9","user":{"login":"gomods","id":36861827,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2ODYxODI3","avatar_url":"https://avatars3.githubusercontent.com/u/36861827?v=4","gravatar_id":"","url":"https://api.github.com/users/gomods","html_url":"https://github.com/gomods","followers_url":"https://api.github.com/users/gomods/followers","following_url":"https://api.github.com/users/gomods/following{/other_user}","gists_url":"https://api.github.com/users/gomods/gists{/gist_id}","starred_url":"https://api.github.com/users/gomods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gomods/subscriptions","organizations_url":"https://api.github.com/users/gomods/orgs","repos_url":"https://api.github.com/users/gomods/repos","events_url":"https://api.github.com/users/gomods/events{/privacy}","received_events_url":"https://api.github.com/users/gomods/received_events","type":"Organization","site_admin":false},"repo":{"id":122872932,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI4NzI5MzI=","name":"athens","full_name":"gomods/athens","owner":{"login":"gomods","id":36861827,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2ODYxODI3","avatar_url":"https://avatars3.githubusercontent.com/u/36861827?v=4","gravatar_id":"","url":"https://api.github.com/users/gomods","html_url":"https://github.com/gomods","followers_url":"https://api.github.com/users/gomods/followers","following_url":"https://api.github.com/users/gomods/following{/other_user}","gists_url":"https://api.github.com/users/gomods/gists{/gist_id}","starred_url":"https://api.github.com/users/gomods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gomods/subscriptions","organizations_url":"https://api.github.com/users/gomods/orgs","repos_url":"https://api.github.com/users/gomods/repos","events_url":"https://api.github.com/users/gomods/events{/privacy}","received_events_url":"https://api.github.com/users/gomods/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gomods/athens","description":"A Go module datastore and proxy","fork":false,"url":"https://api.github.com/repos/gomods/athens","forks_url":"https://api.github.com/repos/gomods/athens/forks","keys_url":"https://api.github.com/repos/gomods/athens/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gomods/athens/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gomods/athens/teams","hooks_url":"https://api.github.com/repos/gomods/athens/hooks","issue_events_url":"https://api.github.com/repos/gomods/athens/issues/events{/number}","events_url":"https://api.github.com/repos/gomods/athens/events","assignees_url":"https://api.github.com/repos/gomods/athens/assignees{/user}","branches_url":"https://api.github.com/repos/gomods/athens/branches{/branch}","tags_url":"https://api.github.com/repos/gomods/athens/tags","blobs_url":"https://api.github.com/repos/gomods/athens/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gomods/athens/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gomods/athens/git/refs{/sha}","trees_url":"https://api.github.com/repos/gomods/athens/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gomods/athens/statuses/{sha}","languages_url":"https://api.github.com/repos/gomods/athens/languages","stargazers_url":"https://api.github.com/repos/gomods/athens/stargazers","contributors_url":"https://api.github.com/repos/gomods/athens/contributors","subscribers_url":"https://api.github.com/repos/gomods/athens/subscribers","subscription_url":"https://api.github.com/repos/gomods/athens/subscription","commits_url":"https://api.github.com/repos/gomods/athens/commits{/sha}","git_commits_url":"https://api.github.com/repos/gomods/athens/git/commits{/sha}","comments_url":"https://api.github.com/repos/gomods/athens/comments{/number}","issue_comment_url":"https://api.github.com/repos/gomods/athens/issues/comments{/number}","contents_url":"https://api.github.com/repos/gomods/athens/contents/{+path}","compare_url":"https://api.github.com/repos/gomods/athens/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gomods/athens/merges","archive_url":"https://api.github.com/repos/gomods/athens/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gomods/athens/downloads","issues_url":"https://api.github.com/repos/gomods/athens/issues{/number}","pulls_url":"https://api.github.com/repos/gomods/athens/pulls{/number}","milestones_url":"https://api.github.com/repos/gomods/athens/milestones{/number}","notifications_url":"https://api.github.com/repos/gomods/athens/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gomods/athens/labels{/name}","releases_url":"https://api.github.com/repos/gomods/athens/releases{/id}","deployments_url":"https://api.github.com/repos/gomods/athens/deployments","created_at":"2018-02-25T20:19:41Z","updated_at":"2018-08-22T21:16:10Z","pushed_at":"2018-08-22T21:07:50Z","git_url":"git://github.com/gomods/athens.git","ssh_url":"git@github.com:gomods/athens.git","clone_url":"https://github.com/gomods/athens.git","svn_url":"https://github.com/gomods/athens","homepage":"https://docs.gomods.io","size":49222,"stargazers_count":540,"watchers_count":540,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":114,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":58,"open_issues":114,"watchers":540,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gomods/athens/pulls/554"},"html":{"href":"https://github.com/gomods/athens/pull/554"},"issue":{"href":"https://api.github.com/repos/gomods/athens/issues/554"},"comments":{"href":"https://api.github.com/repos/gomods/athens/issues/554/comments"},"review_comments":{"href":"https://api.github.com/repos/gomods/athens/pulls/554/comments"},"review_comment":{"href":"https://api.github.com/repos/gomods/athens/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gomods/athens/pulls/554/commits"},"statuses":{"href":"https://api.github.com/repos/gomods/athens/statuses/40e5bea11cc466b7f11ffff8d159c5e2c68466a2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"michalpristas"}}