{"action":"created","issue":{"url":"https://api.github.com/repos/uswitch/kiam/issues/187","repository_url":"https://api.github.com/repos/uswitch/kiam","labels_url":"https://api.github.com/repos/uswitch/kiam/issues/187/labels{/name}","comments_url":"https://api.github.com/repos/uswitch/kiam/issues/187/comments","events_url":"https://api.github.com/repos/uswitch/kiam/issues/187/events","html_url":"https://github.com/uswitch/kiam/issues/187","id":384865896,"node_id":"MDU6SXNzdWUzODQ4NjU4OTY=","number":187,"title":"Fix metric naming /Grafana Dashboard","user":{"login":"Joseph-Irving","id":15195889,"node_id":"MDQ6VXNlcjE1MTk1ODg5","avatar_url":"https://avatars3.githubusercontent.com/u/15195889?v=4","gravatar_id":"","url":"https://api.github.com/users/Joseph-Irving","html_url":"https://github.com/Joseph-Irving","followers_url":"https://api.github.com/users/Joseph-Irving/followers","following_url":"https://api.github.com/users/Joseph-Irving/following{/other_user}","gists_url":"https://api.github.com/users/Joseph-Irving/gists{/gist_id}","starred_url":"https://api.github.com/users/Joseph-Irving/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joseph-Irving/subscriptions","organizations_url":"https://api.github.com/users/Joseph-Irving/orgs","repos_url":"https://api.github.com/users/Joseph-Irving/repos","events_url":"https://api.github.com/users/Joseph-Irving/events{/privacy}","received_events_url":"https://api.github.com/users/Joseph-Irving/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-27T16:00:43Z","updated_at":"2018-11-28T16:22:46Z","closed_at":null,"author_association":"MEMBER","body":"We have a few metrics that seem to be incorrectly called \r\n`kiam_metadata_handler_latency_milliseconds`\r\n`kiam_sts_assumerole_timing_milliseconds`\r\ndespite being in seconds. Which is causing some confusion.\r\n\r\nAlso on the example dashboard Credentials/rolehandler response time graphs don't seem to be showing what their name would suggest, it's doing a sum(irate(histogram_bucket)) which does not give you the response times in seconds. I'm not exactly sure what that does give you.\r\n\r\nAs this is a histogram it would make more sense to plot things like 90, 95, 99th percentile etc e.g: `histogram_quantile(0.95, sum(rate(kiam_metadata_handler_latency_milliseconds_bucket[5m])) by (le))`\r\n\r\nWe could also calculate the average response time with\r\n`rate(kiam_metadata_handler_latency_milliseconds_sum[5m])/rate(kiam_metadata_handler_latency_milliseconds_count[5m])`\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/uswitch/kiam/issues/comments/442508716","html_url":"https://github.com/uswitch/kiam/issues/187#issuecomment-442508716","issue_url":"https://api.github.com/repos/uswitch/kiam/issues/187","id":442508716,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjUwODcxNg==","user":{"login":"pingles","id":1150,"node_id":"MDQ6VXNlcjExNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/1150?v=4","gravatar_id":"","url":"https://api.github.com/users/pingles","html_url":"https://github.com/pingles","followers_url":"https://api.github.com/users/pingles/followers","following_url":"https://api.github.com/users/pingles/following{/other_user}","gists_url":"https://api.github.com/users/pingles/gists{/gist_id}","starred_url":"https://api.github.com/users/pingles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingles/subscriptions","organizations_url":"https://api.github.com/users/pingles/orgs","repos_url":"https://api.github.com/users/pingles/repos","events_url":"https://api.github.com/users/pingles/events{/privacy}","received_events_url":"https://api.github.com/users/pingles/received_events","type":"User","site_admin":false},"created_at":"2018-11-28T16:22:46Z","updated_at":"2018-11-28T16:22:46Z","author_association":"CONTRIBUTOR","body":"I'm going to mark this as something we should resolve before the final v3 release (maybe one more rc on the way 😄); it'll be a huge pain to have to sort this later."}}
{"actor":{"display_login":"pingles"}}