{"action":"created","issue":{"url":"https://api.github.com/repos/mansj/enable-media-replace/issues/31","repository_url":"https://api.github.com/repos/mansj/enable-media-replace","labels_url":"https://api.github.com/repos/mansj/enable-media-replace/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/mansj/enable-media-replace/issues/31/comments","events_url":"https://api.github.com/repos/mansj/enable-media-replace/issues/31/events","html_url":"https://github.com/mansj/enable-media-replace/issues/31","id":250043028,"number":31,"title":"Plugin does not work with stream wrappers for media held off the filesystem.","user":{"login":"philipowen","id":22501280,"avatar_url":"https://avatars0.githubusercontent.com/u/22501280?v=4","gravatar_id":"","url":"https://api.github.com/users/philipowen","html_url":"https://github.com/philipowen","followers_url":"https://api.github.com/users/philipowen/followers","following_url":"https://api.github.com/users/philipowen/following{/other_user}","gists_url":"https://api.github.com/users/philipowen/gists{/gist_id}","starred_url":"https://api.github.com/users/philipowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philipowen/subscriptions","organizations_url":"https://api.github.com/users/philipowen/orgs","repos_url":"https://api.github.com/users/philipowen/repos","events_url":"https://api.github.com/users/philipowen/events{/privacy}","received_events_url":"https://api.github.com/users/philipowen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-08-14T14:12:12Z","updated_at":"2018-03-02T16:23:44Z","closed_at":null,"author_association":"NONE","body":"We us an Amazon S3 storage plugin that stores all the media in an S3 bucket. This means that the files are referred to as `s3://bucket/folder/file`. [Line 206 of upload.php](https://github.com/mansj/enable-media-replace/blame/master/upload.php#L206) is doing a replace on double forward slashes to convert to a single one, which breaks the protocol handler detection and causes the plugin to fail. Commenting out that line makes the plugin work correctly for files of the format `protocol://foo/bar`.\r\n\r\nI'm happy to put a PR up, but wanted to know the best way to address this. It isn't obvious to me what case that replace is covering, but it is clearly there for a reason. Would it be okay to only run that replace where the `//` isn't preceded by a `:`? Or is there some better logic?\r\n\r\nMany thanks."},"comment":{"url":"https://api.github.com/repos/mansj/enable-media-replace/issues/comments/369971663","html_url":"https://github.com/mansj/enable-media-replace/issues/31#issuecomment-369971663","issue_url":"https://api.github.com/repos/mansj/enable-media-replace/issues/31","id":369971663,"user":{"login":"tomtoday","id":2400,"avatar_url":"https://avatars3.githubusercontent.com/u/2400?v=4","gravatar_id":"","url":"https://api.github.com/users/tomtoday","html_url":"https://github.com/tomtoday","followers_url":"https://api.github.com/users/tomtoday/followers","following_url":"https://api.github.com/users/tomtoday/following{/other_user}","gists_url":"https://api.github.com/users/tomtoday/gists{/gist_id}","starred_url":"https://api.github.com/users/tomtoday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomtoday/subscriptions","organizations_url":"https://api.github.com/users/tomtoday/orgs","repos_url":"https://api.github.com/users/tomtoday/repos","events_url":"https://api.github.com/users/tomtoday/events{/privacy}","received_events_url":"https://api.github.com/users/tomtoday/received_events","type":"User","site_admin":false},"created_at":"2018-03-02T16:23:44Z","updated_at":"2018-03-02T16:23:44Z","author_association":"NONE","body":"Thanks! I'll give that a try.\r\n\r\nFWIW, I am very impressed with the frequency at which @mansj updates this code. I appreciate your work and effort."}}
{"actor":{"display_login":"tomtoday"}}