{"action":"created","comment":{"url":"https://api.github.com/repos/keboola/kbc-ui/pulls/comments/207834924","pull_request_review_id":143524826,"id":207834924,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzgzNDkyNA==","diff_hunk":"@@ -0,0 +1,102 @@\n+import assert from 'assert';\n+import {fromJS} from 'immutable';\n+import loadType from './loadType';\n+import {Types} from '../helpers/Constants';\n+\n+const tableId = 'in.some.table';\n+function makeParameters(body = {}) {","path":"src/scripts/modules/gooddata-writer-v3/adapters/loadType.spec.js","position":7,"original_position":7,"commit_id":"44fa4ce84fd759453a211f7db7dd69b0cec02687","original_commit_id":"44fa4ce84fd759453a211f7db7dd69b0cec02687","user":{"login":"kacurez","id":1412120,"node_id":"MDQ6VXNlcjE0MTIxMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1412120?v=4","gravatar_id":"","url":"https://api.github.com/users/kacurez","html_url":"https://github.com/kacurez","followers_url":"https://api.github.com/users/kacurez/followers","following_url":"https://api.github.com/users/kacurez/following{/other_user}","gists_url":"https://api.github.com/users/kacurez/gists{/gist_id}","starred_url":"https://api.github.com/users/kacurez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kacurez/subscriptions","organizations_url":"https://api.github.com/users/kacurez/orgs","repos_url":"https://api.github.com/users/kacurez/repos","events_url":"https://api.github.com/users/kacurez/events{/privacy}","received_events_url":"https://api.github.com/users/kacurez/received_events","type":"User","site_admin":false},"body":"ja sa nato pozeram tak ze cim viac rovnakeho kod skopirujem tym viac je to cele nachylne na chybu(more code ~= more errors) ktoru si nemusim vsimnut a testov je to zvlast blbe :)","created_at":"2018-08-06T09:56:03Z","updated_at":"2018-08-06T09:56:03Z","html_url":"https://github.com/keboola/kbc-ui/pull/1835#discussion_r207834924","pull_request_url":"https://api.github.com/repos/keboola/kbc-ui/pulls/1835","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/keboola/kbc-ui/pulls/comments/207834924"},"html":{"href":"https://github.com/keboola/kbc-ui/pull/1835#discussion_r207834924"},"pull_request":{"href":"https://api.github.com/repos/keboola/kbc-ui/pulls/1835"}},"in_reply_to_id":207833406},"pull_request":{"url":"https://api.github.com/repos/keboola/kbc-ui/pulls/1835","id":199009712,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MDA5NzEy","html_url":"https://github.com/keboola/kbc-ui/pull/1835","diff_url":"https://github.com/keboola/kbc-ui/pull/1835.diff","patch_url":"https://github.com/keboola/kbc-ui/pull/1835.patch","issue_url":"https://api.github.com/repos/keboola/kbc-ui/issues/1835","number":1835,"state":"open","locked":false,"title":"[R4R]: gooddata writer v3 - Finish him(in a next round)!","user":{"login":"kacurez","id":1412120,"node_id":"MDQ6VXNlcjE0MTIxMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1412120?v=4","gravatar_id":"","url":"https://api.github.com/users/kacurez","html_url":"https://github.com/kacurez","followers_url":"https://api.github.com/users/kacurez/followers","following_url":"https://api.github.com/users/kacurez/following{/other_user}","gists_url":"https://api.github.com/users/kacurez/gists{/gist_id}","starred_url":"https://api.github.com/users/kacurez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kacurez/subscriptions","organizations_url":"https://api.github.com/users/kacurez/orgs","repos_url":"https://api.github.com/users/kacurez/repos","events_url":"https://api.github.com/users/kacurez/events{/privacy}","received_events_url":"https://api.github.com/users/kacurez/received_events","type":"User","site_admin":false},"body":"Nakoniec to neni finalnizacny PR - este treba pripravit provisioning gd projektov a to radsej urobim v saostatnom PR. Tu to uzatvorim stym ze :\r\n\r\n- vacsinu kodu tvoria testy pre adatery https://github.com/keboola/kbc-ui/tree/kacurez-gdwrv3-finalization/src/scripts/modules/gooddata-writer-v3/adapters a helpre https://github.com/keboola/kbc-ui/tree/kacurez-gdwrv3-finalization/src/scripts/modules/gooddata-writer-v3/helpers\r\n- odstranene description z row table https://github.com/keboola/kbc-ui/pull/1835/commits/b1d4b7dd4da962959f7edf68547776a409fe1bf6 a https://github.com/keboola/kbc-ui/pull/1835/commits/109f9f88eea95290fff09ee4d39a65f4fcbdfdc2\r\n- prerobena sekcia `Dimensions` pre datumove dimenze\r\n![image](https://user-images.githubusercontent.com/1412120/42997033-a04988b6-8c15-11e8-98dc-a76c04060b80.png)\r\n- prerobena sekcia `Load Type` s changed since a fact grain\r\n![image](https://user-images.githubusercontent.com/1412120/42997129-eb308cee-8c15-11e8-9d99-eb65f9c0ea21.png)\r\n- sekciu `StorageTableColumnsEditor` som vobec neupravoval pretoze sa jej update riesi v https://github.com/keboola/kbc-ui/pull/1834#issuecomment-405960440\r\n","created_at":"2018-07-03T15:53:12Z","updated_at":"2018-08-06T09:56:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8cb2b25a5f403b29d461e96519db4698b505ee2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/keboola/kbc-ui/pulls/1835/commits","review_comments_url":"https://api.github.com/repos/keboola/kbc-ui/pulls/1835/comments","review_comment_url":"https://api.github.com/repos/keboola/kbc-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keboola/kbc-ui/issues/1835/comments","statuses_url":"https://api.github.com/repos/keboola/kbc-ui/statuses/44fa4ce84fd759453a211f7db7dd69b0cec02687","head":{"label":"keboola:kacurez-gdwrv3-finalization","ref":"kacurez-gdwrv3-finalization","sha":"44fa4ce84fd759453a211f7db7dd69b0cec02687","user":{"login":"keboola","id":1424387,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjQzODc=","avatar_url":"https://avatars1.githubusercontent.com/u/1424387?v=4","gravatar_id":"","url":"https://api.github.com/users/keboola","html_url":"https://github.com/keboola","followers_url":"https://api.github.com/users/keboola/followers","following_url":"https://api.github.com/users/keboola/following{/other_user}","gists_url":"https://api.github.com/users/keboola/gists{/gist_id}","starred_url":"https://api.github.com/users/keboola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keboola/subscriptions","organizations_url":"https://api.github.com/users/keboola/orgs","repos_url":"https://api.github.com/users/keboola/repos","events_url":"https://api.github.com/users/keboola/events{/privacy}","received_events_url":"https://api.github.com/users/keboola/received_events","type":"Organization","site_admin":false},"repo":{"id":26681387,"node_id":"MDEwOlJlcG9zaXRvcnkyNjY4MTM4Nw==","name":"kbc-ui","full_name":"keboola/kbc-ui","owner":{"login":"keboola","id":1424387,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjQzODc=","avatar_url":"https://avatars1.githubusercontent.com/u/1424387?v=4","gravatar_id":"","url":"https://api.github.com/users/keboola","html_url":"https://github.com/keboola","followers_url":"https://api.github.com/users/keboola/followers","following_url":"https://api.github.com/users/keboola/following{/other_user}","gists_url":"https://api.github.com/users/keboola/gists{/gist_id}","starred_url":"https://api.github.com/users/keboola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keboola/subscriptions","organizations_url":"https://api.github.com/users/keboola/orgs","repos_url":"https://api.github.com/users/keboola/repos","events_url":"https://api.github.com/users/keboola/events{/privacy}","received_events_url":"https://api.github.com/users/keboola/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keboola/kbc-ui","description":"User interface for Keboola Connection","fork":false,"url":"https://api.github.com/repos/keboola/kbc-ui","forks_url":"https://api.github.com/repos/keboola/kbc-ui/forks","keys_url":"https://api.github.com/repos/keboola/kbc-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keboola/kbc-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keboola/kbc-ui/teams","hooks_url":"https://api.github.com/repos/keboola/kbc-ui/hooks","issue_events_url":"https://api.github.com/repos/keboola/kbc-ui/issues/events{/number}","events_url":"https://api.github.com/repos/keboola/kbc-ui/events","assignees_url":"https://api.github.com/repos/keboola/kbc-ui/assignees{/user}","branches_url":"https://api.github.com/repos/keboola/kbc-ui/branches{/branch}","tags_url":"https://api.github.com/repos/keboola/kbc-ui/tags","blobs_url":"https://api.github.com/repos/keboola/kbc-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keboola/kbc-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keboola/kbc-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/keboola/kbc-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keboola/kbc-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/keboola/kbc-ui/languages","stargazers_url":"https://api.github.com/repos/keboola/kbc-ui/stargazers","contributors_url":"https://api.github.com/repos/keboola/kbc-ui/contributors","subscribers_url":"https://api.github.com/repos/keboola/kbc-ui/subscribers","subscription_url":"https://api.github.com/repos/keboola/kbc-ui/subscription","commits_url":"https://api.github.com/repos/keboola/kbc-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/keboola/kbc-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/keboola/kbc-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/keboola/kbc-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/keboola/kbc-ui/contents/{+path}","compare_url":"https://api.github.com/repos/keboola/kbc-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keboola/kbc-ui/merges","archive_url":"https://api.github.com/repos/keboola/kbc-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keboola/kbc-ui/downloads","issues_url":"https://api.github.com/repos/keboola/kbc-ui/issues{/number}","pulls_url":"https://api.github.com/repos/keboola/kbc-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/keboola/kbc-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/keboola/kbc-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keboola/kbc-ui/labels{/name}","releases_url":"https://api.github.com/repos/keboola/kbc-ui/releases{/id}","deployments_url":"https://api.github.com/repos/keboola/kbc-ui/deployments","created_at":"2014-11-15T13:56:22Z","updated_at":"2018-08-03T10:47:07Z","pushed_at":"2018-08-06T08:36:53Z","git_url":"git://github.com/keboola/kbc-ui.git","ssh_url":"git@github.com:keboola/kbc-ui.git","clone_url":"https://github.com/keboola/kbc-ui.git","svn_url":"https://github.com/keboola/kbc-ui","homepage":"","size":16145,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":275,"license":null,"forks":9,"open_issues":275,"watchers":16,"default_branch":"master"}},"base":{"label":"keboola:master","ref":"master","sha":"2a07d2ffec89e29171cc0ee88b33be9ac43493fb","user":{"login":"keboola","id":1424387,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjQzODc=","avatar_url":"https://avatars1.githubusercontent.com/u/1424387?v=4","gravatar_id":"","url":"https://api.github.com/users/keboola","html_url":"https://github.com/keboola","followers_url":"https://api.github.com/users/keboola/followers","following_url":"https://api.github.com/users/keboola/following{/other_user}","gists_url":"https://api.github.com/users/keboola/gists{/gist_id}","starred_url":"https://api.github.com/users/keboola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keboola/subscriptions","organizations_url":"https://api.github.com/users/keboola/orgs","repos_url":"https://api.github.com/users/keboola/repos","events_url":"https://api.github.com/users/keboola/events{/privacy}","received_events_url":"https://api.github.com/users/keboola/received_events","type":"Organization","site_admin":false},"repo":{"id":26681387,"node_id":"MDEwOlJlcG9zaXRvcnkyNjY4MTM4Nw==","name":"kbc-ui","full_name":"keboola/kbc-ui","owner":{"login":"keboola","id":1424387,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjQzODc=","avatar_url":"https://avatars1.githubusercontent.com/u/1424387?v=4","gravatar_id":"","url":"https://api.github.com/users/keboola","html_url":"https://github.com/keboola","followers_url":"https://api.github.com/users/keboola/followers","following_url":"https://api.github.com/users/keboola/following{/other_user}","gists_url":"https://api.github.com/users/keboola/gists{/gist_id}","starred_url":"https://api.github.com/users/keboola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keboola/subscriptions","organizations_url":"https://api.github.com/users/keboola/orgs","repos_url":"https://api.github.com/users/keboola/repos","events_url":"https://api.github.com/users/keboola/events{/privacy}","received_events_url":"https://api.github.com/users/keboola/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keboola/kbc-ui","description":"User interface for Keboola Connection","fork":false,"url":"https://api.github.com/repos/keboola/kbc-ui","forks_url":"https://api.github.com/repos/keboola/kbc-ui/forks","keys_url":"https://api.github.com/repos/keboola/kbc-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keboola/kbc-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keboola/kbc-ui/teams","hooks_url":"https://api.github.com/repos/keboola/kbc-ui/hooks","issue_events_url":"https://api.github.com/repos/keboola/kbc-ui/issues/events{/number}","events_url":"https://api.github.com/repos/keboola/kbc-ui/events","assignees_url":"https://api.github.com/repos/keboola/kbc-ui/assignees{/user}","branches_url":"https://api.github.com/repos/keboola/kbc-ui/branches{/branch}","tags_url":"https://api.github.com/repos/keboola/kbc-ui/tags","blobs_url":"https://api.github.com/repos/keboola/kbc-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keboola/kbc-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keboola/kbc-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/keboola/kbc-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keboola/kbc-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/keboola/kbc-ui/languages","stargazers_url":"https://api.github.com/repos/keboola/kbc-ui/stargazers","contributors_url":"https://api.github.com/repos/keboola/kbc-ui/contributors","subscribers_url":"https://api.github.com/repos/keboola/kbc-ui/subscribers","subscription_url":"https://api.github.com/repos/keboola/kbc-ui/subscription","commits_url":"https://api.github.com/repos/keboola/kbc-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/keboola/kbc-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/keboola/kbc-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/keboola/kbc-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/keboola/kbc-ui/contents/{+path}","compare_url":"https://api.github.com/repos/keboola/kbc-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keboola/kbc-ui/merges","archive_url":"https://api.github.com/repos/keboola/kbc-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keboola/kbc-ui/downloads","issues_url":"https://api.github.com/repos/keboola/kbc-ui/issues{/number}","pulls_url":"https://api.github.com/repos/keboola/kbc-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/keboola/kbc-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/keboola/kbc-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keboola/kbc-ui/labels{/name}","releases_url":"https://api.github.com/repos/keboola/kbc-ui/releases{/id}","deployments_url":"https://api.github.com/repos/keboola/kbc-ui/deployments","created_at":"2014-11-15T13:56:22Z","updated_at":"2018-08-03T10:47:07Z","pushed_at":"2018-08-06T08:36:53Z","git_url":"git://github.com/keboola/kbc-ui.git","ssh_url":"git@github.com:keboola/kbc-ui.git","clone_url":"https://github.com/keboola/kbc-ui.git","svn_url":"https://github.com/keboola/kbc-ui","homepage":"","size":16145,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":275,"license":null,"forks":9,"open_issues":275,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keboola/kbc-ui/pulls/1835"},"html":{"href":"https://github.com/keboola/kbc-ui/pull/1835"},"issue":{"href":"https://api.github.com/repos/keboola/kbc-ui/issues/1835"},"comments":{"href":"https://api.github.com/repos/keboola/kbc-ui/issues/1835/comments"},"review_comments":{"href":"https://api.github.com/repos/keboola/kbc-ui/pulls/1835/comments"},"review_comment":{"href":"https://api.github.com/repos/keboola/kbc-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keboola/kbc-ui/pulls/1835/commits"},"statuses":{"href":"https://api.github.com/repos/keboola/kbc-ui/statuses/44fa4ce84fd759453a211f7db7dd69b0cec02687"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kacurez"}}