{"action":"created","comment":{"url":"https://api.github.com/repos/namely/docker-protoc/pulls/comments/187087859","pull_request_review_id":118797264,"id":187087859,"diff_hunk":"@@ -159,6 +169,15 @@ plugins=grpc+embedded\\\n         ;;\n esac\n \n+LINT_STRING=''\n+if [[ $LINT == true ]]; then\n+    if [[ $LINT_CHECKS == '' ]]; then\n+        LINT_STRING=\"--lint_out=.\"\n+    else\n+        LINT_STRING=\"--lint_out=$LINT_CHECKS:.\"\n+    fi","path":"all/entrypoint.sh","position":39,"original_position":39,"commit_id":"1ee886275e0ac18923eb3d0808568c2cd0120ba7","original_commit_id":"1ee886275e0ac18923eb3d0808568c2cd0120ba7","user":{"login":"blimmer","id":630449,"avatar_url":"https://avatars1.githubusercontent.com/u/630449?v=4","gravatar_id":"","url":"https://api.github.com/users/blimmer","html_url":"https://github.com/blimmer","followers_url":"https://api.github.com/users/blimmer/followers","following_url":"https://api.github.com/users/blimmer/following{/other_user}","gists_url":"https://api.github.com/users/blimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/blimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blimmer/subscriptions","organizations_url":"https://api.github.com/users/blimmer/orgs","repos_url":"https://api.github.com/users/blimmer/repos","events_url":"https://api.github.com/users/blimmer/events{/privacy}","received_events_url":"https://api.github.com/users/blimmer/received_events","type":"User","site_admin":false},"body":"There might be a better way to handle this inner if statement, but I'm no bash expert 😄 ","created_at":"2018-05-09T15:51:42Z","updated_at":"2018-05-09T15:51:42Z","html_url":"https://github.com/namely/docker-protoc/pull/69#discussion_r187087859","pull_request_url":"https://api.github.com/repos/namely/docker-protoc/pulls/69","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/namely/docker-protoc/pulls/comments/187087859"},"html":{"href":"https://github.com/namely/docker-protoc/pull/69#discussion_r187087859"},"pull_request":{"href":"https://api.github.com/repos/namely/docker-protoc/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/namely/docker-protoc/pulls/69","id":186964147,"html_url":"https://github.com/namely/docker-protoc/pull/69","diff_url":"https://github.com/namely/docker-protoc/pull/69.diff","patch_url":"https://github.com/namely/docker-protoc/pull/69.patch","issue_url":"https://api.github.com/repos/namely/docker-protoc/issues/69","number":69,"state":"open","locked":false,"title":"Expose linting","user":{"login":"blimmer","id":630449,"avatar_url":"https://avatars1.githubusercontent.com/u/630449?v=4","gravatar_id":"","url":"https://api.github.com/users/blimmer","html_url":"https://github.com/blimmer","followers_url":"https://api.github.com/users/blimmer/followers","following_url":"https://api.github.com/users/blimmer/following{/other_user}","gists_url":"https://api.github.com/users/blimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/blimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blimmer/subscriptions","organizations_url":"https://api.github.com/users/blimmer/orgs","repos_url":"https://api.github.com/users/blimmer/repos","events_url":"https://api.github.com/users/blimmer/events{/privacy}","received_events_url":"https://api.github.com/users/blimmer/received_events","type":"User","site_admin":false},"body":"My team is working on introducing linting of our protobufs. I noticed that `protoc-gen-lint` is being installed in the container:\r\n\r\nhttps://github.com/namely/docker-protoc/blob/32cda135bca79697425b25f67f4aa69ceadfc85a/all/Dockerfile#L39\r\n\r\nBut it's not being exposed via the entrypoint. This PR adds a flag to enable linting. I've tested this on my project and it's working as I'd expect.\r\n\r\nThis is available under my dockerhub if you want to test it out:\r\n\r\n```\r\nblimmer/protoc-all:1.11-lint\r\n```","created_at":"2018-05-09T15:49:38Z","updated_at":"2018-05-09T15:51:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2e7e7e4bd09ce1a5bcb4fcbaf98d458e591e40b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/namely/docker-protoc/pulls/69/commits","review_comments_url":"https://api.github.com/repos/namely/docker-protoc/pulls/69/comments","review_comment_url":"https://api.github.com/repos/namely/docker-protoc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/namely/docker-protoc/issues/69/comments","statuses_url":"https://api.github.com/repos/namely/docker-protoc/statuses/1ee886275e0ac18923eb3d0808568c2cd0120ba7","head":{"label":"blimmer:feature/enable-linting","ref":"feature/enable-linting","sha":"1ee886275e0ac18923eb3d0808568c2cd0120ba7","user":{"login":"blimmer","id":630449,"avatar_url":"https://avatars1.githubusercontent.com/u/630449?v=4","gravatar_id":"","url":"https://api.github.com/users/blimmer","html_url":"https://github.com/blimmer","followers_url":"https://api.github.com/users/blimmer/followers","following_url":"https://api.github.com/users/blimmer/following{/other_user}","gists_url":"https://api.github.com/users/blimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/blimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blimmer/subscriptions","organizations_url":"https://api.github.com/users/blimmer/orgs","repos_url":"https://api.github.com/users/blimmer/repos","events_url":"https://api.github.com/users/blimmer/events{/privacy}","received_events_url":"https://api.github.com/users/blimmer/received_events","type":"User","site_admin":false},"repo":{"id":130238079,"name":"docker-protoc","full_name":"blimmer/docker-protoc","owner":{"login":"blimmer","id":630449,"avatar_url":"https://avatars1.githubusercontent.com/u/630449?v=4","gravatar_id":"","url":"https://api.github.com/users/blimmer","html_url":"https://github.com/blimmer","followers_url":"https://api.github.com/users/blimmer/followers","following_url":"https://api.github.com/users/blimmer/following{/other_user}","gists_url":"https://api.github.com/users/blimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/blimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blimmer/subscriptions","organizations_url":"https://api.github.com/users/blimmer/orgs","repos_url":"https://api.github.com/users/blimmer/repos","events_url":"https://api.github.com/users/blimmer/events{/privacy}","received_events_url":"https://api.github.com/users/blimmer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blimmer/docker-protoc","description":"Docker images for generating protocol buffer definitions","fork":true,"url":"https://api.github.com/repos/blimmer/docker-protoc","forks_url":"https://api.github.com/repos/blimmer/docker-protoc/forks","keys_url":"https://api.github.com/repos/blimmer/docker-protoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blimmer/docker-protoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blimmer/docker-protoc/teams","hooks_url":"https://api.github.com/repos/blimmer/docker-protoc/hooks","issue_events_url":"https://api.github.com/repos/blimmer/docker-protoc/issues/events{/number}","events_url":"https://api.github.com/repos/blimmer/docker-protoc/events","assignees_url":"https://api.github.com/repos/blimmer/docker-protoc/assignees{/user}","branches_url":"https://api.github.com/repos/blimmer/docker-protoc/branches{/branch}","tags_url":"https://api.github.com/repos/blimmer/docker-protoc/tags","blobs_url":"https://api.github.com/repos/blimmer/docker-protoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blimmer/docker-protoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blimmer/docker-protoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/blimmer/docker-protoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blimmer/docker-protoc/statuses/{sha}","languages_url":"https://api.github.com/repos/blimmer/docker-protoc/languages","stargazers_url":"https://api.github.com/repos/blimmer/docker-protoc/stargazers","contributors_url":"https://api.github.com/repos/blimmer/docker-protoc/contributors","subscribers_url":"https://api.github.com/repos/blimmer/docker-protoc/subscribers","subscription_url":"https://api.github.com/repos/blimmer/docker-protoc/subscription","commits_url":"https://api.github.com/repos/blimmer/docker-protoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/blimmer/docker-protoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/blimmer/docker-protoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/blimmer/docker-protoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/blimmer/docker-protoc/contents/{+path}","compare_url":"https://api.github.com/repos/blimmer/docker-protoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blimmer/docker-protoc/merges","archive_url":"https://api.github.com/repos/blimmer/docker-protoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blimmer/docker-protoc/downloads","issues_url":"https://api.github.com/repos/blimmer/docker-protoc/issues{/number}","pulls_url":"https://api.github.com/repos/blimmer/docker-protoc/pulls{/number}","milestones_url":"https://api.github.com/repos/blimmer/docker-protoc/milestones{/number}","notifications_url":"https://api.github.com/repos/blimmer/docker-protoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blimmer/docker-protoc/labels{/name}","releases_url":"https://api.github.com/repos/blimmer/docker-protoc/releases{/id}","deployments_url":"https://api.github.com/repos/blimmer/docker-protoc/deployments","created_at":"2018-04-19T15:41:50Z","updated_at":"2018-05-09T15:09:37Z","pushed_at":"2018-05-09T15:43:19Z","git_url":"git://github.com/blimmer/docker-protoc.git","ssh_url":"git@github.com:blimmer/docker-protoc.git","clone_url":"https://github.com/blimmer/docker-protoc.git","svn_url":"https://github.com/blimmer/docker-protoc","homepage":"","size":112,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"namely:master","ref":"master","sha":"32cda135bca79697425b25f67f4aa69ceadfc85a","user":{"login":"namely","id":1004321,"avatar_url":"https://avatars3.githubusercontent.com/u/1004321?v=4","gravatar_id":"","url":"https://api.github.com/users/namely","html_url":"https://github.com/namely","followers_url":"https://api.github.com/users/namely/followers","following_url":"https://api.github.com/users/namely/following{/other_user}","gists_url":"https://api.github.com/users/namely/gists{/gist_id}","starred_url":"https://api.github.com/users/namely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namely/subscriptions","organizations_url":"https://api.github.com/users/namely/orgs","repos_url":"https://api.github.com/users/namely/repos","events_url":"https://api.github.com/users/namely/events{/privacy}","received_events_url":"https://api.github.com/users/namely/received_events","type":"Organization","site_admin":false},"repo":{"id":47358803,"name":"docker-protoc","full_name":"namely/docker-protoc","owner":{"login":"namely","id":1004321,"avatar_url":"https://avatars3.githubusercontent.com/u/1004321?v=4","gravatar_id":"","url":"https://api.github.com/users/namely","html_url":"https://github.com/namely","followers_url":"https://api.github.com/users/namely/followers","following_url":"https://api.github.com/users/namely/following{/other_user}","gists_url":"https://api.github.com/users/namely/gists{/gist_id}","starred_url":"https://api.github.com/users/namely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/namely/subscriptions","organizations_url":"https://api.github.com/users/namely/orgs","repos_url":"https://api.github.com/users/namely/repos","events_url":"https://api.github.com/users/namely/events{/privacy}","received_events_url":"https://api.github.com/users/namely/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/namely/docker-protoc","description":"Docker images for generating protocol buffer definitions","fork":false,"url":"https://api.github.com/repos/namely/docker-protoc","forks_url":"https://api.github.com/repos/namely/docker-protoc/forks","keys_url":"https://api.github.com/repos/namely/docker-protoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/namely/docker-protoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/namely/docker-protoc/teams","hooks_url":"https://api.github.com/repos/namely/docker-protoc/hooks","issue_events_url":"https://api.github.com/repos/namely/docker-protoc/issues/events{/number}","events_url":"https://api.github.com/repos/namely/docker-protoc/events","assignees_url":"https://api.github.com/repos/namely/docker-protoc/assignees{/user}","branches_url":"https://api.github.com/repos/namely/docker-protoc/branches{/branch}","tags_url":"https://api.github.com/repos/namely/docker-protoc/tags","blobs_url":"https://api.github.com/repos/namely/docker-protoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/namely/docker-protoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/namely/docker-protoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/namely/docker-protoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/namely/docker-protoc/statuses/{sha}","languages_url":"https://api.github.com/repos/namely/docker-protoc/languages","stargazers_url":"https://api.github.com/repos/namely/docker-protoc/stargazers","contributors_url":"https://api.github.com/repos/namely/docker-protoc/contributors","subscribers_url":"https://api.github.com/repos/namely/docker-protoc/subscribers","subscription_url":"https://api.github.com/repos/namely/docker-protoc/subscription","commits_url":"https://api.github.com/repos/namely/docker-protoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/namely/docker-protoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/namely/docker-protoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/namely/docker-protoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/namely/docker-protoc/contents/{+path}","compare_url":"https://api.github.com/repos/namely/docker-protoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/namely/docker-protoc/merges","archive_url":"https://api.github.com/repos/namely/docker-protoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/namely/docker-protoc/downloads","issues_url":"https://api.github.com/repos/namely/docker-protoc/issues{/number}","pulls_url":"https://api.github.com/repos/namely/docker-protoc/pulls{/number}","milestones_url":"https://api.github.com/repos/namely/docker-protoc/milestones{/number}","notifications_url":"https://api.github.com/repos/namely/docker-protoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/namely/docker-protoc/labels{/name}","releases_url":"https://api.github.com/repos/namely/docker-protoc/releases{/id}","deployments_url":"https://api.github.com/repos/namely/docker-protoc/deployments","created_at":"2015-12-03T20:36:13Z","updated_at":"2018-05-08T01:12:52Z","pushed_at":"2018-05-09T15:49:39Z","git_url":"git://github.com/namely/docker-protoc.git","ssh_url":"git@github.com:namely/docker-protoc.git","clone_url":"https://github.com/namely/docker-protoc.git","svn_url":"https://github.com/namely/docker-protoc","homepage":"","size":115,"stargazers_count":71,"watchers_count":71,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":27,"open_issues":4,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/namely/docker-protoc/pulls/69"},"html":{"href":"https://github.com/namely/docker-protoc/pull/69"},"issue":{"href":"https://api.github.com/repos/namely/docker-protoc/issues/69"},"comments":{"href":"https://api.github.com/repos/namely/docker-protoc/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/namely/docker-protoc/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/namely/docker-protoc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/namely/docker-protoc/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/namely/docker-protoc/statuses/1ee886275e0ac18923eb3d0808568c2cd0120ba7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"blimmer"}}