{"action":"closed","number":329,"pull_request":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/pulls/329","id":228286645,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4Mjg2NjQ1","html_url":"https://github.com/cocos2d/cocos2d-x-3rd-party-libs-bin/pull/329","diff_url":"https://github.com/cocos2d/cocos2d-x-3rd-party-libs-bin/pull/329.diff","patch_url":"https://github.com/cocos2d/cocos2d-x-3rd-party-libs-bin/pull/329.patch","issue_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/issues/329","number":329,"state":"closed","locked":false,"title":"modern cmake, set needed target macro define","user":{"login":"drelaptop","id":26329291,"node_id":"MDQ6VXNlcjI2MzI5Mjkx","avatar_url":"https://avatars3.githubusercontent.com/u/26329291?v=4","gravatar_id":"","url":"https://api.github.com/users/drelaptop","html_url":"https://github.com/drelaptop","followers_url":"https://api.github.com/users/drelaptop/followers","following_url":"https://api.github.com/users/drelaptop/following{/other_user}","gists_url":"https://api.github.com/users/drelaptop/gists{/gist_id}","starred_url":"https://api.github.com/users/drelaptop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drelaptop/subscriptions","organizations_url":"https://api.github.com/users/drelaptop/orgs","repos_url":"https://api.github.com/users/drelaptop/repos","events_url":"https://api.github.com/users/drelaptop/events{/privacy}","received_events_url":"https://api.github.com/users/drelaptop/received_events","type":"User","site_admin":false},"body":"https://github.com/cocos2d/cocos2d-x/pull/19139\r\n\r\nmodern cmake style use target_* to set macro define and compile options into `cocos2d` target, so that external libs can't access to those values.","created_at":"2018-11-05T09:24:21Z","updated_at":"2018-11-06T02:32:41Z","closed_at":"2018-11-06T02:32:41Z","merged_at":"2018-11-06T02:32:41Z","merge_commit_sha":"222e67ff238445c380824318dcf60b1de0147086","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/pulls/329/commits","review_comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/pulls/329/comments","review_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/issues/329/comments","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/statuses/d53e0b280f285e6ba3f813d90d4039a0c24eaf54","head":{"label":"drelaptop:v3-update-define","ref":"v3-update-define","sha":"d53e0b280f285e6ba3f813d90d4039a0c24eaf54","user":{"login":"drelaptop","id":26329291,"node_id":"MDQ6VXNlcjI2MzI5Mjkx","avatar_url":"https://avatars3.githubusercontent.com/u/26329291?v=4","gravatar_id":"","url":"https://api.github.com/users/drelaptop","html_url":"https://github.com/drelaptop","followers_url":"https://api.github.com/users/drelaptop/followers","following_url":"https://api.github.com/users/drelaptop/following{/other_user}","gists_url":"https://api.github.com/users/drelaptop/gists{/gist_id}","starred_url":"https://api.github.com/users/drelaptop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drelaptop/subscriptions","organizations_url":"https://api.github.com/users/drelaptop/orgs","repos_url":"https://api.github.com/users/drelaptop/repos","events_url":"https://api.github.com/users/drelaptop/events{/privacy}","received_events_url":"https://api.github.com/users/drelaptop/received_events","type":"User","site_admin":false},"repo":{"id":124072214,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQwNzIyMTQ=","name":"cocos2d-x-3rd-party-libs-bin","full_name":"drelaptop/cocos2d-x-3rd-party-libs-bin","private":false,"owner":{"login":"drelaptop","id":26329291,"node_id":"MDQ6VXNlcjI2MzI5Mjkx","avatar_url":"https://avatars3.githubusercontent.com/u/26329291?v=4","gravatar_id":"","url":"https://api.github.com/users/drelaptop","html_url":"https://github.com/drelaptop","followers_url":"https://api.github.com/users/drelaptop/followers","following_url":"https://api.github.com/users/drelaptop/following{/other_user}","gists_url":"https://api.github.com/users/drelaptop/gists{/gist_id}","starred_url":"https://api.github.com/users/drelaptop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drelaptop/subscriptions","organizations_url":"https://api.github.com/users/drelaptop/orgs","repos_url":"https://api.github.com/users/drelaptop/repos","events_url":"https://api.github.com/users/drelaptop/events{/privacy}","received_events_url":"https://api.github.com/users/drelaptop/received_events","type":"User","site_admin":false},"html_url":"https://github.com/drelaptop/cocos2d-x-3rd-party-libs-bin","description":null,"fork":true,"url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin","forks_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/forks","keys_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/teams","hooks_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/hooks","issue_events_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/issues/events{/number}","events_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/events","assignees_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/assignees{/user}","branches_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/branches{/branch}","tags_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/tags","blobs_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/git/refs{/sha}","trees_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/statuses/{sha}","languages_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/languages","stargazers_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/stargazers","contributors_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/contributors","subscribers_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/subscribers","subscription_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/subscription","commits_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/commits{/sha}","git_commits_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/git/commits{/sha}","comments_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/comments{/number}","issue_comment_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/issues/comments{/number}","contents_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/contents/{+path}","compare_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/merges","archive_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/downloads","issues_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/issues{/number}","pulls_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/pulls{/number}","milestones_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/milestones{/number}","notifications_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/labels{/name}","releases_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/releases{/id}","deployments_url":"https://api.github.com/repos/drelaptop/cocos2d-x-3rd-party-libs-bin/deployments","created_at":"2018-03-06T12:01:21Z","updated_at":"2018-03-06T12:01:40Z","pushed_at":"2018-11-05T10:35:20Z","git_url":"git://github.com/drelaptop/cocos2d-x-3rd-party-libs-bin.git","ssh_url":"git@github.com:drelaptop/cocos2d-x-3rd-party-libs-bin.git","clone_url":"https://github.com/drelaptop/cocos2d-x-3rd-party-libs-bin.git","svn_url":"https://github.com/drelaptop/cocos2d-x-3rd-party-libs-bin","homepage":null,"size":676449,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v3"}},"base":{"label":"cocos2d:v3","ref":"v3","sha":"445a0019896e53941cc5ad6c9282018d874a24b6","user":{"login":"cocos2d","id":234324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDMyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/234324?v=4","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"repo":{"id":19443129,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQ0MzEyOQ==","name":"cocos2d-x-3rd-party-libs-bin","full_name":"cocos2d/cocos2d-x-3rd-party-libs-bin","private":false,"owner":{"login":"cocos2d","id":234324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDMyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/234324?v=4","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cocos2d/cocos2d-x-3rd-party-libs-bin","description":null,"fork":false,"url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin","forks_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/forks","keys_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/teams","hooks_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/hooks","issue_events_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/issues/events{/number}","events_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/events","assignees_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/assignees{/user}","branches_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/branches{/branch}","tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/tags","blobs_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/languages","stargazers_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/stargazers","contributors_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/contributors","subscribers_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/subscribers","subscription_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/subscription","commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/contents/{+path}","compare_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/merges","archive_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/downloads","issues_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/issues{/number}","pulls_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/labels{/name}","releases_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/releases{/id}","deployments_url":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/deployments","created_at":"2014-05-05T03:45:07Z","updated_at":"2018-10-21T03:09:26Z","pushed_at":"2018-11-06T02:32:41Z","git_url":"git://github.com/cocos2d/cocos2d-x-3rd-party-libs-bin.git","ssh_url":"git@github.com:cocos2d/cocos2d-x-3rd-party-libs-bin.git","clone_url":"https://github.com/cocos2d/cocos2d-x-3rd-party-libs-bin.git","svn_url":"https://github.com/cocos2d/cocos2d-x-3rd-party-libs-bin","homepage":null,"size":676414,"stargazers_count":106,"watchers_count":106,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":237,"mirror_url":null,"archived":false,"open_issues_count":25,"license":null,"forks":237,"open_issues":25,"watchers":106,"default_branch":"v3"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/pulls/329"},"html":{"href":"https://github.com/cocos2d/cocos2d-x-3rd-party-libs-bin/pull/329"},"issue":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/issues/329"},"comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/issues/329/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/pulls/329/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/pulls/329/commits"},"statuses":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x-3rd-party-libs-bin/statuses/d53e0b280f285e6ba3f813d90d4039a0c24eaf54"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"minggo","id":488203,"node_id":"MDQ6VXNlcjQ4ODIwMw==","avatar_url":"https://avatars1.githubusercontent.com/u/488203?v=4","gravatar_id":"","url":"https://api.github.com/users/minggo","html_url":"https://github.com/minggo","followers_url":"https://api.github.com/users/minggo/followers","following_url":"https://api.github.com/users/minggo/following{/other_user}","gists_url":"https://api.github.com/users/minggo/gists{/gist_id}","starred_url":"https://api.github.com/users/minggo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minggo/subscriptions","organizations_url":"https://api.github.com/users/minggo/orgs","repos_url":"https://api.github.com/users/minggo/repos","events_url":"https://api.github.com/users/minggo/events{/privacy}","received_events_url":"https://api.github.com/users/minggo/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":8,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"minggo"}}