{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/13862","repository_url":"https://api.github.com/repos/xbmc/xbmc","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/13862/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/13862/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/13862/events","html_url":"https://github.com/xbmc/xbmc/pull/13862","id":320944966,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg2NDU1MTg3","number":13862,"title":"[application] Fix order of profile manager init","user":{"login":"mooninite","id":3599707,"node_id":"MDQ6VXNlcjM1OTk3MDc=","avatar_url":"https://avatars0.githubusercontent.com/u/3599707?v=4","gravatar_id":"","url":"https://api.github.com/users/mooninite","html_url":"https://github.com/mooninite","followers_url":"https://api.github.com/users/mooninite/followers","following_url":"https://api.github.com/users/mooninite/following{/other_user}","gists_url":"https://api.github.com/users/mooninite/gists{/gist_id}","starred_url":"https://api.github.com/users/mooninite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mooninite/subscriptions","organizations_url":"https://api.github.com/users/mooninite/orgs","repos_url":"https://api.github.com/users/mooninite/repos","events_url":"https://api.github.com/users/mooninite/events{/privacy}","received_events_url":"https://api.github.com/users/mooninite/received_events","type":"User","site_admin":false},"labels":[{"id":754212621,"node_id":"MDU6TGFiZWw3NTQyMTI2MjE=","url":"https://api.github.com/repos/xbmc/xbmc/labels/Rebase%20needed","name":"Rebase needed","color":"f235e8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-05-07T20:27:33Z","updated_at":"2018-10-07T22:34:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/13862","html_url":"https://github.com/xbmc/xbmc/pull/13862","diff_url":"https://github.com/xbmc/xbmc/pull/13862.diff","patch_url":"https://github.com/xbmc/xbmc/pull/13862.patch"},"body":"## Description\r\nUnder gcc 8.x the unique_ptr check on profile manager fails.\r\nInitDirectoriesLinux() tries to use the pointer and the\r\nprofile manager is not initialized until later. Init the profile\r\nmanager first and everyone else can use the pointer.\r\n\r\nFedora 28 and higher ship GCC 8.1. \r\n\r\n## Motivation and Context\r\nThis change allows kodi to start on Fedora 28+.\r\n\r\nBacktrace prior to this patch:\r\n#0  0x00007fffed996f4b in raise () from /lib64/libc.so.6\r\n#1  0x00007fffed981591 in abort () from /lib64/libc.so.6\r\n#2  0x0000555555e6f9f8 in std::__replacement_assert(char const*, int, char const*, char const*) ()\r\n#3  0x0000555556787921 in CServiceManager::GetProfileManager() ()\r\n#4  0x0000555556beae1e in XFILE::IDirectory::IDirectory() ()\r\n#5  0x000055555600697d in XFILE::CPosixDirectory::CPosixDirectory() ()\r\n#6  0x0000555556bcee85 in XFILE::CDirectoryFactory::Create(CURL const&) ()\r\n#7  0x0000555556bcbc78 in XFILE::CDirectory::Exists(CURL const&, bool) ()\r\n#8  0x0000555556bcc2e8 in XFILE::CDirectory::Exists(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool) ()\r\n#9  0x00005555566e8f19 in CApplication::InitDirectoriesLinux() ()\r\n#10 0x00005555566e94ef in CApplication::Create(CAppParamParser const&) ()\r\n#11 0x00005555563b15ba in XBMC_Run ()\r\n#12 0x0000555555de5eee in main ()\r\n\r\n## How Has This Been Tested?\r\nCompiled 18.0 a1 and ran on a Fedora 28 machine. Plays audio and video successfully.\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of change\r\n<!--- What type of change does your code introduce? Put an `x` in all the boxes that apply like this: [X] -->\r\n- [X] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] Improvement (non-breaking change which improves existing functionality)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply like this: [X] -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X] My code follows the [Code guidelines](https://codedocs.xyz/xbmc/xbmc/code_guidelines.html) of this project \r\n- [ ] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [X] I have read the [CONTRIBUTING](https://github.com/xbmc/xbmc/blob/master/CONTRIBUTING.md) document\r\n- [ ] I have added tests to cover my change\r\n- [X] All new and existing tests passed\r\n"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/427693000","html_url":"https://github.com/xbmc/xbmc/pull/13862#issuecomment-427693000","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/13862","id":427693000,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzY5MzAwMA==","user":{"login":"jenkins4kodi","id":8507773,"node_id":"MDQ6VXNlcjg1MDc3NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/8507773?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkins4kodi","html_url":"https://github.com/jenkins4kodi","followers_url":"https://api.github.com/users/jenkins4kodi/followers","following_url":"https://api.github.com/users/jenkins4kodi/following{/other_user}","gists_url":"https://api.github.com/users/jenkins4kodi/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkins4kodi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkins4kodi/subscriptions","organizations_url":"https://api.github.com/users/jenkins4kodi/orgs","repos_url":"https://api.github.com/users/jenkins4kodi/repos","events_url":"https://api.github.com/users/jenkins4kodi/events{/privacy}","received_events_url":"https://api.github.com/users/jenkins4kodi/received_events","type":"User","site_admin":false},"created_at":"2018-10-07T22:34:24Z","updated_at":"2018-10-07T22:34:24Z","author_association":"CONTRIBUTOR","body":"@mooninite this needs a rebase"}}
{"actor":{"display_login":"jenkins4kodi"}}