{"action":"created","comment":{"url":"https://api.github.com/repos/stardust-ui/react/pulls/comments/222626611","pull_request_review_id":161557967,"id":222626611,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjYyNjYxMQ==","diff_hunk":"@@ -2,16 +2,32 @@ import { pxToRem } from '../../../../lib'\n import { IComponentPartStylesInput, ICSSInJSStyle } from '../../../../../types/theme'\n import { IListItemProps } from '../../../../components/List/ListItem'\n \n+const hoverStyle = variables => ({\n+  background: variables.selectionHoverBackgroundColor,\n+  color: variables.selectionHoverColor,\n+  cursor: 'pointer',\n+\n+  '& .ui-item-layout__header': { color: 'inherit' },\n+  '& .ui-item-layout__content': { color: 'inherit' },\n+\n+  // hide the header media and content media on hover\n+  '& .ui-item-layout__headerMedia': { display: 'none', color: 'inherit' },\n+  '& .ui-item-layout__contentMedia': { display: 'none', color: 'inherit' },\n+\n+  // show the end media on hover\n+  '& .ui-item-layout__endMedia': { display: 'unset', color: 'inherit' },","path":"src/themes/teams/components/List/listItemStyles.ts","position":17,"original_position":17,"commit_id":"1dc7f1c05c0fcd189e1798a7f55874be2a06761c","original_commit_id":"1dc7f1c05c0fcd189e1798a7f55874be2a06761c","user":{"login":"kuzhelov","id":9024564,"node_id":"MDQ6VXNlcjkwMjQ1NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/9024564?v=4","gravatar_id":"","url":"https://api.github.com/users/kuzhelov","html_url":"https://github.com/kuzhelov","followers_url":"https://api.github.com/users/kuzhelov/followers","following_url":"https://api.github.com/users/kuzhelov/following{/other_user}","gists_url":"https://api.github.com/users/kuzhelov/gists{/gist_id}","starred_url":"https://api.github.com/users/kuzhelov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuzhelov/subscriptions","organizations_url":"https://api.github.com/users/kuzhelov/orgs","repos_url":"https://api.github.com/users/kuzhelov/repos","events_url":"https://api.github.com/users/kuzhelov/events{/privacy}","received_events_url":"https://api.github.com/users/kuzhelov/received_events","type":"User","site_admin":false},"body":"heads up, this `unset` value is not supported for IE. is there any other strategy how we could handle it?","created_at":"2018-10-04T11:12:45Z","updated_at":"2018-10-04T11:12:45Z","html_url":"https://github.com/stardust-ui/react/pull/278#discussion_r222626611","pull_request_url":"https://api.github.com/repos/stardust-ui/react/pulls/278","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/stardust-ui/react/pulls/comments/222626611"},"html":{"href":"https://github.com/stardust-ui/react/pull/278#discussion_r222626611"},"pull_request":{"href":"https://api.github.com/repos/stardust-ui/react/pulls/278"}}},"pull_request":{"url":"https://api.github.com/repos/stardust-ui/react/pulls/278","id":218149086,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MTQ5MDg2","html_url":"https://github.com/stardust-ui/react/pull/278","diff_url":"https://github.com/stardust-ui/react/pull/278.diff","patch_url":"https://github.com/stardust-ui/react/pull/278.patch","issue_url":"https://api.github.com/repos/stardust-ui/react/issues/278","number":278,"state":"open","locked":false,"title":"fix: (ListItem) - Fix endMedia to not be removed from DOM on mouseleave for ListItem","user":{"login":"musingh1","id":22622723,"node_id":"MDQ6VXNlcjIyNjIyNzIz","avatar_url":"https://avatars3.githubusercontent.com/u/22622723?v=4","gravatar_id":"","url":"https://api.github.com/users/musingh1","html_url":"https://github.com/musingh1","followers_url":"https://api.github.com/users/musingh1/followers","following_url":"https://api.github.com/users/musingh1/following{/other_user}","gists_url":"https://api.github.com/users/musingh1/gists{/gist_id}","starred_url":"https://api.github.com/users/musingh1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musingh1/subscriptions","organizations_url":"https://api.github.com/users/musingh1/orgs","repos_url":"https://api.github.com/users/musingh1/repos","events_url":"https://api.github.com/users/musingh1/events{/privacy}","received_events_url":"https://api.github.com/users/musingh1/received_events","type":"User","site_admin":false},"body":"Earlier, we were listening for mouseEnter and mouseLeave, maintaining the isHovering state and only showing the endMedia when the item is hovered. This breaks the scenarios where endMedia is a Popup. Once the Popup is triggered we want the content to stay even after the user leaves the list item (e.g. points to the popup content).\r\nSo now, if provided we will always render all the media's and in Teams theme control the display of endMedia, headerMedia etc through styles.\r\n\r\n","created_at":"2018-09-25T23:32:39Z","updated_at":"2018-10-04T11:12:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"683b1f927f58d8fabc00c153bafea17dc6553d7c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mnajdova","id":4512430,"node_id":"MDQ6VXNlcjQ1MTI0MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/4512430?v=4","gravatar_id":"","url":"https://api.github.com/users/mnajdova","html_url":"https://github.com/mnajdova","followers_url":"https://api.github.com/users/mnajdova/followers","following_url":"https://api.github.com/users/mnajdova/following{/other_user}","gists_url":"https://api.github.com/users/mnajdova/gists{/gist_id}","starred_url":"https://api.github.com/users/mnajdova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnajdova/subscriptions","organizations_url":"https://api.github.com/users/mnajdova/orgs","repos_url":"https://api.github.com/users/mnajdova/repos","events_url":"https://api.github.com/users/mnajdova/events{/privacy}","received_events_url":"https://api.github.com/users/mnajdova/received_events","type":"User","site_admin":false},{"login":"levithomason","id":5067638,"node_id":"MDQ6VXNlcjUwNjc2Mzg=","avatar_url":"https://avatars3.githubusercontent.com/u/5067638?v=4","gravatar_id":"","url":"https://api.github.com/users/levithomason","html_url":"https://github.com/levithomason","followers_url":"https://api.github.com/users/levithomason/followers","following_url":"https://api.github.com/users/levithomason/following{/other_user}","gists_url":"https://api.github.com/users/levithomason/gists{/gist_id}","starred_url":"https://api.github.com/users/levithomason/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levithomason/subscriptions","organizations_url":"https://api.github.com/users/levithomason/orgs","repos_url":"https://api.github.com/users/levithomason/repos","events_url":"https://api.github.com/users/levithomason/events{/privacy}","received_events_url":"https://api.github.com/users/levithomason/received_events","type":"User","site_admin":false},{"login":"davezuko","id":6439050,"node_id":"MDQ6VXNlcjY0MzkwNTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6439050?v=4","gravatar_id":"","url":"https://api.github.com/users/davezuko","html_url":"https://github.com/davezuko","followers_url":"https://api.github.com/users/davezuko/followers","following_url":"https://api.github.com/users/davezuko/following{/other_user}","gists_url":"https://api.github.com/users/davezuko/gists{/gist_id}","starred_url":"https://api.github.com/users/davezuko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davezuko/subscriptions","organizations_url":"https://api.github.com/users/davezuko/orgs","repos_url":"https://api.github.com/users/davezuko/repos","events_url":"https://api.github.com/users/davezuko/events{/privacy}","received_events_url":"https://api.github.com/users/davezuko/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1025396700,"node_id":"MDU6TGFiZWwxMDI1Mzk2NzAw","url":"https://api.github.com/repos/stardust-ui/react/labels/ready%20for%20review","name":"ready for review","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/stardust-ui/react/pulls/278/commits","review_comments_url":"https://api.github.com/repos/stardust-ui/react/pulls/278/comments","review_comment_url":"https://api.github.com/repos/stardust-ui/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stardust-ui/react/issues/278/comments","statuses_url":"https://api.github.com/repos/stardust-ui/react/statuses/1dc7f1c05c0fcd189e1798a7f55874be2a06761c","head":{"label":"stardust-ui:feature/mukul/fix-listitem-styles","ref":"feature/mukul/fix-listitem-styles","sha":"1dc7f1c05c0fcd189e1798a7f55874be2a06761c","user":{"login":"stardust-ui","id":40412095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDEyMDk1","avatar_url":"https://avatars3.githubusercontent.com/u/40412095?v=4","gravatar_id":"","url":"https://api.github.com/users/stardust-ui","html_url":"https://github.com/stardust-ui","followers_url":"https://api.github.com/users/stardust-ui/followers","following_url":"https://api.github.com/users/stardust-ui/following{/other_user}","gists_url":"https://api.github.com/users/stardust-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/stardust-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stardust-ui/subscriptions","organizations_url":"https://api.github.com/users/stardust-ui/orgs","repos_url":"https://api.github.com/users/stardust-ui/repos","events_url":"https://api.github.com/users/stardust-ui/events{/privacy}","received_events_url":"https://api.github.com/users/stardust-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":141743704,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE3NDM3MDQ=","name":"react","full_name":"stardust-ui/react","private":false,"owner":{"login":"stardust-ui","id":40412095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDEyMDk1","avatar_url":"https://avatars3.githubusercontent.com/u/40412095?v=4","gravatar_id":"","url":"https://api.github.com/users/stardust-ui","html_url":"https://github.com/stardust-ui","followers_url":"https://api.github.com/users/stardust-ui/followers","following_url":"https://api.github.com/users/stardust-ui/following{/other_user}","gists_url":"https://api.github.com/users/stardust-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/stardust-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stardust-ui/subscriptions","organizations_url":"https://api.github.com/users/stardust-ui/orgs","repos_url":"https://api.github.com/users/stardust-ui/repos","events_url":"https://api.github.com/users/stardust-ui/events{/privacy}","received_events_url":"https://api.github.com/users/stardust-ui/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stardust-ui/react","description":"A themable React component library","fork":false,"url":"https://api.github.com/repos/stardust-ui/react","forks_url":"https://api.github.com/repos/stardust-ui/react/forks","keys_url":"https://api.github.com/repos/stardust-ui/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stardust-ui/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stardust-ui/react/teams","hooks_url":"https://api.github.com/repos/stardust-ui/react/hooks","issue_events_url":"https://api.github.com/repos/stardust-ui/react/issues/events{/number}","events_url":"https://api.github.com/repos/stardust-ui/react/events","assignees_url":"https://api.github.com/repos/stardust-ui/react/assignees{/user}","branches_url":"https://api.github.com/repos/stardust-ui/react/branches{/branch}","tags_url":"https://api.github.com/repos/stardust-ui/react/tags","blobs_url":"https://api.github.com/repos/stardust-ui/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stardust-ui/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stardust-ui/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/stardust-ui/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stardust-ui/react/statuses/{sha}","languages_url":"https://api.github.com/repos/stardust-ui/react/languages","stargazers_url":"https://api.github.com/repos/stardust-ui/react/stargazers","contributors_url":"https://api.github.com/repos/stardust-ui/react/contributors","subscribers_url":"https://api.github.com/repos/stardust-ui/react/subscribers","subscription_url":"https://api.github.com/repos/stardust-ui/react/subscription","commits_url":"https://api.github.com/repos/stardust-ui/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/stardust-ui/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/stardust-ui/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/stardust-ui/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/stardust-ui/react/contents/{+path}","compare_url":"https://api.github.com/repos/stardust-ui/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stardust-ui/react/merges","archive_url":"https://api.github.com/repos/stardust-ui/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stardust-ui/react/downloads","issues_url":"https://api.github.com/repos/stardust-ui/react/issues{/number}","pulls_url":"https://api.github.com/repos/stardust-ui/react/pulls{/number}","milestones_url":"https://api.github.com/repos/stardust-ui/react/milestones{/number}","notifications_url":"https://api.github.com/repos/stardust-ui/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stardust-ui/react/labels{/name}","releases_url":"https://api.github.com/repos/stardust-ui/react/releases{/id}","deployments_url":"https://api.github.com/repos/stardust-ui/react/deployments","created_at":"2018-07-20T18:12:35Z","updated_at":"2018-10-04T10:15:44Z","pushed_at":"2018-10-04T11:01:48Z","git_url":"git://github.com/stardust-ui/react.git","ssh_url":"git@github.com:stardust-ui/react.git","clone_url":"https://github.com/stardust-ui/react.git","svn_url":"https://github.com/stardust-ui/react","homepage":"http://stardust-ui.github.io/react","size":22966,"stargazers_count":63,"watchers_count":63,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":13,"open_issues":62,"watchers":63,"default_branch":"master"}},"base":{"label":"stardust-ui:master","ref":"master","sha":"70acc8138a911255c5565460c8b82ff3118446d8","user":{"login":"stardust-ui","id":40412095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDEyMDk1","avatar_url":"https://avatars3.githubusercontent.com/u/40412095?v=4","gravatar_id":"","url":"https://api.github.com/users/stardust-ui","html_url":"https://github.com/stardust-ui","followers_url":"https://api.github.com/users/stardust-ui/followers","following_url":"https://api.github.com/users/stardust-ui/following{/other_user}","gists_url":"https://api.github.com/users/stardust-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/stardust-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stardust-ui/subscriptions","organizations_url":"https://api.github.com/users/stardust-ui/orgs","repos_url":"https://api.github.com/users/stardust-ui/repos","events_url":"https://api.github.com/users/stardust-ui/events{/privacy}","received_events_url":"https://api.github.com/users/stardust-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":141743704,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE3NDM3MDQ=","name":"react","full_name":"stardust-ui/react","private":false,"owner":{"login":"stardust-ui","id":40412095,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDEyMDk1","avatar_url":"https://avatars3.githubusercontent.com/u/40412095?v=4","gravatar_id":"","url":"https://api.github.com/users/stardust-ui","html_url":"https://github.com/stardust-ui","followers_url":"https://api.github.com/users/stardust-ui/followers","following_url":"https://api.github.com/users/stardust-ui/following{/other_user}","gists_url":"https://api.github.com/users/stardust-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/stardust-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stardust-ui/subscriptions","organizations_url":"https://api.github.com/users/stardust-ui/orgs","repos_url":"https://api.github.com/users/stardust-ui/repos","events_url":"https://api.github.com/users/stardust-ui/events{/privacy}","received_events_url":"https://api.github.com/users/stardust-ui/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stardust-ui/react","description":"A themable React component library","fork":false,"url":"https://api.github.com/repos/stardust-ui/react","forks_url":"https://api.github.com/repos/stardust-ui/react/forks","keys_url":"https://api.github.com/repos/stardust-ui/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stardust-ui/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stardust-ui/react/teams","hooks_url":"https://api.github.com/repos/stardust-ui/react/hooks","issue_events_url":"https://api.github.com/repos/stardust-ui/react/issues/events{/number}","events_url":"https://api.github.com/repos/stardust-ui/react/events","assignees_url":"https://api.github.com/repos/stardust-ui/react/assignees{/user}","branches_url":"https://api.github.com/repos/stardust-ui/react/branches{/branch}","tags_url":"https://api.github.com/repos/stardust-ui/react/tags","blobs_url":"https://api.github.com/repos/stardust-ui/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stardust-ui/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stardust-ui/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/stardust-ui/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stardust-ui/react/statuses/{sha}","languages_url":"https://api.github.com/repos/stardust-ui/react/languages","stargazers_url":"https://api.github.com/repos/stardust-ui/react/stargazers","contributors_url":"https://api.github.com/repos/stardust-ui/react/contributors","subscribers_url":"https://api.github.com/repos/stardust-ui/react/subscribers","subscription_url":"https://api.github.com/repos/stardust-ui/react/subscription","commits_url":"https://api.github.com/repos/stardust-ui/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/stardust-ui/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/stardust-ui/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/stardust-ui/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/stardust-ui/react/contents/{+path}","compare_url":"https://api.github.com/repos/stardust-ui/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stardust-ui/react/merges","archive_url":"https://api.github.com/repos/stardust-ui/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stardust-ui/react/downloads","issues_url":"https://api.github.com/repos/stardust-ui/react/issues{/number}","pulls_url":"https://api.github.com/repos/stardust-ui/react/pulls{/number}","milestones_url":"https://api.github.com/repos/stardust-ui/react/milestones{/number}","notifications_url":"https://api.github.com/repos/stardust-ui/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stardust-ui/react/labels{/name}","releases_url":"https://api.github.com/repos/stardust-ui/react/releases{/id}","deployments_url":"https://api.github.com/repos/stardust-ui/react/deployments","created_at":"2018-07-20T18:12:35Z","updated_at":"2018-10-04T10:15:44Z","pushed_at":"2018-10-04T11:01:48Z","git_url":"git://github.com/stardust-ui/react.git","ssh_url":"git@github.com:stardust-ui/react.git","clone_url":"https://github.com/stardust-ui/react.git","svn_url":"https://github.com/stardust-ui/react","homepage":"http://stardust-ui.github.io/react","size":22966,"stargazers_count":63,"watchers_count":63,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":13,"open_issues":62,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stardust-ui/react/pulls/278"},"html":{"href":"https://github.com/stardust-ui/react/pull/278"},"issue":{"href":"https://api.github.com/repos/stardust-ui/react/issues/278"},"comments":{"href":"https://api.github.com/repos/stardust-ui/react/issues/278/comments"},"review_comments":{"href":"https://api.github.com/repos/stardust-ui/react/pulls/278/comments"},"review_comment":{"href":"https://api.github.com/repos/stardust-ui/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stardust-ui/react/pulls/278/commits"},"statuses":{"href":"https://api.github.com/repos/stardust-ui/react/statuses/1dc7f1c05c0fcd189e1798a7f55874be2a06761c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"kuzhelov"}}