{"action":"created","issue":{"url":"https://api.github.com/repos/k9mail/k-9/issues/3650","repository_url":"https://api.github.com/repos/k9mail/k-9","labels_url":"https://api.github.com/repos/k9mail/k-9/issues/3650/labels{/name}","comments_url":"https://api.github.com/repos/k9mail/k-9/issues/3650/comments","events_url":"https://api.github.com/repos/k9mail/k-9/issues/3650/events","html_url":"https://github.com/k9mail/k-9/pull/3650","id":367583077,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTY2MzQz","number":3650,"title":"Add preferences and unified inbox to drawer","user":{"login":"williamvds","id":26379999,"node_id":"MDQ6VXNlcjI2Mzc5OTk5","avatar_url":"https://avatars3.githubusercontent.com/u/26379999?v=4","gravatar_id":"","url":"https://api.github.com/users/williamvds","html_url":"https://github.com/williamvds","followers_url":"https://api.github.com/users/williamvds/followers","following_url":"https://api.github.com/users/williamvds/following{/other_user}","gists_url":"https://api.github.com/users/williamvds/gists{/gist_id}","starred_url":"https://api.github.com/users/williamvds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamvds/subscriptions","organizations_url":"https://api.github.com/users/williamvds/orgs","repos_url":"https://api.github.com/users/williamvds/repos","events_url":"https://api.github.com/users/williamvds/events{/privacy}","received_events_url":"https://api.github.com/users/williamvds/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-07T19:02:12Z","updated_at":"2018-10-21T12:38:32Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/k9mail/k-9/pulls/3650","html_url":"https://github.com/k9mail/k-9/pull/3650","diff_url":"https://github.com/k9mail/k-9/pull/3650.diff","patch_url":"https://github.com/k9mail/k-9/pull/3650.patch"},"body":"The settings item is part of the spec, while the unified inbox item\r\nlets you avoid going through the context menu and several screens.  \r\nAn entry for the unified inbox is also in the Gmail/Inbox app, and I believe it would make a nice addition to the UI.\r\n\r\nMost existing drawer logic has been moved into `com.fsck.k9.ui.K9Drawer`\r\n\r\nA couple of methods in `MessageList` were made public, and a few new ones\r\nadded, so that the drawer can instruct the list to open a specific\r\nfolder, or the unified inbox.\r\n\r\n### Current issues\r\n- highlighting the correct item when the message list first appears\r\n  - could add new member in `LocalSearch` that explicitly indicates unified inbox\r\n  - could assume unified inbox if `LocalSearch.searchAllAccounts() == true`\r\n  - could create subclasses of `LocalSearch`, e.g. `UnifiedInboxSearch`, `FolderLocalSearch`\r\n  - catching+handling all other entry points for loading a folder\r\n- licensing/attribution of new icon\r\n  - couldn't find Google's own drawable vector version of [all_inbox](https://material.io/tools/icons/?icon=all_inbox&style=baseline)\r\n  - used material design icons' [inbox-multiple](https://materialdesignicons.com/icon/inbox-multiple)\r\n\r\nI'd appreciate some guidance on the above\r\n\r\n### Preview\r\n![drawersettingsinbox](https://user-images.githubusercontent.com/26379999/46585634-b8277700-ca62-11e8-84b3-9f31083bb9b5.jpg)\r\n\r\nThis change builds upon #817\r\n"},"comment":{"url":"https://api.github.com/repos/k9mail/k-9/issues/comments/431665352","html_url":"https://github.com/k9mail/k-9/pull/3650#issuecomment-431665352","issue_url":"https://api.github.com/repos/k9mail/k-9/issues/3650","id":431665352,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTY2NTM1Mg==","user":{"login":"williamvds","id":26379999,"node_id":"MDQ6VXNlcjI2Mzc5OTk5","avatar_url":"https://avatars3.githubusercontent.com/u/26379999?v=4","gravatar_id":"","url":"https://api.github.com/users/williamvds","html_url":"https://github.com/williamvds","followers_url":"https://api.github.com/users/williamvds/followers","following_url":"https://api.github.com/users/williamvds/following{/other_user}","gists_url":"https://api.github.com/users/williamvds/gists{/gist_id}","starred_url":"https://api.github.com/users/williamvds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamvds/subscriptions","organizations_url":"https://api.github.com/users/williamvds/orgs","repos_url":"https://api.github.com/users/williamvds/repos","events_url":"https://api.github.com/users/williamvds/events{/privacy}","received_events_url":"https://api.github.com/users/williamvds/received_events","type":"User","site_admin":false},"created_at":"2018-10-21T12:38:32Z","updated_at":"2018-10-21T12:38:32Z","author_association":"NONE","body":"I've updated my changes\r\n\r\n- First commit is the minimal changes necessary to move stuff into `K9Drawer`\r\n- `LocalSearch` now has an `id` member which is used to identify a unified inbox search\r\n- `inbox_all` icons are Google's SVGs\r\n- Unified Inbox is only added to drawer if `!K9.isHideSpecialAccounts()`\r\n"}}
{"actor":{"display_login":"williamvds"}}