{"action":"created","comment":{"url":"https://api.github.com/repos/pytest-dev/pytest/pulls/comments/234796201","pull_request_review_id":176515609,"id":234796201,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDc5NjIwMQ==","diff_hunk":"@@ -219,7 +219,12 @@ def pytest_pycollect_makeitem(collector, name, obj):\n             )\n         elif getattr(obj, \"__test__\", True):\n             if is_generator(obj):\n-                res = Generator(name, parent=collector)\n+                res = Function(name, parent=collector)\n+                res.add_marker(","path":"src/_pytest/python.py","position":22,"original_position":22,"commit_id":"1875d596482392537f1e19c2c1f740af1d97cd7a","original_commit_id":"1875d596482392537f1e19c2c1f740af1d97cd7a","user":{"login":"nicoddemus","id":1085180,"node_id":"MDQ6VXNlcjEwODUxODA=","avatar_url":"https://avatars2.githubusercontent.com/u/1085180?v=4","gravatar_id":"","url":"https://api.github.com/users/nicoddemus","html_url":"https://github.com/nicoddemus","followers_url":"https://api.github.com/users/nicoddemus/followers","following_url":"https://api.github.com/users/nicoddemus/following{/other_user}","gists_url":"https://api.github.com/users/nicoddemus/gists{/gist_id}","starred_url":"https://api.github.com/users/nicoddemus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicoddemus/subscriptions","organizations_url":"https://api.github.com/users/nicoddemus/orgs","repos_url":"https://api.github.com/users/nicoddemus/repos","events_url":"https://api.github.com/users/nicoddemus/events{/privacy}","received_events_url":"https://api.github.com/users/nicoddemus/received_events","type":"User","site_admin":false},"body":"I believe this should be a warning, as we discussed previously? I think it is fitting because we also issue warnings for test classes with `__init__`.","created_at":"2018-11-19T21:55:10Z","updated_at":"2018-11-19T21:56:25Z","html_url":"https://github.com/pytest-dev/pytest/pull/3898#discussion_r234796201","pull_request_url":"https://api.github.com/repos/pytest-dev/pytest/pulls/3898","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/comments/234796201"},"html":{"href":"https://github.com/pytest-dev/pytest/pull/3898#discussion_r234796201"},"pull_request":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/3898"}}},"pull_request":{"url":"https://api.github.com/repos/pytest-dev/pytest/pulls/3898","id":211340819,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMzQwODE5","html_url":"https://github.com/pytest-dev/pytest/pull/3898","diff_url":"https://github.com/pytest-dev/pytest/pull/3898.diff","patch_url":"https://github.com/pytest-dev/pytest/pull/3898.patch","issue_url":"https://api.github.com/repos/pytest-dev/pytest/issues/3898","number":3898,"state":"open","locked":false,"title":"Remove yield and compatprop [BREAKING CHANGE]","user":{"login":"RonnyPfannschmidt","id":156838,"node_id":"MDQ6VXNlcjE1NjgzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/156838?v=4","gravatar_id":"","url":"https://api.github.com/users/RonnyPfannschmidt","html_url":"https://github.com/RonnyPfannschmidt","followers_url":"https://api.github.com/users/RonnyPfannschmidt/followers","following_url":"https://api.github.com/users/RonnyPfannschmidt/following{/other_user}","gists_url":"https://api.github.com/users/RonnyPfannschmidt/gists{/gist_id}","starred_url":"https://api.github.com/users/RonnyPfannschmidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonnyPfannschmidt/subscriptions","organizations_url":"https://api.github.com/users/RonnyPfannschmidt/orgs","repos_url":"https://api.github.com/users/RonnyPfannschmidt/repos","events_url":"https://api.github.com/users/RonnyPfannschmidt/events{/privacy}","received_events_url":"https://api.github.com/users/RonnyPfannschmidt/received_events","type":"User","site_admin":false},"body":"this pr removes a whole set of internal breakage by removing a broken feature as well as compat properties which are also deprecated since years, just impossibly hard to integrate with the warning system due to their ___bad____ structure","created_at":"2018-08-28T08:28:31Z","updated_at":"2018-11-19T21:56:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"add3e130b7088bfa390091aec624a1966852592a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/pytest-dev/pytest/milestones/20","html_url":"https://github.com/pytest-dev/pytest/milestone/20","labels_url":"https://api.github.com/repos/pytest-dev/pytest/milestones/20/labels","id":3674473,"node_id":"MDk6TWlsZXN0b25lMzY3NDQ3Mw==","number":20,"title":"4.1","description":"This release will effectively remove the features that have been turned into errors in 4.0.","creator":{"login":"nicoddemus","id":1085180,"node_id":"MDQ6VXNlcjEwODUxODA=","avatar_url":"https://avatars2.githubusercontent.com/u/1085180?v=4","gravatar_id":"","url":"https://api.github.com/users/nicoddemus","html_url":"https://github.com/nicoddemus","followers_url":"https://api.github.com/users/nicoddemus/followers","following_url":"https://api.github.com/users/nicoddemus/following{/other_user}","gists_url":"https://api.github.com/users/nicoddemus/gists{/gist_id}","starred_url":"https://api.github.com/users/nicoddemus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicoddemus/subscriptions","organizations_url":"https://api.github.com/users/nicoddemus/orgs","repos_url":"https://api.github.com/users/nicoddemus/repos","events_url":"https://api.github.com/users/nicoddemus/events{/privacy}","received_events_url":"https://api.github.com/users/nicoddemus/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":0,"state":"open","created_at":"2018-09-20T11:28:03Z","updated_at":"2018-11-08T23:22:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/pytest-dev/pytest/pulls/3898/commits","review_comments_url":"https://api.github.com/repos/pytest-dev/pytest/pulls/3898/comments","review_comment_url":"https://api.github.com/repos/pytest-dev/pytest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytest-dev/pytest/issues/3898/comments","statuses_url":"https://api.github.com/repos/pytest-dev/pytest/statuses/1875d596482392537f1e19c2c1f740af1d97cd7a","head":{"label":"RonnyPfannschmidt:remove-yield-and-compatprop","ref":"remove-yield-and-compatprop","sha":"1875d596482392537f1e19c2c1f740af1d97cd7a","user":{"login":"RonnyPfannschmidt","id":156838,"node_id":"MDQ6VXNlcjE1NjgzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/156838?v=4","gravatar_id":"","url":"https://api.github.com/users/RonnyPfannschmidt","html_url":"https://github.com/RonnyPfannschmidt","followers_url":"https://api.github.com/users/RonnyPfannschmidt/followers","following_url":"https://api.github.com/users/RonnyPfannschmidt/following{/other_user}","gists_url":"https://api.github.com/users/RonnyPfannschmidt/gists{/gist_id}","starred_url":"https://api.github.com/users/RonnyPfannschmidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonnyPfannschmidt/subscriptions","organizations_url":"https://api.github.com/users/RonnyPfannschmidt/orgs","repos_url":"https://api.github.com/users/RonnyPfannschmidt/repos","events_url":"https://api.github.com/users/RonnyPfannschmidt/events{/privacy}","received_events_url":"https://api.github.com/users/RonnyPfannschmidt/received_events","type":"User","site_admin":false},"repo":{"id":38833653,"node_id":"MDEwOlJlcG9zaXRvcnkzODgzMzY1Mw==","name":"pytest","full_name":"RonnyPfannschmidt/pytest","private":false,"owner":{"login":"RonnyPfannschmidt","id":156838,"node_id":"MDQ6VXNlcjE1NjgzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/156838?v=4","gravatar_id":"","url":"https://api.github.com/users/RonnyPfannschmidt","html_url":"https://github.com/RonnyPfannschmidt","followers_url":"https://api.github.com/users/RonnyPfannschmidt/followers","following_url":"https://api.github.com/users/RonnyPfannschmidt/following{/other_user}","gists_url":"https://api.github.com/users/RonnyPfannschmidt/gists{/gist_id}","starred_url":"https://api.github.com/users/RonnyPfannschmidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonnyPfannschmidt/subscriptions","organizations_url":"https://api.github.com/users/RonnyPfannschmidt/orgs","repos_url":"https://api.github.com/users/RonnyPfannschmidt/repos","events_url":"https://api.github.com/users/RonnyPfannschmidt/events{/privacy}","received_events_url":"https://api.github.com/users/RonnyPfannschmidt/received_events","type":"User","site_admin":false},"html_url":"https://github.com/RonnyPfannschmidt/pytest","description":"The pytest testing tool makes it easy to write small tests, yet scales to support complex functional testing","fork":true,"url":"https://api.github.com/repos/RonnyPfannschmidt/pytest","forks_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/forks","keys_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/teams","hooks_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/hooks","issue_events_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/issues/events{/number}","events_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/events","assignees_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/assignees{/user}","branches_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/branches{/branch}","tags_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/tags","blobs_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/git/refs{/sha}","trees_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/statuses/{sha}","languages_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/languages","stargazers_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/stargazers","contributors_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/contributors","subscribers_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/subscribers","subscription_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/subscription","commits_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/commits{/sha}","git_commits_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/git/commits{/sha}","comments_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/comments{/number}","issue_comment_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/issues/comments{/number}","contents_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/contents/{+path}","compare_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/merges","archive_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/downloads","issues_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/issues{/number}","pulls_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/pulls{/number}","milestones_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/milestones{/number}","notifications_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/labels{/name}","releases_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/releases{/id}","deployments_url":"https://api.github.com/repos/RonnyPfannschmidt/pytest/deployments","created_at":"2015-07-09T16:58:09Z","updated_at":"2018-11-15T09:49:49Z","pushed_at":"2018-11-19T21:50:18Z","git_url":"git://github.com/RonnyPfannschmidt/pytest.git","ssh_url":"git@github.com:RonnyPfannschmidt/pytest.git","clone_url":"https://github.com/RonnyPfannschmidt/pytest.git","svn_url":"https://github.com/RonnyPfannschmidt/pytest","homepage":"http://pytest.org/","size":15032,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytest-dev:features","ref":"features","sha":"0ffb8ddd7f7814481f7278d4eee1a62d81ae0c8b","user":{"login":"pytest-dev","id":8897583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4OTc1ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/8897583?v=4","gravatar_id":"","url":"https://api.github.com/users/pytest-dev","html_url":"https://github.com/pytest-dev","followers_url":"https://api.github.com/users/pytest-dev/followers","following_url":"https://api.github.com/users/pytest-dev/following{/other_user}","gists_url":"https://api.github.com/users/pytest-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pytest-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytest-dev/subscriptions","organizations_url":"https://api.github.com/users/pytest-dev/orgs","repos_url":"https://api.github.com/users/pytest-dev/repos","events_url":"https://api.github.com/users/pytest-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pytest-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":37489525,"node_id":"MDEwOlJlcG9zaXRvcnkzNzQ4OTUyNQ==","name":"pytest","full_name":"pytest-dev/pytest","private":false,"owner":{"login":"pytest-dev","id":8897583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4OTc1ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/8897583?v=4","gravatar_id":"","url":"https://api.github.com/users/pytest-dev","html_url":"https://github.com/pytest-dev","followers_url":"https://api.github.com/users/pytest-dev/followers","following_url":"https://api.github.com/users/pytest-dev/following{/other_user}","gists_url":"https://api.github.com/users/pytest-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pytest-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytest-dev/subscriptions","organizations_url":"https://api.github.com/users/pytest-dev/orgs","repos_url":"https://api.github.com/users/pytest-dev/repos","events_url":"https://api.github.com/users/pytest-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pytest-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pytest-dev/pytest","description":"The pytest framework makes it easy to write small tests, yet scales to support complex functional testing","fork":false,"url":"https://api.github.com/repos/pytest-dev/pytest","forks_url":"https://api.github.com/repos/pytest-dev/pytest/forks","keys_url":"https://api.github.com/repos/pytest-dev/pytest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytest-dev/pytest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytest-dev/pytest/teams","hooks_url":"https://api.github.com/repos/pytest-dev/pytest/hooks","issue_events_url":"https://api.github.com/repos/pytest-dev/pytest/issues/events{/number}","events_url":"https://api.github.com/repos/pytest-dev/pytest/events","assignees_url":"https://api.github.com/repos/pytest-dev/pytest/assignees{/user}","branches_url":"https://api.github.com/repos/pytest-dev/pytest/branches{/branch}","tags_url":"https://api.github.com/repos/pytest-dev/pytest/tags","blobs_url":"https://api.github.com/repos/pytest-dev/pytest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytest-dev/pytest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytest-dev/pytest/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytest-dev/pytest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytest-dev/pytest/statuses/{sha}","languages_url":"https://api.github.com/repos/pytest-dev/pytest/languages","stargazers_url":"https://api.github.com/repos/pytest-dev/pytest/stargazers","contributors_url":"https://api.github.com/repos/pytest-dev/pytest/contributors","subscribers_url":"https://api.github.com/repos/pytest-dev/pytest/subscribers","subscription_url":"https://api.github.com/repos/pytest-dev/pytest/subscription","commits_url":"https://api.github.com/repos/pytest-dev/pytest/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytest-dev/pytest/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytest-dev/pytest/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytest-dev/pytest/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytest-dev/pytest/contents/{+path}","compare_url":"https://api.github.com/repos/pytest-dev/pytest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytest-dev/pytest/merges","archive_url":"https://api.github.com/repos/pytest-dev/pytest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytest-dev/pytest/downloads","issues_url":"https://api.github.com/repos/pytest-dev/pytest/issues{/number}","pulls_url":"https://api.github.com/repos/pytest-dev/pytest/pulls{/number}","milestones_url":"https://api.github.com/repos/pytest-dev/pytest/milestones{/number}","notifications_url":"https://api.github.com/repos/pytest-dev/pytest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytest-dev/pytest/labels{/name}","releases_url":"https://api.github.com/repos/pytest-dev/pytest/releases{/id}","deployments_url":"https://api.github.com/repos/pytest-dev/pytest/deployments","created_at":"2015-06-15T20:28:27Z","updated_at":"2018-11-19T21:55:16Z","pushed_at":"2018-11-19T21:50:21Z","git_url":"git://github.com/pytest-dev/pytest.git","ssh_url":"git@github.com:pytest-dev/pytest.git","clone_url":"https://github.com/pytest-dev/pytest.git","svn_url":"https://github.com/pytest-dev/pytest","homepage":"https://pytest.org","size":15023,"stargazers_count":3271,"watchers_count":3271,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":843,"mirror_url":null,"archived":false,"open_issues_count":506,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":843,"open_issues":506,"watchers":3271,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/3898"},"html":{"href":"https://github.com/pytest-dev/pytest/pull/3898"},"issue":{"href":"https://api.github.com/repos/pytest-dev/pytest/issues/3898"},"comments":{"href":"https://api.github.com/repos/pytest-dev/pytest/issues/3898/comments"},"review_comments":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/3898/comments"},"review_comment":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytest-dev/pytest/pulls/3898/commits"},"statuses":{"href":"https://api.github.com/repos/pytest-dev/pytest/statuses/1875d596482392537f1e19c2c1f740af1d97cd7a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nicoddemus"}}