{"action":"closed","number":94,"pull_request":{"url":"https://api.github.com/repos/mdn/infra/pulls/94","id":219473557,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NDczNTU3","html_url":"https://github.com/mdn/infra/pull/94","diff_url":"https://github.com/mdn/infra/pull/94.diff","patch_url":"https://github.com/mdn/infra/pull/94.patch","issue_url":"https://api.github.com/repos/mdn/infra/issues/94","number":94,"state":"closed","locked":false,"title":"bug 1488281: Do not cache 400 responses","user":{"login":"jwhitlock","id":286017,"node_id":"MDQ6VXNlcjI4NjAxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/286017?v=4","gravatar_id":"","url":"https://api.github.com/users/jwhitlock","html_url":"https://github.com/jwhitlock","followers_url":"https://api.github.com/users/jwhitlock/followers","following_url":"https://api.github.com/users/jwhitlock/following{/other_user}","gists_url":"https://api.github.com/users/jwhitlock/gists{/gist_id}","starred_url":"https://api.github.com/users/jwhitlock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwhitlock/subscriptions","organizations_url":"https://api.github.com/users/jwhitlock/orgs","repos_url":"https://api.github.com/users/jwhitlock/repos","events_url":"https://api.github.com/users/jwhitlock/events{/privacy}","received_events_url":"https://api.github.com/users/jwhitlock/received_events","type":"User","site_admin":false},"body":"``400 Bad Request`` responses are currently cached, but can cause issues if the cause of the 400 is not one of the Vary parameters, such as the requested host header.\r\n\r\nI manually applied this change about a month ago (see [bug 1488281](https://bugzilla.mozilla.org/show_bug.cgi?id=1488281) for details), but held off on the PR until I could research if an integration test relied on cached 400 errors. We've run a few deployments since then, so I think we're OK.\r\n\r\n","created_at":"2018-10-01T18:36:04Z","updated_at":"2018-10-01T19:43:22Z","closed_at":"2018-10-01T19:43:22Z","merged_at":"2018-10-01T19:43:22Z","merge_commit_sha":"b60f41e1e4ae2601f18b4e3a80830325ab4b60ce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mdn/infra/pulls/94/commits","review_comments_url":"https://api.github.com/repos/mdn/infra/pulls/94/comments","review_comment_url":"https://api.github.com/repos/mdn/infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mdn/infra/issues/94/comments","statuses_url":"https://api.github.com/repos/mdn/infra/statuses/2ff3c34be56eee5692901f45686c9e1c60963580","head":{"label":"jwhitlock:cdn-no-cache-400-1488281","ref":"cdn-no-cache-400-1488281","sha":"2ff3c34be56eee5692901f45686c9e1c60963580","user":{"login":"jwhitlock","id":286017,"node_id":"MDQ6VXNlcjI4NjAxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/286017?v=4","gravatar_id":"","url":"https://api.github.com/users/jwhitlock","html_url":"https://github.com/jwhitlock","followers_url":"https://api.github.com/users/jwhitlock/followers","following_url":"https://api.github.com/users/jwhitlock/following{/other_user}","gists_url":"https://api.github.com/users/jwhitlock/gists{/gist_id}","starred_url":"https://api.github.com/users/jwhitlock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwhitlock/subscriptions","organizations_url":"https://api.github.com/users/jwhitlock/orgs","repos_url":"https://api.github.com/users/jwhitlock/repos","events_url":"https://api.github.com/users/jwhitlock/events{/privacy}","received_events_url":"https://api.github.com/users/jwhitlock/received_events","type":"User","site_admin":false},"repo":{"id":102969354,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI5NjkzNTQ=","name":"infra","full_name":"jwhitlock/infra","private":false,"owner":{"login":"jwhitlock","id":286017,"node_id":"MDQ6VXNlcjI4NjAxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/286017?v=4","gravatar_id":"","url":"https://api.github.com/users/jwhitlock","html_url":"https://github.com/jwhitlock","followers_url":"https://api.github.com/users/jwhitlock/followers","following_url":"https://api.github.com/users/jwhitlock/following{/other_user}","gists_url":"https://api.github.com/users/jwhitlock/gists{/gist_id}","starred_url":"https://api.github.com/users/jwhitlock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwhitlock/subscriptions","organizations_url":"https://api.github.com/users/jwhitlock/orgs","repos_url":"https://api.github.com/users/jwhitlock/repos","events_url":"https://api.github.com/users/jwhitlock/events{/privacy}","received_events_url":"https://api.github.com/users/jwhitlock/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jwhitlock/infra","description":"Mozilla Marketing Engineering and Operations Infrastructure","fork":true,"url":"https://api.github.com/repos/jwhitlock/infra","forks_url":"https://api.github.com/repos/jwhitlock/infra/forks","keys_url":"https://api.github.com/repos/jwhitlock/infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwhitlock/infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwhitlock/infra/teams","hooks_url":"https://api.github.com/repos/jwhitlock/infra/hooks","issue_events_url":"https://api.github.com/repos/jwhitlock/infra/issues/events{/number}","events_url":"https://api.github.com/repos/jwhitlock/infra/events","assignees_url":"https://api.github.com/repos/jwhitlock/infra/assignees{/user}","branches_url":"https://api.github.com/repos/jwhitlock/infra/branches{/branch}","tags_url":"https://api.github.com/repos/jwhitlock/infra/tags","blobs_url":"https://api.github.com/repos/jwhitlock/infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwhitlock/infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwhitlock/infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwhitlock/infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwhitlock/infra/statuses/{sha}","languages_url":"https://api.github.com/repos/jwhitlock/infra/languages","stargazers_url":"https://api.github.com/repos/jwhitlock/infra/stargazers","contributors_url":"https://api.github.com/repos/jwhitlock/infra/contributors","subscribers_url":"https://api.github.com/repos/jwhitlock/infra/subscribers","subscription_url":"https://api.github.com/repos/jwhitlock/infra/subscription","commits_url":"https://api.github.com/repos/jwhitlock/infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwhitlock/infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwhitlock/infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwhitlock/infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwhitlock/infra/contents/{+path}","compare_url":"https://api.github.com/repos/jwhitlock/infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwhitlock/infra/merges","archive_url":"https://api.github.com/repos/jwhitlock/infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwhitlock/infra/downloads","issues_url":"https://api.github.com/repos/jwhitlock/infra/issues{/number}","pulls_url":"https://api.github.com/repos/jwhitlock/infra/pulls{/number}","milestones_url":"https://api.github.com/repos/jwhitlock/infra/milestones{/number}","notifications_url":"https://api.github.com/repos/jwhitlock/infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwhitlock/infra/labels{/name}","releases_url":"https://api.github.com/repos/jwhitlock/infra/releases{/id}","deployments_url":"https://api.github.com/repos/jwhitlock/infra/deployments","created_at":"2017-09-09T16:34:54Z","updated_at":"2017-09-09T16:34:56Z","pushed_at":"2018-10-01T17:42:56Z","git_url":"git://github.com/jwhitlock/infra.git","ssh_url":"git@github.com:jwhitlock/infra.git","clone_url":"https://github.com/jwhitlock/infra.git","svn_url":"https://github.com/jwhitlock/infra","homepage":"https://mozilla.github.io/meao/","size":1153,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mdn:master","ref":"master","sha":"5f91fdb33e5aded94328d2819d3403381572f815","user":{"login":"mdn","id":7565578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NjU1Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7565578?v=4","gravatar_id":"","url":"https://api.github.com/users/mdn","html_url":"https://github.com/mdn","followers_url":"https://api.github.com/users/mdn/followers","following_url":"https://api.github.com/users/mdn/following{/other_user}","gists_url":"https://api.github.com/users/mdn/gists{/gist_id}","starred_url":"https://api.github.com/users/mdn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdn/subscriptions","organizations_url":"https://api.github.com/users/mdn/orgs","repos_url":"https://api.github.com/users/mdn/repos","events_url":"https://api.github.com/users/mdn/events{/privacy}","received_events_url":"https://api.github.com/users/mdn/received_events","type":"Organization","site_admin":false},"repo":{"id":134759439,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ3NTk0Mzk=","name":"infra","full_name":"mdn/infra","private":false,"owner":{"login":"mdn","id":7565578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NjU1Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7565578?v=4","gravatar_id":"","url":"https://api.github.com/users/mdn","html_url":"https://github.com/mdn","followers_url":"https://api.github.com/users/mdn/followers","following_url":"https://api.github.com/users/mdn/following{/other_user}","gists_url":"https://api.github.com/users/mdn/gists{/gist_id}","starred_url":"https://api.github.com/users/mdn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdn/subscriptions","organizations_url":"https://api.github.com/users/mdn/orgs","repos_url":"https://api.github.com/users/mdn/repos","events_url":"https://api.github.com/users/mdn/events{/privacy}","received_events_url":"https://api.github.com/users/mdn/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mdn/infra","description":"MDN Web Docs Infrastructure scripts and configuration","fork":true,"url":"https://api.github.com/repos/mdn/infra","forks_url":"https://api.github.com/repos/mdn/infra/forks","keys_url":"https://api.github.com/repos/mdn/infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdn/infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdn/infra/teams","hooks_url":"https://api.github.com/repos/mdn/infra/hooks","issue_events_url":"https://api.github.com/repos/mdn/infra/issues/events{/number}","events_url":"https://api.github.com/repos/mdn/infra/events","assignees_url":"https://api.github.com/repos/mdn/infra/assignees{/user}","branches_url":"https://api.github.com/repos/mdn/infra/branches{/branch}","tags_url":"https://api.github.com/repos/mdn/infra/tags","blobs_url":"https://api.github.com/repos/mdn/infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdn/infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdn/infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdn/infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdn/infra/statuses/{sha}","languages_url":"https://api.github.com/repos/mdn/infra/languages","stargazers_url":"https://api.github.com/repos/mdn/infra/stargazers","contributors_url":"https://api.github.com/repos/mdn/infra/contributors","subscribers_url":"https://api.github.com/repos/mdn/infra/subscribers","subscription_url":"https://api.github.com/repos/mdn/infra/subscription","commits_url":"https://api.github.com/repos/mdn/infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdn/infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdn/infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdn/infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdn/infra/contents/{+path}","compare_url":"https://api.github.com/repos/mdn/infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdn/infra/merges","archive_url":"https://api.github.com/repos/mdn/infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdn/infra/downloads","issues_url":"https://api.github.com/repos/mdn/infra/issues{/number}","pulls_url":"https://api.github.com/repos/mdn/infra/pulls{/number}","milestones_url":"https://api.github.com/repos/mdn/infra/milestones{/number}","notifications_url":"https://api.github.com/repos/mdn/infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdn/infra/labels{/name}","releases_url":"https://api.github.com/repos/mdn/infra/releases{/id}","deployments_url":"https://api.github.com/repos/mdn/infra/deployments","created_at":"2018-05-24T19:23:35Z","updated_at":"2018-10-01T19:30:42Z","pushed_at":"2018-10-01T19:43:22Z","git_url":"git://github.com/mdn/infra.git","ssh_url":"git@github.com:mdn/infra.git","clone_url":"https://github.com/mdn/infra.git","svn_url":"https://github.com/mdn/infra","homepage":"","size":1096,"stargazers_count":5,"watchers_count":5,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":7,"open_issues":12,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mdn/infra/pulls/94"},"html":{"href":"https://github.com/mdn/infra/pull/94"},"issue":{"href":"https://api.github.com/repos/mdn/infra/issues/94"},"comments":{"href":"https://api.github.com/repos/mdn/infra/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/mdn/infra/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/mdn/infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mdn/infra/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/mdn/infra/statuses/2ff3c34be56eee5692901f45686c9e1c60963580"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"escattone","id":3743693,"node_id":"MDQ6VXNlcjM3NDM2OTM=","avatar_url":"https://avatars2.githubusercontent.com/u/3743693?v=4","gravatar_id":"","url":"https://api.github.com/users/escattone","html_url":"https://github.com/escattone","followers_url":"https://api.github.com/users/escattone/followers","following_url":"https://api.github.com/users/escattone/following{/other_user}","gists_url":"https://api.github.com/users/escattone/gists{/gist_id}","starred_url":"https://api.github.com/users/escattone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/escattone/subscriptions","organizations_url":"https://api.github.com/users/escattone/orgs","repos_url":"https://api.github.com/users/escattone/repos","events_url":"https://api.github.com/users/escattone/events{/privacy}","received_events_url":"https://api.github.com/users/escattone/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"escattone"}}