{"action":"created","issue":{"url":"https://api.github.com/repos/allenai/allennlp/issues/1142","repository_url":"https://api.github.com/repos/allenai/allennlp","labels_url":"https://api.github.com/repos/allenai/allennlp/issues/1142/labels{/name}","comments_url":"https://api.github.com/repos/allenai/allennlp/issues/1142/comments","events_url":"https://api.github.com/repos/allenai/allennlp/issues/1142/events","html_url":"https://github.com/allenai/allennlp/pull/1142","id":318134466,"number":1142,"title":"cached iterator","user":{"login":"ibeltagy","id":2287797,"avatar_url":"https://avatars0.githubusercontent.com/u/2287797?v=4","gravatar_id":"","url":"https://api.github.com/users/ibeltagy","html_url":"https://github.com/ibeltagy","followers_url":"https://api.github.com/users/ibeltagy/followers","following_url":"https://api.github.com/users/ibeltagy/following{/other_user}","gists_url":"https://api.github.com/users/ibeltagy/gists{/gist_id}","starred_url":"https://api.github.com/users/ibeltagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibeltagy/subscriptions","organizations_url":"https://api.github.com/users/ibeltagy/orgs","repos_url":"https://api.github.com/users/ibeltagy/repos","events_url":"https://api.github.com/users/ibeltagy/events{/privacy}","received_events_url":"https://api.github.com/users/ibeltagy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-26T17:53:27Z","updated_at":"2018-04-28T19:08:09Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/allenai/allennlp/pulls/1142","html_url":"https://github.com/allenai/allennlp/pull/1142","diff_url":"https://github.com/allenai/allennlp/pull/1142.diff","patch_url":"https://github.com/allenai/allennlp/pull/1142.patch"},"body":"A solution for this issue: https://github.com/allenai/allennlp/issues/1128\r\n\r\nI implemented it as a subclass of `BucketIterator` just to avoid messing up other stuff. However, it is better to be implemented as an additional option in `BasicIterator` where it is only enabled when `dataset_reader` is not lazy and `max_instances_in_memory is None`. \r\n"},"comment":{"url":"https://api.github.com/repos/allenai/allennlp/issues/comments/385198995","html_url":"https://github.com/allenai/allennlp/pull/1142#issuecomment-385198995","issue_url":"https://api.github.com/repos/allenai/allennlp/issues/1142","id":385198995,"user":{"login":"ibeltagy","id":2287797,"avatar_url":"https://avatars0.githubusercontent.com/u/2287797?v=4","gravatar_id":"","url":"https://api.github.com/users/ibeltagy","html_url":"https://github.com/ibeltagy","followers_url":"https://api.github.com/users/ibeltagy/followers","following_url":"https://api.github.com/users/ibeltagy/following{/other_user}","gists_url":"https://api.github.com/users/ibeltagy/gists{/gist_id}","starred_url":"https://api.github.com/users/ibeltagy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibeltagy/subscriptions","organizations_url":"https://api.github.com/users/ibeltagy/orgs","repos_url":"https://api.github.com/users/ibeltagy/repos","events_url":"https://api.github.com/users/ibeltagy/events{/privacy}","received_events_url":"https://api.github.com/users/ibeltagy/received_events","type":"User","site_admin":false},"created_at":"2018-04-28T19:08:09Z","updated_at":"2018-04-28T19:08:09Z","author_association":"CONTRIBUTOR","body":"This PR still needs more work to make sure batches are cached in main memory not gpu memory"}}
{"actor":{"display_login":"ibeltagy"}}