{"action":"created","issue":{"url":"https://api.github.com/repos/napalm-automation/napalm/issues/787","repository_url":"https://api.github.com/repos/napalm-automation/napalm","labels_url":"https://api.github.com/repos/napalm-automation/napalm/issues/787/labels{/name}","comments_url":"https://api.github.com/repos/napalm-automation/napalm/issues/787/comments","events_url":"https://api.github.com/repos/napalm-automation/napalm/issues/787/events","html_url":"https://github.com/napalm-automation/napalm/pull/787","id":350182120,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MDk0NTE3","number":787,"title":"Added Remote Management IP address to Show LLDP Neighbors detail IOS","user":{"login":"jmcgrath207","id":8764013,"node_id":"MDQ6VXNlcjg3NjQwMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/8764013?v=4","gravatar_id":"","url":"https://api.github.com/users/jmcgrath207","html_url":"https://github.com/jmcgrath207","followers_url":"https://api.github.com/users/jmcgrath207/followers","following_url":"https://api.github.com/users/jmcgrath207/following{/other_user}","gists_url":"https://api.github.com/users/jmcgrath207/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcgrath207/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcgrath207/subscriptions","organizations_url":"https://api.github.com/users/jmcgrath207/orgs","repos_url":"https://api.github.com/users/jmcgrath207/repos","events_url":"https://api.github.com/users/jmcgrath207/events{/privacy}","received_events_url":"https://api.github.com/users/jmcgrath207/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-08-13T20:29:49Z","updated_at":"2018-10-05T16:44:48Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/napalm-automation/napalm/pulls/787","html_url":"https://github.com/napalm-automation/napalm/pull/787","diff_url":"https://github.com/napalm-automation/napalm/pull/787.diff","patch_url":"https://github.com/napalm-automation/napalm/pull/787.patch"},"body":"I added the Variable Remote Management IP address for the  Show LLDP Neighbors detail on the IOS TextFSM template.\r\n\r\nI know I have to add the test for this still, but I wanted to know if this is correct format first since I had to remove `-> Record` inorder for this to work correctly.\r\n\r\n\r\n**Orignal Text**\r\n\r\n```\r\nR1#show lldp neighbors detail \r\n------------------------------------------------\r\nLocal Intf: Gi0/0\r\nChassis id: 0c87.fc76.2100\r\nPort id: Gi0/0\r\nPort Description: GigabitEthernet0/0\r\nSystem Name: R3.test.com\r\n\r\nSystem Description: \r\nCisco IOS Software, IOSv Software (VIOS-ADVENTERPRISEK9-M), Version 15.6(2)T, RELEASE SOFTWARE (fc2)\r\nTechnical Support: http://www.cisco.com/techsupport\r\nCopyright (c) 1986-2016 by Cisco Systems, Inc.\r\nCompiled Tue 22-Mar-16 16:19 by prod_rel_team\r\n\r\nTime remaining: 96 seconds\r\nSystem Capabilities: B,R\r\nEnabled Capabilities: R\r\nManagement Addresses:\r\n    IP: 10.161.105.84\r\nAuto Negotiation - not supported\r\nPhysical media capabilities - not advertised\r\nMedia Attachment Unit type - not advertised\r\nVlan ID: - not advertised\r\n          \r\n\r\nTotal entries displayed: 1\r\n```\r\n\r\n\r\n\r\n\r\n\r\n**Output**\r\n\r\n\r\n```python\r\n{'GigabitEthernet0/0': [{'remote_chassis_id': '0c87.fc76.2100', 'remote_port': 'Gi0/0', 'remote_port_description': 'GigabitEthernet0/0', 'remote_system_name': 'R3.test.com', 'remote_system_description': 'Cisco IOS Software, IOSv Software (VIOS-ADVENTERPRISEK9-M), Version 15.6(2)T, RELEASE SOFTWARE (fc2)', 'remote_system_capab': 'B,R', 'remote_system_enable_capab': 'R', 'remote_management_ip_address': '10.161.105.84', 'parent_interface': 'N/A'}]}\r\n```"},"comment":{"url":"https://api.github.com/repos/napalm-automation/napalm/issues/comments/427428191","html_url":"https://github.com/napalm-automation/napalm/pull/787#issuecomment-427428191","issue_url":"https://api.github.com/repos/napalm-automation/napalm/issues/787","id":427428191,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzQyODE5MQ==","user":{"login":"ktbyers","id":899716,"node_id":"MDQ6VXNlcjg5OTcxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/899716?v=4","gravatar_id":"","url":"https://api.github.com/users/ktbyers","html_url":"https://github.com/ktbyers","followers_url":"https://api.github.com/users/ktbyers/followers","following_url":"https://api.github.com/users/ktbyers/following{/other_user}","gists_url":"https://api.github.com/users/ktbyers/gists{/gist_id}","starred_url":"https://api.github.com/users/ktbyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktbyers/subscriptions","organizations_url":"https://api.github.com/users/ktbyers/orgs","repos_url":"https://api.github.com/users/ktbyers/repos","events_url":"https://api.github.com/users/ktbyers/events{/privacy}","received_events_url":"https://api.github.com/users/ktbyers/received_events","type":"User","site_admin":false},"created_at":"2018-10-05T16:44:48Z","updated_at":"2018-10-05T16:44:48Z","author_association":"CONTRIBUTOR","body":"@jmcgrath207 I think we should open an issue on this and close this PR.\r\n\r\nThe process for doing this is:\r\n1. Get agreement that we are going to change the getter by adding a new field (in the issue).\r\n2. Update napalm base.py to reflect this.\r\n3. Update some set of drivers including unit tests to add the new field.\r\n\r\nOne of the key premises of napalm is to try to maintain uniformity across platforms for a given data structure so this is a bigger change than it initially appears."}}
{"actor":{"display_login":"ktbyers"}}