{"action":"created","comment":{"url":"https://api.github.com/repos/swiftstack/container-crawler/pulls/comments/243451391","pull_request_review_id":187224722,"id":243451391,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzQ1MTM5MQ==","diff_hunk":"@@ -48,11 +53,14 @@ def setUp(self):\n         self.conf = {\n             'devices': '/devices',\n             'items_chunk': 1000,\n-            'status_dir': '/var/scratch',\n+            'status_dir': mkdtemp(),","path":"test/unit/test_container_crawler.py","position":24,"original_position":24,"commit_id":"a933f40fa3f6fdc31c3b08cf8606912cbcca4ac7","original_commit_id":"a933f40fa3f6fdc31c3b08cf8606912cbcca4ac7","user":{"login":"timuralp","id":703870,"node_id":"MDQ6VXNlcjcwMzg3MA==","avatar_url":"https://avatars2.githubusercontent.com/u/703870?v=4","gravatar_id":"","url":"https://api.github.com/users/timuralp","html_url":"https://github.com/timuralp","followers_url":"https://api.github.com/users/timuralp/followers","following_url":"https://api.github.com/users/timuralp/following{/other_user}","gists_url":"https://api.github.com/users/timuralp/gists{/gist_id}","starred_url":"https://api.github.com/users/timuralp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timuralp/subscriptions","organizations_url":"https://api.github.com/users/timuralp/orgs","repos_url":"https://api.github.com/users/timuralp/repos","events_url":"https://api.github.com/users/timuralp/events{/privacy}","received_events_url":"https://api.github.com/users/timuralp/received_events","type":"User","site_admin":false},"body":"Do we need to do this for every test? Most of them do not care about this, right?","created_at":"2018-12-20T23:36:28Z","updated_at":"2018-12-20T23:50:32Z","html_url":"https://github.com/swiftstack/container-crawler/pull/26#discussion_r243451391","pull_request_url":"https://api.github.com/repos/swiftstack/container-crawler/pulls/26","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/swiftstack/container-crawler/pulls/comments/243451391"},"html":{"href":"https://github.com/swiftstack/container-crawler/pull/26#discussion_r243451391"},"pull_request":{"href":"https://api.github.com/repos/swiftstack/container-crawler/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/swiftstack/container-crawler/pulls/26","id":238426746,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NDI2NzQ2","html_url":"https://github.com/swiftstack/container-crawler/pull/26","diff_url":"https://github.com/swiftstack/container-crawler/pull/26.diff","patch_url":"https://github.com/swiftstack/container-crawler/pull/26.patch","issue_url":"https://api.github.com/repos/swiftstack/container-crawler/issues/26","number":26,"state":"open","locked":false,"title":"Add support for crawling sharded containers","user":{"login":"thiagodasilva","id":1494299,"node_id":"MDQ6VXNlcjE0OTQyOTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1494299?v=4","gravatar_id":"","url":"https://api.github.com/users/thiagodasilva","html_url":"https://github.com/thiagodasilva","followers_url":"https://api.github.com/users/thiagodasilva/followers","following_url":"https://api.github.com/users/thiagodasilva/following{/other_user}","gists_url":"https://api.github.com/users/thiagodasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/thiagodasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiagodasilva/subscriptions","organizations_url":"https://api.github.com/users/thiagodasilva/orgs","repos_url":"https://api.github.com/users/thiagodasilva/repos","events_url":"https://api.github.com/users/thiagodasilva/events{/privacy}","received_events_url":"https://api.github.com/users/thiagodasilva/received_events","type":"User","site_admin":false},"body":"For every container to be synced, check if it is sharded.\r\nIf so, then crawler needs to also crawl through\r\nthe hidden sharded containers.\r\n\r\nThe check currently requires a request to account server.\r\nTo prevent wasteful requests hitting the account servers\r\ntoo many times, we limit listing of the hidden sharded\r\naccount once every 24 hours for those containers that\r\nare not sharded. This time interval is configurable.","created_at":"2018-12-13T15:18:54Z","updated_at":"2018-12-20T23:50:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8feb1ccc0b8cecafe607b96b41a8fc4b2684313d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mdegerne","id":60821,"node_id":"MDQ6VXNlcjYwODIx","avatar_url":"https://avatars0.githubusercontent.com/u/60821?v=4","gravatar_id":"","url":"https://api.github.com/users/mdegerne","html_url":"https://github.com/mdegerne","followers_url":"https://api.github.com/users/mdegerne/followers","following_url":"https://api.github.com/users/mdegerne/following{/other_user}","gists_url":"https://api.github.com/users/mdegerne/gists{/gist_id}","starred_url":"https://api.github.com/users/mdegerne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdegerne/subscriptions","organizations_url":"https://api.github.com/users/mdegerne/orgs","repos_url":"https://api.github.com/users/mdegerne/repos","events_url":"https://api.github.com/users/mdegerne/events{/privacy}","received_events_url":"https://api.github.com/users/mdegerne/received_events","type":"User","site_admin":false},{"login":"tipabu","id":4432952,"node_id":"MDQ6VXNlcjQ0MzI5NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/4432952?v=4","gravatar_id":"","url":"https://api.github.com/users/tipabu","html_url":"https://github.com/tipabu","followers_url":"https://api.github.com/users/tipabu/followers","following_url":"https://api.github.com/users/tipabu/following{/other_user}","gists_url":"https://api.github.com/users/tipabu/gists{/gist_id}","starred_url":"https://api.github.com/users/tipabu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tipabu/subscriptions","organizations_url":"https://api.github.com/users/tipabu/orgs","repos_url":"https://api.github.com/users/tipabu/repos","events_url":"https://api.github.com/users/tipabu/events{/privacy}","received_events_url":"https://api.github.com/users/tipabu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/swiftstack/container-crawler/pulls/26/commits","review_comments_url":"https://api.github.com/repos/swiftstack/container-crawler/pulls/26/comments","review_comment_url":"https://api.github.com/repos/swiftstack/container-crawler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swiftstack/container-crawler/issues/26/comments","statuses_url":"https://api.github.com/repos/swiftstack/container-crawler/statuses/a933f40fa3f6fdc31c3b08cf8606912cbcca4ac7","head":{"label":"thiagodasilva:sharded_support","ref":"sharded_support","sha":"a933f40fa3f6fdc31c3b08cf8606912cbcca4ac7","user":{"login":"thiagodasilva","id":1494299,"node_id":"MDQ6VXNlcjE0OTQyOTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1494299?v=4","gravatar_id":"","url":"https://api.github.com/users/thiagodasilva","html_url":"https://github.com/thiagodasilva","followers_url":"https://api.github.com/users/thiagodasilva/followers","following_url":"https://api.github.com/users/thiagodasilva/following{/other_user}","gists_url":"https://api.github.com/users/thiagodasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/thiagodasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiagodasilva/subscriptions","organizations_url":"https://api.github.com/users/thiagodasilva/orgs","repos_url":"https://api.github.com/users/thiagodasilva/repos","events_url":"https://api.github.com/users/thiagodasilva/events{/privacy}","received_events_url":"https://api.github.com/users/thiagodasilva/received_events","type":"User","site_admin":false},"repo":{"id":146010070,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYwMTAwNzA=","name":"container-crawler","full_name":"thiagodasilva/container-crawler","private":false,"owner":{"login":"thiagodasilva","id":1494299,"node_id":"MDQ6VXNlcjE0OTQyOTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1494299?v=4","gravatar_id":"","url":"https://api.github.com/users/thiagodasilva","html_url":"https://github.com/thiagodasilva","followers_url":"https://api.github.com/users/thiagodasilva/followers","following_url":"https://api.github.com/users/thiagodasilva/following{/other_user}","gists_url":"https://api.github.com/users/thiagodasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/thiagodasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiagodasilva/subscriptions","organizations_url":"https://api.github.com/users/thiagodasilva/orgs","repos_url":"https://api.github.com/users/thiagodasilva/repos","events_url":"https://api.github.com/users/thiagodasilva/events{/privacy}","received_events_url":"https://api.github.com/users/thiagodasilva/received_events","type":"User","site_admin":false},"html_url":"https://github.com/thiagodasilva/container-crawler","description":"Library to crawl OpenStack Swift container databases. Can be used in other projects that need to examine changes to the containers.","fork":true,"url":"https://api.github.com/repos/thiagodasilva/container-crawler","forks_url":"https://api.github.com/repos/thiagodasilva/container-crawler/forks","keys_url":"https://api.github.com/repos/thiagodasilva/container-crawler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thiagodasilva/container-crawler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thiagodasilva/container-crawler/teams","hooks_url":"https://api.github.com/repos/thiagodasilva/container-crawler/hooks","issue_events_url":"https://api.github.com/repos/thiagodasilva/container-crawler/issues/events{/number}","events_url":"https://api.github.com/repos/thiagodasilva/container-crawler/events","assignees_url":"https://api.github.com/repos/thiagodasilva/container-crawler/assignees{/user}","branches_url":"https://api.github.com/repos/thiagodasilva/container-crawler/branches{/branch}","tags_url":"https://api.github.com/repos/thiagodasilva/container-crawler/tags","blobs_url":"https://api.github.com/repos/thiagodasilva/container-crawler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thiagodasilva/container-crawler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thiagodasilva/container-crawler/git/refs{/sha}","trees_url":"https://api.github.com/repos/thiagodasilva/container-crawler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thiagodasilva/container-crawler/statuses/{sha}","languages_url":"https://api.github.com/repos/thiagodasilva/container-crawler/languages","stargazers_url":"https://api.github.com/repos/thiagodasilva/container-crawler/stargazers","contributors_url":"https://api.github.com/repos/thiagodasilva/container-crawler/contributors","subscribers_url":"https://api.github.com/repos/thiagodasilva/container-crawler/subscribers","subscription_url":"https://api.github.com/repos/thiagodasilva/container-crawler/subscription","commits_url":"https://api.github.com/repos/thiagodasilva/container-crawler/commits{/sha}","git_commits_url":"https://api.github.com/repos/thiagodasilva/container-crawler/git/commits{/sha}","comments_url":"https://api.github.com/repos/thiagodasilva/container-crawler/comments{/number}","issue_comment_url":"https://api.github.com/repos/thiagodasilva/container-crawler/issues/comments{/number}","contents_url":"https://api.github.com/repos/thiagodasilva/container-crawler/contents/{+path}","compare_url":"https://api.github.com/repos/thiagodasilva/container-crawler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thiagodasilva/container-crawler/merges","archive_url":"https://api.github.com/repos/thiagodasilva/container-crawler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thiagodasilva/container-crawler/downloads","issues_url":"https://api.github.com/repos/thiagodasilva/container-crawler/issues{/number}","pulls_url":"https://api.github.com/repos/thiagodasilva/container-crawler/pulls{/number}","milestones_url":"https://api.github.com/repos/thiagodasilva/container-crawler/milestones{/number}","notifications_url":"https://api.github.com/repos/thiagodasilva/container-crawler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thiagodasilva/container-crawler/labels{/name}","releases_url":"https://api.github.com/repos/thiagodasilva/container-crawler/releases{/id}","deployments_url":"https://api.github.com/repos/thiagodasilva/container-crawler/deployments","created_at":"2018-08-24T15:40:46Z","updated_at":"2018-12-15T02:06:42Z","pushed_at":"2018-12-18T15:57:41Z","git_url":"git://github.com/thiagodasilva/container-crawler.git","ssh_url":"git@github.com:thiagodasilva/container-crawler.git","clone_url":"https://github.com/thiagodasilva/container-crawler.git","svn_url":"https://github.com/thiagodasilva/container-crawler","homepage":"","size":127,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"swiftstack:master","ref":"master","sha":"78d13e7b945ff49e22f1bd64b3821b55590acc12","user":{"login":"swiftstack","id":1240687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDA2ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/1240687?v=4","gravatar_id":"","url":"https://api.github.com/users/swiftstack","html_url":"https://github.com/swiftstack","followers_url":"https://api.github.com/users/swiftstack/followers","following_url":"https://api.github.com/users/swiftstack/following{/other_user}","gists_url":"https://api.github.com/users/swiftstack/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftstack/subscriptions","organizations_url":"https://api.github.com/users/swiftstack/orgs","repos_url":"https://api.github.com/users/swiftstack/repos","events_url":"https://api.github.com/users/swiftstack/events{/privacy}","received_events_url":"https://api.github.com/users/swiftstack/received_events","type":"Organization","site_admin":false},"repo":{"id":64433181,"node_id":"MDEwOlJlcG9zaXRvcnk2NDQzMzE4MQ==","name":"container-crawler","full_name":"swiftstack/container-crawler","private":false,"owner":{"login":"swiftstack","id":1240687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDA2ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/1240687?v=4","gravatar_id":"","url":"https://api.github.com/users/swiftstack","html_url":"https://github.com/swiftstack","followers_url":"https://api.github.com/users/swiftstack/followers","following_url":"https://api.github.com/users/swiftstack/following{/other_user}","gists_url":"https://api.github.com/users/swiftstack/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftstack/subscriptions","organizations_url":"https://api.github.com/users/swiftstack/orgs","repos_url":"https://api.github.com/users/swiftstack/repos","events_url":"https://api.github.com/users/swiftstack/events{/privacy}","received_events_url":"https://api.github.com/users/swiftstack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/swiftstack/container-crawler","description":"Library to crawl OpenStack Swift container databases. Can be used in other projects that need to examine changes to the containers.","fork":false,"url":"https://api.github.com/repos/swiftstack/container-crawler","forks_url":"https://api.github.com/repos/swiftstack/container-crawler/forks","keys_url":"https://api.github.com/repos/swiftstack/container-crawler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swiftstack/container-crawler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swiftstack/container-crawler/teams","hooks_url":"https://api.github.com/repos/swiftstack/container-crawler/hooks","issue_events_url":"https://api.github.com/repos/swiftstack/container-crawler/issues/events{/number}","events_url":"https://api.github.com/repos/swiftstack/container-crawler/events","assignees_url":"https://api.github.com/repos/swiftstack/container-crawler/assignees{/user}","branches_url":"https://api.github.com/repos/swiftstack/container-crawler/branches{/branch}","tags_url":"https://api.github.com/repos/swiftstack/container-crawler/tags","blobs_url":"https://api.github.com/repos/swiftstack/container-crawler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swiftstack/container-crawler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swiftstack/container-crawler/git/refs{/sha}","trees_url":"https://api.github.com/repos/swiftstack/container-crawler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swiftstack/container-crawler/statuses/{sha}","languages_url":"https://api.github.com/repos/swiftstack/container-crawler/languages","stargazers_url":"https://api.github.com/repos/swiftstack/container-crawler/stargazers","contributors_url":"https://api.github.com/repos/swiftstack/container-crawler/contributors","subscribers_url":"https://api.github.com/repos/swiftstack/container-crawler/subscribers","subscription_url":"https://api.github.com/repos/swiftstack/container-crawler/subscription","commits_url":"https://api.github.com/repos/swiftstack/container-crawler/commits{/sha}","git_commits_url":"https://api.github.com/repos/swiftstack/container-crawler/git/commits{/sha}","comments_url":"https://api.github.com/repos/swiftstack/container-crawler/comments{/number}","issue_comment_url":"https://api.github.com/repos/swiftstack/container-crawler/issues/comments{/number}","contents_url":"https://api.github.com/repos/swiftstack/container-crawler/contents/{+path}","compare_url":"https://api.github.com/repos/swiftstack/container-crawler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swiftstack/container-crawler/merges","archive_url":"https://api.github.com/repos/swiftstack/container-crawler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swiftstack/container-crawler/downloads","issues_url":"https://api.github.com/repos/swiftstack/container-crawler/issues{/number}","pulls_url":"https://api.github.com/repos/swiftstack/container-crawler/pulls{/number}","milestones_url":"https://api.github.com/repos/swiftstack/container-crawler/milestones{/number}","notifications_url":"https://api.github.com/repos/swiftstack/container-crawler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swiftstack/container-crawler/labels{/name}","releases_url":"https://api.github.com/repos/swiftstack/container-crawler/releases{/id}","deployments_url":"https://api.github.com/repos/swiftstack/container-crawler/deployments","created_at":"2016-07-28T22:49:55Z","updated_at":"2018-12-14T23:03:53Z","pushed_at":"2018-12-18T15:57:43Z","git_url":"git://github.com/swiftstack/container-crawler.git","ssh_url":"git@github.com:swiftstack/container-crawler.git","clone_url":"https://github.com/swiftstack/container-crawler.git","svn_url":"https://github.com/swiftstack/container-crawler","homepage":"","size":104,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/swiftstack/container-crawler/pulls/26"},"html":{"href":"https://github.com/swiftstack/container-crawler/pull/26"},"issue":{"href":"https://api.github.com/repos/swiftstack/container-crawler/issues/26"},"comments":{"href":"https://api.github.com/repos/swiftstack/container-crawler/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/swiftstack/container-crawler/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/swiftstack/container-crawler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swiftstack/container-crawler/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/swiftstack/container-crawler/statuses/a933f40fa3f6fdc31c3b08cf8606912cbcca4ac7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"timuralp"}}