{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/192566826","pull_request_review_id":125373331,"id":192566826,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjU2NjgyNg==","diff_hunk":"@@ -122,6 +123,13 @@ def escape_cdata(text):\n     text = text.replace('\"', '&quot;')\n     return text\n \n+def check_bitcoin_addr(text):\n+    p = re.compile('^([1,3]|bc1)[a-zA-Z0-9]{33,39}$')","path":"contrib/devtools/update-translations.py","position":13,"original_position":13,"commit_id":"4f03c2240af4e0fb604a22caa6291566fe874729","original_commit_id":"4f03c2240af4e0fb604a22caa6291566fe874729","user":{"login":"kaplanmaxe","id":3860450,"node_id":"MDQ6VXNlcjM4NjA0NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3860450?v=4","gravatar_id":"","url":"https://api.github.com/users/kaplanmaxe","html_url":"https://github.com/kaplanmaxe","followers_url":"https://api.github.com/users/kaplanmaxe/followers","following_url":"https://api.github.com/users/kaplanmaxe/following{/other_user}","gists_url":"https://api.github.com/users/kaplanmaxe/gists{/gist_id}","starred_url":"https://api.github.com/users/kaplanmaxe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaplanmaxe/subscriptions","organizations_url":"https://api.github.com/users/kaplanmaxe/orgs","repos_url":"https://api.github.com/users/kaplanmaxe/repos","events_url":"https://api.github.com/users/kaplanmaxe/events{/privacy}","received_events_url":"https://api.github.com/users/kaplanmaxe/received_events","type":"User","site_admin":false},"body":"Agreed. I want to avoid false positives here. What do you suggest the best way forward is? I could split on any spaces in the string then perform this check, but that might be rather expensive, although I'm not sure if performance is all that important in this file? If I don't set some sort of string length in the regex pattern, there are going to be a bunch of false positives.","created_at":"2018-06-02T18:33:07Z","updated_at":"2018-06-02T18:33:07Z","html_url":"https://github.com/bitcoin/bitcoin/pull/13374#discussion_r192566826","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13374","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/192566826"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/13374#discussion_r192566826"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13374"}},"in_reply_to_id":192566414},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13374","id":192209371,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMjA5Mzcx","html_url":"https://github.com/bitcoin/bitcoin/pull/13374","diff_url":"https://github.com/bitcoin/bitcoin/pull/13374.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/13374.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13374","number":13374,"state":"open","locked":false,"title":"utils and libraries: checking for bitcoin address in translations","user":{"login":"kaplanmaxe","id":3860450,"node_id":"MDQ6VXNlcjM4NjA0NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3860450?v=4","gravatar_id":"","url":"https://api.github.com/users/kaplanmaxe","html_url":"https://github.com/kaplanmaxe","followers_url":"https://api.github.com/users/kaplanmaxe/followers","following_url":"https://api.github.com/users/kaplanmaxe/following{/other_user}","gists_url":"https://api.github.com/users/kaplanmaxe/gists{/gist_id}","starred_url":"https://api.github.com/users/kaplanmaxe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaplanmaxe/subscriptions","organizations_url":"https://api.github.com/users/kaplanmaxe/orgs","repos_url":"https://api.github.com/users/kaplanmaxe/repos","events_url":"https://api.github.com/users/kaplanmaxe/events{/privacy}","received_events_url":"https://api.github.com/users/kaplanmaxe/received_events","type":"User","site_admin":false},"body":"Don't really write much Python so any feedback is appreciated!\r\n\r\nCloses #13363 ","created_at":"2018-06-02T17:47:04Z","updated_at":"2018-06-02T18:33:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"634a608f2f471076021ccd363d1f4610e98c4263","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13374/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13374/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/13374/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/4f03c2240af4e0fb604a22caa6291566fe874729","head":{"label":"kaplanmaxe:check-addr-translations","ref":"check-addr-translations","sha":"4f03c2240af4e0fb604a22caa6291566fe874729","user":{"login":"kaplanmaxe","id":3860450,"node_id":"MDQ6VXNlcjM4NjA0NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3860450?v=4","gravatar_id":"","url":"https://api.github.com/users/kaplanmaxe","html_url":"https://github.com/kaplanmaxe","followers_url":"https://api.github.com/users/kaplanmaxe/followers","following_url":"https://api.github.com/users/kaplanmaxe/following{/other_user}","gists_url":"https://api.github.com/users/kaplanmaxe/gists{/gist_id}","starred_url":"https://api.github.com/users/kaplanmaxe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaplanmaxe/subscriptions","organizations_url":"https://api.github.com/users/kaplanmaxe/orgs","repos_url":"https://api.github.com/users/kaplanmaxe/repos","events_url":"https://api.github.com/users/kaplanmaxe/events{/privacy}","received_events_url":"https://api.github.com/users/kaplanmaxe/received_events","type":"User","site_admin":false},"repo":{"id":135839098,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU4MzkwOTg=","name":"bitcoin","full_name":"kaplanmaxe/bitcoin","owner":{"login":"kaplanmaxe","id":3860450,"node_id":"MDQ6VXNlcjM4NjA0NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3860450?v=4","gravatar_id":"","url":"https://api.github.com/users/kaplanmaxe","html_url":"https://github.com/kaplanmaxe","followers_url":"https://api.github.com/users/kaplanmaxe/followers","following_url":"https://api.github.com/users/kaplanmaxe/following{/other_user}","gists_url":"https://api.github.com/users/kaplanmaxe/gists{/gist_id}","starred_url":"https://api.github.com/users/kaplanmaxe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaplanmaxe/subscriptions","organizations_url":"https://api.github.com/users/kaplanmaxe/orgs","repos_url":"https://api.github.com/users/kaplanmaxe/repos","events_url":"https://api.github.com/users/kaplanmaxe/events{/privacy}","received_events_url":"https://api.github.com/users/kaplanmaxe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kaplanmaxe/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/kaplanmaxe/bitcoin","forks_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/forks","keys_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/teams","hooks_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/events","assignees_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/tags","blobs_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/languages","stargazers_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/subscription","commits_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/merges","archive_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/downloads","issues_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/kaplanmaxe/bitcoin/deployments","created_at":"2018-06-02T17:40:34Z","updated_at":"2018-06-02T17:40:47Z","pushed_at":"2018-06-02T17:43:57Z","git_url":"git://github.com/kaplanmaxe/bitcoin.git","ssh_url":"git@github.com:kaplanmaxe/bitcoin.git","clone_url":"https://github.com/kaplanmaxe/bitcoin.git","svn_url":"https://github.com/kaplanmaxe/bitcoin","homepage":"https://bitcoin.org/en/download","size":103216,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"e24bf1ce184bc8d5bba70a3f3e9c43c2df07f4d3","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2018-06-02T18:21:14Z","pushed_at":"2018-06-02T17:53:19Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":103216,"stargazers_count":32046,"watchers_count":32046,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":19302,"mirror_url":null,"archived":false,"open_issues_count":803,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":19302,"open_issues":803,"watchers":32046,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13374"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/13374"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/13374"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/13374/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13374/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/13374/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/4f03c2240af4e0fb604a22caa6291566fe874729"}},"author_association":"NONE"}}
{"actor":{"display_login":"kaplanmaxe"}}