{"action":"created","issue":{"url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/504","repository_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui","labels_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/504/labels{/name}","comments_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/504/comments","events_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/504/events","html_url":"https://github.com/jsdrupal/drupal-admin-ui/pull/504","id":369493047,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNDIxNDM2","number":504,"title":"Monorepo structure for allowing usage of components outside of this project","user":{"login":"lauriii","id":1845495,"node_id":"MDQ6VXNlcjE4NDU0OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1845495?v=4","gravatar_id":"","url":"https://api.github.com/users/lauriii","html_url":"https://github.com/lauriii","followers_url":"https://api.github.com/users/lauriii/followers","following_url":"https://api.github.com/users/lauriii/following{/other_user}","gists_url":"https://api.github.com/users/lauriii/gists{/gist_id}","starred_url":"https://api.github.com/users/lauriii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lauriii/subscriptions","organizations_url":"https://api.github.com/users/lauriii/orgs","repos_url":"https://api.github.com/users/lauriii/repos","events_url":"https://api.github.com/users/lauriii/events{/privacy}","received_events_url":"https://api.github.com/users/lauriii/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-12T10:28:45Z","updated_at":"2018-10-25T11:05:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/pulls/504","html_url":"https://github.com/jsdrupal/drupal-admin-ui/pull/504","diff_url":"https://github.com/jsdrupal/drupal-admin-ui/pull/504.diff","patch_url":"https://github.com/jsdrupal/drupal-admin-ui/pull/504.patch"},"body":"## Issue\r\n\r\nhttps://github.com/jsdrupal/drupal-admin-ui/issues/497\r\n\r\n## Description\r\nThis modifies the directory structure so that the project is set up as monorepo. I used yarn workspaces but we could consider using [lerna](https://github.com/lerna/lerna) if we find their tooling useful. The packages are under `packages/` folder. The new `drupal-ui` package will contain all of the reusable components.\r\n\r\nTo make sure that at least the build works, I created an entry point which contains all of the components inside the component library. We might want to modify this so that components can be loaded one by one.\r\n\r\n## Remaining tasks\r\n- Update documented installation steps to match with the new structure\r\n- Update installation steps used in the CI to match with the documented steps\r\n- Allow loading of individual components.\r\n\r\n## Example of installation steps for developers wanting to use the component library\r\n*Note: these steps won't work before the package is published in the npm registry*\r\n\r\nAdd dependency for the package 🚀\r\n`yarn add drupal-ui`\r\n\r\nUse components 👯‍♀️🎉\r\n```\r\nimport { PageTitle } from 'drupal-ui';\r\n\r\nconst app = () => (\r\n  <div>\r\n    <PageTitle>Title</PageTitle>\r\n  </div>\r\n)\r\n```\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/comments/433008757","html_url":"https://github.com/jsdrupal/drupal-admin-ui/pull/504#issuecomment-433008757","issue_url":"https://api.github.com/repos/jsdrupal/drupal-admin-ui/issues/504","id":433008757,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzAwODc1Nw==","user":{"login":"lauriii","id":1845495,"node_id":"MDQ6VXNlcjE4NDU0OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/1845495?v=4","gravatar_id":"","url":"https://api.github.com/users/lauriii","html_url":"https://github.com/lauriii","followers_url":"https://api.github.com/users/lauriii/followers","following_url":"https://api.github.com/users/lauriii/following{/other_user}","gists_url":"https://api.github.com/users/lauriii/gists{/gist_id}","starred_url":"https://api.github.com/users/lauriii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lauriii/subscriptions","organizations_url":"https://api.github.com/users/lauriii/orgs","repos_url":"https://api.github.com/users/lauriii/repos","events_url":"https://api.github.com/users/lauriii/events{/privacy}","received_events_url":"https://api.github.com/users/lauriii/received_events","type":"User","site_admin":false},"created_at":"2018-10-25T11:05:14Z","updated_at":"2018-10-25T11:05:14Z","author_association":"CONTRIBUTOR","body":"It seems like the `lint_unit` test is failing because of there's something wrong with CircleCI itself. I run the task using CircleCI locally and the task is passing. My local installation didn't support caches, so I would guess this problem to be most likely caused by that."}}
{"actor":{"display_login":"lauriii"}}