{"action":"created","comment":{"url":"https://api.github.com/repos/encukou/bresenham/pulls/comments/230705706","pull_request_review_id":171499340,"id":230705706,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDcwNTcwNg==","diff_hunk":"@@ -0,0 +1 @@\n+numpy==1.15.4","path":"requirements.txt","position":1,"original_position":1,"commit_id":"c16091cc27e1cb57e78ffccee01790a4eb3814a4","original_commit_id":"c16091cc27e1cb57e78ffccee01790a4eb3814a4","user":{"login":"encukou","id":302922,"node_id":"MDQ6VXNlcjMwMjkyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/302922?v=4","gravatar_id":"","url":"https://api.github.com/users/encukou","html_url":"https://github.com/encukou","followers_url":"https://api.github.com/users/encukou/followers","following_url":"https://api.github.com/users/encukou/following{/other_user}","gists_url":"https://api.github.com/users/encukou/gists{/gist_id}","starred_url":"https://api.github.com/users/encukou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/encukou/subscriptions","organizations_url":"https://api.github.com/users/encukou/orgs","repos_url":"https://api.github.com/users/encukou/repos","events_url":"https://api.github.com/users/encukou/events{/privacy}","received_events_url":"https://api.github.com/users/encukou/received_events","type":"User","site_admin":false},"body":"I'd be happier if this wasn't a hard requirement: the generator version is still useful without numpy, and should be usable (and tested) without numpy.","created_at":"2018-11-05T10:46:24Z","updated_at":"2018-11-05T10:46:24Z","html_url":"https://github.com/encukou/bresenham/pull/5#discussion_r230705706","pull_request_url":"https://api.github.com/repos/encukou/bresenham/pulls/5","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/encukou/bresenham/pulls/comments/230705706"},"html":{"href":"https://github.com/encukou/bresenham/pull/5#discussion_r230705706"},"pull_request":{"href":"https://api.github.com/repos/encukou/bresenham/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/encukou/bresenham/pulls/5","id":228221897,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MjIxODk3","html_url":"https://github.com/encukou/bresenham/pull/5","diff_url":"https://github.com/encukou/bresenham/pull/5.diff","patch_url":"https://github.com/encukou/bresenham/pull/5.patch","issue_url":"https://api.github.com/repos/encukou/bresenham/issues/5","number":5,"state":"open","locked":false,"title":"Add vectorized implementation","user":{"login":"marcotama","id":1052500,"node_id":"MDQ6VXNlcjEwNTI1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1052500?v=4","gravatar_id":"","url":"https://api.github.com/users/marcotama","html_url":"https://github.com/marcotama","followers_url":"https://api.github.com/users/marcotama/followers","following_url":"https://api.github.com/users/marcotama/following{/other_user}","gists_url":"https://api.github.com/users/marcotama/gists{/gist_id}","starred_url":"https://api.github.com/users/marcotama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcotama/subscriptions","organizations_url":"https://api.github.com/users/marcotama/orgs","repos_url":"https://api.github.com/users/marcotama/repos","events_url":"https://api.github.com/users/marcotama/events{/privacy}","received_events_url":"https://api.github.com/users/marcotama/received_events","type":"User","site_admin":false},"body":"This is the vectorized implementation discussed in issue #4 .","created_at":"2018-11-05T01:56:01Z","updated_at":"2018-11-05T10:46:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5c68813f75cec4c86bc5c76509f4eeccdd78bbf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/encukou/bresenham/pulls/5/commits","review_comments_url":"https://api.github.com/repos/encukou/bresenham/pulls/5/comments","review_comment_url":"https://api.github.com/repos/encukou/bresenham/pulls/comments{/number}","comments_url":"https://api.github.com/repos/encukou/bresenham/issues/5/comments","statuses_url":"https://api.github.com/repos/encukou/bresenham/statuses/c16091cc27e1cb57e78ffccee01790a4eb3814a4","head":{"label":"marcotama:vectorized_implementation","ref":"vectorized_implementation","sha":"c16091cc27e1cb57e78ffccee01790a4eb3814a4","user":{"login":"marcotama","id":1052500,"node_id":"MDQ6VXNlcjEwNTI1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1052500?v=4","gravatar_id":"","url":"https://api.github.com/users/marcotama","html_url":"https://github.com/marcotama","followers_url":"https://api.github.com/users/marcotama/followers","following_url":"https://api.github.com/users/marcotama/following{/other_user}","gists_url":"https://api.github.com/users/marcotama/gists{/gist_id}","starred_url":"https://api.github.com/users/marcotama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcotama/subscriptions","organizations_url":"https://api.github.com/users/marcotama/orgs","repos_url":"https://api.github.com/users/marcotama/repos","events_url":"https://api.github.com/users/marcotama/events{/privacy}","received_events_url":"https://api.github.com/users/marcotama/received_events","type":"User","site_admin":false},"repo":{"id":156142562,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYxNDI1NjI=","name":"bresenham","full_name":"marcotama/bresenham","private":false,"owner":{"login":"marcotama","id":1052500,"node_id":"MDQ6VXNlcjEwNTI1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1052500?v=4","gravatar_id":"","url":"https://api.github.com/users/marcotama","html_url":"https://github.com/marcotama","followers_url":"https://api.github.com/users/marcotama/followers","following_url":"https://api.github.com/users/marcotama/following{/other_user}","gists_url":"https://api.github.com/users/marcotama/gists{/gist_id}","starred_url":"https://api.github.com/users/marcotama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcotama/subscriptions","organizations_url":"https://api.github.com/users/marcotama/orgs","repos_url":"https://api.github.com/users/marcotama/repos","events_url":"https://api.github.com/users/marcotama/events{/privacy}","received_events_url":"https://api.github.com/users/marcotama/received_events","type":"User","site_admin":false},"html_url":"https://github.com/marcotama/bresenham","description":"A simple implementation of Bresenham's line drawing algorithm","fork":true,"url":"https://api.github.com/repos/marcotama/bresenham","forks_url":"https://api.github.com/repos/marcotama/bresenham/forks","keys_url":"https://api.github.com/repos/marcotama/bresenham/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcotama/bresenham/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcotama/bresenham/teams","hooks_url":"https://api.github.com/repos/marcotama/bresenham/hooks","issue_events_url":"https://api.github.com/repos/marcotama/bresenham/issues/events{/number}","events_url":"https://api.github.com/repos/marcotama/bresenham/events","assignees_url":"https://api.github.com/repos/marcotama/bresenham/assignees{/user}","branches_url":"https://api.github.com/repos/marcotama/bresenham/branches{/branch}","tags_url":"https://api.github.com/repos/marcotama/bresenham/tags","blobs_url":"https://api.github.com/repos/marcotama/bresenham/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcotama/bresenham/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcotama/bresenham/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcotama/bresenham/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcotama/bresenham/statuses/{sha}","languages_url":"https://api.github.com/repos/marcotama/bresenham/languages","stargazers_url":"https://api.github.com/repos/marcotama/bresenham/stargazers","contributors_url":"https://api.github.com/repos/marcotama/bresenham/contributors","subscribers_url":"https://api.github.com/repos/marcotama/bresenham/subscribers","subscription_url":"https://api.github.com/repos/marcotama/bresenham/subscription","commits_url":"https://api.github.com/repos/marcotama/bresenham/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcotama/bresenham/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcotama/bresenham/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcotama/bresenham/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcotama/bresenham/contents/{+path}","compare_url":"https://api.github.com/repos/marcotama/bresenham/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcotama/bresenham/merges","archive_url":"https://api.github.com/repos/marcotama/bresenham/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcotama/bresenham/downloads","issues_url":"https://api.github.com/repos/marcotama/bresenham/issues{/number}","pulls_url":"https://api.github.com/repos/marcotama/bresenham/pulls{/number}","milestones_url":"https://api.github.com/repos/marcotama/bresenham/milestones{/number}","notifications_url":"https://api.github.com/repos/marcotama/bresenham/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcotama/bresenham/labels{/name}","releases_url":"https://api.github.com/repos/marcotama/bresenham/releases{/id}","deployments_url":"https://api.github.com/repos/marcotama/bresenham/deployments","created_at":"2018-11-05T01:17:24Z","updated_at":"2018-11-05T01:17:26Z","pushed_at":"2018-11-05T01:52:10Z","git_url":"git://github.com/marcotama/bresenham.git","ssh_url":"git@github.com:marcotama/bresenham.git","clone_url":"https://github.com/marcotama/bresenham.git","svn_url":"https://github.com/marcotama/bresenham","homepage":"","size":6,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"encukou:master","ref":"master","sha":"a341fbd891edc014f3e5934cf4c12d1877b4fccd","user":{"login":"encukou","id":302922,"node_id":"MDQ6VXNlcjMwMjkyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/302922?v=4","gravatar_id":"","url":"https://api.github.com/users/encukou","html_url":"https://github.com/encukou","followers_url":"https://api.github.com/users/encukou/followers","following_url":"https://api.github.com/users/encukou/following{/other_user}","gists_url":"https://api.github.com/users/encukou/gists{/gist_id}","starred_url":"https://api.github.com/users/encukou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/encukou/subscriptions","organizations_url":"https://api.github.com/users/encukou/orgs","repos_url":"https://api.github.com/users/encukou/repos","events_url":"https://api.github.com/users/encukou/events{/privacy}","received_events_url":"https://api.github.com/users/encukou/received_events","type":"User","site_admin":false},"repo":{"id":74617338,"node_id":"MDEwOlJlcG9zaXRvcnk3NDYxNzMzOA==","name":"bresenham","full_name":"encukou/bresenham","private":false,"owner":{"login":"encukou","id":302922,"node_id":"MDQ6VXNlcjMwMjkyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/302922?v=4","gravatar_id":"","url":"https://api.github.com/users/encukou","html_url":"https://github.com/encukou","followers_url":"https://api.github.com/users/encukou/followers","following_url":"https://api.github.com/users/encukou/following{/other_user}","gists_url":"https://api.github.com/users/encukou/gists{/gist_id}","starred_url":"https://api.github.com/users/encukou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/encukou/subscriptions","organizations_url":"https://api.github.com/users/encukou/orgs","repos_url":"https://api.github.com/users/encukou/repos","events_url":"https://api.github.com/users/encukou/events{/privacy}","received_events_url":"https://api.github.com/users/encukou/received_events","type":"User","site_admin":false},"html_url":"https://github.com/encukou/bresenham","description":"A simple implementation of Bresenham's line drawing algorithm","fork":false,"url":"https://api.github.com/repos/encukou/bresenham","forks_url":"https://api.github.com/repos/encukou/bresenham/forks","keys_url":"https://api.github.com/repos/encukou/bresenham/keys{/key_id}","collaborators_url":"https://api.github.com/repos/encukou/bresenham/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/encukou/bresenham/teams","hooks_url":"https://api.github.com/repos/encukou/bresenham/hooks","issue_events_url":"https://api.github.com/repos/encukou/bresenham/issues/events{/number}","events_url":"https://api.github.com/repos/encukou/bresenham/events","assignees_url":"https://api.github.com/repos/encukou/bresenham/assignees{/user}","branches_url":"https://api.github.com/repos/encukou/bresenham/branches{/branch}","tags_url":"https://api.github.com/repos/encukou/bresenham/tags","blobs_url":"https://api.github.com/repos/encukou/bresenham/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/encukou/bresenham/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/encukou/bresenham/git/refs{/sha}","trees_url":"https://api.github.com/repos/encukou/bresenham/git/trees{/sha}","statuses_url":"https://api.github.com/repos/encukou/bresenham/statuses/{sha}","languages_url":"https://api.github.com/repos/encukou/bresenham/languages","stargazers_url":"https://api.github.com/repos/encukou/bresenham/stargazers","contributors_url":"https://api.github.com/repos/encukou/bresenham/contributors","subscribers_url":"https://api.github.com/repos/encukou/bresenham/subscribers","subscription_url":"https://api.github.com/repos/encukou/bresenham/subscription","commits_url":"https://api.github.com/repos/encukou/bresenham/commits{/sha}","git_commits_url":"https://api.github.com/repos/encukou/bresenham/git/commits{/sha}","comments_url":"https://api.github.com/repos/encukou/bresenham/comments{/number}","issue_comment_url":"https://api.github.com/repos/encukou/bresenham/issues/comments{/number}","contents_url":"https://api.github.com/repos/encukou/bresenham/contents/{+path}","compare_url":"https://api.github.com/repos/encukou/bresenham/compare/{base}...{head}","merges_url":"https://api.github.com/repos/encukou/bresenham/merges","archive_url":"https://api.github.com/repos/encukou/bresenham/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/encukou/bresenham/downloads","issues_url":"https://api.github.com/repos/encukou/bresenham/issues{/number}","pulls_url":"https://api.github.com/repos/encukou/bresenham/pulls{/number}","milestones_url":"https://api.github.com/repos/encukou/bresenham/milestones{/number}","notifications_url":"https://api.github.com/repos/encukou/bresenham/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/encukou/bresenham/labels{/name}","releases_url":"https://api.github.com/repos/encukou/bresenham/releases{/id}","deployments_url":"https://api.github.com/repos/encukou/bresenham/deployments","created_at":"2016-11-23T22:01:49Z","updated_at":"2018-11-03T01:34:45Z","pushed_at":"2018-11-05T01:56:01Z","git_url":"git://github.com/encukou/bresenham.git","ssh_url":"git@github.com:encukou/bresenham.git","clone_url":"https://github.com/encukou/bresenham.git","svn_url":"https://github.com/encukou/bresenham","homepage":"","size":5,"stargazers_count":15,"watchers_count":15,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":2,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/encukou/bresenham/pulls/5"},"html":{"href":"https://github.com/encukou/bresenham/pull/5"},"issue":{"href":"https://api.github.com/repos/encukou/bresenham/issues/5"},"comments":{"href":"https://api.github.com/repos/encukou/bresenham/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/encukou/bresenham/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/encukou/bresenham/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/encukou/bresenham/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/encukou/bresenham/statuses/c16091cc27e1cb57e78ffccee01790a4eb3814a4"}},"author_association":"NONE"}}
{"actor":{"display_login":"encukou"}}