{"action":"created","issue":{"url":"https://api.github.com/repos/efficient/libcuckoo/issues/103","repository_url":"https://api.github.com/repos/efficient/libcuckoo","labels_url":"https://api.github.com/repos/efficient/libcuckoo/issues/103/labels{/name}","comments_url":"https://api.github.com/repos/efficient/libcuckoo/issues/103/comments","events_url":"https://api.github.com/repos/efficient/libcuckoo/issues/103/events","html_url":"https://github.com/efficient/libcuckoo/pull/103","id":329828274,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyOTgzMDYw","number":103,"title":"Fix friend declarations that refer to templates, not classes.","user":{"login":"toojays","id":378690,"node_id":"MDQ6VXNlcjM3ODY5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/378690?v=4","gravatar_id":"","url":"https://api.github.com/users/toojays","html_url":"https://github.com/toojays","followers_url":"https://api.github.com/users/toojays/followers","following_url":"https://api.github.com/users/toojays/following{/other_user}","gists_url":"https://api.github.com/users/toojays/gists{/gist_id}","starred_url":"https://api.github.com/users/toojays/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toojays/subscriptions","organizations_url":"https://api.github.com/users/toojays/orgs","repos_url":"https://api.github.com/users/toojays/repos","events_url":"https://api.github.com/users/toojays/events{/privacy}","received_events_url":"https://api.github.com/users/toojays/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-06T11:31:36Z","updated_at":"2018-06-06T11:49:07Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/efficient/libcuckoo/pulls/103","html_url":"https://github.com/efficient/libcuckoo/pull/103","diff_url":"https://github.com/efficient/libcuckoo/pull/103.diff","patch_url":"https://github.com/efficient/libcuckoo/pull/103.patch"},"body":"This commit addresses a couple of PW.BAD_FRIEND_DECL parse warnings thrown up by\r\nCoverity.\r\n\r\nApparently a friend declaration that refers to a template (as opposed to a type)\r\nis not legal C++. Who knew? Neither GCC nor MSVC seem to care. Anyhow, this\r\ncommit corrects the error by specifying all the necessary template parameters to\r\nmake the declarations refer to types."},"comment":{"url":"https://api.github.com/repos/efficient/libcuckoo/issues/comments/395041084","html_url":"https://github.com/efficient/libcuckoo/pull/103#issuecomment-395041084","issue_url":"https://api.github.com/repos/efficient/libcuckoo/issues/103","id":395041084,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTA0MTA4NA==","user":{"login":"dnbaker","id":6412885,"node_id":"MDQ6VXNlcjY0MTI4ODU=","avatar_url":"https://avatars2.githubusercontent.com/u/6412885?v=4","gravatar_id":"","url":"https://api.github.com/users/dnbaker","html_url":"https://github.com/dnbaker","followers_url":"https://api.github.com/users/dnbaker/followers","following_url":"https://api.github.com/users/dnbaker/following{/other_user}","gists_url":"https://api.github.com/users/dnbaker/gists{/gist_id}","starred_url":"https://api.github.com/users/dnbaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnbaker/subscriptions","organizations_url":"https://api.github.com/users/dnbaker/orgs","repos_url":"https://api.github.com/users/dnbaker/repos","events_url":"https://api.github.com/users/dnbaker/events{/privacy}","received_events_url":"https://api.github.com/users/dnbaker/received_events","type":"User","site_admin":false},"created_at":"2018-06-06T11:49:07Z","updated_at":"2018-06-06T11:49:07Z","author_association":"NONE","body":"I think Coverity is mistaken here. cuckoohashmap in this context (IE, inside the class template) refers to its own type already, just like the constructor refers to the type of the template class being instantiated, not the class template."}}
{"actor":{"display_login":"dnbaker"}}