{"action":"created","issue":{"url":"https://api.github.com/repos/knative/serving/issues/1913","repository_url":"https://api.github.com/repos/knative/serving","labels_url":"https://api.github.com/repos/knative/serving/issues/1913/labels{/name}","comments_url":"https://api.github.com/repos/knative/serving/issues/1913/comments","events_url":"https://api.github.com/repos/knative/serving/issues/1913/events","html_url":"https://github.com/knative/serving/pull/1913","id":352618610,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5ODg0OTI0","number":1913,"title":"Bypass istio to prevent activator retry loop.","user":{"login":"markusthoemmes","id":1289147,"node_id":"MDQ6VXNlcjEyODkxNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1289147?v=4","gravatar_id":"","url":"https://api.github.com/users/markusthoemmes","html_url":"https://github.com/markusthoemmes","followers_url":"https://api.github.com/users/markusthoemmes/followers","following_url":"https://api.github.com/users/markusthoemmes/following{/other_user}","gists_url":"https://api.github.com/users/markusthoemmes/gists{/gist_id}","starred_url":"https://api.github.com/users/markusthoemmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusthoemmes/subscriptions","organizations_url":"https://api.github.com/users/markusthoemmes/orgs","repos_url":"https://api.github.com/users/markusthoemmes/repos","events_url":"https://api.github.com/users/markusthoemmes/events{/privacy}","received_events_url":"https://api.github.com/users/markusthoemmes/received_events","type":"User","site_admin":false},"labels":[{"id":860818304,"node_id":"MDU6TGFiZWw4NjA4MTgzMDQ=","url":"https://api.github.com/repos/knative/serving/labels/size/S","name":"size/S","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-21T16:28:04Z","updated_at":"2018-08-21T18:12:39Z","closed_at":"2018-08-21T18:12:39Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/knative/serving/pulls/1913","html_url":"https://github.com/knative/serving/pull/1913","diff_url":"https://github.com/knative/serving/pull/1913.diff","patch_url":"https://github.com/knative/serving/pull/1913.patch"},"body":"Fixes #1907\r\n\r\n## Proposed Changes\r\n\r\nWhen the activator proxies and retries requests to make sure a Revision is actually routable, Istio will pick the requests up and forward them to the activator itself if network programming is not done completely.\r\n\r\nResetting the Host header bypasses istio so the Revision's service can be adressed directly.\r\n\r\n**Release Note**\r\n<!-- Enter your extended release note in the below block. If the PR requires\r\nadditional action from users switching to the new release, include the string\r\n\"action required\". If no release note is required, write \"NONE\". -->\r\n```release-note\r\nBypass istio to prevent activator retry loop.\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/knative/serving/issues/comments/414770388","html_url":"https://github.com/knative/serving/pull/1913#issuecomment-414770388","issue_url":"https://api.github.com/repos/knative/serving/issues/1913","id":414770388,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDc3MDM4OA==","user":{"login":"tcnghia","id":138266,"node_id":"MDQ6VXNlcjEzODI2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/138266?v=4","gravatar_id":"","url":"https://api.github.com/users/tcnghia","html_url":"https://github.com/tcnghia","followers_url":"https://api.github.com/users/tcnghia/followers","following_url":"https://api.github.com/users/tcnghia/following{/other_user}","gists_url":"https://api.github.com/users/tcnghia/gists{/gist_id}","starred_url":"https://api.github.com/users/tcnghia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcnghia/subscriptions","organizations_url":"https://api.github.com/users/tcnghia/orgs","repos_url":"https://api.github.com/users/tcnghia/repos","events_url":"https://api.github.com/users/tcnghia/events{/privacy}","received_events_url":"https://api.github.com/users/tcnghia/received_events","type":"User","site_admin":false},"created_at":"2018-08-21T18:12:39Z","updated_at":"2018-08-21T18:12:39Z","author_association":"CONTRIBUTOR","body":"per our discussion on #networking we choose to not mess with requests header and just reject activator self-requests in #1908 "}}
{"actor":{"display_login":"tcnghia"}}