{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/polaris-react/pulls/comments/231311697","pull_request_review_id":172256507,"id":231311697,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTMxMTY5Nw==","diff_hunk":"@@ -418,82 +340,204 @@ describe('<ComboBox/>', () => {\n   });\n \n   describe('keypress events', () => {\n-    it('selects the first option when the down arrow is pressed', () => {\n-      const comboBox = mountWithAppProvider(\n-        <ComboBox\n-          options={options}\n-          selected={[]}\n-          textField={renderTextField()}\n-          onSelect={noop}\n-        />,\n-      );\n-\n-      async () => {\n-        comboBox.find(TextField).simulate('click');\n-        listenerMap.keyup({keyCode: Key.DownArrow});\n-        await expect(comboBox.state('selectedIndex')).toBe(0);\n-      };\n-    });\n-\n-    it('adds to selected options when the down arrow and enter keys are pressed', () => {\n-      const spy = jest.fn();\n-      const comboBox = mountWithAppProvider(\n-        <ComboBox\n-          options={options}\n-          selected={[]}\n-          textField={renderTextField()}\n-          onSelect={spy}\n-        />,\n-      );\n-\n-      async () => {\n-        comboBox.find(TextField).simulate('click');\n-        await listenerMap.keyup({keyCode: Key.DownArrow});\n-      };\n-\n-      async () => {\n-        listenerMap.keyup({keyCode: Key.Enter});\n-        await expect(spy).toHaveBeenCalledTimes(1);\n-        expect(comboBox.prop('selected')[0]).toBe('cheese_pizza');\n-      };\n-    });\n-\n-    it('activates the popover when the tab key is pressed', () => {\n-      const comboBox = mountWithAppProvider(\n-        <ComboBox\n-          options={options}\n-          selected={[]}\n-          textField={renderTextField()}\n-          onSelect={noop}\n-        />,\n-      );\n-\n-      async () => {\n-        listenerMap.keyup({keyCode: Key.Tab});\n-        await expect(comboBox.state('popoverActive')).toBe(true);\n-      };\n-    });\n-\n-    it('deactivates the popover when the escape key is pressed', () => {\n-      const comboBox = mountWithAppProvider(\n-        <ComboBox\n-          options={options}\n-          selected={[]}\n-          textField={renderTextField()}\n-          onSelect={noop}\n-        />,\n-      );\n-\n-      async () => {\n-        comboBox.find(TextField).simulate('click');\n-        await listenerMap.keyup({keyCode: Key.DownArrow});\n-        expect(comboBox.state('popoverActive')).toBe(true);\n-      };\n-\n-      async () => {\n-        listenerMap.keyup({keyCode: Key.Escape});\n-        await expect(comboBox.state('popoverActive')).toBe(false);\n-      };\n+    describe('down arrow', () => {\n+      it('selects nothing if there are no options', () => {\n+        const options: OptionDescriptor[] = [];\n+        const comboBox = mountWithAppProvider(\n+          <ComboBox {...mockProps} options={options} />,\n+        );\n+\n+        async () => {\n+          comboBox.find(TextField).simulate('click');","path":"src/components/Autocomplete/components/ComboBox/tests/ComboBox.test.tsx","position":382,"original_position":382,"commit_id":"c0be5a316fc4f818554d3885650f0f0e6e8409ec","original_commit_id":"c0be5a316fc4f818554d3885650f0f0e6e8409ec","user":{"login":"solonaarmstrong","id":6239480,"node_id":"MDQ6VXNlcjYyMzk0ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/6239480?v=4","gravatar_id":"","url":"https://api.github.com/users/solonaarmstrong","html_url":"https://github.com/solonaarmstrong","followers_url":"https://api.github.com/users/solonaarmstrong/followers","following_url":"https://api.github.com/users/solonaarmstrong/following{/other_user}","gists_url":"https://api.github.com/users/solonaarmstrong/gists{/gist_id}","starred_url":"https://api.github.com/users/solonaarmstrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solonaarmstrong/subscriptions","organizations_url":"https://api.github.com/users/solonaarmstrong/orgs","repos_url":"https://api.github.com/users/solonaarmstrong/repos","events_url":"https://api.github.com/users/solonaarmstrong/events{/privacy}","received_events_url":"https://api.github.com/users/solonaarmstrong/received_events","type":"User","site_admin":false},"body":"I changed them to the tab keypress.","created_at":"2018-11-06T22:07:25Z","updated_at":"2018-11-06T22:07:25Z","html_url":"https://github.com/Shopify/polaris-react/pull/480#discussion_r231311697","pull_request_url":"https://api.github.com/repos/Shopify/polaris-react/pulls/480","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Shopify/polaris-react/pulls/comments/231311697"},"html":{"href":"https://github.com/Shopify/polaris-react/pull/480#discussion_r231311697"},"pull_request":{"href":"https://api.github.com/repos/Shopify/polaris-react/pulls/480"}},"in_reply_to_id":231285571},"pull_request":{"url":"https://api.github.com/repos/Shopify/polaris-react/pulls/480","id":226161940,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MTYxOTQw","html_url":"https://github.com/Shopify/polaris-react/pull/480","diff_url":"https://github.com/Shopify/polaris-react/pull/480.diff","patch_url":"https://github.com/Shopify/polaris-react/pull/480.patch","issue_url":"https://api.github.com/repos/Shopify/polaris-react/issues/480","number":480,"state":"open","locked":false,"title":"[Combobox] Add tests for arrow keys and clean up test suite","user":{"login":"solonaarmstrong","id":6239480,"node_id":"MDQ6VXNlcjYyMzk0ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/6239480?v=4","gravatar_id":"","url":"https://api.github.com/users/solonaarmstrong","html_url":"https://github.com/solonaarmstrong","followers_url":"https://api.github.com/users/solonaarmstrong/followers","following_url":"https://api.github.com/users/solonaarmstrong/following{/other_user}","gists_url":"https://api.github.com/users/solonaarmstrong/gists{/gist_id}","starred_url":"https://api.github.com/users/solonaarmstrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solonaarmstrong/subscriptions","organizations_url":"https://api.github.com/users/solonaarmstrong/orgs","repos_url":"https://api.github.com/users/solonaarmstrong/repos","events_url":"https://api.github.com/users/solonaarmstrong/events{/privacy}","received_events_url":"https://api.github.com/users/solonaarmstrong/received_events","type":"User","site_admin":false},"body":"Codecov for [this PR](https://github.com/Shopify/polaris-react/pull/477) is failing, so I added some more tests.\r\n","created_at":"2018-10-26T16:50:12Z","updated_at":"2018-11-06T22:07:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27c5f9b594884a70c8e4372506b04658afac653d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"AndrewMusgrave","id":24610840,"node_id":"MDQ6VXNlcjI0NjEwODQw","avatar_url":"https://avatars0.githubusercontent.com/u/24610840?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrewMusgrave","html_url":"https://github.com/AndrewMusgrave","followers_url":"https://api.github.com/users/AndrewMusgrave/followers","following_url":"https://api.github.com/users/AndrewMusgrave/following{/other_user}","gists_url":"https://api.github.com/users/AndrewMusgrave/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewMusgrave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewMusgrave/subscriptions","organizations_url":"https://api.github.com/users/AndrewMusgrave/orgs","repos_url":"https://api.github.com/users/AndrewMusgrave/repos","events_url":"https://api.github.com/users/AndrewMusgrave/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewMusgrave/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1038354175,"node_id":"MDU6TGFiZWwxMDM4MzU0MTc1","url":"https://api.github.com/repos/Shopify/polaris-react/labels/Skip%20Changelog","name":"Skip Changelog","color":"dddddd","default":false},{"id":1038352383,"node_id":"MDU6TGFiZWwxMDM4MzUyMzgz","url":"https://api.github.com/repos/Shopify/polaris-react/labels/Testing","name":"Testing","color":"43c42f","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/polaris-react/pulls/480/commits","review_comments_url":"https://api.github.com/repos/Shopify/polaris-react/pulls/480/comments","review_comment_url":"https://api.github.com/repos/Shopify/polaris-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/polaris-react/issues/480/comments","statuses_url":"https://api.github.com/repos/Shopify/polaris-react/statuses/c0be5a316fc4f818554d3885650f0f0e6e8409ec","head":{"label":"Shopify:combobox-arrow-tests","ref":"combobox-arrow-tests","sha":"c0be5a316fc4f818554d3885650f0f0e6e8409ec","user":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":88897663,"node_id":"MDEwOlJlcG9zaXRvcnk4ODg5NzY2Mw==","name":"polaris-react","full_name":"Shopify/polaris-react","private":false,"owner":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Shopify/polaris-react","description":"Shopify’s product component library","fork":false,"url":"https://api.github.com/repos/Shopify/polaris-react","forks_url":"https://api.github.com/repos/Shopify/polaris-react/forks","keys_url":"https://api.github.com/repos/Shopify/polaris-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/polaris-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/polaris-react/teams","hooks_url":"https://api.github.com/repos/Shopify/polaris-react/hooks","issue_events_url":"https://api.github.com/repos/Shopify/polaris-react/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/polaris-react/events","assignees_url":"https://api.github.com/repos/Shopify/polaris-react/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/polaris-react/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/polaris-react/tags","blobs_url":"https://api.github.com/repos/Shopify/polaris-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/polaris-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/polaris-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/polaris-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/polaris-react/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/polaris-react/languages","stargazers_url":"https://api.github.com/repos/Shopify/polaris-react/stargazers","contributors_url":"https://api.github.com/repos/Shopify/polaris-react/contributors","subscribers_url":"https://api.github.com/repos/Shopify/polaris-react/subscribers","subscription_url":"https://api.github.com/repos/Shopify/polaris-react/subscription","commits_url":"https://api.github.com/repos/Shopify/polaris-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/polaris-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/polaris-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/polaris-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/polaris-react/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/polaris-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/polaris-react/merges","archive_url":"https://api.github.com/repos/Shopify/polaris-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/polaris-react/downloads","issues_url":"https://api.github.com/repos/Shopify/polaris-react/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/polaris-react/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/polaris-react/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/polaris-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/polaris-react/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/polaris-react/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/polaris-react/deployments","created_at":"2017-04-20T18:26:34Z","updated_at":"2018-11-06T21:57:15Z","pushed_at":"2018-11-06T22:02:56Z","git_url":"git://github.com/Shopify/polaris-react.git","ssh_url":"git@github.com:Shopify/polaris-react.git","clone_url":"https://github.com/Shopify/polaris-react.git","svn_url":"https://github.com/Shopify/polaris-react","homepage":"https://polaris.shopify.com","size":9016,"stargazers_count":1930,"watchers_count":1930,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":289,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":289,"open_issues":83,"watchers":1930,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"1f0eefccda0a1bd2f4b1a22ad5b27834f030fcee","user":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":88897663,"node_id":"MDEwOlJlcG9zaXRvcnk4ODg5NzY2Mw==","name":"polaris-react","full_name":"Shopify/polaris-react","private":false,"owner":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Shopify/polaris-react","description":"Shopify’s product component library","fork":false,"url":"https://api.github.com/repos/Shopify/polaris-react","forks_url":"https://api.github.com/repos/Shopify/polaris-react/forks","keys_url":"https://api.github.com/repos/Shopify/polaris-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/polaris-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/polaris-react/teams","hooks_url":"https://api.github.com/repos/Shopify/polaris-react/hooks","issue_events_url":"https://api.github.com/repos/Shopify/polaris-react/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/polaris-react/events","assignees_url":"https://api.github.com/repos/Shopify/polaris-react/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/polaris-react/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/polaris-react/tags","blobs_url":"https://api.github.com/repos/Shopify/polaris-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/polaris-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/polaris-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/polaris-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/polaris-react/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/polaris-react/languages","stargazers_url":"https://api.github.com/repos/Shopify/polaris-react/stargazers","contributors_url":"https://api.github.com/repos/Shopify/polaris-react/contributors","subscribers_url":"https://api.github.com/repos/Shopify/polaris-react/subscribers","subscription_url":"https://api.github.com/repos/Shopify/polaris-react/subscription","commits_url":"https://api.github.com/repos/Shopify/polaris-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/polaris-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/polaris-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/polaris-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/polaris-react/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/polaris-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/polaris-react/merges","archive_url":"https://api.github.com/repos/Shopify/polaris-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/polaris-react/downloads","issues_url":"https://api.github.com/repos/Shopify/polaris-react/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/polaris-react/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/polaris-react/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/polaris-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/polaris-react/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/polaris-react/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/polaris-react/deployments","created_at":"2017-04-20T18:26:34Z","updated_at":"2018-11-06T21:57:15Z","pushed_at":"2018-11-06T22:02:56Z","git_url":"git://github.com/Shopify/polaris-react.git","ssh_url":"git@github.com:Shopify/polaris-react.git","clone_url":"https://github.com/Shopify/polaris-react.git","svn_url":"https://github.com/Shopify/polaris-react","homepage":"https://polaris.shopify.com","size":9016,"stargazers_count":1930,"watchers_count":1930,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":289,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":289,"open_issues":83,"watchers":1930,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/polaris-react/pulls/480"},"html":{"href":"https://github.com/Shopify/polaris-react/pull/480"},"issue":{"href":"https://api.github.com/repos/Shopify/polaris-react/issues/480"},"comments":{"href":"https://api.github.com/repos/Shopify/polaris-react/issues/480/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/polaris-react/pulls/480/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/polaris-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/polaris-react/pulls/480/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/polaris-react/statuses/c0be5a316fc4f818554d3885650f0f0e6e8409ec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"solonaarmstrong"}}