{"action":"created","comment":{"url":"https://api.github.com/repos/3scale/porta/pulls/comments/243553715","pull_request_review_id":187355667,"id":243553715,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzU1MzcxNQ==","diff_hunk":"@@ -10,7 +10,14 @@ import { render } from 'react-dom'\n \n import 'Dashboard/styles/dashboard.scss'\n \n-const ApiFilter = ({ apis, displayApis }) => {\n+import type { Api } from 'Types'","path":"app/javascript/src/Dashboard/components/ApiFilter.jsx","position":13,"original_position":13,"commit_id":"6cd461d91b174140c75fcee5e2733e967891d35e","original_commit_id":"6cd461d91b174140c75fcee5e2733e967891d35e","user":{"login":"damianpm","id":13486237,"node_id":"MDQ6VXNlcjEzNDg2MjM3","avatar_url":"https://avatars0.githubusercontent.com/u/13486237?v=4","gravatar_id":"","url":"https://api.github.com/users/damianpm","html_url":"https://github.com/damianpm","followers_url":"https://api.github.com/users/damianpm/followers","following_url":"https://api.github.com/users/damianpm/following{/other_user}","gists_url":"https://api.github.com/users/damianpm/gists{/gist_id}","starred_url":"https://api.github.com/users/damianpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damianpm/subscriptions","organizations_url":"https://api.github.com/users/damianpm/orgs","repos_url":"https://api.github.com/users/damianpm/repos","events_url":"https://api.github.com/users/damianpm/events{/privacy}","received_events_url":"https://api.github.com/users/damianpm/received_events","type":"User","site_admin":false},"body":"Yeah, DRY, I just say we should agree on a way to handle this. It could be having a general `Types` directory, or having corresponding types inside each component directory","created_at":"2018-12-21T11:08:07Z","updated_at":"2018-12-21T11:08:07Z","html_url":"https://github.com/3scale/porta/pull/460#discussion_r243553715","pull_request_url":"https://api.github.com/repos/3scale/porta/pulls/460","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/3scale/porta/pulls/comments/243553715"},"html":{"href":"https://github.com/3scale/porta/pull/460#discussion_r243553715"},"pull_request":{"href":"https://api.github.com/repos/3scale/porta/pulls/460"}},"in_reply_to_id":243543045},"pull_request":{"url":"https://api.github.com/repos/3scale/porta/pulls/460","id":240407914,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNDA3OTE0","html_url":"https://github.com/3scale/porta/pull/460","diff_url":"https://github.com/3scale/porta/pull/460.diff","patch_url":"https://github.com/3scale/porta/pull/460.patch","issue_url":"https://api.github.com/repos/3scale/porta/issues/460","number":460,"state":"open","locked":false,"title":"Flow support for ContextSelector and ApiFilter","user":{"login":"josemigallas","id":11672286,"node_id":"MDQ6VXNlcjExNjcyMjg2","avatar_url":"https://avatars0.githubusercontent.com/u/11672286?v=4","gravatar_id":"","url":"https://api.github.com/users/josemigallas","html_url":"https://github.com/josemigallas","followers_url":"https://api.github.com/users/josemigallas/followers","following_url":"https://api.github.com/users/josemigallas/following{/other_user}","gists_url":"https://api.github.com/users/josemigallas/gists{/gist_id}","starred_url":"https://api.github.com/users/josemigallas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josemigallas/subscriptions","organizations_url":"https://api.github.com/users/josemigallas/orgs","repos_url":"https://api.github.com/users/josemigallas/repos","events_url":"https://api.github.com/users/josemigallas/events{/privacy}","received_events_url":"https://api.github.com/users/josemigallas/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\n\r\nImplements Flow support in Dashboard (ApiFilter) and Navigation (ContextSelector) modules and set correctly some options in `.flowconfig` file.\r\n\r\n**Verification steps** \r\n\r\nRunning flow on the following files should throw no errors:\r\n```\r\nnpm-run flow check-contents app/javascript/src/Dashboard/components/ApiFilter.jsx < app/javascript/src/Dashboard/components/ApiFilter.jsx\r\nnpm-run flow check-contents app/javascript/src/Navigation/components/ContextSelector.jsx < app/javascript/src/Navigation/components/ContextSelector.jsx\r\nnpm-run flow check-contents app/javascript/src/Navigation/components/ActiveMenuTitle.jsx < app/javascript/src/Navigation/components/ActiveMenuTitle.jsx\r\n```\r\n","created_at":"2018-12-21T08:49:24Z","updated_at":"2018-12-21T11:08:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff832a08c55c2dc19457b4f57d5f538d25164f92","assignee":{"login":"josemigallas","id":11672286,"node_id":"MDQ6VXNlcjExNjcyMjg2","avatar_url":"https://avatars0.githubusercontent.com/u/11672286?v=4","gravatar_id":"","url":"https://api.github.com/users/josemigallas","html_url":"https://github.com/josemigallas","followers_url":"https://api.github.com/users/josemigallas/followers","following_url":"https://api.github.com/users/josemigallas/following{/other_user}","gists_url":"https://api.github.com/users/josemigallas/gists{/gist_id}","starred_url":"https://api.github.com/users/josemigallas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josemigallas/subscriptions","organizations_url":"https://api.github.com/users/josemigallas/orgs","repos_url":"https://api.github.com/users/josemigallas/repos","events_url":"https://api.github.com/users/josemigallas/events{/privacy}","received_events_url":"https://api.github.com/users/josemigallas/received_events","type":"User","site_admin":false},"assignees":[{"login":"josemigallas","id":11672286,"node_id":"MDQ6VXNlcjExNjcyMjg2","avatar_url":"https://avatars0.githubusercontent.com/u/11672286?v=4","gravatar_id":"","url":"https://api.github.com/users/josemigallas","html_url":"https://github.com/josemigallas","followers_url":"https://api.github.com/users/josemigallas/followers","following_url":"https://api.github.com/users/josemigallas/following{/other_user}","gists_url":"https://api.github.com/users/josemigallas/gists{/gist_id}","starred_url":"https://api.github.com/users/josemigallas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josemigallas/subscriptions","organizations_url":"https://api.github.com/users/josemigallas/orgs","repos_url":"https://api.github.com/users/josemigallas/repos","events_url":"https://api.github.com/users/josemigallas/events{/privacy}","received_events_url":"https://api.github.com/users/josemigallas/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"didierofrivia","id":4183971,"node_id":"MDQ6VXNlcjQxODM5NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/4183971?v=4","gravatar_id":"","url":"https://api.github.com/users/didierofrivia","html_url":"https://github.com/didierofrivia","followers_url":"https://api.github.com/users/didierofrivia/followers","following_url":"https://api.github.com/users/didierofrivia/following{/other_user}","gists_url":"https://api.github.com/users/didierofrivia/gists{/gist_id}","starred_url":"https://api.github.com/users/didierofrivia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/didierofrivia/subscriptions","organizations_url":"https://api.github.com/users/didierofrivia/orgs","repos_url":"https://api.github.com/users/didierofrivia/repos","events_url":"https://api.github.com/users/didierofrivia/events{/privacy}","received_events_url":"https://api.github.com/users/didierofrivia/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1061163922,"node_id":"MDU6TGFiZWwxMDYxMTYzOTIy","url":"https://api.github.com/repos/3scale/porta/labels/jenkins","name":"jenkins","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/3scale/porta/pulls/460/commits","review_comments_url":"https://api.github.com/repos/3scale/porta/pulls/460/comments","review_comment_url":"https://api.github.com/repos/3scale/porta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/3scale/porta/issues/460/comments","statuses_url":"https://api.github.com/repos/3scale/porta/statuses/6cd461d91b174140c75fcee5e2733e967891d35e","head":{"label":"3scale:feature/apply_some_flow_types","ref":"feature/apply_some_flow_types","sha":"6cd461d91b174140c75fcee5e2733e967891d35e","user":{"login":"3scale","id":21415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNDE1","avatar_url":"https://avatars0.githubusercontent.com/u/21415?v=4","gravatar_id":"","url":"https://api.github.com/users/3scale","html_url":"https://github.com/3scale","followers_url":"https://api.github.com/users/3scale/followers","following_url":"https://api.github.com/users/3scale/following{/other_user}","gists_url":"https://api.github.com/users/3scale/gists{/gist_id}","starred_url":"https://api.github.com/users/3scale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3scale/subscriptions","organizations_url":"https://api.github.com/users/3scale/orgs","repos_url":"https://api.github.com/users/3scale/repos","events_url":"https://api.github.com/users/3scale/events{/privacy}","received_events_url":"https://api.github.com/users/3scale/received_events","type":"Organization","site_admin":false},"repo":{"id":149315920,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkzMTU5MjA=","name":"porta","full_name":"3scale/porta","private":false,"owner":{"login":"3scale","id":21415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNDE1","avatar_url":"https://avatars0.githubusercontent.com/u/21415?v=4","gravatar_id":"","url":"https://api.github.com/users/3scale","html_url":"https://github.com/3scale","followers_url":"https://api.github.com/users/3scale/followers","following_url":"https://api.github.com/users/3scale/following{/other_user}","gists_url":"https://api.github.com/users/3scale/gists{/gist_id}","starred_url":"https://api.github.com/users/3scale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3scale/subscriptions","organizations_url":"https://api.github.com/users/3scale/orgs","repos_url":"https://api.github.com/users/3scale/repos","events_url":"https://api.github.com/users/3scale/events{/privacy}","received_events_url":"https://api.github.com/users/3scale/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/3scale/porta","description":"Red Hat 3scale API Management, Porta","fork":false,"url":"https://api.github.com/repos/3scale/porta","forks_url":"https://api.github.com/repos/3scale/porta/forks","keys_url":"https://api.github.com/repos/3scale/porta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3scale/porta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3scale/porta/teams","hooks_url":"https://api.github.com/repos/3scale/porta/hooks","issue_events_url":"https://api.github.com/repos/3scale/porta/issues/events{/number}","events_url":"https://api.github.com/repos/3scale/porta/events","assignees_url":"https://api.github.com/repos/3scale/porta/assignees{/user}","branches_url":"https://api.github.com/repos/3scale/porta/branches{/branch}","tags_url":"https://api.github.com/repos/3scale/porta/tags","blobs_url":"https://api.github.com/repos/3scale/porta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3scale/porta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3scale/porta/git/refs{/sha}","trees_url":"https://api.github.com/repos/3scale/porta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3scale/porta/statuses/{sha}","languages_url":"https://api.github.com/repos/3scale/porta/languages","stargazers_url":"https://api.github.com/repos/3scale/porta/stargazers","contributors_url":"https://api.github.com/repos/3scale/porta/contributors","subscribers_url":"https://api.github.com/repos/3scale/porta/subscribers","subscription_url":"https://api.github.com/repos/3scale/porta/subscription","commits_url":"https://api.github.com/repos/3scale/porta/commits{/sha}","git_commits_url":"https://api.github.com/repos/3scale/porta/git/commits{/sha}","comments_url":"https://api.github.com/repos/3scale/porta/comments{/number}","issue_comment_url":"https://api.github.com/repos/3scale/porta/issues/comments{/number}","contents_url":"https://api.github.com/repos/3scale/porta/contents/{+path}","compare_url":"https://api.github.com/repos/3scale/porta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3scale/porta/merges","archive_url":"https://api.github.com/repos/3scale/porta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3scale/porta/downloads","issues_url":"https://api.github.com/repos/3scale/porta/issues{/number}","pulls_url":"https://api.github.com/repos/3scale/porta/pulls{/number}","milestones_url":"https://api.github.com/repos/3scale/porta/milestones{/number}","notifications_url":"https://api.github.com/repos/3scale/porta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3scale/porta/labels{/name}","releases_url":"https://api.github.com/repos/3scale/porta/releases{/id}","deployments_url":"https://api.github.com/repos/3scale/porta/deployments","created_at":"2018-09-18T16:03:13Z","updated_at":"2018-12-20T07:19:49Z","pushed_at":"2018-12-21T09:51:12Z","git_url":"git://github.com/3scale/porta.git","ssh_url":"git@github.com:3scale/porta.git","clone_url":"https://github.com/3scale/porta.git","svn_url":"https://github.com/3scale/porta","homepage":"","size":34096,"stargazers_count":12,"watchers_count":12,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":63,"watchers":12,"default_branch":"master"}},"base":{"label":"3scale:master","ref":"master","sha":"b11f9a8511ad6b51cb94db2070a0eaf3ac0fe402","user":{"login":"3scale","id":21415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNDE1","avatar_url":"https://avatars0.githubusercontent.com/u/21415?v=4","gravatar_id":"","url":"https://api.github.com/users/3scale","html_url":"https://github.com/3scale","followers_url":"https://api.github.com/users/3scale/followers","following_url":"https://api.github.com/users/3scale/following{/other_user}","gists_url":"https://api.github.com/users/3scale/gists{/gist_id}","starred_url":"https://api.github.com/users/3scale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3scale/subscriptions","organizations_url":"https://api.github.com/users/3scale/orgs","repos_url":"https://api.github.com/users/3scale/repos","events_url":"https://api.github.com/users/3scale/events{/privacy}","received_events_url":"https://api.github.com/users/3scale/received_events","type":"Organization","site_admin":false},"repo":{"id":149315920,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkzMTU5MjA=","name":"porta","full_name":"3scale/porta","private":false,"owner":{"login":"3scale","id":21415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNDE1","avatar_url":"https://avatars0.githubusercontent.com/u/21415?v=4","gravatar_id":"","url":"https://api.github.com/users/3scale","html_url":"https://github.com/3scale","followers_url":"https://api.github.com/users/3scale/followers","following_url":"https://api.github.com/users/3scale/following{/other_user}","gists_url":"https://api.github.com/users/3scale/gists{/gist_id}","starred_url":"https://api.github.com/users/3scale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3scale/subscriptions","organizations_url":"https://api.github.com/users/3scale/orgs","repos_url":"https://api.github.com/users/3scale/repos","events_url":"https://api.github.com/users/3scale/events{/privacy}","received_events_url":"https://api.github.com/users/3scale/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/3scale/porta","description":"Red Hat 3scale API Management, Porta","fork":false,"url":"https://api.github.com/repos/3scale/porta","forks_url":"https://api.github.com/repos/3scale/porta/forks","keys_url":"https://api.github.com/repos/3scale/porta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3scale/porta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3scale/porta/teams","hooks_url":"https://api.github.com/repos/3scale/porta/hooks","issue_events_url":"https://api.github.com/repos/3scale/porta/issues/events{/number}","events_url":"https://api.github.com/repos/3scale/porta/events","assignees_url":"https://api.github.com/repos/3scale/porta/assignees{/user}","branches_url":"https://api.github.com/repos/3scale/porta/branches{/branch}","tags_url":"https://api.github.com/repos/3scale/porta/tags","blobs_url":"https://api.github.com/repos/3scale/porta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3scale/porta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3scale/porta/git/refs{/sha}","trees_url":"https://api.github.com/repos/3scale/porta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3scale/porta/statuses/{sha}","languages_url":"https://api.github.com/repos/3scale/porta/languages","stargazers_url":"https://api.github.com/repos/3scale/porta/stargazers","contributors_url":"https://api.github.com/repos/3scale/porta/contributors","subscribers_url":"https://api.github.com/repos/3scale/porta/subscribers","subscription_url":"https://api.github.com/repos/3scale/porta/subscription","commits_url":"https://api.github.com/repos/3scale/porta/commits{/sha}","git_commits_url":"https://api.github.com/repos/3scale/porta/git/commits{/sha}","comments_url":"https://api.github.com/repos/3scale/porta/comments{/number}","issue_comment_url":"https://api.github.com/repos/3scale/porta/issues/comments{/number}","contents_url":"https://api.github.com/repos/3scale/porta/contents/{+path}","compare_url":"https://api.github.com/repos/3scale/porta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3scale/porta/merges","archive_url":"https://api.github.com/repos/3scale/porta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3scale/porta/downloads","issues_url":"https://api.github.com/repos/3scale/porta/issues{/number}","pulls_url":"https://api.github.com/repos/3scale/porta/pulls{/number}","milestones_url":"https://api.github.com/repos/3scale/porta/milestones{/number}","notifications_url":"https://api.github.com/repos/3scale/porta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3scale/porta/labels{/name}","releases_url":"https://api.github.com/repos/3scale/porta/releases{/id}","deployments_url":"https://api.github.com/repos/3scale/porta/deployments","created_at":"2018-09-18T16:03:13Z","updated_at":"2018-12-20T07:19:49Z","pushed_at":"2018-12-21T09:51:12Z","git_url":"git://github.com/3scale/porta.git","ssh_url":"git@github.com:3scale/porta.git","clone_url":"https://github.com/3scale/porta.git","svn_url":"https://github.com/3scale/porta","homepage":"","size":34096,"stargazers_count":12,"watchers_count":12,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":63,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/3scale/porta/pulls/460"},"html":{"href":"https://github.com/3scale/porta/pull/460"},"issue":{"href":"https://api.github.com/repos/3scale/porta/issues/460"},"comments":{"href":"https://api.github.com/repos/3scale/porta/issues/460/comments"},"review_comments":{"href":"https://api.github.com/repos/3scale/porta/pulls/460/comments"},"review_comment":{"href":"https://api.github.com/repos/3scale/porta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/3scale/porta/pulls/460/commits"},"statuses":{"href":"https://api.github.com/repos/3scale/porta/statuses/6cd461d91b174140c75fcee5e2733e967891d35e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"damianpm"}}