{"action":"created","issue":{"url":"https://api.github.com/repos/damieng/jekyll-blog-comments-azure/issues/7","repository_url":"https://api.github.com/repos/damieng/jekyll-blog-comments-azure","labels_url":"https://api.github.com/repos/damieng/jekyll-blog-comments-azure/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/damieng/jekyll-blog-comments-azure/issues/7/comments","events_url":"https://api.github.com/repos/damieng/jekyll-blog-comments-azure/issues/7/events","html_url":"https://github.com/damieng/jekyll-blog-comments-azure/pull/7","id":327964243,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNjIzNTc4","number":7,"title":"Encrypting Email Address in commit message.","user":{"login":"jwendl","id":1068431,"node_id":"MDQ6VXNlcjEwNjg0MzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1068431?v=4","gravatar_id":"","url":"https://api.github.com/users/jwendl","html_url":"https://github.com/jwendl","followers_url":"https://api.github.com/users/jwendl/followers","following_url":"https://api.github.com/users/jwendl/following{/other_user}","gists_url":"https://api.github.com/users/jwendl/gists{/gist_id}","starred_url":"https://api.github.com/users/jwendl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwendl/subscriptions","organizations_url":"https://api.github.com/users/jwendl/orgs","repos_url":"https://api.github.com/users/jwendl/repos","events_url":"https://api.github.com/users/jwendl/events{/privacy}","received_events_url":"https://api.github.com/users/jwendl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-05-31T01:49:24Z","updated_at":"2018-06-03T04:31:38Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/damieng/jekyll-blog-comments-azure/pulls/7","html_url":"https://github.com/damieng/jekyll-blog-comments-azure/pull/7","diff_url":"https://github.com/damieng/jekyll-blog-comments-azure/pull/7.diff","patch_url":"https://github.com/damieng/jekyll-blog-comments-azure/pull/7.patch"},"body":"This is just a PR to consider encrypting the email address in the yaml that gets committed to the repository. \r\n\r\nWe could one way hash it as well like we do with gravatar, but if you are a blog owner - it might be nice to know what email someone provided in the event you'd wish to contact them. So using RSA public key private key can help with that as you can hold on to the private key and decrypt the value as needed. \r\n\r\nMainly an issue because on the comment form we say we don't ever show it, yet GitHub does :smile:\r\nBefore: https://github.com/jwendl/jwendl.github.io/pull/28/files\r\n\r\nAfter: https://github.com/jwendl/jwendl.github.io/pull/40/files"},"comment":{"url":"https://api.github.com/repos/damieng/jekyll-blog-comments-azure/issues/comments/394134345","html_url":"https://github.com/damieng/jekyll-blog-comments-azure/pull/7#issuecomment-394134345","issue_url":"https://api.github.com/repos/damieng/jekyll-blog-comments-azure/issues/7","id":394134345,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDEzNDM0NQ==","user":{"login":"Haacked","id":19977,"node_id":"MDQ6VXNlcjE5OTc3","avatar_url":"https://avatars1.githubusercontent.com/u/19977?v=4","gravatar_id":"","url":"https://api.github.com/users/Haacked","html_url":"https://github.com/Haacked","followers_url":"https://api.github.com/users/Haacked/followers","following_url":"https://api.github.com/users/Haacked/following{/other_user}","gists_url":"https://api.github.com/users/Haacked/gists{/gist_id}","starred_url":"https://api.github.com/users/Haacked/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Haacked/subscriptions","organizations_url":"https://api.github.com/users/Haacked/orgs","repos_url":"https://api.github.com/users/Haacked/repos","events_url":"https://api.github.com/users/Haacked/events{/privacy}","received_events_url":"https://api.github.com/users/Haacked/received_events","type":"User","site_admin":true},"created_at":"2018-06-03T04:31:38Z","updated_at":"2018-06-03T04:31:38Z","author_association":"COLLABORATOR","body":"> Can't we just store their GitHub name and disclose what it's doing on the submit form?\r\n\r\nThe problem is that creates a lot of work for the clients.\r\n\r\nFor example, if you make a request for `https://github.com/haacked.png?s=64`, GitHub ignores the `?s=64` parameter and redirects to the full size avatar: `https://avatars1.githubusercontent.com/u/19977?v=4`\r\n\r\nSo in order to support GitHub, a client would have to make that request, follow the redirect, then append the size querystring parameter. I could probably ping folks at GitHub to see if we can just fix that.\r\n\r\nThe other option is to just not support GitHub for now and support Twitter and Gravatar."}}
{"actor":{"display_login":"Haacked"}}