{"action":"created","comment":{"url":"https://api.github.com/repos/cilium/cilium/pulls/comments/244615073","pull_request_review_id":188532403,"id":244615073,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDYxNTA3Mw==","diff_hunk":"@@ -1271,101 +1271,86 @@ type ResourceLifeCycleAction string\n // imported before the timeout is\n // exceeded.\n func (kub *Kubectl) CiliumPolicyAction(namespace, filepath string, action ResourceLifeCycleAction, timeout int64) (string, error) {\n-\trevisions := map[string]int{}\n+\tnumNodes := kub.GetNumNodes()\n \n+\t// Test filter: https://jqplay.org/s/J3epZ41h-c\n+\tjqFilter := fmt.Sprintf(","path":"test/helpers/kubectl.go","position":47,"original_position":8,"commit_id":"4b81e9cf9ec6185f0d47e05987f3a49250550183","original_commit_id":"2df209f0e71372b7b3cd16a1536007c17223154f","user":{"login":"tgraf","id":1417913,"node_id":"MDQ6VXNlcjE0MTc5MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1417913?v=4","gravatar_id":"","url":"https://api.github.com/users/tgraf","html_url":"https://github.com/tgraf","followers_url":"https://api.github.com/users/tgraf/followers","following_url":"https://api.github.com/users/tgraf/following{/other_user}","gists_url":"https://api.github.com/users/tgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/tgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgraf/subscriptions","organizations_url":"https://api.github.com/users/tgraf/orgs","repos_url":"https://api.github.com/users/tgraf/repos","events_url":"https://api.github.com/users/tgraf/events{/privacy}","received_events_url":"https://api.github.com/users/tgraf/received_events","type":"User","site_admin":false},"body":"This filter only makes sense for the apply and create action, not the delete action.","created_at":"2018-12-31T20:09:55Z","updated_at":"2018-12-31T20:31:41Z","html_url":"https://github.com/cilium/cilium/pull/6513#discussion_r244615073","pull_request_url":"https://api.github.com/repos/cilium/cilium/pulls/6513","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments/244615073"},"html":{"href":"https://github.com/cilium/cilium/pull/6513#discussion_r244615073"},"pull_request":{"href":"https://api.github.com/repos/cilium/cilium/pulls/6513"}}},"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/6513","id":241571978,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNTcxOTc4","html_url":"https://github.com/cilium/cilium/pull/6513","diff_url":"https://github.com/cilium/cilium/pull/6513.diff","patch_url":"https://github.com/cilium/cilium/pull/6513.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/6513","number":6513,"state":"open","locked":false,"title":"Test: Refactor kubectl.CiliumPolicyAction.","user":{"login":"eloycoto","id":868013,"node_id":"MDQ6VXNlcjg2ODAxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/868013?v=4","gravatar_id":"","url":"https://api.github.com/users/eloycoto","html_url":"https://github.com/eloycoto","followers_url":"https://api.github.com/users/eloycoto/followers","following_url":"https://api.github.com/users/eloycoto/following{/other_user}","gists_url":"https://api.github.com/users/eloycoto/gists{/gist_id}","starred_url":"https://api.github.com/users/eloycoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eloycoto/subscriptions","organizations_url":"https://api.github.com/users/eloycoto/orgs","repos_url":"https://api.github.com/users/eloycoto/repos","events_url":"https://api.github.com/users/eloycoto/events{/privacy}","received_events_url":"https://api.github.com/users/eloycoto/received_events","type":"User","site_admin":false},"body":"Make a refactor on CiliumPolicyAction to make sure that the policy is\r\nenforced correctly and all other policies are in the rigth status.\r\n\r\nIn case of kubernetes network policies, it'll check that the policy is\r\nloaded in the cilium agent due no status.\r\n\r\nSigned-off-by: Eloy Coto <eloy.coto@gmail.com>\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cilium/cilium/6513)\n<!-- Reviewable:end -->\n","created_at":"2018-12-31T14:57:41Z","updated_at":"2018-12-31T20:31:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3e5fd6b329408a744c0af0693e762616557c74e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"ci","id":2519781,"node_id":"MDQ6VGVhbTI1MTk3ODE=","slug":"ci","description":"CI integration","privacy":"closed","url":"https://api.github.com/teams/2519781","members_url":"https://api.github.com/teams/2519781/members{/member}","repositories_url":"https://api.github.com/teams/2519781/repos","permission":"pull"}],"labels":[{"id":709779088,"node_id":"MDU6TGFiZWw3MDk3NzkwODg=","url":"https://api.github.com/repos/cilium/cilium/labels/area/CI","name":"area/CI","color":"bfd4f2","default":false},{"id":403149902,"node_id":"MDU6TGFiZWw0MDMxNDk5MDI=","url":"https://api.github.com/repos/cilium/cilium/labels/pending-review","name":"pending-review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/6513/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/6513/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/6513/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/4b81e9cf9ec6185f0d47e05987f3a49250550183","head":{"label":"eloycoto:CiliumPolicyAction","ref":"CiliumPolicyAction","sha":"4b81e9cf9ec6185f0d47e05987f3a49250550183","user":{"login":"eloycoto","id":868013,"node_id":"MDQ6VXNlcjg2ODAxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/868013?v=4","gravatar_id":"","url":"https://api.github.com/users/eloycoto","html_url":"https://github.com/eloycoto","followers_url":"https://api.github.com/users/eloycoto/followers","following_url":"https://api.github.com/users/eloycoto/following{/other_user}","gists_url":"https://api.github.com/users/eloycoto/gists{/gist_id}","starred_url":"https://api.github.com/users/eloycoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eloycoto/subscriptions","organizations_url":"https://api.github.com/users/eloycoto/orgs","repos_url":"https://api.github.com/users/eloycoto/repos","events_url":"https://api.github.com/users/eloycoto/events{/privacy}","received_events_url":"https://api.github.com/users/eloycoto/received_events","type":"User","site_admin":false},"repo":{"id":93093102,"node_id":"MDEwOlJlcG9zaXRvcnk5MzA5MzEwMg==","name":"cilium","full_name":"eloycoto/cilium","private":false,"owner":{"login":"eloycoto","id":868013,"node_id":"MDQ6VXNlcjg2ODAxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/868013?v=4","gravatar_id":"","url":"https://api.github.com/users/eloycoto","html_url":"https://github.com/eloycoto","followers_url":"https://api.github.com/users/eloycoto/followers","following_url":"https://api.github.com/users/eloycoto/following{/other_user}","gists_url":"https://api.github.com/users/eloycoto/gists{/gist_id}","starred_url":"https://api.github.com/users/eloycoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eloycoto/subscriptions","organizations_url":"https://api.github.com/users/eloycoto/orgs","repos_url":"https://api.github.com/users/eloycoto/repos","events_url":"https://api.github.com/users/eloycoto/events{/privacy}","received_events_url":"https://api.github.com/users/eloycoto/received_events","type":"User","site_admin":false},"html_url":"https://github.com/eloycoto/cilium","description":"Linux Native, HTTP Aware Networking and Security for Containers","fork":true,"url":"https://api.github.com/repos/eloycoto/cilium","forks_url":"https://api.github.com/repos/eloycoto/cilium/forks","keys_url":"https://api.github.com/repos/eloycoto/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eloycoto/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eloycoto/cilium/teams","hooks_url":"https://api.github.com/repos/eloycoto/cilium/hooks","issue_events_url":"https://api.github.com/repos/eloycoto/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/eloycoto/cilium/events","assignees_url":"https://api.github.com/repos/eloycoto/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/eloycoto/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/eloycoto/cilium/tags","blobs_url":"https://api.github.com/repos/eloycoto/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eloycoto/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eloycoto/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/eloycoto/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eloycoto/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/eloycoto/cilium/languages","stargazers_url":"https://api.github.com/repos/eloycoto/cilium/stargazers","contributors_url":"https://api.github.com/repos/eloycoto/cilium/contributors","subscribers_url":"https://api.github.com/repos/eloycoto/cilium/subscribers","subscription_url":"https://api.github.com/repos/eloycoto/cilium/subscription","commits_url":"https://api.github.com/repos/eloycoto/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/eloycoto/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/eloycoto/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/eloycoto/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/eloycoto/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/eloycoto/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eloycoto/cilium/merges","archive_url":"https://api.github.com/repos/eloycoto/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eloycoto/cilium/downloads","issues_url":"https://api.github.com/repos/eloycoto/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/eloycoto/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/eloycoto/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/eloycoto/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eloycoto/cilium/labels{/name}","releases_url":"https://api.github.com/repos/eloycoto/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/eloycoto/cilium/deployments","created_at":"2017-06-01T19:40:10Z","updated_at":"2018-08-02T13:46:45Z","pushed_at":"2018-12-31T15:27:03Z","git_url":"git://github.com/eloycoto/cilium.git","ssh_url":"git@github.com:eloycoto/cilium.git","clone_url":"https://github.com/eloycoto/cilium.git","svn_url":"https://github.com/eloycoto/cilium","homepage":"","size":89443,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"1678d328b47de14130720537ec8be75db92d02ed","user":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"node_id":"MDEwOlJlcG9zaXRvcnk0ODEwOTIzOQ==","name":"cilium","full_name":"cilium/cilium","private":false,"owner":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cilium/cilium","description":"API Aware Networking and Security using BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-12-31T05:42:25Z","pushed_at":"2018-12-31T16:35:03Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":78112,"stargazers_count":3254,"watchers_count":3254,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":290,"mirror_url":null,"archived":false,"open_issues_count":578,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":290,"open_issues":578,"watchers":3254,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/6513"},"html":{"href":"https://github.com/cilium/cilium/pull/6513"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/6513"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/6513/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/6513/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/6513/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/4b81e9cf9ec6185f0d47e05987f3a49250550183"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tgraf"}}