{"action":"created","issue":{"url":"https://api.github.com/repos/liip/drifter/issues/211","repository_url":"https://api.github.com/repos/liip/drifter","labels_url":"https://api.github.com/repos/liip/drifter/issues/211/labels{/name}","comments_url":"https://api.github.com/repos/liip/drifter/issues/211/comments","events_url":"https://api.github.com/repos/liip/drifter/issues/211/events","html_url":"https://github.com/liip/drifter/pull/211","id":314675557,"number":211,"title":"Conditionally create package.json","user":{"login":"Aerzas","id":15220949,"avatar_url":"https://avatars2.githubusercontent.com/u/15220949?v=4","gravatar_id":"","url":"https://api.github.com/users/Aerzas","html_url":"https://github.com/Aerzas","followers_url":"https://api.github.com/users/Aerzas/followers","following_url":"https://api.github.com/users/Aerzas/following{/other_user}","gists_url":"https://api.github.com/users/Aerzas/gists{/gist_id}","starred_url":"https://api.github.com/users/Aerzas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aerzas/subscriptions","organizations_url":"https://api.github.com/users/Aerzas/orgs","repos_url":"https://api.github.com/users/Aerzas/repos","events_url":"https://api.github.com/users/Aerzas/events{/privacy}","received_events_url":"https://api.github.com/users/Aerzas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-16T14:28:15Z","updated_at":"2018-04-17T05:58:43Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/liip/drifter/pulls/211","html_url":"https://github.com/liip/drifter/pull/211","diff_url":"https://github.com/liip/drifter/pull/211.diff","patch_url":"https://github.com/liip/drifter/pull/211.patch"},"body":"Node.js tasks can be useful for projects that don't necesserally wish to expose a package.json file (like a theme inside a Drupal project), the package.json is installed based `nodejs_install_package_json`  but the package.json file is created unconditionally. The quick PR just propose to submit the `Create default package.json` task to `nodejs_install_package_json` also.\r\n\r\nThis PR is a : Improvement\r\n"},"comment":{"url":"https://api.github.com/repos/liip/drifter/issues/comments/381855021","html_url":"https://github.com/liip/drifter/pull/211#issuecomment-381855021","issue_url":"https://api.github.com/repos/liip/drifter/issues/211","id":381855021,"user":{"login":"LeBenLeBen","id":793344,"avatar_url":"https://avatars1.githubusercontent.com/u/793344?v=4","gravatar_id":"","url":"https://api.github.com/users/LeBenLeBen","html_url":"https://github.com/LeBenLeBen","followers_url":"https://api.github.com/users/LeBenLeBen/followers","following_url":"https://api.github.com/users/LeBenLeBen/following{/other_user}","gists_url":"https://api.github.com/users/LeBenLeBen/gists{/gist_id}","starred_url":"https://api.github.com/users/LeBenLeBen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeBenLeBen/subscriptions","organizations_url":"https://api.github.com/users/LeBenLeBen/orgs","repos_url":"https://api.github.com/users/LeBenLeBen/repos","events_url":"https://api.github.com/users/LeBenLeBen/events{/privacy}","received_events_url":"https://api.github.com/users/LeBenLeBen/received_events","type":"User","site_admin":false},"created_at":"2018-04-17T05:58:43Z","updated_at":"2018-04-17T05:58:43Z","author_association":"CONTRIBUTOR","body":"I think that would make everything more complicate for no added value. I’ve never seen a project using Node without a package.json until now and therefor think this is more the exception than the common behavior.\r\n\r\nSeparating it in a dedicated role means it would be disabled by default which goes against that. Developers would have to enable two roles instead of one in most cases. Also I can’t figure out a role name that would be self-describing enough for people to understand what it actually do and how it’s tied to the Node role.\r\n\r\nYou seems to be assuming a lot here; I would be happy to change my mind with examples of actual problems caused by the existing setup."}}
{"actor":{"display_login":"LeBenLeBen"}}