{"action":"closed","number":26589,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/26589","id":185762603,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg1NzYyNjAz","html_url":"https://github.com/dotnet/roslyn/pull/26589","diff_url":"https://github.com/dotnet/roslyn/pull/26589.diff","patch_url":"https://github.com/dotnet/roslyn/pull/26589.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/26589","number":26589,"state":"closed","locked":false,"title":" Strip common prefixes before applying naming suggestions","user":{"login":"sharwell","id":1408396,"node_id":"MDQ6VXNlcjE0MDgzOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1408396?v=4","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"body":"Fixes #26566\r\n\r\n<details><summary>Ask Mode template not completed</summary>\r\n\r\n<!-- This template is not always required. If you aren't sure about whether it's needed or want help filling out the sections,\r\nsubmit the pull request and then ask us for help. :) -->\r\n\r\n### Customer scenario\r\n\r\nWhat does the customer do to get into this situation, and why do we think this\r\nis common enough to address for this release.  (Granted, sometimes this will be\r\nobvious \"Open project, VS crashes\" but in general, I need to understand how\r\ncommon a scenario is)\r\n\r\n### Bugs this fixes\r\n\r\n(either VSO or GitHub links)\r\n\r\n### Workarounds, if any\r\n\r\nAlso, why we think they are insufficient for RC vs. RC2, RC3, or RTW\r\n\r\n### Risk\r\n\r\nThis is generally a measure our how central the affected code is to adjacent\r\nscenarios and thus how likely your fix is to destabilize a broader area of code\r\n\r\n### Performance impact\r\n\r\n(with a brief justification for that assessment (e.g. \"Low perf impact because no extra allocations/no complexity changes\" vs. \"Low\")\r\n\r\n### Is this a regression from a previous update?\r\n\r\n### Root cause analysis\r\n\r\nHow did we miss it?  What tests are we adding to guard against it in the future?\r\n\r\n### How was the bug found?\r\n\r\n(E.g. customer reported it vs. ad hoc testing)\r\n\r\n### Test documentation updated?\r\n\r\nIf this is a new non-compiler feature or a significant improvement to an existing feature, update https://github.com/dotnet/roslyn/wiki/Manual-Testing once you know which release it is targeting.\r\n\r\n</details>\r\n","created_at":"2018-05-03T15:56:31Z","updated_at":"2018-06-07T20:43:13Z","closed_at":"2018-06-07T20:43:12Z","merged_at":"2018-06-07T20:43:12Z","merge_commit_sha":"c4bc72496dbf1e2bf76faf4440dd709f34f199c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":188683308,"node_id":"MDU6TGFiZWwxODg2ODMzMDg=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Approved%20to%20merge","name":"Approved to merge","color":"fbca04","default":false},{"id":166377917,"node_id":"MDU6TGFiZWwxNjYzNzc5MTc=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-IDE","name":"Area-IDE","color":"5319e7","default":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/33","html_url":"https://github.com/dotnet/roslyn/milestone/33","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/33/labels","id":3020805,"node_id":"MDk6TWlsZXN0b25lMzAyMDgwNQ==","number":33,"title":"15.8","description":null,"creator":{"login":"sharwell","id":1408396,"node_id":"MDQ6VXNlcjE0MDgzOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1408396?v=4","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"open_issues":257,"closed_issues":319,"state":"open","created_at":"2018-01-08T19:35:57Z","updated_at":"2018-06-07T20:43:13Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/26589/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/26589/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/26589/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/add68b01a078ff826b0a164f51db07ff7649643f","head":{"label":"sharwell:strip-prefixes","ref":"strip-prefixes","sha":"add68b01a078ff826b0a164f51db07ff7649643f","user":{"login":"sharwell","id":1408396,"node_id":"MDQ6VXNlcjE0MDgzOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1408396?v=4","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"repo":{"id":29280707,"node_id":"MDEwOlJlcG9zaXRvcnkyOTI4MDcwNw==","name":"roslyn","full_name":"sharwell/roslyn","owner":{"login":"sharwell","id":1408396,"node_id":"MDQ6VXNlcjE0MDgzOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1408396?v=4","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sharwell/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/sharwell/roslyn","forks_url":"https://api.github.com/repos/sharwell/roslyn/forks","keys_url":"https://api.github.com/repos/sharwell/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sharwell/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sharwell/roslyn/teams","hooks_url":"https://api.github.com/repos/sharwell/roslyn/hooks","issue_events_url":"https://api.github.com/repos/sharwell/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/sharwell/roslyn/events","assignees_url":"https://api.github.com/repos/sharwell/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/sharwell/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/sharwell/roslyn/tags","blobs_url":"https://api.github.com/repos/sharwell/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sharwell/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sharwell/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/sharwell/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sharwell/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/sharwell/roslyn/languages","stargazers_url":"https://api.github.com/repos/sharwell/roslyn/stargazers","contributors_url":"https://api.github.com/repos/sharwell/roslyn/contributors","subscribers_url":"https://api.github.com/repos/sharwell/roslyn/subscribers","subscription_url":"https://api.github.com/repos/sharwell/roslyn/subscription","commits_url":"https://api.github.com/repos/sharwell/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/sharwell/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/sharwell/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/sharwell/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/sharwell/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/sharwell/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sharwell/roslyn/merges","archive_url":"https://api.github.com/repos/sharwell/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sharwell/roslyn/downloads","issues_url":"https://api.github.com/repos/sharwell/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/sharwell/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/sharwell/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/sharwell/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sharwell/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/sharwell/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/sharwell/roslyn/deployments","created_at":"2015-01-15T04:27:54Z","updated_at":"2018-05-22T18:34:53Z","pushed_at":"2018-06-07T19:41:35Z","git_url":"git://github.com/sharwell/roslyn.git","ssh_url":"git@github.com:sharwell/roslyn.git","clone_url":"https://github.com/sharwell/roslyn.git","svn_url":"https://github.com/sharwell/roslyn","homepage":"","size":335206,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"745d9a76d04dc4a7b992dba8ff0e0ca120eb3ef5","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA3ODk5Nw==","name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-06-07T20:43:01Z","pushed_at":"2018-06-07T20:43:12Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":389908,"stargazers_count":9409,"watchers_count":9409,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2243,"mirror_url":null,"archived":false,"open_issues_count":4863,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2243,"open_issues":4863,"watchers":9409,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/26589"},"html":{"href":"https://github.com/dotnet/roslyn/pull/26589"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/26589"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/26589/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/26589/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/26589/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/add68b01a078ff826b0a164f51db07ff7649643f"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"sharwell","id":1408396,"node_id":"MDQ6VXNlcjE0MDgzOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1408396?v=4","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"comments":4,"review_comments":16,"maintainer_can_modify":false,"commits":6,"additions":171,"deletions":0,"changed_files":4}}
{"actor":{"display_login":"sharwell"}}