{"action":"created","issue":{"url":"https://api.github.com/repos/wildfly/wildfly-core/issues/3354","repository_url":"https://api.github.com/repos/wildfly/wildfly-core","labels_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/3354/labels{/name}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/3354/comments","events_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/3354/events","html_url":"https://github.com/wildfly/wildfly-core/pull/3354","id":331372674,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MTIwMzk0","number":3354,"title":"[WFCORE-3337] Add capabilities to the logging subsystem","user":{"login":"jamezp","id":420065,"node_id":"MDQ6VXNlcjQyMDA2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/420065?v=4","gravatar_id":"","url":"https://api.github.com/users/jamezp","html_url":"https://github.com/jamezp","followers_url":"https://api.github.com/users/jamezp/followers","following_url":"https://api.github.com/users/jamezp/following{/other_user}","gists_url":"https://api.github.com/users/jamezp/gists{/gist_id}","starred_url":"https://api.github.com/users/jamezp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamezp/subscriptions","organizations_url":"https://api.github.com/users/jamezp/orgs","repos_url":"https://api.github.com/users/jamezp/repos","events_url":"https://api.github.com/users/jamezp/events{/privacy}","received_events_url":"https://api.github.com/users/jamezp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-11T22:27:50Z","updated_at":"2018-06-18T07:49:45Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3354","html_url":"https://github.com/wildfly/wildfly-core/pull/3354","diff_url":"https://github.com/wildfly/wildfly-core/pull/3354.diff","patch_url":"https://github.com/wildfly/wildfly-core/pull/3354.patch"},"body":"https://issues.jboss.org/browse/WFCORE-3337 \r\n\r\nCapability PR: https://github.com/wildfly/wildfly-capabilities/pull/26\r\n\r\nThe first commit is a simple change to allow string module identifiers to be registered for deployments.\r\n\r\nThe next commit refactors the logging subsystem. The bulk of the change is moving things into better packages. There are also some function changes for using the better construction parameters for the resource definitions as well as using the correct abstract OSH's for add and remove operations. \r\n\r\nThe last commit adds the capabilities to the subsystem. This could be squashed with the previous commit, but it seemed easier to review this way."},"comment":{"url":"https://api.github.com/repos/wildfly/wildfly-core/issues/comments/397969970","html_url":"https://github.com/wildfly/wildfly-core/pull/3354#issuecomment-397969970","issue_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/3354","id":397969970,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Nzk2OTk3MA==","user":{"login":"bstansberry","id":299242,"node_id":"MDQ6VXNlcjI5OTI0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/299242?v=4","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"created_at":"2018-06-18T07:49:45Z","updated_at":"2018-06-18T07:49:45Z","author_association":"CONTRIBUTOR","body":"This is a big PR to review in detail but I've skimmed through it and it looks fine to me. And you know your way around the management code so you know what you're about with the big refactoring commit.\r\n\r\nI vote keeping these as separate commits.  Squashing them will really bury the key bits from the 3rd commit."}}
{"actor":{"display_login":"bstansberry"}}