{"action":"created","comment":{"url":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/comments/212093548","pull_request_review_id":148653700,"id":212093548,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjA5MzU0OA==","diff_hunk":"@@ -7,15 +7,25 @@ import {getAction} from 'data/ACTIONS'\n import Module from 'parser/core/Module'\n import {Group, Item} from './Timeline'\n \n-const MIN_GCD = 1500\n-const MAX_GCD = 2500\n+const MIN_GCD_IN_MILLIS = 1500\n+const MAX_GCD_IN_MILLIS = 2500\n+const BASE_GCD_IN_SECONDS = 2.5","path":"src/parser/core/modules/GlobalCooldown.js","position":8,"original_position":8,"commit_id":"1fb572f21c911b88c9cdc38393f5d93de70b9666","original_commit_id":"1fb572f21c911b88c9cdc38393f5d93de70b9666","user":{"login":"LaqiThish","id":30857065,"node_id":"MDQ6VXNlcjMwODU3MDY1","avatar_url":"https://avatars3.githubusercontent.com/u/30857065?v=4","gravatar_id":"","url":"https://api.github.com/users/LaqiThish","html_url":"https://github.com/LaqiThish","followers_url":"https://api.github.com/users/LaqiThish/followers","following_url":"https://api.github.com/users/LaqiThish/following{/other_user}","gists_url":"https://api.github.com/users/LaqiThish/gists{/gist_id}","starred_url":"https://api.github.com/users/LaqiThish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaqiThish/subscriptions","organizations_url":"https://api.github.com/users/LaqiThish/orgs","repos_url":"https://api.github.com/users/LaqiThish/repos","events_url":"https://api.github.com/users/LaqiThish/events{/privacy}","received_events_url":"https://api.github.com/users/LaqiThish/received_events","type":"User","site_admin":false},"body":"That's fair. Even if they're all in ms, I'd prefer the suffix, but it wasn't my file to begin with. I'll make these changes.","created_at":"2018-08-22T20:18:11Z","updated_at":"2018-08-22T20:18:11Z","html_url":"https://github.com/xivanalysis/xivanalysis/pull/161#discussion_r212093548","pull_request_url":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/161","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/comments/212093548"},"html":{"href":"https://github.com/xivanalysis/xivanalysis/pull/161#discussion_r212093548"},"pull_request":{"href":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/161"}},"in_reply_to_id":211955173},"pull_request":{"url":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/161","id":210066095,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMDY2MDk1","html_url":"https://github.com/xivanalysis/xivanalysis/pull/161","diff_url":"https://github.com/xivanalysis/xivanalysis/pull/161.diff","patch_url":"https://github.com/xivanalysis/xivanalysis/pull/161.patch","issue_url":"https://api.github.com/repos/xivanalysis/xivanalysis/issues/161","number":161,"state":"open","locked":false,"title":"GCD estimate/uptime fixes and BLM things","user":{"login":"LaqiThish","id":30857065,"node_id":"MDQ6VXNlcjMwODU3MDY1","avatar_url":"https://avatars3.githubusercontent.com/u/30857065?v=4","gravatar_id":"","url":"https://api.github.com/users/LaqiThish","html_url":"https://github.com/LaqiThish","followers_url":"https://api.github.com/users/LaqiThish/followers","following_url":"https://api.github.com/users/LaqiThish/following{/other_user}","gists_url":"https://api.github.com/users/LaqiThish/gists{/gist_id}","starred_url":"https://api.github.com/users/LaqiThish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaqiThish/subscriptions","organizations_url":"https://api.github.com/users/LaqiThish/orgs","repos_url":"https://api.github.com/users/LaqiThish/repos","events_url":"https://api.github.com/users/LaqiThish/events{/privacy}","received_events_url":"https://api.github.com/users/LaqiThish/received_events","type":"User","site_admin":false},"body":"Big fixes to GCD estimate and uptime calc. BLM Gauge updates to facilitate GCD fixes.\r\n\r\nACTIONS\r\n- Add default values to castTime and cooldown to onGcd actions when not specified\r\n\r\nGlobalCooldown\r\n- Fix pairing GCDs with duration, speedmod, instant flag, etc\r\n- Fix GCD estimate for non-2.5s casts\r\n- Fix uptime calc for BLM's 50% castTime-only speed modifier (very hacky, see note, will clean up in later PR)\r\n- Add caster tax to help with GCD and uptime estimates\r\n\r\nWeaving\r\n- Don't call isBadWeave for 0-length weaves\r\n\r\nBLM Stuff\r\n- Log fast-cast modifier in Speedmod\r\n- Add custom Gauge events\r\n- Update modules to use Gauge events\r\n- Fix some module bugs","created_at":"2018-08-22T09:08:00Z","updated_at":"2018-08-22T20:18:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"facc0befc4a922f06386efe53d2a5efd80d1901e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/161/commits","review_comments_url":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/161/comments","review_comment_url":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xivanalysis/xivanalysis/issues/161/comments","statuses_url":"https://api.github.com/repos/xivanalysis/xivanalysis/statuses/1fb572f21c911b88c9cdc38393f5d93de70b9666","head":{"label":"LaqiThish:master","ref":"master","sha":"1fb572f21c911b88c9cdc38393f5d93de70b9666","user":{"login":"LaqiThish","id":30857065,"node_id":"MDQ6VXNlcjMwODU3MDY1","avatar_url":"https://avatars3.githubusercontent.com/u/30857065?v=4","gravatar_id":"","url":"https://api.github.com/users/LaqiThish","html_url":"https://github.com/LaqiThish","followers_url":"https://api.github.com/users/LaqiThish/followers","following_url":"https://api.github.com/users/LaqiThish/following{/other_user}","gists_url":"https://api.github.com/users/LaqiThish/gists{/gist_id}","starred_url":"https://api.github.com/users/LaqiThish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaqiThish/subscriptions","organizations_url":"https://api.github.com/users/LaqiThish/orgs","repos_url":"https://api.github.com/users/LaqiThish/repos","events_url":"https://api.github.com/users/LaqiThish/events{/privacy}","received_events_url":"https://api.github.com/users/LaqiThish/received_events","type":"User","site_admin":false},"repo":{"id":138377850,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgzNzc4NTA=","name":"xivanalysis","full_name":"LaqiThish/xivanalysis","owner":{"login":"LaqiThish","id":30857065,"node_id":"MDQ6VXNlcjMwODU3MDY1","avatar_url":"https://avatars3.githubusercontent.com/u/30857065?v=4","gravatar_id":"","url":"https://api.github.com/users/LaqiThish","html_url":"https://github.com/LaqiThish","followers_url":"https://api.github.com/users/LaqiThish/followers","following_url":"https://api.github.com/users/LaqiThish/following{/other_user}","gists_url":"https://api.github.com/users/LaqiThish/gists{/gist_id}","starred_url":"https://api.github.com/users/LaqiThish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaqiThish/subscriptions","organizations_url":"https://api.github.com/users/LaqiThish/orgs","repos_url":"https://api.github.com/users/LaqiThish/repos","events_url":"https://api.github.com/users/LaqiThish/events{/privacy}","received_events_url":"https://api.github.com/users/LaqiThish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LaqiThish/xivanalysis","description":"Automated performance analysis and suggestion platform for Final Fantasy XIV: Stormblood.","fork":true,"url":"https://api.github.com/repos/LaqiThish/xivanalysis","forks_url":"https://api.github.com/repos/LaqiThish/xivanalysis/forks","keys_url":"https://api.github.com/repos/LaqiThish/xivanalysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LaqiThish/xivanalysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LaqiThish/xivanalysis/teams","hooks_url":"https://api.github.com/repos/LaqiThish/xivanalysis/hooks","issue_events_url":"https://api.github.com/repos/LaqiThish/xivanalysis/issues/events{/number}","events_url":"https://api.github.com/repos/LaqiThish/xivanalysis/events","assignees_url":"https://api.github.com/repos/LaqiThish/xivanalysis/assignees{/user}","branches_url":"https://api.github.com/repos/LaqiThish/xivanalysis/branches{/branch}","tags_url":"https://api.github.com/repos/LaqiThish/xivanalysis/tags","blobs_url":"https://api.github.com/repos/LaqiThish/xivanalysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LaqiThish/xivanalysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LaqiThish/xivanalysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/LaqiThish/xivanalysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LaqiThish/xivanalysis/statuses/{sha}","languages_url":"https://api.github.com/repos/LaqiThish/xivanalysis/languages","stargazers_url":"https://api.github.com/repos/LaqiThish/xivanalysis/stargazers","contributors_url":"https://api.github.com/repos/LaqiThish/xivanalysis/contributors","subscribers_url":"https://api.github.com/repos/LaqiThish/xivanalysis/subscribers","subscription_url":"https://api.github.com/repos/LaqiThish/xivanalysis/subscription","commits_url":"https://api.github.com/repos/LaqiThish/xivanalysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/LaqiThish/xivanalysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/LaqiThish/xivanalysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/LaqiThish/xivanalysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/LaqiThish/xivanalysis/contents/{+path}","compare_url":"https://api.github.com/repos/LaqiThish/xivanalysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LaqiThish/xivanalysis/merges","archive_url":"https://api.github.com/repos/LaqiThish/xivanalysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LaqiThish/xivanalysis/downloads","issues_url":"https://api.github.com/repos/LaqiThish/xivanalysis/issues{/number}","pulls_url":"https://api.github.com/repos/LaqiThish/xivanalysis/pulls{/number}","milestones_url":"https://api.github.com/repos/LaqiThish/xivanalysis/milestones{/number}","notifications_url":"https://api.github.com/repos/LaqiThish/xivanalysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LaqiThish/xivanalysis/labels{/name}","releases_url":"https://api.github.com/repos/LaqiThish/xivanalysis/releases{/id}","deployments_url":"https://api.github.com/repos/LaqiThish/xivanalysis/deployments","created_at":"2018-06-23T06:40:40Z","updated_at":"2018-08-22T08:56:18Z","pushed_at":"2018-08-22T08:56:17Z","git_url":"git://github.com/LaqiThish/xivanalysis.git","ssh_url":"git@github.com:LaqiThish/xivanalysis.git","clone_url":"https://github.com/LaqiThish/xivanalysis.git","svn_url":"https://github.com/LaqiThish/xivanalysis","homepage":"","size":3034,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xivanalysis:master","ref":"master","sha":"9d995952b2e61160adee1887519f91b5ecef5f17","user":{"login":"xivanalysis","id":39235942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjM1OTQy","avatar_url":"https://avatars0.githubusercontent.com/u/39235942?v=4","gravatar_id":"","url":"https://api.github.com/users/xivanalysis","html_url":"https://github.com/xivanalysis","followers_url":"https://api.github.com/users/xivanalysis/followers","following_url":"https://api.github.com/users/xivanalysis/following{/other_user}","gists_url":"https://api.github.com/users/xivanalysis/gists{/gist_id}","starred_url":"https://api.github.com/users/xivanalysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xivanalysis/subscriptions","organizations_url":"https://api.github.com/users/xivanalysis/orgs","repos_url":"https://api.github.com/users/xivanalysis/repos","events_url":"https://api.github.com/users/xivanalysis/events{/privacy}","received_events_url":"https://api.github.com/users/xivanalysis/received_events","type":"Organization","site_admin":false},"repo":{"id":132010919,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwMTA5MTk=","name":"xivanalysis","full_name":"xivanalysis/xivanalysis","owner":{"login":"xivanalysis","id":39235942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjM1OTQy","avatar_url":"https://avatars0.githubusercontent.com/u/39235942?v=4","gravatar_id":"","url":"https://api.github.com/users/xivanalysis","html_url":"https://github.com/xivanalysis","followers_url":"https://api.github.com/users/xivanalysis/followers","following_url":"https://api.github.com/users/xivanalysis/following{/other_user}","gists_url":"https://api.github.com/users/xivanalysis/gists{/gist_id}","starred_url":"https://api.github.com/users/xivanalysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xivanalysis/subscriptions","organizations_url":"https://api.github.com/users/xivanalysis/orgs","repos_url":"https://api.github.com/users/xivanalysis/repos","events_url":"https://api.github.com/users/xivanalysis/events{/privacy}","received_events_url":"https://api.github.com/users/xivanalysis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xivanalysis/xivanalysis","description":"Automated performance analysis and suggestion platform for Final Fantasy XIV: Stormblood.","fork":false,"url":"https://api.github.com/repos/xivanalysis/xivanalysis","forks_url":"https://api.github.com/repos/xivanalysis/xivanalysis/forks","keys_url":"https://api.github.com/repos/xivanalysis/xivanalysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xivanalysis/xivanalysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xivanalysis/xivanalysis/teams","hooks_url":"https://api.github.com/repos/xivanalysis/xivanalysis/hooks","issue_events_url":"https://api.github.com/repos/xivanalysis/xivanalysis/issues/events{/number}","events_url":"https://api.github.com/repos/xivanalysis/xivanalysis/events","assignees_url":"https://api.github.com/repos/xivanalysis/xivanalysis/assignees{/user}","branches_url":"https://api.github.com/repos/xivanalysis/xivanalysis/branches{/branch}","tags_url":"https://api.github.com/repos/xivanalysis/xivanalysis/tags","blobs_url":"https://api.github.com/repos/xivanalysis/xivanalysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xivanalysis/xivanalysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xivanalysis/xivanalysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/xivanalysis/xivanalysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xivanalysis/xivanalysis/statuses/{sha}","languages_url":"https://api.github.com/repos/xivanalysis/xivanalysis/languages","stargazers_url":"https://api.github.com/repos/xivanalysis/xivanalysis/stargazers","contributors_url":"https://api.github.com/repos/xivanalysis/xivanalysis/contributors","subscribers_url":"https://api.github.com/repos/xivanalysis/xivanalysis/subscribers","subscription_url":"https://api.github.com/repos/xivanalysis/xivanalysis/subscription","commits_url":"https://api.github.com/repos/xivanalysis/xivanalysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/xivanalysis/xivanalysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/xivanalysis/xivanalysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/xivanalysis/xivanalysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/xivanalysis/xivanalysis/contents/{+path}","compare_url":"https://api.github.com/repos/xivanalysis/xivanalysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xivanalysis/xivanalysis/merges","archive_url":"https://api.github.com/repos/xivanalysis/xivanalysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xivanalysis/xivanalysis/downloads","issues_url":"https://api.github.com/repos/xivanalysis/xivanalysis/issues{/number}","pulls_url":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls{/number}","milestones_url":"https://api.github.com/repos/xivanalysis/xivanalysis/milestones{/number}","notifications_url":"https://api.github.com/repos/xivanalysis/xivanalysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xivanalysis/xivanalysis/labels{/name}","releases_url":"https://api.github.com/repos/xivanalysis/xivanalysis/releases{/id}","deployments_url":"https://api.github.com/repos/xivanalysis/xivanalysis/deployments","created_at":"2018-05-03T14:56:32Z","updated_at":"2018-08-21T22:21:04Z","pushed_at":"2018-08-22T09:08:00Z","git_url":"git://github.com/xivanalysis/xivanalysis.git","ssh_url":"git@github.com:xivanalysis/xivanalysis.git","clone_url":"https://github.com/xivanalysis/xivanalysis.git","svn_url":"https://github.com/xivanalysis/xivanalysis","homepage":"https://xivanalysis.com","size":3048,"stargazers_count":33,"watchers_count":33,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":35,"open_issues":18,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/161"},"html":{"href":"https://github.com/xivanalysis/xivanalysis/pull/161"},"issue":{"href":"https://api.github.com/repos/xivanalysis/xivanalysis/issues/161"},"comments":{"href":"https://api.github.com/repos/xivanalysis/xivanalysis/issues/161/comments"},"review_comments":{"href":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/161/comments"},"review_comment":{"href":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/161/commits"},"statuses":{"href":"https://api.github.com/repos/xivanalysis/xivanalysis/statuses/1fb572f21c911b88c9cdc38393f5d93de70b9666"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"LaqiThish"}}