{"action":"created","comment":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/231858739","pull_request_review_id":172918351,"id":231858739,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTg1ODczOQ==","diff_hunk":"@@ -103,25 +109,57 @@ class TestKdump(MachineCase):\n         self.enableKdump()\n         self.rebootMachine()\n         self.browser.wait_visible(\"#app\")\n-\n-        # we should have the amount of memory reserved that we indicated\n-        self.browser.wait_in_text(\"#app\", \"256 MiB\")\n-        # service should start up properly and the button should be on\n-        self.browser.wait_in_text(\"#app\", \"Service is running\")\n-        self.browser.wait_in_text(onOffSelectorActive, \"On\")\n+        self.enableLocalSsh()\n+\n+        if self.machine.image not in [\"rhel-7-6-distropkg\"]:\n+            # generate a valid kdump config with ssh target\n+            settingsLink = \"a:contains('locally in /var/crash')\"\n+            self.browser.wait_present(settingsLink)\n+            self.browser.wait_visible(settingsLink)","path":"test/verify/check-kdump","position":58,"original_position":38,"commit_id":"81fd2ac47c21d3594db05bea807c6ec6ef9abf9e","original_commit_id":"e66909425b4afb1f52b7979abf124c8445d8124a","user":{"login":"martinpitt","id":200109,"node_id":"MDQ6VXNlcjIwMDEwOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/200109?v=4","gravatar_id":"","url":"https://api.github.com/users/martinpitt","html_url":"https://github.com/martinpitt","followers_url":"https://api.github.com/users/martinpitt/followers","following_url":"https://api.github.com/users/martinpitt/following{/other_user}","gists_url":"https://api.github.com/users/martinpitt/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpitt/subscriptions","organizations_url":"https://api.github.com/users/martinpitt/orgs","repos_url":"https://api.github.com/users/martinpitt/repos","events_url":"https://api.github.com/users/martinpitt/events{/privacy}","received_events_url":"https://api.github.com/users/martinpitt/received_events","type":"User","site_admin":false},"body":"As this is React, where we usually don't show/hide, but render or not, does this really need to be checked separately?","created_at":"2018-11-08T11:50:42Z","updated_at":"2018-11-08T11:58:31Z","html_url":"https://github.com/cockpit-project/cockpit/pull/10513#discussion_r231858739","pull_request_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/10513","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/231858739"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/10513#discussion_r231858739"},"pull_request":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/10513"}}},"pull_request":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/10513","id":228694193,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4Njk0MTkz","html_url":"https://github.com/cockpit-project/cockpit/pull/10513","diff_url":"https://github.com/cockpit-project/cockpit/pull/10513.diff","patch_url":"https://github.com/cockpit-project/cockpit/pull/10513.patch","issue_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/10513","number":10513,"state":"open","locked":false,"title":"kdump: Settings dialog dump target fixes","user":{"login":"Gundersanne","id":11140201,"node_id":"MDQ6VXNlcjExMTQwMjAx","avatar_url":"https://avatars0.githubusercontent.com/u/11140201?v=4","gravatar_id":"","url":"https://api.github.com/users/Gundersanne","html_url":"https://github.com/Gundersanne","followers_url":"https://api.github.com/users/Gundersanne/followers","following_url":"https://api.github.com/users/Gundersanne/following{/other_user}","gists_url":"https://api.github.com/users/Gundersanne/gists{/gist_id}","starred_url":"https://api.github.com/users/Gundersanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gundersanne/subscriptions","organizations_url":"https://api.github.com/users/Gundersanne/orgs","repos_url":"https://api.github.com/users/Gundersanne/repos","events_url":"https://api.github.com/users/Gundersanne/events{/privacy}","received_events_url":"https://api.github.com/users/Gundersanne/received_events","type":"User","site_admin":false},"body":"Recognize ssh and raw dump targets.\r\nEliminate \"other\" dump target.\r\nOverwrite old dump targets when writing config as the kdump config\r\nshould only contain one target at a time.\r\nNo editing dump targets we don't support.","created_at":"2018-11-06T13:37:57Z","updated_at":"2018-11-08T11:58:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83c4ddafb90b0df46959d9fba4004ab87fada10f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/10513/commits","review_comments_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/10513/comments","review_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/10513/comments","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/81fd2ac47c21d3594db05bea807c6ec6ef9abf9e","head":{"label":"Gundersanne:cockpit-289","ref":"cockpit-289","sha":"81fd2ac47c21d3594db05bea807c6ec6ef9abf9e","user":{"login":"Gundersanne","id":11140201,"node_id":"MDQ6VXNlcjExMTQwMjAx","avatar_url":"https://avatars0.githubusercontent.com/u/11140201?v=4","gravatar_id":"","url":"https://api.github.com/users/Gundersanne","html_url":"https://github.com/Gundersanne","followers_url":"https://api.github.com/users/Gundersanne/followers","following_url":"https://api.github.com/users/Gundersanne/following{/other_user}","gists_url":"https://api.github.com/users/Gundersanne/gists{/gist_id}","starred_url":"https://api.github.com/users/Gundersanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gundersanne/subscriptions","organizations_url":"https://api.github.com/users/Gundersanne/orgs","repos_url":"https://api.github.com/users/Gundersanne/repos","events_url":"https://api.github.com/users/Gundersanne/events{/privacy}","received_events_url":"https://api.github.com/users/Gundersanne/received_events","type":"User","site_admin":false},"repo":{"id":137205384,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMDUzODQ=","name":"cockpit","full_name":"Gundersanne/cockpit","private":false,"owner":{"login":"Gundersanne","id":11140201,"node_id":"MDQ6VXNlcjExMTQwMjAx","avatar_url":"https://avatars0.githubusercontent.com/u/11140201?v=4","gravatar_id":"","url":"https://api.github.com/users/Gundersanne","html_url":"https://github.com/Gundersanne","followers_url":"https://api.github.com/users/Gundersanne/followers","following_url":"https://api.github.com/users/Gundersanne/following{/other_user}","gists_url":"https://api.github.com/users/Gundersanne/gists{/gist_id}","starred_url":"https://api.github.com/users/Gundersanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gundersanne/subscriptions","organizations_url":"https://api.github.com/users/Gundersanne/orgs","repos_url":"https://api.github.com/users/Gundersanne/repos","events_url":"https://api.github.com/users/Gundersanne/events{/privacy}","received_events_url":"https://api.github.com/users/Gundersanne/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Gundersanne/cockpit","description":"There's code a goin' on","fork":true,"url":"https://api.github.com/repos/Gundersanne/cockpit","forks_url":"https://api.github.com/repos/Gundersanne/cockpit/forks","keys_url":"https://api.github.com/repos/Gundersanne/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gundersanne/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gundersanne/cockpit/teams","hooks_url":"https://api.github.com/repos/Gundersanne/cockpit/hooks","issue_events_url":"https://api.github.com/repos/Gundersanne/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/Gundersanne/cockpit/events","assignees_url":"https://api.github.com/repos/Gundersanne/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/Gundersanne/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/Gundersanne/cockpit/tags","blobs_url":"https://api.github.com/repos/Gundersanne/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gundersanne/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gundersanne/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gundersanne/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gundersanne/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/Gundersanne/cockpit/languages","stargazers_url":"https://api.github.com/repos/Gundersanne/cockpit/stargazers","contributors_url":"https://api.github.com/repos/Gundersanne/cockpit/contributors","subscribers_url":"https://api.github.com/repos/Gundersanne/cockpit/subscribers","subscription_url":"https://api.github.com/repos/Gundersanne/cockpit/subscription","commits_url":"https://api.github.com/repos/Gundersanne/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gundersanne/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gundersanne/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gundersanne/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Gundersanne/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/Gundersanne/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gundersanne/cockpit/merges","archive_url":"https://api.github.com/repos/Gundersanne/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gundersanne/cockpit/downloads","issues_url":"https://api.github.com/repos/Gundersanne/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/Gundersanne/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/Gundersanne/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/Gundersanne/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gundersanne/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/Gundersanne/cockpit/releases{/id}","deployments_url":"https://api.github.com/repos/Gundersanne/cockpit/deployments","created_at":"2018-06-13T11:19:11Z","updated_at":"2018-06-13T11:19:18Z","pushed_at":"2018-11-07T09:55:00Z","git_url":"git://github.com/Gundersanne/cockpit.git","ssh_url":"git@github.com:Gundersanne/cockpit.git","clone_url":"https://github.com/Gundersanne/cockpit.git","svn_url":"https://github.com/Gundersanne/cockpit","homepage":"http://www.cockpit-project.org/","size":58184,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockpit-project:master","ref":"master","sha":"95678c0a70edb62de79882636fb99034b9afb9ca","user":{"login":"cockpit-project","id":5765104,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NjUxMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5765104?v=4","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"repo":{"id":14049216,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA0OTIxNg==","name":"cockpit","full_name":"cockpit-project/cockpit","private":false,"owner":{"login":"cockpit-project","id":5765104,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NjUxMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5765104?v=4","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cockpit-project/cockpit","description":"There's code a goin' on","fork":false,"url":"https://api.github.com/repos/cockpit-project/cockpit","forks_url":"https://api.github.com/repos/cockpit-project/cockpit/forks","keys_url":"https://api.github.com/repos/cockpit-project/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockpit-project/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockpit-project/cockpit/teams","hooks_url":"https://api.github.com/repos/cockpit-project/cockpit/hooks","issue_events_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/cockpit-project/cockpit/events","assignees_url":"https://api.github.com/repos/cockpit-project/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/cockpit-project/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/cockpit-project/cockpit/tags","blobs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockpit-project/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockpit-project/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/cockpit-project/cockpit/languages","stargazers_url":"https://api.github.com/repos/cockpit-project/cockpit/stargazers","contributors_url":"https://api.github.com/repos/cockpit-project/cockpit/contributors","subscribers_url":"https://api.github.com/repos/cockpit-project/cockpit/subscribers","subscription_url":"https://api.github.com/repos/cockpit-project/cockpit/subscription","commits_url":"https://api.github.com/repos/cockpit-project/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockpit-project/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockpit-project/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/cockpit-project/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockpit-project/cockpit/merges","archive_url":"https://api.github.com/repos/cockpit-project/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockpit-project/cockpit/downloads","issues_url":"https://api.github.com/repos/cockpit-project/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/cockpit-project/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/cockpit-project/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockpit-project/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/cockpit-project/cockpit/releases{/id}","deployments_url":"https://api.github.com/repos/cockpit-project/cockpit/deployments","created_at":"2013-11-01T17:36:46Z","updated_at":"2018-11-08T11:17:59Z","pushed_at":"2018-11-08T11:31:48Z","git_url":"git://github.com/cockpit-project/cockpit.git","ssh_url":"git@github.com:cockpit-project/cockpit.git","clone_url":"https://github.com/cockpit-project/cockpit.git","svn_url":"https://github.com/cockpit-project/cockpit","homepage":"http://www.cockpit-project.org/","size":58226,"stargazers_count":3484,"watchers_count":3484,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":451,"mirror_url":null,"archived":false,"open_issues_count":671,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":451,"open_issues":671,"watchers":3484,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/10513"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/10513"},"issue":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/10513"},"comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/10513/comments"},"review_comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/10513/comments"},"review_comment":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/10513/commits"},"statuses":{"href":"https://api.github.com/repos/cockpit-project/cockpit/statuses/81fd2ac47c21d3594db05bea807c6ec6ef9abf9e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"martinpitt"}}