{"action":"created","issue":{"url":"https://api.github.com/repos/SFML/SFML/issues/1512","repository_url":"https://api.github.com/repos/SFML/SFML","labels_url":"https://api.github.com/repos/SFML/SFML/issues/1512/labels{/name}","comments_url":"https://api.github.com/repos/SFML/SFML/issues/1512/comments","events_url":"https://api.github.com/repos/SFML/SFML/issues/1512/events","html_url":"https://github.com/SFML/SFML/pull/1512","id":378270308,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MDE0MDA3","number":1512,"title":"Use C++11 std::unique_ptr","user":{"login":"markand","id":11919008,"node_id":"MDQ6VXNlcjExOTE5MDA4","avatar_url":"https://avatars0.githubusercontent.com/u/11919008?v=4","gravatar_id":"","url":"https://api.github.com/users/markand","html_url":"https://github.com/markand","followers_url":"https://api.github.com/users/markand/followers","following_url":"https://api.github.com/users/markand/following{/other_user}","gists_url":"https://api.github.com/users/markand/gists{/gist_id}","starred_url":"https://api.github.com/users/markand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markand/subscriptions","organizations_url":"https://api.github.com/users/markand/orgs","repos_url":"https://api.github.com/users/markand/repos","events_url":"https://api.github.com/users/markand/events{/privacy}","received_events_url":"https://api.github.com/users/markand/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-07T12:37:55Z","updated_at":"2018-11-07T12:48:21Z","closed_at":"2018-11-07T12:48:21Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/SFML/SFML/pulls/1512","html_url":"https://github.com/SFML/SFML/pull/1512","diff_url":"https://github.com/SFML/SFML/pull/1512.diff","patch_url":"https://github.com/SFML/SFML/pull/1512.patch"},"body":"## Description\r\n\r\nThe std::auto_ptr class will be removed in C++17 and has been deprecated\r\nsince C++11.\r\n\r\nFix warning:\r\n\r\n```\r\n/home/markand/SFML/src/SFML/Audio/AudioDevice.cpp: In static member function ‘static int sf::priv::AudioDevice::getFormatFromChannelCount(unsigned int)’:\r\n/home/markand/SFML/src/SFML/Audio/AudioDevice.cpp:128:10: warning: ‘template<class> class std::auto_ptr’ is deprecated [-Wdeprecated-declarations]\r\n     std::auto_ptr<AudioDevice> device;\r\n          ^~~~~~~~\r\nIn file included from /usr/include/c++/8.2.1/memory:80,\r\n                 from /home/markand/SFML/src/SFML/Audio/AudioDevice.cpp:32:\r\n/usr/include/c++/8.2.1/bits/unique_ptr.h:53:28: note: declared here\r\n   template<typename> class auto_ptr;\r\n```\r\n\r\n## Tasks\r\n\r\n* [x] Tested on Linux"},"comment":{"url":"https://api.github.com/repos/SFML/SFML/issues/comments/436612007","html_url":"https://github.com/SFML/SFML/pull/1512#issuecomment-436612007","issue_url":"https://api.github.com/repos/SFML/SFML/issues/1512","id":436612007,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjYxMjAwNw==","user":{"login":"eXpl0it3r","id":920861,"node_id":"MDQ6VXNlcjkyMDg2MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/920861?v=4","gravatar_id":"","url":"https://api.github.com/users/eXpl0it3r","html_url":"https://github.com/eXpl0it3r","followers_url":"https://api.github.com/users/eXpl0it3r/followers","following_url":"https://api.github.com/users/eXpl0it3r/following{/other_user}","gists_url":"https://api.github.com/users/eXpl0it3r/gists{/gist_id}","starred_url":"https://api.github.com/users/eXpl0it3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eXpl0it3r/subscriptions","organizations_url":"https://api.github.com/users/eXpl0it3r/orgs","repos_url":"https://api.github.com/users/eXpl0it3r/repos","events_url":"https://api.github.com/users/eXpl0it3r/events{/privacy}","received_events_url":"https://api.github.com/users/eXpl0it3r/received_events","type":"User","site_admin":false},"created_at":"2018-11-07T12:48:21Z","updated_at":"2018-11-07T12:48:21Z","author_association":"MEMBER","body":"Thanks, we are aware of this, but since SFML 2.x is still using C++03, we can't change it for now.\r\n\r\nAs for C++1y refactorings, we've already have quite a [few changes done](https://github.com/SFML/SFML/tree/unstable), including this one. As such I'll close this PR."}}
{"actor":{"display_login":"eXpl0it3r"}}