{"action":"opened","issue":{"url":"https://api.github.com/repos/kyma-project/kyma/issues/1827","repository_url":"https://api.github.com/repos/kyma-project/kyma","labels_url":"https://api.github.com/repos/kyma-project/kyma/issues/1827/labels{/name}","comments_url":"https://api.github.com/repos/kyma-project/kyma/issues/1827/comments","events_url":"https://api.github.com/repos/kyma-project/kyma/issues/1827/events","html_url":"https://github.com/kyma-project/kyma/issues/1827","id":384738177,"node_id":"MDU6SXNzdWUzODQ3MzgxNzc=","number":1827,"title":"During installation retry (helm upgrade) pods are not rolled","user":{"login":"PavelPavlov46","id":40396270,"node_id":"MDQ6VXNlcjQwMzk2Mjcw","avatar_url":"https://avatars1.githubusercontent.com/u/40396270?v=4","gravatar_id":"","url":"https://api.github.com/users/PavelPavlov46","html_url":"https://github.com/PavelPavlov46","followers_url":"https://api.github.com/users/PavelPavlov46/followers","following_url":"https://api.github.com/users/PavelPavlov46/following{/other_user}","gists_url":"https://api.github.com/users/PavelPavlov46/gists{/gist_id}","starred_url":"https://api.github.com/users/PavelPavlov46/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PavelPavlov46/subscriptions","organizations_url":"https://api.github.com/users/PavelPavlov46/orgs","repos_url":"https://api.github.com/users/PavelPavlov46/repos","events_url":"https://api.github.com/users/PavelPavlov46/events{/privacy}","received_events_url":"https://api.github.com/users/PavelPavlov46/received_events","type":"User","site_admin":false},"labels":[{"id":1039082083,"node_id":"MDU6TGFiZWwxMDM5MDgyMDgz","url":"https://api.github.com/repos/kyma-project/kyma/labels/area/installation","name":"area/installation","color":"3cba12","default":false},{"id":982732751,"node_id":"MDU6TGFiZWw5ODI3MzI3NTE=","url":"https://api.github.com/repos/kyma-project/kyma/labels/bug","name":"bug","color":"d73a4a","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-27T11:00:01Z","updated_at":"2018-11-27T11:00:01Z","closed_at":null,"author_association":"NONE","body":"**Description**\r\n\r\nIn case of Installation retry the already deployed Charts are upgraded.\r\n\r\n```$ k -n kyma-installer kyma-installer-57fb465f4d-945fk -f\r\n2018/11/27 10:29:49 Warning: Retry number 131 (sleeping for 60[s]).\r\n2018/11/27 10:30:49 ---------------------------\r\n2018/11/27 10:30:49 Get Kyma Sources\r\n2018/11/27 10:30:49 ---------------------------\r\n2018/11/27 10:30:49 Kyma sources available locally.\r\n2018/11/27 10:30:49 Get Kyma Sources...DONE\r\n2018/11/27 10:30:49 Processing Kyma components\r\n2018/11/27 10:30:49 ---------------------------\r\n2018/11/27 10:30:49 Processing component cluster-essentials\r\n2018/11/27 10:30:49 ---------------------------\r\n2018/11/27 10:30:51 Name: cluster-essentials\r\n2018/11/27 10:30:51 Namespace: kyma-system\r\n2018/11/27 10:30:51 Version: 125\r\n2018/11/27 10:30:51 Status: DEPLOYED\r\n2018/11/27 10:30:51 Description: Upgrade complete\r\n2018/11/27 10:30:51 Processing component cluster-essentials...DONE\r\n2018/11/27 10:30:51 ---------------------------\r\n```\r\n\r\nThe upgrade may cause some kubernetes objects to be modified - for example Secrets / ConfigMaps / other settigns related objects. \r\n\r\n**Expected result**\r\n\r\nThe objects impacted by the upgrade changes to be rolled during the Installation retry or during the upgrade in later versions. For example using [automatically-roll-deployments-when-configmaps-or-secrets-change](https://github.com/helm/helm/blob/master/docs/charts_tips_and_tricks.md#automatically-roll-deployments-when-configmaps-or-secrets-change).\r\n\r\n**Actual result**\r\n\r\nWill take cluster-essentials just as one example, but this is valid for all charts.\r\n1. cluster-essentials is installed. Following objects are created:\r\n- kubectl -n kyma-system get MutatingWebhookConfiguration cluster-essentials-pod-preset-webhook\r\n- kubectl -n kyma-system get secret cluster-essentials-pod-preset-webhook-cert\r\n- kubectl -n kyma-system logs cluster-essentials-pod-preset-webhook-98bc79494-d7rfn\r\n\r\n2.  in case of a fail later on during the Installation (or maybe in future releases during upgrade?), chart is upgraded. Following objects are changed:\r\n- kubectl -n kyma-system get MutatingWebhookConfiguration cluster-essentials-pod-preset-webhook\r\n- kubectl -n kyma-system get secret cluster-essentials-pod-preset-webhook-cert\r\nFollowing object is not auto-rolled (does not get the new certificate generated by the Chart during update)\r\n- kubectl -n kyma-system logs cluster-essentials-pod-preset-webhook-98bc79494-d7rfn\r\nImpact: next Installation / operation steps depending on the pod-preset-webhook fail with:\r\n\r\n```\r\n$ k -n kyma-system logs cluster-essentials-pod-preset-webhook-98bc79494-d7rfn\r\n      I1126 10:52:13.543967       1 main.go:496] About to start serving webhooks: &http.Server{Addr:\":443\", Handler:http.Handler(nil), TLSConfig:(\\*tls.Config)(0xc42030e480), ReadTimeout:0, ReadHeaderTimeout:0, WriteTimeout:0, IdleTimeout:0, MaxHeaderBytes:0, TLSNextProto:map[string]func(\\*http.Server, \\*tls.Conn, http.Handler)(nil), ConnState:(func(net.Conn, http.ConnState))(nil), ErrorLog:(\\*log.Logger)(nil), disableKeepAlives:0, inShutdown:0, nextProtoOnce:sync.Once{m:sync.Mutex{state:0, sema:0x0}, done:0x0}, nextProtoErr:error(nil), mu:sync.Mutex{state:0, sema:0x0}, listeners:map[net.Listener]struct {}(nil), activeConn:map[\\*http.conn]struct {}(nil), doneChan:(chan struct {})(nil), onShutdown:[]func()(nil)}\r\n      2018/11/26 10:53:54 http: TLS handshake error from 100.96.0.3:52710: remote error: tls: bad certificate\r\n      2018/11/26 10:53:56 http: TLS handshake error from 100.96.0.3:55952: remote error: tls: bad certificate\r\n```\r\n\r\n\r\n**Steps to reproduce**\r\nOptions to reproduce:\r\nInstall a Chart and try to upgrade it.\r\nInstall kyma partially and wait for auto-retry of the install. \r\nInstall kyma and try to upgrade the instance.\r\n\r\n**Troubleshooting**\r\n\r\nSee actual result.\r\n"}}
{"actor":{"display_login":"PavelPavlov46"}}