{"action":"closed","number":724,"pull_request":{"url":"https://api.github.com/repos/JJ/IV-18-19/pulls/724","id":235008823,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MDA4ODIz","html_url":"https://github.com/JJ/IV-18-19/pull/724","diff_url":"https://github.com/JJ/IV-18-19/pull/724.diff","patch_url":"https://github.com/JJ/IV-18-19/pull/724.patch","issue_url":"https://api.github.com/repos/JJ/IV-18-19/issues/724","number":724,"state":"closed","locked":false,"title":"Reenvío del hito-4","user":{"login":"JaviMancilla","id":14999775,"node_id":"MDQ6VXNlcjE0OTk5Nzc1","avatar_url":"https://avatars1.githubusercontent.com/u/14999775?v=4","gravatar_id":"","url":"https://api.github.com/users/JaviMancilla","html_url":"https://github.com/JaviMancilla","followers_url":"https://api.github.com/users/JaviMancilla/followers","following_url":"https://api.github.com/users/JaviMancilla/following{/other_user}","gists_url":"https://api.github.com/users/JaviMancilla/gists{/gist_id}","starred_url":"https://api.github.com/users/JaviMancilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaviMancilla/subscriptions","organizations_url":"https://api.github.com/users/JaviMancilla/orgs","repos_url":"https://api.github.com/users/JaviMancilla/repos","events_url":"https://api.github.com/users/JaviMancilla/events{/privacy}","received_events_url":"https://api.github.com/users/JaviMancilla/received_events","type":"User","site_admin":false},"body":"# Entrega del hito del proyecto de Infraestructura virtual\r\n\r\nCorresponde al hito 4\r\n\r\n## Lista de comprobación para hitos\r\n\r\n* [X] He leído el guión del hito\r\n* [X] Cumplo los prerrequisitos (he aprobado el hito anterior, por ejemplo)\r\n* [X] He actualizado con la última versión del fichero de entrega y\r\n  añadido mi contribución en una línea que no cree conflictos.\r\n* [X] Si estoy enviando otra versión porque no pasó los tests la\r\nanterior, he [seguido las instrucciones para reenvíos](http://jj.github.io/IV/documentos/proyecto/Reenvios).\r\n\r\n\r\n  \r\n  \r\n## Descripción de la entrega\r\n\r\nArreglos en los fallos comentados por el profesor.\r\nEn arreglado la documentación relativa a docker, donde he eliminado la descripción de como instalar Docker. En este mismo fichero he añadido la documentación referente al despliegue del contenedor en Heroku. \r\nTambién he modificado el archivo Dockerfile, en el cual he cambiado la linea en la cual se copiaban los archivo para un despliegue en local. En dicha línea, anteriormente se descargaba el directorio entero, lo cual no era necesario (no hace falta un Dockerfile para lanzar la aplicacion en local), por lo tanto solo hemos puesto los archivos que se necesitan para el lanzamiento. \r\nTambién he modificado el README.md, donde he arreglado los enlaces a la documentación pertinente.\r\nTambién he creado el archivo heroku.yml.\r\nHe borrado el directorio ENV, el cual no causa ningún efecto en la aplicación. \r\n\r\n## Hitos e *issues* del repositorio que se han cerrado con esta entrega \r\n\r\n[Enlace Milestone](https://github.com/JaviMancilla/MarcadorDeportivo_IV1819/milestone/4)\r\n\r\n#28 Eliminar ficher DocHerokuDocker.md \r\nHe eliminado este archivo ya que la documentación que se detallaba en el era era incorrecta.\r\n#27 Cambios en el documento DocDocker.md \r\nHe añadido las explicaciones con respecto a como desplegar el contenedor de en Heroku\r\n#26 Modificaciones en app.py para pruebas de despliegue. \r\nhe modificado los valores del estado para comprobar que la aplicación estuviera correctamente funcionando.\r\n#25 Modificar documentación DocHerokuDocker.md \r\nSe modificó anteriormente pero como se detalla en un issue anterior este fichero ha sido eliminado.\r\n#24 Modificar archivo Dockerfile \r\nModificamos el dockerfile para que al desplegar la aplicacion en local solo descargue/copie los archivos necesarios para su despliegue\r\n#23 Renombramos el directorio travistes --> src \r\nRenombramos el directorio llamado anteriormente como travistest en el cual se incluia la clase para la aplicación. Ahora su nombre es src.\r\n#22 Eliminar directorio ENV \r\nEliminamos el directorio ENV que se encontraba en la carpeta raiz, puesto que no tiene ningun efecto sobre el proyecto. \r\n#21 Agregar ficher heroku.yml \r\nCreamos y añadimos el fichero heroku.yml\r\n#20 Arreglo de errores en README.md \r\nArreglamos errores de enlazado de documentacion del proyecto.\r\n#19 Arreglar error en archivo de documentación de Docker. \r\nSe cambió la manera de como crear un contenedor en Docker.","created_at":"2018-11-30T14:41:13Z","updated_at":"2018-11-30T15:19:16Z","closed_at":"2018-11-30T15:19:16Z","merged_at":"2018-11-30T15:19:16Z","merge_commit_sha":"47546bd5b4cc868c45716ffabafa802c84244529","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JJ/IV-18-19/pulls/724/commits","review_comments_url":"https://api.github.com/repos/JJ/IV-18-19/pulls/724/comments","review_comment_url":"https://api.github.com/repos/JJ/IV-18-19/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JJ/IV-18-19/issues/724/comments","statuses_url":"https://api.github.com/repos/JJ/IV-18-19/statuses/3fbb735c6cd143b8fa35906114223f2a7dde9ddd","head":{"label":"JaviMancilla:master","ref":"master","sha":"3fbb735c6cd143b8fa35906114223f2a7dde9ddd","user":{"login":"JaviMancilla","id":14999775,"node_id":"MDQ6VXNlcjE0OTk5Nzc1","avatar_url":"https://avatars1.githubusercontent.com/u/14999775?v=4","gravatar_id":"","url":"https://api.github.com/users/JaviMancilla","html_url":"https://github.com/JaviMancilla","followers_url":"https://api.github.com/users/JaviMancilla/followers","following_url":"https://api.github.com/users/JaviMancilla/following{/other_user}","gists_url":"https://api.github.com/users/JaviMancilla/gists{/gist_id}","starred_url":"https://api.github.com/users/JaviMancilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaviMancilla/subscriptions","organizations_url":"https://api.github.com/users/JaviMancilla/orgs","repos_url":"https://api.github.com/users/JaviMancilla/repos","events_url":"https://api.github.com/users/JaviMancilla/events{/privacy}","received_events_url":"https://api.github.com/users/JaviMancilla/received_events","type":"User","site_admin":false},"repo":{"id":148754068,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg3NTQwNjg=","name":"IV-18-19","full_name":"JaviMancilla/IV-18-19","private":false,"owner":{"login":"JaviMancilla","id":14999775,"node_id":"MDQ6VXNlcjE0OTk5Nzc1","avatar_url":"https://avatars1.githubusercontent.com/u/14999775?v=4","gravatar_id":"","url":"https://api.github.com/users/JaviMancilla","html_url":"https://github.com/JaviMancilla","followers_url":"https://api.github.com/users/JaviMancilla/followers","following_url":"https://api.github.com/users/JaviMancilla/following{/other_user}","gists_url":"https://api.github.com/users/JaviMancilla/gists{/gist_id}","starred_url":"https://api.github.com/users/JaviMancilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaviMancilla/subscriptions","organizations_url":"https://api.github.com/users/JaviMancilla/orgs","repos_url":"https://api.github.com/users/JaviMancilla/repos","events_url":"https://api.github.com/users/JaviMancilla/events{/privacy}","received_events_url":"https://api.github.com/users/JaviMancilla/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JaviMancilla/IV-18-19","description":"Repositorio para la asignatura Infraestructura Virtual de 4º del Grado de Ingeniería Informática","fork":true,"url":"https://api.github.com/repos/JaviMancilla/IV-18-19","forks_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/forks","keys_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/teams","hooks_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/hooks","issue_events_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/issues/events{/number}","events_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/events","assignees_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/assignees{/user}","branches_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/branches{/branch}","tags_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/tags","blobs_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/git/refs{/sha}","trees_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/statuses/{sha}","languages_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/languages","stargazers_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/stargazers","contributors_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/contributors","subscribers_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/subscribers","subscription_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/subscription","commits_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/commits{/sha}","git_commits_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/git/commits{/sha}","comments_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/comments{/number}","issue_comment_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/issues/comments{/number}","contents_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/contents/{+path}","compare_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/merges","archive_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/downloads","issues_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/issues{/number}","pulls_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/pulls{/number}","milestones_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/milestones{/number}","notifications_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/labels{/name}","releases_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/releases{/id}","deployments_url":"https://api.github.com/repos/JaviMancilla/IV-18-19/deployments","created_at":"2018-09-14T07:44:38Z","updated_at":"2018-11-30T15:02:42Z","pushed_at":"2018-11-30T15:02:40Z","git_url":"git://github.com/JaviMancilla/IV-18-19.git","ssh_url":"git@github.com:JaviMancilla/IV-18-19.git","clone_url":"https://github.com/JaviMancilla/IV-18-19.git","svn_url":"https://github.com/JaviMancilla/IV-18-19","homepage":null,"size":1226,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"artistic-2.0","name":"Artistic License 2.0","spdx_id":"Artistic-2.0","url":"https://api.github.com/licenses/artistic-2.0","node_id":"MDc6TGljZW5zZTM="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JJ:master","ref":"master","sha":"e99429c03ed1d7409475a09f734ae19f8ae340f7","user":{"login":"JJ","id":500,"node_id":"MDQ6VXNlcjUwMA==","avatar_url":"https://avatars3.githubusercontent.com/u/500?v=4","gravatar_id":"","url":"https://api.github.com/users/JJ","html_url":"https://github.com/JJ","followers_url":"https://api.github.com/users/JJ/followers","following_url":"https://api.github.com/users/JJ/following{/other_user}","gists_url":"https://api.github.com/users/JJ/gists{/gist_id}","starred_url":"https://api.github.com/users/JJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JJ/subscriptions","organizations_url":"https://api.github.com/users/JJ/orgs","repos_url":"https://api.github.com/users/JJ/repos","events_url":"https://api.github.com/users/JJ/events{/privacy}","received_events_url":"https://api.github.com/users/JJ/received_events","type":"User","site_admin":false},"repo":{"id":142431956,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0MzE5NTY=","name":"IV-18-19","full_name":"JJ/IV-18-19","private":false,"owner":{"login":"JJ","id":500,"node_id":"MDQ6VXNlcjUwMA==","avatar_url":"https://avatars3.githubusercontent.com/u/500?v=4","gravatar_id":"","url":"https://api.github.com/users/JJ","html_url":"https://github.com/JJ","followers_url":"https://api.github.com/users/JJ/followers","following_url":"https://api.github.com/users/JJ/following{/other_user}","gists_url":"https://api.github.com/users/JJ/gists{/gist_id}","starred_url":"https://api.github.com/users/JJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JJ/subscriptions","organizations_url":"https://api.github.com/users/JJ/orgs","repos_url":"https://api.github.com/users/JJ/repos","events_url":"https://api.github.com/users/JJ/events{/privacy}","received_events_url":"https://api.github.com/users/JJ/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JJ/IV-18-19","description":"Repositorio para la asignatura Infraestructura Virtual de 4º del Grado de Ingeniería Informática","fork":false,"url":"https://api.github.com/repos/JJ/IV-18-19","forks_url":"https://api.github.com/repos/JJ/IV-18-19/forks","keys_url":"https://api.github.com/repos/JJ/IV-18-19/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JJ/IV-18-19/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JJ/IV-18-19/teams","hooks_url":"https://api.github.com/repos/JJ/IV-18-19/hooks","issue_events_url":"https://api.github.com/repos/JJ/IV-18-19/issues/events{/number}","events_url":"https://api.github.com/repos/JJ/IV-18-19/events","assignees_url":"https://api.github.com/repos/JJ/IV-18-19/assignees{/user}","branches_url":"https://api.github.com/repos/JJ/IV-18-19/branches{/branch}","tags_url":"https://api.github.com/repos/JJ/IV-18-19/tags","blobs_url":"https://api.github.com/repos/JJ/IV-18-19/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JJ/IV-18-19/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JJ/IV-18-19/git/refs{/sha}","trees_url":"https://api.github.com/repos/JJ/IV-18-19/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JJ/IV-18-19/statuses/{sha}","languages_url":"https://api.github.com/repos/JJ/IV-18-19/languages","stargazers_url":"https://api.github.com/repos/JJ/IV-18-19/stargazers","contributors_url":"https://api.github.com/repos/JJ/IV-18-19/contributors","subscribers_url":"https://api.github.com/repos/JJ/IV-18-19/subscribers","subscription_url":"https://api.github.com/repos/JJ/IV-18-19/subscription","commits_url":"https://api.github.com/repos/JJ/IV-18-19/commits{/sha}","git_commits_url":"https://api.github.com/repos/JJ/IV-18-19/git/commits{/sha}","comments_url":"https://api.github.com/repos/JJ/IV-18-19/comments{/number}","issue_comment_url":"https://api.github.com/repos/JJ/IV-18-19/issues/comments{/number}","contents_url":"https://api.github.com/repos/JJ/IV-18-19/contents/{+path}","compare_url":"https://api.github.com/repos/JJ/IV-18-19/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JJ/IV-18-19/merges","archive_url":"https://api.github.com/repos/JJ/IV-18-19/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JJ/IV-18-19/downloads","issues_url":"https://api.github.com/repos/JJ/IV-18-19/issues{/number}","pulls_url":"https://api.github.com/repos/JJ/IV-18-19/pulls{/number}","milestones_url":"https://api.github.com/repos/JJ/IV-18-19/milestones{/number}","notifications_url":"https://api.github.com/repos/JJ/IV-18-19/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JJ/IV-18-19/labels{/name}","releases_url":"https://api.github.com/repos/JJ/IV-18-19/releases{/id}","deployments_url":"https://api.github.com/repos/JJ/IV-18-19/deployments","created_at":"2018-07-26T11:29:54Z","updated_at":"2018-11-30T15:19:19Z","pushed_at":"2018-11-30T15:19:17Z","git_url":"git://github.com/JJ/IV-18-19.git","ssh_url":"git@github.com:JJ/IV-18-19.git","clone_url":"https://github.com/JJ/IV-18-19.git","svn_url":"https://github.com/JJ/IV-18-19","homepage":null,"size":1229,"stargazers_count":18,"watchers_count":18,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"artistic-2.0","name":"Artistic License 2.0","spdx_id":"Artistic-2.0","url":"https://api.github.com/licenses/artistic-2.0","node_id":"MDc6TGljZW5zZTM="},"forks":55,"open_issues":5,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JJ/IV-18-19/pulls/724"},"html":{"href":"https://github.com/JJ/IV-18-19/pull/724"},"issue":{"href":"https://api.github.com/repos/JJ/IV-18-19/issues/724"},"comments":{"href":"https://api.github.com/repos/JJ/IV-18-19/issues/724/comments"},"review_comments":{"href":"https://api.github.com/repos/JJ/IV-18-19/pulls/724/comments"},"review_comment":{"href":"https://api.github.com/repos/JJ/IV-18-19/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JJ/IV-18-19/pulls/724/commits"},"statuses":{"href":"https://api.github.com/repos/JJ/IV-18-19/statuses/3fbb735c6cd143b8fa35906114223f2a7dde9ddd"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"fbarranco","id":15844239,"node_id":"MDQ6VXNlcjE1ODQ0MjM5","avatar_url":"https://avatars1.githubusercontent.com/u/15844239?v=4","gravatar_id":"","url":"https://api.github.com/users/fbarranco","html_url":"https://github.com/fbarranco","followers_url":"https://api.github.com/users/fbarranco/followers","following_url":"https://api.github.com/users/fbarranco/following{/other_user}","gists_url":"https://api.github.com/users/fbarranco/gists{/gist_id}","starred_url":"https://api.github.com/users/fbarranco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbarranco/subscriptions","organizations_url":"https://api.github.com/users/fbarranco/orgs","repos_url":"https://api.github.com/users/fbarranco/repos","events_url":"https://api.github.com/users/fbarranco/events{/privacy}","received_events_url":"https://api.github.com/users/fbarranco/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"fbarranco"}}