{"action":"created","issue":{"url":"https://api.github.com/repos/micropython/micropython/issues/4341","repository_url":"https://api.github.com/repos/micropython/micropython","labels_url":"https://api.github.com/repos/micropython/micropython/issues/4341/labels{/name}","comments_url":"https://api.github.com/repos/micropython/micropython/issues/4341/comments","events_url":"https://api.github.com/repos/micropython/micropython/issues/4341/events","html_url":"https://github.com/micropython/micropython/issues/4341","id":389158009,"node_id":"MDU6SXNzdWUzODkxNTgwMDk=","number":4341,"title":"(Suspected) regression in bytecode dump handling routines","user":{"login":"pfalcon","id":500451,"node_id":"MDQ6VXNlcjUwMDQ1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/500451?v=4","gravatar_id":"","url":"https://api.github.com/users/pfalcon","html_url":"https://github.com/pfalcon","followers_url":"https://api.github.com/users/pfalcon/followers","following_url":"https://api.github.com/users/pfalcon/following{/other_user}","gists_url":"https://api.github.com/users/pfalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/pfalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfalcon/subscriptions","organizations_url":"https://api.github.com/users/pfalcon/orgs","repos_url":"https://api.github.com/users/pfalcon/repos","events_url":"https://api.github.com/users/pfalcon/events{/privacy}","received_events_url":"https://api.github.com/users/pfalcon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-10T06:28:06Z","updated_at":"2018-12-11T07:58:29Z","closed_at":null,"author_association":"MEMBER","body":"I'd like again to attention to particular commits of https://github.com/micropython/micropython/pull/4265 , specifically \"tools/mpy-tools.py: Fix opcode size enumeration and constant definition.\" and \"py/bc.c: Fix opcode size enumeration.\", current links:\r\n\r\n* https://github.com/micropython/micropython/pull/4265/commits/94fffddb19c2ab6a196c72f23aed85bc79d758df\r\n* https://github.com/micropython/micropython/pull/4265/commits/d24402f4f1199cafa72d40b33f459dd397a9a4a9\r\n\r\nAnd comment https://github.com/micropython/micropython/pull/4265#issuecomment-435183103.\r\n\r\nWhat those commits show is that, allegedly, routines for decoding bytecode (as used for example by -v -v flags) have a bug/weren't updated after MICROPY_OPT_CACHE_MAP_LOOKUP_IN_BYTECODE was introduced, and tools/mpy-tool.py even has incorrect values for some bytecodes.\r\n\r\nThis is pretty serious regression, which, if true, may seriously confuse anyone trying to use MicroPython in advanced way, e.g. to look into optimizations.\r\n\r\nNote that I didn't try to verify those findings (apparently, it's maintainer's job), hence modals sprinkled around the text.\r\n"},"comment":{"url":"https://api.github.com/repos/micropython/micropython/issues/comments/446106438","html_url":"https://github.com/micropython/micropython/issues/4341#issuecomment-446106438","issue_url":"https://api.github.com/repos/micropython/micropython/issues/4341","id":446106438,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjEwNjQzOA==","user":{"login":"pfalcon","id":500451,"node_id":"MDQ6VXNlcjUwMDQ1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/500451?v=4","gravatar_id":"","url":"https://api.github.com/users/pfalcon","html_url":"https://github.com/pfalcon","followers_url":"https://api.github.com/users/pfalcon/followers","following_url":"https://api.github.com/users/pfalcon/following{/other_user}","gists_url":"https://api.github.com/users/pfalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/pfalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfalcon/subscriptions","organizations_url":"https://api.github.com/users/pfalcon/orgs","repos_url":"https://api.github.com/users/pfalcon/repos","events_url":"https://api.github.com/users/pfalcon/events{/privacy}","received_events_url":"https://api.github.com/users/pfalcon/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T07:58:29Z","updated_at":"2018-12-11T07:58:29Z","author_association":"MEMBER","body":"> But it's not technically a regression\r\n\r\nI stand corrected, and I used all those modals here because I indeed didn't try to investigate it myself (and don't remember all those details by now). All things bytecode are otherwise rather underused in MicroPython, some people show interest in knowing more about it, and having such issues could puzzle them a lot on their learning curve. Thanks for looking into this!\r\n"}}
{"actor":{"display_login":"pfalcon"}}