{"action":"created","comment":{"url":"https://api.github.com/repos/ghfields/rpooler/pulls/comments/243408203","pull_request_review_id":187172377,"id":243408203,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzQwODIwMw==","diff_hunk":"@@ -1,21 +1,17 @@\n # Rpooler\n ## A ZFS rpool wrapper for the Ubuntu 18.04 Ubiquity Installer\n-This is a wrapper that automates the creation of a fully bootable zfs rpool with Ubuntu 18.04 installed.  It was crafted off the step-by-step [HOWTO install Ubuntu 18.04 to a Whole Disk Native ZFS Root Filesystem using Ubiquity GUI installer](https://github.com/zfsonlinux/pkg-zfs/wiki/HOWTO-install-Ubuntu-18.04-to-a-Whole-Disk-Native-ZFS-Root-Filesystem-using-Ubiquity-GUI-installer).  The goals are to further simplfy the installation process and encourage best practices through the guided process.\n+This is a wrapper that automates the creation of a fully bootable zfs root pool with Ubuntu 18.04 installed.  It was crafted off the step-by-step [HOWTO install Ubuntu 18.04 to a Whole Disk Native ZFS Root Filesystem using Ubiquity GUI installer](https://github.com/zfsonlinux/pkg-zfs/wiki/HOWTO-install-Ubuntu-18.04-to-a-Whole-Disk-Native-ZFS-Root-Filesystem-using-Ubiquity-GUI-installer).  The goals are to further simplfy the installation process and encourage best practices through the guided process.\n \n Instructions:\n 1) Boot Ubuntu 18.04 Desktop Live CD\n 2) Select \"Try Ubuntu\"\n 3) Open terminal (Ctrl+Alt+t)\n-4) wget https://raw.github.com/ghfields/rpooler/master/rpooler.sh\n-5) chmod +x rpooler.sh\n-6) sudo su\n-7) ./rpooler.sh\n+4) `wget https://raw.github.com/ghfields/rpooler/master/rpooler.sh`\n+5) `sudo bash rpooler.sh","path":"README.md","position":15,"original_position":15,"commit_id":"398353f596fc2c3eea60146bf51273a1a461dced","original_commit_id":"398353f596fc2c3eea60146bf51273a1a461dced","user":{"login":"ghfields","id":6624423,"node_id":"MDQ6VXNlcjY2MjQ0MjM=","avatar_url":"https://avatars3.githubusercontent.com/u/6624423?v=4","gravatar_id":"","url":"https://api.github.com/users/ghfields","html_url":"https://github.com/ghfields","followers_url":"https://api.github.com/users/ghfields/followers","following_url":"https://api.github.com/users/ghfields/following{/other_user}","gists_url":"https://api.github.com/users/ghfields/gists{/gist_id}","starred_url":"https://api.github.com/users/ghfields/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghfields/subscriptions","organizations_url":"https://api.github.com/users/ghfields/orgs","repos_url":"https://api.github.com/users/ghfields/repos","events_url":"https://api.github.com/users/ghfields/events{/privacy}","received_events_url":"https://api.github.com/users/ghfields/received_events","type":"User","site_admin":false},"body":"This line is missing a terminating back quote character .  When it is there, it disabled the scripts prompts.  Therefore, I recommend removing the backquote all together .  ","created_at":"2018-12-20T20:31:08Z","updated_at":"2018-12-20T20:41:51Z","html_url":"https://github.com/ghfields/rpooler/pull/29#discussion_r243408203","pull_request_url":"https://api.github.com/repos/ghfields/rpooler/pulls/29","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ghfields/rpooler/pulls/comments/243408203"},"html":{"href":"https://github.com/ghfields/rpooler/pull/29#discussion_r243408203"},"pull_request":{"href":"https://api.github.com/repos/ghfields/rpooler/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/ghfields/rpooler/pulls/29","id":240227409,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMjI3NDA5","html_url":"https://github.com/ghfields/rpooler/pull/29","diff_url":"https://github.com/ghfields/rpooler/pull/29.diff","patch_url":"https://github.com/ghfields/rpooler/pull/29.patch","issue_url":"https://api.github.com/repos/ghfields/rpooler/issues/29","number":29,"state":"open","locked":false,"title":"Slightly enhance README ","user":{"login":"ThomDietrich","id":2870104,"node_id":"MDQ6VXNlcjI4NzAxMDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2870104?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomDietrich","html_url":"https://github.com/ThomDietrich","followers_url":"https://api.github.com/users/ThomDietrich/followers","following_url":"https://api.github.com/users/ThomDietrich/following{/other_user}","gists_url":"https://api.github.com/users/ThomDietrich/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomDietrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomDietrich/subscriptions","organizations_url":"https://api.github.com/users/ThomDietrich/orgs","repos_url":"https://api.github.com/users/ThomDietrich/repos","events_url":"https://api.github.com/users/ThomDietrich/events{/privacy}","received_events_url":"https://api.github.com/users/ThomDietrich/received_events","type":"User","site_admin":false},"body":"Just some small things that came to my mind when checking your repo 👋 ","created_at":"2018-12-20T16:23:29Z","updated_at":"2018-12-20T20:41:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ea328c6559d5918bbe62d25230e73be03d1cebf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ghfields/rpooler/pulls/29/commits","review_comments_url":"https://api.github.com/repos/ghfields/rpooler/pulls/29/comments","review_comment_url":"https://api.github.com/repos/ghfields/rpooler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ghfields/rpooler/issues/29/comments","statuses_url":"https://api.github.com/repos/ghfields/rpooler/statuses/398353f596fc2c3eea60146bf51273a1a461dced","head":{"label":"ThomDietrich:patch-1","ref":"patch-1","sha":"398353f596fc2c3eea60146bf51273a1a461dced","user":{"login":"ThomDietrich","id":2870104,"node_id":"MDQ6VXNlcjI4NzAxMDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2870104?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomDietrich","html_url":"https://github.com/ThomDietrich","followers_url":"https://api.github.com/users/ThomDietrich/followers","following_url":"https://api.github.com/users/ThomDietrich/following{/other_user}","gists_url":"https://api.github.com/users/ThomDietrich/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomDietrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomDietrich/subscriptions","organizations_url":"https://api.github.com/users/ThomDietrich/orgs","repos_url":"https://api.github.com/users/ThomDietrich/repos","events_url":"https://api.github.com/users/ThomDietrich/events{/privacy}","received_events_url":"https://api.github.com/users/ThomDietrich/received_events","type":"User","site_admin":false},"repo":{"id":162603795,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI2MDM3OTU=","name":"rpooler","full_name":"ThomDietrich/rpooler","private":false,"owner":{"login":"ThomDietrich","id":2870104,"node_id":"MDQ6VXNlcjI4NzAxMDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2870104?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomDietrich","html_url":"https://github.com/ThomDietrich","followers_url":"https://api.github.com/users/ThomDietrich/followers","following_url":"https://api.github.com/users/ThomDietrich/following{/other_user}","gists_url":"https://api.github.com/users/ThomDietrich/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomDietrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomDietrich/subscriptions","organizations_url":"https://api.github.com/users/ThomDietrich/orgs","repos_url":"https://api.github.com/users/ThomDietrich/repos","events_url":"https://api.github.com/users/ThomDietrich/events{/privacy}","received_events_url":"https://api.github.com/users/ThomDietrich/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ThomDietrich/rpooler","description":"A guided installation script for zfs rpools","fork":true,"url":"https://api.github.com/repos/ThomDietrich/rpooler","forks_url":"https://api.github.com/repos/ThomDietrich/rpooler/forks","keys_url":"https://api.github.com/repos/ThomDietrich/rpooler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ThomDietrich/rpooler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ThomDietrich/rpooler/teams","hooks_url":"https://api.github.com/repos/ThomDietrich/rpooler/hooks","issue_events_url":"https://api.github.com/repos/ThomDietrich/rpooler/issues/events{/number}","events_url":"https://api.github.com/repos/ThomDietrich/rpooler/events","assignees_url":"https://api.github.com/repos/ThomDietrich/rpooler/assignees{/user}","branches_url":"https://api.github.com/repos/ThomDietrich/rpooler/branches{/branch}","tags_url":"https://api.github.com/repos/ThomDietrich/rpooler/tags","blobs_url":"https://api.github.com/repos/ThomDietrich/rpooler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ThomDietrich/rpooler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ThomDietrich/rpooler/git/refs{/sha}","trees_url":"https://api.github.com/repos/ThomDietrich/rpooler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ThomDietrich/rpooler/statuses/{sha}","languages_url":"https://api.github.com/repos/ThomDietrich/rpooler/languages","stargazers_url":"https://api.github.com/repos/ThomDietrich/rpooler/stargazers","contributors_url":"https://api.github.com/repos/ThomDietrich/rpooler/contributors","subscribers_url":"https://api.github.com/repos/ThomDietrich/rpooler/subscribers","subscription_url":"https://api.github.com/repos/ThomDietrich/rpooler/subscription","commits_url":"https://api.github.com/repos/ThomDietrich/rpooler/commits{/sha}","git_commits_url":"https://api.github.com/repos/ThomDietrich/rpooler/git/commits{/sha}","comments_url":"https://api.github.com/repos/ThomDietrich/rpooler/comments{/number}","issue_comment_url":"https://api.github.com/repos/ThomDietrich/rpooler/issues/comments{/number}","contents_url":"https://api.github.com/repos/ThomDietrich/rpooler/contents/{+path}","compare_url":"https://api.github.com/repos/ThomDietrich/rpooler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ThomDietrich/rpooler/merges","archive_url":"https://api.github.com/repos/ThomDietrich/rpooler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ThomDietrich/rpooler/downloads","issues_url":"https://api.github.com/repos/ThomDietrich/rpooler/issues{/number}","pulls_url":"https://api.github.com/repos/ThomDietrich/rpooler/pulls{/number}","milestones_url":"https://api.github.com/repos/ThomDietrich/rpooler/milestones{/number}","notifications_url":"https://api.github.com/repos/ThomDietrich/rpooler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ThomDietrich/rpooler/labels{/name}","releases_url":"https://api.github.com/repos/ThomDietrich/rpooler/releases{/id}","deployments_url":"https://api.github.com/repos/ThomDietrich/rpooler/deployments","created_at":"2018-12-20T16:20:52Z","updated_at":"2018-12-20T16:20:55Z","pushed_at":"2018-12-20T16:22:35Z","git_url":"git://github.com/ThomDietrich/rpooler.git","ssh_url":"git@github.com:ThomDietrich/rpooler.git","clone_url":"https://github.com/ThomDietrich/rpooler.git","svn_url":"https://github.com/ThomDietrich/rpooler","homepage":"","size":42,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ghfields:master","ref":"master","sha":"4d7154a8e00ddc60b3856d2caad631cceaec2b7d","user":{"login":"ghfields","id":6624423,"node_id":"MDQ6VXNlcjY2MjQ0MjM=","avatar_url":"https://avatars3.githubusercontent.com/u/6624423?v=4","gravatar_id":"","url":"https://api.github.com/users/ghfields","html_url":"https://github.com/ghfields","followers_url":"https://api.github.com/users/ghfields/followers","following_url":"https://api.github.com/users/ghfields/following{/other_user}","gists_url":"https://api.github.com/users/ghfields/gists{/gist_id}","starred_url":"https://api.github.com/users/ghfields/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghfields/subscriptions","organizations_url":"https://api.github.com/users/ghfields/orgs","repos_url":"https://api.github.com/users/ghfields/repos","events_url":"https://api.github.com/users/ghfields/events{/privacy}","received_events_url":"https://api.github.com/users/ghfields/received_events","type":"User","site_admin":false},"repo":{"id":133702648,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM3MDI2NDg=","name":"rpooler","full_name":"ghfields/rpooler","private":false,"owner":{"login":"ghfields","id":6624423,"node_id":"MDQ6VXNlcjY2MjQ0MjM=","avatar_url":"https://avatars3.githubusercontent.com/u/6624423?v=4","gravatar_id":"","url":"https://api.github.com/users/ghfields","html_url":"https://github.com/ghfields","followers_url":"https://api.github.com/users/ghfields/followers","following_url":"https://api.github.com/users/ghfields/following{/other_user}","gists_url":"https://api.github.com/users/ghfields/gists{/gist_id}","starred_url":"https://api.github.com/users/ghfields/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghfields/subscriptions","organizations_url":"https://api.github.com/users/ghfields/orgs","repos_url":"https://api.github.com/users/ghfields/repos","events_url":"https://api.github.com/users/ghfields/events{/privacy}","received_events_url":"https://api.github.com/users/ghfields/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ghfields/rpooler","description":"A guided installation script for zfs rpools","fork":false,"url":"https://api.github.com/repos/ghfields/rpooler","forks_url":"https://api.github.com/repos/ghfields/rpooler/forks","keys_url":"https://api.github.com/repos/ghfields/rpooler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ghfields/rpooler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ghfields/rpooler/teams","hooks_url":"https://api.github.com/repos/ghfields/rpooler/hooks","issue_events_url":"https://api.github.com/repos/ghfields/rpooler/issues/events{/number}","events_url":"https://api.github.com/repos/ghfields/rpooler/events","assignees_url":"https://api.github.com/repos/ghfields/rpooler/assignees{/user}","branches_url":"https://api.github.com/repos/ghfields/rpooler/branches{/branch}","tags_url":"https://api.github.com/repos/ghfields/rpooler/tags","blobs_url":"https://api.github.com/repos/ghfields/rpooler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ghfields/rpooler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ghfields/rpooler/git/refs{/sha}","trees_url":"https://api.github.com/repos/ghfields/rpooler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ghfields/rpooler/statuses/{sha}","languages_url":"https://api.github.com/repos/ghfields/rpooler/languages","stargazers_url":"https://api.github.com/repos/ghfields/rpooler/stargazers","contributors_url":"https://api.github.com/repos/ghfields/rpooler/contributors","subscribers_url":"https://api.github.com/repos/ghfields/rpooler/subscribers","subscription_url":"https://api.github.com/repos/ghfields/rpooler/subscription","commits_url":"https://api.github.com/repos/ghfields/rpooler/commits{/sha}","git_commits_url":"https://api.github.com/repos/ghfields/rpooler/git/commits{/sha}","comments_url":"https://api.github.com/repos/ghfields/rpooler/comments{/number}","issue_comment_url":"https://api.github.com/repos/ghfields/rpooler/issues/comments{/number}","contents_url":"https://api.github.com/repos/ghfields/rpooler/contents/{+path}","compare_url":"https://api.github.com/repos/ghfields/rpooler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ghfields/rpooler/merges","archive_url":"https://api.github.com/repos/ghfields/rpooler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ghfields/rpooler/downloads","issues_url":"https://api.github.com/repos/ghfields/rpooler/issues{/number}","pulls_url":"https://api.github.com/repos/ghfields/rpooler/pulls{/number}","milestones_url":"https://api.github.com/repos/ghfields/rpooler/milestones{/number}","notifications_url":"https://api.github.com/repos/ghfields/rpooler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ghfields/rpooler/labels{/name}","releases_url":"https://api.github.com/repos/ghfields/rpooler/releases{/id}","deployments_url":"https://api.github.com/repos/ghfields/rpooler/deployments","created_at":"2018-05-16T17:38:25Z","updated_at":"2018-12-20T16:19:37Z","pushed_at":"2018-12-20T16:23:29Z","git_url":"git://github.com/ghfields/rpooler.git","ssh_url":"git@github.com:ghfields/rpooler.git","clone_url":"https://github.com/ghfields/rpooler.git","svn_url":"https://github.com/ghfields/rpooler","homepage":"","size":40,"stargazers_count":10,"watchers_count":10,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":1,"open_issues":13,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ghfields/rpooler/pulls/29"},"html":{"href":"https://github.com/ghfields/rpooler/pull/29"},"issue":{"href":"https://api.github.com/repos/ghfields/rpooler/issues/29"},"comments":{"href":"https://api.github.com/repos/ghfields/rpooler/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/ghfields/rpooler/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/ghfields/rpooler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ghfields/rpooler/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/ghfields/rpooler/statuses/398353f596fc2c3eea60146bf51273a1a461dced"}},"author_association":"NONE"}}
{"actor":{"display_login":"ghfields"}}