{"action":"created","comment":{"url":"https://api.github.com/repos/pcdshub/lightpath/pulls/comments/203913234","pull_request_review_id":138899324,"id":203913234,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzkxMzIzNA==","diff_hunk":"@@ -1,14 +1,18 @@\n \"\"\"\n Full Application for Lightpath\n \"\"\"\n+from functools import partial\n import logging\n import threading\n import os.path\n \n+import numpy as np\n+from pcdsdevices.device_types import *  # noqa","path":"lightpath/ui/gui.py","position":10,"original_position":10,"commit_id":"03765d684bca04068d8ae94088e968f54383456f","original_commit_id":"03765d684bca04068d8ae94088e968f54383456f","user":{"login":"ZLLentz","id":10647860,"node_id":"MDQ6VXNlcjEwNjQ3ODYw","avatar_url":"https://avatars3.githubusercontent.com/u/10647860?v=4","gravatar_id":"","url":"https://api.github.com/users/ZLLentz","html_url":"https://github.com/ZLLentz","followers_url":"https://api.github.com/users/ZLLentz/followers","following_url":"https://api.github.com/users/ZLLentz/following{/other_user}","gists_url":"https://api.github.com/users/ZLLentz/gists{/gist_id}","starred_url":"https://api.github.com/users/ZLLentz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZLLentz/subscriptions","organizations_url":"https://api.github.com/users/ZLLentz/orgs","repos_url":"https://api.github.com/users/ZLLentz/repos","events_url":"https://api.github.com/users/ZLLentz/events{/privacy}","received_events_url":"https://api.github.com/users/ZLLentz/received_events","type":"User","site_admin":false},"body":"`*` imports are the devil, but we'll let it slide... though it's odd to have style rules that get dumped when it's convenient.","created_at":"2018-07-20T00:45:54Z","updated_at":"2018-07-20T00:47:43Z","html_url":"https://github.com/pcdshub/lightpath/pull/76#discussion_r203913234","pull_request_url":"https://api.github.com/repos/pcdshub/lightpath/pulls/76","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pcdshub/lightpath/pulls/comments/203913234"},"html":{"href":"https://github.com/pcdshub/lightpath/pull/76#discussion_r203913234"},"pull_request":{"href":"https://api.github.com/repos/pcdshub/lightpath/pulls/76"}}},"pull_request":{"url":"https://api.github.com/repos/pcdshub/lightpath/pulls/76","id":202709576,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNzA5NTc2","html_url":"https://github.com/pcdshub/lightpath/pull/76","diff_url":"https://github.com/pcdshub/lightpath/pull/76.diff","patch_url":"https://github.com/pcdshub/lightpath/pull/76.patch","issue_url":"https://api.github.com/repos/pcdshub/lightpath/issues/76","number":76,"state":"open","locked":false,"title":"ENH: Filter Options","user":{"login":"teddyrendahl","id":25753048,"node_id":"MDQ6VXNlcjI1NzUzMDQ4","avatar_url":"https://avatars3.githubusercontent.com/u/25753048?v=4","gravatar_id":"","url":"https://api.github.com/users/teddyrendahl","html_url":"https://github.com/teddyrendahl","followers_url":"https://api.github.com/users/teddyrendahl/followers","following_url":"https://api.github.com/users/teddyrendahl/following{/other_user}","gists_url":"https://api.github.com/users/teddyrendahl/gists{/gist_id}","starred_url":"https://api.github.com/users/teddyrendahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teddyrendahl/subscriptions","organizations_url":"https://api.github.com/users/teddyrendahl/orgs","repos_url":"https://api.github.com/users/teddyrendahl/repos","events_url":"https://api.github.com/users/teddyrendahl/events{/privacy}","received_events_url":"https://api.github.com/users/teddyrendahl/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nA bunch of helpful navigation widget options. You can now:\r\n* Force scroll to an arbitrary device\r\n* Force scroll to the most upstream blocking device\r\n* Hide devices that are removed from the beam\r\n* Hide devices based on their class\r\n\r\nI also implemented the `upstream` filter in the more general structure now. This means we **only** disconnect / reconnect to widgets when we switch beamlines. Avoid loading the entire beampath whenever possible!\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\nCloses #73 \r\nCloses #67 \r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nAdded tests for all new functions\r\n\r\n## Screenshots (if appropriate):\r\n<img width=\"1233\" alt=\"screen shot 2018-07-19 at 4 26 01 pm\" src=\"https://user-images.githubusercontent.com/25753048/42975335-7881e576-8b70-11e8-93fa-c5bd92a41836.png\">\r\n","created_at":"2018-07-19T23:26:31Z","updated_at":"2018-07-20T00:47:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ee9ba54edd3b8b00c153450dc566242e436c1f8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pcdshub/lightpath/pulls/76/commits","review_comments_url":"https://api.github.com/repos/pcdshub/lightpath/pulls/76/comments","review_comment_url":"https://api.github.com/repos/pcdshub/lightpath/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pcdshub/lightpath/issues/76/comments","statuses_url":"https://api.github.com/repos/pcdshub/lightpath/statuses/03765d684bca04068d8ae94088e968f54383456f","head":{"label":"teddyrendahl:filter","ref":"filter","sha":"03765d684bca04068d8ae94088e968f54383456f","user":{"login":"teddyrendahl","id":25753048,"node_id":"MDQ6VXNlcjI1NzUzMDQ4","avatar_url":"https://avatars3.githubusercontent.com/u/25753048?v=4","gravatar_id":"","url":"https://api.github.com/users/teddyrendahl","html_url":"https://github.com/teddyrendahl","followers_url":"https://api.github.com/users/teddyrendahl/followers","following_url":"https://api.github.com/users/teddyrendahl/following{/other_user}","gists_url":"https://api.github.com/users/teddyrendahl/gists{/gist_id}","starred_url":"https://api.github.com/users/teddyrendahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teddyrendahl/subscriptions","organizations_url":"https://api.github.com/users/teddyrendahl/orgs","repos_url":"https://api.github.com/users/teddyrendahl/repos","events_url":"https://api.github.com/users/teddyrendahl/events{/privacy}","received_events_url":"https://api.github.com/users/teddyrendahl/received_events","type":"User","site_admin":false},"repo":{"id":105712276,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU3MTIyNzY=","name":"lightpath","full_name":"teddyrendahl/lightpath","owner":{"login":"teddyrendahl","id":25753048,"node_id":"MDQ6VXNlcjI1NzUzMDQ4","avatar_url":"https://avatars3.githubusercontent.com/u/25753048?v=4","gravatar_id":"","url":"https://api.github.com/users/teddyrendahl","html_url":"https://github.com/teddyrendahl","followers_url":"https://api.github.com/users/teddyrendahl/followers","following_url":"https://api.github.com/users/teddyrendahl/following{/other_user}","gists_url":"https://api.github.com/users/teddyrendahl/gists{/gist_id}","starred_url":"https://api.github.com/users/teddyrendahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teddyrendahl/subscriptions","organizations_url":"https://api.github.com/users/teddyrendahl/orgs","repos_url":"https://api.github.com/users/teddyrendahl/repos","events_url":"https://api.github.com/users/teddyrendahl/events{/privacy}","received_events_url":"https://api.github.com/users/teddyrendahl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/teddyrendahl/lightpath","description":"LCLS Lightpath Module","fork":true,"url":"https://api.github.com/repos/teddyrendahl/lightpath","forks_url":"https://api.github.com/repos/teddyrendahl/lightpath/forks","keys_url":"https://api.github.com/repos/teddyrendahl/lightpath/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teddyrendahl/lightpath/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teddyrendahl/lightpath/teams","hooks_url":"https://api.github.com/repos/teddyrendahl/lightpath/hooks","issue_events_url":"https://api.github.com/repos/teddyrendahl/lightpath/issues/events{/number}","events_url":"https://api.github.com/repos/teddyrendahl/lightpath/events","assignees_url":"https://api.github.com/repos/teddyrendahl/lightpath/assignees{/user}","branches_url":"https://api.github.com/repos/teddyrendahl/lightpath/branches{/branch}","tags_url":"https://api.github.com/repos/teddyrendahl/lightpath/tags","blobs_url":"https://api.github.com/repos/teddyrendahl/lightpath/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teddyrendahl/lightpath/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teddyrendahl/lightpath/git/refs{/sha}","trees_url":"https://api.github.com/repos/teddyrendahl/lightpath/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teddyrendahl/lightpath/statuses/{sha}","languages_url":"https://api.github.com/repos/teddyrendahl/lightpath/languages","stargazers_url":"https://api.github.com/repos/teddyrendahl/lightpath/stargazers","contributors_url":"https://api.github.com/repos/teddyrendahl/lightpath/contributors","subscribers_url":"https://api.github.com/repos/teddyrendahl/lightpath/subscribers","subscription_url":"https://api.github.com/repos/teddyrendahl/lightpath/subscription","commits_url":"https://api.github.com/repos/teddyrendahl/lightpath/commits{/sha}","git_commits_url":"https://api.github.com/repos/teddyrendahl/lightpath/git/commits{/sha}","comments_url":"https://api.github.com/repos/teddyrendahl/lightpath/comments{/number}","issue_comment_url":"https://api.github.com/repos/teddyrendahl/lightpath/issues/comments{/number}","contents_url":"https://api.github.com/repos/teddyrendahl/lightpath/contents/{+path}","compare_url":"https://api.github.com/repos/teddyrendahl/lightpath/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teddyrendahl/lightpath/merges","archive_url":"https://api.github.com/repos/teddyrendahl/lightpath/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teddyrendahl/lightpath/downloads","issues_url":"https://api.github.com/repos/teddyrendahl/lightpath/issues{/number}","pulls_url":"https://api.github.com/repos/teddyrendahl/lightpath/pulls{/number}","milestones_url":"https://api.github.com/repos/teddyrendahl/lightpath/milestones{/number}","notifications_url":"https://api.github.com/repos/teddyrendahl/lightpath/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teddyrendahl/lightpath/labels{/name}","releases_url":"https://api.github.com/repos/teddyrendahl/lightpath/releases{/id}","deployments_url":"https://api.github.com/repos/teddyrendahl/lightpath/deployments","created_at":"2017-10-03T23:00:59Z","updated_at":"2018-07-17T23:58:30Z","pushed_at":"2018-07-19T23:18:37Z","git_url":"git://github.com/teddyrendahl/lightpath.git","ssh_url":"git@github.com:teddyrendahl/lightpath.git","clone_url":"https://github.com/teddyrendahl/lightpath.git","svn_url":"https://github.com/teddyrendahl/lightpath","homepage":"https://pswww.slac.stanford.edu/swdoc/releases/lightpath/current/","size":336,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pcdshub:master","ref":"master","sha":"3413dd58f6c3f145622eb51f19bff8716153e870","user":{"login":"pcdshub","id":31903189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTAzMTg5","avatar_url":"https://avatars1.githubusercontent.com/u/31903189?v=4","gravatar_id":"","url":"https://api.github.com/users/pcdshub","html_url":"https://github.com/pcdshub","followers_url":"https://api.github.com/users/pcdshub/followers","following_url":"https://api.github.com/users/pcdshub/following{/other_user}","gists_url":"https://api.github.com/users/pcdshub/gists{/gist_id}","starred_url":"https://api.github.com/users/pcdshub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcdshub/subscriptions","organizations_url":"https://api.github.com/users/pcdshub/orgs","repos_url":"https://api.github.com/users/pcdshub/repos","events_url":"https://api.github.com/users/pcdshub/events{/privacy}","received_events_url":"https://api.github.com/users/pcdshub/received_events","type":"Organization","site_admin":false},"repo":{"id":85119571,"node_id":"MDEwOlJlcG9zaXRvcnk4NTExOTU3MQ==","name":"lightpath","full_name":"pcdshub/lightpath","owner":{"login":"pcdshub","id":31903189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTAzMTg5","avatar_url":"https://avatars1.githubusercontent.com/u/31903189?v=4","gravatar_id":"","url":"https://api.github.com/users/pcdshub","html_url":"https://github.com/pcdshub","followers_url":"https://api.github.com/users/pcdshub/followers","following_url":"https://api.github.com/users/pcdshub/following{/other_user}","gists_url":"https://api.github.com/users/pcdshub/gists{/gist_id}","starred_url":"https://api.github.com/users/pcdshub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcdshub/subscriptions","organizations_url":"https://api.github.com/users/pcdshub/orgs","repos_url":"https://api.github.com/users/pcdshub/repos","events_url":"https://api.github.com/users/pcdshub/events{/privacy}","received_events_url":"https://api.github.com/users/pcdshub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pcdshub/lightpath","description":"LCLS Lightpath Module","fork":false,"url":"https://api.github.com/repos/pcdshub/lightpath","forks_url":"https://api.github.com/repos/pcdshub/lightpath/forks","keys_url":"https://api.github.com/repos/pcdshub/lightpath/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pcdshub/lightpath/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pcdshub/lightpath/teams","hooks_url":"https://api.github.com/repos/pcdshub/lightpath/hooks","issue_events_url":"https://api.github.com/repos/pcdshub/lightpath/issues/events{/number}","events_url":"https://api.github.com/repos/pcdshub/lightpath/events","assignees_url":"https://api.github.com/repos/pcdshub/lightpath/assignees{/user}","branches_url":"https://api.github.com/repos/pcdshub/lightpath/branches{/branch}","tags_url":"https://api.github.com/repos/pcdshub/lightpath/tags","blobs_url":"https://api.github.com/repos/pcdshub/lightpath/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pcdshub/lightpath/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pcdshub/lightpath/git/refs{/sha}","trees_url":"https://api.github.com/repos/pcdshub/lightpath/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pcdshub/lightpath/statuses/{sha}","languages_url":"https://api.github.com/repos/pcdshub/lightpath/languages","stargazers_url":"https://api.github.com/repos/pcdshub/lightpath/stargazers","contributors_url":"https://api.github.com/repos/pcdshub/lightpath/contributors","subscribers_url":"https://api.github.com/repos/pcdshub/lightpath/subscribers","subscription_url":"https://api.github.com/repos/pcdshub/lightpath/subscription","commits_url":"https://api.github.com/repos/pcdshub/lightpath/commits{/sha}","git_commits_url":"https://api.github.com/repos/pcdshub/lightpath/git/commits{/sha}","comments_url":"https://api.github.com/repos/pcdshub/lightpath/comments{/number}","issue_comment_url":"https://api.github.com/repos/pcdshub/lightpath/issues/comments{/number}","contents_url":"https://api.github.com/repos/pcdshub/lightpath/contents/{+path}","compare_url":"https://api.github.com/repos/pcdshub/lightpath/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pcdshub/lightpath/merges","archive_url":"https://api.github.com/repos/pcdshub/lightpath/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pcdshub/lightpath/downloads","issues_url":"https://api.github.com/repos/pcdshub/lightpath/issues{/number}","pulls_url":"https://api.github.com/repos/pcdshub/lightpath/pulls{/number}","milestones_url":"https://api.github.com/repos/pcdshub/lightpath/milestones{/number}","notifications_url":"https://api.github.com/repos/pcdshub/lightpath/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pcdshub/lightpath/labels{/name}","releases_url":"https://api.github.com/repos/pcdshub/lightpath/releases{/id}","deployments_url":"https://api.github.com/repos/pcdshub/lightpath/deployments","created_at":"2017-03-15T20:50:02Z","updated_at":"2018-07-18T22:55:30Z","pushed_at":"2018-07-19T23:26:32Z","git_url":"git://github.com/pcdshub/lightpath.git","ssh_url":"git@github.com:pcdshub/lightpath.git","clone_url":"https://github.com/pcdshub/lightpath.git","svn_url":"https://github.com/pcdshub/lightpath","homepage":"https://pcdshub.github.io/lightpath","size":7353,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":13,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pcdshub/lightpath/pulls/76"},"html":{"href":"https://github.com/pcdshub/lightpath/pull/76"},"issue":{"href":"https://api.github.com/repos/pcdshub/lightpath/issues/76"},"comments":{"href":"https://api.github.com/repos/pcdshub/lightpath/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/pcdshub/lightpath/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/pcdshub/lightpath/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pcdshub/lightpath/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/pcdshub/lightpath/statuses/03765d684bca04068d8ae94088e968f54383456f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ZLLentz"}}