{"push_id":2647717206,"size":31,"distinct_size":1,"ref":"refs/heads/c3d-build","head":"b046958599f10ade6355f8e778a7046a74578ec9","before":"1c55ac7ef41e15bed53a3f4238e431bddedb9123","commits":[{"sha":"d567bfe65f010556f12c7ca5e95d0e480b2e4a70","author":{"name":"Victor Toso","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@victortoso.com"},"message":"spice-widget: fix leak of boxed type cursor-shape\n\nDetected while testing valgrind on migration.\n\n> malloc (vg_replace_malloc.c:299)\n> g_malloc (in /usr/lib/libglib-2.0.so.0.5400.3)\n> spice_cursor_shape_copy (channel-cursor.c:99)\n> ??? (in /usr/lib/libgobject-2.0.so.0.5400.3)\n> g_object_get_valist (in /usr/lib/libgobject-2.0.so.0.5400.3)\n> g_object_get (in /usr/lib/libgobject-2.0.so.0.5400.3)\n> cursor_set (spice-widget.c:2653)\n> g_closure_invoke (in /usr/lib/libgobject-2.0.so.0.5400.3)\n> ??? (in /usr/lib/libgobject-2.0.so.0.5400.3)\n> g_signal_emit_valist (in /usr/lib/libgobject-2.0.so.0.5400.3)\n> g_signal_emit (in /usr/lib/libgobject-2.0.so.0.5400.3)\n> ??? (in /usr/lib/libgobject-2.0.so.0.5400.3)\n\nSigned-off-by: Victor Toso <victortoso@redhat.com>\nAcked-by: Frediano Ziglio <fziglio@redhat.com>","distinct":false,"url":"https://api.github.com/repos/c3d/spice-gtk/commits/d567bfe65f010556f12c7ca5e95d0e480b2e4a70"},{"sha":"a562aca77f6c7da753a299fd882411a41d37350f","author":{"name":"Victor Toso","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@victortoso.com"},"message":"spice-widget: fix leak of boxed type cursor-shape\n\nNo valgrind on this one but a leak similar to previous patch.\nThis one was introduced in e691954be459087\n\nSigned-off-by: Victor Toso <victortoso@redhat.com>\nAcked-by: Frediano Ziglio <fziglio@redhat.com>","distinct":false,"url":"https://api.github.com/repos/c3d/spice-gtk/commits/a562aca77f6c7da753a299fd882411a41d37350f"},{"sha":"bdd36be801288e669ce4c7012991522c208d70a5","author":{"name":"Victor Toso","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@victortoso.com"},"message":"channel-display: remove id parameter from helper function\n\nInstead of passing the id parameter for destroy_display_stream() which\nis only used for debug, let's store the id when creating the stream at\ndisplay_stream_create().\n\nWith the removal of Id parameter, we are using a gpointer for\ndisplay_stream struct to comply with GDestroyNotify type and use this,\nfor instance in g_clear_pointer() without warnings.\n\nBenefits of this patch:\n* We can drop a helper function in a follow up patch;\n* Function is now a GDestroyNotify type;\n\nSigned-off-by: Victor Toso <victortoso@redhat.com>\nAcked-by: Frediano Ziglio <fziglio@redhat.com>","distinct":false,"url":"https://api.github.com/repos/c3d/spice-gtk/commits/bdd36be801288e669ce4c7012991522c208d70a5"},{"sha":"d2790c0aef8085511e501643c69490c11c9d19bc","author":{"name":"Victor Toso","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@victortoso.com"},"message":"channel-display: rename display_stream_destroy()\n\nThis patch renames destroy_display_stream() to\ndisplay_stream_destroy() to keep compatibility with\ndisplay_stream_create()\n\nSigned-off-by: Victor Toso <victortoso@redhat.com>\nAcked-by: Frediano Ziglio <fziglio@redhat.com>","distinct":false,"url":"https://api.github.com/repos/c3d/spice-gtk/commits/d2790c0aef8085511e501643c69490c11c9d19bc"},{"sha":"cf5e5e3e53e74f495478f2cb7bf3a731bbcd7117","author":{"name":"Victor Toso","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@victortoso.com"},"message":"channel-display: remove unneeded function\n\nThe get_stream_id_by_stream() was introduced in 141c2d82 to debug\nGStreamer's pipeline. But with previous patch, we are moving the ID to\nthe display_stream structure and can be accessible directly.\n\nSigned-off-by: Victor Toso <victortoso@redhat.com>\nAcked-by: Frediano Ziglio <fziglio@redhat.com>","distinct":false,"url":"https://api.github.com/repos/c3d/spice-gtk/commits/cf5e5e3e53e74f495478f2cb7bf3a731bbcd7117"},{"sha":"f94f0012b8cd2c69e8e06de44dd2a7a7d9bf7428","author":{"name":"Frediano Ziglio","email":"55d48b080b2e443e395cde84d2c83b135a4ff48e@redhat.com"},"message":"spice-channel: Disable TLS v1.0\n\nTLS v1.0 is now considered insecure.\nThe protocol is already disabled on the server side (cfr commit commit\nfac12737d \"reds: Disable TLS 1.0\").\nTo avoid downgrade attacks disable it even on the client.\n\nRelated: https://bugzilla.redhat.com/show_bug.cgi?id=1521053\n\nSigned-off-by: Frediano Ziglio <fziglio@redhat.com>\nAcked-by: Victor Toso <victortoso@redhat.com>","distinct":false,"url":"https://api.github.com/repos/c3d/spice-gtk/commits/f94f0012b8cd2c69e8e06de44dd2a7a7d9bf7428"},{"sha":"070dea03c1d688c7fc87659a05c18c0a43160660","author":{"name":"Frediano Ziglio","email":"55d48b080b2e443e395cde84d2c83b135a4ff48e@redhat.com"},"message":"gio-coroutine: Fix C inheritance\n\nGConditionWaitSource should inherit from GSource so GSource\nshould be the first field.\n\nGSource is\nstruct _GSource\n{\n  /*< private >*/\n  gpointer callback_data;\n  ...\n};\n\nWith GSource being opaque, the only thing which could cause issues\nwas modifying GConditionWaitSource::self.\nHowever, GConditionWaitSource::self is precisely what we use as\ncallback_data, and anyway the GSource probably sets callback_data after\nspice-gtk set GConditiionWaitSource::self. So this ends up all working\neven though this is wrong.\n\nSigned-off-by: Frediano Ziglio <fziglio@redhat.com>\nAcked-by: Christophe Fergeau <cfergeau@redhat.com>","distinct":false,"url":"https://api.github.com/repos/c3d/spice-gtk/commits/070dea03c1d688c7fc87659a05c18c0a43160660"},{"sha":"5f3e58035f752b83a8102921ce43ac8217bbb98e","author":{"name":"Frediano Ziglio","email":"55d48b080b2e443e395cde84d2c83b135a4ff48e@redhat.com"},"message":"gio-coroutine: Make waitFuncs static\n\nSigned-off-by: Frediano Ziglio <fziglio@redhat.com>\nAcked-by: Christophe Fergeau <cfergeau@redhat.com>","distinct":false,"url":"https://api.github.com/repos/c3d/spice-gtk/commits/5f3e58035f752b83a8102921ce43ac8217bbb98e"},{"sha":"46d78d3ebe988a7c2ba21ebf678d9c2f20587c2d","author":{"name":"Frediano Ziglio","email":"55d48b080b2e443e395cde84d2c83b135a4ff48e@redhat.com"},"message":"gio-coroutine: Remove only assigned self field\n\nSigned-off-by: Frediano Ziglio <fziglio@redhat.com>\nAcked-by: Christophe Fergeau <cfergeau@redhat.com>","distinct":false,"url":"https://api.github.com/repos/c3d/spice-gtk/commits/46d78d3ebe988a7c2ba21ebf678d9c2f20587c2d"},{"sha":"761c200f130a78d62fe78cc329e90d2dba8cdebc","author":{"name":"Frediano Ziglio","email":"55d48b080b2e443e395cde84d2c83b135a4ff48e@redhat.com"},"message":"channel-display: Update debug message\n\nThe flags field in SpiceMsgSurfaceCreate does not only contains\nthe primary flag.\n\nSigned-off-by: Frediano Ziglio <fziglio@redhat.com>\nAcked-by: Christophe Fergeau <cfergeau@redhat.com>","distinct":false,"url":"https://api.github.com/repos/c3d/spice-gtk/commits/761c200f130a78d62fe78cc329e90d2dba8cdebc"},{"sha":"39c61d4a998f17e36240a321a3f92ecb1d5ef0c1","author":{"name":"Frediano Ziglio","email":"55d48b080b2e443e395cde84d2c83b135a4ff48e@redhat.com"},"message":"channel-display-gst: Reduce contention on queues_mutex\n\nWe don't need to lock the entire queues to create a frame.\n\nSigned-off-by: Frediano Ziglio <fziglio@redhat.com>\nAcked-by: Snir Sheriber <ssheribe@redhat.com>","distinct":false,"url":"https://api.github.com/repos/c3d/spice-gtk/commits/39c61d4a998f17e36240a321a3f92ecb1d5ef0c1"},{"sha":"04db3a9b79e243e5bd9e193007c046b9e4c88e52","author":{"name":"Frediano Ziglio","email":"55d48b080b2e443e395cde84d2c83b135a4ff48e@redhat.com"},"message":"spice-channel: Make some conditional code more readable\n\nAvoid confusing indentation.\n\nSigned-off-by: Frediano Ziglio <fziglio@redhat.com>\nAcked-by: Snir Sheriber <ssheribe@redhat.com>","distinct":false,"url":"https://api.github.com/repos/c3d/spice-gtk/commits/04db3a9b79e243e5bd9e193007c046b9e4c88e52"},{"sha":"463f62ff8c61337d12512032667ac37104d0e2bd","author":{"name":"Frediano Ziglio","email":"55d48b080b2e443e395cde84d2c83b135a4ff48e@redhat.com"},"message":"channel-display-gst: Protect timer_id with queue_mutex\n\ntimer_id is supposed to be protected by this mutex, make sure this\nis true in spice_gst_decoder_reschedule.\n\nSigned-off-by: Frediano Ziglio <fziglio@redhat.com>\nAcked-by: Snir Sheriber <ssheribe@redhat.com>","distinct":false,"url":"https://api.github.com/repos/c3d/spice-gtk/commits/463f62ff8c61337d12512032667ac37104d0e2bd"},{"sha":"60e40117f968adba1323d48b29fefea437795c52","author":{"name":"Eduardo Lima (Etrunko)","email":"025eb0974a9f48eaca88b86d8c2bcaf361e95a91@redhat.com"},"message":"build: Remove check for pnp.ids path\n\nThis looks like a leftover from the following commit, which removed the\nonly reference for this file.\n\ncommit 30986505ba6041c293c38cb4b7f4b618a59f4716\nAuthor: Marc-André Lureau <marcandre.lureau@redhat.com>\nDate:   Fri May 10 17:05:49 2013 +0200\n\n    Remove GnomeRR code\n\n    Changing client resolution is a bad idea, and never took up.\n    Remove some unmaintained experimental code.\n\nSigned-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>\nAcked-by: Victor Toso <victortoso@redhat.com>","distinct":false,"url":"https://api.github.com/repos/c3d/spice-gtk/commits/60e40117f968adba1323d48b29fefea437795c52"},{"sha":"c0770e0b77f1e05c0c7ac38d9d752300eb448e03","author":{"name":"Victor Toso","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@victortoso.com"},"message":"channel-display-mjpeg: remove verbose logs\n\nThose don't add any useful information.\n\nSigned-off-by: Victor Toso <victortoso@redhat.com>\nAcked-by: Frediano Ziglio <fziglio@redhat.com>","distinct":false,"url":"https://api.github.com/repos/c3d/spice-gtk/commits/c0770e0b77f1e05c0c7ac38d9d752300eb448e03"},{"sha":"03b829dd47368d1a1314abead70ccce4bee27bb3","author":{"name":"Victor Toso","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@victortoso.com"},"message":"channel-display: always name GHashFunc and GEqualFunc\n\ng_hash_table_new() allows to pass NULL for GHashFunc and GEqualFunc\nwhich defaults to g_direct_hash() and g_direct_equal().\n\nThis is the only place in our code that uses NULL while in\nchannel-main and channel-smartcard and spice-file-transfer-task we\nname it.\n\nChanging for consistency and clarity.\n\nSigned-off-by: Victor Toso <victortoso@redhat.com>\nAcked-by: Frediano Ziglio <fziglio@redhat.com>","distinct":false,"url":"https://api.github.com/repos/c3d/spice-gtk/commits/03b829dd47368d1a1314abead70ccce4bee27bb3"},{"sha":"e13ce2f68fa1967fcf6a7df5ade36de11ac09a44","author":{"name":"Frediano Ziglio","email":"55d48b080b2e443e395cde84d2c83b135a4ff48e@redhat.com"},"message":"spice-widget: Fix use after free\n\nBefore d567bfe65f010556f12c7ca5e95d0e480b2e4a70\n(\"spice-widget: fix leak of boxed type cursor-shape\") the cursor was\njust leaked. Now is freed however mouse_pixbuf points to cursor\ndata so when the cursor is freed mouse_pixbuf points to a dangling\npointer. Retain the cursor as long as mouse_pixbuf is live.\n\nSigned-off-by: Frediano Ziglio <fziglio@redhat.com>\nAcked-by: Victor Toso <victortoso@redhat.com>","distinct":false,"url":"https://api.github.com/repos/c3d/spice-gtk/commits/e13ce2f68fa1967fcf6a7df5ade36de11ac09a44"},{"sha":"a15deea3561f8382b2a16e8401ef8fb27408b4be","author":{"name":"Victor Toso","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@victortoso.com"},"message":"usb-device-widget: remove goto/label\n\nThe 'end' label is used only once and can be replaced by moving the\ncode into the existing 'if (!devices)'.\n\nFor convenience this patch also:\n* Explicit check against NULL\n* Added curly brackets to the moved 'for'\n* Moved variable 'i' to inner scope\n\nSigned-off-by: Victor Toso <victortoso@redhat.com>\nReviewed-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>\nAcked-by: Frediano Ziglio <fziglio@redhat.com>","distinct":false,"url":"https://api.github.com/repos/c3d/spice-gtk/commits/a15deea3561f8382b2a16e8401ef8fb27408b4be"},{"sha":"216065cc98eb12d4c71624f536034cd60d35c328","author":{"name":"Victor Toso","email":"b1c1d8736f20db3fb6c1c66bb1455ed43909f0d8@victortoso.com"},"message":"spice-widget: remove old warning\n\nThis log was introduced in 13f5ebbf07a3 to track the situation where\nthe GdkCursor pointer would be invalid/NULL. That was possible if the\ncaller passed a NULL for rgba pointer in cursor_set().\n\nCode has changed a bit since then, it isn't necessary to log a warn in\nthe unlikely event of cursor_shape being NULL.\n\nSigned-off-by: Victor Toso <victortoso@redhat.com>\nReported-by: Frediano Ziglio <fziglio@redhat.com>\nAcked-by: Frediano Ziglio <fziglio@redhat.com>","distinct":false,"url":"https://api.github.com/repos/c3d/spice-gtk/commits/216065cc98eb12d4c71624f536034cd60d35c328"},{"sha":"7d1197522f9debfe696187713b7955ec28b03118","author":{"name":"Eduardo Lima (Etrunko)","email":"025eb0974a9f48eaca88b86d8c2bcaf361e95a91@redhat.com"},"message":"tests: Shut up warnings about unitialized struct fields\n\nBuild complains about lots of unitialized fields in TestCase definition,\nfor instance:\n\n../tests/session.c:276:11: warning: missing initializer for field ‘message’ of ‘TestCase {aka const struct <anonymous>}’ [-Wmissing-field-initializers]\n           \"spice://[::192.9.5.5]:5910\" },\n           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~\n../tests/session.c:11:18: note: ‘message’ declared here\n     const gchar *message;\n                  ^~~~~~~\n../tests/session.c:282:11: warning: missing initializer for field ‘unix_path’ of ‘TestCase {aka const struct <anonymous>}’ [-Wmissing-field-initializers]\n           \"password may be visible in process listings\"},\n           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nSigned-off-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>\nAcked-by: Frediano Ziglio <fziglio@redhat.com>","distinct":false,"url":"https://api.github.com/repos/c3d/spice-gtk/commits/7d1197522f9debfe696187713b7955ec28b03118"}]}
{"actor":{"display_login":"c3d"}}