{"action":"created","comment":{"url":"https://api.github.com/repos/slashdev/arm-loconet-starter/pulls/comments/205738260","pull_request_review_id":141069248,"id":205738260,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTczODI2MA==","diff_hunk":"@@ -10,13 +10,13 @@\n  */\n \n #include \"loconet_rx.h\"\n+#include \"loconet_messages.h\"","path":"src/loconet/loconet_rx.c","position":4,"original_position":4,"commit_id":"6b9ebf36eb4be8d23bcada476f6365ee0101015f","original_commit_id":"6b9ebf36eb4be8d23bcada476f6365ee0101015f","user":{"login":"jmvdwerf","id":5417081,"node_id":"MDQ6VXNlcjU0MTcwODE=","avatar_url":"https://avatars0.githubusercontent.com/u/5417081?v=4","gravatar_id":"","url":"https://api.github.com/users/jmvdwerf","html_url":"https://github.com/jmvdwerf","followers_url":"https://api.github.com/users/jmvdwerf/followers","following_url":"https://api.github.com/users/jmvdwerf/following{/other_user}","gists_url":"https://api.github.com/users/jmvdwerf/gists{/gist_id}","starred_url":"https://api.github.com/users/jmvdwerf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmvdwerf/subscriptions","organizations_url":"https://api.github.com/users/jmvdwerf/orgs","repos_url":"https://api.github.com/users/jmvdwerf/repos","events_url":"https://api.github.com/users/jmvdwerf/events{/privacy}","received_events_url":"https://api.github.com/users/jmvdwerf/received_events","type":"User","site_admin":false},"body":"Done. I also updated the other includes, so that everything is following the layer pattern:\r\n- loconet. h only includes loconet_hw.h\r\n- loconet_rx.h only includes loconet.h\r\n- loconet_tx.h only includes loconet.h","created_at":"2018-07-27T10:58:08Z","updated_at":"2018-07-27T10:58:08Z","html_url":"https://github.com/slashdev/arm-loconet-starter/pull/22#discussion_r205738260","pull_request_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/pulls/22","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/slashdev/arm-loconet-starter/pulls/comments/205738260"},"html":{"href":"https://github.com/slashdev/arm-loconet-starter/pull/22#discussion_r205738260"},"pull_request":{"href":"https://api.github.com/repos/slashdev/arm-loconet-starter/pulls/22"}},"in_reply_to_id":205195536},"pull_request":{"url":"https://api.github.com/repos/slashdev/arm-loconet-starter/pulls/22","id":203670240,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNjcwMjQw","html_url":"https://github.com/slashdev/arm-loconet-starter/pull/22","diff_url":"https://github.com/slashdev/arm-loconet-starter/pull/22.diff","patch_url":"https://github.com/slashdev/arm-loconet-starter/pull/22.patch","issue_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/issues/22","number":22,"state":"open","locked":false,"title":"Feature/observer pattern for rx message call back","user":{"login":"jmvdwerf","id":5417081,"node_id":"MDQ6VXNlcjU0MTcwODE=","avatar_url":"https://avatars0.githubusercontent.com/u/5417081?v=4","gravatar_id":"","url":"https://api.github.com/users/jmvdwerf","html_url":"https://github.com/jmvdwerf","followers_url":"https://api.github.com/users/jmvdwerf/followers","following_url":"https://api.github.com/users/jmvdwerf/following{/other_user}","gists_url":"https://api.github.com/users/jmvdwerf/gists{/gist_id}","starred_url":"https://api.github.com/users/jmvdwerf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmvdwerf/subscriptions","organizations_url":"https://api.github.com/users/jmvdwerf/orgs","repos_url":"https://api.github.com/users/jmvdwerf/repos","events_url":"https://api.github.com/users/jmvdwerf/events{/privacy}","received_events_url":"https://api.github.com/users/jmvdwerf/received_events","type":"User","site_admin":false},"body":"All rx messages available in the code have been rewritten into the observer pattern. Only check I could do remotely is a check whether it compiles. At my machine it does. Hence, the big question, does it also run on the chip with the expected behavior?\r\nAlso, I found two functions that are called, but which I cannot find in the code:\r\n\r\n- loconet_rx_prog_task_final \r\n- loconet_rx_prog_task_start\r\n\r\nPlease have a look at those as well...\r\n\r\nThe component fast_clock is also a candidate to implement a separate observer, as it also has an update function that is weakly referenced. For now, I just updated the RX part.","created_at":"2018-07-24T22:14:38Z","updated_at":"2018-07-27T10:58:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbc74e1849031cd66e67f95007e2deb538b73ce4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":522765707,"node_id":"MDU6TGFiZWw1MjI3NjU3MDc=","url":"https://api.github.com/repos/slashdev/arm-loconet-starter/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":{"url":"https://api.github.com/repos/slashdev/arm-loconet-starter/milestones/4","html_url":"https://github.com/slashdev/arm-loconet-starter/milestone/4","labels_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/milestones/4/labels","id":2473302,"node_id":"MDk6TWlsZXN0b25lMjQ3MzMwMg==","number":4,"title":"0.4","description":"","creator":{"login":"fuegas","id":442230,"node_id":"MDQ6VXNlcjQ0MjIzMA==","avatar_url":"https://avatars3.githubusercontent.com/u/442230?v=4","gravatar_id":"","url":"https://api.github.com/users/fuegas","html_url":"https://github.com/fuegas","followers_url":"https://api.github.com/users/fuegas/followers","following_url":"https://api.github.com/users/fuegas/following{/other_user}","gists_url":"https://api.github.com/users/fuegas/gists{/gist_id}","starred_url":"https://api.github.com/users/fuegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuegas/subscriptions","organizations_url":"https://api.github.com/users/fuegas/orgs","repos_url":"https://api.github.com/users/fuegas/repos","events_url":"https://api.github.com/users/fuegas/events{/privacy}","received_events_url":"https://api.github.com/users/fuegas/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":1,"state":"open","created_at":"2017-04-21T21:25:27Z","updated_at":"2018-07-24T22:15:25Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/pulls/22/commits","review_comments_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/pulls/22/comments","review_comment_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/issues/22/comments","statuses_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/statuses/6b9ebf36eb4be8d23bcada476f6365ee0101015f","head":{"label":"slashdev:feature/observerPatternForRXMessageCallBack","ref":"feature/observerPatternForRXMessageCallBack","sha":"6b9ebf36eb4be8d23bcada476f6365ee0101015f","user":{"login":"slashdev","id":9202665,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyMDI2NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/9202665?v=4","gravatar_id":"","url":"https://api.github.com/users/slashdev","html_url":"https://github.com/slashdev","followers_url":"https://api.github.com/users/slashdev/followers","following_url":"https://api.github.com/users/slashdev/following{/other_user}","gists_url":"https://api.github.com/users/slashdev/gists{/gist_id}","starred_url":"https://api.github.com/users/slashdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slashdev/subscriptions","organizations_url":"https://api.github.com/users/slashdev/orgs","repos_url":"https://api.github.com/users/slashdev/repos","events_url":"https://api.github.com/users/slashdev/events{/privacy}","received_events_url":"https://api.github.com/users/slashdev/received_events","type":"Organization","site_admin":false},"repo":{"id":79597477,"node_id":"MDEwOlJlcG9zaXRvcnk3OTU5NzQ3Nw==","name":"arm-loconet-starter","full_name":"slashdev/arm-loconet-starter","owner":{"login":"slashdev","id":9202665,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyMDI2NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/9202665?v=4","gravatar_id":"","url":"https://api.github.com/users/slashdev","html_url":"https://github.com/slashdev","followers_url":"https://api.github.com/users/slashdev/followers","following_url":"https://api.github.com/users/slashdev/following{/other_user}","gists_url":"https://api.github.com/users/slashdev/gists{/gist_id}","starred_url":"https://api.github.com/users/slashdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slashdev/subscriptions","organizations_url":"https://api.github.com/users/slashdev/orgs","repos_url":"https://api.github.com/users/slashdev/repos","events_url":"https://api.github.com/users/slashdev/events{/privacy}","received_events_url":"https://api.github.com/users/slashdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slashdev/arm-loconet-starter","description":"Starter project for Loconet projects. Based on arm-samd20-starter.","fork":false,"url":"https://api.github.com/repos/slashdev/arm-loconet-starter","forks_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/forks","keys_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/teams","hooks_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/hooks","issue_events_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/issues/events{/number}","events_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/events","assignees_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/assignees{/user}","branches_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/branches{/branch}","tags_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/tags","blobs_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/git/refs{/sha}","trees_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/statuses/{sha}","languages_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/languages","stargazers_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/stargazers","contributors_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/contributors","subscribers_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/subscribers","subscription_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/subscription","commits_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/commits{/sha}","git_commits_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/git/commits{/sha}","comments_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/comments{/number}","issue_comment_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/issues/comments{/number}","contents_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/contents/{+path}","compare_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/merges","archive_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/downloads","issues_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/issues{/number}","pulls_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/pulls{/number}","milestones_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/milestones{/number}","notifications_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/labels{/name}","releases_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/releases{/id}","deployments_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/deployments","created_at":"2017-01-20T20:54:42Z","updated_at":"2018-07-14T17:58:00Z","pushed_at":"2018-07-24T22:14:39Z","git_url":"git://github.com/slashdev/arm-loconet-starter.git","ssh_url":"git@github.com:slashdev/arm-loconet-starter.git","clone_url":"https://github.com/slashdev/arm-loconet-starter.git","svn_url":"https://github.com/slashdev/arm-loconet-starter","homepage":null,"size":485,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"develop"}},"base":{"label":"slashdev:develop","ref":"develop","sha":"33035b301e34f3b03ee62814fd4ab5e7d4c65ed9","user":{"login":"slashdev","id":9202665,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyMDI2NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/9202665?v=4","gravatar_id":"","url":"https://api.github.com/users/slashdev","html_url":"https://github.com/slashdev","followers_url":"https://api.github.com/users/slashdev/followers","following_url":"https://api.github.com/users/slashdev/following{/other_user}","gists_url":"https://api.github.com/users/slashdev/gists{/gist_id}","starred_url":"https://api.github.com/users/slashdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slashdev/subscriptions","organizations_url":"https://api.github.com/users/slashdev/orgs","repos_url":"https://api.github.com/users/slashdev/repos","events_url":"https://api.github.com/users/slashdev/events{/privacy}","received_events_url":"https://api.github.com/users/slashdev/received_events","type":"Organization","site_admin":false},"repo":{"id":79597477,"node_id":"MDEwOlJlcG9zaXRvcnk3OTU5NzQ3Nw==","name":"arm-loconet-starter","full_name":"slashdev/arm-loconet-starter","owner":{"login":"slashdev","id":9202665,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyMDI2NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/9202665?v=4","gravatar_id":"","url":"https://api.github.com/users/slashdev","html_url":"https://github.com/slashdev","followers_url":"https://api.github.com/users/slashdev/followers","following_url":"https://api.github.com/users/slashdev/following{/other_user}","gists_url":"https://api.github.com/users/slashdev/gists{/gist_id}","starred_url":"https://api.github.com/users/slashdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slashdev/subscriptions","organizations_url":"https://api.github.com/users/slashdev/orgs","repos_url":"https://api.github.com/users/slashdev/repos","events_url":"https://api.github.com/users/slashdev/events{/privacy}","received_events_url":"https://api.github.com/users/slashdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slashdev/arm-loconet-starter","description":"Starter project for Loconet projects. Based on arm-samd20-starter.","fork":false,"url":"https://api.github.com/repos/slashdev/arm-loconet-starter","forks_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/forks","keys_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/teams","hooks_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/hooks","issue_events_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/issues/events{/number}","events_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/events","assignees_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/assignees{/user}","branches_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/branches{/branch}","tags_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/tags","blobs_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/git/refs{/sha}","trees_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/statuses/{sha}","languages_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/languages","stargazers_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/stargazers","contributors_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/contributors","subscribers_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/subscribers","subscription_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/subscription","commits_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/commits{/sha}","git_commits_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/git/commits{/sha}","comments_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/comments{/number}","issue_comment_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/issues/comments{/number}","contents_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/contents/{+path}","compare_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/merges","archive_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/downloads","issues_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/issues{/number}","pulls_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/pulls{/number}","milestones_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/milestones{/number}","notifications_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/labels{/name}","releases_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/releases{/id}","deployments_url":"https://api.github.com/repos/slashdev/arm-loconet-starter/deployments","created_at":"2017-01-20T20:54:42Z","updated_at":"2018-07-14T17:58:00Z","pushed_at":"2018-07-24T22:14:39Z","git_url":"git://github.com/slashdev/arm-loconet-starter.git","ssh_url":"git@github.com:slashdev/arm-loconet-starter.git","clone_url":"https://github.com/slashdev/arm-loconet-starter.git","svn_url":"https://github.com/slashdev/arm-loconet-starter","homepage":null,"size":485,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/slashdev/arm-loconet-starter/pulls/22"},"html":{"href":"https://github.com/slashdev/arm-loconet-starter/pull/22"},"issue":{"href":"https://api.github.com/repos/slashdev/arm-loconet-starter/issues/22"},"comments":{"href":"https://api.github.com/repos/slashdev/arm-loconet-starter/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/slashdev/arm-loconet-starter/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/slashdev/arm-loconet-starter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slashdev/arm-loconet-starter/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/slashdev/arm-loconet-starter/statuses/6b9ebf36eb4be8d23bcada476f6365ee0101015f"}},"author_association":"NONE"}}
{"actor":{"display_login":"jmvdwerf"}}