{"action":"created","comment":{"url":"https://api.github.com/repos/zendframework/zend-filter/pulls/comments/211410269","pull_request_review_id":147826256,"id":211410269,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTQxMDI2OQ==","diff_hunk":"@@ -0,0 +1,76 @@\n+<?php\n+/**\n+ * Zend Framework (http://framework.zend.com/)\n+ *\n+ * @link      http://github.com/zendframework/zf2 for the canonical source repository\n+ * @copyright Copyright (c) 2005-2015 Zend Technologies USA Inc. (http://www.zend.com)\n+ * @license   http://framework.zend.com/license/new-bsd New BSD License\n+ */\n+\n+namespace ZendTest\\Filter;\n+\n+use PHPUnit\\Framework\\TestCase;\n+use Zend\\Filter\\Exception\\InvalidArgumentException;\n+use Zend\\Filter\\StringPrefix as StringPrefixFilter;\n+\n+class StringPrefixTest extends TestCase\n+{\n+    /**\n+     * @var StringPrefixFilter\n+     */\n+    protected $filter;\n+\n+    /**\n+     * @return void\n+     */\n+    public function setUp()\n+    {\n+        $this->filter = new StringPrefixFilter();\n+    }\n+\n+    /**\n+     * Ensures that the filter follows expected behavior\n+     *\n+     * @return void\n+     */\n+    public function testBasic()\n+    {\n+        $filter = $this->filter;\n+\n+        $prefix = 'ABC123';\n+        $filter->setPrefix($prefix);\n+\n+        $this->assertStringStartsWith($prefix, $filter('sample'));","path":"test/StringPrefixTest.php","position":43,"original_position":43,"commit_id":"2cfccef3d9a57db76d087e1a1c2b33f804d50db0","original_commit_id":"2cfccef3d9a57db76d087e1a1c2b33f804d50db0","user":{"login":"waltertamboer","id":508054,"node_id":"MDQ6VXNlcjUwODA1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/508054?v=4","gravatar_id":"","url":"https://api.github.com/users/waltertamboer","html_url":"https://github.com/waltertamboer","followers_url":"https://api.github.com/users/waltertamboer/followers","following_url":"https://api.github.com/users/waltertamboer/following{/other_user}","gists_url":"https://api.github.com/users/waltertamboer/gists{/gist_id}","starred_url":"https://api.github.com/users/waltertamboer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waltertamboer/subscriptions","organizations_url":"https://api.github.com/users/waltertamboer/orgs","repos_url":"https://api.github.com/users/waltertamboer/repos","events_url":"https://api.github.com/users/waltertamboer/events{/privacy}","received_events_url":"https://api.github.com/users/waltertamboer/received_events","type":"User","site_admin":false},"body":"I don't agree. There is a right way. The paragraphs in the phpunit docs are just extremely awkward to read.\r\n\r\n> The short answer is: there is no right way. And there is no wrong way, either. It is a matter of personal preference.\r\n\r\nWhich can be rephrased as: \"it doesn't matter\". No, it's not a matter of personal preference. It's a matter of writing semantically correct code. Basically the arguments @Ocramius used in the discussion on Discourse.\r\n\r\nBut it's ok, I've made my argument and it won't change the fact that ZF is currently using `$this`. So let's move on.\r\n\r\nThanks for your time and patience.","created_at":"2018-08-20T21:17:29Z","updated_at":"2018-08-20T21:17:29Z","html_url":"https://github.com/zendframework/zend-filter/pull/69#discussion_r211410269","pull_request_url":"https://api.github.com/repos/zendframework/zend-filter/pulls/69","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/zendframework/zend-filter/pulls/comments/211410269"},"html":{"href":"https://github.com/zendframework/zend-filter/pull/69#discussion_r211410269"},"pull_request":{"href":"https://api.github.com/repos/zendframework/zend-filter/pulls/69"}},"in_reply_to_id":210757691},"pull_request":{"url":"https://api.github.com/repos/zendframework/zend-filter/pulls/69","id":207817062,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODE3MDYy","html_url":"https://github.com/zendframework/zend-filter/pull/69","diff_url":"https://github.com/zendframework/zend-filter/pull/69.diff","patch_url":"https://github.com/zendframework/zend-filter/pull/69.patch","issue_url":"https://api.github.com/repos/zendframework/zend-filter/issues/69","number":69,"state":"open","locked":false,"title":"Add StringPrefix filter with tests","user":{"login":"thexpand","id":14979167,"node_id":"MDQ6VXNlcjE0OTc5MTY3","avatar_url":"https://avatars0.githubusercontent.com/u/14979167?v=4","gravatar_id":"","url":"https://api.github.com/users/thexpand","html_url":"https://github.com/thexpand","followers_url":"https://api.github.com/users/thexpand/followers","following_url":"https://api.github.com/users/thexpand/following{/other_user}","gists_url":"https://api.github.com/users/thexpand/gists{/gist_id}","starred_url":"https://api.github.com/users/thexpand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thexpand/subscriptions","organizations_url":"https://api.github.com/users/thexpand/orgs","repos_url":"https://api.github.com/users/thexpand/repos","events_url":"https://api.github.com/users/thexpand/events{/privacy}","received_events_url":"https://api.github.com/users/thexpand/received_events","type":"User","site_admin":false},"body":"https://github.com/zendframework/zend-filter/issues/28","created_at":"2018-08-12T11:35:55Z","updated_at":"2018-08-20T21:17:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aaeedf19318b2d8626df59e7bee11842935d2bde","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":209128125,"node_id":"MDU6TGFiZWwyMDkxMjgxMjU=","url":"https://api.github.com/repos/zendframework/zend-filter/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/zendframework/zend-filter/pulls/69/commits","review_comments_url":"https://api.github.com/repos/zendframework/zend-filter/pulls/69/comments","review_comment_url":"https://api.github.com/repos/zendframework/zend-filter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendframework/zend-filter/issues/69/comments","statuses_url":"https://api.github.com/repos/zendframework/zend-filter/statuses/2cfccef3d9a57db76d087e1a1c2b33f804d50db0","head":{"label":"thexpand:string-prefix-suffix","ref":"string-prefix-suffix","sha":"2cfccef3d9a57db76d087e1a1c2b33f804d50db0","user":{"login":"thexpand","id":14979167,"node_id":"MDQ6VXNlcjE0OTc5MTY3","avatar_url":"https://avatars0.githubusercontent.com/u/14979167?v=4","gravatar_id":"","url":"https://api.github.com/users/thexpand","html_url":"https://github.com/thexpand","followers_url":"https://api.github.com/users/thexpand/followers","following_url":"https://api.github.com/users/thexpand/following{/other_user}","gists_url":"https://api.github.com/users/thexpand/gists{/gist_id}","starred_url":"https://api.github.com/users/thexpand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thexpand/subscriptions","organizations_url":"https://api.github.com/users/thexpand/orgs","repos_url":"https://api.github.com/users/thexpand/repos","events_url":"https://api.github.com/users/thexpand/events{/privacy}","received_events_url":"https://api.github.com/users/thexpand/received_events","type":"User","site_admin":false},"repo":{"id":144457845,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ0NTc4NDU=","name":"zend-filter","full_name":"thexpand/zend-filter","owner":{"login":"thexpand","id":14979167,"node_id":"MDQ6VXNlcjE0OTc5MTY3","avatar_url":"https://avatars0.githubusercontent.com/u/14979167?v=4","gravatar_id":"","url":"https://api.github.com/users/thexpand","html_url":"https://github.com/thexpand","followers_url":"https://api.github.com/users/thexpand/followers","following_url":"https://api.github.com/users/thexpand/following{/other_user}","gists_url":"https://api.github.com/users/thexpand/gists{/gist_id}","starred_url":"https://api.github.com/users/thexpand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thexpand/subscriptions","organizations_url":"https://api.github.com/users/thexpand/orgs","repos_url":"https://api.github.com/users/thexpand/repos","events_url":"https://api.github.com/users/thexpand/events{/privacy}","received_events_url":"https://api.github.com/users/thexpand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thexpand/zend-filter","description":"Filter component from Zend Framework","fork":true,"url":"https://api.github.com/repos/thexpand/zend-filter","forks_url":"https://api.github.com/repos/thexpand/zend-filter/forks","keys_url":"https://api.github.com/repos/thexpand/zend-filter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thexpand/zend-filter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thexpand/zend-filter/teams","hooks_url":"https://api.github.com/repos/thexpand/zend-filter/hooks","issue_events_url":"https://api.github.com/repos/thexpand/zend-filter/issues/events{/number}","events_url":"https://api.github.com/repos/thexpand/zend-filter/events","assignees_url":"https://api.github.com/repos/thexpand/zend-filter/assignees{/user}","branches_url":"https://api.github.com/repos/thexpand/zend-filter/branches{/branch}","tags_url":"https://api.github.com/repos/thexpand/zend-filter/tags","blobs_url":"https://api.github.com/repos/thexpand/zend-filter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thexpand/zend-filter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thexpand/zend-filter/git/refs{/sha}","trees_url":"https://api.github.com/repos/thexpand/zend-filter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thexpand/zend-filter/statuses/{sha}","languages_url":"https://api.github.com/repos/thexpand/zend-filter/languages","stargazers_url":"https://api.github.com/repos/thexpand/zend-filter/stargazers","contributors_url":"https://api.github.com/repos/thexpand/zend-filter/contributors","subscribers_url":"https://api.github.com/repos/thexpand/zend-filter/subscribers","subscription_url":"https://api.github.com/repos/thexpand/zend-filter/subscription","commits_url":"https://api.github.com/repos/thexpand/zend-filter/commits{/sha}","git_commits_url":"https://api.github.com/repos/thexpand/zend-filter/git/commits{/sha}","comments_url":"https://api.github.com/repos/thexpand/zend-filter/comments{/number}","issue_comment_url":"https://api.github.com/repos/thexpand/zend-filter/issues/comments{/number}","contents_url":"https://api.github.com/repos/thexpand/zend-filter/contents/{+path}","compare_url":"https://api.github.com/repos/thexpand/zend-filter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thexpand/zend-filter/merges","archive_url":"https://api.github.com/repos/thexpand/zend-filter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thexpand/zend-filter/downloads","issues_url":"https://api.github.com/repos/thexpand/zend-filter/issues{/number}","pulls_url":"https://api.github.com/repos/thexpand/zend-filter/pulls{/number}","milestones_url":"https://api.github.com/repos/thexpand/zend-filter/milestones{/number}","notifications_url":"https://api.github.com/repos/thexpand/zend-filter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thexpand/zend-filter/labels{/name}","releases_url":"https://api.github.com/repos/thexpand/zend-filter/releases{/id}","deployments_url":"https://api.github.com/repos/thexpand/zend-filter/deployments","created_at":"2018-08-12T10:35:13Z","updated_at":"2018-08-12T10:35:16Z","pushed_at":"2018-08-12T11:44:05Z","git_url":"git://github.com/thexpand/zend-filter.git","ssh_url":"git@github.com:thexpand/zend-filter.git","clone_url":"https://github.com/thexpand/zend-filter.git","svn_url":"https://github.com/thexpand/zend-filter","homepage":"https://github.com/zendframework/zf2","size":4417,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zendframework:master","ref":"master","sha":"7b997dbe79459f1652deccc8786d7407fb66caa9","user":{"login":"zendframework","id":296074,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjA3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/296074?v=4","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"repo":{"id":35280803,"node_id":"MDEwOlJlcG9zaXRvcnkzNTI4MDgwMw==","name":"zend-filter","full_name":"zendframework/zend-filter","owner":{"login":"zendframework","id":296074,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NjA3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/296074?v=4","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendframework/zend-filter","description":"Filter component from Zend Framework","fork":false,"url":"https://api.github.com/repos/zendframework/zend-filter","forks_url":"https://api.github.com/repos/zendframework/zend-filter/forks","keys_url":"https://api.github.com/repos/zendframework/zend-filter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendframework/zend-filter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendframework/zend-filter/teams","hooks_url":"https://api.github.com/repos/zendframework/zend-filter/hooks","issue_events_url":"https://api.github.com/repos/zendframework/zend-filter/issues/events{/number}","events_url":"https://api.github.com/repos/zendframework/zend-filter/events","assignees_url":"https://api.github.com/repos/zendframework/zend-filter/assignees{/user}","branches_url":"https://api.github.com/repos/zendframework/zend-filter/branches{/branch}","tags_url":"https://api.github.com/repos/zendframework/zend-filter/tags","blobs_url":"https://api.github.com/repos/zendframework/zend-filter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendframework/zend-filter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendframework/zend-filter/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendframework/zend-filter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendframework/zend-filter/statuses/{sha}","languages_url":"https://api.github.com/repos/zendframework/zend-filter/languages","stargazers_url":"https://api.github.com/repos/zendframework/zend-filter/stargazers","contributors_url":"https://api.github.com/repos/zendframework/zend-filter/contributors","subscribers_url":"https://api.github.com/repos/zendframework/zend-filter/subscribers","subscription_url":"https://api.github.com/repos/zendframework/zend-filter/subscription","commits_url":"https://api.github.com/repos/zendframework/zend-filter/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendframework/zend-filter/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendframework/zend-filter/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendframework/zend-filter/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendframework/zend-filter/contents/{+path}","compare_url":"https://api.github.com/repos/zendframework/zend-filter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendframework/zend-filter/merges","archive_url":"https://api.github.com/repos/zendframework/zend-filter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendframework/zend-filter/downloads","issues_url":"https://api.github.com/repos/zendframework/zend-filter/issues{/number}","pulls_url":"https://api.github.com/repos/zendframework/zend-filter/pulls{/number}","milestones_url":"https://api.github.com/repos/zendframework/zend-filter/milestones{/number}","notifications_url":"https://api.github.com/repos/zendframework/zend-filter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendframework/zend-filter/labels{/name}","releases_url":"https://api.github.com/repos/zendframework/zend-filter/releases{/id}","deployments_url":"https://api.github.com/repos/zendframework/zend-filter/deployments","created_at":"2015-05-08T13:27:59Z","updated_at":"2018-08-01T19:47:39Z","pushed_at":"2018-08-17T21:12:49Z","git_url":"git://github.com/zendframework/zend-filter.git","ssh_url":"git@github.com:zendframework/zend-filter.git","clone_url":"https://github.com/zendframework/zend-filter.git","svn_url":"https://github.com/zendframework/zend-filter","homepage":"https://github.com/zendframework/zf2","size":4413,"stargazers_count":43,"watchers_count":43,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":36,"open_issues":19,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendframework/zend-filter/pulls/69"},"html":{"href":"https://github.com/zendframework/zend-filter/pull/69"},"issue":{"href":"https://api.github.com/repos/zendframework/zend-filter/issues/69"},"comments":{"href":"https://api.github.com/repos/zendframework/zend-filter/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/zendframework/zend-filter/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/zendframework/zend-filter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendframework/zend-filter/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/zendframework/zend-filter/statuses/2cfccef3d9a57db76d087e1a1c2b33f804d50db0"}},"author_association":"NONE"}}
{"actor":{"display_login":"waltertamboer"}}