{"action":"created","comment":{"url":"https://api.github.com/repos/positive-js/mosaic/pulls/comments/218374921","pull_request_review_id":156296163,"id":218374921,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODM3NDkyMQ==","diff_hunk":"@@ -124,34 +129,44 @@ export class McToolTipComponent {\n \n     /** Subject for notifying that the tooltip has been hidden from the view */\n     private readonly _onHide: Subject<any> = new Subject();\n+    private _closeOnInteraction: boolean = false;\n \n     constructor(public cdr: ChangeDetectorRef) {\n         this.availablePositions = POSITION_MAP;\n     }\n \n     show(): void {\n-        if (!this.isContentEmpty()) {\n-            this.setClassMap();\n-            this.mcVisible = true;\n+        if (this.hideTId) {\n+            clearTimeout(this.hideTId);\n+        }\n \n-            this._markForCheck();\n+        if (!this.isContentEmpty()) {\n+            this._closeOnInteraction = true;\n+            this.showTId = setTimeout(() => {\n+                this.mcVisible = true;\n+                this.mcVisibleChange.emit(true);\n+\n+                // Mark for check so if any parent component has set the\n+                // ChangeDetectionStrategy to OnPush it will be checked anyways\n+                this._markForCheck();\n+            }, this.mcMouseEnterDelay);\n         }\n     }\n \n     hide(): void {\n-        this.mcVisible = false;\n-\n-        this._markForCheck();\n-    }\n+        if (this.showTId) {\n+            clearTimeout(this.showTId);\n+        }\n \n-    _afterVisibilityAnimation(e: AnimationEvent): void {\n-        if (e.toState === 'false' && !this.mcVisible) {\n+        this.hideTId = setTimeout(() => {","path":"src/lib/tooltip/tooltip.component.ts","position":null,"original_position":84,"commit_id":"1ad45abb02b6e810aa32aa3f3d85b96eaddfb12f","original_commit_id":"1ad45abb02b6e810aa32aa3f3d85b96eaddfb12f","user":{"login":"LeonVay","id":12794877,"node_id":"MDQ6VXNlcjEyNzk0ODc3","avatar_url":"https://avatars1.githubusercontent.com/u/12794877?v=4","gravatar_id":"","url":"https://api.github.com/users/LeonVay","html_url":"https://github.com/LeonVay","followers_url":"https://api.github.com/users/LeonVay/followers","following_url":"https://api.github.com/users/LeonVay/following{/other_user}","gists_url":"https://api.github.com/users/LeonVay/gists{/gist_id}","starred_url":"https://api.github.com/users/LeonVay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeonVay/subscriptions","organizations_url":"https://api.github.com/users/LeonVay/orgs","repos_url":"https://api.github.com/users/LeonVay/repos","events_url":"https://api.github.com/users/LeonVay/events{/privacy}","received_events_url":"https://api.github.com/users/LeonVay/received_events","type":"User","site_admin":false},"body":"Не должен по идее. Возвращаемое значение у setTimeout -> number. Пробовал invalidate сделать, у меня ошибки не появляются.","created_at":"2018-09-18T10:14:29Z","updated_at":"2018-09-18T10:14:29Z","html_url":"https://github.com/positive-js/mosaic/pull/33#discussion_r218374921","pull_request_url":"https://api.github.com/repos/positive-js/mosaic/pulls/33","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/positive-js/mosaic/pulls/comments/218374921"},"html":{"href":"https://github.com/positive-js/mosaic/pull/33#discussion_r218374921"},"pull_request":{"href":"https://api.github.com/repos/positive-js/mosaic/pulls/33"}},"in_reply_to_id":218317849},"pull_request":{"url":"https://api.github.com/repos/positive-js/mosaic/pulls/33","id":207273522,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MjczNTIy","html_url":"https://github.com/positive-js/mosaic/pull/33","diff_url":"https://github.com/positive-js/mosaic/pull/33.diff","patch_url":"https://github.com/positive-js/mosaic/pull/33.patch","issue_url":"https://api.github.com/repos/positive-js/mosaic/issues/33","number":33,"state":"open","locked":false,"title":"[WIP] feat(tooltip): Tooltip component","user":{"login":"LeonVay","id":12794877,"node_id":"MDQ6VXNlcjEyNzk0ODc3","avatar_url":"https://avatars1.githubusercontent.com/u/12794877?v=4","gravatar_id":"","url":"https://api.github.com/users/LeonVay","html_url":"https://github.com/LeonVay","followers_url":"https://api.github.com/users/LeonVay/followers","following_url":"https://api.github.com/users/LeonVay/following{/other_user}","gists_url":"https://api.github.com/users/LeonVay/gists{/gist_id}","starred_url":"https://api.github.com/users/LeonVay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeonVay/subscriptions","organizations_url":"https://api.github.com/users/LeonVay/orgs","repos_url":"https://api.github.com/users/LeonVay/repos","events_url":"https://api.github.com/users/LeonVay/events{/privacy}","received_events_url":"https://api.github.com/users/LeonVay/received_events","type":"User","site_admin":false},"body":"Тултип WIP.\r\nЗапускать \"server-dev:tooltip\": \"npm run server-dev -- --env.component tooltip\"\r\nПервая кнопка показывает тултип по фокусу, две последнии по клику.","created_at":"2018-08-09T10:41:29Z","updated_at":"2018-09-18T10:14:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fee5c1f8ffa883dce37b6927fea1842f23075366","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/positive-js/mosaic/pulls/33/commits","review_comments_url":"https://api.github.com/repos/positive-js/mosaic/pulls/33/comments","review_comment_url":"https://api.github.com/repos/positive-js/mosaic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/positive-js/mosaic/issues/33/comments","statuses_url":"https://api.github.com/repos/positive-js/mosaic/statuses/1ad45abb02b6e810aa32aa3f3d85b96eaddfb12f","head":{"label":"LeonVay:feat(tooltip)_Tooltip","ref":"feat(tooltip)_Tooltip","sha":"1ad45abb02b6e810aa32aa3f3d85b96eaddfb12f","user":{"login":"LeonVay","id":12794877,"node_id":"MDQ6VXNlcjEyNzk0ODc3","avatar_url":"https://avatars1.githubusercontent.com/u/12794877?v=4","gravatar_id":"","url":"https://api.github.com/users/LeonVay","html_url":"https://github.com/LeonVay","followers_url":"https://api.github.com/users/LeonVay/followers","following_url":"https://api.github.com/users/LeonVay/following{/other_user}","gists_url":"https://api.github.com/users/LeonVay/gists{/gist_id}","starred_url":"https://api.github.com/users/LeonVay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeonVay/subscriptions","organizations_url":"https://api.github.com/users/LeonVay/orgs","repos_url":"https://api.github.com/users/LeonVay/repos","events_url":"https://api.github.com/users/LeonVay/events{/privacy}","received_events_url":"https://api.github.com/users/LeonVay/received_events","type":"User","site_admin":false},"repo":{"id":134177352,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQxNzczNTI=","name":"mosaic","full_name":"LeonVay/mosaic","private":false,"owner":{"login":"LeonVay","id":12794877,"node_id":"MDQ6VXNlcjEyNzk0ODc3","avatar_url":"https://avatars1.githubusercontent.com/u/12794877?v=4","gravatar_id":"","url":"https://api.github.com/users/LeonVay","html_url":"https://github.com/LeonVay","followers_url":"https://api.github.com/users/LeonVay/followers","following_url":"https://api.github.com/users/LeonVay/following{/other_user}","gists_url":"https://api.github.com/users/LeonVay/gists{/gist_id}","starred_url":"https://api.github.com/users/LeonVay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeonVay/subscriptions","organizations_url":"https://api.github.com/users/LeonVay/orgs","repos_url":"https://api.github.com/users/LeonVay/repos","events_url":"https://api.github.com/users/LeonVay/events{/privacy}","received_events_url":"https://api.github.com/users/LeonVay/received_events","type":"User","site_admin":false},"html_url":"https://github.com/LeonVay/mosaic","description":"Angular components ✨ 📦🐣 ✨","fork":true,"url":"https://api.github.com/repos/LeonVay/mosaic","forks_url":"https://api.github.com/repos/LeonVay/mosaic/forks","keys_url":"https://api.github.com/repos/LeonVay/mosaic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LeonVay/mosaic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LeonVay/mosaic/teams","hooks_url":"https://api.github.com/repos/LeonVay/mosaic/hooks","issue_events_url":"https://api.github.com/repos/LeonVay/mosaic/issues/events{/number}","events_url":"https://api.github.com/repos/LeonVay/mosaic/events","assignees_url":"https://api.github.com/repos/LeonVay/mosaic/assignees{/user}","branches_url":"https://api.github.com/repos/LeonVay/mosaic/branches{/branch}","tags_url":"https://api.github.com/repos/LeonVay/mosaic/tags","blobs_url":"https://api.github.com/repos/LeonVay/mosaic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LeonVay/mosaic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LeonVay/mosaic/git/refs{/sha}","trees_url":"https://api.github.com/repos/LeonVay/mosaic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LeonVay/mosaic/statuses/{sha}","languages_url":"https://api.github.com/repos/LeonVay/mosaic/languages","stargazers_url":"https://api.github.com/repos/LeonVay/mosaic/stargazers","contributors_url":"https://api.github.com/repos/LeonVay/mosaic/contributors","subscribers_url":"https://api.github.com/repos/LeonVay/mosaic/subscribers","subscription_url":"https://api.github.com/repos/LeonVay/mosaic/subscription","commits_url":"https://api.github.com/repos/LeonVay/mosaic/commits{/sha}","git_commits_url":"https://api.github.com/repos/LeonVay/mosaic/git/commits{/sha}","comments_url":"https://api.github.com/repos/LeonVay/mosaic/comments{/number}","issue_comment_url":"https://api.github.com/repos/LeonVay/mosaic/issues/comments{/number}","contents_url":"https://api.github.com/repos/LeonVay/mosaic/contents/{+path}","compare_url":"https://api.github.com/repos/LeonVay/mosaic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LeonVay/mosaic/merges","archive_url":"https://api.github.com/repos/LeonVay/mosaic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LeonVay/mosaic/downloads","issues_url":"https://api.github.com/repos/LeonVay/mosaic/issues{/number}","pulls_url":"https://api.github.com/repos/LeonVay/mosaic/pulls{/number}","milestones_url":"https://api.github.com/repos/LeonVay/mosaic/milestones{/number}","notifications_url":"https://api.github.com/repos/LeonVay/mosaic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LeonVay/mosaic/labels{/name}","releases_url":"https://api.github.com/repos/LeonVay/mosaic/releases{/id}","deployments_url":"https://api.github.com/repos/LeonVay/mosaic/deployments","created_at":"2018-05-20T18:48:03Z","updated_at":"2018-08-09T06:25:17Z","pushed_at":"2018-09-18T06:00:02Z","git_url":"git://github.com/LeonVay/mosaic.git","ssh_url":"git@github.com:LeonVay/mosaic.git","clone_url":"https://github.com/LeonVay/mosaic.git","svn_url":"https://github.com/LeonVay/mosaic","homepage":"","size":7080,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"positive-js:master","ref":"master","sha":"019987f5e96225c1c0c324c7043bf136fc17a8a9","user":{"login":"positive-js","id":22543527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTQzNTI3","avatar_url":"https://avatars1.githubusercontent.com/u/22543527?v=4","gravatar_id":"","url":"https://api.github.com/users/positive-js","html_url":"https://github.com/positive-js","followers_url":"https://api.github.com/users/positive-js/followers","following_url":"https://api.github.com/users/positive-js/following{/other_user}","gists_url":"https://api.github.com/users/positive-js/gists{/gist_id}","starred_url":"https://api.github.com/users/positive-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/positive-js/subscriptions","organizations_url":"https://api.github.com/users/positive-js/orgs","repos_url":"https://api.github.com/users/positive-js/repos","events_url":"https://api.github.com/users/positive-js/events{/privacy}","received_events_url":"https://api.github.com/users/positive-js/received_events","type":"Organization","site_admin":false},"repo":{"id":69664547,"node_id":"MDEwOlJlcG9zaXRvcnk2OTY2NDU0Nw==","name":"mosaic","full_name":"positive-js/mosaic","private":false,"owner":{"login":"positive-js","id":22543527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTQzNTI3","avatar_url":"https://avatars1.githubusercontent.com/u/22543527?v=4","gravatar_id":"","url":"https://api.github.com/users/positive-js","html_url":"https://github.com/positive-js","followers_url":"https://api.github.com/users/positive-js/followers","following_url":"https://api.github.com/users/positive-js/following{/other_user}","gists_url":"https://api.github.com/users/positive-js/gists{/gist_id}","starred_url":"https://api.github.com/users/positive-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/positive-js/subscriptions","organizations_url":"https://api.github.com/users/positive-js/orgs","repos_url":"https://api.github.com/users/positive-js/repos","events_url":"https://api.github.com/users/positive-js/events{/privacy}","received_events_url":"https://api.github.com/users/positive-js/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/positive-js/mosaic","description":"Angular components ✨ 📦🐣 ✨","fork":false,"url":"https://api.github.com/repos/positive-js/mosaic","forks_url":"https://api.github.com/repos/positive-js/mosaic/forks","keys_url":"https://api.github.com/repos/positive-js/mosaic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/positive-js/mosaic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/positive-js/mosaic/teams","hooks_url":"https://api.github.com/repos/positive-js/mosaic/hooks","issue_events_url":"https://api.github.com/repos/positive-js/mosaic/issues/events{/number}","events_url":"https://api.github.com/repos/positive-js/mosaic/events","assignees_url":"https://api.github.com/repos/positive-js/mosaic/assignees{/user}","branches_url":"https://api.github.com/repos/positive-js/mosaic/branches{/branch}","tags_url":"https://api.github.com/repos/positive-js/mosaic/tags","blobs_url":"https://api.github.com/repos/positive-js/mosaic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/positive-js/mosaic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/positive-js/mosaic/git/refs{/sha}","trees_url":"https://api.github.com/repos/positive-js/mosaic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/positive-js/mosaic/statuses/{sha}","languages_url":"https://api.github.com/repos/positive-js/mosaic/languages","stargazers_url":"https://api.github.com/repos/positive-js/mosaic/stargazers","contributors_url":"https://api.github.com/repos/positive-js/mosaic/contributors","subscribers_url":"https://api.github.com/repos/positive-js/mosaic/subscribers","subscription_url":"https://api.github.com/repos/positive-js/mosaic/subscription","commits_url":"https://api.github.com/repos/positive-js/mosaic/commits{/sha}","git_commits_url":"https://api.github.com/repos/positive-js/mosaic/git/commits{/sha}","comments_url":"https://api.github.com/repos/positive-js/mosaic/comments{/number}","issue_comment_url":"https://api.github.com/repos/positive-js/mosaic/issues/comments{/number}","contents_url":"https://api.github.com/repos/positive-js/mosaic/contents/{+path}","compare_url":"https://api.github.com/repos/positive-js/mosaic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/positive-js/mosaic/merges","archive_url":"https://api.github.com/repos/positive-js/mosaic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/positive-js/mosaic/downloads","issues_url":"https://api.github.com/repos/positive-js/mosaic/issues{/number}","pulls_url":"https://api.github.com/repos/positive-js/mosaic/pulls{/number}","milestones_url":"https://api.github.com/repos/positive-js/mosaic/milestones{/number}","notifications_url":"https://api.github.com/repos/positive-js/mosaic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/positive-js/mosaic/labels{/name}","releases_url":"https://api.github.com/repos/positive-js/mosaic/releases{/id}","deployments_url":"https://api.github.com/repos/positive-js/mosaic/deployments","created_at":"2016-09-30T12:22:09Z","updated_at":"2018-09-13T15:52:58Z","pushed_at":"2018-09-18T08:42:39Z","git_url":"git://github.com/positive-js/mosaic.git","ssh_url":"git@github.com:positive-js/mosaic.git","clone_url":"https://github.com/positive-js/mosaic.git","svn_url":"https://github.com/positive-js/mosaic","homepage":"","size":7240,"stargazers_count":40,"watchers_count":40,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":12,"open_issues":4,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/positive-js/mosaic/pulls/33"},"html":{"href":"https://github.com/positive-js/mosaic/pull/33"},"issue":{"href":"https://api.github.com/repos/positive-js/mosaic/issues/33"},"comments":{"href":"https://api.github.com/repos/positive-js/mosaic/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/positive-js/mosaic/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/positive-js/mosaic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/positive-js/mosaic/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/positive-js/mosaic/statuses/1ad45abb02b6e810aa32aa3f3d85b96eaddfb12f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"LeonVay"}}