{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/mentat/pulls/comments/204113353","pull_request_review_id":139136950,"id":204113353,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDExMzM1Mw==","diff_hunk":"@@ -515,12 +515,19 @@ pub trait MentatStoring {\n     fn insert_non_fts_searches<'a>(&self, entities: &'a [ReducedEntity], search_type: SearchType) -> Result<()>;\n     fn insert_fts_searches<'a>(&self, entities: &'a [ReducedEntity], search_type: SearchType) -> Result<()>;\n \n-    /// Finalize the underlying storage layer after a Mentat transaction.\n-    ///\n+    /// Prepare the underlyin storage layer for finalization after a Mentat transaction.\n+    /// \n     /// Use this to finalize temporary tables, complete indices, revert pragmas, etc, after the\n     /// final `insert_non_fts_searches` invocation.\n+    fn materialize_transaction(&self, tx_id: Entid) -> Result<()>;","path":"db/src/db.rs","position":122,"original_position":10,"commit_id":"4df29da9a4fcea401f86d576b6dce600055a6e70","original_commit_id":"9d395d5001f9e53bda5be0b24146faf16aedb9f0","user":{"login":"ncalexan","id":1097182,"node_id":"MDQ6VXNlcjEwOTcxODI=","avatar_url":"https://avatars0.githubusercontent.com/u/1097182?v=4","gravatar_id":"","url":"https://api.github.com/users/ncalexan","html_url":"https://github.com/ncalexan","followers_url":"https://api.github.com/users/ncalexan/followers","following_url":"https://api.github.com/users/ncalexan/following{/other_user}","gists_url":"https://api.github.com/users/ncalexan/gists{/gist_id}","starred_url":"https://api.github.com/users/ncalexan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncalexan/subscriptions","organizations_url":"https://api.github.com/users/ncalexan/orgs","repos_url":"https://api.github.com/users/ncalexan/repos","events_url":"https://api.github.com/users/ncalexan/events{/privacy}","received_events_url":"https://api.github.com/users/ncalexan/received_events","type":"User","site_admin":false},"body":"I got tripped up earlier this week, so let's call this `materialize_mentat_transaction`.","created_at":"2018-07-20T17:20:50Z","updated_at":"2018-07-20T17:43:53Z","html_url":"https://github.com/mozilla/mentat/pull/783#discussion_r204113353","pull_request_url":"https://api.github.com/repos/mozilla/mentat/pulls/783","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mozilla/mentat/pulls/comments/204113353"},"html":{"href":"https://github.com/mozilla/mentat/pull/783#discussion_r204113353"},"pull_request":{"href":"https://api.github.com/repos/mozilla/mentat/pulls/783"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/mentat/pulls/783","id":201142723,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMTQyNzIz","html_url":"https://github.com/mozilla/mentat/pull/783","diff_url":"https://github.com/mozilla/mentat/pull/783.diff","patch_url":"https://github.com/mozilla/mentat/pull/783.patch","issue_url":"https://api.github.com/repos/mozilla/mentat/issues/783","number":783,"state":"open","locked":false,"title":"Basic timelines support","user":{"login":"grigoryk","id":465422,"node_id":"MDQ6VXNlcjQ2NTQyMg==","avatar_url":"https://avatars3.githubusercontent.com/u/465422?v=4","gravatar_id":"","url":"https://api.github.com/users/grigoryk","html_url":"https://github.com/grigoryk","followers_url":"https://api.github.com/users/grigoryk/followers","following_url":"https://api.github.com/users/grigoryk/following{/other_user}","gists_url":"https://api.github.com/users/grigoryk/gists{/gist_id}","starred_url":"https://api.github.com/users/grigoryk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grigoryk/subscriptions","organizations_url":"https://api.github.com/users/grigoryk/orgs","repos_url":"https://api.github.com/users/grigoryk/repos","events_url":"https://api.github.com/users/grigoryk/events{/privacy}","received_events_url":"https://api.github.com/users/grigoryk/received_events","type":"User","site_admin":false},"body":"Initial pass","created_at":"2018-07-12T22:28:15Z","updated_at":"2018-07-20T17:43:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c6ed32be2e0e4605901a439ec7f039a61d734c8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/mentat/pulls/783/commits","review_comments_url":"https://api.github.com/repos/mozilla/mentat/pulls/783/comments","review_comment_url":"https://api.github.com/repos/mozilla/mentat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/mentat/issues/783/comments","statuses_url":"https://api.github.com/repos/mozilla/mentat/statuses/4df29da9a4fcea401f86d576b6dce600055a6e70","head":{"label":"mozilla:grisha/moving-timelines","ref":"grisha/moving-timelines","sha":"4df29da9a4fcea401f86d576b6dce600055a6e70","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":62660036,"node_id":"MDEwOlJlcG9zaXRvcnk2MjY2MDAzNg==","name":"mentat","full_name":"mozilla/mentat","owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/mentat","description":"A persistent, relational store inspired by Datomic and DataScript.","fork":false,"url":"https://api.github.com/repos/mozilla/mentat","forks_url":"https://api.github.com/repos/mozilla/mentat/forks","keys_url":"https://api.github.com/repos/mozilla/mentat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/mentat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/mentat/teams","hooks_url":"https://api.github.com/repos/mozilla/mentat/hooks","issue_events_url":"https://api.github.com/repos/mozilla/mentat/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/mentat/events","assignees_url":"https://api.github.com/repos/mozilla/mentat/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/mentat/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/mentat/tags","blobs_url":"https://api.github.com/repos/mozilla/mentat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/mentat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/mentat/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/mentat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/mentat/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/mentat/languages","stargazers_url":"https://api.github.com/repos/mozilla/mentat/stargazers","contributors_url":"https://api.github.com/repos/mozilla/mentat/contributors","subscribers_url":"https://api.github.com/repos/mozilla/mentat/subscribers","subscription_url":"https://api.github.com/repos/mozilla/mentat/subscription","commits_url":"https://api.github.com/repos/mozilla/mentat/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/mentat/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/mentat/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/mentat/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/mentat/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/mentat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/mentat/merges","archive_url":"https://api.github.com/repos/mozilla/mentat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/mentat/downloads","issues_url":"https://api.github.com/repos/mozilla/mentat/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/mentat/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/mentat/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/mentat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/mentat/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/mentat/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/mentat/deployments","created_at":"2016-07-05T18:29:34Z","updated_at":"2018-07-19T23:49:29Z","pushed_at":"2018-07-20T00:16:55Z","git_url":"git://github.com/mozilla/mentat.git","ssh_url":"git@github.com:mozilla/mentat.git","clone_url":"https://github.com/mozilla/mentat.git","svn_url":"https://github.com/mozilla/mentat","homepage":"https://mozilla.github.io/mentat/","size":40735,"stargazers_count":1258,"watchers_count":1258,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":232,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":57,"open_issues":232,"watchers":1258,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"89d8ac50a85a2dc07701c74075f3fb0fcdc1467f","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":62660036,"node_id":"MDEwOlJlcG9zaXRvcnk2MjY2MDAzNg==","name":"mentat","full_name":"mozilla/mentat","owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/mentat","description":"A persistent, relational store inspired by Datomic and DataScript.","fork":false,"url":"https://api.github.com/repos/mozilla/mentat","forks_url":"https://api.github.com/repos/mozilla/mentat/forks","keys_url":"https://api.github.com/repos/mozilla/mentat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/mentat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/mentat/teams","hooks_url":"https://api.github.com/repos/mozilla/mentat/hooks","issue_events_url":"https://api.github.com/repos/mozilla/mentat/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/mentat/events","assignees_url":"https://api.github.com/repos/mozilla/mentat/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/mentat/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/mentat/tags","blobs_url":"https://api.github.com/repos/mozilla/mentat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/mentat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/mentat/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/mentat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/mentat/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/mentat/languages","stargazers_url":"https://api.github.com/repos/mozilla/mentat/stargazers","contributors_url":"https://api.github.com/repos/mozilla/mentat/contributors","subscribers_url":"https://api.github.com/repos/mozilla/mentat/subscribers","subscription_url":"https://api.github.com/repos/mozilla/mentat/subscription","commits_url":"https://api.github.com/repos/mozilla/mentat/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/mentat/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/mentat/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/mentat/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/mentat/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/mentat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/mentat/merges","archive_url":"https://api.github.com/repos/mozilla/mentat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/mentat/downloads","issues_url":"https://api.github.com/repos/mozilla/mentat/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/mentat/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/mentat/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/mentat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/mentat/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/mentat/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/mentat/deployments","created_at":"2016-07-05T18:29:34Z","updated_at":"2018-07-19T23:49:29Z","pushed_at":"2018-07-20T00:16:55Z","git_url":"git://github.com/mozilla/mentat.git","ssh_url":"git@github.com:mozilla/mentat.git","clone_url":"https://github.com/mozilla/mentat.git","svn_url":"https://github.com/mozilla/mentat","homepage":"https://mozilla.github.io/mentat/","size":40735,"stargazers_count":1258,"watchers_count":1258,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":232,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":57,"open_issues":232,"watchers":1258,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/mentat/pulls/783"},"html":{"href":"https://github.com/mozilla/mentat/pull/783"},"issue":{"href":"https://api.github.com/repos/mozilla/mentat/issues/783"},"comments":{"href":"https://api.github.com/repos/mozilla/mentat/issues/783/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/mentat/pulls/783/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/mentat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/mentat/pulls/783/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/mentat/statuses/4df29da9a4fcea401f86d576b6dce600055a6e70"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ncalexan"}}