{"action":"created","issue":{"url":"https://api.github.com/repos/reconhub/incidence/issues/59","repository_url":"https://api.github.com/repos/reconhub/incidence","labels_url":"https://api.github.com/repos/reconhub/incidence/issues/59/labels{/name}","comments_url":"https://api.github.com/repos/reconhub/incidence/issues/59/comments","events_url":"https://api.github.com/repos/reconhub/incidence/issues/59/events","html_url":"https://github.com/reconhub/incidence/pull/59","id":349070359,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MjcwOTg2","number":59,"title":"Allow separate fits per group for `fit_optim_split()`","user":{"login":"zkamvar","id":3639446,"node_id":"MDQ6VXNlcjM2Mzk0NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/3639446?v=4","gravatar_id":"","url":"https://api.github.com/users/zkamvar","html_url":"https://github.com/zkamvar","followers_url":"https://api.github.com/users/zkamvar/followers","following_url":"https://api.github.com/users/zkamvar/following{/other_user}","gists_url":"https://api.github.com/users/zkamvar/gists{/gist_id}","starred_url":"https://api.github.com/users/zkamvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zkamvar/subscriptions","organizations_url":"https://api.github.com/users/zkamvar/orgs","repos_url":"https://api.github.com/users/zkamvar/repos","events_url":"https://api.github.com/users/zkamvar/events{/privacy}","received_events_url":"https://api.github.com/users/zkamvar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-09T10:31:59Z","updated_at":"2018-08-10T08:13:12Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/reconhub/incidence/pulls/59","html_url":"https://github.com/reconhub/incidence/pull/59","diff_url":"https://github.com/reconhub/incidence/pull/59.diff","patch_url":"https://github.com/reconhub/incidence/pull/59.patch"},"body":"This implements an option `separate_split` in `fit_optim_split()` that allows the groups to have separate split dates to fix #39. I've also raised the coverage to >97%\r\n\r\n\r\nChanges\r\n========\r\n\r\n* `fit_optim_split()` now gains a `separate_split` argument that will determine\r\n  the optimal split separately for groups.\r\n\r\n* A new class, `incidence_fit_list`, has been implemented to store and summarise\r\n  `incidence_fit` objects within a nested list. This is the class returned by\r\n  in the `$fit` element of `fit_optim_split()`.\r\n\r\n* `find_peak()` gains the argument `pool`, giving the user the choice to find the \r\n  peak per group or pooled.\r\n\r\n* `get_counts()` returns the matrix of case counts for each date.\r\n\r\n* `get_fit()` returns a list of `incidence_fit` objects from an\r\n  `incidence_fit_list` object.\r\n\r\n* `get_info()` returns information stored in the `$info` element of an \r\n  `incidence_fit`/`incidence_fit_list` object. "},"comment":{"url":"https://api.github.com/repos/reconhub/incidence/issues/comments/412010534","html_url":"https://github.com/reconhub/incidence/pull/59#issuecomment-412010534","issue_url":"https://api.github.com/repos/reconhub/incidence/issues/59","id":412010534,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjAxMDUzNA==","user":{"login":"zkamvar","id":3639446,"node_id":"MDQ6VXNlcjM2Mzk0NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/3639446?v=4","gravatar_id":"","url":"https://api.github.com/users/zkamvar","html_url":"https://github.com/zkamvar","followers_url":"https://api.github.com/users/zkamvar/followers","following_url":"https://api.github.com/users/zkamvar/following{/other_user}","gists_url":"https://api.github.com/users/zkamvar/gists{/gist_id}","starred_url":"https://api.github.com/users/zkamvar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zkamvar/subscriptions","organizations_url":"https://api.github.com/users/zkamvar/orgs","repos_url":"https://api.github.com/users/zkamvar/repos","events_url":"https://api.github.com/users/zkamvar/events{/privacy}","received_events_url":"https://api.github.com/users/zkamvar/received_events","type":"User","site_admin":false},"created_at":"2018-08-10T08:13:12Z","updated_at":"2018-08-10T08:13:12Z","author_association":"MEMBER","body":"I'll consider that good enough. And if @thibautjombart doesn't like this change, then he shouldn't have made me maintainer :stuck_out_tongue_winking_eye: "}}
{"actor":{"display_login":"zkamvar"}}