{"action":"created","comment":{"url":"https://api.github.com/repos/spotify/featran/pulls/comments/199634993","pull_request_review_id":133784139,"id":199634993,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTYzNDk5Mw==","diff_hunk":"@@ -0,0 +1,180 @@\n+/*\n+ * Copyright 2017 Spotify AB.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied.  See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+\n+package com.spotify.featran.tensorflow\n+\n+import com.spotify.featran.FeatureSpec\n+import com.spotify.featran.transformers._\n+import org.scalacheck.{Arbitrary, Gen, Prop, Properties}\n+import org.tensorflow.example.{Example, Feature, Features}\n+import shapeless.datatype.tensorflow._\n+\n+case class TFRecord(d: Float, optD: Option[Float])\n+\n+case class TFStr(d: String)\n+\n+class ExampleTransformerSpec extends Properties(\"FeatureSpec\") {","path":"tensorflow/src/test/scala/com/spotify/featran/tensorflow/ExampleTransformerSpec.scala","position":30,"original_position":30,"commit_id":"ac7afd18cc21385c0f977115656a9028333e9039","original_commit_id":"ac7afd18cc21385c0f977115656a9028333e9039","user":{"login":"ravwojdyla","id":1419010,"node_id":"MDQ6VXNlcjE0MTkwMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/1419010?v=4","gravatar_id":"","url":"https://api.github.com/users/ravwojdyla","html_url":"https://github.com/ravwojdyla","followers_url":"https://api.github.com/users/ravwojdyla/followers","following_url":"https://api.github.com/users/ravwojdyla/following{/other_user}","gists_url":"https://api.github.com/users/ravwojdyla/gists{/gist_id}","starred_url":"https://api.github.com/users/ravwojdyla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravwojdyla/subscriptions","organizations_url":"https://api.github.com/users/ravwojdyla/orgs","repos_url":"https://api.github.com/users/ravwojdyla/repos","events_url":"https://api.github.com/users/ravwojdyla/events{/privacy}","received_events_url":"https://api.github.com/users/ravwojdyla/received_events","type":"User","site_admin":false},"body":"`\"FeatureSpec\"` -> `\"ExampleTransformerSpec\"`?","created_at":"2018-07-02T22:08:18Z","updated_at":"2018-07-02T22:16:52Z","html_url":"https://github.com/spotify/featran/pull/153#discussion_r199634993","pull_request_url":"https://api.github.com/repos/spotify/featran/pulls/153","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spotify/featran/pulls/comments/199634993"},"html":{"href":"https://github.com/spotify/featran/pull/153#discussion_r199634993"},"pull_request":{"href":"https://api.github.com/repos/spotify/featran/pulls/153"}}},"pull_request":{"url":"https://api.github.com/repos/spotify/featran/pulls/153","id":197830178,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3ODMwMTc4","html_url":"https://github.com/spotify/featran/pull/153","diff_url":"https://github.com/spotify/featran/pull/153.diff","patch_url":"https://github.com/spotify/featran/pull/153.patch","issue_url":"https://api.github.com/repos/spotify/featran/issues/153","number":153,"state":"open","locked":false,"title":"New Class that applies transformations from a settings file on TFRecords","user":{"login":"richwhitjr","id":202552,"node_id":"MDQ6VXNlcjIwMjU1Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/202552?v=4","gravatar_id":"","url":"https://api.github.com/users/richwhitjr","html_url":"https://github.com/richwhitjr","followers_url":"https://api.github.com/users/richwhitjr/followers","following_url":"https://api.github.com/users/richwhitjr/following{/other_user}","gists_url":"https://api.github.com/users/richwhitjr/gists{/gist_id}","starred_url":"https://api.github.com/users/richwhitjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richwhitjr/subscriptions","organizations_url":"https://api.github.com/users/richwhitjr/orgs","repos_url":"https://api.github.com/users/richwhitjr/repos","events_url":"https://api.github.com/users/richwhitjr/events{/privacy}","received_events_url":"https://api.github.com/users/richwhitjr/received_events","type":"User","site_admin":false},"body":"This is a new option for Featran architectures that would allow systems to move closer to how TF normally handles transformations.  Using this function a service for example does not necessarily need to have updated dependencies with the scala object.  Instead a pipeline or another client can handle the conversion to TFRecords and the service only needs to read the json settings file to do the conversion.  This will allow for settings files to be versioned with models without also a dependency on code versions.","created_at":"2018-06-27T19:28:55Z","updated_at":"2018-07-02T22:16:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"556f6dcbd27abd01a2389117e98151441134fcf9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"regadas","id":163899,"node_id":"MDQ6VXNlcjE2Mzg5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/163899?v=4","gravatar_id":"","url":"https://api.github.com/users/regadas","html_url":"https://github.com/regadas","followers_url":"https://api.github.com/users/regadas/followers","following_url":"https://api.github.com/users/regadas/following{/other_user}","gists_url":"https://api.github.com/users/regadas/gists{/gist_id}","starred_url":"https://api.github.com/users/regadas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regadas/subscriptions","organizations_url":"https://api.github.com/users/regadas/orgs","repos_url":"https://api.github.com/users/regadas/repos","events_url":"https://api.github.com/users/regadas/events{/privacy}","received_events_url":"https://api.github.com/users/regadas/received_events","type":"User","site_admin":false},{"login":"fallonchen","id":7786007,"node_id":"MDQ6VXNlcjc3ODYwMDc=","avatar_url":"https://avatars2.githubusercontent.com/u/7786007?v=4","gravatar_id":"","url":"https://api.github.com/users/fallonchen","html_url":"https://github.com/fallonchen","followers_url":"https://api.github.com/users/fallonchen/followers","following_url":"https://api.github.com/users/fallonchen/following{/other_user}","gists_url":"https://api.github.com/users/fallonchen/gists{/gist_id}","starred_url":"https://api.github.com/users/fallonchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fallonchen/subscriptions","organizations_url":"https://api.github.com/users/fallonchen/orgs","repos_url":"https://api.github.com/users/fallonchen/repos","events_url":"https://api.github.com/users/fallonchen/events{/privacy}","received_events_url":"https://api.github.com/users/fallonchen/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spotify/featran/pulls/153/commits","review_comments_url":"https://api.github.com/repos/spotify/featran/pulls/153/comments","review_comment_url":"https://api.github.com/repos/spotify/featran/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spotify/featran/issues/153/comments","statuses_url":"https://api.github.com/repos/spotify/featran/statuses/ac7afd18cc21385c0f977115656a9028333e9039","head":{"label":"spotify:richwhitjr/example_transformer","ref":"richwhitjr/example_transformer","sha":"ac7afd18cc21385c0f977115656a9028333e9039","user":{"login":"spotify","id":251374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTM3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":90654004,"node_id":"MDEwOlJlcG9zaXRvcnk5MDY1NDAwNA==","name":"featran","full_name":"spotify/featran","owner":{"login":"spotify","id":251374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTM3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/featran","description":"A Scala feature transformation library for data science and machine learning","fork":false,"url":"https://api.github.com/repos/spotify/featran","forks_url":"https://api.github.com/repos/spotify/featran/forks","keys_url":"https://api.github.com/repos/spotify/featran/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/featran/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/featran/teams","hooks_url":"https://api.github.com/repos/spotify/featran/hooks","issue_events_url":"https://api.github.com/repos/spotify/featran/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/featran/events","assignees_url":"https://api.github.com/repos/spotify/featran/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/featran/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/featran/tags","blobs_url":"https://api.github.com/repos/spotify/featran/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/featran/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/featran/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/featran/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/featran/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/featran/languages","stargazers_url":"https://api.github.com/repos/spotify/featran/stargazers","contributors_url":"https://api.github.com/repos/spotify/featran/contributors","subscribers_url":"https://api.github.com/repos/spotify/featran/subscribers","subscription_url":"https://api.github.com/repos/spotify/featran/subscription","commits_url":"https://api.github.com/repos/spotify/featran/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/featran/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/featran/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/featran/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/featran/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/featran/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/featran/merges","archive_url":"https://api.github.com/repos/spotify/featran/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/featran/downloads","issues_url":"https://api.github.com/repos/spotify/featran/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/featran/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/featran/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/featran/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/featran/labels{/name}","releases_url":"https://api.github.com/repos/spotify/featran/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/featran/deployments","created_at":"2017-05-08T17:20:27Z","updated_at":"2018-07-02T15:51:14Z","pushed_at":"2018-07-02T20:44:27Z","git_url":"git://github.com/spotify/featran.git","ssh_url":"git@github.com:spotify/featran.git","clone_url":"https://github.com/spotify/featran.git","svn_url":"https://github.com/spotify/featran","homepage":"https://spotify.github.io/featran","size":1122,"stargazers_count":183,"watchers_count":183,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":30,"open_issues":22,"watchers":183,"default_branch":"master"}},"base":{"label":"spotify:master","ref":"master","sha":"ecac9653cf520162f883747c01445027c6ca8207","user":{"login":"spotify","id":251374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTM3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":90654004,"node_id":"MDEwOlJlcG9zaXRvcnk5MDY1NDAwNA==","name":"featran","full_name":"spotify/featran","owner":{"login":"spotify","id":251374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTM3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/featran","description":"A Scala feature transformation library for data science and machine learning","fork":false,"url":"https://api.github.com/repos/spotify/featran","forks_url":"https://api.github.com/repos/spotify/featran/forks","keys_url":"https://api.github.com/repos/spotify/featran/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/featran/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/featran/teams","hooks_url":"https://api.github.com/repos/spotify/featran/hooks","issue_events_url":"https://api.github.com/repos/spotify/featran/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/featran/events","assignees_url":"https://api.github.com/repos/spotify/featran/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/featran/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/featran/tags","blobs_url":"https://api.github.com/repos/spotify/featran/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/featran/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/featran/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/featran/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/featran/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/featran/languages","stargazers_url":"https://api.github.com/repos/spotify/featran/stargazers","contributors_url":"https://api.github.com/repos/spotify/featran/contributors","subscribers_url":"https://api.github.com/repos/spotify/featran/subscribers","subscription_url":"https://api.github.com/repos/spotify/featran/subscription","commits_url":"https://api.github.com/repos/spotify/featran/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/featran/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/featran/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/featran/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/featran/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/featran/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/featran/merges","archive_url":"https://api.github.com/repos/spotify/featran/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/featran/downloads","issues_url":"https://api.github.com/repos/spotify/featran/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/featran/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/featran/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/featran/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/featran/labels{/name}","releases_url":"https://api.github.com/repos/spotify/featran/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/featran/deployments","created_at":"2017-05-08T17:20:27Z","updated_at":"2018-07-02T15:51:14Z","pushed_at":"2018-07-02T20:44:27Z","git_url":"git://github.com/spotify/featran.git","ssh_url":"git@github.com:spotify/featran.git","clone_url":"https://github.com/spotify/featran.git","svn_url":"https://github.com/spotify/featran","homepage":"https://spotify.github.io/featran","size":1122,"stargazers_count":183,"watchers_count":183,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":30,"open_issues":22,"watchers":183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spotify/featran/pulls/153"},"html":{"href":"https://github.com/spotify/featran/pull/153"},"issue":{"href":"https://api.github.com/repos/spotify/featran/issues/153"},"comments":{"href":"https://api.github.com/repos/spotify/featran/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/spotify/featran/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/spotify/featran/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spotify/featran/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/spotify/featran/statuses/ac7afd18cc21385c0f977115656a9028333e9039"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ravwojdyla"}}