{"action":"created","comment":{"url":"https://api.github.com/repos/CloakProject/CloakCoin/pulls/comments/181491644","pull_request_review_id":112136546,"id":181491644,"diff_hunk":"@@ -1,150 +1,268 @@\n-QT += core gui network\n-QT += widgets\n+########################\n+# Introduction\n+########################\n+#\n+# This is the file that controls how the Qt GUI wallet is built\n+# It is the same for all platforms: use qmake to compile it to a Makefile (that will be specific to your platform)\n+# Then run make to build the wallet.\n+# It is splitted into sections:\n+# * QT configuration: generic configuration specific to Qt\n+# * Debug variables: variables you want to switch on or off to ease debugging\n+# * Where to compile: the location where the various object files will be located. By default, everything goes to the \"build\" directory\n+# * Platform defines: make the platform visible to the code via compiler DEFINE\n+# * Mandatory dependencies: see README.md for more explanations, especially about specific version and how to install\n+# * Optional Dependencies: turn them on or off through qmake arguments. See README.md for more explanations\n+# * Security flags: various compiler flags to improve security\n+# * Other compiler flags: various compiler flags, explained\n+# * Translations: build the translations\n+# * Files to compile: the list of all files that have to be compiled\n+# * Misc: things that don't really fit anywhere else\n+\n+\n+########################\n+# QT configuration\n+########################\n+\n+# QT modules we use. Widgets are since QT 4, but we don't support under that anyway\n+QT += core gui network widgets\n TEMPLATE = app\n-TARGET = cloakcoin-qt\n-VERSION = 0.7.2\n-INCLUDEPATH += src src/json src/qt src/tor\n-DEFINES += QT_GUI BOOST_THREAD_USE_LIB BOOST_SPIRIT_THREADSAFE BOOST_THREAD_PROVIDES_GENERIC_SHARED_MUTEX_ON_WIN __NO_SYSTEM_INCLUDES\n-#DEFINES += CURL_STATICLIB\n-CONFIG += no_include_pwd\n-CONFIG += thread\n-CONFIG += static\n \n-message($$QMAKESPEC)\n+# The output file name. The extension depends on the OS\n+TARGET = cloakcoin-qt\n \n-#PRECOMPILED_HEADER = src/stable.h\n+# Current app version\n+VERSION = 2.1.0\n \n-#DEFINES += DEBUG_LOCKCONTENTION DEBUG_LOCKORDER\n+# We should aim to have a clean up-to-date build\n+# Emit warnings for deprecations. \n+#DEFINES += QT_DEPRECATED_WARNINGS\n \n-#CONFIG += console\n-# UNCOMMENT THIS TO GET CONSOLE QDEBUG OUTPUT\n-# CONFIG += console\n+# disables all the APIs deprecated before Qt 5.6\n+#DEFINES += QT_DISABLE_DEPRECATED_BEFORE=0x050600\n \n+# But that's not the case yet, so avoid disabling deprecated for now\n greaterThan(QT_MAJOR_VERSION, 4) {\n     DEFINES += QT_DISABLE_DEPRECATED_BEFORE=0\n }\n \n+# Is that actually necessary?\n+DEFINES += QT_GUI \n+\n+CONFIG += no_include_pwd thread static c++11\n+INCLUDEPATH += src src/json src/qt src/tor\n+\n+# \"Other files\" to show in Qt Creator\n+OTHER_FILES += \\\n+    doc/*.rst doc/*.txt doc/README \\\n+    README.md \\\n+    res/bitcoin-qt.rc \\\n+    src/test/*.cpp src/test/*.h src/qt/test/*.cpp src/qt/test/*.h \\\n+    src/qt/locale/*.ts\n+\n+########################\n+# Debug variables\n+########################\n+\n+# UNCOMMENT THIS TO GET CONSOLE QDEBUG OUTPUT\n+#CONFIG += console\n+\n+#DEFINES += DEBUG_LOCKCONTENTION\n+#DEFINES += DEBUG_LOCKORDER\n+\n #DEFINES += ENABLE_WALLET\n \n+########################\n+# Where to compile\n+########################\n+\n OBJECTS_DIR = build\n MOC_DIR = build\n UI_DIR = build\n+RCC_DIR = build\n \n-message(LIBS = $$LIBS)\n+########################\n+# Platform defines\n+########################\n+\n+win32:DEFINES += WIN32\n+linux:DEFINES += LINUX\n+macx:DEFINES += MAC_OSX\n+\n+\n+########################\n+# Mandatory Dependencies\n+########################\n+\n+# Configure boost\n+DEFINES += BOOST_THREAD_USE_LIB BOOST_SPIRIT_THREADSAFE BOOST_THREAD_PROVIDES_GENERIC_SHARED_MUTEX_ON_WIN\n+\n+# What's that? The only Google match I found is form Berkely DB. We might not need that\n+DEFINES +=  __NO_SYSTEM_INCLUDES","path":"cloakcoin-qt.pro","position":117,"original_position":117,"commit_id":"1a9a7b37173be3ff9c66ac525d09ca33c697da2e","original_commit_id":"1a9a7b37173be3ff9c66ac525d09ca33c697da2e","user":{"login":"anorakthagreat","id":33412340,"avatar_url":"https://avatars2.githubusercontent.com/u/33412340?v=4","gravatar_id":"","url":"https://api.github.com/users/anorakthagreat","html_url":"https://github.com/anorakthagreat","followers_url":"https://api.github.com/users/anorakthagreat/followers","following_url":"https://api.github.com/users/anorakthagreat/following{/other_user}","gists_url":"https://api.github.com/users/anorakthagreat/gists{/gist_id}","starred_url":"https://api.github.com/users/anorakthagreat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anorakthagreat/subscriptions","organizations_url":"https://api.github.com/users/anorakthagreat/orgs","repos_url":"https://api.github.com/users/anorakthagreat/repos","events_url":"https://api.github.com/users/anorakthagreat/events{/privacy}","received_events_url":"https://api.github.com/users/anorakthagreat/received_events","type":"User","site_admin":false},"body":"This one instructs the compiler/linker to not look at default system include paths, for gcc it would be equivalent as `-nostdinc` flag.","created_at":"2018-04-13T19:40:41Z","updated_at":"2018-04-13T19:40:41Z","html_url":"https://github.com/CloakProject/CloakCoin/pull/9#discussion_r181491644","pull_request_url":"https://api.github.com/repos/CloakProject/CloakCoin/pulls/9","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CloakProject/CloakCoin/pulls/comments/181491644"},"html":{"href":"https://github.com/CloakProject/CloakCoin/pull/9#discussion_r181491644"},"pull_request":{"href":"https://api.github.com/repos/CloakProject/CloakCoin/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/CloakProject/CloakCoin/pulls/9","id":171120604,"html_url":"https://github.com/CloakProject/CloakCoin/pull/9","diff_url":"https://github.com/CloakProject/CloakCoin/pull/9.diff","patch_url":"https://github.com/CloakProject/CloakCoin/pull/9.patch","issue_url":"https://api.github.com/repos/CloakProject/CloakCoin/issues/9","number":9,"state":"open","locked":false,"title":"Improve .pro, improve readme and add Linux and Mac build instructions","user":{"login":"fradow-cloak","id":35728526,"avatar_url":"https://avatars0.githubusercontent.com/u/35728526?v=4","gravatar_id":"","url":"https://api.github.com/users/fradow-cloak","html_url":"https://github.com/fradow-cloak","followers_url":"https://api.github.com/users/fradow-cloak/followers","following_url":"https://api.github.com/users/fradow-cloak/following{/other_user}","gists_url":"https://api.github.com/users/fradow-cloak/gists{/gist_id}","starred_url":"https://api.github.com/users/fradow-cloak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fradow-cloak/subscriptions","organizations_url":"https://api.github.com/users/fradow-cloak/orgs","repos_url":"https://api.github.com/users/fradow-cloak/repos","events_url":"https://api.github.com/users/fradow-cloak/events{/privacy}","received_events_url":"https://api.github.com/users/fradow-cloak/received_events","type":"User","site_admin":false},"body":"This is a big PR because it wasn't easy to split work into different PRs.\r\n\r\nI personally tested the build on:\r\n- Windows XP VM provided by anorak\r\n- Lubuntu\r\n- Debian Jessie\r\n- Mac OS X Sierra (10.12)\r\n\r\nThe .pro here was the one used to create version 2.1.0.0 of the Mac wallet.\r\n\r\nHere is a list of changes:\r\n- gitignored and remove some files that should be and that are safe to delete (files that should be but are used for the build were not modified or removed for the time being)\r\n- put Enigma explanation in a separate file, referenced from Readme\r\n- totally rewrite Readme to put information you'd expect there (there is still room for improvement)\r\n- big refactor of cloakcoin-qt.pro, which was a mess (remove duplicates, refactor to have sections, remove useless commands)\r\n- fix and simplify Mac build, and add instructions to compile on Mac\r\n- add instructions to compile on Ubuntu, as well as some troubleshooting for Debian (to enrich when we get more infos about other Linux)\r\n\r\nWindows instructions are not there yet. I figured it would be best to have instructions for the Mac build as well as working Mac compilation now rather than later.\r\n\r\nFeel free to comment on things you want improved before merging.","created_at":"2018-02-23T21:28:59Z","updated_at":"2018-04-13T19:40:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c98e61e60984b9a842eca3cbaf20e527f81b4413","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CloakProject/CloakCoin/pulls/9/commits","review_comments_url":"https://api.github.com/repos/CloakProject/CloakCoin/pulls/9/comments","review_comment_url":"https://api.github.com/repos/CloakProject/CloakCoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CloakProject/CloakCoin/issues/9/comments","statuses_url":"https://api.github.com/repos/CloakProject/CloakCoin/statuses/1a9a7b37173be3ff9c66ac525d09ca33c697da2e","head":{"label":"fradow-cloak:improve-build-readme-2.1.0","ref":"improve-build-readme-2.1.0","sha":"1a9a7b37173be3ff9c66ac525d09ca33c697da2e","user":{"login":"fradow-cloak","id":35728526,"avatar_url":"https://avatars0.githubusercontent.com/u/35728526?v=4","gravatar_id":"","url":"https://api.github.com/users/fradow-cloak","html_url":"https://github.com/fradow-cloak","followers_url":"https://api.github.com/users/fradow-cloak/followers","following_url":"https://api.github.com/users/fradow-cloak/following{/other_user}","gists_url":"https://api.github.com/users/fradow-cloak/gists{/gist_id}","starred_url":"https://api.github.com/users/fradow-cloak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fradow-cloak/subscriptions","organizations_url":"https://api.github.com/users/fradow-cloak/orgs","repos_url":"https://api.github.com/users/fradow-cloak/repos","events_url":"https://api.github.com/users/fradow-cloak/events{/privacy}","received_events_url":"https://api.github.com/users/fradow-cloak/received_events","type":"User","site_admin":false},"repo":{"id":118606704,"name":"CloakCoin","full_name":"fradow-cloak/CloakCoin","owner":{"login":"fradow-cloak","id":35728526,"avatar_url":"https://avatars0.githubusercontent.com/u/35728526?v=4","gravatar_id":"","url":"https://api.github.com/users/fradow-cloak","html_url":"https://github.com/fradow-cloak","followers_url":"https://api.github.com/users/fradow-cloak/followers","following_url":"https://api.github.com/users/fradow-cloak/following{/other_user}","gists_url":"https://api.github.com/users/fradow-cloak/gists{/gist_id}","starred_url":"https://api.github.com/users/fradow-cloak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fradow-cloak/subscriptions","organizations_url":"https://api.github.com/users/fradow-cloak/orgs","repos_url":"https://api.github.com/users/fradow-cloak/repos","events_url":"https://api.github.com/users/fradow-cloak/events{/privacy}","received_events_url":"https://api.github.com/users/fradow-cloak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fradow-cloak/CloakCoin","description":null,"fork":true,"url":"https://api.github.com/repos/fradow-cloak/CloakCoin","forks_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/forks","keys_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/teams","hooks_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/hooks","issue_events_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/issues/events{/number}","events_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/events","assignees_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/assignees{/user}","branches_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/branches{/branch}","tags_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/tags","blobs_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/statuses/{sha}","languages_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/languages","stargazers_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/stargazers","contributors_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/contributors","subscribers_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/subscribers","subscription_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/subscription","commits_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/contents/{+path}","compare_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/merges","archive_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/downloads","issues_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/issues{/number}","pulls_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/pulls{/number}","milestones_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/milestones{/number}","notifications_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/labels{/name}","releases_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/releases{/id}","deployments_url":"https://api.github.com/repos/fradow-cloak/CloakCoin/deployments","created_at":"2018-01-23T12:21:15Z","updated_at":"2018-02-19T20:43:44Z","pushed_at":"2018-04-13T19:12:25Z","git_url":"git://github.com/fradow-cloak/CloakCoin.git","ssh_url":"git@github.com:fradow-cloak/CloakCoin.git","clone_url":"https://github.com/fradow-cloak/CloakCoin.git","svn_url":"https://github.com/fradow-cloak/CloakCoin","homepage":null,"size":11120,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"anorak_master"}},"base":{"label":"CloakProject:2.1.0","ref":"2.1.0","sha":"10df3d27e5a5143198436bac20b298e96e152e10","user":{"login":"CloakProject","id":29306334,"avatar_url":"https://avatars1.githubusercontent.com/u/29306334?v=4","gravatar_id":"","url":"https://api.github.com/users/CloakProject","html_url":"https://github.com/CloakProject","followers_url":"https://api.github.com/users/CloakProject/followers","following_url":"https://api.github.com/users/CloakProject/following{/other_user}","gists_url":"https://api.github.com/users/CloakProject/gists{/gist_id}","starred_url":"https://api.github.com/users/CloakProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CloakProject/subscriptions","organizations_url":"https://api.github.com/users/CloakProject/orgs","repos_url":"https://api.github.com/users/CloakProject/repos","events_url":"https://api.github.com/users/CloakProject/events{/privacy}","received_events_url":"https://api.github.com/users/CloakProject/received_events","type":"Organization","site_admin":false},"repo":{"id":115882382,"name":"CloakCoin","full_name":"CloakProject/CloakCoin","owner":{"login":"CloakProject","id":29306334,"avatar_url":"https://avatars1.githubusercontent.com/u/29306334?v=4","gravatar_id":"","url":"https://api.github.com/users/CloakProject","html_url":"https://github.com/CloakProject","followers_url":"https://api.github.com/users/CloakProject/followers","following_url":"https://api.github.com/users/CloakProject/following{/other_user}","gists_url":"https://api.github.com/users/CloakProject/gists{/gist_id}","starred_url":"https://api.github.com/users/CloakProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CloakProject/subscriptions","organizations_url":"https://api.github.com/users/CloakProject/orgs","repos_url":"https://api.github.com/users/CloakProject/repos","events_url":"https://api.github.com/users/CloakProject/events{/privacy}","received_events_url":"https://api.github.com/users/CloakProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CloakProject/CloakCoin","description":null,"fork":false,"url":"https://api.github.com/repos/CloakProject/CloakCoin","forks_url":"https://api.github.com/repos/CloakProject/CloakCoin/forks","keys_url":"https://api.github.com/repos/CloakProject/CloakCoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CloakProject/CloakCoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CloakProject/CloakCoin/teams","hooks_url":"https://api.github.com/repos/CloakProject/CloakCoin/hooks","issue_events_url":"https://api.github.com/repos/CloakProject/CloakCoin/issues/events{/number}","events_url":"https://api.github.com/repos/CloakProject/CloakCoin/events","assignees_url":"https://api.github.com/repos/CloakProject/CloakCoin/assignees{/user}","branches_url":"https://api.github.com/repos/CloakProject/CloakCoin/branches{/branch}","tags_url":"https://api.github.com/repos/CloakProject/CloakCoin/tags","blobs_url":"https://api.github.com/repos/CloakProject/CloakCoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CloakProject/CloakCoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CloakProject/CloakCoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/CloakProject/CloakCoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CloakProject/CloakCoin/statuses/{sha}","languages_url":"https://api.github.com/repos/CloakProject/CloakCoin/languages","stargazers_url":"https://api.github.com/repos/CloakProject/CloakCoin/stargazers","contributors_url":"https://api.github.com/repos/CloakProject/CloakCoin/contributors","subscribers_url":"https://api.github.com/repos/CloakProject/CloakCoin/subscribers","subscription_url":"https://api.github.com/repos/CloakProject/CloakCoin/subscription","commits_url":"https://api.github.com/repos/CloakProject/CloakCoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/CloakProject/CloakCoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/CloakProject/CloakCoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/CloakProject/CloakCoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/CloakProject/CloakCoin/contents/{+path}","compare_url":"https://api.github.com/repos/CloakProject/CloakCoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CloakProject/CloakCoin/merges","archive_url":"https://api.github.com/repos/CloakProject/CloakCoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CloakProject/CloakCoin/downloads","issues_url":"https://api.github.com/repos/CloakProject/CloakCoin/issues{/number}","pulls_url":"https://api.github.com/repos/CloakProject/CloakCoin/pulls{/number}","milestones_url":"https://api.github.com/repos/CloakProject/CloakCoin/milestones{/number}","notifications_url":"https://api.github.com/repos/CloakProject/CloakCoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CloakProject/CloakCoin/labels{/name}","releases_url":"https://api.github.com/repos/CloakProject/CloakCoin/releases{/id}","deployments_url":"https://api.github.com/repos/CloakProject/CloakCoin/deployments","created_at":"2017-12-31T19:46:48Z","updated_at":"2018-04-11T20:10:05Z","pushed_at":"2018-04-13T19:12:26Z","git_url":"git://github.com/CloakProject/CloakCoin.git","ssh_url":"git@github.com:CloakProject/CloakCoin.git","clone_url":"https://github.com/CloakProject/CloakCoin.git","svn_url":"https://github.com/CloakProject/CloakCoin","homepage":null,"size":9954,"stargazers_count":11,"watchers_count":11,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":13,"open_issues":8,"watchers":11,"default_branch":"2.1.0"}},"_links":{"self":{"href":"https://api.github.com/repos/CloakProject/CloakCoin/pulls/9"},"html":{"href":"https://github.com/CloakProject/CloakCoin/pull/9"},"issue":{"href":"https://api.github.com/repos/CloakProject/CloakCoin/issues/9"},"comments":{"href":"https://api.github.com/repos/CloakProject/CloakCoin/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/CloakProject/CloakCoin/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/CloakProject/CloakCoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CloakProject/CloakCoin/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/CloakProject/CloakCoin/statuses/1a9a7b37173be3ff9c66ac525d09ca33c697da2e"}},"author_association":"NONE"}}
{"actor":{"display_login":"anorakthagreat"}}