{"action":"created","comment":{"url":"https://api.github.com/repos/djc/quinn/pulls/comments/236833195","pull_request_review_id":178980971,"id":236833195,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjgzMzE5NQ==","diff_hunk":"@@ -1101,10 +1074,9 @@ impl Connection {\n                                 self.handshake_cleanup(&ctx.config);\n                                 let mut msgs = Vec::new();\n                                 self.tls.write_tls(&mut msgs).unwrap();\n-                                if self.side == Side::Client {\n-                                    self.transmit_handshake(&msgs);\n-                                } else {\n-                                    self.transmit(StreamId(0), msgs.into());\n+                                self.transmit_handshake(&msgs);\n+                                if self.side == Side::Server {\n+                                    self.awaiting_handshake = false;","path":"quinn-proto/src/connection.rs","position":564,"original_position":182,"commit_id":"80ecc7b4adae3eabf257b4727973bd493de3b018","original_commit_id":"cdc65e0978385308c9d53e824e280d5cd6bd713c","user":{"login":"djc","id":158471,"node_id":"MDQ6VXNlcjE1ODQ3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/158471?v=4","gravatar_id":"","url":"https://api.github.com/users/djc","html_url":"https://github.com/djc","followers_url":"https://api.github.com/users/djc/followers","following_url":"https://api.github.com/users/djc/following{/other_user}","gists_url":"https://api.github.com/users/djc/gists{/gist_id}","starred_url":"https://api.github.com/users/djc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djc/subscriptions","organizations_url":"https://api.github.com/users/djc/orgs","repos_url":"https://api.github.com/users/djc/repos","events_url":"https://api.github.com/users/djc/events{/privacy}","received_events_url":"https://api.github.com/users/djc/received_events","type":"User","site_admin":false},"body":"Why do we actually need `awaiting_handshake`? Doesn't that somehow duplicate other bits of state we have in the `Connection` (like, perhaps, the actual `state`)?","created_at":"2018-11-27T20:26:37Z","updated_at":"2018-11-27T20:53:36Z","html_url":"https://github.com/djc/quinn/pull/98#discussion_r236833195","pull_request_url":"https://api.github.com/repos/djc/quinn/pulls/98","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/djc/quinn/pulls/comments/236833195"},"html":{"href":"https://github.com/djc/quinn/pull/98#discussion_r236833195"},"pull_request":{"href":"https://api.github.com/repos/djc/quinn/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/djc/quinn/pulls/98","id":233346533,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzQ2NTMz","html_url":"https://github.com/djc/quinn/pull/98","diff_url":"https://github.com/djc/quinn/pull/98.diff","patch_url":"https://github.com/djc/quinn/pull/98.patch","issue_url":"https://api.github.com/repos/djc/quinn/issues/98","number":98,"state":"open","locked":false,"title":"Draft 15 updates","user":{"login":"Ralith","id":104558,"node_id":"MDQ6VXNlcjEwNDU1OA==","avatar_url":"https://avatars2.githubusercontent.com/u/104558?v=4","gravatar_id":"","url":"https://api.github.com/users/Ralith","html_url":"https://github.com/Ralith","followers_url":"https://api.github.com/users/Ralith/followers","following_url":"https://api.github.com/users/Ralith/following{/other_user}","gists_url":"https://api.github.com/users/Ralith/gists{/gist_id}","starred_url":"https://api.github.com/users/Ralith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ralith/subscriptions","organizations_url":"https://api.github.com/users/Ralith/orgs","repos_url":"https://api.github.com/users/Ralith/repos","events_url":"https://api.github.com/users/Ralith/events{/privacy}","received_events_url":"https://api.github.com/users/Ralith/received_events","type":"User","site_admin":false},"body":"Independent fixes on the path towards updating the handshake state machine. I may add more to this as I pursue that goal.","created_at":"2018-11-24T23:42:09Z","updated_at":"2018-11-27T20:53:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bc97e7176bf486d918b4b9b34ad84eaa0bd6559","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/djc/quinn/pulls/98/commits","review_comments_url":"https://api.github.com/repos/djc/quinn/pulls/98/comments","review_comment_url":"https://api.github.com/repos/djc/quinn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/djc/quinn/issues/98/comments","statuses_url":"https://api.github.com/repos/djc/quinn/statuses/80ecc7b4adae3eabf257b4727973bd493de3b018","head":{"label":"djc:new-handshake","ref":"new-handshake","sha":"80ecc7b4adae3eabf257b4727973bd493de3b018","user":{"login":"djc","id":158471,"node_id":"MDQ6VXNlcjE1ODQ3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/158471?v=4","gravatar_id":"","url":"https://api.github.com/users/djc","html_url":"https://github.com/djc","followers_url":"https://api.github.com/users/djc/followers","following_url":"https://api.github.com/users/djc/following{/other_user}","gists_url":"https://api.github.com/users/djc/gists{/gist_id}","starred_url":"https://api.github.com/users/djc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djc/subscriptions","organizations_url":"https://api.github.com/users/djc/orgs","repos_url":"https://api.github.com/users/djc/repos","events_url":"https://api.github.com/users/djc/events{/privacy}","received_events_url":"https://api.github.com/users/djc/received_events","type":"User","site_admin":false},"repo":{"id":127870944,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc4NzA5NDQ=","name":"quinn","full_name":"djc/quinn","private":false,"owner":{"login":"djc","id":158471,"node_id":"MDQ6VXNlcjE1ODQ3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/158471?v=4","gravatar_id":"","url":"https://api.github.com/users/djc","html_url":"https://github.com/djc","followers_url":"https://api.github.com/users/djc/followers","following_url":"https://api.github.com/users/djc/following{/other_user}","gists_url":"https://api.github.com/users/djc/gists{/gist_id}","starred_url":"https://api.github.com/users/djc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djc/subscriptions","organizations_url":"https://api.github.com/users/djc/orgs","repos_url":"https://api.github.com/users/djc/repos","events_url":"https://api.github.com/users/djc/events{/privacy}","received_events_url":"https://api.github.com/users/djc/received_events","type":"User","site_admin":false},"html_url":"https://github.com/djc/quinn","description":"Futures-based QUIC implementation in Rust","fork":false,"url":"https://api.github.com/repos/djc/quinn","forks_url":"https://api.github.com/repos/djc/quinn/forks","keys_url":"https://api.github.com/repos/djc/quinn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/djc/quinn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/djc/quinn/teams","hooks_url":"https://api.github.com/repos/djc/quinn/hooks","issue_events_url":"https://api.github.com/repos/djc/quinn/issues/events{/number}","events_url":"https://api.github.com/repos/djc/quinn/events","assignees_url":"https://api.github.com/repos/djc/quinn/assignees{/user}","branches_url":"https://api.github.com/repos/djc/quinn/branches{/branch}","tags_url":"https://api.github.com/repos/djc/quinn/tags","blobs_url":"https://api.github.com/repos/djc/quinn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/djc/quinn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/djc/quinn/git/refs{/sha}","trees_url":"https://api.github.com/repos/djc/quinn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/djc/quinn/statuses/{sha}","languages_url":"https://api.github.com/repos/djc/quinn/languages","stargazers_url":"https://api.github.com/repos/djc/quinn/stargazers","contributors_url":"https://api.github.com/repos/djc/quinn/contributors","subscribers_url":"https://api.github.com/repos/djc/quinn/subscribers","subscription_url":"https://api.github.com/repos/djc/quinn/subscription","commits_url":"https://api.github.com/repos/djc/quinn/commits{/sha}","git_commits_url":"https://api.github.com/repos/djc/quinn/git/commits{/sha}","comments_url":"https://api.github.com/repos/djc/quinn/comments{/number}","issue_comment_url":"https://api.github.com/repos/djc/quinn/issues/comments{/number}","contents_url":"https://api.github.com/repos/djc/quinn/contents/{+path}","compare_url":"https://api.github.com/repos/djc/quinn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/djc/quinn/merges","archive_url":"https://api.github.com/repos/djc/quinn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/djc/quinn/downloads","issues_url":"https://api.github.com/repos/djc/quinn/issues{/number}","pulls_url":"https://api.github.com/repos/djc/quinn/pulls{/number}","milestones_url":"https://api.github.com/repos/djc/quinn/milestones{/number}","notifications_url":"https://api.github.com/repos/djc/quinn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/djc/quinn/labels{/name}","releases_url":"https://api.github.com/repos/djc/quinn/releases{/id}","deployments_url":"https://api.github.com/repos/djc/quinn/deployments","created_at":"2018-04-03T07:47:41Z","updated_at":"2018-11-27T20:47:19Z","pushed_at":"2018-11-27T18:44:56Z","git_url":"git://github.com/djc/quinn.git","ssh_url":"git@github.com:djc/quinn.git","clone_url":"https://github.com/djc/quinn.git","svn_url":"https://github.com/djc/quinn","homepage":null,"size":1021,"stargazers_count":244,"watchers_count":244,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":21,"open_issues":25,"watchers":244,"default_branch":"master"}},"base":{"label":"djc:master","ref":"master","sha":"f7e01ae1c9db771187593c6660a960a7b1e41b46","user":{"login":"djc","id":158471,"node_id":"MDQ6VXNlcjE1ODQ3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/158471?v=4","gravatar_id":"","url":"https://api.github.com/users/djc","html_url":"https://github.com/djc","followers_url":"https://api.github.com/users/djc/followers","following_url":"https://api.github.com/users/djc/following{/other_user}","gists_url":"https://api.github.com/users/djc/gists{/gist_id}","starred_url":"https://api.github.com/users/djc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djc/subscriptions","organizations_url":"https://api.github.com/users/djc/orgs","repos_url":"https://api.github.com/users/djc/repos","events_url":"https://api.github.com/users/djc/events{/privacy}","received_events_url":"https://api.github.com/users/djc/received_events","type":"User","site_admin":false},"repo":{"id":127870944,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc4NzA5NDQ=","name":"quinn","full_name":"djc/quinn","private":false,"owner":{"login":"djc","id":158471,"node_id":"MDQ6VXNlcjE1ODQ3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/158471?v=4","gravatar_id":"","url":"https://api.github.com/users/djc","html_url":"https://github.com/djc","followers_url":"https://api.github.com/users/djc/followers","following_url":"https://api.github.com/users/djc/following{/other_user}","gists_url":"https://api.github.com/users/djc/gists{/gist_id}","starred_url":"https://api.github.com/users/djc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djc/subscriptions","organizations_url":"https://api.github.com/users/djc/orgs","repos_url":"https://api.github.com/users/djc/repos","events_url":"https://api.github.com/users/djc/events{/privacy}","received_events_url":"https://api.github.com/users/djc/received_events","type":"User","site_admin":false},"html_url":"https://github.com/djc/quinn","description":"Futures-based QUIC implementation in Rust","fork":false,"url":"https://api.github.com/repos/djc/quinn","forks_url":"https://api.github.com/repos/djc/quinn/forks","keys_url":"https://api.github.com/repos/djc/quinn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/djc/quinn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/djc/quinn/teams","hooks_url":"https://api.github.com/repos/djc/quinn/hooks","issue_events_url":"https://api.github.com/repos/djc/quinn/issues/events{/number}","events_url":"https://api.github.com/repos/djc/quinn/events","assignees_url":"https://api.github.com/repos/djc/quinn/assignees{/user}","branches_url":"https://api.github.com/repos/djc/quinn/branches{/branch}","tags_url":"https://api.github.com/repos/djc/quinn/tags","blobs_url":"https://api.github.com/repos/djc/quinn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/djc/quinn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/djc/quinn/git/refs{/sha}","trees_url":"https://api.github.com/repos/djc/quinn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/djc/quinn/statuses/{sha}","languages_url":"https://api.github.com/repos/djc/quinn/languages","stargazers_url":"https://api.github.com/repos/djc/quinn/stargazers","contributors_url":"https://api.github.com/repos/djc/quinn/contributors","subscribers_url":"https://api.github.com/repos/djc/quinn/subscribers","subscription_url":"https://api.github.com/repos/djc/quinn/subscription","commits_url":"https://api.github.com/repos/djc/quinn/commits{/sha}","git_commits_url":"https://api.github.com/repos/djc/quinn/git/commits{/sha}","comments_url":"https://api.github.com/repos/djc/quinn/comments{/number}","issue_comment_url":"https://api.github.com/repos/djc/quinn/issues/comments{/number}","contents_url":"https://api.github.com/repos/djc/quinn/contents/{+path}","compare_url":"https://api.github.com/repos/djc/quinn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/djc/quinn/merges","archive_url":"https://api.github.com/repos/djc/quinn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/djc/quinn/downloads","issues_url":"https://api.github.com/repos/djc/quinn/issues{/number}","pulls_url":"https://api.github.com/repos/djc/quinn/pulls{/number}","milestones_url":"https://api.github.com/repos/djc/quinn/milestones{/number}","notifications_url":"https://api.github.com/repos/djc/quinn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/djc/quinn/labels{/name}","releases_url":"https://api.github.com/repos/djc/quinn/releases{/id}","deployments_url":"https://api.github.com/repos/djc/quinn/deployments","created_at":"2018-04-03T07:47:41Z","updated_at":"2018-11-27T20:47:19Z","pushed_at":"2018-11-27T18:44:56Z","git_url":"git://github.com/djc/quinn.git","ssh_url":"git@github.com:djc/quinn.git","clone_url":"https://github.com/djc/quinn.git","svn_url":"https://github.com/djc/quinn","homepage":null,"size":1021,"stargazers_count":244,"watchers_count":244,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":21,"open_issues":25,"watchers":244,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/djc/quinn/pulls/98"},"html":{"href":"https://github.com/djc/quinn/pull/98"},"issue":{"href":"https://api.github.com/repos/djc/quinn/issues/98"},"comments":{"href":"https://api.github.com/repos/djc/quinn/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/djc/quinn/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/djc/quinn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/djc/quinn/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/djc/quinn/statuses/80ecc7b4adae3eabf257b4727973bd493de3b018"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"djc"}}