{"action":"created","issue":{"url":"https://api.github.com/repos/gardener/gardener/issues/318","repository_url":"https://api.github.com/repos/gardener/gardener","labels_url":"https://api.github.com/repos/gardener/gardener/issues/318/labels{/name}","comments_url":"https://api.github.com/repos/gardener/gardener/issues/318/comments","events_url":"https://api.github.com/repos/gardener/gardener/issues/318/events","html_url":"https://github.com/gardener/gardener/pull/318","id":349911507,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODg3NDgw","number":318,"title":"remove finalizers from apiservice registration","user":{"login":"mvladev","id":33343952,"node_id":"MDQ6VXNlcjMzMzQzOTUy","avatar_url":"https://avatars1.githubusercontent.com/u/33343952?v=4","gravatar_id":"","url":"https://api.github.com/users/mvladev","html_url":"https://github.com/mvladev","followers_url":"https://api.github.com/users/mvladev/followers","following_url":"https://api.github.com/users/mvladev/following{/other_user}","gists_url":"https://api.github.com/users/mvladev/gists{/gist_id}","starred_url":"https://api.github.com/users/mvladev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvladev/subscriptions","organizations_url":"https://api.github.com/users/mvladev/orgs","repos_url":"https://api.github.com/users/mvladev/repos","events_url":"https://api.github.com/users/mvladev/events{/privacy}","received_events_url":"https://api.github.com/users/mvladev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-13T07:10:45Z","updated_at":"2018-08-13T07:16:29Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/gardener/gardener/pulls/318","html_url":"https://github.com/gardener/gardener/pull/318","diff_url":"https://github.com/gardener/gardener/pull/318.diff","patch_url":"https://github.com/gardener/gardener/pull/318.patch"},"body":"**What this PR does / why we need it**: apiservices have finalizers, which prevents deletion, especially in the local development case when the gardener apiserver is down.\r\n\r\n**Which issue(s) this PR fixes**:\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your release note in the below block.\r\n2. If no release note is required, just write \"NONE\" within the block.\r\n\r\nFormat of block header: <category> <target_group>\r\nPossible values:\r\n- category:       improvement|noteworthy\r\n- target_group:   user|operator\r\n-->\r\n```improvement operator\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/gardener/gardener/issues/comments/412428872","html_url":"https://github.com/gardener/gardener/pull/318#issuecomment-412428872","issue_url":"https://api.github.com/repos/gardener/gardener/issues/318","id":412428872,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjQyODg3Mg==","user":{"login":"rfranzke","id":19169361,"node_id":"MDQ6VXNlcjE5MTY5MzYx","avatar_url":"https://avatars1.githubusercontent.com/u/19169361?v=4","gravatar_id":"","url":"https://api.github.com/users/rfranzke","html_url":"https://github.com/rfranzke","followers_url":"https://api.github.com/users/rfranzke/followers","following_url":"https://api.github.com/users/rfranzke/following{/other_user}","gists_url":"https://api.github.com/users/rfranzke/gists{/gist_id}","starred_url":"https://api.github.com/users/rfranzke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfranzke/subscriptions","organizations_url":"https://api.github.com/users/rfranzke/orgs","repos_url":"https://api.github.com/users/rfranzke/repos","events_url":"https://api.github.com/users/rfranzke/events{/privacy}","received_events_url":"https://api.github.com/users/rfranzke/received_events","type":"User","site_admin":false},"created_at":"2018-08-13T07:16:29Z","updated_at":"2018-08-13T07:16:29Z","author_association":"MEMBER","body":"Just checked, in my local installation there are no finalizers on the `APIService` object:\r\n\r\n```yaml\r\n$ k get apiservice v1beta1.garden.sapcloud.io -o yaml\r\napiVersion: apiregistration.k8s.io/v1\r\nkind: APIService\r\nmetadata:\r\n  annotations:\r\n    kubectl.kubernetes.io/last-applied-configuration: |\r\n      ...\r\n  creationTimestamp: 2018-08-13T06:32:39Z\r\n  name: v1beta1.garden.sapcloud.io\r\n  resourceVersion: \"79505\"\r\n  selfLink: /apis/apiregistration.k8s.io/v1/apiservices/v1beta1.garden.sapcloud.io\r\n  uid: aca23805-9ec2-11e8-a35c-025000000001\r\nspec:\r\n  ...\r\n```\r\n\r\nExecuting the script would fail as the `kubectl delete apiservice` call will delete the object immediately.\r\n\r\nWhy is that (no finalizers)? Server version is `1.10.3`"}}
{"actor":{"display_login":"rfranzke"}}