{"action":"created","comment":{"url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments/187369904","pull_request_review_id":119136783,"id":187369904,"diff_hunk":"@@ -96,7 +98,7 @@ typedef enum\n  * Example: a libc-based port may implement this with vfprintf(stderr) or\n  * vfprintf(logfile), or both, depending on log level.\n  */\n-void jerry_port_log (jerry_log_level_t level, const char *format, ...) __attribute__ ((format (printf, 2, 3)));\n+void JERRY_ATTR_FORMAT (printf, 2, 3) jerry_port_log (jerry_log_level_t level, const char *format, ...);","path":"jerry-core/include/jerryscript-port.h","position":23,"original_position":23,"commit_id":"f3a6b7c0402615a6e540c28f44f56862468e0153","original_commit_id":"f3a6b7c0402615a6e540c28f44f56862468e0153","user":{"login":"lygstate","id":121040,"avatar_url":"https://avatars3.githubusercontent.com/u/121040?v=4","gravatar_id":"","url":"https://api.github.com/users/lygstate","html_url":"https://github.com/lygstate","followers_url":"https://api.github.com/users/lygstate/followers","following_url":"https://api.github.com/users/lygstate/following{/other_user}","gists_url":"https://api.github.com/users/lygstate/gists{/gist_id}","starred_url":"https://api.github.com/users/lygstate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lygstate/subscriptions","organizations_url":"https://api.github.com/users/lygstate/orgs","repos_url":"https://api.github.com/users/lygstate/repos","events_url":"https://api.github.com/users/lygstate/events{/privacy}","received_events_url":"https://api.github.com/users/lygstate/received_events","type":"User","site_admin":false},"body":"```\r\nJERRY_ATTR_FORMAT (printf, 2, 3) \r\n```\r\nAre to long in a single line with jerry_port_log (jerry_log_level_t level, const char *format, ...);\r\n\r\nAre the following style acceptble?\r\n```c\r\nvoid JERRY_ATTR_FORMAT (printf, 2, 3)\r\njerry_port_log (jerry_log_level_t level, const char *format, ...);\r\n\r\n```","created_at":"2018-05-10T15:40:17Z","updated_at":"2018-05-10T15:40:17Z","html_url":"https://github.com/jerryscript-project/jerryscript/pull/2313#discussion_r187369904","pull_request_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2313","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments/187369904"},"html":{"href":"https://github.com/jerryscript-project/jerryscript/pull/2313#discussion_r187369904"},"pull_request":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2313"}},"in_reply_to_id":187348768},"pull_request":{"url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2313","id":186308495,"html_url":"https://github.com/jerryscript-project/jerryscript/pull/2313","diff_url":"https://github.com/jerryscript-project/jerryscript/pull/2313.diff","patch_url":"https://github.com/jerryscript-project/jerryscript/pull/2313.patch","issue_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/2313","number":2313,"state":"open","locked":false,"title":"[RfC] Add jerryscript-compiler.h public header to cover compiler incompatibilities","user":{"login":"akosthekiss","id":9976482,"avatar_url":"https://avatars0.githubusercontent.com/u/9976482?v=4","gravatar_id":"","url":"https://api.github.com/users/akosthekiss","html_url":"https://github.com/akosthekiss","followers_url":"https://api.github.com/users/akosthekiss/followers","following_url":"https://api.github.com/users/akosthekiss/following{/other_user}","gists_url":"https://api.github.com/users/akosthekiss/gists{/gist_id}","starred_url":"https://api.github.com/users/akosthekiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akosthekiss/subscriptions","organizations_url":"https://api.github.com/users/akosthekiss/orgs","repos_url":"https://api.github.com/users/akosthekiss/repos","events_url":"https://api.github.com/users/akosthekiss/events{/privacy}","received_events_url":"https://api.github.com/users/akosthekiss/received_events","type":"User","site_admin":false},"body":"In general, public headers should not have compiler-specific\r\nconstructs but both the core and the port headers have attributes,\r\nwhich are non-standard. It's better to factor out such constructs\r\nto a common place (a new header) and hide them behind macros, which\r\ncan then be defined on a per-compiler basis.\r\n\r\nThis patch moves the existing definitions of function attributes and\r\nlikely/unlikely builtins to the new header. At the same time, it\r\nunifies the names of these attribute defines. Moreover, it touches\r\non jerry-main and removes the uses of `__attribute__((unused))`\r\nentirely and replaces them with the elsewhere used `(void) ...`\r\npattern.\r\n\r\nJerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu","created_at":"2018-05-07T10:05:43Z","updated_at":"2018-05-10T15:40:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a33ac038f6c3bbbb9ec4ce7356f1dd293f9aa50","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2313/commits","review_comments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2313/comments","review_comment_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/2313/comments","statuses_url":"https://api.github.com/repos/jerryscript-project/jerryscript/statuses/f3a6b7c0402615a6e540c28f44f56862468e0153","head":{"label":"akosthekiss:ccc","ref":"ccc","sha":"f3a6b7c0402615a6e540c28f44f56862468e0153","user":{"login":"akosthekiss","id":9976482,"avatar_url":"https://avatars0.githubusercontent.com/u/9976482?v=4","gravatar_id":"","url":"https://api.github.com/users/akosthekiss","html_url":"https://github.com/akosthekiss","followers_url":"https://api.github.com/users/akosthekiss/followers","following_url":"https://api.github.com/users/akosthekiss/following{/other_user}","gists_url":"https://api.github.com/users/akosthekiss/gists{/gist_id}","starred_url":"https://api.github.com/users/akosthekiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akosthekiss/subscriptions","organizations_url":"https://api.github.com/users/akosthekiss/orgs","repos_url":"https://api.github.com/users/akosthekiss/repos","events_url":"https://api.github.com/users/akosthekiss/events{/privacy}","received_events_url":"https://api.github.com/users/akosthekiss/received_events","type":"User","site_admin":false},"repo":{"id":39144593,"name":"jerryscript","full_name":"akosthekiss/jerryscript","owner":{"login":"akosthekiss","id":9976482,"avatar_url":"https://avatars0.githubusercontent.com/u/9976482?v=4","gravatar_id":"","url":"https://api.github.com/users/akosthekiss","html_url":"https://github.com/akosthekiss","followers_url":"https://api.github.com/users/akosthekiss/followers","following_url":"https://api.github.com/users/akosthekiss/following{/other_user}","gists_url":"https://api.github.com/users/akosthekiss/gists{/gist_id}","starred_url":"https://api.github.com/users/akosthekiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akosthekiss/subscriptions","organizations_url":"https://api.github.com/users/akosthekiss/orgs","repos_url":"https://api.github.com/users/akosthekiss/repos","events_url":"https://api.github.com/users/akosthekiss/events{/privacy}","received_events_url":"https://api.github.com/users/akosthekiss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akosthekiss/jerryscript","description":null,"fork":true,"url":"https://api.github.com/repos/akosthekiss/jerryscript","forks_url":"https://api.github.com/repos/akosthekiss/jerryscript/forks","keys_url":"https://api.github.com/repos/akosthekiss/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akosthekiss/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akosthekiss/jerryscript/teams","hooks_url":"https://api.github.com/repos/akosthekiss/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/akosthekiss/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/akosthekiss/jerryscript/events","assignees_url":"https://api.github.com/repos/akosthekiss/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/akosthekiss/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/akosthekiss/jerryscript/tags","blobs_url":"https://api.github.com/repos/akosthekiss/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akosthekiss/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akosthekiss/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/akosthekiss/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akosthekiss/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/akosthekiss/jerryscript/languages","stargazers_url":"https://api.github.com/repos/akosthekiss/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/akosthekiss/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/akosthekiss/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/akosthekiss/jerryscript/subscription","commits_url":"https://api.github.com/repos/akosthekiss/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/akosthekiss/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/akosthekiss/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/akosthekiss/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/akosthekiss/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/akosthekiss/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akosthekiss/jerryscript/merges","archive_url":"https://api.github.com/repos/akosthekiss/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akosthekiss/jerryscript/downloads","issues_url":"https://api.github.com/repos/akosthekiss/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/akosthekiss/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/akosthekiss/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/akosthekiss/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akosthekiss/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/akosthekiss/jerryscript/releases{/id}","deployments_url":"https://api.github.com/repos/akosthekiss/jerryscript/deployments","created_at":"2015-07-15T15:25:30Z","updated_at":"2016-02-15T12:02:02Z","pushed_at":"2018-05-10T12:37:08Z","git_url":"git://github.com/akosthekiss/jerryscript.git","ssh_url":"git@github.com:akosthekiss/jerryscript.git","clone_url":"https://github.com/akosthekiss/jerryscript.git","svn_url":"https://github.com/akosthekiss/jerryscript","homepage":null,"size":13443,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jerryscript-project:master","ref":"master","sha":"134845e0991e78e46876c74df4499e2f894b7ffc","user":{"login":"jerryscript-project","id":23194380,"avatar_url":"https://avatars1.githubusercontent.com/u/23194380?v=4","gravatar_id":"","url":"https://api.github.com/users/jerryscript-project","html_url":"https://github.com/jerryscript-project","followers_url":"https://api.github.com/users/jerryscript-project/followers","following_url":"https://api.github.com/users/jerryscript-project/following{/other_user}","gists_url":"https://api.github.com/users/jerryscript-project/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryscript-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryscript-project/subscriptions","organizations_url":"https://api.github.com/users/jerryscript-project/orgs","repos_url":"https://api.github.com/users/jerryscript-project/repos","events_url":"https://api.github.com/users/jerryscript-project/events{/privacy}","received_events_url":"https://api.github.com/users/jerryscript-project/received_events","type":"Organization","site_admin":false},"repo":{"id":33339660,"name":"jerryscript","full_name":"jerryscript-project/jerryscript","owner":{"login":"jerryscript-project","id":23194380,"avatar_url":"https://avatars1.githubusercontent.com/u/23194380?v=4","gravatar_id":"","url":"https://api.github.com/users/jerryscript-project","html_url":"https://github.com/jerryscript-project","followers_url":"https://api.github.com/users/jerryscript-project/followers","following_url":"https://api.github.com/users/jerryscript-project/following{/other_user}","gists_url":"https://api.github.com/users/jerryscript-project/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryscript-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryscript-project/subscriptions","organizations_url":"https://api.github.com/users/jerryscript-project/orgs","repos_url":"https://api.github.com/users/jerryscript-project/repos","events_url":"https://api.github.com/users/jerryscript-project/events{/privacy}","received_events_url":"https://api.github.com/users/jerryscript-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jerryscript-project/jerryscript","description":"Ultra-lightweight JavaScript engine for the Internet of Things.","fork":false,"url":"https://api.github.com/repos/jerryscript-project/jerryscript","forks_url":"https://api.github.com/repos/jerryscript-project/jerryscript/forks","keys_url":"https://api.github.com/repos/jerryscript-project/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jerryscript-project/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jerryscript-project/jerryscript/teams","hooks_url":"https://api.github.com/repos/jerryscript-project/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/jerryscript-project/jerryscript/events","assignees_url":"https://api.github.com/repos/jerryscript-project/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/jerryscript-project/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/jerryscript-project/jerryscript/tags","blobs_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jerryscript-project/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/jerryscript-project/jerryscript/languages","stargazers_url":"https://api.github.com/repos/jerryscript-project/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/jerryscript-project/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/jerryscript-project/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/jerryscript-project/jerryscript/subscription","commits_url":"https://api.github.com/repos/jerryscript-project/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/jerryscript-project/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/jerryscript-project/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jerryscript-project/jerryscript/merges","archive_url":"https://api.github.com/repos/jerryscript-project/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jerryscript-project/jerryscript/downloads","issues_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/jerryscript-project/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/jerryscript-project/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jerryscript-project/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/jerryscript-project/jerryscript/releases{/id}","deployments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/deployments","created_at":"2015-04-03T01:10:31Z","updated_at":"2018-05-10T10:37:23Z","pushed_at":"2018-05-10T12:37:10Z","git_url":"git://github.com/jerryscript-project/jerryscript.git","ssh_url":"git@github.com:jerryscript-project/jerryscript.git","clone_url":"https://github.com/jerryscript-project/jerryscript.git","svn_url":"https://github.com/jerryscript-project/jerryscript","homepage":"http://jerryscript.net","size":45811,"stargazers_count":3033,"watchers_count":3033,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":355,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":355,"open_issues":59,"watchers":3033,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2313"},"html":{"href":"https://github.com/jerryscript-project/jerryscript/pull/2313"},"issue":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/2313"},"comments":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/2313/comments"},"review_comments":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2313/comments"},"review_comment":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/2313/commits"},"statuses":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/statuses/f3a6b7c0402615a6e540c28f44f56862468e0153"}},"author_association":"OWNER"}}
{"actor":{"display_login":"lygstate"}}