{"push_id":2805153627,"size":3,"distinct_size":3,"ref":"refs/heads/xpe-13.0","head":"09d2ab873bdacdd67e9c8b60a36b2996295fd606","before":"2a68c630ff05a50e9d1969f12293f6d3e8f78c63","commits":[{"sha":"7375339c769c25338c8bbaf7ff51e86d19a7bfc7","author":{"name":"klozz","email":"6bb284d882b86bda4c62c9ab0a9a166554a38a6e@gmail.com"},"message":"Revert \"linker: Move shims to TARGET_LD_SHIM_LIBS\"\n\nThis reverts commit 78f3503094c3804d30fc8fae0e415c2a8d51b174.","distinct":true,"url":"https://api.github.com/repos/TheXPerienceProject/android_bionic/commits/7375339c769c25338c8bbaf7ff51e86d19a7bfc7"},{"sha":"00ce33faefc2e6cfc0bf05525df05ca49aa8e295","author":{"name":"klozz","email":"6bb284d882b86bda4c62c9ab0a9a166554a38a6e@gmail.com"},"message":"fix linker with our new additions\n\nChange-Id: Ia52ecce4a5f872b6ea6f618172918d3010188a4b\nSigned-off-by: klozz <shaclone707@gmail.com>","distinct":true,"url":"https://api.github.com/repos/TheXPerienceProject/android_bionic/commits/00ce33faefc2e6cfc0bf05525df05ca49aa8e295"},{"sha":"09d2ab873bdacdd67e9c8b60a36b2996295fd606","author":{"name":"Christopher R. Palmer","email":"90b51f8a5079017e81711ae9317c35b0575b34e1@gmail.com"},"message":"linker: Add support for dynamic SHIM libraries\n\nAuthor: Christopher R. Palmer <crpalmer@gmail.com>\nDate:   Tue Nov 3 16:44:44 2015 -0500\n\n    linker: Add support for dynamic \"shim\" libs\n\n    Add a new environment variable\n\n    LD_SHIM_LIBS\n\n    that is a colon (\":\") separated list of vertical bar (\"|\") separated pairs.\n    The pairs are the name for a soinfo reference (executable or shared library)\n    followed by the name of the shim library to load.  For example:\n\n    LD_SHIM_LIBS=rmt_storage|libshim_ioprio.so:/system/lib/libicuuv.so|libshim_icu53.so\n\n    will instruct the linker to load the dynamic library libshim_ioprio.so\n    whenver rmt_storage is executed [*] and will load libshim_icu53.so whenever\n    any executable or other shared library links against /system/lib/libicuuv.so.\n\n    There are no restrictions against circular references.  In this example,\n    libshim_icu53.so can link against libicuuv.so which provides a simple and\n    convenient means of adding compatibility symbols.\n\n    [*] Note that the absolute path is not available to the linker and therefore\n    using the name of executables does depend on the invocation and therefore\n    should only be used if absolutely necessary.  That is, running\n    /system/bin/rmt_storage would not load any shim libs in this example because\n    it does not match the name of the invocation of the command.\n\n    If you have trouble determining the sonames being loaded, you can also set\n    the environment variable LD_DEBUG=1 which will cause additional information\n    to be logged to help trace the detection of the shim libs.\n\n    Change-Id: I0ef80fa466167f7bcb7dac90842bef1c3cf879b6\n\nAuthor: Christopher R. Palmer <crpalmer@gmail.com>\nDate:   Sun Nov 15 14:26:32 2015 -0500\n\n    linker: Fix the fact that shim libs do not properly call constructors\n\n    Change-Id: I34333e13443a154e675b853fa41442351bc4243a\n\nAuthor: Christopher R. Palmer <crpalmer@gmail.com>\nDate:   Tue Dec 1 07:10:36 2015 -0500\n\n    linker: Don't try to walk the g_active_shim_libs when doing dlsym\n\n    This is a bug in the original shim_lib implementation which was\n    doing the shim lib resolution both when loading the libraries\n    and when doing the dynamic symbol resolution.\n\n    Change-Id: Ib2df0498cf551b3bbd37d7c351410b9908eb1795\n\nAuthor: Christopher R. Palmer <crpalmer@gmail.com>\nDate:   Sun Nov 29 08:28:10 2015 -0500\n\n    linker: Reset the active shim libs each time we do a dlopen\n\n    We use the active libs to avoid recursively trying to load the\n    same library:\n\n    A -> shimlibs add B -> depends on A -> shimlibs add B -> ...\n\n    However, when we repeatedly dlopen the same library we need\n    to reset the active shim libs to avoid failing to add B the\n    second time we dlopen A.\n\n    Change-Id: I27580e3d6a53858e8bca025d6c85f981cffbea06\n\nAuthor: Danny Baumann <dannybaumann@web.de>\nDate:   Fri Dec 11 10:29:16 2015 +0100\n\n    Make shim lib load failure non-fatal.\n\n    Instead, print an appropriate warning message. Aborting symbol\n    resolution on shim lib load failure leads to weird symbol lookup\n    failures, because symbols in libraries referenced after the one loading\n    the shim won't be loaded anymore without a log message stating why that\n    happened.\n\n    Change-Id: Ic3ad7095ddae7ea1039cb6a18603d5cde8a16143\n\nAuthor: Christopher R. Palmer <crpalmer@gmail.com>\nDate:   Sat Dec 12 06:10:09 2015 -0500\n\n    bionic: Do not allow LD_SHIM_LIBS for setuid executables\n\n    That's really not safe...\n\n    Change-Id: If79af951830966fc21812cd0f60a8998a752a941\n\nAuthor: Christopher R. Palmer <crpalmer@gmail.com>\nDate:   Sun Feb 14 11:38:44 2016 -0500\n\n    bionic: linker: Load shim libs *before* the self-linked libs\n\n    By loading them earlier, this allows us to override a symbol in\n    a library that is being directly linked.\n\n    I believe this explains why some people have had problems shimming\n    one lib but when the changet he shim to be against a different\n    lib it magically works.\n\n    It also makes it possible to override some symbols that were\n    nearly impossible to override before this change.  For example, it is\n    pretty much impossible to override a symbol in libutils without\n    this change because it's loaded almost everywhere so no matter\n    where you try to place the shimming, it will be too late and\n    the other symbol will have priority.\n\n    In particularly, this is necessary to be able to correctly\n    shim the VectorImpl symbols for dlx.\n\n    Change-Id: I461ca416bc288e28035352da00fde5f34f8d9ffa\n\nAuthor: Chirayu Desai <chirayudesai1@gmail.com>\nDate:   Thu Aug 25 19:02:41 2016 +0530\n\n    linker: Update find_library call for shimlibs\n\n    commits 0cdef7e7f3c6837b56a969120d9098463d1df8d8\n    \"Respect caller DT_RUNPATH in dlopen().\"\n    and 42d5fcb9f494eb45de3b6bf759f4a18076e84728\n    \"Introducing linker namespaces\"\n    added new arguments to find_library, add them here.\n\n    Change-Id: I8f35a45b00d14f8b2ce01a0a96d2dc7759be04a6\n\nAuthor: Chippa-a <vusal1372@gmail.com>\nDate:   Sat Aug 27 14:56:30 2016 +0200\n\n    linker: Update LD_SHIM_LIBS parser function\n\n     * Upgrade the code using the same changes as\n        42d5fcb9f494eb45de3b6bf759f4a18076e84728\n        bda20e78f0f314dbbf0f0bbcf0740cf2d6a4b85e\n\n    Change-Id: Ic8be0871945bd9feccd0f94a6770f3cc78a70a0f\n\nAuthor: Danny Baumann <dannybaumann@web.de>\nDate:   Wed Sep 7 16:54:06 2016 +0200\n\n    Inject shim libs as if they were DT_NEEDED.\n\n    The previous separate approach had one flaw: If the shim lib requires\n    another lib that's already loaded, find_library_internal() would return\n    the previously loaded copy, but the later load action would fail as the\n    ELF reader map of the initial loading round was already discarded and\n    thus a new ElfReader instance for the soinfo instance was created, which\n    didn't know about the previous reading/loading state.\n\n    Change-Id: Ib224dbd35d114197097e3dee14a077cc9130fedb\n\nAuthor: jrior001 <jriordan001@gmail.com>\nDate:   Fri Oct 7 19:36:51 2016 -0400\n\n    linker: load shims prior to DT_NEEDED check\n\n    This allows shims to override existing symbols, not just\n    inject new symbols.\n\n    Change-Id: Ib9216bcc651d8d38999c593babb94d76dc1dbc95\n\nAuthor: Adrian DC <radian.dc@gmail.com>\nDate: Sat, 8 Apr 2017 22:40:01 +0200\n\n     * Adapt to latest AOSP Oreo bionic linker changes\n     * Additional header to avoid unused function\n\n    Change-Id: Ib9216bcc651d8d38999c593babb94d76dc1dbc95\n\nAuthor: Paul Keith <javelinanddart@gmail.com>\nDate:   Thu Feb 15 21:57:33 2018 +0100\n\n    linker: Move shims to TARGET_LD_SHIM_LIBS\n\n    * To reduce security exposure, let's set this at compile time,\n      and block off all the code unless the board flag is set\n\n    Change-Id: Ieec5f5d9e0f39a798fd48eae037ecffe9502474c\n\nAuthor: Nich <nctrenco@gmail.com>\nDate:   Fri Jun 8 09:48:17 2018 +0800\n\n    linker: Provide soinfo path of the shimmed binary\n\n    This is a forward port of part of the original change that was missed out\n    since the initial port of the shim logic to O.\n\n    Change-Id: I1f7ff98472cfef5cb2d2bcb303082784898cd0c6\n\nAuthor: Nich <nctrenco@gmail.com>\nDate:   Tue Jun 5 13:36:43 2018 +0800\n\n    linker: Remove unused find_libraries declaration\n\n    commit \"Inject shim libs as if they were DT_NEEDED.\" removed references\n    to the forward declaration.\n\n    Change-Id: I5f1aaa3a96f2af3edef07d4ea4e204b586424631\n\nAuthor: Nich <nctrenco@gmail.com>\nDate:   Sun Jun 10 00:45:51 2018 +0800\n\n    linker: Make shim reference path absolute\n\n    This way, we can filter out non-existent binaries, and ensure we get\n    its absolute path before matching with get_realpath(). This for one\n    allows the use of symlinks in TARGET_LD_SHIM_LIBS.\n\n    Change-Id: I823815271b3257965534b6b87d8ea36ffb68bc08\n\nAuthor: Nich <nctrenco@gmail.com>\nDate:   Fri Jun 15 03:59:05 2018 +0800\n\n    linker: Ensure active matching pairs\n\n    Change-Id: I54c666b4560dbfb40839b0bf9132a7fd8d3ed2dd\n\nAuthor: Nich <nctrenco@gmail.com>\nDate:   Thu Jun 21 01:58:10 2018 +0800\n\n    linker: Don't involve shim in for_each_dt_needed\n\n    for_each_dt_needed may have other usages that shouldn't involve the\n    shim, for example, in the unloading of soinfos.\n\n    Change-Id: Id38de183d90c3f707767bdca032a5ea2bc82fde8\n\nChange-Id: Ic3ad7095ddae7ea1039cb6a18603d5cde8a16152\nSigned-off-by: klozz <shaclone707@gmail.com>","distinct":true,"url":"https://api.github.com/repos/TheXPerienceProject/android_bionic/commits/09d2ab873bdacdd67e9c8b60a36b2996295fd606"}]}
{"actor":{"display_login":"Klozz"}}