{"action":"created","issue":{"url":"https://api.github.com/repos/taniman/profit-trailer/issues/1014","repository_url":"https://api.github.com/repos/taniman/profit-trailer","labels_url":"https://api.github.com/repos/taniman/profit-trailer/issues/1014/labels{/name}","comments_url":"https://api.github.com/repos/taniman/profit-trailer/issues/1014/comments","events_url":"https://api.github.com/repos/taniman/profit-trailer/issues/1014/events","html_url":"https://github.com/taniman/profit-trailer/issues/1014","id":295051272,"number":1014,"title":"DCA_enabled = false - Causing pairs that are already in DCA 1+ to get moved to Pairs log and not showing DCA level in Sales Log.","user":{"login":"Legedric","id":8308141,"avatar_url":"https://avatars2.githubusercontent.com/u/8308141?v=4","gravatar_id":"","url":"https://api.github.com/users/Legedric","html_url":"https://github.com/Legedric","followers_url":"https://api.github.com/users/Legedric/followers","following_url":"https://api.github.com/users/Legedric/following{/other_user}","gists_url":"https://api.github.com/users/Legedric/gists{/gist_id}","starred_url":"https://api.github.com/users/Legedric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Legedric/subscriptions","organizations_url":"https://api.github.com/users/Legedric/orgs","repos_url":"https://api.github.com/users/Legedric/repos","events_url":"https://api.github.com/users/Legedric/events{/privacy}","received_events_url":"https://api.github.com/users/Legedric/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-02-07T08:46:55Z","updated_at":"2018-02-09T08:32:21Z","closed_at":"2018-02-09T08:32:21Z","author_association":"NONE","body":"So here is my issue.\r\n\r\nYesterday I had several bags in my DCA log and my automated setting tool (similar to Feeder) set some coins to \"DCA_enabled = false\".\r\n\r\nWhen it does that, they get moved from DCA log to Pairs log, no matter if they already got DCA'd or not.\r\nIn addition, when it sells one of these coins the column \"Bough price\" is just listing the plain price, without its DCA level like this:\r\n![image](https://user-images.githubusercontent.com/8308141/35906622-81abad94-0beb-11e8-93a8-9aedb8370fc3.png)\r\n\r\nThis seems to be a bit inconsistent as when I set DCA_enabled to lets say -100 (which pretty much equals false) it will NOT move coins that got already DCA'd back into Pairs Log and lists the DCA level correct in my Sales Log.\r\n\r\nI know that setting it to false disabled DCA. But it should follow the same rule so that any coin that already is in DCA 1 or more, will stay in DCA log and just won't go further down."},"comment":{"url":"https://api.github.com/repos/taniman/profit-trailer/issues/comments/364368491","html_url":"https://github.com/taniman/profit-trailer/issues/1014#issuecomment-364368491","issue_url":"https://api.github.com/repos/taniman/profit-trailer/issues/1014","id":364368491,"user":{"login":"taniman","id":6751341,"avatar_url":"https://avatars3.githubusercontent.com/u/6751341?v=4","gravatar_id":"","url":"https://api.github.com/users/taniman","html_url":"https://github.com/taniman","followers_url":"https://api.github.com/users/taniman/followers","following_url":"https://api.github.com/users/taniman/following{/other_user}","gists_url":"https://api.github.com/users/taniman/gists{/gist_id}","starred_url":"https://api.github.com/users/taniman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taniman/subscriptions","organizations_url":"https://api.github.com/users/taniman/orgs","repos_url":"https://api.github.com/users/taniman/repos","events_url":"https://api.github.com/users/taniman/events{/privacy}","received_events_url":"https://api.github.com/users/taniman/received_events","type":"User","site_admin":false},"created_at":"2018-02-09T08:32:21Z","updated_at":"2018-02-09T08:32:21Z","author_association":"OWNER","body":"@Legedric If a coin in in DCA log it will get DCA'd  unless it reached it's limit.\r\nSo if a coin has not reached it's limit and I don't want it to DCA anymore what do I do??\r\n\r\nAnswer: I Disable DCA for this particular coin. and let it go to pairs log.\r\n\r\nThe logic is consistent. pairs in DCA log get dca'd, pairs not in DCA log will not get DCA'd\r\nI am not seeing any confusion here.\r\n\r\nIf we do as you suggest and leave them there, but they not get DCA, THAT will create confusion.\r\n\r\n```My coin is in DCA log but it's not buying anything```\r\n\r\nSo all in all, currently this is not something that will change.  "}}
{"actor":{"display_login":"taniman"}}