{"action":"created","comment":{"url":"https://api.github.com/repos/projectriff/riff/pulls/comments/230771209","pull_request_review_id":171581950,"id":230771209,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDc3MTIwOQ==","diff_hunk":"@@ -37,7 +37,7 @@ install: build\n \tcp $(OUTPUT) $(GOBIN)\n \n $(OUTPUT): $(GO_SOURCES) vendor VERSION\n-\tgo build -o $(OUTPUT) -ldflags \"$(LDFLAGS_VERSION)\" main.go\n+\tgo build -o $(OUTPUT) -ldflags \"$(LDFLAGS_VERSION)\" *.go","path":"Makefile","position":5,"original_position":5,"commit_id":"8be36fda72f15dd83a5f7aad7611b4faef8e319d","original_commit_id":"8be36fda72f15dd83a5f7aad7611b4faef8e319d","user":{"login":"ericbottard","id":313494,"node_id":"MDQ6VXNlcjMxMzQ5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/313494?v=4","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"body":"I'm not sure I understand *why* this is necessary, I thought `go build` found all required files (just the same way it knows how to find referenced packages).\r\n\r\nAnyway, we could also change from \"build these `.go` files\" to \"build this package\"","created_at":"2018-11-05T14:35:29Z","updated_at":"2018-11-05T14:35:29Z","html_url":"https://github.com/projectriff/riff/pull/936#discussion_r230771209","pull_request_url":"https://api.github.com/repos/projectriff/riff/pulls/936","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/projectriff/riff/pulls/comments/230771209"},"html":{"href":"https://github.com/projectriff/riff/pull/936#discussion_r230771209"},"pull_request":{"href":"https://api.github.com/repos/projectriff/riff/pulls/936"}},"in_reply_to_id":230682989},"pull_request":{"url":"https://api.github.com/repos/projectriff/riff/pulls/936","id":228289343,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4Mjg5MzQz","html_url":"https://github.com/projectriff/riff/pull/936","diff_url":"https://github.com/projectriff/riff/pull/936.diff","patch_url":"https://github.com/projectriff/riff/pull/936.patch","issue_url":"https://api.github.com/repos/projectriff/riff/issues/936","number":936,"state":"open","locked":false,"title":"Make `riff` and `riff-distro` use consistent manifest declarations","user":{"login":"glyn","id":94953,"node_id":"MDQ6VXNlcjk0OTUz","avatar_url":"https://avatars3.githubusercontent.com/u/94953?v=4","gravatar_id":"","url":"https://api.github.com/users/glyn","html_url":"https://github.com/glyn","followers_url":"https://api.github.com/users/glyn/followers","following_url":"https://api.github.com/users/glyn/following{/other_user}","gists_url":"https://api.github.com/users/glyn/gists{/gist_id}","starred_url":"https://api.github.com/users/glyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glyn/subscriptions","organizations_url":"https://api.github.com/users/glyn/orgs","repos_url":"https://api.github.com/users/glyn/repos","events_url":"https://api.github.com/users/glyn/events{/privacy}","received_events_url":"https://api.github.com/users/glyn/received_events","type":"User","site_admin":false},"body":"It is important that the manifests are consistent so that distributions built with `riff-distro create` can refer to the same stable and latest values as `riff`.\r\n\r\nThis change ensures that manifests are only declared in main packages (to avoid the possibility of direct imports bypassing dependency injection), but shares the declarations using a symbolically linked file to avoid dual maintenance.\r\n\r\n/cc @scothis @trisberg ","created_at":"2018-11-05T09:34:41Z","updated_at":"2018-11-05T14:35:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbeb08d4104cba357b47fb93a1513abb4aacc6a7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"scothis","id":302992,"node_id":"MDQ6VXNlcjMwMjk5Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/302992?v=4","gravatar_id":"","url":"https://api.github.com/users/scothis","html_url":"https://github.com/scothis","followers_url":"https://api.github.com/users/scothis/followers","following_url":"https://api.github.com/users/scothis/following{/other_user}","gists_url":"https://api.github.com/users/scothis/gists{/gist_id}","starred_url":"https://api.github.com/users/scothis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scothis/subscriptions","organizations_url":"https://api.github.com/users/scothis/orgs","repos_url":"https://api.github.com/users/scothis/repos","events_url":"https://api.github.com/users/scothis/events{/privacy}","received_events_url":"https://api.github.com/users/scothis/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1016534259,"node_id":"MDU6TGFiZWwxMDE2NTM0MjU5","url":"https://api.github.com/repos/projectriff/riff/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":852574075,"node_id":"MDU6TGFiZWw4NTI1NzQwNzU=","url":"https://api.github.com/repos/projectriff/riff/labels/riff-cli","name":"riff-cli","color":"083072","default":false},{"id":1069986753,"node_id":"MDU6TGFiZWwxMDY5OTg2NzUz","url":"https://api.github.com/repos/projectriff/riff/labels/riff-distro-cli","name":"riff-distro-cli","color":"083072","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/projectriff/riff/pulls/936/commits","review_comments_url":"https://api.github.com/repos/projectriff/riff/pulls/936/comments","review_comment_url":"https://api.github.com/repos/projectriff/riff/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectriff/riff/issues/936/comments","statuses_url":"https://api.github.com/repos/projectriff/riff/statuses/8be36fda72f15dd83a5f7aad7611b4faef8e319d","head":{"label":"glyn:remove-duplication","ref":"remove-duplication","sha":"8be36fda72f15dd83a5f7aad7611b4faef8e319d","user":{"login":"glyn","id":94953,"node_id":"MDQ6VXNlcjk0OTUz","avatar_url":"https://avatars3.githubusercontent.com/u/94953?v=4","gravatar_id":"","url":"https://api.github.com/users/glyn","html_url":"https://github.com/glyn","followers_url":"https://api.github.com/users/glyn/followers","following_url":"https://api.github.com/users/glyn/following{/other_user}","gists_url":"https://api.github.com/users/glyn/gists{/gist_id}","starred_url":"https://api.github.com/users/glyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glyn/subscriptions","organizations_url":"https://api.github.com/users/glyn/orgs","repos_url":"https://api.github.com/users/glyn/repos","events_url":"https://api.github.com/users/glyn/events{/privacy}","received_events_url":"https://api.github.com/users/glyn/received_events","type":"User","site_admin":false},"repo":{"id":118480147,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg0ODAxNDc=","name":"riff","full_name":"glyn/riff","private":false,"owner":{"login":"glyn","id":94953,"node_id":"MDQ6VXNlcjk0OTUz","avatar_url":"https://avatars3.githubusercontent.com/u/94953?v=4","gravatar_id":"","url":"https://api.github.com/users/glyn","html_url":"https://github.com/glyn","followers_url":"https://api.github.com/users/glyn/followers","following_url":"https://api.github.com/users/glyn/following{/other_user}","gists_url":"https://api.github.com/users/glyn/gists{/gist_id}","starred_url":"https://api.github.com/users/glyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glyn/subscriptions","organizations_url":"https://api.github.com/users/glyn/orgs","repos_url":"https://api.github.com/users/glyn/repos","events_url":"https://api.github.com/users/glyn/events{/privacy}","received_events_url":"https://api.github.com/users/glyn/received_events","type":"User","site_admin":false},"html_url":"https://github.com/glyn/riff","description":"riff is for functions","fork":true,"url":"https://api.github.com/repos/glyn/riff","forks_url":"https://api.github.com/repos/glyn/riff/forks","keys_url":"https://api.github.com/repos/glyn/riff/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glyn/riff/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glyn/riff/teams","hooks_url":"https://api.github.com/repos/glyn/riff/hooks","issue_events_url":"https://api.github.com/repos/glyn/riff/issues/events{/number}","events_url":"https://api.github.com/repos/glyn/riff/events","assignees_url":"https://api.github.com/repos/glyn/riff/assignees{/user}","branches_url":"https://api.github.com/repos/glyn/riff/branches{/branch}","tags_url":"https://api.github.com/repos/glyn/riff/tags","blobs_url":"https://api.github.com/repos/glyn/riff/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glyn/riff/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glyn/riff/git/refs{/sha}","trees_url":"https://api.github.com/repos/glyn/riff/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glyn/riff/statuses/{sha}","languages_url":"https://api.github.com/repos/glyn/riff/languages","stargazers_url":"https://api.github.com/repos/glyn/riff/stargazers","contributors_url":"https://api.github.com/repos/glyn/riff/contributors","subscribers_url":"https://api.github.com/repos/glyn/riff/subscribers","subscription_url":"https://api.github.com/repos/glyn/riff/subscription","commits_url":"https://api.github.com/repos/glyn/riff/commits{/sha}","git_commits_url":"https://api.github.com/repos/glyn/riff/git/commits{/sha}","comments_url":"https://api.github.com/repos/glyn/riff/comments{/number}","issue_comment_url":"https://api.github.com/repos/glyn/riff/issues/comments{/number}","contents_url":"https://api.github.com/repos/glyn/riff/contents/{+path}","compare_url":"https://api.github.com/repos/glyn/riff/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glyn/riff/merges","archive_url":"https://api.github.com/repos/glyn/riff/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glyn/riff/downloads","issues_url":"https://api.github.com/repos/glyn/riff/issues{/number}","pulls_url":"https://api.github.com/repos/glyn/riff/pulls{/number}","milestones_url":"https://api.github.com/repos/glyn/riff/milestones{/number}","notifications_url":"https://api.github.com/repos/glyn/riff/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glyn/riff/labels{/name}","releases_url":"https://api.github.com/repos/glyn/riff/releases{/id}","deployments_url":"https://api.github.com/repos/glyn/riff/deployments","created_at":"2018-01-22T16:03:14Z","updated_at":"2018-09-26T10:03:58Z","pushed_at":"2018-11-05T09:29:18Z","git_url":"git://github.com/glyn/riff.git","ssh_url":"git@github.com:glyn/riff.git","clone_url":"https://github.com/glyn/riff.git","svn_url":"https://github.com/glyn/riff","homepage":"https://projectriff.io","size":68692,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectriff:master","ref":"master","sha":"9b33ab9bf564bad67b4083cf176b818bd38148b6","user":{"login":"projectriff","id":33602961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjAyOTYx","avatar_url":"https://avatars1.githubusercontent.com/u/33602961?v=4","gravatar_id":"","url":"https://api.github.com/users/projectriff","html_url":"https://github.com/projectriff","followers_url":"https://api.github.com/users/projectriff/followers","following_url":"https://api.github.com/users/projectriff/following{/other_user}","gists_url":"https://api.github.com/users/projectriff/gists{/gist_id}","starred_url":"https://api.github.com/users/projectriff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectriff/subscriptions","organizations_url":"https://api.github.com/users/projectriff/orgs","repos_url":"https://api.github.com/users/projectriff/repos","events_url":"https://api.github.com/users/projectriff/events{/privacy}","received_events_url":"https://api.github.com/users/projectriff/received_events","type":"Organization","site_admin":false},"repo":{"id":98690441,"node_id":"MDEwOlJlcG9zaXRvcnk5ODY5MDQ0MQ==","name":"riff","full_name":"projectriff/riff","private":false,"owner":{"login":"projectriff","id":33602961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjAyOTYx","avatar_url":"https://avatars1.githubusercontent.com/u/33602961?v=4","gravatar_id":"","url":"https://api.github.com/users/projectriff","html_url":"https://github.com/projectriff","followers_url":"https://api.github.com/users/projectriff/followers","following_url":"https://api.github.com/users/projectriff/following{/other_user}","gists_url":"https://api.github.com/users/projectriff/gists{/gist_id}","starred_url":"https://api.github.com/users/projectriff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectriff/subscriptions","organizations_url":"https://api.github.com/users/projectriff/orgs","repos_url":"https://api.github.com/users/projectriff/repos","events_url":"https://api.github.com/users/projectriff/events{/privacy}","received_events_url":"https://api.github.com/users/projectriff/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/projectriff/riff","description":"riff is for functions","fork":false,"url":"https://api.github.com/repos/projectriff/riff","forks_url":"https://api.github.com/repos/projectriff/riff/forks","keys_url":"https://api.github.com/repos/projectriff/riff/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectriff/riff/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectriff/riff/teams","hooks_url":"https://api.github.com/repos/projectriff/riff/hooks","issue_events_url":"https://api.github.com/repos/projectriff/riff/issues/events{/number}","events_url":"https://api.github.com/repos/projectriff/riff/events","assignees_url":"https://api.github.com/repos/projectriff/riff/assignees{/user}","branches_url":"https://api.github.com/repos/projectriff/riff/branches{/branch}","tags_url":"https://api.github.com/repos/projectriff/riff/tags","blobs_url":"https://api.github.com/repos/projectriff/riff/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectriff/riff/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectriff/riff/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectriff/riff/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectriff/riff/statuses/{sha}","languages_url":"https://api.github.com/repos/projectriff/riff/languages","stargazers_url":"https://api.github.com/repos/projectriff/riff/stargazers","contributors_url":"https://api.github.com/repos/projectriff/riff/contributors","subscribers_url":"https://api.github.com/repos/projectriff/riff/subscribers","subscription_url":"https://api.github.com/repos/projectriff/riff/subscription","commits_url":"https://api.github.com/repos/projectriff/riff/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectriff/riff/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectriff/riff/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectriff/riff/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectriff/riff/contents/{+path}","compare_url":"https://api.github.com/repos/projectriff/riff/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectriff/riff/merges","archive_url":"https://api.github.com/repos/projectriff/riff/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectriff/riff/downloads","issues_url":"https://api.github.com/repos/projectriff/riff/issues{/number}","pulls_url":"https://api.github.com/repos/projectriff/riff/pulls{/number}","milestones_url":"https://api.github.com/repos/projectriff/riff/milestones{/number}","notifications_url":"https://api.github.com/repos/projectriff/riff/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectriff/riff/labels{/name}","releases_url":"https://api.github.com/repos/projectriff/riff/releases{/id}","deployments_url":"https://api.github.com/repos/projectriff/riff/deployments","created_at":"2017-07-28T21:42:28Z","updated_at":"2018-11-04T23:20:40Z","pushed_at":"2018-11-05T09:34:41Z","git_url":"git://github.com/projectriff/riff.git","ssh_url":"git@github.com:projectriff/riff.git","clone_url":"https://github.com/projectriff/riff.git","svn_url":"https://github.com/projectriff/riff","homepage":"https://projectriff.io","size":68609,"stargazers_count":606,"watchers_count":606,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":47,"open_issues":67,"watchers":606,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectriff/riff/pulls/936"},"html":{"href":"https://github.com/projectriff/riff/pull/936"},"issue":{"href":"https://api.github.com/repos/projectriff/riff/issues/936"},"comments":{"href":"https://api.github.com/repos/projectriff/riff/issues/936/comments"},"review_comments":{"href":"https://api.github.com/repos/projectriff/riff/pulls/936/comments"},"review_comment":{"href":"https://api.github.com/repos/projectriff/riff/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectriff/riff/pulls/936/commits"},"statuses":{"href":"https://api.github.com/repos/projectriff/riff/statuses/8be36fda72f15dd83a5f7aad7611b4faef8e319d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ericbottard"}}