{"action":"created","comment":{"url":"https://api.github.com/repos/woocommerce/wc-admin/pulls/comments/231625725","pull_request_review_id":172635459,"id":231625725,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTYyNTcyNQ==","diff_hunk":"@@ -43,8 +43,16 @@ function wc_admin_plugins_notice() {\n  * @return bool\n  */\n function dependencies_satisfied() {\n-\treturn ( defined( 'GUTENBERG_DEVELOPMENT_MODE' ) || defined( 'GUTENBERG_VERSION' ) )\n-\t\t\t&& class_exists( 'WooCommerce' ) && version_compare( WC_VERSION, '3.5', '>' );\n+\t$woocommerce_minimum_met = class_exists( 'WooCommerce' ) && version_compare( WC_VERSION, '3.5', '>' );\n+\tif ( ! $woocommerce_minimum_met ) {\n+\t\treturn false;\n+\t}\n+\n+\t$wordpress_version            = get_bloginfo( 'version' );\n+\t$wordpress_includes_gutenberg = version_compare( $wordpress_version, '4.9.9', '>' );","path":"wc-admin.php","position":12,"original_position":12,"commit_id":"598069f28eddfec9155b9153cd59d719275b7ada","original_commit_id":"598069f28eddfec9155b9153cd59d719275b7ada","user":{"login":"timmyc","id":22080,"node_id":"MDQ6VXNlcjIyMDgw","avatar_url":"https://avatars0.githubusercontent.com/u/22080?v=4","gravatar_id":"","url":"https://api.github.com/users/timmyc","html_url":"https://github.com/timmyc","followers_url":"https://api.github.com/users/timmyc/followers","following_url":"https://api.github.com/users/timmyc/following{/other_user}","gists_url":"https://api.github.com/users/timmyc/gists{/gist_id}","starred_url":"https://api.github.com/users/timmyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timmyc/subscriptions","organizations_url":"https://api.github.com/users/timmyc/orgs","repos_url":"https://api.github.com/users/timmyc/repos","events_url":"https://api.github.com/users/timmyc/events{/privacy}","received_events_url":"https://api.github.com/users/timmyc/received_events","type":"User","site_admin":false},"body":"Since we have the known issue of `SCRIPT_DEBUG` needing to be on, should we add that as a required condition to this line? That would allow us to ensure `wc-admin` will function in 5.0 until the other issue is resolved - and we could cut a release too!\r\n\r\n```\r\n$wordpress_includes_gutenberg = version_compare( $wordpress_version, '4.9.9', '>' ) && is_defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG;\r\n```\r\n","created_at":"2018-11-07T18:32:08Z","updated_at":"2018-11-07T18:32:36Z","html_url":"https://github.com/woocommerce/wc-admin/pull/774#discussion_r231625725","pull_request_url":"https://api.github.com/repos/woocommerce/wc-admin/pulls/774","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/woocommerce/wc-admin/pulls/comments/231625725"},"html":{"href":"https://github.com/woocommerce/wc-admin/pull/774#discussion_r231625725"},"pull_request":{"href":"https://api.github.com/repos/woocommerce/wc-admin/pulls/774"}}},"pull_request":{"url":"https://api.github.com/repos/woocommerce/wc-admin/pulls/774","id":228224278,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MjI0Mjc4","html_url":"https://github.com/woocommerce/wc-admin/pull/774","diff_url":"https://github.com/woocommerce/wc-admin/pull/774.diff","patch_url":"https://github.com/woocommerce/wc-admin/pull/774.patch","issue_url":"https://api.github.com/repos/woocommerce/wc-admin/issues/774","number":774,"state":"open","locked":false,"title":"Allow WC-Admin to activate on WP 5 without Gutenberg plugin active","user":{"login":"allendav","id":1595739,"node_id":"MDQ6VXNlcjE1OTU3Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1595739?v=4","gravatar_id":"","url":"https://api.github.com/users/allendav","html_url":"https://github.com/allendav","followers_url":"https://api.github.com/users/allendav/followers","following_url":"https://api.github.com/users/allendav/following{/other_user}","gists_url":"https://api.github.com/users/allendav/gists{/gist_id}","starred_url":"https://api.github.com/users/allendav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allendav/subscriptions","organizations_url":"https://api.github.com/users/allendav/orgs","repos_url":"https://api.github.com/users/allendav/repos","events_url":"https://api.github.com/users/allendav/events{/privacy}","received_events_url":"https://api.github.com/users/allendav/received_events","type":"User","site_admin":false},"body":"Fixes #772 \r\n\r\n- Don't rely on GUTENBERG_DEVELOPMENT_MODE or GUTENBERG_VERSION - since those are not present in WordPress 5.\r\n- Don't call `gutenberg_get_jed_locale_data` on WordPress 5 - use `wp_get_jed_locale_data` instead (see https://github.com/WordPress/gutenberg-examples/pull/51 )\r\n\r\n### Detailed test instructions:\r\n\r\n- Install on WordPress 5\r\n- Make sure you have `define('SCRIPT_DEBUG', true);` - there is a separate issue with the minified scripts on 5.0 that is causing a problem ( #796 )\r\n- Do NOT have the Gutenberg plugin active\r\n- Make sure you can activate this (the WC-Admin) plugin 1) without a fatal error and 2) that the wp-admin > WooCommerce > Dashboard loads properly (including no console errors)\r\n\r\n- Install on WordPress 4.9.8\r\n- Do NOT have the Gutenberg plugin active\r\n- Make sure that you cannot activate this (the WC-Admin) plugin\r\n- Install and activate the Gutenberg plugin\r\n- Make sure you can activate this plugin 1) without a fatal error and 2) that the wp-admin > WooCommerce > Dashboard loads properly (including no console errors)\r\n","created_at":"2018-11-05T02:20:35Z","updated_at":"2018-11-07T18:32:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"530654ee643ffa89ae7e45b247e57196a742f1d3","assignee":{"login":"allendav","id":1595739,"node_id":"MDQ6VXNlcjE1OTU3Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1595739?v=4","gravatar_id":"","url":"https://api.github.com/users/allendav","html_url":"https://github.com/allendav","followers_url":"https://api.github.com/users/allendav/followers","following_url":"https://api.github.com/users/allendav/following{/other_user}","gists_url":"https://api.github.com/users/allendav/gists{/gist_id}","starred_url":"https://api.github.com/users/allendav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allendav/subscriptions","organizations_url":"https://api.github.com/users/allendav/orgs","repos_url":"https://api.github.com/users/allendav/repos","events_url":"https://api.github.com/users/allendav/events{/privacy}","received_events_url":"https://api.github.com/users/allendav/received_events","type":"User","site_admin":false},"assignees":[{"login":"allendav","id":1595739,"node_id":"MDQ6VXNlcjE1OTU3Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1595739?v=4","gravatar_id":"","url":"https://api.github.com/users/allendav","html_url":"https://github.com/allendav","followers_url":"https://api.github.com/users/allendav/followers","following_url":"https://api.github.com/users/allendav/following{/other_user}","gists_url":"https://api.github.com/users/allendav/gists{/gist_id}","starred_url":"https://api.github.com/users/allendav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allendav/subscriptions","organizations_url":"https://api.github.com/users/allendav/orgs","repos_url":"https://api.github.com/users/allendav/repos","events_url":"https://api.github.com/users/allendav/events{/privacy}","received_events_url":"https://api.github.com/users/allendav/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":921782814,"node_id":"MDU6TGFiZWw5MjE3ODI4MTQ=","url":"https://api.github.com/repos/woocommerce/wc-admin/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/woocommerce/wc-admin/pulls/774/commits","review_comments_url":"https://api.github.com/repos/woocommerce/wc-admin/pulls/774/comments","review_comment_url":"https://api.github.com/repos/woocommerce/wc-admin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/woocommerce/wc-admin/issues/774/comments","statuses_url":"https://api.github.com/repos/woocommerce/wc-admin/statuses/598069f28eddfec9155b9153cd59d719275b7ada","head":{"label":"woocommerce:fix/772-wp5-compat","ref":"fix/772-wp5-compat","sha":"598069f28eddfec9155b9153cd59d719275b7ada","user":{"login":"woocommerce","id":473596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/473596?v=4","gravatar_id":"","url":"https://api.github.com/users/woocommerce","html_url":"https://github.com/woocommerce","followers_url":"https://api.github.com/users/woocommerce/followers","following_url":"https://api.github.com/users/woocommerce/following{/other_user}","gists_url":"https://api.github.com/users/woocommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/woocommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woocommerce/subscriptions","organizations_url":"https://api.github.com/users/woocommerce/orgs","repos_url":"https://api.github.com/users/woocommerce/repos","events_url":"https://api.github.com/users/woocommerce/events{/privacy}","received_events_url":"https://api.github.com/users/woocommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":128732084,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg3MzIwODQ=","name":"wc-admin","full_name":"woocommerce/wc-admin","private":false,"owner":{"login":"woocommerce","id":473596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/473596?v=4","gravatar_id":"","url":"https://api.github.com/users/woocommerce","html_url":"https://github.com/woocommerce","followers_url":"https://api.github.com/users/woocommerce/followers","following_url":"https://api.github.com/users/woocommerce/following{/other_user}","gists_url":"https://api.github.com/users/woocommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/woocommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woocommerce/subscriptions","organizations_url":"https://api.github.com/users/woocommerce/orgs","repos_url":"https://api.github.com/users/woocommerce/repos","events_url":"https://api.github.com/users/woocommerce/events{/privacy}","received_events_url":"https://api.github.com/users/woocommerce/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/woocommerce/wc-admin","description":"A feature plugin for a modern, javascript-driven WooCommerce Admin experience.","fork":false,"url":"https://api.github.com/repos/woocommerce/wc-admin","forks_url":"https://api.github.com/repos/woocommerce/wc-admin/forks","keys_url":"https://api.github.com/repos/woocommerce/wc-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/woocommerce/wc-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/woocommerce/wc-admin/teams","hooks_url":"https://api.github.com/repos/woocommerce/wc-admin/hooks","issue_events_url":"https://api.github.com/repos/woocommerce/wc-admin/issues/events{/number}","events_url":"https://api.github.com/repos/woocommerce/wc-admin/events","assignees_url":"https://api.github.com/repos/woocommerce/wc-admin/assignees{/user}","branches_url":"https://api.github.com/repos/woocommerce/wc-admin/branches{/branch}","tags_url":"https://api.github.com/repos/woocommerce/wc-admin/tags","blobs_url":"https://api.github.com/repos/woocommerce/wc-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/woocommerce/wc-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/woocommerce/wc-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/woocommerce/wc-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/woocommerce/wc-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/woocommerce/wc-admin/languages","stargazers_url":"https://api.github.com/repos/woocommerce/wc-admin/stargazers","contributors_url":"https://api.github.com/repos/woocommerce/wc-admin/contributors","subscribers_url":"https://api.github.com/repos/woocommerce/wc-admin/subscribers","subscription_url":"https://api.github.com/repos/woocommerce/wc-admin/subscription","commits_url":"https://api.github.com/repos/woocommerce/wc-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/woocommerce/wc-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/woocommerce/wc-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/woocommerce/wc-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/woocommerce/wc-admin/contents/{+path}","compare_url":"https://api.github.com/repos/woocommerce/wc-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/woocommerce/wc-admin/merges","archive_url":"https://api.github.com/repos/woocommerce/wc-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/woocommerce/wc-admin/downloads","issues_url":"https://api.github.com/repos/woocommerce/wc-admin/issues{/number}","pulls_url":"https://api.github.com/repos/woocommerce/wc-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/woocommerce/wc-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/woocommerce/wc-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/woocommerce/wc-admin/labels{/name}","releases_url":"https://api.github.com/repos/woocommerce/wc-admin/releases{/id}","deployments_url":"https://api.github.com/repos/woocommerce/wc-admin/deployments","created_at":"2018-04-09T07:29:35Z","updated_at":"2018-11-07T17:25:53Z","pushed_at":"2018-11-07T17:53:34Z","git_url":"git://github.com/woocommerce/wc-admin.git","ssh_url":"git@github.com:woocommerce/wc-admin.git","clone_url":"https://github.com/woocommerce/wc-admin.git","svn_url":"https://github.com/woocommerce/wc-admin","homepage":"https://woocommerce.github.io/wc-admin/#/","size":4303,"stargazers_count":78,"watchers_count":78,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":101,"license":null,"forks":4,"open_issues":101,"watchers":78,"default_branch":"master"}},"base":{"label":"woocommerce:master","ref":"master","sha":"f202ab5ba38b2dab1b958eaf632e53fc44db5c93","user":{"login":"woocommerce","id":473596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/473596?v=4","gravatar_id":"","url":"https://api.github.com/users/woocommerce","html_url":"https://github.com/woocommerce","followers_url":"https://api.github.com/users/woocommerce/followers","following_url":"https://api.github.com/users/woocommerce/following{/other_user}","gists_url":"https://api.github.com/users/woocommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/woocommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woocommerce/subscriptions","organizations_url":"https://api.github.com/users/woocommerce/orgs","repos_url":"https://api.github.com/users/woocommerce/repos","events_url":"https://api.github.com/users/woocommerce/events{/privacy}","received_events_url":"https://api.github.com/users/woocommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":128732084,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg3MzIwODQ=","name":"wc-admin","full_name":"woocommerce/wc-admin","private":false,"owner":{"login":"woocommerce","id":473596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/473596?v=4","gravatar_id":"","url":"https://api.github.com/users/woocommerce","html_url":"https://github.com/woocommerce","followers_url":"https://api.github.com/users/woocommerce/followers","following_url":"https://api.github.com/users/woocommerce/following{/other_user}","gists_url":"https://api.github.com/users/woocommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/woocommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woocommerce/subscriptions","organizations_url":"https://api.github.com/users/woocommerce/orgs","repos_url":"https://api.github.com/users/woocommerce/repos","events_url":"https://api.github.com/users/woocommerce/events{/privacy}","received_events_url":"https://api.github.com/users/woocommerce/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/woocommerce/wc-admin","description":"A feature plugin for a modern, javascript-driven WooCommerce Admin experience.","fork":false,"url":"https://api.github.com/repos/woocommerce/wc-admin","forks_url":"https://api.github.com/repos/woocommerce/wc-admin/forks","keys_url":"https://api.github.com/repos/woocommerce/wc-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/woocommerce/wc-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/woocommerce/wc-admin/teams","hooks_url":"https://api.github.com/repos/woocommerce/wc-admin/hooks","issue_events_url":"https://api.github.com/repos/woocommerce/wc-admin/issues/events{/number}","events_url":"https://api.github.com/repos/woocommerce/wc-admin/events","assignees_url":"https://api.github.com/repos/woocommerce/wc-admin/assignees{/user}","branches_url":"https://api.github.com/repos/woocommerce/wc-admin/branches{/branch}","tags_url":"https://api.github.com/repos/woocommerce/wc-admin/tags","blobs_url":"https://api.github.com/repos/woocommerce/wc-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/woocommerce/wc-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/woocommerce/wc-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/woocommerce/wc-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/woocommerce/wc-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/woocommerce/wc-admin/languages","stargazers_url":"https://api.github.com/repos/woocommerce/wc-admin/stargazers","contributors_url":"https://api.github.com/repos/woocommerce/wc-admin/contributors","subscribers_url":"https://api.github.com/repos/woocommerce/wc-admin/subscribers","subscription_url":"https://api.github.com/repos/woocommerce/wc-admin/subscription","commits_url":"https://api.github.com/repos/woocommerce/wc-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/woocommerce/wc-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/woocommerce/wc-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/woocommerce/wc-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/woocommerce/wc-admin/contents/{+path}","compare_url":"https://api.github.com/repos/woocommerce/wc-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/woocommerce/wc-admin/merges","archive_url":"https://api.github.com/repos/woocommerce/wc-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/woocommerce/wc-admin/downloads","issues_url":"https://api.github.com/repos/woocommerce/wc-admin/issues{/number}","pulls_url":"https://api.github.com/repos/woocommerce/wc-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/woocommerce/wc-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/woocommerce/wc-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/woocommerce/wc-admin/labels{/name}","releases_url":"https://api.github.com/repos/woocommerce/wc-admin/releases{/id}","deployments_url":"https://api.github.com/repos/woocommerce/wc-admin/deployments","created_at":"2018-04-09T07:29:35Z","updated_at":"2018-11-07T17:25:53Z","pushed_at":"2018-11-07T17:53:34Z","git_url":"git://github.com/woocommerce/wc-admin.git","ssh_url":"git@github.com:woocommerce/wc-admin.git","clone_url":"https://github.com/woocommerce/wc-admin.git","svn_url":"https://github.com/woocommerce/wc-admin","homepage":"https://woocommerce.github.io/wc-admin/#/","size":4303,"stargazers_count":78,"watchers_count":78,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":101,"license":null,"forks":4,"open_issues":101,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/woocommerce/wc-admin/pulls/774"},"html":{"href":"https://github.com/woocommerce/wc-admin/pull/774"},"issue":{"href":"https://api.github.com/repos/woocommerce/wc-admin/issues/774"},"comments":{"href":"https://api.github.com/repos/woocommerce/wc-admin/issues/774/comments"},"review_comments":{"href":"https://api.github.com/repos/woocommerce/wc-admin/pulls/774/comments"},"review_comment":{"href":"https://api.github.com/repos/woocommerce/wc-admin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/woocommerce/wc-admin/pulls/774/commits"},"statuses":{"href":"https://api.github.com/repos/woocommerce/wc-admin/statuses/598069f28eddfec9155b9153cd59d719275b7ada"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"timmyc"}}