{"action":"created","issue":{"url":"https://api.github.com/repos/NeurodataWithoutBorders/pynwb/issues/494","repository_url":"https://api.github.com/repos/NeurodataWithoutBorders/pynwb","labels_url":"https://api.github.com/repos/NeurodataWithoutBorders/pynwb/issues/494/labels{/name}","comments_url":"https://api.github.com/repos/NeurodataWithoutBorders/pynwb/issues/494/comments","events_url":"https://api.github.com/repos/NeurodataWithoutBorders/pynwb/issues/494/events","html_url":"https://github.com/NeurodataWithoutBorders/pynwb/issues/494","id":318223315,"number":494,"title":"ophys.ImagingPlane.imaging_rate should be float for consistency","user":{"login":"elyall","id":1179288,"avatar_url":"https://avatars2.githubusercontent.com/u/1179288?v=4","gravatar_id":"","url":"https://api.github.com/users/elyall","html_url":"https://github.com/elyall","followers_url":"https://api.github.com/users/elyall/followers","following_url":"https://api.github.com/users/elyall/following{/other_user}","gists_url":"https://api.github.com/users/elyall/gists{/gist_id}","starred_url":"https://api.github.com/users/elyall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elyall/subscriptions","organizations_url":"https://api.github.com/users/elyall/orgs","repos_url":"https://api.github.com/users/elyall/repos","events_url":"https://api.github.com/users/elyall/events{/privacy}","received_events_url":"https://api.github.com/users/elyall/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-26T22:51:31Z","updated_at":"2018-04-26T23:32:12Z","closed_at":"2018-04-26T23:32:12Z","author_association":"NONE","body":"Sampling frequencies are recorded in multiple locations. As far as I'm aware, in all but 1 of these locations it is referred to as \"rate\" and is specified as a float. \r\n\r\nIn [ophys.ImagingPlane](http://pynwb.readthedocs.io/en/latest/pynwb.ophys.html?highlight=opticalchannel#pynwb.ophys.ImagingPlane) the sampling frequency is specified under \"imaging_rate\" as a string. \r\n\r\nI'd recommend changing the parameter name (\"imaging_rate\" -> \"rate\") and datatype (str -> float) for consistency. "},"comment":{"url":"https://api.github.com/repos/NeurodataWithoutBorders/pynwb/issues/comments/384819526","html_url":"https://github.com/NeurodataWithoutBorders/pynwb/issues/494#issuecomment-384819526","issue_url":"https://api.github.com/repos/NeurodataWithoutBorders/pynwb/issues/494","id":384819526,"user":{"login":"elyall","id":1179288,"avatar_url":"https://avatars2.githubusercontent.com/u/1179288?v=4","gravatar_id":"","url":"https://api.github.com/users/elyall","html_url":"https://github.com/elyall","followers_url":"https://api.github.com/users/elyall/followers","following_url":"https://api.github.com/users/elyall/following{/other_user}","gists_url":"https://api.github.com/users/elyall/gists{/gist_id}","starred_url":"https://api.github.com/users/elyall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elyall/subscriptions","organizations_url":"https://api.github.com/users/elyall/orgs","repos_url":"https://api.github.com/users/elyall/repos","events_url":"https://api.github.com/users/elyall/events{/privacy}","received_events_url":"https://api.github.com/users/elyall/received_events","type":"User","site_admin":false},"created_at":"2018-04-26T23:32:12Z","updated_at":"2018-04-26T23:32:12Z","author_association":"NONE","body":"Ah yes, should've realized that. I'll add my suggestion over there and close this issue."}}
{"actor":{"display_login":"elyall"}}