{"action":"closed","number":864,"pull_request":{"url":"https://api.github.com/repos/drud/ddev/pulls/864","id":188862197,"html_url":"https://github.com/drud/ddev/pull/864","diff_url":"https://github.com/drud/ddev/pull/864.diff","patch_url":"https://github.com/drud/ddev/pull/864.patch","issue_url":"https://api.github.com/repos/drud/ddev/issues/864","number":864,"state":"closed","locked":false,"title":"[regression fix] Make project uniqueness constraint work again, fixes #136","user":{"login":"rfay","id":112444,"avatar_url":"https://avatars2.githubusercontent.com/u/112444?v=4","gravatar_id":"","url":"https://api.github.com/users/rfay","html_url":"https://github.com/rfay","followers_url":"https://api.github.com/users/rfay/followers","following_url":"https://api.github.com/users/rfay/following{/other_user}","gists_url":"https://api.github.com/users/rfay/gists{/gist_id}","starred_url":"https://api.github.com/users/rfay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfay/subscriptions","organizations_url":"https://api.github.com/users/rfay/orgs","repos_url":"https://api.github.com/users/rfay/repos","events_url":"https://api.github.com/users/rfay/events{/privacy}","received_events_url":"https://api.github.com/users/rfay/received_events","type":"User","site_admin":false},"body":"## The Problem/Issue/Bug:\r\n\r\n#136: We had made running projects have to have unique names, but that got lost somewhere. This restores it.\r\n\r\nThis does not solve:\r\n* Duplicate project name when one is not running\r\n* One project taking over another project's database inappropriately (databases are uniquely named as well)\r\n* Duplicated hostnames (across projects) breaking ddev-router. (Adding an additional_hostname to one project that is already taken by another)\r\n\r\n## How this PR Solves The Problem:\r\n\r\nTake seriously when the error says there's a duplicate site.\r\n\r\n## Manual Testing Instructions:\r\n\r\nStart a site.\r\nIn another directory, start a site with the same name. You should get a failure.\r\n\r\n## Automated Testing Overview:\r\n\r\n* The test for uniqueness was updated to catch this case. \r\n\r\n## Related Issue Link(s):\r\n\r\nOP #136 \r\n\r\n## Release/Deployment notes:\r\n<!-- Does this affect anything else, or are there ramifications for other code? Does anything have to be done on deployment? -->\r\n\r\n","created_at":"2018-05-17T21:09:59Z","updated_at":"2018-05-25T23:46:52Z","closed_at":"2018-05-25T23:46:52Z","merged_at":"2018-05-25T23:46:52Z","merge_commit_sha":"8140f3d6dcd3c5d972293b76f2d2bd66d49fc254","assignee":{"login":"rfay","id":112444,"avatar_url":"https://avatars2.githubusercontent.com/u/112444?v=4","gravatar_id":"","url":"https://api.github.com/users/rfay","html_url":"https://github.com/rfay","followers_url":"https://api.github.com/users/rfay/followers","following_url":"https://api.github.com/users/rfay/following{/other_user}","gists_url":"https://api.github.com/users/rfay/gists{/gist_id}","starred_url":"https://api.github.com/users/rfay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfay/subscriptions","organizations_url":"https://api.github.com/users/rfay/orgs","repos_url":"https://api.github.com/users/rfay/repos","events_url":"https://api.github.com/users/rfay/events{/privacy}","received_events_url":"https://api.github.com/users/rfay/received_events","type":"User","site_admin":false},"assignees":[{"login":"rfay","id":112444,"avatar_url":"https://avatars2.githubusercontent.com/u/112444?v=4","gravatar_id":"","url":"https://api.github.com/users/rfay","html_url":"https://github.com/rfay","followers_url":"https://api.github.com/users/rfay/followers","following_url":"https://api.github.com/users/rfay/following{/other_user}","gists_url":"https://api.github.com/users/rfay/gists{/gist_id}","starred_url":"https://api.github.com/users/rfay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfay/subscriptions","organizations_url":"https://api.github.com/users/rfay/orgs","repos_url":"https://api.github.com/users/rfay/repos","events_url":"https://api.github.com/users/rfay/events{/privacy}","received_events_url":"https://api.github.com/users/rfay/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/drud/ddev/milestones/30","html_url":"https://github.com/drud/ddev/milestone/30","labels_url":"https://api.github.com/repos/drud/ddev/milestones/30/labels","id":3325976,"number":30,"title":"v0.19.0","description":"","creator":{"login":"rickmanelius","id":913096,"avatar_url":"https://avatars1.githubusercontent.com/u/913096?v=4","gravatar_id":"","url":"https://api.github.com/users/rickmanelius","html_url":"https://github.com/rickmanelius","followers_url":"https://api.github.com/users/rickmanelius/followers","following_url":"https://api.github.com/users/rickmanelius/following{/other_user}","gists_url":"https://api.github.com/users/rickmanelius/gists{/gist_id}","starred_url":"https://api.github.com/users/rickmanelius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickmanelius/subscriptions","organizations_url":"https://api.github.com/users/rickmanelius/orgs","repos_url":"https://api.github.com/users/rickmanelius/repos","events_url":"https://api.github.com/users/rickmanelius/events{/privacy}","received_events_url":"https://api.github.com/users/rickmanelius/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":24,"state":"open","created_at":"2018-05-07T15:13:02Z","updated_at":"2018-05-25T23:46:52Z","due_on":"2018-05-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/drud/ddev/pulls/864/commits","review_comments_url":"https://api.github.com/repos/drud/ddev/pulls/864/comments","review_comment_url":"https://api.github.com/repos/drud/ddev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/drud/ddev/issues/864/comments","statuses_url":"https://api.github.com/repos/drud/ddev/statuses/422689405d344977c0877f822bd9924bbaebcd85","head":{"label":"rfay:20180517_project_name_uniqueness","ref":"20180517_project_name_uniqueness","sha":"422689405d344977c0877f822bd9924bbaebcd85","user":{"login":"rfay","id":112444,"avatar_url":"https://avatars2.githubusercontent.com/u/112444?v=4","gravatar_id":"","url":"https://api.github.com/users/rfay","html_url":"https://github.com/rfay","followers_url":"https://api.github.com/users/rfay/followers","following_url":"https://api.github.com/users/rfay/following{/other_user}","gists_url":"https://api.github.com/users/rfay/gists{/gist_id}","starred_url":"https://api.github.com/users/rfay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfay/subscriptions","organizations_url":"https://api.github.com/users/rfay/orgs","repos_url":"https://api.github.com/users/rfay/repos","events_url":"https://api.github.com/users/rfay/events{/privacy}","received_events_url":"https://api.github.com/users/rfay/received_events","type":"User","site_admin":false},"repo":{"id":80927419,"name":"ddev","full_name":"rfay/ddev","owner":{"login":"rfay","id":112444,"avatar_url":"https://avatars2.githubusercontent.com/u/112444?v=4","gravatar_id":"","url":"https://api.github.com/users/rfay","html_url":"https://github.com/rfay","followers_url":"https://api.github.com/users/rfay/followers","following_url":"https://api.github.com/users/rfay/following{/other_user}","gists_url":"https://api.github.com/users/rfay/gists{/gist_id}","starred_url":"https://api.github.com/users/rfay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfay/subscriptions","organizations_url":"https://api.github.com/users/rfay/orgs","repos_url":"https://api.github.com/users/rfay/repos","events_url":"https://api.github.com/users/rfay/events{/privacy}","received_events_url":"https://api.github.com/users/rfay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rfay/ddev","description":"Drud dev: a local development environment management system","fork":true,"url":"https://api.github.com/repos/rfay/ddev","forks_url":"https://api.github.com/repos/rfay/ddev/forks","keys_url":"https://api.github.com/repos/rfay/ddev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rfay/ddev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rfay/ddev/teams","hooks_url":"https://api.github.com/repos/rfay/ddev/hooks","issue_events_url":"https://api.github.com/repos/rfay/ddev/issues/events{/number}","events_url":"https://api.github.com/repos/rfay/ddev/events","assignees_url":"https://api.github.com/repos/rfay/ddev/assignees{/user}","branches_url":"https://api.github.com/repos/rfay/ddev/branches{/branch}","tags_url":"https://api.github.com/repos/rfay/ddev/tags","blobs_url":"https://api.github.com/repos/rfay/ddev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rfay/ddev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rfay/ddev/git/refs{/sha}","trees_url":"https://api.github.com/repos/rfay/ddev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rfay/ddev/statuses/{sha}","languages_url":"https://api.github.com/repos/rfay/ddev/languages","stargazers_url":"https://api.github.com/repos/rfay/ddev/stargazers","contributors_url":"https://api.github.com/repos/rfay/ddev/contributors","subscribers_url":"https://api.github.com/repos/rfay/ddev/subscribers","subscription_url":"https://api.github.com/repos/rfay/ddev/subscription","commits_url":"https://api.github.com/repos/rfay/ddev/commits{/sha}","git_commits_url":"https://api.github.com/repos/rfay/ddev/git/commits{/sha}","comments_url":"https://api.github.com/repos/rfay/ddev/comments{/number}","issue_comment_url":"https://api.github.com/repos/rfay/ddev/issues/comments{/number}","contents_url":"https://api.github.com/repos/rfay/ddev/contents/{+path}","compare_url":"https://api.github.com/repos/rfay/ddev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rfay/ddev/merges","archive_url":"https://api.github.com/repos/rfay/ddev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rfay/ddev/downloads","issues_url":"https://api.github.com/repos/rfay/ddev/issues{/number}","pulls_url":"https://api.github.com/repos/rfay/ddev/pulls{/number}","milestones_url":"https://api.github.com/repos/rfay/ddev/milestones{/number}","notifications_url":"https://api.github.com/repos/rfay/ddev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rfay/ddev/labels{/name}","releases_url":"https://api.github.com/repos/rfay/ddev/releases{/id}","deployments_url":"https://api.github.com/repos/rfay/ddev/deployments","created_at":"2017-02-04T15:16:33Z","updated_at":"2018-05-23T13:09:06Z","pushed_at":"2018-05-25T21:39:44Z","git_url":"git://github.com/rfay/ddev.git","ssh_url":"git@github.com:rfay/ddev.git","clone_url":"https://github.com/rfay/ddev.git","svn_url":"https://github.com/rfay/ddev","homepage":null,"size":38252,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"drud:master","ref":"master","sha":"adb0b8ea9850088dddf6f1371a3d567b0701f41d","user":{"login":"drud","id":8115114,"avatar_url":"https://avatars2.githubusercontent.com/u/8115114?v=4","gravatar_id":"","url":"https://api.github.com/users/drud","html_url":"https://github.com/drud","followers_url":"https://api.github.com/users/drud/followers","following_url":"https://api.github.com/users/drud/following{/other_user}","gists_url":"https://api.github.com/users/drud/gists{/gist_id}","starred_url":"https://api.github.com/users/drud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drud/subscriptions","organizations_url":"https://api.github.com/users/drud/orgs","repos_url":"https://api.github.com/users/drud/repos","events_url":"https://api.github.com/users/drud/events{/privacy}","received_events_url":"https://api.github.com/users/drud/received_events","type":"Organization","site_admin":false},"repo":{"id":80669528,"name":"ddev","full_name":"drud/ddev","owner":{"login":"drud","id":8115114,"avatar_url":"https://avatars2.githubusercontent.com/u/8115114?v=4","gravatar_id":"","url":"https://api.github.com/users/drud","html_url":"https://github.com/drud","followers_url":"https://api.github.com/users/drud/followers","following_url":"https://api.github.com/users/drud/following{/other_user}","gists_url":"https://api.github.com/users/drud/gists{/gist_id}","starred_url":"https://api.github.com/users/drud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drud/subscriptions","organizations_url":"https://api.github.com/users/drud/orgs","repos_url":"https://api.github.com/users/drud/repos","events_url":"https://api.github.com/users/drud/events{/privacy}","received_events_url":"https://api.github.com/users/drud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/drud/ddev","description":"DDEV-Local: a local PHP development environment system","fork":false,"url":"https://api.github.com/repos/drud/ddev","forks_url":"https://api.github.com/repos/drud/ddev/forks","keys_url":"https://api.github.com/repos/drud/ddev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drud/ddev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drud/ddev/teams","hooks_url":"https://api.github.com/repos/drud/ddev/hooks","issue_events_url":"https://api.github.com/repos/drud/ddev/issues/events{/number}","events_url":"https://api.github.com/repos/drud/ddev/events","assignees_url":"https://api.github.com/repos/drud/ddev/assignees{/user}","branches_url":"https://api.github.com/repos/drud/ddev/branches{/branch}","tags_url":"https://api.github.com/repos/drud/ddev/tags","blobs_url":"https://api.github.com/repos/drud/ddev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drud/ddev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drud/ddev/git/refs{/sha}","trees_url":"https://api.github.com/repos/drud/ddev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drud/ddev/statuses/{sha}","languages_url":"https://api.github.com/repos/drud/ddev/languages","stargazers_url":"https://api.github.com/repos/drud/ddev/stargazers","contributors_url":"https://api.github.com/repos/drud/ddev/contributors","subscribers_url":"https://api.github.com/repos/drud/ddev/subscribers","subscription_url":"https://api.github.com/repos/drud/ddev/subscription","commits_url":"https://api.github.com/repos/drud/ddev/commits{/sha}","git_commits_url":"https://api.github.com/repos/drud/ddev/git/commits{/sha}","comments_url":"https://api.github.com/repos/drud/ddev/comments{/number}","issue_comment_url":"https://api.github.com/repos/drud/ddev/issues/comments{/number}","contents_url":"https://api.github.com/repos/drud/ddev/contents/{+path}","compare_url":"https://api.github.com/repos/drud/ddev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drud/ddev/merges","archive_url":"https://api.github.com/repos/drud/ddev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drud/ddev/downloads","issues_url":"https://api.github.com/repos/drud/ddev/issues{/number}","pulls_url":"https://api.github.com/repos/drud/ddev/pulls{/number}","milestones_url":"https://api.github.com/repos/drud/ddev/milestones{/number}","notifications_url":"https://api.github.com/repos/drud/ddev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drud/ddev/labels{/name}","releases_url":"https://api.github.com/repos/drud/ddev/releases{/id}","deployments_url":"https://api.github.com/repos/drud/ddev/deployments","created_at":"2017-02-01T22:09:39Z","updated_at":"2018-05-25T21:38:59Z","pushed_at":"2018-05-25T23:46:52Z","git_url":"git://github.com/drud/ddev.git","ssh_url":"git@github.com:drud/ddev.git","clone_url":"https://github.com/drud/ddev.git","svn_url":"https://github.com/drud/ddev","homepage":"https://ddev.readthedocs.io","size":38221,"stargazers_count":150,"watchers_count":150,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":28,"open_issues":98,"watchers":150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/drud/ddev/pulls/864"},"html":{"href":"https://github.com/drud/ddev/pull/864"},"issue":{"href":"https://api.github.com/repos/drud/ddev/issues/864"},"comments":{"href":"https://api.github.com/repos/drud/ddev/issues/864/comments"},"review_comments":{"href":"https://api.github.com/repos/drud/ddev/pulls/864/comments"},"review_comment":{"href":"https://api.github.com/repos/drud/ddev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/drud/ddev/pulls/864/commits"},"statuses":{"href":"https://api.github.com/repos/drud/ddev/statuses/422689405d344977c0877f822bd9924bbaebcd85"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rfay","id":112444,"avatar_url":"https://avatars2.githubusercontent.com/u/112444?v=4","gravatar_id":"","url":"https://api.github.com/users/rfay","html_url":"https://github.com/rfay","followers_url":"https://api.github.com/users/rfay/followers","following_url":"https://api.github.com/users/rfay/following{/other_user}","gists_url":"https://api.github.com/users/rfay/gists{/gist_id}","starred_url":"https://api.github.com/users/rfay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfay/subscriptions","organizations_url":"https://api.github.com/users/rfay/orgs","repos_url":"https://api.github.com/users/rfay/repos","events_url":"https://api.github.com/users/rfay/events{/privacy}","received_events_url":"https://api.github.com/users/rfay/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":12,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"rfay"}}