{"action":"created","issue":{"url":"https://api.github.com/repos/EddyVerbruggen/nativescript-nodeify/issues/29","repository_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-nodeify","labels_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-nodeify/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-nodeify/issues/29/comments","events_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-nodeify/issues/29/events","html_url":"https://github.com/EddyVerbruggen/nativescript-nodeify/issues/29","id":283656060,"number":29,"title":"This plugin breaks build tools","user":{"login":"ukch","id":973865,"avatar_url":"https://avatars1.githubusercontent.com/u/973865?v=4","gravatar_id":"","url":"https://api.github.com/users/ukch","html_url":"https://github.com/ukch","followers_url":"https://api.github.com/users/ukch/followers","following_url":"https://api.github.com/users/ukch/following{/other_user}","gists_url":"https://api.github.com/users/ukch/gists{/gist_id}","starred_url":"https://api.github.com/users/ukch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ukch/subscriptions","organizations_url":"https://api.github.com/users/ukch/orgs","repos_url":"https://api.github.com/users/ukch/repos","events_url":"https://api.github.com/users/ukch/events{/privacy}","received_events_url":"https://api.github.com/users/ukch/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/EddyVerbruggen/nativescript-nodeify/milestones/9","html_url":"https://github.com/EddyVerbruggen/nativescript-nodeify/milestone/9","labels_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-nodeify/milestones/9/labels","id":3075225,"number":9,"title":"0.6.0","description":null,"creator":{"login":"EddyVerbruggen","id":1426370,"avatar_url":"https://avatars1.githubusercontent.com/u/1426370?v=4","gravatar_id":"","url":"https://api.github.com/users/EddyVerbruggen","html_url":"https://github.com/EddyVerbruggen","followers_url":"https://api.github.com/users/EddyVerbruggen/followers","following_url":"https://api.github.com/users/EddyVerbruggen/following{/other_user}","gists_url":"https://api.github.com/users/EddyVerbruggen/gists{/gist_id}","starred_url":"https://api.github.com/users/EddyVerbruggen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EddyVerbruggen/subscriptions","organizations_url":"https://api.github.com/users/EddyVerbruggen/orgs","repos_url":"https://api.github.com/users/EddyVerbruggen/repos","events_url":"https://api.github.com/users/EddyVerbruggen/events{/privacy}","received_events_url":"https://api.github.com/users/EddyVerbruggen/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":2,"state":"open","created_at":"2018-01-30T15:17:10Z","updated_at":"2018-01-30T15:26:19Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2017-12-20T18:31:55Z","updated_at":"2018-03-04T13:22:15Z","closed_at":"2018-01-30T15:26:05Z","author_association":"NONE","body":"Because of the way this plugin works (rewriting almost the whole of `node_modules`), this breaks all non-blacklisted build tools (ie. Babel) and creates a huge headache to debug and use.\r\n\r\nInstead of the current approach (rewrite everything in `node_modules` except those modules that are blacklisted), I propose the following approach:\r\n\r\n1. Read the project's `package.json` and note the `dependencies` (`devDependencies` are ignored)\r\n2. For each noted module:\r\n   * Rewrite imports for the module\r\n   * Repeat step 1, but this time for the module's own `package.json`.\r\n\r\nIn the meanwhile, I have made a fork of this project for my own use, that uses a whitelist instead of a blacklist. If anyone might find it helpful, it is available at [ukch/nativescript-nodeify](https://github.com/ukch/nativescript-nodeify) (any user will probably need to modify the whitelist for their own needs)"},"comment":{"url":"https://api.github.com/repos/EddyVerbruggen/nativescript-nodeify/issues/comments/370229038","html_url":"https://github.com/EddyVerbruggen/nativescript-nodeify/issues/29#issuecomment-370229038","issue_url":"https://api.github.com/repos/EddyVerbruggen/nativescript-nodeify/issues/29","id":370229038,"user":{"login":"EddyVerbruggen","id":1426370,"avatar_url":"https://avatars1.githubusercontent.com/u/1426370?v=4","gravatar_id":"","url":"https://api.github.com/users/EddyVerbruggen","html_url":"https://github.com/EddyVerbruggen","followers_url":"https://api.github.com/users/EddyVerbruggen/followers","following_url":"https://api.github.com/users/EddyVerbruggen/following{/other_user}","gists_url":"https://api.github.com/users/EddyVerbruggen/gists{/gist_id}","starred_url":"https://api.github.com/users/EddyVerbruggen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EddyVerbruggen/subscriptions","organizations_url":"https://api.github.com/users/EddyVerbruggen/orgs","repos_url":"https://api.github.com/users/EddyVerbruggen/repos","events_url":"https://api.github.com/users/EddyVerbruggen/events{/privacy}","received_events_url":"https://api.github.com/users/EddyVerbruggen/received_events","type":"User","site_admin":false},"created_at":"2018-03-04T13:22:15Z","updated_at":"2018-03-04T13:22:15Z","author_association":"OWNER","body":"@kaurag007ph yeah that's what I figured (my previous comment). Thanks for confirming that."}}
{"actor":{"display_login":"EddyVerbruggen"}}