{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71300","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71300/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71300/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71300/events","html_url":"https://github.com/kubernetes/kubernetes/pull/71300","id":382949877,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNTM1MDQ0","number":71300,"title":"Use prometheus conventions for workqueue metrics","user":{"login":"danielqsj","id":7528864,"node_id":"MDQ6VXNlcjc1Mjg4NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7528864?v=4","gravatar_id":"","url":"https://api.github.com/users/danielqsj","html_url":"https://github.com/danielqsj","followers_url":"https://api.github.com/users/danielqsj/followers","following_url":"https://api.github.com/users/danielqsj/following{/other_user}","gists_url":"https://api.github.com/users/danielqsj/gists{/gist_id}","starred_url":"https://api.github.com/users/danielqsj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielqsj/subscriptions","organizations_url":"https://api.github.com/users/danielqsj/orgs","repos_url":"https://api.github.com/users/danielqsj/repos","events_url":"https://api.github.com/users/danielqsj/events{/privacy}","received_events_url":"https://api.github.com/users/danielqsj/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":267761362,"node_id":"MDU6TGFiZWwyNjc3NjEzNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":1111992057,"node_id":"MDU6TGFiZWwxMTExOTkyMDU3","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-priority","name":"needs-priority","color":"ededed","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":173493835,"node_id":"MDU6TGFiZWwxNzM0OTM4MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"mortent","id":8463,"node_id":"MDQ6VXNlcjg0NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8463?v=4","gravatar_id":"","url":"https://api.github.com/users/mortent","html_url":"https://github.com/mortent","followers_url":"https://api.github.com/users/mortent/followers","following_url":"https://api.github.com/users/mortent/following{/other_user}","gists_url":"https://api.github.com/users/mortent/gists{/gist_id}","starred_url":"https://api.github.com/users/mortent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mortent/subscriptions","organizations_url":"https://api.github.com/users/mortent/orgs","repos_url":"https://api.github.com/users/mortent/repos","events_url":"https://api.github.com/users/mortent/events{/privacy}","received_events_url":"https://api.github.com/users/mortent/received_events","type":"User","site_admin":false},"assignees":[{"login":"mortent","id":8463,"node_id":"MDQ6VXNlcjg0NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8463?v=4","gravatar_id":"","url":"https://api.github.com/users/mortent","html_url":"https://github.com/mortent","followers_url":"https://api.github.com/users/mortent/followers","following_url":"https://api.github.com/users/mortent/following{/other_user}","gists_url":"https://api.github.com/users/mortent/gists{/gist_id}","starred_url":"https://api.github.com/users/mortent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mortent/subscriptions","organizations_url":"https://api.github.com/users/mortent/orgs","repos_url":"https://api.github.com/users/mortent/repos","events_url":"https://api.github.com/users/mortent/events{/privacy}","received_events_url":"https://api.github.com/users/mortent/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-11-21T04:23:51Z","updated_at":"2018-11-24T07:18:45Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/71300","html_url":"https://github.com/kubernetes/kubernetes/pull/71300","diff_url":"https://github.com/kubernetes/kubernetes/pull/71300.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/71300.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here:\r\nhttps://git.k8s.io/community/contributors/devel/release.md#issue-kind-label\r\n3. Ensure you have added or ran the appropriate tests for your PR: https://git.k8s.io/community/contributors/devel/testing.md\r\n4. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n5. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n6. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What type of PR is this?**\r\n/kind feature\r\n/sig api-machinery\r\n\r\n**What this PR does / why we need it**:\r\nUse prometheus conventions for workqueue metrics\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #71165\r\n\r\n**Special notes for your reviewer**:\r\nThis patch does not remove the existing metrics but mark them as deprecated.\r\nWe need 2 releases for users to convert monitoring configuration.\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n<!--  \r\nIf no, just write \"NONE\".\r\nIf yes, a release note is required:\r\nEnter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. \r\n-->\r\n```release-note\r\nUse prometheus conventions for workqueue metrics.\r\nIt is now deprecated to use the following metrics:\r\n* `{WorkQueueName}_depth`\r\n* `{WorkQueueName}_adds`\r\n* `{WorkQueueName}_queue_latency`\r\n* `{WorkQueueName}_work_duration`\r\n* `{WorkQueueName}_unfinished_work_seconds`\r\n* `{WorkQueueName}_longest_running_processor_microseconds`\r\n* `{WorkQueueName}_retries`\r\nPlease convert to the following metrics:\r\n* `workqueue_depth`\r\n* `workqueue_adds_total`\r\n* `workqueue_queue_latency_seconds`\r\n* `workqueue_work_duration_seconds`\r\n* `workqueue_unfinished_work_seconds`\r\n* `workqueue_longest_running_processor_seconds`\r\n* `workqueue_retries_total`\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/441349163","html_url":"https://github.com/kubernetes/kubernetes/pull/71300#issuecomment-441349163","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71300","id":441349163,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTM0OTE2Mw==","user":{"login":"mortent","id":8463,"node_id":"MDQ6VXNlcjg0NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8463?v=4","gravatar_id":"","url":"https://api.github.com/users/mortent","html_url":"https://github.com/mortent","followers_url":"https://api.github.com/users/mortent/followers","following_url":"https://api.github.com/users/mortent/following{/other_user}","gists_url":"https://api.github.com/users/mortent/gists{/gist_id}","starred_url":"https://api.github.com/users/mortent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mortent/subscriptions","organizations_url":"https://api.github.com/users/mortent/orgs","repos_url":"https://api.github.com/users/mortent/repos","events_url":"https://api.github.com/users/mortent/events{/privacy}","received_events_url":"https://api.github.com/users/mortent/received_events","type":"User","site_admin":false},"created_at":"2018-11-24T07:18:45Z","updated_at":"2018-11-24T07:18:45Z","author_association":"MEMBER","body":"/lgtm"}}
{"actor":{"display_login":"mortent"}}