{"action":"created","issue":{"url":"https://api.github.com/repos/nodes-vapor/flash/issues/34","repository_url":"https://api.github.com/repos/nodes-vapor/flash","labels_url":"https://api.github.com/repos/nodes-vapor/flash/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/nodes-vapor/flash/issues/34/comments","events_url":"https://api.github.com/repos/nodes-vapor/flash/issues/34/events","html_url":"https://github.com/nodes-vapor/flash/pull/34","id":373222687,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MjAyNDI1","number":34,"title":"Fix PR #29","user":{"login":"code28","id":7918047,"node_id":"MDQ6VXNlcjc5MTgwNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/7918047?v=4","gravatar_id":"","url":"https://api.github.com/users/code28","html_url":"https://github.com/code28","followers_url":"https://api.github.com/users/code28/followers","following_url":"https://api.github.com/users/code28/following{/other_user}","gists_url":"https://api.github.com/users/code28/gists{/gist_id}","starred_url":"https://api.github.com/users/code28/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code28/subscriptions","organizations_url":"https://api.github.com/users/code28/orgs","repos_url":"https://api.github.com/users/code28/repos","events_url":"https://api.github.com/users/code28/events{/privacy}","received_events_url":"https://api.github.com/users/code28/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-23T22:04:38Z","updated_at":"2018-10-24T09:57:24Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/nodes-vapor/flash/pulls/34","html_url":"https://github.com/nodes-vapor/flash/pull/34","diff_url":"https://github.com/nodes-vapor/flash/pull/34.diff","patch_url":"https://github.com/nodes-vapor/flash/pull/34.patch"},"body":"I liked the idea of not having a private container (Issue #26 and Pull request #29). Since there was no development since june, I took a look and fixed two little things (one of them fixes #30), so now I think it works.\r\n\r\nSo the main work for this was done by @siemensikkema, I just made two tiny fixes to make it work. :)"},"comment":{"url":"https://api.github.com/repos/nodes-vapor/flash/issues/comments/432593321","html_url":"https://github.com/nodes-vapor/flash/pull/34#issuecomment-432593321","issue_url":"https://api.github.com/repos/nodes-vapor/flash/issues/34","id":432593321,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjU5MzMyMQ==","user":{"login":"code28","id":7918047,"node_id":"MDQ6VXNlcjc5MTgwNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/7918047?v=4","gravatar_id":"","url":"https://api.github.com/users/code28","html_url":"https://github.com/code28","followers_url":"https://api.github.com/users/code28/followers","following_url":"https://api.github.com/users/code28/following{/other_user}","gists_url":"https://api.github.com/users/code28/gists{/gist_id}","starred_url":"https://api.github.com/users/code28/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code28/subscriptions","organizations_url":"https://api.github.com/users/code28/orgs","repos_url":"https://api.github.com/users/code28/repos","events_url":"https://api.github.com/users/code28/events{/privacy}","received_events_url":"https://api.github.com/users/code28/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T09:57:24Z","updated_at":"2018-10-24T09:57:24Z","author_association":"NONE","body":"Well, it seems to me, that the privateContainer is not necessary anymore. I tried removing `privateContainer` part when en-/decoding to and from the session, and it still works. In general, I don't use private containers for flashes at all in my project and it works.\r\n\r\nI must admit, that I don't fully understand the principle of private containers here, but I have the impression, that we can remove it here.\r\n\r\nI can fix the readme, as soon as we found the way to go :)"}}
{"actor":{"display_login":"code28"}}