{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/182895230","pull_request_review_id":113790228,"id":182895230,"diff_hunk":"@@ -97,6 +103,13 @@ func NewTemplateInstanceController(config *rest.Config, kc kclientsetinternal.In\n \t\t},\n \t})\n \n+\tdiscoveryClient := cacheddiscovery.NewMemCacheClient(c.kc.Discovery())\n+\tc.dynamicRestMapper = discovery.NewDeferredDiscoveryRESTMapper(discoveryClient, meta.InterfacesForUnstructured)\n+\tc.dynamicRestMapper.Reset()","path":"pkg/template/controller/templateinstance_controller.go","position":39,"original_position":39,"commit_id":"f1eaefb0f494162891ee048bbb79041b80bd25f5","original_commit_id":"f1eaefb0f494162891ee048bbb79041b80bd25f5","user":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"body":"This is the third or fourth one of these I've seen and it also happens to *different*.  Put it on the `ControllerContext` and we can fix the debt on the other ones next time we touch them.  Might even take this upstream now that we all use the same discovery.","created_at":"2018-04-19T21:51:50Z","updated_at":"2018-04-19T21:51:50Z","html_url":"https://github.com/openshift/origin/pull/19396#discussion_r182895230","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/19396","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/182895230"},"html":{"href":"https://github.com/openshift/origin/pull/19396#discussion_r182895230"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/19396"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/19396","id":182325982,"html_url":"https://github.com/openshift/origin/pull/19396","diff_url":"https://github.com/openshift/origin/pull/19396.diff","patch_url":"https://github.com/openshift/origin/pull/19396.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/19396","number":19396,"state":"open","locked":false,"title":"allow template instance controller to create CRDs","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars2.githubusercontent.com/u/4974046?v=4","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"Still need to resolve https://bugzilla.redhat.com/show_bug.cgi?id=1568607\r\n\r\nmerging this allows the creation of CRDs, but GC is still going to do weird things.\r\n\r\nfixes https://github.com/openshift/origin/issues/19368\r\n","created_at":"2018-04-17T22:54:27Z","updated_at":"2018-04-19T21:51:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd1abc083b196251a8998d07c41c8fb167f2c8b7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jim-minter","id":1038301,"avatar_url":"https://avatars2.githubusercontent.com/u/1038301?v=4","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},{"login":"juanvallejo","id":3902875,"avatar_url":"https://avatars2.githubusercontent.com/u/3902875?v=4","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":223051294,"url":"https://api.github.com/repos/openshift/origin/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":683198191,"url":"https://api.github.com/repos/openshift/origin/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":657292628,"url":"https://api.github.com/repos/openshift/origin/labels/sig/security","name":"sig/security","color":"f9d0c4","default":false},{"id":640548301,"url":"https://api.github.com/repos/openshift/origin/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/19396/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/19396/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/19396/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/f1eaefb0f494162891ee048bbb79041b80bd25f5","head":{"label":"bparees:template_crds","ref":"template_crds","sha":"f1eaefb0f494162891ee048bbb79041b80bd25f5","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars2.githubusercontent.com/u/4974046?v=4","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"repo":{"id":23590442,"name":"origin","full_name":"bparees/origin","owner":{"login":"bparees","id":4974046,"avatar_url":"https://avatars2.githubusercontent.com/u/4974046?v=4","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bparees/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/bparees/origin","forks_url":"https://api.github.com/repos/bparees/origin/forks","keys_url":"https://api.github.com/repos/bparees/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bparees/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bparees/origin/teams","hooks_url":"https://api.github.com/repos/bparees/origin/hooks","issue_events_url":"https://api.github.com/repos/bparees/origin/issues/events{/number}","events_url":"https://api.github.com/repos/bparees/origin/events","assignees_url":"https://api.github.com/repos/bparees/origin/assignees{/user}","branches_url":"https://api.github.com/repos/bparees/origin/branches{/branch}","tags_url":"https://api.github.com/repos/bparees/origin/tags","blobs_url":"https://api.github.com/repos/bparees/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bparees/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bparees/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bparees/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bparees/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/bparees/origin/languages","stargazers_url":"https://api.github.com/repos/bparees/origin/stargazers","contributors_url":"https://api.github.com/repos/bparees/origin/contributors","subscribers_url":"https://api.github.com/repos/bparees/origin/subscribers","subscription_url":"https://api.github.com/repos/bparees/origin/subscription","commits_url":"https://api.github.com/repos/bparees/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bparees/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bparees/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bparees/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bparees/origin/contents/{+path}","compare_url":"https://api.github.com/repos/bparees/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bparees/origin/merges","archive_url":"https://api.github.com/repos/bparees/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bparees/origin/downloads","issues_url":"https://api.github.com/repos/bparees/origin/issues{/number}","pulls_url":"https://api.github.com/repos/bparees/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/bparees/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/bparees/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bparees/origin/labels{/name}","releases_url":"https://api.github.com/repos/bparees/origin/releases{/id}","deployments_url":"https://api.github.com/repos/bparees/origin/deployments","created_at":"2014-09-02T18:28:48Z","updated_at":"2018-04-19T12:51:44Z","pushed_at":"2018-04-19T21:44:10Z","git_url":"git://github.com/bparees/origin.git","ssh_url":"git@github.com:bparees/origin.git","clone_url":"https://github.com/bparees/origin.git","svn_url":"https://github.com/bparees/origin","homepage":"https://openshift.github.io","size":942873,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"0792236de538f08c85ff570b660777fdfb52dbaa","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2018-04-19T21:41:59Z","pushed_at":"2018-04-19T21:45:16Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":903246,"stargazers_count":4390,"watchers_count":4390,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2736,"mirror_url":null,"archived":false,"open_issues_count":1029,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2736,"open_issues":1029,"watchers":4390,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/19396"},"html":{"href":"https://github.com/openshift/origin/pull/19396"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/19396"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/19396/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/19396/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/19396/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/f1eaefb0f494162891ee048bbb79041b80bd25f5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"deads2k"}}