{"action":"reopened","number":4041,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4041","id":217894621,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3ODk0NjIx","html_url":"https://github.com/apache/incubator-openwhisk/pull/4041","diff_url":"https://github.com/apache/incubator-openwhisk/pull/4041.diff","patch_url":"https://github.com/apache/incubator-openwhisk/pull/4041.patch","issue_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/4041","number":4041,"state":"open","locked":false,"title":"Send active-ack after log collection for nonblocking activations.","user":{"login":"cbickel","id":13397688,"node_id":"MDQ6VXNlcjEzMzk3Njg4","avatar_url":"https://avatars1.githubusercontent.com/u/13397688?v=4","gravatar_id":"","url":"https://api.github.com/users/cbickel","html_url":"https://github.com/cbickel","followers_url":"https://api.github.com/users/cbickel/followers","following_url":"https://api.github.com/users/cbickel/following{/other_user}","gists_url":"https://api.github.com/users/cbickel/gists{/gist_id}","starred_url":"https://api.github.com/users/cbickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbickel/subscriptions","organizations_url":"https://api.github.com/users/cbickel/orgs","repos_url":"https://api.github.com/users/cbickel/repos","events_url":"https://api.github.com/users/cbickel/events{/privacy}","received_events_url":"https://api.github.com/users/cbickel/received_events","type":"User","site_admin":false},"body":"Until now, an active-ack is sent before logs of a container are collected. If one customer writes a lot of logs or if log-collection is slow for some other reason, the invoker already gets new activations, that are queueing up.\r\nThis PR changes the behavior, to send the active-ack (for non-blocking) activations after log collection is finished. For blocking actions, there are two active acks now. One with the response for the user and one to free up the space in the bookkeeping of the loadbalancer.\r\n\r\nI've put this proposal on the dev-list for discussion: https://lists.apache.org/thread.html/726c802f38f3872d057f9adb6a52043eeb8fbd68b601c57bdb12d706@%3Cdev.openwhisk.apache.org%3E\r\n\r\nI'll continue work on this PR, if we come to a conclusion how to proceed with this issue.\r\n\r\n## Related issue and scope\r\n- [ ] I opened an issue to propose and discuss this change (#????)\r\n\r\n## My changes affect the following components\r\n<!--- Select below all system components are affected by your change. -->\r\n<!--- Enter an `x` in all applicable boxes. -->\r\n- [ ] API\r\n- [x] Controller\r\n- [ ] Message Bus (e.g., Kafka)\r\n- [x] Loadbalancer\r\n- [x] Invoker\r\n- [ ] Intrinsic actions (e.g., sequences, conductors)\r\n- [ ] Data stores (e.g., CouchDB)\r\n- [ ] Tests\r\n- [ ] Deployment\r\n- [ ] CLI\r\n- [ ] General tooling\r\n- [ ] Documentation\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->\r\n- [x] Bug fix (generally a non-breaking change which closes an issue).\r\n- [ ] Enhancement or new feature (adds new functionality).\r\n- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).\r\n\r\n## Checklist:\r\n<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->\r\n\r\n- [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).\r\n- [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).\r\n- [ ] I added tests to cover my changes.\r\n- [ ] My changes require further changes to the documentation.\r\n- [ ] I updated the documentation where necessary.\r\n\r\n","created_at":"2018-09-25T08:29:12Z","updated_at":"2018-10-19T09:42:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b379a9908aa97db2810e1bb325bc927fcd96d188","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":962245898,"node_id":"MDU6TGFiZWw5NjIyNDU4OTg=","url":"https://api.github.com/repos/apache/incubator-openwhisk/labels/feature%20request","name":"feature request","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4041/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4041/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/4041/comments","statuses_url":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/6be0ff3a754c7ea90c999e26e1d3cc29db15eded","head":{"label":"cbickel:ack","ref":"ack","sha":"6be0ff3a754c7ea90c999e26e1d3cc29db15eded","user":{"login":"cbickel","id":13397688,"node_id":"MDQ6VXNlcjEzMzk3Njg4","avatar_url":"https://avatars1.githubusercontent.com/u/13397688?v=4","gravatar_id":"","url":"https://api.github.com/users/cbickel","html_url":"https://github.com/cbickel","followers_url":"https://api.github.com/users/cbickel/followers","following_url":"https://api.github.com/users/cbickel/following{/other_user}","gists_url":"https://api.github.com/users/cbickel/gists{/gist_id}","starred_url":"https://api.github.com/users/cbickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbickel/subscriptions","organizations_url":"https://api.github.com/users/cbickel/orgs","repos_url":"https://api.github.com/users/cbickel/repos","events_url":"https://api.github.com/users/cbickel/events{/privacy}","received_events_url":"https://api.github.com/users/cbickel/received_events","type":"User","site_admin":false},"repo":{"id":52370280,"node_id":"MDEwOlJlcG9zaXRvcnk1MjM3MDI4MA==","name":"openwhisk","full_name":"cbickel/openwhisk","private":false,"owner":{"login":"cbickel","id":13397688,"node_id":"MDQ6VXNlcjEzMzk3Njg4","avatar_url":"https://avatars1.githubusercontent.com/u/13397688?v=4","gravatar_id":"","url":"https://api.github.com/users/cbickel","html_url":"https://github.com/cbickel","followers_url":"https://api.github.com/users/cbickel/followers","following_url":"https://api.github.com/users/cbickel/following{/other_user}","gists_url":"https://api.github.com/users/cbickel/gists{/gist_id}","starred_url":"https://api.github.com/users/cbickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbickel/subscriptions","organizations_url":"https://api.github.com/users/cbickel/orgs","repos_url":"https://api.github.com/users/cbickel/repos","events_url":"https://api.github.com/users/cbickel/events{/privacy}","received_events_url":"https://api.github.com/users/cbickel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cbickel/openwhisk","description":"OpenWhisk is a cloud-first distributed event-based programming service.","fork":true,"url":"https://api.github.com/repos/cbickel/openwhisk","forks_url":"https://api.github.com/repos/cbickel/openwhisk/forks","keys_url":"https://api.github.com/repos/cbickel/openwhisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbickel/openwhisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbickel/openwhisk/teams","hooks_url":"https://api.github.com/repos/cbickel/openwhisk/hooks","issue_events_url":"https://api.github.com/repos/cbickel/openwhisk/issues/events{/number}","events_url":"https://api.github.com/repos/cbickel/openwhisk/events","assignees_url":"https://api.github.com/repos/cbickel/openwhisk/assignees{/user}","branches_url":"https://api.github.com/repos/cbickel/openwhisk/branches{/branch}","tags_url":"https://api.github.com/repos/cbickel/openwhisk/tags","blobs_url":"https://api.github.com/repos/cbickel/openwhisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbickel/openwhisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbickel/openwhisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbickel/openwhisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbickel/openwhisk/statuses/{sha}","languages_url":"https://api.github.com/repos/cbickel/openwhisk/languages","stargazers_url":"https://api.github.com/repos/cbickel/openwhisk/stargazers","contributors_url":"https://api.github.com/repos/cbickel/openwhisk/contributors","subscribers_url":"https://api.github.com/repos/cbickel/openwhisk/subscribers","subscription_url":"https://api.github.com/repos/cbickel/openwhisk/subscription","commits_url":"https://api.github.com/repos/cbickel/openwhisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbickel/openwhisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbickel/openwhisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbickel/openwhisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/cbickel/openwhisk/contents/{+path}","compare_url":"https://api.github.com/repos/cbickel/openwhisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbickel/openwhisk/merges","archive_url":"https://api.github.com/repos/cbickel/openwhisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbickel/openwhisk/downloads","issues_url":"https://api.github.com/repos/cbickel/openwhisk/issues{/number}","pulls_url":"https://api.github.com/repos/cbickel/openwhisk/pulls{/number}","milestones_url":"https://api.github.com/repos/cbickel/openwhisk/milestones{/number}","notifications_url":"https://api.github.com/repos/cbickel/openwhisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbickel/openwhisk/labels{/name}","releases_url":"https://api.github.com/repos/cbickel/openwhisk/releases{/id}","deployments_url":"https://api.github.com/repos/cbickel/openwhisk/deployments","created_at":"2016-02-23T15:44:59Z","updated_at":"2018-10-18T06:09:22Z","pushed_at":"2018-10-19T09:40:58Z","git_url":"git://github.com/cbickel/openwhisk.git","ssh_url":"git@github.com:cbickel/openwhisk.git","clone_url":"https://github.com/cbickel/openwhisk.git","svn_url":"https://github.com/cbickel/openwhisk","homepage":"","size":62921,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c8054fa067ea0fbe9f18c96f738618f5da548fe0","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":52039373,"node_id":"MDEwOlJlcG9zaXRvcnk1MjAzOTM3Mw==","name":"incubator-openwhisk","full_name":"apache/incubator-openwhisk","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-openwhisk","description":"Apache OpenWhisk is a serverless event-based programming service and an Apache Incubator project.","fork":false,"url":"https://api.github.com/repos/apache/incubator-openwhisk","forks_url":"https://api.github.com/repos/apache/incubator-openwhisk/forks","keys_url":"https://api.github.com/repos/apache/incubator-openwhisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-openwhisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-openwhisk/teams","hooks_url":"https://api.github.com/repos/apache/incubator-openwhisk/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-openwhisk/events","assignees_url":"https://api.github.com/repos/apache/incubator-openwhisk/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-openwhisk/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-openwhisk/tags","blobs_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-openwhisk/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-openwhisk/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-openwhisk/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-openwhisk/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-openwhisk/subscription","commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-openwhisk/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-openwhisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-openwhisk/merges","archive_url":"https://api.github.com/repos/apache/incubator-openwhisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-openwhisk/downloads","issues_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-openwhisk/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-openwhisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-openwhisk/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-openwhisk/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-openwhisk/deployments","created_at":"2016-02-18T21:16:19Z","updated_at":"2018-10-19T05:50:54Z","pushed_at":"2018-10-19T07:37:31Z","git_url":"git://github.com/apache/incubator-openwhisk.git","ssh_url":"git@github.com:apache/incubator-openwhisk.git","clone_url":"https://github.com/apache/incubator-openwhisk.git","svn_url":"https://github.com/apache/incubator-openwhisk","homepage":"https://openwhisk.apache.org/ ","size":62829,"stargazers_count":3563,"watchers_count":3563,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":668,"mirror_url":null,"archived":false,"open_issues_count":426,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":668,"open_issues":426,"watchers":3563,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4041"},"html":{"href":"https://github.com/apache/incubator-openwhisk/pull/4041"},"issue":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/issues/4041"},"comments":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/issues/4041/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4041/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4041/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/6be0ff3a754c7ea90c999e26e1d3cc29db15eded"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":3,"review_comments":1,"maintainer_can_modify":true,"commits":2,"additions":228,"deletions":123,"changed_files":8}}
{"actor":{"display_login":"cbickel"}}