{"action":"created","comment":{"url":"https://api.github.com/repos/geosolutions-it/MapStore2/pulls/comments/177731497","pull_request_review_id":107655222,"id":177731497,"diff_hunk":"@@ -33,14 +42,7 @@ const layerSelectorWithMarkers = createSelector(\n             newLayers.push(MapInfoUtils.getMarkerLayer(\"GeoCoder\", geocoder.markerPosition, \"marker\",\n                 {\n                     overrideOLStyle: true,\n-                    style: {\n-                        iconUrl: \"https://cdn.rawgit.com/pointhi/leaflet-color-markers/master/img/marker-icon-red.png\",\n-                        shadowUrl: 'https://cdnjs.cloudflare.com/ajax/libs/leaflet/0.7.7/images/marker-shadow.png',\n-                        iconSize: [25, 41],\n-                        iconAnchor: [12, 41],\n-                        popupAnchor: [1, -34],\n-                        shadowSize: [41, 41]\n-                    }\n+                    style: isObject(geocoder.style) && !isEmpty(geocoder.style) && {...deafaultIconStyle, ...geocoder.style} || deafaultIconStyle","path":"web/client/selectors/layers.js","position":37,"original_position":37,"commit_id":"65f3ec1f7386728286c9d0c402c622aa9da0ec72","original_commit_id":"65f3ec1f7386728286c9d0c402c622aa9da0ec72","user":{"login":"MV88","id":11991428,"avatar_url":"https://avatars1.githubusercontent.com/u/11991428?v=4","gravatar_id":"","url":"https://api.github.com/users/MV88","html_url":"https://github.com/MV88","followers_url":"https://api.github.com/users/MV88/followers","following_url":"https://api.github.com/users/MV88/following{/other_user}","gists_url":"https://api.github.com/users/MV88/gists{/gist_id}","starred_url":"https://api.github.com/users/MV88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MV88/subscriptions","organizations_url":"https://api.github.com/users/MV88/orgs","repos_url":"https://api.github.com/users/MV88/repos","events_url":"https://api.github.com/users/MV88/events{/privacy}","received_events_url":"https://api.github.com/users/MV88/received_events","type":"User","site_admin":false},"body":"typo deafaultIconStyle","created_at":"2018-03-28T12:30:03Z","updated_at":"2018-03-28T12:31:41Z","html_url":"https://github.com/geosolutions-it/MapStore2/pull/2771#discussion_r177731497","pull_request_url":"https://api.github.com/repos/geosolutions-it/MapStore2/pulls/2771","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/geosolutions-it/MapStore2/pulls/comments/177731497"},"html":{"href":"https://github.com/geosolutions-it/MapStore2/pull/2771#discussion_r177731497"},"pull_request":{"href":"https://api.github.com/repos/geosolutions-it/MapStore2/pulls/2771"}}},"pull_request":{"url":"https://api.github.com/repos/geosolutions-it/MapStore2/pulls/2771","id":177699399,"html_url":"https://github.com/geosolutions-it/MapStore2/pull/2771","diff_url":"https://github.com/geosolutions-it/MapStore2/pull/2771.diff","patch_url":"https://github.com/geosolutions-it/MapStore2/pull/2771.patch","issue_url":"https://api.github.com/repos/geosolutions-it/MapStore2/issues/2771","number":2771,"state":"open","locked":false,"title":"Fixes #1506 OpenLayers and Leaflet vector different default styles ","user":{"login":"allyoucanmap","id":19175505,"avatar_url":"https://avatars2.githubusercontent.com/u/19175505?v=4","gravatar_id":"","url":"https://api.github.com/users/allyoucanmap","html_url":"https://github.com/allyoucanmap","followers_url":"https://api.github.com/users/allyoucanmap/followers","following_url":"https://api.github.com/users/allyoucanmap/following{/other_user}","gists_url":"https://api.github.com/users/allyoucanmap/gists{/gist_id}","starred_url":"https://api.github.com/users/allyoucanmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allyoucanmap/subscriptions","organizations_url":"https://api.github.com/users/allyoucanmap/orgs","repos_url":"https://api.github.com/users/allyoucanmap/repos","events_url":"https://api.github.com/users/allyoucanmap/events{/privacy}","received_events_url":"https://api.github.com/users/allyoucanmap/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis PR introduces the posiibilities to customize styles for geometries of searched feature (geocoder).\r\nAdded a default style to align OL with Leaflet.\r\n\r\ncustom configuration:\r\n```\r\n{\r\n    \"name\": \"Search\",\r\n    \"cfg\": {\r\n        \"resultsStyle\": {\r\n            \"iconUrl\": \"https://cdn.rawgit.com/pointhi/leaflet-color-markers/master/img/marker-icon-red.png\",\r\n            \"shadowUrl\": \"https://cdnjs.cloudflare.com/ajax/libs/leaflet/0.7.7/images/marker-shadow.png\",\r\n            \"iconSize\": [\r\n                25,\r\n                41\r\n            ],\r\n            \"iconAnchor\": [\r\n                12,\r\n                41\r\n            ],\r\n            \"popupAnchor\": [\r\n                1,\r\n                -34\r\n            ],\r\n            \"shadowSize\": [\r\n                41,\r\n                41\r\n            ],\r\n            \"color\": \"#ff0000\",\r\n            \"weight\": 4,\r\n            \"dashArray\": \"\",\r\n            \"fillColor\": \"rgba(255, 0, 255, 0.2)\",\r\n            \"fillOpacity\": 1.0,\r\n            \"LineString\": {\r\n                // custom style for LineString, it overrides deafult/general style (optional)\r\n            },\r\n            \"MultiLineString\": {\r\n                // custom style for MultiLineString, it overrides deafult/general style (optional)\r\n            },\r\n            \"Polygon\": {\r\n                // custom style for Polygon, it overrides deafult/general style (optional)\r\n            },\r\n            \"MultiPolygon\": {\r\n                // custom style for MultiPolygon, it overrides deafult/general style (optional)\r\n            }\r\n        }\r\n    }\r\n}\r\n```\r\n\r\n## Issues\r\n - Fix #1506\r\n\r\n**Please check if the PR fulfills these requirements**\r\n- [x] The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n- [x] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n**What kind of change does this PR introduce?** (check one with \"x\", remove the others)\r\n\r\n - [x] Feature\r\n\r\n\r\n**What is the current behavior?** (You can also link to an open issue here)\r\nIt's not possible to customize the style of resulted geometries from search (geocoder).\r\nDeafult styles of OL and Leaflet are different.\r\n\r\n**What is the new behavior?**\r\nIt's possible to customize the style of resulted geometries from search (geocoder).\r\nAdded a default style to align OL with Leaflet.\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\", remove the other)\r\n\r\n - [x] No\r\n\r\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications: ...\r\n\r\n**Other information**:\r\n","created_at":"2018-03-27T10:42:22Z","updated_at":"2018-03-28T12:31:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d9a85c05b7b1c5246625fb614fc655cb73bbffc","assignee":{"login":"allyoucanmap","id":19175505,"avatar_url":"https://avatars2.githubusercontent.com/u/19175505?v=4","gravatar_id":"","url":"https://api.github.com/users/allyoucanmap","html_url":"https://github.com/allyoucanmap","followers_url":"https://api.github.com/users/allyoucanmap/followers","following_url":"https://api.github.com/users/allyoucanmap/following{/other_user}","gists_url":"https://api.github.com/users/allyoucanmap/gists{/gist_id}","starred_url":"https://api.github.com/users/allyoucanmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allyoucanmap/subscriptions","organizations_url":"https://api.github.com/users/allyoucanmap/orgs","repos_url":"https://api.github.com/users/allyoucanmap/repos","events_url":"https://api.github.com/users/allyoucanmap/events{/privacy}","received_events_url":"https://api.github.com/users/allyoucanmap/received_events","type":"User","site_admin":false},"assignees":[{"login":"allyoucanmap","id":19175505,"avatar_url":"https://avatars2.githubusercontent.com/u/19175505?v=4","gravatar_id":"","url":"https://api.github.com/users/allyoucanmap","html_url":"https://github.com/allyoucanmap","followers_url":"https://api.github.com/users/allyoucanmap/followers","following_url":"https://api.github.com/users/allyoucanmap/following{/other_user}","gists_url":"https://api.github.com/users/allyoucanmap/gists{/gist_id}","starred_url":"https://api.github.com/users/allyoucanmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allyoucanmap/subscriptions","organizations_url":"https://api.github.com/users/allyoucanmap/orgs","repos_url":"https://api.github.com/users/allyoucanmap/repos","events_url":"https://api.github.com/users/allyoucanmap/events{/privacy}","received_events_url":"https://api.github.com/users/allyoucanmap/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":824935578,"url":"https://api.github.com/repos/geosolutions-it/MapStore2/labels/In%20Test","name":"In Test","color":"d19010","default":false},{"id":798402916,"url":"https://api.github.com/repos/geosolutions-it/MapStore2/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/geosolutions-it/MapStore2/pulls/2771/commits","review_comments_url":"https://api.github.com/repos/geosolutions-it/MapStore2/pulls/2771/comments","review_comment_url":"https://api.github.com/repos/geosolutions-it/MapStore2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geosolutions-it/MapStore2/issues/2771/comments","statuses_url":"https://api.github.com/repos/geosolutions-it/MapStore2/statuses/65f3ec1f7386728286c9d0c402c622aa9da0ec72","head":{"label":"allyoucanmap:highlight-locator","ref":"highlight-locator","sha":"65f3ec1f7386728286c9d0c402c622aa9da0ec72","user":{"login":"allyoucanmap","id":19175505,"avatar_url":"https://avatars2.githubusercontent.com/u/19175505?v=4","gravatar_id":"","url":"https://api.github.com/users/allyoucanmap","html_url":"https://github.com/allyoucanmap","followers_url":"https://api.github.com/users/allyoucanmap/followers","following_url":"https://api.github.com/users/allyoucanmap/following{/other_user}","gists_url":"https://api.github.com/users/allyoucanmap/gists{/gist_id}","starred_url":"https://api.github.com/users/allyoucanmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allyoucanmap/subscriptions","organizations_url":"https://api.github.com/users/allyoucanmap/orgs","repos_url":"https://api.github.com/users/allyoucanmap/repos","events_url":"https://api.github.com/users/allyoucanmap/events{/privacy}","received_events_url":"https://api.github.com/users/allyoucanmap/received_events","type":"User","site_admin":false},"repo":{"id":79842534,"name":"MapStore2","full_name":"allyoucanmap/MapStore2","owner":{"login":"allyoucanmap","id":19175505,"avatar_url":"https://avatars2.githubusercontent.com/u/19175505?v=4","gravatar_id":"","url":"https://api.github.com/users/allyoucanmap","html_url":"https://github.com/allyoucanmap","followers_url":"https://api.github.com/users/allyoucanmap/followers","following_url":"https://api.github.com/users/allyoucanmap/following{/other_user}","gists_url":"https://api.github.com/users/allyoucanmap/gists{/gist_id}","starred_url":"https://api.github.com/users/allyoucanmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allyoucanmap/subscriptions","organizations_url":"https://api.github.com/users/allyoucanmap/orgs","repos_url":"https://api.github.com/users/allyoucanmap/repos","events_url":"https://api.github.com/users/allyoucanmap/events{/privacy}","received_events_url":"https://api.github.com/users/allyoucanmap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/allyoucanmap/MapStore2","description":"Modern webmapping with OL3, Leaflet and React","fork":true,"url":"https://api.github.com/repos/allyoucanmap/MapStore2","forks_url":"https://api.github.com/repos/allyoucanmap/MapStore2/forks","keys_url":"https://api.github.com/repos/allyoucanmap/MapStore2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allyoucanmap/MapStore2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allyoucanmap/MapStore2/teams","hooks_url":"https://api.github.com/repos/allyoucanmap/MapStore2/hooks","issue_events_url":"https://api.github.com/repos/allyoucanmap/MapStore2/issues/events{/number}","events_url":"https://api.github.com/repos/allyoucanmap/MapStore2/events","assignees_url":"https://api.github.com/repos/allyoucanmap/MapStore2/assignees{/user}","branches_url":"https://api.github.com/repos/allyoucanmap/MapStore2/branches{/branch}","tags_url":"https://api.github.com/repos/allyoucanmap/MapStore2/tags","blobs_url":"https://api.github.com/repos/allyoucanmap/MapStore2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allyoucanmap/MapStore2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allyoucanmap/MapStore2/git/refs{/sha}","trees_url":"https://api.github.com/repos/allyoucanmap/MapStore2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allyoucanmap/MapStore2/statuses/{sha}","languages_url":"https://api.github.com/repos/allyoucanmap/MapStore2/languages","stargazers_url":"https://api.github.com/repos/allyoucanmap/MapStore2/stargazers","contributors_url":"https://api.github.com/repos/allyoucanmap/MapStore2/contributors","subscribers_url":"https://api.github.com/repos/allyoucanmap/MapStore2/subscribers","subscription_url":"https://api.github.com/repos/allyoucanmap/MapStore2/subscription","commits_url":"https://api.github.com/repos/allyoucanmap/MapStore2/commits{/sha}","git_commits_url":"https://api.github.com/repos/allyoucanmap/MapStore2/git/commits{/sha}","comments_url":"https://api.github.com/repos/allyoucanmap/MapStore2/comments{/number}","issue_comment_url":"https://api.github.com/repos/allyoucanmap/MapStore2/issues/comments{/number}","contents_url":"https://api.github.com/repos/allyoucanmap/MapStore2/contents/{+path}","compare_url":"https://api.github.com/repos/allyoucanmap/MapStore2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allyoucanmap/MapStore2/merges","archive_url":"https://api.github.com/repos/allyoucanmap/MapStore2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allyoucanmap/MapStore2/downloads","issues_url":"https://api.github.com/repos/allyoucanmap/MapStore2/issues{/number}","pulls_url":"https://api.github.com/repos/allyoucanmap/MapStore2/pulls{/number}","milestones_url":"https://api.github.com/repos/allyoucanmap/MapStore2/milestones{/number}","notifications_url":"https://api.github.com/repos/allyoucanmap/MapStore2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allyoucanmap/MapStore2/labels{/name}","releases_url":"https://api.github.com/repos/allyoucanmap/MapStore2/releases{/id}","deployments_url":"https://api.github.com/repos/allyoucanmap/MapStore2/deployments","created_at":"2017-01-23T20:02:08Z","updated_at":"2017-01-23T20:02:13Z","pushed_at":"2018-03-28T12:28:19Z","git_url":"git://github.com/allyoucanmap/MapStore2.git","ssh_url":"git@github.com:allyoucanmap/MapStore2.git","clone_url":"https://github.com/allyoucanmap/MapStore2.git","svn_url":"https://github.com/allyoucanmap/MapStore2","homepage":"http://mapstore2.geo-solutions.it/","size":21941,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"geosolutions-it:master","ref":"master","sha":"47463ac896e8f400ea5042ae224cd4230804173c","user":{"login":"geosolutions-it","id":775710,"avatar_url":"https://avatars0.githubusercontent.com/u/775710?v=4","gravatar_id":"","url":"https://api.github.com/users/geosolutions-it","html_url":"https://github.com/geosolutions-it","followers_url":"https://api.github.com/users/geosolutions-it/followers","following_url":"https://api.github.com/users/geosolutions-it/following{/other_user}","gists_url":"https://api.github.com/users/geosolutions-it/gists{/gist_id}","starred_url":"https://api.github.com/users/geosolutions-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geosolutions-it/subscriptions","organizations_url":"https://api.github.com/users/geosolutions-it/orgs","repos_url":"https://api.github.com/users/geosolutions-it/repos","events_url":"https://api.github.com/users/geosolutions-it/events{/privacy}","received_events_url":"https://api.github.com/users/geosolutions-it/received_events","type":"Organization","site_admin":false},"repo":{"id":39382076,"name":"MapStore2","full_name":"geosolutions-it/MapStore2","owner":{"login":"geosolutions-it","id":775710,"avatar_url":"https://avatars0.githubusercontent.com/u/775710?v=4","gravatar_id":"","url":"https://api.github.com/users/geosolutions-it","html_url":"https://github.com/geosolutions-it","followers_url":"https://api.github.com/users/geosolutions-it/followers","following_url":"https://api.github.com/users/geosolutions-it/following{/other_user}","gists_url":"https://api.github.com/users/geosolutions-it/gists{/gist_id}","starred_url":"https://api.github.com/users/geosolutions-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geosolutions-it/subscriptions","organizations_url":"https://api.github.com/users/geosolutions-it/orgs","repos_url":"https://api.github.com/users/geosolutions-it/repos","events_url":"https://api.github.com/users/geosolutions-it/events{/privacy}","received_events_url":"https://api.github.com/users/geosolutions-it/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geosolutions-it/MapStore2","description":"Modern webmapping with OL3, Leaflet and React","fork":false,"url":"https://api.github.com/repos/geosolutions-it/MapStore2","forks_url":"https://api.github.com/repos/geosolutions-it/MapStore2/forks","keys_url":"https://api.github.com/repos/geosolutions-it/MapStore2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geosolutions-it/MapStore2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geosolutions-it/MapStore2/teams","hooks_url":"https://api.github.com/repos/geosolutions-it/MapStore2/hooks","issue_events_url":"https://api.github.com/repos/geosolutions-it/MapStore2/issues/events{/number}","events_url":"https://api.github.com/repos/geosolutions-it/MapStore2/events","assignees_url":"https://api.github.com/repos/geosolutions-it/MapStore2/assignees{/user}","branches_url":"https://api.github.com/repos/geosolutions-it/MapStore2/branches{/branch}","tags_url":"https://api.github.com/repos/geosolutions-it/MapStore2/tags","blobs_url":"https://api.github.com/repos/geosolutions-it/MapStore2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geosolutions-it/MapStore2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geosolutions-it/MapStore2/git/refs{/sha}","trees_url":"https://api.github.com/repos/geosolutions-it/MapStore2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geosolutions-it/MapStore2/statuses/{sha}","languages_url":"https://api.github.com/repos/geosolutions-it/MapStore2/languages","stargazers_url":"https://api.github.com/repos/geosolutions-it/MapStore2/stargazers","contributors_url":"https://api.github.com/repos/geosolutions-it/MapStore2/contributors","subscribers_url":"https://api.github.com/repos/geosolutions-it/MapStore2/subscribers","subscription_url":"https://api.github.com/repos/geosolutions-it/MapStore2/subscription","commits_url":"https://api.github.com/repos/geosolutions-it/MapStore2/commits{/sha}","git_commits_url":"https://api.github.com/repos/geosolutions-it/MapStore2/git/commits{/sha}","comments_url":"https://api.github.com/repos/geosolutions-it/MapStore2/comments{/number}","issue_comment_url":"https://api.github.com/repos/geosolutions-it/MapStore2/issues/comments{/number}","contents_url":"https://api.github.com/repos/geosolutions-it/MapStore2/contents/{+path}","compare_url":"https://api.github.com/repos/geosolutions-it/MapStore2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geosolutions-it/MapStore2/merges","archive_url":"https://api.github.com/repos/geosolutions-it/MapStore2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geosolutions-it/MapStore2/downloads","issues_url":"https://api.github.com/repos/geosolutions-it/MapStore2/issues{/number}","pulls_url":"https://api.github.com/repos/geosolutions-it/MapStore2/pulls{/number}","milestones_url":"https://api.github.com/repos/geosolutions-it/MapStore2/milestones{/number}","notifications_url":"https://api.github.com/repos/geosolutions-it/MapStore2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geosolutions-it/MapStore2/labels{/name}","releases_url":"https://api.github.com/repos/geosolutions-it/MapStore2/releases{/id}","deployments_url":"https://api.github.com/repos/geosolutions-it/MapStore2/deployments","created_at":"2015-07-20T12:20:59Z","updated_at":"2018-03-28T07:25:24Z","pushed_at":"2018-03-28T07:25:23Z","git_url":"git://github.com/geosolutions-it/MapStore2.git","ssh_url":"git@github.com:geosolutions-it/MapStore2.git","clone_url":"https://github.com/geosolutions-it/MapStore2.git","svn_url":"https://github.com/geosolutions-it/MapStore2","homepage":"http://mapstore2.geo-solutions.it/","size":21629,"stargazers_count":100,"watchers_count":100,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":85,"mirror_url":null,"archived":false,"open_issues_count":243,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":85,"open_issues":243,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geosolutions-it/MapStore2/pulls/2771"},"html":{"href":"https://github.com/geosolutions-it/MapStore2/pull/2771"},"issue":{"href":"https://api.github.com/repos/geosolutions-it/MapStore2/issues/2771"},"comments":{"href":"https://api.github.com/repos/geosolutions-it/MapStore2/issues/2771/comments"},"review_comments":{"href":"https://api.github.com/repos/geosolutions-it/MapStore2/pulls/2771/comments"},"review_comment":{"href":"https://api.github.com/repos/geosolutions-it/MapStore2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geosolutions-it/MapStore2/pulls/2771/commits"},"statuses":{"href":"https://api.github.com/repos/geosolutions-it/MapStore2/statuses/65f3ec1f7386728286c9d0c402c622aa9da0ec72"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"MV88"}}