{"action":"created","comment":{"url":"https://api.github.com/repos/wix/wix-style-react/pulls/comments/195450659","pull_request_review_id":128821693,"id":195450659,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTQ1MDY1OQ==","diff_hunk":"@@ -39,24 +37,33 @@ describe('AddItem', () => {\n \n   describe('height and width', () => {\n \n-    it('should be added to style attribute when item is not present', () => {\n+    it('should use asspect ratio from props', () => {\n+      props = {\n+        aspectRatio: '16/9'\n+      };\n       driver = createDriver(<AddItem {...props}/>);\n-      expect(driver.getHeight()).toEqual('400px');\n-      expect(driver.getWidth()).toEqual('300px');\n+      expect(driver.getRadio()).toEqual('ratio16x9');","path":"src/AddItem/AddItem.spec.js","position":23,"original_position":23,"commit_id":"197b69debdab24557856cc74304e517a78ac766d","original_commit_id":"197b69debdab24557856cc74304e517a78ac766d","user":{"login":"lbelinsk","id":18248989,"node_id":"MDQ6VXNlcjE4MjQ4OTg5","avatar_url":"https://avatars1.githubusercontent.com/u/18248989?v=4","gravatar_id":"","url":"https://api.github.com/users/lbelinsk","html_url":"https://github.com/lbelinsk","followers_url":"https://api.github.com/users/lbelinsk/followers","following_url":"https://api.github.com/users/lbelinsk/following{/other_user}","gists_url":"https://api.github.com/users/lbelinsk/gists{/gist_id}","starred_url":"https://api.github.com/users/lbelinsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbelinsk/subscriptions","organizations_url":"https://api.github.com/users/lbelinsk/orgs","repos_url":"https://api.github.com/users/lbelinsk/repos","events_url":"https://api.github.com/users/lbelinsk/events{/privacy}","received_events_url":"https://api.github.com/users/lbelinsk/received_events","type":"User","site_admin":false},"body":"`getRadio` --> `getRatio`\r\nAnd I think it will be nicer just to return `16x9` not `ratio16x9` (think about the end user)","created_at":"2018-06-14T14:42:29Z","updated_at":"2018-06-14T14:43:12Z","html_url":"https://github.com/wix/wix-style-react/pull/1822#discussion_r195450659","pull_request_url":"https://api.github.com/repos/wix/wix-style-react/pulls/1822","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/comments/195450659"},"html":{"href":"https://github.com/wix/wix-style-react/pull/1822#discussion_r195450659"},"pull_request":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/1822"}}},"pull_request":{"url":"https://api.github.com/repos/wix/wix-style-react/pulls/1822","id":194807156,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0ODA3MTU2","html_url":"https://github.com/wix/wix-style-react/pull/1822","diff_url":"https://github.com/wix/wix-style-react/pull/1822.diff","patch_url":"https://github.com/wix/wix-style-react/pull/1822.patch","issue_url":"https://api.github.com/repos/wix/wix-style-react/issues/1822","number":1822,"state":"open","locked":false,"title":"Add item ratio","user":{"login":"shaibv","id":4509002,"node_id":"MDQ6VXNlcjQ1MDkwMDI=","avatar_url":"https://avatars2.githubusercontent.com/u/4509002?v=4","gravatar_id":"","url":"https://api.github.com/users/shaibv","html_url":"https://github.com/shaibv","followers_url":"https://api.github.com/users/shaibv/followers","following_url":"https://api.github.com/users/shaibv/following{/other_user}","gists_url":"https://api.github.com/users/shaibv/gists{/gist_id}","starred_url":"https://api.github.com/users/shaibv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaibv/subscriptions","organizations_url":"https://api.github.com/users/shaibv/orgs","repos_url":"https://api.github.com/users/shaibv/repos","events_url":"https://api.github.com/users/shaibv/events{/privacy}","received_events_url":"https://api.github.com/users/shaibv/received_events","type":"User","site_admin":false},"body":"### What changed\r\n\r\n...\r\n\r\n### Why it changed\r\n\r\n...\r\n\r\n---\r\n\r\n- [ ] Change is tested\r\n- [ ] Change is documented\r\n- [ ] Build is green\r\n- [ ] Change of UX is approved by [wuwa](https://github.com/wuwa) or [milkyfruit](https://github.com/milkyfruit)\r\n\r\n### Thanks for contributing :)\r\n","created_at":"2018-06-14T07:56:26Z","updated_at":"2018-06-14T14:43:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32e02ed39cb6484da65a1d18116807177e155d6d","assignee":{"login":"lbelinsk","id":18248989,"node_id":"MDQ6VXNlcjE4MjQ4OTg5","avatar_url":"https://avatars1.githubusercontent.com/u/18248989?v=4","gravatar_id":"","url":"https://api.github.com/users/lbelinsk","html_url":"https://github.com/lbelinsk","followers_url":"https://api.github.com/users/lbelinsk/followers","following_url":"https://api.github.com/users/lbelinsk/following{/other_user}","gists_url":"https://api.github.com/users/lbelinsk/gists{/gist_id}","starred_url":"https://api.github.com/users/lbelinsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbelinsk/subscriptions","organizations_url":"https://api.github.com/users/lbelinsk/orgs","repos_url":"https://api.github.com/users/lbelinsk/repos","events_url":"https://api.github.com/users/lbelinsk/events{/privacy}","received_events_url":"https://api.github.com/users/lbelinsk/received_events","type":"User","site_admin":false},"assignees":[{"login":"lbelinsk","id":18248989,"node_id":"MDQ6VXNlcjE4MjQ4OTg5","avatar_url":"https://avatars1.githubusercontent.com/u/18248989?v=4","gravatar_id":"","url":"https://api.github.com/users/lbelinsk","html_url":"https://github.com/lbelinsk","followers_url":"https://api.github.com/users/lbelinsk/followers","following_url":"https://api.github.com/users/lbelinsk/following{/other_user}","gists_url":"https://api.github.com/users/lbelinsk/gists{/gist_id}","starred_url":"https://api.github.com/users/lbelinsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbelinsk/subscriptions","organizations_url":"https://api.github.com/users/lbelinsk/orgs","repos_url":"https://api.github.com/users/lbelinsk/repos","events_url":"https://api.github.com/users/lbelinsk/events{/privacy}","received_events_url":"https://api.github.com/users/lbelinsk/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wix/wix-style-react/pulls/1822/commits","review_comments_url":"https://api.github.com/repos/wix/wix-style-react/pulls/1822/comments","review_comment_url":"https://api.github.com/repos/wix/wix-style-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wix/wix-style-react/issues/1822/comments","statuses_url":"https://api.github.com/repos/wix/wix-style-react/statuses/197b69debdab24557856cc74304e517a78ac766d","head":{"label":"wix:AddItem_ratio","ref":"AddItem_ratio","sha":"197b69debdab24557856cc74304e517a78ac766d","user":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"repo":{"id":73713311,"node_id":"MDEwOlJlcG9zaXRvcnk3MzcxMzMxMQ==","name":"wix-style-react","full_name":"wix/wix-style-react","owner":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wix/wix-style-react","description":"Common React UI components for all Wix verticals developing in React","fork":false,"url":"https://api.github.com/repos/wix/wix-style-react","forks_url":"https://api.github.com/repos/wix/wix-style-react/forks","keys_url":"https://api.github.com/repos/wix/wix-style-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wix/wix-style-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wix/wix-style-react/teams","hooks_url":"https://api.github.com/repos/wix/wix-style-react/hooks","issue_events_url":"https://api.github.com/repos/wix/wix-style-react/issues/events{/number}","events_url":"https://api.github.com/repos/wix/wix-style-react/events","assignees_url":"https://api.github.com/repos/wix/wix-style-react/assignees{/user}","branches_url":"https://api.github.com/repos/wix/wix-style-react/branches{/branch}","tags_url":"https://api.github.com/repos/wix/wix-style-react/tags","blobs_url":"https://api.github.com/repos/wix/wix-style-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wix/wix-style-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wix/wix-style-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/wix/wix-style-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wix/wix-style-react/statuses/{sha}","languages_url":"https://api.github.com/repos/wix/wix-style-react/languages","stargazers_url":"https://api.github.com/repos/wix/wix-style-react/stargazers","contributors_url":"https://api.github.com/repos/wix/wix-style-react/contributors","subscribers_url":"https://api.github.com/repos/wix/wix-style-react/subscribers","subscription_url":"https://api.github.com/repos/wix/wix-style-react/subscription","commits_url":"https://api.github.com/repos/wix/wix-style-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/wix/wix-style-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/wix/wix-style-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/wix/wix-style-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/wix/wix-style-react/contents/{+path}","compare_url":"https://api.github.com/repos/wix/wix-style-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wix/wix-style-react/merges","archive_url":"https://api.github.com/repos/wix/wix-style-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wix/wix-style-react/downloads","issues_url":"https://api.github.com/repos/wix/wix-style-react/issues{/number}","pulls_url":"https://api.github.com/repos/wix/wix-style-react/pulls{/number}","milestones_url":"https://api.github.com/repos/wix/wix-style-react/milestones{/number}","notifications_url":"https://api.github.com/repos/wix/wix-style-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wix/wix-style-react/labels{/name}","releases_url":"https://api.github.com/repos/wix/wix-style-react/releases{/id}","deployments_url":"https://api.github.com/repos/wix/wix-style-react/deployments","created_at":"2016-11-14T14:37:00Z","updated_at":"2018-06-14T12:24:13Z","pushed_at":"2018-06-14T14:20:37Z","git_url":"git://github.com/wix/wix-style-react.git","ssh_url":"git@github.com:wix/wix-style-react.git","clone_url":"https://github.com/wix/wix-style-react.git","svn_url":"https://github.com/wix/wix-style-react","homepage":"https://wix-wix-style-react.surge.sh","size":7628,"stargazers_count":289,"watchers_count":289,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":66,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":66,"open_issues":112,"watchers":289,"default_branch":"master"}},"base":{"label":"wix:master","ref":"master","sha":"26aecae800087b3891b4d1b17aaca09c16e8e181","user":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"repo":{"id":73713311,"node_id":"MDEwOlJlcG9zaXRvcnk3MzcxMzMxMQ==","name":"wix-style-react","full_name":"wix/wix-style-react","owner":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wix/wix-style-react","description":"Common React UI components for all Wix verticals developing in React","fork":false,"url":"https://api.github.com/repos/wix/wix-style-react","forks_url":"https://api.github.com/repos/wix/wix-style-react/forks","keys_url":"https://api.github.com/repos/wix/wix-style-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wix/wix-style-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wix/wix-style-react/teams","hooks_url":"https://api.github.com/repos/wix/wix-style-react/hooks","issue_events_url":"https://api.github.com/repos/wix/wix-style-react/issues/events{/number}","events_url":"https://api.github.com/repos/wix/wix-style-react/events","assignees_url":"https://api.github.com/repos/wix/wix-style-react/assignees{/user}","branches_url":"https://api.github.com/repos/wix/wix-style-react/branches{/branch}","tags_url":"https://api.github.com/repos/wix/wix-style-react/tags","blobs_url":"https://api.github.com/repos/wix/wix-style-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wix/wix-style-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wix/wix-style-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/wix/wix-style-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wix/wix-style-react/statuses/{sha}","languages_url":"https://api.github.com/repos/wix/wix-style-react/languages","stargazers_url":"https://api.github.com/repos/wix/wix-style-react/stargazers","contributors_url":"https://api.github.com/repos/wix/wix-style-react/contributors","subscribers_url":"https://api.github.com/repos/wix/wix-style-react/subscribers","subscription_url":"https://api.github.com/repos/wix/wix-style-react/subscription","commits_url":"https://api.github.com/repos/wix/wix-style-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/wix/wix-style-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/wix/wix-style-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/wix/wix-style-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/wix/wix-style-react/contents/{+path}","compare_url":"https://api.github.com/repos/wix/wix-style-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wix/wix-style-react/merges","archive_url":"https://api.github.com/repos/wix/wix-style-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wix/wix-style-react/downloads","issues_url":"https://api.github.com/repos/wix/wix-style-react/issues{/number}","pulls_url":"https://api.github.com/repos/wix/wix-style-react/pulls{/number}","milestones_url":"https://api.github.com/repos/wix/wix-style-react/milestones{/number}","notifications_url":"https://api.github.com/repos/wix/wix-style-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wix/wix-style-react/labels{/name}","releases_url":"https://api.github.com/repos/wix/wix-style-react/releases{/id}","deployments_url":"https://api.github.com/repos/wix/wix-style-react/deployments","created_at":"2016-11-14T14:37:00Z","updated_at":"2018-06-14T12:24:13Z","pushed_at":"2018-06-14T14:20:37Z","git_url":"git://github.com/wix/wix-style-react.git","ssh_url":"git@github.com:wix/wix-style-react.git","clone_url":"https://github.com/wix/wix-style-react.git","svn_url":"https://github.com/wix/wix-style-react","homepage":"https://wix-wix-style-react.surge.sh","size":7628,"stargazers_count":289,"watchers_count":289,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":66,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":66,"open_issues":112,"watchers":289,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/1822"},"html":{"href":"https://github.com/wix/wix-style-react/pull/1822"},"issue":{"href":"https://api.github.com/repos/wix/wix-style-react/issues/1822"},"comments":{"href":"https://api.github.com/repos/wix/wix-style-react/issues/1822/comments"},"review_comments":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/1822/comments"},"review_comment":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wix/wix-style-react/pulls/1822/commits"},"statuses":{"href":"https://api.github.com/repos/wix/wix-style-react/statuses/197b69debdab24557856cc74304e517a78ac766d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lbelinsk"}}