{"action":"created","comment":{"url":"https://api.github.com/repos/ufz/ogs/pulls/comments/234210194","pull_request_review_id":175809052,"id":234210194,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDIxMDE5NA==","diff_hunk":"@@ -0,0 +1,252 @@\n+/**\n+ * \\file\n+ *\n+ * \\copyright\n+ * Copyright (c) 2012-2018, OpenGeoSys Community (http://www.opengeosys.org)\n+ *            Distributed under a Modified BSD License.\n+ *              See accompanying file LICENSE.txt or\n+ *              http://www.opengeosys.org/project/license\n+ *\n+ */\n+\n+#include \"TestDefinition.h\"\n+\n+#include <cstdlib>\n+\n+#include \"BaseLib/ConfigTree.h\"\n+#include \"BaseLib/Error.h\"\n+#include \"BaseLib/FileTools.h\"\n+#ifdef USE_PETSC\n+#include \"MeshLib/IO/VtkIO/VtuInterface.h\"  // For petsc file name conversion.\n+#include <petsc.h>\n+#endif\n+\n+namespace\n+{\n+/// Test if the given string is convertible to a valid double value, not a NaN.\n+bool isConvertibleToDouble(std::string const& s)\n+{\n+    std::size_t pos = 0;\n+    double value;\n+    try\n+    {\n+        value = std::stod(s, &pos);\n+    }\n+    catch (...)\n+    {\n+        OGS_FATAL(\"The given string '%s' is not convertible to double.\",\n+                  s.c_str());\n+    }\n+    if (pos != s.size())\n+    {\n+        OGS_FATAL(\n+            \"Only %d characters were used for double conversion of string '%s'\",\n+            pos, s.c_str());\n+    }\n+\n+    if (std::isnan(value))","path":"Applications/ApplicationsLib/TestDefinition.cpp","position":47,"original_position":47,"commit_id":"a0e987b3b977194390c16734d2ec9b3e8bfbc99a","original_commit_id":"a0e987b3b977194390c16734d2ec9b3e8bfbc99a","user":{"login":"wenqing","id":1343839,"node_id":"MDQ6VXNlcjEzNDM4Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/1343839?v=4","gravatar_id":"","url":"https://api.github.com/users/wenqing","html_url":"https://github.com/wenqing","followers_url":"https://api.github.com/users/wenqing/followers","following_url":"https://api.github.com/users/wenqing/following{/other_user}","gists_url":"https://api.github.com/users/wenqing/gists{/gist_id}","starred_url":"https://api.github.com/users/wenqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wenqing/subscriptions","organizations_url":"https://api.github.com/users/wenqing/orgs","repos_url":"https://api.github.com/users/wenqing/repos","events_url":"https://api.github.com/users/wenqing/events{/privacy}","received_events_url":"https://api.github.com/users/wenqing/received_events","type":"User","site_admin":false},"body":"@bilke Thanks.","created_at":"2018-11-16T13:53:46Z","updated_at":"2018-11-16T13:53:47Z","html_url":"https://github.com/ufz/ogs/pull/2255#discussion_r234210194","pull_request_url":"https://api.github.com/repos/ufz/ogs/pulls/2255","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/234210194"},"html":{"href":"https://github.com/ufz/ogs/pull/2255#discussion_r234210194"},"pull_request":{"href":"https://api.github.com/repos/ufz/ogs/pulls/2255"}},"in_reply_to_id":234156853},"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/2255","id":228211234,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MjExMjM0","html_url":"https://github.com/ufz/ogs/pull/2255","diff_url":"https://github.com/ufz/ogs/pull/2255.diff","patch_url":"https://github.com/ufz/ogs/pull/2255.patch","issue_url":"https://api.github.com/repos/ufz/ogs/issues/2255","number":2255,"state":"closed","locked":false,"title":"OgsTester. Add test definitions to project files.","user":{"login":"endJunction","id":329493,"node_id":"MDQ6VXNlcjMyOTQ5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/329493?v=4","gravatar_id":"","url":"https://api.github.com/users/endJunction","html_url":"https://github.com/endJunction","followers_url":"https://api.github.com/users/endJunction/followers","following_url":"https://api.github.com/users/endJunction/following{/other_user}","gists_url":"https://api.github.com/users/endJunction/gists{/gist_id}","starred_url":"https://api.github.com/users/endJunction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endJunction/subscriptions","organizations_url":"https://api.github.com/users/endJunction/orgs","repos_url":"https://api.github.com/users/endJunction/repos","events_url":"https://api.github.com/users/endJunction/events{/privacy}","received_events_url":"https://api.github.com/users/endJunction/received_events","type":"User","site_admin":false},"body":"Move test definitions into the project files and add a \"test mode\" to the ogs executable.","created_at":"2018-11-04T23:28:02Z","updated_at":"2018-11-16T13:53:47Z","closed_at":"2018-11-14T22:02:59Z","merged_at":"2018-11-14T22:02:59Z","merge_commit_sha":"8dd1ce415eb6ab6c7e0572db3103b4b9474ad463","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ufz/ogs/pulls/2255/commits","review_comments_url":"https://api.github.com/repos/ufz/ogs/pulls/2255/comments","review_comment_url":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/2255/comments","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/a0e987b3b977194390c16734d2ec9b3e8bfbc99a","head":{"label":"endJunction:OgsTester","ref":"OgsTester","sha":"a0e987b3b977194390c16734d2ec9b3e8bfbc99a","user":{"login":"endJunction","id":329493,"node_id":"MDQ6VXNlcjMyOTQ5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/329493?v=4","gravatar_id":"","url":"https://api.github.com/users/endJunction","html_url":"https://github.com/endJunction","followers_url":"https://api.github.com/users/endJunction/followers","following_url":"https://api.github.com/users/endJunction/following{/other_user}","gists_url":"https://api.github.com/users/endJunction/gists{/gist_id}","starred_url":"https://api.github.com/users/endJunction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endJunction/subscriptions","organizations_url":"https://api.github.com/users/endJunction/orgs","repos_url":"https://api.github.com/users/endJunction/repos","events_url":"https://api.github.com/users/endJunction/events{/privacy}","received_events_url":"https://api.github.com/users/endJunction/received_events","type":"User","site_admin":false},"repo":{"id":6429859,"node_id":"MDEwOlJlcG9zaXRvcnk2NDI5ODU5","name":"ogs","full_name":"endJunction/ogs","private":false,"owner":{"login":"endJunction","id":329493,"node_id":"MDQ6VXNlcjMyOTQ5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/329493?v=4","gravatar_id":"","url":"https://api.github.com/users/endJunction","html_url":"https://github.com/endJunction","followers_url":"https://api.github.com/users/endJunction/followers","following_url":"https://api.github.com/users/endJunction/following{/other_user}","gists_url":"https://api.github.com/users/endJunction/gists{/gist_id}","starred_url":"https://api.github.com/users/endJunction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endJunction/subscriptions","organizations_url":"https://api.github.com/users/endJunction/orgs","repos_url":"https://api.github.com/users/endJunction/repos","events_url":"https://api.github.com/users/endJunction/events{/privacy}","received_events_url":"https://api.github.com/users/endJunction/received_events","type":"User","site_admin":false},"html_url":"https://github.com/endJunction/ogs","description":"OGS source code","fork":true,"url":"https://api.github.com/repos/endJunction/ogs","forks_url":"https://api.github.com/repos/endJunction/ogs/forks","keys_url":"https://api.github.com/repos/endJunction/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endJunction/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endJunction/ogs/teams","hooks_url":"https://api.github.com/repos/endJunction/ogs/hooks","issue_events_url":"https://api.github.com/repos/endJunction/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/endJunction/ogs/events","assignees_url":"https://api.github.com/repos/endJunction/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/endJunction/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/endJunction/ogs/tags","blobs_url":"https://api.github.com/repos/endJunction/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endJunction/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endJunction/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/endJunction/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endJunction/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/endJunction/ogs/languages","stargazers_url":"https://api.github.com/repos/endJunction/ogs/stargazers","contributors_url":"https://api.github.com/repos/endJunction/ogs/contributors","subscribers_url":"https://api.github.com/repos/endJunction/ogs/subscribers","subscription_url":"https://api.github.com/repos/endJunction/ogs/subscription","commits_url":"https://api.github.com/repos/endJunction/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/endJunction/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/endJunction/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/endJunction/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/endJunction/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/endJunction/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endJunction/ogs/merges","archive_url":"https://api.github.com/repos/endJunction/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endJunction/ogs/downloads","issues_url":"https://api.github.com/repos/endJunction/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/endJunction/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/endJunction/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/endJunction/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endJunction/ogs/labels{/name}","releases_url":"https://api.github.com/repos/endJunction/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/endJunction/ogs/deployments","created_at":"2012-10-28T17:18:48Z","updated_at":"2018-11-14T09:24:52Z","pushed_at":"2018-11-15T16:54:45Z","git_url":"git://github.com/endJunction/ogs.git","ssh_url":"git@github.com:endJunction/ogs.git","clone_url":"https://github.com/endJunction/ogs.git","svn_url":"https://github.com/endJunction/ogs","homepage":"www.opengeosys.net","size":52644,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ufz:master","ref":"master","sha":"2e6ee4dd3f90af4da21cdbd551b33c5a6a994207","user":{"login":"ufz","id":767517,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NzUxNw==","avatar_url":"https://avatars3.githubusercontent.com/u/767517?v=4","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"repo":{"id":1701384,"node_id":"MDEwOlJlcG9zaXRvcnkxNzAxMzg0","name":"ogs","full_name":"ufz/ogs","private":false,"owner":{"login":"ufz","id":767517,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NzUxNw==","avatar_url":"https://avatars3.githubusercontent.com/u/767517?v=4","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ufz/ogs","description":"OGS-6 source code","fork":false,"url":"https://api.github.com/repos/ufz/ogs","forks_url":"https://api.github.com/repos/ufz/ogs/forks","keys_url":"https://api.github.com/repos/ufz/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufz/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufz/ogs/teams","hooks_url":"https://api.github.com/repos/ufz/ogs/hooks","issue_events_url":"https://api.github.com/repos/ufz/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/ufz/ogs/events","assignees_url":"https://api.github.com/repos/ufz/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/ufz/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/ufz/ogs/tags","blobs_url":"https://api.github.com/repos/ufz/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufz/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufz/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufz/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/ufz/ogs/languages","stargazers_url":"https://api.github.com/repos/ufz/ogs/stargazers","contributors_url":"https://api.github.com/repos/ufz/ogs/contributors","subscribers_url":"https://api.github.com/repos/ufz/ogs/subscribers","subscription_url":"https://api.github.com/repos/ufz/ogs/subscription","commits_url":"https://api.github.com/repos/ufz/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufz/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufz/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufz/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufz/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/ufz/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufz/ogs/merges","archive_url":"https://api.github.com/repos/ufz/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufz/ogs/downloads","issues_url":"https://api.github.com/repos/ufz/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/ufz/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/ufz/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/ufz/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufz/ogs/labels{/name}","releases_url":"https://api.github.com/repos/ufz/ogs/releases{/id}","deployments_url":"https://api.github.com/repos/ufz/ogs/deployments","created_at":"2011-05-04T14:09:57Z","updated_at":"2018-11-16T13:23:37Z","pushed_at":"2018-11-16T13:23:33Z","git_url":"git://github.com/ufz/ogs.git","ssh_url":"git@github.com:ufz/ogs.git","clone_url":"https://github.com/ufz/ogs.git","svn_url":"https://github.com/ufz/ogs","homepage":"https://www.opengeosys.org","size":39407,"stargazers_count":39,"watchers_count":39,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":137,"mirror_url":null,"archived":false,"open_issues_count":116,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":137,"open_issues":116,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/2255"},"html":{"href":"https://github.com/ufz/ogs/pull/2255"},"issue":{"href":"https://api.github.com/repos/ufz/ogs/issues/2255"},"comments":{"href":"https://api.github.com/repos/ufz/ogs/issues/2255/comments"},"review_comments":{"href":"https://api.github.com/repos/ufz/ogs/pulls/2255/comments"},"review_comment":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ufz/ogs/pulls/2255/commits"},"statuses":{"href":"https://api.github.com/repos/ufz/ogs/statuses/a0e987b3b977194390c16734d2ec9b3e8bfbc99a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"wenqing"}}