{"action":"closed","number":3458,"pull_request":{"url":"https://api.github.com/repos/duplicati/duplicati/pulls/3458","id":225567180,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NTY3MTgw","html_url":"https://github.com/duplicati/duplicati/pull/3458","diff_url":"https://github.com/duplicati/duplicati/pull/3458.diff","patch_url":"https://github.com/duplicati/duplicati/pull/3458.patch","issue_url":"https://api.github.com/repos/duplicati/duplicati/issues/3458","number":3458,"state":"closed","locked":false,"title":"Fix useless notification \"Warning: Got 0 warning(s)\"","user":{"login":"mikaelmello","id":17488630,"node_id":"MDQ6VXNlcjE3NDg4NjMw","avatar_url":"https://avatars3.githubusercontent.com/u/17488630?v=4","gravatar_id":"","url":"https://api.github.com/users/mikaelmello","html_url":"https://github.com/mikaelmello","followers_url":"https://api.github.com/users/mikaelmello/followers","following_url":"https://api.github.com/users/mikaelmello/following{/other_user}","gists_url":"https://api.github.com/users/mikaelmello/gists{/gist_id}","starred_url":"https://api.github.com/users/mikaelmello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikaelmello/subscriptions","organizations_url":"https://api.github.com/users/mikaelmello/orgs","repos_url":"https://api.github.com/users/mikaelmello/repos","events_url":"https://api.github.com/users/mikaelmello/events{/privacy}","received_events_url":"https://api.github.com/users/mikaelmello/received_events","type":"User","site_admin":false},"body":"When a restore was made in which 0 files were restored, the Result has Success set to \"Warning\" and then a notification displaying \"Warning: Got 0 warning(s)\" appears\r\n\r\nAnother solution to avoid this was to remove the condition to return \"Warning\" when 0 files were restored but this could affect things that I don't know about and the problem actually belongs to the notification, so I've decided to simply show warning notifications if and only if we actually have notifications or warnings.\r\n\r\nI don't know if this is the behavior wanted by you, just thought it would be a nice PR.","created_at":"2018-10-24T22:13:40Z","updated_at":"2018-11-08T11:47:14Z","closed_at":"2018-11-08T11:47:14Z","merged_at":"2018-11-08T11:47:14Z","merge_commit_sha":"5ad0228d5aaca7c0ffb3540009bc86d4833950b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/duplicati/duplicati/pulls/3458/commits","review_comments_url":"https://api.github.com/repos/duplicati/duplicati/pulls/3458/comments","review_comment_url":"https://api.github.com/repos/duplicati/duplicati/pulls/comments{/number}","comments_url":"https://api.github.com/repos/duplicati/duplicati/issues/3458/comments","statuses_url":"https://api.github.com/repos/duplicati/duplicati/statuses/f03e8f6c299dbe7931fac1ecc7d622c73caa01de","head":{"label":"LacunaSoftware:warning-got-0","ref":"warning-got-0","sha":"f03e8f6c299dbe7931fac1ecc7d622c73caa01de","user":{"login":"LacunaSoftware","id":14690857,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjkwODU3","avatar_url":"https://avatars1.githubusercontent.com/u/14690857?v=4","gravatar_id":"","url":"https://api.github.com/users/LacunaSoftware","html_url":"https://github.com/LacunaSoftware","followers_url":"https://api.github.com/users/LacunaSoftware/followers","following_url":"https://api.github.com/users/LacunaSoftware/following{/other_user}","gists_url":"https://api.github.com/users/LacunaSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/LacunaSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LacunaSoftware/subscriptions","organizations_url":"https://api.github.com/users/LacunaSoftware/orgs","repos_url":"https://api.github.com/users/LacunaSoftware/repos","events_url":"https://api.github.com/users/LacunaSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/LacunaSoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":147219840,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcyMTk4NDA=","name":"duplicati","full_name":"LacunaSoftware/duplicati","private":false,"owner":{"login":"LacunaSoftware","id":14690857,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjkwODU3","avatar_url":"https://avatars1.githubusercontent.com/u/14690857?v=4","gravatar_id":"","url":"https://api.github.com/users/LacunaSoftware","html_url":"https://github.com/LacunaSoftware","followers_url":"https://api.github.com/users/LacunaSoftware/followers","following_url":"https://api.github.com/users/LacunaSoftware/following{/other_user}","gists_url":"https://api.github.com/users/LacunaSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/LacunaSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LacunaSoftware/subscriptions","organizations_url":"https://api.github.com/users/LacunaSoftware/orgs","repos_url":"https://api.github.com/users/LacunaSoftware/repos","events_url":"https://api.github.com/users/LacunaSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/LacunaSoftware/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LacunaSoftware/duplicati","description":"Store securely encrypted backups in the cloud!","fork":true,"url":"https://api.github.com/repos/LacunaSoftware/duplicati","forks_url":"https://api.github.com/repos/LacunaSoftware/duplicati/forks","keys_url":"https://api.github.com/repos/LacunaSoftware/duplicati/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LacunaSoftware/duplicati/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LacunaSoftware/duplicati/teams","hooks_url":"https://api.github.com/repos/LacunaSoftware/duplicati/hooks","issue_events_url":"https://api.github.com/repos/LacunaSoftware/duplicati/issues/events{/number}","events_url":"https://api.github.com/repos/LacunaSoftware/duplicati/events","assignees_url":"https://api.github.com/repos/LacunaSoftware/duplicati/assignees{/user}","branches_url":"https://api.github.com/repos/LacunaSoftware/duplicati/branches{/branch}","tags_url":"https://api.github.com/repos/LacunaSoftware/duplicati/tags","blobs_url":"https://api.github.com/repos/LacunaSoftware/duplicati/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LacunaSoftware/duplicati/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LacunaSoftware/duplicati/git/refs{/sha}","trees_url":"https://api.github.com/repos/LacunaSoftware/duplicati/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LacunaSoftware/duplicati/statuses/{sha}","languages_url":"https://api.github.com/repos/LacunaSoftware/duplicati/languages","stargazers_url":"https://api.github.com/repos/LacunaSoftware/duplicati/stargazers","contributors_url":"https://api.github.com/repos/LacunaSoftware/duplicati/contributors","subscribers_url":"https://api.github.com/repos/LacunaSoftware/duplicati/subscribers","subscription_url":"https://api.github.com/repos/LacunaSoftware/duplicati/subscription","commits_url":"https://api.github.com/repos/LacunaSoftware/duplicati/commits{/sha}","git_commits_url":"https://api.github.com/repos/LacunaSoftware/duplicati/git/commits{/sha}","comments_url":"https://api.github.com/repos/LacunaSoftware/duplicati/comments{/number}","issue_comment_url":"https://api.github.com/repos/LacunaSoftware/duplicati/issues/comments{/number}","contents_url":"https://api.github.com/repos/LacunaSoftware/duplicati/contents/{+path}","compare_url":"https://api.github.com/repos/LacunaSoftware/duplicati/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LacunaSoftware/duplicati/merges","archive_url":"https://api.github.com/repos/LacunaSoftware/duplicati/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LacunaSoftware/duplicati/downloads","issues_url":"https://api.github.com/repos/LacunaSoftware/duplicati/issues{/number}","pulls_url":"https://api.github.com/repos/LacunaSoftware/duplicati/pulls{/number}","milestones_url":"https://api.github.com/repos/LacunaSoftware/duplicati/milestones{/number}","notifications_url":"https://api.github.com/repos/LacunaSoftware/duplicati/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LacunaSoftware/duplicati/labels{/name}","releases_url":"https://api.github.com/repos/LacunaSoftware/duplicati/releases{/id}","deployments_url":"https://api.github.com/repos/LacunaSoftware/duplicati/deployments","created_at":"2018-09-03T14:59:10Z","updated_at":"2018-11-01T11:53:10Z","pushed_at":"2018-11-08T10:51:15Z","git_url":"git://github.com/LacunaSoftware/duplicati.git","ssh_url":"git@github.com:LacunaSoftware/duplicati.git","clone_url":"https://github.com/LacunaSoftware/duplicati.git","svn_url":"https://github.com/LacunaSoftware/duplicati","homepage":"","size":91903,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"duplicati:master","ref":"master","sha":"7e80cad2a41d432be1c43df14eaf89832e57a1bc","user":{"login":"duplicati","id":8270231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNzAyMzE=","avatar_url":"https://avatars1.githubusercontent.com/u/8270231?v=4","gravatar_id":"","url":"https://api.github.com/users/duplicati","html_url":"https://github.com/duplicati","followers_url":"https://api.github.com/users/duplicati/followers","following_url":"https://api.github.com/users/duplicati/following{/other_user}","gists_url":"https://api.github.com/users/duplicati/gists{/gist_id}","starred_url":"https://api.github.com/users/duplicati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duplicati/subscriptions","organizations_url":"https://api.github.com/users/duplicati/orgs","repos_url":"https://api.github.com/users/duplicati/repos","events_url":"https://api.github.com/users/duplicati/events{/privacy}","received_events_url":"https://api.github.com/users/duplicati/received_events","type":"Organization","site_admin":false},"repo":{"id":22636263,"node_id":"MDEwOlJlcG9zaXRvcnkyMjYzNjI2Mw==","name":"duplicati","full_name":"duplicati/duplicati","private":false,"owner":{"login":"duplicati","id":8270231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNzAyMzE=","avatar_url":"https://avatars1.githubusercontent.com/u/8270231?v=4","gravatar_id":"","url":"https://api.github.com/users/duplicati","html_url":"https://github.com/duplicati","followers_url":"https://api.github.com/users/duplicati/followers","following_url":"https://api.github.com/users/duplicati/following{/other_user}","gists_url":"https://api.github.com/users/duplicati/gists{/gist_id}","starred_url":"https://api.github.com/users/duplicati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duplicati/subscriptions","organizations_url":"https://api.github.com/users/duplicati/orgs","repos_url":"https://api.github.com/users/duplicati/repos","events_url":"https://api.github.com/users/duplicati/events{/privacy}","received_events_url":"https://api.github.com/users/duplicati/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/duplicati/duplicati","description":"Store securely encrypted backups in the cloud!","fork":false,"url":"https://api.github.com/repos/duplicati/duplicati","forks_url":"https://api.github.com/repos/duplicati/duplicati/forks","keys_url":"https://api.github.com/repos/duplicati/duplicati/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duplicati/duplicati/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duplicati/duplicati/teams","hooks_url":"https://api.github.com/repos/duplicati/duplicati/hooks","issue_events_url":"https://api.github.com/repos/duplicati/duplicati/issues/events{/number}","events_url":"https://api.github.com/repos/duplicati/duplicati/events","assignees_url":"https://api.github.com/repos/duplicati/duplicati/assignees{/user}","branches_url":"https://api.github.com/repos/duplicati/duplicati/branches{/branch}","tags_url":"https://api.github.com/repos/duplicati/duplicati/tags","blobs_url":"https://api.github.com/repos/duplicati/duplicati/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duplicati/duplicati/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duplicati/duplicati/git/refs{/sha}","trees_url":"https://api.github.com/repos/duplicati/duplicati/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duplicati/duplicati/statuses/{sha}","languages_url":"https://api.github.com/repos/duplicati/duplicati/languages","stargazers_url":"https://api.github.com/repos/duplicati/duplicati/stargazers","contributors_url":"https://api.github.com/repos/duplicati/duplicati/contributors","subscribers_url":"https://api.github.com/repos/duplicati/duplicati/subscribers","subscription_url":"https://api.github.com/repos/duplicati/duplicati/subscription","commits_url":"https://api.github.com/repos/duplicati/duplicati/commits{/sha}","git_commits_url":"https://api.github.com/repos/duplicati/duplicati/git/commits{/sha}","comments_url":"https://api.github.com/repos/duplicati/duplicati/comments{/number}","issue_comment_url":"https://api.github.com/repos/duplicati/duplicati/issues/comments{/number}","contents_url":"https://api.github.com/repos/duplicati/duplicati/contents/{+path}","compare_url":"https://api.github.com/repos/duplicati/duplicati/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duplicati/duplicati/merges","archive_url":"https://api.github.com/repos/duplicati/duplicati/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duplicati/duplicati/downloads","issues_url":"https://api.github.com/repos/duplicati/duplicati/issues{/number}","pulls_url":"https://api.github.com/repos/duplicati/duplicati/pulls{/number}","milestones_url":"https://api.github.com/repos/duplicati/duplicati/milestones{/number}","notifications_url":"https://api.github.com/repos/duplicati/duplicati/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duplicati/duplicati/labels{/name}","releases_url":"https://api.github.com/repos/duplicati/duplicati/releases{/id}","deployments_url":"https://api.github.com/repos/duplicati/duplicati/deployments","created_at":"2014-08-05T08:28:16Z","updated_at":"2018-11-08T11:41:35Z","pushed_at":"2018-11-08T11:47:14Z","git_url":"git://github.com/duplicati/duplicati.git","ssh_url":"git@github.com:duplicati/duplicati.git","clone_url":"https://github.com/duplicati/duplicati.git","svn_url":"https://github.com/duplicati/duplicati","homepage":"","size":89565,"stargazers_count":3387,"watchers_count":3387,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":425,"mirror_url":null,"archived":false,"open_issues_count":775,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":425,"open_issues":775,"watchers":3387,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/duplicati/duplicati/pulls/3458"},"html":{"href":"https://github.com/duplicati/duplicati/pull/3458"},"issue":{"href":"https://api.github.com/repos/duplicati/duplicati/issues/3458"},"comments":{"href":"https://api.github.com/repos/duplicati/duplicati/issues/3458/comments"},"review_comments":{"href":"https://api.github.com/repos/duplicati/duplicati/pulls/3458/comments"},"review_comment":{"href":"https://api.github.com/repos/duplicati/duplicati/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/duplicati/duplicati/pulls/3458/commits"},"statuses":{"href":"https://api.github.com/repos/duplicati/duplicati/statuses/f03e8f6c299dbe7931fac1ecc7d622c73caa01de"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kenkendk","id":1510755,"node_id":"MDQ6VXNlcjE1MTA3NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1510755?v=4","gravatar_id":"","url":"https://api.github.com/users/kenkendk","html_url":"https://github.com/kenkendk","followers_url":"https://api.github.com/users/kenkendk/followers","following_url":"https://api.github.com/users/kenkendk/following{/other_user}","gists_url":"https://api.github.com/users/kenkendk/gists{/gist_id}","starred_url":"https://api.github.com/users/kenkendk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenkendk/subscriptions","organizations_url":"https://api.github.com/users/kenkendk/orgs","repos_url":"https://api.github.com/users/kenkendk/repos","events_url":"https://api.github.com/users/kenkendk/events{/privacy}","received_events_url":"https://api.github.com/users/kenkendk/received_events","type":"User","site_admin":false},"comments":14,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":30,"deletions":31,"changed_files":3}}
{"actor":{"display_login":"kenkendk"}}