{"action":"created","comment":{"url":"https://api.github.com/repos/internap/fake-switches/pulls/comments/169640640","pull_request_review_id":98197891,"id":169640640,"diff_hunk":"@@ -1,24 +1,16 @@\n-import unittest\n-\n-from flexmock import flexmock_teardown\n-from tests.util.global_reactor import brocade_switch_ip, \\\n-    brocade_switch_ssh_port, brocade_privileged_password\n import mock\n-from tests.util.protocol_util import SshTester, with_protocol\n-\n+from tests.util.protocol_util import SshTester, with_protocol, ProtocolTest\n \n-class TestBrocadeSwitchProtocol(unittest.TestCase):\n-    def setUp(self):\n-        self.protocol = SshTester(\"ssh\", brocade_switch_ip, brocade_switch_ssh_port, 'root', 'root')\n \n-    def tearDown(self):\n-        flexmock_teardown()\n+class TestBrocadeSwitchProtocol(ProtocolTest):\n+    teser_class = SshTester","path":"tests/brocade/test_brocade_switch_protocol.py","position":null,"original_position":18,"commit_id":"2d5bb3cc5b14505612ac61b8ca8069702548f856","original_commit_id":"8bfbd06df0800604570e1a34ce12e2f72fded93c","user":{"login":"lindycoder","id":12926519,"avatar_url":"https://avatars2.githubusercontent.com/u/12926519?v=4","gravatar_id":"","url":"https://api.github.com/users/lindycoder","html_url":"https://github.com/lindycoder","followers_url":"https://api.github.com/users/lindycoder/followers","following_url":"https://api.github.com/users/lindycoder/following{/other_user}","gists_url":"https://api.github.com/users/lindycoder/gists{/gist_id}","starred_url":"https://api.github.com/users/lindycoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindycoder/subscriptions","organizations_url":"https://api.github.com/users/lindycoder/orgs","repos_url":"https://api.github.com/users/lindycoder/repos","events_url":"https://api.github.com/users/lindycoder/events{/privacy}","received_events_url":"https://api.github.com/users/lindycoder/received_events","type":"User","site_admin":false},"body":"👍 \r\n","created_at":"2018-02-21T13:49:05Z","updated_at":"2018-02-21T13:49:05Z","html_url":"https://github.com/internap/fake-switches/pull/114#discussion_r169640640","pull_request_url":"https://api.github.com/repos/internap/fake-switches/pulls/114","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/internap/fake-switches/pulls/comments/169640640"},"html":{"href":"https://github.com/internap/fake-switches/pull/114#discussion_r169640640"},"pull_request":{"href":"https://api.github.com/repos/internap/fake-switches/pulls/114"}},"in_reply_to_id":169624774},"pull_request":{"url":"https://api.github.com/repos/internap/fake-switches/pulls/114","id":170330047,"html_url":"https://github.com/internap/fake-switches/pull/114","diff_url":"https://github.com/internap/fake-switches/pull/114.diff","patch_url":"https://github.com/internap/fake-switches/pull/114.patch","issue_url":"https://api.github.com/repos/internap/fake-switches/issues/114","number":114,"state":"open","locked":false,"title":"Refactor the global reactor","user":{"login":"lindycoder","id":12926519,"avatar_url":"https://avatars2.githubusercontent.com/u/12926519?v=4","gravatar_id":"","url":"https://api.github.com/users/lindycoder","html_url":"https://github.com/lindycoder","followers_url":"https://api.github.com/users/lindycoder/followers","following_url":"https://api.github.com/users/lindycoder/following{/other_user}","gists_url":"https://api.github.com/users/lindycoder/gists{/gist_id}","starred_url":"https://api.github.com/users/lindycoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindycoder/subscriptions","organizations_url":"https://api.github.com/users/lindycoder/orgs","repos_url":"https://api.github.com/users/lindycoder/repos","events_url":"https://api.github.com/users/lindycoder/events{/privacy}","received_events_url":"https://api.github.com/users/lindycoder/received_events","type":"User","site_admin":false},"body":"It's about time this thing gets a little sexier.\r\n\r\nThe test switches are now in a normalized structure, less clunky than\r\ninstantiating all the stuff, and they use the global mapping so that no\r\nmore switch is forgotten in that list.\r\n\r\nAll the tests using the test switches now have a member defining which\r\nswitch it's using and the base test classes can create the right clients\r\naccording to the configuration. This allowed the introduction of random\r\nport numbers.\r\n\r\nTo achieve this, a contract change was required:\r\n- The juniper switches don't create their own ports anymore, it will be\r\nthe user's responsibility for this, this is a contract change that will\r\ntrigger a major version update","created_at":"2018-02-20T22:43:44Z","updated_at":"2018-02-21T13:49:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88a14875f9c14fb20e44ee309bcb405dcd01610b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/internap/fake-switches/pulls/114/commits","review_comments_url":"https://api.github.com/repos/internap/fake-switches/pulls/114/comments","review_comment_url":"https://api.github.com/repos/internap/fake-switches/pulls/comments{/number}","comments_url":"https://api.github.com/repos/internap/fake-switches/issues/114/comments","statuses_url":"https://api.github.com/repos/internap/fake-switches/statuses/2d5bb3cc5b14505612ac61b8ca8069702548f856","head":{"label":"lindycoder:refactor_tests","ref":"refactor_tests","sha":"2d5bb3cc5b14505612ac61b8ca8069702548f856","user":{"login":"lindycoder","id":12926519,"avatar_url":"https://avatars2.githubusercontent.com/u/12926519?v=4","gravatar_id":"","url":"https://api.github.com/users/lindycoder","html_url":"https://github.com/lindycoder","followers_url":"https://api.github.com/users/lindycoder/followers","following_url":"https://api.github.com/users/lindycoder/following{/other_user}","gists_url":"https://api.github.com/users/lindycoder/gists{/gist_id}","starred_url":"https://api.github.com/users/lindycoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindycoder/subscriptions","organizations_url":"https://api.github.com/users/lindycoder/orgs","repos_url":"https://api.github.com/users/lindycoder/repos","events_url":"https://api.github.com/users/lindycoder/events{/privacy}","received_events_url":"https://api.github.com/users/lindycoder/received_events","type":"User","site_admin":false},"repo":{"id":43026411,"name":"fake-switches","full_name":"lindycoder/fake-switches","owner":{"login":"lindycoder","id":12926519,"avatar_url":"https://avatars2.githubusercontent.com/u/12926519?v=4","gravatar_id":"","url":"https://api.github.com/users/lindycoder","html_url":"https://github.com/lindycoder","followers_url":"https://api.github.com/users/lindycoder/followers","following_url":"https://api.github.com/users/lindycoder/following{/other_user}","gists_url":"https://api.github.com/users/lindycoder/gists{/gist_id}","starred_url":"https://api.github.com/users/lindycoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindycoder/subscriptions","organizations_url":"https://api.github.com/users/lindycoder/orgs","repos_url":"https://api.github.com/users/lindycoder/repos","events_url":"https://api.github.com/users/lindycoder/events{/privacy}","received_events_url":"https://api.github.com/users/lindycoder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lindycoder/fake-switches","description":"A pluggable switch/router command-line simulator","fork":true,"url":"https://api.github.com/repos/lindycoder/fake-switches","forks_url":"https://api.github.com/repos/lindycoder/fake-switches/forks","keys_url":"https://api.github.com/repos/lindycoder/fake-switches/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lindycoder/fake-switches/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lindycoder/fake-switches/teams","hooks_url":"https://api.github.com/repos/lindycoder/fake-switches/hooks","issue_events_url":"https://api.github.com/repos/lindycoder/fake-switches/issues/events{/number}","events_url":"https://api.github.com/repos/lindycoder/fake-switches/events","assignees_url":"https://api.github.com/repos/lindycoder/fake-switches/assignees{/user}","branches_url":"https://api.github.com/repos/lindycoder/fake-switches/branches{/branch}","tags_url":"https://api.github.com/repos/lindycoder/fake-switches/tags","blobs_url":"https://api.github.com/repos/lindycoder/fake-switches/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lindycoder/fake-switches/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lindycoder/fake-switches/git/refs{/sha}","trees_url":"https://api.github.com/repos/lindycoder/fake-switches/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lindycoder/fake-switches/statuses/{sha}","languages_url":"https://api.github.com/repos/lindycoder/fake-switches/languages","stargazers_url":"https://api.github.com/repos/lindycoder/fake-switches/stargazers","contributors_url":"https://api.github.com/repos/lindycoder/fake-switches/contributors","subscribers_url":"https://api.github.com/repos/lindycoder/fake-switches/subscribers","subscription_url":"https://api.github.com/repos/lindycoder/fake-switches/subscription","commits_url":"https://api.github.com/repos/lindycoder/fake-switches/commits{/sha}","git_commits_url":"https://api.github.com/repos/lindycoder/fake-switches/git/commits{/sha}","comments_url":"https://api.github.com/repos/lindycoder/fake-switches/comments{/number}","issue_comment_url":"https://api.github.com/repos/lindycoder/fake-switches/issues/comments{/number}","contents_url":"https://api.github.com/repos/lindycoder/fake-switches/contents/{+path}","compare_url":"https://api.github.com/repos/lindycoder/fake-switches/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lindycoder/fake-switches/merges","archive_url":"https://api.github.com/repos/lindycoder/fake-switches/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lindycoder/fake-switches/downloads","issues_url":"https://api.github.com/repos/lindycoder/fake-switches/issues{/number}","pulls_url":"https://api.github.com/repos/lindycoder/fake-switches/pulls{/number}","milestones_url":"https://api.github.com/repos/lindycoder/fake-switches/milestones{/number}","notifications_url":"https://api.github.com/repos/lindycoder/fake-switches/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lindycoder/fake-switches/labels{/name}","releases_url":"https://api.github.com/repos/lindycoder/fake-switches/releases{/id}","deployments_url":"https://api.github.com/repos/lindycoder/fake-switches/deployments","created_at":"2015-09-23T20:56:07Z","updated_at":"2016-02-03T18:51:31Z","pushed_at":"2018-02-21T13:48:42Z","git_url":"git://github.com/lindycoder/fake-switches.git","ssh_url":"git@github.com:lindycoder/fake-switches.git","clone_url":"https://github.com/lindycoder/fake-switches.git","svn_url":"https://github.com/lindycoder/fake-switches","homepage":null,"size":669,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"internap:master","ref":"master","sha":"f482970b10630b046a7f3c654493b0743b99ff26","user":{"login":"internap","id":13888621,"avatar_url":"https://avatars2.githubusercontent.com/u/13888621?v=4","gravatar_id":"","url":"https://api.github.com/users/internap","html_url":"https://github.com/internap","followers_url":"https://api.github.com/users/internap/followers","following_url":"https://api.github.com/users/internap/following{/other_user}","gists_url":"https://api.github.com/users/internap/gists{/gist_id}","starred_url":"https://api.github.com/users/internap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/internap/subscriptions","organizations_url":"https://api.github.com/users/internap/orgs","repos_url":"https://api.github.com/users/internap/repos","events_url":"https://api.github.com/users/internap/events{/privacy}","received_events_url":"https://api.github.com/users/internap/received_events","type":"Organization","site_admin":false},"repo":{"id":41325076,"name":"fake-switches","full_name":"internap/fake-switches","owner":{"login":"internap","id":13888621,"avatar_url":"https://avatars2.githubusercontent.com/u/13888621?v=4","gravatar_id":"","url":"https://api.github.com/users/internap","html_url":"https://github.com/internap","followers_url":"https://api.github.com/users/internap/followers","following_url":"https://api.github.com/users/internap/following{/other_user}","gists_url":"https://api.github.com/users/internap/gists{/gist_id}","starred_url":"https://api.github.com/users/internap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/internap/subscriptions","organizations_url":"https://api.github.com/users/internap/orgs","repos_url":"https://api.github.com/users/internap/repos","events_url":"https://api.github.com/users/internap/events{/privacy}","received_events_url":"https://api.github.com/users/internap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/internap/fake-switches","description":"A pluggable switch/router command-line simulator","fork":false,"url":"https://api.github.com/repos/internap/fake-switches","forks_url":"https://api.github.com/repos/internap/fake-switches/forks","keys_url":"https://api.github.com/repos/internap/fake-switches/keys{/key_id}","collaborators_url":"https://api.github.com/repos/internap/fake-switches/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/internap/fake-switches/teams","hooks_url":"https://api.github.com/repos/internap/fake-switches/hooks","issue_events_url":"https://api.github.com/repos/internap/fake-switches/issues/events{/number}","events_url":"https://api.github.com/repos/internap/fake-switches/events","assignees_url":"https://api.github.com/repos/internap/fake-switches/assignees{/user}","branches_url":"https://api.github.com/repos/internap/fake-switches/branches{/branch}","tags_url":"https://api.github.com/repos/internap/fake-switches/tags","blobs_url":"https://api.github.com/repos/internap/fake-switches/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/internap/fake-switches/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/internap/fake-switches/git/refs{/sha}","trees_url":"https://api.github.com/repos/internap/fake-switches/git/trees{/sha}","statuses_url":"https://api.github.com/repos/internap/fake-switches/statuses/{sha}","languages_url":"https://api.github.com/repos/internap/fake-switches/languages","stargazers_url":"https://api.github.com/repos/internap/fake-switches/stargazers","contributors_url":"https://api.github.com/repos/internap/fake-switches/contributors","subscribers_url":"https://api.github.com/repos/internap/fake-switches/subscribers","subscription_url":"https://api.github.com/repos/internap/fake-switches/subscription","commits_url":"https://api.github.com/repos/internap/fake-switches/commits{/sha}","git_commits_url":"https://api.github.com/repos/internap/fake-switches/git/commits{/sha}","comments_url":"https://api.github.com/repos/internap/fake-switches/comments{/number}","issue_comment_url":"https://api.github.com/repos/internap/fake-switches/issues/comments{/number}","contents_url":"https://api.github.com/repos/internap/fake-switches/contents/{+path}","compare_url":"https://api.github.com/repos/internap/fake-switches/compare/{base}...{head}","merges_url":"https://api.github.com/repos/internap/fake-switches/merges","archive_url":"https://api.github.com/repos/internap/fake-switches/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/internap/fake-switches/downloads","issues_url":"https://api.github.com/repos/internap/fake-switches/issues{/number}","pulls_url":"https://api.github.com/repos/internap/fake-switches/pulls{/number}","milestones_url":"https://api.github.com/repos/internap/fake-switches/milestones{/number}","notifications_url":"https://api.github.com/repos/internap/fake-switches/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/internap/fake-switches/labels{/name}","releases_url":"https://api.github.com/repos/internap/fake-switches/releases{/id}","deployments_url":"https://api.github.com/repos/internap/fake-switches/deployments","created_at":"2015-08-24T20:19:57Z","updated_at":"2018-02-15T08:19:32Z","pushed_at":"2018-02-21T13:48:44Z","git_url":"git://github.com/internap/fake-switches.git","ssh_url":"git@github.com:internap/fake-switches.git","clone_url":"https://github.com/internap/fake-switches.git","svn_url":"https://github.com/internap/fake-switches","homepage":null,"size":646,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":15,"open_issues":3,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/internap/fake-switches/pulls/114"},"html":{"href":"https://github.com/internap/fake-switches/pull/114"},"issue":{"href":"https://api.github.com/repos/internap/fake-switches/issues/114"},"comments":{"href":"https://api.github.com/repos/internap/fake-switches/issues/114/comments"},"review_comments":{"href":"https://api.github.com/repos/internap/fake-switches/pulls/114/comments"},"review_comment":{"href":"https://api.github.com/repos/internap/fake-switches/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/internap/fake-switches/pulls/114/commits"},"statuses":{"href":"https://api.github.com/repos/internap/fake-switches/statuses/2d5bb3cc5b14505612ac61b8ca8069702548f856"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lindycoder"}}