{"action":"closed","number":421,"pull_request":{"url":"https://api.github.com/repos/Opentrons/opentrons/pulls/421","id":152168877,"html_url":"https://github.com/Opentrons/opentrons/pull/421","diff_url":"https://github.com/Opentrons/opentrons/pull/421.diff","patch_url":"https://github.com/Opentrons/opentrons/pull/421.patch","issue_url":"https://api.github.com/repos/Opentrons/opentrons/issues/421","number":421,"state":"closed","locked":false,"title":"Verify constraints for the execution plan by comparing max volume aga…","user":{"login":"zubrabubra","id":14136449,"avatar_url":"https://avatars1.githubusercontent.com/u/14136449?v=4","gravatar_id":"","url":"https://api.github.com/users/zubrabubra","html_url":"https://github.com/zubrabubra","followers_url":"https://api.github.com/users/zubrabubra/followers","following_url":"https://api.github.com/users/zubrabubra/following{/other_user}","gists_url":"https://api.github.com/users/zubrabubra/gists{/gist_id}","starred_url":"https://api.github.com/users/zubrabubra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zubrabubra/subscriptions","organizations_url":"https://api.github.com/users/zubrabubra/orgs","repos_url":"https://api.github.com/users/zubrabubra/repos","events_url":"https://api.github.com/users/zubrabubra/events{/privacy}","received_events_url":"https://api.github.com/users/zubrabubra/received_events","type":"User","site_admin":false},"body":"…inst air gap. Constraints are feasible if and only if amount of the transferable liquid volume is bigger than zero.\r\n\r\n## overview\r\n\r\nWrite a high level description of the pull request.\r\n\r\nThis PR includes:\r\n\r\n- [ ] Chore work\r\n- [X] Bug fixes\r\n- [ ] Backwards-compatible feature additions\r\n- [ ] Breaking changes\r\n- [ ] Documentation updates\r\n- [X] Test updates\r\n\r\n## changelog\r\n\r\nFix to the problem i found while debugging github issue https://github.com/Opentrons/opentrons/issues/364, i was not able to reproduce the one mentioned, though it's possible to get into infinite loop when air gap is bigger or equal to the amount of the volume in pipette.\r\n\r\nThe one thing is not clear whether we want to have such scenarios or not. There might be a case for gas transferring when we would like to have a pipette to be full of the air. That case should require a bit more changes.\r\n\r\n## review requests\r\n\r\nDescribe any specific requests for your reviewers here. Tag any people or groups as necessary.\r\n","created_at":"2017-11-13T07:27:05Z","updated_at":"2018-04-11T19:34:34Z","closed_at":"2018-04-11T19:34:34Z","merged_at":null,"merge_commit_sha":"f8a3c9b28bdcf7e753a26079b3efa9395f12b36d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"btmorr","id":5034659,"avatar_url":"https://avatars2.githubusercontent.com/u/5034659?v=4","gravatar_id":"","url":"https://api.github.com/users/btmorr","html_url":"https://github.com/btmorr","followers_url":"https://api.github.com/users/btmorr/followers","following_url":"https://api.github.com/users/btmorr/following{/other_user}","gists_url":"https://api.github.com/users/btmorr/gists{/gist_id}","starred_url":"https://api.github.com/users/btmorr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btmorr/subscriptions","organizations_url":"https://api.github.com/users/btmorr/orgs","repos_url":"https://api.github.com/users/btmorr/repos","events_url":"https://api.github.com/users/btmorr/events{/privacy}","received_events_url":"https://api.github.com/users/btmorr/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":749345056,"url":"https://api.github.com/repos/Opentrons/opentrons/labels/WIP","name":"WIP","color":"bc0903","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/421/commits","review_comments_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/421/comments","review_comment_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/issues/421/comments","statuses_url":"https://api.github.com/repos/Opentrons/opentrons/statuses/6fc474e4f56ce9123e8ea69571ad22df71c2b9da","head":{"label":"zubrabubra:v3a-air_gap_max_volume_check","ref":"v3a-air_gap_max_volume_check","sha":"6fc474e4f56ce9123e8ea69571ad22df71c2b9da","user":{"login":"zubrabubra","id":14136449,"avatar_url":"https://avatars1.githubusercontent.com/u/14136449?v=4","gravatar_id":"","url":"https://api.github.com/users/zubrabubra","html_url":"https://github.com/zubrabubra","followers_url":"https://api.github.com/users/zubrabubra/followers","following_url":"https://api.github.com/users/zubrabubra/following{/other_user}","gists_url":"https://api.github.com/users/zubrabubra/gists{/gist_id}","starred_url":"https://api.github.com/users/zubrabubra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zubrabubra/subscriptions","organizations_url":"https://api.github.com/users/zubrabubra/orgs","repos_url":"https://api.github.com/users/zubrabubra/repos","events_url":"https://api.github.com/users/zubrabubra/events{/privacy}","received_events_url":"https://api.github.com/users/zubrabubra/received_events","type":"User","site_admin":false},"repo":{"id":110165972,"name":"opentrons","full_name":"zubrabubra/opentrons","owner":{"login":"zubrabubra","id":14136449,"avatar_url":"https://avatars1.githubusercontent.com/u/14136449?v=4","gravatar_id":"","url":"https://api.github.com/users/zubrabubra","html_url":"https://github.com/zubrabubra","followers_url":"https://api.github.com/users/zubrabubra/followers","following_url":"https://api.github.com/users/zubrabubra/following{/other_user}","gists_url":"https://api.github.com/users/zubrabubra/gists{/gist_id}","starred_url":"https://api.github.com/users/zubrabubra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zubrabubra/subscriptions","organizations_url":"https://api.github.com/users/zubrabubra/orgs","repos_url":"https://api.github.com/users/zubrabubra/repos","events_url":"https://api.github.com/users/zubrabubra/events{/privacy}","received_events_url":"https://api.github.com/users/zubrabubra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zubrabubra/opentrons","description":"Python API for writing protocols and running them on Opentrons robots","fork":true,"url":"https://api.github.com/repos/zubrabubra/opentrons","forks_url":"https://api.github.com/repos/zubrabubra/opentrons/forks","keys_url":"https://api.github.com/repos/zubrabubra/opentrons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zubrabubra/opentrons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zubrabubra/opentrons/teams","hooks_url":"https://api.github.com/repos/zubrabubra/opentrons/hooks","issue_events_url":"https://api.github.com/repos/zubrabubra/opentrons/issues/events{/number}","events_url":"https://api.github.com/repos/zubrabubra/opentrons/events","assignees_url":"https://api.github.com/repos/zubrabubra/opentrons/assignees{/user}","branches_url":"https://api.github.com/repos/zubrabubra/opentrons/branches{/branch}","tags_url":"https://api.github.com/repos/zubrabubra/opentrons/tags","blobs_url":"https://api.github.com/repos/zubrabubra/opentrons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zubrabubra/opentrons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zubrabubra/opentrons/git/refs{/sha}","trees_url":"https://api.github.com/repos/zubrabubra/opentrons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zubrabubra/opentrons/statuses/{sha}","languages_url":"https://api.github.com/repos/zubrabubra/opentrons/languages","stargazers_url":"https://api.github.com/repos/zubrabubra/opentrons/stargazers","contributors_url":"https://api.github.com/repos/zubrabubra/opentrons/contributors","subscribers_url":"https://api.github.com/repos/zubrabubra/opentrons/subscribers","subscription_url":"https://api.github.com/repos/zubrabubra/opentrons/subscription","commits_url":"https://api.github.com/repos/zubrabubra/opentrons/commits{/sha}","git_commits_url":"https://api.github.com/repos/zubrabubra/opentrons/git/commits{/sha}","comments_url":"https://api.github.com/repos/zubrabubra/opentrons/comments{/number}","issue_comment_url":"https://api.github.com/repos/zubrabubra/opentrons/issues/comments{/number}","contents_url":"https://api.github.com/repos/zubrabubra/opentrons/contents/{+path}","compare_url":"https://api.github.com/repos/zubrabubra/opentrons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zubrabubra/opentrons/merges","archive_url":"https://api.github.com/repos/zubrabubra/opentrons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zubrabubra/opentrons/downloads","issues_url":"https://api.github.com/repos/zubrabubra/opentrons/issues{/number}","pulls_url":"https://api.github.com/repos/zubrabubra/opentrons/pulls{/number}","milestones_url":"https://api.github.com/repos/zubrabubra/opentrons/milestones{/number}","notifications_url":"https://api.github.com/repos/zubrabubra/opentrons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zubrabubra/opentrons/labels{/name}","releases_url":"https://api.github.com/repos/zubrabubra/opentrons/releases{/id}","deployments_url":"https://api.github.com/repos/zubrabubra/opentrons/deployments","created_at":"2017-11-09T21:02:36Z","updated_at":"2017-11-09T21:02:39Z","pushed_at":"2017-11-13T20:04:55Z","git_url":"git://github.com/zubrabubra/opentrons.git","ssh_url":"git@github.com:zubrabubra/opentrons.git","clone_url":"https://github.com/zubrabubra/opentrons.git","svn_url":"https://github.com/zubrabubra/opentrons","homepage":"","size":16111,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Opentrons:v3a","ref":"v3a","sha":"ad3e14456e2d0f9cf2a27912d7e8d02d32f617b3","user":{"login":"Opentrons","id":6139147,"avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"repo":{"id":38644841,"name":"opentrons","full_name":"Opentrons/opentrons","owner":{"login":"Opentrons","id":6139147,"avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Opentrons/opentrons","description":"Software for writing protocols and running them on Opentrons robots","fork":false,"url":"https://api.github.com/repos/Opentrons/opentrons","forks_url":"https://api.github.com/repos/Opentrons/opentrons/forks","keys_url":"https://api.github.com/repos/Opentrons/opentrons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Opentrons/opentrons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Opentrons/opentrons/teams","hooks_url":"https://api.github.com/repos/Opentrons/opentrons/hooks","issue_events_url":"https://api.github.com/repos/Opentrons/opentrons/issues/events{/number}","events_url":"https://api.github.com/repos/Opentrons/opentrons/events","assignees_url":"https://api.github.com/repos/Opentrons/opentrons/assignees{/user}","branches_url":"https://api.github.com/repos/Opentrons/opentrons/branches{/branch}","tags_url":"https://api.github.com/repos/Opentrons/opentrons/tags","blobs_url":"https://api.github.com/repos/Opentrons/opentrons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Opentrons/opentrons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Opentrons/opentrons/git/refs{/sha}","trees_url":"https://api.github.com/repos/Opentrons/opentrons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Opentrons/opentrons/statuses/{sha}","languages_url":"https://api.github.com/repos/Opentrons/opentrons/languages","stargazers_url":"https://api.github.com/repos/Opentrons/opentrons/stargazers","contributors_url":"https://api.github.com/repos/Opentrons/opentrons/contributors","subscribers_url":"https://api.github.com/repos/Opentrons/opentrons/subscribers","subscription_url":"https://api.github.com/repos/Opentrons/opentrons/subscription","commits_url":"https://api.github.com/repos/Opentrons/opentrons/commits{/sha}","git_commits_url":"https://api.github.com/repos/Opentrons/opentrons/git/commits{/sha}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/comments{/number}","issue_comment_url":"https://api.github.com/repos/Opentrons/opentrons/issues/comments{/number}","contents_url":"https://api.github.com/repos/Opentrons/opentrons/contents/{+path}","compare_url":"https://api.github.com/repos/Opentrons/opentrons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Opentrons/opentrons/merges","archive_url":"https://api.github.com/repos/Opentrons/opentrons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Opentrons/opentrons/downloads","issues_url":"https://api.github.com/repos/Opentrons/opentrons/issues{/number}","pulls_url":"https://api.github.com/repos/Opentrons/opentrons/pulls{/number}","milestones_url":"https://api.github.com/repos/Opentrons/opentrons/milestones{/number}","notifications_url":"https://api.github.com/repos/Opentrons/opentrons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Opentrons/opentrons/labels{/name}","releases_url":"https://api.github.com/repos/Opentrons/opentrons/releases{/id}","deployments_url":"https://api.github.com/repos/Opentrons/opentrons/deployments","created_at":"2015-07-06T20:41:01Z","updated_at":"2018-04-11T17:15:30Z","pushed_at":"2018-04-11T19:33:47Z","git_url":"git://github.com/Opentrons/opentrons.git","ssh_url":"git@github.com:Opentrons/opentrons.git","clone_url":"https://github.com/Opentrons/opentrons.git","svn_url":"https://github.com/Opentrons/opentrons","homepage":"","size":25907,"stargazers_count":48,"watchers_count":48,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":193,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":33,"open_issues":193,"watchers":48,"default_branch":"edge"}},"_links":{"self":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/421"},"html":{"href":"https://github.com/Opentrons/opentrons/pull/421"},"issue":{"href":"https://api.github.com/repos/Opentrons/opentrons/issues/421"},"comments":{"href":"https://api.github.com/repos/Opentrons/opentrons/issues/421/comments"},"review_comments":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/421/comments"},"review_comment":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/421/commits"},"statuses":{"href":"https://api.github.com/repos/Opentrons/opentrons/statuses/6fc474e4f56ce9123e8ea69571ad22df71c2b9da"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":21,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"Kadee80"}}