{"action":"created","comment":{"url":"https://api.github.com/repos/alsatian-test/alsatian/pulls/comments/203681550","pull_request_review_id":138616966,"id":203681550,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzY4MTU1MA==","diff_hunk":"@@ -105,6 +110,20 @@ export class Matcher<T> {\n     }\n   }\n \n+  private _checkBuffersAreEqual(_bufferA: any, _bufferB: any): boolean {\n+    try {\n+      const bufferA = Buffer.from(_bufferA);","path":"core/matchers/matcher.ts","position":null,"original_position":18,"commit_id":"942772106f44bbd52ea374c8547d558480e93a7f","original_commit_id":"23d14226c1c12192104411b3c5b96af23db2ea11","user":{"login":"pathurs","id":3084995,"node_id":"MDQ6VXNlcjMwODQ5OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3084995?v=4","gravatar_id":"","url":"https://api.github.com/users/pathurs","html_url":"https://github.com/pathurs","followers_url":"https://api.github.com/users/pathurs/followers","following_url":"https://api.github.com/users/pathurs/following{/other_user}","gists_url":"https://api.github.com/users/pathurs/gists{/gist_id}","starred_url":"https://api.github.com/users/pathurs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pathurs/subscriptions","organizations_url":"https://api.github.com/users/pathurs/orgs","repos_url":"https://api.github.com/users/pathurs/repos","events_url":"https://api.github.com/users/pathurs/events{/privacy}","received_events_url":"https://api.github.com/users/pathurs/received_events","type":"User","site_admin":false},"body":"Updated as above.","created_at":"2018-07-19T10:45:42Z","updated_at":"2018-07-19T10:45:42Z","html_url":"https://github.com/alsatian-test/alsatian/pull/472#discussion_r203681550","pull_request_url":"https://api.github.com/repos/alsatian-test/alsatian/pulls/472","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/alsatian-test/alsatian/pulls/comments/203681550"},"html":{"href":"https://github.com/alsatian-test/alsatian/pull/472#discussion_r203681550"},"pull_request":{"href":"https://api.github.com/repos/alsatian-test/alsatian/pulls/472"}},"in_reply_to_id":203675025},"pull_request":{"url":"https://api.github.com/repos/alsatian-test/alsatian/pulls/472","id":202508025,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNTA4MDI1","html_url":"https://github.com/alsatian-test/alsatian/pull/472","diff_url":"https://github.com/alsatian-test/alsatian/pull/472.diff","patch_url":"https://github.com/alsatian-test/alsatian/pull/472.patch","issue_url":"https://api.github.com/repos/alsatian-test/alsatian/issues/472","number":472,"state":"open","locked":false,"title":"Allow toEqual() to check Buffers for equality","user":{"login":"pathurs","id":3084995,"node_id":"MDQ6VXNlcjMwODQ5OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3084995?v=4","gravatar_id":"","url":"https://api.github.com/users/pathurs","html_url":"https://github.com/pathurs","followers_url":"https://api.github.com/users/pathurs/followers","following_url":"https://api.github.com/users/pathurs/following{/other_user}","gists_url":"https://api.github.com/users/pathurs/gists{/gist_id}","starred_url":"https://api.github.com/users/pathurs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pathurs/subscriptions","organizations_url":"https://api.github.com/users/pathurs/orgs","repos_url":"https://api.github.com/users/pathurs/repos","events_url":"https://api.github.com/users/pathurs/events{/privacy}","received_events_url":"https://api.github.com/users/pathurs/received_events","type":"User","site_admin":false},"body":"<!-- Hey, there! Thanks for contributing to Alsatian,\r\n      Add a quick description of the changes you have made below -->\r\n\r\n# Description\r\n\r\nIf either `expectedValue` or `actualValue` are of type `Buffer`, they will be converted to a new `Buffer`, and compared using `Buffer.equals(Buffer)`.\r\n\r\nFixes #465\r\n\r\n<!-- Now, we've created a handy checklist before submitting your pull request to ensure it goes smoothly\r\n      (we checked the first one for you because we know it's true) -->\r\n\r\n# Checklist\r\n\r\n- [x] I am an awesome developer and proud of my code\r\n- [x] I added / updated / removed relevant unit or integration tests to prove my change works\r\n- [x] I ran all tests using ```npm test``` to make sure everything else still works\r\n- [x] I ran ```npm run review``` to ensure the code adheres to the repository standards\r\n\r\n<!-- Thanks again, and if you'd like to add any further information you can do so below -->\r\n\r\n# Additional Information\r\n","created_at":"2018-07-19T10:04:18Z","updated_at":"2018-07-19T10:45:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad7f365097fefefd6632c56df70c0d53399d696b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alsatian-test/alsatian/pulls/472/commits","review_comments_url":"https://api.github.com/repos/alsatian-test/alsatian/pulls/472/comments","review_comment_url":"https://api.github.com/repos/alsatian-test/alsatian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alsatian-test/alsatian/issues/472/comments","statuses_url":"https://api.github.com/repos/alsatian-test/alsatian/statuses/942772106f44bbd52ea374c8547d558480e93a7f","head":{"label":"pathurs:toEqual-matches-buffer","ref":"toEqual-matches-buffer","sha":"942772106f44bbd52ea374c8547d558480e93a7f","user":{"login":"pathurs","id":3084995,"node_id":"MDQ6VXNlcjMwODQ5OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3084995?v=4","gravatar_id":"","url":"https://api.github.com/users/pathurs","html_url":"https://github.com/pathurs","followers_url":"https://api.github.com/users/pathurs/followers","following_url":"https://api.github.com/users/pathurs/following{/other_user}","gists_url":"https://api.github.com/users/pathurs/gists{/gist_id}","starred_url":"https://api.github.com/users/pathurs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pathurs/subscriptions","organizations_url":"https://api.github.com/users/pathurs/orgs","repos_url":"https://api.github.com/users/pathurs/repos","events_url":"https://api.github.com/users/pathurs/events{/privacy}","received_events_url":"https://api.github.com/users/pathurs/received_events","type":"User","site_admin":false},"repo":{"id":141274160,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEyNzQxNjA=","name":"alsatian","full_name":"pathurs/alsatian","owner":{"login":"pathurs","id":3084995,"node_id":"MDQ6VXNlcjMwODQ5OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3084995?v=4","gravatar_id":"","url":"https://api.github.com/users/pathurs","html_url":"https://github.com/pathurs","followers_url":"https://api.github.com/users/pathurs/followers","following_url":"https://api.github.com/users/pathurs/following{/other_user}","gists_url":"https://api.github.com/users/pathurs/gists{/gist_id}","starred_url":"https://api.github.com/users/pathurs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pathurs/subscriptions","organizations_url":"https://api.github.com/users/pathurs/orgs","repos_url":"https://api.github.com/users/pathurs/repos","events_url":"https://api.github.com/users/pathurs/events{/privacy}","received_events_url":"https://api.github.com/users/pathurs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pathurs/alsatian","description":"TypeScript testing framework with test cases","fork":true,"url":"https://api.github.com/repos/pathurs/alsatian","forks_url":"https://api.github.com/repos/pathurs/alsatian/forks","keys_url":"https://api.github.com/repos/pathurs/alsatian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pathurs/alsatian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pathurs/alsatian/teams","hooks_url":"https://api.github.com/repos/pathurs/alsatian/hooks","issue_events_url":"https://api.github.com/repos/pathurs/alsatian/issues/events{/number}","events_url":"https://api.github.com/repos/pathurs/alsatian/events","assignees_url":"https://api.github.com/repos/pathurs/alsatian/assignees{/user}","branches_url":"https://api.github.com/repos/pathurs/alsatian/branches{/branch}","tags_url":"https://api.github.com/repos/pathurs/alsatian/tags","blobs_url":"https://api.github.com/repos/pathurs/alsatian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pathurs/alsatian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pathurs/alsatian/git/refs{/sha}","trees_url":"https://api.github.com/repos/pathurs/alsatian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pathurs/alsatian/statuses/{sha}","languages_url":"https://api.github.com/repos/pathurs/alsatian/languages","stargazers_url":"https://api.github.com/repos/pathurs/alsatian/stargazers","contributors_url":"https://api.github.com/repos/pathurs/alsatian/contributors","subscribers_url":"https://api.github.com/repos/pathurs/alsatian/subscribers","subscription_url":"https://api.github.com/repos/pathurs/alsatian/subscription","commits_url":"https://api.github.com/repos/pathurs/alsatian/commits{/sha}","git_commits_url":"https://api.github.com/repos/pathurs/alsatian/git/commits{/sha}","comments_url":"https://api.github.com/repos/pathurs/alsatian/comments{/number}","issue_comment_url":"https://api.github.com/repos/pathurs/alsatian/issues/comments{/number}","contents_url":"https://api.github.com/repos/pathurs/alsatian/contents/{+path}","compare_url":"https://api.github.com/repos/pathurs/alsatian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pathurs/alsatian/merges","archive_url":"https://api.github.com/repos/pathurs/alsatian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pathurs/alsatian/downloads","issues_url":"https://api.github.com/repos/pathurs/alsatian/issues{/number}","pulls_url":"https://api.github.com/repos/pathurs/alsatian/pulls{/number}","milestones_url":"https://api.github.com/repos/pathurs/alsatian/milestones{/number}","notifications_url":"https://api.github.com/repos/pathurs/alsatian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pathurs/alsatian/labels{/name}","releases_url":"https://api.github.com/repos/pathurs/alsatian/releases{/id}","deployments_url":"https://api.github.com/repos/pathurs/alsatian/deployments","created_at":"2018-07-17T10:33:48Z","updated_at":"2018-07-17T11:36:59Z","pushed_at":"2018-07-19T10:44:19Z","git_url":"git://github.com/pathurs/alsatian.git","ssh_url":"git@github.com:pathurs/alsatian.git","clone_url":"https://github.com/pathurs/alsatian.git","svn_url":"https://github.com/pathurs/alsatian","homepage":null,"size":1908,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alsatian-test:master","ref":"master","sha":"f9d7970ea5fd47ef81f64a4b5cab0e0ed7feb7da","user":{"login":"alsatian-test","id":20105577,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTA1NTc3","avatar_url":"https://avatars2.githubusercontent.com/u/20105577?v=4","gravatar_id":"","url":"https://api.github.com/users/alsatian-test","html_url":"https://github.com/alsatian-test","followers_url":"https://api.github.com/users/alsatian-test/followers","following_url":"https://api.github.com/users/alsatian-test/following{/other_user}","gists_url":"https://api.github.com/users/alsatian-test/gists{/gist_id}","starred_url":"https://api.github.com/users/alsatian-test/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alsatian-test/subscriptions","organizations_url":"https://api.github.com/users/alsatian-test/orgs","repos_url":"https://api.github.com/users/alsatian-test/repos","events_url":"https://api.github.com/users/alsatian-test/events{/privacy}","received_events_url":"https://api.github.com/users/alsatian-test/received_events","type":"Organization","site_admin":false},"repo":{"id":60793910,"node_id":"MDEwOlJlcG9zaXRvcnk2MDc5MzkxMA==","name":"alsatian","full_name":"alsatian-test/alsatian","owner":{"login":"alsatian-test","id":20105577,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTA1NTc3","avatar_url":"https://avatars2.githubusercontent.com/u/20105577?v=4","gravatar_id":"","url":"https://api.github.com/users/alsatian-test","html_url":"https://github.com/alsatian-test","followers_url":"https://api.github.com/users/alsatian-test/followers","following_url":"https://api.github.com/users/alsatian-test/following{/other_user}","gists_url":"https://api.github.com/users/alsatian-test/gists{/gist_id}","starred_url":"https://api.github.com/users/alsatian-test/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alsatian-test/subscriptions","organizations_url":"https://api.github.com/users/alsatian-test/orgs","repos_url":"https://api.github.com/users/alsatian-test/repos","events_url":"https://api.github.com/users/alsatian-test/events{/privacy}","received_events_url":"https://api.github.com/users/alsatian-test/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alsatian-test/alsatian","description":"TypeScript testing framework with test cases","fork":false,"url":"https://api.github.com/repos/alsatian-test/alsatian","forks_url":"https://api.github.com/repos/alsatian-test/alsatian/forks","keys_url":"https://api.github.com/repos/alsatian-test/alsatian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alsatian-test/alsatian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alsatian-test/alsatian/teams","hooks_url":"https://api.github.com/repos/alsatian-test/alsatian/hooks","issue_events_url":"https://api.github.com/repos/alsatian-test/alsatian/issues/events{/number}","events_url":"https://api.github.com/repos/alsatian-test/alsatian/events","assignees_url":"https://api.github.com/repos/alsatian-test/alsatian/assignees{/user}","branches_url":"https://api.github.com/repos/alsatian-test/alsatian/branches{/branch}","tags_url":"https://api.github.com/repos/alsatian-test/alsatian/tags","blobs_url":"https://api.github.com/repos/alsatian-test/alsatian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alsatian-test/alsatian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alsatian-test/alsatian/git/refs{/sha}","trees_url":"https://api.github.com/repos/alsatian-test/alsatian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alsatian-test/alsatian/statuses/{sha}","languages_url":"https://api.github.com/repos/alsatian-test/alsatian/languages","stargazers_url":"https://api.github.com/repos/alsatian-test/alsatian/stargazers","contributors_url":"https://api.github.com/repos/alsatian-test/alsatian/contributors","subscribers_url":"https://api.github.com/repos/alsatian-test/alsatian/subscribers","subscription_url":"https://api.github.com/repos/alsatian-test/alsatian/subscription","commits_url":"https://api.github.com/repos/alsatian-test/alsatian/commits{/sha}","git_commits_url":"https://api.github.com/repos/alsatian-test/alsatian/git/commits{/sha}","comments_url":"https://api.github.com/repos/alsatian-test/alsatian/comments{/number}","issue_comment_url":"https://api.github.com/repos/alsatian-test/alsatian/issues/comments{/number}","contents_url":"https://api.github.com/repos/alsatian-test/alsatian/contents/{+path}","compare_url":"https://api.github.com/repos/alsatian-test/alsatian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alsatian-test/alsatian/merges","archive_url":"https://api.github.com/repos/alsatian-test/alsatian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alsatian-test/alsatian/downloads","issues_url":"https://api.github.com/repos/alsatian-test/alsatian/issues{/number}","pulls_url":"https://api.github.com/repos/alsatian-test/alsatian/pulls{/number}","milestones_url":"https://api.github.com/repos/alsatian-test/alsatian/milestones{/number}","notifications_url":"https://api.github.com/repos/alsatian-test/alsatian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alsatian-test/alsatian/labels{/name}","releases_url":"https://api.github.com/repos/alsatian-test/alsatian/releases{/id}","deployments_url":"https://api.github.com/repos/alsatian-test/alsatian/deployments","created_at":"2016-06-09T17:33:57Z","updated_at":"2018-07-08T00:06:24Z","pushed_at":"2018-07-19T10:44:20Z","git_url":"git://github.com/alsatian-test/alsatian.git","ssh_url":"git@github.com:alsatian-test/alsatian.git","clone_url":"https://github.com/alsatian-test/alsatian.git","svn_url":"https://github.com/alsatian-test/alsatian","homepage":null,"size":1975,"stargazers_count":114,"watchers_count":114,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":16,"open_issues":82,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alsatian-test/alsatian/pulls/472"},"html":{"href":"https://github.com/alsatian-test/alsatian/pull/472"},"issue":{"href":"https://api.github.com/repos/alsatian-test/alsatian/issues/472"},"comments":{"href":"https://api.github.com/repos/alsatian-test/alsatian/issues/472/comments"},"review_comments":{"href":"https://api.github.com/repos/alsatian-test/alsatian/pulls/472/comments"},"review_comment":{"href":"https://api.github.com/repos/alsatian-test/alsatian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alsatian-test/alsatian/pulls/472/commits"},"statuses":{"href":"https://api.github.com/repos/alsatian-test/alsatian/statuses/942772106f44bbd52ea374c8547d558480e93a7f"}},"author_association":"NONE"}}
{"actor":{"display_login":"pathurs"}}