{"action":"closed","issue":{"url":"https://api.github.com/repos/japaric/embedded-hal/issues/88","repository_url":"https://api.github.com/repos/japaric/embedded-hal","labels_url":"https://api.github.com/repos/japaric/embedded-hal/issues/88/labels{/name}","comments_url":"https://api.github.com/repos/japaric/embedded-hal/issues/88/comments","events_url":"https://api.github.com/repos/japaric/embedded-hal/issues/88/events","html_url":"https://github.com/japaric/embedded-hal/issues/88","id":334950185,"node_id":"MDU6SXNzdWUzMzQ5NTAxODU=","number":88,"title":"i2c: address format","user":{"login":"chrysn","id":442326,"node_id":"MDQ6VXNlcjQ0MjMyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/442326?v=4","gravatar_id":"","url":"https://api.github.com/users/chrysn","html_url":"https://github.com/chrysn","followers_url":"https://api.github.com/users/chrysn/followers","following_url":"https://api.github.com/users/chrysn/following{/other_user}","gists_url":"https://api.github.com/users/chrysn/gists{/gist_id}","starred_url":"https://api.github.com/users/chrysn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrysn/subscriptions","organizations_url":"https://api.github.com/users/chrysn/orgs","repos_url":"https://api.github.com/users/chrysn/repos","events_url":"https://api.github.com/users/chrysn/events{/privacy}","received_events_url":"https://api.github.com/users/chrysn/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-06-22T16:56:20Z","updated_at":"2018-06-26T11:51:15Z","closed_at":"2018-06-26T11:51:15Z","author_association":"NONE","body":"I've encountered i2c addresses both in on-the-wire format (typically given as an even number, between 0 and 254, to which 1 is ORed for reads)  and in 7-bit format (a number between 0 and 127).\r\n\r\nWhich one of those is addr in the read/write/write_read functions supposed to be?\r\n\r\nIf it's 7-bit, I'd add a \"Slave addresses are always given as 7-bit numbers (0 <= address < 128).\" in the module documentation, and maybe change \"`SAD+R` = slave address with 8th bit set to 1\" to \"`SAD+R` = slave address followed by bit 1\" and similar at the function level. (Can provide a PR if that's the intention)."}}
{"actor":{"display_login":"therealprof"}}