{"action":"created","comment":{"url":"https://api.github.com/repos/lagom/lagom/pulls/comments/187908717","pull_request_review_id":119780459,"id":187908717,"diff_hunk":"@@ -0,0 +1,19 @@\n+/*\n+ * Copyright (C) 2016-2018 Lightbend Inc. <https://www.lightbend.com>\n+ */\n+package com.lightbend.lagom.internal.persistence\n+\n+import com.typesafe.config.{ Config, ConfigFactory }\n+import play.api.{ Configuration, Environment }\n+\n+package object testkit {\n+  private[lagom] lazy val clusterConfig: Config = ConfigFactory.parseString(\n+    s\"\"\"\n+    akka.actor.provider = akka.cluster.ClusterActorRefProvider\n+    akka.remote.netty.tcp.port = 0\n+    akka.remote.netty.tcp.hostname = 127.0.0.1\n+    \"\"\"\n+  )\n+\n+  private[lagom] def loadTestConfig(): Config = Configuration.load(Environment.simple()).underlying\n+}","path":"persistence/core/src/main/scala/com/lightbend/lagom/internal/persistence/testkit/package.scala","position":19,"original_position":19,"commit_id":"6a51e8cbc4960c9f61da2730e3edba9b26b46a74","original_commit_id":"6a51e8cbc4960c9f61da2730e3edba9b26b46a74","user":{"login":"TimMoore","id":44385,"avatar_url":"https://avatars0.githubusercontent.com/u/44385?v=4","gravatar_id":"","url":"https://api.github.com/users/TimMoore","html_url":"https://github.com/TimMoore","followers_url":"https://api.github.com/users/TimMoore/followers","following_url":"https://api.github.com/users/TimMoore/following{/other_user}","gists_url":"https://api.github.com/users/TimMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/TimMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimMoore/subscriptions","organizations_url":"https://api.github.com/users/TimMoore/orgs","repos_url":"https://api.github.com/users/TimMoore/repos","events_url":"https://api.github.com/users/TimMoore/events{/privacy}","received_events_url":"https://api.github.com/users/TimMoore/received_events","type":"User","site_admin":false},"body":"Both names are confusing, or just `loadTestConfig`? Should I change the latter to `loadConfig`, or any other suggestions?","created_at":"2018-05-14T10:47:56Z","updated_at":"2018-05-14T10:47:57Z","html_url":"https://github.com/lagom/lagom/pull/1350#discussion_r187908717","pull_request_url":"https://api.github.com/repos/lagom/lagom/pulls/1350","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/lagom/lagom/pulls/comments/187908717"},"html":{"href":"https://github.com/lagom/lagom/pull/1350#discussion_r187908717"},"pull_request":{"href":"https://api.github.com/repos/lagom/lagom/pulls/1350"}},"in_reply_to_id":187865530},"pull_request":{"url":"https://api.github.com/repos/lagom/lagom/pulls/1350","id":187391734,"html_url":"https://github.com/lagom/lagom/pull/1350","diff_url":"https://github.com/lagom/lagom/pull/1350.diff","patch_url":"https://github.com/lagom/lagom/pull/1350.patch","issue_url":"https://api.github.com/repos/lagom/lagom/issues/1350","number":1350,"state":"open","locked":false,"title":"Fix retries of the Slick offset table creation","user":{"login":"TimMoore","id":44385,"avatar_url":"https://avatars0.githubusercontent.com/u/44385?v=4","gravatar_id":"","url":"https://api.github.com/users/TimMoore","html_url":"https://github.com/TimMoore","followers_url":"https://api.github.com/users/TimMoore/followers","following_url":"https://api.github.com/users/TimMoore/following{/other_user}","gists_url":"https://api.github.com/users/TimMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/TimMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimMoore/subscriptions","organizations_url":"https://api.github.com/users/TimMoore/orgs","repos_url":"https://api.github.com/users/TimMoore/repos","events_url":"https://api.github.com/users/TimMoore/events{/privacy}","received_events_url":"https://api.github.com/users/TimMoore/received_events","type":"User","site_admin":false},"body":"The existing code caches the future result of the first execution of the cluster startup task, and never retries on failure.\r\n\r\nThis means that if it times out the first time, it will continue to return the ask timeout failure on every subsequent attempt.\r\n\r\n## Fixes\r\n\r\nFixes #1336\r\n\r\n## Background Context\r\n\r\nThe code now more closely resembles the equivalent in [`CassandraOffsetStore`](https://github.com/lagom/lagom/blob/master/persistence-cassandra/core/src/main/scala/com/lightbend/lagom/internal/persistence/cassandra/CassandraOffsetStore.scala).\r\n","created_at":"2018-05-11T07:51:42Z","updated_at":"2018-05-14T10:47:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e29a92fa5b4be2520b96ff0b25a9662c0d14b59","assignee":{"login":"TimMoore","id":44385,"avatar_url":"https://avatars0.githubusercontent.com/u/44385?v=4","gravatar_id":"","url":"https://api.github.com/users/TimMoore","html_url":"https://github.com/TimMoore","followers_url":"https://api.github.com/users/TimMoore/followers","following_url":"https://api.github.com/users/TimMoore/following{/other_user}","gists_url":"https://api.github.com/users/TimMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/TimMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimMoore/subscriptions","organizations_url":"https://api.github.com/users/TimMoore/orgs","repos_url":"https://api.github.com/users/TimMoore/repos","events_url":"https://api.github.com/users/TimMoore/events{/privacy}","received_events_url":"https://api.github.com/users/TimMoore/received_events","type":"User","site_admin":false},"assignees":[{"login":"TimMoore","id":44385,"avatar_url":"https://avatars0.githubusercontent.com/u/44385?v=4","gravatar_id":"","url":"https://api.github.com/users/TimMoore","html_url":"https://github.com/TimMoore","followers_url":"https://api.github.com/users/TimMoore/followers","following_url":"https://api.github.com/users/TimMoore/following{/other_user}","gists_url":"https://api.github.com/users/TimMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/TimMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimMoore/subscriptions","organizations_url":"https://api.github.com/users/TimMoore/orgs","repos_url":"https://api.github.com/users/TimMoore/repos","events_url":"https://api.github.com/users/TimMoore/events{/privacy}","received_events_url":"https://api.github.com/users/TimMoore/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"renatocaval","id":502982,"avatar_url":"https://avatars0.githubusercontent.com/u/502982?v=4","gravatar_id":"","url":"https://api.github.com/users/renatocaval","html_url":"https://github.com/renatocaval","followers_url":"https://api.github.com/users/renatocaval/followers","following_url":"https://api.github.com/users/renatocaval/following{/other_user}","gists_url":"https://api.github.com/users/renatocaval/gists{/gist_id}","starred_url":"https://api.github.com/users/renatocaval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renatocaval/subscriptions","organizations_url":"https://api.github.com/users/renatocaval/orgs","repos_url":"https://api.github.com/users/renatocaval/repos","events_url":"https://api.github.com/users/renatocaval/events{/privacy}","received_events_url":"https://api.github.com/users/renatocaval/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":660037077,"url":"https://api.github.com/repos/lagom/lagom/labels/topic:persistence-api","name":"topic:persistence-api","color":"c5def5","default":false},{"id":330385907,"url":"https://api.github.com/repos/lagom/lagom/labels/type:defect","name":"type:defect","color":"d93f0b","default":false}],"milestone":{"url":"https://api.github.com/repos/lagom/lagom/milestones/30","html_url":"https://github.com/lagom/lagom/milestone/30","labels_url":"https://api.github.com/repos/lagom/lagom/milestones/30/labels","id":3223498,"number":30,"title":"Lagom 1.4.5","description":"","creator":{"login":"renatocaval","id":502982,"avatar_url":"https://avatars0.githubusercontent.com/u/502982?v=4","gravatar_id":"","url":"https://api.github.com/users/renatocaval","html_url":"https://github.com/renatocaval","followers_url":"https://api.github.com/users/renatocaval/followers","following_url":"https://api.github.com/users/renatocaval/following{/other_user}","gists_url":"https://api.github.com/users/renatocaval/gists{/gist_id}","starred_url":"https://api.github.com/users/renatocaval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renatocaval/subscriptions","organizations_url":"https://api.github.com/users/renatocaval/orgs","repos_url":"https://api.github.com/users/renatocaval/repos","events_url":"https://api.github.com/users/renatocaval/events{/privacy}","received_events_url":"https://api.github.com/users/renatocaval/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":26,"state":"open","created_at":"2018-03-27T22:49:07Z","updated_at":"2018-05-14T01:47:00Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/lagom/lagom/pulls/1350/commits","review_comments_url":"https://api.github.com/repos/lagom/lagom/pulls/1350/comments","review_comment_url":"https://api.github.com/repos/lagom/lagom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lagom/lagom/issues/1350/comments","statuses_url":"https://api.github.com/repos/lagom/lagom/statuses/6a51e8cbc4960c9f61da2730e3edba9b26b46a74","head":{"label":"TimMoore:fix-cluster-startup-task","ref":"fix-cluster-startup-task","sha":"6a51e8cbc4960c9f61da2730e3edba9b26b46a74","user":{"login":"TimMoore","id":44385,"avatar_url":"https://avatars0.githubusercontent.com/u/44385?v=4","gravatar_id":"","url":"https://api.github.com/users/TimMoore","html_url":"https://github.com/TimMoore","followers_url":"https://api.github.com/users/TimMoore/followers","following_url":"https://api.github.com/users/TimMoore/following{/other_user}","gists_url":"https://api.github.com/users/TimMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/TimMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimMoore/subscriptions","organizations_url":"https://api.github.com/users/TimMoore/orgs","repos_url":"https://api.github.com/users/TimMoore/repos","events_url":"https://api.github.com/users/TimMoore/events{/privacy}","received_events_url":"https://api.github.com/users/TimMoore/received_events","type":"User","site_admin":false},"repo":{"id":70356980,"name":"lagom","full_name":"TimMoore/lagom","owner":{"login":"TimMoore","id":44385,"avatar_url":"https://avatars0.githubusercontent.com/u/44385?v=4","gravatar_id":"","url":"https://api.github.com/users/TimMoore","html_url":"https://github.com/TimMoore","followers_url":"https://api.github.com/users/TimMoore/followers","following_url":"https://api.github.com/users/TimMoore/following{/other_user}","gists_url":"https://api.github.com/users/TimMoore/gists{/gist_id}","starred_url":"https://api.github.com/users/TimMoore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimMoore/subscriptions","organizations_url":"https://api.github.com/users/TimMoore/orgs","repos_url":"https://api.github.com/users/TimMoore/repos","events_url":"https://api.github.com/users/TimMoore/events{/privacy}","received_events_url":"https://api.github.com/users/TimMoore/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TimMoore/lagom","description":"Reactive Microservices for the JVM","fork":true,"url":"https://api.github.com/repos/TimMoore/lagom","forks_url":"https://api.github.com/repos/TimMoore/lagom/forks","keys_url":"https://api.github.com/repos/TimMoore/lagom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TimMoore/lagom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TimMoore/lagom/teams","hooks_url":"https://api.github.com/repos/TimMoore/lagom/hooks","issue_events_url":"https://api.github.com/repos/TimMoore/lagom/issues/events{/number}","events_url":"https://api.github.com/repos/TimMoore/lagom/events","assignees_url":"https://api.github.com/repos/TimMoore/lagom/assignees{/user}","branches_url":"https://api.github.com/repos/TimMoore/lagom/branches{/branch}","tags_url":"https://api.github.com/repos/TimMoore/lagom/tags","blobs_url":"https://api.github.com/repos/TimMoore/lagom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TimMoore/lagom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TimMoore/lagom/git/refs{/sha}","trees_url":"https://api.github.com/repos/TimMoore/lagom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TimMoore/lagom/statuses/{sha}","languages_url":"https://api.github.com/repos/TimMoore/lagom/languages","stargazers_url":"https://api.github.com/repos/TimMoore/lagom/stargazers","contributors_url":"https://api.github.com/repos/TimMoore/lagom/contributors","subscribers_url":"https://api.github.com/repos/TimMoore/lagom/subscribers","subscription_url":"https://api.github.com/repos/TimMoore/lagom/subscription","commits_url":"https://api.github.com/repos/TimMoore/lagom/commits{/sha}","git_commits_url":"https://api.github.com/repos/TimMoore/lagom/git/commits{/sha}","comments_url":"https://api.github.com/repos/TimMoore/lagom/comments{/number}","issue_comment_url":"https://api.github.com/repos/TimMoore/lagom/issues/comments{/number}","contents_url":"https://api.github.com/repos/TimMoore/lagom/contents/{+path}","compare_url":"https://api.github.com/repos/TimMoore/lagom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TimMoore/lagom/merges","archive_url":"https://api.github.com/repos/TimMoore/lagom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TimMoore/lagom/downloads","issues_url":"https://api.github.com/repos/TimMoore/lagom/issues{/number}","pulls_url":"https://api.github.com/repos/TimMoore/lagom/pulls{/number}","milestones_url":"https://api.github.com/repos/TimMoore/lagom/milestones{/number}","notifications_url":"https://api.github.com/repos/TimMoore/lagom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TimMoore/lagom/labels{/name}","releases_url":"https://api.github.com/repos/TimMoore/lagom/releases{/id}","deployments_url":"https://api.github.com/repos/TimMoore/lagom/deployments","created_at":"2016-10-08T20:56:40Z","updated_at":"2018-05-08T05:45:31Z","pushed_at":"2018-05-14T07:10:44Z","git_url":"git://github.com/TimMoore/lagom.git","ssh_url":"git@github.com:TimMoore/lagom.git","clone_url":"https://github.com/TimMoore/lagom.git","svn_url":"https://github.com/TimMoore/lagom","homepage":"https://lightbend.com/lagom","size":7544,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lagom:master","ref":"master","sha":"f264f62c6f0432341e5babf3e4a6b12ed183070a","user":{"login":"lagom","id":17168851,"avatar_url":"https://avatars1.githubusercontent.com/u/17168851?v=4","gravatar_id":"","url":"https://api.github.com/users/lagom","html_url":"https://github.com/lagom","followers_url":"https://api.github.com/users/lagom/followers","following_url":"https://api.github.com/users/lagom/following{/other_user}","gists_url":"https://api.github.com/users/lagom/gists{/gist_id}","starred_url":"https://api.github.com/users/lagom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagom/subscriptions","organizations_url":"https://api.github.com/users/lagom/orgs","repos_url":"https://api.github.com/users/lagom/repos","events_url":"https://api.github.com/users/lagom/events{/privacy}","received_events_url":"https://api.github.com/users/lagom/received_events","type":"Organization","site_admin":false},"repo":{"id":52320967,"name":"lagom","full_name":"lagom/lagom","owner":{"login":"lagom","id":17168851,"avatar_url":"https://avatars1.githubusercontent.com/u/17168851?v=4","gravatar_id":"","url":"https://api.github.com/users/lagom","html_url":"https://github.com/lagom","followers_url":"https://api.github.com/users/lagom/followers","following_url":"https://api.github.com/users/lagom/following{/other_user}","gists_url":"https://api.github.com/users/lagom/gists{/gist_id}","starred_url":"https://api.github.com/users/lagom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lagom/subscriptions","organizations_url":"https://api.github.com/users/lagom/orgs","repos_url":"https://api.github.com/users/lagom/repos","events_url":"https://api.github.com/users/lagom/events{/privacy}","received_events_url":"https://api.github.com/users/lagom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lagom/lagom","description":"Reactive Microservices for the JVM","fork":false,"url":"https://api.github.com/repos/lagom/lagom","forks_url":"https://api.github.com/repos/lagom/lagom/forks","keys_url":"https://api.github.com/repos/lagom/lagom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lagom/lagom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lagom/lagom/teams","hooks_url":"https://api.github.com/repos/lagom/lagom/hooks","issue_events_url":"https://api.github.com/repos/lagom/lagom/issues/events{/number}","events_url":"https://api.github.com/repos/lagom/lagom/events","assignees_url":"https://api.github.com/repos/lagom/lagom/assignees{/user}","branches_url":"https://api.github.com/repos/lagom/lagom/branches{/branch}","tags_url":"https://api.github.com/repos/lagom/lagom/tags","blobs_url":"https://api.github.com/repos/lagom/lagom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lagom/lagom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lagom/lagom/git/refs{/sha}","trees_url":"https://api.github.com/repos/lagom/lagom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lagom/lagom/statuses/{sha}","languages_url":"https://api.github.com/repos/lagom/lagom/languages","stargazers_url":"https://api.github.com/repos/lagom/lagom/stargazers","contributors_url":"https://api.github.com/repos/lagom/lagom/contributors","subscribers_url":"https://api.github.com/repos/lagom/lagom/subscribers","subscription_url":"https://api.github.com/repos/lagom/lagom/subscription","commits_url":"https://api.github.com/repos/lagom/lagom/commits{/sha}","git_commits_url":"https://api.github.com/repos/lagom/lagom/git/commits{/sha}","comments_url":"https://api.github.com/repos/lagom/lagom/comments{/number}","issue_comment_url":"https://api.github.com/repos/lagom/lagom/issues/comments{/number}","contents_url":"https://api.github.com/repos/lagom/lagom/contents/{+path}","compare_url":"https://api.github.com/repos/lagom/lagom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lagom/lagom/merges","archive_url":"https://api.github.com/repos/lagom/lagom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lagom/lagom/downloads","issues_url":"https://api.github.com/repos/lagom/lagom/issues{/number}","pulls_url":"https://api.github.com/repos/lagom/lagom/pulls{/number}","milestones_url":"https://api.github.com/repos/lagom/lagom/milestones{/number}","notifications_url":"https://api.github.com/repos/lagom/lagom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lagom/lagom/labels{/name}","releases_url":"https://api.github.com/repos/lagom/lagom/releases{/id}","deployments_url":"https://api.github.com/repos/lagom/lagom/deployments","created_at":"2016-02-23T01:51:06Z","updated_at":"2018-05-14T09:34:59Z","pushed_at":"2018-05-14T07:10:46Z","git_url":"git://github.com/lagom/lagom.git","ssh_url":"git@github.com:lagom/lagom.git","clone_url":"https://github.com/lagom/lagom.git","svn_url":"https://github.com/lagom/lagom","homepage":"https://www.lagomframework.com","size":7559,"stargazers_count":1859,"watchers_count":1859,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":405,"mirror_url":null,"archived":false,"open_issues_count":272,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":405,"open_issues":272,"watchers":1859,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lagom/lagom/pulls/1350"},"html":{"href":"https://github.com/lagom/lagom/pull/1350"},"issue":{"href":"https://api.github.com/repos/lagom/lagom/issues/1350"},"comments":{"href":"https://api.github.com/repos/lagom/lagom/issues/1350/comments"},"review_comments":{"href":"https://api.github.com/repos/lagom/lagom/pulls/1350/comments"},"review_comment":{"href":"https://api.github.com/repos/lagom/lagom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lagom/lagom/pulls/1350/commits"},"statuses":{"href":"https://api.github.com/repos/lagom/lagom/statuses/6a51e8cbc4960c9f61da2730e3edba9b26b46a74"}},"author_association":"OWNER"}}
{"actor":{"display_login":"TimMoore"}}