{"action":"created","comment":{"url":"https://api.github.com/repos/all-of-us/workbench/pulls/comments/192433594","pull_request_review_id":125214288,"id":192433594,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjQzMzU5NA==","diff_hunk":"@@ -41,19 +41,43 @@ public ConceptService(EntityManager entityManager) {\n   public Slice<Concept> searchConcepts(String query,\n       StandardConceptFilter standardConceptFilter, List<String> vocabularyIds,\n       List<String> domainIds, int limit) {\n+\n+      //String[] keywords=query.split(\"\\\\s*(=>|,|\\\\s)\\\\s*\");\n+      String[] keywords=query.split(\"[,+\\\\s+]\");","path":"common-api/src/main/java/org/pmiops/workbench/cdr/dao/ConceptService.java","position":6,"original_position":6,"commit_id":"13b83d57ddb02e0072c0864d87aa6cd81b4b690a","original_commit_id":"89d0ba132138ead3d0bebc4e905731a7a2251d39","user":{"login":"danqrodney","id":12536316,"node_id":"MDQ6VXNlcjEyNTM2MzE2","avatar_url":"https://avatars0.githubusercontent.com/u/12536316?v=4","gravatar_id":"","url":"https://api.github.com/users/danqrodney","html_url":"https://github.com/danqrodney","followers_url":"https://api.github.com/users/danqrodney/followers","following_url":"https://api.github.com/users/danqrodney/following{/other_user}","gists_url":"https://api.github.com/users/danqrodney/gists{/gist_id}","starred_url":"https://api.github.com/users/danqrodney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danqrodney/subscriptions","organizations_url":"https://api.github.com/users/danqrodney/orgs","repos_url":"https://api.github.com/users/danqrodney/repos","events_url":"https://api.github.com/users/danqrodney/events{/privacy}","received_events_url":"https://api.github.com/users/danqrodney/received_events","type":"User","site_admin":false},"body":"Style nit: please add spaces between variable names and operators... e.g. keywords = query.split(...), query2 = new String(), for (String key: keywords), etc.","created_at":"2018-06-01T15:32:49Z","updated_at":"2018-06-01T15:41:31Z","html_url":"https://github.com/all-of-us/workbench/pull/891#discussion_r192433594","pull_request_url":"https://api.github.com/repos/all-of-us/workbench/pulls/891","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/comments/192433594"},"html":{"href":"https://github.com/all-of-us/workbench/pull/891#discussion_r192433594"},"pull_request":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/891"}}},"pull_request":{"url":"https://api.github.com/repos/all-of-us/workbench/pulls/891","id":192066089,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMDY2MDg5","html_url":"https://github.com/all-of-us/workbench/pull/891","diff_url":"https://github.com/all-of-us/workbench/pull/891.diff","patch_url":"https://github.com/all-of-us/workbench/pull/891.patch","issue_url":"https://api.github.com/repos/all-of-us/workbench/issues/891","number":891,"state":"open","locked":false,"title":"Srushti gangireddy/concept analysis results","user":{"login":"SrushtiGangireddy","id":21062724,"node_id":"MDQ6VXNlcjIxMDYyNzI0","avatar_url":"https://avatars1.githubusercontent.com/u/21062724?v=4","gravatar_id":"","url":"https://api.github.com/users/SrushtiGangireddy","html_url":"https://github.com/SrushtiGangireddy","followers_url":"https://api.github.com/users/SrushtiGangireddy/followers","following_url":"https://api.github.com/users/SrushtiGangireddy/following{/other_user}","gists_url":"https://api.github.com/users/SrushtiGangireddy/gists{/gist_id}","starred_url":"https://api.github.com/users/SrushtiGangireddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SrushtiGangireddy/subscriptions","organizations_url":"https://api.github.com/users/SrushtiGangireddy/orgs","repos_url":"https://api.github.com/users/SrushtiGangireddy/repos","events_url":"https://api.github.com/users/SrushtiGangireddy/events{/privacy}","received_events_url":"https://api.github.com/users/SrushtiGangireddy/received_events","type":"User","site_admin":false},"body":"Changes:\r\n1. Added concept analysis results and tests\r\n2. Changed the concept count fetch to be distinct concept count for domains which was sum of count value of each concept previously\r\n3. Modified the count value to be same as source count value in case count value is 0\r\n4. Made public api to use dan's concept search and added a test to it\r\n5. Modified concept keyword search to match multiple words\r\n6. Changed the local csvs(concept.csv,achilles_results.csv) with modified count value.\r\n","created_at":"2018-06-01T15:20:11Z","updated_at":"2018-06-01T15:41:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4aa967864d8f5fcd770b87118964f1f07f19a98f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/all-of-us/workbench/pulls/891/commits","review_comments_url":"https://api.github.com/repos/all-of-us/workbench/pulls/891/comments","review_comment_url":"https://api.github.com/repos/all-of-us/workbench/pulls/comments{/number}","comments_url":"https://api.github.com/repos/all-of-us/workbench/issues/891/comments","statuses_url":"https://api.github.com/repos/all-of-us/workbench/statuses/13b83d57ddb02e0072c0864d87aa6cd81b4b690a","head":{"label":"all-of-us:SrushtiGangireddy/ConceptAnalysisResults","ref":"SrushtiGangireddy/ConceptAnalysisResults","sha":"13b83d57ddb02e0072c0864d87aa6cd81b4b690a","user":{"login":"all-of-us","id":22846942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODQ2OTQy","avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"repo":{"id":95247186,"node_id":"MDEwOlJlcG9zaXRvcnk5NTI0NzE4Ng==","name":"workbench","full_name":"all-of-us/workbench","owner":{"login":"all-of-us","id":22846942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODQ2OTQy","avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/all-of-us/workbench","description":null,"fork":false,"url":"https://api.github.com/repos/all-of-us/workbench","forks_url":"https://api.github.com/repos/all-of-us/workbench/forks","keys_url":"https://api.github.com/repos/all-of-us/workbench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/all-of-us/workbench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/all-of-us/workbench/teams","hooks_url":"https://api.github.com/repos/all-of-us/workbench/hooks","issue_events_url":"https://api.github.com/repos/all-of-us/workbench/issues/events{/number}","events_url":"https://api.github.com/repos/all-of-us/workbench/events","assignees_url":"https://api.github.com/repos/all-of-us/workbench/assignees{/user}","branches_url":"https://api.github.com/repos/all-of-us/workbench/branches{/branch}","tags_url":"https://api.github.com/repos/all-of-us/workbench/tags","blobs_url":"https://api.github.com/repos/all-of-us/workbench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/all-of-us/workbench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/all-of-us/workbench/git/refs{/sha}","trees_url":"https://api.github.com/repos/all-of-us/workbench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/all-of-us/workbench/statuses/{sha}","languages_url":"https://api.github.com/repos/all-of-us/workbench/languages","stargazers_url":"https://api.github.com/repos/all-of-us/workbench/stargazers","contributors_url":"https://api.github.com/repos/all-of-us/workbench/contributors","subscribers_url":"https://api.github.com/repos/all-of-us/workbench/subscribers","subscription_url":"https://api.github.com/repos/all-of-us/workbench/subscription","commits_url":"https://api.github.com/repos/all-of-us/workbench/commits{/sha}","git_commits_url":"https://api.github.com/repos/all-of-us/workbench/git/commits{/sha}","comments_url":"https://api.github.com/repos/all-of-us/workbench/comments{/number}","issue_comment_url":"https://api.github.com/repos/all-of-us/workbench/issues/comments{/number}","contents_url":"https://api.github.com/repos/all-of-us/workbench/contents/{+path}","compare_url":"https://api.github.com/repos/all-of-us/workbench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/all-of-us/workbench/merges","archive_url":"https://api.github.com/repos/all-of-us/workbench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/all-of-us/workbench/downloads","issues_url":"https://api.github.com/repos/all-of-us/workbench/issues{/number}","pulls_url":"https://api.github.com/repos/all-of-us/workbench/pulls{/number}","milestones_url":"https://api.github.com/repos/all-of-us/workbench/milestones{/number}","notifications_url":"https://api.github.com/repos/all-of-us/workbench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/all-of-us/workbench/labels{/name}","releases_url":"https://api.github.com/repos/all-of-us/workbench/releases{/id}","deployments_url":"https://api.github.com/repos/all-of-us/workbench/deployments","created_at":"2017-06-23T18:44:24Z","updated_at":"2018-06-01T15:05:35Z","pushed_at":"2018-06-01T15:41:29Z","git_url":"git://github.com/all-of-us/workbench.git","ssh_url":"git@github.com:all-of-us/workbench.git","clone_url":"https://github.com/all-of-us/workbench.git","svn_url":"https://github.com/all-of-us/workbench","homepage":null,"size":117196,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":3,"open_issues":5,"watchers":5,"default_branch":"master"}},"base":{"label":"all-of-us:master","ref":"master","sha":"7e8ee56057b3cbeb3f6054bba6d97abcff27be85","user":{"login":"all-of-us","id":22846942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODQ2OTQy","avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"repo":{"id":95247186,"node_id":"MDEwOlJlcG9zaXRvcnk5NTI0NzE4Ng==","name":"workbench","full_name":"all-of-us/workbench","owner":{"login":"all-of-us","id":22846942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODQ2OTQy","avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/all-of-us/workbench","description":null,"fork":false,"url":"https://api.github.com/repos/all-of-us/workbench","forks_url":"https://api.github.com/repos/all-of-us/workbench/forks","keys_url":"https://api.github.com/repos/all-of-us/workbench/keys{/key_id}","collaborators_url":"https://api.github.com/repos/all-of-us/workbench/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/all-of-us/workbench/teams","hooks_url":"https://api.github.com/repos/all-of-us/workbench/hooks","issue_events_url":"https://api.github.com/repos/all-of-us/workbench/issues/events{/number}","events_url":"https://api.github.com/repos/all-of-us/workbench/events","assignees_url":"https://api.github.com/repos/all-of-us/workbench/assignees{/user}","branches_url":"https://api.github.com/repos/all-of-us/workbench/branches{/branch}","tags_url":"https://api.github.com/repos/all-of-us/workbench/tags","blobs_url":"https://api.github.com/repos/all-of-us/workbench/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/all-of-us/workbench/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/all-of-us/workbench/git/refs{/sha}","trees_url":"https://api.github.com/repos/all-of-us/workbench/git/trees{/sha}","statuses_url":"https://api.github.com/repos/all-of-us/workbench/statuses/{sha}","languages_url":"https://api.github.com/repos/all-of-us/workbench/languages","stargazers_url":"https://api.github.com/repos/all-of-us/workbench/stargazers","contributors_url":"https://api.github.com/repos/all-of-us/workbench/contributors","subscribers_url":"https://api.github.com/repos/all-of-us/workbench/subscribers","subscription_url":"https://api.github.com/repos/all-of-us/workbench/subscription","commits_url":"https://api.github.com/repos/all-of-us/workbench/commits{/sha}","git_commits_url":"https://api.github.com/repos/all-of-us/workbench/git/commits{/sha}","comments_url":"https://api.github.com/repos/all-of-us/workbench/comments{/number}","issue_comment_url":"https://api.github.com/repos/all-of-us/workbench/issues/comments{/number}","contents_url":"https://api.github.com/repos/all-of-us/workbench/contents/{+path}","compare_url":"https://api.github.com/repos/all-of-us/workbench/compare/{base}...{head}","merges_url":"https://api.github.com/repos/all-of-us/workbench/merges","archive_url":"https://api.github.com/repos/all-of-us/workbench/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/all-of-us/workbench/downloads","issues_url":"https://api.github.com/repos/all-of-us/workbench/issues{/number}","pulls_url":"https://api.github.com/repos/all-of-us/workbench/pulls{/number}","milestones_url":"https://api.github.com/repos/all-of-us/workbench/milestones{/number}","notifications_url":"https://api.github.com/repos/all-of-us/workbench/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/all-of-us/workbench/labels{/name}","releases_url":"https://api.github.com/repos/all-of-us/workbench/releases{/id}","deployments_url":"https://api.github.com/repos/all-of-us/workbench/deployments","created_at":"2017-06-23T18:44:24Z","updated_at":"2018-06-01T15:05:35Z","pushed_at":"2018-06-01T15:41:29Z","git_url":"git://github.com/all-of-us/workbench.git","ssh_url":"git@github.com:all-of-us/workbench.git","clone_url":"https://github.com/all-of-us/workbench.git","svn_url":"https://github.com/all-of-us/workbench","homepage":null,"size":117196,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":3,"open_issues":5,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/891"},"html":{"href":"https://github.com/all-of-us/workbench/pull/891"},"issue":{"href":"https://api.github.com/repos/all-of-us/workbench/issues/891"},"comments":{"href":"https://api.github.com/repos/all-of-us/workbench/issues/891/comments"},"review_comments":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/891/comments"},"review_comment":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/all-of-us/workbench/pulls/891/commits"},"statuses":{"href":"https://api.github.com/repos/all-of-us/workbench/statuses/13b83d57ddb02e0072c0864d87aa6cd81b4b690a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"danqrodney"}}