{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/175666182","pull_request_review_id":105230832,"id":175666182,"diff_hunk":"@@ -103,3 +111,21 @@ def update(self, *_):\n     def add_update_listener(self, listener):\n         \"\"\"Add a listener for update notifications.\"\"\"\n         self._update_listeners.append(listener)\n+\n+    def async_add_to_group(self, vehicle, entity_id: str):","path":"homeassistant/components/bmw_connected_drive.py","position":null,"original_position":77,"commit_id":"3872022d7f37c92821146ef3aa231c5fc3645754","original_commit_id":"4e9818473bf1a542898afc05adcdc61af002cc1c","user":{"login":"ChristianKuehnel","id":19961352,"avatar_url":"https://avatars2.githubusercontent.com/u/19961352?v=4","gravatar_id":"","url":"https://api.github.com/users/ChristianKuehnel","html_url":"https://github.com/ChristianKuehnel","followers_url":"https://api.github.com/users/ChristianKuehnel/followers","following_url":"https://api.github.com/users/ChristianKuehnel/following{/other_user}","gists_url":"https://api.github.com/users/ChristianKuehnel/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristianKuehnel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristianKuehnel/subscriptions","organizations_url":"https://api.github.com/users/ChristianKuehnel/orgs","repos_url":"https://api.github.com/users/ChristianKuehnel/repos","events_url":"https://api.github.com/users/ChristianKuehnel/events{/privacy}","received_events_url":"https://api.github.com/users/ChristianKuehnel/received_events","type":"User","site_admin":false},"body":"OK, removed the groups again.\r\n\r\nI though it would be handy, as a vehicle might end up with 10-15 individual sensors. And creating the groups manually is annoying...","created_at":"2018-03-20T06:38:35Z","updated_at":"2018-03-20T06:38:35Z","html_url":"https://github.com/home-assistant/home-assistant/pull/13305#discussion_r175666182","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/13305","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/175666182"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/13305#discussion_r175666182"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/13305"}},"in_reply_to_id":175309849},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/13305","id":175745568,"html_url":"https://github.com/home-assistant/home-assistant/pull/13305","diff_url":"https://github.com/home-assistant/home-assistant/pull/13305.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/13305.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/13305","number":13305,"state":"open","locked":false,"title":"WIP - updated to new \"b2vapi\" of BMW ConnectedDrive","user":{"login":"ChristianKuehnel","id":19961352,"avatar_url":"https://avatars2.githubusercontent.com/u/19961352?v=4","gravatar_id":"","url":"https://api.github.com/users/ChristianKuehnel","html_url":"https://github.com/ChristianKuehnel","followers_url":"https://api.github.com/users/ChristianKuehnel/followers","following_url":"https://api.github.com/users/ChristianKuehnel/following{/other_user}","gists_url":"https://api.github.com/users/ChristianKuehnel/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristianKuehnel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristianKuehnel/subscriptions","organizations_url":"https://api.github.com/users/ChristianKuehnel/orgs","repos_url":"https://api.github.com/users/ChristianKuehnel/repos","events_url":"https://api.github.com/users/ChristianKuehnel/events{/privacy}","received_events_url":"https://api.github.com/users/ChristianKuehnel/received_events","type":"User","site_admin":false},"body":"## Description:\r\nTo support users from USA and Canada, the bimmer_connected library moved to a different API on the BMW servers. As this is a breaking changes for the bimmer_connected library, several changes were required to the Home Assistant modules.\r\n\r\nAdded automatic grouping of all sensors of a vehicle into a single group named after the vehicle model.\r\n\r\n:warning: Breaking change:\r\nThe `country`attribute in the configuration is now replaced with a `region` attribute.\r\n\r\n**Related issue (if applicable):** fixes N/A\r\n\r\n**Pull request in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io) with documentation (if applicable):** home-assistant/home-assistant.github.io#4947\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\nbmw_connected_drive:\r\n  somename:\r\n    username: USERNAME_BMW_CONNECTED_DRIVE\r\n    password: PASSWORD_BMW_CONNECTED_DRIVE\r\n    region: <one of \"north_america\", \"china\", \"rest_of_world\">\r\n```\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n  - [ ] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [ ] Documentation added/updated in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n  - [ ] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n  - [ ] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n  - [ ] New dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n  - [ ] New files were added to `.coveragerc`.\r\n\r\nIf the code does not interact with devices:\r\n  - [ ] Tests have been added to verify that the new code works.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n","created_at":"2018-03-18T11:04:42Z","updated_at":"2018-03-20T06:38:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd94d500a35d6708821af4dd1313aea22918971a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andrey-git","id":5478779,"avatar_url":"https://avatars0.githubusercontent.com/u/5478779?v=4","gravatar_id":"","url":"https://api.github.com/users/andrey-git","html_url":"https://github.com/andrey-git","followers_url":"https://api.github.com/users/andrey-git/followers","following_url":"https://api.github.com/users/andrey-git/following{/other_user}","gists_url":"https://api.github.com/users/andrey-git/gists{/gist_id}","starred_url":"https://api.github.com/users/andrey-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrey-git/subscriptions","organizations_url":"https://api.github.com/users/andrey-git/orgs","repos_url":"https://api.github.com/users/andrey-git/repos","events_url":"https://api.github.com/users/andrey-git/events{/privacy}","received_events_url":"https://api.github.com/users/andrey-git/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":527871105,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":833389538,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/component:%20bmw_connected_drive","name":"component: bmw_connected_drive","color":"ededed","default":false},{"id":540056046,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/component:%20device_tracker","name":"component: device_tracker","color":"ededed","default":false},{"id":451931292,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/core","name":"core","color":"c5def5","default":false},{"id":844417819,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20binary_sensor.bmw_connected_drive","name":"platform: binary_sensor.bmw_connected_drive","color":"ededed","default":false},{"id":844417822,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20lock.bmw_connected_drive","name":"platform: lock.bmw_connected_drive","color":"ededed","default":false},{"id":833389544,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20sensor.bmw_connected_drive","name":"platform: sensor.bmw_connected_drive","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/13305/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/13305/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/13305/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/3872022d7f37c92821146ef3aa231c5fc3645754","head":{"label":"ChristianKuehnel:b2vapi","ref":"b2vapi","sha":"3872022d7f37c92821146ef3aa231c5fc3645754","user":{"login":"ChristianKuehnel","id":19961352,"avatar_url":"https://avatars2.githubusercontent.com/u/19961352?v=4","gravatar_id":"","url":"https://api.github.com/users/ChristianKuehnel","html_url":"https://github.com/ChristianKuehnel","followers_url":"https://api.github.com/users/ChristianKuehnel/followers","following_url":"https://api.github.com/users/ChristianKuehnel/following{/other_user}","gists_url":"https://api.github.com/users/ChristianKuehnel/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristianKuehnel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristianKuehnel/subscriptions","organizations_url":"https://api.github.com/users/ChristianKuehnel/orgs","repos_url":"https://api.github.com/users/ChristianKuehnel/repos","events_url":"https://api.github.com/users/ChristianKuehnel/events{/privacy}","received_events_url":"https://api.github.com/users/ChristianKuehnel/received_events","type":"User","site_admin":false},"repo":{"id":82385957,"name":"home-assistant","full_name":"ChristianKuehnel/home-assistant","owner":{"login":"ChristianKuehnel","id":19961352,"avatar_url":"https://avatars2.githubusercontent.com/u/19961352?v=4","gravatar_id":"","url":"https://api.github.com/users/ChristianKuehnel","html_url":"https://github.com/ChristianKuehnel","followers_url":"https://api.github.com/users/ChristianKuehnel/followers","following_url":"https://api.github.com/users/ChristianKuehnel/following{/other_user}","gists_url":"https://api.github.com/users/ChristianKuehnel/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristianKuehnel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristianKuehnel/subscriptions","organizations_url":"https://api.github.com/users/ChristianKuehnel/orgs","repos_url":"https://api.github.com/users/ChristianKuehnel/repos","events_url":"https://api.github.com/users/ChristianKuehnel/events{/privacy}","received_events_url":"https://api.github.com/users/ChristianKuehnel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ChristianKuehnel/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/ChristianKuehnel/home-assistant","forks_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/forks","keys_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/teams","hooks_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/events","assignees_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/tags","blobs_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/languages","stargazers_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/subscription","commits_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/merges","archive_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/downloads","issues_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/ChristianKuehnel/home-assistant/deployments","created_at":"2017-02-18T12:41:31Z","updated_at":"2017-02-18T12:41:37Z","pushed_at":"2018-03-20T06:37:22Z","git_url":"git://github.com/ChristianKuehnel/home-assistant.git","ssh_url":"git@github.com:ChristianKuehnel/home-assistant.git","clone_url":"https://github.com/ChristianKuehnel/home-assistant.git","svn_url":"https://github.com/ChristianKuehnel/home-assistant","homepage":"https://home-assistant.io","size":79821,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"4270bc7abb7a2fe6aa4f8fbca8908c03338dd3c2","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-03-20T03:55:33Z","pushed_at":"2018-03-20T06:37:28Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":80016,"stargazers_count":13293,"watchers_count":13293,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3853,"mirror_url":null,"archived":false,"open_issues_count":808,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3853,"open_issues":808,"watchers":13293,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/13305"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/13305"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/13305"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/13305/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/13305/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/13305/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/3872022d7f37c92821146ef3aa231c5fc3645754"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ChristianKuehnel"}}