{"action":"closed","number":143,"pull_request":{"url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/pulls/143","id":201294312,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMjk0MzEy","html_url":"https://github.com/jrl-umi3218/jrl-cmakemodules/pull/143","diff_url":"https://github.com/jrl-umi3218/jrl-cmakemodules/pull/143.diff","patch_url":"https://github.com/jrl-umi3218/jrl-cmakemodules/pull/143.patch","issue_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/issues/143","number":143,"state":"closed","locked":false,"title":"make release: also run make dist","user":{"login":"nim65s","id":131929,"node_id":"MDQ6VXNlcjEzMTkyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/131929?v=4","gravatar_id":"","url":"https://api.github.com/users/nim65s","html_url":"https://github.com/nim65s","followers_url":"https://api.github.com/users/nim65s/followers","following_url":"https://api.github.com/users/nim65s/following{/other_user}","gists_url":"https://api.github.com/users/nim65s/gists{/gist_id}","starred_url":"https://api.github.com/users/nim65s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nim65s/subscriptions","organizations_url":"https://api.github.com/users/nim65s/orgs","repos_url":"https://api.github.com/users/nim65s/repos","events_url":"https://api.github.com/users/nim65s/events{/privacy}","received_events_url":"https://api.github.com/users/nim65s/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nI think that `make release` should also create the tarball, so I hereby suggest to add `make dist` inside it.\r\n\r\nThis is the purpose of this PR, plus updating the corresponding documentation.\r\n\r\nGuilhem.","created_at":"2018-07-13T13:39:48Z","updated_at":"2018-07-19T01:42:45Z","closed_at":"2018-07-19T01:42:45Z","merged_at":"2018-07-19T01:42:45Z","merge_commit_sha":"b0120d64aea995a9aebccf33f22c3f6d6cf2b2f2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/pulls/143/commits","review_comments_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/pulls/143/comments","review_comment_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/issues/143/comments","statuses_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/statuses/f435c262989bca2582ab65dbe602c65174e99fd3","head":{"label":"nim65s:master","ref":"master","sha":"f435c262989bca2582ab65dbe602c65174e99fd3","user":{"login":"nim65s","id":131929,"node_id":"MDQ6VXNlcjEzMTkyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/131929?v=4","gravatar_id":"","url":"https://api.github.com/users/nim65s","html_url":"https://github.com/nim65s","followers_url":"https://api.github.com/users/nim65s/followers","following_url":"https://api.github.com/users/nim65s/following{/other_user}","gists_url":"https://api.github.com/users/nim65s/gists{/gist_id}","starred_url":"https://api.github.com/users/nim65s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nim65s/subscriptions","organizations_url":"https://api.github.com/users/nim65s/orgs","repos_url":"https://api.github.com/users/nim65s/repos","events_url":"https://api.github.com/users/nim65s/events{/privacy}","received_events_url":"https://api.github.com/users/nim65s/received_events","type":"User","site_admin":false},"repo":{"id":118590786,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg1OTA3ODY=","name":"jrl-cmakemodules","full_name":"nim65s/jrl-cmakemodules","owner":{"login":"nim65s","id":131929,"node_id":"MDQ6VXNlcjEzMTkyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/131929?v=4","gravatar_id":"","url":"https://api.github.com/users/nim65s","html_url":"https://github.com/nim65s","followers_url":"https://api.github.com/users/nim65s/followers","following_url":"https://api.github.com/users/nim65s/following{/other_user}","gists_url":"https://api.github.com/users/nim65s/gists{/gist_id}","starred_url":"https://api.github.com/users/nim65s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nim65s/subscriptions","organizations_url":"https://api.github.com/users/nim65s/orgs","repos_url":"https://api.github.com/users/nim65s/repos","events_url":"https://api.github.com/users/nim65s/events{/privacy}","received_events_url":"https://api.github.com/users/nim65s/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nim65s/jrl-cmakemodules","description":"CMake utility toolbox","fork":true,"url":"https://api.github.com/repos/nim65s/jrl-cmakemodules","forks_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/forks","keys_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/teams","hooks_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/hooks","issue_events_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/issues/events{/number}","events_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/events","assignees_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/assignees{/user}","branches_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/branches{/branch}","tags_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/tags","blobs_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/git/refs{/sha}","trees_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/statuses/{sha}","languages_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/languages","stargazers_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/stargazers","contributors_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/contributors","subscribers_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/subscribers","subscription_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/subscription","commits_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/commits{/sha}","git_commits_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/git/commits{/sha}","comments_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/comments{/number}","issue_comment_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/issues/comments{/number}","contents_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/contents/{+path}","compare_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/merges","archive_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/downloads","issues_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/issues{/number}","pulls_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/pulls{/number}","milestones_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/milestones{/number}","notifications_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/labels{/name}","releases_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/releases{/id}","deployments_url":"https://api.github.com/repos/nim65s/jrl-cmakemodules/deployments","created_at":"2018-01-23T09:51:45Z","updated_at":"2018-07-13T13:38:15Z","pushed_at":"2018-07-13T13:38:13Z","git_url":"git://github.com/nim65s/jrl-cmakemodules.git","ssh_url":"git@github.com:nim65s/jrl-cmakemodules.git","clone_url":"https://github.com/nim65s/jrl-cmakemodules.git","svn_url":"https://github.com/nim65s/jrl-cmakemodules","homepage":"","size":1219,"stargazers_count":0,"watchers_count":0,"language":"CMake","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jrl-umi3218:master","ref":"master","sha":"07de776d7e5ef324f114b1756649aec1d221268b","user":{"login":"jrl-umi3218","id":410812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDgxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/410812?v=4","gravatar_id":"","url":"https://api.github.com/users/jrl-umi3218","html_url":"https://github.com/jrl-umi3218","followers_url":"https://api.github.com/users/jrl-umi3218/followers","following_url":"https://api.github.com/users/jrl-umi3218/following{/other_user}","gists_url":"https://api.github.com/users/jrl-umi3218/gists{/gist_id}","starred_url":"https://api.github.com/users/jrl-umi3218/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrl-umi3218/subscriptions","organizations_url":"https://api.github.com/users/jrl-umi3218/orgs","repos_url":"https://api.github.com/users/jrl-umi3218/repos","events_url":"https://api.github.com/users/jrl-umi3218/events{/privacy}","received_events_url":"https://api.github.com/users/jrl-umi3218/received_events","type":"Organization","site_admin":false},"repo":{"id":955394,"node_id":"MDEwOlJlcG9zaXRvcnk5NTUzOTQ=","name":"jrl-cmakemodules","full_name":"jrl-umi3218/jrl-cmakemodules","owner":{"login":"jrl-umi3218","id":410812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDgxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/410812?v=4","gravatar_id":"","url":"https://api.github.com/users/jrl-umi3218","html_url":"https://github.com/jrl-umi3218","followers_url":"https://api.github.com/users/jrl-umi3218/followers","following_url":"https://api.github.com/users/jrl-umi3218/following{/other_user}","gists_url":"https://api.github.com/users/jrl-umi3218/gists{/gist_id}","starred_url":"https://api.github.com/users/jrl-umi3218/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrl-umi3218/subscriptions","organizations_url":"https://api.github.com/users/jrl-umi3218/orgs","repos_url":"https://api.github.com/users/jrl-umi3218/repos","events_url":"https://api.github.com/users/jrl-umi3218/events{/privacy}","received_events_url":"https://api.github.com/users/jrl-umi3218/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jrl-umi3218/jrl-cmakemodules","description":"CMake utility toolbox","fork":false,"url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules","forks_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/forks","keys_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/teams","hooks_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/hooks","issue_events_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/issues/events{/number}","events_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/events","assignees_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/assignees{/user}","branches_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/branches{/branch}","tags_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/tags","blobs_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/statuses/{sha}","languages_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/languages","stargazers_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/stargazers","contributors_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/contributors","subscribers_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/subscribers","subscription_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/subscription","commits_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/contents/{+path}","compare_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/merges","archive_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/downloads","issues_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/issues{/number}","pulls_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/pulls{/number}","milestones_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/milestones{/number}","notifications_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/labels{/name}","releases_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/releases{/id}","deployments_url":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/deployments","created_at":"2010-10-01T21:26:36Z","updated_at":"2018-07-11T08:41:40Z","pushed_at":"2018-07-19T01:42:45Z","git_url":"git://github.com/jrl-umi3218/jrl-cmakemodules.git","ssh_url":"git@github.com:jrl-umi3218/jrl-cmakemodules.git","clone_url":"https://github.com/jrl-umi3218/jrl-cmakemodules.git","svn_url":"https://github.com/jrl-umi3218/jrl-cmakemodules","homepage":"","size":1220,"stargazers_count":15,"watchers_count":15,"language":"CMake","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":18,"open_issues":13,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/pulls/143"},"html":{"href":"https://github.com/jrl-umi3218/jrl-cmakemodules/pull/143"},"issue":{"href":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/issues/143"},"comments":{"href":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/jrl-umi3218/jrl-cmakemodules/statuses/f435c262989bca2582ab65dbe602c65174e99fd3"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"gergondet","id":473543,"node_id":"MDQ6VXNlcjQ3MzU0Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/473543?v=4","gravatar_id":"","url":"https://api.github.com/users/gergondet","html_url":"https://github.com/gergondet","followers_url":"https://api.github.com/users/gergondet/followers","following_url":"https://api.github.com/users/gergondet/following{/other_user}","gists_url":"https://api.github.com/users/gergondet/gists{/gist_id}","starred_url":"https://api.github.com/users/gergondet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gergondet/subscriptions","organizations_url":"https://api.github.com/users/gergondet/orgs","repos_url":"https://api.github.com/users/gergondet/repos","events_url":"https://api.github.com/users/gergondet/events{/privacy}","received_events_url":"https://api.github.com/users/gergondet/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"gergondet"}}