{"action":"created","issue":{"url":"https://api.github.com/repos/abraunegg/onedrive/issues/142","repository_url":"https://api.github.com/repos/abraunegg/onedrive","labels_url":"https://api.github.com/repos/abraunegg/onedrive/issues/142/labels{/name}","comments_url":"https://api.github.com/repos/abraunegg/onedrive/issues/142/comments","events_url":"https://api.github.com/repos/abraunegg/onedrive/issues/142/events","html_url":"https://github.com/abraunegg/onedrive/issues/142","id":354075312,"node_id":"MDU6SXNzdWUzNTQwNzUzMTI=","number":142,"title":"Validate filename length before download to conform with Linux FS limits","user":{"login":"abraunegg","id":4956234,"node_id":"MDQ6VXNlcjQ5NTYyMzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4956234?v=4","gravatar_id":"","url":"https://api.github.com/users/abraunegg","html_url":"https://github.com/abraunegg","followers_url":"https://api.github.com/users/abraunegg/followers","following_url":"https://api.github.com/users/abraunegg/following{/other_user}","gists_url":"https://api.github.com/users/abraunegg/gists{/gist_id}","starred_url":"https://api.github.com/users/abraunegg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abraunegg/subscriptions","organizations_url":"https://api.github.com/users/abraunegg/orgs","repos_url":"https://api.github.com/users/abraunegg/repos","events_url":"https://api.github.com/users/abraunegg/events{/privacy}","received_events_url":"https://api.github.com/users/abraunegg/received_events","type":"User","site_admin":false},"labels":[{"id":866537879,"node_id":"MDU6TGFiZWw4NjY1Mzc4Nzk=","url":"https://api.github.com/repos/abraunegg/onedrive/labels/Bug","name":"Bug","color":"d73a4a","default":false},{"id":942586927,"node_id":"MDU6TGFiZWw5NDI1ODY5Mjc=","url":"https://api.github.com/repos/abraunegg/onedrive/labels/Investigating","name":"Investigating","color":"5d65d3","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-26T07:59:29Z","updated_at":"2018-08-27T20:28:05Z","closed_at":null,"author_association":"OWNER","body":"If the file that resides on OneDrive is longer than the filename length allowed by the Linux FS (255 bytes), then the sync fails to continue until the file on OneDrive is renamed or removed.\r\n\r\nA check needs to be added when downloading a file that it conforms to the Linux FS limits & prints an applicable message if the filename length is longer than the FS limit and is skipped.\r\n\r\nFurther details here:\r\n\r\nhttps://github.com/abraunegg/onedrive/issues/134#issuecomment-416016568\r\n\r\n>One more issue with filename/path length, totally unrelated to the one discussed above, but I just don't want to populate multiple issues (I will create a separate issue if it's necessary).\r\n\r\n>If filename (not full path) about to be downloaded from OneDrive exceeds filesystem limitations (most of Linux FS have 255 bytes (this time it's bytes, not Unicode chars!) - can be seen by issuing \" getconf NAME_MAX [path]\" command) - an exception is raised and appears in log:\r\nCannot open file [very long name here] in mode 'wb' (File name too long)\r\nThe program doesn't crash, but syncing doesn't proceed until the offending file is removed/renamed.\r\n\r\n>I think filesystem limits should be checked before attempting to create file and if they are not met - the program should fail gracefully, allowing the sync to proceed.\r\n\r\n>The issue is important as both OneDrive Personal and Windows allow much longer filenames.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/abraunegg/onedrive/issues/comments/416357519","html_url":"https://github.com/abraunegg/onedrive/issues/142#issuecomment-416357519","issue_url":"https://api.github.com/repos/abraunegg/onedrive/issues/142","id":416357519,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjM1NzUxOQ==","user":{"login":"abraunegg","id":4956234,"node_id":"MDQ6VXNlcjQ5NTYyMzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4956234?v=4","gravatar_id":"","url":"https://api.github.com/users/abraunegg","html_url":"https://github.com/abraunegg","followers_url":"https://api.github.com/users/abraunegg/followers","following_url":"https://api.github.com/users/abraunegg/following{/other_user}","gists_url":"https://api.github.com/users/abraunegg/gists{/gist_id}","starred_url":"https://api.github.com/users/abraunegg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abraunegg/subscriptions","organizations_url":"https://api.github.com/users/abraunegg/orgs","repos_url":"https://api.github.com/users/abraunegg/repos","events_url":"https://api.github.com/users/abraunegg/events{/privacy}","received_events_url":"https://api.github.com/users/abraunegg/received_events","type":"User","site_admin":false},"created_at":"2018-08-27T20:28:05Z","updated_at":"2018-08-27T20:28:05Z","author_association":"OWNER","body":"@borouhin \r\nCan you please help validate this PR:\r\n\r\n```\r\ngit clone https://github.com/abraunegg/onedrive.git\r\ncd onedrive\r\ngit fetch origin pull/149/head:pr149\r\ngit checkout pr149\r\nmake\r\nmake install\r\n```"}}
{"actor":{"display_login":"abraunegg"}}