{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments/183178980","pull_request_review_id":114138150,"id":183178980,"diff_hunk":"@@ -30,6 +30,19 @@ function getErrorMessage(obj, file, message) {\n /** Tests for template files in a solution template */\n describe('template files - ', () => {\n \n+    /** Tests for $schema property in template files */\n+    describe('$schema property tests - ', () => {\n+        /** schema property MUST use https  */\n+        it('schema property must use https not http', () => {\n+            templateFileJSONObjects.forEach(templateJSONObject => {\n+                var templateObject = templateJSONObject.value;\n+                if (templateObject.$schema) {","path":"test/solution-template-validation-tests/test/mainTemplateTests.js","position":10,"original_position":10,"commit_id":"5e414f4271730abc3ca9b0e3a3ec848d0780af6d","original_commit_id":"252874c1907c2d5dbfd254962b246717eb4dce8b","user":{"login":"zjpjack","id":6173244,"avatar_url":"https://avatars3.githubusercontent.com/u/6173244?v=4","gravatar_id":"","url":"https://api.github.com/users/zjpjack","html_url":"https://github.com/zjpjack","followers_url":"https://api.github.com/users/zjpjack/followers","following_url":"https://api.github.com/users/zjpjack/following{/other_user}","gists_url":"https://api.github.com/users/zjpjack/gists{/gist_id}","starred_url":"https://api.github.com/users/zjpjack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjpjack/subscriptions","organizations_url":"https://api.github.com/users/zjpjack/orgs","repos_url":"https://api.github.com/users/zjpjack/repos","events_url":"https://api.github.com/users/zjpjack/events{/privacy}","received_events_url":"https://api.github.com/users/zjpjack/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-04-20T22:01:38Z","updated_at":"2018-04-20T22:01:38Z","html_url":"https://github.com/Azure/azure-quickstart-templates/pull/4551#discussion_r183178980","pull_request_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/4551","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments/183178980"},"html":{"href":"https://github.com/Azure/azure-quickstart-templates/pull/4551#discussion_r183178980"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/4551"}},"in_reply_to_id":181236538},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/4551","id":181292584,"html_url":"https://github.com/Azure/azure-quickstart-templates/pull/4551","diff_url":"https://github.com/Azure/azure-quickstart-templates/pull/4551.diff","patch_url":"https://github.com/Azure/azure-quickstart-templates/pull/4551.patch","issue_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/4551","number":4551,"state":"open","locked":false,"title":"Add schema property value check for all template files","user":{"login":"zjpjack","id":6173244,"avatar_url":"https://avatars3.githubusercontent.com/u/6173244?v=4","gravatar_id":"","url":"https://api.github.com/users/zjpjack","html_url":"https://github.com/zjpjack","followers_url":"https://api.github.com/users/zjpjack/followers","following_url":"https://api.github.com/users/zjpjack/following{/other_user}","gists_url":"https://api.github.com/users/zjpjack/gists{/gist_id}","starred_url":"https://api.github.com/users/zjpjack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjpjack/subscriptions","organizations_url":"https://api.github.com/users/zjpjack/orgs","repos_url":"https://api.github.com/users/zjpjack/repos","events_url":"https://api.github.com/users/zjpjack/events{/privacy}","received_events_url":"https://api.github.com/users/zjpjack/received_events","type":"User","site_admin":false},"body":"### Best Practice Checklist\r\nCheck these items before submitting a PR... See the Contribution Guide for the full detail: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md \r\n\r\n1. uri's compatible with all clouds (Stack, China, Government)\r\n1. Staged artifacts use _artifactsLocation & _artifactsLocationSasToken\r\n1. Use resourceGroup().location for resource locations\r\n1. Folder names for artifacts (nestedtemplates, scripts, DSC)\r\n1. Use literal values for apiVersion (no variables)\r\n1. Parameter files (GEN-UNIQUE for value generation and no \"changemeplease\" values\r\n1. $schema and other uris use https\r\n1. Use uniqueString() whenever possible to generate names for resources.  While this is not required, it's one of the most common failure points in a deployment. \r\n1. Update the metadata.json with the current date\r\n\r\nFor details: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/bp-checklist.md\r\n\r\n- [ ] - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.\r\n\r\n### Changelog\r\n\r\n*\r\n*\r\n*\r\n\r\n","created_at":"2018-04-12T18:46:36Z","updated_at":"2018-04-20T22:01:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97497082cbc462a3d1e7873f0489c07e0b550fca","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/4551/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/4551/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/4551/comments","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/5e414f4271730abc3ca9b0e3a3ec848d0780af6d","head":{"label":"zjpjack:msft-jizen/check_schema","ref":"msft-jizen/check_schema","sha":"5e414f4271730abc3ca9b0e3a3ec848d0780af6d","user":{"login":"zjpjack","id":6173244,"avatar_url":"https://avatars3.githubusercontent.com/u/6173244?v=4","gravatar_id":"","url":"https://api.github.com/users/zjpjack","html_url":"https://github.com/zjpjack","followers_url":"https://api.github.com/users/zjpjack/followers","following_url":"https://api.github.com/users/zjpjack/following{/other_user}","gists_url":"https://api.github.com/users/zjpjack/gists{/gist_id}","starred_url":"https://api.github.com/users/zjpjack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjpjack/subscriptions","organizations_url":"https://api.github.com/users/zjpjack/orgs","repos_url":"https://api.github.com/users/zjpjack/repos","events_url":"https://api.github.com/users/zjpjack/events{/privacy}","received_events_url":"https://api.github.com/users/zjpjack/received_events","type":"User","site_admin":false},"repo":{"id":117791080,"name":"azure-quickstart-templates","full_name":"zjpjack/azure-quickstart-templates","owner":{"login":"zjpjack","id":6173244,"avatar_url":"https://avatars3.githubusercontent.com/u/6173244?v=4","gravatar_id":"","url":"https://api.github.com/users/zjpjack","html_url":"https://github.com/zjpjack","followers_url":"https://api.github.com/users/zjpjack/followers","following_url":"https://api.github.com/users/zjpjack/following{/other_user}","gists_url":"https://api.github.com/users/zjpjack/gists{/gist_id}","starred_url":"https://api.github.com/users/zjpjack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjpjack/subscriptions","organizations_url":"https://api.github.com/users/zjpjack/orgs","repos_url":"https://api.github.com/users/zjpjack/repos","events_url":"https://api.github.com/users/zjpjack/events{/privacy}","received_events_url":"https://api.github.com/users/zjpjack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zjpjack/azure-quickstart-templates","description":"Azure Quickstart Templates","fork":true,"url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates","forks_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/forks","keys_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/teams","hooks_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/hooks","issue_events_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/issues/events{/number}","events_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/events","assignees_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/assignees{/user}","branches_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/branches{/branch}","tags_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/tags","blobs_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/languages","stargazers_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/stargazers","contributors_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/contributors","subscribers_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/subscribers","subscription_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/subscription","commits_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/contents/{+path}","compare_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/merges","archive_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/downloads","issues_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/issues{/number}","pulls_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/labels{/name}","releases_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/releases{/id}","deployments_url":"https://api.github.com/repos/zjpjack/azure-quickstart-templates/deployments","created_at":"2018-01-17T05:54:02Z","updated_at":"2018-04-18T00:57:41Z","pushed_at":"2018-04-20T22:01:17Z","git_url":"git://github.com/zjpjack/azure-quickstart-templates.git","ssh_url":"git@github.com:zjpjack/azure-quickstart-templates.git","clone_url":"https://github.com/zjpjack/azure-quickstart-templates.git","svn_url":"https://github.com/zjpjack/azure-quickstart-templates","homepage":"https://azure.microsoft.com/en-us/documentation/templates","size":250321,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"ea060b084141ade84a597351ac0029eaa1b99afd","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":34407651,"name":"azure-quickstart-templates","full_name":"Azure/azure-quickstart-templates","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-quickstart-templates","description":"Azure Quickstart Templates","fork":false,"url":"https://api.github.com/repos/Azure/azure-quickstart-templates","forks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/forks","keys_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/teams","hooks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/events","assignees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/tags","blobs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscription","commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/merges","archive_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/downloads","issues_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/deployments","created_at":"2015-04-22T18:19:03Z","updated_at":"2018-04-20T18:32:57Z","pushed_at":"2018-04-20T22:01:19Z","git_url":"git://github.com/Azure/azure-quickstart-templates.git","ssh_url":"git@github.com:Azure/azure-quickstart-templates.git","clone_url":"https://github.com/Azure/azure-quickstart-templates.git","svn_url":"https://github.com/Azure/azure-quickstart-templates","homepage":"https://azure.microsoft.com/en-us/documentation/templates","size":250365,"stargazers_count":3504,"watchers_count":3504,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5073,"mirror_url":null,"archived":false,"open_issues_count":426,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":5073,"open_issues":426,"watchers":3504,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/4551"},"html":{"href":"https://github.com/Azure/azure-quickstart-templates/pull/4551"},"issue":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/4551"},"comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/4551/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/4551/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/4551/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/5e414f4271730abc3ca9b0e3a3ec848d0780af6d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"zjpjack"}}