{"action":"created","comment":{"url":"https://api.github.com/repos/google/go-cloud/pulls/comments/226089369","pull_request_review_id":165829939,"id":226089369,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjA4OTM2OQ==","diff_hunk":"@@ -154,6 +154,85 @@ func (w *Writer) open(p []byte) (n int, err error) {\n \treturn w.w.Write(p)\n }\n \n+// MaxPageSize is the maximum number of results to retrieve at a time via ListPaged.\n+const MaxPageSize = 1000\n+\n+// ListOptions sets options for listing objects.\n+// TODO(rvangent): Add Delimiter.\n+type ListOptions struct {\n+\t// Prefix indicates that only objects with a key starting with this prefix\n+\t// should be returned.\n+\tPrefix string\n+\n+\t// PageSize sets the maximum number of objects that will be returned in\n+\t// a single call to ListPaged. For List, it sets the internal buffer size.\n+\t// Must be >= 0 and <= MaxPageSize; 0 defaults to MaxPageSize.\n+\tPageSize int","path":"blob/blob.go","position":17,"original_position":17,"commit_id":"163eb6ad0a14d117f5974631db754b0bb969e57d","original_commit_id":"93574671fdebaa32c1ecee07594268901c43d859","user":{"login":"zombiezen","id":181535,"node_id":"MDQ6VXNlcjE4MTUzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/181535?v=4","gravatar_id":"","url":"https://api.github.com/users/zombiezen","html_url":"https://github.com/zombiezen","followers_url":"https://api.github.com/users/zombiezen/followers","following_url":"https://api.github.com/users/zombiezen/following{/other_user}","gists_url":"https://api.github.com/users/zombiezen/gists{/gist_id}","starred_url":"https://api.github.com/users/zombiezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zombiezen/subscriptions","organizations_url":"https://api.github.com/users/zombiezen/orgs","repos_url":"https://api.github.com/users/zombiezen/repos","events_url":"https://api.github.com/users/zombiezen/events{/privacy}","received_events_url":"https://api.github.com/users/zombiezen/received_events","type":"User","site_admin":false},"body":"Now that the paging is gone, can we also remove the page size option and `MaxPageSize`? Seems like an implementation detail.","created_at":"2018-10-17T20:49:57Z","updated_at":"2018-10-17T20:55:03Z","html_url":"https://github.com/google/go-cloud/pull/510#discussion_r226089369","pull_request_url":"https://api.github.com/repos/google/go-cloud/pulls/510","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/google/go-cloud/pulls/comments/226089369"},"html":{"href":"https://github.com/google/go-cloud/pull/510#discussion_r226089369"},"pull_request":{"href":"https://api.github.com/repos/google/go-cloud/pulls/510"}},"in_reply_to_id":224874152},"pull_request":{"url":"https://api.github.com/repos/google/go-cloud/pulls/510","id":221612114,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNjEyMTE0","html_url":"https://github.com/google/go-cloud/pull/510","diff_url":"https://github.com/google/go-cloud/pull/510.diff","patch_url":"https://github.com/google/go-cloud/pull/510.patch","issue_url":"https://api.github.com/repos/google/go-cloud/issues/510","number":510,"state":"open","locked":false,"title":"blob/all: add List, for listing blobs in the bucket","user":{"login":"vangent","id":22553934,"node_id":"MDQ6VXNlcjIyNTUzOTM0","avatar_url":"https://avatars3.githubusercontent.com/u/22553934?v=4","gravatar_id":"","url":"https://api.github.com/users/vangent","html_url":"https://github.com/vangent","followers_url":"https://api.github.com/users/vangent/followers","following_url":"https://api.github.com/users/vangent/following{/other_user}","gists_url":"https://api.github.com/users/vangent/gists{/gist_id}","starred_url":"https://api.github.com/users/vangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vangent/subscriptions","organizations_url":"https://api.github.com/users/vangent/orgs","repos_url":"https://api.github.com/users/vangent/repos","events_url":"https://api.github.com/users/vangent/events{/privacy}","received_events_url":"https://api.github.com/users/vangent/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-09T23:01:40Z","updated_at":"2018-10-17T20:55:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20c6dab5a2a0a9a7d98405a9853938d59464aa5c","assignee":{"login":"zombiezen","id":181535,"node_id":"MDQ6VXNlcjE4MTUzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/181535?v=4","gravatar_id":"","url":"https://api.github.com/users/zombiezen","html_url":"https://github.com/zombiezen","followers_url":"https://api.github.com/users/zombiezen/followers","following_url":"https://api.github.com/users/zombiezen/following{/other_user}","gists_url":"https://api.github.com/users/zombiezen/gists{/gist_id}","starred_url":"https://api.github.com/users/zombiezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zombiezen/subscriptions","organizations_url":"https://api.github.com/users/zombiezen/orgs","repos_url":"https://api.github.com/users/zombiezen/repos","events_url":"https://api.github.com/users/zombiezen/events{/privacy}","received_events_url":"https://api.github.com/users/zombiezen/received_events","type":"User","site_admin":false},"assignees":[{"login":"zombiezen","id":181535,"node_id":"MDQ6VXNlcjE4MTUzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/181535?v=4","gravatar_id":"","url":"https://api.github.com/users/zombiezen","html_url":"https://github.com/zombiezen","followers_url":"https://api.github.com/users/zombiezen/followers","following_url":"https://api.github.com/users/zombiezen/following{/other_user}","gists_url":"https://api.github.com/users/zombiezen/gists{/gist_id}","starred_url":"https://api.github.com/users/zombiezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zombiezen/subscriptions","organizations_url":"https://api.github.com/users/zombiezen/orgs","repos_url":"https://api.github.com/users/zombiezen/repos","events_url":"https://api.github.com/users/zombiezen/events{/privacy}","received_events_url":"https://api.github.com/users/zombiezen/received_events","type":"User","site_admin":false},{"login":"shantuo","id":8689543,"node_id":"MDQ6VXNlcjg2ODk1NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/8689543?v=4","gravatar_id":"","url":"https://api.github.com/users/shantuo","html_url":"https://github.com/shantuo","followers_url":"https://api.github.com/users/shantuo/followers","following_url":"https://api.github.com/users/shantuo/following{/other_user}","gists_url":"https://api.github.com/users/shantuo/gists{/gist_id}","starred_url":"https://api.github.com/users/shantuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shantuo/subscriptions","organizations_url":"https://api.github.com/users/shantuo/orgs","repos_url":"https://api.github.com/users/shantuo/repos","events_url":"https://api.github.com/users/shantuo/events{/privacy}","received_events_url":"https://api.github.com/users/shantuo/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1016532751,"node_id":"MDU6TGFiZWwxMDE2NTMyNzUx","url":"https://api.github.com/repos/google/go-cloud/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/go-cloud/pulls/510/commits","review_comments_url":"https://api.github.com/repos/google/go-cloud/pulls/510/comments","review_comment_url":"https://api.github.com/repos/google/go-cloud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/go-cloud/issues/510/comments","statuses_url":"https://api.github.com/repos/google/go-cloud/statuses/163eb6ad0a14d117f5974631db754b0bb969e57d","head":{"label":"vangent:list","ref":"list","sha":"163eb6ad0a14d117f5974631db754b0bb969e57d","user":{"login":"vangent","id":22553934,"node_id":"MDQ6VXNlcjIyNTUzOTM0","avatar_url":"https://avatars3.githubusercontent.com/u/22553934?v=4","gravatar_id":"","url":"https://api.github.com/users/vangent","html_url":"https://github.com/vangent","followers_url":"https://api.github.com/users/vangent/followers","following_url":"https://api.github.com/users/vangent/following{/other_user}","gists_url":"https://api.github.com/users/vangent/gists{/gist_id}","starred_url":"https://api.github.com/users/vangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vangent/subscriptions","organizations_url":"https://api.github.com/users/vangent/orgs","repos_url":"https://api.github.com/users/vangent/repos","events_url":"https://api.github.com/users/vangent/events{/privacy}","received_events_url":"https://api.github.com/users/vangent/received_events","type":"User","site_admin":false},"repo":{"id":143323945,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMzMjM5NDU=","name":"go-cloud","full_name":"vangent/go-cloud","private":false,"owner":{"login":"vangent","id":22553934,"node_id":"MDQ6VXNlcjIyNTUzOTM0","avatar_url":"https://avatars3.githubusercontent.com/u/22553934?v=4","gravatar_id":"","url":"https://api.github.com/users/vangent","html_url":"https://github.com/vangent","followers_url":"https://api.github.com/users/vangent/followers","following_url":"https://api.github.com/users/vangent/following{/other_user}","gists_url":"https://api.github.com/users/vangent/gists{/gist_id}","starred_url":"https://api.github.com/users/vangent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vangent/subscriptions","organizations_url":"https://api.github.com/users/vangent/orgs","repos_url":"https://api.github.com/users/vangent/repos","events_url":"https://api.github.com/users/vangent/events{/privacy}","received_events_url":"https://api.github.com/users/vangent/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vangent/go-cloud","description":"A library and tools for open cloud development in Go.","fork":true,"url":"https://api.github.com/repos/vangent/go-cloud","forks_url":"https://api.github.com/repos/vangent/go-cloud/forks","keys_url":"https://api.github.com/repos/vangent/go-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vangent/go-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vangent/go-cloud/teams","hooks_url":"https://api.github.com/repos/vangent/go-cloud/hooks","issue_events_url":"https://api.github.com/repos/vangent/go-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/vangent/go-cloud/events","assignees_url":"https://api.github.com/repos/vangent/go-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/vangent/go-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/vangent/go-cloud/tags","blobs_url":"https://api.github.com/repos/vangent/go-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vangent/go-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vangent/go-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/vangent/go-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vangent/go-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/vangent/go-cloud/languages","stargazers_url":"https://api.github.com/repos/vangent/go-cloud/stargazers","contributors_url":"https://api.github.com/repos/vangent/go-cloud/contributors","subscribers_url":"https://api.github.com/repos/vangent/go-cloud/subscribers","subscription_url":"https://api.github.com/repos/vangent/go-cloud/subscription","commits_url":"https://api.github.com/repos/vangent/go-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/vangent/go-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/vangent/go-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/vangent/go-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/vangent/go-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/vangent/go-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vangent/go-cloud/merges","archive_url":"https://api.github.com/repos/vangent/go-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vangent/go-cloud/downloads","issues_url":"https://api.github.com/repos/vangent/go-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/vangent/go-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/vangent/go-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/vangent/go-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vangent/go-cloud/labels{/name}","releases_url":"https://api.github.com/repos/vangent/go-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/vangent/go-cloud/deployments","created_at":"2018-08-02T17:11:06Z","updated_at":"2018-10-12T20:08:17Z","pushed_at":"2018-10-16T22:27:36Z","git_url":"git://github.com/vangent/go-cloud.git","ssh_url":"git@github.com:vangent/go-cloud.git","clone_url":"https://github.com/vangent/go-cloud.git","svn_url":"https://github.com/vangent/go-cloud","homepage":"https://godoc.org/github.com/google/go-cloud","size":18057,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"8b0e835ca9605c7c7a85a39e94a1dd672ab97662","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":126250425,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYyNTA0MjU=","name":"go-cloud","full_name":"google/go-cloud","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/go-cloud","description":"A library and tools for open cloud development in Go.","fork":false,"url":"https://api.github.com/repos/google/go-cloud","forks_url":"https://api.github.com/repos/google/go-cloud/forks","keys_url":"https://api.github.com/repos/google/go-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/go-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/go-cloud/teams","hooks_url":"https://api.github.com/repos/google/go-cloud/hooks","issue_events_url":"https://api.github.com/repos/google/go-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/google/go-cloud/events","assignees_url":"https://api.github.com/repos/google/go-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/google/go-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/google/go-cloud/tags","blobs_url":"https://api.github.com/repos/google/go-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/go-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/go-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/go-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/go-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/google/go-cloud/languages","stargazers_url":"https://api.github.com/repos/google/go-cloud/stargazers","contributors_url":"https://api.github.com/repos/google/go-cloud/contributors","subscribers_url":"https://api.github.com/repos/google/go-cloud/subscribers","subscription_url":"https://api.github.com/repos/google/go-cloud/subscription","commits_url":"https://api.github.com/repos/google/go-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/go-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/go-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/go-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/go-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/google/go-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/go-cloud/merges","archive_url":"https://api.github.com/repos/google/go-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/go-cloud/downloads","issues_url":"https://api.github.com/repos/google/go-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/google/go-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/google/go-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/google/go-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/go-cloud/labels{/name}","releases_url":"https://api.github.com/repos/google/go-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/google/go-cloud/deployments","created_at":"2018-03-21T22:57:26Z","updated_at":"2018-10-17T17:48:25Z","pushed_at":"2018-10-17T16:47:47Z","git_url":"git://github.com/google/go-cloud.git","ssh_url":"git@github.com:google/go-cloud.git","clone_url":"https://github.com/google/go-cloud.git","svn_url":"https://github.com/google/go-cloud","homepage":"https://godoc.org/github.com/google/go-cloud","size":17947,"stargazers_count":4778,"watchers_count":4778,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":241,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":241,"open_issues":73,"watchers":4778,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/go-cloud/pulls/510"},"html":{"href":"https://github.com/google/go-cloud/pull/510"},"issue":{"href":"https://api.github.com/repos/google/go-cloud/issues/510"},"comments":{"href":"https://api.github.com/repos/google/go-cloud/issues/510/comments"},"review_comments":{"href":"https://api.github.com/repos/google/go-cloud/pulls/510/comments"},"review_comment":{"href":"https://api.github.com/repos/google/go-cloud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/go-cloud/pulls/510/commits"},"statuses":{"href":"https://api.github.com/repos/google/go-cloud/statuses/163eb6ad0a14d117f5974631db754b0bb969e57d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zombiezen"}}