{"action":"created","comment":{"url":"https://api.github.com/repos/ProtonMail/libsieve-php/pulls/comments/220882202","pull_request_review_id":159393065,"id":220882202,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDg4MjIwMg==","diff_hunk":"@@ -0,0 +1,48 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+\n+<phpunit bootstrap=\"./tests/bootstrap.php\"\n+         backupGlobals=\"false\"\n+         backupStaticAttributes=\"false\"\n+         verbose=\"true\"\n+         colors=\"true\"\n+         convertErrorsToExceptions=\"true\"\n+         convertNoticesToExceptions=\"true\"\n+         convertWarningsToExceptions=\"true\"\n+         processIsolation=\"false\"\n+         stopOnFailure=\"false\"\n+         >\n+\n+    <!-- Define logging and code coverage -->\n+    <filter>\n+        <whitelist addUncoveredFilesFromWhitelist=\"true\">\n+            <directory suffix=\".php\">lib</directory>\n+        </whitelist>\n+    </filter>\n+\n+    <logging>\n+      <log type=\"coverage-html\" target=\"./reports/report\" lowUpperBound=\"35\" highLowerBound=\"70\"/>\n+      <!-- <log type=\"coverage-clover\" target=\"./reports/coverage.xml\"/> -->\n+      <!-- <log type=\"coverage-php\" target=\"./reports/coverage.serialized\"/> -->\n+      <log type=\"coverage-text\" target=\"php://stdout\" showUncoveredFiles=\"false\"/>\n+      <log type=\"json\" target=\"./reports/logfile.json\"/>\n+      <!-- <log type=\"tap\" target=\"./reports/logfile.tap\"/> -->\n+      <!-- <log type=\"junit\" target=\"./reports/logfile.xml\"/> -->\n+      <log type=\"testdox-text\" target=\"./reports/testdox.txt\"/>\n+      <!-- <log type=\"testdox-html\" target=\"./reports/testdox.html\"/> -->\n+    </logging>\n+\n+    <!-- Define test suites below -->\n+    <testsuites>\n+        <testsuite name=\"Global\">\n+            <directory suffix=\"Test.php\">./tests</directory>\n+        </testsuite>\n+    </testsuites>\n+\n+    <!-- This can be used to configure PHP settings, constants, and global variables. It can also be used to prepend the include_path. -->\n+    <php>\n+        <const name=\"PHPUNIT\" value=\"true\"/>\n+        <const name=\"EMAIL_SERVICES\" value=\"false\"/>","path":"phpunit.xml","position":44,"original_position":44,"commit_id":"dc59c86941a7876845fc0eb25223fe853093b92d","original_commit_id":"dc59c86941a7876845fc0eb25223fe853093b92d","user":{"login":"KAYLukas","id":1674504,"node_id":"MDQ6VXNlcjE2NzQ1MDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1674504?v=4","gravatar_id":"","url":"https://api.github.com/users/KAYLukas","html_url":"https://github.com/KAYLukas","followers_url":"https://api.github.com/users/KAYLukas/followers","following_url":"https://api.github.com/users/KAYLukas/following{/other_user}","gists_url":"https://api.github.com/users/KAYLukas/gists{/gist_id}","starred_url":"https://api.github.com/users/KAYLukas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KAYLukas/subscriptions","organizations_url":"https://api.github.com/users/KAYLukas/orgs","repos_url":"https://api.github.com/users/KAYLukas/repos","events_url":"https://api.github.com/users/KAYLukas/events{/privacy}","received_events_url":"https://api.github.com/users/KAYLukas/received_events","type":"User","site_admin":false},"body":"Do we still need these constants?","created_at":"2018-09-27T11:09:03Z","updated_at":"2018-09-27T11:13:20Z","html_url":"https://github.com/ProtonMail/libsieve-php/pull/4#discussion_r220882202","pull_request_url":"https://api.github.com/repos/ProtonMail/libsieve-php/pulls/4","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ProtonMail/libsieve-php/pulls/comments/220882202"},"html":{"href":"https://github.com/ProtonMail/libsieve-php/pull/4#discussion_r220882202"},"pull_request":{"href":"https://api.github.com/repos/ProtonMail/libsieve-php/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/ProtonMail/libsieve-php/pulls/4","id":218598081,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NTk4MDgx","html_url":"https://github.com/ProtonMail/libsieve-php/pull/4","diff_url":"https://github.com/ProtonMail/libsieve-php/pull/4.diff","patch_url":"https://github.com/ProtonMail/libsieve-php/pull/4.patch","issue_url":"https://api.github.com/repos/ProtonMail/libsieve-php/issues/4","number":4,"state":"open","locked":false,"title":"Feature/store comments and whitespaces","user":{"login":"ThHareau","id":9265111,"node_id":"MDQ6VXNlcjkyNjUxMTE=","avatar_url":"https://avatars0.githubusercontent.com/u/9265111?v=4","gravatar_id":"","url":"https://api.github.com/users/ThHareau","html_url":"https://github.com/ThHareau","followers_url":"https://api.github.com/users/ThHareau/followers","following_url":"https://api.github.com/users/ThHareau/following{/other_user}","gists_url":"https://api.github.com/users/ThHareau/gists{/gist_id}","starred_url":"https://api.github.com/users/ThHareau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThHareau/subscriptions","organizations_url":"https://api.github.com/users/ThHareau/orgs","repos_url":"https://api.github.com/users/ThHareau/repos","events_url":"https://api.github.com/users/ThHareau/events{/privacy}","received_events_url":"https://api.github.com/users/ThHareau/received_events","type":"User","site_admin":false},"body":"* add the comments and the white spaces in the tree\r\n* add unit testing with phpunit. ","created_at":"2018-09-27T10:17:42Z","updated_at":"2018-09-27T11:13:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11a2df3511b95e368bb7ae0e65be5a20ec311f7d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ProtonMail/libsieve-php/pulls/4/commits","review_comments_url":"https://api.github.com/repos/ProtonMail/libsieve-php/pulls/4/comments","review_comment_url":"https://api.github.com/repos/ProtonMail/libsieve-php/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ProtonMail/libsieve-php/issues/4/comments","statuses_url":"https://api.github.com/repos/ProtonMail/libsieve-php/statuses/dc59c86941a7876845fc0eb25223fe853093b92d","head":{"label":"ProtonMail:feature/storeCommentsAndWhitespaces","ref":"feature/storeCommentsAndWhitespaces","sha":"dc59c86941a7876845fc0eb25223fe853093b92d","user":{"login":"ProtonMail","id":6953970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTM5NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6953970?v=4","gravatar_id":"","url":"https://api.github.com/users/ProtonMail","html_url":"https://github.com/ProtonMail","followers_url":"https://api.github.com/users/ProtonMail/followers","following_url":"https://api.github.com/users/ProtonMail/following{/other_user}","gists_url":"https://api.github.com/users/ProtonMail/gists{/gist_id}","starred_url":"https://api.github.com/users/ProtonMail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProtonMail/subscriptions","organizations_url":"https://api.github.com/users/ProtonMail/orgs","repos_url":"https://api.github.com/users/ProtonMail/repos","events_url":"https://api.github.com/users/ProtonMail/events{/privacy}","received_events_url":"https://api.github.com/users/ProtonMail/received_events","type":"Organization","site_admin":false},"repo":{"id":56619014,"node_id":"MDEwOlJlcG9zaXRvcnk1NjYxOTAxNA==","name":"libsieve-php","full_name":"ProtonMail/libsieve-php","private":false,"owner":{"login":"ProtonMail","id":6953970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTM5NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6953970?v=4","gravatar_id":"","url":"https://api.github.com/users/ProtonMail","html_url":"https://github.com/ProtonMail","followers_url":"https://api.github.com/users/ProtonMail/followers","following_url":"https://api.github.com/users/ProtonMail/following{/other_user}","gists_url":"https://api.github.com/users/ProtonMail/gists{/gist_id}","starred_url":"https://api.github.com/users/ProtonMail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProtonMail/subscriptions","organizations_url":"https://api.github.com/users/ProtonMail/orgs","repos_url":"https://api.github.com/users/ProtonMail/repos","events_url":"https://api.github.com/users/ProtonMail/events{/privacy}","received_events_url":"https://api.github.com/users/ProtonMail/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ProtonMail/libsieve-php","description":"libsieve-php is a library to manage and modify sieve (RFC5228) scripts. It contains a parser for the sieve language (including extensions) and a client for the managesieve protocol. It is written entirely in PHP 5.","fork":false,"url":"https://api.github.com/repos/ProtonMail/libsieve-php","forks_url":"https://api.github.com/repos/ProtonMail/libsieve-php/forks","keys_url":"https://api.github.com/repos/ProtonMail/libsieve-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProtonMail/libsieve-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProtonMail/libsieve-php/teams","hooks_url":"https://api.github.com/repos/ProtonMail/libsieve-php/hooks","issue_events_url":"https://api.github.com/repos/ProtonMail/libsieve-php/issues/events{/number}","events_url":"https://api.github.com/repos/ProtonMail/libsieve-php/events","assignees_url":"https://api.github.com/repos/ProtonMail/libsieve-php/assignees{/user}","branches_url":"https://api.github.com/repos/ProtonMail/libsieve-php/branches{/branch}","tags_url":"https://api.github.com/repos/ProtonMail/libsieve-php/tags","blobs_url":"https://api.github.com/repos/ProtonMail/libsieve-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProtonMail/libsieve-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProtonMail/libsieve-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProtonMail/libsieve-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProtonMail/libsieve-php/statuses/{sha}","languages_url":"https://api.github.com/repos/ProtonMail/libsieve-php/languages","stargazers_url":"https://api.github.com/repos/ProtonMail/libsieve-php/stargazers","contributors_url":"https://api.github.com/repos/ProtonMail/libsieve-php/contributors","subscribers_url":"https://api.github.com/repos/ProtonMail/libsieve-php/subscribers","subscription_url":"https://api.github.com/repos/ProtonMail/libsieve-php/subscription","commits_url":"https://api.github.com/repos/ProtonMail/libsieve-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProtonMail/libsieve-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProtonMail/libsieve-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProtonMail/libsieve-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProtonMail/libsieve-php/contents/{+path}","compare_url":"https://api.github.com/repos/ProtonMail/libsieve-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProtonMail/libsieve-php/merges","archive_url":"https://api.github.com/repos/ProtonMail/libsieve-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProtonMail/libsieve-php/downloads","issues_url":"https://api.github.com/repos/ProtonMail/libsieve-php/issues{/number}","pulls_url":"https://api.github.com/repos/ProtonMail/libsieve-php/pulls{/number}","milestones_url":"https://api.github.com/repos/ProtonMail/libsieve-php/milestones{/number}","notifications_url":"https://api.github.com/repos/ProtonMail/libsieve-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProtonMail/libsieve-php/labels{/name}","releases_url":"https://api.github.com/repos/ProtonMail/libsieve-php/releases{/id}","deployments_url":"https://api.github.com/repos/ProtonMail/libsieve-php/deployments","created_at":"2016-04-19T17:53:06Z","updated_at":"2018-09-27T10:20:31Z","pushed_at":"2018-09-27T10:23:12Z","git_url":"git://github.com/ProtonMail/libsieve-php.git","ssh_url":"git@github.com:ProtonMail/libsieve-php.git","clone_url":"https://github.com/ProtonMail/libsieve-php.git","svn_url":"https://github.com/ProtonMail/libsieve-php","homepage":null,"size":334,"stargazers_count":6,"watchers_count":6,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":4,"open_issues":1,"watchers":6,"default_branch":"master"}},"base":{"label":"ProtonMail:master","ref":"master","sha":"4caec4b3a7902a8020e4c84cb8332aff773bf8c3","user":{"login":"ProtonMail","id":6953970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTM5NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6953970?v=4","gravatar_id":"","url":"https://api.github.com/users/ProtonMail","html_url":"https://github.com/ProtonMail","followers_url":"https://api.github.com/users/ProtonMail/followers","following_url":"https://api.github.com/users/ProtonMail/following{/other_user}","gists_url":"https://api.github.com/users/ProtonMail/gists{/gist_id}","starred_url":"https://api.github.com/users/ProtonMail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProtonMail/subscriptions","organizations_url":"https://api.github.com/users/ProtonMail/orgs","repos_url":"https://api.github.com/users/ProtonMail/repos","events_url":"https://api.github.com/users/ProtonMail/events{/privacy}","received_events_url":"https://api.github.com/users/ProtonMail/received_events","type":"Organization","site_admin":false},"repo":{"id":56619014,"node_id":"MDEwOlJlcG9zaXRvcnk1NjYxOTAxNA==","name":"libsieve-php","full_name":"ProtonMail/libsieve-php","private":false,"owner":{"login":"ProtonMail","id":6953970,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTM5NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6953970?v=4","gravatar_id":"","url":"https://api.github.com/users/ProtonMail","html_url":"https://github.com/ProtonMail","followers_url":"https://api.github.com/users/ProtonMail/followers","following_url":"https://api.github.com/users/ProtonMail/following{/other_user}","gists_url":"https://api.github.com/users/ProtonMail/gists{/gist_id}","starred_url":"https://api.github.com/users/ProtonMail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProtonMail/subscriptions","organizations_url":"https://api.github.com/users/ProtonMail/orgs","repos_url":"https://api.github.com/users/ProtonMail/repos","events_url":"https://api.github.com/users/ProtonMail/events{/privacy}","received_events_url":"https://api.github.com/users/ProtonMail/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ProtonMail/libsieve-php","description":"libsieve-php is a library to manage and modify sieve (RFC5228) scripts. It contains a parser for the sieve language (including extensions) and a client for the managesieve protocol. It is written entirely in PHP 5.","fork":false,"url":"https://api.github.com/repos/ProtonMail/libsieve-php","forks_url":"https://api.github.com/repos/ProtonMail/libsieve-php/forks","keys_url":"https://api.github.com/repos/ProtonMail/libsieve-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProtonMail/libsieve-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProtonMail/libsieve-php/teams","hooks_url":"https://api.github.com/repos/ProtonMail/libsieve-php/hooks","issue_events_url":"https://api.github.com/repos/ProtonMail/libsieve-php/issues/events{/number}","events_url":"https://api.github.com/repos/ProtonMail/libsieve-php/events","assignees_url":"https://api.github.com/repos/ProtonMail/libsieve-php/assignees{/user}","branches_url":"https://api.github.com/repos/ProtonMail/libsieve-php/branches{/branch}","tags_url":"https://api.github.com/repos/ProtonMail/libsieve-php/tags","blobs_url":"https://api.github.com/repos/ProtonMail/libsieve-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProtonMail/libsieve-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProtonMail/libsieve-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProtonMail/libsieve-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProtonMail/libsieve-php/statuses/{sha}","languages_url":"https://api.github.com/repos/ProtonMail/libsieve-php/languages","stargazers_url":"https://api.github.com/repos/ProtonMail/libsieve-php/stargazers","contributors_url":"https://api.github.com/repos/ProtonMail/libsieve-php/contributors","subscribers_url":"https://api.github.com/repos/ProtonMail/libsieve-php/subscribers","subscription_url":"https://api.github.com/repos/ProtonMail/libsieve-php/subscription","commits_url":"https://api.github.com/repos/ProtonMail/libsieve-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProtonMail/libsieve-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProtonMail/libsieve-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProtonMail/libsieve-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProtonMail/libsieve-php/contents/{+path}","compare_url":"https://api.github.com/repos/ProtonMail/libsieve-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProtonMail/libsieve-php/merges","archive_url":"https://api.github.com/repos/ProtonMail/libsieve-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProtonMail/libsieve-php/downloads","issues_url":"https://api.github.com/repos/ProtonMail/libsieve-php/issues{/number}","pulls_url":"https://api.github.com/repos/ProtonMail/libsieve-php/pulls{/number}","milestones_url":"https://api.github.com/repos/ProtonMail/libsieve-php/milestones{/number}","notifications_url":"https://api.github.com/repos/ProtonMail/libsieve-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProtonMail/libsieve-php/labels{/name}","releases_url":"https://api.github.com/repos/ProtonMail/libsieve-php/releases{/id}","deployments_url":"https://api.github.com/repos/ProtonMail/libsieve-php/deployments","created_at":"2016-04-19T17:53:06Z","updated_at":"2018-09-27T10:20:31Z","pushed_at":"2018-09-27T10:23:12Z","git_url":"git://github.com/ProtonMail/libsieve-php.git","ssh_url":"git@github.com:ProtonMail/libsieve-php.git","clone_url":"https://github.com/ProtonMail/libsieve-php.git","svn_url":"https://github.com/ProtonMail/libsieve-php","homepage":null,"size":334,"stargazers_count":6,"watchers_count":6,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":4,"open_issues":1,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ProtonMail/libsieve-php/pulls/4"},"html":{"href":"https://github.com/ProtonMail/libsieve-php/pull/4"},"issue":{"href":"https://api.github.com/repos/ProtonMail/libsieve-php/issues/4"},"comments":{"href":"https://api.github.com/repos/ProtonMail/libsieve-php/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/ProtonMail/libsieve-php/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/ProtonMail/libsieve-php/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ProtonMail/libsieve-php/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/ProtonMail/libsieve-php/statuses/dc59c86941a7876845fc0eb25223fe853093b92d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"KAYLukas"}}