{"action":"created","comment":{"url":"https://api.github.com/repos/PowerShell/vscode-powershell/pulls/comments/202225332","pull_request_review_id":136884222,"id":202225332,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjIyNTMzMg==","diff_hunk":"@@ -421,9 +421,9 @@ export class FoldingProvider implements vscode.FoldingRangeProvider {\n     ): ITokenList {\n         const result = [];\n \n-        const emptyLine = /^[\\s]+$/;\n-        const startRegionText = /^#\\s*region\\b/;\n-        const endRegionText = /^#\\s*endregion\\b/;\n+        const emptyLine = /^[\\s]*$/;\n+        const startRegionText = /^#\\s*[rR]egion\\b/;","path":"src/features/Folding.ts","position":null,"original_position":17,"commit_id":"e5f16cee7d42f7dbb65e28d6a8def33e4985ea01","original_commit_id":"e91298b85bdc1b0e217e8159fc6426458bf2a240","user":{"login":"glennsarti","id":5819622,"node_id":"MDQ6VXNlcjU4MTk2MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/5819622?v=4","gravatar_id":"","url":"https://api.github.com/users/glennsarti","html_url":"https://github.com/glennsarti","followers_url":"https://api.github.com/users/glennsarti/followers","following_url":"https://api.github.com/users/glennsarti/following{/other_user}","gists_url":"https://api.github.com/users/glennsarti/gists{/gist_id}","starred_url":"https://api.github.com/users/glennsarti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennsarti/subscriptions","organizations_url":"https://api.github.com/users/glennsarti/orgs","repos_url":"https://api.github.com/users/glennsarti/repos","events_url":"https://api.github.com/users/glennsarti/events{/privacy}","received_events_url":"https://api.github.com/users/glennsarti/received_events","type":"User","site_admin":false},"body":"yeah .... could also argue the same for;\r\n\r\n```\r\n#blah blah blah blah in the same \r\n#region as blah blah blah\r\n```","created_at":"2018-07-13T01:49:28Z","updated_at":"2018-07-13T01:49:28Z","html_url":"https://github.com/PowerShell/vscode-powershell/pull/1430#discussion_r202225332","pull_request_url":"https://api.github.com/repos/PowerShell/vscode-powershell/pulls/1430","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PowerShell/vscode-powershell/pulls/comments/202225332"},"html":{"href":"https://github.com/PowerShell/vscode-powershell/pull/1430#discussion_r202225332"},"pull_request":{"href":"https://api.github.com/repos/PowerShell/vscode-powershell/pulls/1430"}},"in_reply_to_id":202060110},"pull_request":{"url":"https://api.github.com/repos/PowerShell/vscode-powershell/pulls/1430","id":200975437,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwOTc1NDM3","html_url":"https://github.com/PowerShell/vscode-powershell/pull/1430","diff_url":"https://github.com/PowerShell/vscode-powershell/pull/1430.diff","patch_url":"https://github.com/PowerShell/vscode-powershell/pull/1430.patch","issue_url":"https://api.github.com/repos/PowerShell/vscode-powershell/issues/1430","number":1430,"state":"open","locked":false,"title":"(GH-1428) Make region folding case insensitive and parse whitespace correctly","user":{"login":"glennsarti","id":5819622,"node_id":"MDQ6VXNlcjU4MTk2MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/5819622?v=4","gravatar_id":"","url":"https://api.github.com/users/glennsarti","html_url":"https://github.com/glennsarti","followers_url":"https://api.github.com/users/glennsarti/followers","following_url":"https://api.github.com/users/glennsarti/following{/other_user}","gists_url":"https://api.github.com/users/glennsarti/gists{/gist_id}","starred_url":"https://api.github.com/users/glennsarti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennsarti/subscriptions","organizations_url":"https://api.github.com/users/glennsarti/orgs","repos_url":"https://api.github.com/users/glennsarti/repos","events_url":"https://api.github.com/users/glennsarti/events{/privacy}","received_events_url":"https://api.github.com/users/glennsarti/received_events","type":"User","site_admin":false},"body":"## PR Summary\r\n\r\nPreviously the code folding feature would fail to find region blocks starting\r\nwith `Region` or ending with `EndRegion`.  This was due to the regex only\r\nlooking for lower case.  This commit updates the start and end region\r\ndetection to be case insensitive, similar to that defined in\r\nhttps://github.com/Microsoft/vscode/commit/64186b0a262f0ff89a060cf8dbbf8de7ff831a00\r\n\r\nPreviously the code folding had trouble detecting the beginning of comment\r\nblocks and regions which were not indented.  This was due to the empty line\r\nregex expecting at least one whitespace character to be considered \"an empty\r\nline\".  This commit modifies the empty line regex to also allow an empty string\r\nwhich is indeed, an empty line.\r\n\r\nFixes #1428\r\n\r\n## PR Checklist\r\n\r\nNote: Tick the boxes below that apply to this pull request by putting an `x` between the square brackets.\r\nPlease mark anything not applicable to this PR `NA`.\r\n\r\n- [x] PR has a meaningful title\r\n- [x] Summarized changes\r\n- [x] This PR is ready to merge and is not work in progress\r\n    - If the PR is work in progress, please add the prefix `WIP:` to the beginning of the title and remove the prefix when the PR is ready\r\n","created_at":"2018-07-12T11:50:04Z","updated_at":"2018-07-13T01:49:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2644a448015d8b1815b97c7700eda725178d6a55","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PowerShell/vscode-powershell/pulls/1430/commits","review_comments_url":"https://api.github.com/repos/PowerShell/vscode-powershell/pulls/1430/comments","review_comment_url":"https://api.github.com/repos/PowerShell/vscode-powershell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerShell/vscode-powershell/issues/1430/comments","statuses_url":"https://api.github.com/repos/PowerShell/vscode-powershell/statuses/e5f16cee7d42f7dbb65e28d6a8def33e4985ea01","head":{"label":"glennsarti:gh-1428-folding-casing","ref":"gh-1428-folding-casing","sha":"e5f16cee7d42f7dbb65e28d6a8def33e4985ea01","user":{"login":"glennsarti","id":5819622,"node_id":"MDQ6VXNlcjU4MTk2MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/5819622?v=4","gravatar_id":"","url":"https://api.github.com/users/glennsarti","html_url":"https://github.com/glennsarti","followers_url":"https://api.github.com/users/glennsarti/followers","following_url":"https://api.github.com/users/glennsarti/following{/other_user}","gists_url":"https://api.github.com/users/glennsarti/gists{/gist_id}","starred_url":"https://api.github.com/users/glennsarti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennsarti/subscriptions","organizations_url":"https://api.github.com/users/glennsarti/orgs","repos_url":"https://api.github.com/users/glennsarti/repos","events_url":"https://api.github.com/users/glennsarti/events{/privacy}","received_events_url":"https://api.github.com/users/glennsarti/received_events","type":"User","site_admin":false},"repo":{"id":136583672,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY1ODM2NzI=","name":"vscode-powershell","full_name":"glennsarti/vscode-powershell","owner":{"login":"glennsarti","id":5819622,"node_id":"MDQ6VXNlcjU4MTk2MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/5819622?v=4","gravatar_id":"","url":"https://api.github.com/users/glennsarti","html_url":"https://github.com/glennsarti","followers_url":"https://api.github.com/users/glennsarti/followers","following_url":"https://api.github.com/users/glennsarti/following{/other_user}","gists_url":"https://api.github.com/users/glennsarti/gists{/gist_id}","starred_url":"https://api.github.com/users/glennsarti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennsarti/subscriptions","organizations_url":"https://api.github.com/users/glennsarti/orgs","repos_url":"https://api.github.com/users/glennsarti/repos","events_url":"https://api.github.com/users/glennsarti/events{/privacy}","received_events_url":"https://api.github.com/users/glennsarti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/glennsarti/vscode-powershell","description":"Provides PowerShell language and debugging support for Visual Studio Code","fork":true,"url":"https://api.github.com/repos/glennsarti/vscode-powershell","forks_url":"https://api.github.com/repos/glennsarti/vscode-powershell/forks","keys_url":"https://api.github.com/repos/glennsarti/vscode-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glennsarti/vscode-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glennsarti/vscode-powershell/teams","hooks_url":"https://api.github.com/repos/glennsarti/vscode-powershell/hooks","issue_events_url":"https://api.github.com/repos/glennsarti/vscode-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/glennsarti/vscode-powershell/events","assignees_url":"https://api.github.com/repos/glennsarti/vscode-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/glennsarti/vscode-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/glennsarti/vscode-powershell/tags","blobs_url":"https://api.github.com/repos/glennsarti/vscode-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glennsarti/vscode-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glennsarti/vscode-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/glennsarti/vscode-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glennsarti/vscode-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/glennsarti/vscode-powershell/languages","stargazers_url":"https://api.github.com/repos/glennsarti/vscode-powershell/stargazers","contributors_url":"https://api.github.com/repos/glennsarti/vscode-powershell/contributors","subscribers_url":"https://api.github.com/repos/glennsarti/vscode-powershell/subscribers","subscription_url":"https://api.github.com/repos/glennsarti/vscode-powershell/subscription","commits_url":"https://api.github.com/repos/glennsarti/vscode-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/glennsarti/vscode-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/glennsarti/vscode-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/glennsarti/vscode-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/glennsarti/vscode-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/glennsarti/vscode-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glennsarti/vscode-powershell/merges","archive_url":"https://api.github.com/repos/glennsarti/vscode-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glennsarti/vscode-powershell/downloads","issues_url":"https://api.github.com/repos/glennsarti/vscode-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/glennsarti/vscode-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/glennsarti/vscode-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/glennsarti/vscode-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glennsarti/vscode-powershell/labels{/name}","releases_url":"https://api.github.com/repos/glennsarti/vscode-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/glennsarti/vscode-powershell/deployments","created_at":"2018-06-08T07:32:11Z","updated_at":"2018-07-12T11:00:53Z","pushed_at":"2018-07-13T01:27:26Z","git_url":"git://github.com/glennsarti/vscode-powershell.git","ssh_url":"git@github.com:glennsarti/vscode-powershell.git","clone_url":"https://github.com/glennsarti/vscode-powershell.git","svn_url":"https://github.com/glennsarti/vscode-powershell","homepage":"https://marketplace.visualstudio.com/items/ms-vscode.PowerShell","size":1159,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"PowerShell:master","ref":"master","sha":"65245a1f672b22123d8e450c076e4218f6337dfa","user":{"login":"PowerShell","id":11524380,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTI0Mzgw","avatar_url":"https://avatars3.githubusercontent.com/u/11524380?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"repo":{"id":42131201,"node_id":"MDEwOlJlcG9zaXRvcnk0MjEzMTIwMQ==","name":"vscode-powershell","full_name":"PowerShell/vscode-powershell","owner":{"login":"PowerShell","id":11524380,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTI0Mzgw","avatar_url":"https://avatars3.githubusercontent.com/u/11524380?v=4","gravatar_id":"","url":"https://api.github.com/users/PowerShell","html_url":"https://github.com/PowerShell","followers_url":"https://api.github.com/users/PowerShell/followers","following_url":"https://api.github.com/users/PowerShell/following{/other_user}","gists_url":"https://api.github.com/users/PowerShell/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerShell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerShell/subscriptions","organizations_url":"https://api.github.com/users/PowerShell/orgs","repos_url":"https://api.github.com/users/PowerShell/repos","events_url":"https://api.github.com/users/PowerShell/events{/privacy}","received_events_url":"https://api.github.com/users/PowerShell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PowerShell/vscode-powershell","description":"Provides PowerShell language and debugging support for Visual Studio Code","fork":false,"url":"https://api.github.com/repos/PowerShell/vscode-powershell","forks_url":"https://api.github.com/repos/PowerShell/vscode-powershell/forks","keys_url":"https://api.github.com/repos/PowerShell/vscode-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerShell/vscode-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerShell/vscode-powershell/teams","hooks_url":"https://api.github.com/repos/PowerShell/vscode-powershell/hooks","issue_events_url":"https://api.github.com/repos/PowerShell/vscode-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/PowerShell/vscode-powershell/events","assignees_url":"https://api.github.com/repos/PowerShell/vscode-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/PowerShell/vscode-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/PowerShell/vscode-powershell/tags","blobs_url":"https://api.github.com/repos/PowerShell/vscode-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerShell/vscode-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerShell/vscode-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerShell/vscode-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerShell/vscode-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerShell/vscode-powershell/languages","stargazers_url":"https://api.github.com/repos/PowerShell/vscode-powershell/stargazers","contributors_url":"https://api.github.com/repos/PowerShell/vscode-powershell/contributors","subscribers_url":"https://api.github.com/repos/PowerShell/vscode-powershell/subscribers","subscription_url":"https://api.github.com/repos/PowerShell/vscode-powershell/subscription","commits_url":"https://api.github.com/repos/PowerShell/vscode-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerShell/vscode-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerShell/vscode-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerShell/vscode-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerShell/vscode-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/PowerShell/vscode-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerShell/vscode-powershell/merges","archive_url":"https://api.github.com/repos/PowerShell/vscode-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerShell/vscode-powershell/downloads","issues_url":"https://api.github.com/repos/PowerShell/vscode-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/PowerShell/vscode-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerShell/vscode-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerShell/vscode-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerShell/vscode-powershell/labels{/name}","releases_url":"https://api.github.com/repos/PowerShell/vscode-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/PowerShell/vscode-powershell/deployments","created_at":"2015-09-08T18:29:04Z","updated_at":"2018-07-11T17:29:59Z","pushed_at":"2018-07-13T01:27:27Z","git_url":"git://github.com/PowerShell/vscode-powershell.git","ssh_url":"git@github.com:PowerShell/vscode-powershell.git","clone_url":"https://github.com/PowerShell/vscode-powershell.git","svn_url":"https://github.com/PowerShell/vscode-powershell","homepage":"https://marketplace.visualstudio.com/items/ms-vscode.PowerShell","size":1223,"stargazers_count":583,"watchers_count":583,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":168,"mirror_url":null,"archived":false,"open_issues_count":396,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":168,"open_issues":396,"watchers":583,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerShell/vscode-powershell/pulls/1430"},"html":{"href":"https://github.com/PowerShell/vscode-powershell/pull/1430"},"issue":{"href":"https://api.github.com/repos/PowerShell/vscode-powershell/issues/1430"},"comments":{"href":"https://api.github.com/repos/PowerShell/vscode-powershell/issues/1430/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerShell/vscode-powershell/pulls/1430/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerShell/vscode-powershell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerShell/vscode-powershell/pulls/1430/commits"},"statuses":{"href":"https://api.github.com/repos/PowerShell/vscode-powershell/statuses/e5f16cee7d42f7dbb65e28d6a8def33e4985ea01"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"glennsarti"}}