{"action":"created","comment":{"url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/pulls/comments/237524610","pull_request_review_id":179842866,"id":237524610,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzUyNDYxMA==","diff_hunk":"@@ -180,7 +186,7 @@ objects:\n                 key: span-storage-type\n         - image: jaegertracing/jaeger-agent:${IMAGE_VERSION}\n           name: jaeger-agent\n-          args: [\"--collector.host-port=jaeger-collector:14267\"]\n+          args: [\"--reporter.tchannel.host-port=jaeger-collector:14267\"]","path":"production/jaeger-production-template.yml","position":25,"original_position":25,"commit_id":"03f46dc94b2008755e5aa0a6b9c744e709bceab9","original_commit_id":"03f46dc94b2008755e5aa0a6b9c744e709bceab9","user":{"login":"jkandasa","id":1004403,"node_id":"MDQ6VXNlcjEwMDQ0MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1004403?v=4","gravatar_id":"","url":"https://api.github.com/users/jkandasa","html_url":"https://github.com/jkandasa","followers_url":"https://api.github.com/users/jkandasa/followers","following_url":"https://api.github.com/users/jkandasa/following{/other_user}","gists_url":"https://api.github.com/users/jkandasa/gists{/gist_id}","starred_url":"https://api.github.com/users/jkandasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkandasa/subscriptions","organizations_url":"https://api.github.com/users/jkandasa/orgs","repos_url":"https://api.github.com/users/jkandasa/repos","events_url":"https://api.github.com/users/jkandasa/events{/privacy}","received_events_url":"https://api.github.com/users/jkandasa/received_events","type":"User","site_admin":false},"body":"@pavolloffay Sure, I will send a PR","created_at":"2018-11-29T15:09:30Z","updated_at":"2018-11-29T15:09:30Z","html_url":"https://github.com/jaegertracing/jaeger-openshift/pull/99#discussion_r237524610","pull_request_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/pulls/99","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger-openshift/pulls/comments/237524610"},"html":{"href":"https://github.com/jaegertracing/jaeger-openshift/pull/99#discussion_r237524610"},"pull_request":{"href":"https://api.github.com/repos/jaegertracing/jaeger-openshift/pulls/99"}},"in_reply_to_id":237520825},"pull_request":{"url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/pulls/99","id":234576426,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NTc2NDI2","html_url":"https://github.com/jaegertracing/jaeger-openshift/pull/99","diff_url":"https://github.com/jaegertracing/jaeger-openshift/pull/99.diff","patch_url":"https://github.com/jaegertracing/jaeger-openshift/pull/99.patch","issue_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/issues/99","number":99,"state":"closed","locked":false,"title":"Expose jaeger collector gRPC port","user":{"login":"jkandasa","id":1004403,"node_id":"MDQ6VXNlcjEwMDQ0MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1004403?v=4","gravatar_id":"","url":"https://api.github.com/users/jkandasa","html_url":"https://github.com/jkandasa","followers_url":"https://api.github.com/users/jkandasa/followers","following_url":"https://api.github.com/users/jkandasa/following{/other_user}","gists_url":"https://api.github.com/users/jkandasa/gists{/gist_id}","starred_url":"https://api.github.com/users/jkandasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkandasa/subscriptions","organizations_url":"https://api.github.com/users/jkandasa/orgs","repos_url":"https://api.github.com/users/jkandasa/repos","events_url":"https://api.github.com/users/jkandasa/events{/privacy}","received_events_url":"https://api.github.com/users/jkandasa/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Jeeva Kandasamy <jkandasa@redhat.com>\r\n\r\n## Which problem is this PR solving?\r\n- Fixes #98 \r\n- Removed deprecated argument, `collector.host-port` >> `reporter.tchannel.host-port`\r\n","created_at":"2018-11-29T10:07:29Z","updated_at":"2018-11-29T15:09:30Z","closed_at":"2018-11-29T10:25:51Z","merged_at":"2018-11-29T10:25:51Z","merge_commit_sha":"82b6e080b9fc198c22af3b1ba68bc7af65111474","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/pulls/99/commits","review_comments_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/pulls/99/comments","review_comment_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/issues/99/comments","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/statuses/03f46dc94b2008755e5aa0a6b9c744e709bceab9","head":{"label":"jkandasa:grpc-update","ref":"grpc-update","sha":"03f46dc94b2008755e5aa0a6b9c744e709bceab9","user":{"login":"jkandasa","id":1004403,"node_id":"MDQ6VXNlcjEwMDQ0MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1004403?v=4","gravatar_id":"","url":"https://api.github.com/users/jkandasa","html_url":"https://github.com/jkandasa","followers_url":"https://api.github.com/users/jkandasa/followers","following_url":"https://api.github.com/users/jkandasa/following{/other_user}","gists_url":"https://api.github.com/users/jkandasa/gists{/gist_id}","starred_url":"https://api.github.com/users/jkandasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkandasa/subscriptions","organizations_url":"https://api.github.com/users/jkandasa/orgs","repos_url":"https://api.github.com/users/jkandasa/repos","events_url":"https://api.github.com/users/jkandasa/events{/privacy}","received_events_url":"https://api.github.com/users/jkandasa/received_events","type":"User","site_admin":false},"repo":{"id":97218518,"node_id":"MDEwOlJlcG9zaXRvcnk5NzIxODUxOA==","name":"jaeger-openshift","full_name":"jkandasa/jaeger-openshift","private":false,"owner":{"login":"jkandasa","id":1004403,"node_id":"MDQ6VXNlcjEwMDQ0MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1004403?v=4","gravatar_id":"","url":"https://api.github.com/users/jkandasa","html_url":"https://github.com/jkandasa","followers_url":"https://api.github.com/users/jkandasa/followers","following_url":"https://api.github.com/users/jkandasa/following{/other_user}","gists_url":"https://api.github.com/users/jkandasa/gists{/gist_id}","starred_url":"https://api.github.com/users/jkandasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkandasa/subscriptions","organizations_url":"https://api.github.com/users/jkandasa/orgs","repos_url":"https://api.github.com/users/jkandasa/repos","events_url":"https://api.github.com/users/jkandasa/events{/privacy}","received_events_url":"https://api.github.com/users/jkandasa/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jkandasa/jaeger-openshift","description":"Support for deploying Jaeger into OpenShift","fork":true,"url":"https://api.github.com/repos/jkandasa/jaeger-openshift","forks_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/forks","keys_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/teams","hooks_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/hooks","issue_events_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/issues/events{/number}","events_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/events","assignees_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/assignees{/user}","branches_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/branches{/branch}","tags_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/tags","blobs_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/git/refs{/sha}","trees_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/statuses/{sha}","languages_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/languages","stargazers_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/stargazers","contributors_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/contributors","subscribers_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/subscribers","subscription_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/subscription","commits_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/commits{/sha}","git_commits_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/git/commits{/sha}","comments_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/comments{/number}","issue_comment_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/issues/comments{/number}","contents_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/contents/{+path}","compare_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/merges","archive_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/downloads","issues_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/issues{/number}","pulls_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/pulls{/number}","milestones_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/milestones{/number}","notifications_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/labels{/name}","releases_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/releases{/id}","deployments_url":"https://api.github.com/repos/jkandasa/jaeger-openshift/deployments","created_at":"2017-07-14T09:43:06Z","updated_at":"2018-11-29T09:50:44Z","pushed_at":"2018-11-29T14:32:08Z","git_url":"git://github.com/jkandasa/jaeger-openshift.git","ssh_url":"git@github.com:jkandasa/jaeger-openshift.git","clone_url":"https://github.com/jkandasa/jaeger-openshift.git","svn_url":"https://github.com/jkandasa/jaeger-openshift","homepage":"https://github.com/uber/jaeger","size":694,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jaegertracing:master","ref":"master","sha":"dad7d64e7fbbfa8ab2e6b8d5cfcf181694a8f845","user":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"repo":{"id":90716955,"node_id":"MDEwOlJlcG9zaXRvcnk5MDcxNjk1NQ==","name":"jaeger-openshift","full_name":"jaegertracing/jaeger-openshift","private":false,"owner":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jaegertracing/jaeger-openshift","description":"Support for deploying Jaeger into OpenShift","fork":false,"url":"https://api.github.com/repos/jaegertracing/jaeger-openshift","forks_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/forks","keys_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/teams","hooks_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/hooks","issue_events_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/issues/events{/number}","events_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/events","assignees_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/assignees{/user}","branches_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/branches{/branch}","tags_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/tags","blobs_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/statuses/{sha}","languages_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/languages","stargazers_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/stargazers","contributors_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/contributors","subscribers_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/subscribers","subscription_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/subscription","commits_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/contents/{+path}","compare_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/merges","archive_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/downloads","issues_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/issues{/number}","pulls_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/pulls{/number}","milestones_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/milestones{/number}","notifications_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/labels{/name}","releases_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/releases{/id}","deployments_url":"https://api.github.com/repos/jaegertracing/jaeger-openshift/deployments","created_at":"2017-05-09T07:41:04Z","updated_at":"2018-11-29T10:25:53Z","pushed_at":"2018-11-29T10:25:51Z","git_url":"git://github.com/jaegertracing/jaeger-openshift.git","ssh_url":"git@github.com:jaegertracing/jaeger-openshift.git","clone_url":"https://github.com/jaegertracing/jaeger-openshift.git","svn_url":"https://github.com/jaegertracing/jaeger-openshift","homepage":"https://jaegertracing.io/","size":696,"stargazers_count":35,"watchers_count":35,"language":"Groovy","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":10,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger-openshift/pulls/99"},"html":{"href":"https://github.com/jaegertracing/jaeger-openshift/pull/99"},"issue":{"href":"https://api.github.com/repos/jaegertracing/jaeger-openshift/issues/99"},"comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger-openshift/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger-openshift/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/jaegertracing/jaeger-openshift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jaegertracing/jaeger-openshift/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/jaegertracing/jaeger-openshift/statuses/03f46dc94b2008755e5aa0a6b9c744e709bceab9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jkandasa"}}