{"action":"created","comment":{"url":"https://api.github.com/repos/fossasia/open-event-webapp/pulls/comments/200004151","pull_request_review_id":134232688,"id":200004151,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDAwNDE1MQ==","diff_hunk":"@@ -112,8 +112,49 @@ const loadVideoAndSlides = function(div, videoURL, slideURL) {\n   }\n };\n \n-window.handleClientLoad = handleClientLoad;\n-window.initClient = initClient;\n-window.handleAuthClick = handleAuthClick;\n-window.listUpcomingEvents = listUpcomingEvents;\n-window.loadVideoAndSlides = loadVideoAndSlides;\n+$(document).ready(function () {\n+  let filter;\n+  //store room filters\n+  let room ={\n+    dateFilter:'.date-filter'\n+  };\n+  //store track filters\n+  let track ={\n+    dateFilter:'.date-filter'\n+  };\n+  //store schedule filters\n+  let schedule={\n+    dateFilter:'.day-filter'\n+  };\n+\n+  const noResult=function(filterType,calendarMode) {\n+    filter=eval(filterType);\n+    var search=false;\n+    $('.fossasia-filter').each(function() {\n+      if($(this).is(':visible') && $(this).val().length!==0) {\n+        search=true;\n+      }\n+    });\n+    var listFilterLength =$(filter.dateFilter+':visible').length;\n+    var calendarFilterLength = $('.room:visible').length;\n+    if((calendarMode && calendarFilterLength == false) || (!calendarMode && listFilterLength == false)) {\n+      $('#no-results').remove();\n+      if(search) {\n+        $('.date-list').after(\"<p style = 'padding-left: 15px; margin-top: 15px; font-weight: bold; color: red' id='no-results'>No matching results found.</p>\");\n+      } else {\n+        $('.date-list').after(\"<p style = 'padding-left: 15px; margin-top: 15px; font-weight: bold; color: red' id='no-results'>No result found.</p>\");\n+        }","path":"src/backend/assets/js/main.js","position":83,"original_position":83,"commit_id":"8d807d1f38cdcbfe72cfee1cb425620a0a1958b9","original_commit_id":"8d807d1f38cdcbfe72cfee1cb425620a0a1958b9","user":{"login":"joeytwiddle","id":911799,"node_id":"MDQ6VXNlcjkxMTc5OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/911799?v=4","gravatar_id":"","url":"https://api.github.com/users/joeytwiddle","html_url":"https://github.com/joeytwiddle","followers_url":"https://api.github.com/users/joeytwiddle/followers","following_url":"https://api.github.com/users/joeytwiddle/following{/other_user}","gists_url":"https://api.github.com/users/joeytwiddle/gists{/gist_id}","starred_url":"https://api.github.com/users/joeytwiddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeytwiddle/subscriptions","organizations_url":"https://api.github.com/users/joeytwiddle/orgs","repos_url":"https://api.github.com/users/joeytwiddle/repos","events_url":"https://api.github.com/users/joeytwiddle/events{/privacy}","received_events_url":"https://api.github.com/users/joeytwiddle/received_events","type":"User","site_admin":false},"body":"If you want to minimize this:\r\n```js\r\nconst message = search ? 'No matching results found.' : 'No result found.';\r\n$('.date-list').after(\"<p style='padding-left: 15px; margin-top: 15px; font-weight: bold; color: red' id='no-results'>\" + message + \"</p>\");\r\n```\r\n\r\n(Although I'm not sure if two different messages are really needed anyway. They are almost the same!)","created_at":"2018-07-04T04:12:53Z","updated_at":"2018-07-04T04:12:53Z","html_url":"https://github.com/fossasia/open-event-webapp/pull/1982#discussion_r200004151","pull_request_url":"https://api.github.com/repos/fossasia/open-event-webapp/pulls/1982","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fossasia/open-event-webapp/pulls/comments/200004151"},"html":{"href":"https://github.com/fossasia/open-event-webapp/pull/1982#discussion_r200004151"},"pull_request":{"href":"https://api.github.com/repos/fossasia/open-event-webapp/pulls/1982"}}},"pull_request":{"url":"https://api.github.com/repos/fossasia/open-event-webapp/pulls/1982","id":198492337,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NDkyMzM3","html_url":"https://github.com/fossasia/open-event-webapp/pull/1982","diff_url":"https://github.com/fossasia/open-event-webapp/pull/1982.diff","patch_url":"https://github.com/fossasia/open-event-webapp/pull/1982.patch","issue_url":"https://api.github.com/repos/fossasia/open-event-webapp/issues/1982","number":1982,"state":"open","locked":false,"title":"code minimize","user":{"login":"shubham3211","id":19900978,"node_id":"MDQ6VXNlcjE5OTAwOTc4","avatar_url":"https://avatars2.githubusercontent.com/u/19900978?v=4","gravatar_id":"","url":"https://api.github.com/users/shubham3211","html_url":"https://github.com/shubham3211","followers_url":"https://api.github.com/users/shubham3211/followers","following_url":"https://api.github.com/users/shubham3211/following{/other_user}","gists_url":"https://api.github.com/users/shubham3211/gists{/gist_id}","starred_url":"https://api.github.com/users/shubham3211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shubham3211/subscriptions","organizations_url":"https://api.github.com/users/shubham3211/orgs","repos_url":"https://api.github.com/users/shubham3211/repos","events_url":"https://api.github.com/users/shubham3211/events{/privacy}","received_events_url":"https://api.github.com/users/shubham3211/received_events","type":"User","site_admin":false},"body":"Partial Fixes #1881 \r\nSample:-https://shubham3211.github.io/calendar-fix/index.html","created_at":"2018-06-30T20:09:42Z","updated_at":"2018-07-04T04:12:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"905714be0b87def2bcd6caec05b845ae36862eaa","assignee":{"login":"shubham3211","id":19900978,"node_id":"MDQ6VXNlcjE5OTAwOTc4","avatar_url":"https://avatars2.githubusercontent.com/u/19900978?v=4","gravatar_id":"","url":"https://api.github.com/users/shubham3211","html_url":"https://github.com/shubham3211","followers_url":"https://api.github.com/users/shubham3211/followers","following_url":"https://api.github.com/users/shubham3211/following{/other_user}","gists_url":"https://api.github.com/users/shubham3211/gists{/gist_id}","starred_url":"https://api.github.com/users/shubham3211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shubham3211/subscriptions","organizations_url":"https://api.github.com/users/shubham3211/orgs","repos_url":"https://api.github.com/users/shubham3211/repos","events_url":"https://api.github.com/users/shubham3211/events{/privacy}","received_events_url":"https://api.github.com/users/shubham3211/received_events","type":"User","site_admin":false},"assignees":[{"login":"shubham3211","id":19900978,"node_id":"MDQ6VXNlcjE5OTAwOTc4","avatar_url":"https://avatars2.githubusercontent.com/u/19900978?v=4","gravatar_id":"","url":"https://api.github.com/users/shubham3211","html_url":"https://github.com/shubham3211","followers_url":"https://api.github.com/users/shubham3211/followers","following_url":"https://api.github.com/users/shubham3211/following{/other_user}","gists_url":"https://api.github.com/users/shubham3211/gists{/gist_id}","starred_url":"https://api.github.com/users/shubham3211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shubham3211/subscriptions","organizations_url":"https://api.github.com/users/shubham3211/orgs","repos_url":"https://api.github.com/users/shubham3211/repos","events_url":"https://api.github.com/users/shubham3211/events{/privacy}","received_events_url":"https://api.github.com/users/shubham3211/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fossasia/open-event-webapp/pulls/1982/commits","review_comments_url":"https://api.github.com/repos/fossasia/open-event-webapp/pulls/1982/comments","review_comment_url":"https://api.github.com/repos/fossasia/open-event-webapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fossasia/open-event-webapp/issues/1982/comments","statuses_url":"https://api.github.com/repos/fossasia/open-event-webapp/statuses/8d807d1f38cdcbfe72cfee1cb425620a0a1958b9","head":{"label":"shubham3211:development","ref":"development","sha":"8d807d1f38cdcbfe72cfee1cb425620a0a1958b9","user":{"login":"shubham3211","id":19900978,"node_id":"MDQ6VXNlcjE5OTAwOTc4","avatar_url":"https://avatars2.githubusercontent.com/u/19900978?v=4","gravatar_id":"","url":"https://api.github.com/users/shubham3211","html_url":"https://github.com/shubham3211","followers_url":"https://api.github.com/users/shubham3211/followers","following_url":"https://api.github.com/users/shubham3211/following{/other_user}","gists_url":"https://api.github.com/users/shubham3211/gists{/gist_id}","starred_url":"https://api.github.com/users/shubham3211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shubham3211/subscriptions","organizations_url":"https://api.github.com/users/shubham3211/orgs","repos_url":"https://api.github.com/users/shubham3211/repos","events_url":"https://api.github.com/users/shubham3211/events{/privacy}","received_events_url":"https://api.github.com/users/shubham3211/received_events","type":"User","site_admin":false},"repo":{"id":138959149,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg5NTkxNDk=","name":"open-event-webapp","full_name":"shubham3211/open-event-webapp","owner":{"login":"shubham3211","id":19900978,"node_id":"MDQ6VXNlcjE5OTAwOTc4","avatar_url":"https://avatars2.githubusercontent.com/u/19900978?v=4","gravatar_id":"","url":"https://api.github.com/users/shubham3211","html_url":"https://github.com/shubham3211","followers_url":"https://api.github.com/users/shubham3211/followers","following_url":"https://api.github.com/users/shubham3211/following{/other_user}","gists_url":"https://api.github.com/users/shubham3211/gists{/gist_id}","starred_url":"https://api.github.com/users/shubham3211/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shubham3211/subscriptions","organizations_url":"https://api.github.com/users/shubham3211/orgs","repos_url":"https://api.github.com/users/shubham3211/repos","events_url":"https://api.github.com/users/shubham3211/events{/privacy}","received_events_url":"https://api.github.com/users/shubham3211/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shubham3211/open-event-webapp","description":"Open Event Web App Generator http://opev-webgen-dev.herokuapp.com http://sched.eventyay.com","fork":true,"url":"https://api.github.com/repos/shubham3211/open-event-webapp","forks_url":"https://api.github.com/repos/shubham3211/open-event-webapp/forks","keys_url":"https://api.github.com/repos/shubham3211/open-event-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shubham3211/open-event-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shubham3211/open-event-webapp/teams","hooks_url":"https://api.github.com/repos/shubham3211/open-event-webapp/hooks","issue_events_url":"https://api.github.com/repos/shubham3211/open-event-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/shubham3211/open-event-webapp/events","assignees_url":"https://api.github.com/repos/shubham3211/open-event-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/shubham3211/open-event-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/shubham3211/open-event-webapp/tags","blobs_url":"https://api.github.com/repos/shubham3211/open-event-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shubham3211/open-event-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shubham3211/open-event-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/shubham3211/open-event-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shubham3211/open-event-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/shubham3211/open-event-webapp/languages","stargazers_url":"https://api.github.com/repos/shubham3211/open-event-webapp/stargazers","contributors_url":"https://api.github.com/repos/shubham3211/open-event-webapp/contributors","subscribers_url":"https://api.github.com/repos/shubham3211/open-event-webapp/subscribers","subscription_url":"https://api.github.com/repos/shubham3211/open-event-webapp/subscription","commits_url":"https://api.github.com/repos/shubham3211/open-event-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/shubham3211/open-event-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/shubham3211/open-event-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/shubham3211/open-event-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/shubham3211/open-event-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/shubham3211/open-event-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shubham3211/open-event-webapp/merges","archive_url":"https://api.github.com/repos/shubham3211/open-event-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shubham3211/open-event-webapp/downloads","issues_url":"https://api.github.com/repos/shubham3211/open-event-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/shubham3211/open-event-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/shubham3211/open-event-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/shubham3211/open-event-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shubham3211/open-event-webapp/labels{/name}","releases_url":"https://api.github.com/repos/shubham3211/open-event-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/shubham3211/open-event-webapp/deployments","created_at":"2018-06-28T03:00:48Z","updated_at":"2018-07-03T19:47:35Z","pushed_at":"2018-07-03T22:05:45Z","git_url":"git://github.com/shubham3211/open-event-webapp.git","ssh_url":"git@github.com:shubham3211/open-event-webapp.git","clone_url":"https://github.com/shubham3211/open-event-webapp.git","svn_url":"https://github.com/shubham3211/open-event-webapp","homepage":"","size":381637,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"fossasia:development","ref":"development","sha":"662f64be39e9cbfac78f154aebd16e68c4038521","user":{"login":"fossasia","id":6295529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyOTU1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/6295529?v=4","gravatar_id":"","url":"https://api.github.com/users/fossasia","html_url":"https://github.com/fossasia","followers_url":"https://api.github.com/users/fossasia/followers","following_url":"https://api.github.com/users/fossasia/following{/other_user}","gists_url":"https://api.github.com/users/fossasia/gists{/gist_id}","starred_url":"https://api.github.com/users/fossasia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossasia/subscriptions","organizations_url":"https://api.github.com/users/fossasia/orgs","repos_url":"https://api.github.com/users/fossasia/repos","events_url":"https://api.github.com/users/fossasia/events{/privacy}","received_events_url":"https://api.github.com/users/fossasia/received_events","type":"Organization","site_admin":false},"repo":{"id":35269905,"node_id":"MDEwOlJlcG9zaXRvcnkzNTI2OTkwNQ==","name":"open-event-webapp","full_name":"fossasia/open-event-webapp","owner":{"login":"fossasia","id":6295529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyOTU1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/6295529?v=4","gravatar_id":"","url":"https://api.github.com/users/fossasia","html_url":"https://github.com/fossasia","followers_url":"https://api.github.com/users/fossasia/followers","following_url":"https://api.github.com/users/fossasia/following{/other_user}","gists_url":"https://api.github.com/users/fossasia/gists{/gist_id}","starred_url":"https://api.github.com/users/fossasia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossasia/subscriptions","organizations_url":"https://api.github.com/users/fossasia/orgs","repos_url":"https://api.github.com/users/fossasia/repos","events_url":"https://api.github.com/users/fossasia/events{/privacy}","received_events_url":"https://api.github.com/users/fossasia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fossasia/open-event-webapp","description":"Open Event Web App Generator http://opev-webgen-dev.herokuapp.com http://sched.eventyay.com","fork":false,"url":"https://api.github.com/repos/fossasia/open-event-webapp","forks_url":"https://api.github.com/repos/fossasia/open-event-webapp/forks","keys_url":"https://api.github.com/repos/fossasia/open-event-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fossasia/open-event-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fossasia/open-event-webapp/teams","hooks_url":"https://api.github.com/repos/fossasia/open-event-webapp/hooks","issue_events_url":"https://api.github.com/repos/fossasia/open-event-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/fossasia/open-event-webapp/events","assignees_url":"https://api.github.com/repos/fossasia/open-event-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/fossasia/open-event-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/fossasia/open-event-webapp/tags","blobs_url":"https://api.github.com/repos/fossasia/open-event-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fossasia/open-event-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fossasia/open-event-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/fossasia/open-event-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fossasia/open-event-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/fossasia/open-event-webapp/languages","stargazers_url":"https://api.github.com/repos/fossasia/open-event-webapp/stargazers","contributors_url":"https://api.github.com/repos/fossasia/open-event-webapp/contributors","subscribers_url":"https://api.github.com/repos/fossasia/open-event-webapp/subscribers","subscription_url":"https://api.github.com/repos/fossasia/open-event-webapp/subscription","commits_url":"https://api.github.com/repos/fossasia/open-event-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/fossasia/open-event-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/fossasia/open-event-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/fossasia/open-event-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/fossasia/open-event-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/fossasia/open-event-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fossasia/open-event-webapp/merges","archive_url":"https://api.github.com/repos/fossasia/open-event-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fossasia/open-event-webapp/downloads","issues_url":"https://api.github.com/repos/fossasia/open-event-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/fossasia/open-event-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/fossasia/open-event-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/fossasia/open-event-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fossasia/open-event-webapp/labels{/name}","releases_url":"https://api.github.com/repos/fossasia/open-event-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/fossasia/open-event-webapp/deployments","created_at":"2015-05-08T09:11:00Z","updated_at":"2018-07-04T03:44:14Z","pushed_at":"2018-07-04T03:54:46Z","git_url":"git://github.com/fossasia/open-event-webapp.git","ssh_url":"git@github.com:fossasia/open-event-webapp.git","clone_url":"https://github.com/fossasia/open-event-webapp.git","svn_url":"https://github.com/fossasia/open-event-webapp","homepage":"","size":395744,"stargazers_count":800,"watchers_count":800,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":773,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":773,"open_issues":13,"watchers":800,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/fossasia/open-event-webapp/pulls/1982"},"html":{"href":"https://github.com/fossasia/open-event-webapp/pull/1982"},"issue":{"href":"https://api.github.com/repos/fossasia/open-event-webapp/issues/1982"},"comments":{"href":"https://api.github.com/repos/fossasia/open-event-webapp/issues/1982/comments"},"review_comments":{"href":"https://api.github.com/repos/fossasia/open-event-webapp/pulls/1982/comments"},"review_comment":{"href":"https://api.github.com/repos/fossasia/open-event-webapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fossasia/open-event-webapp/pulls/1982/commits"},"statuses":{"href":"https://api.github.com/repos/fossasia/open-event-webapp/statuses/8d807d1f38cdcbfe72cfee1cb425620a0a1958b9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"joeytwiddle"}}