{"action":"created","issue":{"url":"https://api.github.com/repos/flexible-collision-library/fcl/issues/264","repository_url":"https://api.github.com/repos/flexible-collision-library/fcl","labels_url":"https://api.github.com/repos/flexible-collision-library/fcl/issues/264/labels{/name}","comments_url":"https://api.github.com/repos/flexible-collision-library/fcl/issues/264/comments","events_url":"https://api.github.com/repos/flexible-collision-library/fcl/issues/264/events","html_url":"https://github.com/flexible-collision-library/fcl/pull/264","id":303915545,"number":264,"title":"Replace non-portable M_PI reference with fcl::constants invocation","user":{"login":"SeanCurtis-TRI","id":22159799,"avatar_url":"https://avatars3.githubusercontent.com/u/22159799?v=4","gravatar_id":"","url":"https://api.github.com/users/SeanCurtis-TRI","html_url":"https://github.com/SeanCurtis-TRI","followers_url":"https://api.github.com/users/SeanCurtis-TRI/followers","following_url":"https://api.github.com/users/SeanCurtis-TRI/following{/other_user}","gists_url":"https://api.github.com/users/SeanCurtis-TRI/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanCurtis-TRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanCurtis-TRI/subscriptions","organizations_url":"https://api.github.com/users/SeanCurtis-TRI/orgs","repos_url":"https://api.github.com/users/SeanCurtis-TRI/repos","events_url":"https://api.github.com/users/SeanCurtis-TRI/events{/privacy}","received_events_url":"https://api.github.com/users/SeanCurtis-TRI/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-09T17:17:37Z","updated_at":"2018-03-09T19:43:13Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/flexible-collision-library/fcl/pulls/264","html_url":"https://github.com/flexible-collision-library/fcl/pull/264","diff_url":"https://github.com/flexible-collision-library/fcl/pull/264.diff","patch_url":"https://github.com/flexible-collision-library/fcl/pull/264.patch"},"body":"There is a non-portable reference to M_PI in a test. This changes it to the fcl-standard constants reference to maintain portability.\r\n\r\n(It also shuffles up the includes in the test to be more \"standard\".)\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/flexible-collision-library/fcl/264)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/flexible-collision-library/fcl/issues/comments/371924963","html_url":"https://github.com/flexible-collision-library/fcl/pull/264#issuecomment-371924963","issue_url":"https://api.github.com/repos/flexible-collision-library/fcl/issues/264","id":371924963,"user":{"login":"SeanCurtis-TRI","id":22159799,"avatar_url":"https://avatars3.githubusercontent.com/u/22159799?v=4","gravatar_id":"","url":"https://api.github.com/users/SeanCurtis-TRI","html_url":"https://github.com/SeanCurtis-TRI","followers_url":"https://api.github.com/users/SeanCurtis-TRI/followers","following_url":"https://api.github.com/users/SeanCurtis-TRI/following{/other_user}","gists_url":"https://api.github.com/users/SeanCurtis-TRI/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanCurtis-TRI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanCurtis-TRI/subscriptions","organizations_url":"https://api.github.com/users/SeanCurtis-TRI/orgs","repos_url":"https://api.github.com/users/SeanCurtis-TRI/repos","events_url":"https://api.github.com/users/SeanCurtis-TRI/events{/privacy}","received_events_url":"https://api.github.com/users/SeanCurtis-TRI/received_events","type":"User","site_admin":false},"created_at":"2018-03-09T19:43:13Z","updated_at":"2018-03-09T19:43:13Z","author_association":"CONTRIBUTOR","body":"The Debug failure is the same we've seen before (box-capsule test via ccd). However, the mac release has unexpected errors. Apparently #259 introduced functionality that fails in the mac release mode; these failures were masked by the box-capsule failures). In this PR, I recognized these failures.\n\nThe failure is independent of this PR. I've added an issue for the CI failures: #265.\n\n---\n\nReview status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.\n\n---\n\n\n\n*Comments from [Reviewable](https://beta.reviewable.io/reviews/flexible-collision-library/fcl/264#-:-L7BGkGy9o2rabKJOBxa:b-9ya04v)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"SeanCurtis-TRI"}}