{"action":"created","issue":{"url":"https://api.github.com/repos/szeged/webrender/issues/162","repository_url":"https://api.github.com/repos/szeged/webrender","labels_url":"https://api.github.com/repos/szeged/webrender/issues/162/labels{/name}","comments_url":"https://api.github.com/repos/szeged/webrender/issues/162/comments","events_url":"https://api.github.com/repos/szeged/webrender/issues/162/events","html_url":"https://github.com/szeged/webrender/pull/162","id":319903166,"number":162,"title":"Restore DebugRenderer [WIP]","user":{"login":"zakorgy","id":11725775,"avatar_url":"https://avatars2.githubusercontent.com/u/11725775?v=4","gravatar_id":"","url":"https://api.github.com/users/zakorgy","html_url":"https://github.com/zakorgy","followers_url":"https://api.github.com/users/zakorgy/followers","following_url":"https://api.github.com/users/zakorgy/following{/other_user}","gists_url":"https://api.github.com/users/zakorgy/gists{/gist_id}","starred_url":"https://api.github.com/users/zakorgy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zakorgy/subscriptions","organizations_url":"https://api.github.com/users/zakorgy/orgs","repos_url":"https://api.github.com/users/zakorgy/repos","events_url":"https://api.github.com/users/zakorgy/events{/privacy}","received_events_url":"https://api.github.com/users/zakorgy/received_events","type":"User","site_admin":false},"labels":[{"id":562172170,"url":"https://api.github.com/repos/szeged/webrender/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-03T12:39:35Z","updated_at":"2018-05-03T12:56:06Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/szeged/webrender/pulls/162","html_url":"https://github.com/szeged/webrender/pull/162","diff_url":"https://github.com/szeged/webrender/pull/162.diff","patch_url":"https://github.com/szeged/webrender/pull/162.patch"},"body":"Fixes the third part of #150: restore DebugRenderer.\r\nAdded `DebugColor` and `DebugFont` shader kinds. These shaders are handled differently when creating programs, because they need index and vertex buffers with relative large [sizes](https://github.com/szeged/webrender/compare/master...zakorgy:restore-debug-renderer#diff-d058594280164bb23d9b1ca25ba9fe79R36) (these are the maximum values I got from upstream WebRender), and just one pipeline.\r\nAlso replaced `draw` with `draw_indexed` to support drawing with these shaders.\r\n\r\nAt the moment the `DebugRenderer` draws, but after we reach a certain number of indices/vertices the following vulkan validation layer error shows up:\r\n`2018-05-03T12:24:58Z: gfx_backend_vulkan: [MEM] Object: 0x1779beb3980 | Number of currently valid memory objects is not less than the maximum allowed (4096).`\r\nI'm not sure if this is caused by the high number of vertices/indices, or I missed something in the implementation.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/szeged/webrender/issues/comments/386285970","html_url":"https://github.com/szeged/webrender/pull/162#issuecomment-386285970","issue_url":"https://api.github.com/repos/szeged/webrender/issues/162","id":386285970,"user":{"login":"zakorgy","id":11725775,"avatar_url":"https://avatars2.githubusercontent.com/u/11725775?v=4","gravatar_id":"","url":"https://api.github.com/users/zakorgy","html_url":"https://github.com/zakorgy","followers_url":"https://api.github.com/users/zakorgy/followers","following_url":"https://api.github.com/users/zakorgy/following{/other_user}","gists_url":"https://api.github.com/users/zakorgy/gists{/gist_id}","starred_url":"https://api.github.com/users/zakorgy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zakorgy/subscriptions","organizations_url":"https://api.github.com/users/zakorgy/orgs","repos_url":"https://api.github.com/users/zakorgy/repos","events_url":"https://api.github.com/users/zakorgy/events{/privacy}","received_events_url":"https://api.github.com/users/zakorgy/received_events","type":"User","site_admin":false},"created_at":"2018-05-03T12:56:06Z","updated_at":"2018-05-03T12:56:06Z","author_association":"NONE","body":"Here is an image from the DebugRenderer with the current code:\r\n![debug_renderer](https://user-images.githubusercontent.com/11725775/39577334-5ea8a8cc-4ee1-11e8-8142-9c27483d0b48.PNG)\r\n"}}
{"actor":{"display_login":"zakorgy"}}