{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11342","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11342/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11342/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11342/events","html_url":"https://github.com/bitcoin/bitcoin/pull/11342","id":258076998,"node_id":"MDExOlB1bGxSZXF1ZXN0MTQxMzM3MzU1","number":11342,"title":"Sanity assert GetAncestor() != nullptr where appropriate","user":{"login":"danra","id":84245,"node_id":"MDQ6VXNlcjg0MjQ1","avatar_url":"https://avatars3.githubusercontent.com/u/84245?v=4","gravatar_id":"","url":"https://api.github.com/users/danra","html_url":"https://github.com/danra","followers_url":"https://api.github.com/users/danra/followers","following_url":"https://api.github.com/users/danra/following{/other_user}","gists_url":"https://api.github.com/users/danra/gists{/gist_id}","starred_url":"https://api.github.com/users/danra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danra/subscriptions","organizations_url":"https://api.github.com/users/danra/orgs","repos_url":"https://api.github.com/users/danra/repos","events_url":"https://api.github.com/users/danra/events{/privacy}","received_events_url":"https://api.github.com/users/danra/received_events","type":"User","site_admin":false},"labels":[{"id":955867938,"node_id":"MDU6TGFiZWw5NTU4Njc5Mzg=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Needs%20rebase","name":"Needs rebase","color":"cccccc","default":false},{"id":749416508,"node_id":"MDU6TGFiZWw3NDk0MTY1MDg=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Up%20for%20grabs","name":"Up for grabs","color":"99a810","default":false},{"id":118379652,"node_id":"MDU6TGFiZWwxMTgzNzk2NTI=","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Validation","name":"Validation","color":"6060aa","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-09-15T15:21:47Z","updated_at":"2018-08-31T12:29:29Z","closed_at":"2018-08-31T12:29:29Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11342","html_url":"https://github.com/bitcoin/bitcoin/pull/11342","diff_url":"https://github.com/bitcoin/bitcoin/pull/11342.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/11342.patch"},"body":"Add sanity asserts for return value of `CBlockIndex::GetAncestor()` where appropriate.\r\n\r\nIn validation.cpp `CheckSequenceLocks`, check the return value of `tip->GetAncestor(maxInputHeight)` stored into `lp->maxInputBlock`. If it ever returns `nullptr` because the ancestor isn't found, it's going to be a bad bug to keep going, since a `LockPoints` object with the `maxInputBlock` member set to `nullptr` signifies no relative lock time.\r\n\r\nIn the other places, the added asserts would prevent accidental dereferencing of a null pointer which is UB."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/417648949","html_url":"https://github.com/bitcoin/bitcoin/pull/11342#issuecomment-417648949","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11342","id":417648949,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzY0ODk0OQ==","user":{"login":"laanwj","id":126646,"node_id":"MDQ6VXNlcjEyNjY0Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/126646?v=4","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"created_at":"2018-08-31T12:29:29Z","updated_at":"2018-08-31T12:29:29Z","author_association":"MEMBER","body":"Closing because of inactivity, see that @MarcoFalke already added up for grabs"}}
{"actor":{"display_login":"laanwj"}}