{"action":"created","comment":{"url":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/comments/217133468","pull_request_review_id":154743300,"id":217133468,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzEzMzQ2OA==","diff_hunk":"@@ -1340,6 +1340,60 @@ object DataFixture {\n     }\n   }\n \n+  def removeExistingTrafficSignsDuplicates(): Unit = {\n+    println(\"\\nStarting removing of traffic signs duplicates\")\n+    println(DateTime.now())\n+\n+    //Get All Municipalities\n+    val municipalities: Seq[Int] =\n+      OracleDatabase.withDynSession {\n+        Queries.getMunicipalities\n+      }\n+\n+    municipalities.foreach { municipality =>\n+      println(\"\")\n+      println(s\"Fetching Traffic Signs for Municipality: $municipality\")\n+\n+      val existingAssets = trafficSignService.getByMunicipality(municipality)\n+      println(\"\")\n+      println(s\"Number of existing assets: ${existingAssets.length}\")\n+      println(\"\")\n+\n+      existingAssets.foreach {\n+        asset =>\n+          println(s\"Analyzing Traffic Sign with => Id: ${asset.id}, LinkID: ${asset.linkId}\")\n+\n+          val signType = asset.propertyData.find(_.publicId == trafficSignService.typePublicId).get.values.head.propertyValue.toInt","path":"digiroad2-oracle/src/test/scala/fi/liikennevirasto/digiroad2/util/DataFixture.scala","position":36,"original_position":36,"commit_id":"3646761653d5636b24173c339ef99e3d14a41736","original_commit_id":"3646761653d5636b24173c339ef99e3d14a41736","user":{"login":"MAC-CGI","id":22151972,"node_id":"MDQ6VXNlcjIyMTUxOTcy","avatar_url":"https://avatars2.githubusercontent.com/u/22151972?v=4","gravatar_id":"","url":"https://api.github.com/users/MAC-CGI","html_url":"https://github.com/MAC-CGI","followers_url":"https://api.github.com/users/MAC-CGI/followers","following_url":"https://api.github.com/users/MAC-CGI/following{/other_user}","gists_url":"https://api.github.com/users/MAC-CGI/gists{/gist_id}","starred_url":"https://api.github.com/users/MAC-CGI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MAC-CGI/subscriptions","organizations_url":"https://api.github.com/users/MAC-CGI/orgs","repos_url":"https://api.github.com/users/MAC-CGI/repos","events_url":"https://api.github.com/users/MAC-CGI/events{/privacy}","received_events_url":"https://api.github.com/users/MAC-CGI/received_events","type":"User","site_admin":false},"body":"Could be replace getTrafficSignsProperties(asset, \"trafficSigns_type\")","created_at":"2018-09-12T18:04:33Z","updated_at":"2018-09-12T18:04:43Z","html_url":"https://github.com/finnishtransportagency/digiroad2/pull/1257#discussion_r217133468","pull_request_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/1257","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/comments/217133468"},"html":{"href":"https://github.com/finnishtransportagency/digiroad2/pull/1257#discussion_r217133468"},"pull_request":{"href":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/1257"}}},"pull_request":{"url":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/1257","id":212001442,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMDAxNDQy","html_url":"https://github.com/finnishtransportagency/digiroad2/pull/1257","diff_url":"https://github.com/finnishtransportagency/digiroad2/pull/1257.diff","patch_url":"https://github.com/finnishtransportagency/digiroad2/pull/1257.patch","issue_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/issues/1257","number":1257,"state":"open","locked":false,"title":"Droth 1486 modification for csv import","user":{"login":"oskarmalmstrom","id":19705734,"node_id":"MDQ6VXNlcjE5NzA1NzM0","avatar_url":"https://avatars3.githubusercontent.com/u/19705734?v=4","gravatar_id":"","url":"https://api.github.com/users/oskarmalmstrom","html_url":"https://github.com/oskarmalmstrom","followers_url":"https://api.github.com/users/oskarmalmstrom/followers","following_url":"https://api.github.com/users/oskarmalmstrom/following{/other_user}","gists_url":"https://api.github.com/users/oskarmalmstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/oskarmalmstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oskarmalmstrom/subscriptions","organizations_url":"https://api.github.com/users/oskarmalmstrom/orgs","repos_url":"https://api.github.com/users/oskarmalmstrom/repos","events_url":"https://api.github.com/users/oskarmalmstrom/events{/privacy}","received_events_url":"https://api.github.com/users/oskarmalmstrom/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-30T08:47:52Z","updated_at":"2018-09-12T18:04:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/1257/commits","review_comments_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/1257/comments","review_comment_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/issues/1257/comments","statuses_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/statuses/3646761653d5636b24173c339ef99e3d14a41736","head":{"label":"finnishtransportagency:DROTH-1486_modification_for_csv-import","ref":"DROTH-1486_modification_for_csv-import","sha":"3646761653d5636b24173c339ef99e3d14a41736","user":{"login":"finnishtransportagency","id":5737015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MzcwMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/5737015?v=4","gravatar_id":"","url":"https://api.github.com/users/finnishtransportagency","html_url":"https://github.com/finnishtransportagency","followers_url":"https://api.github.com/users/finnishtransportagency/followers","following_url":"https://api.github.com/users/finnishtransportagency/following{/other_user}","gists_url":"https://api.github.com/users/finnishtransportagency/gists{/gist_id}","starred_url":"https://api.github.com/users/finnishtransportagency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finnishtransportagency/subscriptions","organizations_url":"https://api.github.com/users/finnishtransportagency/orgs","repos_url":"https://api.github.com/users/finnishtransportagency/repos","events_url":"https://api.github.com/users/finnishtransportagency/events{/privacy}","received_events_url":"https://api.github.com/users/finnishtransportagency/received_events","type":"Organization","site_admin":false},"repo":{"id":13739672,"node_id":"MDEwOlJlcG9zaXRvcnkxMzczOTY3Mg==","name":"digiroad2","full_name":"finnishtransportagency/digiroad2","owner":{"login":"finnishtransportagency","id":5737015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MzcwMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/5737015?v=4","gravatar_id":"","url":"https://api.github.com/users/finnishtransportagency","html_url":"https://github.com/finnishtransportagency","followers_url":"https://api.github.com/users/finnishtransportagency/followers","following_url":"https://api.github.com/users/finnishtransportagency/following{/other_user}","gists_url":"https://api.github.com/users/finnishtransportagency/gists{/gist_id}","starred_url":"https://api.github.com/users/finnishtransportagency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finnishtransportagency/subscriptions","organizations_url":"https://api.github.com/users/finnishtransportagency/orgs","repos_url":"https://api.github.com/users/finnishtransportagency/repos","events_url":"https://api.github.com/users/finnishtransportagency/events{/privacy}","received_events_url":"https://api.github.com/users/finnishtransportagency/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/finnishtransportagency/digiroad2","description":"Digiroad 2 development","fork":false,"url":"https://api.github.com/repos/finnishtransportagency/digiroad2","forks_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/forks","keys_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/teams","hooks_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/hooks","issue_events_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/issues/events{/number}","events_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/events","assignees_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/assignees{/user}","branches_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/branches{/branch}","tags_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/tags","blobs_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/git/refs{/sha}","trees_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/statuses/{sha}","languages_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/languages","stargazers_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/stargazers","contributors_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/contributors","subscribers_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/subscribers","subscription_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/subscription","commits_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/commits{/sha}","git_commits_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/git/commits{/sha}","comments_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/comments{/number}","issue_comment_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/issues/comments{/number}","contents_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/contents/{+path}","compare_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/merges","archive_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/downloads","issues_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/issues{/number}","pulls_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls{/number}","milestones_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/milestones{/number}","notifications_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/labels{/name}","releases_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/releases{/id}","deployments_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/deployments","created_at":"2013-10-21T10:47:36Z","updated_at":"2018-09-11T15:48:12Z","pushed_at":"2018-09-12T16:41:35Z","git_url":"git://github.com/finnishtransportagency/digiroad2.git","ssh_url":"git@github.com:finnishtransportagency/digiroad2.git","clone_url":"https://github.com/finnishtransportagency/digiroad2.git","svn_url":"https://github.com/finnishtransportagency/digiroad2","homepage":"","size":277442,"stargazers_count":11,"watchers_count":11,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":12,"license":null,"forks":8,"open_issues":12,"watchers":11,"default_branch":"master"}},"base":{"label":"finnishtransportagency:master","ref":"master","sha":"f0dcabf7f581af461622c4a6f4e3a12da7329691","user":{"login":"finnishtransportagency","id":5737015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MzcwMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/5737015?v=4","gravatar_id":"","url":"https://api.github.com/users/finnishtransportagency","html_url":"https://github.com/finnishtransportagency","followers_url":"https://api.github.com/users/finnishtransportagency/followers","following_url":"https://api.github.com/users/finnishtransportagency/following{/other_user}","gists_url":"https://api.github.com/users/finnishtransportagency/gists{/gist_id}","starred_url":"https://api.github.com/users/finnishtransportagency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finnishtransportagency/subscriptions","organizations_url":"https://api.github.com/users/finnishtransportagency/orgs","repos_url":"https://api.github.com/users/finnishtransportagency/repos","events_url":"https://api.github.com/users/finnishtransportagency/events{/privacy}","received_events_url":"https://api.github.com/users/finnishtransportagency/received_events","type":"Organization","site_admin":false},"repo":{"id":13739672,"node_id":"MDEwOlJlcG9zaXRvcnkxMzczOTY3Mg==","name":"digiroad2","full_name":"finnishtransportagency/digiroad2","owner":{"login":"finnishtransportagency","id":5737015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MzcwMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/5737015?v=4","gravatar_id":"","url":"https://api.github.com/users/finnishtransportagency","html_url":"https://github.com/finnishtransportagency","followers_url":"https://api.github.com/users/finnishtransportagency/followers","following_url":"https://api.github.com/users/finnishtransportagency/following{/other_user}","gists_url":"https://api.github.com/users/finnishtransportagency/gists{/gist_id}","starred_url":"https://api.github.com/users/finnishtransportagency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finnishtransportagency/subscriptions","organizations_url":"https://api.github.com/users/finnishtransportagency/orgs","repos_url":"https://api.github.com/users/finnishtransportagency/repos","events_url":"https://api.github.com/users/finnishtransportagency/events{/privacy}","received_events_url":"https://api.github.com/users/finnishtransportagency/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/finnishtransportagency/digiroad2","description":"Digiroad 2 development","fork":false,"url":"https://api.github.com/repos/finnishtransportagency/digiroad2","forks_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/forks","keys_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/teams","hooks_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/hooks","issue_events_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/issues/events{/number}","events_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/events","assignees_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/assignees{/user}","branches_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/branches{/branch}","tags_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/tags","blobs_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/git/refs{/sha}","trees_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/statuses/{sha}","languages_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/languages","stargazers_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/stargazers","contributors_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/contributors","subscribers_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/subscribers","subscription_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/subscription","commits_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/commits{/sha}","git_commits_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/git/commits{/sha}","comments_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/comments{/number}","issue_comment_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/issues/comments{/number}","contents_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/contents/{+path}","compare_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/merges","archive_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/downloads","issues_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/issues{/number}","pulls_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls{/number}","milestones_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/milestones{/number}","notifications_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/labels{/name}","releases_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/releases{/id}","deployments_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/deployments","created_at":"2013-10-21T10:47:36Z","updated_at":"2018-09-11T15:48:12Z","pushed_at":"2018-09-12T16:41:35Z","git_url":"git://github.com/finnishtransportagency/digiroad2.git","ssh_url":"git@github.com:finnishtransportagency/digiroad2.git","clone_url":"https://github.com/finnishtransportagency/digiroad2.git","svn_url":"https://github.com/finnishtransportagency/digiroad2","homepage":"","size":277442,"stargazers_count":11,"watchers_count":11,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":12,"license":null,"forks":8,"open_issues":12,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/1257"},"html":{"href":"https://github.com/finnishtransportagency/digiroad2/pull/1257"},"issue":{"href":"https://api.github.com/repos/finnishtransportagency/digiroad2/issues/1257"},"comments":{"href":"https://api.github.com/repos/finnishtransportagency/digiroad2/issues/1257/comments"},"review_comments":{"href":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/1257/comments"},"review_comment":{"href":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/1257/commits"},"statuses":{"href":"https://api.github.com/repos/finnishtransportagency/digiroad2/statuses/3646761653d5636b24173c339ef99e3d14a41736"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"MAC-CGI"}}