{"action":"created","comment":{"url":"https://api.github.com/repos/voxpupuli/puppet-nginx/pulls/comments/240170008","pull_request_review_id":183135220,"id":240170008,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDE3MDAwOA==","diff_hunk":"@@ -7,8 +7,7 @@\n #     (present|absent)\n #   [*internal*]             - Indicates whether or not this location can be\n #     used for internal requests only. Default: false\n-#   [*server*]                - Defines the default server for this location\n-#     entry to include with\n+#   [*server*]                - Defines all server for this location entry to include with","path":"manifests/resource/location.pp","position":null,"original_position":6,"commit_id":"117b1562e9d4a3cd43083bc8fb480ec81e7891b3","original_commit_id":"82658855a889aeeee9ced9ba5c3dbd98d0c2e4cd","user":{"login":"SaschaDoering","id":20457879,"node_id":"MDQ6VXNlcjIwNDU3ODc5","avatar_url":"https://avatars1.githubusercontent.com/u/20457879?v=4","gravatar_id":"","url":"https://api.github.com/users/SaschaDoering","html_url":"https://github.com/SaschaDoering","followers_url":"https://api.github.com/users/SaschaDoering/followers","following_url":"https://api.github.com/users/SaschaDoering/following{/other_user}","gists_url":"https://api.github.com/users/SaschaDoering/gists{/gist_id}","starred_url":"https://api.github.com/users/SaschaDoering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaschaDoering/subscriptions","organizations_url":"https://api.github.com/users/SaschaDoering/orgs","repos_url":"https://api.github.com/users/SaschaDoering/repos","events_url":"https://api.github.com/users/SaschaDoering/events{/privacy}","received_events_url":"https://api.github.com/users/SaschaDoering/received_events","type":"User","site_admin":false},"body":"I changed the text, hopefully it's better than the last try :)","created_at":"2018-12-10T11:11:55Z","updated_at":"2018-12-10T11:11:55Z","html_url":"https://github.com/voxpupuli/puppet-nginx/pull/1278#discussion_r240170008","pull_request_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/pulls/1278","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-nginx/pulls/comments/240170008"},"html":{"href":"https://github.com/voxpupuli/puppet-nginx/pull/1278#discussion_r240170008"},"pull_request":{"href":"https://api.github.com/repos/voxpupuli/puppet-nginx/pulls/1278"}},"in_reply_to_id":237288832},"pull_request":{"url":"https://api.github.com/repos/voxpupuli/puppet-nginx/pulls/1278","id":232722555,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNzIyNTU1","html_url":"https://github.com/voxpupuli/puppet-nginx/pull/1278","diff_url":"https://github.com/voxpupuli/puppet-nginx/pull/1278.diff","patch_url":"https://github.com/voxpupuli/puppet-nginx/pull/1278.patch","issue_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/1278","number":1278,"state":"open","locked":false,"title":"Allow multiple servers per location","user":{"login":"SaschaDoering","id":20457879,"node_id":"MDQ6VXNlcjIwNDU3ODc5","avatar_url":"https://avatars1.githubusercontent.com/u/20457879?v=4","gravatar_id":"","url":"https://api.github.com/users/SaschaDoering","html_url":"https://github.com/SaschaDoering","followers_url":"https://api.github.com/users/SaschaDoering/followers","following_url":"https://api.github.com/users/SaschaDoering/following{/other_user}","gists_url":"https://api.github.com/users/SaschaDoering/gists{/gist_id}","starred_url":"https://api.github.com/users/SaschaDoering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaschaDoering/subscriptions","organizations_url":"https://api.github.com/users/SaschaDoering/orgs","repos_url":"https://api.github.com/users/SaschaDoering/repos","events_url":"https://api.github.com/users/SaschaDoering/events{/privacy}","received_events_url":"https://api.github.com/users/SaschaDoering/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to this project!\r\n\r\n- This project has a Contributor Code of Conduct: https://voxpupuli.org/coc/\r\n- Please check that here is no existing issue or PR that addresses your problem.\r\n- Our vulnerabilities reporting process is at https://voxpupuli.org/security/\r\n\r\n-->\r\n#### Pull Request (PR) description\r\nBy changing the data type, you can now specify multiple servers for\r\na location. These are then rolled out in a loop. This doesn't break existing installations.\r\n\r\n#### This Pull Request (PR) fixes the following issues\r\nFixes GH-1187\r\n","created_at":"2018-11-21T16:17:47Z","updated_at":"2018-12-10T11:11:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83c30ccc84641e57d157d2182e708f12f33df28d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":199182239,"node_id":"MDU6TGFiZWwxOTkxODIyMzk=","url":"https://api.github.com/repos/voxpupuli/puppet-nginx/labels/enhancement","name":"enhancement","color":"0052cc","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/pulls/1278/commits","review_comments_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/pulls/1278/comments","review_comment_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/1278/comments","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/statuses/117b1562e9d4a3cd43083bc8fb480ec81e7891b3","head":{"label":"syseleven:1187_recycle_locations","ref":"1187_recycle_locations","sha":"117b1562e9d4a3cd43083bc8fb480ec81e7891b3","user":{"login":"syseleven","id":475401,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NTQwMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/475401?v=4","gravatar_id":"","url":"https://api.github.com/users/syseleven","html_url":"https://github.com/syseleven","followers_url":"https://api.github.com/users/syseleven/followers","following_url":"https://api.github.com/users/syseleven/following{/other_user}","gists_url":"https://api.github.com/users/syseleven/gists{/gist_id}","starred_url":"https://api.github.com/users/syseleven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syseleven/subscriptions","organizations_url":"https://api.github.com/users/syseleven/orgs","repos_url":"https://api.github.com/users/syseleven/repos","events_url":"https://api.github.com/users/syseleven/events{/privacy}","received_events_url":"https://api.github.com/users/syseleven/received_events","type":"Organization","site_admin":false},"repo":{"id":137752479,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc3NTI0Nzk=","name":"puppet-nginx","full_name":"syseleven/puppet-nginx","private":false,"owner":{"login":"syseleven","id":475401,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NTQwMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/475401?v=4","gravatar_id":"","url":"https://api.github.com/users/syseleven","html_url":"https://github.com/syseleven","followers_url":"https://api.github.com/users/syseleven/followers","following_url":"https://api.github.com/users/syseleven/following{/other_user}","gists_url":"https://api.github.com/users/syseleven/gists{/gist_id}","starred_url":"https://api.github.com/users/syseleven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syseleven/subscriptions","organizations_url":"https://api.github.com/users/syseleven/orgs","repos_url":"https://api.github.com/users/syseleven/repos","events_url":"https://api.github.com/users/syseleven/events{/privacy}","received_events_url":"https://api.github.com/users/syseleven/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/syseleven/puppet-nginx","description":"Puppet Module to manage NGINX on various UNIXes","fork":true,"url":"https://api.github.com/repos/syseleven/puppet-nginx","forks_url":"https://api.github.com/repos/syseleven/puppet-nginx/forks","keys_url":"https://api.github.com/repos/syseleven/puppet-nginx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syseleven/puppet-nginx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syseleven/puppet-nginx/teams","hooks_url":"https://api.github.com/repos/syseleven/puppet-nginx/hooks","issue_events_url":"https://api.github.com/repos/syseleven/puppet-nginx/issues/events{/number}","events_url":"https://api.github.com/repos/syseleven/puppet-nginx/events","assignees_url":"https://api.github.com/repos/syseleven/puppet-nginx/assignees{/user}","branches_url":"https://api.github.com/repos/syseleven/puppet-nginx/branches{/branch}","tags_url":"https://api.github.com/repos/syseleven/puppet-nginx/tags","blobs_url":"https://api.github.com/repos/syseleven/puppet-nginx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syseleven/puppet-nginx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syseleven/puppet-nginx/git/refs{/sha}","trees_url":"https://api.github.com/repos/syseleven/puppet-nginx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syseleven/puppet-nginx/statuses/{sha}","languages_url":"https://api.github.com/repos/syseleven/puppet-nginx/languages","stargazers_url":"https://api.github.com/repos/syseleven/puppet-nginx/stargazers","contributors_url":"https://api.github.com/repos/syseleven/puppet-nginx/contributors","subscribers_url":"https://api.github.com/repos/syseleven/puppet-nginx/subscribers","subscription_url":"https://api.github.com/repos/syseleven/puppet-nginx/subscription","commits_url":"https://api.github.com/repos/syseleven/puppet-nginx/commits{/sha}","git_commits_url":"https://api.github.com/repos/syseleven/puppet-nginx/git/commits{/sha}","comments_url":"https://api.github.com/repos/syseleven/puppet-nginx/comments{/number}","issue_comment_url":"https://api.github.com/repos/syseleven/puppet-nginx/issues/comments{/number}","contents_url":"https://api.github.com/repos/syseleven/puppet-nginx/contents/{+path}","compare_url":"https://api.github.com/repos/syseleven/puppet-nginx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syseleven/puppet-nginx/merges","archive_url":"https://api.github.com/repos/syseleven/puppet-nginx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syseleven/puppet-nginx/downloads","issues_url":"https://api.github.com/repos/syseleven/puppet-nginx/issues{/number}","pulls_url":"https://api.github.com/repos/syseleven/puppet-nginx/pulls{/number}","milestones_url":"https://api.github.com/repos/syseleven/puppet-nginx/milestones{/number}","notifications_url":"https://api.github.com/repos/syseleven/puppet-nginx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syseleven/puppet-nginx/labels{/name}","releases_url":"https://api.github.com/repos/syseleven/puppet-nginx/releases{/id}","deployments_url":"https://api.github.com/repos/syseleven/puppet-nginx/deployments","created_at":"2018-06-18T13:02:18Z","updated_at":"2018-08-31T13:48:52Z","pushed_at":"2018-12-10T11:02:28Z","git_url":"git://github.com/syseleven/puppet-nginx.git","ssh_url":"git@github.com:syseleven/puppet-nginx.git","clone_url":"https://github.com/syseleven/puppet-nginx.git","svn_url":"https://github.com/syseleven/puppet-nginx","homepage":"https://forge.puppet.com/puppet/nginx","size":2225,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"voxpupuli:master","ref":"master","sha":"705c19b1b5c03e52416200c411a171d5009e61db","user":{"login":"voxpupuli","id":8693967,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2OTM5Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"repo":{"id":1791219,"node_id":"MDEwOlJlcG9zaXRvcnkxNzkxMjE5","name":"puppet-nginx","full_name":"voxpupuli/puppet-nginx","private":false,"owner":{"login":"voxpupuli","id":8693967,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2OTM5Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/voxpupuli/puppet-nginx","description":"Puppet Module to manage NGINX on various UNIXes","fork":false,"url":"https://api.github.com/repos/voxpupuli/puppet-nginx","forks_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/forks","keys_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/teams","hooks_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/hooks","issue_events_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/events{/number}","events_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/events","assignees_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/assignees{/user}","branches_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/branches{/branch}","tags_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/tags","blobs_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/git/refs{/sha}","trees_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/statuses/{sha}","languages_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/languages","stargazers_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/stargazers","contributors_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/contributors","subscribers_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/subscribers","subscription_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/subscription","commits_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/commits{/sha}","git_commits_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/git/commits{/sha}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/comments{/number}","issue_comment_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/comments{/number}","contents_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/contents/{+path}","compare_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/merges","archive_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/downloads","issues_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues{/number}","pulls_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/pulls{/number}","milestones_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/milestones{/number}","notifications_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/labels{/name}","releases_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/releases{/id}","deployments_url":"https://api.github.com/repos/voxpupuli/puppet-nginx/deployments","created_at":"2011-05-24T01:53:48Z","updated_at":"2018-11-20T15:53:01Z","pushed_at":"2018-12-10T11:02:31Z","git_url":"git://github.com/voxpupuli/puppet-nginx.git","ssh_url":"git@github.com:voxpupuli/puppet-nginx.git","clone_url":"https://github.com/voxpupuli/puppet-nginx.git","svn_url":"https://github.com/voxpupuli/puppet-nginx","homepage":"https://forge.puppet.com/puppet/nginx","size":2218,"stargazers_count":446,"watchers_count":446,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":837,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":837,"open_issues":85,"watchers":446,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-nginx/pulls/1278"},"html":{"href":"https://github.com/voxpupuli/puppet-nginx/pull/1278"},"issue":{"href":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/1278"},"comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-nginx/issues/1278/comments"},"review_comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-nginx/pulls/1278/comments"},"review_comment":{"href":"https://api.github.com/repos/voxpupuli/puppet-nginx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/voxpupuli/puppet-nginx/pulls/1278/commits"},"statuses":{"href":"https://api.github.com/repos/voxpupuli/puppet-nginx/statuses/117b1562e9d4a3cd43083bc8fb480ec81e7891b3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"SaschaDoering"}}