{"action":"created","comment":{"url":"https://api.github.com/repos/facebookresearch/pushmi/pulls/comments/200487157","pull_request_review_id":134814893,"id":200487157,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDQ4NzE1Nw==","diff_hunk":"@@ -32,8 +32,9 @@ class flow_single<V, PE, E> {\n     void (*value_)(data&, V) = s_value;\n     void (*stopping_)(data&) noexcept = s_stopping;\n     void (*starting_)(data&, any_none<PE>&) = s_starting;\n-    PUSHMI_DECLARE_CONSTEXPR_IN_CLASS_INIT(static vtable const noop_);\n-  } const* vptr_ = &vtable::noop_;\n+  };\n+  PUSHMI_DECLARE_CONSTEXPR_IN_CLASS_INIT(static vtable const noop_);\n+  vtable const* vptr_ = &noop_;","path":"include/pushmi/flow_single.h","position":8,"original_position":8,"commit_id":"eb4b30da2858ccb4d8bcd9cf956e44d92d70687f","original_commit_id":"eb4b30da2858ccb4d8bcd9cf956e44d92d70687f","user":{"login":"kirkshoop","id":982716,"node_id":"MDQ6VXNlcjk4MjcxNg==","avatar_url":"https://avatars3.githubusercontent.com/u/982716?v=4","gravatar_id":"","url":"https://api.github.com/users/kirkshoop","html_url":"https://github.com/kirkshoop","followers_url":"https://api.github.com/users/kirkshoop/followers","following_url":"https://api.github.com/users/kirkshoop/following{/other_user}","gists_url":"https://api.github.com/users/kirkshoop/gists{/gist_id}","starred_url":"https://api.github.com/users/kirkshoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirkshoop/subscriptions","organizations_url":"https://api.github.com/users/kirkshoop/orgs","repos_url":"https://api.github.com/users/kirkshoop/repos","events_url":"https://api.github.com/users/kirkshoop/events{/privacy}","received_events_url":"https://api.github.com/users/kirkshoop/received_events","type":"User","site_admin":false},"body":"Yes, I expect that moving it outside the vtable struct will allow those macros to be removed","created_at":"2018-07-05T20:55:16Z","updated_at":"2018-07-05T20:55:17Z","html_url":"https://github.com/facebookresearch/pushmi/pull/23#discussion_r200487157","pull_request_url":"https://api.github.com/repos/facebookresearch/pushmi/pulls/23","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebookresearch/pushmi/pulls/comments/200487157"},"html":{"href":"https://github.com/facebookresearch/pushmi/pull/23#discussion_r200487157"},"pull_request":{"href":"https://api.github.com/repos/facebookresearch/pushmi/pulls/23"}},"in_reply_to_id":200482446},"pull_request":{"url":"https://api.github.com/repos/facebookresearch/pushmi/pulls/23","id":199580562,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NTgwNTYy","html_url":"https://github.com/facebookresearch/pushmi/pull/23","diff_url":"https://github.com/facebookresearch/pushmi/pull/23.diff","patch_url":"https://github.com/facebookresearch/pushmi/pull/23.patch","issue_url":"https://api.github.com/repos/facebookresearch/pushmi/issues/23","number":23,"state":"open","locked":false,"title":"make pushmi build with clang trunk","user":{"login":"ericniebler","id":225757,"node_id":"MDQ6VXNlcjIyNTc1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/225757?v=4","gravatar_id":"","url":"https://api.github.com/users/ericniebler","html_url":"https://github.com/ericniebler","followers_url":"https://api.github.com/users/ericniebler/followers","following_url":"https://api.github.com/users/ericniebler/following{/other_user}","gists_url":"https://api.github.com/users/ericniebler/gists{/gist_id}","starred_url":"https://api.github.com/users/ericniebler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericniebler/subscriptions","organizations_url":"https://api.github.com/users/ericniebler/orgs","repos_url":"https://api.github.com/users/ericniebler/repos","events_url":"https://api.github.com/users/ericniebler/events{/privacy}","received_events_url":"https://api.github.com/users/ericniebler/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-05T20:35:17Z","updated_at":"2018-07-05T20:55:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"189bb18e9986f1f55e662359e5af75647655ea6d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":954372935,"node_id":"MDU6TGFiZWw5NTQzNzI5MzU=","url":"https://api.github.com/repos/facebookresearch/pushmi/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebookresearch/pushmi/pulls/23/commits","review_comments_url":"https://api.github.com/repos/facebookresearch/pushmi/pulls/23/comments","review_comment_url":"https://api.github.com/repos/facebookresearch/pushmi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebookresearch/pushmi/issues/23/comments","statuses_url":"https://api.github.com/repos/facebookresearch/pushmi/statuses/eb4b30da2858ccb4d8bcd9cf956e44d92d70687f","head":{"label":"facebookresearch:clang-trunk","ref":"clang-trunk","sha":"eb4b30da2858ccb4d8bcd9cf956e44d92d70687f","user":{"login":"facebookresearch","id":16943930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTQzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"repo":{"id":136069174,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwNjkxNzQ=","name":"pushmi","full_name":"facebookresearch/pushmi","owner":{"login":"facebookresearch","id":16943930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTQzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebookresearch/pushmi","description":"pushmi project","fork":false,"url":"https://api.github.com/repos/facebookresearch/pushmi","forks_url":"https://api.github.com/repos/facebookresearch/pushmi/forks","keys_url":"https://api.github.com/repos/facebookresearch/pushmi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebookresearch/pushmi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebookresearch/pushmi/teams","hooks_url":"https://api.github.com/repos/facebookresearch/pushmi/hooks","issue_events_url":"https://api.github.com/repos/facebookresearch/pushmi/issues/events{/number}","events_url":"https://api.github.com/repos/facebookresearch/pushmi/events","assignees_url":"https://api.github.com/repos/facebookresearch/pushmi/assignees{/user}","branches_url":"https://api.github.com/repos/facebookresearch/pushmi/branches{/branch}","tags_url":"https://api.github.com/repos/facebookresearch/pushmi/tags","blobs_url":"https://api.github.com/repos/facebookresearch/pushmi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebookresearch/pushmi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebookresearch/pushmi/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebookresearch/pushmi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebookresearch/pushmi/statuses/{sha}","languages_url":"https://api.github.com/repos/facebookresearch/pushmi/languages","stargazers_url":"https://api.github.com/repos/facebookresearch/pushmi/stargazers","contributors_url":"https://api.github.com/repos/facebookresearch/pushmi/contributors","subscribers_url":"https://api.github.com/repos/facebookresearch/pushmi/subscribers","subscription_url":"https://api.github.com/repos/facebookresearch/pushmi/subscription","commits_url":"https://api.github.com/repos/facebookresearch/pushmi/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebookresearch/pushmi/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebookresearch/pushmi/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebookresearch/pushmi/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebookresearch/pushmi/contents/{+path}","compare_url":"https://api.github.com/repos/facebookresearch/pushmi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebookresearch/pushmi/merges","archive_url":"https://api.github.com/repos/facebookresearch/pushmi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebookresearch/pushmi/downloads","issues_url":"https://api.github.com/repos/facebookresearch/pushmi/issues{/number}","pulls_url":"https://api.github.com/repos/facebookresearch/pushmi/pulls{/number}","milestones_url":"https://api.github.com/repos/facebookresearch/pushmi/milestones{/number}","notifications_url":"https://api.github.com/repos/facebookresearch/pushmi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebookresearch/pushmi/labels{/name}","releases_url":"https://api.github.com/repos/facebookresearch/pushmi/releases{/id}","deployments_url":"https://api.github.com/repos/facebookresearch/pushmi/deployments","created_at":"2018-06-04T18:51:41Z","updated_at":"2018-07-05T18:49:24Z","pushed_at":"2018-07-05T20:35:17Z","git_url":"git://github.com/facebookresearch/pushmi.git","ssh_url":"git@github.com:facebookresearch/pushmi.git","clone_url":"https://github.com/facebookresearch/pushmi.git","svn_url":"https://github.com/facebookresearch/pushmi","homepage":null,"size":172,"stargazers_count":24,"watchers_count":24,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":24,"default_branch":"master"}},"base":{"label":"facebookresearch:master","ref":"master","sha":"3a8add7d5630ae24d9e08d900fe45810e284e59f","user":{"login":"facebookresearch","id":16943930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTQzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"repo":{"id":136069174,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwNjkxNzQ=","name":"pushmi","full_name":"facebookresearch/pushmi","owner":{"login":"facebookresearch","id":16943930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTQzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebookresearch/pushmi","description":"pushmi project","fork":false,"url":"https://api.github.com/repos/facebookresearch/pushmi","forks_url":"https://api.github.com/repos/facebookresearch/pushmi/forks","keys_url":"https://api.github.com/repos/facebookresearch/pushmi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebookresearch/pushmi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebookresearch/pushmi/teams","hooks_url":"https://api.github.com/repos/facebookresearch/pushmi/hooks","issue_events_url":"https://api.github.com/repos/facebookresearch/pushmi/issues/events{/number}","events_url":"https://api.github.com/repos/facebookresearch/pushmi/events","assignees_url":"https://api.github.com/repos/facebookresearch/pushmi/assignees{/user}","branches_url":"https://api.github.com/repos/facebookresearch/pushmi/branches{/branch}","tags_url":"https://api.github.com/repos/facebookresearch/pushmi/tags","blobs_url":"https://api.github.com/repos/facebookresearch/pushmi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebookresearch/pushmi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebookresearch/pushmi/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebookresearch/pushmi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebookresearch/pushmi/statuses/{sha}","languages_url":"https://api.github.com/repos/facebookresearch/pushmi/languages","stargazers_url":"https://api.github.com/repos/facebookresearch/pushmi/stargazers","contributors_url":"https://api.github.com/repos/facebookresearch/pushmi/contributors","subscribers_url":"https://api.github.com/repos/facebookresearch/pushmi/subscribers","subscription_url":"https://api.github.com/repos/facebookresearch/pushmi/subscription","commits_url":"https://api.github.com/repos/facebookresearch/pushmi/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebookresearch/pushmi/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebookresearch/pushmi/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebookresearch/pushmi/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebookresearch/pushmi/contents/{+path}","compare_url":"https://api.github.com/repos/facebookresearch/pushmi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebookresearch/pushmi/merges","archive_url":"https://api.github.com/repos/facebookresearch/pushmi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebookresearch/pushmi/downloads","issues_url":"https://api.github.com/repos/facebookresearch/pushmi/issues{/number}","pulls_url":"https://api.github.com/repos/facebookresearch/pushmi/pulls{/number}","milestones_url":"https://api.github.com/repos/facebookresearch/pushmi/milestones{/number}","notifications_url":"https://api.github.com/repos/facebookresearch/pushmi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebookresearch/pushmi/labels{/name}","releases_url":"https://api.github.com/repos/facebookresearch/pushmi/releases{/id}","deployments_url":"https://api.github.com/repos/facebookresearch/pushmi/deployments","created_at":"2018-06-04T18:51:41Z","updated_at":"2018-07-05T18:49:24Z","pushed_at":"2018-07-05T20:35:17Z","git_url":"git://github.com/facebookresearch/pushmi.git","ssh_url":"git@github.com:facebookresearch/pushmi.git","clone_url":"https://github.com/facebookresearch/pushmi.git","svn_url":"https://github.com/facebookresearch/pushmi","homepage":null,"size":172,"stargazers_count":24,"watchers_count":24,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebookresearch/pushmi/pulls/23"},"html":{"href":"https://github.com/facebookresearch/pushmi/pull/23"},"issue":{"href":"https://api.github.com/repos/facebookresearch/pushmi/issues/23"},"comments":{"href":"https://api.github.com/repos/facebookresearch/pushmi/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/facebookresearch/pushmi/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/facebookresearch/pushmi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebookresearch/pushmi/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/facebookresearch/pushmi/statuses/eb4b30da2858ccb4d8bcd9cf956e44d92d70687f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kirkshoop"}}