{"action":"created","issue":{"url":"https://api.github.com/repos/jorgebucaran/superfine/issues/123","repository_url":"https://api.github.com/repos/jorgebucaran/superfine","labels_url":"https://api.github.com/repos/jorgebucaran/superfine/issues/123/labels{/name}","comments_url":"https://api.github.com/repos/jorgebucaran/superfine/issues/123/comments","events_url":"https://api.github.com/repos/jorgebucaran/superfine/issues/123/events","html_url":"https://github.com/jorgebucaran/superfine/issues/123","id":336591560,"node_id":"MDU6SXNzdWUzMzY1OTE1NjA=","number":123,"title":"Cannot render pure component with jsx","user":{"login":"Kornflexx","id":11311853,"node_id":"MDQ6VXNlcjExMzExODUz","avatar_url":"https://avatars1.githubusercontent.com/u/11311853?v=4","gravatar_id":"","url":"https://api.github.com/users/Kornflexx","html_url":"https://github.com/Kornflexx","followers_url":"https://api.github.com/users/Kornflexx/followers","following_url":"https://api.github.com/users/Kornflexx/following{/other_user}","gists_url":"https://api.github.com/users/Kornflexx/gists{/gist_id}","starred_url":"https://api.github.com/users/Kornflexx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kornflexx/subscriptions","organizations_url":"https://api.github.com/users/Kornflexx/orgs","repos_url":"https://api.github.com/users/Kornflexx/repos","events_url":"https://api.github.com/users/Kornflexx/events{/privacy}","received_events_url":"https://api.github.com/users/Kornflexx/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-28T12:01:08Z","updated_at":"2018-06-28T12:04:05Z","closed_at":"2018-06-28T12:03:06Z","author_association":"NONE","body":"Hello,\r\n\r\nFirst of all, thank you for your work.\r\nI encounter an issue trying to run the last example (others examples works with jsx).\r\n\r\n```\r\nimport { h, render } from \"superfine\"\r\n\r\nconst ClickMe = props => (\r\n  <a href={props.url}>\r\n    <h1>{children}</h1>\r\n  </a>\r\n)\r\n\r\nlet lastNode = render(\r\n  null,\r\n  <ClickMe url=\"/\">Click Here!</ClickMe>,\r\n  document.body\r\n)\r\n```\r\n\r\n\r\nIn my browser console I have the following error:\r\n\r\n```\r\nVM9945:1 Uncaught DOMException: Failed to execute 'createElement' on 'Document': The tag name provided ('function ClickMe(props) {\r\n  return (0, _superfine.h)(\"a\", {\r\n    href: props.url\r\n  }, (0, _superfine.h)(\"h1\", null, children));\r\n}') is not a valid name.\r\n    at HTMLDocument.createElement (<anonymous>:1:1554)\r\n    at createElement (webpack:///./node_modules/superfine/src/index.js?:51:20)\r\n    at patchElement (webpack:///./node_modules/superfine/src/index.js?:132:7)\r\n    at render (webpack:///./node_modules/superfine/src/index.js?:258:3)\r\n    at eval (webpack:///./src/index.js?:11:38)\r\n    at Object../src/index.js (http://localhost:3000/index.js:384:1)\r\n    at __webpack_require__ (http://localhost:3000/index.js:20:30)\r\n    at eval (webpack:///multi_(webpack)-dev-server/client?:2:18)\r\n    at Object.0 (http://localhost:3000/index.js:395:1)\r\n    at __webpack_require__ (http://localhost:3000/index.js:20:30)\r\n(anonymous) @ VM9945:1\r\ncreateElement @ index.js:51\r\npatchElement @ index.js:132\r\nrender @ index.js:258\r\n(anonymous) @ index.js:11\r\n./src/index.js @ index.js:384\r\n__webpack_require__ @ index.js:20\r\n(anonymous) @ client:2\r\n0 @ index.js:395\r\n__webpack_require__ @ index.js:20\r\n(anonymous) @ index.js:84\r\n(anonymous) @ index.js:87\r\n```\r\n\r\n\r\nHere are my configs:\r\n\r\n`.babelrc`\r\n```\r\n{\r\n    \"presets\": [\r\n        \"@babel/preset-env\"\r\n    ],\r\n    \"plugins\": [\r\n        [\r\n            \"transform-react-jsx\",\r\n            {\r\n                \"pragma\": \"h\"\r\n            }\r\n        ]\r\n    ]\r\n}\r\n```\r\n\r\n`webpack.config.js`\r\n```\r\nconst path = require('path')\r\n\r\nmodule.exports = {\r\n    entry: './src/index.js',\r\n    output: {\r\n      path: path.resolve(__dirname, 'dist'),\r\n      filename: 'index.js'\r\n    },\r\n    mode: 'development',\r\n    module: {\r\n        rules: [\r\n            {\r\n                test: /\\.js$/,\r\n                exclude: /(node_modules|bower_components)/,\r\n                use: {\r\n                    loader: 'babel-loader',\r\n                    options: {\r\n                        babelrc: true\r\n                    }\r\n                }\r\n            }\r\n        ]\r\n    },\r\n    devServer: {\r\n        contentBase: path.resolve(__dirname, 'dist'),\r\n        compress: true,\r\n        port: 3000\r\n    }\r\n};\r\n```\r\n\r\n`package.json`\r\n```\r\n{\r\n  \"name\": \"superfine-test\",\r\n  \"version\": \"1.0.0\",\r\n  \"description\": \"\",\r\n  \"main\": \"index.js\",\r\n  \"scripts\": {\r\n    \"start\": \"webpack-dev-server --watch\",\r\n    \"build\": \"webpack\",\r\n    \"test\": \"echo \\\"Error: no test specified\\\" && exit 1\"\r\n  },\r\n  \"author\": \"\",\r\n  \"license\": \"ISC\",\r\n  \"dependencies\": {\r\n    \"babel-plugin-transform-react-jsx\": \"^6.24.1\",\r\n    \"superfine\": \"^5.0.1\"\r\n  },\r\n  \"devDependencies\": {\r\n    \"@babel/core\": \"^7.0.0-beta.51\",\r\n    \"@babel/preset-env\": \"^7.0.0-beta.51\",\r\n    \"babel-cli\": \"^6.26.0\",\r\n    \"babel-loader\": \"^8.0.0-beta.4\",\r\n    \"babel-plugin-auto-import\": \"^0.7.1\",\r\n    \"babel-preset-env\": \"^1.7.0\",\r\n    \"webpack\": \"^4.12.2\",\r\n    \"webpack-cli\": \"^3.0.8\",\r\n    \"webpack-dev-server\": \"^3.1.4\",\r\n    \"webpack-hot-middleware\": \"^2.22.2\"\r\n  }\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/jorgebucaran/superfine/issues/comments/401011694","html_url":"https://github.com/jorgebucaran/superfine/issues/123#issuecomment-401011694","issue_url":"https://api.github.com/repos/jorgebucaran/superfine/issues/123","id":401011694,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTAxMTY5NA==","user":{"login":"jorgebucaran","id":56996,"node_id":"MDQ6VXNlcjU2OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/56996?v=4","gravatar_id":"","url":"https://api.github.com/users/jorgebucaran","html_url":"https://github.com/jorgebucaran","followers_url":"https://api.github.com/users/jorgebucaran/followers","following_url":"https://api.github.com/users/jorgebucaran/following{/other_user}","gists_url":"https://api.github.com/users/jorgebucaran/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgebucaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgebucaran/subscriptions","organizations_url":"https://api.github.com/users/jorgebucaran/orgs","repos_url":"https://api.github.com/users/jorgebucaran/repos","events_url":"https://api.github.com/users/jorgebucaran/events{/privacy}","received_events_url":"https://api.github.com/users/jorgebucaran/received_events","type":"User","site_admin":false},"created_at":"2018-06-28T12:04:05Z","updated_at":"2018-06-28T12:04:05Z","author_association":"OWNER","body":"Thanks, @Kornflexx. It's added here 0b9667a38fff30f9f68694bdbaea8ac2af477d62, I just need to cut  a new release. 👋 "}}
{"actor":{"display_login":"jorgebucaran"}}