{"action":"created","comment":{"url":"https://api.github.com/repos/QSYdev/goterm/pulls/comments/207282769","pull_request_review_id":142863774,"id":207282769,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzI4Mjc2OQ==","diff_hunk":"@@ -147,7 +147,7 @@ func main() {\n \tonStateChanged := func(d gatt.Device, s gatt.State) {\n \t\tswitch s {\n \t\tcase gatt.StatePoweredOn:\n-\t\t\tsvc := ble.NewService(client)","path":"cmd/ble/main.go","position":null,"original_position":13,"commit_id":"268f19475ad52502ed9be710b532daf329e61c7f","original_commit_id":"268f19475ad52502ed9be710b532daf329e61c7f","user":{"login":"matipan","id":8126891,"node_id":"MDQ6VXNlcjgxMjY4OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8126891?v=4","gravatar_id":"","url":"https://api.github.com/users/matipan","html_url":"https://github.com/matipan","followers_url":"https://api.github.com/users/matipan/followers","following_url":"https://api.github.com/users/matipan/following{/other_user}","gists_url":"https://api.github.com/users/matipan/gists{/gist_id}","starred_url":"https://api.github.com/users/matipan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matipan/subscriptions","organizations_url":"https://api.github.com/users/matipan/orgs","repos_url":"https://api.github.com/users/matipan/repos","events_url":"https://api.github.com/users/matipan/events{/privacy}","received_events_url":"https://api.github.com/users/matipan/received_events","type":"User","site_admin":false},"body":"Fragmenter seria el servicio que hace el Write y Notify con fragmentacion, no se me ocurrio otro nombre jajaja","created_at":"2018-08-02T16:00:20Z","updated_at":"2018-08-02T16:00:20Z","html_url":"https://github.com/QSYdev/goterm/pull/4#discussion_r207282769","pull_request_url":"https://api.github.com/repos/QSYdev/goterm/pulls/4","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/QSYdev/goterm/pulls/comments/207282769"},"html":{"href":"https://github.com/QSYdev/goterm/pull/4#discussion_r207282769"},"pull_request":{"href":"https://api.github.com/repos/QSYdev/goterm/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/QSYdev/goterm/pulls/4","id":203611864,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNjExODY0","html_url":"https://github.com/QSYdev/goterm/pull/4","diff_url":"https://github.com/QSYdev/goterm/pull/4.diff","patch_url":"https://github.com/QSYdev/goterm/pull/4.patch","issue_url":"https://api.github.com/repos/QSYdev/goterm/issues/4","number":4,"state":"open","locked":false,"title":"Ble service refactor","user":{"login":"matipan","id":8126891,"node_id":"MDQ6VXNlcjgxMjY4OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8126891?v=4","gravatar_id":"","url":"https://api.github.com/users/matipan","html_url":"https://github.com/matipan","followers_url":"https://api.github.com/users/matipan/followers","following_url":"https://api.github.com/users/matipan/following{/other_user}","gists_url":"https://api.github.com/users/matipan/gists{/gist_id}","starred_url":"https://api.github.com/users/matipan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matipan/subscriptions","organizations_url":"https://api.github.com/users/matipan/orgs","repos_url":"https://api.github.com/users/matipan/repos","events_url":"https://api.github.com/users/matipan/events{/privacy}","received_events_url":"https://api.github.com/users/matipan/received_events","type":"User","site_admin":false},"body":"Me gusta mas esta forma de hacer lo de BLE.\r\nEn este caso BLE tiene dos caracteristicas, un `write` y un `notify`. Ambas saben como hacer fragmentacion.\r\n* `write(UUID=0xBBBB)`: se usa cuando se le quiere mandar data a la terminal. Esto puede ser una rutina(tanto random como custom) o puede ser un stop de rutina corriendo, o si en el futuro decidimos agregar algo mas lo hacemos.\r\n* `notify(UUID=0xCCCC)`: esto se usa para notificar cada evento que va pasando, los eventos son los mismos de antes.\r\n\r\nLo que tiene de bueno implementarlo de esta manera es que si en el futuro queremos modificar la estructura interna de los packets o si queremos mandar otro tipo de data, no tenemos que tocar el codigo de BLE ni un toque. Y ahora la libreria de BLE no tiene ni idea acerca del formato interno del packet. Entonces el formato requerido para la fragmentacion queda separado del formato de los packets en si. ","created_at":"2018-07-24T18:14:55Z","updated_at":"2018-08-02T16:00:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4aa4e37d2640f2b8ed31efa4968a481eb7569466","assignee":{"login":"matipan","id":8126891,"node_id":"MDQ6VXNlcjgxMjY4OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8126891?v=4","gravatar_id":"","url":"https://api.github.com/users/matipan","html_url":"https://github.com/matipan","followers_url":"https://api.github.com/users/matipan/followers","following_url":"https://api.github.com/users/matipan/following{/other_user}","gists_url":"https://api.github.com/users/matipan/gists{/gist_id}","starred_url":"https://api.github.com/users/matipan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matipan/subscriptions","organizations_url":"https://api.github.com/users/matipan/orgs","repos_url":"https://api.github.com/users/matipan/repos","events_url":"https://api.github.com/users/matipan/events{/privacy}","received_events_url":"https://api.github.com/users/matipan/received_events","type":"User","site_admin":false},"assignees":[{"login":"matipan","id":8126891,"node_id":"MDQ6VXNlcjgxMjY4OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8126891?v=4","gravatar_id":"","url":"https://api.github.com/users/matipan","html_url":"https://github.com/matipan","followers_url":"https://api.github.com/users/matipan/followers","following_url":"https://api.github.com/users/matipan/following{/other_user}","gists_url":"https://api.github.com/users/matipan/gists{/gist_id}","starred_url":"https://api.github.com/users/matipan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matipan/subscriptions","organizations_url":"https://api.github.com/users/matipan/orgs","repos_url":"https://api.github.com/users/matipan/repos","events_url":"https://api.github.com/users/matipan/events{/privacy}","received_events_url":"https://api.github.com/users/matipan/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"Agusss19","id":21260850,"node_id":"MDQ6VXNlcjIxMjYwODUw","avatar_url":"https://avatars0.githubusercontent.com/u/21260850?v=4","gravatar_id":"","url":"https://api.github.com/users/Agusss19","html_url":"https://github.com/Agusss19","followers_url":"https://api.github.com/users/Agusss19/followers","following_url":"https://api.github.com/users/Agusss19/following{/other_user}","gists_url":"https://api.github.com/users/Agusss19/gists{/gist_id}","starred_url":"https://api.github.com/users/Agusss19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Agusss19/subscriptions","organizations_url":"https://api.github.com/users/Agusss19/orgs","repos_url":"https://api.github.com/users/Agusss19/repos","events_url":"https://api.github.com/users/Agusss19/events{/privacy}","received_events_url":"https://api.github.com/users/Agusss19/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":972759587,"node_id":"MDU6TGFiZWw5NzI3NTk1ODc=","url":"https://api.github.com/repos/QSYdev/goterm/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/QSYdev/goterm/pulls/4/commits","review_comments_url":"https://api.github.com/repos/QSYdev/goterm/pulls/4/comments","review_comment_url":"https://api.github.com/repos/QSYdev/goterm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/QSYdev/goterm/issues/4/comments","statuses_url":"https://api.github.com/repos/QSYdev/goterm/statuses/268f19475ad52502ed9be710b532daf329e61c7f","head":{"label":"QSYdev:ble-service-refactor","ref":"ble-service-refactor","sha":"268f19475ad52502ed9be710b532daf329e61c7f","user":{"login":"QSYdev","id":39226170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjI2MTcw","avatar_url":"https://avatars1.githubusercontent.com/u/39226170?v=4","gravatar_id":"","url":"https://api.github.com/users/QSYdev","html_url":"https://github.com/QSYdev","followers_url":"https://api.github.com/users/QSYdev/followers","following_url":"https://api.github.com/users/QSYdev/following{/other_user}","gists_url":"https://api.github.com/users/QSYdev/gists{/gist_id}","starred_url":"https://api.github.com/users/QSYdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QSYdev/subscriptions","organizations_url":"https://api.github.com/users/QSYdev/orgs","repos_url":"https://api.github.com/users/QSYdev/repos","events_url":"https://api.github.com/users/QSYdev/events{/privacy}","received_events_url":"https://api.github.com/users/QSYdev/received_events","type":"Organization","site_admin":false},"repo":{"id":138352084,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgzNTIwODQ=","name":"goterm","full_name":"QSYdev/goterm","owner":{"login":"QSYdev","id":39226170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjI2MTcw","avatar_url":"https://avatars1.githubusercontent.com/u/39226170?v=4","gravatar_id":"","url":"https://api.github.com/users/QSYdev","html_url":"https://github.com/QSYdev","followers_url":"https://api.github.com/users/QSYdev/followers","following_url":"https://api.github.com/users/QSYdev/following{/other_user}","gists_url":"https://api.github.com/users/QSYdev/gists{/gist_id}","starred_url":"https://api.github.com/users/QSYdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QSYdev/subscriptions","organizations_url":"https://api.github.com/users/QSYdev/orgs","repos_url":"https://api.github.com/users/QSYdev/repos","events_url":"https://api.github.com/users/QSYdev/events{/privacy}","received_events_url":"https://api.github.com/users/QSYdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/QSYdev/goterm","description":"Terminal implementation in Go","fork":false,"url":"https://api.github.com/repos/QSYdev/goterm","forks_url":"https://api.github.com/repos/QSYdev/goterm/forks","keys_url":"https://api.github.com/repos/QSYdev/goterm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QSYdev/goterm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QSYdev/goterm/teams","hooks_url":"https://api.github.com/repos/QSYdev/goterm/hooks","issue_events_url":"https://api.github.com/repos/QSYdev/goterm/issues/events{/number}","events_url":"https://api.github.com/repos/QSYdev/goterm/events","assignees_url":"https://api.github.com/repos/QSYdev/goterm/assignees{/user}","branches_url":"https://api.github.com/repos/QSYdev/goterm/branches{/branch}","tags_url":"https://api.github.com/repos/QSYdev/goterm/tags","blobs_url":"https://api.github.com/repos/QSYdev/goterm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QSYdev/goterm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QSYdev/goterm/git/refs{/sha}","trees_url":"https://api.github.com/repos/QSYdev/goterm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QSYdev/goterm/statuses/{sha}","languages_url":"https://api.github.com/repos/QSYdev/goterm/languages","stargazers_url":"https://api.github.com/repos/QSYdev/goterm/stargazers","contributors_url":"https://api.github.com/repos/QSYdev/goterm/contributors","subscribers_url":"https://api.github.com/repos/QSYdev/goterm/subscribers","subscription_url":"https://api.github.com/repos/QSYdev/goterm/subscription","commits_url":"https://api.github.com/repos/QSYdev/goterm/commits{/sha}","git_commits_url":"https://api.github.com/repos/QSYdev/goterm/git/commits{/sha}","comments_url":"https://api.github.com/repos/QSYdev/goterm/comments{/number}","issue_comment_url":"https://api.github.com/repos/QSYdev/goterm/issues/comments{/number}","contents_url":"https://api.github.com/repos/QSYdev/goterm/contents/{+path}","compare_url":"https://api.github.com/repos/QSYdev/goterm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QSYdev/goterm/merges","archive_url":"https://api.github.com/repos/QSYdev/goterm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QSYdev/goterm/downloads","issues_url":"https://api.github.com/repos/QSYdev/goterm/issues{/number}","pulls_url":"https://api.github.com/repos/QSYdev/goterm/pulls{/number}","milestones_url":"https://api.github.com/repos/QSYdev/goterm/milestones{/number}","notifications_url":"https://api.github.com/repos/QSYdev/goterm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QSYdev/goterm/labels{/name}","releases_url":"https://api.github.com/repos/QSYdev/goterm/releases{/id}","deployments_url":"https://api.github.com/repos/QSYdev/goterm/deployments","created_at":"2018-06-22T22:06:24Z","updated_at":"2018-07-05T00:09:42Z","pushed_at":"2018-08-02T15:59:14Z","git_url":"git://github.com/QSYdev/goterm.git","ssh_url":"git@github.com:QSYdev/goterm.git","clone_url":"https://github.com/QSYdev/goterm.git","svn_url":"https://github.com/QSYdev/goterm","homepage":null,"size":5001,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"QSYdev:master","ref":"master","sha":"7f4a021126f9d21736c24c3fced48646e14def2f","user":{"login":"QSYdev","id":39226170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjI2MTcw","avatar_url":"https://avatars1.githubusercontent.com/u/39226170?v=4","gravatar_id":"","url":"https://api.github.com/users/QSYdev","html_url":"https://github.com/QSYdev","followers_url":"https://api.github.com/users/QSYdev/followers","following_url":"https://api.github.com/users/QSYdev/following{/other_user}","gists_url":"https://api.github.com/users/QSYdev/gists{/gist_id}","starred_url":"https://api.github.com/users/QSYdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QSYdev/subscriptions","organizations_url":"https://api.github.com/users/QSYdev/orgs","repos_url":"https://api.github.com/users/QSYdev/repos","events_url":"https://api.github.com/users/QSYdev/events{/privacy}","received_events_url":"https://api.github.com/users/QSYdev/received_events","type":"Organization","site_admin":false},"repo":{"id":138352084,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgzNTIwODQ=","name":"goterm","full_name":"QSYdev/goterm","owner":{"login":"QSYdev","id":39226170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjI2MTcw","avatar_url":"https://avatars1.githubusercontent.com/u/39226170?v=4","gravatar_id":"","url":"https://api.github.com/users/QSYdev","html_url":"https://github.com/QSYdev","followers_url":"https://api.github.com/users/QSYdev/followers","following_url":"https://api.github.com/users/QSYdev/following{/other_user}","gists_url":"https://api.github.com/users/QSYdev/gists{/gist_id}","starred_url":"https://api.github.com/users/QSYdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QSYdev/subscriptions","organizations_url":"https://api.github.com/users/QSYdev/orgs","repos_url":"https://api.github.com/users/QSYdev/repos","events_url":"https://api.github.com/users/QSYdev/events{/privacy}","received_events_url":"https://api.github.com/users/QSYdev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/QSYdev/goterm","description":"Terminal implementation in Go","fork":false,"url":"https://api.github.com/repos/QSYdev/goterm","forks_url":"https://api.github.com/repos/QSYdev/goterm/forks","keys_url":"https://api.github.com/repos/QSYdev/goterm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QSYdev/goterm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QSYdev/goterm/teams","hooks_url":"https://api.github.com/repos/QSYdev/goterm/hooks","issue_events_url":"https://api.github.com/repos/QSYdev/goterm/issues/events{/number}","events_url":"https://api.github.com/repos/QSYdev/goterm/events","assignees_url":"https://api.github.com/repos/QSYdev/goterm/assignees{/user}","branches_url":"https://api.github.com/repos/QSYdev/goterm/branches{/branch}","tags_url":"https://api.github.com/repos/QSYdev/goterm/tags","blobs_url":"https://api.github.com/repos/QSYdev/goterm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QSYdev/goterm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QSYdev/goterm/git/refs{/sha}","trees_url":"https://api.github.com/repos/QSYdev/goterm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QSYdev/goterm/statuses/{sha}","languages_url":"https://api.github.com/repos/QSYdev/goterm/languages","stargazers_url":"https://api.github.com/repos/QSYdev/goterm/stargazers","contributors_url":"https://api.github.com/repos/QSYdev/goterm/contributors","subscribers_url":"https://api.github.com/repos/QSYdev/goterm/subscribers","subscription_url":"https://api.github.com/repos/QSYdev/goterm/subscription","commits_url":"https://api.github.com/repos/QSYdev/goterm/commits{/sha}","git_commits_url":"https://api.github.com/repos/QSYdev/goterm/git/commits{/sha}","comments_url":"https://api.github.com/repos/QSYdev/goterm/comments{/number}","issue_comment_url":"https://api.github.com/repos/QSYdev/goterm/issues/comments{/number}","contents_url":"https://api.github.com/repos/QSYdev/goterm/contents/{+path}","compare_url":"https://api.github.com/repos/QSYdev/goterm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QSYdev/goterm/merges","archive_url":"https://api.github.com/repos/QSYdev/goterm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QSYdev/goterm/downloads","issues_url":"https://api.github.com/repos/QSYdev/goterm/issues{/number}","pulls_url":"https://api.github.com/repos/QSYdev/goterm/pulls{/number}","milestones_url":"https://api.github.com/repos/QSYdev/goterm/milestones{/number}","notifications_url":"https://api.github.com/repos/QSYdev/goterm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QSYdev/goterm/labels{/name}","releases_url":"https://api.github.com/repos/QSYdev/goterm/releases{/id}","deployments_url":"https://api.github.com/repos/QSYdev/goterm/deployments","created_at":"2018-06-22T22:06:24Z","updated_at":"2018-07-05T00:09:42Z","pushed_at":"2018-08-02T15:59:14Z","git_url":"git://github.com/QSYdev/goterm.git","ssh_url":"git@github.com:QSYdev/goterm.git","clone_url":"https://github.com/QSYdev/goterm.git","svn_url":"https://github.com/QSYdev/goterm","homepage":null,"size":5001,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/QSYdev/goterm/pulls/4"},"html":{"href":"https://github.com/QSYdev/goterm/pull/4"},"issue":{"href":"https://api.github.com/repos/QSYdev/goterm/issues/4"},"comments":{"href":"https://api.github.com/repos/QSYdev/goterm/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/QSYdev/goterm/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/QSYdev/goterm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/QSYdev/goterm/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/QSYdev/goterm/statuses/268f19475ad52502ed9be710b532daf329e61c7f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"matipan"}}