{"action":"created","issue":{"url":"https://api.github.com/repos/ivmai/bdwgc/issues/239","repository_url":"https://api.github.com/repos/ivmai/bdwgc","labels_url":"https://api.github.com/repos/ivmai/bdwgc/issues/239/labels{/name}","comments_url":"https://api.github.com/repos/ivmai/bdwgc/issues/239/comments","events_url":"https://api.github.com/repos/ivmai/bdwgc/issues/239/events","html_url":"https://github.com/ivmai/bdwgc/pull/239","id":367912670,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMjExOTgz","number":239,"title":"Add test using disclaim notifiers to implement a weak map.","user":{"login":"paurkedal","id":144070,"node_id":"MDQ6VXNlcjE0NDA3MA==","avatar_url":"https://avatars3.githubusercontent.com/u/144070?v=4","gravatar_id":"","url":"https://api.github.com/users/paurkedal","html_url":"https://github.com/paurkedal","followers_url":"https://api.github.com/users/paurkedal/followers","following_url":"https://api.github.com/users/paurkedal/following{/other_user}","gists_url":"https://api.github.com/users/paurkedal/gists{/gist_id}","starred_url":"https://api.github.com/users/paurkedal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paurkedal/subscriptions","organizations_url":"https://api.github.com/users/paurkedal/orgs","repos_url":"https://api.github.com/users/paurkedal/repos","events_url":"https://api.github.com/users/paurkedal/events{/privacy}","received_events_url":"https://api.github.com/users/paurkedal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-08T18:55:51Z","updated_at":"2018-10-10T18:18:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ivmai/bdwgc/pulls/239","html_url":"https://github.com/ivmai/bdwgc/pull/239","diff_url":"https://github.com/ivmai/bdwgc/pull/239.diff","patch_url":"https://github.com/ivmai/bdwgc/pull/239.patch"},"body":"This test is more in the spirit of my original motivation for the disclaim notifiers, which relies on returning non-zero to block collection of objects.  My old library code is highly optimised and too involved to lift into the test, so I wrote a hash map from scratch.  It took a bit more time than expected to debug, but the result is fairly straight forward.  Note that the \"Skipping marked...\" case can happen, it's just extremely rare."},"comment":{"url":"https://api.github.com/repos/ivmai/bdwgc/issues/comments/428677413","html_url":"https://github.com/ivmai/bdwgc/pull/239#issuecomment-428677413","issue_url":"https://api.github.com/repos/ivmai/bdwgc/issues/239","id":428677413,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODY3NzQxMw==","user":{"login":"paurkedal","id":144070,"node_id":"MDQ6VXNlcjE0NDA3MA==","avatar_url":"https://avatars3.githubusercontent.com/u/144070?v=4","gravatar_id":"","url":"https://api.github.com/users/paurkedal","html_url":"https://github.com/paurkedal","followers_url":"https://api.github.com/users/paurkedal/followers","following_url":"https://api.github.com/users/paurkedal/following{/other_user}","gists_url":"https://api.github.com/users/paurkedal/gists{/gist_id}","starred_url":"https://api.github.com/users/paurkedal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paurkedal/subscriptions","organizations_url":"https://api.github.com/users/paurkedal/orgs","repos_url":"https://api.github.com/users/paurkedal/repos","events_url":"https://api.github.com/users/paurkedal/events{/privacy}","received_events_url":"https://api.github.com/users/paurkedal/received_events","type":"User","site_admin":false},"created_at":"2018-10-10T18:18:49Z","updated_at":"2018-10-10T18:18:49Z","author_association":"CONTRIBUTOR","body":"Yes, I noticed this need more work. Updating now with at least the warnings fixed, and I think the uninitialized var was fixed by zeroing a struct which probably contained some padding. We'll see in a moment.\r\n\r\nI am not sure what the last test failure is, as I don't have a working build environment (the instrumentation gives segfault in all tests).  I may need to revisit this later if I don't figure it out this week.\r\n\r\nA am not sure merging everything into `disclaim_test.c` is wise.  Both tests are heavy and we have seen in the past that it may take dozens of re-runs to reproduce an error.  Also I think it is useful to see whether the two tests fail independently, in case they fail consistently.\r\n"}}
{"actor":{"display_login":"paurkedal"}}