{"action":"closed","number":42,"pull_request":{"url":"https://api.github.com/repos/MestreLion/humblebundle/pulls/42","id":175140928,"html_url":"https://github.com/MestreLion/humblebundle/pull/42","diff_url":"https://github.com/MestreLion/humblebundle/pull/42.diff","patch_url":"https://github.com/MestreLion/humblebundle/pull/42.patch","issue_url":"https://api.github.com/repos/MestreLion/humblebundle/issues/42","number":42,"state":"closed","locked":false,"title":"Download option working in Python 3","user":{"login":"chilinux","id":9854863,"avatar_url":"https://avatars1.githubusercontent.com/u/9854863?v=4","gravatar_id":"","url":"https://api.github.com/users/chilinux","html_url":"https://github.com/chilinux","followers_url":"https://api.github.com/users/chilinux/followers","following_url":"https://api.github.com/users/chilinux/following{/other_user}","gists_url":"https://api.github.com/users/chilinux/gists{/gist_id}","starred_url":"https://api.github.com/users/chilinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chilinux/subscriptions","organizations_url":"https://api.github.com/users/chilinux/orgs","repos_url":"https://api.github.com/users/chilinux/repos","events_url":"https://api.github.com/users/chilinux/events{/privacy}","received_events_url":"https://api.github.com/users/chilinux/received_events","type":"User","site_admin":false},"body":"I had not tested the download capability under Python 3 previously.  It turned out this option needed some minor modifications.  With this pull request, I have now gotten the download option working in Python 3.\r\n\r\nWhen called with the trace module, it wasn't passing the argv correctly to the main() function.  I made a minor tweak to work-around this.\r\n\r\nI ran into an issue with iterating over binary reads that it would iterate forever since python v3 treats '' and b'' as two different things.  The kept the script from proceeding past the download.\r\n\r\nIt also seems like Progressbar v2 has no currval but both the python v2 and v3 modules have \"value\" instead.\r\n\r\nLet me know if there is anything you would like see modified in the pull request before merging.\r\n","created_at":"2018-03-15T03:38:52Z","updated_at":"2018-03-28T15:51:17Z","closed_at":"2018-03-28T15:51:17Z","merged_at":"2018-03-28T15:51:17Z","merge_commit_sha":"bfd6ce7c1b047a189fd075220dadfc82446acedd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MestreLion/humblebundle/pulls/42/commits","review_comments_url":"https://api.github.com/repos/MestreLion/humblebundle/pulls/42/comments","review_comment_url":"https://api.github.com/repos/MestreLion/humblebundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MestreLion/humblebundle/issues/42/comments","statuses_url":"https://api.github.com/repos/MestreLion/humblebundle/statuses/16f7de24e31caf85867bfb6988cf38a3dd2e6659","head":{"label":"chilinux:master","ref":"master","sha":"16f7de24e31caf85867bfb6988cf38a3dd2e6659","user":{"login":"chilinux","id":9854863,"avatar_url":"https://avatars1.githubusercontent.com/u/9854863?v=4","gravatar_id":"","url":"https://api.github.com/users/chilinux","html_url":"https://github.com/chilinux","followers_url":"https://api.github.com/users/chilinux/followers","following_url":"https://api.github.com/users/chilinux/following{/other_user}","gists_url":"https://api.github.com/users/chilinux/gists{/gist_id}","starred_url":"https://api.github.com/users/chilinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chilinux/subscriptions","organizations_url":"https://api.github.com/users/chilinux/orgs","repos_url":"https://api.github.com/users/chilinux/repos","events_url":"https://api.github.com/users/chilinux/events{/privacy}","received_events_url":"https://api.github.com/users/chilinux/received_events","type":"User","site_admin":false},"repo":{"id":120392356,"name":"humblebundle","full_name":"chilinux/humblebundle","owner":{"login":"chilinux","id":9854863,"avatar_url":"https://avatars1.githubusercontent.com/u/9854863?v=4","gravatar_id":"","url":"https://api.github.com/users/chilinux","html_url":"https://github.com/chilinux","followers_url":"https://api.github.com/users/chilinux/followers","following_url":"https://api.github.com/users/chilinux/following{/other_user}","gists_url":"https://api.github.com/users/chilinux/gists{/gist_id}","starred_url":"https://api.github.com/users/chilinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chilinux/subscriptions","organizations_url":"https://api.github.com/users/chilinux/orgs","repos_url":"https://api.github.com/users/chilinux/repos","events_url":"https://api.github.com/users/chilinux/events{/privacy}","received_events_url":"https://api.github.com/users/chilinux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chilinux/humblebundle","description":"API for managing Humble Bundle games library","fork":true,"url":"https://api.github.com/repos/chilinux/humblebundle","forks_url":"https://api.github.com/repos/chilinux/humblebundle/forks","keys_url":"https://api.github.com/repos/chilinux/humblebundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chilinux/humblebundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chilinux/humblebundle/teams","hooks_url":"https://api.github.com/repos/chilinux/humblebundle/hooks","issue_events_url":"https://api.github.com/repos/chilinux/humblebundle/issues/events{/number}","events_url":"https://api.github.com/repos/chilinux/humblebundle/events","assignees_url":"https://api.github.com/repos/chilinux/humblebundle/assignees{/user}","branches_url":"https://api.github.com/repos/chilinux/humblebundle/branches{/branch}","tags_url":"https://api.github.com/repos/chilinux/humblebundle/tags","blobs_url":"https://api.github.com/repos/chilinux/humblebundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chilinux/humblebundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chilinux/humblebundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/chilinux/humblebundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chilinux/humblebundle/statuses/{sha}","languages_url":"https://api.github.com/repos/chilinux/humblebundle/languages","stargazers_url":"https://api.github.com/repos/chilinux/humblebundle/stargazers","contributors_url":"https://api.github.com/repos/chilinux/humblebundle/contributors","subscribers_url":"https://api.github.com/repos/chilinux/humblebundle/subscribers","subscription_url":"https://api.github.com/repos/chilinux/humblebundle/subscription","commits_url":"https://api.github.com/repos/chilinux/humblebundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/chilinux/humblebundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/chilinux/humblebundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/chilinux/humblebundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/chilinux/humblebundle/contents/{+path}","compare_url":"https://api.github.com/repos/chilinux/humblebundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chilinux/humblebundle/merges","archive_url":"https://api.github.com/repos/chilinux/humblebundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chilinux/humblebundle/downloads","issues_url":"https://api.github.com/repos/chilinux/humblebundle/issues{/number}","pulls_url":"https://api.github.com/repos/chilinux/humblebundle/pulls{/number}","milestones_url":"https://api.github.com/repos/chilinux/humblebundle/milestones{/number}","notifications_url":"https://api.github.com/repos/chilinux/humblebundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chilinux/humblebundle/labels{/name}","releases_url":"https://api.github.com/repos/chilinux/humblebundle/releases{/id}","deployments_url":"https://api.github.com/repos/chilinux/humblebundle/deployments","created_at":"2018-02-06T02:45:56Z","updated_at":"2018-03-15T03:28:59Z","pushed_at":"2018-03-15T03:28:58Z","git_url":"git://github.com/chilinux/humblebundle.git","ssh_url":"git@github.com:chilinux/humblebundle.git","clone_url":"https://github.com/chilinux/humblebundle.git","svn_url":"https://github.com/chilinux/humblebundle","homepage":null,"size":141,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MestreLion:master","ref":"master","sha":"f66cb14ff3243f5cf4771a7cce0a000a17b5e7b3","user":{"login":"MestreLion","id":992317,"avatar_url":"https://avatars3.githubusercontent.com/u/992317?v=4","gravatar_id":"","url":"https://api.github.com/users/MestreLion","html_url":"https://github.com/MestreLion","followers_url":"https://api.github.com/users/MestreLion/followers","following_url":"https://api.github.com/users/MestreLion/following{/other_user}","gists_url":"https://api.github.com/users/MestreLion/gists{/gist_id}","starred_url":"https://api.github.com/users/MestreLion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MestreLion/subscriptions","organizations_url":"https://api.github.com/users/MestreLion/orgs","repos_url":"https://api.github.com/users/MestreLion/repos","events_url":"https://api.github.com/users/MestreLion/events{/privacy}","received_events_url":"https://api.github.com/users/MestreLion/received_events","type":"User","site_admin":false},"repo":{"id":21812413,"name":"humblebundle","full_name":"MestreLion/humblebundle","owner":{"login":"MestreLion","id":992317,"avatar_url":"https://avatars3.githubusercontent.com/u/992317?v=4","gravatar_id":"","url":"https://api.github.com/users/MestreLion","html_url":"https://github.com/MestreLion","followers_url":"https://api.github.com/users/MestreLion/followers","following_url":"https://api.github.com/users/MestreLion/following{/other_user}","gists_url":"https://api.github.com/users/MestreLion/gists{/gist_id}","starred_url":"https://api.github.com/users/MestreLion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MestreLion/subscriptions","organizations_url":"https://api.github.com/users/MestreLion/orgs","repos_url":"https://api.github.com/users/MestreLion/repos","events_url":"https://api.github.com/users/MestreLion/events{/privacy}","received_events_url":"https://api.github.com/users/MestreLion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MestreLion/humblebundle","description":"API for managing Humble Bundle games library","fork":false,"url":"https://api.github.com/repos/MestreLion/humblebundle","forks_url":"https://api.github.com/repos/MestreLion/humblebundle/forks","keys_url":"https://api.github.com/repos/MestreLion/humblebundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MestreLion/humblebundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MestreLion/humblebundle/teams","hooks_url":"https://api.github.com/repos/MestreLion/humblebundle/hooks","issue_events_url":"https://api.github.com/repos/MestreLion/humblebundle/issues/events{/number}","events_url":"https://api.github.com/repos/MestreLion/humblebundle/events","assignees_url":"https://api.github.com/repos/MestreLion/humblebundle/assignees{/user}","branches_url":"https://api.github.com/repos/MestreLion/humblebundle/branches{/branch}","tags_url":"https://api.github.com/repos/MestreLion/humblebundle/tags","blobs_url":"https://api.github.com/repos/MestreLion/humblebundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MestreLion/humblebundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MestreLion/humblebundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/MestreLion/humblebundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MestreLion/humblebundle/statuses/{sha}","languages_url":"https://api.github.com/repos/MestreLion/humblebundle/languages","stargazers_url":"https://api.github.com/repos/MestreLion/humblebundle/stargazers","contributors_url":"https://api.github.com/repos/MestreLion/humblebundle/contributors","subscribers_url":"https://api.github.com/repos/MestreLion/humblebundle/subscribers","subscription_url":"https://api.github.com/repos/MestreLion/humblebundle/subscription","commits_url":"https://api.github.com/repos/MestreLion/humblebundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/MestreLion/humblebundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/MestreLion/humblebundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/MestreLion/humblebundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/MestreLion/humblebundle/contents/{+path}","compare_url":"https://api.github.com/repos/MestreLion/humblebundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MestreLion/humblebundle/merges","archive_url":"https://api.github.com/repos/MestreLion/humblebundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MestreLion/humblebundle/downloads","issues_url":"https://api.github.com/repos/MestreLion/humblebundle/issues{/number}","pulls_url":"https://api.github.com/repos/MestreLion/humblebundle/pulls{/number}","milestones_url":"https://api.github.com/repos/MestreLion/humblebundle/milestones{/number}","notifications_url":"https://api.github.com/repos/MestreLion/humblebundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MestreLion/humblebundle/labels{/name}","releases_url":"https://api.github.com/repos/MestreLion/humblebundle/releases{/id}","deployments_url":"https://api.github.com/repos/MestreLion/humblebundle/deployments","created_at":"2014-07-14T08:24:22Z","updated_at":"2018-03-28T15:48:51Z","pushed_at":"2018-03-28T15:51:17Z","git_url":"git://github.com/MestreLion/humblebundle.git","ssh_url":"git@github.com:MestreLion/humblebundle.git","clone_url":"https://github.com/MestreLion/humblebundle.git","svn_url":"https://github.com/MestreLion/humblebundle","homepage":null,"size":138,"stargazers_count":110,"watchers_count":110,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":23,"open_issues":13,"watchers":110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MestreLion/humblebundle/pulls/42"},"html":{"href":"https://github.com/MestreLion/humblebundle/pull/42"},"issue":{"href":"https://api.github.com/repos/MestreLion/humblebundle/issues/42"},"comments":{"href":"https://api.github.com/repos/MestreLion/humblebundle/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/MestreLion/humblebundle/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/MestreLion/humblebundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MestreLion/humblebundle/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/MestreLion/humblebundle/statuses/16f7de24e31caf85867bfb6988cf38a3dd2e6659"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"MestreLion","id":992317,"avatar_url":"https://avatars3.githubusercontent.com/u/992317?v=4","gravatar_id":"","url":"https://api.github.com/users/MestreLion","html_url":"https://github.com/MestreLion","followers_url":"https://api.github.com/users/MestreLion/followers","following_url":"https://api.github.com/users/MestreLion/following{/other_user}","gists_url":"https://api.github.com/users/MestreLion/gists{/gist_id}","starred_url":"https://api.github.com/users/MestreLion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MestreLion/subscriptions","organizations_url":"https://api.github.com/users/MestreLion/orgs","repos_url":"https://api.github.com/users/MestreLion/repos","events_url":"https://api.github.com/users/MestreLion/events{/privacy}","received_events_url":"https://api.github.com/users/MestreLion/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":9,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"MestreLion"}}