{"action":"created","comment":{"url":"https://api.github.com/repos/C0DK/P4-HCL/pulls/comments/166134129","pull_request_review_id":94167805,"id":166134129,"diff_hunk":"@@ -0,0 +1,35 @@\n+_**Please edit this to reflect the pull request. A pullr equest with this line in it will not(!!!) be accepted.**_\n+### Description\n+A short explaination of the pullrequest if needed. could be \"we added support for Python\" or a long ass text. idealy a few lines.\n+\n+### Changelog\n+ - this has changed\n+ - this has aswell \n+   - which includes this\n+   - and also this\n+\n+### Issues solved \n+add these with the respective key as HCLANG-1 (as an example)\n+ - HCLANG-[number]\n+\n+### Issues opened as a result of this \n+Add something here if new issues arrise because of this. For instance if new features-needs or bugs arrise from this PR. if this is not the cause, then remove this section\n+\n+## FOR REVIEWER [Do not remove]\n+A small checklist of things to note when you are doing a review. Make sure these things apply before going into master.\n+ - Did the PR actually fix the issue\n+ - Comment anything that doesn't make sense or anything you want clarified. Many comments are always excuseable\n+ - Make sure this is ready for exams if this is going into master\n+ - It's always a good idea having another reviewer look at a PR as well, if it's major. get a buddy.\n+\n+### Regarding code [if applicable]\n+- Check [coding conventions](https://kotlinlang.org/docs/reference/coding-conventions.html)\n+- Is public methods documented? ","path":".github/pull_request_template.md","position":27,"original_position":27,"commit_id":"23eb604cd0abd9b2e9217e31f5314b819b39817e","original_commit_id":"23eb604cd0abd9b2e9217e31f5314b819b39817e","user":{"login":"nillas12","id":6108612,"avatar_url":"https://avatars0.githubusercontent.com/u/6108612?v=4","gravatar_id":"","url":"https://api.github.com/users/nillas12","html_url":"https://github.com/nillas12","followers_url":"https://api.github.com/users/nillas12/followers","following_url":"https://api.github.com/users/nillas12/following{/other_user}","gists_url":"https://api.github.com/users/nillas12/gists{/gist_id}","starred_url":"https://api.github.com/users/nillas12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nillas12/subscriptions","organizations_url":"https://api.github.com/users/nillas12/orgs","repos_url":"https://api.github.com/users/nillas12/repos","events_url":"https://api.github.com/users/nillas12/events{/privacy}","received_events_url":"https://api.github.com/users/nillas12/received_events","type":"User","site_admin":false},"body":"Are public methods","created_at":"2018-02-05T22:35:16Z","updated_at":"2018-02-05T22:35:16Z","html_url":"https://github.com/C0DK/P4-HCL/pull/2#discussion_r166134129","pull_request_url":"https://api.github.com/repos/C0DK/P4-HCL/pulls/2","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/C0DK/P4-HCL/pulls/comments/166134129"},"html":{"href":"https://github.com/C0DK/P4-HCL/pull/2#discussion_r166134129"},"pull_request":{"href":"https://api.github.com/repos/C0DK/P4-HCL/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/C0DK/P4-HCL/pulls/2","id":167272351,"html_url":"https://github.com/C0DK/P4-HCL/pull/2","diff_url":"https://github.com/C0DK/P4-HCL/pull/2.diff","patch_url":"https://github.com/C0DK/P4-HCL/pull/2.patch","issue_url":"https://api.github.com/repos/C0DK/P4-HCL/issues/2","number":2,"state":"open","locked":false,"title":"initial test fix","user":{"login":"C0DK","id":9048078,"avatar_url":"https://avatars2.githubusercontent.com/u/9048078?v=4","gravatar_id":"","url":"https://api.github.com/users/C0DK","html_url":"https://github.com/C0DK","followers_url":"https://api.github.com/users/C0DK/followers","following_url":"https://api.github.com/users/C0DK/following{/other_user}","gists_url":"https://api.github.com/users/C0DK/gists{/gist_id}","starred_url":"https://api.github.com/users/C0DK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/C0DK/subscriptions","organizations_url":"https://api.github.com/users/C0DK/orgs","repos_url":"https://api.github.com/users/C0DK/repos","events_url":"https://api.github.com/users/C0DK/events{/privacy}","received_events_url":"https://api.github.com/users/C0DK/received_events","type":"User","site_admin":false},"body":"### description\r\n\r\nadded a pull request template.\r\nThe markdown can be tested with this tool: https://dillinger.io/\r\nI'm not completly sure that this will use the template on github. it's hard to test without having it in master ^^ however i followed [this guide](https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/) which should verify that this does in fact work. \r\n\r\n### Changelog\r\n- Added pull request template\r\n\r\n### Issue solved\r\n- [HCLANG-1](http://hcl.codes/jira/browse/HCLANG-1)\r\n","created_at":"2018-02-05T22:30:47Z","updated_at":"2018-02-05T22:35:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"531b42568bbd56c203a38fb518e0b0cb284a6772","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/C0DK/P4-HCL/pulls/2/commits","review_comments_url":"https://api.github.com/repos/C0DK/P4-HCL/pulls/2/comments","review_comment_url":"https://api.github.com/repos/C0DK/P4-HCL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/C0DK/P4-HCL/issues/2/comments","statuses_url":"https://api.github.com/repos/C0DK/P4-HCL/statuses/23eb604cd0abd9b2e9217e31f5314b819b39817e","head":{"label":"C0DK:create-pull-request-temlate","ref":"create-pull-request-temlate","sha":"23eb604cd0abd9b2e9217e31f5314b819b39817e","user":{"login":"C0DK","id":9048078,"avatar_url":"https://avatars2.githubusercontent.com/u/9048078?v=4","gravatar_id":"","url":"https://api.github.com/users/C0DK","html_url":"https://github.com/C0DK","followers_url":"https://api.github.com/users/C0DK/followers","following_url":"https://api.github.com/users/C0DK/following{/other_user}","gists_url":"https://api.github.com/users/C0DK/gists{/gist_id}","starred_url":"https://api.github.com/users/C0DK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/C0DK/subscriptions","organizations_url":"https://api.github.com/users/C0DK/orgs","repos_url":"https://api.github.com/users/C0DK/repos","events_url":"https://api.github.com/users/C0DK/events{/privacy}","received_events_url":"https://api.github.com/users/C0DK/received_events","type":"User","site_admin":false},"repo":{"id":120297748,"name":"P4-HCL","full_name":"C0DK/P4-HCL","owner":{"login":"C0DK","id":9048078,"avatar_url":"https://avatars2.githubusercontent.com/u/9048078?v=4","gravatar_id":"","url":"https://api.github.com/users/C0DK","html_url":"https://github.com/C0DK","followers_url":"https://api.github.com/users/C0DK/followers","following_url":"https://api.github.com/users/C0DK/following{/other_user}","gists_url":"https://api.github.com/users/C0DK/gists{/gist_id}","starred_url":"https://api.github.com/users/C0DK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/C0DK/subscriptions","organizations_url":"https://api.github.com/users/C0DK/orgs","repos_url":"https://api.github.com/users/C0DK/repos","events_url":"https://api.github.com/users/C0DK/events{/privacy}","received_events_url":"https://api.github.com/users/C0DK/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/C0DK/P4-HCL","description":"P3 project on university: HCL Compiled Language.","fork":false,"url":"https://api.github.com/repos/C0DK/P4-HCL","forks_url":"https://api.github.com/repos/C0DK/P4-HCL/forks","keys_url":"https://api.github.com/repos/C0DK/P4-HCL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/C0DK/P4-HCL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/C0DK/P4-HCL/teams","hooks_url":"https://api.github.com/repos/C0DK/P4-HCL/hooks","issue_events_url":"https://api.github.com/repos/C0DK/P4-HCL/issues/events{/number}","events_url":"https://api.github.com/repos/C0DK/P4-HCL/events","assignees_url":"https://api.github.com/repos/C0DK/P4-HCL/assignees{/user}","branches_url":"https://api.github.com/repos/C0DK/P4-HCL/branches{/branch}","tags_url":"https://api.github.com/repos/C0DK/P4-HCL/tags","blobs_url":"https://api.github.com/repos/C0DK/P4-HCL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/C0DK/P4-HCL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/C0DK/P4-HCL/git/refs{/sha}","trees_url":"https://api.github.com/repos/C0DK/P4-HCL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/C0DK/P4-HCL/statuses/{sha}","languages_url":"https://api.github.com/repos/C0DK/P4-HCL/languages","stargazers_url":"https://api.github.com/repos/C0DK/P4-HCL/stargazers","contributors_url":"https://api.github.com/repos/C0DK/P4-HCL/contributors","subscribers_url":"https://api.github.com/repos/C0DK/P4-HCL/subscribers","subscription_url":"https://api.github.com/repos/C0DK/P4-HCL/subscription","commits_url":"https://api.github.com/repos/C0DK/P4-HCL/commits{/sha}","git_commits_url":"https://api.github.com/repos/C0DK/P4-HCL/git/commits{/sha}","comments_url":"https://api.github.com/repos/C0DK/P4-HCL/comments{/number}","issue_comment_url":"https://api.github.com/repos/C0DK/P4-HCL/issues/comments{/number}","contents_url":"https://api.github.com/repos/C0DK/P4-HCL/contents/{+path}","compare_url":"https://api.github.com/repos/C0DK/P4-HCL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/C0DK/P4-HCL/merges","archive_url":"https://api.github.com/repos/C0DK/P4-HCL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/C0DK/P4-HCL/downloads","issues_url":"https://api.github.com/repos/C0DK/P4-HCL/issues{/number}","pulls_url":"https://api.github.com/repos/C0DK/P4-HCL/pulls{/number}","milestones_url":"https://api.github.com/repos/C0DK/P4-HCL/milestones{/number}","notifications_url":"https://api.github.com/repos/C0DK/P4-HCL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/C0DK/P4-HCL/labels{/name}","releases_url":"https://api.github.com/repos/C0DK/P4-HCL/releases{/id}","deployments_url":"https://api.github.com/repos/C0DK/P4-HCL/deployments","created_at":"2018-02-05T11:46:59Z","updated_at":"2018-02-05T11:47:42Z","pushed_at":"2018-02-05T22:30:47Z","git_url":"git://github.com/C0DK/P4-HCL.git","ssh_url":"git@github.com:C0DK/P4-HCL.git","clone_url":"https://github.com/C0DK/P4-HCL.git","svn_url":"https://github.com/C0DK/P4-HCL","homepage":null,"size":7,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"C0DK:master","ref":"master","sha":"7d94d3959a6075b3562a86eb6982c00f7cc9b509","user":{"login":"C0DK","id":9048078,"avatar_url":"https://avatars2.githubusercontent.com/u/9048078?v=4","gravatar_id":"","url":"https://api.github.com/users/C0DK","html_url":"https://github.com/C0DK","followers_url":"https://api.github.com/users/C0DK/followers","following_url":"https://api.github.com/users/C0DK/following{/other_user}","gists_url":"https://api.github.com/users/C0DK/gists{/gist_id}","starred_url":"https://api.github.com/users/C0DK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/C0DK/subscriptions","organizations_url":"https://api.github.com/users/C0DK/orgs","repos_url":"https://api.github.com/users/C0DK/repos","events_url":"https://api.github.com/users/C0DK/events{/privacy}","received_events_url":"https://api.github.com/users/C0DK/received_events","type":"User","site_admin":false},"repo":{"id":120297748,"name":"P4-HCL","full_name":"C0DK/P4-HCL","owner":{"login":"C0DK","id":9048078,"avatar_url":"https://avatars2.githubusercontent.com/u/9048078?v=4","gravatar_id":"","url":"https://api.github.com/users/C0DK","html_url":"https://github.com/C0DK","followers_url":"https://api.github.com/users/C0DK/followers","following_url":"https://api.github.com/users/C0DK/following{/other_user}","gists_url":"https://api.github.com/users/C0DK/gists{/gist_id}","starred_url":"https://api.github.com/users/C0DK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/C0DK/subscriptions","organizations_url":"https://api.github.com/users/C0DK/orgs","repos_url":"https://api.github.com/users/C0DK/repos","events_url":"https://api.github.com/users/C0DK/events{/privacy}","received_events_url":"https://api.github.com/users/C0DK/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/C0DK/P4-HCL","description":"P3 project on university: HCL Compiled Language.","fork":false,"url":"https://api.github.com/repos/C0DK/P4-HCL","forks_url":"https://api.github.com/repos/C0DK/P4-HCL/forks","keys_url":"https://api.github.com/repos/C0DK/P4-HCL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/C0DK/P4-HCL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/C0DK/P4-HCL/teams","hooks_url":"https://api.github.com/repos/C0DK/P4-HCL/hooks","issue_events_url":"https://api.github.com/repos/C0DK/P4-HCL/issues/events{/number}","events_url":"https://api.github.com/repos/C0DK/P4-HCL/events","assignees_url":"https://api.github.com/repos/C0DK/P4-HCL/assignees{/user}","branches_url":"https://api.github.com/repos/C0DK/P4-HCL/branches{/branch}","tags_url":"https://api.github.com/repos/C0DK/P4-HCL/tags","blobs_url":"https://api.github.com/repos/C0DK/P4-HCL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/C0DK/P4-HCL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/C0DK/P4-HCL/git/refs{/sha}","trees_url":"https://api.github.com/repos/C0DK/P4-HCL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/C0DK/P4-HCL/statuses/{sha}","languages_url":"https://api.github.com/repos/C0DK/P4-HCL/languages","stargazers_url":"https://api.github.com/repos/C0DK/P4-HCL/stargazers","contributors_url":"https://api.github.com/repos/C0DK/P4-HCL/contributors","subscribers_url":"https://api.github.com/repos/C0DK/P4-HCL/subscribers","subscription_url":"https://api.github.com/repos/C0DK/P4-HCL/subscription","commits_url":"https://api.github.com/repos/C0DK/P4-HCL/commits{/sha}","git_commits_url":"https://api.github.com/repos/C0DK/P4-HCL/git/commits{/sha}","comments_url":"https://api.github.com/repos/C0DK/P4-HCL/comments{/number}","issue_comment_url":"https://api.github.com/repos/C0DK/P4-HCL/issues/comments{/number}","contents_url":"https://api.github.com/repos/C0DK/P4-HCL/contents/{+path}","compare_url":"https://api.github.com/repos/C0DK/P4-HCL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/C0DK/P4-HCL/merges","archive_url":"https://api.github.com/repos/C0DK/P4-HCL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/C0DK/P4-HCL/downloads","issues_url":"https://api.github.com/repos/C0DK/P4-HCL/issues{/number}","pulls_url":"https://api.github.com/repos/C0DK/P4-HCL/pulls{/number}","milestones_url":"https://api.github.com/repos/C0DK/P4-HCL/milestones{/number}","notifications_url":"https://api.github.com/repos/C0DK/P4-HCL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/C0DK/P4-HCL/labels{/name}","releases_url":"https://api.github.com/repos/C0DK/P4-HCL/releases{/id}","deployments_url":"https://api.github.com/repos/C0DK/P4-HCL/deployments","created_at":"2018-02-05T11:46:59Z","updated_at":"2018-02-05T11:47:42Z","pushed_at":"2018-02-05T22:30:47Z","git_url":"git://github.com/C0DK/P4-HCL.git","ssh_url":"git@github.com:C0DK/P4-HCL.git","clone_url":"https://github.com/C0DK/P4-HCL.git","svn_url":"https://github.com/C0DK/P4-HCL","homepage":null,"size":7,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/C0DK/P4-HCL/pulls/2"},"html":{"href":"https://github.com/C0DK/P4-HCL/pull/2"},"issue":{"href":"https://api.github.com/repos/C0DK/P4-HCL/issues/2"},"comments":{"href":"https://api.github.com/repos/C0DK/P4-HCL/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/C0DK/P4-HCL/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/C0DK/P4-HCL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/C0DK/P4-HCL/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/C0DK/P4-HCL/statuses/23eb604cd0abd9b2e9217e31f5314b819b39817e"}},"author_association":"OWNER"}}
{"actor":{"display_login":"nillas12"}}