{"action":"created","issue":{"url":"https://api.github.com/repos/fission/fission/issues/936","repository_url":"https://api.github.com/repos/fission/fission","labels_url":"https://api.github.com/repos/fission/fission/issues/936/labels{/name}","comments_url":"https://api.github.com/repos/fission/fission/issues/936/comments","events_url":"https://api.github.com/repos/fission/fission/issues/936/events","html_url":"https://github.com/fission/fission/pull/936","id":370236010,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyOTYxNjA3","number":936,"title":"Adding JVM heap options to environment","user":{"login":"vishal-biyani","id":1167948,"node_id":"MDQ6VXNlcjExNjc5NDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1167948?v=4","gravatar_id":"","url":"https://api.github.com/users/vishal-biyani","html_url":"https://github.com/vishal-biyani","followers_url":"https://api.github.com/users/vishal-biyani/followers","following_url":"https://api.github.com/users/vishal-biyani/following{/other_user}","gists_url":"https://api.github.com/users/vishal-biyani/gists{/gist_id}","starred_url":"https://api.github.com/users/vishal-biyani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishal-biyani/subscriptions","organizations_url":"https://api.github.com/users/vishal-biyani/orgs","repos_url":"https://api.github.com/users/vishal-biyani/repos","events_url":"https://api.github.com/users/vishal-biyani/events{/privacy}","received_events_url":"https://api.github.com/users/vishal-biyani/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-15T16:08:48Z","updated_at":"2018-10-15T16:11:16Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/fission/fission/pulls/936","html_url":"https://github.com/fission/fission/pull/936","diff_url":"https://github.com/fission/fission/pull/936.diff","patch_url":"https://github.com/fission/fission/pull/936.patch"},"body":"This PR solves #925 and enables providing options to JVM heap.  The heap options can be passed with spec file for environment as shown in example below:\r\n\r\n```\r\napiVersion: fission.io/v1\r\nkind: Environment\r\nmetadata:\r\n  creationTimestamp: null\r\n  name: jvm\r\n  namespace: default\r\nspec:\r\n  TerminationGracePeriod: 360\r\n  builder: {}\r\n  keeparchive: true\r\n  poolsize: 3\r\n  resources: {}\r\n  runtime:\r\n    functionendpointport: 0\r\n    image: fission/jvm-env\r\n    loadendpointpath: \"\"\r\n    loadendpointport: 0\r\n    container:\r\n      env:\r\n      - name: JVM_OPTS\r\n        value: \"-Xms256M -Xmx1024M\"\r\n  version: 2\r\n```\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/fission/fission/936)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/fission/fission/issues/comments/429916505","html_url":"https://github.com/fission/fission/pull/936#issuecomment-429916505","issue_url":"https://api.github.com/repos/fission/fission/issues/936","id":429916505,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTkxNjUwNQ==","user":{"login":"soamvasani","id":16418446,"node_id":"MDQ6VXNlcjE2NDE4NDQ2","avatar_url":"https://avatars1.githubusercontent.com/u/16418446?v=4","gravatar_id":"","url":"https://api.github.com/users/soamvasani","html_url":"https://github.com/soamvasani","followers_url":"https://api.github.com/users/soamvasani/followers","following_url":"https://api.github.com/users/soamvasani/following{/other_user}","gists_url":"https://api.github.com/users/soamvasani/gists{/gist_id}","starred_url":"https://api.github.com/users/soamvasani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soamvasani/subscriptions","organizations_url":"https://api.github.com/users/soamvasani/orgs","repos_url":"https://api.github.com/users/soamvasani/repos","events_url":"https://api.github.com/users/soamvasani/events{/privacy}","received_events_url":"https://api.github.com/users/soamvasani/received_events","type":"User","site_admin":false},"created_at":"2018-10-15T16:11:16Z","updated_at":"2018-10-15T16:11:16Z","author_association":"MEMBER","body":"Nice, LGTM!  How did you test it?"}}
{"actor":{"display_login":"soamvasani"}}