{"action":"created","comment":{"url":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/comments/229315022","pull_request_review_id":169775102,"id":229315022,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTMxNTAyMg==","diff_hunk":"@@ -61,6 +72,13 @@ public void record() {\n \n   @Override\n   public void record(TagContext tags) {\n+    if (hasUnsupportedValues) {\n+      // drop all the recorded values\n+      builder.clear();","path":"impl_core/src/main/java/io/opencensus/implcore/stats/MeasureMapImpl.java","position":42,"original_position":42,"commit_id":"bbe1b2469b9ecf369025bc372fbe355c704fae4e","original_commit_id":"bbe1b2469b9ecf369025bc372fbe355c704fae4e","user":{"login":"bogdandrutu","id":1373887,"node_id":"MDQ6VXNlcjEzNzM4ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/1373887?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdandrutu","html_url":"https://github.com/bogdandrutu","followers_url":"https://api.github.com/users/bogdandrutu/followers","following_url":"https://api.github.com/users/bogdandrutu/following{/other_user}","gists_url":"https://api.github.com/users/bogdandrutu/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdandrutu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdandrutu/subscriptions","organizations_url":"https://api.github.com/users/bogdandrutu/orgs","repos_url":"https://api.github.com/users/bogdandrutu/repos","events_url":"https://api.github.com/users/bogdandrutu/events{/privacy}","received_events_url":"https://api.github.com/users/bogdandrutu/received_events","type":"User","site_admin":false},"body":"this is a change that we should not add it right now. I think record should not reset the values.","created_at":"2018-10-30T13:55:18Z","updated_at":"2018-10-30T13:55:38Z","html_url":"https://github.com/census-instrumentation/opencensus-java/pull/1499#discussion_r229315022","pull_request_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/1499","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/comments/229315022"},"html":{"href":"https://github.com/census-instrumentation/opencensus-java/pull/1499#discussion_r229315022"},"pull_request":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/1499"}}},"pull_request":{"url":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/1499","id":223076242,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMDc2MjQy","html_url":"https://github.com/census-instrumentation/opencensus-java/pull/1499","diff_url":"https://github.com/census-instrumentation/opencensus-java/pull/1499.diff","patch_url":"https://github.com/census-instrumentation/opencensus-java/pull/1499.patch","issue_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/issues/1499","number":1499,"state":"open","locked":false,"title":"ignore negative bucket bounds","user":{"login":"mayurkale22","id":6525361,"node_id":"MDQ6VXNlcjY1MjUzNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/6525361?v=4","gravatar_id":"","url":"https://api.github.com/users/mayurkale22","html_url":"https://github.com/mayurkale22","followers_url":"https://api.github.com/users/mayurkale22/followers","following_url":"https://api.github.com/users/mayurkale22/following{/other_user}","gists_url":"https://api.github.com/users/mayurkale22/gists{/gist_id}","starred_url":"https://api.github.com/users/mayurkale22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayurkale22/subscriptions","organizations_url":"https://api.github.com/users/mayurkale22/orgs","repos_url":"https://api.github.com/users/mayurkale22/repos","events_url":"https://api.github.com/users/mayurkale22/events{/privacy}","received_events_url":"https://api.github.com/users/mayurkale22/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-15T23:51:54Z","updated_at":"2018-10-30T13:55:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da6a30fa46b6ba172ce24455a6a566e247167aaf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":616301408,"node_id":"MDU6TGFiZWw2MTYzMDE0MDg=","url":"https://api.github.com/repos/census-instrumentation/opencensus-java/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/1499/commits","review_comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/1499/comments","review_comment_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/issues/1499/comments","statuses_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/statuses/bbe1b2469b9ecf369025bc372fbe355c704fae4e","head":{"label":"mayurkale22:drop_negative_buckets","ref":"drop_negative_buckets","sha":"bbe1b2469b9ecf369025bc372fbe355c704fae4e","user":{"login":"mayurkale22","id":6525361,"node_id":"MDQ6VXNlcjY1MjUzNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/6525361?v=4","gravatar_id":"","url":"https://api.github.com/users/mayurkale22","html_url":"https://github.com/mayurkale22","followers_url":"https://api.github.com/users/mayurkale22/followers","following_url":"https://api.github.com/users/mayurkale22/following{/other_user}","gists_url":"https://api.github.com/users/mayurkale22/gists{/gist_id}","starred_url":"https://api.github.com/users/mayurkale22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayurkale22/subscriptions","organizations_url":"https://api.github.com/users/mayurkale22/orgs","repos_url":"https://api.github.com/users/mayurkale22/repos","events_url":"https://api.github.com/users/mayurkale22/events{/privacy}","received_events_url":"https://api.github.com/users/mayurkale22/received_events","type":"User","site_admin":false},"repo":{"id":144620293,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ2MjAyOTM=","name":"opencensus-java","full_name":"mayurkale22/opencensus-java","private":false,"owner":{"login":"mayurkale22","id":6525361,"node_id":"MDQ6VXNlcjY1MjUzNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/6525361?v=4","gravatar_id":"","url":"https://api.github.com/users/mayurkale22","html_url":"https://github.com/mayurkale22","followers_url":"https://api.github.com/users/mayurkale22/followers","following_url":"https://api.github.com/users/mayurkale22/following{/other_user}","gists_url":"https://api.github.com/users/mayurkale22/gists{/gist_id}","starred_url":"https://api.github.com/users/mayurkale22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayurkale22/subscriptions","organizations_url":"https://api.github.com/users/mayurkale22/orgs","repos_url":"https://api.github.com/users/mayurkale22/repos","events_url":"https://api.github.com/users/mayurkale22/events{/privacy}","received_events_url":"https://api.github.com/users/mayurkale22/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mayurkale22/opencensus-java","description":"A stats collection and distributed tracing framework","fork":true,"url":"https://api.github.com/repos/mayurkale22/opencensus-java","forks_url":"https://api.github.com/repos/mayurkale22/opencensus-java/forks","keys_url":"https://api.github.com/repos/mayurkale22/opencensus-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mayurkale22/opencensus-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mayurkale22/opencensus-java/teams","hooks_url":"https://api.github.com/repos/mayurkale22/opencensus-java/hooks","issue_events_url":"https://api.github.com/repos/mayurkale22/opencensus-java/issues/events{/number}","events_url":"https://api.github.com/repos/mayurkale22/opencensus-java/events","assignees_url":"https://api.github.com/repos/mayurkale22/opencensus-java/assignees{/user}","branches_url":"https://api.github.com/repos/mayurkale22/opencensus-java/branches{/branch}","tags_url":"https://api.github.com/repos/mayurkale22/opencensus-java/tags","blobs_url":"https://api.github.com/repos/mayurkale22/opencensus-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mayurkale22/opencensus-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mayurkale22/opencensus-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/mayurkale22/opencensus-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mayurkale22/opencensus-java/statuses/{sha}","languages_url":"https://api.github.com/repos/mayurkale22/opencensus-java/languages","stargazers_url":"https://api.github.com/repos/mayurkale22/opencensus-java/stargazers","contributors_url":"https://api.github.com/repos/mayurkale22/opencensus-java/contributors","subscribers_url":"https://api.github.com/repos/mayurkale22/opencensus-java/subscribers","subscription_url":"https://api.github.com/repos/mayurkale22/opencensus-java/subscription","commits_url":"https://api.github.com/repos/mayurkale22/opencensus-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/mayurkale22/opencensus-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/mayurkale22/opencensus-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/mayurkale22/opencensus-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/mayurkale22/opencensus-java/contents/{+path}","compare_url":"https://api.github.com/repos/mayurkale22/opencensus-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mayurkale22/opencensus-java/merges","archive_url":"https://api.github.com/repos/mayurkale22/opencensus-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mayurkale22/opencensus-java/downloads","issues_url":"https://api.github.com/repos/mayurkale22/opencensus-java/issues{/number}","pulls_url":"https://api.github.com/repos/mayurkale22/opencensus-java/pulls{/number}","milestones_url":"https://api.github.com/repos/mayurkale22/opencensus-java/milestones{/number}","notifications_url":"https://api.github.com/repos/mayurkale22/opencensus-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mayurkale22/opencensus-java/labels{/name}","releases_url":"https://api.github.com/repos/mayurkale22/opencensus-java/releases{/id}","deployments_url":"https://api.github.com/repos/mayurkale22/opencensus-java/deployments","created_at":"2018-08-13T18:45:58Z","updated_at":"2018-10-26T17:07:07Z","pushed_at":"2018-10-29T23:18:00Z","git_url":"git://github.com/mayurkale22/opencensus-java.git","ssh_url":"git@github.com:mayurkale22/opencensus-java.git","clone_url":"https://github.com/mayurkale22/opencensus-java.git","svn_url":"https://github.com/mayurkale22/opencensus-java","homepage":"https://opencensus.io","size":6137,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"census-instrumentation:master","ref":"master","sha":"056069f659b4238faaaaf7b854f2b7a0a1faeb39","user":{"login":"census-instrumentation","id":26944525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2OTQ0NTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26944525?v=4","gravatar_id":"","url":"https://api.github.com/users/census-instrumentation","html_url":"https://github.com/census-instrumentation","followers_url":"https://api.github.com/users/census-instrumentation/followers","following_url":"https://api.github.com/users/census-instrumentation/following{/other_user}","gists_url":"https://api.github.com/users/census-instrumentation/gists{/gist_id}","starred_url":"https://api.github.com/users/census-instrumentation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/census-instrumentation/subscriptions","organizations_url":"https://api.github.com/users/census-instrumentation/orgs","repos_url":"https://api.github.com/users/census-instrumentation/repos","events_url":"https://api.github.com/users/census-instrumentation/events{/privacy}","received_events_url":"https://api.github.com/users/census-instrumentation/received_events","type":"Organization","site_admin":false},"repo":{"id":64431348,"node_id":"MDEwOlJlcG9zaXRvcnk2NDQzMTM0OA==","name":"opencensus-java","full_name":"census-instrumentation/opencensus-java","private":false,"owner":{"login":"census-instrumentation","id":26944525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2OTQ0NTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26944525?v=4","gravatar_id":"","url":"https://api.github.com/users/census-instrumentation","html_url":"https://github.com/census-instrumentation","followers_url":"https://api.github.com/users/census-instrumentation/followers","following_url":"https://api.github.com/users/census-instrumentation/following{/other_user}","gists_url":"https://api.github.com/users/census-instrumentation/gists{/gist_id}","starred_url":"https://api.github.com/users/census-instrumentation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/census-instrumentation/subscriptions","organizations_url":"https://api.github.com/users/census-instrumentation/orgs","repos_url":"https://api.github.com/users/census-instrumentation/repos","events_url":"https://api.github.com/users/census-instrumentation/events{/privacy}","received_events_url":"https://api.github.com/users/census-instrumentation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/census-instrumentation/opencensus-java","description":"A stats collection and distributed tracing framework","fork":false,"url":"https://api.github.com/repos/census-instrumentation/opencensus-java","forks_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/forks","keys_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/teams","hooks_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/hooks","issue_events_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/issues/events{/number}","events_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/events","assignees_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/assignees{/user}","branches_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/branches{/branch}","tags_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/tags","blobs_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/statuses/{sha}","languages_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/languages","stargazers_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/stargazers","contributors_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/contributors","subscribers_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/subscribers","subscription_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/subscription","commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/contents/{+path}","compare_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/merges","archive_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/downloads","issues_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/issues{/number}","pulls_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls{/number}","milestones_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/milestones{/number}","notifications_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/labels{/name}","releases_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/releases{/id}","deployments_url":"https://api.github.com/repos/census-instrumentation/opencensus-java/deployments","created_at":"2016-07-28T22:10:03Z","updated_at":"2018-10-30T13:53:50Z","pushed_at":"2018-10-30T13:53:46Z","git_url":"git://github.com/census-instrumentation/opencensus-java.git","ssh_url":"git@github.com:census-instrumentation/opencensus-java.git","clone_url":"https://github.com/census-instrumentation/opencensus-java.git","svn_url":"https://github.com/census-instrumentation/opencensus-java","homepage":"https://opencensus.io","size":6035,"stargazers_count":446,"watchers_count":446,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":114,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":114,"open_issues":85,"watchers":446,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/1499"},"html":{"href":"https://github.com/census-instrumentation/opencensus-java/pull/1499"},"issue":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-java/issues/1499"},"comments":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-java/issues/1499/comments"},"review_comments":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/1499/comments"},"review_comment":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-java/pulls/1499/commits"},"statuses":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-java/statuses/bbe1b2469b9ecf369025bc372fbe355c704fae4e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bogdandrutu"}}