{"action":"closed","number":1716,"pull_request":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/1716","id":193704853,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzA0ODUz","html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Android/pull/1716","diff_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Android/pull/1716.diff","patch_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Android/pull/1716.patch","issue_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/issues/1716","number":1716,"state":"closed","locked":false,"title":"PushService is now subclassable","user":{"login":"chrlie","id":5178841,"node_id":"MDQ6VXNlcjUxNzg4NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/5178841?v=4","gravatar_id":"","url":"https://api.github.com/users/chrlie","html_url":"https://github.com/chrlie","followers_url":"https://api.github.com/users/chrlie/followers","following_url":"https://api.github.com/users/chrlie/following{/other_user}","gists_url":"https://api.github.com/users/chrlie/gists{/gist_id}","starred_url":"https://api.github.com/users/chrlie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrlie/subscriptions","organizations_url":"https://api.github.com/users/chrlie/orgs","repos_url":"https://api.github.com/users/chrlie/repos","events_url":"https://api.github.com/users/chrlie/events{/privacy}","received_events_url":"https://api.github.com/users/chrlie/received_events","type":"User","site_admin":false},"body":"This allows for easier subclassing of `PushService` by overriding the methods that create requests for registration and unregistration. In order to specify that the subclass service be used, it has to be specified in the manifest (I've added an example in the Javadoc) and it has to be set with `SalesforceSDKManager.setPushServiceType`. This is because the service is started programmtically in a static method in PushMessaging and we need to know the correct class.\r\n\r\n I've also added a callback method for receiving the current registration status. This has been kept protected for subclassing purposes.","created_at":"2018-06-08T19:35:09Z","updated_at":"2018-06-08T21:58:56Z","closed_at":"2018-06-08T21:58:56Z","merged_at":"2018-06-08T21:58:56Z","merge_commit_sha":"ad59717d068b3afce3ff8dc2e46e2d15e62dfe58","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":959128852,"node_id":"MDU6TGFiZWw5NTkxMjg4NTI=","url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/labels/cla:signed","name":"cla:signed","color":"5ebc41","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/1716/commits","review_comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/1716/comments","review_comment_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/issues/1716/comments","statuses_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/statuses/4f22abaa605c868904b15d17c6cbdda6ad0e74a5","head":{"label":"chrlie:dev","ref":"dev","sha":"4f22abaa605c868904b15d17c6cbdda6ad0e74a5","user":{"login":"chrlie","id":5178841,"node_id":"MDQ6VXNlcjUxNzg4NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/5178841?v=4","gravatar_id":"","url":"https://api.github.com/users/chrlie","html_url":"https://github.com/chrlie","followers_url":"https://api.github.com/users/chrlie/followers","following_url":"https://api.github.com/users/chrlie/following{/other_user}","gists_url":"https://api.github.com/users/chrlie/gists{/gist_id}","starred_url":"https://api.github.com/users/chrlie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrlie/subscriptions","organizations_url":"https://api.github.com/users/chrlie/orgs","repos_url":"https://api.github.com/users/chrlie/repos","events_url":"https://api.github.com/users/chrlie/events{/privacy}","received_events_url":"https://api.github.com/users/chrlie/received_events","type":"User","site_admin":false},"repo":{"id":85632884,"node_id":"MDEwOlJlcG9zaXRvcnk4NTYzMjg4NA==","name":"SalesforceMobileSDK-Android","full_name":"chrlie/SalesforceMobileSDK-Android","owner":{"login":"chrlie","id":5178841,"node_id":"MDQ6VXNlcjUxNzg4NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/5178841?v=4","gravatar_id":"","url":"https://api.github.com/users/chrlie","html_url":"https://github.com/chrlie","followers_url":"https://api.github.com/users/chrlie/followers","following_url":"https://api.github.com/users/chrlie/following{/other_user}","gists_url":"https://api.github.com/users/chrlie/gists{/gist_id}","starred_url":"https://api.github.com/users/chrlie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrlie/subscriptions","organizations_url":"https://api.github.com/users/chrlie/orgs","repos_url":"https://api.github.com/users/chrlie/repos","events_url":"https://api.github.com/users/chrlie/events{/privacy}","received_events_url":"https://api.github.com/users/chrlie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrlie/SalesforceMobileSDK-Android","description":"Android SDK for Salesforce","fork":true,"url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android","forks_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/forks","keys_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/teams","hooks_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/hooks","issue_events_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/issues/events{/number}","events_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/events","assignees_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/assignees{/user}","branches_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/branches{/branch}","tags_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/tags","blobs_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/languages","stargazers_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/stargazers","contributors_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/contributors","subscribers_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/subscribers","subscription_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/subscription","commits_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/contents/{+path}","compare_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/merges","archive_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/downloads","issues_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/issues{/number}","pulls_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/labels{/name}","releases_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/releases{/id}","deployments_url":"https://api.github.com/repos/chrlie/SalesforceMobileSDK-Android/deployments","created_at":"2017-03-20T22:19:29Z","updated_at":"2017-03-20T22:19:32Z","pushed_at":"2018-06-08T21:42:55Z","git_url":"git://github.com/chrlie/SalesforceMobileSDK-Android.git","ssh_url":"git@github.com:chrlie/SalesforceMobileSDK-Android.git","clone_url":"https://github.com/chrlie/SalesforceMobileSDK-Android.git","svn_url":"https://github.com/chrlie/SalesforceMobileSDK-Android","homepage":"","size":64912,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"forcedotcom:dev","ref":"dev","sha":"2dff2fdb85cd2283d1d34d602d56036e85b751ee","user":{"login":"forcedotcom","id":464563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NDU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"repo":{"id":2782691,"node_id":"MDEwOlJlcG9zaXRvcnkyNzgyNjkx","name":"SalesforceMobileSDK-Android","full_name":"forcedotcom/SalesforceMobileSDK-Android","owner":{"login":"forcedotcom","id":464563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NDU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Android","description":"Android SDK for Salesforce","fork":false,"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android","forks_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/forks","keys_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/teams","hooks_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/hooks","issue_events_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/issues/events{/number}","events_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/events","assignees_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/assignees{/user}","branches_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/branches{/branch}","tags_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/tags","blobs_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/languages","stargazers_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/stargazers","contributors_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/contributors","subscribers_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/subscribers","subscription_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/subscription","commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/contents/{+path}","compare_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/merges","archive_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/downloads","issues_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/issues{/number}","pulls_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/labels{/name}","releases_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/releases{/id}","deployments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/deployments","created_at":"2011-11-15T19:35:05Z","updated_at":"2018-05-21T22:56:38Z","pushed_at":"2018-06-08T21:58:56Z","git_url":"git://github.com/forcedotcom/SalesforceMobileSDK-Android.git","ssh_url":"git@github.com:forcedotcom/SalesforceMobileSDK-Android.git","clone_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Android.git","svn_url":"https://github.com/forcedotcom/SalesforceMobileSDK-Android","homepage":"","size":66406,"stargazers_count":233,"watchers_count":233,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":321,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":321,"open_issues":9,"watchers":233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/1716"},"html":{"href":"https://github.com/forcedotcom/SalesforceMobileSDK-Android/pull/1716"},"issue":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/issues/1716"},"comments":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/issues/1716/comments"},"review_comments":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/1716/comments"},"review_comment":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/pulls/1716/commits"},"statuses":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-Android/statuses/4f22abaa605c868904b15d17c6cbdda6ad0e74a5"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bhariharan","id":1820287,"node_id":"MDQ6VXNlcjE4MjAyODc=","avatar_url":"https://avatars1.githubusercontent.com/u/1820287?v=4","gravatar_id":"","url":"https://api.github.com/users/bhariharan","html_url":"https://github.com/bhariharan","followers_url":"https://api.github.com/users/bhariharan/followers","following_url":"https://api.github.com/users/bhariharan/following{/other_user}","gists_url":"https://api.github.com/users/bhariharan/gists{/gist_id}","starred_url":"https://api.github.com/users/bhariharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhariharan/subscriptions","organizations_url":"https://api.github.com/users/bhariharan/orgs","repos_url":"https://api.github.com/users/bhariharan/repos","events_url":"https://api.github.com/users/bhariharan/events{/privacy}","received_events_url":"https://api.github.com/users/bhariharan/received_events","type":"User","site_admin":false},"comments":2,"review_comments":1,"maintainer_can_modify":false,"commits":4,"additions":121,"deletions":12,"changed_files":2}}
{"actor":{"display_login":"bhariharan"}}