{"action":"created","comment":{"url":"https://api.github.com/repos/lounick/orchestrator/pulls/comments/207529399","pull_request_review_id":143157543,"id":207529399,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzUyOTM5OQ==","diff_hunk":"@@ -1090,6 +1141,11 @@ def InvokeOcarinaMakefiles(\n                         base = os.path.basename(ss)\n                         baseDir = os.path.splitext(base)[0]\n                         externals += g_absOutputDir + os.sep + baseDir + os.sep + \"ext\" + os.sep + '*.o '\n+                for ss in rosBridgeSubsystems:\n+                    if ss == aplc:\n+                        base = os.path.basename(ss)\n+                        baseDir = os.path.splitext(base)[0]\n+                        externals += g_absOutputDir + os.sep + baseDir + os.sep + \"ext\" + os.sep + '*.o '","path":"orchestrator/taste-orchestrator.py","position":115,"original_position":115,"commit_id":"4875dfcee6d444982c2f44097924ecfb21cb2f46","original_commit_id":"4875dfcee6d444982c2f44097924ecfb21cb2f46","user":{"login":"kevindm","id":22317315,"node_id":"MDQ6VXNlcjIyMzE3MzE1","avatar_url":"https://avatars3.githubusercontent.com/u/22317315?v=4","gravatar_id":"","url":"https://api.github.com/users/kevindm","html_url":"https://github.com/kevindm","followers_url":"https://api.github.com/users/kevindm/followers","following_url":"https://api.github.com/users/kevindm/following{/other_user}","gists_url":"https://api.github.com/users/kevindm/gists{/gist_id}","starred_url":"https://api.github.com/users/kevindm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevindm/subscriptions","organizations_url":"https://api.github.com/users/kevindm/orgs","repos_url":"https://api.github.com/users/kevindm/repos","events_url":"https://api.github.com/users/kevindm/events{/privacy}","received_events_url":"https://api.github.com/users/kevindm/received_events","type":"User","site_admin":false},"body":"Taste wise, I'd prefer `os.sep.join(...)` and consistency in string quotation style.","created_at":"2018-08-03T12:31:16Z","updated_at":"2018-08-03T12:44:10Z","html_url":"https://github.com/lounick/orchestrator/pull/1#discussion_r207529399","pull_request_url":"https://api.github.com/repos/lounick/orchestrator/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/lounick/orchestrator/pulls/comments/207529399"},"html":{"href":"https://github.com/lounick/orchestrator/pull/1#discussion_r207529399"},"pull_request":{"href":"https://api.github.com/repos/lounick/orchestrator/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/lounick/orchestrator/pulls/1","id":206004296,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDA0Mjk2","html_url":"https://github.com/lounick/orchestrator/pull/1","diff_url":"https://github.com/lounick/orchestrator/pull/1.diff","patch_url":"https://github.com/lounick/orchestrator/pull/1.patch","issue_url":"https://api.github.com/repos/lounick/orchestrator/issues/1","number":1,"state":"open","locked":false,"title":"Rosbridge integration","user":{"login":"lounick","id":1877437,"node_id":"MDQ6VXNlcjE4Nzc0Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1877437?v=4","gravatar_id":"","url":"https://api.github.com/users/lounick","html_url":"https://github.com/lounick","followers_url":"https://api.github.com/users/lounick/followers","following_url":"https://api.github.com/users/lounick/following{/other_user}","gists_url":"https://api.github.com/users/lounick/gists{/gist_id}","starred_url":"https://api.github.com/users/lounick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lounick/subscriptions","organizations_url":"https://api.github.com/users/lounick/orgs","repos_url":"https://api.github.com/users/lounick/repos","events_url":"https://api.github.com/users/lounick/events{/privacy}","received_events_url":"https://api.github.com/users/lounick/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-03T11:37:02Z","updated_at":"2018-08-03T12:44:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc56a869d13d5a9417d0282b9f1901d86bdd2b6c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lounick/orchestrator/pulls/1/commits","review_comments_url":"https://api.github.com/repos/lounick/orchestrator/pulls/1/comments","review_comment_url":"https://api.github.com/repos/lounick/orchestrator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lounick/orchestrator/issues/1/comments","statuses_url":"https://api.github.com/repos/lounick/orchestrator/statuses/4875dfcee6d444982c2f44097924ecfb21cb2f46","head":{"label":"lounick:rosbridge_integration","ref":"rosbridge_integration","sha":"4875dfcee6d444982c2f44097924ecfb21cb2f46","user":{"login":"lounick","id":1877437,"node_id":"MDQ6VXNlcjE4Nzc0Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1877437?v=4","gravatar_id":"","url":"https://api.github.com/users/lounick","html_url":"https://github.com/lounick","followers_url":"https://api.github.com/users/lounick/followers","following_url":"https://api.github.com/users/lounick/following{/other_user}","gists_url":"https://api.github.com/users/lounick/gists{/gist_id}","starred_url":"https://api.github.com/users/lounick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lounick/subscriptions","organizations_url":"https://api.github.com/users/lounick/orgs","repos_url":"https://api.github.com/users/lounick/repos","events_url":"https://api.github.com/users/lounick/events{/privacy}","received_events_url":"https://api.github.com/users/lounick/received_events","type":"User","site_admin":false},"repo":{"id":142439067,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0MzkwNjc=","name":"orchestrator","full_name":"lounick/orchestrator","owner":{"login":"lounick","id":1877437,"node_id":"MDQ6VXNlcjE4Nzc0Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1877437?v=4","gravatar_id":"","url":"https://api.github.com/users/lounick","html_url":"https://github.com/lounick","followers_url":"https://api.github.com/users/lounick/followers","following_url":"https://api.github.com/users/lounick/following{/other_user}","gists_url":"https://api.github.com/users/lounick/gists{/gist_id}","starred_url":"https://api.github.com/users/lounick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lounick/subscriptions","organizations_url":"https://api.github.com/users/lounick/orgs","repos_url":"https://api.github.com/users/lounick/repos","events_url":"https://api.github.com/users/lounick/events{/privacy}","received_events_url":"https://api.github.com/users/lounick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lounick/orchestrator","description":null,"fork":false,"url":"https://api.github.com/repos/lounick/orchestrator","forks_url":"https://api.github.com/repos/lounick/orchestrator/forks","keys_url":"https://api.github.com/repos/lounick/orchestrator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lounick/orchestrator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lounick/orchestrator/teams","hooks_url":"https://api.github.com/repos/lounick/orchestrator/hooks","issue_events_url":"https://api.github.com/repos/lounick/orchestrator/issues/events{/number}","events_url":"https://api.github.com/repos/lounick/orchestrator/events","assignees_url":"https://api.github.com/repos/lounick/orchestrator/assignees{/user}","branches_url":"https://api.github.com/repos/lounick/orchestrator/branches{/branch}","tags_url":"https://api.github.com/repos/lounick/orchestrator/tags","blobs_url":"https://api.github.com/repos/lounick/orchestrator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lounick/orchestrator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lounick/orchestrator/git/refs{/sha}","trees_url":"https://api.github.com/repos/lounick/orchestrator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lounick/orchestrator/statuses/{sha}","languages_url":"https://api.github.com/repos/lounick/orchestrator/languages","stargazers_url":"https://api.github.com/repos/lounick/orchestrator/stargazers","contributors_url":"https://api.github.com/repos/lounick/orchestrator/contributors","subscribers_url":"https://api.github.com/repos/lounick/orchestrator/subscribers","subscription_url":"https://api.github.com/repos/lounick/orchestrator/subscription","commits_url":"https://api.github.com/repos/lounick/orchestrator/commits{/sha}","git_commits_url":"https://api.github.com/repos/lounick/orchestrator/git/commits{/sha}","comments_url":"https://api.github.com/repos/lounick/orchestrator/comments{/number}","issue_comment_url":"https://api.github.com/repos/lounick/orchestrator/issues/comments{/number}","contents_url":"https://api.github.com/repos/lounick/orchestrator/contents/{+path}","compare_url":"https://api.github.com/repos/lounick/orchestrator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lounick/orchestrator/merges","archive_url":"https://api.github.com/repos/lounick/orchestrator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lounick/orchestrator/downloads","issues_url":"https://api.github.com/repos/lounick/orchestrator/issues{/number}","pulls_url":"https://api.github.com/repos/lounick/orchestrator/pulls{/number}","milestones_url":"https://api.github.com/repos/lounick/orchestrator/milestones{/number}","notifications_url":"https://api.github.com/repos/lounick/orchestrator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lounick/orchestrator/labels{/name}","releases_url":"https://api.github.com/repos/lounick/orchestrator/releases{/id}","deployments_url":"https://api.github.com/repos/lounick/orchestrator/deployments","created_at":"2018-07-26T12:39:28Z","updated_at":"2018-07-26T12:40:46Z","pushed_at":"2018-08-03T11:37:02Z","git_url":"git://github.com/lounick/orchestrator.git","ssh_url":"git@github.com:lounick/orchestrator.git","clone_url":"https://github.com/lounick/orchestrator.git","svn_url":"https://github.com/lounick/orchestrator","homepage":null,"size":80,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"lounick:master","ref":"master","sha":"a3f46ff9fa4d9678f0865e17ce9c3961193f2786","user":{"login":"lounick","id":1877437,"node_id":"MDQ6VXNlcjE4Nzc0Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1877437?v=4","gravatar_id":"","url":"https://api.github.com/users/lounick","html_url":"https://github.com/lounick","followers_url":"https://api.github.com/users/lounick/followers","following_url":"https://api.github.com/users/lounick/following{/other_user}","gists_url":"https://api.github.com/users/lounick/gists{/gist_id}","starred_url":"https://api.github.com/users/lounick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lounick/subscriptions","organizations_url":"https://api.github.com/users/lounick/orgs","repos_url":"https://api.github.com/users/lounick/repos","events_url":"https://api.github.com/users/lounick/events{/privacy}","received_events_url":"https://api.github.com/users/lounick/received_events","type":"User","site_admin":false},"repo":{"id":142439067,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0MzkwNjc=","name":"orchestrator","full_name":"lounick/orchestrator","owner":{"login":"lounick","id":1877437,"node_id":"MDQ6VXNlcjE4Nzc0Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1877437?v=4","gravatar_id":"","url":"https://api.github.com/users/lounick","html_url":"https://github.com/lounick","followers_url":"https://api.github.com/users/lounick/followers","following_url":"https://api.github.com/users/lounick/following{/other_user}","gists_url":"https://api.github.com/users/lounick/gists{/gist_id}","starred_url":"https://api.github.com/users/lounick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lounick/subscriptions","organizations_url":"https://api.github.com/users/lounick/orgs","repos_url":"https://api.github.com/users/lounick/repos","events_url":"https://api.github.com/users/lounick/events{/privacy}","received_events_url":"https://api.github.com/users/lounick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lounick/orchestrator","description":null,"fork":false,"url":"https://api.github.com/repos/lounick/orchestrator","forks_url":"https://api.github.com/repos/lounick/orchestrator/forks","keys_url":"https://api.github.com/repos/lounick/orchestrator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lounick/orchestrator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lounick/orchestrator/teams","hooks_url":"https://api.github.com/repos/lounick/orchestrator/hooks","issue_events_url":"https://api.github.com/repos/lounick/orchestrator/issues/events{/number}","events_url":"https://api.github.com/repos/lounick/orchestrator/events","assignees_url":"https://api.github.com/repos/lounick/orchestrator/assignees{/user}","branches_url":"https://api.github.com/repos/lounick/orchestrator/branches{/branch}","tags_url":"https://api.github.com/repos/lounick/orchestrator/tags","blobs_url":"https://api.github.com/repos/lounick/orchestrator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lounick/orchestrator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lounick/orchestrator/git/refs{/sha}","trees_url":"https://api.github.com/repos/lounick/orchestrator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lounick/orchestrator/statuses/{sha}","languages_url":"https://api.github.com/repos/lounick/orchestrator/languages","stargazers_url":"https://api.github.com/repos/lounick/orchestrator/stargazers","contributors_url":"https://api.github.com/repos/lounick/orchestrator/contributors","subscribers_url":"https://api.github.com/repos/lounick/orchestrator/subscribers","subscription_url":"https://api.github.com/repos/lounick/orchestrator/subscription","commits_url":"https://api.github.com/repos/lounick/orchestrator/commits{/sha}","git_commits_url":"https://api.github.com/repos/lounick/orchestrator/git/commits{/sha}","comments_url":"https://api.github.com/repos/lounick/orchestrator/comments{/number}","issue_comment_url":"https://api.github.com/repos/lounick/orchestrator/issues/comments{/number}","contents_url":"https://api.github.com/repos/lounick/orchestrator/contents/{+path}","compare_url":"https://api.github.com/repos/lounick/orchestrator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lounick/orchestrator/merges","archive_url":"https://api.github.com/repos/lounick/orchestrator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lounick/orchestrator/downloads","issues_url":"https://api.github.com/repos/lounick/orchestrator/issues{/number}","pulls_url":"https://api.github.com/repos/lounick/orchestrator/pulls{/number}","milestones_url":"https://api.github.com/repos/lounick/orchestrator/milestones{/number}","notifications_url":"https://api.github.com/repos/lounick/orchestrator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lounick/orchestrator/labels{/name}","releases_url":"https://api.github.com/repos/lounick/orchestrator/releases{/id}","deployments_url":"https://api.github.com/repos/lounick/orchestrator/deployments","created_at":"2018-07-26T12:39:28Z","updated_at":"2018-07-26T12:40:46Z","pushed_at":"2018-08-03T11:37:02Z","git_url":"git://github.com/lounick/orchestrator.git","ssh_url":"git@github.com:lounick/orchestrator.git","clone_url":"https://github.com/lounick/orchestrator.git","svn_url":"https://github.com/lounick/orchestrator","homepage":null,"size":80,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lounick/orchestrator/pulls/1"},"html":{"href":"https://github.com/lounick/orchestrator/pull/1"},"issue":{"href":"https://api.github.com/repos/lounick/orchestrator/issues/1"},"comments":{"href":"https://api.github.com/repos/lounick/orchestrator/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/lounick/orchestrator/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/lounick/orchestrator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lounick/orchestrator/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/lounick/orchestrator/statuses/4875dfcee6d444982c2f44097924ecfb21cb2f46"}},"author_association":"OWNER"}}
{"actor":{"display_login":"kevindm"}}