{"action":"created","issue":{"url":"https://api.github.com/repos/curl/curl/issues/2180","repository_url":"https://api.github.com/repos/curl/curl","labels_url":"https://api.github.com/repos/curl/curl/issues/2180/labels{/name}","comments_url":"https://api.github.com/repos/curl/curl/issues/2180/comments","events_url":"https://api.github.com/repos/curl/curl/issues/2180/events","html_url":"https://github.com/curl/curl/pull/2180","id":282729933,"number":2180,"title":"MacOSX-Framework: Added --without-ca-bundle to configure lines","user":{"login":"sbrokenshire","id":20288364,"avatar_url":"https://avatars3.githubusercontent.com/u/20288364?v=4","gravatar_id":"","url":"https://api.github.com/users/sbrokenshire","html_url":"https://github.com/sbrokenshire","followers_url":"https://api.github.com/users/sbrokenshire/followers","following_url":"https://api.github.com/users/sbrokenshire/following{/other_user}","gists_url":"https://api.github.com/users/sbrokenshire/gists{/gist_id}","starred_url":"https://api.github.com/users/sbrokenshire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbrokenshire/subscriptions","organizations_url":"https://api.github.com/users/sbrokenshire/orgs","repos_url":"https://api.github.com/users/sbrokenshire/repos","events_url":"https://api.github.com/users/sbrokenshire/events{/privacy}","received_events_url":"https://api.github.com/users/sbrokenshire/received_events","type":"User","site_admin":false},"labels":[{"id":184118221,"url":"https://api.github.com/repos/curl/curl/labels/SSL/TLS","name":"SSL/TLS","color":"bfdadc","default":false},{"id":184118182,"url":"https://api.github.com/repos/curl/curl/labels/build","name":"build","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-12-17T22:37:09Z","updated_at":"2018-02-14T23:57:00Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/curl/curl/pulls/2180","html_url":"https://github.com/curl/curl/pull/2180","diff_url":"https://github.com/curl/curl/pull/2180.diff","patch_url":"https://github.com/curl/curl/pull/2180.patch"},"body":"When I'm using my own libcurl built with the MacOSX-Framework script in my applications I've found that in Sierra at least, the included libcurl installation is configured with --without-ca-bundle while a framework produced from MacOSX-Framework doesn't.\r\n\r\nBecause of that, it is producing different results (cURL error code 51, SSL code 5) instead of outputting page data when attempting to connect to a server with a self-signed certificate that is already trusted in a keychain because it's looking in /etc/ssl/cert.pem instead of the keychains. Looking at /etc/ssl/cert.pem seems to be a really bad idea as certain valid certificates in the System Roots keychain are not appearing in the file (Sierra at least) which should be like the Deutsche Telekom, Certum and Visa ones for example.\r\n\r\nThe pull request is simply adding --without-ca-bundle to the configure lines in the MacOSX-Framework script so that it looks at the keychains instead of /etc/ssl/cert.pem.\r\n\r\nPotential problem is issue #2103 - Apple has swapped SecureTransport for BoringSSL in High Sierra - based on this I'll test it on High Sierra and update this part of the pull request message.\r\n\r\nI'm assuming that MacOSX-Framework should still be using SecureTransport?"},"comment":{"url":"https://api.github.com/repos/curl/curl/issues/comments/365784853","html_url":"https://github.com/curl/curl/pull/2180#issuecomment-365784853","issue_url":"https://api.github.com/repos/curl/curl/issues/2180","id":365784853,"user":{"login":"sbrokenshire","id":20288364,"avatar_url":"https://avatars3.githubusercontent.com/u/20288364?v=4","gravatar_id":"","url":"https://api.github.com/users/sbrokenshire","html_url":"https://github.com/sbrokenshire","followers_url":"https://api.github.com/users/sbrokenshire/followers","following_url":"https://api.github.com/users/sbrokenshire/following{/other_user}","gists_url":"https://api.github.com/users/sbrokenshire/gists{/gist_id}","starred_url":"https://api.github.com/users/sbrokenshire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbrokenshire/subscriptions","organizations_url":"https://api.github.com/users/sbrokenshire/orgs","repos_url":"https://api.github.com/users/sbrokenshire/repos","events_url":"https://api.github.com/users/sbrokenshire/events{/privacy}","received_events_url":"https://api.github.com/users/sbrokenshire/received_events","type":"User","site_admin":false},"created_at":"2018-02-14T23:57:00Z","updated_at":"2018-02-14T23:57:00Z","author_association":"CONTRIBUTOR","body":"I like the CURLOPT_USE_CA_CERT_STORE option name. Clearly tells me that libcurl should use the native certificate store over the other backends that use the CA bundle. :)"}}
{"actor":{"display_login":"sbrokenshire"}}