{"action":"created","comment":{"url":"https://api.github.com/repos/mlpack/mlpack/pulls/comments/192815018","pull_request_review_id":125662935,"id":192815018,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjgxNTAxOA==","diff_hunk":"@@ -0,0 +1,116 @@\n+/**\n+ * @file sampling_impl.hpp\n+ * @author Atharva Khandait\n+ *\n+ * Implementation of the Sampling class which samples from parameters for a given\n+ * distribution.\n+ *\n+ * mlpack is free software; you may redistribute it and/or modify it under the\n+ * terms of the 3-clause BSD license.  You should have received a copy of the\n+ * 3-clause BSD license along with mlpack.  If not, see\n+ * http://www.opensource.org/licenses/BSD-3-Clause for more information.\n+ */\n+#ifndef MLPACK_METHODS_ANN_LAYER_SAMPLING_IMPL_HPP\n+#define MLPACK_METHODS_ANN_LAYER_SAMPLING_IMPL_HPP\n+\n+// In case it hasn't yet been included.\n+#include \"sampling.hpp\"\n+\n+namespace mlpack {\n+namespace ann /** Artificial Neural Network. */ {\n+\n+template<typename InputDataType, typename OutputDataType>\n+Sampling<InputDataType, OutputDataType>::Sampling()\n+{\n+  // Nothing to do here.\n+}\n+\n+template <typename InputDataType, typename OutputDataType>\n+Sampling<InputDataType, OutputDataType>::Sampling(","path":"src/mlpack/methods/ann/layer/sampling_impl.hpp","position":29,"original_position":29,"commit_id":"8da863e21c4b8cd6ea7bdb989ac0a17fc3308ba0","original_commit_id":"8da863e21c4b8cd6ea7bdb989ac0a17fc3308ba0","user":{"login":"sumedhghaisas","id":5289793,"node_id":"MDQ6VXNlcjUyODk3OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5289793?v=4","gravatar_id":"","url":"https://api.github.com/users/sumedhghaisas","html_url":"https://github.com/sumedhghaisas","followers_url":"https://api.github.com/users/sumedhghaisas/followers","following_url":"https://api.github.com/users/sumedhghaisas/following{/other_user}","gists_url":"https://api.github.com/users/sumedhghaisas/gists{/gist_id}","starred_url":"https://api.github.com/users/sumedhghaisas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumedhghaisas/subscriptions","organizations_url":"https://api.github.com/users/sumedhghaisas/orgs","repos_url":"https://api.github.com/users/sumedhghaisas/repos","events_url":"https://api.github.com/users/sumedhghaisas/events{/privacy}","received_events_url":"https://api.github.com/users/sumedhghaisas/received_events","type":"User","site_admin":false},"body":"Is there any specific case in which this constructor will be used? I think the constructor which accepts only the size should suffice. ","created_at":"2018-06-04T17:08:46Z","updated_at":"2018-06-04T17:19:53Z","html_url":"https://github.com/mlpack/mlpack/pull/1420#discussion_r192815018","pull_request_url":"https://api.github.com/repos/mlpack/mlpack/pulls/1420","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/comments/192815018"},"html":{"href":"https://github.com/mlpack/mlpack/pull/1420#discussion_r192815018"},"pull_request":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/1420"}}},"pull_request":{"url":"https://api.github.com/repos/mlpack/mlpack/pulls/1420","id":192319572,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMzE5NTcy","html_url":"https://github.com/mlpack/mlpack/pull/1420","diff_url":"https://github.com/mlpack/mlpack/pull/1420.diff","patch_url":"https://github.com/mlpack/mlpack/pull/1420.patch","issue_url":"https://api.github.com/repos/mlpack/mlpack/issues/1420","number":1420,"state":"open","locked":false,"title":"[WIP] Add a Sampling layer, implement KL divergence in it ","user":{"login":"akhandait","id":27204270,"node_id":"MDQ6VXNlcjI3MjA0Mjcw","avatar_url":"https://avatars2.githubusercontent.com/u/27204270?v=4","gravatar_id":"","url":"https://api.github.com/users/akhandait","html_url":"https://github.com/akhandait","followers_url":"https://api.github.com/users/akhandait/followers","following_url":"https://api.github.com/users/akhandait/following{/other_user}","gists_url":"https://api.github.com/users/akhandait/gists{/gist_id}","starred_url":"https://api.github.com/users/akhandait/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhandait/subscriptions","organizations_url":"https://api.github.com/users/akhandait/orgs","repos_url":"https://api.github.com/users/akhandait/repos","events_url":"https://api.github.com/users/akhandait/events{/privacy}","received_events_url":"https://api.github.com/users/akhandait/received_events","type":"User","site_admin":false},"body":"I will add the backward function for KL divergence soon. @sumedhghaisas ","created_at":"2018-06-04T07:29:01Z","updated_at":"2018-06-04T17:19:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"341047101647b8e844db45e7a4c3e546d924417c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mlpack/mlpack/pulls/1420/commits","review_comments_url":"https://api.github.com/repos/mlpack/mlpack/pulls/1420/comments","review_comment_url":"https://api.github.com/repos/mlpack/mlpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mlpack/mlpack/issues/1420/comments","statuses_url":"https://api.github.com/repos/mlpack/mlpack/statuses/8da863e21c4b8cd6ea7bdb989ac0a17fc3308ba0","head":{"label":"akhandait:sampling","ref":"sampling","sha":"8da863e21c4b8cd6ea7bdb989ac0a17fc3308ba0","user":{"login":"akhandait","id":27204270,"node_id":"MDQ6VXNlcjI3MjA0Mjcw","avatar_url":"https://avatars2.githubusercontent.com/u/27204270?v=4","gravatar_id":"","url":"https://api.github.com/users/akhandait","html_url":"https://github.com/akhandait","followers_url":"https://api.github.com/users/akhandait/followers","following_url":"https://api.github.com/users/akhandait/following{/other_user}","gists_url":"https://api.github.com/users/akhandait/gists{/gist_id}","starred_url":"https://api.github.com/users/akhandait/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhandait/subscriptions","organizations_url":"https://api.github.com/users/akhandait/orgs","repos_url":"https://api.github.com/users/akhandait/repos","events_url":"https://api.github.com/users/akhandait/events{/privacy}","received_events_url":"https://api.github.com/users/akhandait/received_events","type":"User","site_admin":false},"repo":{"id":120950616,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA5NTA2MTY=","name":"mlpack","full_name":"akhandait/mlpack","owner":{"login":"akhandait","id":27204270,"node_id":"MDQ6VXNlcjI3MjA0Mjcw","avatar_url":"https://avatars2.githubusercontent.com/u/27204270?v=4","gravatar_id":"","url":"https://api.github.com/users/akhandait","html_url":"https://github.com/akhandait","followers_url":"https://api.github.com/users/akhandait/followers","following_url":"https://api.github.com/users/akhandait/following{/other_user}","gists_url":"https://api.github.com/users/akhandait/gists{/gist_id}","starred_url":"https://api.github.com/users/akhandait/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhandait/subscriptions","organizations_url":"https://api.github.com/users/akhandait/orgs","repos_url":"https://api.github.com/users/akhandait/repos","events_url":"https://api.github.com/users/akhandait/events{/privacy}","received_events_url":"https://api.github.com/users/akhandait/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akhandait/mlpack","description":"mlpack: a scalable C++ machine learning library -- ","fork":true,"url":"https://api.github.com/repos/akhandait/mlpack","forks_url":"https://api.github.com/repos/akhandait/mlpack/forks","keys_url":"https://api.github.com/repos/akhandait/mlpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akhandait/mlpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akhandait/mlpack/teams","hooks_url":"https://api.github.com/repos/akhandait/mlpack/hooks","issue_events_url":"https://api.github.com/repos/akhandait/mlpack/issues/events{/number}","events_url":"https://api.github.com/repos/akhandait/mlpack/events","assignees_url":"https://api.github.com/repos/akhandait/mlpack/assignees{/user}","branches_url":"https://api.github.com/repos/akhandait/mlpack/branches{/branch}","tags_url":"https://api.github.com/repos/akhandait/mlpack/tags","blobs_url":"https://api.github.com/repos/akhandait/mlpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akhandait/mlpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akhandait/mlpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/akhandait/mlpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akhandait/mlpack/statuses/{sha}","languages_url":"https://api.github.com/repos/akhandait/mlpack/languages","stargazers_url":"https://api.github.com/repos/akhandait/mlpack/stargazers","contributors_url":"https://api.github.com/repos/akhandait/mlpack/contributors","subscribers_url":"https://api.github.com/repos/akhandait/mlpack/subscribers","subscription_url":"https://api.github.com/repos/akhandait/mlpack/subscription","commits_url":"https://api.github.com/repos/akhandait/mlpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/akhandait/mlpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/akhandait/mlpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/akhandait/mlpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/akhandait/mlpack/contents/{+path}","compare_url":"https://api.github.com/repos/akhandait/mlpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akhandait/mlpack/merges","archive_url":"https://api.github.com/repos/akhandait/mlpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akhandait/mlpack/downloads","issues_url":"https://api.github.com/repos/akhandait/mlpack/issues{/number}","pulls_url":"https://api.github.com/repos/akhandait/mlpack/pulls{/number}","milestones_url":"https://api.github.com/repos/akhandait/mlpack/milestones{/number}","notifications_url":"https://api.github.com/repos/akhandait/mlpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akhandait/mlpack/labels{/name}","releases_url":"https://api.github.com/repos/akhandait/mlpack/releases{/id}","deployments_url":"https://api.github.com/repos/akhandait/mlpack/deployments","created_at":"2018-02-09T20:09:33Z","updated_at":"2018-05-28T08:10:46Z","pushed_at":"2018-06-04T11:30:40Z","git_url":"git://github.com/akhandait/mlpack.git","ssh_url":"git@github.com:akhandait/mlpack.git","clone_url":"https://github.com/akhandait/mlpack.git","svn_url":"https://github.com/akhandait/mlpack","homepage":"http://www.mlpack.org/","size":243604,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mlpack:master","ref":"master","sha":"9d1f364cc4c611c31091bcb03b64f89ac3ee2d4e","user":{"login":"mlpack","id":10216045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjE2MDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10216045?v=4","gravatar_id":"","url":"https://api.github.com/users/mlpack","html_url":"https://github.com/mlpack","followers_url":"https://api.github.com/users/mlpack/followers","following_url":"https://api.github.com/users/mlpack/following{/other_user}","gists_url":"https://api.github.com/users/mlpack/gists{/gist_id}","starred_url":"https://api.github.com/users/mlpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlpack/subscriptions","organizations_url":"https://api.github.com/users/mlpack/orgs","repos_url":"https://api.github.com/users/mlpack/repos","events_url":"https://api.github.com/users/mlpack/events{/privacy}","received_events_url":"https://api.github.com/users/mlpack/received_events","type":"Organization","site_admin":false},"repo":{"id":28149409,"node_id":"MDEwOlJlcG9zaXRvcnkyODE0OTQwOQ==","name":"mlpack","full_name":"mlpack/mlpack","owner":{"login":"mlpack","id":10216045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjE2MDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10216045?v=4","gravatar_id":"","url":"https://api.github.com/users/mlpack","html_url":"https://github.com/mlpack","followers_url":"https://api.github.com/users/mlpack/followers","following_url":"https://api.github.com/users/mlpack/following{/other_user}","gists_url":"https://api.github.com/users/mlpack/gists{/gist_id}","starred_url":"https://api.github.com/users/mlpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlpack/subscriptions","organizations_url":"https://api.github.com/users/mlpack/orgs","repos_url":"https://api.github.com/users/mlpack/repos","events_url":"https://api.github.com/users/mlpack/events{/privacy}","received_events_url":"https://api.github.com/users/mlpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mlpack/mlpack","description":"mlpack: a scalable C++ machine learning library -- ","fork":false,"url":"https://api.github.com/repos/mlpack/mlpack","forks_url":"https://api.github.com/repos/mlpack/mlpack/forks","keys_url":"https://api.github.com/repos/mlpack/mlpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlpack/mlpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlpack/mlpack/teams","hooks_url":"https://api.github.com/repos/mlpack/mlpack/hooks","issue_events_url":"https://api.github.com/repos/mlpack/mlpack/issues/events{/number}","events_url":"https://api.github.com/repos/mlpack/mlpack/events","assignees_url":"https://api.github.com/repos/mlpack/mlpack/assignees{/user}","branches_url":"https://api.github.com/repos/mlpack/mlpack/branches{/branch}","tags_url":"https://api.github.com/repos/mlpack/mlpack/tags","blobs_url":"https://api.github.com/repos/mlpack/mlpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlpack/mlpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlpack/mlpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlpack/mlpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlpack/mlpack/statuses/{sha}","languages_url":"https://api.github.com/repos/mlpack/mlpack/languages","stargazers_url":"https://api.github.com/repos/mlpack/mlpack/stargazers","contributors_url":"https://api.github.com/repos/mlpack/mlpack/contributors","subscribers_url":"https://api.github.com/repos/mlpack/mlpack/subscribers","subscription_url":"https://api.github.com/repos/mlpack/mlpack/subscription","commits_url":"https://api.github.com/repos/mlpack/mlpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlpack/mlpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlpack/mlpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlpack/mlpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlpack/mlpack/contents/{+path}","compare_url":"https://api.github.com/repos/mlpack/mlpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlpack/mlpack/merges","archive_url":"https://api.github.com/repos/mlpack/mlpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlpack/mlpack/downloads","issues_url":"https://api.github.com/repos/mlpack/mlpack/issues{/number}","pulls_url":"https://api.github.com/repos/mlpack/mlpack/pulls{/number}","milestones_url":"https://api.github.com/repos/mlpack/mlpack/milestones{/number}","notifications_url":"https://api.github.com/repos/mlpack/mlpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlpack/mlpack/labels{/name}","releases_url":"https://api.github.com/repos/mlpack/mlpack/releases{/id}","deployments_url":"https://api.github.com/repos/mlpack/mlpack/deployments","created_at":"2014-12-17T18:16:59Z","updated_at":"2018-06-04T14:40:12Z","pushed_at":"2018-06-04T15:47:53Z","git_url":"git://github.com/mlpack/mlpack.git","ssh_url":"git@github.com:mlpack/mlpack.git","clone_url":"https://github.com/mlpack/mlpack.git","svn_url":"https://github.com/mlpack/mlpack","homepage":"http://www.mlpack.org/","size":243556,"stargazers_count":2217,"watchers_count":2217,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":813,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":813,"open_issues":112,"watchers":2217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/1420"},"html":{"href":"https://github.com/mlpack/mlpack/pull/1420"},"issue":{"href":"https://api.github.com/repos/mlpack/mlpack/issues/1420"},"comments":{"href":"https://api.github.com/repos/mlpack/mlpack/issues/1420/comments"},"review_comments":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/1420/comments"},"review_comment":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/1420/commits"},"statuses":{"href":"https://api.github.com/repos/mlpack/mlpack/statuses/8da863e21c4b8cd6ea7bdb989ac0a17fc3308ba0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sumedhghaisas"}}