{"action":"created","comment":{"url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/pulls/comments/214753954","pull_request_review_id":151872092,"id":214753954,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDc1Mzk1NA==","diff_hunk":"@@ -0,0 +1,545 @@\n+#ifndef AMCPP_CPPCON_2018_MATRIX_HPP\n+#define AMCPP_CPPCON_2018_MATRIX_HPP\n+\n+#include <array>\n+#include <complex>\n+#include <gsl/gsl>\n+#include <range/v3/all.hpp>\n+\n+namespace amcpp {\n+   namespace view = ranges::view;\n+   namespace action = ranges::action;\n+\n+   /// \\brief\n+   /// \\tparam T\n+   /// \\tparam Rows\n+   /// \\tparam Columns\n+   /// \\pre\n+   ///\n+   template <typename T, std::ptrdiff_t Rows, std::ptrdiff_t Columns = Rows>\n+   class matrix {\n+      static constexpr bool is_complex =","path":"include/amcpp/cppcon2018/matrix.hpp","position":21,"original_position":21,"commit_id":"2d23496d922e304907f6f62252c85786d2cd86e7","original_commit_id":"2d2818f43f4d929458f61083b65cd76957fd5881","user":{"login":"cjdb","id":8622748,"node_id":"MDQ6VXNlcjg2MjI3NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/8622748?v=4","gravatar_id":"","url":"https://api.github.com/users/cjdb","html_url":"https://github.com/cjdb","followers_url":"https://api.github.com/users/cjdb/followers","following_url":"https://api.github.com/users/cjdb/following{/other_user}","gists_url":"https://api.github.com/users/cjdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cjdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjdb/subscriptions","organizations_url":"https://api.github.com/users/cjdb/orgs","repos_url":"https://api.github.com/users/cjdb/repos","events_url":"https://api.github.com/users/cjdb/events{/privacy}","received_events_url":"https://api.github.com/users/cjdb/received_events","type":"User","site_admin":false},"body":"Great suggestion! I've simplified this a bit, since we can specialise template variables.","created_at":"2018-09-03T20:44:09Z","updated_at":"2018-09-03T20:44:09Z","html_url":"https://github.com/cjdb/cppcon-2018-challenge/pull/1#discussion_r214753954","pull_request_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/pulls/comments/214753954"},"html":{"href":"https://github.com/cjdb/cppcon-2018-challenge/pull/1#discussion_r214753954"},"pull_request":{"href":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/pulls/1"}},"in_reply_to_id":214750403},"pull_request":{"url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/pulls/1","id":212810442,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyODEwNDQy","html_url":"https://github.com/cjdb/cppcon-2018-challenge/pull/1","diff_url":"https://github.com/cjdb/cppcon-2018-challenge/pull/1.diff","patch_url":"https://github.com/cjdb/cppcon-2018-challenge/pull/1.patch","issue_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/issues/1","number":1,"state":"open","locked":false,"title":"Initial code commit.","user":{"login":"cjdb","id":8622748,"node_id":"MDQ6VXNlcjg2MjI3NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/8622748?v=4","gravatar_id":"","url":"https://api.github.com/users/cjdb","html_url":"https://github.com/cjdb","followers_url":"https://api.github.com/users/cjdb/followers","following_url":"https://api.github.com/users/cjdb/following{/other_user}","gists_url":"https://api.github.com/users/cjdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cjdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjdb/subscriptions","organizations_url":"https://api.github.com/users/cjdb/orgs","repos_url":"https://api.github.com/users/cjdb/repos","events_url":"https://api.github.com/users/cjdb/events{/privacy}","received_events_url":"https://api.github.com/users/cjdb/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-03T19:36:19Z","updated_at":"2018-09-03T20:44:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1090f7b30d3eb551fabcdf6abe28bfa0c83d7765","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/pulls/1/commits","review_comments_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/pulls/1/comments","review_comment_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/issues/1/comments","statuses_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/statuses/2d23496d922e304907f6f62252c85786d2cd86e7","head":{"label":"cjdb:development","ref":"development","sha":"2d23496d922e304907f6f62252c85786d2cd86e7","user":{"login":"cjdb","id":8622748,"node_id":"MDQ6VXNlcjg2MjI3NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/8622748?v=4","gravatar_id":"","url":"https://api.github.com/users/cjdb","html_url":"https://github.com/cjdb","followers_url":"https://api.github.com/users/cjdb/followers","following_url":"https://api.github.com/users/cjdb/following{/other_user}","gists_url":"https://api.github.com/users/cjdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cjdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjdb/subscriptions","organizations_url":"https://api.github.com/users/cjdb/orgs","repos_url":"https://api.github.com/users/cjdb/repos","events_url":"https://api.github.com/users/cjdb/events{/privacy}","received_events_url":"https://api.github.com/users/cjdb/received_events","type":"User","site_admin":false},"repo":{"id":147243080,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcyNDMwODA=","name":"cppcon-2018-challenge","full_name":"cjdb/cppcon-2018-challenge","owner":{"login":"cjdb","id":8622748,"node_id":"MDQ6VXNlcjg2MjI3NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/8622748?v=4","gravatar_id":"","url":"https://api.github.com/users/cjdb","html_url":"https://github.com/cjdb","followers_url":"https://api.github.com/users/cjdb/followers","following_url":"https://api.github.com/users/cjdb/following{/other_user}","gists_url":"https://api.github.com/users/cjdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cjdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjdb/subscriptions","organizations_url":"https://api.github.com/users/cjdb/orgs","repos_url":"https://api.github.com/users/cjdb/repos","events_url":"https://api.github.com/users/cjdb/events{/privacy}","received_events_url":"https://api.github.com/users/cjdb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cjdb/cppcon-2018-challenge","description":null,"fork":false,"url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge","forks_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/forks","keys_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/teams","hooks_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/hooks","issue_events_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/issues/events{/number}","events_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/events","assignees_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/assignees{/user}","branches_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/branches{/branch}","tags_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/tags","blobs_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/statuses/{sha}","languages_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/languages","stargazers_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/stargazers","contributors_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/contributors","subscribers_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/subscribers","subscription_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/subscription","commits_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/issues/comments{/number}","contents_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/contents/{+path}","compare_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/merges","archive_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/downloads","issues_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/issues{/number}","pulls_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/pulls{/number}","milestones_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/milestones{/number}","notifications_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/labels{/name}","releases_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/releases{/id}","deployments_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/deployments","created_at":"2018-09-03T19:02:59Z","updated_at":"2018-09-03T19:35:56Z","pushed_at":"2018-09-03T20:32:30Z","git_url":"git://github.com/cjdb/cppcon-2018-challenge.git","ssh_url":"git@github.com:cjdb/cppcon-2018-challenge.git","clone_url":"https://github.com/cjdb/cppcon-2018-challenge.git","svn_url":"https://github.com/cjdb/cppcon-2018-challenge","homepage":null,"size":29,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"cjdb:master","ref":"master","sha":"b46f71d9f5221e3cfdc018f19b57307f8c3ebf6d","user":{"login":"cjdb","id":8622748,"node_id":"MDQ6VXNlcjg2MjI3NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/8622748?v=4","gravatar_id":"","url":"https://api.github.com/users/cjdb","html_url":"https://github.com/cjdb","followers_url":"https://api.github.com/users/cjdb/followers","following_url":"https://api.github.com/users/cjdb/following{/other_user}","gists_url":"https://api.github.com/users/cjdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cjdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjdb/subscriptions","organizations_url":"https://api.github.com/users/cjdb/orgs","repos_url":"https://api.github.com/users/cjdb/repos","events_url":"https://api.github.com/users/cjdb/events{/privacy}","received_events_url":"https://api.github.com/users/cjdb/received_events","type":"User","site_admin":false},"repo":{"id":147243080,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcyNDMwODA=","name":"cppcon-2018-challenge","full_name":"cjdb/cppcon-2018-challenge","owner":{"login":"cjdb","id":8622748,"node_id":"MDQ6VXNlcjg2MjI3NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/8622748?v=4","gravatar_id":"","url":"https://api.github.com/users/cjdb","html_url":"https://github.com/cjdb","followers_url":"https://api.github.com/users/cjdb/followers","following_url":"https://api.github.com/users/cjdb/following{/other_user}","gists_url":"https://api.github.com/users/cjdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cjdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjdb/subscriptions","organizations_url":"https://api.github.com/users/cjdb/orgs","repos_url":"https://api.github.com/users/cjdb/repos","events_url":"https://api.github.com/users/cjdb/events{/privacy}","received_events_url":"https://api.github.com/users/cjdb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cjdb/cppcon-2018-challenge","description":null,"fork":false,"url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge","forks_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/forks","keys_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/teams","hooks_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/hooks","issue_events_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/issues/events{/number}","events_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/events","assignees_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/assignees{/user}","branches_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/branches{/branch}","tags_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/tags","blobs_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/statuses/{sha}","languages_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/languages","stargazers_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/stargazers","contributors_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/contributors","subscribers_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/subscribers","subscription_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/subscription","commits_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/issues/comments{/number}","contents_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/contents/{+path}","compare_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/merges","archive_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/downloads","issues_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/issues{/number}","pulls_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/pulls{/number}","milestones_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/milestones{/number}","notifications_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/labels{/name}","releases_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/releases{/id}","deployments_url":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/deployments","created_at":"2018-09-03T19:02:59Z","updated_at":"2018-09-03T19:35:56Z","pushed_at":"2018-09-03T20:32:30Z","git_url":"git://github.com/cjdb/cppcon-2018-challenge.git","ssh_url":"git@github.com:cjdb/cppcon-2018-challenge.git","clone_url":"https://github.com/cjdb/cppcon-2018-challenge.git","svn_url":"https://github.com/cjdb/cppcon-2018-challenge","homepage":null,"size":29,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/pulls/1"},"html":{"href":"https://github.com/cjdb/cppcon-2018-challenge/pull/1"},"issue":{"href":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/issues/1"},"comments":{"href":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/cjdb/cppcon-2018-challenge/statuses/2d23496d922e304907f6f62252c85786d2cd86e7"}},"author_association":"OWNER"}}
{"actor":{"display_login":"cjdb"}}