{"action":"created","issue":{"url":"https://api.github.com/repos/golang/go/issues/23828","repository_url":"https://api.github.com/repos/golang/go","labels_url":"https://api.github.com/repos/golang/go/issues/23828/labels{/name}","comments_url":"https://api.github.com/repos/golang/go/issues/23828/comments","events_url":"https://api.github.com/repos/golang/go/issues/23828/events","html_url":"https://github.com/golang/go/issues/23828","id":297196249,"number":23828,"title":"cmd/compile: use strings.Builder","user":{"login":"josharian","id":67496,"avatar_url":"https://avatars2.githubusercontent.com/u/67496?v=4","gravatar_id":"","url":"https://api.github.com/users/josharian","html_url":"https://github.com/josharian","followers_url":"https://api.github.com/users/josharian/followers","following_url":"https://api.github.com/users/josharian/following{/other_user}","gists_url":"https://api.github.com/users/josharian/gists{/gist_id}","starred_url":"https://api.github.com/users/josharian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josharian/subscriptions","organizations_url":"https://api.github.com/users/josharian/orgs","repos_url":"https://api.github.com/users/josharian/repos","events_url":"https://api.github.com/users/josharian/events{/privacy}","received_events_url":"https://api.github.com/users/josharian/received_events","type":"User","site_admin":false},"labels":[{"id":150880161,"url":"https://api.github.com/repos/golang/go/labels/Suggested","name":"Suggested","color":"ddffdd","default":false},{"id":358732225,"url":"https://api.github.com/repos/golang/go/labels/ToolSpeed","name":"ToolSpeed","color":"ededed","default":false},{"id":150880243,"url":"https://api.github.com/repos/golang/go/labels/help%20wanted","name":"help wanted","color":"fbca04","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/golang/go/milestones/62","html_url":"https://github.com/golang/go/milestone/62","labels_url":"https://api.github.com/repos/golang/go/milestones/62/labels","id":2827591,"number":62,"title":"Go1.11","description":"","creator":{"login":"rsc","id":104030,"avatar_url":"https://avatars1.githubusercontent.com/u/104030?v=4","gravatar_id":"","url":"https://api.github.com/users/rsc","html_url":"https://github.com/rsc","followers_url":"https://api.github.com/users/rsc/followers","following_url":"https://api.github.com/users/rsc/following{/other_user}","gists_url":"https://api.github.com/users/rsc/gists{/gist_id}","starred_url":"https://api.github.com/users/rsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsc/subscriptions","organizations_url":"https://api.github.com/users/rsc/orgs","repos_url":"https://api.github.com/users/rsc/repos","events_url":"https://api.github.com/users/rsc/events{/privacy}","received_events_url":"https://api.github.com/users/rsc/received_events","type":"User","site_admin":false},"open_issues":773,"closed_issues":100,"state":"open","created_at":"2017-10-10T13:39:17Z","updated_at":"2018-02-14T20:09:14Z","due_on":"2018-07-31T07:00:00Z","closed_at":null},"comments":5,"created_at":"2018-02-14T18:19:27Z","updated_at":"2018-02-14T20:20:25Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"The main challenge here is ensuring everything still works when built with 1.4.\r\n\r\nProbably build tag protected files, with something like\r\n\r\ntype buffer struct {\r\n  bytes.Buffer\r\n}\r\n\r\nfor pre-1.10 and\r\n\r\ntype buffer = strings.Builder\r\n\r\nfor 1.10+."},"comment":{"url":"https://api.github.com/repos/golang/go/issues/comments/365732844","html_url":"https://github.com/golang/go/issues/23828#issuecomment-365732844","issue_url":"https://api.github.com/repos/golang/go/issues/23828","id":365732844,"user":{"login":"bradfitz","id":2621,"avatar_url":"https://avatars1.githubusercontent.com/u/2621?v=4","gravatar_id":"","url":"https://api.github.com/users/bradfitz","html_url":"https://github.com/bradfitz","followers_url":"https://api.github.com/users/bradfitz/followers","following_url":"https://api.github.com/users/bradfitz/following{/other_user}","gists_url":"https://api.github.com/users/bradfitz/gists{/gist_id}","starred_url":"https://api.github.com/users/bradfitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradfitz/subscriptions","organizations_url":"https://api.github.com/users/bradfitz/orgs","repos_url":"https://api.github.com/users/bradfitz/repos","events_url":"https://api.github.com/users/bradfitz/events{/privacy}","received_events_url":"https://api.github.com/users/bradfitz/received_events","type":"User","site_admin":false},"created_at":"2018-02-14T20:20:25Z","updated_at":"2018-02-14T20:20:25Z","author_association":"OWNER","body":"In any case, the point behind my snark was to make sure that the package does NOT become a \"util\" package that itself depends on many things the caller of your package may not want.\r\n\r\nIt might be valid for the first few things, but it'll inevitably grow, and the util-ness bloat will sneak up on us.\r\n\r\nIt might be best to have N such packages under some \"compat\" or \"future\" directory."}}
{"actor":{"display_login":"bradfitz"}}