{"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/site-www/pulls/comments/184196355","pull_request_review_id":115342805,"id":184196355,"diff_hunk":"@@ -1468,11 +1523,12 @@ Duration(\n     int microseconds: 0});\n {% endprettify %}\n \n-### AVOID mandatory parameters that permit nonce values.\n+\n+### AVOID mandatory parameters that permit sentinel values.","path":"src/_guides/language/effective-dart/design.md","position":103,"original_position":103,"commit_id":"0462b228b9ee7be58eeaac02df23f18b229a5cd6","original_commit_id":"0462b228b9ee7be58eeaac02df23f18b229a5cd6","user":{"login":"munificent","id":46275,"avatar_url":"https://avatars0.githubusercontent.com/u/46275?v=4","gravatar_id":"","url":"https://api.github.com/users/munificent","html_url":"https://github.com/munificent","followers_url":"https://api.github.com/users/munificent/followers","following_url":"https://api.github.com/users/munificent/following{/other_user}","gists_url":"https://api.github.com/users/munificent/gists{/gist_id}","starred_url":"https://api.github.com/users/munificent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munificent/subscriptions","organizations_url":"https://api.github.com/users/munificent/orgs","repos_url":"https://api.github.com/users/munificent/repos","events_url":"https://api.github.com/users/munificent/events{/privacy}","received_events_url":"https://api.github.com/users/munificent/received_events","type":"User","site_admin":false},"body":"I meant \"sentinel\", but it's not a perfect match. It's the best word I could come up with: https://en.wikipedia.org/wiki/Sentinel_value. \"Nonce\" isn't right.","created_at":"2018-04-25T20:31:00Z","updated_at":"2018-04-25T20:31:00Z","html_url":"https://github.com/dart-lang/site-www/pull/808#discussion_r184196355","pull_request_url":"https://api.github.com/repos/dart-lang/site-www/pulls/808","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/comments/184196355"},"html":{"href":"https://github.com/dart-lang/site-www/pull/808#discussion_r184196355"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/808"}},"in_reply_to_id":183371677},"pull_request":{"url":"https://api.github.com/repos/dart-lang/site-www/pulls/808","id":183189496,"html_url":"https://github.com/dart-lang/site-www/pull/808","diff_url":"https://github.com/dart-lang/site-www/pull/808.diff","patch_url":"https://github.com/dart-lang/site-www/pull/808.patch","issue_url":"https://api.github.com/repos/dart-lang/site-www/issues/808","number":808,"state":"open","locked":false,"title":"More \"Effective Dart\" guidelines.","user":{"login":"munificent","id":46275,"avatar_url":"https://avatars0.githubusercontent.com/u/46275?v=4","gravatar_id":"","url":"https://api.github.com/users/munificent","html_url":"https://github.com/munificent","followers_url":"https://api.github.com/users/munificent/followers","following_url":"https://api.github.com/users/munificent/following{/other_user}","gists_url":"https://api.github.com/users/munificent/gists{/gist_id}","starred_url":"https://api.github.com/users/munificent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munificent/subscriptions","organizations_url":"https://api.github.com/users/munificent/orgs","repos_url":"https://api.github.com/users/munificent/repos","events_url":"https://api.github.com/users/munificent/events{/privacy}","received_events_url":"https://api.github.com/users/munificent/received_events","type":"User","site_admin":false},"body":"- Don't return FutureOr.\r\n- Use whereType().\r\n- Don't do unneeded cast() or retype().\r\n\r\n@lrhn, this includes one of your suggested guidelines. I'm still working out what to do for `cast()` and `retype()`. I'll do that in a different PR.","created_at":"2018-04-20T23:12:53Z","updated_at":"2018-04-25T20:31:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87c7c1fe0092546795111d9ec5119b9f71a25d8e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lrhn","id":4865287,"avatar_url":"https://avatars3.githubusercontent.com/u/4865287?v=4","gravatar_id":"","url":"https://api.github.com/users/lrhn","html_url":"https://github.com/lrhn","followers_url":"https://api.github.com/users/lrhn/followers","following_url":"https://api.github.com/users/lrhn/following{/other_user}","gists_url":"https://api.github.com/users/lrhn/gists{/gist_id}","starred_url":"https://api.github.com/users/lrhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrhn/subscriptions","organizations_url":"https://api.github.com/users/lrhn/orgs","repos_url":"https://api.github.com/users/lrhn/repos","events_url":"https://api.github.com/users/lrhn/events{/privacy}","received_events_url":"https://api.github.com/users/lrhn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":421018044,"url":"https://api.github.com/repos/dart-lang/site-www/labels/cla:%20yes","name":"cla: yes","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dart-lang/site-www/pulls/808/commits","review_comments_url":"https://api.github.com/repos/dart-lang/site-www/pulls/808/comments","review_comment_url":"https://api.github.com/repos/dart-lang/site-www/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/site-www/issues/808/comments","statuses_url":"https://api.github.com/repos/dart-lang/site-www/statuses/0462b228b9ee7be58eeaac02df23f18b229a5cd6","head":{"label":"dart-lang:future-or-collections","ref":"future-or-collections","sha":"0462b228b9ee7be58eeaac02df23f18b229a5cd6","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":63089994,"name":"site-www","full_name":"dart-lang/site-www","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/site-www","description":"Source for Dart website","fork":false,"url":"https://api.github.com/repos/dart-lang/site-www","forks_url":"https://api.github.com/repos/dart-lang/site-www/forks","keys_url":"https://api.github.com/repos/dart-lang/site-www/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/site-www/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/site-www/teams","hooks_url":"https://api.github.com/repos/dart-lang/site-www/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/site-www/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/site-www/events","assignees_url":"https://api.github.com/repos/dart-lang/site-www/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/site-www/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/site-www/tags","blobs_url":"https://api.github.com/repos/dart-lang/site-www/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/site-www/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/site-www/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/site-www/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/site-www/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/site-www/languages","stargazers_url":"https://api.github.com/repos/dart-lang/site-www/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/site-www/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/site-www/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/site-www/subscription","commits_url":"https://api.github.com/repos/dart-lang/site-www/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/site-www/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/site-www/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/site-www/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/site-www/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/site-www/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/site-www/merges","archive_url":"https://api.github.com/repos/dart-lang/site-www/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/site-www/downloads","issues_url":"https://api.github.com/repos/dart-lang/site-www/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/site-www/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/site-www/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/site-www/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/site-www/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/site-www/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/site-www/deployments","created_at":"2016-07-11T17:57:36Z","updated_at":"2018-04-23T17:36:41Z","pushed_at":"2018-04-25T14:00:35Z","git_url":"git://github.com/dart-lang/site-www.git","ssh_url":"git@github.com:dart-lang/site-www.git","clone_url":"https://github.com/dart-lang/site-www.git","svn_url":"https://github.com/dart-lang/site-www","homepage":"https://www.dartlang.org/","size":11731,"stargazers_count":93,"watchers_count":93,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"archived":false,"open_issues_count":147,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":76,"open_issues":147,"watchers":93,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"28322cd0dbc7469b7f009866abb5a577451b4955","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":63089994,"name":"site-www","full_name":"dart-lang/site-www","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/site-www","description":"Source for Dart website","fork":false,"url":"https://api.github.com/repos/dart-lang/site-www","forks_url":"https://api.github.com/repos/dart-lang/site-www/forks","keys_url":"https://api.github.com/repos/dart-lang/site-www/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/site-www/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/site-www/teams","hooks_url":"https://api.github.com/repos/dart-lang/site-www/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/site-www/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/site-www/events","assignees_url":"https://api.github.com/repos/dart-lang/site-www/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/site-www/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/site-www/tags","blobs_url":"https://api.github.com/repos/dart-lang/site-www/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/site-www/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/site-www/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/site-www/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/site-www/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/site-www/languages","stargazers_url":"https://api.github.com/repos/dart-lang/site-www/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/site-www/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/site-www/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/site-www/subscription","commits_url":"https://api.github.com/repos/dart-lang/site-www/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/site-www/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/site-www/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/site-www/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/site-www/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/site-www/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/site-www/merges","archive_url":"https://api.github.com/repos/dart-lang/site-www/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/site-www/downloads","issues_url":"https://api.github.com/repos/dart-lang/site-www/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/site-www/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/site-www/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/site-www/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/site-www/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/site-www/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/site-www/deployments","created_at":"2016-07-11T17:57:36Z","updated_at":"2018-04-23T17:36:41Z","pushed_at":"2018-04-25T14:00:35Z","git_url":"git://github.com/dart-lang/site-www.git","ssh_url":"git@github.com:dart-lang/site-www.git","clone_url":"https://github.com/dart-lang/site-www.git","svn_url":"https://github.com/dart-lang/site-www","homepage":"https://www.dartlang.org/","size":11731,"stargazers_count":93,"watchers_count":93,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"archived":false,"open_issues_count":147,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":76,"open_issues":147,"watchers":93,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/808"},"html":{"href":"https://github.com/dart-lang/site-www/pull/808"},"issue":{"href":"https://api.github.com/repos/dart-lang/site-www/issues/808"},"comments":{"href":"https://api.github.com/repos/dart-lang/site-www/issues/808/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/808/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/808/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/site-www/statuses/0462b228b9ee7be58eeaac02df23f18b229a5cd6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"munificent"}}