{"action":"created","comment":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments/208295857","pull_request_review_id":144075519,"id":208295857,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODI5NTg1Nw==","diff_hunk":"@@ -649,6 +655,29 @@ export class DetailsListBase extends BaseComponent<IDetailsListProps, IDetailsLi\n     }\n   }\n \n+  private _onColumnDragEnd(event: MouseEvent, onHeader: boolean): void {\n+    const { columnReorderOptions } = this.props;\n+    if (columnReorderOptions && columnReorderOptions.onColumnDragEnd) {\n+      let dropLocation = 0;","path":"packages/office-ui-fabric-react/src/components/DetailsList/DetailsList.base.tsx","position":54,"original_position":54,"commit_id":"6b59369b66a9af398c5b27ba93666e7f35fdd274","original_commit_id":"6b59369b66a9af398c5b27ba93666e7f35fdd274","user":{"login":"ThomasMichon","id":6828233,"node_id":"MDQ6VXNlcjY4MjgyMzM=","avatar_url":"https://avatars0.githubusercontent.com/u/6828233?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasMichon","html_url":"https://github.com/ThomasMichon","followers_url":"https://api.github.com/users/ThomasMichon/followers","following_url":"https://api.github.com/users/ThomasMichon/following{/other_user}","gists_url":"https://api.github.com/users/ThomasMichon/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasMichon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasMichon/subscriptions","organizations_url":"https://api.github.com/users/ThomasMichon/orgs","repos_url":"https://api.github.com/users/ThomasMichon/repos","events_url":"https://api.github.com/users/ThomasMichon/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasMichon/received_events","type":"User","site_admin":false},"body":"This should use the enum.","created_at":"2018-08-07T16:17:50Z","updated_at":"2018-08-07T16:17:50Z","html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/5779#discussion_r208295857","pull_request_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/5779","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments/208295857"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/5779#discussion_r208295857"},"pull_request":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/5779"}}},"pull_request":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/5779","id":205771681,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NzcxNjgx","html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/5779","diff_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/5779.diff","patch_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/5779.patch","issue_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/5779","number":5779,"state":"open","locked":false,"title":"Column drag drop changes - Added 2 callback functions to notify the dragStart and dragEnd events","user":{"login":"laxmikankanala","id":39089979,"node_id":"MDQ6VXNlcjM5MDg5OTc5","avatar_url":"https://avatars0.githubusercontent.com/u/39089979?v=4","gravatar_id":"","url":"https://api.github.com/users/laxmikankanala","html_url":"https://github.com/laxmikankanala","followers_url":"https://api.github.com/users/laxmikankanala/followers","following_url":"https://api.github.com/users/laxmikankanala/following{/other_user}","gists_url":"https://api.github.com/users/laxmikankanala/gists{/gist_id}","starred_url":"https://api.github.com/users/laxmikankanala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laxmikankanala/subscriptions","organizations_url":"https://api.github.com/users/laxmikankanala/orgs","repos_url":"https://api.github.com/users/laxmikankanala/repos","events_url":"https://api.github.com/users/laxmikankanala/events{/privacy}","received_events_url":"https://api.github.com/users/laxmikankanala/received_events","type":"User","site_admin":false},"body":"Added 2 callback functions to notify the dragstart and end events.\r\nAdded onColumnDrop to deprecate the handleColumnReorder. Will remove this once the ODSP-Next changes are done.\r\nCallbacks will be used in ODSP-Next to log the events for telemetry.\r\nColumnDragEndLocation  is added to get exactly dragend details, whether its ended on header or list or outside of the list\n###### Microsoft Reviewers: [Open in CodeFlow](http://wpcp.azurewebsites.net/CodeFlowProtocolProxy2.php?pullrequest=https://github.com/OfficeDev/office-ui-fabric-react/pull/5779)\n\n","created_at":"2018-08-02T15:19:04Z","updated_at":"2018-08-07T16:17:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b3d7127e1e4b76de25246fc91791d0c6b6ec02f","assignee":{"login":"KevinTCoughlin","id":706967,"node_id":"MDQ6VXNlcjcwNjk2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/706967?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinTCoughlin","html_url":"https://github.com/KevinTCoughlin","followers_url":"https://api.github.com/users/KevinTCoughlin/followers","following_url":"https://api.github.com/users/KevinTCoughlin/following{/other_user}","gists_url":"https://api.github.com/users/KevinTCoughlin/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinTCoughlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinTCoughlin/subscriptions","organizations_url":"https://api.github.com/users/KevinTCoughlin/orgs","repos_url":"https://api.github.com/users/KevinTCoughlin/repos","events_url":"https://api.github.com/users/KevinTCoughlin/events{/privacy}","received_events_url":"https://api.github.com/users/KevinTCoughlin/received_events","type":"User","site_admin":false},"assignees":[{"login":"KevinTCoughlin","id":706967,"node_id":"MDQ6VXNlcjcwNjk2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/706967?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinTCoughlin","html_url":"https://github.com/KevinTCoughlin","followers_url":"https://api.github.com/users/KevinTCoughlin/followers","following_url":"https://api.github.com/users/KevinTCoughlin/following{/other_user}","gists_url":"https://api.github.com/users/KevinTCoughlin/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinTCoughlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinTCoughlin/subscriptions","organizations_url":"https://api.github.com/users/KevinTCoughlin/orgs","repos_url":"https://api.github.com/users/KevinTCoughlin/repos","events_url":"https://api.github.com/users/KevinTCoughlin/events{/privacy}","received_events_url":"https://api.github.com/users/KevinTCoughlin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/5779/commits","review_comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/5779/comments","review_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/5779/comments","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/6b59369b66a9af398c5b27ba93666e7f35fdd274","head":{"label":"laxmikankanala:laxmika/ColumnDragDropCallbacks","ref":"laxmika/ColumnDragDropCallbacks","sha":"6b59369b66a9af398c5b27ba93666e7f35fdd274","user":{"login":"laxmikankanala","id":39089979,"node_id":"MDQ6VXNlcjM5MDg5OTc5","avatar_url":"https://avatars0.githubusercontent.com/u/39089979?v=4","gravatar_id":"","url":"https://api.github.com/users/laxmikankanala","html_url":"https://github.com/laxmikankanala","followers_url":"https://api.github.com/users/laxmikankanala/followers","following_url":"https://api.github.com/users/laxmikankanala/following{/other_user}","gists_url":"https://api.github.com/users/laxmikankanala/gists{/gist_id}","starred_url":"https://api.github.com/users/laxmikankanala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laxmikankanala/subscriptions","organizations_url":"https://api.github.com/users/laxmikankanala/orgs","repos_url":"https://api.github.com/users/laxmikankanala/repos","events_url":"https://api.github.com/users/laxmikankanala/events{/privacy}","received_events_url":"https://api.github.com/users/laxmikankanala/received_events","type":"User","site_admin":false},"repo":{"id":132608710,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI2MDg3MTA=","name":"office-ui-fabric-react","full_name":"laxmikankanala/office-ui-fabric-react","owner":{"login":"laxmikankanala","id":39089979,"node_id":"MDQ6VXNlcjM5MDg5OTc5","avatar_url":"https://avatars0.githubusercontent.com/u/39089979?v=4","gravatar_id":"","url":"https://api.github.com/users/laxmikankanala","html_url":"https://github.com/laxmikankanala","followers_url":"https://api.github.com/users/laxmikankanala/followers","following_url":"https://api.github.com/users/laxmikankanala/following{/other_user}","gists_url":"https://api.github.com/users/laxmikankanala/gists{/gist_id}","starred_url":"https://api.github.com/users/laxmikankanala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laxmikankanala/subscriptions","organizations_url":"https://api.github.com/users/laxmikankanala/orgs","repos_url":"https://api.github.com/users/laxmikankanala/repos","events_url":"https://api.github.com/users/laxmikankanala/events{/privacy}","received_events_url":"https://api.github.com/users/laxmikankanala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laxmikankanala/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":true,"url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react","forks_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/laxmikankanala/office-ui-fabric-react/deployments","created_at":"2018-05-08T12:53:32Z","updated_at":"2018-05-08T12:53:39Z","pushed_at":"2018-08-07T16:02:46Z","git_url":"git://github.com/laxmikankanala/office-ui-fabric-react.git","ssh_url":"git@github.com:laxmikankanala/office-ui-fabric-react.git","clone_url":"https://github.com/laxmikankanala/office-ui-fabric-react.git","svn_url":"https://github.com/laxmikankanala/office-ui-fabric-react","homepage":"https://developer.microsoft.com/en-us/fabric#/components","size":40486,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OfficeDev:master","ref":"master","sha":"17a692d79d111dc05dc96ae8b384695bc99cdd2b","user":{"login":"OfficeDev","id":6789362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3ODkzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"repo":{"id":60537144,"node_id":"MDEwOlJlcG9zaXRvcnk2MDUzNzE0NA==","name":"office-ui-fabric-react","full_name":"OfficeDev/office-ui-fabric-react","owner":{"login":"OfficeDev","id":6789362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3ODkzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OfficeDev/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":false,"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react","forks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/deployments","created_at":"2016-06-06T15:03:44Z","updated_at":"2018-08-07T15:01:05Z","pushed_at":"2018-08-07T16:08:14Z","git_url":"git://github.com/OfficeDev/office-ui-fabric-react.git","ssh_url":"git@github.com:OfficeDev/office-ui-fabric-react.git","clone_url":"https://github.com/OfficeDev/office-ui-fabric-react.git","svn_url":"https://github.com/OfficeDev/office-ui-fabric-react","homepage":"https://developer.microsoft.com/en-us/fabric#/components","size":38061,"stargazers_count":3068,"watchers_count":3068,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":692,"mirror_url":null,"archived":false,"open_issues_count":339,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":692,"open_issues":339,"watchers":3068,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/5779"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/5779"},"issue":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/5779"},"comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/5779/comments"},"review_comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/5779/comments"},"review_comment":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/5779/commits"},"statuses":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/6b59369b66a9af398c5b27ba93666e7f35fdd274"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ThomasMichon"}}