{"action":"created","comment":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/243350812","pull_request_review_id":187098552,"id":243350812,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzM1MDgxMg==","diff_hunk":"@@ -320,6 +321,55 @@ public ShortestQualifiedNameReplacer(ClassTable classTable, ElementResolver reso\n             this.resolver = resolver;\n         }\n \n+        public override AssociativeNode VisitTypedIdentifierNode(TypedIdentifierNode node)\n+        {\n+            if (node == null)\n+                return null;\n+\n+            // If type is primitive type\n+            if (node.datatype.UID != (int)PrimitiveType.InvalidType &&\n+                node.datatype.UID < (int)PrimitiveType.MaxPrimitive)\n+                return node;\n+            \n+            // build an idlistnode from the full type name\n+            var identListNode = CoreUtils.CreateNodeFromString(node.datatype.Name);\n+            if (identListNode == null)\n+                return null;\n+\n+            // visit the idlist \n+            var shortNameNode = identListNode.Accept(this);\n+            if(shortNameNode == null)\n+                return null;\n+            \n+\n+            var resultingNode = new TypedIdentifierNode();\n+            resultingNode.Name = node.Name;\n+            resultingNode.Value = node.Name;\n+            resultingNode.datatype = node.datatype;\n+\n+            //return a typedIdNode built from the shortNameId returned above.\n+            if (shortNameNode is IdentifierListNode)\n+            {\n+                var idListNode = (shortNameNode as IdentifierListNode);\n+                resultingNode.TypeAlias = idListNode.ToString();\n+            }\n+\n+            else if (shortNameNode is IdentifierNode)\n+            {\n+                var idNode = (shortNameNode as IdentifierNode);\n+                resultingNode.TypeAlias = idNode.Value;\n+            }","path":"src/DynamoCore/Engine/NodeToCode/NodeToCode.cs","position":49,"original_position":49,"commit_id":"7f082592cc5a41f74dc114d444b9d132608dd58c","original_commit_id":"7f082592cc5a41f74dc114d444b9d132608dd58c","user":{"login":"aparajit-pratap","id":5710686,"node_id":"MDQ6VXNlcjU3MTA2ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/5710686?v=4","gravatar_id":"","url":"https://api.github.com/users/aparajit-pratap","html_url":"https://github.com/aparajit-pratap","followers_url":"https://api.github.com/users/aparajit-pratap/followers","following_url":"https://api.github.com/users/aparajit-pratap/following{/other_user}","gists_url":"https://api.github.com/users/aparajit-pratap/gists{/gist_id}","starred_url":"https://api.github.com/users/aparajit-pratap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aparajit-pratap/subscriptions","organizations_url":"https://api.github.com/users/aparajit-pratap/orgs","repos_url":"https://api.github.com/users/aparajit-pratap/repos","events_url":"https://api.github.com/users/aparajit-pratap/events{/privacy}","received_events_url":"https://api.github.com/users/aparajit-pratap/received_events","type":"User","site_admin":false},"body":"I think we can just do: `resultingNode.TypeAlias = shortNameNode.ToString();`","created_at":"2018-12-20T17:13:43Z","updated_at":"2018-12-20T17:13:43Z","html_url":"https://github.com/DynamoDS/Dynamo/pull/9330#discussion_r243350812","pull_request_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9330","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments/243350812"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/9330#discussion_r243350812"},"pull_request":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9330"}}},"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9330","id":239859930,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5ODU5OTMw","html_url":"https://github.com/DynamoDS/Dynamo/pull/9330","diff_url":"https://github.com/DynamoDS/Dynamo/pull/9330.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/9330.patch","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/9330","number":9330,"state":"open","locked":false,"title":"[WIP] Avoid namespace collisions when collapsing graph to custom node","user":{"login":"mjkkirschner","id":508936,"node_id":"MDQ6VXNlcjUwODkzNg==","avatar_url":"https://avatars3.githubusercontent.com/u/508936?v=4","gravatar_id":"","url":"https://api.github.com/users/mjkkirschner","html_url":"https://github.com/mjkkirschner","followers_url":"https://api.github.com/users/mjkkirschner/followers","following_url":"https://api.github.com/users/mjkkirschner/following{/other_user}","gists_url":"https://api.github.com/users/mjkkirschner/gists{/gist_id}","starred_url":"https://api.github.com/users/mjkkirschner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjkkirschner/subscriptions","organizations_url":"https://api.github.com/users/mjkkirschner/orgs","repos_url":"https://api.github.com/users/mjkkirschner/repos","events_url":"https://api.github.com/users/mjkkirschner/events{/privacy}","received_events_url":"https://api.github.com/users/mjkkirschner/received_events","type":"User","site_admin":false},"body":"Not sure how this effects node2code. - may create rewriter directly instead as an alternative.\r\n\r\n### Purpose\r\n\r\nCollapsing a graph to a custom node can create errors if there is a namespace conflict in types used in the generated input nodes.\r\n\r\n### Declarations\r\n\r\nCheck these if you believe they are true\r\n\r\n- [ ] The code base is in a better state after this PR\r\n- [ ] Is documented according to the [standards](https://github.com/DynamoDS/Dynamo/wiki/Coding-Standards)\r\n- [ ] The level of testing this PR includes is appropriate\r\n- [ ] User facing strings, if any, are extracted into `*.resx` files\r\n- [ ] All tests pass using the self-service CI.\r\n- [ ] Snapshot of UI changes, if any.\r\n- [ ] Changes to the API follow [Semantic Versioning](https://github.com/DynamoDS/Dynamo/wiki/Dynamo-Versions), and are documented in the [API Changes](https://github.com/DynamoDS/Dynamo/wiki/API-Changes) document.\r\n\r\n### Reviewers\r\n\r\n(FILL ME IN) Reviewer 1  (If possible, assign the Reviewer for the PR)\r\n\r\n(FILL ME IN, optional) Any additional notes to reviewers or testers.\r\n\r\n### FYIs\r\n\r\n(FILL ME IN, Optional) Names of anyone else you wish to be notified of\r\n","created_at":"2018-12-19T14:43:03Z","updated_at":"2018-12-20T17:13:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef099079c0f94cc476aed0f6872eea036146d70d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":206524440,"node_id":"MDU6TGFiZWwyMDY1MjQ0NDA=","url":"https://api.github.com/repos/DynamoDS/Dynamo/labels/WIP","name":"WIP","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9330/commits","review_comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9330/comments","review_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/9330/comments","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/7f082592cc5a41f74dc114d444b9d132608dd58c","head":{"label":"mjkkirschner:elementResolverNull","ref":"elementResolverNull","sha":"7f082592cc5a41f74dc114d444b9d132608dd58c","user":{"login":"mjkkirschner","id":508936,"node_id":"MDQ6VXNlcjUwODkzNg==","avatar_url":"https://avatars3.githubusercontent.com/u/508936?v=4","gravatar_id":"","url":"https://api.github.com/users/mjkkirschner","html_url":"https://github.com/mjkkirschner","followers_url":"https://api.github.com/users/mjkkirschner/followers","following_url":"https://api.github.com/users/mjkkirschner/following{/other_user}","gists_url":"https://api.github.com/users/mjkkirschner/gists{/gist_id}","starred_url":"https://api.github.com/users/mjkkirschner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjkkirschner/subscriptions","organizations_url":"https://api.github.com/users/mjkkirschner/orgs","repos_url":"https://api.github.com/users/mjkkirschner/repos","events_url":"https://api.github.com/users/mjkkirschner/events{/privacy}","received_events_url":"https://api.github.com/users/mjkkirschner/received_events","type":"User","site_admin":false},"repo":{"id":14159492,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE1OTQ5Mg==","name":"Dynamo","full_name":"mjkkirschner/Dynamo","private":false,"owner":{"login":"mjkkirschner","id":508936,"node_id":"MDQ6VXNlcjUwODkzNg==","avatar_url":"https://avatars3.githubusercontent.com/u/508936?v=4","gravatar_id":"","url":"https://api.github.com/users/mjkkirschner","html_url":"https://github.com/mjkkirschner","followers_url":"https://api.github.com/users/mjkkirschner/followers","following_url":"https://api.github.com/users/mjkkirschner/following{/other_user}","gists_url":"https://api.github.com/users/mjkkirschner/gists{/gist_id}","starred_url":"https://api.github.com/users/mjkkirschner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjkkirschner/subscriptions","organizations_url":"https://api.github.com/users/mjkkirschner/orgs","repos_url":"https://api.github.com/users/mjkkirschner/repos","events_url":"https://api.github.com/users/mjkkirschner/events{/privacy}","received_events_url":"https://api.github.com/users/mjkkirschner/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mjkkirschner/Dynamo","description":"Visual Programming For Revit","fork":true,"url":"https://api.github.com/repos/mjkkirschner/Dynamo","forks_url":"https://api.github.com/repos/mjkkirschner/Dynamo/forks","keys_url":"https://api.github.com/repos/mjkkirschner/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjkkirschner/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjkkirschner/Dynamo/teams","hooks_url":"https://api.github.com/repos/mjkkirschner/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/mjkkirschner/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/mjkkirschner/Dynamo/events","assignees_url":"https://api.github.com/repos/mjkkirschner/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/mjkkirschner/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/mjkkirschner/Dynamo/tags","blobs_url":"https://api.github.com/repos/mjkkirschner/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjkkirschner/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjkkirschner/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjkkirschner/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjkkirschner/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/mjkkirschner/Dynamo/languages","stargazers_url":"https://api.github.com/repos/mjkkirschner/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/mjkkirschner/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/mjkkirschner/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/mjkkirschner/Dynamo/subscription","commits_url":"https://api.github.com/repos/mjkkirschner/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjkkirschner/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjkkirschner/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjkkirschner/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjkkirschner/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/mjkkirschner/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjkkirschner/Dynamo/merges","archive_url":"https://api.github.com/repos/mjkkirschner/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjkkirschner/Dynamo/downloads","issues_url":"https://api.github.com/repos/mjkkirschner/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/mjkkirschner/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/mjkkirschner/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/mjkkirschner/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjkkirschner/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/mjkkirschner/Dynamo/releases{/id}","deployments_url":"https://api.github.com/repos/mjkkirschner/Dynamo/deployments","created_at":"2013-11-06T01:18:42Z","updated_at":"2015-01-20T19:30:58Z","pushed_at":"2018-12-20T02:29:14Z","git_url":"git://github.com/mjkkirschner/Dynamo.git","ssh_url":"git@github.com:mjkkirschner/Dynamo.git","clone_url":"https://github.com/mjkkirschner/Dynamo.git","svn_url":"https://github.com/mjkkirschner/Dynamo","homepage":"http://dynamobim.org","size":1163895,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DynamoDS:master","ref":"master","sha":"28bbd9be0fe40325f293798406c18e2b6cc65d9e","user":{"login":"DynamoDS","id":6528209,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjgyMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6528209?v=4","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":3395179,"node_id":"MDEwOlJlcG9zaXRvcnkzMzk1MTc5","name":"Dynamo","full_name":"DynamoDS/Dynamo","private":false,"owner":{"login":"DynamoDS","id":6528209,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjgyMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6528209?v=4","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DynamoDS/Dynamo","description":"Open Source Graphical Programming for Design","fork":false,"url":"https://api.github.com/repos/DynamoDS/Dynamo","forks_url":"https://api.github.com/repos/DynamoDS/Dynamo/forks","keys_url":"https://api.github.com/repos/DynamoDS/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/Dynamo/teams","hooks_url":"https://api.github.com/repos/DynamoDS/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/events","assignees_url":"https://api.github.com/repos/DynamoDS/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/tags","blobs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/Dynamo/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscription","commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoDS/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/Dynamo/merges","archive_url":"https://api.github.com/repos/DynamoDS/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/Dynamo/downloads","issues_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/Dynamo/releases{/id}","deployments_url":"https://api.github.com/repos/DynamoDS/Dynamo/deployments","created_at":"2012-02-09T07:35:33Z","updated_at":"2018-12-19T21:30:35Z","pushed_at":"2018-12-20T17:09:08Z","git_url":"git://github.com/DynamoDS/Dynamo.git","ssh_url":"git@github.com:DynamoDS/Dynamo.git","clone_url":"https://github.com/DynamoDS/Dynamo.git","svn_url":"https://github.com/DynamoDS/Dynamo","homepage":"http://dynamobim.org","size":1404469,"stargazers_count":666,"watchers_count":666,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":382,"mirror_url":null,"archived":false,"open_issues_count":373,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":382,"open_issues":373,"watchers":666,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9330"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/9330"},"issue":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/9330"},"comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/9330/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9330/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/9330/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/7f082592cc5a41f74dc114d444b9d132608dd58c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"aparajit-pratap"}}