{"push_id":2746984427,"size":7,"distinct_size":3,"ref":"refs/heads/network-registrations","head":"7319c279f0fbfd49c8e76c0f09f18d061de92c47","before":"32cfdfecd2a278e67af893d8d92d5b8cfd2670a6","commits":[{"sha":"5e5dec4c550dba5e2e5eff4569c3ed2da9779a4e","author":{"name":"Dan Gershony","email":"e23cea8156837de889461882c8c5dc2705e28bb4@gmail.com"},"message":"Validator headers (#1683)\n\n* Next work rule in to calculate rule\r\n\r\n* Creating header rules\r\n\r\n* Creating some header rules\r\n\r\n* Minor fix\r\n\r\n* Coinview persistence\r\n\r\n* Fixing some tests\r\n\r\n* Act on review\r\n\r\n* All tests pass (apart for SC)\r\n\r\n* Fixing smart contract tests (some still failing).\r\n\r\n* Creating difficulty validation headers\r\n\r\n* Correctly check pow height\r\n\r\n* Some renameing\r\n\r\n* using uints\r\n\r\n* Act on review","distinct":false,"url":"https://api.github.com/repos/rowandh/StratisBitcoinFullNode/commits/5e5dec4c550dba5e2e5eff4569c3ed2da9779a4e"},{"sha":"6689d4f69e1f2dd91f11a128dd16b30e5c0f5cd5","author":{"name":"Fazz","email":"db56b96a97d83db4f6e5c700a69f30839f5c33f8@users.noreply.github.com"},"message":"Peer Discovery: Add filtering based on IP ranges #1216 (#1660)\n\n* First check in: Peer Discovery - add filtering based on IP ranges (#1216)\r\n\r\n* Refactor, bugfix in logic, config support for Nullable<bool> (#1216)\r\n\r\n* Review feedback (#1216)\r\n\r\n* Comment fixes, refactoring,  tests extended (#1216)\r\n\r\n* Updated tests, replace IsLocal with IsRoutable (#1216)\r\n\r\n* Reverting changes to < size of PR (#1216).\r\n\r\n* Commenting, test data standardisation, refactoring (#1216).\r\n\r\n* Formatting, config corrections (#1216).\r\n\r\n* Fix failing tests: add missing peers to ConnectionManager (#1216).\r\n\r\n* Mock ConnectionManager and update to reflect new peers (#1216).\r\n\r\n* Formatting: added line (#1216).","distinct":false,"url":"https://api.github.com/repos/rowandh/StratisBitcoinFullNode/commits/6689d4f69e1f2dd91f11a128dd16b30e5c0f5cd5"},{"sha":"4ddebe2b0e38b7ac56b11fa2614f49bd9cebe880","author":{"name":"Andy Davis","email":"64b2b6d12bfe4baae7dad3d018f8cbf6b0e7a044@andy-davis.co.uk"},"message":"Node settings not used, so removed (#1722)","distinct":false,"url":"https://api.github.com/repos/rowandh/StratisBitcoinFullNode/commits/4ddebe2b0e38b7ac56b11fa2614f49bd9cebe880"},{"sha":"a026cd58da8f78bda73997785ef33d068d6b2b2c","author":{"name":"Aleksei","email":"1880225d6e6779e7a3c4c4db7aa3341631395fed@gmail.com"},"message":"CHT Issue 19 & 6 Common test cases (#1608)\n\n* Common Cases and Issue 19\r\n\r\n* removed notfinished test\r\n\r\n* #1936 #1765 #1806\r\n\r\n* Test Issue 19 #1766\r\n\r\n* code cleanup\r\n\r\n* formating fix\r\n\r\n* test fix. resolve comments\r\n\r\n* clean formating\r\n\r\n* fixed formation\r\n\r\n* Decline .Next pointer usage.\r\n\r\n* fixed test. changed order for basic tests.\r\n\r\n* Formating issues fixed\r\n\r\n* fixed/refactored test case\r\n\r\n* used static const for localpeer\r\n\r\n* edits","distinct":false,"url":"https://api.github.com/repos/rowandh/StratisBitcoinFullNode/commits/a026cd58da8f78bda73997785ef33d068d6b2b2c"},{"sha":"30f91f021663eaa44635f4fd3236503c4a84196d","author":{"name":"Rowan de Haas","email":"c08991e38e107f6a434836bddb09fb7c57270f23@users.noreply.github.com"},"message":"Remove Consensus from ConsensusFactory (#1717)\n\n* Change checks for POS\r\n\r\n* Remove Consensus property from ConsensusFactory\r\n\r\n* Fix StratisTest and StratisRegTest","distinct":true,"url":"https://api.github.com/repos/rowandh/StratisBitcoinFullNode/commits/30f91f021663eaa44635f4fd3236503c4a84196d"},{"sha":"1a8822a8aad10e1237eb00420809f0ff08787d68","author":{"name":"Francois de la Rouviere","email":"6f4bbf3c79085089f01a384adecf2e945e3a4f92@gmail.com"},"message":"[SC] Merge sc-dev to master (#1733)\n\n* [SC] Separate CallData deserialization (#1661)\r\n\r\nMove CallData serialization into its own class\r\n\r\n* MockChain (#1670)\r\n\r\n* Remove VM builder and SmartContractNetworkSimulator (#1668)\r\n\r\n* [SC] Revert last 2 merges (#1672)\r\n\r\n* Revert \"Remove VM builder and SmartContractNetworkSimulator (#1668)\"\r\n\r\nThis reverts commit 48912ce6e5cf89ef16843b54bfb896bbe675f124.\r\n\r\n* Revert \"Merge branch 'sc-dev'\"\r\n\r\nThis reverts commit 7428d2cfa30afc238f4d1355f3cef8634b10fcd2, reversing\r\nchanges made to 7aefc3289a5392bf2341a2841ebacc7e894de9d9.\r\n\r\n* [SC] Push executor functionality to VM (#1674)\r\n\r\n* Add call data serializer and use in format rule\r\n\r\n* Add package ref\r\n\r\n* Begin using CallData in CallSmartContract\r\n\r\n* Add MethodParameters to CallData\r\n\r\n* Remove carrier from result transfer processor\r\n\r\n* Remove carrier from refund processor\r\n\r\n* Use CallData in CreateSmartContract\r\n\r\n* Fix tests\r\n\r\n* Register service\r\n\r\n* Remove dependency on Carrier.Deserialize\r\n\r\n* Update ReflectionVirtualMachineTests\r\n\r\n* Remove opcode from constructor\r\n\r\n* Rename and add call data serializer tests\r\n\r\n* Update ResultProcessorTests\r\n\r\n* Use call data deserializer\r\n\r\n* Remove unused methods\r\n\r\n* Move to own file\r\n\r\n* Remove unused\r\n\r\n* Add CallData param to Create\r\n\r\n* Update Create to use CallData\r\n\r\n* Remove unused\r\n\r\n* Add TransactionContext\r\n\r\n* Pass TransactionContext to Create\r\n\r\n* Remve dependency on ISmartContractExecutionContext\r\n\r\n* Remove ISmartContractExecutionContext from signature\r\n\r\n* Remove creation of context from executor\r\n\r\n* Generate address correctly in VM\r\n\r\n* Create account in VM\r\n\r\n* Create persistent state in VM\r\n\r\n* Return new contract address with execution result\r\n\r\n* Remove address creation from executor\r\n\r\n* Fix tests\r\n\r\n* Move basefee spend\r\n\r\n* Move decompilation and validation into VM\r\n\r\n* Fix tests\r\n\r\n* Remove unused constructor args\r\n\r\n* Consolidate methods\r\n\r\n* Add calldata and transactioncontext to call\r\n\r\n* Remove unused method params\r\n\r\n* Cleanup\r\n\r\n* Remove unused\r\n\r\n* Get code in VM\r\n\r\n* Move persistent state creation\r\n\r\n* Move basefee spend in call\r\n\r\n* Cleanup unused\r\n\r\n* Remove persistent state from signature\r\n\r\n* Use correct code\r\n\r\n* Fix test\r\n\r\n* Fix tests\r\n\r\n* Fix tests\r\n\r\n* Cleanup\r\n\r\n* DI interface\r\n\r\n* Remove unused param\r\n\r\n* Remove unused\r\n\r\n* Create correct nested context\r\n\r\n* Update test\r\n\r\n* Rename\r\n\r\n* Remove unused params and usings\r\n\r\n* Fix logging\r\n\r\n* [SC] Remove SmartContractVmBuilder and SmartContractNetworkSimulator  (#1675)\r\n\r\n* Redo\r\n\r\n* Fix DI\r\n\r\n* [SC] Executor consolidation (#1680)\r\n\r\n* Add call data serializer and use in format rule\r\n\r\n* Add package ref\r\n\r\n* Begin using CallData in CallSmartContract\r\n\r\n* Add MethodParameters to CallData\r\n\r\n* Remove carrier from result transfer processor\r\n\r\n* Remove carrier from refund processor\r\n\r\n* Use CallData in CreateSmartContract\r\n\r\n* Fix tests\r\n\r\n* Register service\r\n\r\n* Remove dependency on Carrier.Deserialize\r\n\r\n* Update ReflectionVirtualMachineTests\r\n\r\n* Remove opcode from constructor\r\n\r\n* Rename and add call data serializer tests\r\n\r\n* Update ResultProcessorTests\r\n\r\n* Use call data deserializer\r\n\r\n* Remove unused methods\r\n\r\n* Move to own file\r\n\r\n* Remove unused\r\n\r\n* Add CallData param to Create\r\n\r\n* Update Create to use CallData\r\n\r\n* Remove unused\r\n\r\n* Add TransactionContext\r\n\r\n* Pass TransactionContext to Create\r\n\r\n* Remve dependency on ISmartContractExecutionContext\r\n\r\n* Remove ISmartContractExecutionContext from signature\r\n\r\n* Remove creation of context from executor\r\n\r\n* Generate address correctly in VM\r\n\r\n* Create account in VM\r\n\r\n* Create persistent state in VM\r\n\r\n* Return new contract address with execution result\r\n\r\n* Remove address creation from executor\r\n\r\n* Fix tests\r\n\r\n* Move basefee spend\r\n\r\n* Move decompilation and validation into VM\r\n\r\n* Fix tests\r\n\r\n* Remove unused constructor args\r\n\r\n* Consolidate methods\r\n\r\n* Add calldata and transactioncontext to call\r\n\r\n* Remove unused method params\r\n\r\n* Cleanup\r\n\r\n* Remove unused\r\n\r\n* Get code in VM\r\n\r\n* Move persistent state creation\r\n\r\n* Move basefee spend in call\r\n\r\n* Cleanup unused\r\n\r\n* Remove persistent state from signature\r\n\r\n* Use correct code\r\n\r\n* Fix test\r\n\r\n* Fix tests\r\n\r\n* Fix tests\r\n\r\n* Cleanup\r\n\r\n* DI interface\r\n\r\n* Remove unused param\r\n\r\n* Remove unused\r\n\r\n* Create correct nested context\r\n\r\n* Update test\r\n\r\n* Rename\r\n\r\n* Remove unused params and usings\r\n\r\n* Consolidate Executors\r\n\r\n* Replace executor in tests\r\n\r\n* Remove old executors\r\n\r\n* Add doc\r\n\r\n* Add exit log\r\n\r\n* [SC] Recommit reverted changes (#1684)\r\n\r\n* Consensus manager behavior (CHB refactoring) (#1653)\r\n\r\n* Init with CHB\r\n\r\n* Work in progress\r\n\r\n* work in progress\r\n\r\n* work in progress\r\n\r\n* Upd\r\n\r\n* edits\r\n\r\n* Edits\r\n\r\n* minor edits\r\n\r\n* Edits\r\n\r\n* Fixes per review\r\n\r\n* Fixes per review\r\n\r\n* Fixes\r\n\r\n* Revert\r\n\r\n* Fixes per review\r\n\r\n* Fixes per review\r\n\r\n* fixes\r\n\r\n* More tests\r\n\r\n* Renamed blockLocators to blockLocator\r\n\r\n* Moved construction of headers payload to a separated method\r\n\r\n* Fixes per review\r\n\r\n* logs\r\n\r\n* [Integration Tests] Remove GenerateStratis (#1658)\r\n\r\nThis method is now an extension on the CoreNode as there are valid scenarios where want to inject transactions into block generation.\r\n\r\n* Connecting consensus rules (#1612)\r\n\r\n* Adding validators\r\n\r\n* Rename rule attributes and create two new attributes\r\n\r\n* Adding lists\r\n\r\n* Some fixes\r\n\r\n* Act on review\r\n\r\n* modifying BlockHeaderRule\r\n\r\n* Making some rules Obsolete\r\n\r\n* act on review\r\n\r\n* Inverting CanSkipValidation to be false by default\r\n\r\n* some changes (build is broken)\r\n\r\n* Calling the rules (not compiling)\r\n\r\n* IntegrityValidation rules\r\n\r\n* Fixing tests\r\n\r\n* Act on review\r\n\r\n* Fix failing test after merge\r\n\r\n* Feature plugins (#1651)\r\n\r\n* Initial commit\r\n\r\n* Further work on the new Apps Feature\r\n\r\n* Further work on the new Apps Feature\r\n\r\n* Stratis.Bitcoin.Features.Apps POC latest\r\n\r\n* Stratis.Bitcoin.Features.Apps latest (AppsController)\r\n\r\n* Latest Apps feature commit including Blazor apps browser\r\n\r\n* Added 'this' prefixes.\r\n\r\n* Apps Feature latest\r\n\r\n* Apps Feature latest\r\n\r\n* Apps Feature latest\r\n\r\n* Removed UseApps use from Stratis.Stratis.StratisD/Program.cs\r\n\r\n* Changes following PR feedback\r\n\r\n* Changes following merge\r\n\r\n* Changes following PR feedback:-\r\n- Removed Stratis.Bitcoin.Features.Apps.Browser project (is now Stratis.Bitcoin.Apps.Browser)\r\n- Removed redundant spaces from part of Stratis.Bitcoin.Features.Api/Startup.cs\r\n\r\n* Futher whitespace removed\r\n\r\n* Changes following PR feedback.  In particular:-\r\n- removed AppsFileService; now use FileStorage in utils\r\n- Attribute decoration of StratisApp in order to work with FileStorage\r\n\r\n* Latest following PR feedback\r\n\r\n* Changes following PR feedback.\r\n\r\n* [Integration Tests] Fix GenerateBlockManually (#1662)\r\n\r\n* Fix build\r\n\r\n* First pass\r\n\r\n* Remove GenerateWithStratis\r\n\r\n* Merge\r\n\r\n* Cleanup\r\n\r\n* Changes as per review\r\n\r\n* Fix tests\r\n\r\n* Fix test\r\n\r\n* fix test\r\n\r\n* Small refactor\r\n\r\n* Refactor\r\n\r\n* Fix SC test\r\n\r\n* Remove smart contract node sync test\r\n\r\n* Revert test\r\n\r\n* changes as per review\r\n\r\n* [SC] Separate CallData deserialization (#1661)\r\n\r\nMove CallData serialization into its own class\r\n\r\n* Remove VM builder and SmartContractNetworkSimulator (#1668)\r\n\r\n* [SC] Revert last 2 merges (#1672)\r\n\r\n* Revert \"Remove VM builder and SmartContractNetworkSimulator (#1668)\"\r\n\r\nThis reverts commit 48912ce6e5cf89ef16843b54bfb896bbe675f124.\r\n\r\n* Revert \"Merge branch 'sc-dev'\"\r\n\r\nThis reverts commit 7428d2cfa30afc238f4d1355f3cef8634b10fcd2, reversing\r\nchanges made to 7aefc3289a5392bf2341a2841ebacc7e894de9d9.\r\n\r\n* Revert \"[SC] Revert last 2 merges (#1672)\"\r\n\r\nThis reverts commit dabdf460ee4fd47535c7e245dd1fe5565f6323ab.\r\n\r\n* Fix tests\r\n\r\n* [SC] Precursor to creating contracts (#1681)\r\n\r\n* API Updates\r\n\r\n* Auxiliary Info\r\n\r\n* stashing\r\n\r\n* Updating tests etc\r\n\r\n* Updated Tests\r\n\r\n* Fixing tests and allowing multiple files in missed places\r\n\r\n* Per review\r\n\r\n* string.Empty\r\n\r\n* [SC] Compile multiple files within a directory. Option to compile specific namespace. (#1700)\r\n\r\n* API Updates\r\n\r\n* Auxiliary Info\r\n\r\n* stashing\r\n\r\n* Updating tests etc\r\n\r\n* Updated Tests\r\n\r\n* Fixing tests and allowing multiple files in missed places\r\n\r\n* Per review\r\n\r\n* string.Empty\r\n\r\n* API to compile multiple files\r\n\r\n* Handle entire directories too.\r\n\r\n* [SC] Separate CreateData and CallData (#1687)\r\n\r\nSeparates CreateData and CallData from ContractTxData\r\n\r\n* [SC] Create Smart Contract Wallet / Clean up sc code in wallet classes. (#1682)\r\n\r\n* First commit\r\n\r\n* solution fix\r\n\r\n* Add network to TransactionBuildContext\r\n\r\n* Fix smart contract test\r\n\r\n* Fixes as per review\r\n\r\n* Self Review\r\n\r\n* Changes as per review\r\n\r\n* Fix tests\r\n\r\n* Fixes as per review\r\n\r\n* Changes as poer review\r\n\r\n* Merge master into sc-dev (#1713)\r\n\r\n* Move ui to apps folder (#1673)\r\n\r\n* Made bblock signature validation rule non-skippable (#1663)\r\n\r\n* Fixed sorting issue with concurrent dictionary (#1664)\r\n\r\n* Fixed sorting issue with concurrent dictionary\r\n\r\n* Updated logic to use Values collection as it is thread safe and has a lock\r\n\r\n* missing singletons (#1676)\r\n\r\n* CMB tests. Part1 (#1667)\r\n\r\n* Tests description\r\n\r\n* Moved some chained header tools to a shared helper\r\n\r\n* Created interface for CM\r\n\r\n* Use CM interface and tests setting up\r\n\r\n* Edits\r\n\r\n* edits\r\n\r\n* stability fixes and fixes per review\r\n\r\n* optimizations\r\n\r\n* fixes per review\r\n\r\n* Merge NBitcoin fix for MacOSX buffer sizes (#1671)\r\n\r\nReference NBitcoin commit:\r\n\r\nhttps://github.com/MetacoSA/NBitcoin/commit/6ae1452e8e5252f3ea7aee3028d882199fe8e66a\r\n\r\nFixes #1173\r\n\r\n* CMB tests part 2 + added interface to connection manager behavior (#1679)\r\n\r\n* init\r\n\r\n* Add an interface for connection manager behavior\r\n\r\n* Implemented rest of ProcessGetHeadersAsync tests\r\n\r\n* comments\r\n\r\n* Fixes per review\r\n\r\n* Replaced contains with accert.Equal\r\n\r\n* Wallet xpub key support (#1652)\r\n\r\n* Wallet to work in readonly mode with a special field in the wallet json file of isExtPubKeyOnlyWallet\r\n\r\n* string -> bool\r\n\r\n* Method rename and reuse\r\n\r\n* Recover using xpub and account number\r\n\r\n* Recover wallet to work with the standard stratis xpub key bytes. Extra checks around adding existing accounts and existing account indexes when recovering with xpub.\r\n\r\n* Implemented protection on adding an account to xpubkey wallet via normal AddAccount endpoint\r\n\r\n* merge\r\n\r\n* Pulled legacy xpubkey converter into its own file with documentation\r\n\r\n* redundant returns docs\r\n\r\n* Changes as per @noescape00 review\r\n\r\n* summary update for xpub converter\r\n\r\n* inherit doc\r\n\r\n* Summary corrections\r\n\r\n* changes as per @bokobsa review\r\n\r\n* unvar\r\n\r\n* don't shuffle\r\n\r\n* added log traces\r\n\r\n* review changes\r\n\r\n* added log traces on returns and exceptions\r\n\r\n* lock around adding new account and log trace tweaks\r\n\r\n* inherit doc\r\n\r\n* lock in wallet manager instead of wallet\r\n\r\n* lock in wallet manager instead of wallet\r\n\r\n* Moved AddNewAccountLocked as local functions and renamed other Lock methods to Locked\r\n\r\n* ok, removed local function :)\r\n\r\n* Logger trace differentiator\r\n\r\n* do not AnnounceBlocks on null behaviors, Fix race condition expectation in MiningNodeWithOneConnectionAlwaysSynced, restore coinbase maturity after altering it in test (#1659)\r\n\r\n* do not call null behaviors\r\nrestore coinbaseMaturity upon leaving the test\r\n\r\n* try to detach behaviors upon disconnecting peers\r\n\r\n* just fix a typo\r\n\r\n* remove the 2 experimental lines\r\n\r\n* remove race condition test fromMiningNodeWithOneConnectionAlwaysSynced\r\nthis race condition is not guaranteed to happen which can make the test fail\r\nrewrite a bit the test to use NodeGroupBuilder instead of NetworkSimulator and delete NetworkSimulator\r\n\r\n* CMB tests part 3 (#1692)\r\n\r\n* setup tests\r\n\r\n* Added some tests\r\n\r\n* Edits\r\n\r\n* Fix\r\n\r\n* edits\r\n\r\n* Fix\r\n\r\n* Fixes per review\r\n\r\n* CMB tests part 4 (#1694)\r\n\r\n* Init some tests\r\n\r\n* Some more tests\r\n\r\n* Added more tests\r\n\r\n* fixes per review\r\n\r\n* fixes per review\r\n\r\n* Fix Build\r\n\r\n* [SC] Merge master into sc-dev (#1720)\r\n\r\n* Move ui to apps folder (#1673)\r\n\r\n* Made bblock signature validation rule non-skippable (#1663)\r\n\r\n* Fixed sorting issue with concurrent dictionary (#1664)\r\n\r\n* Fixed sorting issue with concurrent dictionary\r\n\r\n* Updated logic to use Values collection as it is thread safe and has a lock\r\n\r\n* missing singletons (#1676)\r\n\r\n* CMB tests. Part1 (#1667)\r\n\r\n* Tests description\r\n\r\n* Moved some chained header tools to a shared helper\r\n\r\n* Created interface for CM\r\n\r\n* Use CM interface and tests setting up\r\n\r\n* Edits\r\n\r\n* edits\r\n\r\n* stability fixes and fixes per review\r\n\r\n* optimizations\r\n\r\n* fixes per review\r\n\r\n* Merge NBitcoin fix for MacOSX buffer sizes (#1671)\r\n\r\nReference NBitcoin commit:\r\n\r\nhttps://github.com/MetacoSA/NBitcoin/commit/6ae1452e8e5252f3ea7aee3028d882199fe8e66a\r\n\r\nFixes #1173\r\n\r\n* CMB tests part 2 + added interface to connection manager behavior (#1679)\r\n\r\n* init\r\n\r\n* Add an interface for connection manager behavior\r\n\r\n* Implemented rest of ProcessGetHeadersAsync tests\r\n\r\n* comments\r\n\r\n* Fixes per review\r\n\r\n* Replaced contains with accert.Equal\r\n\r\n* Wallet xpub key support (#1652)\r\n\r\n* Wallet to work in readonly mode with a special field in the wallet json file of isExtPubKeyOnlyWallet\r\n\r\n* string -> bool\r\n\r\n* Method rename and reuse\r\n\r\n* Recover using xpub and account number\r\n\r\n* Recover wallet to work with the standard stratis xpub key bytes. Extra checks around adding existing accounts and existing account indexes when recovering with xpub.\r\n\r\n* Implemented protection on adding an account to xpubkey wallet via normal AddAccount endpoint\r\n\r\n* merge\r\n\r\n* Pulled legacy xpubkey converter into its own file with documentation\r\n\r\n* redundant returns docs\r\n\r\n* Changes as per @noescape00 review\r\n\r\n* summary update for xpub converter\r\n\r\n* inherit doc\r\n\r\n* Summary corrections\r\n\r\n* changes as per @bokobsa review\r\n\r\n* unvar\r\n\r\n* don't shuffle\r\n\r\n* added log traces\r\n\r\n* review changes\r\n\r\n* added log traces on returns and exceptions\r\n\r\n* lock around adding new account and log trace tweaks\r\n\r\n* inherit doc\r\n\r\n* lock in wallet manager instead of wallet\r\n\r\n* lock in wallet manager instead of wallet\r\n\r\n* Moved AddNewAccountLocked as local functions and renamed other Lock methods to Locked\r\n\r\n* ok, removed local function :)\r\n\r\n* Logger trace differentiator\r\n\r\n* do not AnnounceBlocks on null behaviors, Fix race condition expectation in MiningNodeWithOneConnectionAlwaysSynced, restore coinbase maturity after altering it in test (#1659)\r\n\r\n* do not call null behaviors\r\nrestore coinbaseMaturity upon leaving the test\r\n\r\n* try to detach behaviors upon disconnecting peers\r\n\r\n* just fix a typo\r\n\r\n* remove the 2 experimental lines\r\n\r\n* remove race condition test fromMiningNodeWithOneConnectionAlwaysSynced\r\nthis race condition is not guaranteed to happen which can make the test fail\r\nrewrite a bit the test to use NodeGroupBuilder instead of NetworkSimulator and delete NetworkSimulator\r\n\r\n* CMB tests part 3 (#1692)\r\n\r\n* setup tests\r\n\r\n* Added some tests\r\n\r\n* Edits\r\n\r\n* Fix\r\n\r\n* edits\r\n\r\n* Fix\r\n\r\n* Fixes per review\r\n\r\n* CMB tests part 4 (#1694)\r\n\r\n* Init some tests\r\n\r\n* Some more tests\r\n\r\n* Added more tests\r\n\r\n* fixes per review\r\n\r\n* fixes per review\r\n\r\n* -reindex command now functions as expected. (#1688)\r\n\r\n* Table names, error message and method stubs\r\n\r\n* Reindexing Functionality\r\n\r\n* Tests\r\n\r\n* Test improvements and documentation\r\n\r\n* PR changes\r\n\r\n*  ConsensusOptions per Network (#1704)\r\n\r\n* ConsensusOptions Rework\r\n\r\n* unvar\r\n\r\n* CHB tests part 5 (#1710)\r\n\r\n* ResyncAsync tests\r\n\r\n* more tests\r\n\r\n* fixes per review\r\n\r\n* fixes per review\r\n\r\n* Assign SmartContracts Consensus settings directly (#1715)\r\n\r\n* Assign all Consensus settings directly in inherited networks (#1571)\r\n\r\n* Set Consensus settings directly in StratisTest\r\n\r\n* Set Consensus settings directly in StratisRegTest\r\n\r\n* Set Consensus settings directly in BitcoinTest\r\n\r\n* Set Consensus settings directly in BitcoinRegTest\r\n\r\n* Update StratisRegTest to use StratisMain values\r\n\r\n* Revert \"Update StratisRegTest to use StratisMain values\"\r\n\r\nThis reverts commit 68a2983ec7591271587ca96b727a2bb9554cb778.\r\n\r\n* [SC] Merge master into sc-dev (#1727)\r\n\r\n* Move ui to apps folder (#1673)\r\n\r\n* Made bblock signature validation rule non-skippable (#1663)\r\n\r\n* Fixed sorting issue with concurrent dictionary (#1664)\r\n\r\n* Fixed sorting issue with concurrent dictionary\r\n\r\n* Updated logic to use Values collection as it is thread safe and has a lock\r\n\r\n* missing singletons (#1676)\r\n\r\n* CMB tests. Part1 (#1667)\r\n\r\n* Tests description\r\n\r\n* Moved some chained header tools to a shared helper\r\n\r\n* Created interface for CM\r\n\r\n* Use CM interface and tests setting up\r\n\r\n* Edits\r\n\r\n* edits\r\n\r\n* stability fixes and fixes per review\r\n\r\n* optimizations\r\n\r\n* fixes per review\r\n\r\n* Merge NBitcoin fix for MacOSX buffer sizes (#1671)\r\n\r\nReference NBitcoin commit:\r\n\r\nhttps://github.com/MetacoSA/NBitcoin/commit/6ae1452e8e5252f3ea7aee3028d882199fe8e66a\r\n\r\nFixes #1173\r\n\r\n* CMB tests part 2 + added interface to connection manager behavior (#1679)\r\n\r\n* init\r\n\r\n* Add an interface for connection manager behavior\r\n\r\n* Implemented rest of ProcessGetHeadersAsync tests\r\n\r\n* comments\r\n\r\n* Fixes per review\r\n\r\n* Replaced contains with accert.Equal\r\n\r\n* Wallet xpub key support (#1652)\r\n\r\n* Wallet to work in readonly mode with a special field in the wallet json file of isExtPubKeyOnlyWallet\r\n\r\n* string -> bool\r\n\r\n* Method rename and reuse\r\n\r\n* Recover using xpub and account number\r\n\r\n* Recover wallet to work with the standard stratis xpub key bytes. Extra checks around adding existing accounts and existing account indexes when recovering with xpub.\r\n\r\n* Implemented protection on adding an account to xpubkey wallet via normal AddAccount endpoint\r\n\r\n* merge\r\n\r\n* Pulled legacy xpubkey converter into its own file with documentation\r\n\r\n* redundant returns docs\r\n\r\n* Changes as per @noescape00 review\r\n\r\n* summary update for xpub converter\r\n\r\n* inherit doc\r\n\r\n* Summary corrections\r\n\r\n* changes as per @bokobsa review\r\n\r\n* unvar\r\n\r\n* don't shuffle\r\n\r\n* added log traces\r\n\r\n* review changes\r\n\r\n* added log traces on returns and exceptions\r\n\r\n* lock around adding new account and log trace tweaks\r\n\r\n* inherit doc\r\n\r\n* lock in wallet manager instead of wallet\r\n\r\n* lock in wallet manager instead of wallet\r\n\r\n* Moved AddNewAccountLocked as local functions and renamed other Lock methods to Locked\r\n\r\n* ok, removed local function :)\r\n\r\n* Logger trace differentiator\r\n\r\n* do not AnnounceBlocks on null behaviors, Fix race condition expectation in MiningNodeWithOneConnectionAlwaysSynced, restore coinbase maturity after altering it in test (#1659)\r\n\r\n* do not call null behaviors\r\nrestore coinbaseMaturity upon leaving the test\r\n\r\n* try to detach behaviors upon disconnecting peers\r\n\r\n* just fix a typo\r\n\r\n* remove the 2 experimental lines\r\n\r\n* remove race condition test fromMiningNodeWithOneConnectionAlwaysSynced\r\nthis race condition is not guaranteed to happen which can make the test fail\r\nrewrite a bit the test to use NodeGroupBuilder instead of NetworkSimulator and delete NetworkSimulator\r\n\r\n* CMB tests part 3 (#1692)\r\n\r\n* setup tests\r\n\r\n* Added some tests\r\n\r\n* Edits\r\n\r\n* Fix\r\n\r\n* edits\r\n\r\n* Fix\r\n\r\n* Fixes per review\r\n\r\n* CMB tests part 4 (#1694)\r\n\r\n* Init some tests\r\n\r\n* Some more tests\r\n\r\n* Added more tests\r\n\r\n* fixes per review\r\n\r\n* fixes per review\r\n\r\n* -reindex command now functions as expected. (#1688)\r\n\r\n* Table names, error message and method stubs\r\n\r\n* Reindexing Functionality\r\n\r\n* Tests\r\n\r\n* Test improvements and documentation\r\n\r\n* PR changes\r\n\r\n*  ConsensusOptions per Network (#1704)\r\n\r\n* ConsensusOptions Rework\r\n\r\n* unvar\r\n\r\n* CHB tests part 5 (#1710)\r\n\r\n* ResyncAsync tests\r\n\r\n* more tests\r\n\r\n* fixes per review\r\n\r\n* fixes per review\r\n\r\n* Assign SmartContracts Consensus settings directly (#1715)\r\n\r\n* Assign all Consensus settings directly in inherited networks (#1571)\r\n\r\n* Set Consensus settings directly in StratisTest\r\n\r\n* Set Consensus settings directly in StratisRegTest\r\n\r\n* Set Consensus settings directly in BitcoinTest\r\n\r\n* Set Consensus settings directly in BitcoinRegTest\r\n\r\n* Update StratisRegTest to use StratisMain values\r\n\r\n* Revert \"Update StratisRegTest to use StratisMain values\"\r\n\r\nThis reverts commit 68a2983ec7591271587ca96b727a2bb9554cb778.\r\n\r\n* Validator headers (#1683)\r\n\r\n* Next work rule in to calculate rule\r\n\r\n* Creating header rules\r\n\r\n* Creating some header rules\r\n\r\n* Minor fix\r\n\r\n* Coinview persistence\r\n\r\n* Fixing some tests\r\n\r\n* Act on review\r\n\r\n* All tests pass (apart for SC)\r\n\r\n* Fixing smart contract tests (some still failing).\r\n\r\n* Creating difficulty validation headers\r\n\r\n* Correctly check pow height\r\n\r\n* Some renameing\r\n\r\n* using uints\r\n\r\n* Act on review\r\n\r\n* Peer Discovery: Add filtering based on IP ranges #1216 (#1660)\r\n\r\n* First check in: Peer Discovery - add filtering based on IP ranges (#1216)\r\n\r\n* Refactor, bugfix in logic, config support for Nullable<bool> (#1216)\r\n\r\n* Review feedback (#1216)\r\n\r\n* Comment fixes, refactoring,  tests extended (#1216)\r\n\r\n* Updated tests, replace IsLocal with IsRoutable (#1216)\r\n\r\n* Reverting changes to < size of PR (#1216).\r\n\r\n* Commenting, test data standardisation, refactoring (#1216).\r\n\r\n* Formatting, config corrections (#1216).\r\n\r\n* Fix failing tests: add missing peers to ConnectionManager (#1216).\r\n\r\n* Mock ConnectionManager and update to reflect new peers (#1216).\r\n\r\n* Formatting: added line (#1216).\r\n\r\n* Node settings not used, so removed (#1722)\r\n\r\n* Fix rules","distinct":true,"url":"https://api.github.com/repos/rowandh/StratisBitcoinFullNode/commits/1a8822a8aad10e1237eb00420809f0ff08787d68"},{"sha":"7319c279f0fbfd49c8e76c0f09f18d061de92c47","author":{"name":"Francois de la Rouviere","email":"6f4bbf3c79085089f01a384adecf2e945e3a4f92@gmail.com"},"message":"Merge remote-tracking branch 'upstream/master' into network-registrations","distinct":true,"url":"https://api.github.com/repos/rowandh/StratisBitcoinFullNode/commits/7319c279f0fbfd49c8e76c0f09f18d061de92c47"}]}
{"actor":{"display_login":"fassadlr"}}