{"action":"created","comment":{"url":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/comments/213607745","pull_request_review_id":150477203,"id":213607745,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzYwNzc0NQ==","diff_hunk":"@@ -509,34 +517,72 @@ nm_config_cmd_line_options_free (NMConfigCmdLineOptions *cli)\n \tg_free (cli);\n }\n \n+static NMConfigConfigureAndQuitType\n+string_to_configure_and_quit (const char *value, GError **error)\n+{\n+\tNMConfigConfigureAndQuitType ret;\n+\n+\tif (value == NULL)\n+\t\treturn NM_CONFIG_CONFIGURE_AND_QUIT_DISABLED;\n+\n+\tif (strcmp (value, \"initrd\") == 0)\n+\t\treturn NM_CONFIG_CONFIGURE_AND_QUIT_INITRD;\n+\n+\tret = nm_config_parse_boolean (value, NM_CONFIG_CONFIGURE_AND_QUIT_INVALID);\n+\tif (ret == NM_CONFIG_CONFIGURE_AND_QUIT_INVALID)\n+\t\tg_set_error (error, 1, 0, N_(\"'%s' is not valid\"), value);\n+\n+\treturn ret;\n+}\n+\n+static gboolean\n+parse_configure_and_quit (const char *option_name, const char *value, gpointer user_data, GError **error)\n+{\n+\tNMConfigCmdLineOptions *cli = user_data;\n+\n+\tif (value == NULL)\n+\t\tcli->configure_and_quit = NM_CONFIG_CONFIGURE_AND_QUIT_ENABLED;\n+\telse\n+\t\tcli->configure_and_quit = string_to_configure_and_quit (value, error);\n+\n+\tif (cli->configure_and_quit == NM_CONFIG_CONFIGURE_AND_QUIT_INVALID) {\n+\t\tg_prefix_error (error, N_(\"Bad '%s' option: \"), option_name);\n+\t\treturn FALSE;\n+\t}\n+\n+\treturn TRUE;\n+}\n+\n void\n nm_config_cmd_line_options_add_to_entries (NMConfigCmdLineOptions *cli,\n                                            GOptionContext *opt_ctx)\n {\n+\tGOptionGroup *group;\n+\tGOptionEntry config_options[] = {\n+\t\t{ \"config\", 0, 0, G_OPTION_ARG_FILENAME, &cli->config_main_file, N_(\"Config file location\"), DEFAULT_CONFIG_MAIN_FILE },\n+\t\t{ \"config-dir\", 0, 0, G_OPTION_ARG_FILENAME, &cli->config_dir, N_(\"Config directory location\"), DEFAULT_CONFIG_DIR },\n+\t\t{ \"system-config-dir\", 0, 0, G_OPTION_ARG_FILENAME, &cli->system_config_dir, N_(\"System config directory location\"), DEFAULT_SYSTEM_CONFIG_DIR },\n+\t\t{ \"intern-config\", 0, 0, G_OPTION_ARG_FILENAME, &cli->intern_config_file, N_(\"Internal config file location\"), DEFAULT_INTERN_CONFIG_FILE },\n+\t\t{ \"state-file\", 0, 0, G_OPTION_ARG_FILENAME, &cli->state_file, N_(\"State file location\"), DEFAULT_STATE_FILE },\n+\t\t{ \"no-auto-default\", 0, G_OPTION_FLAG_HIDDEN, G_OPTION_ARG_FILENAME, &cli->no_auto_default_file, N_(\"State file for no-auto-default devices\"), DEFAULT_NO_AUTO_DEFAULT_FILE },\n+\t\t{ \"plugins\", 0, 0, G_OPTION_ARG_STRING, &cli->plugins, N_(\"List of plugins separated by ','\"), NM_CONFIG_DEFAULT_MAIN_PLUGINS },\n+\t\t{ \"configure-and-quit\", 0, G_OPTION_FLAG_OPTIONAL_ARG, G_OPTION_ARG_CALLBACK, parse_configure_and_quit, N_(\"Quit after initial configuration\"), NULL },\n+\t\t{ \"debug\", 'd', 0, G_OPTION_ARG_NONE, &cli->is_debug, N_(\"Don't become a daemon, and log to stderr\"), NULL },\n+\n+\t\t\t/* These three are hidden for now, and should eventually just go away. */\n+\t\t{ \"connectivity-uri\", 0, G_OPTION_FLAG_HIDDEN, G_OPTION_ARG_STRING, &cli->connectivity_uri, N_(\"An http(s) address for checking internet connectivity\"), \"http://example.com\" },\n+\t\t{ \"connectivity-interval\", 0, G_OPTION_FLAG_HIDDEN, G_OPTION_ARG_INT, &cli->connectivity_interval, N_(\"The interval between connectivity checks (in seconds)\"), G_STRINGIFY (NM_CONFIG_DEFAULT_CONNECTIVITY_INTERVAL) },\n+\t\t{ \"connectivity-response\", 0, G_OPTION_FLAG_HIDDEN, G_OPTION_ARG_STRING, &cli->connectivity_response, N_(\"The expected start of the response\"), NM_CONFIG_DEFAULT_CONNECTIVITY_RESPONSE },\n+\t\t{ 0 },\n+\t};\n+","path":"src/nm-config.c","position":117,"original_position":117,"commit_id":"fce164aa6cad198737d03aa2f889db983d0397a5","original_commit_id":"22728238e24d30617f698b17e5c6243d9fb76c25","user":{"login":"bengal","id":110632,"node_id":"MDQ6VXNlcjExMDYzMg==","avatar_url":"https://avatars2.githubusercontent.com/u/110632?v=4","gravatar_id":"","url":"https://api.github.com/users/bengal","html_url":"https://github.com/bengal","followers_url":"https://api.github.com/users/bengal/followers","following_url":"https://api.github.com/users/bengal/following{/other_user}","gists_url":"https://api.github.com/users/bengal/gists{/gist_id}","starred_url":"https://api.github.com/users/bengal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bengal/subscriptions","organizations_url":"https://api.github.com/users/bengal/orgs","repos_url":"https://api.github.com/users/bengal/repos","events_url":"https://api.github.com/users/bengal/events{/privacy}","received_events_url":"https://api.github.com/users/bengal/received_events","type":"User","site_admin":false},"body":"Can you also update the man page?","created_at":"2018-08-29T09:31:30Z","updated_at":"2018-08-29T09:31:31Z","html_url":"https://github.com/NetworkManager/NetworkManager/pull/116#discussion_r213607745","pull_request_url":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/116","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/comments/213607745"},"html":{"href":"https://github.com/NetworkManager/NetworkManager/pull/116#discussion_r213607745"},"pull_request":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/116","id":189437119,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5NDM3MTE5","html_url":"https://github.com/NetworkManager/NetworkManager/pull/116","diff_url":"https://github.com/NetworkManager/NetworkManager/pull/116.diff","patch_url":"https://github.com/NetworkManager/NetworkManager/pull/116.patch","issue_url":"https://api.github.com/repos/NetworkManager/NetworkManager/issues/116","number":116,"state":"open","locked":false,"title":"lr/initrd: support running from initrd","user":{"login":"lkundrak","id":92695,"node_id":"MDQ6VXNlcjkyNjk1","avatar_url":"https://avatars2.githubusercontent.com/u/92695?v=4","gravatar_id":"","url":"https://api.github.com/users/lkundrak","html_url":"https://github.com/lkundrak","followers_url":"https://api.github.com/users/lkundrak/followers","following_url":"https://api.github.com/users/lkundrak/following{/other_user}","gists_url":"https://api.github.com/users/lkundrak/gists{/gist_id}","starred_url":"https://api.github.com/users/lkundrak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkundrak/subscriptions","organizations_url":"https://api.github.com/users/lkundrak/orgs","repos_url":"https://api.github.com/users/lkundrak/repos","events_url":"https://api.github.com/users/lkundrak/events{/privacy}","received_events_url":"https://api.github.com/users/lkundrak/received_events","type":"User","site_admin":false},"body":":poodle: ","created_at":"2018-05-21T17:12:55Z","updated_at":"2018-08-29T09:31:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdec9ef80b860801b7a70f401d3da6dd3a303a84","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/116/commits","review_comments_url":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/116/comments","review_comment_url":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NetworkManager/NetworkManager/issues/116/comments","statuses_url":"https://api.github.com/repos/NetworkManager/NetworkManager/statuses/fce164aa6cad198737d03aa2f889db983d0397a5","head":{"label":"lkundrak:lr/initrd","ref":"lr/initrd","sha":"fce164aa6cad198737d03aa2f889db983d0397a5","user":{"login":"lkundrak","id":92695,"node_id":"MDQ6VXNlcjkyNjk1","avatar_url":"https://avatars2.githubusercontent.com/u/92695?v=4","gravatar_id":"","url":"https://api.github.com/users/lkundrak","html_url":"https://github.com/lkundrak","followers_url":"https://api.github.com/users/lkundrak/followers","following_url":"https://api.github.com/users/lkundrak/following{/other_user}","gists_url":"https://api.github.com/users/lkundrak/gists{/gist_id}","starred_url":"https://api.github.com/users/lkundrak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkundrak/subscriptions","organizations_url":"https://api.github.com/users/lkundrak/orgs","repos_url":"https://api.github.com/users/lkundrak/repos","events_url":"https://api.github.com/users/lkundrak/events{/privacy}","received_events_url":"https://api.github.com/users/lkundrak/received_events","type":"User","site_admin":false},"repo":{"id":42936560,"node_id":"MDEwOlJlcG9zaXRvcnk0MjkzNjU2MA==","name":"NetworkManager","full_name":"lkundrak/NetworkManager","owner":{"login":"lkundrak","id":92695,"node_id":"MDQ6VXNlcjkyNjk1","avatar_url":"https://avatars2.githubusercontent.com/u/92695?v=4","gravatar_id":"","url":"https://api.github.com/users/lkundrak","html_url":"https://github.com/lkundrak","followers_url":"https://api.github.com/users/lkundrak/followers","following_url":"https://api.github.com/users/lkundrak/following{/other_user}","gists_url":"https://api.github.com/users/lkundrak/gists{/gist_id}","starred_url":"https://api.github.com/users/lkundrak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkundrak/subscriptions","organizations_url":"https://api.github.com/users/lkundrak/orgs","repos_url":"https://api.github.com/users/lkundrak/repos","events_url":"https://api.github.com/users/lkundrak/events{/privacy}","received_events_url":"https://api.github.com/users/lkundrak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lkundrak/NetworkManager","description":"Mirror of the freedesktop.org repository. Feel free to do the pull requests!","fork":true,"url":"https://api.github.com/repos/lkundrak/NetworkManager","forks_url":"https://api.github.com/repos/lkundrak/NetworkManager/forks","keys_url":"https://api.github.com/repos/lkundrak/NetworkManager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lkundrak/NetworkManager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lkundrak/NetworkManager/teams","hooks_url":"https://api.github.com/repos/lkundrak/NetworkManager/hooks","issue_events_url":"https://api.github.com/repos/lkundrak/NetworkManager/issues/events{/number}","events_url":"https://api.github.com/repos/lkundrak/NetworkManager/events","assignees_url":"https://api.github.com/repos/lkundrak/NetworkManager/assignees{/user}","branches_url":"https://api.github.com/repos/lkundrak/NetworkManager/branches{/branch}","tags_url":"https://api.github.com/repos/lkundrak/NetworkManager/tags","blobs_url":"https://api.github.com/repos/lkundrak/NetworkManager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lkundrak/NetworkManager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lkundrak/NetworkManager/git/refs{/sha}","trees_url":"https://api.github.com/repos/lkundrak/NetworkManager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lkundrak/NetworkManager/statuses/{sha}","languages_url":"https://api.github.com/repos/lkundrak/NetworkManager/languages","stargazers_url":"https://api.github.com/repos/lkundrak/NetworkManager/stargazers","contributors_url":"https://api.github.com/repos/lkundrak/NetworkManager/contributors","subscribers_url":"https://api.github.com/repos/lkundrak/NetworkManager/subscribers","subscription_url":"https://api.github.com/repos/lkundrak/NetworkManager/subscription","commits_url":"https://api.github.com/repos/lkundrak/NetworkManager/commits{/sha}","git_commits_url":"https://api.github.com/repos/lkundrak/NetworkManager/git/commits{/sha}","comments_url":"https://api.github.com/repos/lkundrak/NetworkManager/comments{/number}","issue_comment_url":"https://api.github.com/repos/lkundrak/NetworkManager/issues/comments{/number}","contents_url":"https://api.github.com/repos/lkundrak/NetworkManager/contents/{+path}","compare_url":"https://api.github.com/repos/lkundrak/NetworkManager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lkundrak/NetworkManager/merges","archive_url":"https://api.github.com/repos/lkundrak/NetworkManager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lkundrak/NetworkManager/downloads","issues_url":"https://api.github.com/repos/lkundrak/NetworkManager/issues{/number}","pulls_url":"https://api.github.com/repos/lkundrak/NetworkManager/pulls{/number}","milestones_url":"https://api.github.com/repos/lkundrak/NetworkManager/milestones{/number}","notifications_url":"https://api.github.com/repos/lkundrak/NetworkManager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lkundrak/NetworkManager/labels{/name}","releases_url":"https://api.github.com/repos/lkundrak/NetworkManager/releases{/id}","deployments_url":"https://api.github.com/repos/lkundrak/NetworkManager/deployments","created_at":"2015-09-22T13:48:43Z","updated_at":"2016-01-12T09:41:30Z","pushed_at":"2018-08-27T11:23:08Z","git_url":"git://github.com/lkundrak/NetworkManager.git","ssh_url":"git@github.com:lkundrak/NetworkManager.git","clone_url":"https://github.com/lkundrak/NetworkManager.git","svn_url":"https://github.com/lkundrak/NetworkManager","homepage":"http://cgit.freedesktop.org/NetworkManager/NetworkManager/","size":106952,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NetworkManager:master","ref":"master","sha":"304e21164081e7c1c630bfa89485fdb55787358f","user":{"login":"NetworkManager","id":14775807,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Nzc1ODA3","avatar_url":"https://avatars2.githubusercontent.com/u/14775807?v=4","gravatar_id":"","url":"https://api.github.com/users/NetworkManager","html_url":"https://github.com/NetworkManager","followers_url":"https://api.github.com/users/NetworkManager/followers","following_url":"https://api.github.com/users/NetworkManager/following{/other_user}","gists_url":"https://api.github.com/users/NetworkManager/gists{/gist_id}","starred_url":"https://api.github.com/users/NetworkManager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetworkManager/subscriptions","organizations_url":"https://api.github.com/users/NetworkManager/orgs","repos_url":"https://api.github.com/users/NetworkManager/repos","events_url":"https://api.github.com/users/NetworkManager/events{/privacy}","received_events_url":"https://api.github.com/users/NetworkManager/received_events","type":"Organization","site_admin":false},"repo":{"id":42934521,"node_id":"MDEwOlJlcG9zaXRvcnk0MjkzNDUyMQ==","name":"NetworkManager","full_name":"NetworkManager/NetworkManager","owner":{"login":"NetworkManager","id":14775807,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Nzc1ODA3","avatar_url":"https://avatars2.githubusercontent.com/u/14775807?v=4","gravatar_id":"","url":"https://api.github.com/users/NetworkManager","html_url":"https://github.com/NetworkManager","followers_url":"https://api.github.com/users/NetworkManager/followers","following_url":"https://api.github.com/users/NetworkManager/following{/other_user}","gists_url":"https://api.github.com/users/NetworkManager/gists{/gist_id}","starred_url":"https://api.github.com/users/NetworkManager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetworkManager/subscriptions","organizations_url":"https://api.github.com/users/NetworkManager/orgs","repos_url":"https://api.github.com/users/NetworkManager/repos","events_url":"https://api.github.com/users/NetworkManager/events{/privacy}","received_events_url":"https://api.github.com/users/NetworkManager/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NetworkManager/NetworkManager","description":"Mirror of the freedesktop.org repository. Feel free to do the pull requests!","fork":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager","forks_url":"https://api.github.com/repos/NetworkManager/NetworkManager/forks","keys_url":"https://api.github.com/repos/NetworkManager/NetworkManager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NetworkManager/NetworkManager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NetworkManager/NetworkManager/teams","hooks_url":"https://api.github.com/repos/NetworkManager/NetworkManager/hooks","issue_events_url":"https://api.github.com/repos/NetworkManager/NetworkManager/issues/events{/number}","events_url":"https://api.github.com/repos/NetworkManager/NetworkManager/events","assignees_url":"https://api.github.com/repos/NetworkManager/NetworkManager/assignees{/user}","branches_url":"https://api.github.com/repos/NetworkManager/NetworkManager/branches{/branch}","tags_url":"https://api.github.com/repos/NetworkManager/NetworkManager/tags","blobs_url":"https://api.github.com/repos/NetworkManager/NetworkManager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NetworkManager/NetworkManager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NetworkManager/NetworkManager/git/refs{/sha}","trees_url":"https://api.github.com/repos/NetworkManager/NetworkManager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NetworkManager/NetworkManager/statuses/{sha}","languages_url":"https://api.github.com/repos/NetworkManager/NetworkManager/languages","stargazers_url":"https://api.github.com/repos/NetworkManager/NetworkManager/stargazers","contributors_url":"https://api.github.com/repos/NetworkManager/NetworkManager/contributors","subscribers_url":"https://api.github.com/repos/NetworkManager/NetworkManager/subscribers","subscription_url":"https://api.github.com/repos/NetworkManager/NetworkManager/subscription","commits_url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits{/sha}","git_commits_url":"https://api.github.com/repos/NetworkManager/NetworkManager/git/commits{/sha}","comments_url":"https://api.github.com/repos/NetworkManager/NetworkManager/comments{/number}","issue_comment_url":"https://api.github.com/repos/NetworkManager/NetworkManager/issues/comments{/number}","contents_url":"https://api.github.com/repos/NetworkManager/NetworkManager/contents/{+path}","compare_url":"https://api.github.com/repos/NetworkManager/NetworkManager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NetworkManager/NetworkManager/merges","archive_url":"https://api.github.com/repos/NetworkManager/NetworkManager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NetworkManager/NetworkManager/downloads","issues_url":"https://api.github.com/repos/NetworkManager/NetworkManager/issues{/number}","pulls_url":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls{/number}","milestones_url":"https://api.github.com/repos/NetworkManager/NetworkManager/milestones{/number}","notifications_url":"https://api.github.com/repos/NetworkManager/NetworkManager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NetworkManager/NetworkManager/labels{/name}","releases_url":"https://api.github.com/repos/NetworkManager/NetworkManager/releases{/id}","deployments_url":"https://api.github.com/repos/NetworkManager/NetworkManager/deployments","created_at":"2015-09-22T13:12:35Z","updated_at":"2018-08-28T20:30:28Z","pushed_at":"2018-08-28T20:32:08Z","git_url":"git://github.com/NetworkManager/NetworkManager.git","ssh_url":"git@github.com:NetworkManager/NetworkManager.git","clone_url":"https://github.com/NetworkManager/NetworkManager.git","svn_url":"https://github.com/NetworkManager/NetworkManager","homepage":"https://gitlab.freedesktop.org/NetworkManager/NetworkManager","size":109983,"stargazers_count":58,"watchers_count":58,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":67,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":67,"open_issues":10,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/116"},"html":{"href":"https://github.com/NetworkManager/NetworkManager/pull/116"},"issue":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/issues/116"},"comments":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/NetworkManager/NetworkManager/statuses/fce164aa6cad198737d03aa2f889db983d0397a5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bengal"}}