{"action":"closed","number":29,"pull_request":{"url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/pulls/29","id":242235381,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMjM1Mzgx","html_url":"https://github.com/ONSdigital/eq-smoke-tests/pull/29","diff_url":"https://github.com/ONSdigital/eq-smoke-tests/pull/29.diff","patch_url":"https://github.com/ONSdigital/eq-smoke-tests/pull/29.patch","issue_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/issues/29","number":29,"state":"closed","locked":false,"title":"Failing to update questionnaire properties","user":{"login":"tgandrews","id":180903,"node_id":"MDQ6VXNlcjE4MDkwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/180903?v=4","gravatar_id":"","url":"https://api.github.com/users/tgandrews","html_url":"https://github.com/tgandrews","followers_url":"https://api.github.com/users/tgandrews/followers","following_url":"https://api.github.com/users/tgandrews/following{/other_user}","gists_url":"https://api.github.com/users/tgandrews/gists{/gist_id}","starred_url":"https://api.github.com/users/tgandrews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgandrews/subscriptions","organizations_url":"https://api.github.com/users/tgandrews/orgs","repos_url":"https://api.github.com/users/tgandrews/repos","events_url":"https://api.github.com/users/tgandrews/events{/privacy}","received_events_url":"https://api.github.com/users/tgandrews/received_events","type":"User","site_admin":false},"body":"They are failing because for some reason cypress is clearing out the\r\nlocalStorage so the first couple of graphql calls fail - it then\r\nsucceeds.\r\n\r\nCypress is supposed to fully clear out localStorage between tests (`it`)\r\nbut seems to do it badly. They want to give users control over this but\r\nthat is coming later. https://github.com/cypress-io/cypress/issues/686\r\n\r\n~~To resolve this issue for the moment - saving logging in over and over\r\nis to put all the work into 2 tests, one for author side and one for\r\nrunner.~~\r\nTo resolve this issue for the moment is to cache the access token and\r\nre-add it at the start of each test.","created_at":"2019-01-04T11:15:25Z","updated_at":"2019-01-04T15:10:46Z","closed_at":"2019-01-04T15:10:46Z","merged_at":"2019-01-04T15:10:46Z","merge_commit_sha":"00b63534eeae89b6067148b0e69a7cf3b9b8b882","assignee":null,"assignees":[],"requested_reviewers":[{"login":"samiwel","id":4097796,"node_id":"MDQ6VXNlcjQwOTc3OTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4097796?v=4","gravatar_id":"","url":"https://api.github.com/users/samiwel","html_url":"https://github.com/samiwel","followers_url":"https://api.github.com/users/samiwel/followers","following_url":"https://api.github.com/users/samiwel/following{/other_user}","gists_url":"https://api.github.com/users/samiwel/gists{/gist_id}","starred_url":"https://api.github.com/users/samiwel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samiwel/subscriptions","organizations_url":"https://api.github.com/users/samiwel/orgs","repos_url":"https://api.github.com/users/samiwel/repos","events_url":"https://api.github.com/users/samiwel/events{/privacy}","received_events_url":"https://api.github.com/users/samiwel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/pulls/29/commits","review_comments_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/pulls/29/comments","review_comment_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/issues/29/comments","statuses_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/statuses/0b4f70ebb0456a5199976a9430ad976b9a0825b2","head":{"label":"ONSdigital:bug-failing-to-add-answer","ref":"bug-failing-to-add-answer","sha":"0b4f70ebb0456a5199976a9430ad976b9a0825b2","user":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":110829375,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA4MjkzNzU=","name":"eq-smoke-tests","full_name":"ONSdigital/eq-smoke-tests","private":false,"owner":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ONSdigital/eq-smoke-tests","description":null,"fork":false,"url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests","forks_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/forks","keys_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/teams","hooks_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/events","assignees_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/tags","blobs_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/subscription","commits_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/merges","archive_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/downloads","issues_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/deployments","created_at":"2017-11-15T12:14:53Z","updated_at":"2018-12-20T10:18:43Z","pushed_at":"2019-01-04T15:10:46Z","git_url":"git://github.com/ONSdigital/eq-smoke-tests.git","ssh_url":"git@github.com:ONSdigital/eq-smoke-tests.git","clone_url":"https://github.com/ONSdigital/eq-smoke-tests.git","svn_url":"https://github.com/ONSdigital/eq-smoke-tests","homepage":null,"size":171,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ONSdigital:master","ref":"master","sha":"c0103d12277dd09dc5ac64850462341f17a6e892","user":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":110829375,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA4MjkzNzU=","name":"eq-smoke-tests","full_name":"ONSdigital/eq-smoke-tests","private":false,"owner":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ONSdigital/eq-smoke-tests","description":null,"fork":false,"url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests","forks_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/forks","keys_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/teams","hooks_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/events","assignees_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/tags","blobs_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/subscription","commits_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/merges","archive_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/downloads","issues_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/deployments","created_at":"2017-11-15T12:14:53Z","updated_at":"2018-12-20T10:18:43Z","pushed_at":"2019-01-04T15:10:46Z","git_url":"git://github.com/ONSdigital/eq-smoke-tests.git","ssh_url":"git@github.com:ONSdigital/eq-smoke-tests.git","clone_url":"https://github.com/ONSdigital/eq-smoke-tests.git","svn_url":"https://github.com/ONSdigital/eq-smoke-tests","homepage":null,"size":171,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/pulls/29"},"html":{"href":"https://github.com/ONSdigital/eq-smoke-tests/pull/29"},"issue":{"href":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/issues/29"},"comments":{"href":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/ONSdigital/eq-smoke-tests/statuses/0b4f70ebb0456a5199976a9430ad976b9a0825b2"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tgandrews","id":180903,"node_id":"MDQ6VXNlcjE4MDkwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/180903?v=4","gravatar_id":"","url":"https://api.github.com/users/tgandrews","html_url":"https://github.com/tgandrews","followers_url":"https://api.github.com/users/tgandrews/followers","following_url":"https://api.github.com/users/tgandrews/following{/other_user}","gists_url":"https://api.github.com/users/tgandrews/gists{/gist_id}","starred_url":"https://api.github.com/users/tgandrews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgandrews/subscriptions","organizations_url":"https://api.github.com/users/tgandrews/orgs","repos_url":"https://api.github.com/users/tgandrews/repos","events_url":"https://api.github.com/users/tgandrews/events{/privacy}","received_events_url":"https://api.github.com/users/tgandrews/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":81,"deletions":47,"changed_files":1}}
{"actor":{"display_login":"tgandrews"}}