{"action":"created","comment":{"url":"https://api.github.com/repos/sensu/sensu-puppet/pulls/comments/208415584","pull_request_review_id":144220854,"id":208415584,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODQxNTU4NA==","diff_hunk":"@@ -0,0 +1,98 @@\n+require File.expand_path(File.join(File.dirname(__FILE__), '..', 'sensuctl'))","path":"lib/puppet/provider/sensu_cluster_member/sensuctl.rb","position":1,"original_position":1,"commit_id":"6578dd0d88fa1f4438903ca6c1e95a4e1699083a","original_commit_id":"6578dd0d88fa1f4438903ca6c1e95a4e1699083a","user":{"login":"treydock","id":739622,"node_id":"MDQ6VXNlcjczOTYyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/739622?v=4","gravatar_id":"","url":"https://api.github.com/users/treydock","html_url":"https://github.com/treydock","followers_url":"https://api.github.com/users/treydock/followers","following_url":"https://api.github.com/users/treydock/following{/other_user}","gists_url":"https://api.github.com/users/treydock/gists{/gist_id}","starred_url":"https://api.github.com/users/treydock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treydock/subscriptions","organizations_url":"https://api.github.com/users/treydock/orgs","repos_url":"https://api.github.com/users/treydock/repos","events_url":"https://api.github.com/users/treydock/events{/privacy}","received_events_url":"https://api.github.com/users/treydock/received_events","type":"User","site_admin":false},"body":"There is an example in the type description that will get picked up with puppet-strings, do we also want additional examples in README?  If yes, should we also document how to setup a cluster?  It's currently not documented by Sensu but managed to figure it out based on their docker compose configs.  This new type is tightly coupled to configs in `backend.yml` as they won't work without both being implemented.","created_at":"2018-08-07T23:27:29Z","updated_at":"2018-08-07T23:27:29Z","html_url":"https://github.com/sensu/sensu-puppet/pull/947#discussion_r208415584","pull_request_url":"https://api.github.com/repos/sensu/sensu-puppet/pulls/947","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/sensu/sensu-puppet/pulls/comments/208415584"},"html":{"href":"https://github.com/sensu/sensu-puppet/pull/947#discussion_r208415584"},"pull_request":{"href":"https://api.github.com/repos/sensu/sensu-puppet/pulls/947"}},"in_reply_to_id":207752076},"pull_request":{"url":"https://api.github.com/repos/sensu/sensu-puppet/pulls/947","id":206248972,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjQ4OTcy","html_url":"https://github.com/sensu/sensu-puppet/pull/947","diff_url":"https://github.com/sensu/sensu-puppet/pull/947.diff","patch_url":"https://github.com/sensu/sensu-puppet/pull/947.patch","issue_url":"https://api.github.com/repos/sensu/sensu-puppet/issues/947","number":947,"state":"open","locked":false,"title":"Add sensu_cluster_member type","user":{"login":"treydock","id":739622,"node_id":"MDQ6VXNlcjczOTYyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/739622?v=4","gravatar_id":"","url":"https://api.github.com/users/treydock","html_url":"https://github.com/treydock","followers_url":"https://api.github.com/users/treydock/followers","following_url":"https://api.github.com/users/treydock/following{/other_user}","gists_url":"https://api.github.com/users/treydock/gists{/gist_id}","starred_url":"https://api.github.com/users/treydock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treydock/subscriptions","organizations_url":"https://api.github.com/users/treydock/orgs","repos_url":"https://api.github.com/users/treydock/repos","events_url":"https://api.github.com/users/treydock/events{/privacy}","received_events_url":"https://api.github.com/users/treydock/received_events","type":"User","site_admin":false},"body":"# Pull Request Checklist\r\n\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nAdd a custom type that can add cluster members.\r\n\r\n## Related Issue\r\n<!--- Suggest creating an issue first and then referencing it here. -->\r\n<!--- If suggesting a new feature or change, please discuss it in an issue first -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here: -->\r\n\r\nPart of #901 \r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\nsensuctl supports adding members.  The members won't actually be fully added until the new member is started with the proper configuration.  The necessary configuration is printed by this custom type in the info output which comes from output of the `sensuctl` command to add the member.\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nAdded new way to run acceptance tests that spawn 3 backend servers.  Using only 2 caused issues (see https://github.com/sensu/sensu-go/issues/1890).  When `BEAKER_sensu_cluster` is `yes` or `true` the cluster acceptance tests are run.\r\n\r\n## General\r\n\r\n- [ ] Update `README.md` with any necessary configuration snippets\r\n\r\n- [ ] Tests pass - `bundle exec rake validate lint spec`\r\n","created_at":"2018-08-05T17:20:11Z","updated_at":"2018-08-07T23:27:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e24c5787b8b97a10fef733d5d6fecb8f947674e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sensu/sensu-puppet/pulls/947/commits","review_comments_url":"https://api.github.com/repos/sensu/sensu-puppet/pulls/947/comments","review_comment_url":"https://api.github.com/repos/sensu/sensu-puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sensu/sensu-puppet/issues/947/comments","statuses_url":"https://api.github.com/repos/sensu/sensu-puppet/statuses/6578dd0d88fa1f4438903ca6c1e95a4e1699083a","head":{"label":"treydock:sensu2-cluster-member","ref":"sensu2-cluster-member","sha":"6578dd0d88fa1f4438903ca6c1e95a4e1699083a","user":{"login":"treydock","id":739622,"node_id":"MDQ6VXNlcjczOTYyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/739622?v=4","gravatar_id":"","url":"https://api.github.com/users/treydock","html_url":"https://github.com/treydock","followers_url":"https://api.github.com/users/treydock/followers","following_url":"https://api.github.com/users/treydock/following{/other_user}","gists_url":"https://api.github.com/users/treydock/gists{/gist_id}","starred_url":"https://api.github.com/users/treydock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treydock/subscriptions","organizations_url":"https://api.github.com/users/treydock/orgs","repos_url":"https://api.github.com/users/treydock/repos","events_url":"https://api.github.com/users/treydock/events{/privacy}","received_events_url":"https://api.github.com/users/treydock/received_events","type":"User","site_admin":false},"repo":{"id":117577173,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc1NzcxNzM=","name":"sensu-puppet","full_name":"treydock/sensu-puppet","owner":{"login":"treydock","id":739622,"node_id":"MDQ6VXNlcjczOTYyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/739622?v=4","gravatar_id":"","url":"https://api.github.com/users/treydock","html_url":"https://github.com/treydock","followers_url":"https://api.github.com/users/treydock/followers","following_url":"https://api.github.com/users/treydock/following{/other_user}","gists_url":"https://api.github.com/users/treydock/gists{/gist_id}","starred_url":"https://api.github.com/users/treydock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treydock/subscriptions","organizations_url":"https://api.github.com/users/treydock/orgs","repos_url":"https://api.github.com/users/treydock/repos","events_url":"https://api.github.com/users/treydock/events{/privacy}","received_events_url":"https://api.github.com/users/treydock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/treydock/sensu-puppet","description":"Sensu Puppet module.","fork":true,"url":"https://api.github.com/repos/treydock/sensu-puppet","forks_url":"https://api.github.com/repos/treydock/sensu-puppet/forks","keys_url":"https://api.github.com/repos/treydock/sensu-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/treydock/sensu-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/treydock/sensu-puppet/teams","hooks_url":"https://api.github.com/repos/treydock/sensu-puppet/hooks","issue_events_url":"https://api.github.com/repos/treydock/sensu-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/treydock/sensu-puppet/events","assignees_url":"https://api.github.com/repos/treydock/sensu-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/treydock/sensu-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/treydock/sensu-puppet/tags","blobs_url":"https://api.github.com/repos/treydock/sensu-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/treydock/sensu-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/treydock/sensu-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/treydock/sensu-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/treydock/sensu-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/treydock/sensu-puppet/languages","stargazers_url":"https://api.github.com/repos/treydock/sensu-puppet/stargazers","contributors_url":"https://api.github.com/repos/treydock/sensu-puppet/contributors","subscribers_url":"https://api.github.com/repos/treydock/sensu-puppet/subscribers","subscription_url":"https://api.github.com/repos/treydock/sensu-puppet/subscription","commits_url":"https://api.github.com/repos/treydock/sensu-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/treydock/sensu-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/treydock/sensu-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/treydock/sensu-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/treydock/sensu-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/treydock/sensu-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/treydock/sensu-puppet/merges","archive_url":"https://api.github.com/repos/treydock/sensu-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/treydock/sensu-puppet/downloads","issues_url":"https://api.github.com/repos/treydock/sensu-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/treydock/sensu-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/treydock/sensu-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/treydock/sensu-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/treydock/sensu-puppet/labels{/name}","releases_url":"https://api.github.com/repos/treydock/sensu-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/treydock/sensu-puppet/deployments","created_at":"2018-01-15T17:52:17Z","updated_at":"2018-01-15T17:52:19Z","pushed_at":"2018-08-05T17:46:08Z","git_url":"git://github.com/treydock/sensu-puppet.git","ssh_url":"git@github.com:treydock/sensu-puppet.git","clone_url":"https://github.com/treydock/sensu-puppet.git","svn_url":"https://github.com/treydock/sensu-puppet","homepage":"https://github.com/sensu/sensu-puppet","size":1947,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sensu:sensu2","ref":"sensu2","sha":"c330c514b2d299cc04e57f97a7ee324372d35df2","user":{"login":"sensu","id":1648901,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDg5MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1648901?v=4","gravatar_id":"","url":"https://api.github.com/users/sensu","html_url":"https://github.com/sensu","followers_url":"https://api.github.com/users/sensu/followers","following_url":"https://api.github.com/users/sensu/following{/other_user}","gists_url":"https://api.github.com/users/sensu/gists{/gist_id}","starred_url":"https://api.github.com/users/sensu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sensu/subscriptions","organizations_url":"https://api.github.com/users/sensu/orgs","repos_url":"https://api.github.com/users/sensu/repos","events_url":"https://api.github.com/users/sensu/events{/privacy}","received_events_url":"https://api.github.com/users/sensu/received_events","type":"Organization","site_admin":false},"repo":{"id":4091770,"node_id":"MDEwOlJlcG9zaXRvcnk0MDkxNzcw","name":"sensu-puppet","full_name":"sensu/sensu-puppet","owner":{"login":"sensu","id":1648901,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDg5MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1648901?v=4","gravatar_id":"","url":"https://api.github.com/users/sensu","html_url":"https://github.com/sensu","followers_url":"https://api.github.com/users/sensu/followers","following_url":"https://api.github.com/users/sensu/following{/other_user}","gists_url":"https://api.github.com/users/sensu/gists{/gist_id}","starred_url":"https://api.github.com/users/sensu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sensu/subscriptions","organizations_url":"https://api.github.com/users/sensu/orgs","repos_url":"https://api.github.com/users/sensu/repos","events_url":"https://api.github.com/users/sensu/events{/privacy}","received_events_url":"https://api.github.com/users/sensu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sensu/sensu-puppet","description":"Sensu Puppet module.","fork":false,"url":"https://api.github.com/repos/sensu/sensu-puppet","forks_url":"https://api.github.com/repos/sensu/sensu-puppet/forks","keys_url":"https://api.github.com/repos/sensu/sensu-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sensu/sensu-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sensu/sensu-puppet/teams","hooks_url":"https://api.github.com/repos/sensu/sensu-puppet/hooks","issue_events_url":"https://api.github.com/repos/sensu/sensu-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/sensu/sensu-puppet/events","assignees_url":"https://api.github.com/repos/sensu/sensu-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/sensu/sensu-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/sensu/sensu-puppet/tags","blobs_url":"https://api.github.com/repos/sensu/sensu-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sensu/sensu-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sensu/sensu-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/sensu/sensu-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sensu/sensu-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/sensu/sensu-puppet/languages","stargazers_url":"https://api.github.com/repos/sensu/sensu-puppet/stargazers","contributors_url":"https://api.github.com/repos/sensu/sensu-puppet/contributors","subscribers_url":"https://api.github.com/repos/sensu/sensu-puppet/subscribers","subscription_url":"https://api.github.com/repos/sensu/sensu-puppet/subscription","commits_url":"https://api.github.com/repos/sensu/sensu-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/sensu/sensu-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/sensu/sensu-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/sensu/sensu-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/sensu/sensu-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/sensu/sensu-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sensu/sensu-puppet/merges","archive_url":"https://api.github.com/repos/sensu/sensu-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sensu/sensu-puppet/downloads","issues_url":"https://api.github.com/repos/sensu/sensu-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/sensu/sensu-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/sensu/sensu-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/sensu/sensu-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sensu/sensu-puppet/labels{/name}","releases_url":"https://api.github.com/repos/sensu/sensu-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/sensu/sensu-puppet/deployments","created_at":"2012-04-20T22:09:45Z","updated_at":"2018-07-06T11:02:48Z","pushed_at":"2018-08-05T17:46:09Z","git_url":"git://github.com/sensu/sensu-puppet.git","ssh_url":"git@github.com:sensu/sensu-puppet.git","clone_url":"https://github.com/sensu/sensu-puppet.git","svn_url":"https://github.com/sensu/sensu-puppet","homepage":"https://github.com/sensu/sensu-puppet","size":1944,"stargazers_count":164,"watchers_count":164,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":289,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":289,"open_issues":20,"watchers":164,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sensu/sensu-puppet/pulls/947"},"html":{"href":"https://github.com/sensu/sensu-puppet/pull/947"},"issue":{"href":"https://api.github.com/repos/sensu/sensu-puppet/issues/947"},"comments":{"href":"https://api.github.com/repos/sensu/sensu-puppet/issues/947/comments"},"review_comments":{"href":"https://api.github.com/repos/sensu/sensu-puppet/pulls/947/comments"},"review_comment":{"href":"https://api.github.com/repos/sensu/sensu-puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sensu/sensu-puppet/pulls/947/commits"},"statuses":{"href":"https://api.github.com/repos/sensu/sensu-puppet/statuses/6578dd0d88fa1f4438903ca6c1e95a4e1699083a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"treydock"}}