{"action":"created","issue":{"url":"https://api.github.com/repos/MGraefe/RP-Soundboard/issues/65","repository_url":"https://api.github.com/repos/MGraefe/RP-Soundboard","labels_url":"https://api.github.com/repos/MGraefe/RP-Soundboard/issues/65/labels{/name}","comments_url":"https://api.github.com/repos/MGraefe/RP-Soundboard/issues/65/comments","events_url":"https://api.github.com/repos/MGraefe/RP-Soundboard/issues/65/events","html_url":"https://github.com/MGraefe/RP-Soundboard/pull/65","id":354053093,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTI3MTIw","number":65,"title":"Changes update source to use HTTPS","user":{"login":"JoshGreen0x04","id":4805803,"node_id":"MDQ6VXNlcjQ4MDU4MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/4805803?v=4","gravatar_id":"","url":"https://api.github.com/users/JoshGreen0x04","html_url":"https://github.com/JoshGreen0x04","followers_url":"https://api.github.com/users/JoshGreen0x04/followers","following_url":"https://api.github.com/users/JoshGreen0x04/following{/other_user}","gists_url":"https://api.github.com/users/JoshGreen0x04/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshGreen0x04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshGreen0x04/subscriptions","organizations_url":"https://api.github.com/users/JoshGreen0x04/orgs","repos_url":"https://api.github.com/users/JoshGreen0x04/repos","events_url":"https://api.github.com/users/JoshGreen0x04/events{/privacy}","received_events_url":"https://api.github.com/users/JoshGreen0x04/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-26T00:13:19Z","updated_at":"2018-08-29T21:07:31Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/MGraefe/RP-Soundboard/pulls/65","html_url":"https://github.com/MGraefe/RP-Soundboard/pull/65","diff_url":"https://github.com/MGraefe/RP-Soundboard/pull/65.diff","patch_url":"https://github.com/MGraefe/RP-Soundboard/pull/65.patch"},"body":"Hi, I noticed your update site still works over HTTPS, this pull request is to change the update urls to use the HTTPS version. This is needed because using an unsecured HTTP connection might be intercepted and an attacker can modify the following xml:\r\n```\r\n<latestDownload>\r\n      <url>http://www.mediafire.com/file/9r4lz2bp51xt6w4/rp_soundboard_1733.ts3_plugin</url>\r\n</latestDownload>\r\n```\r\nto point to a malicious ts3 plugin. HTTPS will prevent this.\r\n\r\nCheers,\r\nJoshua Green"},"comment":{"url":"https://api.github.com/repos/MGraefe/RP-Soundboard/issues/comments/417106207","html_url":"https://github.com/MGraefe/RP-Soundboard/pull/65#issuecomment-417106207","issue_url":"https://api.github.com/repos/MGraefe/RP-Soundboard/issues/65","id":417106207,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzEwNjIwNw==","user":{"login":"MGraefe","id":8102494,"node_id":"MDQ6VXNlcjgxMDI0OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8102494?v=4","gravatar_id":"","url":"https://api.github.com/users/MGraefe","html_url":"https://github.com/MGraefe","followers_url":"https://api.github.com/users/MGraefe/followers","following_url":"https://api.github.com/users/MGraefe/following{/other_user}","gists_url":"https://api.github.com/users/MGraefe/gists{/gist_id}","starred_url":"https://api.github.com/users/MGraefe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MGraefe/subscriptions","organizations_url":"https://api.github.com/users/MGraefe/orgs","repos_url":"https://api.github.com/users/MGraefe/repos","events_url":"https://api.github.com/users/MGraefe/events{/privacy}","received_events_url":"https://api.github.com/users/MGraefe/received_events","type":"User","site_admin":false},"created_at":"2018-08-29T21:07:31Z","updated_at":"2018-08-29T21:07:31Z","author_association":"OWNER","body":"Usually if you can build the plugin, you can run it. Just remember to copy the dlls into the plugin directory. The plugin dll will then use the qt dlls that come with teamspeak.Am 29.08.2018 19:22 schrieb Joshua Green <notifications@github.com>:Ah sure thanks, and that's annoying. I used the prebuilt binaries ages ago but that required the qt dlls in the plugin directory to work. If you don't mind, could you let me know the options you used? Every resource I can find is asking me to build qt myself with -static, which so far is still not working.\r\n\r\n—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the thread."}}
{"actor":{"display_login":"MGraefe"}}