{"action":"created","comment":{"url":"https://api.github.com/repos/MysteriumNetwork/mysterion/pulls/comments/192124452","pull_request_review_id":124837102,"id":192124452,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjEyNDQ1Mg==","diff_hunk":"@@ -92,32 +92,26 @@\n         this.$store.dispatch(type.OVERLAY_ERROR, error)\n       })\n \n-      let previousClientRunningState = true\n+      // if the client was down, but now up, we need to unlock the identity once again\n+      this.rendererCommunication.onMysteriumClientUp(() => {\n+        this.$store.dispatch('setClientRunningState', true)\n \n-      this.rendererCommunication.onHealthCheck((healthCheckDTO) => {\n-        const clientRunningState = healthCheckDTO.isRunning\n         // do nothing while on terms page\n-        if (this.$route.name === 'terms') {\n-          return\n-        }\n-\n-        if (previousClientRunningState === clientRunningState) {\n-          return\n-        }\n-        previousClientRunningState = clientRunningState\n-\n-        // if the client was down, but now up, we need to unlock the identity once again\n-        if (clientRunningState) {\n+        if (this.$route.name !== 'terms') {\n           this.$store.dispatch(type.OVERLAY_ERROR, null)\n           this.$router.push('/load')\n-          return\n         }\n+      })\n+      this.rendererCommunication.onMysteriumClientDown(() => {\n+        this.$store.dispatch('setClientRunningState', false)\n \n-        this.$store.dispatch(type.OVERLAY_ERROR, {\n-          message: 'mysterium_client is down',\n-          hint: 'Please give it a moment to boot. If this message persists try restarting the app or please contact support'\n-        })\n-        this.$store.dispatch('setClientRunningState', clientRunningState)\n+        // do nothing while on terms page\n+        if (this.$route.name !== 'terms') {","path":"src/renderer/App.vue","position":38,"original_position":38,"commit_id":"11e4cc2b0093334f5726c04a921db03162ae95d3","original_commit_id":"11e4cc2b0093334f5726c04a921db03162ae95d3","user":{"login":"Waldz","id":2713911,"node_id":"MDQ6VXNlcjI3MTM5MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2713911?v=4","gravatar_id":"","url":"https://api.github.com/users/Waldz","html_url":"https://github.com/Waldz","followers_url":"https://api.github.com/users/Waldz/followers","following_url":"https://api.github.com/users/Waldz/following{/other_user}","gists_url":"https://api.github.com/users/Waldz/gists{/gist_id}","starred_url":"https://api.github.com/users/Waldz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Waldz/subscriptions","organizations_url":"https://api.github.com/users/Waldz/orgs","repos_url":"https://api.github.com/users/Waldz/repos","events_url":"https://api.github.com/users/Waldz/events{/privacy}","received_events_url":"https://api.github.com/users/Waldz/received_events","type":"User","site_admin":false},"body":"Too small improvement to worry about. Such conditional behaviour should be dropped at all ","created_at":"2018-05-31T14:45:01Z","updated_at":"2018-05-31T14:45:01Z","html_url":"https://github.com/MysteriumNetwork/mysterion/pull/161#discussion_r192124452","pull_request_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/pulls/161","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/MysteriumNetwork/mysterion/pulls/comments/192124452"},"html":{"href":"https://github.com/MysteriumNetwork/mysterion/pull/161#discussion_r192124452"},"pull_request":{"href":"https://api.github.com/repos/MysteriumNetwork/mysterion/pulls/161"}},"in_reply_to_id":192099446},"pull_request":{"url":"https://api.github.com/repos/MysteriumNetwork/mysterion/pulls/161","id":188454343,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg4NDU0MzQz","html_url":"https://github.com/MysteriumNetwork/mysterion/pull/161","diff_url":"https://github.com/MysteriumNetwork/mysterion/pull/161.diff","patch_url":"https://github.com/MysteriumNetwork/mysterion/pull/161.patch","issue_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/issues/161","number":161,"state":"open","locked":false,"title":"MYST-508 Mysterion logs","user":{"login":"Waldz","id":2713911,"node_id":"MDQ6VXNlcjI3MTM5MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2713911?v=4","gravatar_id":"","url":"https://api.github.com/users/Waldz","html_url":"https://github.com/Waldz","followers_url":"https://api.github.com/users/Waldz/followers","following_url":"https://api.github.com/users/Waldz/following{/other_user}","gists_url":"https://api.github.com/users/Waldz/gists{/gist_id}","starred_url":"https://api.github.com/users/Waldz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Waldz/subscriptions","organizations_url":"https://api.github.com/users/Waldz/orgs","repos_url":"https://api.github.com/users/Waldz/repos","events_url":"https://api.github.com/users/Waldz/events{/privacy}","received_events_url":"https://api.github.com/users/Waldz/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-16T14:34:12Z","updated_at":"2018-05-31T14:45:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abf21114db95c199d98efb41310c629de6e90197","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/pulls/161/commits","review_comments_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/pulls/161/comments","review_comment_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/issues/161/comments","statuses_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/statuses/11e4cc2b0093334f5726c04a921db03162ae95d3","head":{"label":"MysteriumNetwork:feature/MYST-508-mysterion-logs","ref":"feature/MYST-508-mysterion-logs","sha":"11e4cc2b0093334f5726c04a921db03162ae95d3","user":{"login":"MysteriumNetwork","id":23056638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU2NjM4","avatar_url":"https://avatars3.githubusercontent.com/u/23056638?v=4","gravatar_id":"","url":"https://api.github.com/users/MysteriumNetwork","html_url":"https://github.com/MysteriumNetwork","followers_url":"https://api.github.com/users/MysteriumNetwork/followers","following_url":"https://api.github.com/users/MysteriumNetwork/following{/other_user}","gists_url":"https://api.github.com/users/MysteriumNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/MysteriumNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MysteriumNetwork/subscriptions","organizations_url":"https://api.github.com/users/MysteriumNetwork/orgs","repos_url":"https://api.github.com/users/MysteriumNetwork/repos","events_url":"https://api.github.com/users/MysteriumNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/MysteriumNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":112330860,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIzMzA4NjA=","name":"mysterion","full_name":"MysteriumNetwork/mysterion","owner":{"login":"MysteriumNetwork","id":23056638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU2NjM4","avatar_url":"https://avatars3.githubusercontent.com/u/23056638?v=4","gravatar_id":"","url":"https://api.github.com/users/MysteriumNetwork","html_url":"https://github.com/MysteriumNetwork","followers_url":"https://api.github.com/users/MysteriumNetwork/followers","following_url":"https://api.github.com/users/MysteriumNetwork/following{/other_user}","gists_url":"https://api.github.com/users/MysteriumNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/MysteriumNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MysteriumNetwork/subscriptions","organizations_url":"https://api.github.com/users/MysteriumNetwork/orgs","repos_url":"https://api.github.com/users/MysteriumNetwork/repos","events_url":"https://api.github.com/users/MysteriumNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/MysteriumNetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MysteriumNetwork/mysterion","description":"Mysterion is desktop application to access Mysterion Network - decentralized VPN built on blockchain.","fork":false,"url":"https://api.github.com/repos/MysteriumNetwork/mysterion","forks_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/forks","keys_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/teams","hooks_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/hooks","issue_events_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/issues/events{/number}","events_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/events","assignees_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/assignees{/user}","branches_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/branches{/branch}","tags_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/tags","blobs_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/git/refs{/sha}","trees_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/statuses/{sha}","languages_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/languages","stargazers_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/stargazers","contributors_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/contributors","subscribers_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/subscribers","subscription_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/subscription","commits_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/commits{/sha}","git_commits_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/git/commits{/sha}","comments_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/comments{/number}","issue_comment_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/issues/comments{/number}","contents_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/contents/{+path}","compare_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/merges","archive_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/downloads","issues_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/issues{/number}","pulls_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/pulls{/number}","milestones_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/milestones{/number}","notifications_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/labels{/name}","releases_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/releases{/id}","deployments_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/deployments","created_at":"2017-11-28T12:12:23Z","updated_at":"2018-05-30T14:10:16Z","pushed_at":"2018-05-31T13:22:17Z","git_url":"git://github.com/MysteriumNetwork/mysterion.git","ssh_url":"git@github.com:MysteriumNetwork/mysterion.git","clone_url":"https://github.com/MysteriumNetwork/mysterion.git","svn_url":"https://github.com/MysteriumNetwork/mysterion","homepage":"https://mysterium.network/","size":9805,"stargazers_count":21,"watchers_count":21,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":5,"watchers":21,"default_branch":"master"}},"base":{"label":"MysteriumNetwork:0.0.2","ref":"0.0.2","sha":"6b31c5e229575e89f515b9f093beb8bf301a4fd2","user":{"login":"MysteriumNetwork","id":23056638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU2NjM4","avatar_url":"https://avatars3.githubusercontent.com/u/23056638?v=4","gravatar_id":"","url":"https://api.github.com/users/MysteriumNetwork","html_url":"https://github.com/MysteriumNetwork","followers_url":"https://api.github.com/users/MysteriumNetwork/followers","following_url":"https://api.github.com/users/MysteriumNetwork/following{/other_user}","gists_url":"https://api.github.com/users/MysteriumNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/MysteriumNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MysteriumNetwork/subscriptions","organizations_url":"https://api.github.com/users/MysteriumNetwork/orgs","repos_url":"https://api.github.com/users/MysteriumNetwork/repos","events_url":"https://api.github.com/users/MysteriumNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/MysteriumNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":112330860,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIzMzA4NjA=","name":"mysterion","full_name":"MysteriumNetwork/mysterion","owner":{"login":"MysteriumNetwork","id":23056638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMDU2NjM4","avatar_url":"https://avatars3.githubusercontent.com/u/23056638?v=4","gravatar_id":"","url":"https://api.github.com/users/MysteriumNetwork","html_url":"https://github.com/MysteriumNetwork","followers_url":"https://api.github.com/users/MysteriumNetwork/followers","following_url":"https://api.github.com/users/MysteriumNetwork/following{/other_user}","gists_url":"https://api.github.com/users/MysteriumNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/MysteriumNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MysteriumNetwork/subscriptions","organizations_url":"https://api.github.com/users/MysteriumNetwork/orgs","repos_url":"https://api.github.com/users/MysteriumNetwork/repos","events_url":"https://api.github.com/users/MysteriumNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/MysteriumNetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MysteriumNetwork/mysterion","description":"Mysterion is desktop application to access Mysterion Network - decentralized VPN built on blockchain.","fork":false,"url":"https://api.github.com/repos/MysteriumNetwork/mysterion","forks_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/forks","keys_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/teams","hooks_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/hooks","issue_events_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/issues/events{/number}","events_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/events","assignees_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/assignees{/user}","branches_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/branches{/branch}","tags_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/tags","blobs_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/git/refs{/sha}","trees_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/statuses/{sha}","languages_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/languages","stargazers_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/stargazers","contributors_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/contributors","subscribers_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/subscribers","subscription_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/subscription","commits_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/commits{/sha}","git_commits_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/git/commits{/sha}","comments_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/comments{/number}","issue_comment_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/issues/comments{/number}","contents_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/contents/{+path}","compare_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/merges","archive_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/downloads","issues_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/issues{/number}","pulls_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/pulls{/number}","milestones_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/milestones{/number}","notifications_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/labels{/name}","releases_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/releases{/id}","deployments_url":"https://api.github.com/repos/MysteriumNetwork/mysterion/deployments","created_at":"2017-11-28T12:12:23Z","updated_at":"2018-05-30T14:10:16Z","pushed_at":"2018-05-31T13:22:17Z","git_url":"git://github.com/MysteriumNetwork/mysterion.git","ssh_url":"git@github.com:MysteriumNetwork/mysterion.git","clone_url":"https://github.com/MysteriumNetwork/mysterion.git","svn_url":"https://github.com/MysteriumNetwork/mysterion","homepage":"https://mysterium.network/","size":9805,"stargazers_count":21,"watchers_count":21,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":5,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MysteriumNetwork/mysterion/pulls/161"},"html":{"href":"https://github.com/MysteriumNetwork/mysterion/pull/161"},"issue":{"href":"https://api.github.com/repos/MysteriumNetwork/mysterion/issues/161"},"comments":{"href":"https://api.github.com/repos/MysteriumNetwork/mysterion/issues/161/comments"},"review_comments":{"href":"https://api.github.com/repos/MysteriumNetwork/mysterion/pulls/161/comments"},"review_comment":{"href":"https://api.github.com/repos/MysteriumNetwork/mysterion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MysteriumNetwork/mysterion/pulls/161/commits"},"statuses":{"href":"https://api.github.com/repos/MysteriumNetwork/mysterion/statuses/11e4cc2b0093334f5726c04a921db03162ae95d3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Waldz"}}