{"action":"created","issue":{"url":"https://api.github.com/repos/jwplayer/jwplayer/issues/3082","repository_url":"https://api.github.com/repos/jwplayer/jwplayer","labels_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/3082/labels{/name}","comments_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/3082/comments","events_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/3082/events","html_url":"https://github.com/jwplayer/jwplayer/pull/3082","id":364204804,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NDQ5Mzg0","number":3082,"title":"Treat media errors during preload as warnings","user":{"login":"johnBartos","id":5042276,"node_id":"MDQ6VXNlcjUwNDIyNzY=","avatar_url":"https://avatars1.githubusercontent.com/u/5042276?v=4","gravatar_id":"","url":"https://api.github.com/users/johnBartos","html_url":"https://github.com/johnBartos","followers_url":"https://api.github.com/users/johnBartos/followers","following_url":"https://api.github.com/users/johnBartos/following{/other_user}","gists_url":"https://api.github.com/users/johnBartos/gists{/gist_id}","starred_url":"https://api.github.com/users/johnBartos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnBartos/subscriptions","organizations_url":"https://api.github.com/users/johnBartos/orgs","repos_url":"https://api.github.com/users/johnBartos/repos","events_url":"https://api.github.com/users/johnBartos/events{/privacy}","received_events_url":"https://api.github.com/users/johnBartos/received_events","type":"User","site_admin":false},"labels":[{"id":89434458,"node_id":"MDU6TGFiZWw4OTQzNDQ1OA==","url":"https://api.github.com/repos/jwplayer/jwplayer/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/jwplayer/jwplayer/milestones/101","html_url":"https://github.com/jwplayer/jwplayer/milestone/101","labels_url":"https://api.github.com/repos/jwplayer/jwplayer/milestones/101/labels","id":3562667,"node_id":"MDk6TWlsZXN0b25lMzU2MjY2Nw==","number":101,"title":"v8.6.0","description":"","creator":{"login":"robwalch","id":333258,"node_id":"MDQ6VXNlcjMzMzI1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/333258?v=4","gravatar_id":"","url":"https://api.github.com/users/robwalch","html_url":"https://github.com/robwalch","followers_url":"https://api.github.com/users/robwalch/followers","following_url":"https://api.github.com/users/robwalch/following{/other_user}","gists_url":"https://api.github.com/users/robwalch/gists{/gist_id}","starred_url":"https://api.github.com/users/robwalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robwalch/subscriptions","organizations_url":"https://api.github.com/users/robwalch/orgs","repos_url":"https://api.github.com/users/robwalch/repos","events_url":"https://api.github.com/users/robwalch/events{/privacy}","received_events_url":"https://api.github.com/users/robwalch/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":26,"state":"open","created_at":"2018-08-11T18:49:57Z","updated_at":"2018-10-01T21:30:33Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2018-09-26T20:46:00Z","updated_at":"2018-10-01T21:35:10Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/3082","html_url":"https://github.com/jwplayer/jwplayer/pull/3082","diff_url":"https://github.com/jwplayer/jwplayer/pull/3082.diff","patch_url":"https://github.com/jwplayer/jwplayer/pull/3082.patch"},"body":"### This PR will...\r\n- Re-emit MEDIA_ERROR as a warning on preload (i.e. when mediaModel `setup`is false)\r\n- Reset video src on HTML5 provider error \r\n\r\n### Why is this Pull Request needed?\r\nSo that players which encountered an error preloading 1) don't show an error screen until interacted with and 2) are given a chance to retry.\r\n\r\n### Are there any points in the code the reviewer needs to double check?\r\nShould the preload check (`mediaModel.get('setup')`) be changed to `mediaModel.get('preload') && mediaModel.get('setup')`? It seems that`setup` is  a good proxy because it's false before preload and true after.\r\n \r\n### Are there any Pull Requests open in other repos which need to be merged with this?\r\nhttps://github.com/jwplayer/jwplayer-commercial/pull/5759\r\n\r\n#### Addresses Issue(s):\r\n\r\nJW8-1816\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/jwplayer/jwplayer/issues/comments/426071217","html_url":"https://github.com/jwplayer/jwplayer/pull/3082#issuecomment-426071217","issue_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/3082","id":426071217,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjA3MTIxNw==","user":{"login":"johnBartos","id":5042276,"node_id":"MDQ6VXNlcjUwNDIyNzY=","avatar_url":"https://avatars1.githubusercontent.com/u/5042276?v=4","gravatar_id":"","url":"https://api.github.com/users/johnBartos","html_url":"https://github.com/johnBartos","followers_url":"https://api.github.com/users/johnBartos/followers","following_url":"https://api.github.com/users/johnBartos/following{/other_user}","gists_url":"https://api.github.com/users/johnBartos/gists{/gist_id}","starred_url":"https://api.github.com/users/johnBartos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnBartos/subscriptions","organizations_url":"https://api.github.com/users/johnBartos/orgs","repos_url":"https://api.github.com/users/johnBartos/repos","events_url":"https://api.github.com/users/johnBartos/events{/privacy}","received_events_url":"https://api.github.com/users/johnBartos/received_events","type":"User","site_admin":false},"created_at":"2018-10-01T21:35:10Z","updated_at":"2018-10-01T21:35:10Z","author_association":"MEMBER","body":"test this please "}}
{"actor":{"display_login":"johnBartos"}}