{"action":"created","issue":{"url":"https://api.github.com/repos/sudomesh/sudowrt-firmware/issues/136","repository_url":"https://api.github.com/repos/sudomesh/sudowrt-firmware","labels_url":"https://api.github.com/repos/sudomesh/sudowrt-firmware/issues/136/labels{/name}","comments_url":"https://api.github.com/repos/sudomesh/sudowrt-firmware/issues/136/comments","events_url":"https://api.github.com/repos/sudomesh/sudowrt-firmware/issues/136/events","html_url":"https://github.com/sudomesh/sudowrt-firmware/issues/136","id":324095223,"node_id":"MDU6SXNzdWUzMjQwOTUyMjM=","number":136,"title":"automatically name build using git commit (or other version controlled identifier)","user":{"login":"paidforby","id":20746091,"node_id":"MDQ6VXNlcjIwNzQ2MDkx","avatar_url":"https://avatars1.githubusercontent.com/u/20746091?v=4","gravatar_id":"","url":"https://api.github.com/users/paidforby","html_url":"https://github.com/paidforby","followers_url":"https://api.github.com/users/paidforby/followers","following_url":"https://api.github.com/users/paidforby/following{/other_user}","gists_url":"https://api.github.com/users/paidforby/gists{/gist_id}","starred_url":"https://api.github.com/users/paidforby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paidforby/subscriptions","organizations_url":"https://api.github.com/users/paidforby/orgs","repos_url":"https://api.github.com/users/paidforby/repos","events_url":"https://api.github.com/users/paidforby/events{/privacy}","received_events_url":"https://api.github.com/users/paidforby/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-17T16:22:19Z","updated_at":"2018-10-24T19:53:55Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Hey, so it gets really confusing when @paidforby links to a version of the firmware and it has the exact same name as the last build and you end up with `openwrt-ar71xx-generic-mynet-n600-squashfs-factory(12).bin` as your file name because you never deleted the previous builds, so now you have no idea if you are flashing your node with the correct binary. Someone should fix this. Hint: probably can be done somewhere in the openwrt build config, https://github.com/sudomesh/sudowrt-firmware/blob/master/build_lib#L182. However, the hacky (read:easier) way is to fiddle with [entrypoint.sh](https://github.com/sudomesh/sudowrt-firmware/blob/master/entrypoint.sh) and rename the binaries while copying them out of the docker container.\r\n\r\nRelated minor issue, the banner could also include the git commit? next to the version number, https://github.com/sudomesh/sudowrt-firmware/blob/master/files/etc/banner"},"comment":{"url":"https://api.github.com/repos/sudomesh/sudowrt-firmware/issues/comments/432804900","html_url":"https://github.com/sudomesh/sudowrt-firmware/issues/136#issuecomment-432804900","issue_url":"https://api.github.com/repos/sudomesh/sudowrt-firmware/issues/136","id":432804900,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjgwNDkwMA==","user":{"login":"paidforby","id":20746091,"node_id":"MDQ6VXNlcjIwNzQ2MDkx","avatar_url":"https://avatars1.githubusercontent.com/u/20746091?v=4","gravatar_id":"","url":"https://api.github.com/users/paidforby","html_url":"https://github.com/paidforby","followers_url":"https://api.github.com/users/paidforby/followers","following_url":"https://api.github.com/users/paidforby/following{/other_user}","gists_url":"https://api.github.com/users/paidforby/gists{/gist_id}","starred_url":"https://api.github.com/users/paidforby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paidforby/subscriptions","organizations_url":"https://api.github.com/users/paidforby/orgs","repos_url":"https://api.github.com/users/paidforby/repos","events_url":"https://api.github.com/users/paidforby/events{/privacy}","received_events_url":"https://api.github.com/users/paidforby/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T19:53:55Z","updated_at":"2018-10-24T19:53:55Z","author_association":"CONTRIBUTOR","body":"After a lot of trial and error, I made some progress on this with 538deee6dac1a2cc3f64ca6fbd9b06b32477f49b now travis is adding the commit hash to the binary file names before pushing them to a dated directory on http://builds.sudomesh.org/sudowrt-firmware/latest/. One thing to figure out it to figure out how to manage the deletion of old binaries, so the server doesn't become overloaded with nightly images."}}
{"actor":{"display_login":"paidforby"}}