{"action":"created","issue":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/10465","repository_url":"https://api.github.com/repos/MarlinFirmware/Marlin","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/10465/labels{/name}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/10465/comments","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/10465/events","html_url":"https://github.com/MarlinFirmware/Marlin/pull/10465","id":316363032,"number":10465,"title":"[1.1.x] Add new capability to report if Thermal Protection is enabled","user":{"login":"andrivet","id":981049,"avatar_url":"https://avatars0.githubusercontent.com/u/981049?v=4","gravatar_id":"","url":"https://api.github.com/users/andrivet","html_url":"https://github.com/andrivet","followers_url":"https://api.github.com/users/andrivet/followers","following_url":"https://api.github.com/users/andrivet/following{/other_user}","gists_url":"https://api.github.com/users/andrivet/gists{/gist_id}","starred_url":"https://api.github.com/users/andrivet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrivet/subscriptions","organizations_url":"https://api.github.com/users/andrivet/orgs","repos_url":"https://api.github.com/users/andrivet/repos","events_url":"https://api.github.com/users/andrivet/events{/privacy}","received_events_url":"https://api.github.com/users/andrivet/received_events","type":"User","site_admin":false},"labels":[{"id":870682925,"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/C:%20Safety","name":"C: Safety","color":"006b75","default":false},{"id":574769697,"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/T:%20Suggestion","name":"T: Suggestion","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-04-20T18:11:54Z","updated_at":"2018-04-20T21:41:29Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/10465","html_url":"https://github.com/MarlinFirmware/Marlin/pull/10465","diff_url":"https://github.com/MarlinFirmware/Marlin/pull/10465.diff","patch_url":"https://github.com/MarlinFirmware/Marlin/pull/10465.patch"},"body":"### Description\r\n\r\nThis code add a new capability to report if Thermal Protection is enabled (value 1) or not (value 0). Capabilities are reported by the M115 command. Thermal Protection is a feature of Marlin and is enabled with `THERMAL_PROTECTION_HOTENDS` and `THERMAL_PROTECTION_BED` macros.\r\n\r\nThe idea behind this new capability is to increase the awareness of users regarding Thermal Protection and the danger to disable it. Thanks to this new capability, software such as OctoPrint (more precisely the [Printer Safety Check plugin](http://docs.octoprint.org/en/devel/bundledplugins/printer_safety_check.html)) will be able to warn users when Thermal Protection is not enabled in the firmware.\r\n\r\n### Benefits\r\n\r\nIt is a very minor and simple modification and it can increase the awareness of users regarding Thermal Protection and the danger to disable it.\r\n\r\n### Related Issues\r\n\r\n* A PR will be submitted to OctoPrint to detect this new capability and warn users.\r\n* A PR will be submitted to a firmware based on Marlin: [ADVi3++](https://github.com/andrivet/ADVi3pp-Marlin) (I am the author).\r\n"},"comment":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments/383230285","html_url":"https://github.com/MarlinFirmware/Marlin/pull/10465#issuecomment-383230285","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/10465","id":383230285,"user":{"login":"andrivet","id":981049,"avatar_url":"https://avatars0.githubusercontent.com/u/981049?v=4","gravatar_id":"","url":"https://api.github.com/users/andrivet","html_url":"https://github.com/andrivet","followers_url":"https://api.github.com/users/andrivet/followers","following_url":"https://api.github.com/users/andrivet/following{/other_user}","gists_url":"https://api.github.com/users/andrivet/gists{/gist_id}","starred_url":"https://api.github.com/users/andrivet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrivet/subscriptions","organizations_url":"https://api.github.com/users/andrivet/orgs","repos_url":"https://api.github.com/users/andrivet/repos","events_url":"https://api.github.com/users/andrivet/events{/privacy}","received_events_url":"https://api.github.com/users/andrivet/received_events","type":"User","site_admin":false},"created_at":"2018-04-20T21:41:29Z","updated_at":"2018-04-20T21:41:29Z","author_association":"NONE","body":"In my mind \"your point of view\" means the point of view of Marlin Team, the point of view of your role. \r\n\r\nFor your question (\"Should hosts report \"WARNING!...\"), for me the answer is clearly no. The host has to report WARNING only if the capability is 0. Not if the capability is not there."}}
{"actor":{"display_login":"andrivet"}}