{"action":"created","comment":{"url":"https://api.github.com/repos/google/keytransparency/pulls/comments/224776626","pull_request_review_id":164226973,"id":224776626,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDc3NjYyNg==","diff_hunk":"@@ -58,40 +58,40 @@ func (m *Mutations) Send(ctx context.Context, domainID string, update *pb.EntryU\n \t}\n \t// TODO(gbelvin): Implement retry with backoff for retryable errors if\n \t// we get timestamp contention.\n-\treturn m.send(ctx, domainID, shardID, mData, time.Now())\n+\treturn m.send(ctx, domainID, logID, mData, time.Now())\n }\n \n-// randShard returns a random, enabled shard for domainID.\n-func (m *Mutations) randShard(ctx context.Context, domainID string) (int64, error) {\n+// randLog returns a random, enabled log for domainID.\n+func (m *Mutations) randLog(ctx context.Context, domainID string) (int64, error) {\n \t// TODO(gbelvin): Cache these results.\n-\tvar shardIDs []int64\n+\tvar logIDs []int64\n \trows, err := m.db.QueryContext(ctx,\n-\t\t`SELECT ShardID from Shards WHERE DomainID = ? AND Enabled = ?;`,\n+\t\t`SELECT LogID from Logs WHERE DomainID = ? AND Enabled = ?;`,\n \t\tdomainID, true)\n \tif err != nil {\n \t\treturn 0, err\n \t}\n \tdefer rows.Close()\n \tfor rows.Next() {\n-\t\tvar shardID int64\n-\t\tif err := rows.Scan(&shardID); err != nil {\n+\t\tvar logID int64\n+\t\tif err := rows.Scan(&logID); err != nil {\n \t\t\treturn 0, err\n \t\t}\n-\t\tshardIDs = append(shardIDs, shardID)\n+\t\tlogIDs = append(logIDs, logID)\n \t}\n \tif err := rows.Err(); err != nil {\n \t\treturn 0, err\n \t}\n-\tif len(shardIDs) == 0 {\n-\t\treturn 0, status.Errorf(codes.NotFound, \"No shard found for domain %v\", domainID)\n+\tif len(logIDs) == 0 {\n+\t\treturn 0, status.Errorf(codes.NotFound, \"No log found for domain %v\", domainID)","path":"impl/sql/mutationstorage/queue.go","position":71,"original_position":71,"commit_id":"89127fb1a71b60483c2d465e6eba5b69e27588ad","original_commit_id":"89127fb1a71b60483c2d465e6eba5b69e27588ad","user":{"login":"AlCutter","id":7648032,"node_id":"MDQ6VXNlcjc2NDgwMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/7648032?v=4","gravatar_id":"","url":"https://api.github.com/users/AlCutter","html_url":"https://github.com/AlCutter","followers_url":"https://api.github.com/users/AlCutter/followers","following_url":"https://api.github.com/users/AlCutter/following{/other_user}","gists_url":"https://api.github.com/users/AlCutter/gists{/gist_id}","starred_url":"https://api.github.com/users/AlCutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlCutter/subscriptions","organizations_url":"https://api.github.com/users/AlCutter/orgs","repos_url":"https://api.github.com/users/AlCutter/repos","events_url":"https://api.github.com/users/AlCutter/events{/privacy}","received_events_url":"https://api.github.com/users/AlCutter/received_events","type":"User","site_admin":false},"body":"No/no","created_at":"2018-10-12T13:05:51Z","updated_at":"2018-10-12T13:10:46Z","html_url":"https://github.com/google/keytransparency/pull/1064#discussion_r224776626","pull_request_url":"https://api.github.com/repos/google/keytransparency/pulls/1064","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/google/keytransparency/pulls/comments/224776626"},"html":{"href":"https://github.com/google/keytransparency/pull/1064#discussion_r224776626"},"pull_request":{"href":"https://api.github.com/repos/google/keytransparency/pulls/1064"}}},"pull_request":{"url":"https://api.github.com/repos/google/keytransparency/pulls/1064","id":222216167,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjE2MTY3","html_url":"https://github.com/google/keytransparency/pull/1064","diff_url":"https://github.com/google/keytransparency/pull/1064.diff","patch_url":"https://github.com/google/keytransparency/pull/1064.patch","issue_url":"https://api.github.com/repos/google/keytransparency/issues/1064","number":1064,"state":"open","locked":false,"title":"Rename *Queue* with *Logs*","user":{"login":"gdbelvin","id":198478,"node_id":"MDQ6VXNlcjE5ODQ3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/198478?v=4","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"body":"The previous few PRs have been migrating Key Transparency away from a queue based model where things in the queue are deleted after they have been processed, to a log(s) based model, where once things go in the log, they stay there forever.  This change helps increase reliability by creating a journal that can be replayed into the map at any time if things go haywire for any reason. \r\n\r\nThis PR clarifies variables and comments by switching the terminology from Queues and Shards to a group of logs and individual logIDs. ","created_at":"2018-10-11T17:18:52Z","updated_at":"2018-10-12T13:10:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26805a928a3fa323c2557631b03d13923ff8dd79","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/keytransparency/pulls/1064/commits","review_comments_url":"https://api.github.com/repos/google/keytransparency/pulls/1064/comments","review_comment_url":"https://api.github.com/repos/google/keytransparency/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/keytransparency/issues/1064/comments","statuses_url":"https://api.github.com/repos/google/keytransparency/statuses/89127fb1a71b60483c2d465e6eba5b69e27588ad","head":{"label":"gdbelvin:queue_to_log","ref":"queue_to_log","sha":"89127fb1a71b60483c2d465e6eba5b69e27588ad","user":{"login":"gdbelvin","id":198478,"node_id":"MDQ6VXNlcjE5ODQ3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/198478?v=4","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"repo":{"id":79116210,"node_id":"MDEwOlJlcG9zaXRvcnk3OTExNjIxMA==","name":"keytransparency","full_name":"gdbelvin/keytransparency","private":false,"owner":{"login":"gdbelvin","id":198478,"node_id":"MDQ6VXNlcjE5ODQ3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/198478?v=4","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gdbelvin/keytransparency","description":"A transparent and secure way to look up public keys.","fork":true,"url":"https://api.github.com/repos/gdbelvin/keytransparency","forks_url":"https://api.github.com/repos/gdbelvin/keytransparency/forks","keys_url":"https://api.github.com/repos/gdbelvin/keytransparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gdbelvin/keytransparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gdbelvin/keytransparency/teams","hooks_url":"https://api.github.com/repos/gdbelvin/keytransparency/hooks","issue_events_url":"https://api.github.com/repos/gdbelvin/keytransparency/issues/events{/number}","events_url":"https://api.github.com/repos/gdbelvin/keytransparency/events","assignees_url":"https://api.github.com/repos/gdbelvin/keytransparency/assignees{/user}","branches_url":"https://api.github.com/repos/gdbelvin/keytransparency/branches{/branch}","tags_url":"https://api.github.com/repos/gdbelvin/keytransparency/tags","blobs_url":"https://api.github.com/repos/gdbelvin/keytransparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gdbelvin/keytransparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gdbelvin/keytransparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/gdbelvin/keytransparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gdbelvin/keytransparency/statuses/{sha}","languages_url":"https://api.github.com/repos/gdbelvin/keytransparency/languages","stargazers_url":"https://api.github.com/repos/gdbelvin/keytransparency/stargazers","contributors_url":"https://api.github.com/repos/gdbelvin/keytransparency/contributors","subscribers_url":"https://api.github.com/repos/gdbelvin/keytransparency/subscribers","subscription_url":"https://api.github.com/repos/gdbelvin/keytransparency/subscription","commits_url":"https://api.github.com/repos/gdbelvin/keytransparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/gdbelvin/keytransparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/gdbelvin/keytransparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/gdbelvin/keytransparency/issues/comments{/number}","contents_url":"https://api.github.com/repos/gdbelvin/keytransparency/contents/{+path}","compare_url":"https://api.github.com/repos/gdbelvin/keytransparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gdbelvin/keytransparency/merges","archive_url":"https://api.github.com/repos/gdbelvin/keytransparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gdbelvin/keytransparency/downloads","issues_url":"https://api.github.com/repos/gdbelvin/keytransparency/issues{/number}","pulls_url":"https://api.github.com/repos/gdbelvin/keytransparency/pulls{/number}","milestones_url":"https://api.github.com/repos/gdbelvin/keytransparency/milestones{/number}","notifications_url":"https://api.github.com/repos/gdbelvin/keytransparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gdbelvin/keytransparency/labels{/name}","releases_url":"https://api.github.com/repos/gdbelvin/keytransparency/releases{/id}","deployments_url":"https://api.github.com/repos/gdbelvin/keytransparency/deployments","created_at":"2017-01-16T12:28:44Z","updated_at":"2018-10-12T10:12:40Z","pushed_at":"2018-10-12T10:20:31Z","git_url":"git://github.com/gdbelvin/keytransparency.git","ssh_url":"git@github.com:gdbelvin/keytransparency.git","clone_url":"https://github.com/gdbelvin/keytransparency.git","svn_url":"https://github.com/gdbelvin/keytransparency","homepage":"https://security.googleblog.com/2017/01/security-through-transparency.html","size":25159,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"e869a3b44fc9ea7f500dcae6b6e7051dddfd7bb0","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":37165115,"node_id":"MDEwOlJlcG9zaXRvcnkzNzE2NTExNQ==","name":"keytransparency","full_name":"google/keytransparency","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/keytransparency","description":"A transparent and secure way to look up public keys.","fork":false,"url":"https://api.github.com/repos/google/keytransparency","forks_url":"https://api.github.com/repos/google/keytransparency/forks","keys_url":"https://api.github.com/repos/google/keytransparency/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/keytransparency/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/keytransparency/teams","hooks_url":"https://api.github.com/repos/google/keytransparency/hooks","issue_events_url":"https://api.github.com/repos/google/keytransparency/issues/events{/number}","events_url":"https://api.github.com/repos/google/keytransparency/events","assignees_url":"https://api.github.com/repos/google/keytransparency/assignees{/user}","branches_url":"https://api.github.com/repos/google/keytransparency/branches{/branch}","tags_url":"https://api.github.com/repos/google/keytransparency/tags","blobs_url":"https://api.github.com/repos/google/keytransparency/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/keytransparency/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/keytransparency/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/keytransparency/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/keytransparency/statuses/{sha}","languages_url":"https://api.github.com/repos/google/keytransparency/languages","stargazers_url":"https://api.github.com/repos/google/keytransparency/stargazers","contributors_url":"https://api.github.com/repos/google/keytransparency/contributors","subscribers_url":"https://api.github.com/repos/google/keytransparency/subscribers","subscription_url":"https://api.github.com/repos/google/keytransparency/subscription","commits_url":"https://api.github.com/repos/google/keytransparency/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/keytransparency/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/keytransparency/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/keytransparency/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/keytransparency/contents/{+path}","compare_url":"https://api.github.com/repos/google/keytransparency/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/keytransparency/merges","archive_url":"https://api.github.com/repos/google/keytransparency/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/keytransparency/downloads","issues_url":"https://api.github.com/repos/google/keytransparency/issues{/number}","pulls_url":"https://api.github.com/repos/google/keytransparency/pulls{/number}","milestones_url":"https://api.github.com/repos/google/keytransparency/milestones{/number}","notifications_url":"https://api.github.com/repos/google/keytransparency/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/keytransparency/labels{/name}","releases_url":"https://api.github.com/repos/google/keytransparency/releases{/id}","deployments_url":"https://api.github.com/repos/google/keytransparency/deployments","created_at":"2015-06-09T23:55:20Z","updated_at":"2018-10-12T05:32:48Z","pushed_at":"2018-10-12T10:29:52Z","git_url":"git://github.com/google/keytransparency.git","ssh_url":"git@github.com:google/keytransparency.git","clone_url":"https://github.com/google/keytransparency.git","svn_url":"https://github.com/google/keytransparency","homepage":"https://security.googleblog.com/2017/01/security-through-transparency.html","size":23594,"stargazers_count":1320,"watchers_count":1320,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":107,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":107,"open_issues":55,"watchers":1320,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/keytransparency/pulls/1064"},"html":{"href":"https://github.com/google/keytransparency/pull/1064"},"issue":{"href":"https://api.github.com/repos/google/keytransparency/issues/1064"},"comments":{"href":"https://api.github.com/repos/google/keytransparency/issues/1064/comments"},"review_comments":{"href":"https://api.github.com/repos/google/keytransparency/pulls/1064/comments"},"review_comment":{"href":"https://api.github.com/repos/google/keytransparency/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/keytransparency/pulls/1064/commits"},"statuses":{"href":"https://api.github.com/repos/google/keytransparency/statuses/89127fb1a71b60483c2d465e6eba5b69e27588ad"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"AlCutter"}}