{"action":"created","issue":{"url":"https://api.github.com/repos/jetstack/cert-manager/issues/520","repository_url":"https://api.github.com/repos/jetstack/cert-manager","labels_url":"https://api.github.com/repos/jetstack/cert-manager/issues/520/labels{/name}","comments_url":"https://api.github.com/repos/jetstack/cert-manager/issues/520/comments","events_url":"https://api.github.com/repos/jetstack/cert-manager/issues/520/events","html_url":"https://github.com/jetstack/cert-manager/pull/520","id":318600152,"number":520,"title":"Configurable issuer duration and renewBefore","user":{"login":"vdesjardins","id":67089,"avatar_url":"https://avatars1.githubusercontent.com/u/67089?v=4","gravatar_id":"","url":"https://api.github.com/users/vdesjardins","html_url":"https://github.com/vdesjardins","followers_url":"https://api.github.com/users/vdesjardins/followers","following_url":"https://api.github.com/users/vdesjardins/following{/other_user}","gists_url":"https://api.github.com/users/vdesjardins/gists{/gist_id}","starred_url":"https://api.github.com/users/vdesjardins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdesjardins/subscriptions","organizations_url":"https://api.github.com/users/vdesjardins/orgs","repos_url":"https://api.github.com/users/vdesjardins/repos","events_url":"https://api.github.com/users/vdesjardins/events{/privacy}","received_events_url":"https://api.github.com/users/vdesjardins/received_events","type":"User","site_admin":false},"labels":[{"id":727722560,"url":"https://api.github.com/repos/jetstack/cert-manager/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":728244369,"url":"https://api.github.com/repos/jetstack/cert-manager/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/jetstack/cert-manager/milestones/7","html_url":"https://github.com/jetstack/cert-manager/milestone/7","labels_url":"https://api.github.com/repos/jetstack/cert-manager/milestones/7/labels","id":3134108,"number":7,"title":"v0.4","description":"","creator":{"login":"munnerz","id":203583,"avatar_url":"https://avatars3.githubusercontent.com/u/203583?v=4","gravatar_id":"","url":"https://api.github.com/users/munnerz","html_url":"https://github.com/munnerz","followers_url":"https://api.github.com/users/munnerz/followers","following_url":"https://api.github.com/users/munnerz/following{/other_user}","gists_url":"https://api.github.com/users/munnerz/gists{/gist_id}","starred_url":"https://api.github.com/users/munnerz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munnerz/subscriptions","organizations_url":"https://api.github.com/users/munnerz/orgs","repos_url":"https://api.github.com/users/munnerz/repos","events_url":"https://api.github.com/users/munnerz/events{/privacy}","received_events_url":"https://api.github.com/users/munnerz/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":0,"state":"open","created_at":"2018-02-21T18:19:46Z","updated_at":"2018-05-21T09:49:17Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2018-04-28T04:46:35Z","updated_at":"2018-05-24T13:22:35Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/jetstack/cert-manager/pulls/520","html_url":"https://github.com/jetstack/cert-manager/pull/520","diff_url":"https://github.com/jetstack/cert-manager/pull/520.diff","patch_url":"https://github.com/jetstack/cert-manager/pull/520.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nThis pull request makes possible to configure the certificate validity duration and the renewal before duration per issuer. \r\n**Which issue this PR fixes**: \r\n#437 \r\n**Special notes for your reviewer**:\r\nSplit from Vault issuer pull request #292 \r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```\r\nConfigurable certificate duration and renewal duration using fields Issuer.spec.duration and \r\nIssuer.spec.renewBefore respectively.\r\nThe CA Issuer default duration is now 90 days instead of 365 days to make all issuers more consistent when configured without explicit duration.\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/jetstack/cert-manager/issues/comments/391712631","html_url":"https://github.com/jetstack/cert-manager/pull/520#issuecomment-391712631","issue_url":"https://api.github.com/repos/jetstack/cert-manager/issues/520","id":391712631,"user":{"login":"jetstack-bot","id":32282838,"avatar_url":"https://avatars1.githubusercontent.com/u/32282838?v=4","gravatar_id":"","url":"https://api.github.com/users/jetstack-bot","html_url":"https://github.com/jetstack-bot","followers_url":"https://api.github.com/users/jetstack-bot/followers","following_url":"https://api.github.com/users/jetstack-bot/following{/other_user}","gists_url":"https://api.github.com/users/jetstack-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/jetstack-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetstack-bot/subscriptions","organizations_url":"https://api.github.com/users/jetstack-bot/orgs","repos_url":"https://api.github.com/users/jetstack-bot/repos","events_url":"https://api.github.com/users/jetstack-bot/events{/privacy}","received_events_url":"https://api.github.com/users/jetstack-bot/received_events","type":"User","site_admin":false},"created_at":"2018-05-24T13:22:35Z","updated_at":"2018-05-24T13:22:35Z","author_association":"COLLABORATOR","body":"@munnerz: GitHub didn't allow me to request PR reviews from the following users: vdesjardins.\n\nNote that only [jetstack members](https://github.com/orgs/jetstack/people) and repo collaborators can review this PR, and authors cannot review their own PRs.\n\n<details>\n\nIn response to [this](https://github.com/jetstack/cert-manager/pull/520#issuecomment-391712620):\n\n>/cc @vdesjardins \n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>"}}
{"actor":{"display_login":"jetstack-bot"}}