{"action":"created","comment":{"url":"https://api.github.com/repos/ant-design/ant-design/pulls/comments/207029167","pull_request_review_id":142560331,"id":207029167,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzAyOTE2Nw==","diff_hunk":"@@ -22,16 +22,15 @@ While defining the font system for a visual system, we propose to start from the\n In order to implement a good font system, the first thing is to choose an appropriate font family. Ant Design prefers the system default font family and then also provides a set of alternative font libraries to maintain readability for screens on different platforms and browsers and to make sure it's always user friendly, stable and professional to end user.\n \n ```css\n-font-family: -apple-system, BlinkMacSystemFont, \"Segoe UI\", Roboto,\n-             \"Helvetica Neue\", Helvetica, \"PingFang SC\", \"Hiragino Sans GB\", \"Microsoft YaHei\",\n-             SimSun, sans-serif;\n+font-family: \"Chinese Quote\", -apple-system, BlinkMacSystemFont, \"Segoe UI\", \"PingFang SC\", \"Hiragino Sans GB\", \"Microsoft YaHei\", \"Helvetica Neue\", Helvetica, Arial, sans-serif,","path":"docs/spec/font.en-US.md","position":7,"original_position":7,"commit_id":"7b8b41d3add70b0506cbb2d94f486a61215aca0e","original_commit_id":"7b8b41d3add70b0506cbb2d94f486a61215aca0e","user":{"login":"tibdex","id":6574550,"node_id":"MDQ6VXNlcjY1NzQ1NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6574550?v=4","gravatar_id":"","url":"https://api.github.com/users/tibdex","html_url":"https://github.com/tibdex","followers_url":"https://api.github.com/users/tibdex/followers","following_url":"https://api.github.com/users/tibdex/following{/other_user}","gists_url":"https://api.github.com/users/tibdex/gists{/gist_id}","starred_url":"https://api.github.com/users/tibdex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tibdex/subscriptions","organizations_url":"https://api.github.com/users/tibdex/orgs","repos_url":"https://api.github.com/users/tibdex/repos","events_url":"https://api.github.com/users/tibdex/events{/privacy}","received_events_url":"https://api.github.com/users/tibdex/received_events","type":"User","site_admin":false},"body":"I removed `SimSun` here because [it wasn't actually used](https://github.com/ant-design/ant-design/pull/11567/files#diff-4b7c05557620faa918b0919c047d049a).\r\n\r\nI didn't change the `font.zh-CN.md` file, but the PR is configure to \"Allow edits from maintainers.\". Feel free to edit the Chinese page and to tweak the line breaking if you want shorter lines in the docs.","created_at":"2018-08-01T20:57:59Z","updated_at":"2018-08-01T20:58:00Z","html_url":"https://github.com/ant-design/ant-design/pull/11567#discussion_r207029167","pull_request_url":"https://api.github.com/repos/ant-design/ant-design/pulls/11567","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/comments/207029167"},"html":{"href":"https://github.com/ant-design/ant-design/pull/11567#discussion_r207029167"},"pull_request":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/11567"}}},"pull_request":{"url":"https://api.github.com/repos/ant-design/ant-design/pulls/11567","id":205540481,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NTQwNDgx","html_url":"https://github.com/ant-design/ant-design/pull/11567","diff_url":"https://github.com/ant-design/ant-design/pull/11567.diff","patch_url":"https://github.com/ant-design/ant-design/pull/11567.patch","issue_url":"https://api.github.com/repos/ant-design/ant-design/issues/11567","number":11567,"state":"open","locked":false,"title":"Use tabular-nums font variant instead of switching to Tahoma for figures","user":{"login":"tibdex","id":6574550,"node_id":"MDQ6VXNlcjY1NzQ1NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6574550?v=4","gravatar_id":"","url":"https://api.github.com/users/tibdex","html_url":"https://github.com/tibdex","followers_url":"https://api.github.com/users/tibdex/followers","following_url":"https://api.github.com/users/tibdex/following{/other_user}","gists_url":"https://api.github.com/users/tibdex/gists{/gist_id}","starred_url":"https://api.github.com/users/tibdex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tibdex/subscriptions","organizations_url":"https://api.github.com/users/tibdex/orgs","repos_url":"https://api.github.com/users/tibdex/repos","events_url":"https://api.github.com/users/tibdex/events{/privacy}","received_events_url":"https://api.github.com/users/tibdex/received_events","type":"User","site_admin":false},"body":"Using a completely different font for figures leads to inconsistencies: https://github.com/ant-design/ant-design/issues/9422.\r\nMost modern font systems default to [tabular figures](https://www.fonts.com/content/learning/fontology/level-3/numbers/proportional-vs-tabular-figures).\r\nOne exception to this is Apple's San Francisco which defaults to [proportional figures](http://martiancraft.com/blog/2015/10/san-francisco-part-2/#special-features-numerals).\r\nThere is, however, an official and clean way to switch to tabular figures. It's the [`font-variant` CSS property](https://developer.mozilla.org/en-US/docs/Web/CSS/font-variant-numeric) that can be set to `tabular-nums`.\r\n\r\nThis commit removes the \"Monospaced Number\" font altogether and use `font-variant: tabular-nums` instead where it was used.\r\nIt also moves closer to the sans-serif and monospace [system font stacks used by GitHub](http://markdotto.com/2018/02/07/github-system-fonts/).\r\n\r\n---\r\n\r\nHere is the before/after on Windows where Segoe UI is now used for figures too. The difference is subtle but you can see it. Especially for the figure 1.\r\n\r\n#### Before\r\n\r\n![before](https://user-images.githubusercontent.com/6574550/43546662-41b56950-95a7-11e8-9959-7a3821d29757.png)\r\n\r\n#### After\r\n\r\n![after](https://user-images.githubusercontent.com/6574550/43546665-463ad1cc-95a7-11e8-91ca-6f95da907dab.png)\r\n\r\n\r\n","created_at":"2018-08-01T20:16:13Z","updated_at":"2018-08-01T20:58:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef41aeb2b756b47009d012dbc752fdba607c7f70","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ant-design/ant-design/pulls/11567/commits","review_comments_url":"https://api.github.com/repos/ant-design/ant-design/pulls/11567/comments","review_comment_url":"https://api.github.com/repos/ant-design/ant-design/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ant-design/ant-design/issues/11567/comments","statuses_url":"https://api.github.com/repos/ant-design/ant-design/statuses/7b8b41d3add70b0506cbb2d94f486a61215aca0e","head":{"label":"tibdex:feature-3.8.0","ref":"feature-3.8.0","sha":"7b8b41d3add70b0506cbb2d94f486a61215aca0e","user":{"login":"tibdex","id":6574550,"node_id":"MDQ6VXNlcjY1NzQ1NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6574550?v=4","gravatar_id":"","url":"https://api.github.com/users/tibdex","html_url":"https://github.com/tibdex","followers_url":"https://api.github.com/users/tibdex/followers","following_url":"https://api.github.com/users/tibdex/following{/other_user}","gists_url":"https://api.github.com/users/tibdex/gists{/gist_id}","starred_url":"https://api.github.com/users/tibdex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tibdex/subscriptions","organizations_url":"https://api.github.com/users/tibdex/orgs","repos_url":"https://api.github.com/users/tibdex/repos","events_url":"https://api.github.com/users/tibdex/events{/privacy}","received_events_url":"https://api.github.com/users/tibdex/received_events","type":"User","site_admin":false},"repo":{"id":143188500,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMxODg1MDA=","name":"ant-design","full_name":"tibdex/ant-design","owner":{"login":"tibdex","id":6574550,"node_id":"MDQ6VXNlcjY1NzQ1NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6574550?v=4","gravatar_id":"","url":"https://api.github.com/users/tibdex","html_url":"https://github.com/tibdex","followers_url":"https://api.github.com/users/tibdex/followers","following_url":"https://api.github.com/users/tibdex/following{/other_user}","gists_url":"https://api.github.com/users/tibdex/gists{/gist_id}","starred_url":"https://api.github.com/users/tibdex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tibdex/subscriptions","organizations_url":"https://api.github.com/users/tibdex/orgs","repos_url":"https://api.github.com/users/tibdex/repos","events_url":"https://api.github.com/users/tibdex/events{/privacy}","received_events_url":"https://api.github.com/users/tibdex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tibdex/ant-design","description":"🐜 A UI Design Language","fork":true,"url":"https://api.github.com/repos/tibdex/ant-design","forks_url":"https://api.github.com/repos/tibdex/ant-design/forks","keys_url":"https://api.github.com/repos/tibdex/ant-design/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tibdex/ant-design/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tibdex/ant-design/teams","hooks_url":"https://api.github.com/repos/tibdex/ant-design/hooks","issue_events_url":"https://api.github.com/repos/tibdex/ant-design/issues/events{/number}","events_url":"https://api.github.com/repos/tibdex/ant-design/events","assignees_url":"https://api.github.com/repos/tibdex/ant-design/assignees{/user}","branches_url":"https://api.github.com/repos/tibdex/ant-design/branches{/branch}","tags_url":"https://api.github.com/repos/tibdex/ant-design/tags","blobs_url":"https://api.github.com/repos/tibdex/ant-design/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tibdex/ant-design/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tibdex/ant-design/git/refs{/sha}","trees_url":"https://api.github.com/repos/tibdex/ant-design/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tibdex/ant-design/statuses/{sha}","languages_url":"https://api.github.com/repos/tibdex/ant-design/languages","stargazers_url":"https://api.github.com/repos/tibdex/ant-design/stargazers","contributors_url":"https://api.github.com/repos/tibdex/ant-design/contributors","subscribers_url":"https://api.github.com/repos/tibdex/ant-design/subscribers","subscription_url":"https://api.github.com/repos/tibdex/ant-design/subscription","commits_url":"https://api.github.com/repos/tibdex/ant-design/commits{/sha}","git_commits_url":"https://api.github.com/repos/tibdex/ant-design/git/commits{/sha}","comments_url":"https://api.github.com/repos/tibdex/ant-design/comments{/number}","issue_comment_url":"https://api.github.com/repos/tibdex/ant-design/issues/comments{/number}","contents_url":"https://api.github.com/repos/tibdex/ant-design/contents/{+path}","compare_url":"https://api.github.com/repos/tibdex/ant-design/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tibdex/ant-design/merges","archive_url":"https://api.github.com/repos/tibdex/ant-design/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tibdex/ant-design/downloads","issues_url":"https://api.github.com/repos/tibdex/ant-design/issues{/number}","pulls_url":"https://api.github.com/repos/tibdex/ant-design/pulls{/number}","milestones_url":"https://api.github.com/repos/tibdex/ant-design/milestones{/number}","notifications_url":"https://api.github.com/repos/tibdex/ant-design/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tibdex/ant-design/labels{/name}","releases_url":"https://api.github.com/repos/tibdex/ant-design/releases{/id}","deployments_url":"https://api.github.com/repos/tibdex/ant-design/deployments","created_at":"2018-08-01T17:37:39Z","updated_at":"2018-08-01T20:14:16Z","pushed_at":"2018-08-01T20:14:15Z","git_url":"git://github.com/tibdex/ant-design.git","ssh_url":"git@github.com:tibdex/ant-design.git","clone_url":"https://github.com/tibdex/ant-design.git","svn_url":"https://github.com/tibdex/ant-design","homepage":"http://ant.design","size":261340,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ant-design:feature-3.8.0","ref":"feature-3.8.0","sha":"2f81349c21d6acaf529a1c8dff77fba1f2fb7139","user":{"login":"ant-design","id":12101536,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAxNTM2","avatar_url":"https://avatars3.githubusercontent.com/u/12101536?v=4","gravatar_id":"","url":"https://api.github.com/users/ant-design","html_url":"https://github.com/ant-design","followers_url":"https://api.github.com/users/ant-design/followers","following_url":"https://api.github.com/users/ant-design/following{/other_user}","gists_url":"https://api.github.com/users/ant-design/gists{/gist_id}","starred_url":"https://api.github.com/users/ant-design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ant-design/subscriptions","organizations_url":"https://api.github.com/users/ant-design/orgs","repos_url":"https://api.github.com/users/ant-design/repos","events_url":"https://api.github.com/users/ant-design/events{/privacy}","received_events_url":"https://api.github.com/users/ant-design/received_events","type":"Organization","site_admin":false},"repo":{"id":34526884,"node_id":"MDEwOlJlcG9zaXRvcnkzNDUyNjg4NA==","name":"ant-design","full_name":"ant-design/ant-design","owner":{"login":"ant-design","id":12101536,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAxNTM2","avatar_url":"https://avatars3.githubusercontent.com/u/12101536?v=4","gravatar_id":"","url":"https://api.github.com/users/ant-design","html_url":"https://github.com/ant-design","followers_url":"https://api.github.com/users/ant-design/followers","following_url":"https://api.github.com/users/ant-design/following{/other_user}","gists_url":"https://api.github.com/users/ant-design/gists{/gist_id}","starred_url":"https://api.github.com/users/ant-design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ant-design/subscriptions","organizations_url":"https://api.github.com/users/ant-design/orgs","repos_url":"https://api.github.com/users/ant-design/repos","events_url":"https://api.github.com/users/ant-design/events{/privacy}","received_events_url":"https://api.github.com/users/ant-design/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ant-design/ant-design","description":"🐜 A UI Design Language","fork":false,"url":"https://api.github.com/repos/ant-design/ant-design","forks_url":"https://api.github.com/repos/ant-design/ant-design/forks","keys_url":"https://api.github.com/repos/ant-design/ant-design/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ant-design/ant-design/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ant-design/ant-design/teams","hooks_url":"https://api.github.com/repos/ant-design/ant-design/hooks","issue_events_url":"https://api.github.com/repos/ant-design/ant-design/issues/events{/number}","events_url":"https://api.github.com/repos/ant-design/ant-design/events","assignees_url":"https://api.github.com/repos/ant-design/ant-design/assignees{/user}","branches_url":"https://api.github.com/repos/ant-design/ant-design/branches{/branch}","tags_url":"https://api.github.com/repos/ant-design/ant-design/tags","blobs_url":"https://api.github.com/repos/ant-design/ant-design/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ant-design/ant-design/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ant-design/ant-design/git/refs{/sha}","trees_url":"https://api.github.com/repos/ant-design/ant-design/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ant-design/ant-design/statuses/{sha}","languages_url":"https://api.github.com/repos/ant-design/ant-design/languages","stargazers_url":"https://api.github.com/repos/ant-design/ant-design/stargazers","contributors_url":"https://api.github.com/repos/ant-design/ant-design/contributors","subscribers_url":"https://api.github.com/repos/ant-design/ant-design/subscribers","subscription_url":"https://api.github.com/repos/ant-design/ant-design/subscription","commits_url":"https://api.github.com/repos/ant-design/ant-design/commits{/sha}","git_commits_url":"https://api.github.com/repos/ant-design/ant-design/git/commits{/sha}","comments_url":"https://api.github.com/repos/ant-design/ant-design/comments{/number}","issue_comment_url":"https://api.github.com/repos/ant-design/ant-design/issues/comments{/number}","contents_url":"https://api.github.com/repos/ant-design/ant-design/contents/{+path}","compare_url":"https://api.github.com/repos/ant-design/ant-design/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ant-design/ant-design/merges","archive_url":"https://api.github.com/repos/ant-design/ant-design/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ant-design/ant-design/downloads","issues_url":"https://api.github.com/repos/ant-design/ant-design/issues{/number}","pulls_url":"https://api.github.com/repos/ant-design/ant-design/pulls{/number}","milestones_url":"https://api.github.com/repos/ant-design/ant-design/milestones{/number}","notifications_url":"https://api.github.com/repos/ant-design/ant-design/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ant-design/ant-design/labels{/name}","releases_url":"https://api.github.com/repos/ant-design/ant-design/releases{/id}","deployments_url":"https://api.github.com/repos/ant-design/ant-design/deployments","created_at":"2015-04-24T15:37:24Z","updated_at":"2018-08-01T19:26:10Z","pushed_at":"2018-08-01T20:23:32Z","git_url":"git://github.com/ant-design/ant-design.git","ssh_url":"git@github.com:ant-design/ant-design.git","clone_url":"https://github.com/ant-design/ant-design.git","svn_url":"https://github.com/ant-design/ant-design","homepage":"http://ant.design","size":261342,"stargazers_count":31584,"watchers_count":31584,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9990,"mirror_url":null,"archived":false,"open_issues_count":271,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9990,"open_issues":271,"watchers":31584,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/11567"},"html":{"href":"https://github.com/ant-design/ant-design/pull/11567"},"issue":{"href":"https://api.github.com/repos/ant-design/ant-design/issues/11567"},"comments":{"href":"https://api.github.com/repos/ant-design/ant-design/issues/11567/comments"},"review_comments":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/11567/comments"},"review_comment":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/11567/commits"},"statuses":{"href":"https://api.github.com/repos/ant-design/ant-design/statuses/7b8b41d3add70b0506cbb2d94f486a61215aca0e"}},"author_association":"NONE"}}
{"actor":{"display_login":"tibdex"}}