{"action":"created","comment":{"url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/comments/209747062","pull_request_review_id":145821468,"id":209747062,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTc0NzA2Mg==","diff_hunk":"@@ -64,4 +64,14 @@ contract('Pausable', function () {\n     const drasticMeasureTaken = await this.Pausable.drasticMeasureTaken();\n     drasticMeasureTaken.should.be.false;\n   });\n+\n+  it('should log Pause and Unpause events appropriately', async function () {\n+    const setPauseLogs = (await this.Pausable.pause()).logs;\n+    if(setPauseLogs.find(e => e.event === 'Pause') == undefined)\n+      assert();","path":"test/lifecycle/Pausable.test.js","position":null,"original_position":8,"commit_id":"46c3fa57c9e7b5a956c7ec841291576fc34c0e1a","original_commit_id":"eeb62279d22c34628c16f98f893f873a50f71f7b","user":{"login":"elopio","id":617831,"node_id":"MDQ6VXNlcjYxNzgzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/617831?v=4","gravatar_id":"","url":"https://api.github.com/users/elopio","html_url":"https://github.com/elopio","followers_url":"https://api.github.com/users/elopio/followers","following_url":"https://api.github.com/users/elopio/following{/other_user}","gists_url":"https://api.github.com/users/elopio/gists{/gist_id}","starred_url":"https://api.github.com/users/elopio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elopio/subscriptions","organizations_url":"https://api.github.com/users/elopio/orgs","repos_url":"https://api.github.com/users/elopio/repos","events_url":"https://api.github.com/users/elopio/events{/privacy}","received_events_url":"https://api.github.com/users/elopio/received_events","type":"User","site_admin":false},"body":"we have tests/helpers/expectEvent.js. It uses assert.exists, which seems better. Here you should use expectEvent. I'll check if this is affecting any of the other tests.","created_at":"2018-08-13T20:26:48Z","updated_at":"2018-08-13T20:26:48Z","html_url":"https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1207#discussion_r209747062","pull_request_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/1207","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/comments/209747062"},"html":{"href":"https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1207#discussion_r209747062"},"pull_request":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/1207"}},"in_reply_to_id":209731951},"pull_request":{"url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/1207","id":208010324,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MDEwMzI0","html_url":"https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1207","diff_url":"https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1207.diff","patch_url":"https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1207.patch","issue_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/issues/1207","number":1207,"state":"open","locked":false,"title":"Added Events tests of Pausable contract","user":{"login":"viquezclaudio","id":31874948,"node_id":"MDQ6VXNlcjMxODc0OTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/31874948?v=4","gravatar_id":"","url":"https://api.github.com/users/viquezclaudio","html_url":"https://github.com/viquezclaudio","followers_url":"https://api.github.com/users/viquezclaudio/followers","following_url":"https://api.github.com/users/viquezclaudio/following{/other_user}","gists_url":"https://api.github.com/users/viquezclaudio/gists{/gist_id}","starred_url":"https://api.github.com/users/viquezclaudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viquezclaudio/subscriptions","organizations_url":"https://api.github.com/users/viquezclaudio/orgs","repos_url":"https://api.github.com/users/viquezclaudio/repos","events_url":"https://api.github.com/users/viquezclaudio/events{/privacy}","received_events_url":"https://api.github.com/users/viquezclaudio/received_events","type":"User","site_admin":false},"body":"<!-- 0. 🎉 Thank you for submitting a PR! -->\r\n\r\n<!-- 1. **Does this close any open issues?** If so, list them here. If not, remove the `Fixes #` line. -->\r\n\r\nFixes #1180 \r\n\r\n# 🚀 Description\r\n\r\n<!-- 2. Describe the changes introduced in this pull request -->\r\nAdded unittests for the Events within the Pausable contract\r\n\r\n<!--    Include any context necessary for understanding the PR's purpose. -->\r\n\r\n<!-- 3. Before submitting, please review the following checklist: -->\r\n\r\n- [x ] 📘 I've reviewed the [OpenZeppelin Contributor Guidelines](../blob/master/CONTRIBUTING.md)\r\n- [x ] ✅ I've added tests where applicable to test my new functionality.\r\n- [ ] 📖 I've made sure that my contracts are well-documented.\r\n- [ ] 🎨 I've run the JS/Solidity linters and fixed any issues (`npm run lint:all:fix`).\r\n","created_at":"2018-08-13T15:11:10Z","updated_at":"2018-08-13T20:26:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b36a83f29e2797346ca2eb5d1dd18863842a4914","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/1207/commits","review_comments_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/1207/comments","review_comment_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/issues/1207/comments","statuses_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/statuses/46c3fa57c9e7b5a956c7ec841291576fc34c0e1a","head":{"label":"viquezclaudio:fix/1180","ref":"fix/1180","sha":"46c3fa57c9e7b5a956c7ec841291576fc34c0e1a","user":{"login":"viquezclaudio","id":31874948,"node_id":"MDQ6VXNlcjMxODc0OTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/31874948?v=4","gravatar_id":"","url":"https://api.github.com/users/viquezclaudio","html_url":"https://github.com/viquezclaudio","followers_url":"https://api.github.com/users/viquezclaudio/followers","following_url":"https://api.github.com/users/viquezclaudio/following{/other_user}","gists_url":"https://api.github.com/users/viquezclaudio/gists{/gist_id}","starred_url":"https://api.github.com/users/viquezclaudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viquezclaudio/subscriptions","organizations_url":"https://api.github.com/users/viquezclaudio/orgs","repos_url":"https://api.github.com/users/viquezclaudio/repos","events_url":"https://api.github.com/users/viquezclaudio/events{/privacy}","received_events_url":"https://api.github.com/users/viquezclaudio/received_events","type":"User","site_admin":false},"repo":{"id":143653754,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM2NTM3NTQ=","name":"openzeppelin-solidity","full_name":"viquezclaudio/openzeppelin-solidity","owner":{"login":"viquezclaudio","id":31874948,"node_id":"MDQ6VXNlcjMxODc0OTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/31874948?v=4","gravatar_id":"","url":"https://api.github.com/users/viquezclaudio","html_url":"https://github.com/viquezclaudio","followers_url":"https://api.github.com/users/viquezclaudio/followers","following_url":"https://api.github.com/users/viquezclaudio/following{/other_user}","gists_url":"https://api.github.com/users/viquezclaudio/gists{/gist_id}","starred_url":"https://api.github.com/users/viquezclaudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viquezclaudio/subscriptions","organizations_url":"https://api.github.com/users/viquezclaudio/orgs","repos_url":"https://api.github.com/users/viquezclaudio/repos","events_url":"https://api.github.com/users/viquezclaudio/events{/privacy}","received_events_url":"https://api.github.com/users/viquezclaudio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/viquezclaudio/openzeppelin-solidity","description":"OpenZeppelin, a framework to build secure smart contracts on Ethereum","fork":true,"url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity","forks_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/forks","keys_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/teams","hooks_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/hooks","issue_events_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/issues/events{/number}","events_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/events","assignees_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/assignees{/user}","branches_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/branches{/branch}","tags_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/tags","blobs_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/languages","stargazers_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/stargazers","contributors_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/contributors","subscribers_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/subscribers","subscription_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/subscription","commits_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/contents/{+path}","compare_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/merges","archive_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/downloads","issues_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/issues{/number}","pulls_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/labels{/name}","releases_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/releases{/id}","deployments_url":"https://api.github.com/repos/viquezclaudio/openzeppelin-solidity/deployments","created_at":"2018-08-05T23:02:51Z","updated_at":"2018-08-13T12:22:10Z","pushed_at":"2018-08-13T19:54:28Z","git_url":"git://github.com/viquezclaudio/openzeppelin-solidity.git","ssh_url":"git@github.com:viquezclaudio/openzeppelin-solidity.git","clone_url":"https://github.com/viquezclaudio/openzeppelin-solidity.git","svn_url":"https://github.com/viquezclaudio/openzeppelin-solidity","homepage":"https://openzeppelin.org","size":2069,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenZeppelin:master","ref":"master","sha":"41e6b2e9923dbc601faff44128a5390161440e38","user":{"login":"OpenZeppelin","id":20820676,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODIwNjc2","avatar_url":"https://avatars3.githubusercontent.com/u/20820676?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenZeppelin","html_url":"https://github.com/OpenZeppelin","followers_url":"https://api.github.com/users/OpenZeppelin/followers","following_url":"https://api.github.com/users/OpenZeppelin/following{/other_user}","gists_url":"https://api.github.com/users/OpenZeppelin/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenZeppelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenZeppelin/subscriptions","organizations_url":"https://api.github.com/users/OpenZeppelin/orgs","repos_url":"https://api.github.com/users/OpenZeppelin/repos","events_url":"https://api.github.com/users/OpenZeppelin/events{/privacy}","received_events_url":"https://api.github.com/users/OpenZeppelin/received_events","type":"Organization","site_admin":false},"repo":{"id":64700934,"node_id":"MDEwOlJlcG9zaXRvcnk2NDcwMDkzNA==","name":"openzeppelin-solidity","full_name":"OpenZeppelin/openzeppelin-solidity","owner":{"login":"OpenZeppelin","id":20820676,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODIwNjc2","avatar_url":"https://avatars3.githubusercontent.com/u/20820676?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenZeppelin","html_url":"https://github.com/OpenZeppelin","followers_url":"https://api.github.com/users/OpenZeppelin/followers","following_url":"https://api.github.com/users/OpenZeppelin/following{/other_user}","gists_url":"https://api.github.com/users/OpenZeppelin/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenZeppelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenZeppelin/subscriptions","organizations_url":"https://api.github.com/users/OpenZeppelin/orgs","repos_url":"https://api.github.com/users/OpenZeppelin/repos","events_url":"https://api.github.com/users/OpenZeppelin/events{/privacy}","received_events_url":"https://api.github.com/users/OpenZeppelin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenZeppelin/openzeppelin-solidity","description":"OpenZeppelin, a framework to build secure smart contracts on Ethereum","fork":false,"url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity","forks_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/forks","keys_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/teams","hooks_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/hooks","issue_events_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/issues/events{/number}","events_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/events","assignees_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/assignees{/user}","branches_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/branches{/branch}","tags_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/tags","blobs_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/languages","stargazers_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/stargazers","contributors_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/contributors","subscribers_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/subscribers","subscription_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/subscription","commits_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/contents/{+path}","compare_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/merges","archive_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/downloads","issues_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/issues{/number}","pulls_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/labels{/name}","releases_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/releases{/id}","deployments_url":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/deployments","created_at":"2016-08-01T20:54:54Z","updated_at":"2018-08-13T19:07:42Z","pushed_at":"2018-08-13T19:54:30Z","git_url":"git://github.com/OpenZeppelin/openzeppelin-solidity.git","ssh_url":"git@github.com:OpenZeppelin/openzeppelin-solidity.git","clone_url":"https://github.com/OpenZeppelin/openzeppelin-solidity.git","svn_url":"https://github.com/OpenZeppelin/openzeppelin-solidity","homepage":"https://openzeppelin.org","size":2069,"stargazers_count":5622,"watchers_count":5622,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1874,"mirror_url":null,"archived":false,"open_issues_count":195,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1874,"open_issues":195,"watchers":5622,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/1207"},"html":{"href":"https://github.com/OpenZeppelin/openzeppelin-solidity/pull/1207"},"issue":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/issues/1207"},"comments":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/issues/1207/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/1207/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/pulls/1207/commits"},"statuses":{"href":"https://api.github.com/repos/OpenZeppelin/openzeppelin-solidity/statuses/46c3fa57c9e7b5a956c7ec841291576fc34c0e1a"}},"author_association":"NONE"}}
{"actor":{"display_login":"elopio"}}