{"action":"opened","number":2421,"pull_request":{"url":"https://api.github.com/repos/openwrt/luci/pulls/2421","id":242140259,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMTQwMjU5","html_url":"https://github.com/openwrt/luci/pull/2421","diff_url":"https://github.com/openwrt/luci/pull/2421.diff","patch_url":"https://github.com/openwrt/luci/pull/2421.patch","issue_url":"https://api.github.com/repos/openwrt/luci/issues/2421","number":2421,"state":"open","locked":false,"title":"SSID escaping [RFC]","user":{"login":"SibrenVasse","id":5833571,"node_id":"MDQ6VXNlcjU4MzM1NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/5833571?v=4","gravatar_id":"","url":"https://api.github.com/users/SibrenVasse","html_url":"https://github.com/SibrenVasse","followers_url":"https://api.github.com/users/SibrenVasse/followers","following_url":"https://api.github.com/users/SibrenVasse/following{/other_user}","gists_url":"https://api.github.com/users/SibrenVasse/gists{/gist_id}","starred_url":"https://api.github.com/users/SibrenVasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SibrenVasse/subscriptions","organizations_url":"https://api.github.com/users/SibrenVasse/orgs","repos_url":"https://api.github.com/users/SibrenVasse/repos","events_url":"https://api.github.com/users/SibrenVasse/events{/privacy}","received_events_url":"https://api.github.com/users/SibrenVasse/received_events","type":"User","site_admin":false},"body":"I have a wireless network with an SSID containing an apostrophe. After escaping the SSID, \"&#39;\" is displayed on multiple locations in the interface. When removing the '%h'.format() calls, the apostrophe is displayed correctly.\r\nIs this the correct fix?\r\n\r\nThere are a few more usages of '%h'.format() not changed by this commit.\r\n\r\nSigned-off-by: Sibren Vasse <github@sibrenvasse.nl>","created_at":"2019-01-03T23:33:13Z","updated_at":"2019-01-03T23:33:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openwrt/luci/pulls/2421/commits","review_comments_url":"https://api.github.com/repos/openwrt/luci/pulls/2421/comments","review_comment_url":"https://api.github.com/repos/openwrt/luci/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openwrt/luci/issues/2421/comments","statuses_url":"https://api.github.com/repos/openwrt/luci/statuses/20d4b518cc412b5b843b8fce07f996a88abb1455","head":{"label":"SibrenVasse:ssid_format","ref":"ssid_format","sha":"20d4b518cc412b5b843b8fce07f996a88abb1455","user":{"login":"SibrenVasse","id":5833571,"node_id":"MDQ6VXNlcjU4MzM1NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/5833571?v=4","gravatar_id":"","url":"https://api.github.com/users/SibrenVasse","html_url":"https://github.com/SibrenVasse","followers_url":"https://api.github.com/users/SibrenVasse/followers","following_url":"https://api.github.com/users/SibrenVasse/following{/other_user}","gists_url":"https://api.github.com/users/SibrenVasse/gists{/gist_id}","starred_url":"https://api.github.com/users/SibrenVasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SibrenVasse/subscriptions","organizations_url":"https://api.github.com/users/SibrenVasse/orgs","repos_url":"https://api.github.com/users/SibrenVasse/repos","events_url":"https://api.github.com/users/SibrenVasse/events{/privacy}","received_events_url":"https://api.github.com/users/SibrenVasse/received_events","type":"User","site_admin":false},"repo":{"id":164027510,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQwMjc1MTA=","name":"luci","full_name":"SibrenVasse/luci","private":false,"owner":{"login":"SibrenVasse","id":5833571,"node_id":"MDQ6VXNlcjU4MzM1NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/5833571?v=4","gravatar_id":"","url":"https://api.github.com/users/SibrenVasse","html_url":"https://github.com/SibrenVasse","followers_url":"https://api.github.com/users/SibrenVasse/followers","following_url":"https://api.github.com/users/SibrenVasse/following{/other_user}","gists_url":"https://api.github.com/users/SibrenVasse/gists{/gist_id}","starred_url":"https://api.github.com/users/SibrenVasse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SibrenVasse/subscriptions","organizations_url":"https://api.github.com/users/SibrenVasse/orgs","repos_url":"https://api.github.com/users/SibrenVasse/repos","events_url":"https://api.github.com/users/SibrenVasse/events{/privacy}","received_events_url":"https://api.github.com/users/SibrenVasse/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SibrenVasse/luci","description":"LuCI - OpenWrt Configuration Interface","fork":true,"url":"https://api.github.com/repos/SibrenVasse/luci","forks_url":"https://api.github.com/repos/SibrenVasse/luci/forks","keys_url":"https://api.github.com/repos/SibrenVasse/luci/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SibrenVasse/luci/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SibrenVasse/luci/teams","hooks_url":"https://api.github.com/repos/SibrenVasse/luci/hooks","issue_events_url":"https://api.github.com/repos/SibrenVasse/luci/issues/events{/number}","events_url":"https://api.github.com/repos/SibrenVasse/luci/events","assignees_url":"https://api.github.com/repos/SibrenVasse/luci/assignees{/user}","branches_url":"https://api.github.com/repos/SibrenVasse/luci/branches{/branch}","tags_url":"https://api.github.com/repos/SibrenVasse/luci/tags","blobs_url":"https://api.github.com/repos/SibrenVasse/luci/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SibrenVasse/luci/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SibrenVasse/luci/git/refs{/sha}","trees_url":"https://api.github.com/repos/SibrenVasse/luci/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SibrenVasse/luci/statuses/{sha}","languages_url":"https://api.github.com/repos/SibrenVasse/luci/languages","stargazers_url":"https://api.github.com/repos/SibrenVasse/luci/stargazers","contributors_url":"https://api.github.com/repos/SibrenVasse/luci/contributors","subscribers_url":"https://api.github.com/repos/SibrenVasse/luci/subscribers","subscription_url":"https://api.github.com/repos/SibrenVasse/luci/subscription","commits_url":"https://api.github.com/repos/SibrenVasse/luci/commits{/sha}","git_commits_url":"https://api.github.com/repos/SibrenVasse/luci/git/commits{/sha}","comments_url":"https://api.github.com/repos/SibrenVasse/luci/comments{/number}","issue_comment_url":"https://api.github.com/repos/SibrenVasse/luci/issues/comments{/number}","contents_url":"https://api.github.com/repos/SibrenVasse/luci/contents/{+path}","compare_url":"https://api.github.com/repos/SibrenVasse/luci/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SibrenVasse/luci/merges","archive_url":"https://api.github.com/repos/SibrenVasse/luci/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SibrenVasse/luci/downloads","issues_url":"https://api.github.com/repos/SibrenVasse/luci/issues{/number}","pulls_url":"https://api.github.com/repos/SibrenVasse/luci/pulls{/number}","milestones_url":"https://api.github.com/repos/SibrenVasse/luci/milestones{/number}","notifications_url":"https://api.github.com/repos/SibrenVasse/luci/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SibrenVasse/luci/labels{/name}","releases_url":"https://api.github.com/repos/SibrenVasse/luci/releases{/id}","deployments_url":"https://api.github.com/repos/SibrenVasse/luci/deployments","created_at":"2019-01-03T22:03:06Z","updated_at":"2019-01-03T22:03:15Z","pushed_at":"2019-01-03T23:14:11Z","git_url":"git://github.com/SibrenVasse/luci.git","ssh_url":"git@github.com:SibrenVasse/luci.git","clone_url":"https://github.com/SibrenVasse/luci.git","svn_url":"https://github.com/SibrenVasse/luci","homepage":null,"size":45921,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openwrt:master","ref":"master","sha":"c7776c8959b1297b03de9eb836edf3a447b0b6fa","user":{"login":"openwrt","id":2528830,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Mjg4MzA=","avatar_url":"https://avatars0.githubusercontent.com/u/2528830?v=4","gravatar_id":"","url":"https://api.github.com/users/openwrt","html_url":"https://github.com/openwrt","followers_url":"https://api.github.com/users/openwrt/followers","following_url":"https://api.github.com/users/openwrt/following{/other_user}","gists_url":"https://api.github.com/users/openwrt/gists{/gist_id}","starred_url":"https://api.github.com/users/openwrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openwrt/subscriptions","organizations_url":"https://api.github.com/users/openwrt/orgs","repos_url":"https://api.github.com/users/openwrt/repos","events_url":"https://api.github.com/users/openwrt/events{/privacy}","received_events_url":"https://api.github.com/users/openwrt/received_events","type":"Organization","site_admin":false},"repo":{"id":24997096,"node_id":"MDEwOlJlcG9zaXRvcnkyNDk5NzA5Ng==","name":"luci","full_name":"openwrt/luci","private":false,"owner":{"login":"openwrt","id":2528830,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Mjg4MzA=","avatar_url":"https://avatars0.githubusercontent.com/u/2528830?v=4","gravatar_id":"","url":"https://api.github.com/users/openwrt","html_url":"https://github.com/openwrt","followers_url":"https://api.github.com/users/openwrt/followers","following_url":"https://api.github.com/users/openwrt/following{/other_user}","gists_url":"https://api.github.com/users/openwrt/gists{/gist_id}","starred_url":"https://api.github.com/users/openwrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openwrt/subscriptions","organizations_url":"https://api.github.com/users/openwrt/orgs","repos_url":"https://api.github.com/users/openwrt/repos","events_url":"https://api.github.com/users/openwrt/events{/privacy}","received_events_url":"https://api.github.com/users/openwrt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openwrt/luci","description":"LuCI - OpenWrt Configuration Interface","fork":false,"url":"https://api.github.com/repos/openwrt/luci","forks_url":"https://api.github.com/repos/openwrt/luci/forks","keys_url":"https://api.github.com/repos/openwrt/luci/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openwrt/luci/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openwrt/luci/teams","hooks_url":"https://api.github.com/repos/openwrt/luci/hooks","issue_events_url":"https://api.github.com/repos/openwrt/luci/issues/events{/number}","events_url":"https://api.github.com/repos/openwrt/luci/events","assignees_url":"https://api.github.com/repos/openwrt/luci/assignees{/user}","branches_url":"https://api.github.com/repos/openwrt/luci/branches{/branch}","tags_url":"https://api.github.com/repos/openwrt/luci/tags","blobs_url":"https://api.github.com/repos/openwrt/luci/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openwrt/luci/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openwrt/luci/git/refs{/sha}","trees_url":"https://api.github.com/repos/openwrt/luci/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openwrt/luci/statuses/{sha}","languages_url":"https://api.github.com/repos/openwrt/luci/languages","stargazers_url":"https://api.github.com/repos/openwrt/luci/stargazers","contributors_url":"https://api.github.com/repos/openwrt/luci/contributors","subscribers_url":"https://api.github.com/repos/openwrt/luci/subscribers","subscription_url":"https://api.github.com/repos/openwrt/luci/subscription","commits_url":"https://api.github.com/repos/openwrt/luci/commits{/sha}","git_commits_url":"https://api.github.com/repos/openwrt/luci/git/commits{/sha}","comments_url":"https://api.github.com/repos/openwrt/luci/comments{/number}","issue_comment_url":"https://api.github.com/repos/openwrt/luci/issues/comments{/number}","contents_url":"https://api.github.com/repos/openwrt/luci/contents/{+path}","compare_url":"https://api.github.com/repos/openwrt/luci/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openwrt/luci/merges","archive_url":"https://api.github.com/repos/openwrt/luci/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openwrt/luci/downloads","issues_url":"https://api.github.com/repos/openwrt/luci/issues{/number}","pulls_url":"https://api.github.com/repos/openwrt/luci/pulls{/number}","milestones_url":"https://api.github.com/repos/openwrt/luci/milestones{/number}","notifications_url":"https://api.github.com/repos/openwrt/luci/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openwrt/luci/labels{/name}","releases_url":"https://api.github.com/repos/openwrt/luci/releases{/id}","deployments_url":"https://api.github.com/repos/openwrt/luci/deployments","created_at":"2014-10-09T16:02:20Z","updated_at":"2019-01-03T09:49:00Z","pushed_at":"2019-01-03T16:53:00Z","git_url":"git://github.com/openwrt/luci.git","ssh_url":"git@github.com:openwrt/luci.git","clone_url":"https://github.com/openwrt/luci.git","svn_url":"https://github.com/openwrt/luci","homepage":null,"size":45925,"stargazers_count":1554,"watchers_count":1554,"language":"Lua","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":866,"mirror_url":null,"archived":false,"open_issues_count":170,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":866,"open_issues":170,"watchers":1554,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openwrt/luci/pulls/2421"},"html":{"href":"https://github.com/openwrt/luci/pull/2421"},"issue":{"href":"https://api.github.com/repos/openwrt/luci/issues/2421"},"comments":{"href":"https://api.github.com/repos/openwrt/luci/issues/2421/comments"},"review_comments":{"href":"https://api.github.com/repos/openwrt/luci/pulls/2421/comments"},"review_comment":{"href":"https://api.github.com/repos/openwrt/luci/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openwrt/luci/pulls/2421/commits"},"statuses":{"href":"https://api.github.com/repos/openwrt/luci/statuses/20d4b518cc412b5b843b8fce07f996a88abb1455"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":3,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"SibrenVasse"}}