{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/comments/197994023","pull_request_review_id":131843800,"id":197994023,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Nzk5NDAyMw==","diff_hunk":"@@ -208,7 +208,8 @@ jvmtiGetAvailableProcessors(jvmtiEnv* env,\n \n \tENSURE_NON_NULL(processor_count_ptr);\n \n-\tcpuCount = j9sysinfo_get_number_CPUs_by_type(J9PORT_CPU_ONLINE);\n+\t/* This implementation should be kept consistent with JVM_ActiveProcessorCount */\n+\tcpuCount = j9sysinfo_get_number_CPUs_by_type(J9PORT_CPU_TARGET);\n \t*processor_count_ptr = ((cpuCount == 0) ? 1 : (jint) cpuCount);","path":"runtime/jvmti/jvmtiTimers.c","position":7,"original_position":7,"commit_id":"b80ef115049eda2d5474adbe416d7328657a3655","original_commit_id":"b80ef115049eda2d5474adbe416d7328657a3655","user":{"login":"DanHeidinga","id":8503711,"node_id":"MDQ6VXNlcjg1MDM3MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8503711?v=4","gravatar_id":"","url":"https://api.github.com/users/DanHeidinga","html_url":"https://github.com/DanHeidinga","followers_url":"https://api.github.com/users/DanHeidinga/followers","following_url":"https://api.github.com/users/DanHeidinga/following{/other_user}","gists_url":"https://api.github.com/users/DanHeidinga/gists{/gist_id}","starred_url":"https://api.github.com/users/DanHeidinga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanHeidinga/subscriptions","organizations_url":"https://api.github.com/users/DanHeidinga/orgs","repos_url":"https://api.github.com/users/DanHeidinga/repos","events_url":"https://api.github.com/users/DanHeidinga/events{/privacy}","received_events_url":"https://api.github.com/users/DanHeidinga/received_events","type":"User","site_admin":false},"body":"To make the two consistent, can you modify the `((cpuCount == 0)` to be `((cpuCount < 1)`","created_at":"2018-06-26T02:08:31Z","updated_at":"2018-06-26T02:08:41Z","html_url":"https://github.com/eclipse/openj9/pull/2255#discussion_r197994023","pull_request_url":"https://api.github.com/repos/eclipse/openj9/pulls/2255","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments/197994023"},"html":{"href":"https://github.com/eclipse/openj9/pull/2255#discussion_r197994023"},"pull_request":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2255"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/2255","id":196806805,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2ODA2ODA1","html_url":"https://github.com/eclipse/openj9/pull/2255","diff_url":"https://github.com/eclipse/openj9/pull/2255.diff","patch_url":"https://github.com/eclipse/openj9/pull/2255.patch","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/2255","number":2255,"state":"open","locked":false,"title":"Change jvmtiGetAvailableProcessors to use J9PORT_CPU_TARGET","user":{"login":"Ali-Ni","id":6136958,"node_id":"MDQ6VXNlcjYxMzY5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6136958?v=4","gravatar_id":"","url":"https://api.github.com/users/Ali-Ni","html_url":"https://github.com/Ali-Ni","followers_url":"https://api.github.com/users/Ali-Ni/followers","following_url":"https://api.github.com/users/Ali-Ni/following{/other_user}","gists_url":"https://api.github.com/users/Ali-Ni/gists{/gist_id}","starred_url":"https://api.github.com/users/Ali-Ni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ali-Ni/subscriptions","organizations_url":"https://api.github.com/users/Ali-Ni/orgs","repos_url":"https://api.github.com/users/Ali-Ni/repos","events_url":"https://api.github.com/users/Ali-Ni/events{/privacy}","received_events_url":"https://api.github.com/users/Ali-Ni/received_events","type":"User","site_admin":false},"body":"This change causes `jvmtiGetAvailableProcessors` to behave identically\r\nto `JVM_ActiveProcessorCount`, also taking into account cgroup limits\r\nwhen appropriate as discussed in #1166.\r\n\r\nSigned-off-by: Mohammad Ali Nikseresht <anikser@ibm.com>","created_at":"2018-06-22T18:03:56Z","updated_at":"2018-06-26T02:08:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a670d38aaea438a5215ca880b366b6c41dfb4f3e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/openj9/pulls/2255/commits","review_comments_url":"https://api.github.com/repos/eclipse/openj9/pulls/2255/comments","review_comment_url":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/2255/comments","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/b80ef115049eda2d5474adbe416d7328657a3655","head":{"label":"Ali-Ni:jvmti-get-available-processors-use-target","ref":"jvmti-get-available-processors-use-target","sha":"b80ef115049eda2d5474adbe416d7328657a3655","user":{"login":"Ali-Ni","id":6136958,"node_id":"MDQ6VXNlcjYxMzY5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6136958?v=4","gravatar_id":"","url":"https://api.github.com/users/Ali-Ni","html_url":"https://github.com/Ali-Ni","followers_url":"https://api.github.com/users/Ali-Ni/followers","following_url":"https://api.github.com/users/Ali-Ni/following{/other_user}","gists_url":"https://api.github.com/users/Ali-Ni/gists{/gist_id}","starred_url":"https://api.github.com/users/Ali-Ni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ali-Ni/subscriptions","organizations_url":"https://api.github.com/users/Ali-Ni/orgs","repos_url":"https://api.github.com/users/Ali-Ni/repos","events_url":"https://api.github.com/users/Ali-Ni/events{/privacy}","received_events_url":"https://api.github.com/users/Ali-Ni/received_events","type":"User","site_admin":false},"repo":{"id":132627401,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI2Mjc0MDE=","name":"openj9","full_name":"Ali-Ni/openj9","owner":{"login":"Ali-Ni","id":6136958,"node_id":"MDQ6VXNlcjYxMzY5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6136958?v=4","gravatar_id":"","url":"https://api.github.com/users/Ali-Ni","html_url":"https://github.com/Ali-Ni","followers_url":"https://api.github.com/users/Ali-Ni/followers","following_url":"https://api.github.com/users/Ali-Ni/following{/other_user}","gists_url":"https://api.github.com/users/Ali-Ni/gists{/gist_id}","starred_url":"https://api.github.com/users/Ali-Ni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ali-Ni/subscriptions","organizations_url":"https://api.github.com/users/Ali-Ni/orgs","repos_url":"https://api.github.com/users/Ali-Ni/repos","events_url":"https://api.github.com/users/Ali-Ni/events{/privacy}","received_events_url":"https://api.github.com/users/Ali-Ni/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ali-Ni/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":true,"url":"https://api.github.com/repos/Ali-Ni/openj9","forks_url":"https://api.github.com/repos/Ali-Ni/openj9/forks","keys_url":"https://api.github.com/repos/Ali-Ni/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ali-Ni/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ali-Ni/openj9/teams","hooks_url":"https://api.github.com/repos/Ali-Ni/openj9/hooks","issue_events_url":"https://api.github.com/repos/Ali-Ni/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/Ali-Ni/openj9/events","assignees_url":"https://api.github.com/repos/Ali-Ni/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/Ali-Ni/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/Ali-Ni/openj9/tags","blobs_url":"https://api.github.com/repos/Ali-Ni/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ali-Ni/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ali-Ni/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ali-Ni/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ali-Ni/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/Ali-Ni/openj9/languages","stargazers_url":"https://api.github.com/repos/Ali-Ni/openj9/stargazers","contributors_url":"https://api.github.com/repos/Ali-Ni/openj9/contributors","subscribers_url":"https://api.github.com/repos/Ali-Ni/openj9/subscribers","subscription_url":"https://api.github.com/repos/Ali-Ni/openj9/subscription","commits_url":"https://api.github.com/repos/Ali-Ni/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ali-Ni/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ali-Ni/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ali-Ni/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ali-Ni/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/Ali-Ni/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ali-Ni/openj9/merges","archive_url":"https://api.github.com/repos/Ali-Ni/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ali-Ni/openj9/downloads","issues_url":"https://api.github.com/repos/Ali-Ni/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/Ali-Ni/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/Ali-Ni/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/Ali-Ni/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ali-Ni/openj9/labels{/name}","releases_url":"https://api.github.com/repos/Ali-Ni/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/Ali-Ni/openj9/deployments","created_at":"2018-05-08T15:17:01Z","updated_at":"2018-06-19T19:53:12Z","pushed_at":"2018-06-25T15:35:06Z","git_url":"git://github.com/Ali-Ni/openj9.git","ssh_url":"git@github.com:Ali-Ni/openj9.git","clone_url":"https://github.com/Ali-Ni/openj9.git","svn_url":"https://github.com/Ali-Ni/openj9","homepage":"","size":31176,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"5a483a7b9aa635cdae1973d17102f85fda57b51f","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":101408117,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE0MDgxMTc=","name":"openj9","full_name":"eclipse/openj9","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":false,"url":"https://api.github.com/repos/eclipse/openj9","forks_url":"https://api.github.com/repos/eclipse/openj9/forks","keys_url":"https://api.github.com/repos/eclipse/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/openj9/teams","hooks_url":"https://api.github.com/repos/eclipse/openj9/hooks","issue_events_url":"https://api.github.com/repos/eclipse/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/openj9/events","assignees_url":"https://api.github.com/repos/eclipse/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/openj9/tags","blobs_url":"https://api.github.com/repos/eclipse/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/openj9/languages","stargazers_url":"https://api.github.com/repos/eclipse/openj9/stargazers","contributors_url":"https://api.github.com/repos/eclipse/openj9/contributors","subscribers_url":"https://api.github.com/repos/eclipse/openj9/subscribers","subscription_url":"https://api.github.com/repos/eclipse/openj9/subscription","commits_url":"https://api.github.com/repos/eclipse/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/openj9/merges","archive_url":"https://api.github.com/repos/eclipse/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/openj9/downloads","issues_url":"https://api.github.com/repos/eclipse/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/openj9/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/openj9/deployments","created_at":"2017-08-25T13:46:07Z","updated_at":"2018-06-26T02:02:19Z","pushed_at":"2018-06-26T02:02:03Z","git_url":"git://github.com/eclipse/openj9.git","ssh_url":"git@github.com:eclipse/openj9.git","clone_url":"https://github.com/eclipse/openj9.git","svn_url":"https://github.com/eclipse/openj9","homepage":"","size":31099,"stargazers_count":1286,"watchers_count":1286,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":262,"mirror_url":null,"archived":false,"open_issues_count":405,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":262,"open_issues":405,"watchers":1286,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2255"},"html":{"href":"https://github.com/eclipse/openj9/pull/2255"},"issue":{"href":"https://api.github.com/repos/eclipse/openj9/issues/2255"},"comments":{"href":"https://api.github.com/repos/eclipse/openj9/issues/2255/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2255/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2255/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/openj9/statuses/b80ef115049eda2d5474adbe416d7328657a3655"}},"author_association":"NONE"}}
{"actor":{"display_login":"DanHeidinga"}}