{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/22413","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22413/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22413/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22413/events","html_url":"https://github.com/cms-sw/cmssw/pull/22413","id":301692922,"number":22413,"title":"Fix a.clone(b=dict(c=None))","user":{"login":"makortel","id":33993,"avatar_url":"https://avatars3.githubusercontent.com/u/33993?v=4","gravatar_id":"","url":"https://api.github.com/users/makortel","html_url":"https://github.com/makortel","followers_url":"https://api.github.com/users/makortel/followers","following_url":"https://api.github.com/users/makortel/following{/other_user}","gists_url":"https://api.github.com/users/makortel/gists{/gist_id}","starred_url":"https://api.github.com/users/makortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makortel/subscriptions","organizations_url":"https://api.github.com/users/makortel/orgs","repos_url":"https://api.github.com/users/makortel/repos","events_url":"https://api.github.com/users/makortel/events{/privacy}","received_events_url":"https://api.github.com/users/makortel/received_events","type":"User","site_admin":false},"labels":[{"id":290514703,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/bug-fix","name":"bug-fix","color":"b8860b","default":false},{"id":673935047,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"009800","default":false},{"id":88645479,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800","default":false},{"id":52882056,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/core-approved","name":"core-approved","color":"009800","default":false},{"id":53149121,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/fully-signed","name":"fully-signed","color":"009800","default":false},{"id":290514704,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-approved","name":"orp-approved","color":"009800","default":false},{"id":56131220,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-rejected","name":"tests-rejected","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/73","html_url":"https://github.com/cms-sw/cmssw/milestone/73","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/73/labels","id":3060828,"number":73,"title":"CMSSW_10_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":86,"closed_issues":351,"state":"open","created_at":"2018-01-24T11:24:59Z","updated_at":"2018-03-04T23:06:49Z","due_on":null,"closed_at":null},"comments":22,"created_at":"2018-03-02T08:47:37Z","updated_at":"2018-03-05T09:57:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22413","html_url":"https://github.com/cms-sw/cmssw/pull/22413","diff_url":"https://github.com/cms-sw/cmssw/pull/22413.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/22413.patch"},"body":"I noticed that\r\n```\r\na = cms.PSet(b = cms.PSet(c = ...))\r\nd = a.clone(b=dict(c=None))\r\n```\r\ndid not remove `d.b.c`. This PR adds a unit test for this case and attempts to fix it.\r\n\r\nTested in CMSSW_10_1_X_2018-02-27-2300, no changes expected (I assume we have not hit this bug before)."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/370367383","html_url":"https://github.com/cms-sw/cmssw/pull/22413#issuecomment-370367383","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22413","id":370367383,"user":{"login":"fabiocos","id":4058194,"avatar_url":"https://avatars3.githubusercontent.com/u/4058194?v=4","gravatar_id":"","url":"https://api.github.com/users/fabiocos","html_url":"https://github.com/fabiocos","followers_url":"https://api.github.com/users/fabiocos/followers","following_url":"https://api.github.com/users/fabiocos/following{/other_user}","gists_url":"https://api.github.com/users/fabiocos/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiocos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiocos/subscriptions","organizations_url":"https://api.github.com/users/fabiocos/orgs","repos_url":"https://api.github.com/users/fabiocos/repos","events_url":"https://api.github.com/users/fabiocos/events{/privacy}","received_events_url":"https://api.github.com/users/fabiocos/received_events","type":"User","site_admin":false},"created_at":"2018-03-05T09:57:06Z","updated_at":"2018-03-05T09:57:06Z","author_association":"CONTRIBUTOR","body":"merge"}}
{"actor":{"display_login":"fabiocos"}}