{"action":"closed","number":15,"pull_request":{"url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/pulls/15","id":205544901,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NTQ0OTAx","html_url":"https://github.com/fabric8-ui/ngx-feature-flag/pull/15","diff_url":"https://github.com/fabric8-ui/ngx-feature-flag/pull/15.diff","patch_url":"https://github.com/fabric8-ui/ngx-feature-flag/pull/15.patch","issue_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/issues/15","number":15,"state":"closed","locked":false,"title":"feat(resolver): move feature-flag.resolver from fabric8-ui to ngx-feature-flag","user":{"login":"rohitkrai03","id":6041994,"node_id":"MDQ6VXNlcjYwNDE5OTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6041994?v=4","gravatar_id":"","url":"https://api.github.com/users/rohitkrai03","html_url":"https://github.com/rohitkrai03","followers_url":"https://api.github.com/users/rohitkrai03/followers","following_url":"https://api.github.com/users/rohitkrai03/following{/other_user}","gists_url":"https://api.github.com/users/rohitkrai03/gists{/gist_id}","starred_url":"https://api.github.com/users/rohitkrai03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohitkrai03/subscriptions","organizations_url":"https://api.github.com/users/rohitkrai03/orgs","repos_url":"https://api.github.com/users/rohitkrai03/repos","events_url":"https://api.github.com/users/rohitkrai03/events{/privacy}","received_events_url":"https://api.github.com/users/rohitkrai03/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/openshiftio/openshift.io/issues/4116\r\nFixes https://github.com/fabric8-services/fabric8-auth/issues/570\r\n\r\n- `ngx-feature-flag` library was extracted out of `fabric8-ui` so that external libraries such as `fabric8-planner` would be able to use feature flags.\r\n- But there is still one piece of code `FeatureFlagResolver` inside `fabric8-ui` which needs to move to `ngx-feature-flag` so that the other libraries do not need to write it all over again.","created_at":"2018-08-01T20:33:11Z","updated_at":"2018-08-06T13:45:28Z","closed_at":"2018-08-06T13:45:28Z","merged_at":"2018-08-06T13:45:28Z","merge_commit_sha":"9e43dff17427f016a83d77fb01433d3b5261b958","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/pulls/15/commits","review_comments_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/pulls/15/comments","review_comment_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/issues/15/comments","statuses_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/statuses/ecbe02be4e8ecef5de5cefa20e37d0a70e0c892f","head":{"label":"rohitkrai03:add-resolver","ref":"add-resolver","sha":"ecbe02be4e8ecef5de5cefa20e37d0a70e0c892f","user":{"login":"rohitkrai03","id":6041994,"node_id":"MDQ6VXNlcjYwNDE5OTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6041994?v=4","gravatar_id":"","url":"https://api.github.com/users/rohitkrai03","html_url":"https://github.com/rohitkrai03","followers_url":"https://api.github.com/users/rohitkrai03/followers","following_url":"https://api.github.com/users/rohitkrai03/following{/other_user}","gists_url":"https://api.github.com/users/rohitkrai03/gists{/gist_id}","starred_url":"https://api.github.com/users/rohitkrai03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohitkrai03/subscriptions","organizations_url":"https://api.github.com/users/rohitkrai03/orgs","repos_url":"https://api.github.com/users/rohitkrai03/repos","events_url":"https://api.github.com/users/rohitkrai03/events{/privacy}","received_events_url":"https://api.github.com/users/rohitkrai03/received_events","type":"User","site_admin":false},"repo":{"id":143194738,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMxOTQ3Mzg=","name":"ngx-feature-flag","full_name":"rohitkrai03/ngx-feature-flag","owner":{"login":"rohitkrai03","id":6041994,"node_id":"MDQ6VXNlcjYwNDE5OTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6041994?v=4","gravatar_id":"","url":"https://api.github.com/users/rohitkrai03","html_url":"https://github.com/rohitkrai03","followers_url":"https://api.github.com/users/rohitkrai03/followers","following_url":"https://api.github.com/users/rohitkrai03/following{/other_user}","gists_url":"https://api.github.com/users/rohitkrai03/gists{/gist_id}","starred_url":"https://api.github.com/users/rohitkrai03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohitkrai03/subscriptions","organizations_url":"https://api.github.com/users/rohitkrai03/orgs","repos_url":"https://api.github.com/users/rohitkrai03/repos","events_url":"https://api.github.com/users/rohitkrai03/events{/privacy}","received_events_url":"https://api.github.com/users/rohitkrai03/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rohitkrai03/ngx-feature-flag","description":":sparkles: Feature flag angular library :checkered_flag:","fork":true,"url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag","forks_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/forks","keys_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/teams","hooks_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/hooks","issue_events_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/issues/events{/number}","events_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/events","assignees_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/assignees{/user}","branches_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/branches{/branch}","tags_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/tags","blobs_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/git/refs{/sha}","trees_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/statuses/{sha}","languages_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/languages","stargazers_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/stargazers","contributors_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/contributors","subscribers_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/subscribers","subscription_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/subscription","commits_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/commits{/sha}","git_commits_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/git/commits{/sha}","comments_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/comments{/number}","issue_comment_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/issues/comments{/number}","contents_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/contents/{+path}","compare_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/merges","archive_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/downloads","issues_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/issues{/number}","pulls_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/pulls{/number}","milestones_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/milestones{/number}","notifications_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/labels{/name}","releases_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/releases{/id}","deployments_url":"https://api.github.com/repos/rohitkrai03/ngx-feature-flag/deployments","created_at":"2018-08-01T18:41:12Z","updated_at":"2018-08-01T18:41:14Z","pushed_at":"2018-08-02T13:38:25Z","git_url":"git://github.com/rohitkrai03/ngx-feature-flag.git","ssh_url":"git@github.com:rohitkrai03/ngx-feature-flag.git","clone_url":"https://github.com/rohitkrai03/ngx-feature-flag.git","svn_url":"https://github.com/rohitkrai03/ngx-feature-flag","homepage":"","size":271,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8-ui:master","ref":"master","sha":"444a5bead2126910ecdccda771e9271dd67a734a","user":{"login":"fabric8-ui","id":25244298,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjQ0Mjk4","avatar_url":"https://avatars2.githubusercontent.com/u/25244298?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-ui","html_url":"https://github.com/fabric8-ui","followers_url":"https://api.github.com/users/fabric8-ui/followers","following_url":"https://api.github.com/users/fabric8-ui/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-ui/subscriptions","organizations_url":"https://api.github.com/users/fabric8-ui/orgs","repos_url":"https://api.github.com/users/fabric8-ui/repos","events_url":"https://api.github.com/users/fabric8-ui/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":138324550,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgzMjQ1NTA=","name":"ngx-feature-flag","full_name":"fabric8-ui/ngx-feature-flag","owner":{"login":"fabric8-ui","id":25244298,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjQ0Mjk4","avatar_url":"https://avatars2.githubusercontent.com/u/25244298?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-ui","html_url":"https://github.com/fabric8-ui","followers_url":"https://api.github.com/users/fabric8-ui/followers","following_url":"https://api.github.com/users/fabric8-ui/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-ui/subscriptions","organizations_url":"https://api.github.com/users/fabric8-ui/orgs","repos_url":"https://api.github.com/users/fabric8-ui/repos","events_url":"https://api.github.com/users/fabric8-ui/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric8-ui/ngx-feature-flag","description":":sparkles: Feature flag angular library :checkered_flag:","fork":false,"url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag","forks_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/forks","keys_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/teams","hooks_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/hooks","issue_events_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/events","assignees_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/tags","blobs_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/languages","stargazers_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/stargazers","contributors_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/contributors","subscribers_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/subscribers","subscription_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/subscription","commits_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/merges","archive_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/downloads","issues_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/labels{/name}","releases_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/deployments","created_at":"2018-06-22T16:25:52Z","updated_at":"2018-07-26T15:08:59Z","pushed_at":"2018-08-06T13:45:28Z","git_url":"git://github.com/fabric8-ui/ngx-feature-flag.git","ssh_url":"git@github.com:fabric8-ui/ngx-feature-flag.git","clone_url":"https://github.com/fabric8-ui/ngx-feature-flag.git","svn_url":"https://github.com/fabric8-ui/ngx-feature-flag","homepage":"","size":269,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/pulls/15"},"html":{"href":"https://github.com/fabric8-ui/ngx-feature-flag/pull/15"},"issue":{"href":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/issues/15"},"comments":{"href":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8-ui/ngx-feature-flag/statuses/ecbe02be4e8ecef5de5cefa20e37d0a70e0c892f"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"joshuawilson","id":1184371,"node_id":"MDQ6VXNlcjExODQzNzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1184371?v=4","gravatar_id":"","url":"https://api.github.com/users/joshuawilson","html_url":"https://github.com/joshuawilson","followers_url":"https://api.github.com/users/joshuawilson/followers","following_url":"https://api.github.com/users/joshuawilson/following{/other_user}","gists_url":"https://api.github.com/users/joshuawilson/gists{/gist_id}","starred_url":"https://api.github.com/users/joshuawilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshuawilson/subscriptions","organizations_url":"https://api.github.com/users/joshuawilson/orgs","repos_url":"https://api.github.com/users/joshuawilson/repos","events_url":"https://api.github.com/users/joshuawilson/events{/privacy}","received_events_url":"https://api.github.com/users/joshuawilson/received_events","type":"User","site_admin":false},"comments":7,"review_comments":2,"maintainer_can_modify":false,"commits":2,"additions":289,"deletions":0,"changed_files":3}}
{"actor":{"display_login":"joshuawilson"}}