{"action":"created","comment":{"url":"https://api.github.com/repos/mads-hartmann/bash-language-server/pulls/comments/192971322","pull_request_review_id":125845720,"id":192971322,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mjk3MTMyMg==","diff_hunk":"@@ -20,7 +20,13 @@ npm i -g bash-language-server\n - [x] Highlight occurrences\n - [x] Code completion\n - [x] Simple diagnostics reporting\n+- [x] Documentation for flags on hover\n - [ ] Rename symbol\n \n+## Configuration\n+","path":"vscode-client/README.md","position":17,"original_position":17,"commit_id":"182fecc33d3dfac5f45a744c877a1a3062de37d8","original_commit_id":"30b64d6fb261e45283ee1b479784958e956a2894","user":{"login":"skovhus","id":1260305,"node_id":"MDQ6VXNlcjEyNjAzMDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1260305?v=4","gravatar_id":"","url":"https://api.github.com/users/skovhus","html_url":"https://github.com/skovhus","followers_url":"https://api.github.com/users/skovhus/followers","following_url":"https://api.github.com/users/skovhus/following{/other_user}","gists_url":"https://api.github.com/users/skovhus/gists{/gist_id}","starred_url":"https://api.github.com/users/skovhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skovhus/subscriptions","organizations_url":"https://api.github.com/users/skovhus/orgs","repos_url":"https://api.github.com/users/skovhus/repos","events_url":"https://api.github.com/users/skovhus/events{/privacy}","received_events_url":"https://api.github.com/users/skovhus/received_events","type":"User","site_admin":false},"body":"Awesome. Maybe also a link to https://github.com/idank/explainshell/pull/125 ?","created_at":"2018-06-05T07:27:00Z","updated_at":"2018-06-05T07:28:06Z","html_url":"https://github.com/mads-hartmann/bash-language-server/pull/45#discussion_r192971322","pull_request_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/pulls/45","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mads-hartmann/bash-language-server/pulls/comments/192971322"},"html":{"href":"https://github.com/mads-hartmann/bash-language-server/pull/45#discussion_r192971322"},"pull_request":{"href":"https://api.github.com/repos/mads-hartmann/bash-language-server/pulls/45"}},"in_reply_to_id":192664097},"pull_request":{"url":"https://api.github.com/repos/mads-hartmann/bash-language-server/pulls/45","id":192310542,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMzEwNTQy","html_url":"https://github.com/mads-hartmann/bash-language-server/pull/45","diff_url":"https://github.com/mads-hartmann/bash-language-server/pull/45.diff","patch_url":"https://github.com/mads-hartmann/bash-language-server/pull/45.patch","issue_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/issues/45","number":45,"state":"open","locked":false,"title":"Add explainshell integration","user":{"login":"chrismwendt","id":1387653,"node_id":"MDQ6VXNlcjEzODc2NTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1387653?v=4","gravatar_id":"","url":"https://api.github.com/users/chrismwendt","html_url":"https://github.com/chrismwendt","followers_url":"https://api.github.com/users/chrismwendt/followers","following_url":"https://api.github.com/users/chrismwendt/following{/other_user}","gists_url":"https://api.github.com/users/chrismwendt/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismwendt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismwendt/subscriptions","organizations_url":"https://api.github.com/users/chrismwendt/orgs","repos_url":"https://api.github.com/users/chrismwendt/repos","events_url":"https://api.github.com/users/chrismwendt/events{/privacy}","received_events_url":"https://api.github.com/users/chrismwendt/received_events","type":"User","site_admin":false},"body":"![2018-06-03 20 59 17](https://user-images.githubusercontent.com/1387653/40897821-1961c830-6772-11e8-9cfb-da39b868f588.gif)\r\n\r\nThis adds a VS Code setting `bash.explainshellEndpoint` which is forwarded to the language server as an environment variable `EXPLAINSHELL_ENDPOINT` (when `\"\"` the feature is disabled, and once https://github.com/idank/explainshell/pull/125 is merged in, you'll be able to set this to `\"https://explainshell.com\"`). When enabled, HTTP requests will be sent to [explainshell][xs] upon hover to show documentation for flags.\r\n\r\n**How to run this**\r\n\r\n```\r\ndocker run --name bash-explainshell --rm -p 5000:5000 chrismwendt/codeintel-bash-with-explainshell\r\n```\r\n\r\nThen set this in your VS Code config:\r\n\r\n```\r\n    \"bash.explainshellEndpoint\": \"http://localhost:5000\",\r\n```\r\n\r\nThen launch the version of the extension on this branch through VS Code and you should see docs on hover like in the GIF above.\r\n\r\nResolves #42 \r\n\r\n[xs]: https://explainshell.com/","created_at":"2018-06-04T06:38:57Z","updated_at":"2018-06-05T07:28:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95c3ae377517ab581d9568a30913cb796a13a387","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mads-hartmann","id":83561,"node_id":"MDQ6VXNlcjgzNTYx","avatar_url":"https://avatars3.githubusercontent.com/u/83561?v=4","gravatar_id":"","url":"https://api.github.com/users/mads-hartmann","html_url":"https://github.com/mads-hartmann","followers_url":"https://api.github.com/users/mads-hartmann/followers","following_url":"https://api.github.com/users/mads-hartmann/following{/other_user}","gists_url":"https://api.github.com/users/mads-hartmann/gists{/gist_id}","starred_url":"https://api.github.com/users/mads-hartmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mads-hartmann/subscriptions","organizations_url":"https://api.github.com/users/mads-hartmann/orgs","repos_url":"https://api.github.com/users/mads-hartmann/repos","events_url":"https://api.github.com/users/mads-hartmann/events{/privacy}","received_events_url":"https://api.github.com/users/mads-hartmann/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/pulls/45/commits","review_comments_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/pulls/45/comments","review_comment_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/issues/45/comments","statuses_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/statuses/182fecc33d3dfac5f45a744c877a1a3062de37d8","head":{"label":"chrismwendt:explainshell","ref":"explainshell","sha":"182fecc33d3dfac5f45a744c877a1a3062de37d8","user":{"login":"chrismwendt","id":1387653,"node_id":"MDQ6VXNlcjEzODc2NTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1387653?v=4","gravatar_id":"","url":"https://api.github.com/users/chrismwendt","html_url":"https://github.com/chrismwendt","followers_url":"https://api.github.com/users/chrismwendt/followers","following_url":"https://api.github.com/users/chrismwendt/following{/other_user}","gists_url":"https://api.github.com/users/chrismwendt/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismwendt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismwendt/subscriptions","organizations_url":"https://api.github.com/users/chrismwendt/orgs","repos_url":"https://api.github.com/users/chrismwendt/repos","events_url":"https://api.github.com/users/chrismwendt/events{/privacy}","received_events_url":"https://api.github.com/users/chrismwendt/received_events","type":"User","site_admin":false},"repo":{"id":135107481,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUxMDc0ODE=","name":"bash-language-server","full_name":"chrismwendt/bash-language-server","owner":{"login":"chrismwendt","id":1387653,"node_id":"MDQ6VXNlcjEzODc2NTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1387653?v=4","gravatar_id":"","url":"https://api.github.com/users/chrismwendt","html_url":"https://github.com/chrismwendt","followers_url":"https://api.github.com/users/chrismwendt/followers","following_url":"https://api.github.com/users/chrismwendt/following{/other_user}","gists_url":"https://api.github.com/users/chrismwendt/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismwendt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismwendt/subscriptions","organizations_url":"https://api.github.com/users/chrismwendt/orgs","repos_url":"https://api.github.com/users/chrismwendt/repos","events_url":"https://api.github.com/users/chrismwendt/events{/privacy}","received_events_url":"https://api.github.com/users/chrismwendt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrismwendt/bash-language-server","description":"A language server for Bash","fork":true,"url":"https://api.github.com/repos/chrismwendt/bash-language-server","forks_url":"https://api.github.com/repos/chrismwendt/bash-language-server/forks","keys_url":"https://api.github.com/repos/chrismwendt/bash-language-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrismwendt/bash-language-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrismwendt/bash-language-server/teams","hooks_url":"https://api.github.com/repos/chrismwendt/bash-language-server/hooks","issue_events_url":"https://api.github.com/repos/chrismwendt/bash-language-server/issues/events{/number}","events_url":"https://api.github.com/repos/chrismwendt/bash-language-server/events","assignees_url":"https://api.github.com/repos/chrismwendt/bash-language-server/assignees{/user}","branches_url":"https://api.github.com/repos/chrismwendt/bash-language-server/branches{/branch}","tags_url":"https://api.github.com/repos/chrismwendt/bash-language-server/tags","blobs_url":"https://api.github.com/repos/chrismwendt/bash-language-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrismwendt/bash-language-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrismwendt/bash-language-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrismwendt/bash-language-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrismwendt/bash-language-server/statuses/{sha}","languages_url":"https://api.github.com/repos/chrismwendt/bash-language-server/languages","stargazers_url":"https://api.github.com/repos/chrismwendt/bash-language-server/stargazers","contributors_url":"https://api.github.com/repos/chrismwendt/bash-language-server/contributors","subscribers_url":"https://api.github.com/repos/chrismwendt/bash-language-server/subscribers","subscription_url":"https://api.github.com/repos/chrismwendt/bash-language-server/subscription","commits_url":"https://api.github.com/repos/chrismwendt/bash-language-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrismwendt/bash-language-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrismwendt/bash-language-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrismwendt/bash-language-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrismwendt/bash-language-server/contents/{+path}","compare_url":"https://api.github.com/repos/chrismwendt/bash-language-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrismwendt/bash-language-server/merges","archive_url":"https://api.github.com/repos/chrismwendt/bash-language-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrismwendt/bash-language-server/downloads","issues_url":"https://api.github.com/repos/chrismwendt/bash-language-server/issues{/number}","pulls_url":"https://api.github.com/repos/chrismwendt/bash-language-server/pulls{/number}","milestones_url":"https://api.github.com/repos/chrismwendt/bash-language-server/milestones{/number}","notifications_url":"https://api.github.com/repos/chrismwendt/bash-language-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrismwendt/bash-language-server/labels{/name}","releases_url":"https://api.github.com/repos/chrismwendt/bash-language-server/releases{/id}","deployments_url":"https://api.github.com/repos/chrismwendt/bash-language-server/deployments","created_at":"2018-05-28T03:57:45Z","updated_at":"2018-05-28T03:57:47Z","pushed_at":"2018-06-05T01:41:48Z","git_url":"git://github.com/chrismwendt/bash-language-server.git","ssh_url":"git@github.com:chrismwendt/bash-language-server.git","clone_url":"https://github.com/chrismwendt/bash-language-server.git","svn_url":"https://github.com/chrismwendt/bash-language-server","homepage":null,"size":319,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mads-hartmann:master","ref":"master","sha":"4dee1c7a4b67dce8dc7a9df420564ea6aab8ca4b","user":{"login":"mads-hartmann","id":83561,"node_id":"MDQ6VXNlcjgzNTYx","avatar_url":"https://avatars3.githubusercontent.com/u/83561?v=4","gravatar_id":"","url":"https://api.github.com/users/mads-hartmann","html_url":"https://github.com/mads-hartmann","followers_url":"https://api.github.com/users/mads-hartmann/followers","following_url":"https://api.github.com/users/mads-hartmann/following{/other_user}","gists_url":"https://api.github.com/users/mads-hartmann/gists{/gist_id}","starred_url":"https://api.github.com/users/mads-hartmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mads-hartmann/subscriptions","organizations_url":"https://api.github.com/users/mads-hartmann/orgs","repos_url":"https://api.github.com/users/mads-hartmann/repos","events_url":"https://api.github.com/users/mads-hartmann/events{/privacy}","received_events_url":"https://api.github.com/users/mads-hartmann/received_events","type":"User","site_admin":false},"repo":{"id":122759875,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI3NTk4NzU=","name":"bash-language-server","full_name":"mads-hartmann/bash-language-server","owner":{"login":"mads-hartmann","id":83561,"node_id":"MDQ6VXNlcjgzNTYx","avatar_url":"https://avatars3.githubusercontent.com/u/83561?v=4","gravatar_id":"","url":"https://api.github.com/users/mads-hartmann","html_url":"https://github.com/mads-hartmann","followers_url":"https://api.github.com/users/mads-hartmann/followers","following_url":"https://api.github.com/users/mads-hartmann/following{/other_user}","gists_url":"https://api.github.com/users/mads-hartmann/gists{/gist_id}","starred_url":"https://api.github.com/users/mads-hartmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mads-hartmann/subscriptions","organizations_url":"https://api.github.com/users/mads-hartmann/orgs","repos_url":"https://api.github.com/users/mads-hartmann/repos","events_url":"https://api.github.com/users/mads-hartmann/events{/privacy}","received_events_url":"https://api.github.com/users/mads-hartmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mads-hartmann/bash-language-server","description":"A language server for Bash","fork":false,"url":"https://api.github.com/repos/mads-hartmann/bash-language-server","forks_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/forks","keys_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/teams","hooks_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/hooks","issue_events_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/issues/events{/number}","events_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/events","assignees_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/assignees{/user}","branches_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/branches{/branch}","tags_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/tags","blobs_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/languages","stargazers_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/stargazers","contributors_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/contributors","subscribers_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/subscribers","subscription_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/subscription","commits_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/contents/{+path}","compare_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/merges","archive_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/downloads","issues_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/issues{/number}","pulls_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/labels{/name}","releases_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/releases{/id}","deployments_url":"https://api.github.com/repos/mads-hartmann/bash-language-server/deployments","created_at":"2018-02-24T16:55:00Z","updated_at":"2018-06-05T01:56:29Z","pushed_at":"2018-06-05T01:41:49Z","git_url":"git://github.com/mads-hartmann/bash-language-server.git","ssh_url":"git@github.com:mads-hartmann/bash-language-server.git","clone_url":"https://github.com/mads-hartmann/bash-language-server.git","svn_url":"https://github.com/mads-hartmann/bash-language-server","homepage":null,"size":294,"stargazers_count":44,"watchers_count":44,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":14,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mads-hartmann/bash-language-server/pulls/45"},"html":{"href":"https://github.com/mads-hartmann/bash-language-server/pull/45"},"issue":{"href":"https://api.github.com/repos/mads-hartmann/bash-language-server/issues/45"},"comments":{"href":"https://api.github.com/repos/mads-hartmann/bash-language-server/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/mads-hartmann/bash-language-server/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/mads-hartmann/bash-language-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mads-hartmann/bash-language-server/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/mads-hartmann/bash-language-server/statuses/182fecc33d3dfac5f45a744c877a1a3062de37d8"}},"author_association":"NONE"}}
{"actor":{"display_login":"skovhus"}}