{"action":"created","issue":{"url":"https://api.github.com/repos/plv8/plv8/issues/298","repository_url":"https://api.github.com/repos/plv8/plv8","labels_url":"https://api.github.com/repos/plv8/plv8/issues/298/labels{/name}","comments_url":"https://api.github.com/repos/plv8/plv8/issues/298/comments","events_url":"https://api.github.com/repos/plv8/plv8/issues/298/events","html_url":"https://github.com/plv8/plv8/issues/298","id":348016475,"node_id":"MDU6SXNzdWUzNDgwMTY0NzU=","number":298,"title":"Suggestion: add SPI_freetuptable(SPI_tuptable) in plv8_PlanFree","user":{"login":"myday1227","id":3161756,"node_id":"MDQ6VXNlcjMxNjE3NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3161756?v=4","gravatar_id":"","url":"https://api.github.com/users/myday1227","html_url":"https://github.com/myday1227","followers_url":"https://api.github.com/users/myday1227/followers","following_url":"https://api.github.com/users/myday1227/following{/other_user}","gists_url":"https://api.github.com/users/myday1227/gists{/gist_id}","starred_url":"https://api.github.com/users/myday1227/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myday1227/subscriptions","organizations_url":"https://api.github.com/users/myday1227/orgs","repos_url":"https://api.github.com/users/myday1227/repos","events_url":"https://api.github.com/users/myday1227/events{/privacy}","received_events_url":"https://api.github.com/users/myday1227/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-06T17:33:38Z","updated_at":"2018-08-06T17:35:07Z","closed_at":null,"author_association":"NONE","body":"I debug through the following code circle:\r\n    plv8_Prepare\r\n    plv8_PlanExecute\r\n    plv8_PlanFree\r\n\r\nI notice we didn't free SPI_tuptable until finishing the entire \"language plv8 as $$ $$;\" block with SPI_finish() in DoCall.\r\n\r\n`Local<v8::Value> result = fn->Call(receiver, nargs, args);`\r\n`int\tstatus = SPI_finish(); <== none of native psql results will be released until here`\t\r\n\r\nIf there are a lot of sql statements in one \"language plv8 as $$ $$;\" block, it will end up with holding a large truck of memory in SPI_tuptable.\r\n\r\nCan we add SPI_freetuptable(SPI_tuptable) in plv8_PlanFree? Since plv8_PlanFree is a very clear indication that developer is done with the statement and the result is already copied into v8 javascript variable from SPI_tuptable.\r\n\r\nThanks"},"comment":{"url":"https://api.github.com/repos/plv8/plv8/issues/comments/410788597","html_url":"https://github.com/plv8/plv8/issues/298#issuecomment-410788597","issue_url":"https://api.github.com/repos/plv8/plv8/issues/298","id":410788597,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDc4ODU5Nw==","user":{"login":"JerrySievert","id":471270,"node_id":"MDQ6VXNlcjQ3MTI3MA==","avatar_url":"https://avatars3.githubusercontent.com/u/471270?v=4","gravatar_id":"","url":"https://api.github.com/users/JerrySievert","html_url":"https://github.com/JerrySievert","followers_url":"https://api.github.com/users/JerrySievert/followers","following_url":"https://api.github.com/users/JerrySievert/following{/other_user}","gists_url":"https://api.github.com/users/JerrySievert/gists{/gist_id}","starred_url":"https://api.github.com/users/JerrySievert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JerrySievert/subscriptions","organizations_url":"https://api.github.com/users/JerrySievert/orgs","repos_url":"https://api.github.com/users/JerrySievert/repos","events_url":"https://api.github.com/users/JerrySievert/events{/privacy}","received_events_url":"https://api.github.com/users/JerrySievert/received_events","type":"User","site_admin":false},"created_at":"2018-08-06T17:35:07Z","updated_at":"2018-08-06T17:35:07Z","author_association":"CONTRIBUTOR","body":"I'll take a look - good suggestion.\r\n\r\nif I make the change, likely it will be a \"going forward\" change, though."}}
{"actor":{"display_login":"JerrySievert"}}