{"action":"created","issue":{"url":"https://api.github.com/repos/DoSomething/gambit-campaigns/issues/1035","repository_url":"https://api.github.com/repos/DoSomething/gambit-campaigns","labels_url":"https://api.github.com/repos/DoSomething/gambit-campaigns/issues/1035/labels{/name}","comments_url":"https://api.github.com/repos/DoSomething/gambit-campaigns/issues/1035/comments","events_url":"https://api.github.com/repos/DoSomething/gambit-campaigns/issues/1035/events","html_url":"https://github.com/DoSomething/gambit-campaigns/pull/1035","id":313860230,"number":1035,"title":"signupConfirmed refactor: photoPostConfig.startPhotoPost + textPostConfig.askText","user":{"login":"aaronschachter","id":1236811,"avatar_url":"https://avatars2.githubusercontent.com/u/1236811?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronschachter","html_url":"https://github.com/aaronschachter","followers_url":"https://api.github.com/users/aaronschachter/followers","following_url":"https://api.github.com/users/aaronschachter/following{/other_user}","gists_url":"https://api.github.com/users/aaronschachter/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronschachter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronschachter/subscriptions","organizations_url":"https://api.github.com/users/aaronschachter/orgs","repos_url":"https://api.github.com/users/aaronschachter/repos","events_url":"https://api.github.com/users/aaronschachter/events{/privacy}","received_events_url":"https://api.github.com/users/aaronschachter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-12T19:38:30Z","updated_at":"2018-04-16T21:59:01Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/DoSomething/gambit-campaigns/pulls/1035","html_url":"https://github.com/DoSomething/gambit-campaigns/pull/1035","diff_url":"https://github.com/DoSomething/gambit-campaigns/pull/1035.diff","patch_url":"https://github.com/DoSomething/gambit-campaigns/pull/1035.patch"},"body":"## Update\r\n4/16 - I'm going to hold off on renaming and migrating any fields in Contentful, as we'll want to start using code for content migrations #1037. \r\n\r\nWhen I revisited the `menu-doing` and `menu-completed` middleware to rename the replies to `botSignupConfirmed` and `photoPostCompleted`, it got me thinking that it felt pretty confusing that a `botSignupConfirmed` template could have two different functions, it asks for START in a photoPostConfig and asks for reportback text in a textPostConfig.  It also seemed logical to combine the `menu-doing` and `menu-completed` middleware into a single `draft-not-found` to DRY.  Seeing the logic for both doing/completed in one place made it seem like renaming `botSignupConfirmed` as `startPhotoPost`  would help make things more readable.\r\n\r\nFor now, this PR uses the existing field names to avoid making too many potentially breaking changes at once. I'll be opening up a new Conversations PR to parse the new template names as campaign activity messages.\r\n\r\n## Original PR\r\n\r\n#### What's this PR do?\r\nAdds new templates for a `photoPostConfig` content type per the Gambini spec in #1033, adding new fields in Contentful:\r\n*  `botSignupConfirmedMessage`\r\n*  `webSignupConfirmedMessage`\r\n*  `signupConfirmedAutoReply`\r\n*  `photoPostCompleted`\r\n* `photoPostCompletedAutoReply`\r\n\r\n#### How should this be reviewed?\r\nOnce the fields have been added and their values have been backfilled, verify the copy is identical in a `GET /campaigns/:id` response for each pair of templates, listed as new template + to-be-deprecated template.\r\n\r\n* botSignupConfirmed + gambitSignupMenu\r\n* webSignupConfirmed + externalSignupMenu\r\n* signupConfirmedAutoReply + invalidSignupMenuCommand\r\n* photoPostCompleted + completedMenu\r\n* photoPostCompletedAutoReply + invalidCompletedMenuCommand\r\n\r\n#### Any background context you want to provide?\r\nI'll be checking off each field in this PR as I add them into Contentful, and will go through each `photoPostConfig` entry in production to copy values over.  Contentful migration CLI could be nice for this... but there's only 7 entries so it doesn't feel like a huge time sink 🚰 \r\n\r\n#### Relevant tickets\r\n#1033 \r\n\r\n#### Checklist\r\n- [ ] Documentation added for new features/changed endpoints.\r\n- [ ] Tested on staging.\r\n"},"comment":{"url":"https://api.github.com/repos/DoSomething/gambit-campaigns/issues/comments/381763603","html_url":"https://github.com/DoSomething/gambit-campaigns/pull/1035#issuecomment-381763603","issue_url":"https://api.github.com/repos/DoSomething/gambit-campaigns/issues/1035","id":381763603,"user":{"login":"aaronschachter","id":1236811,"avatar_url":"https://avatars2.githubusercontent.com/u/1236811?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronschachter","html_url":"https://github.com/aaronschachter","followers_url":"https://api.github.com/users/aaronschachter/followers","following_url":"https://api.github.com/users/aaronschachter/following{/other_user}","gists_url":"https://api.github.com/users/aaronschachter/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronschachter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronschachter/subscriptions","organizations_url":"https://api.github.com/users/aaronschachter/orgs","repos_url":"https://api.github.com/users/aaronschachter/repos","events_url":"https://api.github.com/users/aaronschachter/events{/privacy}","received_events_url":"https://api.github.com/users/aaronschachter/received_events","type":"User","site_admin":false},"created_at":"2018-04-16T21:59:01Z","updated_at":"2018-04-16T21:59:01Z","author_association":"OWNER","body":"I've updated this PR description and tested on staging, this is ready for review along with proposed field names in the bottom section of the botConfig spec."}}
{"actor":{"display_login":"aaronschachter"}}