{"action":"created","comment":{"url":"https://api.github.com/repos/picoriley/Turntable/pulls/comments/208629796","pull_request_review_id":144476817,"id":208629796,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODYyOTc5Ng==","diff_hunk":"@@ -45,11 +45,12 @@ class SongCache\n     SongID FindLeastAccessedSong();\n     SongID FindSongToDelete();\n     bool RemoveFromCache(const SongID songID);\n+    unsigned __int64 GetProcessMemoryBytes();\n \n     //CONSTANTS/////////////////////////////////////////////////////////////////////\n-    const static unsigned int MAX_MEMORY_THRESHOLD = (unsigned int)4e8; //400 MB\n     const double SONG_NEVER_ACCESSED = -1.0;\n     const SongID INVALID_SONG_ID = 0;\n+    const unsigned int MAX_MEMORY_THRESHOLD = (unsigned int)8e8; //1 GB limit for win32","path":"Clients/Win32 Player/Code/Game/Audio/SongCache.hpp","position":10,"original_position":10,"commit_id":"1b630cdccfc6097f2d196a636df68f47f5f3cb44","original_commit_id":"1b630cdccfc6097f2d196a636df68f47f5f3cb44","user":{"login":"picoriley","id":3309340,"node_id":"MDQ6VXNlcjMzMDkzNDA=","avatar_url":"https://avatars1.githubusercontent.com/u/3309340?v=4","gravatar_id":"","url":"https://api.github.com/users/picoriley","html_url":"https://github.com/picoriley","followers_url":"https://api.github.com/users/picoriley/followers","following_url":"https://api.github.com/users/picoriley/following{/other_user}","gists_url":"https://api.github.com/users/picoriley/gists{/gist_id}","starred_url":"https://api.github.com/users/picoriley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/picoriley/subscriptions","organizations_url":"https://api.github.com/users/picoriley/orgs","repos_url":"https://api.github.com/users/picoriley/repos","events_url":"https://api.github.com/users/picoriley/events{/privacy}","received_events_url":"https://api.github.com/users/picoriley/received_events","type":"User","site_admin":false},"body":"Isn't that 800MB?","created_at":"2018-08-08T15:34:30Z","updated_at":"2018-08-08T15:36:53Z","html_url":"https://github.com/picoriley/Turntable/pull/126#discussion_r208629796","pull_request_url":"https://api.github.com/repos/picoriley/Turntable/pulls/126","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/picoriley/Turntable/pulls/comments/208629796"},"html":{"href":"https://github.com/picoriley/Turntable/pull/126#discussion_r208629796"},"pull_request":{"href":"https://api.github.com/repos/picoriley/Turntable/pulls/126"}}},"pull_request":{"url":"https://api.github.com/repos/picoriley/Turntable/pulls/126","id":205256675,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MjU2Njc1","html_url":"https://github.com/picoriley/Turntable/pull/126","diff_url":"https://github.com/picoriley/Turntable/pull/126.diff","patch_url":"https://github.com/picoriley/Turntable/pull/126.patch","issue_url":"https://api.github.com/repos/picoriley/Turntable/issues/126","number":126,"state":"open","locked":false,"title":"Count uncompressed filesizes toward the cache size, and forward track loading","user":{"login":"weruder","id":8061625,"node_id":"MDQ6VXNlcjgwNjE2MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/8061625?v=4","gravatar_id":"","url":"https://api.github.com/users/weruder","html_url":"https://github.com/weruder","followers_url":"https://api.github.com/users/weruder/followers","following_url":"https://api.github.com/users/weruder/following{/other_user}","gists_url":"https://api.github.com/users/weruder/gists{/gist_id}","starred_url":"https://api.github.com/users/weruder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weruder/subscriptions","organizations_url":"https://api.github.com/users/weruder/orgs","repos_url":"https://api.github.com/users/weruder/repos","events_url":"https://api.github.com/users/weruder/events{/privacy}","received_events_url":"https://api.github.com/users/weruder/received_events","type":"User","site_admin":false},"body":"Also added a function for getting the amount of process memory in bytes.","created_at":"2018-07-31T22:09:26Z","updated_at":"2018-08-08T15:36:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3088232793db5f9e490151c07c7aaeeb8bb8d763","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/picoriley/Turntable/milestones/4","html_url":"https://github.com/picoriley/Turntable/milestone/4","labels_url":"https://api.github.com/repos/picoriley/Turntable/milestones/4/labels","id":3268363,"node_id":"MDk6TWlsZXN0b25lMzI2ODM2Mw==","number":4,"title":"v0.4 - Obbligato","description":"","creator":{"login":"picoriley","id":3309340,"node_id":"MDQ6VXNlcjMzMDkzNDA=","avatar_url":"https://avatars1.githubusercontent.com/u/3309340?v=4","gravatar_id":"","url":"https://api.github.com/users/picoriley","html_url":"https://github.com/picoriley","followers_url":"https://api.github.com/users/picoriley/followers","following_url":"https://api.github.com/users/picoriley/following{/other_user}","gists_url":"https://api.github.com/users/picoriley/gists{/gist_id}","starred_url":"https://api.github.com/users/picoriley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/picoriley/subscriptions","organizations_url":"https://api.github.com/users/picoriley/orgs","repos_url":"https://api.github.com/users/picoriley/repos","events_url":"https://api.github.com/users/picoriley/events{/privacy}","received_events_url":"https://api.github.com/users/picoriley/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":10,"state":"open","created_at":"2018-04-15T22:16:49Z","updated_at":"2018-07-31T22:09:26Z","due_on":"2018-08-17T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/picoriley/Turntable/pulls/126/commits","review_comments_url":"https://api.github.com/repos/picoriley/Turntable/pulls/126/comments","review_comment_url":"https://api.github.com/repos/picoriley/Turntable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/picoriley/Turntable/issues/126/comments","statuses_url":"https://api.github.com/repos/picoriley/Turntable/statuses/1b630cdccfc6097f2d196a636df68f47f5f3cb44","head":{"label":"picoriley:queue","ref":"queue","sha":"1b630cdccfc6097f2d196a636df68f47f5f3cb44","user":{"login":"picoriley","id":3309340,"node_id":"MDQ6VXNlcjMzMDkzNDA=","avatar_url":"https://avatars1.githubusercontent.com/u/3309340?v=4","gravatar_id":"","url":"https://api.github.com/users/picoriley","html_url":"https://github.com/picoriley","followers_url":"https://api.github.com/users/picoriley/followers","following_url":"https://api.github.com/users/picoriley/following{/other_user}","gists_url":"https://api.github.com/users/picoriley/gists{/gist_id}","starred_url":"https://api.github.com/users/picoriley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/picoriley/subscriptions","organizations_url":"https://api.github.com/users/picoriley/orgs","repos_url":"https://api.github.com/users/picoriley/repos","events_url":"https://api.github.com/users/picoriley/events{/privacy}","received_events_url":"https://api.github.com/users/picoriley/received_events","type":"User","site_admin":false},"repo":{"id":89801099,"node_id":"MDEwOlJlcG9zaXRvcnk4OTgwMTA5OQ==","name":"Turntable","full_name":"picoriley/Turntable","owner":{"login":"picoriley","id":3309340,"node_id":"MDQ6VXNlcjMzMDkzNDA=","avatar_url":"https://avatars1.githubusercontent.com/u/3309340?v=4","gravatar_id":"","url":"https://api.github.com/users/picoriley","html_url":"https://github.com/picoriley","followers_url":"https://api.github.com/users/picoriley/followers","following_url":"https://api.github.com/users/picoriley/following{/other_user}","gists_url":"https://api.github.com/users/picoriley/gists{/gist_id}","starred_url":"https://api.github.com/users/picoriley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/picoriley/subscriptions","organizations_url":"https://api.github.com/users/picoriley/orgs","repos_url":"https://api.github.com/users/picoriley/repos","events_url":"https://api.github.com/users/picoriley/events{/privacy}","received_events_url":"https://api.github.com/users/picoriley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/picoriley/Turntable","description":"A niche music player, full of features you didn't know you ever wanted.","fork":false,"url":"https://api.github.com/repos/picoriley/Turntable","forks_url":"https://api.github.com/repos/picoriley/Turntable/forks","keys_url":"https://api.github.com/repos/picoriley/Turntable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/picoriley/Turntable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/picoriley/Turntable/teams","hooks_url":"https://api.github.com/repos/picoriley/Turntable/hooks","issue_events_url":"https://api.github.com/repos/picoriley/Turntable/issues/events{/number}","events_url":"https://api.github.com/repos/picoriley/Turntable/events","assignees_url":"https://api.github.com/repos/picoriley/Turntable/assignees{/user}","branches_url":"https://api.github.com/repos/picoriley/Turntable/branches{/branch}","tags_url":"https://api.github.com/repos/picoriley/Turntable/tags","blobs_url":"https://api.github.com/repos/picoriley/Turntable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/picoriley/Turntable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/picoriley/Turntable/git/refs{/sha}","trees_url":"https://api.github.com/repos/picoriley/Turntable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/picoriley/Turntable/statuses/{sha}","languages_url":"https://api.github.com/repos/picoriley/Turntable/languages","stargazers_url":"https://api.github.com/repos/picoriley/Turntable/stargazers","contributors_url":"https://api.github.com/repos/picoriley/Turntable/contributors","subscribers_url":"https://api.github.com/repos/picoriley/Turntable/subscribers","subscription_url":"https://api.github.com/repos/picoriley/Turntable/subscription","commits_url":"https://api.github.com/repos/picoriley/Turntable/commits{/sha}","git_commits_url":"https://api.github.com/repos/picoriley/Turntable/git/commits{/sha}","comments_url":"https://api.github.com/repos/picoriley/Turntable/comments{/number}","issue_comment_url":"https://api.github.com/repos/picoriley/Turntable/issues/comments{/number}","contents_url":"https://api.github.com/repos/picoriley/Turntable/contents/{+path}","compare_url":"https://api.github.com/repos/picoriley/Turntable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/picoriley/Turntable/merges","archive_url":"https://api.github.com/repos/picoriley/Turntable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/picoriley/Turntable/downloads","issues_url":"https://api.github.com/repos/picoriley/Turntable/issues{/number}","pulls_url":"https://api.github.com/repos/picoriley/Turntable/pulls{/number}","milestones_url":"https://api.github.com/repos/picoriley/Turntable/milestones{/number}","notifications_url":"https://api.github.com/repos/picoriley/Turntable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/picoriley/Turntable/labels{/name}","releases_url":"https://api.github.com/repos/picoriley/Turntable/releases{/id}","deployments_url":"https://api.github.com/repos/picoriley/Turntable/deployments","created_at":"2017-04-29T17:24:20Z","updated_at":"2018-07-12T00:56:41Z","pushed_at":"2018-07-31T22:09:27Z","git_url":"git://github.com/picoriley/Turntable.git","ssh_url":"git@github.com:picoriley/Turntable.git","clone_url":"https://github.com/picoriley/Turntable.git","svn_url":"https://github.com/picoriley/Turntable","homepage":"","size":717628,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":36,"license":null,"forks":0,"open_issues":36,"watchers":5,"default_branch":"master"}},"base":{"label":"picoriley:master","ref":"master","sha":"c444a4ec15b7e186154cc993d662f8b62513ea3c","user":{"login":"picoriley","id":3309340,"node_id":"MDQ6VXNlcjMzMDkzNDA=","avatar_url":"https://avatars1.githubusercontent.com/u/3309340?v=4","gravatar_id":"","url":"https://api.github.com/users/picoriley","html_url":"https://github.com/picoriley","followers_url":"https://api.github.com/users/picoriley/followers","following_url":"https://api.github.com/users/picoriley/following{/other_user}","gists_url":"https://api.github.com/users/picoriley/gists{/gist_id}","starred_url":"https://api.github.com/users/picoriley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/picoriley/subscriptions","organizations_url":"https://api.github.com/users/picoriley/orgs","repos_url":"https://api.github.com/users/picoriley/repos","events_url":"https://api.github.com/users/picoriley/events{/privacy}","received_events_url":"https://api.github.com/users/picoriley/received_events","type":"User","site_admin":false},"repo":{"id":89801099,"node_id":"MDEwOlJlcG9zaXRvcnk4OTgwMTA5OQ==","name":"Turntable","full_name":"picoriley/Turntable","owner":{"login":"picoriley","id":3309340,"node_id":"MDQ6VXNlcjMzMDkzNDA=","avatar_url":"https://avatars1.githubusercontent.com/u/3309340?v=4","gravatar_id":"","url":"https://api.github.com/users/picoriley","html_url":"https://github.com/picoriley","followers_url":"https://api.github.com/users/picoriley/followers","following_url":"https://api.github.com/users/picoriley/following{/other_user}","gists_url":"https://api.github.com/users/picoriley/gists{/gist_id}","starred_url":"https://api.github.com/users/picoriley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/picoriley/subscriptions","organizations_url":"https://api.github.com/users/picoriley/orgs","repos_url":"https://api.github.com/users/picoriley/repos","events_url":"https://api.github.com/users/picoriley/events{/privacy}","received_events_url":"https://api.github.com/users/picoriley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/picoriley/Turntable","description":"A niche music player, full of features you didn't know you ever wanted.","fork":false,"url":"https://api.github.com/repos/picoriley/Turntable","forks_url":"https://api.github.com/repos/picoriley/Turntable/forks","keys_url":"https://api.github.com/repos/picoriley/Turntable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/picoriley/Turntable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/picoriley/Turntable/teams","hooks_url":"https://api.github.com/repos/picoriley/Turntable/hooks","issue_events_url":"https://api.github.com/repos/picoriley/Turntable/issues/events{/number}","events_url":"https://api.github.com/repos/picoriley/Turntable/events","assignees_url":"https://api.github.com/repos/picoriley/Turntable/assignees{/user}","branches_url":"https://api.github.com/repos/picoriley/Turntable/branches{/branch}","tags_url":"https://api.github.com/repos/picoriley/Turntable/tags","blobs_url":"https://api.github.com/repos/picoriley/Turntable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/picoriley/Turntable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/picoriley/Turntable/git/refs{/sha}","trees_url":"https://api.github.com/repos/picoriley/Turntable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/picoriley/Turntable/statuses/{sha}","languages_url":"https://api.github.com/repos/picoriley/Turntable/languages","stargazers_url":"https://api.github.com/repos/picoriley/Turntable/stargazers","contributors_url":"https://api.github.com/repos/picoriley/Turntable/contributors","subscribers_url":"https://api.github.com/repos/picoriley/Turntable/subscribers","subscription_url":"https://api.github.com/repos/picoriley/Turntable/subscription","commits_url":"https://api.github.com/repos/picoriley/Turntable/commits{/sha}","git_commits_url":"https://api.github.com/repos/picoriley/Turntable/git/commits{/sha}","comments_url":"https://api.github.com/repos/picoriley/Turntable/comments{/number}","issue_comment_url":"https://api.github.com/repos/picoriley/Turntable/issues/comments{/number}","contents_url":"https://api.github.com/repos/picoriley/Turntable/contents/{+path}","compare_url":"https://api.github.com/repos/picoriley/Turntable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/picoriley/Turntable/merges","archive_url":"https://api.github.com/repos/picoriley/Turntable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/picoriley/Turntable/downloads","issues_url":"https://api.github.com/repos/picoriley/Turntable/issues{/number}","pulls_url":"https://api.github.com/repos/picoriley/Turntable/pulls{/number}","milestones_url":"https://api.github.com/repos/picoriley/Turntable/milestones{/number}","notifications_url":"https://api.github.com/repos/picoriley/Turntable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/picoriley/Turntable/labels{/name}","releases_url":"https://api.github.com/repos/picoriley/Turntable/releases{/id}","deployments_url":"https://api.github.com/repos/picoriley/Turntable/deployments","created_at":"2017-04-29T17:24:20Z","updated_at":"2018-07-12T00:56:41Z","pushed_at":"2018-07-31T22:09:27Z","git_url":"git://github.com/picoriley/Turntable.git","ssh_url":"git@github.com:picoriley/Turntable.git","clone_url":"https://github.com/picoriley/Turntable.git","svn_url":"https://github.com/picoriley/Turntable","homepage":"","size":717628,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":36,"license":null,"forks":0,"open_issues":36,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/picoriley/Turntable/pulls/126"},"html":{"href":"https://github.com/picoriley/Turntable/pull/126"},"issue":{"href":"https://api.github.com/repos/picoriley/Turntable/issues/126"},"comments":{"href":"https://api.github.com/repos/picoriley/Turntable/issues/126/comments"},"review_comments":{"href":"https://api.github.com/repos/picoriley/Turntable/pulls/126/comments"},"review_comment":{"href":"https://api.github.com/repos/picoriley/Turntable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/picoriley/Turntable/pulls/126/commits"},"statuses":{"href":"https://api.github.com/repos/picoriley/Turntable/statuses/1b630cdccfc6097f2d196a636df68f47f5f3cb44"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"picoriley"}}