{"action":"created","issue":{"url":"https://api.github.com/repos/inexorgame/entity-system/issues/3","repository_url":"https://api.github.com/repos/inexorgame/entity-system","labels_url":"https://api.github.com/repos/inexorgame/entity-system/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/inexorgame/entity-system/issues/3/comments","events_url":"https://api.github.com/repos/inexorgame/entity-system/issues/3/events","html_url":"https://github.com/inexorgame/entity-system/issues/3","id":347310575,"node_id":"MDU6SXNzdWUzNDczMTA1NzU=","number":3,"title":"May use smart pointers for safe (heap) memory allocation","user":{"login":"IAmNotHanni","id":7914428,"node_id":"MDQ6VXNlcjc5MTQ0Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/7914428?v=4","gravatar_id":"","url":"https://api.github.com/users/IAmNotHanni","html_url":"https://github.com/IAmNotHanni","followers_url":"https://api.github.com/users/IAmNotHanni/followers","following_url":"https://api.github.com/users/IAmNotHanni/following{/other_user}","gists_url":"https://api.github.com/users/IAmNotHanni/gists{/gist_id}","starred_url":"https://api.github.com/users/IAmNotHanni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IAmNotHanni/subscriptions","organizations_url":"https://api.github.com/users/IAmNotHanni/orgs","repos_url":"https://api.github.com/users/IAmNotHanni/repos","events_url":"https://api.github.com/users/IAmNotHanni/events{/privacy}","received_events_url":"https://api.github.com/users/IAmNotHanni/received_events","type":"User","site_admin":false},"labels":[{"id":993151430,"node_id":"MDU6TGFiZWw5OTMxNTE0MzA=","url":"https://api.github.com/repos/inexorgame/entity-system/labels/question","name":"question","color":"d876e3","default":true}],"state":"closed","locked":false,"assignee":{"login":"aschaeffer","id":2207279,"node_id":"MDQ6VXNlcjIyMDcyNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2207279?v=4","gravatar_id":"","url":"https://api.github.com/users/aschaeffer","html_url":"https://github.com/aschaeffer","followers_url":"https://api.github.com/users/aschaeffer/followers","following_url":"https://api.github.com/users/aschaeffer/following{/other_user}","gists_url":"https://api.github.com/users/aschaeffer/gists{/gist_id}","starred_url":"https://api.github.com/users/aschaeffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschaeffer/subscriptions","organizations_url":"https://api.github.com/users/aschaeffer/orgs","repos_url":"https://api.github.com/users/aschaeffer/repos","events_url":"https://api.github.com/users/aschaeffer/events{/privacy}","received_events_url":"https://api.github.com/users/aschaeffer/received_events","type":"User","site_admin":false},"assignees":[{"login":"aschaeffer","id":2207279,"node_id":"MDQ6VXNlcjIyMDcyNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2207279?v=4","gravatar_id":"","url":"https://api.github.com/users/aschaeffer","html_url":"https://github.com/aschaeffer","followers_url":"https://api.github.com/users/aschaeffer/followers","following_url":"https://api.github.com/users/aschaeffer/following{/other_user}","gists_url":"https://api.github.com/users/aschaeffer/gists{/gist_id}","starred_url":"https://api.github.com/users/aschaeffer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschaeffer/subscriptions","organizations_url":"https://api.github.com/users/aschaeffer/orgs","repos_url":"https://api.github.com/users/aschaeffer/repos","events_url":"https://api.github.com/users/aschaeffer/events{/privacy}","received_events_url":"https://api.github.com/users/aschaeffer/received_events","type":"User","site_admin":false},{"login":"IAmNotHanni","id":7914428,"node_id":"MDQ6VXNlcjc5MTQ0Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/7914428?v=4","gravatar_id":"","url":"https://api.github.com/users/IAmNotHanni","html_url":"https://github.com/IAmNotHanni","followers_url":"https://api.github.com/users/IAmNotHanni/followers","following_url":"https://api.github.com/users/IAmNotHanni/following{/other_user}","gists_url":"https://api.github.com/users/IAmNotHanni/gists{/gist_id}","starred_url":"https://api.github.com/users/IAmNotHanni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IAmNotHanni/subscriptions","organizations_url":"https://api.github.com/users/IAmNotHanni/orgs","repos_url":"https://api.github.com/users/IAmNotHanni/repos","events_url":"https://api.github.com/users/IAmNotHanni/events{/privacy}","received_events_url":"https://api.github.com/users/IAmNotHanni/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-08-03T08:43:49Z","updated_at":"2018-08-20T14:01:25Z","closed_at":"2018-08-20T14:01:25Z","author_association":"MEMBER","body":"Is it ok to use const references for parameter declaration in class methods:\r\n\r\n`\r\nEntityInstance EntityInstanceManager::Create(const std::string& entity_type_name)\r\n`\r\n\r\nOr should we use [smart pointers](https://en.cppreference.com/w/cpp/memory/shared_ptr/shared_ptr) instead ?\r\n\r\n`\r\nInstanceRefPtr<EntityInstance> EntityInstanceManager::Create(std::string entity_type_name)\r\n`\r\n"},"comment":{"url":"https://api.github.com/repos/inexorgame/entity-system/issues/comments/414326685","html_url":"https://github.com/inexorgame/entity-system/issues/3#issuecomment-414326685","issue_url":"https://api.github.com/repos/inexorgame/entity-system/issues/3","id":414326685,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDMyNjY4NQ==","user":{"login":"IAmNotHanni","id":7914428,"node_id":"MDQ6VXNlcjc5MTQ0Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/7914428?v=4","gravatar_id":"","url":"https://api.github.com/users/IAmNotHanni","html_url":"https://github.com/IAmNotHanni","followers_url":"https://api.github.com/users/IAmNotHanni/followers","following_url":"https://api.github.com/users/IAmNotHanni/following{/other_user}","gists_url":"https://api.github.com/users/IAmNotHanni/gists{/gist_id}","starred_url":"https://api.github.com/users/IAmNotHanni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IAmNotHanni/subscriptions","organizations_url":"https://api.github.com/users/IAmNotHanni/orgs","repos_url":"https://api.github.com/users/IAmNotHanni/repos","events_url":"https://api.github.com/users/IAmNotHanni/events{/privacy}","received_events_url":"https://api.github.com/users/IAmNotHanni/received_events","type":"User","site_admin":false},"created_at":"2018-08-20T14:01:25Z","updated_at":"2018-08-20T14:01:25Z","author_association":"MEMBER","body":"This feature has been implemented."}}
{"actor":{"display_login":"IAmNotHanni"}}