{"action":"created","comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments/171061968","pull_request_review_id":99849713,"id":171061968,"diff_hunk":"@@ -136,8 +136,12 @@ extras.\n Continuing our example let's add a \"constructive\" style to our *Clean-up* button. First you need to be able to add\n custom JS code into the CMS. You can do this by adding a new source file, here\n `mysite/javascript/CMSMain.CustomActionsExtension.js`, and requiring it\n-through a YAML configuration value: `LeftAndMain.extra_requirements_javascript`.\n-Set it to 'mysite/javascript/CMSMain.CustomActionsExtension.js'.\n+through a YAML configuration value: \n+```\n+<Name space>\\<Class name>:\n+  extra_requirements_javascript:\n+    - mysite/javascript/<Name of file including including .js suffix\n+```","path":"docs/en/02_Developer_Guides/15_Customising_the_Admin_Interface/How_Tos/CMS_Alternating_Button.md","position":11,"original_position":11,"commit_id":"acdc0a9a5a73566301d5c3c854a6dd884431abf2","original_commit_id":"acdc0a9a5a73566301d5c3c854a6dd884431abf2","user":{"login":"robbieaverill","id":5170590,"avatar_url":"https://avatars1.githubusercontent.com/u/5170590?v=4","gravatar_id":"","url":"https://api.github.com/users/robbieaverill","html_url":"https://github.com/robbieaverill","followers_url":"https://api.github.com/users/robbieaverill/followers","following_url":"https://api.github.com/users/robbieaverill/following{/other_user}","gists_url":"https://api.github.com/users/robbieaverill/gists{/gist_id}","starred_url":"https://api.github.com/users/robbieaverill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbieaverill/subscriptions","organizations_url":"https://api.github.com/users/robbieaverill/orgs","repos_url":"https://api.github.com/users/robbieaverill/repos","events_url":"https://api.github.com/users/robbieaverill/events{/privacy}","received_events_url":"https://api.github.com/users/robbieaverill/received_events","type":"User","site_admin":false},"body":"I think it might be good to clarify that this is a LeftAndMain configuration option, but (if this is true) that you can also apply it to subclasses of LeftAndMain. I think keeping LeftAndMain in the example code would be good, so you're just adding the namespace to the class","created_at":"2018-02-27T20:51:51Z","updated_at":"2018-02-27T20:51:53Z","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/7897#discussion_r171061968","pull_request_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/7897","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments/171061968"},"html":{"href":"https://github.com/silverstripe/silverstripe-framework/pull/7897#discussion_r171061968"},"pull_request":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/7897"}}},"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/7897","id":171780081,"html_url":"https://github.com/silverstripe/silverstripe-framework/pull/7897","diff_url":"https://github.com/silverstripe/silverstripe-framework/pull/7897.diff","patch_url":"https://github.com/silverstripe/silverstripe-framework/pull/7897.patch","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/7897","number":7897,"state":"open","locked":false,"title":"Clarify how to import JavaScript","user":{"login":"worikgh","id":5387413,"avatar_url":"https://avatars1.githubusercontent.com/u/5387413?v=4","gravatar_id":"","url":"https://api.github.com/users/worikgh","html_url":"https://github.com/worikgh","followers_url":"https://api.github.com/users/worikgh/followers","following_url":"https://api.github.com/users/worikgh/following{/other_user}","gists_url":"https://api.github.com/users/worikgh/gists{/gist_id}","starred_url":"https://api.github.com/users/worikgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worikgh/subscriptions","organizations_url":"https://api.github.com/users/worikgh/orgs","repos_url":"https://api.github.com/users/worikgh/repos","events_url":"https://api.github.com/users/worikgh/events{/privacy}","received_events_url":"https://api.github.com/users/worikgh/received_events","type":"User","site_admin":false},"body":"The documentation as it stands is not clear enough for a complete novice.\r\nI am not quite a complete novice so I decoded it.  But 12 weeks ago it would have stumped me\r\nMy style will not be right, I have not learnt well enough the documentation style, but I think I have made my point\r\n\r\nThanks for contributing, you're awesome! :star:\r\nPlease describe expected and observed behaviour, and what you're fixing.\r\nFor visual fixes, please include tested browsers and screenshots.\r\nSearch for related existing issues and link to them if possible.\r\nPlease read https://docs.silverstripe.org/en/contributing/code/","created_at":"2018-02-27T20:48:15Z","updated_at":"2018-02-27T20:51:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c67c26658a50fb270251ae466aae8b1961374ed8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/7897/commits","review_comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/7897/comments","review_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/7897/comments","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/acdc0a9a5a73566301d5c3c854a6dd884431abf2","head":{"label":"worikgh:patch-2","ref":"patch-2","sha":"acdc0a9a5a73566301d5c3c854a6dd884431abf2","user":{"login":"worikgh","id":5387413,"avatar_url":"https://avatars1.githubusercontent.com/u/5387413?v=4","gravatar_id":"","url":"https://api.github.com/users/worikgh","html_url":"https://github.com/worikgh","followers_url":"https://api.github.com/users/worikgh/followers","following_url":"https://api.github.com/users/worikgh/following{/other_user}","gists_url":"https://api.github.com/users/worikgh/gists{/gist_id}","starred_url":"https://api.github.com/users/worikgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worikgh/subscriptions","organizations_url":"https://api.github.com/users/worikgh/orgs","repos_url":"https://api.github.com/users/worikgh/repos","events_url":"https://api.github.com/users/worikgh/events{/privacy}","received_events_url":"https://api.github.com/users/worikgh/received_events","type":"User","site_admin":false},"repo":{"id":114054062,"name":"silverstripe-framework","full_name":"worikgh/silverstripe-framework","owner":{"login":"worikgh","id":5387413,"avatar_url":"https://avatars1.githubusercontent.com/u/5387413?v=4","gravatar_id":"","url":"https://api.github.com/users/worikgh","html_url":"https://github.com/worikgh","followers_url":"https://api.github.com/users/worikgh/followers","following_url":"https://api.github.com/users/worikgh/following{/other_user}","gists_url":"https://api.github.com/users/worikgh/gists{/gist_id}","starred_url":"https://api.github.com/users/worikgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/worikgh/subscriptions","organizations_url":"https://api.github.com/users/worikgh/orgs","repos_url":"https://api.github.com/users/worikgh/repos","events_url":"https://api.github.com/users/worikgh/events{/privacy}","received_events_url":"https://api.github.com/users/worikgh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/worikgh/silverstripe-framework","description":"SilverStripe Framework, the MVC framework that powers SilverStripe CMS","fork":true,"url":"https://api.github.com/repos/worikgh/silverstripe-framework","forks_url":"https://api.github.com/repos/worikgh/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/worikgh/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/worikgh/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/worikgh/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/worikgh/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/worikgh/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/worikgh/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/worikgh/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/worikgh/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/worikgh/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/worikgh/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/worikgh/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/worikgh/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/worikgh/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/worikgh/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/worikgh/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/worikgh/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/worikgh/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/worikgh/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/worikgh/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/worikgh/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/worikgh/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/worikgh/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/worikgh/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/worikgh/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/worikgh/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/worikgh/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/worikgh/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/worikgh/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/worikgh/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/worikgh/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/worikgh/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/worikgh/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/worikgh/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/worikgh/silverstripe-framework/releases{/id}","deployments_url":"https://api.github.com/repos/worikgh/silverstripe-framework/deployments","created_at":"2017-12-13T00:32:52Z","updated_at":"2017-12-13T00:32:58Z","pushed_at":"2018-02-27T20:47:58Z","git_url":"git://github.com/worikgh/silverstripe-framework.git","ssh_url":"git@github.com:worikgh/silverstripe-framework.git","clone_url":"https://github.com/worikgh/silverstripe-framework.git","svn_url":"https://github.com/worikgh/silverstripe-framework","homepage":"http://silverstripe.org/","size":98361,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"4.0"}},"base":{"label":"silverstripe:4","ref":"4","sha":"32da1f575896689abc65bda6c3962c02263774f8","user":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars0.githubusercontent.com/u/379348?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":1318892,"name":"silverstripe-framework","full_name":"silverstripe/silverstripe-framework","owner":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars0.githubusercontent.com/u/379348?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripe/silverstripe-framework","description":"SilverStripe Framework, the MVC framework that powers SilverStripe CMS","fork":false,"url":"https://api.github.com/repos/silverstripe/silverstripe-framework","forks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/releases{/id}","deployments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/deployments","created_at":"2011-02-02T02:04:13Z","updated_at":"2018-02-27T19:52:21Z","pushed_at":"2018-02-27T20:48:16Z","git_url":"git://github.com/silverstripe/silverstripe-framework.git","ssh_url":"git@github.com:silverstripe/silverstripe-framework.git","clone_url":"https://github.com/silverstripe/silverstripe-framework.git","svn_url":"https://github.com/silverstripe/silverstripe-framework","homepage":"http://silverstripe.org/","size":98919,"stargazers_count":591,"watchers_count":591,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":688,"mirror_url":null,"archived":false,"open_issues_count":492,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":688,"open_issues":492,"watchers":591,"default_branch":"4.0"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/7897"},"html":{"href":"https://github.com/silverstripe/silverstripe-framework/pull/7897"},"issue":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/7897"},"comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/7897/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/7897/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/7897/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/acdc0a9a5a73566301d5c3c854a6dd884431abf2"}},"author_association":"NONE"}}
{"actor":{"display_login":"robbieaverill"}}