{"action":"created","issue":{"url":"https://api.github.com/repos/justeat/JustSaying/issues/380","repository_url":"https://api.github.com/repos/justeat/JustSaying","labels_url":"https://api.github.com/repos/justeat/JustSaying/issues/380/labels{/name}","comments_url":"https://api.github.com/repos/justeat/JustSaying/issues/380/comments","events_url":"https://api.github.com/repos/justeat/JustSaying/issues/380/events","html_url":"https://github.com/justeat/JustSaying/issues/380","id":351834039,"node_id":"MDU6SXNzdWUzNTE4MzQwMzk=","number":380,"title":"Stop using JustBehave","user":{"login":"martincostello","id":1439341,"node_id":"MDQ6VXNlcjE0MzkzNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1439341?v=4","gravatar_id":"","url":"https://api.github.com/users/martincostello","html_url":"https://github.com/martincostello","followers_url":"https://api.github.com/users/martincostello/followers","following_url":"https://api.github.com/users/martincostello/following{/other_user}","gists_url":"https://api.github.com/users/martincostello/gists{/gist_id}","starred_url":"https://api.github.com/users/martincostello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martincostello/subscriptions","organizations_url":"https://api.github.com/users/martincostello/orgs","repos_url":"https://api.github.com/users/martincostello/repos","events_url":"https://api.github.com/users/martincostello/events{/privacy}","received_events_url":"https://api.github.com/users/martincostello/received_events","type":"User","site_admin":false},"labels":[{"id":90921240,"node_id":"MDU6TGFiZWw5MDkyMTI0MA==","url":"https://api.github.com/repos/justeat/JustSaying/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/justeat/JustSaying/milestones/2","html_url":"https://github.com/justeat/JustSaying/milestone/2","labels_url":"https://api.github.com/repos/justeat/JustSaying/milestones/2/labels","id":3560855,"node_id":"MDk6TWlsZXN0b25lMzU2MDg1NQ==","number":2,"title":"v7.0.0","description":"JustSaying v7.0.0.","creator":{"login":"martincostello","id":1439341,"node_id":"MDQ6VXNlcjE0MzkzNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1439341?v=4","gravatar_id":"","url":"https://api.github.com/users/martincostello","html_url":"https://github.com/martincostello","followers_url":"https://api.github.com/users/martincostello/followers","following_url":"https://api.github.com/users/martincostello/following{/other_user}","gists_url":"https://api.github.com/users/martincostello/gists{/gist_id}","starred_url":"https://api.github.com/users/martincostello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martincostello/subscriptions","organizations_url":"https://api.github.com/users/martincostello/orgs","repos_url":"https://api.github.com/users/martincostello/repos","events_url":"https://api.github.com/users/martincostello/events{/privacy}","received_events_url":"https://api.github.com/users/martincostello/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":18,"state":"open","created_at":"2018-08-10T13:20:55Z","updated_at":"2018-11-06T13:46:39Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2018-08-18T16:38:35Z","updated_at":"2018-11-07T11:45:35Z","closed_at":null,"author_association":"MEMBER","body":"As part of the investigation for #159 I've found that there's _a lot_ of use of `Task.GetAwaiter().GetResult()` and `Task.Wait()` to work around limitations with JustBehave's design of running test setup and teardown steps on synchronous code paths for constructors and disposal.\r\n\r\nJustSaying is heavily asynchronous now, so this just profligates poor async usage throughout the tests.\r\n\r\nI also think it is also causing deadlocks when I try and run them locally en-masse using the Visual Studio test runner with a local AWS simulator. This is a hunch, but it mainly comes from the fact that if I run all the tests they seem to get stuck, but if I run tests individually they pass.\r\n\r\nThe pattern of calling derived methods from constructors in JustBehave also prevents `ITestOutputHelper` (and other things) from being injected into the tests and being used as part of the test setup as the class' own constructor logic runs after the overridden classes, meaning any fields don't have their values set yet.\r\n\r\nI'm happy to do the work to refactor this out of the integration test project myself as part of #159 if we agree that it's a necessary step to move the test suite forward.\r\n\r\nI think the time has come to put it out to pasture for JustSaying and adopt a more conventional and xunit-friendly test style using fixtures."},"comment":{"url":"https://api.github.com/repos/justeat/JustSaying/issues/comments/436597587","html_url":"https://github.com/justeat/JustSaying/issues/380#issuecomment-436597587","issue_url":"https://api.github.com/repos/justeat/JustSaying/issues/380","id":436597587,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjU5NzU4Nw==","user":{"login":"shaynevanasperen","id":1126129,"node_id":"MDQ6VXNlcjExMjYxMjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1126129?v=4","gravatar_id":"","url":"https://api.github.com/users/shaynevanasperen","html_url":"https://github.com/shaynevanasperen","followers_url":"https://api.github.com/users/shaynevanasperen/followers","following_url":"https://api.github.com/users/shaynevanasperen/following{/other_user}","gists_url":"https://api.github.com/users/shaynevanasperen/gists{/gist_id}","starred_url":"https://api.github.com/users/shaynevanasperen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaynevanasperen/subscriptions","organizations_url":"https://api.github.com/users/shaynevanasperen/orgs","repos_url":"https://api.github.com/users/shaynevanasperen/repos","events_url":"https://api.github.com/users/shaynevanasperen/events{/privacy}","received_events_url":"https://api.github.com/users/shaynevanasperen/received_events","type":"User","site_admin":false},"created_at":"2018-11-07T11:45:35Z","updated_at":"2018-11-07T11:45:35Z","author_association":"MEMBER","body":"@slang25 Because of `InternalsVisibleTo`"}}
{"actor":{"display_login":"shaynevanasperen"}}