{"action":"created","issue":{"url":"https://api.github.com/repos/dequelabs/axe-core/issues/820","repository_url":"https://api.github.com/repos/dequelabs/axe-core","labels_url":"https://api.github.com/repos/dequelabs/axe-core/issues/820/labels{/name}","comments_url":"https://api.github.com/repos/dequelabs/axe-core/issues/820/comments","events_url":"https://api.github.com/repos/dequelabs/axe-core/issues/820/events","html_url":"https://github.com/dequelabs/axe-core/pull/820","id":310659819,"number":820,"title":"fix(rule): disallow select options for accessible naming","user":{"login":"marcysutton","id":1045233,"avatar_url":"https://avatars0.githubusercontent.com/u/1045233?v=4","gravatar_id":"","url":"https://api.github.com/users/marcysutton","html_url":"https://github.com/marcysutton","followers_url":"https://api.github.com/users/marcysutton/followers","following_url":"https://api.github.com/users/marcysutton/following{/other_user}","gists_url":"https://api.github.com/users/marcysutton/gists{/gist_id}","starred_url":"https://api.github.com/users/marcysutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcysutton/subscriptions","organizations_url":"https://api.github.com/users/marcysutton/orgs","repos_url":"https://api.github.com/users/marcysutton/repos","events_url":"https://api.github.com/users/marcysutton/events{/privacy}","received_events_url":"https://api.github.com/users/marcysutton/received_events","type":"User","site_admin":false},"labels":[{"id":674170321,"url":"https://api.github.com/repos/dequelabs/axe-core/labels/Support","name":"Support","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-04-03T01:10:20Z","updated_at":"2018-05-18T23:12:26Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/dequelabs/axe-core/pulls/820","html_url":"https://github.com/dequelabs/axe-core/pull/820","diff_url":"https://github.com/dequelabs/axe-core/pull/820.diff","patch_url":"https://github.com/dequelabs/axe-core/pull/820.patch"},"body":"This change impacts our interpretation of the accessible name computation algorithm, specifically disallowing `select` labels from steps 2E and 2F. Select option values are still used when referenced by `aria-labelledby`.\r\n\r\nCloses https://github.com/dequelabs/axe-core/issues/754"},"comment":{"url":"https://api.github.com/repos/dequelabs/axe-core/issues/comments/390355459","html_url":"https://github.com/dequelabs/axe-core/pull/820#issuecomment-390355459","issue_url":"https://api.github.com/repos/dequelabs/axe-core/issues/820","id":390355459,"user":{"login":"marcysutton","id":1045233,"avatar_url":"https://avatars0.githubusercontent.com/u/1045233?v=4","gravatar_id":"","url":"https://api.github.com/users/marcysutton","html_url":"https://github.com/marcysutton","followers_url":"https://api.github.com/users/marcysutton/followers","following_url":"https://api.github.com/users/marcysutton/following{/other_user}","gists_url":"https://api.github.com/users/marcysutton/gists{/gist_id}","starred_url":"https://api.github.com/users/marcysutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcysutton/subscriptions","organizations_url":"https://api.github.com/users/marcysutton/orgs","repos_url":"https://api.github.com/users/marcysutton/repos","events_url":"https://api.github.com/users/marcysutton/events{/privacy}","received_events_url":"https://api.github.com/users/marcysutton/received_events","type":"User","site_admin":false},"created_at":"2018-05-18T23:12:26Z","updated_at":"2018-05-18T23:12:26Z","author_association":"MEMBER","body":"There are examples in this Codepen: https://codepen.io/marcysutton/pen/jxwOaB?editors=1000\r\n\r\nI still feel the code in this PR is sufficient. In general the aria-labelledby cases work okay, but native input labeling by reference to a select does not. This PR already covers those two cases. "}}
{"actor":{"display_login":"marcysutton"}}