{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/go-ethereum/issues/17178","repository_url":"https://api.github.com/repos/ethereum/go-ethereum","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/17178/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/17178/comments","events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/17178/events","html_url":"https://github.com/ethereum/go-ethereum/pull/17178","id":341325641,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNTAxMDUz","number":17178,"title":"core: check txn length when building a transaction set","user":{"login":"jmank88","id":1194128,"node_id":"MDQ6VXNlcjExOTQxMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/1194128?v=4","gravatar_id":"","url":"https://api.github.com/users/jmank88","html_url":"https://github.com/jmank88","followers_url":"https://api.github.com/users/jmank88/followers","following_url":"https://api.github.com/users/jmank88/following{/other_user}","gists_url":"https://api.github.com/users/jmank88/gists{/gist_id}","starred_url":"https://api.github.com/users/jmank88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmank88/subscriptions","organizations_url":"https://api.github.com/users/jmank88/orgs","repos_url":"https://api.github.com/users/jmank88/repos","events_url":"https://api.github.com/users/jmank88/events{/privacy}","received_events_url":"https://api.github.com/users/jmank88/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-07-15T14:35:02Z","updated_at":"2018-07-27T09:22:37Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ethereum/go-ethereum/pulls/17178","html_url":"https://github.com/ethereum/go-ethereum/pull/17178","diff_url":"https://github.com/ethereum/go-ethereum/pull/17178.diff","patch_url":"https://github.com/ethereum/go-ethereum/pull/17178.patch"},"body":"This PR proposes a length check to prevent an `index out of range` panic when building `NewTransactionsByPriceAndNonce`. Perhaps empty slice values are actually 'bad data' which shouldn't have been in the input map in the first place, but this check is cheap.\r\n\r\n```\r\npanic: runtime error: index out of range\r\n\r\ngoroutine 105 [running]:\r\ngithub.com/ethereum/go-ethereum/core/types.NewTransactionsByPriceAndNonce(0x10cd7e0, 0xc4214605a0, 0xc422d00f90, 0x0)\r\n\t/go-ethereum/build/_workspace/src/github.com/ethereum/go-ethereum/core/types/transaction.go:334 +0x4ec\r\ngithub.com/ethereum/go-ethereum/miner.(*worker).commitNewWork(0xc4202534a0)\r\n\t/go-ethereum/build/_workspace/src/github.com/ethereum/go-ethereum/miner/worker.go:454 +0x9dc\r\ngithub.com/ethereum/go-ethereum/miner.(*worker).update(0xc4202534a0)\r\n\t/go-ethereum/build/_workspace/src/github.com/ethereum/go-ethereum/miner/worker.go:254 +0x781\r\ncreated by github.com/ethereum/go-ethereum/miner.newWorker\r\n\t/go-ethereum/build/_workspace/src/github.com/ethereum/go-ethereum/miner/worker.go:158 +0x4ae\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments/408363734","html_url":"https://github.com/ethereum/go-ethereum/pull/17178#issuecomment-408363734","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/17178","id":408363734,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODM2MzczNA==","user":{"login":"sunanxiang","id":18612826,"node_id":"MDQ6VXNlcjE4NjEyODI2","avatar_url":"https://avatars3.githubusercontent.com/u/18612826?v=4","gravatar_id":"","url":"https://api.github.com/users/sunanxiang","html_url":"https://github.com/sunanxiang","followers_url":"https://api.github.com/users/sunanxiang/followers","following_url":"https://api.github.com/users/sunanxiang/following{/other_user}","gists_url":"https://api.github.com/users/sunanxiang/gists{/gist_id}","starred_url":"https://api.github.com/users/sunanxiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunanxiang/subscriptions","organizations_url":"https://api.github.com/users/sunanxiang/orgs","repos_url":"https://api.github.com/users/sunanxiang/repos","events_url":"https://api.github.com/users/sunanxiang/events{/privacy}","received_events_url":"https://api.github.com/users/sunanxiang/received_events","type":"User","site_admin":false},"created_at":"2018-07-27T09:22:37Z","updated_at":"2018-07-27T09:22:37Z","author_association":"NONE","body":"Has this problem been solved? I also have this problem. @jmank88 "}}
{"actor":{"display_login":"sunanxiang"}}