{"action":"created","comment":{"url":"https://api.github.com/repos/OutWatch/outwatch/pulls/comments/204871445","pull_request_review_id":140030531,"id":204871445,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDg3MTQ0NQ==","diff_hunk":"@@ -42,18 +41,21 @@ class Storage(domStorage: dom.Storage) {\n         None\n     }\n \n-  def handlerWithoutEvents(key: String)(implicit scheduler: Scheduler): IO[Handler[Option[String]]] = {\n-    handlerWithTransform(key, identity)\n+  def subjectWithoutEvents(key: String)(implicit scheduler: Scheduler): IO[Subject[Option[String], Option[String]]] = {\n+    subjectWithTransform(key, identity)\n   }\n \n-  def handlerWithEventsOnly(key: String)(implicit scheduler: Scheduler): IO[Handler[Option[String]]] = {","path":"src/main/scala/outwatch/util/LocalStorage.scala","position":47,"original_position":47,"commit_id":"0d101697860a93857de2adbca308ecc7ae2c75a0","original_commit_id":"0d101697860a93857de2adbca308ecc7ae2c75a0","user":{"login":"cornerman","id":1043127,"node_id":"MDQ6VXNlcjEwNDMxMjc=","avatar_url":"https://avatars3.githubusercontent.com/u/1043127?v=4","gravatar_id":"","url":"https://api.github.com/users/cornerman","html_url":"https://github.com/cornerman","followers_url":"https://api.github.com/users/cornerman/followers","following_url":"https://api.github.com/users/cornerman/following{/other_user}","gists_url":"https://api.github.com/users/cornerman/gists{/gist_id}","starred_url":"https://api.github.com/users/cornerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cornerman/subscriptions","organizations_url":"https://api.github.com/users/cornerman/orgs","repos_url":"https://api.github.com/users/cornerman/repos","events_url":"https://api.github.com/users/cornerman/events{/privacy}","received_events_url":"https://api.github.com/users/cornerman/received_events","type":"User","site_admin":false},"body":"deprecated handlerWithEventsOnly","created_at":"2018-07-24T18:50:06Z","updated_at":"2018-07-24T18:50:06Z","html_url":"https://github.com/OutWatch/outwatch/pull/203#discussion_r204871445","pull_request_url":"https://api.github.com/repos/OutWatch/outwatch/pulls/203","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/OutWatch/outwatch/pulls/comments/204871445"},"html":{"href":"https://github.com/OutWatch/outwatch/pull/203#discussion_r204871445"},"pull_request":{"href":"https://api.github.com/repos/OutWatch/outwatch/pulls/203"}}},"pull_request":{"url":"https://api.github.com/repos/OutWatch/outwatch/pulls/203","id":201040379,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMDQwMzc5","html_url":"https://github.com/OutWatch/outwatch/pull/203","diff_url":"https://github.com/OutWatch/outwatch/pull/203.diff","patch_url":"https://github.com/OutWatch/outwatch/pull/203.patch","issue_url":"https://api.github.com/repos/OutWatch/outwatch/issues/203","number":203,"state":"open","locked":false,"title":"WIP: Remove Sink and Handler","user":{"login":"fdietze","id":1186516,"node_id":"MDQ6VXNlcjExODY1MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1186516?v=4","gravatar_id":"","url":"https://api.github.com/users/fdietze","html_url":"https://github.com/fdietze","followers_url":"https://api.github.com/users/fdietze/followers","following_url":"https://api.github.com/users/fdietze/following{/other_user}","gists_url":"https://api.github.com/users/fdietze/gists{/gist_id}","starred_url":"https://api.github.com/users/fdietze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdietze/subscriptions","organizations_url":"https://api.github.com/users/fdietze/orgs","repos_url":"https://api.github.com/users/fdietze/repos","events_url":"https://api.github.com/users/fdietze/events{/privacy}","received_events_url":"https://api.github.com/users/fdietze/received_events","type":"User","site_admin":false},"body":"In our code base we recognized that we are working\r\n a lot with `Observable` and `Observer`/`Subject` from Monix. It is cumbersome to always wrap these in `Handler` and `Sink` just to use them with outwatch.\r\n\r\nI think many people already know the Monix Api and should not need to learn a new one with the same functionality.\r\n\r\nWhat do you think?\r\n\r\nPlease provide feedback especially for `MonixOps`: https://github.com/OutWatch/outwatch/pull/203/files#diff-99d5d9668fb74825f242be5dccf96340","created_at":"2018-07-12T15:28:50Z","updated_at":"2018-07-24T18:50:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd73cc1d7693386fb68e6e15b7b22ad22a224462","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OutWatch/outwatch/pulls/203/commits","review_comments_url":"https://api.github.com/repos/OutWatch/outwatch/pulls/203/comments","review_comment_url":"https://api.github.com/repos/OutWatch/outwatch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OutWatch/outwatch/issues/203/comments","statuses_url":"https://api.github.com/repos/OutWatch/outwatch/statuses/0d101697860a93857de2adbca308ecc7ae2c75a0","head":{"label":"OutWatch:remove-sink","ref":"remove-sink","sha":"0d101697860a93857de2adbca308ecc7ae2c75a0","user":{"login":"OutWatch","id":20708480,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzA4NDgw","avatar_url":"https://avatars1.githubusercontent.com/u/20708480?v=4","gravatar_id":"","url":"https://api.github.com/users/OutWatch","html_url":"https://github.com/OutWatch","followers_url":"https://api.github.com/users/OutWatch/followers","following_url":"https://api.github.com/users/OutWatch/following{/other_user}","gists_url":"https://api.github.com/users/OutWatch/gists{/gist_id}","starred_url":"https://api.github.com/users/OutWatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OutWatch/subscriptions","organizations_url":"https://api.github.com/users/OutWatch/orgs","repos_url":"https://api.github.com/users/OutWatch/repos","events_url":"https://api.github.com/users/OutWatch/events{/privacy}","received_events_url":"https://api.github.com/users/OutWatch/received_events","type":"Organization","site_admin":false},"repo":{"id":72870054,"node_id":"MDEwOlJlcG9zaXRvcnk3Mjg3MDA1NA==","name":"outwatch","full_name":"OutWatch/outwatch","owner":{"login":"OutWatch","id":20708480,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzA4NDgw","avatar_url":"https://avatars1.githubusercontent.com/u/20708480?v=4","gravatar_id":"","url":"https://api.github.com/users/OutWatch","html_url":"https://github.com/OutWatch","followers_url":"https://api.github.com/users/OutWatch/followers","following_url":"https://api.github.com/users/OutWatch/following{/other_user}","gists_url":"https://api.github.com/users/OutWatch/gists{/gist_id}","starred_url":"https://api.github.com/users/OutWatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OutWatch/subscriptions","organizations_url":"https://api.github.com/users/OutWatch/orgs","repos_url":"https://api.github.com/users/OutWatch/repos","events_url":"https://api.github.com/users/OutWatch/events{/privacy}","received_events_url":"https://api.github.com/users/OutWatch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OutWatch/outwatch","description":"A purely functional and reactive UI framework based on Monix and VirtualDom","fork":false,"url":"https://api.github.com/repos/OutWatch/outwatch","forks_url":"https://api.github.com/repos/OutWatch/outwatch/forks","keys_url":"https://api.github.com/repos/OutWatch/outwatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OutWatch/outwatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OutWatch/outwatch/teams","hooks_url":"https://api.github.com/repos/OutWatch/outwatch/hooks","issue_events_url":"https://api.github.com/repos/OutWatch/outwatch/issues/events{/number}","events_url":"https://api.github.com/repos/OutWatch/outwatch/events","assignees_url":"https://api.github.com/repos/OutWatch/outwatch/assignees{/user}","branches_url":"https://api.github.com/repos/OutWatch/outwatch/branches{/branch}","tags_url":"https://api.github.com/repos/OutWatch/outwatch/tags","blobs_url":"https://api.github.com/repos/OutWatch/outwatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OutWatch/outwatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OutWatch/outwatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/OutWatch/outwatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OutWatch/outwatch/statuses/{sha}","languages_url":"https://api.github.com/repos/OutWatch/outwatch/languages","stargazers_url":"https://api.github.com/repos/OutWatch/outwatch/stargazers","contributors_url":"https://api.github.com/repos/OutWatch/outwatch/contributors","subscribers_url":"https://api.github.com/repos/OutWatch/outwatch/subscribers","subscription_url":"https://api.github.com/repos/OutWatch/outwatch/subscription","commits_url":"https://api.github.com/repos/OutWatch/outwatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/OutWatch/outwatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/OutWatch/outwatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/OutWatch/outwatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/OutWatch/outwatch/contents/{+path}","compare_url":"https://api.github.com/repos/OutWatch/outwatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OutWatch/outwatch/merges","archive_url":"https://api.github.com/repos/OutWatch/outwatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OutWatch/outwatch/downloads","issues_url":"https://api.github.com/repos/OutWatch/outwatch/issues{/number}","pulls_url":"https://api.github.com/repos/OutWatch/outwatch/pulls{/number}","milestones_url":"https://api.github.com/repos/OutWatch/outwatch/milestones{/number}","notifications_url":"https://api.github.com/repos/OutWatch/outwatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OutWatch/outwatch/labels{/name}","releases_url":"https://api.github.com/repos/OutWatch/outwatch/releases{/id}","deployments_url":"https://api.github.com/repos/OutWatch/outwatch/deployments","created_at":"2016-11-04T17:26:16Z","updated_at":"2018-07-24T13:29:08Z","pushed_at":"2018-07-24T14:36:25Z","git_url":"git://github.com/OutWatch/outwatch.git","ssh_url":"git@github.com:OutWatch/outwatch.git","clone_url":"https://github.com/OutWatch/outwatch.git","svn_url":"https://github.com/OutWatch/outwatch","homepage":"http://outwatch.github.io","size":617,"stargazers_count":224,"watchers_count":224,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":29,"watchers":224,"default_branch":"master"}},"base":{"label":"OutWatch:master","ref":"master","sha":"b6e6d8600686c0e1af729ae42d30d885cb3bd049","user":{"login":"OutWatch","id":20708480,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzA4NDgw","avatar_url":"https://avatars1.githubusercontent.com/u/20708480?v=4","gravatar_id":"","url":"https://api.github.com/users/OutWatch","html_url":"https://github.com/OutWatch","followers_url":"https://api.github.com/users/OutWatch/followers","following_url":"https://api.github.com/users/OutWatch/following{/other_user}","gists_url":"https://api.github.com/users/OutWatch/gists{/gist_id}","starred_url":"https://api.github.com/users/OutWatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OutWatch/subscriptions","organizations_url":"https://api.github.com/users/OutWatch/orgs","repos_url":"https://api.github.com/users/OutWatch/repos","events_url":"https://api.github.com/users/OutWatch/events{/privacy}","received_events_url":"https://api.github.com/users/OutWatch/received_events","type":"Organization","site_admin":false},"repo":{"id":72870054,"node_id":"MDEwOlJlcG9zaXRvcnk3Mjg3MDA1NA==","name":"outwatch","full_name":"OutWatch/outwatch","owner":{"login":"OutWatch","id":20708480,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzA4NDgw","avatar_url":"https://avatars1.githubusercontent.com/u/20708480?v=4","gravatar_id":"","url":"https://api.github.com/users/OutWatch","html_url":"https://github.com/OutWatch","followers_url":"https://api.github.com/users/OutWatch/followers","following_url":"https://api.github.com/users/OutWatch/following{/other_user}","gists_url":"https://api.github.com/users/OutWatch/gists{/gist_id}","starred_url":"https://api.github.com/users/OutWatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OutWatch/subscriptions","organizations_url":"https://api.github.com/users/OutWatch/orgs","repos_url":"https://api.github.com/users/OutWatch/repos","events_url":"https://api.github.com/users/OutWatch/events{/privacy}","received_events_url":"https://api.github.com/users/OutWatch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OutWatch/outwatch","description":"A purely functional and reactive UI framework based on Monix and VirtualDom","fork":false,"url":"https://api.github.com/repos/OutWatch/outwatch","forks_url":"https://api.github.com/repos/OutWatch/outwatch/forks","keys_url":"https://api.github.com/repos/OutWatch/outwatch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OutWatch/outwatch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OutWatch/outwatch/teams","hooks_url":"https://api.github.com/repos/OutWatch/outwatch/hooks","issue_events_url":"https://api.github.com/repos/OutWatch/outwatch/issues/events{/number}","events_url":"https://api.github.com/repos/OutWatch/outwatch/events","assignees_url":"https://api.github.com/repos/OutWatch/outwatch/assignees{/user}","branches_url":"https://api.github.com/repos/OutWatch/outwatch/branches{/branch}","tags_url":"https://api.github.com/repos/OutWatch/outwatch/tags","blobs_url":"https://api.github.com/repos/OutWatch/outwatch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OutWatch/outwatch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OutWatch/outwatch/git/refs{/sha}","trees_url":"https://api.github.com/repos/OutWatch/outwatch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OutWatch/outwatch/statuses/{sha}","languages_url":"https://api.github.com/repos/OutWatch/outwatch/languages","stargazers_url":"https://api.github.com/repos/OutWatch/outwatch/stargazers","contributors_url":"https://api.github.com/repos/OutWatch/outwatch/contributors","subscribers_url":"https://api.github.com/repos/OutWatch/outwatch/subscribers","subscription_url":"https://api.github.com/repos/OutWatch/outwatch/subscription","commits_url":"https://api.github.com/repos/OutWatch/outwatch/commits{/sha}","git_commits_url":"https://api.github.com/repos/OutWatch/outwatch/git/commits{/sha}","comments_url":"https://api.github.com/repos/OutWatch/outwatch/comments{/number}","issue_comment_url":"https://api.github.com/repos/OutWatch/outwatch/issues/comments{/number}","contents_url":"https://api.github.com/repos/OutWatch/outwatch/contents/{+path}","compare_url":"https://api.github.com/repos/OutWatch/outwatch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OutWatch/outwatch/merges","archive_url":"https://api.github.com/repos/OutWatch/outwatch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OutWatch/outwatch/downloads","issues_url":"https://api.github.com/repos/OutWatch/outwatch/issues{/number}","pulls_url":"https://api.github.com/repos/OutWatch/outwatch/pulls{/number}","milestones_url":"https://api.github.com/repos/OutWatch/outwatch/milestones{/number}","notifications_url":"https://api.github.com/repos/OutWatch/outwatch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OutWatch/outwatch/labels{/name}","releases_url":"https://api.github.com/repos/OutWatch/outwatch/releases{/id}","deployments_url":"https://api.github.com/repos/OutWatch/outwatch/deployments","created_at":"2016-11-04T17:26:16Z","updated_at":"2018-07-24T13:29:08Z","pushed_at":"2018-07-24T14:36:25Z","git_url":"git://github.com/OutWatch/outwatch.git","ssh_url":"git@github.com:OutWatch/outwatch.git","clone_url":"https://github.com/OutWatch/outwatch.git","svn_url":"https://github.com/OutWatch/outwatch","homepage":"http://outwatch.github.io","size":617,"stargazers_count":224,"watchers_count":224,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":29,"watchers":224,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OutWatch/outwatch/pulls/203"},"html":{"href":"https://github.com/OutWatch/outwatch/pull/203"},"issue":{"href":"https://api.github.com/repos/OutWatch/outwatch/issues/203"},"comments":{"href":"https://api.github.com/repos/OutWatch/outwatch/issues/203/comments"},"review_comments":{"href":"https://api.github.com/repos/OutWatch/outwatch/pulls/203/comments"},"review_comment":{"href":"https://api.github.com/repos/OutWatch/outwatch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OutWatch/outwatch/pulls/203/commits"},"statuses":{"href":"https://api.github.com/repos/OutWatch/outwatch/statuses/0d101697860a93857de2adbca308ecc7ae2c75a0"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"cornerman"}}