{"action":"created","issue":{"url":"https://api.github.com/repos/superckl/BiomeTweaker/issues/206","repository_url":"https://api.github.com/repos/superckl/BiomeTweaker","labels_url":"https://api.github.com/repos/superckl/BiomeTweaker/issues/206/labels{/name}","comments_url":"https://api.github.com/repos/superckl/BiomeTweaker/issues/206/comments","events_url":"https://api.github.com/repos/superckl/BiomeTweaker/issues/206/events","html_url":"https://github.com/superckl/BiomeTweaker/issues/206","id":353531734,"node_id":"MDU6SXNzdWUzNTM1MzE3MzQ=","number":206,"title":"removeBOP() not working correctly?","user":{"login":"HeroOfChaos","id":19752542,"node_id":"MDQ6VXNlcjE5NzUyNTQy","avatar_url":"https://avatars0.githubusercontent.com/u/19752542?v=4","gravatar_id":"","url":"https://api.github.com/users/HeroOfChaos","html_url":"https://github.com/HeroOfChaos","followers_url":"https://api.github.com/users/HeroOfChaos/followers","following_url":"https://api.github.com/users/HeroOfChaos/following{/other_user}","gists_url":"https://api.github.com/users/HeroOfChaos/gists{/gist_id}","starred_url":"https://api.github.com/users/HeroOfChaos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeroOfChaos/subscriptions","organizations_url":"https://api.github.com/users/HeroOfChaos/orgs","repos_url":"https://api.github.com/users/HeroOfChaos/repos","events_url":"https://api.github.com/users/HeroOfChaos/events{/privacy}","received_events_url":"https://api.github.com/users/HeroOfChaos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-23T20:00:19Z","updated_at":"2018-08-23T20:16:39Z","closed_at":null,"author_association":"NONE","body":"Hi,\r\nI'm using the following script:\r\n```\r\nbamboomarshBiome = forBiomes(111)\r\nbirchautumnBiome = forBiomes(112)\r\nblueoakBiome = forBiomes(113)\r\nbombonaBiome = forBiomes(114)\r\nburoakBiome = forBiomes(115)\r\nemperorridgeBiome = forBiomes(117)\r\nflatlandthicketBiome = forBiomes(116)\r\nsprucemountainBiome = forBiomes(120)\r\nspinyBiome = forBiomes(119)\r\nsilverbirchBiome = forBiomes(118)\r\nallrwBiomes = forBiomes(111, 112, 113, 114, 115, 116, 117, 118, 119, 120)\r\n\r\nallrwBiomes.removeBOP()\r\nbamboomarshBiome.addToGenerationBOP(\"HOT_SWAMP\", 5)\r\nbirchautumnBiome.addToGenerationBOP(\"COOL_TEMPERATE\", 2)\r\nblueoakBiome.addToGenerationBOP(\"WARM_TEMPERATE\", 5)\r\nbombonaBiome.addToGenerationBOP(\"SAVANNA\", 1)\r\nburoakBiome.addToGenerationBOP(\"WARM_TEMPERATE\", 3)\r\nburoakBiome.addToGenerationBOP(\"COOL_TEMPERATE\", 3)\r\nemperorridgeBiome.addToGenerationBOP(\"WARM_TEMPERATE\", 1)\r\nflatlandthicketBiome.addToGenerationBOP(\"COOL_TEMPERATE\", 5)\r\nsilverbirchBiome.addToGenerationBOP(\"BOREAL\", 2)\r\nsilverbirchBiome.addToGenerationBOP(\"COOL_TEMPERATE\", 2)\r\nspinyBiome.addToGenerationBOP(\"HOT_DESERT\", 2)\r\nsprucemountainBiome.addToGenerationBOP(\"BOREAL\", 2)\r\n```\r\nThe idea is that I want to replace the default BOP climate weights for biomes from RealWorld with these custom values. The weights are first deleted via allrwBiomes.removeBOP(), then each biome gets new weights individually.\r\nThe problem is that according to the Output files, sometimes this works correctly, while sometimes the values are not overwritten, but rather added on top of the existing weights. This essentially changes the world generator and thus you get those cut-off chunk biomes in existing worlds (without having actually changed anything in the files yourself which would affect the world generator).\r\nE.g. sometimes I get this, which is correct:\r\n```\r\n\"BOP Climate Weights\": {\r\n    \"WARM_TEMPERATE\": [\r\n      5\r\n    ]\r\n  },\r\n```\r\nBut most of the time I get this, which is wrong:\r\n```\r\n\"BOP Climate Weights\": {\r\n    \"WET_TEMPERATE\": [\r\n      2\r\n    ],\r\n    \"DRY_TEMPERATE\": [\r\n      2\r\n    ],\r\n    \"WARM_TEMPERATE\": [\r\n      2,\r\n      5\r\n    ],\r\n    \"HOT_SWAMP\": [\r\n      2\r\n    ],\r\n    \"MEDITERANEAN\": [\r\n      2\r\n    ]\r\n  },\r\n```\r\nIf you reload the script and regenerate the output files in the in-game Mod config, the new weights are just applied over the existing weights every time (so in this case, the \"5\" in \"WARM_TEMPERATE\" would be added again every time).\r\nUnfortunately, I haven't found a reliable way to get the correct result, it rarely just works, but as I stated above, I usually get the wrong result. Sometimes I have to restart 3 or 4 times before getting the correct result (without doing anything inbetween restarts). And sometimes it seems like I can restart as often as I'd like, I'd always get the wrong result.\r\nThis is rather annoying since you have to check the Output files every time you start the game again and have to restart each time you get the wrong result, otherwise you pretty much screw up your whole world.\r\n\r\nBiomeTweaker Version: 1.12.2 3.2.354\r\nForge Version: 1.12.2-14.23.4.2757"},"comment":{"url":"https://api.github.com/repos/superckl/BiomeTweaker/issues/comments/415557099","html_url":"https://github.com/superckl/BiomeTweaker/issues/206#issuecomment-415557099","issue_url":"https://api.github.com/repos/superckl/BiomeTweaker/issues/206","id":415557099,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTU1NzA5OQ==","user":{"login":"HeroOfChaos","id":19752542,"node_id":"MDQ6VXNlcjE5NzUyNTQy","avatar_url":"https://avatars0.githubusercontent.com/u/19752542?v=4","gravatar_id":"","url":"https://api.github.com/users/HeroOfChaos","html_url":"https://github.com/HeroOfChaos","followers_url":"https://api.github.com/users/HeroOfChaos/followers","following_url":"https://api.github.com/users/HeroOfChaos/following{/other_user}","gists_url":"https://api.github.com/users/HeroOfChaos/gists{/gist_id}","starred_url":"https://api.github.com/users/HeroOfChaos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HeroOfChaos/subscriptions","organizations_url":"https://api.github.com/users/HeroOfChaos/orgs","repos_url":"https://api.github.com/users/HeroOfChaos/repos","events_url":"https://api.github.com/users/HeroOfChaos/events{/privacy}","received_events_url":"https://api.github.com/users/HeroOfChaos/received_events","type":"User","site_admin":false},"created_at":"2018-08-23T20:16:39Z","updated_at":"2018-08-23T20:16:39Z","author_association":"NONE","body":"Just checked them. I found no errors/warnings related to BiomeTweaker. Neither in the normal logs, nor in the debug logs."}}
{"actor":{"display_login":"HeroOfChaos"}}