{"action":"created","comment":{"url":"https://api.github.com/repos/sumup/circuit-ui/pulls/comments/193986475","pull_request_review_id":127073196,"id":193986475,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mzk4NjQ3NQ==","diff_hunk":"@@ -46,12 +46,17 @@ class Popover extends Component {\n     /**\n      * alignment of the popover relative to the button\n      */\n-    align: alignPropType\n+    align: alignPropType,\n+    /**\n+     * onClose callback functin","path":"src/components/Popover/Popover.js","position":7,"original_position":7,"commit_id":"cc8474a1b2cf9b8092b7854edc6e3ee332b68a51","original_commit_id":"cc8474a1b2cf9b8092b7854edc6e3ee332b68a51","user":{"login":"connor-baer","id":11017722,"node_id":"MDQ6VXNlcjExMDE3NzIy","avatar_url":"https://avatars0.githubusercontent.com/u/11017722?v=4","gravatar_id":"","url":"https://api.github.com/users/connor-baer","html_url":"https://github.com/connor-baer","followers_url":"https://api.github.com/users/connor-baer/followers","following_url":"https://api.github.com/users/connor-baer/following{/other_user}","gists_url":"https://api.github.com/users/connor-baer/gists{/gist_id}","starred_url":"https://api.github.com/users/connor-baer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connor-baer/subscriptions","organizations_url":"https://api.github.com/users/connor-baer/orgs","repos_url":"https://api.github.com/users/connor-baer/repos","events_url":"https://api.github.com/users/connor-baer/events{/privacy}","received_events_url":"https://api.github.com/users/connor-baer/received_events","type":"User","site_admin":false},"body":"You have a typo here (`function`) 😉\r\nCould you make this more descriptive, please? Something like: `A function that is called when the Popover is closed\"","created_at":"2018-06-08T08:27:36Z","updated_at":"2018-06-08T08:29:08Z","html_url":"https://github.com/sumup/circuit-ui/pull/193#discussion_r193986475","pull_request_url":"https://api.github.com/repos/sumup/circuit-ui/pulls/193","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sumup/circuit-ui/pulls/comments/193986475"},"html":{"href":"https://github.com/sumup/circuit-ui/pull/193#discussion_r193986475"},"pull_request":{"href":"https://api.github.com/repos/sumup/circuit-ui/pulls/193"}}},"pull_request":{"url":"https://api.github.com/repos/sumup/circuit-ui/pulls/193","id":193481475,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNDgxNDc1","html_url":"https://github.com/sumup/circuit-ui/pull/193","diff_url":"https://github.com/sumup/circuit-ui/pull/193.diff","patch_url":"https://github.com/sumup/circuit-ui/pull/193.patch","issue_url":"https://api.github.com/repos/sumup/circuit-ui/issues/193","number":193,"state":"open","locked":false,"title":"[Popover] Changes","user":{"login":"elanoism","id":2035446,"node_id":"MDQ6VXNlcjIwMzU0NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/2035446?v=4","gravatar_id":"","url":"https://api.github.com/users/elanoism","html_url":"https://github.com/elanoism","followers_url":"https://api.github.com/users/elanoism/followers","following_url":"https://api.github.com/users/elanoism/following{/other_user}","gists_url":"https://api.github.com/users/elanoism/gists{/gist_id}","starred_url":"https://api.github.com/users/elanoism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elanoism/subscriptions","organizations_url":"https://api.github.com/users/elanoism/orgs","repos_url":"https://api.github.com/users/elanoism/repos","events_url":"https://api.github.com/users/elanoism/events{/privacy}","received_events_url":"https://api.github.com/users/elanoism/received_events","type":"User","site_admin":false},"body":"* Add `onClose` event\r\n* Add hierarchy to the story","created_at":"2018-06-08T00:33:00Z","updated_at":"2018-06-08T08:29:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e1fd6292267fbc867e3c53b47f40cad76bfb583","assignee":null,"assignees":[],"requested_reviewers":[{"login":"felixjung","id":265947,"node_id":"MDQ6VXNlcjI2NTk0Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/265947?v=4","gravatar_id":"","url":"https://api.github.com/users/felixjung","html_url":"https://github.com/felixjung","followers_url":"https://api.github.com/users/felixjung/followers","following_url":"https://api.github.com/users/felixjung/following{/other_user}","gists_url":"https://api.github.com/users/felixjung/gists{/gist_id}","starred_url":"https://api.github.com/users/felixjung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixjung/subscriptions","organizations_url":"https://api.github.com/users/felixjung/orgs","repos_url":"https://api.github.com/users/felixjung/repos","events_url":"https://api.github.com/users/felixjung/events{/privacy}","received_events_url":"https://api.github.com/users/felixjung/received_events","type":"User","site_admin":false},{"login":"fernandofleury","id":2780941,"node_id":"MDQ6VXNlcjI3ODA5NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/2780941?v=4","gravatar_id":"","url":"https://api.github.com/users/fernandofleury","html_url":"https://github.com/fernandofleury","followers_url":"https://api.github.com/users/fernandofleury/followers","following_url":"https://api.github.com/users/fernandofleury/following{/other_user}","gists_url":"https://api.github.com/users/fernandofleury/gists{/gist_id}","starred_url":"https://api.github.com/users/fernandofleury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fernandofleury/subscriptions","organizations_url":"https://api.github.com/users/fernandofleury/orgs","repos_url":"https://api.github.com/users/fernandofleury/repos","events_url":"https://api.github.com/users/fernandofleury/events{/privacy}","received_events_url":"https://api.github.com/users/fernandofleury/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sumup/circuit-ui/pulls/193/commits","review_comments_url":"https://api.github.com/repos/sumup/circuit-ui/pulls/193/comments","review_comment_url":"https://api.github.com/repos/sumup/circuit-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sumup/circuit-ui/issues/193/comments","statuses_url":"https://api.github.com/repos/sumup/circuit-ui/statuses/cc8474a1b2cf9b8092b7854edc6e3ee332b68a51","head":{"label":"sumup:tech/popover-changes","ref":"tech/popover-changes","sha":"cc8474a1b2cf9b8092b7854edc6e3ee332b68a51","user":{"login":"sumup","id":1194464,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTQ0NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1194464?v=4","gravatar_id":"","url":"https://api.github.com/users/sumup","html_url":"https://github.com/sumup","followers_url":"https://api.github.com/users/sumup/followers","following_url":"https://api.github.com/users/sumup/following{/other_user}","gists_url":"https://api.github.com/users/sumup/gists{/gist_id}","starred_url":"https://api.github.com/users/sumup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumup/subscriptions","organizations_url":"https://api.github.com/users/sumup/orgs","repos_url":"https://api.github.com/users/sumup/repos","events_url":"https://api.github.com/users/sumup/events{/privacy}","received_events_url":"https://api.github.com/users/sumup/received_events","type":"Organization","site_admin":false},"repo":{"id":95433249,"node_id":"MDEwOlJlcG9zaXRvcnk5NTQzMzI0OQ==","name":"circuit-ui","full_name":"sumup/circuit-ui","owner":{"login":"sumup","id":1194464,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTQ0NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1194464?v=4","gravatar_id":"","url":"https://api.github.com/users/sumup","html_url":"https://github.com/sumup","followers_url":"https://api.github.com/users/sumup/followers","following_url":"https://api.github.com/users/sumup/following{/other_user}","gists_url":"https://api.github.com/users/sumup/gists{/gist_id}","starred_url":"https://api.github.com/users/sumup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumup/subscriptions","organizations_url":"https://api.github.com/users/sumup/orgs","repos_url":"https://api.github.com/users/sumup/repos","events_url":"https://api.github.com/users/sumup/events{/privacy}","received_events_url":"https://api.github.com/users/sumup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sumup/circuit-ui","description":"React component library for sumup web apps","fork":false,"url":"https://api.github.com/repos/sumup/circuit-ui","forks_url":"https://api.github.com/repos/sumup/circuit-ui/forks","keys_url":"https://api.github.com/repos/sumup/circuit-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sumup/circuit-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sumup/circuit-ui/teams","hooks_url":"https://api.github.com/repos/sumup/circuit-ui/hooks","issue_events_url":"https://api.github.com/repos/sumup/circuit-ui/issues/events{/number}","events_url":"https://api.github.com/repos/sumup/circuit-ui/events","assignees_url":"https://api.github.com/repos/sumup/circuit-ui/assignees{/user}","branches_url":"https://api.github.com/repos/sumup/circuit-ui/branches{/branch}","tags_url":"https://api.github.com/repos/sumup/circuit-ui/tags","blobs_url":"https://api.github.com/repos/sumup/circuit-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sumup/circuit-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sumup/circuit-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/sumup/circuit-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sumup/circuit-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/sumup/circuit-ui/languages","stargazers_url":"https://api.github.com/repos/sumup/circuit-ui/stargazers","contributors_url":"https://api.github.com/repos/sumup/circuit-ui/contributors","subscribers_url":"https://api.github.com/repos/sumup/circuit-ui/subscribers","subscription_url":"https://api.github.com/repos/sumup/circuit-ui/subscription","commits_url":"https://api.github.com/repos/sumup/circuit-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/sumup/circuit-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/sumup/circuit-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/sumup/circuit-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/sumup/circuit-ui/contents/{+path}","compare_url":"https://api.github.com/repos/sumup/circuit-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sumup/circuit-ui/merges","archive_url":"https://api.github.com/repos/sumup/circuit-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sumup/circuit-ui/downloads","issues_url":"https://api.github.com/repos/sumup/circuit-ui/issues{/number}","pulls_url":"https://api.github.com/repos/sumup/circuit-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/sumup/circuit-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/sumup/circuit-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sumup/circuit-ui/labels{/name}","releases_url":"https://api.github.com/repos/sumup/circuit-ui/releases{/id}","deployments_url":"https://api.github.com/repos/sumup/circuit-ui/deployments","created_at":"2017-06-26T09:57:50Z","updated_at":"2018-06-08T05:51:14Z","pushed_at":"2018-06-08T00:56:33Z","git_url":"git://github.com/sumup/circuit-ui.git","ssh_url":"git@github.com:sumup/circuit-ui.git","clone_url":"https://github.com/sumup/circuit-ui.git","svn_url":"https://github.com/sumup/circuit-ui","homepage":"https://sumup.github.io/circuit-ui","size":7350,"stargazers_count":60,"watchers_count":60,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":40,"license":null,"forks":8,"open_issues":40,"watchers":60,"default_branch":"master"}},"base":{"label":"sumup:master","ref":"master","sha":"0d71d27bd667bab50acdb3911bec5ba731929f0b","user":{"login":"sumup","id":1194464,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTQ0NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1194464?v=4","gravatar_id":"","url":"https://api.github.com/users/sumup","html_url":"https://github.com/sumup","followers_url":"https://api.github.com/users/sumup/followers","following_url":"https://api.github.com/users/sumup/following{/other_user}","gists_url":"https://api.github.com/users/sumup/gists{/gist_id}","starred_url":"https://api.github.com/users/sumup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumup/subscriptions","organizations_url":"https://api.github.com/users/sumup/orgs","repos_url":"https://api.github.com/users/sumup/repos","events_url":"https://api.github.com/users/sumup/events{/privacy}","received_events_url":"https://api.github.com/users/sumup/received_events","type":"Organization","site_admin":false},"repo":{"id":95433249,"node_id":"MDEwOlJlcG9zaXRvcnk5NTQzMzI0OQ==","name":"circuit-ui","full_name":"sumup/circuit-ui","owner":{"login":"sumup","id":1194464,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTQ0NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1194464?v=4","gravatar_id":"","url":"https://api.github.com/users/sumup","html_url":"https://github.com/sumup","followers_url":"https://api.github.com/users/sumup/followers","following_url":"https://api.github.com/users/sumup/following{/other_user}","gists_url":"https://api.github.com/users/sumup/gists{/gist_id}","starred_url":"https://api.github.com/users/sumup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumup/subscriptions","organizations_url":"https://api.github.com/users/sumup/orgs","repos_url":"https://api.github.com/users/sumup/repos","events_url":"https://api.github.com/users/sumup/events{/privacy}","received_events_url":"https://api.github.com/users/sumup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sumup/circuit-ui","description":"React component library for sumup web apps","fork":false,"url":"https://api.github.com/repos/sumup/circuit-ui","forks_url":"https://api.github.com/repos/sumup/circuit-ui/forks","keys_url":"https://api.github.com/repos/sumup/circuit-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sumup/circuit-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sumup/circuit-ui/teams","hooks_url":"https://api.github.com/repos/sumup/circuit-ui/hooks","issue_events_url":"https://api.github.com/repos/sumup/circuit-ui/issues/events{/number}","events_url":"https://api.github.com/repos/sumup/circuit-ui/events","assignees_url":"https://api.github.com/repos/sumup/circuit-ui/assignees{/user}","branches_url":"https://api.github.com/repos/sumup/circuit-ui/branches{/branch}","tags_url":"https://api.github.com/repos/sumup/circuit-ui/tags","blobs_url":"https://api.github.com/repos/sumup/circuit-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sumup/circuit-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sumup/circuit-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/sumup/circuit-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sumup/circuit-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/sumup/circuit-ui/languages","stargazers_url":"https://api.github.com/repos/sumup/circuit-ui/stargazers","contributors_url":"https://api.github.com/repos/sumup/circuit-ui/contributors","subscribers_url":"https://api.github.com/repos/sumup/circuit-ui/subscribers","subscription_url":"https://api.github.com/repos/sumup/circuit-ui/subscription","commits_url":"https://api.github.com/repos/sumup/circuit-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/sumup/circuit-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/sumup/circuit-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/sumup/circuit-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/sumup/circuit-ui/contents/{+path}","compare_url":"https://api.github.com/repos/sumup/circuit-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sumup/circuit-ui/merges","archive_url":"https://api.github.com/repos/sumup/circuit-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sumup/circuit-ui/downloads","issues_url":"https://api.github.com/repos/sumup/circuit-ui/issues{/number}","pulls_url":"https://api.github.com/repos/sumup/circuit-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/sumup/circuit-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/sumup/circuit-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sumup/circuit-ui/labels{/name}","releases_url":"https://api.github.com/repos/sumup/circuit-ui/releases{/id}","deployments_url":"https://api.github.com/repos/sumup/circuit-ui/deployments","created_at":"2017-06-26T09:57:50Z","updated_at":"2018-06-08T05:51:14Z","pushed_at":"2018-06-08T00:56:33Z","git_url":"git://github.com/sumup/circuit-ui.git","ssh_url":"git@github.com:sumup/circuit-ui.git","clone_url":"https://github.com/sumup/circuit-ui.git","svn_url":"https://github.com/sumup/circuit-ui","homepage":"https://sumup.github.io/circuit-ui","size":7350,"stargazers_count":60,"watchers_count":60,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":40,"license":null,"forks":8,"open_issues":40,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sumup/circuit-ui/pulls/193"},"html":{"href":"https://github.com/sumup/circuit-ui/pull/193"},"issue":{"href":"https://api.github.com/repos/sumup/circuit-ui/issues/193"},"comments":{"href":"https://api.github.com/repos/sumup/circuit-ui/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/sumup/circuit-ui/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/sumup/circuit-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sumup/circuit-ui/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/sumup/circuit-ui/statuses/cc8474a1b2cf9b8092b7854edc6e3ee332b68a51"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"connor-baer"}}