{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/25037","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25037/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25037/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25037/events","html_url":"https://github.com/cms-sw/cmssw/pull/25037","id":375090048,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NjE3Njgz","number":25037,"title":"Prepare for concurrent IOVs, L1ConfigOnlineProdBase","user":{"login":"wddgit","id":4295891,"node_id":"MDQ6VXNlcjQyOTU4OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/4295891?v=4","gravatar_id":"","url":"https://api.github.com/users/wddgit","html_url":"https://github.com/wddgit","followers_url":"https://api.github.com/users/wddgit/followers","following_url":"https://api.github.com/users/wddgit/following{/other_user}","gists_url":"https://api.github.com/users/wddgit/gists{/gist_id}","starred_url":"https://api.github.com/users/wddgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wddgit/subscriptions","organizations_url":"https://api.github.com/users/wddgit/orgs","repos_url":"https://api.github.com/users/wddgit/repos","events_url":"https://api.github.com/users/wddgit/events{/privacy}","received_events_url":"https://api.github.com/users/wddgit/received_events","type":"User","site_admin":false},"labels":[{"id":52881463,"node_id":"MDU6TGFiZWw1Mjg4MTQ2Mw==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/alca-pending","name":"alca-pending","color":"fbca04","default":false},{"id":673935056,"node_id":"MDU6TGFiZWw2NzM5MzUwNTY=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-pending","name":"code-checks-pending","color":"fbca04","default":false},{"id":88653795,"node_id":"MDU6TGFiZWw4ODY1Mzc5NQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":52881671,"node_id":"MDU6TGFiZWw1Mjg4MTY3MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/db-pending","name":"db-pending","color":"fbca04","default":false},{"id":52820587,"node_id":"MDU6TGFiZWw1MjgyMDU4Nw==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/l1-pending","name":"l1-pending","color":"fbca04","default":false},{"id":56953091,"node_id":"MDU6TGFiZWw1Njk1MzA5MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"node_id":"MDU6TGFiZWw1MzE2Nzc3MA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":56131152,"node_id":"MDU6TGFiZWw1NjEzMTE1Mg==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/78","html_url":"https://github.com/cms-sw/cmssw/milestone/78","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/78/labels","id":3727036,"node_id":"MDk6TWlsZXN0b25lMzcyNzAzNg==","number":78,"title":"CMSSW_10_4_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":60,"closed_issues":137,"state":"open","created_at":"2018-10-10T09:27:21Z","updated_at":"2018-10-29T20:02:06Z","due_on":null,"closed_at":null},"comments":11,"created_at":"2018-10-29T16:00:33Z","updated_at":"2018-10-29T20:26:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/25037","html_url":"https://github.com/cms-sw/cmssw/pull/25037","diff_url":"https://github.com/cms-sw/cmssw/pull/25037.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/25037.patch"},"body":"Prepare for concurrent IOVs in files related to L1ConfigOnlineProdBase\r\nand L1ConfigOnlineProdBaseExt. Mostly this is conversion of\r\nshared_ptr to unique_ptr in those base classes and the many ESProducers\r\nthat derive from them. In a few modules I needed to remove a data member\r\nto do this.\r\n\r\nNote this also required changing the return type of the deserialization\r\nfunction in CondCore/CondDB/interface/Serialization.h and the fetchPayload\r\nfunction in CondCore/CondDB/interface/Session.h. Both of these changes\r\nseem to be better design to me. Probably the only reason it was a shared_ptr\r\nwas because this code was originally written before unique_ptr existed. I do\r\nnot know if it is significant, but this should also improve performance at least\r\nslightly. (One could make more similar changes in CondCore, but I only did\r\nthe minimum necessary for my immediate goal).\r\n\r\nThere is also a bit of cleanup mixed in. \"scram code-checks\" fixed a few things.\r\nIn one of the previous PRs in this ESProducer campaign\r\nsomeone requested I remove all the unnecessary \"using edm::es\" namespace\r\ndirectives, so I removed all those in these packages as well. Plus a little bit of\r\nfixing indentation around the lines I changed.\r\n\r\nFYI @Dr15Jones "},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/434065990","html_url":"https://github.com/cms-sw/cmssw/pull/25037#issuecomment-434065990","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/25037","id":434065990,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDA2NTk5MA==","user":{"login":"cmsbuild","id":4170616,"node_id":"MDQ6VXNlcjQxNzA2MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4170616?v=4","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2018-10-29T20:26:03Z","updated_at":"2018-10-29T20:26:03Z","author_association":"CONTRIBUTOR","body":"+code-checks\n\nLogs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25037/7028"}}
{"actor":{"display_login":"cmsbuild"}}