{"action":"created","issue":{"url":"https://api.github.com/repos/yourlabs/django-autocomplete-light/issues/1070","repository_url":"https://api.github.com/repos/yourlabs/django-autocomplete-light","labels_url":"https://api.github.com/repos/yourlabs/django-autocomplete-light/issues/1070/labels{/name}","comments_url":"https://api.github.com/repos/yourlabs/django-autocomplete-light/issues/1070/comments","events_url":"https://api.github.com/repos/yourlabs/django-autocomplete-light/issues/1070/events","html_url":"https://github.com/yourlabs/django-autocomplete-light/issues/1070","id":379611298,"node_id":"MDU6SXNzdWUzNzk2MTEyOTg=","number":1070,"title":"Port fix for jQuery usage in af721ca to Django 1.11 compatible releases (> 3.2.10)","user":{"login":"mandarg","id":160992,"node_id":"MDQ6VXNlcjE2MDk5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/160992?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarg","html_url":"https://github.com/mandarg","followers_url":"https://api.github.com/users/mandarg/followers","following_url":"https://api.github.com/users/mandarg/following{/other_user}","gists_url":"https://api.github.com/users/mandarg/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarg/subscriptions","organizations_url":"https://api.github.com/users/mandarg/orgs","repos_url":"https://api.github.com/users/mandarg/repos","events_url":"https://api.github.com/users/mandarg/events{/privacy}","received_events_url":"https://api.github.com/users/mandarg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-12T03:56:38Z","updated_at":"2018-11-12T13:15:24Z","closed_at":null,"author_association":"NONE","body":"So af721ca54c75625d80b22007db70c93ca096b81c proved to be the definitive fix for \"Select2: An instance of jQuery or a jQuery-compatible library was not found.\" type issues seen when using just `dal` and `dal_select2` with no other jQuery or Select2 modules. The issues seem to have been due to the fact that `$` was not being defined by either django-jquery or the `jquery.init.js` in this module, but the bundled `select2.full.js` expected `$` to be present. (I was halfway towards writing a fix before I found @coredumperror's much better one on master, so I'll let him weigh in in case I'm saying something wrong).\r\n\r\nAnyway, the reason for this issue is – I'm still stuck on using Django 1.11, which is supported only by the 3.2.10 release, so I couldn't take advantage of the fix on master (which is only in 3.3 and upwards, which are [not supported for Django 1.11](https://github.com/yourlabs/django-autocomplete-light/pull/1064/files). \r\n\r\nSo, to use it with Django 1.11, I changed some minor things in the patch and applied it to the 3.2.10 release [here](https://github.com/mandarg/django-autocomplete-light/commit/4bd04780061b36bc608b58dd07d40c0836a3eba6). Would you be open to cutting a new 3.2.11 release with that patch applied? (This will mean a new branch starting at the `3.2.10` tag). [Direct link to patch](https://github.com/mandarg/django-autocomplete-light/commit/4bd04780061b36bc608b58dd07d40c0836a3eba6.patch) that can be `git am`'d if it helps.\r\n\r\nLet me know if you want any more work/input from me here, this is just to gauge the level of interest in a fix and 3.2.11 release. I'm fairly certain this also closes #824, and possibly #886 as well.\r\n"},"comment":{"url":"https://api.github.com/repos/yourlabs/django-autocomplete-light/issues/comments/437875555","html_url":"https://github.com/yourlabs/django-autocomplete-light/issues/1070#issuecomment-437875555","issue_url":"https://api.github.com/repos/yourlabs/django-autocomplete-light/issues/1070","id":437875555,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzg3NTU1NQ==","user":{"login":"jpic","id":94636,"node_id":"MDQ6VXNlcjk0NjM2","avatar_url":"https://avatars3.githubusercontent.com/u/94636?v=4","gravatar_id":"","url":"https://api.github.com/users/jpic","html_url":"https://github.com/jpic","followers_url":"https://api.github.com/users/jpic/followers","following_url":"https://api.github.com/users/jpic/following{/other_user}","gists_url":"https://api.github.com/users/jpic/gists{/gist_id}","starred_url":"https://api.github.com/users/jpic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpic/subscriptions","organizations_url":"https://api.github.com/users/jpic/orgs","repos_url":"https://api.github.com/users/jpic/repos","events_url":"https://api.github.com/users/jpic/events{/privacy}","received_events_url":"https://api.github.com/users/jpic/received_events","type":"User","site_admin":false},"created_at":"2018-11-12T13:15:24Z","updated_at":"2018-11-12T13:15:24Z","author_association":"MEMBER","body":"I don't mind merging your patch: I don't target 1.11 compat myself, but I have nothing against it."}}
{"actor":{"display_login":"jpic"}}