{"action":"closed","number":309,"pull_request":{"url":"https://api.github.com/repos/Clever/components/pulls/309","id":214010550,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDEwNTUw","html_url":"https://github.com/Clever/components/pull/309","diff_url":"https://github.com/Clever/components/pull/309.diff","patch_url":"https://github.com/Clever/components/pull/309.patch","issue_url":"https://api.github.com/repos/Clever/components/issues/309","number":309,"state":"closed","locked":false,"title":"Textarea default rows","user":{"login":"johnhuangclever","id":13126257,"node_id":"MDQ6VXNlcjEzMTI2MjU3","avatar_url":"https://avatars3.githubusercontent.com/u/13126257?v=4","gravatar_id":"","url":"https://api.github.com/users/johnhuangclever","html_url":"https://github.com/johnhuangclever","followers_url":"https://api.github.com/users/johnhuangclever/followers","following_url":"https://api.github.com/users/johnhuangclever/following{/other_user}","gists_url":"https://api.github.com/users/johnhuangclever/gists{/gist_id}","starred_url":"https://api.github.com/users/johnhuangclever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnhuangclever/subscriptions","organizations_url":"https://api.github.com/users/johnhuangclever/orgs","repos_url":"https://api.github.com/users/johnhuangclever/repos","events_url":"https://api.github.com/users/johnhuangclever/events{/privacy}","received_events_url":"https://api.github.com/users/johnhuangclever/received_events","type":"User","site_admin":false},"body":"Error from console:\r\n![screenshot 2018-09-07 11 40 09](https://user-images.githubusercontent.com/13126257/45237446-92f0ee80-b293-11e8-89cb-c039782e74ed.png)\r\n\r\nStepping through old code:\r\n![textarea-broken](https://user-images.githubusercontent.com/13126257/45237582-fb3fd000-b293-11e8-96f6-dae1af9d1d3d.gif)\r\n\r\nStepping through new code:\r\n![textarea-fixed](https://user-images.githubusercontent.com/13126257/45237593-02ff7480-b294-11e8-85d2-b2a9e1931260.gif)\r\n\r\nVerified that visual sizing of textarea is the same with the new code\r\n\r\n**Roll Out:**\r\n- Before merging:\r\n  - [x] Updated docs\r\n  - [ ] Bumped version in `package.json`\r\n    - Breaking change? Run `npm version minor`\r\n    - Backward compatible change? Run `npm version patch`\r\n    - Only changing documentation? All good. Skip this step.\r\n- After merging:\r\n  - [ ] Deployed updated docs (`make deploy-docs`)\r\n","created_at":"2018-09-07T18:49:30Z","updated_at":"2018-09-07T19:38:05Z","closed_at":"2018-09-07T19:38:05Z","merged_at":"2018-09-07T19:38:05Z","merge_commit_sha":"5a4d8660f050b86f8ce17d554bb143233e5d7c56","assignee":{"login":"brollin","id":12655228,"node_id":"MDQ6VXNlcjEyNjU1MjI4","avatar_url":"https://avatars1.githubusercontent.com/u/12655228?v=4","gravatar_id":"","url":"https://api.github.com/users/brollin","html_url":"https://github.com/brollin","followers_url":"https://api.github.com/users/brollin/followers","following_url":"https://api.github.com/users/brollin/following{/other_user}","gists_url":"https://api.github.com/users/brollin/gists{/gist_id}","starred_url":"https://api.github.com/users/brollin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brollin/subscriptions","organizations_url":"https://api.github.com/users/brollin/orgs","repos_url":"https://api.github.com/users/brollin/repos","events_url":"https://api.github.com/users/brollin/events{/privacy}","received_events_url":"https://api.github.com/users/brollin/received_events","type":"User","site_admin":false},"assignees":[{"login":"brollin","id":12655228,"node_id":"MDQ6VXNlcjEyNjU1MjI4","avatar_url":"https://avatars1.githubusercontent.com/u/12655228?v=4","gravatar_id":"","url":"https://api.github.com/users/brollin","html_url":"https://github.com/brollin","followers_url":"https://api.github.com/users/brollin/followers","following_url":"https://api.github.com/users/brollin/following{/other_user}","gists_url":"https://api.github.com/users/brollin/gists{/gist_id}","starred_url":"https://api.github.com/users/brollin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brollin/subscriptions","organizations_url":"https://api.github.com/users/brollin/orgs","repos_url":"https://api.github.com/users/brollin/repos","events_url":"https://api.github.com/users/brollin/events{/privacy}","received_events_url":"https://api.github.com/users/brollin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Clever/components/pulls/309/commits","review_comments_url":"https://api.github.com/repos/Clever/components/pulls/309/comments","review_comment_url":"https://api.github.com/repos/Clever/components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Clever/components/issues/309/comments","statuses_url":"https://api.github.com/repos/Clever/components/statuses/3c1b97c7139990b16fa8043f8d936e220b90b94d","head":{"label":"Clever:textarea-default-rows","ref":"textarea-default-rows","sha":"3c1b97c7139990b16fa8043f8d936e220b90b94d","user":{"login":"Clever","id":1885509,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4ODU1MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1885509?v=4","gravatar_id":"","url":"https://api.github.com/users/Clever","html_url":"https://github.com/Clever","followers_url":"https://api.github.com/users/Clever/followers","following_url":"https://api.github.com/users/Clever/following{/other_user}","gists_url":"https://api.github.com/users/Clever/gists{/gist_id}","starred_url":"https://api.github.com/users/Clever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clever/subscriptions","organizations_url":"https://api.github.com/users/Clever/orgs","repos_url":"https://api.github.com/users/Clever/repos","events_url":"https://api.github.com/users/Clever/events{/privacy}","received_events_url":"https://api.github.com/users/Clever/received_events","type":"Organization","site_admin":false},"repo":{"id":46310590,"node_id":"MDEwOlJlcG9zaXRvcnk0NjMxMDU5MA==","name":"components","full_name":"Clever/components","owner":{"login":"Clever","id":1885509,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4ODU1MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1885509?v=4","gravatar_id":"","url":"https://api.github.com/users/Clever","html_url":"https://github.com/Clever","followers_url":"https://api.github.com/users/Clever/followers","following_url":"https://api.github.com/users/Clever/following{/other_user}","gists_url":"https://api.github.com/users/Clever/gists{/gist_id}","starred_url":"https://api.github.com/users/Clever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clever/subscriptions","organizations_url":"https://api.github.com/users/Clever/orgs","repos_url":"https://api.github.com/users/Clever/repos","events_url":"https://api.github.com/users/Clever/events{/privacy}","received_events_url":"https://api.github.com/users/Clever/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Clever/components","description":"Frontend components","fork":false,"url":"https://api.github.com/repos/Clever/components","forks_url":"https://api.github.com/repos/Clever/components/forks","keys_url":"https://api.github.com/repos/Clever/components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Clever/components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Clever/components/teams","hooks_url":"https://api.github.com/repos/Clever/components/hooks","issue_events_url":"https://api.github.com/repos/Clever/components/issues/events{/number}","events_url":"https://api.github.com/repos/Clever/components/events","assignees_url":"https://api.github.com/repos/Clever/components/assignees{/user}","branches_url":"https://api.github.com/repos/Clever/components/branches{/branch}","tags_url":"https://api.github.com/repos/Clever/components/tags","blobs_url":"https://api.github.com/repos/Clever/components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Clever/components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Clever/components/git/refs{/sha}","trees_url":"https://api.github.com/repos/Clever/components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Clever/components/statuses/{sha}","languages_url":"https://api.github.com/repos/Clever/components/languages","stargazers_url":"https://api.github.com/repos/Clever/components/stargazers","contributors_url":"https://api.github.com/repos/Clever/components/contributors","subscribers_url":"https://api.github.com/repos/Clever/components/subscribers","subscription_url":"https://api.github.com/repos/Clever/components/subscription","commits_url":"https://api.github.com/repos/Clever/components/commits{/sha}","git_commits_url":"https://api.github.com/repos/Clever/components/git/commits{/sha}","comments_url":"https://api.github.com/repos/Clever/components/comments{/number}","issue_comment_url":"https://api.github.com/repos/Clever/components/issues/comments{/number}","contents_url":"https://api.github.com/repos/Clever/components/contents/{+path}","compare_url":"https://api.github.com/repos/Clever/components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Clever/components/merges","archive_url":"https://api.github.com/repos/Clever/components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Clever/components/downloads","issues_url":"https://api.github.com/repos/Clever/components/issues{/number}","pulls_url":"https://api.github.com/repos/Clever/components/pulls{/number}","milestones_url":"https://api.github.com/repos/Clever/components/milestones{/number}","notifications_url":"https://api.github.com/repos/Clever/components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Clever/components/labels{/name}","releases_url":"https://api.github.com/repos/Clever/components/releases{/id}","deployments_url":"https://api.github.com/repos/Clever/components/deployments","created_at":"2015-11-16T23:47:29Z","updated_at":"2018-09-06T02:45:00Z","pushed_at":"2018-09-07T19:38:05Z","git_url":"git://github.com/Clever/components.git","ssh_url":"git@github.com:Clever/components.git","clone_url":"https://github.com/Clever/components.git","svn_url":"https://github.com/Clever/components","homepage":"http://clever.github.io/components/","size":10989,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":12,"license":null,"forks":0,"open_issues":12,"watchers":14,"default_branch":"master"}},"base":{"label":"Clever:master","ref":"master","sha":"e9214fc09ae99e95864650cd810592152e08f7fc","user":{"login":"Clever","id":1885509,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4ODU1MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1885509?v=4","gravatar_id":"","url":"https://api.github.com/users/Clever","html_url":"https://github.com/Clever","followers_url":"https://api.github.com/users/Clever/followers","following_url":"https://api.github.com/users/Clever/following{/other_user}","gists_url":"https://api.github.com/users/Clever/gists{/gist_id}","starred_url":"https://api.github.com/users/Clever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clever/subscriptions","organizations_url":"https://api.github.com/users/Clever/orgs","repos_url":"https://api.github.com/users/Clever/repos","events_url":"https://api.github.com/users/Clever/events{/privacy}","received_events_url":"https://api.github.com/users/Clever/received_events","type":"Organization","site_admin":false},"repo":{"id":46310590,"node_id":"MDEwOlJlcG9zaXRvcnk0NjMxMDU5MA==","name":"components","full_name":"Clever/components","owner":{"login":"Clever","id":1885509,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4ODU1MDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1885509?v=4","gravatar_id":"","url":"https://api.github.com/users/Clever","html_url":"https://github.com/Clever","followers_url":"https://api.github.com/users/Clever/followers","following_url":"https://api.github.com/users/Clever/following{/other_user}","gists_url":"https://api.github.com/users/Clever/gists{/gist_id}","starred_url":"https://api.github.com/users/Clever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clever/subscriptions","organizations_url":"https://api.github.com/users/Clever/orgs","repos_url":"https://api.github.com/users/Clever/repos","events_url":"https://api.github.com/users/Clever/events{/privacy}","received_events_url":"https://api.github.com/users/Clever/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Clever/components","description":"Frontend components","fork":false,"url":"https://api.github.com/repos/Clever/components","forks_url":"https://api.github.com/repos/Clever/components/forks","keys_url":"https://api.github.com/repos/Clever/components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Clever/components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Clever/components/teams","hooks_url":"https://api.github.com/repos/Clever/components/hooks","issue_events_url":"https://api.github.com/repos/Clever/components/issues/events{/number}","events_url":"https://api.github.com/repos/Clever/components/events","assignees_url":"https://api.github.com/repos/Clever/components/assignees{/user}","branches_url":"https://api.github.com/repos/Clever/components/branches{/branch}","tags_url":"https://api.github.com/repos/Clever/components/tags","blobs_url":"https://api.github.com/repos/Clever/components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Clever/components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Clever/components/git/refs{/sha}","trees_url":"https://api.github.com/repos/Clever/components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Clever/components/statuses/{sha}","languages_url":"https://api.github.com/repos/Clever/components/languages","stargazers_url":"https://api.github.com/repos/Clever/components/stargazers","contributors_url":"https://api.github.com/repos/Clever/components/contributors","subscribers_url":"https://api.github.com/repos/Clever/components/subscribers","subscription_url":"https://api.github.com/repos/Clever/components/subscription","commits_url":"https://api.github.com/repos/Clever/components/commits{/sha}","git_commits_url":"https://api.github.com/repos/Clever/components/git/commits{/sha}","comments_url":"https://api.github.com/repos/Clever/components/comments{/number}","issue_comment_url":"https://api.github.com/repos/Clever/components/issues/comments{/number}","contents_url":"https://api.github.com/repos/Clever/components/contents/{+path}","compare_url":"https://api.github.com/repos/Clever/components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Clever/components/merges","archive_url":"https://api.github.com/repos/Clever/components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Clever/components/downloads","issues_url":"https://api.github.com/repos/Clever/components/issues{/number}","pulls_url":"https://api.github.com/repos/Clever/components/pulls{/number}","milestones_url":"https://api.github.com/repos/Clever/components/milestones{/number}","notifications_url":"https://api.github.com/repos/Clever/components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Clever/components/labels{/name}","releases_url":"https://api.github.com/repos/Clever/components/releases{/id}","deployments_url":"https://api.github.com/repos/Clever/components/deployments","created_at":"2015-11-16T23:47:29Z","updated_at":"2018-09-06T02:45:00Z","pushed_at":"2018-09-07T19:38:05Z","git_url":"git://github.com/Clever/components.git","ssh_url":"git@github.com:Clever/components.git","clone_url":"https://github.com/Clever/components.git","svn_url":"https://github.com/Clever/components","homepage":"http://clever.github.io/components/","size":10989,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":12,"license":null,"forks":0,"open_issues":12,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Clever/components/pulls/309"},"html":{"href":"https://github.com/Clever/components/pull/309"},"issue":{"href":"https://api.github.com/repos/Clever/components/issues/309"},"comments":{"href":"https://api.github.com/repos/Clever/components/issues/309/comments"},"review_comments":{"href":"https://api.github.com/repos/Clever/components/pulls/309/comments"},"review_comment":{"href":"https://api.github.com/repos/Clever/components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Clever/components/pulls/309/commits"},"statuses":{"href":"https://api.github.com/repos/Clever/components/statuses/3c1b97c7139990b16fa8043f8d936e220b90b94d"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"johnhuangclever","id":13126257,"node_id":"MDQ6VXNlcjEzMTI2MjU3","avatar_url":"https://avatars3.githubusercontent.com/u/13126257?v=4","gravatar_id":"","url":"https://api.github.com/users/johnhuangclever","html_url":"https://github.com/johnhuangclever","followers_url":"https://api.github.com/users/johnhuangclever/followers","following_url":"https://api.github.com/users/johnhuangclever/following{/other_user}","gists_url":"https://api.github.com/users/johnhuangclever/gists{/gist_id}","starred_url":"https://api.github.com/users/johnhuangclever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnhuangclever/subscriptions","organizations_url":"https://api.github.com/users/johnhuangclever/orgs","repos_url":"https://api.github.com/users/johnhuangclever/repos","events_url":"https://api.github.com/users/johnhuangclever/events{/privacy}","received_events_url":"https://api.github.com/users/johnhuangclever/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"maintainer_can_modify":false,"commits":3,"additions":11,"deletions":6,"changed_files":3}}
{"actor":{"display_login":"johnhuangclever"}}