{"action":"created","issue":{"url":"https://api.github.com/repos/SamVerschueren/alfred-fkill/issues/9","repository_url":"https://api.github.com/repos/SamVerschueren/alfred-fkill","labels_url":"https://api.github.com/repos/SamVerschueren/alfred-fkill/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/SamVerschueren/alfred-fkill/issues/9/comments","events_url":"https://api.github.com/repos/SamVerschueren/alfred-fkill/issues/9/events","html_url":"https://github.com/SamVerschueren/alfred-fkill/pull/9","id":306534946,"number":9,"title":"Add support for searching and killing by port - fixes #7","user":{"login":"SamVerschueren","id":1913805,"avatar_url":"https://avatars2.githubusercontent.com/u/1913805?v=4","gravatar_id":"","url":"https://api.github.com/users/SamVerschueren","html_url":"https://github.com/SamVerschueren","followers_url":"https://api.github.com/users/SamVerschueren/followers","following_url":"https://api.github.com/users/SamVerschueren/following{/other_user}","gists_url":"https://api.github.com/users/SamVerschueren/gists{/gist_id}","starred_url":"https://api.github.com/users/SamVerschueren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamVerschueren/subscriptions","organizations_url":"https://api.github.com/users/SamVerschueren/orgs","repos_url":"https://api.github.com/users/SamVerschueren/repos","events_url":"https://api.github.com/users/SamVerschueren/events{/privacy}","received_events_url":"https://api.github.com/users/SamVerschueren/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-19T16:25:39Z","updated_at":"2018-03-20T07:01:51Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/SamVerschueren/alfred-fkill/pulls/9","html_url":"https://github.com/SamVerschueren/alfred-fkill/pull/9","diff_url":"https://github.com/SamVerschueren/alfred-fkill/pull/9.diff","patch_url":"https://github.com/SamVerschueren/alfred-fkill/pull/9.patch"},"body":"I gave #7 a go. Looked at how @kevva implemented it in `fkill-cli` and used the same approach. I did not document it yet, but feel free to provide feedback on the implementation details."},"comment":{"url":"https://api.github.com/repos/SamVerschueren/alfred-fkill/issues/comments/374495955","html_url":"https://github.com/SamVerschueren/alfred-fkill/pull/9#issuecomment-374495955","issue_url":"https://api.github.com/repos/SamVerschueren/alfred-fkill/issues/9","id":374495955,"user":{"login":"SamVerschueren","id":1913805,"avatar_url":"https://avatars2.githubusercontent.com/u/1913805?v=4","gravatar_id":"","url":"https://api.github.com/users/SamVerschueren","html_url":"https://github.com/SamVerschueren","followers_url":"https://api.github.com/users/SamVerschueren/followers","following_url":"https://api.github.com/users/SamVerschueren/following{/other_user}","gists_url":"https://api.github.com/users/SamVerschueren/gists{/gist_id}","starred_url":"https://api.github.com/users/SamVerschueren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamVerschueren/subscriptions","organizations_url":"https://api.github.com/users/SamVerschueren/orgs","repos_url":"https://api.github.com/users/SamVerschueren/repos","events_url":"https://api.github.com/users/SamVerschueren/events{/privacy}","received_events_url":"https://api.github.com/users/SamVerschueren/received_events","type":"User","site_admin":false},"created_at":"2018-03-20T07:01:51Z","updated_at":"2018-03-20T07:01:51Z","author_association":"OWNER","body":"I tried running `alfred-fkill` and `fkill-cli` side by side to see if they return identical results. Most of the time they do, but apparently Chrome is tied to 20 port numbers or so our utils function `getPortFromPid` randomly returns one of the ports. Should we make it more intelligent and filter out the ports first which don't match the search query and then bind the port to the process?"}}
{"actor":{"display_login":"SamVerschueren"}}