{"action":"created","comment":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/comments/189758086","pull_request_review_id":121998459,"id":189758086,"diff_hunk":"@@ -97,6 +97,12 @@\n     protected static int numBookies = 3;\n     private static final List<File> tmpDirs = new ArrayList<File>();\n \n+    protected static File newTempDir(String name) throws IOException {\n+        File zkTmpDir = IOUtils.createTempDir(name, \"distrlog\");","path":"stream/distributedlog/core/src/test/java/org/apache/distributedlog/TestDistributedLogBase.java","position":5,"original_position":5,"commit_id":"5349f8ba956cfe0f3ab95e39752fdb1d2d57c460","original_commit_id":"5349f8ba956cfe0f3ab95e39752fdb1d2d57c460","user":{"login":"jiazhai","id":6348208,"avatar_url":"https://avatars2.githubusercontent.com/u/6348208?v=4","gravatar_id":"","url":"https://api.github.com/users/jiazhai","html_url":"https://github.com/jiazhai","followers_url":"https://api.github.com/users/jiazhai/followers","following_url":"https://api.github.com/users/jiazhai/following{/other_user}","gists_url":"https://api.github.com/users/jiazhai/gists{/gist_id}","starred_url":"https://api.github.com/users/jiazhai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiazhai/subscriptions","organizations_url":"https://api.github.com/users/jiazhai/orgs","repos_url":"https://api.github.com/users/jiazhai/repos","events_url":"https://api.github.com/users/jiazhai/events{/privacy}","received_events_url":"https://api.github.com/users/jiazhai/received_events","type":"User","site_admin":false},"body":"in the name, `zk` looks not needed, how about rename it?","created_at":"2018-05-22T01:44:06Z","updated_at":"2018-05-22T01:44:06Z","html_url":"https://github.com/apache/bookkeeper/pull/1417#discussion_r189758086","pull_request_url":"https://api.github.com/repos/apache/bookkeeper/pulls/1417","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/comments/189758086"},"html":{"href":"https://github.com/apache/bookkeeper/pull/1417#discussion_r189758086"},"pull_request":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1417"}}},"pull_request":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/1417","id":189373619,"html_url":"https://github.com/apache/bookkeeper/pull/1417","diff_url":"https://github.com/apache/bookkeeper/pull/1417.diff","patch_url":"https://github.com/apache/bookkeeper/pull/1417.patch","issue_url":"https://api.github.com/repos/apache/bookkeeper/issues/1417","number":1417,"state":"open","locked":false,"title":"Issue-1415: [DLOG] org.apache.distributedlog.fs.TestDLFileSystem fails on CI","user":{"login":"eolivelli","id":9469110,"avatar_url":"https://avatars0.githubusercontent.com/u/9469110?v=4","gravatar_id":"","url":"https://api.github.com/users/eolivelli","html_url":"https://github.com/eolivelli","followers_url":"https://api.github.com/users/eolivelli/followers","following_url":"https://api.github.com/users/eolivelli/following{/other_user}","gists_url":"https://api.github.com/users/eolivelli/gists{/gist_id}","starred_url":"https://api.github.com/users/eolivelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eolivelli/subscriptions","organizations_url":"https://api.github.com/users/eolivelli/orgs","repos_url":"https://api.github.com/users/eolivelli/repos","events_url":"https://api.github.com/users/eolivelli/events{/privacy}","received_events_url":"https://api.github.com/users/eolivelli/received_events","type":"User","site_admin":false},"body":"Use a generated tempDir for DL FS tests instead of using an hard coded /tmp path\r\n\r\nFix for #1415 ","created_at":"2018-05-21T13:05:16Z","updated_at":"2018-05-22T01:44:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c5887640fda263bdd172f544d7ca050163d5a1e","assignee":{"login":"eolivelli","id":9469110,"avatar_url":"https://avatars0.githubusercontent.com/u/9469110?v=4","gravatar_id":"","url":"https://api.github.com/users/eolivelli","html_url":"https://github.com/eolivelli","followers_url":"https://api.github.com/users/eolivelli/followers","following_url":"https://api.github.com/users/eolivelli/following{/other_user}","gists_url":"https://api.github.com/users/eolivelli/gists{/gist_id}","starred_url":"https://api.github.com/users/eolivelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eolivelli/subscriptions","organizations_url":"https://api.github.com/users/eolivelli/orgs","repos_url":"https://api.github.com/users/eolivelli/repos","events_url":"https://api.github.com/users/eolivelli/events{/privacy}","received_events_url":"https://api.github.com/users/eolivelli/received_events","type":"User","site_admin":false},"assignees":[{"login":"eolivelli","id":9469110,"avatar_url":"https://avatars0.githubusercontent.com/u/9469110?v=4","gravatar_id":"","url":"https://api.github.com/users/eolivelli","html_url":"https://github.com/eolivelli","followers_url":"https://api.github.com/users/eolivelli/followers","following_url":"https://api.github.com/users/eolivelli/following{/other_user}","gists_url":"https://api.github.com/users/eolivelli/gists{/gist_id}","starred_url":"https://api.github.com/users/eolivelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eolivelli/subscriptions","organizations_url":"https://api.github.com/users/eolivelli/orgs","repos_url":"https://api.github.com/users/eolivelli/repos","events_url":"https://api.github.com/users/eolivelli/events{/privacy}","received_events_url":"https://api.github.com/users/eolivelli/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":822862030,"url":"https://api.github.com/repos/apache/bookkeeper/labels/area/dlog","name":"area/dlog","color":"f9d0c4","default":false},{"id":636302110,"url":"https://api.github.com/repos/apache/bookkeeper/labels/area/tests","name":"area/tests","color":"f9d0c4","default":false}],"milestone":{"url":"https://api.github.com/repos/apache/bookkeeper/milestones/4","html_url":"https://github.com/apache/bookkeeper/milestone/4","labels_url":"https://api.github.com/repos/apache/bookkeeper/milestones/4/labels","id":3081917,"number":4,"title":"4.8.0","description":"Release 4.8.0","creator":{"login":"sijie","id":1217863,"avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"open_issues":39,"closed_issues":49,"state":"open","created_at":"2018-02-01T19:35:05Z","updated_at":"2018-05-21T22:53:19Z","due_on":"2018-08-02T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apache/bookkeeper/pulls/1417/commits","review_comments_url":"https://api.github.com/repos/apache/bookkeeper/pulls/1417/comments","review_comment_url":"https://api.github.com/repos/apache/bookkeeper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/bookkeeper/issues/1417/comments","statuses_url":"https://api.github.com/repos/apache/bookkeeper/statuses/5349f8ba956cfe0f3ab95e39752fdb1d2d57c460","head":{"label":"eolivelli:fix/no-tmpdir-fsdl","ref":"fix/no-tmpdir-fsdl","sha":"5349f8ba956cfe0f3ab95e39752fdb1d2d57c460","user":{"login":"eolivelli","id":9469110,"avatar_url":"https://avatars0.githubusercontent.com/u/9469110?v=4","gravatar_id":"","url":"https://api.github.com/users/eolivelli","html_url":"https://github.com/eolivelli","followers_url":"https://api.github.com/users/eolivelli/followers","following_url":"https://api.github.com/users/eolivelli/following{/other_user}","gists_url":"https://api.github.com/users/eolivelli/gists{/gist_id}","starred_url":"https://api.github.com/users/eolivelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eolivelli/subscriptions","organizations_url":"https://api.github.com/users/eolivelli/orgs","repos_url":"https://api.github.com/users/eolivelli/repos","events_url":"https://api.github.com/users/eolivelli/events{/privacy}","received_events_url":"https://api.github.com/users/eolivelli/received_events","type":"User","site_admin":false},"repo":{"id":61374519,"name":"bookkeeper","full_name":"eolivelli/bookkeeper","owner":{"login":"eolivelli","id":9469110,"avatar_url":"https://avatars0.githubusercontent.com/u/9469110?v=4","gravatar_id":"","url":"https://api.github.com/users/eolivelli","html_url":"https://github.com/eolivelli","followers_url":"https://api.github.com/users/eolivelli/followers","following_url":"https://api.github.com/users/eolivelli/following{/other_user}","gists_url":"https://api.github.com/users/eolivelli/gists{/gist_id}","starred_url":"https://api.github.com/users/eolivelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eolivelli/subscriptions","organizations_url":"https://api.github.com/users/eolivelli/orgs","repos_url":"https://api.github.com/users/eolivelli/repos","events_url":"https://api.github.com/users/eolivelli/events{/privacy}","received_events_url":"https://api.github.com/users/eolivelli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eolivelli/bookkeeper","description":"Mirror of Apache Bookkeeper","fork":true,"url":"https://api.github.com/repos/eolivelli/bookkeeper","forks_url":"https://api.github.com/repos/eolivelli/bookkeeper/forks","keys_url":"https://api.github.com/repos/eolivelli/bookkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eolivelli/bookkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eolivelli/bookkeeper/teams","hooks_url":"https://api.github.com/repos/eolivelli/bookkeeper/hooks","issue_events_url":"https://api.github.com/repos/eolivelli/bookkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/eolivelli/bookkeeper/events","assignees_url":"https://api.github.com/repos/eolivelli/bookkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/eolivelli/bookkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/eolivelli/bookkeeper/tags","blobs_url":"https://api.github.com/repos/eolivelli/bookkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eolivelli/bookkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eolivelli/bookkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/eolivelli/bookkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eolivelli/bookkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/eolivelli/bookkeeper/languages","stargazers_url":"https://api.github.com/repos/eolivelli/bookkeeper/stargazers","contributors_url":"https://api.github.com/repos/eolivelli/bookkeeper/contributors","subscribers_url":"https://api.github.com/repos/eolivelli/bookkeeper/subscribers","subscription_url":"https://api.github.com/repos/eolivelli/bookkeeper/subscription","commits_url":"https://api.github.com/repos/eolivelli/bookkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/eolivelli/bookkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/eolivelli/bookkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/eolivelli/bookkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/eolivelli/bookkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/eolivelli/bookkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eolivelli/bookkeeper/merges","archive_url":"https://api.github.com/repos/eolivelli/bookkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eolivelli/bookkeeper/downloads","issues_url":"https://api.github.com/repos/eolivelli/bookkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/eolivelli/bookkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/eolivelli/bookkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/eolivelli/bookkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eolivelli/bookkeeper/labels{/name}","releases_url":"https://api.github.com/repos/eolivelli/bookkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/eolivelli/bookkeeper/deployments","created_at":"2016-06-17T13:11:53Z","updated_at":"2018-03-28T18:26:11Z","pushed_at":"2018-05-21T13:04:19Z","git_url":"git://github.com/eolivelli/bookkeeper.git","ssh_url":"git@github.com:eolivelli/bookkeeper.git","clone_url":"https://github.com/eolivelli/bookkeeper.git","svn_url":"https://github.com/eolivelli/bookkeeper","homepage":null,"size":19916,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"5bdfbf6a673b69a9027f85ad4e82c427d41646be","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":1575956,"name":"bookkeeper","full_name":"apache/bookkeeper","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/bookkeeper","description":"Apache Bookkeeper","fork":false,"url":"https://api.github.com/repos/apache/bookkeeper","forks_url":"https://api.github.com/repos/apache/bookkeeper/forks","keys_url":"https://api.github.com/repos/apache/bookkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/bookkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/bookkeeper/teams","hooks_url":"https://api.github.com/repos/apache/bookkeeper/hooks","issue_events_url":"https://api.github.com/repos/apache/bookkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/apache/bookkeeper/events","assignees_url":"https://api.github.com/repos/apache/bookkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/apache/bookkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/apache/bookkeeper/tags","blobs_url":"https://api.github.com/repos/apache/bookkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/bookkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/bookkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/bookkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/bookkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/bookkeeper/languages","stargazers_url":"https://api.github.com/repos/apache/bookkeeper/stargazers","contributors_url":"https://api.github.com/repos/apache/bookkeeper/contributors","subscribers_url":"https://api.github.com/repos/apache/bookkeeper/subscribers","subscription_url":"https://api.github.com/repos/apache/bookkeeper/subscription","commits_url":"https://api.github.com/repos/apache/bookkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/bookkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/bookkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/bookkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/bookkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/apache/bookkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/bookkeeper/merges","archive_url":"https://api.github.com/repos/apache/bookkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/bookkeeper/downloads","issues_url":"https://api.github.com/repos/apache/bookkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/apache/bookkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/bookkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/bookkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/bookkeeper/labels{/name}","releases_url":"https://api.github.com/repos/apache/bookkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/apache/bookkeeper/deployments","created_at":"2011-04-06T07:00:07Z","updated_at":"2018-05-21T21:55:04Z","pushed_at":"2018-05-21T22:53:20Z","git_url":"git://github.com/apache/bookkeeper.git","ssh_url":"git@github.com:apache/bookkeeper.git","clone_url":"https://github.com/apache/bookkeeper.git","svn_url":"https://github.com/apache/bookkeeper","homepage":"https://bookkeeper.apache.org","size":29227,"stargazers_count":332,"watchers_count":332,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":167,"mirror_url":null,"archived":false,"open_issues_count":167,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":167,"open_issues":167,"watchers":332,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1417"},"html":{"href":"https://github.com/apache/bookkeeper/pull/1417"},"issue":{"href":"https://api.github.com/repos/apache/bookkeeper/issues/1417"},"comments":{"href":"https://api.github.com/repos/apache/bookkeeper/issues/1417/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1417/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1417/commits"},"statuses":{"href":"https://api.github.com/repos/apache/bookkeeper/statuses/5349f8ba956cfe0f3ab95e39752fdb1d2d57c460"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jiazhai"}}