{"action":"created","issue":{"url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/8140","repository_url":"https://api.github.com/repos/akeneo/pim-community-dev","labels_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/8140/labels{/name}","comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/8140/comments","events_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/8140/events","html_url":"https://github.com/akeneo/pim-community-dev/pull/8140","id":323642225,"number":8140,"title":"Spring cleaning - Burn \"I should see the flash message\" from all behat steps","user":{"login":"momoss","id":17565301,"avatar_url":"https://avatars3.githubusercontent.com/u/17565301?v=4","gravatar_id":"","url":"https://api.github.com/users/momoss","html_url":"https://github.com/momoss","followers_url":"https://api.github.com/users/momoss/followers","following_url":"https://api.github.com/users/momoss/following{/other_user}","gists_url":"https://api.github.com/users/momoss/gists{/gist_id}","starred_url":"https://api.github.com/users/momoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/momoss/subscriptions","organizations_url":"https://api.github.com/users/momoss/orgs","repos_url":"https://api.github.com/users/momoss/repos","events_url":"https://api.github.com/users/momoss/events{/privacy}","received_events_url":"https://api.github.com/users/momoss/received_events","type":"User","site_admin":false},"labels":[{"id":306739671,"url":"https://api.github.com/repos/akeneo/pim-community-dev/labels/to%20review","name":"to review","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-05-16T14:18:31Z","updated_at":"2018-05-22T13:32:56Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/8140","html_url":"https://github.com/akeneo/pim-community-dev/pull/8140","diff_url":"https://github.com/akeneo/pim-community-dev/pull/8140.diff","patch_url":"https://github.com/akeneo/pim-community-dev/pull/8140.patch"},"body":"**Time to clean our own shit**\r\n\r\nRemove Old Behat Legacy step \"I should see the flash message\"  where code of function was a `return;` since many time...\r\n\r\n**Definition Of Done (for Core Developer only)**\r\n\r\n| Q                                 | A\r\n| --------------------------------- | ---\r\n| Added Specs                       | Todo\r\n| Added legacy Behats               | Todo\r\n| Added acceptance tests            | Todo\r\n| Added integration tests           | Todo\r\n| Changelog updated                 | Todo\r\n| Review and 2 GTM                  | Todo\r\n| Micro Demo to the PO (Story only) | Todo\r\n| Migration script                  | -\r\n| Tech Doc                          | -\r\n\r\n`Todo`: Pending / Work in progress\r\n`OK`: Done / Validated\r\n`-`: Not needed\r\n"},"comment":{"url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/comments/390991384","html_url":"https://github.com/akeneo/pim-community-dev/pull/8140#issuecomment-390991384","issue_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/8140","id":390991384,"user":{"login":"damien-carcel","id":5039018,"avatar_url":"https://avatars3.githubusercontent.com/u/5039018?v=4","gravatar_id":"","url":"https://api.github.com/users/damien-carcel","html_url":"https://github.com/damien-carcel","followers_url":"https://api.github.com/users/damien-carcel/followers","following_url":"https://api.github.com/users/damien-carcel/following{/other_user}","gists_url":"https://api.github.com/users/damien-carcel/gists{/gist_id}","starred_url":"https://api.github.com/users/damien-carcel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damien-carcel/subscriptions","organizations_url":"https://api.github.com/users/damien-carcel/orgs","repos_url":"https://api.github.com/users/damien-carcel/repos","events_url":"https://api.github.com/users/damien-carcel/events{/privacy}","received_events_url":"https://api.github.com/users/damien-carcel/received_events","type":"User","site_admin":false},"created_at":"2018-05-22T13:32:56Z","updated_at":"2018-05-22T13:32:56Z","author_association":"MEMBER","body":"Those flash messages are useless and dangerous because non reliable. And anyway, we should stop writing this kind of behat step. It has no business value, it is not how we should write gherkins.\r\n\r\nChecking that the flash message work is a front test, not back, so no place in behats."}}
{"actor":{"display_login":"damien-carcel"}}