{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/186198582","pull_request_review_id":117741987,"id":186198582,"diff_hunk":"@@ -23,6 +23,16 @@ amp-story, amp-story-page, amp-story-grid-layer, amp-story-cta-layer {\n   overflow: hidden !important;\n }\n \n+amp-consent {\n+  position: absolute !important;\n+  top: 0 !important;\n+  left: 0 !important;\n+  height: 100% !important;\n+  width: 100% !important;\n+  background: none !important;\n+  z-index: initial !important;","path":"extensions/amp-story/1.0/amp-story.css","position":11,"original_position":11,"commit_id":"cc7b8ec17b131ab1c0765d66552e26b3fa77e93e","original_commit_id":"cc7b8ec17b131ab1c0765d66552e26b3fa77e93e","user":{"login":"gmajoulet","id":1492044,"avatar_url":"https://avatars1.githubusercontent.com/u/1492044?v=4","gravatar_id":"","url":"https://api.github.com/users/gmajoulet","html_url":"https://github.com/gmajoulet","followers_url":"https://api.github.com/users/gmajoulet/followers","following_url":"https://api.github.com/users/gmajoulet/following{/other_user}","gists_url":"https://api.github.com/users/gmajoulet/gists{/gist_id}","starred_url":"https://api.github.com/users/gmajoulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmajoulet/subscriptions","organizations_url":"https://api.github.com/users/gmajoulet/orgs","repos_url":"https://api.github.com/users/gmajoulet/repos","events_url":"https://api.github.com/users/gmajoulet/events{/privacy}","received_events_url":"https://api.github.com/users/gmajoulet/received_events","type":"User","site_admin":false},"body":"(I could see myself updating the z-index in the amp-story-consent.css file later, raging for 30 minutes before figuring out I actually have to change the amp-consent z-index in the amp-story.css file 🙄)","created_at":"2018-05-04T19:53:36Z","updated_at":"2018-05-04T19:53:37Z","html_url":"https://github.com/ampproject/amphtml/pull/15101#discussion_r186198582","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/15101","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/186198582"},"html":{"href":"https://github.com/ampproject/amphtml/pull/15101#discussion_r186198582"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/15101"}},"in_reply_to_id":186196694},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/15101","id":186082862,"html_url":"https://github.com/ampproject/amphtml/pull/15101","diff_url":"https://github.com/ampproject/amphtml/pull/15101.diff","patch_url":"https://github.com/ampproject/amphtml/pull/15101.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/15101","number":15101,"state":"open","locked":false,"title":"Migrate amp-story-consent away from position: fixed.","user":{"login":"gmajoulet","id":1492044,"avatar_url":"https://avatars1.githubusercontent.com/u/1492044?v=4","gravatar_id":"","url":"https://api.github.com/users/gmajoulet","html_url":"https://github.com/gmajoulet","followers_url":"https://api.github.com/users/gmajoulet/followers","following_url":"https://api.github.com/users/gmajoulet/following{/other_user}","gists_url":"https://api.github.com/users/gmajoulet/gists{/gist_id}","starred_url":"https://api.github.com/users/gmajoulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmajoulet/subscriptions","organizations_url":"https://api.github.com/users/gmajoulet/orgs","repos_url":"https://api.github.com/users/gmajoulet/repos","events_url":"https://api.github.com/users/gmajoulet/events{/privacy}","received_events_url":"https://api.github.com/users/gmajoulet/received_events","type":"User","site_admin":false},"body":"Fixes #15057 ","created_at":"2018-05-04T19:43:24Z","updated_at":"2018-05-04T19:53:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79bcdd045aeb7f324b2a1ff79dd21e0eca841544","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":596633554,"url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/15101/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/15101/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/15101/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/cc7b8ec17b131ab1c0765d66552e26b3fa77e93e","head":{"label":"gmajoulet:gdpr_consent_not_fixed","ref":"gdpr_consent_not_fixed","sha":"cc7b8ec17b131ab1c0765d66552e26b3fa77e93e","user":{"login":"gmajoulet","id":1492044,"avatar_url":"https://avatars1.githubusercontent.com/u/1492044?v=4","gravatar_id":"","url":"https://api.github.com/users/gmajoulet","html_url":"https://github.com/gmajoulet","followers_url":"https://api.github.com/users/gmajoulet/followers","following_url":"https://api.github.com/users/gmajoulet/following{/other_user}","gists_url":"https://api.github.com/users/gmajoulet/gists{/gist_id}","starred_url":"https://api.github.com/users/gmajoulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmajoulet/subscriptions","organizations_url":"https://api.github.com/users/gmajoulet/orgs","repos_url":"https://api.github.com/users/gmajoulet/repos","events_url":"https://api.github.com/users/gmajoulet/events{/privacy}","received_events_url":"https://api.github.com/users/gmajoulet/received_events","type":"User","site_admin":false},"repo":{"id":116157484,"name":"amphtml","full_name":"gmajoulet/amphtml","owner":{"login":"gmajoulet","id":1492044,"avatar_url":"https://avatars1.githubusercontent.com/u/1492044?v=4","gravatar_id":"","url":"https://api.github.com/users/gmajoulet","html_url":"https://github.com/gmajoulet","followers_url":"https://api.github.com/users/gmajoulet/followers","following_url":"https://api.github.com/users/gmajoulet/following{/other_user}","gists_url":"https://api.github.com/users/gmajoulet/gists{/gist_id}","starred_url":"https://api.github.com/users/gmajoulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmajoulet/subscriptions","organizations_url":"https://api.github.com/users/gmajoulet/orgs","repos_url":"https://api.github.com/users/gmajoulet/repos","events_url":"https://api.github.com/users/gmajoulet/events{/privacy}","received_events_url":"https://api.github.com/users/gmajoulet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gmajoulet/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/gmajoulet/amphtml","forks_url":"https://api.github.com/repos/gmajoulet/amphtml/forks","keys_url":"https://api.github.com/repos/gmajoulet/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gmajoulet/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gmajoulet/amphtml/teams","hooks_url":"https://api.github.com/repos/gmajoulet/amphtml/hooks","issue_events_url":"https://api.github.com/repos/gmajoulet/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/gmajoulet/amphtml/events","assignees_url":"https://api.github.com/repos/gmajoulet/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/gmajoulet/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/gmajoulet/amphtml/tags","blobs_url":"https://api.github.com/repos/gmajoulet/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gmajoulet/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gmajoulet/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/gmajoulet/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gmajoulet/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/gmajoulet/amphtml/languages","stargazers_url":"https://api.github.com/repos/gmajoulet/amphtml/stargazers","contributors_url":"https://api.github.com/repos/gmajoulet/amphtml/contributors","subscribers_url":"https://api.github.com/repos/gmajoulet/amphtml/subscribers","subscription_url":"https://api.github.com/repos/gmajoulet/amphtml/subscription","commits_url":"https://api.github.com/repos/gmajoulet/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/gmajoulet/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/gmajoulet/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/gmajoulet/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/gmajoulet/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/gmajoulet/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gmajoulet/amphtml/merges","archive_url":"https://api.github.com/repos/gmajoulet/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gmajoulet/amphtml/downloads","issues_url":"https://api.github.com/repos/gmajoulet/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/gmajoulet/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/gmajoulet/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/gmajoulet/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gmajoulet/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/gmajoulet/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/gmajoulet/amphtml/deployments","created_at":"2018-01-03T16:19:49Z","updated_at":"2018-04-25T22:18:34Z","pushed_at":"2018-05-04T19:41:10Z","git_url":"git://github.com/gmajoulet/amphtml.git","ssh_url":"git@github.com:gmajoulet/amphtml.git","clone_url":"https://github.com/gmajoulet/amphtml.git","svn_url":"https://github.com/gmajoulet/amphtml","homepage":"https://www.ampproject.org","size":419221,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"777646bb18569bc5604c1ea78ef19e4cbd379b16","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-05-04T19:20:37Z","pushed_at":"2018-05-04T19:48:47Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":419175,"stargazers_count":11513,"watchers_count":11513,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2368,"mirror_url":null,"archived":false,"open_issues_count":1325,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2368,"open_issues":1325,"watchers":11513,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/15101"},"html":{"href":"https://github.com/ampproject/amphtml/pull/15101"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/15101"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/15101/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/15101/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/15101/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/cc7b8ec17b131ab1c0765d66552e26b3fa77e93e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"gmajoulet"}}