{"action":"created","comment":{"url":"https://api.github.com/repos/behnam/rust-unic/pulls/comments/170103170","pull_request_review_id":98737510,"id":170103170,"diff_hunk":"@@ -74,21 +101,49 @@ impl Name {\n     fn number_of_hex_digits(ch: char) -> usize {\n         (32 - u32::leading_zeros(ch as u32) as usize + 3) / 4\n     }\n+\n+    fn jamo_short_name(ch: char) -> &'static str {\n+        data::JAMO_SHORT_NAMES\n+            .find(ch)\n+            .expect(\"Unexpected jamo character\")\n+    }\n+\n+    fn collect_jamo_short_names(ch: char) -> [&'static str; 3] {\n+        let mut jamos = [\"\"; 3];","path":"unic/ucd/name/src/name.rs","position":82,"original_position":82,"commit_id":"dfdab37b3fbb640a53364aae8fab530f9a2a5567","original_commit_id":"dfdab37b3fbb640a53364aae8fab530f9a2a5567","user":{"login":"behnam","id":37169,"avatar_url":"https://avatars2.githubusercontent.com/u/37169?v=4","gravatar_id":"","url":"https://api.github.com/users/behnam","html_url":"https://github.com/behnam","followers_url":"https://api.github.com/users/behnam/followers","following_url":"https://api.github.com/users/behnam/following{/other_user}","gists_url":"https://api.github.com/users/behnam/gists{/gist_id}","starred_url":"https://api.github.com/users/behnam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behnam/subscriptions","organizations_url":"https://api.github.com/users/behnam/orgs","repos_url":"https://api.github.com/users/behnam/repos","events_url":"https://api.github.com/users/behnam/events{/privacy}","received_events_url":"https://api.github.com/users/behnam/received_events","type":"User","site_admin":false},"body":"Curious if using an *empty string* is the best way of doing this here. Any thoughts?","created_at":"2018-02-22T21:45:48Z","updated_at":"2018-02-22T21:55:23Z","html_url":"https://github.com/behnam/rust-unic/pull/208#discussion_r170103170","pull_request_url":"https://api.github.com/repos/behnam/rust-unic/pulls/208","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/behnam/rust-unic/pulls/comments/170103170"},"html":{"href":"https://github.com/behnam/rust-unic/pull/208#discussion_r170103170"},"pull_request":{"href":"https://api.github.com/repos/behnam/rust-unic/pulls/208"}}},"pull_request":{"url":"https://api.github.com/repos/behnam/rust-unic/pulls/208","id":170657218,"html_url":"https://github.com/behnam/rust-unic/pull/208","diff_url":"https://github.com/behnam/rust-unic/pull/208.diff","patch_url":"https://github.com/behnam/rust-unic/pull/208.patch","issue_url":"https://api.github.com/repos/behnam/rust-unic/issues/208","number":208,"state":"open","locked":false,"title":"Implement Unicode Name - NR1","user":{"login":"eyeplum","id":988437,"avatar_url":"https://avatars1.githubusercontent.com/u/988437?v=4","gravatar_id":"","url":"https://api.github.com/users/eyeplum","html_url":"https://github.com/eyeplum","followers_url":"https://api.github.com/users/eyeplum/followers","following_url":"https://api.github.com/users/eyeplum/following{/other_user}","gists_url":"https://api.github.com/users/eyeplum/gists{/gist_id}","starred_url":"https://api.github.com/users/eyeplum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyeplum/subscriptions","organizations_url":"https://api.github.com/users/eyeplum/orgs","repos_url":"https://api.github.com/users/eyeplum/repos","events_url":"https://api.github.com/users/eyeplum/events{/privacy}","received_events_url":"https://api.github.com/users/eyeplum/received_events","type":"User","site_admin":false},"body":"This pull request includes the implementation for Unicode Name - NR1 (#171).\r\n\r\n- [x] NR1: Hangul Syllables\r\n- [x] Add documentations for `unic-ucd-name`\r\n- [ ] Generate `jamo.rsv` from `Jamo.txt` (currently it's hand-coded)","created_at":"2018-02-22T04:58:35Z","updated_at":"2018-02-22T21:55:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5222944a868a8d8528f2537f7e065a7f349fe119","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/behnam/rust-unic/pulls/208/commits","review_comments_url":"https://api.github.com/repos/behnam/rust-unic/pulls/208/comments","review_comment_url":"https://api.github.com/repos/behnam/rust-unic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/behnam/rust-unic/issues/208/comments","statuses_url":"https://api.github.com/repos/behnam/rust-unic/statuses/dfdab37b3fbb640a53364aae8fab530f9a2a5567","head":{"label":"eyeplum:unicode-name","ref":"unicode-name","sha":"dfdab37b3fbb640a53364aae8fab530f9a2a5567","user":{"login":"eyeplum","id":988437,"avatar_url":"https://avatars1.githubusercontent.com/u/988437?v=4","gravatar_id":"","url":"https://api.github.com/users/eyeplum","html_url":"https://github.com/eyeplum","followers_url":"https://api.github.com/users/eyeplum/followers","following_url":"https://api.github.com/users/eyeplum/following{/other_user}","gists_url":"https://api.github.com/users/eyeplum/gists{/gist_id}","starred_url":"https://api.github.com/users/eyeplum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyeplum/subscriptions","organizations_url":"https://api.github.com/users/eyeplum/orgs","repos_url":"https://api.github.com/users/eyeplum/repos","events_url":"https://api.github.com/users/eyeplum/events{/privacy}","received_events_url":"https://api.github.com/users/eyeplum/received_events","type":"User","site_admin":false},"repo":{"id":119647588,"name":"rust-unic","full_name":"eyeplum/rust-unic","owner":{"login":"eyeplum","id":988437,"avatar_url":"https://avatars1.githubusercontent.com/u/988437?v=4","gravatar_id":"","url":"https://api.github.com/users/eyeplum","html_url":"https://github.com/eyeplum","followers_url":"https://api.github.com/users/eyeplum/followers","following_url":"https://api.github.com/users/eyeplum/following{/other_user}","gists_url":"https://api.github.com/users/eyeplum/gists{/gist_id}","starred_url":"https://api.github.com/users/eyeplum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyeplum/subscriptions","organizations_url":"https://api.github.com/users/eyeplum/orgs","repos_url":"https://api.github.com/users/eyeplum/repos","events_url":"https://api.github.com/users/eyeplum/events{/privacy}","received_events_url":"https://api.github.com/users/eyeplum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eyeplum/rust-unic","description":"UNIC: Unicode and Internationalization Crates for Rust","fork":true,"url":"https://api.github.com/repos/eyeplum/rust-unic","forks_url":"https://api.github.com/repos/eyeplum/rust-unic/forks","keys_url":"https://api.github.com/repos/eyeplum/rust-unic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eyeplum/rust-unic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eyeplum/rust-unic/teams","hooks_url":"https://api.github.com/repos/eyeplum/rust-unic/hooks","issue_events_url":"https://api.github.com/repos/eyeplum/rust-unic/issues/events{/number}","events_url":"https://api.github.com/repos/eyeplum/rust-unic/events","assignees_url":"https://api.github.com/repos/eyeplum/rust-unic/assignees{/user}","branches_url":"https://api.github.com/repos/eyeplum/rust-unic/branches{/branch}","tags_url":"https://api.github.com/repos/eyeplum/rust-unic/tags","blobs_url":"https://api.github.com/repos/eyeplum/rust-unic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eyeplum/rust-unic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eyeplum/rust-unic/git/refs{/sha}","trees_url":"https://api.github.com/repos/eyeplum/rust-unic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eyeplum/rust-unic/statuses/{sha}","languages_url":"https://api.github.com/repos/eyeplum/rust-unic/languages","stargazers_url":"https://api.github.com/repos/eyeplum/rust-unic/stargazers","contributors_url":"https://api.github.com/repos/eyeplum/rust-unic/contributors","subscribers_url":"https://api.github.com/repos/eyeplum/rust-unic/subscribers","subscription_url":"https://api.github.com/repos/eyeplum/rust-unic/subscription","commits_url":"https://api.github.com/repos/eyeplum/rust-unic/commits{/sha}","git_commits_url":"https://api.github.com/repos/eyeplum/rust-unic/git/commits{/sha}","comments_url":"https://api.github.com/repos/eyeplum/rust-unic/comments{/number}","issue_comment_url":"https://api.github.com/repos/eyeplum/rust-unic/issues/comments{/number}","contents_url":"https://api.github.com/repos/eyeplum/rust-unic/contents/{+path}","compare_url":"https://api.github.com/repos/eyeplum/rust-unic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eyeplum/rust-unic/merges","archive_url":"https://api.github.com/repos/eyeplum/rust-unic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eyeplum/rust-unic/downloads","issues_url":"https://api.github.com/repos/eyeplum/rust-unic/issues{/number}","pulls_url":"https://api.github.com/repos/eyeplum/rust-unic/pulls{/number}","milestones_url":"https://api.github.com/repos/eyeplum/rust-unic/milestones{/number}","notifications_url":"https://api.github.com/repos/eyeplum/rust-unic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eyeplum/rust-unic/labels{/name}","releases_url":"https://api.github.com/repos/eyeplum/rust-unic/releases{/id}","deployments_url":"https://api.github.com/repos/eyeplum/rust-unic/deployments","created_at":"2018-01-31T06:55:36Z","updated_at":"2018-01-31T06:55:39Z","pushed_at":"2018-02-22T06:47:54Z","git_url":"git://github.com/eyeplum/rust-unic.git","ssh_url":"git@github.com:eyeplum/rust-unic.git","clone_url":"https://github.com/eyeplum/rust-unic.git","svn_url":"https://github.com/eyeplum/rust-unic","homepage":"https://crates.io/crates/unic","size":5428,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"behnam:master","ref":"master","sha":"d82122e420a20a02214e83be1dba338b489e27f2","user":{"login":"behnam","id":37169,"avatar_url":"https://avatars2.githubusercontent.com/u/37169?v=4","gravatar_id":"","url":"https://api.github.com/users/behnam","html_url":"https://github.com/behnam","followers_url":"https://api.github.com/users/behnam/followers","following_url":"https://api.github.com/users/behnam/following{/other_user}","gists_url":"https://api.github.com/users/behnam/gists{/gist_id}","starred_url":"https://api.github.com/users/behnam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behnam/subscriptions","organizations_url":"https://api.github.com/users/behnam/orgs","repos_url":"https://api.github.com/users/behnam/repos","events_url":"https://api.github.com/users/behnam/events{/privacy}","received_events_url":"https://api.github.com/users/behnam/received_events","type":"User","site_admin":false},"repo":{"id":94862886,"name":"rust-unic","full_name":"behnam/rust-unic","owner":{"login":"behnam","id":37169,"avatar_url":"https://avatars2.githubusercontent.com/u/37169?v=4","gravatar_id":"","url":"https://api.github.com/users/behnam","html_url":"https://github.com/behnam","followers_url":"https://api.github.com/users/behnam/followers","following_url":"https://api.github.com/users/behnam/following{/other_user}","gists_url":"https://api.github.com/users/behnam/gists{/gist_id}","starred_url":"https://api.github.com/users/behnam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behnam/subscriptions","organizations_url":"https://api.github.com/users/behnam/orgs","repos_url":"https://api.github.com/users/behnam/repos","events_url":"https://api.github.com/users/behnam/events{/privacy}","received_events_url":"https://api.github.com/users/behnam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/behnam/rust-unic","description":"UNIC: Unicode and Internationalization Crates for Rust","fork":false,"url":"https://api.github.com/repos/behnam/rust-unic","forks_url":"https://api.github.com/repos/behnam/rust-unic/forks","keys_url":"https://api.github.com/repos/behnam/rust-unic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/behnam/rust-unic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/behnam/rust-unic/teams","hooks_url":"https://api.github.com/repos/behnam/rust-unic/hooks","issue_events_url":"https://api.github.com/repos/behnam/rust-unic/issues/events{/number}","events_url":"https://api.github.com/repos/behnam/rust-unic/events","assignees_url":"https://api.github.com/repos/behnam/rust-unic/assignees{/user}","branches_url":"https://api.github.com/repos/behnam/rust-unic/branches{/branch}","tags_url":"https://api.github.com/repos/behnam/rust-unic/tags","blobs_url":"https://api.github.com/repos/behnam/rust-unic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/behnam/rust-unic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/behnam/rust-unic/git/refs{/sha}","trees_url":"https://api.github.com/repos/behnam/rust-unic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/behnam/rust-unic/statuses/{sha}","languages_url":"https://api.github.com/repos/behnam/rust-unic/languages","stargazers_url":"https://api.github.com/repos/behnam/rust-unic/stargazers","contributors_url":"https://api.github.com/repos/behnam/rust-unic/contributors","subscribers_url":"https://api.github.com/repos/behnam/rust-unic/subscribers","subscription_url":"https://api.github.com/repos/behnam/rust-unic/subscription","commits_url":"https://api.github.com/repos/behnam/rust-unic/commits{/sha}","git_commits_url":"https://api.github.com/repos/behnam/rust-unic/git/commits{/sha}","comments_url":"https://api.github.com/repos/behnam/rust-unic/comments{/number}","issue_comment_url":"https://api.github.com/repos/behnam/rust-unic/issues/comments{/number}","contents_url":"https://api.github.com/repos/behnam/rust-unic/contents/{+path}","compare_url":"https://api.github.com/repos/behnam/rust-unic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/behnam/rust-unic/merges","archive_url":"https://api.github.com/repos/behnam/rust-unic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/behnam/rust-unic/downloads","issues_url":"https://api.github.com/repos/behnam/rust-unic/issues{/number}","pulls_url":"https://api.github.com/repos/behnam/rust-unic/pulls{/number}","milestones_url":"https://api.github.com/repos/behnam/rust-unic/milestones{/number}","notifications_url":"https://api.github.com/repos/behnam/rust-unic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/behnam/rust-unic/labels{/name}","releases_url":"https://api.github.com/repos/behnam/rust-unic/releases{/id}","deployments_url":"https://api.github.com/repos/behnam/rust-unic/deployments","created_at":"2017-06-20T07:33:45Z","updated_at":"2018-02-20T08:05:33Z","pushed_at":"2018-02-22T06:47:55Z","git_url":"git://github.com/behnam/rust-unic.git","ssh_url":"git@github.com:behnam/rust-unic.git","clone_url":"https://github.com/behnam/rust-unic.git","svn_url":"https://github.com/behnam/rust-unic","homepage":"https://crates.io/crates/unic","size":5416,"stargazers_count":58,"watchers_count":58,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":11,"open_issues":33,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/behnam/rust-unic/pulls/208"},"html":{"href":"https://github.com/behnam/rust-unic/pull/208"},"issue":{"href":"https://api.github.com/repos/behnam/rust-unic/issues/208"},"comments":{"href":"https://api.github.com/repos/behnam/rust-unic/issues/208/comments"},"review_comments":{"href":"https://api.github.com/repos/behnam/rust-unic/pulls/208/comments"},"review_comment":{"href":"https://api.github.com/repos/behnam/rust-unic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/behnam/rust-unic/pulls/208/commits"},"statuses":{"href":"https://api.github.com/repos/behnam/rust-unic/statuses/dfdab37b3fbb640a53364aae8fab530f9a2a5567"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"behnam"}}