{"action":"created","comment":{"url":"https://api.github.com/repos/pypeit/PypeIt/pulls/comments/232095254","pull_request_review_id":173214024,"id":232095254,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjA5NTI1NA==","diff_hunk":"@@ -18,18 +18,19 @@\n \n import pkg_resources\n \n-def test_setup_param():\n-    \"\"\" Run the parameter setup script\n-    \n-    Returns\n-    -------\n-    \"\"\"\n-    spectrograph = load_spectrograph('shane_kast_blue')\n-    fitstbl = metadata.dummy_fitstbl()\n-    # Run\n-    arcparm = arc.setup_param(spectrograph, (2048,2048), fitstbl, 0)\n-    for key in ['llist','disp','wvmnx']:\n-        assert key in arcparm\n+# JFH comementing out this test since the arcparm is now defunct.\n+#def test_setup_param():","path":"pypeit/tests/test_arc.py","position":17,"original_position":17,"commit_id":"53b80a31c23deab1c5b90e4e467827aa30ba30e7","original_commit_id":"53b80a31c23deab1c5b90e4e467827aa30ba30e7","user":{"login":"profxj","id":3998093,"node_id":"MDQ6VXNlcjM5OTgwOTM=","avatar_url":"https://avatars2.githubusercontent.com/u/3998093?v=4","gravatar_id":"","url":"https://api.github.com/users/profxj","html_url":"https://github.com/profxj","followers_url":"https://api.github.com/users/profxj/followers","following_url":"https://api.github.com/users/profxj/following{/other_user}","gists_url":"https://api.github.com/users/profxj/gists{/gist_id}","starred_url":"https://api.github.com/users/profxj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/profxj/subscriptions","organizations_url":"https://api.github.com/users/profxj/orgs","repos_url":"https://api.github.com/users/profxj/repos","events_url":"https://api.github.com/users/profxj/events{/privacy}","received_events_url":"https://api.github.com/users/profxj/received_events","type":"User","site_admin":false},"body":"might as well just remove this test altogether.","created_at":"2018-11-08T23:15:08Z","updated_at":"2018-11-08T23:19:21Z","html_url":"https://github.com/pypeit/PypeIt/pull/539#discussion_r232095254","pull_request_url":"https://api.github.com/repos/pypeit/PypeIt/pulls/539","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/pypeit/PypeIt/pulls/comments/232095254"},"html":{"href":"https://github.com/pypeit/PypeIt/pull/539#discussion_r232095254"},"pull_request":{"href":"https://api.github.com/repos/pypeit/PypeIt/pulls/539"}}},"pull_request":{"url":"https://api.github.com/repos/pypeit/PypeIt/pulls/539","id":228199392,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTk5Mzky","html_url":"https://github.com/pypeit/PypeIt/pull/539","diff_url":"https://github.com/pypeit/PypeIt/pull/539.diff","patch_url":"https://github.com/pypeit/PypeIt/pull/539.patch","issue_url":"https://api.github.com/repos/pypeit/PypeIt/issues/539","number":539,"state":"open","locked":false,"title":"Fixing masters","user":{"login":"jhennawi","id":8774563,"node_id":"MDQ6VXNlcjg3NzQ1NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8774563?v=4","gravatar_id":"","url":"https://api.github.com/users/jhennawi","html_url":"https://github.com/jhennawi","followers_url":"https://api.github.com/users/jhennawi/followers","following_url":"https://api.github.com/users/jhennawi/following{/other_user}","gists_url":"https://api.github.com/users/jhennawi/gists{/gist_id}","starred_url":"https://api.github.com/users/jhennawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhennawi/subscriptions","organizations_url":"https://api.github.com/users/jhennawi/orgs","repos_url":"https://api.github.com/users/jhennawi/repos","events_url":"https://api.github.com/users/jhennawi/events{/privacy}","received_events_url":"https://api.github.com/users/jhennawi/received_events","type":"User","site_admin":false},"body":"This PR attempts to streamline, simplify and homogenize the treatment of masters in the base classes.Most of the confusion in dealing with the master frames is due to the fact that there are like five different functions that wrap five other different functions, making the logical flow very difficult to follow. Furthermore it is ambiguous which methods of the masterframe class children of that class should overload.  Here is a summary of the changes that have been made:\r\n\r\n1) The core.masters module is now deprecated. These codes are now moved to the masterframe class.   The functionality in core.masters that were master frame specific are now moved to the child classes of masterframe by simply overloading the respective load_master or save_master routines. \r\n\r\n2) It is much more clear now what should be overloaded in child class of masterframe. Basically the developer should only ever overload the load_master or save_master methods. \r\n\r\n3) The master() method is now not to be overloaded since it is generic code that is always executed. Some child classes were executing code in their master method which was actually not dealing with masters or was doing higher level master related things.  This made it very confusing how to overload and what was being overloaded. This code has been moved or renamed such that the master methods only ever deal with reading in or saving master files. \r\n\r\n4. There are also major bug fixes which gets wavelengths working again after changes to  arclines broke it. I think this happened during @profxj gmos PR but am not sure. \r\n\r\nAll tests and the dev suite are passing on my machine. \r\n\r\nJoe","created_at":"2018-11-04T20:09:36Z","updated_at":"2018-11-08T23:19:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef176ff4e5aba907ddbc7c4231dac2b7fa9ca0f5","assignee":{"login":"profxj","id":3998093,"node_id":"MDQ6VXNlcjM5OTgwOTM=","avatar_url":"https://avatars2.githubusercontent.com/u/3998093?v=4","gravatar_id":"","url":"https://api.github.com/users/profxj","html_url":"https://github.com/profxj","followers_url":"https://api.github.com/users/profxj/followers","following_url":"https://api.github.com/users/profxj/following{/other_user}","gists_url":"https://api.github.com/users/profxj/gists{/gist_id}","starred_url":"https://api.github.com/users/profxj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/profxj/subscriptions","organizations_url":"https://api.github.com/users/profxj/orgs","repos_url":"https://api.github.com/users/profxj/repos","events_url":"https://api.github.com/users/profxj/events{/privacy}","received_events_url":"https://api.github.com/users/profxj/received_events","type":"User","site_admin":false},"assignees":[{"login":"profxj","id":3998093,"node_id":"MDQ6VXNlcjM5OTgwOTM=","avatar_url":"https://avatars2.githubusercontent.com/u/3998093?v=4","gravatar_id":"","url":"https://api.github.com/users/profxj","html_url":"https://github.com/profxj","followers_url":"https://api.github.com/users/profxj/followers","following_url":"https://api.github.com/users/profxj/following{/other_user}","gists_url":"https://api.github.com/users/profxj/gists{/gist_id}","starred_url":"https://api.github.com/users/profxj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/profxj/subscriptions","organizations_url":"https://api.github.com/users/profxj/orgs","repos_url":"https://api.github.com/users/profxj/repos","events_url":"https://api.github.com/users/profxj/events{/privacy}","received_events_url":"https://api.github.com/users/profxj/received_events","type":"User","site_admin":false},{"login":"kbwestfall","id":15785898,"node_id":"MDQ6VXNlcjE1Nzg1ODk4","avatar_url":"https://avatars2.githubusercontent.com/u/15785898?v=4","gravatar_id":"","url":"https://api.github.com/users/kbwestfall","html_url":"https://github.com/kbwestfall","followers_url":"https://api.github.com/users/kbwestfall/followers","following_url":"https://api.github.com/users/kbwestfall/following{/other_user}","gists_url":"https://api.github.com/users/kbwestfall/gists{/gist_id}","starred_url":"https://api.github.com/users/kbwestfall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbwestfall/subscriptions","organizations_url":"https://api.github.com/users/kbwestfall/orgs","repos_url":"https://api.github.com/users/kbwestfall/repos","events_url":"https://api.github.com/users/kbwestfall/events{/privacy}","received_events_url":"https://api.github.com/users/kbwestfall/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pypeit/PypeIt/pulls/539/commits","review_comments_url":"https://api.github.com/repos/pypeit/PypeIt/pulls/539/comments","review_comment_url":"https://api.github.com/repos/pypeit/PypeIt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pypeit/PypeIt/issues/539/comments","statuses_url":"https://api.github.com/repos/pypeit/PypeIt/statuses/53b80a31c23deab1c5b90e4e467827aa30ba30e7","head":{"label":"pypeit:master_of_disaster","ref":"master_of_disaster","sha":"53b80a31c23deab1c5b90e4e467827aa30ba30e7","user":{"login":"pypeit","id":41153172,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMTUzMTcy","avatar_url":"https://avatars1.githubusercontent.com/u/41153172?v=4","gravatar_id":"","url":"https://api.github.com/users/pypeit","html_url":"https://github.com/pypeit","followers_url":"https://api.github.com/users/pypeit/followers","following_url":"https://api.github.com/users/pypeit/following{/other_user}","gists_url":"https://api.github.com/users/pypeit/gists{/gist_id}","starred_url":"https://api.github.com/users/pypeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypeit/subscriptions","organizations_url":"https://api.github.com/users/pypeit/orgs","repos_url":"https://api.github.com/users/pypeit/repos","events_url":"https://api.github.com/users/pypeit/events{/privacy}","received_events_url":"https://api.github.com/users/pypeit/received_events","type":"Organization","site_admin":false},"repo":{"id":36958428,"node_id":"MDEwOlJlcG9zaXRvcnkzNjk1ODQyOA==","name":"PypeIt","full_name":"pypeit/PypeIt","private":false,"owner":{"login":"pypeit","id":41153172,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMTUzMTcy","avatar_url":"https://avatars1.githubusercontent.com/u/41153172?v=4","gravatar_id":"","url":"https://api.github.com/users/pypeit","html_url":"https://github.com/pypeit","followers_url":"https://api.github.com/users/pypeit/followers","following_url":"https://api.github.com/users/pypeit/following{/other_user}","gists_url":"https://api.github.com/users/pypeit/gists{/gist_id}","starred_url":"https://api.github.com/users/pypeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypeit/subscriptions","organizations_url":"https://api.github.com/users/pypeit/orgs","repos_url":"https://api.github.com/users/pypeit/repos","events_url":"https://api.github.com/users/pypeit/events{/privacy}","received_events_url":"https://api.github.com/users/pypeit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pypeit/PypeIt","description":"The Python Spectroscopic Data Reduction Pipeline","fork":false,"url":"https://api.github.com/repos/pypeit/PypeIt","forks_url":"https://api.github.com/repos/pypeit/PypeIt/forks","keys_url":"https://api.github.com/repos/pypeit/PypeIt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pypeit/PypeIt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pypeit/PypeIt/teams","hooks_url":"https://api.github.com/repos/pypeit/PypeIt/hooks","issue_events_url":"https://api.github.com/repos/pypeit/PypeIt/issues/events{/number}","events_url":"https://api.github.com/repos/pypeit/PypeIt/events","assignees_url":"https://api.github.com/repos/pypeit/PypeIt/assignees{/user}","branches_url":"https://api.github.com/repos/pypeit/PypeIt/branches{/branch}","tags_url":"https://api.github.com/repos/pypeit/PypeIt/tags","blobs_url":"https://api.github.com/repos/pypeit/PypeIt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pypeit/PypeIt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pypeit/PypeIt/git/refs{/sha}","trees_url":"https://api.github.com/repos/pypeit/PypeIt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pypeit/PypeIt/statuses/{sha}","languages_url":"https://api.github.com/repos/pypeit/PypeIt/languages","stargazers_url":"https://api.github.com/repos/pypeit/PypeIt/stargazers","contributors_url":"https://api.github.com/repos/pypeit/PypeIt/contributors","subscribers_url":"https://api.github.com/repos/pypeit/PypeIt/subscribers","subscription_url":"https://api.github.com/repos/pypeit/PypeIt/subscription","commits_url":"https://api.github.com/repos/pypeit/PypeIt/commits{/sha}","git_commits_url":"https://api.github.com/repos/pypeit/PypeIt/git/commits{/sha}","comments_url":"https://api.github.com/repos/pypeit/PypeIt/comments{/number}","issue_comment_url":"https://api.github.com/repos/pypeit/PypeIt/issues/comments{/number}","contents_url":"https://api.github.com/repos/pypeit/PypeIt/contents/{+path}","compare_url":"https://api.github.com/repos/pypeit/PypeIt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pypeit/PypeIt/merges","archive_url":"https://api.github.com/repos/pypeit/PypeIt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pypeit/PypeIt/downloads","issues_url":"https://api.github.com/repos/pypeit/PypeIt/issues{/number}","pulls_url":"https://api.github.com/repos/pypeit/PypeIt/pulls{/number}","milestones_url":"https://api.github.com/repos/pypeit/PypeIt/milestones{/number}","notifications_url":"https://api.github.com/repos/pypeit/PypeIt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pypeit/PypeIt/labels{/name}","releases_url":"https://api.github.com/repos/pypeit/PypeIt/releases{/id}","deployments_url":"https://api.github.com/repos/pypeit/PypeIt/deployments","created_at":"2015-06-05T22:25:37Z","updated_at":"2018-11-08T21:18:37Z","pushed_at":"2018-11-08T19:42:37Z","git_url":"git://github.com/pypeit/PypeIt.git","ssh_url":"git@github.com:pypeit/PypeIt.git","clone_url":"https://github.com/pypeit/PypeIt.git","svn_url":"https://github.com/pypeit/PypeIt","homepage":null,"size":34796,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":104,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":12,"open_issues":104,"watchers":18,"default_branch":"master"}},"base":{"label":"pypeit:master","ref":"master","sha":"2df6fbd221d0e652391a5c438e24400d3879fc55","user":{"login":"pypeit","id":41153172,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMTUzMTcy","avatar_url":"https://avatars1.githubusercontent.com/u/41153172?v=4","gravatar_id":"","url":"https://api.github.com/users/pypeit","html_url":"https://github.com/pypeit","followers_url":"https://api.github.com/users/pypeit/followers","following_url":"https://api.github.com/users/pypeit/following{/other_user}","gists_url":"https://api.github.com/users/pypeit/gists{/gist_id}","starred_url":"https://api.github.com/users/pypeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypeit/subscriptions","organizations_url":"https://api.github.com/users/pypeit/orgs","repos_url":"https://api.github.com/users/pypeit/repos","events_url":"https://api.github.com/users/pypeit/events{/privacy}","received_events_url":"https://api.github.com/users/pypeit/received_events","type":"Organization","site_admin":false},"repo":{"id":36958428,"node_id":"MDEwOlJlcG9zaXRvcnkzNjk1ODQyOA==","name":"PypeIt","full_name":"pypeit/PypeIt","private":false,"owner":{"login":"pypeit","id":41153172,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMTUzMTcy","avatar_url":"https://avatars1.githubusercontent.com/u/41153172?v=4","gravatar_id":"","url":"https://api.github.com/users/pypeit","html_url":"https://github.com/pypeit","followers_url":"https://api.github.com/users/pypeit/followers","following_url":"https://api.github.com/users/pypeit/following{/other_user}","gists_url":"https://api.github.com/users/pypeit/gists{/gist_id}","starred_url":"https://api.github.com/users/pypeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypeit/subscriptions","organizations_url":"https://api.github.com/users/pypeit/orgs","repos_url":"https://api.github.com/users/pypeit/repos","events_url":"https://api.github.com/users/pypeit/events{/privacy}","received_events_url":"https://api.github.com/users/pypeit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pypeit/PypeIt","description":"The Python Spectroscopic Data Reduction Pipeline","fork":false,"url":"https://api.github.com/repos/pypeit/PypeIt","forks_url":"https://api.github.com/repos/pypeit/PypeIt/forks","keys_url":"https://api.github.com/repos/pypeit/PypeIt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pypeit/PypeIt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pypeit/PypeIt/teams","hooks_url":"https://api.github.com/repos/pypeit/PypeIt/hooks","issue_events_url":"https://api.github.com/repos/pypeit/PypeIt/issues/events{/number}","events_url":"https://api.github.com/repos/pypeit/PypeIt/events","assignees_url":"https://api.github.com/repos/pypeit/PypeIt/assignees{/user}","branches_url":"https://api.github.com/repos/pypeit/PypeIt/branches{/branch}","tags_url":"https://api.github.com/repos/pypeit/PypeIt/tags","blobs_url":"https://api.github.com/repos/pypeit/PypeIt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pypeit/PypeIt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pypeit/PypeIt/git/refs{/sha}","trees_url":"https://api.github.com/repos/pypeit/PypeIt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pypeit/PypeIt/statuses/{sha}","languages_url":"https://api.github.com/repos/pypeit/PypeIt/languages","stargazers_url":"https://api.github.com/repos/pypeit/PypeIt/stargazers","contributors_url":"https://api.github.com/repos/pypeit/PypeIt/contributors","subscribers_url":"https://api.github.com/repos/pypeit/PypeIt/subscribers","subscription_url":"https://api.github.com/repos/pypeit/PypeIt/subscription","commits_url":"https://api.github.com/repos/pypeit/PypeIt/commits{/sha}","git_commits_url":"https://api.github.com/repos/pypeit/PypeIt/git/commits{/sha}","comments_url":"https://api.github.com/repos/pypeit/PypeIt/comments{/number}","issue_comment_url":"https://api.github.com/repos/pypeit/PypeIt/issues/comments{/number}","contents_url":"https://api.github.com/repos/pypeit/PypeIt/contents/{+path}","compare_url":"https://api.github.com/repos/pypeit/PypeIt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pypeit/PypeIt/merges","archive_url":"https://api.github.com/repos/pypeit/PypeIt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pypeit/PypeIt/downloads","issues_url":"https://api.github.com/repos/pypeit/PypeIt/issues{/number}","pulls_url":"https://api.github.com/repos/pypeit/PypeIt/pulls{/number}","milestones_url":"https://api.github.com/repos/pypeit/PypeIt/milestones{/number}","notifications_url":"https://api.github.com/repos/pypeit/PypeIt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pypeit/PypeIt/labels{/name}","releases_url":"https://api.github.com/repos/pypeit/PypeIt/releases{/id}","deployments_url":"https://api.github.com/repos/pypeit/PypeIt/deployments","created_at":"2015-06-05T22:25:37Z","updated_at":"2018-11-08T21:18:37Z","pushed_at":"2018-11-08T19:42:37Z","git_url":"git://github.com/pypeit/PypeIt.git","ssh_url":"git@github.com:pypeit/PypeIt.git","clone_url":"https://github.com/pypeit/PypeIt.git","svn_url":"https://github.com/pypeit/PypeIt","homepage":null,"size":34796,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":104,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":12,"open_issues":104,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pypeit/PypeIt/pulls/539"},"html":{"href":"https://github.com/pypeit/PypeIt/pull/539"},"issue":{"href":"https://api.github.com/repos/pypeit/PypeIt/issues/539"},"comments":{"href":"https://api.github.com/repos/pypeit/PypeIt/issues/539/comments"},"review_comments":{"href":"https://api.github.com/repos/pypeit/PypeIt/pulls/539/comments"},"review_comment":{"href":"https://api.github.com/repos/pypeit/PypeIt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pypeit/PypeIt/pulls/539/commits"},"statuses":{"href":"https://api.github.com/repos/pypeit/PypeIt/statuses/53b80a31c23deab1c5b90e4e467827aa30ba30e7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"profxj"}}