{"action":"created","comment":{"url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/comments/166352809","pull_request_review_id":94401919,"id":166352809,"diff_hunk":"@@ -0,0 +1,345 @@\n+package design\n+\n+import (\n+\td \"github.com/goadesign/goa/design\"\n+\ta \"github.com/goadesign/goa/design/apidsl\"\n+)\n+\n+// SimpleSpace describe a space\n+var simpleSpace = a.Type(\"SimpleSpace\", func() {\n+\ta.Description(`a space consisting of multiple applications`)\n+\ta.Attribute(\"type\", d.String, \"The type of the related resource\", func() {\n+\t\ta.Enum(\"space\")\n+\t\ta.Default(\"space\")\n+\t})\n+\ta.Attribute(\"id\", d.UUID, \"ID of the space\", func() {\n+\t\ta.Example(\"40bbdd3d-8b5d-4fd6-ac90-7236b669af04\")\n+\t})\n+\ta.Attribute(\"attributes\", simpleSpaceAttributes)\n+\ta.Required(\"type\", \"id\", \"attributes\")\n+})\n+\n+var simpleSpaceAttributes = a.Type(\"SimpleSpaceAttributes\", func() {\n+\ta.Description(`a space consisting of multiple applications`)\n+\ta.Attribute(\"name\", d.String)","path":"design/deployments.go","position":24,"original_position":24,"commit_id":"9d472654525af29b0a4316ccb23f2051d1181cdb","original_commit_id":"d1381732b91d8eae847b2c7090098fa8eef85d44","user":{"login":"xcoulon","id":178502,"avatar_url":"https://avatars2.githubusercontent.com/u/178502?v=4","gravatar_id":"","url":"https://api.github.com/users/xcoulon","html_url":"https://github.com/xcoulon","followers_url":"https://api.github.com/users/xcoulon/followers","following_url":"https://api.github.com/users/xcoulon/following{/other_user}","gists_url":"https://api.github.com/users/xcoulon/gists{/gist_id}","starred_url":"https://api.github.com/users/xcoulon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcoulon/subscriptions","organizations_url":"https://api.github.com/users/xcoulon/orgs","repos_url":"https://api.github.com/users/xcoulon/repos","events_url":"https://api.github.com/users/xcoulon/events{/privacy}","received_events_url":"https://api.github.com/users/xcoulon/received_events","type":"User","site_admin":false},"body":"ok","created_at":"2018-02-06T16:08:33Z","updated_at":"2018-02-06T16:08:33Z","html_url":"https://github.com/fabric8-services/fabric8-wit/pull/1870#discussion_r166352809","pull_request_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/1870","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/comments/166352809"},"html":{"href":"https://github.com/fabric8-services/fabric8-wit/pull/1870#discussion_r166352809"},"pull_request":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/1870"}},"in_reply_to_id":165300042},"pull_request":{"url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/1870","id":165430657,"html_url":"https://github.com/fabric8-services/fabric8-wit/pull/1870","diff_url":"https://github.com/fabric8-services/fabric8-wit/pull/1870.diff","patch_url":"https://github.com/fabric8-services/fabric8-wit/pull/1870.patch","issue_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/1870","number":1870,"state":"open","locked":false,"title":"Make /apps API JSON-API conformant (Issue #1848)","user":{"login":"stooke","id":28760513,"avatar_url":"https://avatars3.githubusercontent.com/u/28760513?v=4","gravatar_id":"","url":"https://api.github.com/users/stooke","html_url":"https://github.com/stooke","followers_url":"https://api.github.com/users/stooke/followers","following_url":"https://api.github.com/users/stooke/following{/other_user}","gists_url":"https://api.github.com/users/stooke/gists{/gist_id}","starred_url":"https://api.github.com/users/stooke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stooke/subscriptions","organizations_url":"https://api.github.com/users/stooke/orgs","repos_url":"https://api.github.com/users/stooke/repos","events_url":"https://api.github.com/users/stooke/events{/privacy}","received_events_url":"https://api.github.com/users/stooke/received_events","type":"User","site_admin":false},"body":"Addresses issue #1848\r\n\r\nThis PR adds JSON-API conformance to the following endpoints (used on the Deployments page UI):\r\n\r\n/deployments/environments/{envName}\r\n/deployments/environments/{envName}/applications/{appName}/pods\r\n/deployments/spaces/{spaceID}\r\n/deployments/spaces/{spaceID}/environments\r\n/deployments/spaces/{spaceID}/applications/{appName}\r\n/deployments/spaces/{spaceID}/applications/{appName}/deployments/{deployName}\r\n/deployments/spaces/{spaceID}/applications/{appName}/deployments/{deployName} (PUT)\r\n/deployments/spaces/{spaceID}/applications/{appName}/deployments/{deployName}/stats\r\n/deployments/spaces/{spaceID}/applications/{appName}/deployments/{deployName}/statseries\r\n\r\nThe intent is that a future PR will delete the /apps endpoint and code, once the UI has been deployed using this new endpoint.\r\n\r\nThis PR replaces PR #1849.\r\n","created_at":"2018-01-26T18:32:07Z","updated_at":"2018-02-06T16:08:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcd53f7c0f4842bb95a5bd6d1bca3fba81f436d1","assignee":{"login":"ebaron","id":4326090,"avatar_url":"https://avatars3.githubusercontent.com/u/4326090?v=4","gravatar_id":"","url":"https://api.github.com/users/ebaron","html_url":"https://github.com/ebaron","followers_url":"https://api.github.com/users/ebaron/followers","following_url":"https://api.github.com/users/ebaron/following{/other_user}","gists_url":"https://api.github.com/users/ebaron/gists{/gist_id}","starred_url":"https://api.github.com/users/ebaron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebaron/subscriptions","organizations_url":"https://api.github.com/users/ebaron/orgs","repos_url":"https://api.github.com/users/ebaron/repos","events_url":"https://api.github.com/users/ebaron/events{/privacy}","received_events_url":"https://api.github.com/users/ebaron/received_events","type":"User","site_admin":false},"assignees":[{"login":"ebaron","id":4326090,"avatar_url":"https://avatars3.githubusercontent.com/u/4326090?v=4","gravatar_id":"","url":"https://api.github.com/users/ebaron","html_url":"https://github.com/ebaron","followers_url":"https://api.github.com/users/ebaron/followers","following_url":"https://api.github.com/users/ebaron/following{/other_user}","gists_url":"https://api.github.com/users/ebaron/gists{/gist_id}","starred_url":"https://api.github.com/users/ebaron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebaron/subscriptions","organizations_url":"https://api.github.com/users/ebaron/orgs","repos_url":"https://api.github.com/users/ebaron/repos","events_url":"https://api.github.com/users/ebaron/events{/privacy}","received_events_url":"https://api.github.com/users/ebaron/received_events","type":"User","site_admin":false},{"login":"stooke","id":28760513,"avatar_url":"https://avatars3.githubusercontent.com/u/28760513?v=4","gravatar_id":"","url":"https://api.github.com/users/stooke","html_url":"https://github.com/stooke","followers_url":"https://api.github.com/users/stooke/followers","following_url":"https://api.github.com/users/stooke/following{/other_user}","gists_url":"https://api.github.com/users/stooke/gists{/gist_id}","starred_url":"https://api.github.com/users/stooke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stooke/subscriptions","organizations_url":"https://api.github.com/users/stooke/orgs","repos_url":"https://api.github.com/users/stooke/repos","events_url":"https://api.github.com/users/stooke/events{/privacy}","received_events_url":"https://api.github.com/users/stooke/received_events","type":"User","site_admin":false},{"login":"c-koehler","id":33262856,"avatar_url":"https://avatars3.githubusercontent.com/u/33262856?v=4","gravatar_id":"","url":"https://api.github.com/users/c-koehler","html_url":"https://github.com/c-koehler","followers_url":"https://api.github.com/users/c-koehler/followers","following_url":"https://api.github.com/users/c-koehler/following{/other_user}","gists_url":"https://api.github.com/users/c-koehler/gists{/gist_id}","starred_url":"https://api.github.com/users/c-koehler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-koehler/subscriptions","organizations_url":"https://api.github.com/users/c-koehler/orgs","repos_url":"https://api.github.com/users/c-koehler/repos","events_url":"https://api.github.com/users/c-koehler/events{/privacy}","received_events_url":"https://api.github.com/users/c-koehler/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/1870/commits","review_comments_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/1870/comments","review_comment_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/1870/comments","statuses_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/statuses/9d472654525af29b0a4316ccb23f2051d1181cdb","head":{"label":"stooke:jstjson","ref":"jstjson","sha":"9d472654525af29b0a4316ccb23f2051d1181cdb","user":{"login":"stooke","id":28760513,"avatar_url":"https://avatars3.githubusercontent.com/u/28760513?v=4","gravatar_id":"","url":"https://api.github.com/users/stooke","html_url":"https://github.com/stooke","followers_url":"https://api.github.com/users/stooke/followers","following_url":"https://api.github.com/users/stooke/following{/other_user}","gists_url":"https://api.github.com/users/stooke/gists{/gist_id}","starred_url":"https://api.github.com/users/stooke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stooke/subscriptions","organizations_url":"https://api.github.com/users/stooke/orgs","repos_url":"https://api.github.com/users/stooke/repos","events_url":"https://api.github.com/users/stooke/events{/privacy}","received_events_url":"https://api.github.com/users/stooke/received_events","type":"User","site_admin":false},"repo":{"id":112378509,"name":"fabric8-wit","full_name":"stooke/fabric8-wit","owner":{"login":"stooke","id":28760513,"avatar_url":"https://avatars3.githubusercontent.com/u/28760513?v=4","gravatar_id":"","url":"https://api.github.com/users/stooke","html_url":"https://github.com/stooke","followers_url":"https://api.github.com/users/stooke/followers","following_url":"https://api.github.com/users/stooke/following{/other_user}","gists_url":"https://api.github.com/users/stooke/gists{/gist_id}","starred_url":"https://api.github.com/users/stooke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stooke/subscriptions","organizations_url":"https://api.github.com/users/stooke/orgs","repos_url":"https://api.github.com/users/stooke/repos","events_url":"https://api.github.com/users/stooke/events{/privacy}","received_events_url":"https://api.github.com/users/stooke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stooke/fabric8-wit","description":null,"fork":true,"url":"https://api.github.com/repos/stooke/fabric8-wit","forks_url":"https://api.github.com/repos/stooke/fabric8-wit/forks","keys_url":"https://api.github.com/repos/stooke/fabric8-wit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stooke/fabric8-wit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stooke/fabric8-wit/teams","hooks_url":"https://api.github.com/repos/stooke/fabric8-wit/hooks","issue_events_url":"https://api.github.com/repos/stooke/fabric8-wit/issues/events{/number}","events_url":"https://api.github.com/repos/stooke/fabric8-wit/events","assignees_url":"https://api.github.com/repos/stooke/fabric8-wit/assignees{/user}","branches_url":"https://api.github.com/repos/stooke/fabric8-wit/branches{/branch}","tags_url":"https://api.github.com/repos/stooke/fabric8-wit/tags","blobs_url":"https://api.github.com/repos/stooke/fabric8-wit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stooke/fabric8-wit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stooke/fabric8-wit/git/refs{/sha}","trees_url":"https://api.github.com/repos/stooke/fabric8-wit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stooke/fabric8-wit/statuses/{sha}","languages_url":"https://api.github.com/repos/stooke/fabric8-wit/languages","stargazers_url":"https://api.github.com/repos/stooke/fabric8-wit/stargazers","contributors_url":"https://api.github.com/repos/stooke/fabric8-wit/contributors","subscribers_url":"https://api.github.com/repos/stooke/fabric8-wit/subscribers","subscription_url":"https://api.github.com/repos/stooke/fabric8-wit/subscription","commits_url":"https://api.github.com/repos/stooke/fabric8-wit/commits{/sha}","git_commits_url":"https://api.github.com/repos/stooke/fabric8-wit/git/commits{/sha}","comments_url":"https://api.github.com/repos/stooke/fabric8-wit/comments{/number}","issue_comment_url":"https://api.github.com/repos/stooke/fabric8-wit/issues/comments{/number}","contents_url":"https://api.github.com/repos/stooke/fabric8-wit/contents/{+path}","compare_url":"https://api.github.com/repos/stooke/fabric8-wit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stooke/fabric8-wit/merges","archive_url":"https://api.github.com/repos/stooke/fabric8-wit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stooke/fabric8-wit/downloads","issues_url":"https://api.github.com/repos/stooke/fabric8-wit/issues{/number}","pulls_url":"https://api.github.com/repos/stooke/fabric8-wit/pulls{/number}","milestones_url":"https://api.github.com/repos/stooke/fabric8-wit/milestones{/number}","notifications_url":"https://api.github.com/repos/stooke/fabric8-wit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stooke/fabric8-wit/labels{/name}","releases_url":"https://api.github.com/repos/stooke/fabric8-wit/releases{/id}","deployments_url":"https://api.github.com/repos/stooke/fabric8-wit/deployments","created_at":"2017-11-28T19:19:52Z","updated_at":"2017-11-28T19:19:56Z","pushed_at":"2018-02-05T21:42:24Z","git_url":"git://github.com/stooke/fabric8-wit.git","ssh_url":"git@github.com:stooke/fabric8-wit.git","clone_url":"https://github.com/stooke/fabric8-wit.git","svn_url":"https://github.com/stooke/fabric8-wit","homepage":"http://devdoc.almighty.io/","size":7440,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8-services:master","ref":"master","sha":"37ee032edc3501e7a29d3e69ca5637f8de80692d","user":{"login":"fabric8-services","id":29751612,"avatar_url":"https://avatars1.githubusercontent.com/u/29751612?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-services","html_url":"https://github.com/fabric8-services","followers_url":"https://api.github.com/users/fabric8-services/followers","following_url":"https://api.github.com/users/fabric8-services/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-services/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-services/subscriptions","organizations_url":"https://api.github.com/users/fabric8-services/orgs","repos_url":"https://api.github.com/users/fabric8-services/repos","events_url":"https://api.github.com/users/fabric8-services/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-services/received_events","type":"Organization","site_admin":false},"repo":{"id":54260706,"name":"fabric8-wit","full_name":"fabric8-services/fabric8-wit","owner":{"login":"fabric8-services","id":29751612,"avatar_url":"https://avatars1.githubusercontent.com/u/29751612?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-services","html_url":"https://github.com/fabric8-services","followers_url":"https://api.github.com/users/fabric8-services/followers","following_url":"https://api.github.com/users/fabric8-services/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-services/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-services/subscriptions","organizations_url":"https://api.github.com/users/fabric8-services/orgs","repos_url":"https://api.github.com/users/fabric8-services/repos","events_url":"https://api.github.com/users/fabric8-services/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric8-services/fabric8-wit","description":null,"fork":false,"url":"https://api.github.com/repos/fabric8-services/fabric8-wit","forks_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/forks","keys_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/teams","hooks_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/hooks","issue_events_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/events","assignees_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/tags","blobs_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/languages","stargazers_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/stargazers","contributors_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/contributors","subscribers_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/subscribers","subscription_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/subscription","commits_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/merges","archive_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/downloads","issues_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/labels{/name}","releases_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/deployments","created_at":"2016-03-19T10:42:15Z","updated_at":"2017-12-29T13:13:12Z","pushed_at":"2018-02-06T14:18:20Z","git_url":"git://github.com/fabric8-services/fabric8-wit.git","ssh_url":"git@github.com:fabric8-services/fabric8-wit.git","clone_url":"https://github.com/fabric8-services/fabric8-wit.git","svn_url":"https://github.com/fabric8-services/fabric8-wit","homepage":"http://devdoc.almighty.io/","size":11437,"stargazers_count":35,"watchers_count":35,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":68,"mirror_url":null,"archived":false,"open_issues_count":148,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":68,"open_issues":148,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/1870"},"html":{"href":"https://github.com/fabric8-services/fabric8-wit/pull/1870"},"issue":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/1870"},"comments":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/1870/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/1870/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/1870/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/statuses/9d472654525af29b0a4316ccb23f2051d1181cdb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xcoulon"}}