{"action":"created","issue":{"url":"https://api.github.com/repos/roboll/helmfile/issues/171","repository_url":"https://api.github.com/repos/roboll/helmfile","labels_url":"https://api.github.com/repos/roboll/helmfile/issues/171/labels{/name}","comments_url":"https://api.github.com/repos/roboll/helmfile/issues/171/comments","events_url":"https://api.github.com/repos/roboll/helmfile/issues/171/events","html_url":"https://github.com/roboll/helmfile/pull/171","id":332136289,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0Njk0NDQ2","number":171,"title":"adding args to be added in helmfile along with context to be set in helmspec","user":{"login":"rmartinez3","id":5596913,"node_id":"MDQ6VXNlcjU1OTY5MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5596913?v=4","gravatar_id":"","url":"https://api.github.com/users/rmartinez3","html_url":"https://github.com/rmartinez3","followers_url":"https://api.github.com/users/rmartinez3/followers","following_url":"https://api.github.com/users/rmartinez3/following{/other_user}","gists_url":"https://api.github.com/users/rmartinez3/gists{/gist_id}","starred_url":"https://api.github.com/users/rmartinez3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmartinez3/subscriptions","organizations_url":"https://api.github.com/users/rmartinez3/orgs","repos_url":"https://api.github.com/users/rmartinez3/repos","events_url":"https://api.github.com/users/rmartinez3/events{/privacy}","received_events_url":"https://api.github.com/users/rmartinez3/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-13T19:43:26Z","updated_at":"2018-06-19T07:42:37Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/roboll/helmfile/pulls/171","html_url":"https://github.com/roboll/helmfile/pull/171","diff_url":"https://github.com/roboll/helmfile/pull/171.diff","patch_url":"https://github.com/roboll/helmfile/pull/171.patch"},"body":"This is regarding issue #114. This PR allows for args to be set in helmfile. Added section helm which \r\n args can be set ,as well as context will be set and other contributed key values later on when contributed."},"comment":{"url":"https://api.github.com/repos/roboll/helmfile/issues/comments/398305905","html_url":"https://github.com/roboll/helmfile/pull/171#issuecomment-398305905","issue_url":"https://api.github.com/repos/roboll/helmfile/issues/171","id":398305905,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODMwNTkwNQ==","user":{"login":"mumoshu","id":22009,"node_id":"MDQ6VXNlcjIyMDA5","avatar_url":"https://avatars0.githubusercontent.com/u/22009?v=4","gravatar_id":"","url":"https://api.github.com/users/mumoshu","html_url":"https://github.com/mumoshu","followers_url":"https://api.github.com/users/mumoshu/followers","following_url":"https://api.github.com/users/mumoshu/following{/other_user}","gists_url":"https://api.github.com/users/mumoshu/gists{/gist_id}","starred_url":"https://api.github.com/users/mumoshu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumoshu/subscriptions","organizations_url":"https://api.github.com/users/mumoshu/orgs","repos_url":"https://api.github.com/users/mumoshu/repos","events_url":"https://api.github.com/users/mumoshu/events{/privacy}","received_events_url":"https://api.github.com/users/mumoshu/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T07:42:36Z","updated_at":"2018-06-19T07:42:36Z","author_association":"COLLABORATOR","body":"@schollii Hi, thanks for the feedback!\r\n\r\nActually I'm fine with including `--` in the array items, because it looks natural to me after `args:` in the k8s pod spec.\r\n\r\nAnyway, we(including you and me) should be always open to add dedicated keys later. See my first proposal in https://github.com/roboll/helmfile/issues/114#issuecomment-384851216. Take `helmDefaults.args` as a dirty but a cover-all setting to get your work done today. We can later enhance helmfile to support keys like `tillerNamespace` which translates to `--tiller-namespace=yourns` as I wrote in the linked comment.\r\n\r\nWDYT?"}}
{"actor":{"display_login":"mumoshu"}}