{"action":"created","issue":{"url":"https://api.github.com/repos/python/cpython/issues/4348","repository_url":"https://api.github.com/repos/python/cpython","labels_url":"https://api.github.com/repos/python/cpython/issues/4348/labels{/name}","comments_url":"https://api.github.com/repos/python/cpython/issues/4348/comments","events_url":"https://api.github.com/repos/python/cpython/issues/4348/events","html_url":"https://github.com/python/cpython/pull/4348","id":272586089,"node_id":"MDExOlB1bGxSZXF1ZXN0MTUxNjY3OTI3","number":4348,"title":"bpo-28441: Ensures that EXE_SUFFIX is appended to the end of sys.executable on platforms that have it defined","user":{"login":"embray","id":676149,"node_id":"MDQ6VXNlcjY3NjE0OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/676149?v=4","gravatar_id":"","url":"https://api.github.com/users/embray","html_url":"https://github.com/embray","followers_url":"https://api.github.com/users/embray/followers","following_url":"https://api.github.com/users/embray/following{/other_user}","gists_url":"https://api.github.com/users/embray/gists{/gist_id}","starred_url":"https://api.github.com/users/embray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embray/subscriptions","organizations_url":"https://api.github.com/users/embray/orgs","repos_url":"https://api.github.com/users/embray/repos","events_url":"https://api.github.com/users/embray/events{/privacy}","received_events_url":"https://api.github.com/users/embray/received_events","type":"User","site_admin":false},"labels":[{"id":536945472,"node_id":"MDU6TGFiZWw1MzY5NDU0NzI=","url":"https://api.github.com/repos/python/cpython/labels/CLA%20signed","name":"CLA signed","color":"0e8a16","default":false},{"id":666979821,"node_id":"MDU6TGFiZWw2NjY5Nzk4MjE=","url":"https://api.github.com/repos/python/cpython/labels/awaiting%20review","name":"awaiting review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2017-11-09T14:36:45Z","updated_at":"2018-07-26T12:01:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/4348","html_url":"https://github.com/python/cpython/pull/4348","diff_url":"https://github.com/python/cpython/pull/4348.diff","patch_url":"https://github.com/python/cpython/pull/4348.patch"},"body":"Based on original patch by @ma8ma \r\n\r\nFixes bpo-28441.\r\n\r\nNote: This is needed to even the run the test suite on buildbots for affected platforms; e.g.:\r\n\r\n```\r\n./python.exe  ./Tools/scripts/run_tests.py -j 1 -u all -W --slowest --fail-env-changed --timeout=11700 -j2\r\n/home/embray/src/python/test-worker/3.x.test-worker/build/python -u -W default -bb -E -W error::BytesWarning -m test -r -w -j 1 -u all -W --slowest --fail-env-changed --timeout=11700 -j2\r\nTraceback (most recent call last):\r\n  File \"./Tools/scripts/run_tests.py\", line 56, in <module>\r\n    main(sys.argv[1:])\r\n  File \"./Tools/scripts/run_tests.py\", line 52, in main\r\n    os.execv(sys.executable, args)\r\nPermissionError: [Errno 13] Permission denied\r\nmake: *** [Makefile:1073: buildbottest] Error 1\r\n```\n\n<!-- issue-number: bpo-28441 -->\nhttps://bugs.python.org/issue28441\n<!-- /issue-number -->\n"},"comment":{"url":"https://api.github.com/repos/python/cpython/issues/comments/408073514","html_url":"https://github.com/python/cpython/pull/4348#issuecomment-408073514","issue_url":"https://api.github.com/repos/python/cpython/issues/4348","id":408073514,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODA3MzUxNA==","user":{"login":"embray","id":676149,"node_id":"MDQ6VXNlcjY3NjE0OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/676149?v=4","gravatar_id":"","url":"https://api.github.com/users/embray","html_url":"https://github.com/embray","followers_url":"https://api.github.com/users/embray/followers","following_url":"https://api.github.com/users/embray/following{/other_user}","gists_url":"https://api.github.com/users/embray/gists{/gist_id}","starred_url":"https://api.github.com/users/embray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embray/subscriptions","organizations_url":"https://api.github.com/users/embray/orgs","repos_url":"https://api.github.com/users/embray/repos","events_url":"https://api.github.com/users/embray/events{/privacy}","received_events_url":"https://api.github.com/users/embray/received_events","type":"User","site_admin":false},"created_at":"2018-07-26T12:01:03Z","updated_at":"2018-07-26T12:01:03Z","author_association":"CONTRIBUTOR","body":"Ok, I see.  I think, while the examples you gave like `configure CFLAGS=-O2 --with-suffix=-o2` seem like valid use cases, they're really not what this flag is meant for.  It's really only supposed to be about filename suffixes for executables, *not* appending some suffix to the python executable name itself.\r\n\r\nThere are a few possible options then:\r\n\r\n1) Add a separate configure flag for appending a suffix to the python executable filename (similar to how `--with-suffix` might currently be misused).\r\n2) Remove and/or deprecate `--with-suffix` altogether\r\n3) 1) and 2)\r\n4) Keep using `--with-suffix`, but do *not* use it to set the executable extension.  autoconf already selects the appropriate extension by seeing what the compiler outputs, so there's no good reason to override it, except in the OSX case, but  `BUILDEXEEXT` was added for that."}}
{"actor":{"display_login":"embray"}}