{"action":"opened","number":1959,"pull_request":{"url":"https://api.github.com/repos/sinonjs/sinon/pulls/1959","id":237742537,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NzQyNTM3","html_url":"https://github.com/sinonjs/sinon/pull/1959","diff_url":"https://github.com/sinonjs/sinon/pull/1959.diff","patch_url":"https://github.com/sinonjs/sinon/pull/1959.patch","issue_url":"https://api.github.com/repos/sinonjs/sinon/issues/1959","number":1959,"state":"open","locked":false,"title":"#1957 Fix passing null as an override","user":{"login":"spicalous","id":4274552,"node_id":"MDQ6VXNlcjQyNzQ1NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/4274552?v=4","gravatar_id":"","url":"https://api.github.com/users/spicalous","html_url":"https://github.com/spicalous","followers_url":"https://api.github.com/users/spicalous/followers","following_url":"https://api.github.com/users/spicalous/following{/other_user}","gists_url":"https://api.github.com/users/spicalous/gists{/gist_id}","starred_url":"https://api.github.com/users/spicalous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spicalous/subscriptions","organizations_url":"https://api.github.com/users/spicalous/orgs","repos_url":"https://api.github.com/users/spicalous/repos","events_url":"https://api.github.com/users/spicalous/events{/privacy}","received_events_url":"https://api.github.com/users/spicalous/received_events","type":"User","site_admin":false},"body":" #### Purpose (TL;DR)\r\nFix passing null as an override when invoking `sinon.createStubInstance(Class, <overrides>)`\r\n\r\nFixes #1957 \r\n\r\n #### How to verify\r\nUnit test added and can be verified with `npm test`\r\n\r\n #### Checklist for author\r\n\r\n- [x] `npm run lint` passes\r\n- [ ] ~~References to standard library functions are [cached](https://github.com/sinonjs/sinon/pull/1523).~~ N/A\r\n","created_at":"2018-12-11T16:22:58Z","updated_at":"2018-12-11T16:22:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sinonjs/sinon/pulls/1959/commits","review_comments_url":"https://api.github.com/repos/sinonjs/sinon/pulls/1959/comments","review_comment_url":"https://api.github.com/repos/sinonjs/sinon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sinonjs/sinon/issues/1959/comments","statuses_url":"https://api.github.com/repos/sinonjs/sinon/statuses/c51809f97d87ac22e0d0cf1ebd62979b1f7de1d7","head":{"label":"spicalous:bugfix/1957","ref":"bugfix/1957","sha":"c51809f97d87ac22e0d0cf1ebd62979b1f7de1d7","user":{"login":"spicalous","id":4274552,"node_id":"MDQ6VXNlcjQyNzQ1NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/4274552?v=4","gravatar_id":"","url":"https://api.github.com/users/spicalous","html_url":"https://github.com/spicalous","followers_url":"https://api.github.com/users/spicalous/followers","following_url":"https://api.github.com/users/spicalous/following{/other_user}","gists_url":"https://api.github.com/users/spicalous/gists{/gist_id}","starred_url":"https://api.github.com/users/spicalous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spicalous/subscriptions","organizations_url":"https://api.github.com/users/spicalous/orgs","repos_url":"https://api.github.com/users/spicalous/repos","events_url":"https://api.github.com/users/spicalous/events{/privacy}","received_events_url":"https://api.github.com/users/spicalous/received_events","type":"User","site_admin":false},"repo":{"id":161358961,"node_id":"MDEwOlJlcG9zaXRvcnkxNjEzNTg5NjE=","name":"sinon","full_name":"spicalous/sinon","private":false,"owner":{"login":"spicalous","id":4274552,"node_id":"MDQ6VXNlcjQyNzQ1NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/4274552?v=4","gravatar_id":"","url":"https://api.github.com/users/spicalous","html_url":"https://github.com/spicalous","followers_url":"https://api.github.com/users/spicalous/followers","following_url":"https://api.github.com/users/spicalous/following{/other_user}","gists_url":"https://api.github.com/users/spicalous/gists{/gist_id}","starred_url":"https://api.github.com/users/spicalous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spicalous/subscriptions","organizations_url":"https://api.github.com/users/spicalous/orgs","repos_url":"https://api.github.com/users/spicalous/repos","events_url":"https://api.github.com/users/spicalous/events{/privacy}","received_events_url":"https://api.github.com/users/spicalous/received_events","type":"User","site_admin":false},"html_url":"https://github.com/spicalous/sinon","description":"Test spies, stubs and mocks for JavaScript.","fork":true,"url":"https://api.github.com/repos/spicalous/sinon","forks_url":"https://api.github.com/repos/spicalous/sinon/forks","keys_url":"https://api.github.com/repos/spicalous/sinon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spicalous/sinon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spicalous/sinon/teams","hooks_url":"https://api.github.com/repos/spicalous/sinon/hooks","issue_events_url":"https://api.github.com/repos/spicalous/sinon/issues/events{/number}","events_url":"https://api.github.com/repos/spicalous/sinon/events","assignees_url":"https://api.github.com/repos/spicalous/sinon/assignees{/user}","branches_url":"https://api.github.com/repos/spicalous/sinon/branches{/branch}","tags_url":"https://api.github.com/repos/spicalous/sinon/tags","blobs_url":"https://api.github.com/repos/spicalous/sinon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spicalous/sinon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spicalous/sinon/git/refs{/sha}","trees_url":"https://api.github.com/repos/spicalous/sinon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spicalous/sinon/statuses/{sha}","languages_url":"https://api.github.com/repos/spicalous/sinon/languages","stargazers_url":"https://api.github.com/repos/spicalous/sinon/stargazers","contributors_url":"https://api.github.com/repos/spicalous/sinon/contributors","subscribers_url":"https://api.github.com/repos/spicalous/sinon/subscribers","subscription_url":"https://api.github.com/repos/spicalous/sinon/subscription","commits_url":"https://api.github.com/repos/spicalous/sinon/commits{/sha}","git_commits_url":"https://api.github.com/repos/spicalous/sinon/git/commits{/sha}","comments_url":"https://api.github.com/repos/spicalous/sinon/comments{/number}","issue_comment_url":"https://api.github.com/repos/spicalous/sinon/issues/comments{/number}","contents_url":"https://api.github.com/repos/spicalous/sinon/contents/{+path}","compare_url":"https://api.github.com/repos/spicalous/sinon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spicalous/sinon/merges","archive_url":"https://api.github.com/repos/spicalous/sinon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spicalous/sinon/downloads","issues_url":"https://api.github.com/repos/spicalous/sinon/issues{/number}","pulls_url":"https://api.github.com/repos/spicalous/sinon/pulls{/number}","milestones_url":"https://api.github.com/repos/spicalous/sinon/milestones{/number}","notifications_url":"https://api.github.com/repos/spicalous/sinon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spicalous/sinon/labels{/name}","releases_url":"https://api.github.com/repos/spicalous/sinon/releases{/id}","deployments_url":"https://api.github.com/repos/spicalous/sinon/deployments","created_at":"2018-12-11T16:02:45Z","updated_at":"2018-12-11T16:02:48Z","pushed_at":"2018-12-11T16:17:26Z","git_url":"git://github.com/spicalous/sinon.git","ssh_url":"git@github.com:spicalous/sinon.git","clone_url":"https://github.com/spicalous/sinon.git","svn_url":"https://github.com/spicalous/sinon","homepage":"https://sinonjs.org/","size":24393,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sinonjs:master","ref":"master","sha":"9741f41f94d45785daed11a129c080ea04f7f78e","user":{"login":"sinonjs","id":6570253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NzAyNTM=","avatar_url":"https://avatars3.githubusercontent.com/u/6570253?v=4","gravatar_id":"","url":"https://api.github.com/users/sinonjs","html_url":"https://github.com/sinonjs","followers_url":"https://api.github.com/users/sinonjs/followers","following_url":"https://api.github.com/users/sinonjs/following{/other_user}","gists_url":"https://api.github.com/users/sinonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/sinonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinonjs/subscriptions","organizations_url":"https://api.github.com/users/sinonjs/orgs","repos_url":"https://api.github.com/users/sinonjs/repos","events_url":"https://api.github.com/users/sinonjs/events{/privacy}","received_events_url":"https://api.github.com/users/sinonjs/received_events","type":"Organization","site_admin":false},"repo":{"id":747698,"node_id":"MDEwOlJlcG9zaXRvcnk3NDc2OTg=","name":"sinon","full_name":"sinonjs/sinon","private":false,"owner":{"login":"sinonjs","id":6570253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NzAyNTM=","avatar_url":"https://avatars3.githubusercontent.com/u/6570253?v=4","gravatar_id":"","url":"https://api.github.com/users/sinonjs","html_url":"https://github.com/sinonjs","followers_url":"https://api.github.com/users/sinonjs/followers","following_url":"https://api.github.com/users/sinonjs/following{/other_user}","gists_url":"https://api.github.com/users/sinonjs/gists{/gist_id}","starred_url":"https://api.github.com/users/sinonjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinonjs/subscriptions","organizations_url":"https://api.github.com/users/sinonjs/orgs","repos_url":"https://api.github.com/users/sinonjs/repos","events_url":"https://api.github.com/users/sinonjs/events{/privacy}","received_events_url":"https://api.github.com/users/sinonjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sinonjs/sinon","description":"Test spies, stubs and mocks for JavaScript.","fork":false,"url":"https://api.github.com/repos/sinonjs/sinon","forks_url":"https://api.github.com/repos/sinonjs/sinon/forks","keys_url":"https://api.github.com/repos/sinonjs/sinon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sinonjs/sinon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sinonjs/sinon/teams","hooks_url":"https://api.github.com/repos/sinonjs/sinon/hooks","issue_events_url":"https://api.github.com/repos/sinonjs/sinon/issues/events{/number}","events_url":"https://api.github.com/repos/sinonjs/sinon/events","assignees_url":"https://api.github.com/repos/sinonjs/sinon/assignees{/user}","branches_url":"https://api.github.com/repos/sinonjs/sinon/branches{/branch}","tags_url":"https://api.github.com/repos/sinonjs/sinon/tags","blobs_url":"https://api.github.com/repos/sinonjs/sinon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sinonjs/sinon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sinonjs/sinon/git/refs{/sha}","trees_url":"https://api.github.com/repos/sinonjs/sinon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sinonjs/sinon/statuses/{sha}","languages_url":"https://api.github.com/repos/sinonjs/sinon/languages","stargazers_url":"https://api.github.com/repos/sinonjs/sinon/stargazers","contributors_url":"https://api.github.com/repos/sinonjs/sinon/contributors","subscribers_url":"https://api.github.com/repos/sinonjs/sinon/subscribers","subscription_url":"https://api.github.com/repos/sinonjs/sinon/subscription","commits_url":"https://api.github.com/repos/sinonjs/sinon/commits{/sha}","git_commits_url":"https://api.github.com/repos/sinonjs/sinon/git/commits{/sha}","comments_url":"https://api.github.com/repos/sinonjs/sinon/comments{/number}","issue_comment_url":"https://api.github.com/repos/sinonjs/sinon/issues/comments{/number}","contents_url":"https://api.github.com/repos/sinonjs/sinon/contents/{+path}","compare_url":"https://api.github.com/repos/sinonjs/sinon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sinonjs/sinon/merges","archive_url":"https://api.github.com/repos/sinonjs/sinon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sinonjs/sinon/downloads","issues_url":"https://api.github.com/repos/sinonjs/sinon/issues{/number}","pulls_url":"https://api.github.com/repos/sinonjs/sinon/pulls{/number}","milestones_url":"https://api.github.com/repos/sinonjs/sinon/milestones{/number}","notifications_url":"https://api.github.com/repos/sinonjs/sinon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sinonjs/sinon/labels{/name}","releases_url":"https://api.github.com/repos/sinonjs/sinon/releases{/id}","deployments_url":"https://api.github.com/repos/sinonjs/sinon/deployments","created_at":"2010-06-29T21:15:32Z","updated_at":"2018-12-11T13:05:23Z","pushed_at":"2018-12-10T12:05:45Z","git_url":"git://github.com/sinonjs/sinon.git","ssh_url":"git@github.com:sinonjs/sinon.git","clone_url":"https://github.com/sinonjs/sinon.git","svn_url":"https://github.com/sinonjs/sinon","homepage":"https://sinonjs.org/","size":24393,"stargazers_count":6679,"watchers_count":6679,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":679,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":679,"open_issues":34,"watchers":6679,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sinonjs/sinon/pulls/1959"},"html":{"href":"https://github.com/sinonjs/sinon/pull/1959"},"issue":{"href":"https://api.github.com/repos/sinonjs/sinon/issues/1959"},"comments":{"href":"https://api.github.com/repos/sinonjs/sinon/issues/1959/comments"},"review_comments":{"href":"https://api.github.com/repos/sinonjs/sinon/pulls/1959/comments"},"review_comment":{"href":"https://api.github.com/repos/sinonjs/sinon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sinonjs/sinon/pulls/1959/commits"},"statuses":{"href":"https://api.github.com/repos/sinonjs/sinon/statuses/c51809f97d87ac22e0d0cf1ebd62979b1f7de1d7"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":16,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"spicalous"}}