{"action":"created","comment":{"url":"https://api.github.com/repos/apache/zeppelin/pulls/comments/236167755","pull_request_review_id":178184638,"id":236167755,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjE2Nzc1NQ==","diff_hunk":"@@ -228,6 +234,22 @@ private void setMaxLineResults() {\n     }\n   }\n \n+  /**\n+   * Fetch ROWS_FETCH_SIZE_KEY value from property file and set it to\n+   * \"rowsFetchSize\" value.\n+   */\n+  private void setRowsFetchSize() {\n+    rowsFetchSize = Integer.valueOf(getProperty(ROWS_FETCH_SIZE_KEY));","path":"jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java","position":null,"original_position":35,"commit_id":"84e51f7a2a937c2a7a295d4d18d59810e269899f","original_commit_id":"58068816a341c96aa96a08663a16eb89a7d85904","user":{"login":"monsieurp","id":350116,"node_id":"MDQ6VXNlcjM1MDExNg==","avatar_url":"https://avatars2.githubusercontent.com/u/350116?v=4","gravatar_id":"","url":"https://api.github.com/users/monsieurp","html_url":"https://github.com/monsieurp","followers_url":"https://api.github.com/users/monsieurp/followers","following_url":"https://api.github.com/users/monsieurp/following{/other_user}","gists_url":"https://api.github.com/users/monsieurp/gists{/gist_id}","starred_url":"https://api.github.com/users/monsieurp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monsieurp/subscriptions","organizations_url":"https://api.github.com/users/monsieurp/orgs","repos_url":"https://api.github.com/users/monsieurp/repos","events_url":"https://api.github.com/users/monsieurp/events{/privacy}","received_events_url":"https://api.github.com/users/monsieurp/received_events","type":"User","site_admin":false},"body":"Problem addressed. See the latest commit.","created_at":"2018-11-26T09:04:07Z","updated_at":"2018-11-26T09:04:07Z","html_url":"https://github.com/apache/zeppelin/pull/3239#discussion_r236167755","pull_request_url":"https://api.github.com/repos/apache/zeppelin/pulls/3239","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/comments/236167755"},"html":{"href":"https://github.com/apache/zeppelin/pull/3239#discussion_r236167755"},"pull_request":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/3239"}},"in_reply_to_id":236034376},"pull_request":{"url":"https://api.github.com/repos/apache/zeppelin/pulls/3239","id":233290919,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMjkwOTE5","html_url":"https://github.com/apache/zeppelin/pull/3239","diff_url":"https://github.com/apache/zeppelin/pull/3239.diff","patch_url":"https://github.com/apache/zeppelin/pull/3239.patch","issue_url":"https://api.github.com/repos/apache/zeppelin/issues/3239","number":3239,"state":"open","locked":false,"title":"Zeppelin 3879: create \"maxRows\" and \"rowsFetchSize\" values in interpreter/jdbc/interpreter-setting.json","user":{"login":"monsieurp","id":350116,"node_id":"MDQ6VXNlcjM1MDExNg==","avatar_url":"https://avatars2.githubusercontent.com/u/350116?v=4","gravatar_id":"","url":"https://api.github.com/users/monsieurp","html_url":"https://github.com/monsieurp","followers_url":"https://api.github.com/users/monsieurp/followers","following_url":"https://api.github.com/users/monsieurp/following{/other_user}","gists_url":"https://api.github.com/users/monsieurp/gists{/gist_id}","starred_url":"https://api.github.com/users/monsieurp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monsieurp/subscriptions","organizations_url":"https://api.github.com/users/monsieurp/orgs","repos_url":"https://api.github.com/users/monsieurp/repos","events_url":"https://api.github.com/users/monsieurp/events{/privacy}","received_events_url":"https://api.github.com/users/monsieurp/received_events","type":"User","site_admin":false},"body":"### What is this PR for?\r\nThis PR introduces code to configure manually the \"maxRows\" and \"rowsFetchSize\" Statement settings directly from the interpreter/jdbc/interpreter-setting.json file. The default value for these two settings is 1000 which can slow down a Zeppelin instance quite a lot if a SQL query returns a big chunk of data. See [1] and [2] for more info about these function calls.\r\n\r\n[1]: https://docs.oracle.com/javase/8/docs/api/java/sql/Statement.html#setFetchSize-int-\r\n[2]: https://docs.oracle.com/javase/8/docs/api/java/sql/Statement.html#setMaxRows-int-\r\n\r\n### What type of PR is it?\r\nImprovement.\r\n\r\n### Todos\r\n\r\n\r\n### What is the Jira issue?\r\nhttps://issues.apache.org/jira/browse/ZEPPELIN-3879\r\n\r\n### How should this be tested?\r\n* CI pass\r\n\r\n### Screenshots (if appropriate)\r\n\r\n### Questions:\r\n* Does the licenses files need update? No.\r\n* Is there breaking changes for older versions? No.\r\n* Does this needs documentation? Yes. For the time being, I'd like the Zeppelin authors input whether such a change makes sense.\r\n\r\nThanks!","created_at":"2018-11-23T23:55:36Z","updated_at":"2018-11-26T09:04:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5570aac7ff566b622178b6ff4ecf57838b9917c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/zeppelin/pulls/3239/commits","review_comments_url":"https://api.github.com/repos/apache/zeppelin/pulls/3239/comments","review_comment_url":"https://api.github.com/repos/apache/zeppelin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/zeppelin/issues/3239/comments","statuses_url":"https://api.github.com/repos/apache/zeppelin/statuses/84e51f7a2a937c2a7a295d4d18d59810e269899f","head":{"label":"monsieurp:ZEPPELIN-3879","ref":"ZEPPELIN-3879","sha":"84e51f7a2a937c2a7a295d4d18d59810e269899f","user":{"login":"monsieurp","id":350116,"node_id":"MDQ6VXNlcjM1MDExNg==","avatar_url":"https://avatars2.githubusercontent.com/u/350116?v=4","gravatar_id":"","url":"https://api.github.com/users/monsieurp","html_url":"https://github.com/monsieurp","followers_url":"https://api.github.com/users/monsieurp/followers","following_url":"https://api.github.com/users/monsieurp/following{/other_user}","gists_url":"https://api.github.com/users/monsieurp/gists{/gist_id}","starred_url":"https://api.github.com/users/monsieurp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monsieurp/subscriptions","organizations_url":"https://api.github.com/users/monsieurp/orgs","repos_url":"https://api.github.com/users/monsieurp/repos","events_url":"https://api.github.com/users/monsieurp/events{/privacy}","received_events_url":"https://api.github.com/users/monsieurp/received_events","type":"User","site_admin":false},"repo":{"id":121175205,"node_id":"MDEwOlJlcG9zaXRvcnkxMjExNzUyMDU=","name":"zeppelin","full_name":"monsieurp/zeppelin","private":false,"owner":{"login":"monsieurp","id":350116,"node_id":"MDQ6VXNlcjM1MDExNg==","avatar_url":"https://avatars2.githubusercontent.com/u/350116?v=4","gravatar_id":"","url":"https://api.github.com/users/monsieurp","html_url":"https://github.com/monsieurp","followers_url":"https://api.github.com/users/monsieurp/followers","following_url":"https://api.github.com/users/monsieurp/following{/other_user}","gists_url":"https://api.github.com/users/monsieurp/gists{/gist_id}","starred_url":"https://api.github.com/users/monsieurp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monsieurp/subscriptions","organizations_url":"https://api.github.com/users/monsieurp/orgs","repos_url":"https://api.github.com/users/monsieurp/repos","events_url":"https://api.github.com/users/monsieurp/events{/privacy}","received_events_url":"https://api.github.com/users/monsieurp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/monsieurp/zeppelin","description":"Mirror of Apache Zeppelin","fork":true,"url":"https://api.github.com/repos/monsieurp/zeppelin","forks_url":"https://api.github.com/repos/monsieurp/zeppelin/forks","keys_url":"https://api.github.com/repos/monsieurp/zeppelin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monsieurp/zeppelin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monsieurp/zeppelin/teams","hooks_url":"https://api.github.com/repos/monsieurp/zeppelin/hooks","issue_events_url":"https://api.github.com/repos/monsieurp/zeppelin/issues/events{/number}","events_url":"https://api.github.com/repos/monsieurp/zeppelin/events","assignees_url":"https://api.github.com/repos/monsieurp/zeppelin/assignees{/user}","branches_url":"https://api.github.com/repos/monsieurp/zeppelin/branches{/branch}","tags_url":"https://api.github.com/repos/monsieurp/zeppelin/tags","blobs_url":"https://api.github.com/repos/monsieurp/zeppelin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monsieurp/zeppelin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monsieurp/zeppelin/git/refs{/sha}","trees_url":"https://api.github.com/repos/monsieurp/zeppelin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monsieurp/zeppelin/statuses/{sha}","languages_url":"https://api.github.com/repos/monsieurp/zeppelin/languages","stargazers_url":"https://api.github.com/repos/monsieurp/zeppelin/stargazers","contributors_url":"https://api.github.com/repos/monsieurp/zeppelin/contributors","subscribers_url":"https://api.github.com/repos/monsieurp/zeppelin/subscribers","subscription_url":"https://api.github.com/repos/monsieurp/zeppelin/subscription","commits_url":"https://api.github.com/repos/monsieurp/zeppelin/commits{/sha}","git_commits_url":"https://api.github.com/repos/monsieurp/zeppelin/git/commits{/sha}","comments_url":"https://api.github.com/repos/monsieurp/zeppelin/comments{/number}","issue_comment_url":"https://api.github.com/repos/monsieurp/zeppelin/issues/comments{/number}","contents_url":"https://api.github.com/repos/monsieurp/zeppelin/contents/{+path}","compare_url":"https://api.github.com/repos/monsieurp/zeppelin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monsieurp/zeppelin/merges","archive_url":"https://api.github.com/repos/monsieurp/zeppelin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monsieurp/zeppelin/downloads","issues_url":"https://api.github.com/repos/monsieurp/zeppelin/issues{/number}","pulls_url":"https://api.github.com/repos/monsieurp/zeppelin/pulls{/number}","milestones_url":"https://api.github.com/repos/monsieurp/zeppelin/milestones{/number}","notifications_url":"https://api.github.com/repos/monsieurp/zeppelin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monsieurp/zeppelin/labels{/name}","releases_url":"https://api.github.com/repos/monsieurp/zeppelin/releases{/id}","deployments_url":"https://api.github.com/repos/monsieurp/zeppelin/deployments","created_at":"2018-02-11T22:48:28Z","updated_at":"2018-11-23T10:53:08Z","pushed_at":"2018-11-26T09:02:13Z","git_url":"git://github.com/monsieurp/zeppelin.git","ssh_url":"git@github.com:monsieurp/zeppelin.git","clone_url":"https://github.com/monsieurp/zeppelin.git","svn_url":"https://github.com/monsieurp/zeppelin","homepage":"","size":70254,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"04b726a0a2935475d26816f99dab6e778e96b5dd","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":32848140,"node_id":"MDEwOlJlcG9zaXRvcnkzMjg0ODE0MA==","name":"zeppelin","full_name":"apache/zeppelin","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/zeppelin","description":"Mirror of Apache Zeppelin","fork":false,"url":"https://api.github.com/repos/apache/zeppelin","forks_url":"https://api.github.com/repos/apache/zeppelin/forks","keys_url":"https://api.github.com/repos/apache/zeppelin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/zeppelin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/zeppelin/teams","hooks_url":"https://api.github.com/repos/apache/zeppelin/hooks","issue_events_url":"https://api.github.com/repos/apache/zeppelin/issues/events{/number}","events_url":"https://api.github.com/repos/apache/zeppelin/events","assignees_url":"https://api.github.com/repos/apache/zeppelin/assignees{/user}","branches_url":"https://api.github.com/repos/apache/zeppelin/branches{/branch}","tags_url":"https://api.github.com/repos/apache/zeppelin/tags","blobs_url":"https://api.github.com/repos/apache/zeppelin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/zeppelin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/zeppelin/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/zeppelin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/zeppelin/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/zeppelin/languages","stargazers_url":"https://api.github.com/repos/apache/zeppelin/stargazers","contributors_url":"https://api.github.com/repos/apache/zeppelin/contributors","subscribers_url":"https://api.github.com/repos/apache/zeppelin/subscribers","subscription_url":"https://api.github.com/repos/apache/zeppelin/subscription","commits_url":"https://api.github.com/repos/apache/zeppelin/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/zeppelin/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/zeppelin/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/zeppelin/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/zeppelin/contents/{+path}","compare_url":"https://api.github.com/repos/apache/zeppelin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/zeppelin/merges","archive_url":"https://api.github.com/repos/apache/zeppelin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/zeppelin/downloads","issues_url":"https://api.github.com/repos/apache/zeppelin/issues{/number}","pulls_url":"https://api.github.com/repos/apache/zeppelin/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/zeppelin/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/zeppelin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/zeppelin/labels{/name}","releases_url":"https://api.github.com/repos/apache/zeppelin/releases{/id}","deployments_url":"https://api.github.com/repos/apache/zeppelin/deployments","created_at":"2015-03-25T07:00:06Z","updated_at":"2018-11-26T07:10:52Z","pushed_at":"2018-11-26T09:02:16Z","git_url":"git://github.com/apache/zeppelin.git","ssh_url":"git@github.com:apache/zeppelin.git","clone_url":"https://github.com/apache/zeppelin.git","svn_url":"https://github.com/apache/zeppelin","homepage":"","size":70924,"stargazers_count":3859,"watchers_count":3859,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1949,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1949,"open_issues":55,"watchers":3859,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/3239"},"html":{"href":"https://github.com/apache/zeppelin/pull/3239"},"issue":{"href":"https://api.github.com/repos/apache/zeppelin/issues/3239"},"comments":{"href":"https://api.github.com/repos/apache/zeppelin/issues/3239/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/3239/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/3239/commits"},"statuses":{"href":"https://api.github.com/repos/apache/zeppelin/statuses/84e51f7a2a937c2a7a295d4d18d59810e269899f"}},"author_association":"NONE"}}
{"actor":{"display_login":"monsieurp"}}