{"action":"created","issue":{"url":"https://api.github.com/repos/bcgov/groundwater-levels-indicator/issues/4","repository_url":"https://api.github.com/repos/bcgov/groundwater-levels-indicator","labels_url":"https://api.github.com/repos/bcgov/groundwater-levels-indicator/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/bcgov/groundwater-levels-indicator/issues/4/comments","events_url":"https://api.github.com/repos/bcgov/groundwater-levels-indicator/issues/4/events","html_url":"https://github.com/bcgov/groundwater-levels-indicator/pull/4","id":315109043,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgyMjAyMjA0","number":4,"title":"Update 2018","user":{"login":"steffilazerte","id":14676081,"node_id":"MDQ6VXNlcjE0Njc2MDgx","avatar_url":"https://avatars1.githubusercontent.com/u/14676081?v=4","gravatar_id":"","url":"https://api.github.com/users/steffilazerte","html_url":"https://github.com/steffilazerte","followers_url":"https://api.github.com/users/steffilazerte/followers","following_url":"https://api.github.com/users/steffilazerte/following{/other_user}","gists_url":"https://api.github.com/users/steffilazerte/gists{/gist_id}","starred_url":"https://api.github.com/users/steffilazerte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steffilazerte/subscriptions","organizations_url":"https://api.github.com/users/steffilazerte/orgs","repos_url":"https://api.github.com/users/steffilazerte/repos","events_url":"https://api.github.com/users/steffilazerte/events{/privacy}","received_events_url":"https://api.github.com/users/steffilazerte/received_events","type":"User","site_admin":false},"labels":[{"id":904902989,"node_id":"MDU6TGFiZWw5MDQ5MDI5ODk=","url":"https://api.github.com/repos/bcgov/groundwater-levels-indicator/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-04-17T15:19:17Z","updated_at":"2018-10-26T21:55:20Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/bcgov/groundwater-levels-indicator/pulls/4","html_url":"https://github.com/bcgov/groundwater-levels-indicator/pull/4","diff_url":"https://github.com/bcgov/groundwater-levels-indicator/pull/4.diff","patch_url":"https://github.com/bcgov/groundwater-levels-indicator/pull/4.patch"},"body":"Full update to use new data from new sources and to streamline some of the processes:\r\n\r\n**Changes to methodology:**\r\n- Script automatically downloads all data (no raw data needs to be stored locally)\r\n- Each script is self-contained. That is, that each script loads the packages and the data required and saves the output data at the end.\r\n- Mapping code moved to visualization script to keep all figure creation together (ggmap script omitted)\r\n\r\n**Date related changes:**\r\n- Includes wells active as of 2008-01-01\r\n- I've updated all references to dates including copyright. The only place I haven't is in the links to 2014 methodology (as that would break the links)\r\n\r\n**Rmd file changes:**\r\n- Under pdf_document, Rmd file runs and creates the output as expected. Some of the figures may require tweaking, as the dates on the axes are starting to run into each other. This may not be a problem with the right theme?\r\n- Rmd file now uses the summary figures saved from the visualizations script rather than recreating them again (individual well figures are still created in the Rmd file, though)\r\n- There are no \"Station Names\" in the data that I could find, so I've used Observation Well number alone in the Rmd file appendix (Let me know if I missed them)\r\n\r\n**Things to note:**\r\n- Some of the wells show a convergence code 52 when calculating the trends (I've made a list of them in the clean script, not sure how to proceed with these). At least one (302) shows a Large rate of decline, so this should probably be assessed.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/bcgov/groundwater-levels-indicator/issues/comments/433553971","html_url":"https://github.com/bcgov/groundwater-levels-indicator/pull/4#issuecomment-433553971","issue_url":"https://api.github.com/repos/bcgov/groundwater-levels-indicator/issues/4","id":433553971,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzU1Mzk3MQ==","user":{"login":"ateucher","id":2816635,"node_id":"MDQ6VXNlcjI4MTY2MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/2816635?v=4","gravatar_id":"","url":"https://api.github.com/users/ateucher","html_url":"https://github.com/ateucher","followers_url":"https://api.github.com/users/ateucher/followers","following_url":"https://api.github.com/users/ateucher/following{/other_user}","gists_url":"https://api.github.com/users/ateucher/gists{/gist_id}","starred_url":"https://api.github.com/users/ateucher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ateucher/subscriptions","organizations_url":"https://api.github.com/users/ateucher/orgs","repos_url":"https://api.github.com/users/ateucher/repos","events_url":"https://api.github.com/users/ateucher/events{/privacy}","received_events_url":"https://api.github.com/users/ateucher/received_events","type":"User","site_admin":false},"created_at":"2018-10-26T21:55:20Z","updated_at":"2018-10-26T21:55:20Z","author_association":"MEMBER","body":"As for the location of leaflet-related functions... I think the ones that are applicable to > 1 map and we can see using them for many other SoE maps (`popups_centre()`, `set_bc_view_on_close()`, `set_bc_view()`, possibly `popup_create_row()` and `popup_combine_rows()`) can stay in **envreportutils**. Could probably make the case for the caaqs one to be in there too since they are used in two indicators (and will be more in the future). The other ones (i.e., anything with  or `_groundwater` in the name can probably go in a `leaflet_functions.R` (or something) file in the analysis repo. I think the same goes for the css...?"}}
{"actor":{"display_login":"ateucher"}}