{"action":"opened","number":418,"pull_request":{"url":"https://api.github.com/repos/ankane/chartkick/pulls/418","id":170760829,"html_url":"https://github.com/ankane/chartkick/pull/418","diff_url":"https://github.com/ankane/chartkick/pull/418.diff","patch_url":"https://github.com/ankane/chartkick/pull/418.patch","issue_url":"https://api.github.com/repos/ankane/chartkick/issues/418","number":418,"state":"open","locked":false,"title":"Fix thousands format","user":{"login":"Novtopro","id":7251140,"avatar_url":"https://avatars2.githubusercontent.com/u/7251140?v=4","gravatar_id":"","url":"https://api.github.com/users/Novtopro","html_url":"https://github.com/Novtopro","followers_url":"https://api.github.com/users/Novtopro/followers","following_url":"https://api.github.com/users/Novtopro/following{/other_user}","gists_url":"https://api.github.com/users/Novtopro/gists{/gist_id}","starred_url":"https://api.github.com/users/Novtopro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Novtopro/subscriptions","organizations_url":"https://api.github.com/users/Novtopro/orgs","repos_url":"https://api.github.com/users/Novtopro/repos","events_url":"https://api.github.com/users/Novtopro/events{/privacy}","received_events_url":"https://api.github.com/users/Novtopro/received_events","type":"User","site_admin":false},"body":"@ankane I found there exists a minor issue when formatting numbers with thousands option.\r\n\r\n```javascript\r\nvar regexp = /(\\d)(?=(\\d{3})+(?!\\d))/g;\r\nconsole.log(\"1000\".replace(regexp, ','));   // ,000\r\n```\r\n\r\n```javascript\r\nvar regexp = /\\B(?=(\\d{3})+(?!\\d))/g;\r\nconsole.log(\"1000\".replace(regexp, ','));   // 1,000\r\n```","created_at":"2018-02-22T14:12:21Z","updated_at":"2018-02-22T14:12:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ankane/chartkick/pulls/418/commits","review_comments_url":"https://api.github.com/repos/ankane/chartkick/pulls/418/comments","review_comment_url":"https://api.github.com/repos/ankane/chartkick/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ankane/chartkick/issues/418/comments","statuses_url":"https://api.github.com/repos/ankane/chartkick/statuses/045e82eab392d01676f84d4c5731e0f318f784d0","head":{"label":"Novtopro:fix-thousands-format","ref":"fix-thousands-format","sha":"045e82eab392d01676f84d4c5731e0f318f784d0","user":{"login":"Novtopro","id":7251140,"avatar_url":"https://avatars2.githubusercontent.com/u/7251140?v=4","gravatar_id":"","url":"https://api.github.com/users/Novtopro","html_url":"https://github.com/Novtopro","followers_url":"https://api.github.com/users/Novtopro/followers","following_url":"https://api.github.com/users/Novtopro/following{/other_user}","gists_url":"https://api.github.com/users/Novtopro/gists{/gist_id}","starred_url":"https://api.github.com/users/Novtopro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Novtopro/subscriptions","organizations_url":"https://api.github.com/users/Novtopro/orgs","repos_url":"https://api.github.com/users/Novtopro/repos","events_url":"https://api.github.com/users/Novtopro/events{/privacy}","received_events_url":"https://api.github.com/users/Novtopro/received_events","type":"User","site_admin":false},"repo":{"id":122486141,"name":"chartkick","full_name":"Novtopro/chartkick","owner":{"login":"Novtopro","id":7251140,"avatar_url":"https://avatars2.githubusercontent.com/u/7251140?v=4","gravatar_id":"","url":"https://api.github.com/users/Novtopro","html_url":"https://github.com/Novtopro","followers_url":"https://api.github.com/users/Novtopro/followers","following_url":"https://api.github.com/users/Novtopro/following{/other_user}","gists_url":"https://api.github.com/users/Novtopro/gists{/gist_id}","starred_url":"https://api.github.com/users/Novtopro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Novtopro/subscriptions","organizations_url":"https://api.github.com/users/Novtopro/orgs","repos_url":"https://api.github.com/users/Novtopro/repos","events_url":"https://api.github.com/users/Novtopro/events{/privacy}","received_events_url":"https://api.github.com/users/Novtopro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Novtopro/chartkick","description":"Create beautiful JavaScript charts with one line of Ruby","fork":true,"url":"https://api.github.com/repos/Novtopro/chartkick","forks_url":"https://api.github.com/repos/Novtopro/chartkick/forks","keys_url":"https://api.github.com/repos/Novtopro/chartkick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Novtopro/chartkick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Novtopro/chartkick/teams","hooks_url":"https://api.github.com/repos/Novtopro/chartkick/hooks","issue_events_url":"https://api.github.com/repos/Novtopro/chartkick/issues/events{/number}","events_url":"https://api.github.com/repos/Novtopro/chartkick/events","assignees_url":"https://api.github.com/repos/Novtopro/chartkick/assignees{/user}","branches_url":"https://api.github.com/repos/Novtopro/chartkick/branches{/branch}","tags_url":"https://api.github.com/repos/Novtopro/chartkick/tags","blobs_url":"https://api.github.com/repos/Novtopro/chartkick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Novtopro/chartkick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Novtopro/chartkick/git/refs{/sha}","trees_url":"https://api.github.com/repos/Novtopro/chartkick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Novtopro/chartkick/statuses/{sha}","languages_url":"https://api.github.com/repos/Novtopro/chartkick/languages","stargazers_url":"https://api.github.com/repos/Novtopro/chartkick/stargazers","contributors_url":"https://api.github.com/repos/Novtopro/chartkick/contributors","subscribers_url":"https://api.github.com/repos/Novtopro/chartkick/subscribers","subscription_url":"https://api.github.com/repos/Novtopro/chartkick/subscription","commits_url":"https://api.github.com/repos/Novtopro/chartkick/commits{/sha}","git_commits_url":"https://api.github.com/repos/Novtopro/chartkick/git/commits{/sha}","comments_url":"https://api.github.com/repos/Novtopro/chartkick/comments{/number}","issue_comment_url":"https://api.github.com/repos/Novtopro/chartkick/issues/comments{/number}","contents_url":"https://api.github.com/repos/Novtopro/chartkick/contents/{+path}","compare_url":"https://api.github.com/repos/Novtopro/chartkick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Novtopro/chartkick/merges","archive_url":"https://api.github.com/repos/Novtopro/chartkick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Novtopro/chartkick/downloads","issues_url":"https://api.github.com/repos/Novtopro/chartkick/issues{/number}","pulls_url":"https://api.github.com/repos/Novtopro/chartkick/pulls{/number}","milestones_url":"https://api.github.com/repos/Novtopro/chartkick/milestones{/number}","notifications_url":"https://api.github.com/repos/Novtopro/chartkick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Novtopro/chartkick/labels{/name}","releases_url":"https://api.github.com/repos/Novtopro/chartkick/releases{/id}","deployments_url":"https://api.github.com/repos/Novtopro/chartkick/deployments","created_at":"2018-02-22T14:01:24Z","updated_at":"2018-02-22T14:01:26Z","pushed_at":"2018-02-22T14:08:18Z","git_url":"git://github.com/Novtopro/chartkick.git","ssh_url":"git@github.com:Novtopro/chartkick.git","clone_url":"https://github.com/Novtopro/chartkick.git","svn_url":"https://github.com/Novtopro/chartkick","homepage":"https://www.chartkick.com","size":1219,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ankane:master","ref":"master","sha":"5fa6f55a65155f52f1ec779fac6426e0c6d4849b","user":{"login":"ankane","id":220358,"avatar_url":"https://avatars3.githubusercontent.com/u/220358?v=4","gravatar_id":"","url":"https://api.github.com/users/ankane","html_url":"https://github.com/ankane","followers_url":"https://api.github.com/users/ankane/followers","following_url":"https://api.github.com/users/ankane/following{/other_user}","gists_url":"https://api.github.com/users/ankane/gists{/gist_id}","starred_url":"https://api.github.com/users/ankane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankane/subscriptions","organizations_url":"https://api.github.com/users/ankane/orgs","repos_url":"https://api.github.com/users/ankane/repos","events_url":"https://api.github.com/users/ankane/events{/privacy}","received_events_url":"https://api.github.com/users/ankane/received_events","type":"User","site_admin":false},"repo":{"id":9906653,"name":"chartkick","full_name":"ankane/chartkick","owner":{"login":"ankane","id":220358,"avatar_url":"https://avatars3.githubusercontent.com/u/220358?v=4","gravatar_id":"","url":"https://api.github.com/users/ankane","html_url":"https://github.com/ankane","followers_url":"https://api.github.com/users/ankane/followers","following_url":"https://api.github.com/users/ankane/following{/other_user}","gists_url":"https://api.github.com/users/ankane/gists{/gist_id}","starred_url":"https://api.github.com/users/ankane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankane/subscriptions","organizations_url":"https://api.github.com/users/ankane/orgs","repos_url":"https://api.github.com/users/ankane/repos","events_url":"https://api.github.com/users/ankane/events{/privacy}","received_events_url":"https://api.github.com/users/ankane/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ankane/chartkick","description":"Create beautiful JavaScript charts with one line of Ruby","fork":false,"url":"https://api.github.com/repos/ankane/chartkick","forks_url":"https://api.github.com/repos/ankane/chartkick/forks","keys_url":"https://api.github.com/repos/ankane/chartkick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ankane/chartkick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ankane/chartkick/teams","hooks_url":"https://api.github.com/repos/ankane/chartkick/hooks","issue_events_url":"https://api.github.com/repos/ankane/chartkick/issues/events{/number}","events_url":"https://api.github.com/repos/ankane/chartkick/events","assignees_url":"https://api.github.com/repos/ankane/chartkick/assignees{/user}","branches_url":"https://api.github.com/repos/ankane/chartkick/branches{/branch}","tags_url":"https://api.github.com/repos/ankane/chartkick/tags","blobs_url":"https://api.github.com/repos/ankane/chartkick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ankane/chartkick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ankane/chartkick/git/refs{/sha}","trees_url":"https://api.github.com/repos/ankane/chartkick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ankane/chartkick/statuses/{sha}","languages_url":"https://api.github.com/repos/ankane/chartkick/languages","stargazers_url":"https://api.github.com/repos/ankane/chartkick/stargazers","contributors_url":"https://api.github.com/repos/ankane/chartkick/contributors","subscribers_url":"https://api.github.com/repos/ankane/chartkick/subscribers","subscription_url":"https://api.github.com/repos/ankane/chartkick/subscription","commits_url":"https://api.github.com/repos/ankane/chartkick/commits{/sha}","git_commits_url":"https://api.github.com/repos/ankane/chartkick/git/commits{/sha}","comments_url":"https://api.github.com/repos/ankane/chartkick/comments{/number}","issue_comment_url":"https://api.github.com/repos/ankane/chartkick/issues/comments{/number}","contents_url":"https://api.github.com/repos/ankane/chartkick/contents/{+path}","compare_url":"https://api.github.com/repos/ankane/chartkick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ankane/chartkick/merges","archive_url":"https://api.github.com/repos/ankane/chartkick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ankane/chartkick/downloads","issues_url":"https://api.github.com/repos/ankane/chartkick/issues{/number}","pulls_url":"https://api.github.com/repos/ankane/chartkick/pulls{/number}","milestones_url":"https://api.github.com/repos/ankane/chartkick/milestones{/number}","notifications_url":"https://api.github.com/repos/ankane/chartkick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ankane/chartkick/labels{/name}","releases_url":"https://api.github.com/repos/ankane/chartkick/releases{/id}","deployments_url":"https://api.github.com/repos/ankane/chartkick/deployments","created_at":"2013-05-07T07:39:38Z","updated_at":"2018-02-22T06:00:31Z","pushed_at":"2018-02-22T11:29:55Z","git_url":"git://github.com/ankane/chartkick.git","ssh_url":"git@github.com:ankane/chartkick.git","clone_url":"https://github.com/ankane/chartkick.git","svn_url":"https://github.com/ankane/chartkick","homepage":"https://www.chartkick.com","size":1219,"stargazers_count":4681,"watchers_count":4681,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":467,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":467,"open_issues":20,"watchers":4681,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ankane/chartkick/pulls/418"},"html":{"href":"https://github.com/ankane/chartkick/pull/418"},"issue":{"href":"https://api.github.com/repos/ankane/chartkick/issues/418"},"comments":{"href":"https://api.github.com/repos/ankane/chartkick/issues/418/comments"},"review_comments":{"href":"https://api.github.com/repos/ankane/chartkick/pulls/418/comments"},"review_comment":{"href":"https://api.github.com/repos/ankane/chartkick/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ankane/chartkick/pulls/418/commits"},"statuses":{"href":"https://api.github.com/repos/ankane/chartkick/statuses/045e82eab392d01676f84d4c5731e0f318f784d0"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"Novtopro"}}