{"action":"created","comment":{"url":"https://api.github.com/repos/spotify/scio/pulls/comments/192456695","pull_request_review_id":125244164,"id":192456695,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjQ1NjY5NQ==","diff_hunk":"@@ -69,12 +68,10 @@ private object PairSCollectionFunctions {\n \n // scalastyle:off number.of.methods\n /**\n- * Extra functions available on SCollections of (key, value) pairs through an implicit conversion.\n+ * Extra functions available on SCollections of (key, value) pairs for skew joins","path":"scio-core/src/main/scala/com/spotify/scio/values/PairSCollectionFunctions.scala","position":13,"original_position":13,"commit_id":"4bcd3c66d73269aae93e69154c5e9e96ea8ef055","original_commit_id":"4bcd3c66d73269aae93e69154c5e9e96ea8ef055","user":{"login":"nevillelyh","id":468514,"node_id":"MDQ6VXNlcjQ2ODUxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/468514?v=4","gravatar_id":"","url":"https://api.github.com/users/nevillelyh","html_url":"https://github.com/nevillelyh","followers_url":"https://api.github.com/users/nevillelyh/followers","following_url":"https://api.github.com/users/nevillelyh/following{/other_user}","gists_url":"https://api.github.com/users/nevillelyh/gists{/gist_id}","starred_url":"https://api.github.com/users/nevillelyh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nevillelyh/subscriptions","organizations_url":"https://api.github.com/users/nevillelyh/orgs","repos_url":"https://api.github.com/users/nevillelyh/repos","events_url":"https://api.github.com/users/nevillelyh/events{/privacy}","received_events_url":"https://api.github.com/users/nevillelyh/received_events","type":"User","site_admin":false},"body":"This shouldn't change right? Coz we moved skewed join methods elsewhere.","created_at":"2018-06-01T17:00:42Z","updated_at":"2018-06-01T17:00:42Z","html_url":"https://github.com/spotify/scio/pull/1193#discussion_r192456695","pull_request_url":"https://api.github.com/repos/spotify/scio/pulls/1193","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/spotify/scio/pulls/comments/192456695"},"html":{"href":"https://github.com/spotify/scio/pull/1193#discussion_r192456695"},"pull_request":{"href":"https://api.github.com/repos/spotify/scio/pulls/1193"}}},"pull_request":{"url":"https://api.github.com/repos/spotify/scio/pulls/1193","id":191848795,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxODQ4Nzk1","html_url":"https://github.com/spotify/scio/pull/1193","diff_url":"https://github.com/spotify/scio/pull/1193.diff","patch_url":"https://github.com/spotify/scio/pull/1193.patch","issue_url":"https://api.github.com/repos/spotify/scio/issues/1193","number":1193,"state":"open","locked":false,"title":"Add skew join variants","user":{"login":"martinbomio","id":3895162,"node_id":"MDQ6VXNlcjM4OTUxNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/3895162?v=4","gravatar_id":"","url":"https://api.github.com/users/martinbomio","html_url":"https://github.com/martinbomio","followers_url":"https://api.github.com/users/martinbomio/followers","following_url":"https://api.github.com/users/martinbomio/following{/other_user}","gists_url":"https://api.github.com/users/martinbomio/gists{/gist_id}","starred_url":"https://api.github.com/users/martinbomio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinbomio/subscriptions","organizations_url":"https://api.github.com/users/martinbomio/orgs","repos_url":"https://api.github.com/users/martinbomio/repos","events_url":"https://api.github.com/users/martinbomio/events{/privacy}","received_events_url":"https://api.github.com/users/martinbomio/received_events","type":"User","site_admin":false},"body":"This PR tries to addresses https://github.com/spotify/scio/issues/1064.\r\n\r\nAlso move around some of the join hash and skewed variants to its own classes, mostly because the PairSCollection functions class was getting big, but can be moved again.\r\n\r\n@nevillelyh @fallonchen ","created_at":"2018-05-31T19:18:37Z","updated_at":"2018-06-01T17:00:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae6a5cfa73d467b85339ed3fdc59a058e88fdc7e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spotify/scio/pulls/1193/commits","review_comments_url":"https://api.github.com/repos/spotify/scio/pulls/1193/comments","review_comment_url":"https://api.github.com/repos/spotify/scio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spotify/scio/issues/1193/comments","statuses_url":"https://api.github.com/repos/spotify/scio/statuses/4bcd3c66d73269aae93e69154c5e9e96ea8ef055","head":{"label":"martinbomio:skewed-join-variants","ref":"skewed-join-variants","sha":"4bcd3c66d73269aae93e69154c5e9e96ea8ef055","user":{"login":"martinbomio","id":3895162,"node_id":"MDQ6VXNlcjM4OTUxNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/3895162?v=4","gravatar_id":"","url":"https://api.github.com/users/martinbomio","html_url":"https://github.com/martinbomio","followers_url":"https://api.github.com/users/martinbomio/followers","following_url":"https://api.github.com/users/martinbomio/following{/other_user}","gists_url":"https://api.github.com/users/martinbomio/gists{/gist_id}","starred_url":"https://api.github.com/users/martinbomio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinbomio/subscriptions","organizations_url":"https://api.github.com/users/martinbomio/orgs","repos_url":"https://api.github.com/users/martinbomio/repos","events_url":"https://api.github.com/users/martinbomio/events{/privacy}","received_events_url":"https://api.github.com/users/martinbomio/received_events","type":"User","site_admin":false},"repo":{"id":99909721,"node_id":"MDEwOlJlcG9zaXRvcnk5OTkwOTcyMQ==","name":"scio","full_name":"martinbomio/scio","owner":{"login":"martinbomio","id":3895162,"node_id":"MDQ6VXNlcjM4OTUxNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/3895162?v=4","gravatar_id":"","url":"https://api.github.com/users/martinbomio","html_url":"https://github.com/martinbomio","followers_url":"https://api.github.com/users/martinbomio/followers","following_url":"https://api.github.com/users/martinbomio/following{/other_user}","gists_url":"https://api.github.com/users/martinbomio/gists{/gist_id}","starred_url":"https://api.github.com/users/martinbomio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinbomio/subscriptions","organizations_url":"https://api.github.com/users/martinbomio/orgs","repos_url":"https://api.github.com/users/martinbomio/repos","events_url":"https://api.github.com/users/martinbomio/events{/privacy}","received_events_url":"https://api.github.com/users/martinbomio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martinbomio/scio","description":"A Scala API for Apache Beam and Google Cloud Dataflow.","fork":true,"url":"https://api.github.com/repos/martinbomio/scio","forks_url":"https://api.github.com/repos/martinbomio/scio/forks","keys_url":"https://api.github.com/repos/martinbomio/scio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinbomio/scio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinbomio/scio/teams","hooks_url":"https://api.github.com/repos/martinbomio/scio/hooks","issue_events_url":"https://api.github.com/repos/martinbomio/scio/issues/events{/number}","events_url":"https://api.github.com/repos/martinbomio/scio/events","assignees_url":"https://api.github.com/repos/martinbomio/scio/assignees{/user}","branches_url":"https://api.github.com/repos/martinbomio/scio/branches{/branch}","tags_url":"https://api.github.com/repos/martinbomio/scio/tags","blobs_url":"https://api.github.com/repos/martinbomio/scio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinbomio/scio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinbomio/scio/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinbomio/scio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinbomio/scio/statuses/{sha}","languages_url":"https://api.github.com/repos/martinbomio/scio/languages","stargazers_url":"https://api.github.com/repos/martinbomio/scio/stargazers","contributors_url":"https://api.github.com/repos/martinbomio/scio/contributors","subscribers_url":"https://api.github.com/repos/martinbomio/scio/subscribers","subscription_url":"https://api.github.com/repos/martinbomio/scio/subscription","commits_url":"https://api.github.com/repos/martinbomio/scio/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinbomio/scio/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinbomio/scio/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinbomio/scio/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinbomio/scio/contents/{+path}","compare_url":"https://api.github.com/repos/martinbomio/scio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinbomio/scio/merges","archive_url":"https://api.github.com/repos/martinbomio/scio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinbomio/scio/downloads","issues_url":"https://api.github.com/repos/martinbomio/scio/issues{/number}","pulls_url":"https://api.github.com/repos/martinbomio/scio/pulls{/number}","milestones_url":"https://api.github.com/repos/martinbomio/scio/milestones{/number}","notifications_url":"https://api.github.com/repos/martinbomio/scio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinbomio/scio/labels{/name}","releases_url":"https://api.github.com/repos/martinbomio/scio/releases{/id}","deployments_url":"https://api.github.com/repos/martinbomio/scio/deployments","created_at":"2017-08-10T10:08:07Z","updated_at":"2017-08-10T10:08:09Z","pushed_at":"2018-05-31T19:25:17Z","git_url":"git://github.com/martinbomio/scio.git","ssh_url":"git@github.com:martinbomio/scio.git","clone_url":"https://github.com/martinbomio/scio.git","svn_url":"https://github.com/martinbomio/scio","homepage":"http://spotify.github.io/scio","size":6949,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spotify:master","ref":"master","sha":"ec8935b59cb4f569cd498305030467fbbe43673e","user":{"login":"spotify","id":251374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTM3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":32946662,"node_id":"MDEwOlJlcG9zaXRvcnkzMjk0NjY2Mg==","name":"scio","full_name":"spotify/scio","owner":{"login":"spotify","id":251374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTM3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/scio","description":"A Scala API for Apache Beam and Google Cloud Dataflow.","fork":false,"url":"https://api.github.com/repos/spotify/scio","forks_url":"https://api.github.com/repos/spotify/scio/forks","keys_url":"https://api.github.com/repos/spotify/scio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/scio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/scio/teams","hooks_url":"https://api.github.com/repos/spotify/scio/hooks","issue_events_url":"https://api.github.com/repos/spotify/scio/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/scio/events","assignees_url":"https://api.github.com/repos/spotify/scio/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/scio/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/scio/tags","blobs_url":"https://api.github.com/repos/spotify/scio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/scio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/scio/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/scio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/scio/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/scio/languages","stargazers_url":"https://api.github.com/repos/spotify/scio/stargazers","contributors_url":"https://api.github.com/repos/spotify/scio/contributors","subscribers_url":"https://api.github.com/repos/spotify/scio/subscribers","subscription_url":"https://api.github.com/repos/spotify/scio/subscription","commits_url":"https://api.github.com/repos/spotify/scio/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/scio/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/scio/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/scio/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/scio/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/scio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/scio/merges","archive_url":"https://api.github.com/repos/spotify/scio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/scio/downloads","issues_url":"https://api.github.com/repos/spotify/scio/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/scio/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/scio/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/scio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/scio/labels{/name}","releases_url":"https://api.github.com/repos/spotify/scio/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/scio/deployments","created_at":"2015-03-26T19:07:34Z","updated_at":"2018-06-01T09:00:38Z","pushed_at":"2018-06-01T14:30:32Z","git_url":"git://github.com/spotify/scio.git","ssh_url":"git@github.com:spotify/scio.git","clone_url":"https://github.com/spotify/scio.git","svn_url":"https://github.com/spotify/scio","homepage":"https://spotify.github.io/scio","size":10512,"stargazers_count":1089,"watchers_count":1089,"language":"Scala","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":177,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":177,"open_issues":71,"watchers":1089,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spotify/scio/pulls/1193"},"html":{"href":"https://github.com/spotify/scio/pull/1193"},"issue":{"href":"https://api.github.com/repos/spotify/scio/issues/1193"},"comments":{"href":"https://api.github.com/repos/spotify/scio/issues/1193/comments"},"review_comments":{"href":"https://api.github.com/repos/spotify/scio/pulls/1193/comments"},"review_comment":{"href":"https://api.github.com/repos/spotify/scio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spotify/scio/pulls/1193/commits"},"statuses":{"href":"https://api.github.com/repos/spotify/scio/statuses/4bcd3c66d73269aae93e69154c5e9e96ea8ef055"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nevillelyh"}}