{"action":"created","comment":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/188919103","pull_request_review_id":120991210,"id":188919103,"diff_hunk":"@@ -373,7 +373,7 @@ public class CoinstakeContext\n             this.targetReserveBalance = 0; // TOOD:settings.targetReserveBalance\n             this.stakeProgressFlag = StakeNotInProgress;\n \n-            this.posConsensusValidator = consensusLoop.Validator as IPosConsensusValidator;\n+            //this.posConsensusValidator = consensusLoop.Validator as IPosConsensusValidator;","path":"src/Stratis.Bitcoin.Features.Miner/PosMinting.cs","position":23,"original_position":23,"commit_id":"3b250ac8cd2872f2fc3e616ade9fb6ed5a2966ba","original_commit_id":"3b250ac8cd2872f2fc3e616ade9fb6ed5a2966ba","user":{"login":"noescape00","id":10259355,"avatar_url":"https://avatars0.githubusercontent.com/u/10259355?v=4","gravatar_id":"","url":"https://api.github.com/users/noescape00","html_url":"https://github.com/noescape00","followers_url":"https://api.github.com/users/noescape00/followers","following_url":"https://api.github.com/users/noescape00/following{/other_user}","gists_url":"https://api.github.com/users/noescape00/gists{/gist_id}","starred_url":"https://api.github.com/users/noescape00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noescape00/subscriptions","organizations_url":"https://api.github.com/users/noescape00/orgs","repos_url":"https://api.github.com/users/noescape00/repos","events_url":"https://api.github.com/users/noescape00/events{/privacy}","received_events_url":"https://api.github.com/users/noescape00/received_events","type":"User","site_admin":false},"body":"Remove commented code please if it's not needed","created_at":"2018-05-17T11:03:18Z","updated_at":"2018-05-17T11:14:00Z","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1414#discussion_r188919103","pull_request_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1414","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/188919103"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1414#discussion_r188919103"},"pull_request":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1414"}}},"pull_request":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1414","id":188482769,"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1414","diff_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1414.diff","patch_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1414.patch","issue_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1414","number":1414,"state":"open","locked":false,"title":"Pull out coinview validation rule","user":{"login":"majikandy","id":444711,"avatar_url":"https://avatars0.githubusercontent.com/u/444711?v=4","gravatar_id":"","url":"https://api.github.com/users/majikandy","html_url":"https://github.com/majikandy","followers_url":"https://api.github.com/users/majikandy/followers","following_url":"https://api.github.com/users/majikandy/following{/other_user}","gists_url":"https://api.github.com/users/majikandy/gists{/gist_id}","starred_url":"https://api.github.com/users/majikandy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majikandy/subscriptions","organizations_url":"https://api.github.com/users/majikandy/orgs","repos_url":"https://api.github.com/users/majikandy/repos","events_url":"https://api.github.com/users/majikandy/events{/privacy}","received_events_url":"https://api.github.com/users/majikandy/received_events","type":"User","site_admin":false},"body":"This is the conversion of the final rule in the Validator and removal of the validator.\r\n\r\nhttps://github.com/stratisproject/StratisBitcoinFullNode/issues/124\r\n\r\nDespite going down the route of breaking the Uxto CoinviewRule into lots of subrules that run per transaction.  @dangershony and I decided to go back to the idea of pulling it out as just one rule (at least in the first instance).\r\n\r\nThe code review on that would have been a challenge, so to reduce that complexity and make it much easier in this first instance, the starting point was to rename the PowConsensusValidator as PowCoinviewRule and the equivalent same change for Pos.\r\n\r\nThen, changing all the usages of IPos/PowValidators to use the rules engine (or a rule from the rules engine) - allowing us to remove the remaining validator code completely.\r\n\r\nThis PR should be labelled as critical.\r\n\r\nSome of the documentation was moved around to avoid deleting it completely when deleting the 2 interfaces, so I want to make sure this is the in the right place too.\r\n","created_at":"2018-05-16T16:01:15Z","updated_at":"2018-05-17T11:14:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68442af74ae3d1ff43bf8045ed77325c69b580e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":929868428,"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels/pr-review-critical","name":"pr-review-critical","color":"0D2B51","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1414/commits","review_comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1414/comments","review_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1414/comments","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/3b250ac8cd2872f2fc3e616ade9fb6ed5a2966ba","head":{"label":"majikandy:pull_out_coinview_validation_rule","ref":"pull_out_coinview_validation_rule","sha":"3b250ac8cd2872f2fc3e616ade9fb6ed5a2966ba","user":{"login":"majikandy","id":444711,"avatar_url":"https://avatars0.githubusercontent.com/u/444711?v=4","gravatar_id":"","url":"https://api.github.com/users/majikandy","html_url":"https://github.com/majikandy","followers_url":"https://api.github.com/users/majikandy/followers","following_url":"https://api.github.com/users/majikandy/following{/other_user}","gists_url":"https://api.github.com/users/majikandy/gists{/gist_id}","starred_url":"https://api.github.com/users/majikandy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majikandy/subscriptions","organizations_url":"https://api.github.com/users/majikandy/orgs","repos_url":"https://api.github.com/users/majikandy/repos","events_url":"https://api.github.com/users/majikandy/events{/privacy}","received_events_url":"https://api.github.com/users/majikandy/received_events","type":"User","site_admin":false},"repo":{"id":122504266,"name":"StratisBitcoinFullNode","full_name":"majikandy/StratisBitcoinFullNode","owner":{"login":"majikandy","id":444711,"avatar_url":"https://avatars0.githubusercontent.com/u/444711?v=4","gravatar_id":"","url":"https://api.github.com/users/majikandy","html_url":"https://github.com/majikandy","followers_url":"https://api.github.com/users/majikandy/followers","following_url":"https://api.github.com/users/majikandy/following{/other_user}","gists_url":"https://api.github.com/users/majikandy/gists{/gist_id}","starred_url":"https://api.github.com/users/majikandy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/majikandy/subscriptions","organizations_url":"https://api.github.com/users/majikandy/orgs","repos_url":"https://api.github.com/users/majikandy/repos","events_url":"https://api.github.com/users/majikandy/events{/privacy}","received_events_url":"https://api.github.com/users/majikandy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/majikandy/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":true,"url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/majikandy/StratisBitcoinFullNode/deployments","created_at":"2018-02-22T16:28:04Z","updated_at":"2018-05-16T11:53:02Z","pushed_at":"2018-05-16T15:49:31Z","git_url":"git://github.com/majikandy/StratisBitcoinFullNode.git","ssh_url":"git@github.com:majikandy/StratisBitcoinFullNode.git","clone_url":"https://github.com/majikandy/StratisBitcoinFullNode.git","svn_url":"https://github.com/majikandy/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":11412,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stratisproject:master","ref":"master","sha":"dbc08149cc3902a3db2885a6e885bdd59abe5e5e","user":{"login":"stratisproject","id":15229748,"avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"repo":{"id":67271290,"name":"StratisBitcoinFullNode","full_name":"stratisproject/StratisBitcoinFullNode","owner":{"login":"stratisproject","id":15229748,"avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":false,"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/deployments","created_at":"2016-09-03T04:32:51Z","updated_at":"2018-05-17T07:04:58Z","pushed_at":"2018-05-17T10:32:16Z","git_url":"git://github.com/stratisproject/StratisBitcoinFullNode.git","ssh_url":"git@github.com:stratisproject/StratisBitcoinFullNode.git","clone_url":"https://github.com/stratisproject/StratisBitcoinFullNode.git","svn_url":"https://github.com/stratisproject/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":12363,"stargazers_count":464,"watchers_count":464,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":199,"mirror_url":null,"archived":false,"open_issues_count":103,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":199,"open_issues":103,"watchers":464,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1414"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1414"},"issue":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1414"},"comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1414/comments"},"review_comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1414/comments"},"review_comment":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1414/commits"},"statuses":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/3b250ac8cd2872f2fc3e616ade9fb6ed5a2966ba"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"noescape00"}}