{"action":"created","comment":{"url":"https://api.github.com/repos/divio/django-cms/pulls/comments/200728310","pull_request_review_id":135105659,"id":200728310,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDcyODMxMA==","diff_hunk":"@@ -663,6 +666,7 @@ def copy(self, site, parent_node=None, language=None,\n             parent_page = None\n \n         new_page = copy.copy(self)\n+        new_page._state = ModelState()","path":"cms/models/pagemodel.py","position":50,"original_position":50,"commit_id":"5ca2b0cf5e96041e10b2c066c1bce17da3669b52","original_commit_id":"5ca2b0cf5e96041e10b2c066c1bce17da3669b52","user":{"login":"toffi9","id":10218190,"node_id":"MDQ6VXNlcjEwMjE4MTkw","avatar_url":"https://avatars0.githubusercontent.com/u/10218190?v=4","gravatar_id":"","url":"https://api.github.com/users/toffi9","html_url":"https://github.com/toffi9","followers_url":"https://api.github.com/users/toffi9/followers","following_url":"https://api.github.com/users/toffi9/following{/other_user}","gists_url":"https://api.github.com/users/toffi9/gists{/gist_id}","starred_url":"https://api.github.com/users/toffi9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toffi9/subscriptions","organizations_url":"https://api.github.com/users/toffi9/orgs","repos_url":"https://api.github.com/users/toffi9/repos","events_url":"https://api.github.com/users/toffi9/events{/privacy}","received_events_url":"https://api.github.com/users/toffi9/received_events","type":"User","site_admin":false},"body":"Problem is that from dj20 fields caching is in _state object when we copy page like above, then also a _state object is copied, and it's referencing to the same object as original page, and it generated failures in tests. I resolved this issue by creating new instance of this object, this is done the same way as in django (https://github.com/django/django/blob/1.11/django/db/models/base.py#L481).","created_at":"2018-07-06T17:58:14Z","updated_at":"2018-07-06T17:58:15Z","html_url":"https://github.com/divio/django-cms/pull/6402#discussion_r200728310","pull_request_url":"https://api.github.com/repos/divio/django-cms/pulls/6402","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/divio/django-cms/pulls/comments/200728310"},"html":{"href":"https://github.com/divio/django-cms/pull/6402#discussion_r200728310"},"pull_request":{"href":"https://api.github.com/repos/divio/django-cms/pulls/6402"}},"in_reply_to_id":199794855},"pull_request":{"url":"https://api.github.com/repos/divio/django-cms/pulls/6402","id":192397518,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMzk3NTE4","html_url":"https://github.com/divio/django-cms/pull/6402","diff_url":"https://github.com/divio/django-cms/pull/6402.diff","patch_url":"https://github.com/divio/django-cms/pull/6402.patch","issue_url":"https://api.github.com/repos/divio/django-cms/issues/6402","number":6402,"state":"open","locked":false,"title":"Django 2.0 & 2.1 support","user":{"login":"toffi9","id":10218190,"node_id":"MDQ6VXNlcjEwMjE4MTkw","avatar_url":"https://avatars0.githubusercontent.com/u/10218190?v=4","gravatar_id":"","url":"https://api.github.com/users/toffi9","html_url":"https://github.com/toffi9","followers_url":"https://api.github.com/users/toffi9/followers","following_url":"https://api.github.com/users/toffi9/following{/other_user}","gists_url":"https://api.github.com/users/toffi9/gists{/gist_id}","starred_url":"https://api.github.com/users/toffi9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toffi9/subscriptions","organizations_url":"https://api.github.com/users/toffi9/orgs","repos_url":"https://api.github.com/users/toffi9/repos","events_url":"https://api.github.com/users/toffi9/events{/privacy}","received_events_url":"https://api.github.com/users/toffi9/received_events","type":"User","site_admin":false},"body":"Before merge of this PR please merge https://github.com/divio/djangocms-text-ckeditor/pull/483\r\n\r\n\r\nPlease @czpython write in review what will be your desired travis matrix for dj21 dj20 and dj111. And also please write how this matrix works because its only travis without tox.","created_at":"2018-06-04T12:50:59Z","updated_at":"2018-07-06T17:58:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"czpython","id":994951,"node_id":"MDQ6VXNlcjk5NDk1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/994951?v=4","gravatar_id":"","url":"https://api.github.com/users/czpython","html_url":"https://github.com/czpython","followers_url":"https://api.github.com/users/czpython/followers","following_url":"https://api.github.com/users/czpython/following{/other_user}","gists_url":"https://api.github.com/users/czpython/gists{/gist_id}","starred_url":"https://api.github.com/users/czpython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czpython/subscriptions","organizations_url":"https://api.github.com/users/czpython/orgs","repos_url":"https://api.github.com/users/czpython/repos","events_url":"https://api.github.com/users/czpython/events{/privacy}","received_events_url":"https://api.github.com/users/czpython/received_events","type":"User","site_admin":false},"assignees":[{"login":"czpython","id":994951,"node_id":"MDQ6VXNlcjk5NDk1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/994951?v=4","gravatar_id":"","url":"https://api.github.com/users/czpython","html_url":"https://github.com/czpython","followers_url":"https://api.github.com/users/czpython/followers","following_url":"https://api.github.com/users/czpython/following{/other_user}","gists_url":"https://api.github.com/users/czpython/gists{/gist_id}","starred_url":"https://api.github.com/users/czpython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czpython/subscriptions","organizations_url":"https://api.github.com/users/czpython/orgs","repos_url":"https://api.github.com/users/czpython/repos","events_url":"https://api.github.com/users/czpython/events{/privacy}","received_events_url":"https://api.github.com/users/czpython/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":87328666,"node_id":"MDU6TGFiZWw4NzMyODY2Ng==","url":"https://api.github.com/repos/divio/django-cms/labels/status:%20work%20in%20progress","name":"status: work in progress","color":"0052cc","default":false}],"milestone":{"url":"https://api.github.com/repos/divio/django-cms/milestones/60","html_url":"https://github.com/divio/django-cms/milestone/60","labels_url":"https://api.github.com/repos/divio/django-cms/milestones/60/labels","id":3271040,"node_id":"MDk6TWlsZXN0b25lMzI3MTA0MA==","number":60,"title":"3.6.0","description":"","creator":{"login":"czpython","id":994951,"node_id":"MDQ6VXNlcjk5NDk1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/994951?v=4","gravatar_id":"","url":"https://api.github.com/users/czpython","html_url":"https://github.com/czpython","followers_url":"https://api.github.com/users/czpython/followers","following_url":"https://api.github.com/users/czpython/following{/other_user}","gists_url":"https://api.github.com/users/czpython/gists{/gist_id}","starred_url":"https://api.github.com/users/czpython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czpython/subscriptions","organizations_url":"https://api.github.com/users/czpython/orgs","repos_url":"https://api.github.com/users/czpython/repos","events_url":"https://api.github.com/users/czpython/events{/privacy}","received_events_url":"https://api.github.com/users/czpython/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":8,"state":"open","created_at":"2018-04-16T15:31:08Z","updated_at":"2018-06-15T17:59:50Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/divio/django-cms/pulls/6402/commits","review_comments_url":"https://api.github.com/repos/divio/django-cms/pulls/6402/comments","review_comment_url":"https://api.github.com/repos/divio/django-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/divio/django-cms/issues/6402/comments","statuses_url":"https://api.github.com/repos/divio/django-cms/statuses/5ca2b0cf5e96041e10b2c066c1bce17da3669b52","head":{"label":"toffi9:feature/django20comp","ref":"feature/django20comp","sha":"5ca2b0cf5e96041e10b2c066c1bce17da3669b52","user":{"login":"toffi9","id":10218190,"node_id":"MDQ6VXNlcjEwMjE4MTkw","avatar_url":"https://avatars0.githubusercontent.com/u/10218190?v=4","gravatar_id":"","url":"https://api.github.com/users/toffi9","html_url":"https://github.com/toffi9","followers_url":"https://api.github.com/users/toffi9/followers","following_url":"https://api.github.com/users/toffi9/following{/other_user}","gists_url":"https://api.github.com/users/toffi9/gists{/gist_id}","starred_url":"https://api.github.com/users/toffi9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toffi9/subscriptions","organizations_url":"https://api.github.com/users/toffi9/orgs","repos_url":"https://api.github.com/users/toffi9/repos","events_url":"https://api.github.com/users/toffi9/events{/privacy}","received_events_url":"https://api.github.com/users/toffi9/received_events","type":"User","site_admin":false},"repo":{"id":126166401,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYxNjY0MDE=","name":"django-cms","full_name":"toffi9/django-cms","owner":{"login":"toffi9","id":10218190,"node_id":"MDQ6VXNlcjEwMjE4MTkw","avatar_url":"https://avatars0.githubusercontent.com/u/10218190?v=4","gravatar_id":"","url":"https://api.github.com/users/toffi9","html_url":"https://github.com/toffi9","followers_url":"https://api.github.com/users/toffi9/followers","following_url":"https://api.github.com/users/toffi9/following{/other_user}","gists_url":"https://api.github.com/users/toffi9/gists{/gist_id}","starred_url":"https://api.github.com/users/toffi9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toffi9/subscriptions","organizations_url":"https://api.github.com/users/toffi9/orgs","repos_url":"https://api.github.com/users/toffi9/repos","events_url":"https://api.github.com/users/toffi9/events{/privacy}","received_events_url":"https://api.github.com/users/toffi9/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/toffi9/django-cms","description":"The easy-to-use and developer-friendly CMS","fork":true,"url":"https://api.github.com/repos/toffi9/django-cms","forks_url":"https://api.github.com/repos/toffi9/django-cms/forks","keys_url":"https://api.github.com/repos/toffi9/django-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toffi9/django-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toffi9/django-cms/teams","hooks_url":"https://api.github.com/repos/toffi9/django-cms/hooks","issue_events_url":"https://api.github.com/repos/toffi9/django-cms/issues/events{/number}","events_url":"https://api.github.com/repos/toffi9/django-cms/events","assignees_url":"https://api.github.com/repos/toffi9/django-cms/assignees{/user}","branches_url":"https://api.github.com/repos/toffi9/django-cms/branches{/branch}","tags_url":"https://api.github.com/repos/toffi9/django-cms/tags","blobs_url":"https://api.github.com/repos/toffi9/django-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toffi9/django-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toffi9/django-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/toffi9/django-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toffi9/django-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/toffi9/django-cms/languages","stargazers_url":"https://api.github.com/repos/toffi9/django-cms/stargazers","contributors_url":"https://api.github.com/repos/toffi9/django-cms/contributors","subscribers_url":"https://api.github.com/repos/toffi9/django-cms/subscribers","subscription_url":"https://api.github.com/repos/toffi9/django-cms/subscription","commits_url":"https://api.github.com/repos/toffi9/django-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/toffi9/django-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/toffi9/django-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/toffi9/django-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/toffi9/django-cms/contents/{+path}","compare_url":"https://api.github.com/repos/toffi9/django-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toffi9/django-cms/merges","archive_url":"https://api.github.com/repos/toffi9/django-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toffi9/django-cms/downloads","issues_url":"https://api.github.com/repos/toffi9/django-cms/issues{/number}","pulls_url":"https://api.github.com/repos/toffi9/django-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/toffi9/django-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/toffi9/django-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toffi9/django-cms/labels{/name}","releases_url":"https://api.github.com/repos/toffi9/django-cms/releases{/id}","deployments_url":"https://api.github.com/repos/toffi9/django-cms/deployments","created_at":"2018-03-21T11:07:45Z","updated_at":"2018-03-21T11:07:50Z","pushed_at":"2018-07-06T16:14:41Z","git_url":"git://github.com/toffi9/django-cms.git","ssh_url":"git@github.com:toffi9/django-cms.git","clone_url":"https://github.com/toffi9/django-cms.git","svn_url":"https://github.com/toffi9/django-cms","homepage":"http://www.django-cms.org","size":78895,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"divio:develop","ref":"develop","sha":"4205eca24f7040350b7e0700ef4d8cea783cf73c","user":{"login":"divio","id":117904,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzkwNA==","avatar_url":"https://avatars0.githubusercontent.com/u/117904?v=4","gravatar_id":"","url":"https://api.github.com/users/divio","html_url":"https://github.com/divio","followers_url":"https://api.github.com/users/divio/followers","following_url":"https://api.github.com/users/divio/following{/other_user}","gists_url":"https://api.github.com/users/divio/gists{/gist_id}","starred_url":"https://api.github.com/users/divio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divio/subscriptions","organizations_url":"https://api.github.com/users/divio/orgs","repos_url":"https://api.github.com/users/divio/repos","events_url":"https://api.github.com/users/divio/events{/privacy}","received_events_url":"https://api.github.com/users/divio/received_events","type":"Organization","site_admin":false},"repo":{"id":143580,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM1ODA=","name":"django-cms","full_name":"divio/django-cms","owner":{"login":"divio","id":117904,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzkwNA==","avatar_url":"https://avatars0.githubusercontent.com/u/117904?v=4","gravatar_id":"","url":"https://api.github.com/users/divio","html_url":"https://github.com/divio","followers_url":"https://api.github.com/users/divio/followers","following_url":"https://api.github.com/users/divio/following{/other_user}","gists_url":"https://api.github.com/users/divio/gists{/gist_id}","starred_url":"https://api.github.com/users/divio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divio/subscriptions","organizations_url":"https://api.github.com/users/divio/orgs","repos_url":"https://api.github.com/users/divio/repos","events_url":"https://api.github.com/users/divio/events{/privacy}","received_events_url":"https://api.github.com/users/divio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/divio/django-cms","description":"The easy-to-use and developer-friendly CMS","fork":false,"url":"https://api.github.com/repos/divio/django-cms","forks_url":"https://api.github.com/repos/divio/django-cms/forks","keys_url":"https://api.github.com/repos/divio/django-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/divio/django-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/divio/django-cms/teams","hooks_url":"https://api.github.com/repos/divio/django-cms/hooks","issue_events_url":"https://api.github.com/repos/divio/django-cms/issues/events{/number}","events_url":"https://api.github.com/repos/divio/django-cms/events","assignees_url":"https://api.github.com/repos/divio/django-cms/assignees{/user}","branches_url":"https://api.github.com/repos/divio/django-cms/branches{/branch}","tags_url":"https://api.github.com/repos/divio/django-cms/tags","blobs_url":"https://api.github.com/repos/divio/django-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/divio/django-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/divio/django-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/divio/django-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/divio/django-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/divio/django-cms/languages","stargazers_url":"https://api.github.com/repos/divio/django-cms/stargazers","contributors_url":"https://api.github.com/repos/divio/django-cms/contributors","subscribers_url":"https://api.github.com/repos/divio/django-cms/subscribers","subscription_url":"https://api.github.com/repos/divio/django-cms/subscription","commits_url":"https://api.github.com/repos/divio/django-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/divio/django-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/divio/django-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/divio/django-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/divio/django-cms/contents/{+path}","compare_url":"https://api.github.com/repos/divio/django-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/divio/django-cms/merges","archive_url":"https://api.github.com/repos/divio/django-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/divio/django-cms/downloads","issues_url":"https://api.github.com/repos/divio/django-cms/issues{/number}","pulls_url":"https://api.github.com/repos/divio/django-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/divio/django-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/divio/django-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/divio/django-cms/labels{/name}","releases_url":"https://api.github.com/repos/divio/django-cms/releases{/id}","deployments_url":"https://api.github.com/repos/divio/django-cms/deployments","created_at":"2009-03-05T10:14:18Z","updated_at":"2018-07-05T23:32:48Z","pushed_at":"2018-07-06T14:20:25Z","git_url":"git://github.com/divio/django-cms.git","ssh_url":"git@github.com:divio/django-cms.git","clone_url":"https://github.com/divio/django-cms.git","svn_url":"https://github.com/divio/django-cms","homepage":"http://www.django-cms.org","size":78798,"stargazers_count":5953,"watchers_count":5953,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2126,"mirror_url":null,"archived":false,"open_issues_count":227,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":2126,"open_issues":227,"watchers":5953,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/divio/django-cms/pulls/6402"},"html":{"href":"https://github.com/divio/django-cms/pull/6402"},"issue":{"href":"https://api.github.com/repos/divio/django-cms/issues/6402"},"comments":{"href":"https://api.github.com/repos/divio/django-cms/issues/6402/comments"},"review_comments":{"href":"https://api.github.com/repos/divio/django-cms/pulls/6402/comments"},"review_comment":{"href":"https://api.github.com/repos/divio/django-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/divio/django-cms/pulls/6402/commits"},"statuses":{"href":"https://api.github.com/repos/divio/django-cms/statuses/5ca2b0cf5e96041e10b2c066c1bce17da3669b52"}},"author_association":"NONE"}}
{"actor":{"display_login":"toffi9"}}