{"action":"created","comment":{"url":"https://api.github.com/repos/react-dnd/react-dnd/pulls/comments/173544382","pull_request_review_id":102760699,"id":173544382,"diff_hunk":"@@ -297,10 +298,21 @@ export default class HTML5Backend {\n \t\t// Receiving a mouse event in the middle of a dragging operation\n \t\t// means it has ended and the drag source node disappeared from DOM,\n \t\t// so the browser didn't dispatch the dragend event.\n-\t\tthis.window.addEventListener(\n-\t\t\t'mousemove',\n-\t\t\tthis.endDragIfSourceWasRemovedFromDOM,\n-\t\t\ttrue,\n+\t\t//\n+\t\t// We need to wait an execution frame before we start listening for mousemove events.\n+\t\t// This is needed because the drag preview needs to be drawn or else it fires an 'mousemove' event\n+\t\t// immediately in some browsers.\n+\t\tthis.mouseMoveTimeoutId = setTimeout(","path":"packages/react-dnd-html5-backend/src/HTML5Backend.js","position":20,"original_position":20,"commit_id":"ba336d9c4387a6e0304f30f53e9a5ae79f3534fa","original_commit_id":"ba336d9c4387a6e0304f30f53e9a5ae79f3534fa","user":{"login":"darthtrevino","id":113544,"avatar_url":"https://avatars0.githubusercontent.com/u/113544?v=4","gravatar_id":"","url":"https://api.github.com/users/darthtrevino","html_url":"https://github.com/darthtrevino","followers_url":"https://api.github.com/users/darthtrevino/followers","following_url":"https://api.github.com/users/darthtrevino/following{/other_user}","gists_url":"https://api.github.com/users/darthtrevino/gists{/gist_id}","starred_url":"https://api.github.com/users/darthtrevino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darthtrevino/subscriptions","organizations_url":"https://api.github.com/users/darthtrevino/orgs","repos_url":"https://api.github.com/users/darthtrevino/repos","events_url":"https://api.github.com/users/darthtrevino/events{/privacy}","received_events_url":"https://api.github.com/users/darthtrevino/received_events","type":"User","site_admin":false},"body":"Can we rename this to `mouseMoveTimeoutTimer`?","created_at":"2018-03-09T19:25:16Z","updated_at":"2018-03-09T19:29:40Z","html_url":"https://github.com/react-dnd/react-dnd/pull/928#discussion_r173544382","pull_request_url":"https://api.github.com/repos/react-dnd/react-dnd/pulls/928","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/react-dnd/react-dnd/pulls/comments/173544382"},"html":{"href":"https://github.com/react-dnd/react-dnd/pull/928#discussion_r173544382"},"pull_request":{"href":"https://api.github.com/repos/react-dnd/react-dnd/pulls/928"}}},"pull_request":{"url":"https://api.github.com/repos/react-dnd/react-dnd/pulls/928","id":155000186,"html_url":"https://github.com/react-dnd/react-dnd/pull/928","diff_url":"https://github.com/react-dnd/react-dnd/pull/928.diff","patch_url":"https://github.com/react-dnd/react-dnd/pull/928.patch","issue_url":"https://api.github.com/repos/react-dnd/react-dnd/issues/928","number":928,"state":"open","locked":false,"title":"#869 - Fix issue which causes drag operation to not work on newer Fir…","user":{"login":"erwinverdonk","id":448481,"avatar_url":"https://avatars2.githubusercontent.com/u/448481?v=4","gravatar_id":"","url":"https://api.github.com/users/erwinverdonk","html_url":"https://github.com/erwinverdonk","followers_url":"https://api.github.com/users/erwinverdonk/followers","following_url":"https://api.github.com/users/erwinverdonk/following{/other_user}","gists_url":"https://api.github.com/users/erwinverdonk/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinverdonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinverdonk/subscriptions","organizations_url":"https://api.github.com/users/erwinverdonk/orgs","repos_url":"https://api.github.com/users/erwinverdonk/repos","events_url":"https://api.github.com/users/erwinverdonk/events{/privacy}","received_events_url":"https://api.github.com/users/erwinverdonk/received_events","type":"User","site_admin":false},"body":"…efox versions and potential other browsers as well\r\n\r\nTest this example on the newer Firefox versions and you will see that it doesnt perform the drag operation: http://react-dnd.github.io/react-dnd/examples-drag-around-naive.html\r\n\r\nAfter this fix it does work, as the 'mouseover' event is now not triggered immediately because we now wait for the drag preview to be there before attaching the listener.","created_at":"2017-11-28T07:48:17Z","updated_at":"2018-03-09T19:29:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5132a82d3ba14a8270691317eb0f2b7c14593ea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/react-dnd/react-dnd/pulls/928/commits","review_comments_url":"https://api.github.com/repos/react-dnd/react-dnd/pulls/928/comments","review_comment_url":"https://api.github.com/repos/react-dnd/react-dnd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/react-dnd/react-dnd/issues/928/comments","statuses_url":"https://api.github.com/repos/react-dnd/react-dnd/statuses/ba336d9c4387a6e0304f30f53e9a5ae79f3534fa","head":{"label":"erwinverdonk:bug/869-not-working-firefox","ref":"bug/869-not-working-firefox","sha":"ba336d9c4387a6e0304f30f53e9a5ae79f3534fa","user":{"login":"erwinverdonk","id":448481,"avatar_url":"https://avatars2.githubusercontent.com/u/448481?v=4","gravatar_id":"","url":"https://api.github.com/users/erwinverdonk","html_url":"https://github.com/erwinverdonk","followers_url":"https://api.github.com/users/erwinverdonk/followers","following_url":"https://api.github.com/users/erwinverdonk/following{/other_user}","gists_url":"https://api.github.com/users/erwinverdonk/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinverdonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinverdonk/subscriptions","organizations_url":"https://api.github.com/users/erwinverdonk/orgs","repos_url":"https://api.github.com/users/erwinverdonk/repos","events_url":"https://api.github.com/users/erwinverdonk/events{/privacy}","received_events_url":"https://api.github.com/users/erwinverdonk/received_events","type":"User","site_admin":false},"repo":{"id":112300623,"name":"react-dnd","full_name":"erwinverdonk/react-dnd","owner":{"login":"erwinverdonk","id":448481,"avatar_url":"https://avatars2.githubusercontent.com/u/448481?v=4","gravatar_id":"","url":"https://api.github.com/users/erwinverdonk","html_url":"https://github.com/erwinverdonk","followers_url":"https://api.github.com/users/erwinverdonk/followers","following_url":"https://api.github.com/users/erwinverdonk/following{/other_user}","gists_url":"https://api.github.com/users/erwinverdonk/gists{/gist_id}","starred_url":"https://api.github.com/users/erwinverdonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erwinverdonk/subscriptions","organizations_url":"https://api.github.com/users/erwinverdonk/orgs","repos_url":"https://api.github.com/users/erwinverdonk/repos","events_url":"https://api.github.com/users/erwinverdonk/events{/privacy}","received_events_url":"https://api.github.com/users/erwinverdonk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erwinverdonk/react-dnd","description":"Drag and Drop for React","fork":true,"url":"https://api.github.com/repos/erwinverdonk/react-dnd","forks_url":"https://api.github.com/repos/erwinverdonk/react-dnd/forks","keys_url":"https://api.github.com/repos/erwinverdonk/react-dnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erwinverdonk/react-dnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erwinverdonk/react-dnd/teams","hooks_url":"https://api.github.com/repos/erwinverdonk/react-dnd/hooks","issue_events_url":"https://api.github.com/repos/erwinverdonk/react-dnd/issues/events{/number}","events_url":"https://api.github.com/repos/erwinverdonk/react-dnd/events","assignees_url":"https://api.github.com/repos/erwinverdonk/react-dnd/assignees{/user}","branches_url":"https://api.github.com/repos/erwinverdonk/react-dnd/branches{/branch}","tags_url":"https://api.github.com/repos/erwinverdonk/react-dnd/tags","blobs_url":"https://api.github.com/repos/erwinverdonk/react-dnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erwinverdonk/react-dnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erwinverdonk/react-dnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/erwinverdonk/react-dnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erwinverdonk/react-dnd/statuses/{sha}","languages_url":"https://api.github.com/repos/erwinverdonk/react-dnd/languages","stargazers_url":"https://api.github.com/repos/erwinverdonk/react-dnd/stargazers","contributors_url":"https://api.github.com/repos/erwinverdonk/react-dnd/contributors","subscribers_url":"https://api.github.com/repos/erwinverdonk/react-dnd/subscribers","subscription_url":"https://api.github.com/repos/erwinverdonk/react-dnd/subscription","commits_url":"https://api.github.com/repos/erwinverdonk/react-dnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/erwinverdonk/react-dnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/erwinverdonk/react-dnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/erwinverdonk/react-dnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/erwinverdonk/react-dnd/contents/{+path}","compare_url":"https://api.github.com/repos/erwinverdonk/react-dnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erwinverdonk/react-dnd/merges","archive_url":"https://api.github.com/repos/erwinverdonk/react-dnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erwinverdonk/react-dnd/downloads","issues_url":"https://api.github.com/repos/erwinverdonk/react-dnd/issues{/number}","pulls_url":"https://api.github.com/repos/erwinverdonk/react-dnd/pulls{/number}","milestones_url":"https://api.github.com/repos/erwinverdonk/react-dnd/milestones{/number}","notifications_url":"https://api.github.com/repos/erwinverdonk/react-dnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erwinverdonk/react-dnd/labels{/name}","releases_url":"https://api.github.com/repos/erwinverdonk/react-dnd/releases{/id}","deployments_url":"https://api.github.com/repos/erwinverdonk/react-dnd/deployments","created_at":"2017-11-28T07:21:26Z","updated_at":"2017-11-28T07:21:28Z","pushed_at":"2018-02-07T20:53:46Z","git_url":"git://github.com/erwinverdonk/react-dnd.git","ssh_url":"git@github.com:erwinverdonk/react-dnd.git","clone_url":"https://github.com/erwinverdonk/react-dnd.git","svn_url":"https://github.com/erwinverdonk/react-dnd","homepage":"http://react-dnd.github.io/react-dnd","size":27183,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"react-dnd:master","ref":"master","sha":"e2983343eaf2c58f8c896a86ba94ab0250a59544","user":{"login":"react-dnd","id":25307599,"avatar_url":"https://avatars1.githubusercontent.com/u/25307599?v=4","gravatar_id":"","url":"https://api.github.com/users/react-dnd","html_url":"https://github.com/react-dnd","followers_url":"https://api.github.com/users/react-dnd/followers","following_url":"https://api.github.com/users/react-dnd/following{/other_user}","gists_url":"https://api.github.com/users/react-dnd/gists{/gist_id}","starred_url":"https://api.github.com/users/react-dnd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-dnd/subscriptions","organizations_url":"https://api.github.com/users/react-dnd/orgs","repos_url":"https://api.github.com/users/react-dnd/repos","events_url":"https://api.github.com/users/react-dnd/events{/privacy}","received_events_url":"https://api.github.com/users/react-dnd/received_events","type":"Organization","site_admin":false},"repo":{"id":25427817,"name":"react-dnd","full_name":"react-dnd/react-dnd","owner":{"login":"react-dnd","id":25307599,"avatar_url":"https://avatars1.githubusercontent.com/u/25307599?v=4","gravatar_id":"","url":"https://api.github.com/users/react-dnd","html_url":"https://github.com/react-dnd","followers_url":"https://api.github.com/users/react-dnd/followers","following_url":"https://api.github.com/users/react-dnd/following{/other_user}","gists_url":"https://api.github.com/users/react-dnd/gists{/gist_id}","starred_url":"https://api.github.com/users/react-dnd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-dnd/subscriptions","organizations_url":"https://api.github.com/users/react-dnd/orgs","repos_url":"https://api.github.com/users/react-dnd/repos","events_url":"https://api.github.com/users/react-dnd/events{/privacy}","received_events_url":"https://api.github.com/users/react-dnd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/react-dnd/react-dnd","description":"Drag and Drop for React","fork":false,"url":"https://api.github.com/repos/react-dnd/react-dnd","forks_url":"https://api.github.com/repos/react-dnd/react-dnd/forks","keys_url":"https://api.github.com/repos/react-dnd/react-dnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/react-dnd/react-dnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/react-dnd/react-dnd/teams","hooks_url":"https://api.github.com/repos/react-dnd/react-dnd/hooks","issue_events_url":"https://api.github.com/repos/react-dnd/react-dnd/issues/events{/number}","events_url":"https://api.github.com/repos/react-dnd/react-dnd/events","assignees_url":"https://api.github.com/repos/react-dnd/react-dnd/assignees{/user}","branches_url":"https://api.github.com/repos/react-dnd/react-dnd/branches{/branch}","tags_url":"https://api.github.com/repos/react-dnd/react-dnd/tags","blobs_url":"https://api.github.com/repos/react-dnd/react-dnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/react-dnd/react-dnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/react-dnd/react-dnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/react-dnd/react-dnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/react-dnd/react-dnd/statuses/{sha}","languages_url":"https://api.github.com/repos/react-dnd/react-dnd/languages","stargazers_url":"https://api.github.com/repos/react-dnd/react-dnd/stargazers","contributors_url":"https://api.github.com/repos/react-dnd/react-dnd/contributors","subscribers_url":"https://api.github.com/repos/react-dnd/react-dnd/subscribers","subscription_url":"https://api.github.com/repos/react-dnd/react-dnd/subscription","commits_url":"https://api.github.com/repos/react-dnd/react-dnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/react-dnd/react-dnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/react-dnd/react-dnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/react-dnd/react-dnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/react-dnd/react-dnd/contents/{+path}","compare_url":"https://api.github.com/repos/react-dnd/react-dnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/react-dnd/react-dnd/merges","archive_url":"https://api.github.com/repos/react-dnd/react-dnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/react-dnd/react-dnd/downloads","issues_url":"https://api.github.com/repos/react-dnd/react-dnd/issues{/number}","pulls_url":"https://api.github.com/repos/react-dnd/react-dnd/pulls{/number}","milestones_url":"https://api.github.com/repos/react-dnd/react-dnd/milestones{/number}","notifications_url":"https://api.github.com/repos/react-dnd/react-dnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/react-dnd/react-dnd/labels{/name}","releases_url":"https://api.github.com/repos/react-dnd/react-dnd/releases{/id}","deployments_url":"https://api.github.com/repos/react-dnd/react-dnd/deployments","created_at":"2014-10-19T13:29:28Z","updated_at":"2018-03-09T18:12:27Z","pushed_at":"2018-03-09T19:09:58Z","git_url":"git://github.com/react-dnd/react-dnd.git","ssh_url":"git@github.com:react-dnd/react-dnd.git","clone_url":"https://github.com/react-dnd/react-dnd.git","svn_url":"https://github.com/react-dnd/react-dnd","homepage":"http://react-dnd.github.io/react-dnd","size":27226,"stargazers_count":7855,"watchers_count":7855,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":915,"mirror_url":null,"archived":false,"open_issues_count":300,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":915,"open_issues":300,"watchers":7855,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/react-dnd/react-dnd/pulls/928"},"html":{"href":"https://github.com/react-dnd/react-dnd/pull/928"},"issue":{"href":"https://api.github.com/repos/react-dnd/react-dnd/issues/928"},"comments":{"href":"https://api.github.com/repos/react-dnd/react-dnd/issues/928/comments"},"review_comments":{"href":"https://api.github.com/repos/react-dnd/react-dnd/pulls/928/comments"},"review_comment":{"href":"https://api.github.com/repos/react-dnd/react-dnd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/react-dnd/react-dnd/pulls/928/commits"},"statuses":{"href":"https://api.github.com/repos/react-dnd/react-dnd/statuses/ba336d9c4387a6e0304f30f53e9a5ae79f3534fa"}},"author_association":"NONE"}}
{"actor":{"display_login":"darthtrevino"}}