{"action":"created","comment":{"url":"https://api.github.com/repos/ooyala/html5-skin/pulls/comments/199618088","pull_request_review_id":133773590,"id":199618088,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTYxODA4OA==","diff_hunk":"@@ -1036,6 +1036,115 @@ describe('Controller', function() {\n     });\n   });\n \n+  describe('Scrubber Bar', function() {\n+    var spyRender;\n+\n+    beforeEach(function() {\n+      spyRender = sinon.spy(controller, 'renderSkin');\n+    });\n+\n+    afterEach(function() {\n+      spyRender.restore();\n+    });\n+\n+    it('should update scrubber bar hover state and render when setScrubberBarHoverState() is called', function() {\n+      controller.state.scrubberBar.isHovering = false;\n+      controller.setScrubberBarHoverState(true);\n+      expect(controller.state.scrubberBar.isHovering).toBe(true);\n+      expect(spyRender.callCount).toBe(1);\n+    });\n+\n+    it('should NOT render when setScrubberBarHoverState() is called with same value', function() {\n+      controller.state.scrubberBar.isHovering = false;\n+      controller.setScrubberBarHoverState(false);\n+      expect(spyRender.callCount).toBe(0);\n+    });\n+  });\n+\n+  describe('Skip Controls', function() {\n+    var spyPublish;\n+\n+    beforeEach(function() {\n+      spyPublish = sinon.spy(OO.mb, 'publish');\n+    });\n+\n+    afterEach(function() {\n+      spyPublish.restore()\n+    });\n+\n+    it('should update skip controls state on POSITION_IN_PLAYLIST_DETERMINED', function() {\n+      controller.state.skipControls.hasPreviousVideos = false;\n+      controller.state.skipControls.hasNextVideos = false;\n+      expect(controller.state.skipControls.hasPreviousVideos).toBe(false);\n+      expect(controller.state.skipControls.hasNextVideos).toBe(false);\n+      controller.onPositionInPlaylistDetermined('eventName', {\n+        hasPreviousVideos: true,\n+        hasNextVideos: true\n+      });\n+      expect(controller.state.skipControls.hasPreviousVideos).toBe(true);\n+      expect(controller.state.skipControls.hasNextVideos).toBe(true);\n+    });\n+\n+    it('should publish OO.EVENTS.REQUEST_NEXT_VIDEO when requestNextVideo() is called', function() {\n+      controller.requestNextVideo();\n+      expect(spyPublish.callCount).toBe(1);\n+      expect(spyPublish.calledWith(OO.EVENTS.REQUEST_NEXT_VIDEO)).toBe(true);\n+    });\n+\n+    describe('Previous Video', function() {\n+      var spyUpdatePlayhead, spySeek;\n+\n+      beforeEach(function() {\n+        spyUpdatePlayhead = sinon.spy(controller, 'updateSeekingPlayhead');\n+        spySeek = sinon.spy(controller, 'seek');\n+      });\n+\n+      afterEach(function() {\n+        spyUpdatePlayhead.restore();\n+        spySeek.restore();\n+      });\n+\n+      it('should rewind and immediately update playhead UI on first \"Previous Video\" click if playhead is above threshold', function() {\n+        controller.state.mainVideoPlayhead = CONSTANTS.UI.REQUEST_PREVIOUS_PLAYHEAD_THRESHOLD + 1;\n+        controller.rewindOrRequestPreviousVideo();\n+        expect(spyUpdatePlayhead.callCount).toBe(1);\n+        expect(spySeek.callCount).toBe(1);\n+        expect(spyUpdatePlayhead.calledWith(0)).toBe(true);\n+        expect(spySeek.calledWith(0)).toBe(true);\n+      });\n+\n+      it('should request previous video on first \"Previous Video\" click if playhead is below threshold', function() {\n+        controller.state.mainVideoPlayhead = CONSTANTS.UI.REQUEST_PREVIOUS_PLAYHEAD_THRESHOLD - 1;\n+        controller.rewindOrRequestPreviousVideo();\n+        expect(spyUpdatePlayhead.callCount).toBe(0);\n+        expect(spySeek.callCount).toBe(0);\n+        expect(spyPublish.callCount).toBe(1);","path":"tests/html5skin-test.js","position":86,"original_position":86,"commit_id":"298052d451d7947a00e9866676a82b129095e185","original_commit_id":"298052d451d7947a00e9866676a82b129095e185","user":{"login":"aeng7","id":14931241,"node_id":"MDQ6VXNlcjE0OTMxMjQx","avatar_url":"https://avatars3.githubusercontent.com/u/14931241?v=4","gravatar_id":"","url":"https://api.github.com/users/aeng7","html_url":"https://github.com/aeng7","followers_url":"https://api.github.com/users/aeng7/followers","following_url":"https://api.github.com/users/aeng7/following{/other_user}","gists_url":"https://api.github.com/users/aeng7/gists{/gist_id}","starred_url":"https://api.github.com/users/aeng7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeng7/subscriptions","organizations_url":"https://api.github.com/users/aeng7/orgs","repos_url":"https://api.github.com/users/aeng7/repos","events_url":"https://api.github.com/users/aeng7/events{/privacy}","received_events_url":"https://api.github.com/users/aeng7/received_events","type":"User","site_admin":false},"body":"Should we check what the contents of this publish are?","created_at":"2018-07-02T20:54:08Z","updated_at":"2018-07-02T20:54:08Z","html_url":"https://github.com/ooyala/html5-skin/pull/1095#discussion_r199618088","pull_request_url":"https://api.github.com/repos/ooyala/html5-skin/pulls/1095","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/comments/199618088"},"html":{"href":"https://github.com/ooyala/html5-skin/pull/1095#discussion_r199618088"},"pull_request":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/1095"}}},"pull_request":{"url":"https://api.github.com/repos/ooyala/html5-skin/pulls/1095","id":198439316,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NDM5MzE2","html_url":"https://github.com/ooyala/html5-skin/pull/1095","diff_url":"https://github.com/ooyala/html5-skin/pull/1095.diff","patch_url":"https://github.com/ooyala/html5-skin/pull/1095.patch","issue_url":"https://api.github.com/repos/ooyala/html5-skin/issues/1095","number":1095,"state":"open","locked":false,"title":"[PLAYER-3835] Fix for rewind with loop + controller unit tests for Skip Ctrls","user":{"login":"jpfranco","id":1322503,"node_id":"MDQ6VXNlcjEzMjI1MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1322503?v=4","gravatar_id":"","url":"https://api.github.com/users/jpfranco","html_url":"https://github.com/jpfranco","followers_url":"https://api.github.com/users/jpfranco/followers","following_url":"https://api.github.com/users/jpfranco/following{/other_user}","gists_url":"https://api.github.com/users/jpfranco/gists{/gist_id}","starred_url":"https://api.github.com/users/jpfranco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpfranco/subscriptions","organizations_url":"https://api.github.com/users/jpfranco/orgs","repos_url":"https://api.github.com/users/jpfranco/repos","events_url":"https://api.github.com/users/jpfranco/events{/privacy}","received_events_url":"https://api.github.com/users/jpfranco/received_events","type":"User","site_admin":false},"body":"Fixes an issue in which rewind doesn't happen if `loop=true`. Also added the first set of unit tests for the Skip Controls. Will continue adding more of these.","created_at":"2018-06-29T22:37:41Z","updated_at":"2018-07-02T20:54:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"994f2d51b8616b50f9997eaff4f7ddca7103a161","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dallen42","id":3966781,"node_id":"MDQ6VXNlcjM5NjY3ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/3966781?v=4","gravatar_id":"","url":"https://api.github.com/users/dallen42","html_url":"https://github.com/dallen42","followers_url":"https://api.github.com/users/dallen42/followers","following_url":"https://api.github.com/users/dallen42/following{/other_user}","gists_url":"https://api.github.com/users/dallen42/gists{/gist_id}","starred_url":"https://api.github.com/users/dallen42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dallen42/subscriptions","organizations_url":"https://api.github.com/users/dallen42/orgs","repos_url":"https://api.github.com/users/dallen42/repos","events_url":"https://api.github.com/users/dallen42/events{/privacy}","received_events_url":"https://api.github.com/users/dallen42/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ooyala/html5-skin/pulls/1095/commits","review_comments_url":"https://api.github.com/repos/ooyala/html5-skin/pulls/1095/comments","review_comment_url":"https://api.github.com/repos/ooyala/html5-skin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ooyala/html5-skin/issues/1095/comments","statuses_url":"https://api.github.com/repos/ooyala/html5-skin/statuses/298052d451d7947a00e9866676a82b129095e185","head":{"label":"ooyala:PLAYER-3835","ref":"PLAYER-3835","sha":"298052d451d7947a00e9866676a82b129095e185","user":{"login":"ooyala","id":365274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTI3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/365274?v=4","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"repo":{"id":32830770,"node_id":"MDEwOlJlcG9zaXRvcnkzMjgzMDc3MA==","name":"html5-skin","full_name":"ooyala/html5-skin","owner":{"login":"ooyala","id":365274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTI3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/365274?v=4","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ooyala/html5-skin","description":null,"fork":false,"url":"https://api.github.com/repos/ooyala/html5-skin","forks_url":"https://api.github.com/repos/ooyala/html5-skin/forks","keys_url":"https://api.github.com/repos/ooyala/html5-skin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ooyala/html5-skin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ooyala/html5-skin/teams","hooks_url":"https://api.github.com/repos/ooyala/html5-skin/hooks","issue_events_url":"https://api.github.com/repos/ooyala/html5-skin/issues/events{/number}","events_url":"https://api.github.com/repos/ooyala/html5-skin/events","assignees_url":"https://api.github.com/repos/ooyala/html5-skin/assignees{/user}","branches_url":"https://api.github.com/repos/ooyala/html5-skin/branches{/branch}","tags_url":"https://api.github.com/repos/ooyala/html5-skin/tags","blobs_url":"https://api.github.com/repos/ooyala/html5-skin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ooyala/html5-skin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ooyala/html5-skin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ooyala/html5-skin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ooyala/html5-skin/statuses/{sha}","languages_url":"https://api.github.com/repos/ooyala/html5-skin/languages","stargazers_url":"https://api.github.com/repos/ooyala/html5-skin/stargazers","contributors_url":"https://api.github.com/repos/ooyala/html5-skin/contributors","subscribers_url":"https://api.github.com/repos/ooyala/html5-skin/subscribers","subscription_url":"https://api.github.com/repos/ooyala/html5-skin/subscription","commits_url":"https://api.github.com/repos/ooyala/html5-skin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ooyala/html5-skin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ooyala/html5-skin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ooyala/html5-skin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ooyala/html5-skin/contents/{+path}","compare_url":"https://api.github.com/repos/ooyala/html5-skin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ooyala/html5-skin/merges","archive_url":"https://api.github.com/repos/ooyala/html5-skin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ooyala/html5-skin/downloads","issues_url":"https://api.github.com/repos/ooyala/html5-skin/issues{/number}","pulls_url":"https://api.github.com/repos/ooyala/html5-skin/pulls{/number}","milestones_url":"https://api.github.com/repos/ooyala/html5-skin/milestones{/number}","notifications_url":"https://api.github.com/repos/ooyala/html5-skin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ooyala/html5-skin/labels{/name}","releases_url":"https://api.github.com/repos/ooyala/html5-skin/releases{/id}","deployments_url":"https://api.github.com/repos/ooyala/html5-skin/deployments","created_at":"2015-03-24T23:20:15Z","updated_at":"2018-06-28T20:42:30Z","pushed_at":"2018-07-02T18:23:55Z","git_url":"git://github.com/ooyala/html5-skin.git","ssh_url":"git@github.com:ooyala/html5-skin.git","clone_url":"https://github.com/ooyala/html5-skin.git","svn_url":"https://github.com/ooyala/html5-skin","homepage":null,"size":5718,"stargazers_count":23,"watchers_count":23,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":14,"license":null,"forks":40,"open_issues":14,"watchers":23,"default_branch":"master"}},"base":{"label":"ooyala:master","ref":"master","sha":"7b9e7a6528b3bb28636de3467a73ea4e0c7737f8","user":{"login":"ooyala","id":365274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTI3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/365274?v=4","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"repo":{"id":32830770,"node_id":"MDEwOlJlcG9zaXRvcnkzMjgzMDc3MA==","name":"html5-skin","full_name":"ooyala/html5-skin","owner":{"login":"ooyala","id":365274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTI3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/365274?v=4","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ooyala/html5-skin","description":null,"fork":false,"url":"https://api.github.com/repos/ooyala/html5-skin","forks_url":"https://api.github.com/repos/ooyala/html5-skin/forks","keys_url":"https://api.github.com/repos/ooyala/html5-skin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ooyala/html5-skin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ooyala/html5-skin/teams","hooks_url":"https://api.github.com/repos/ooyala/html5-skin/hooks","issue_events_url":"https://api.github.com/repos/ooyala/html5-skin/issues/events{/number}","events_url":"https://api.github.com/repos/ooyala/html5-skin/events","assignees_url":"https://api.github.com/repos/ooyala/html5-skin/assignees{/user}","branches_url":"https://api.github.com/repos/ooyala/html5-skin/branches{/branch}","tags_url":"https://api.github.com/repos/ooyala/html5-skin/tags","blobs_url":"https://api.github.com/repos/ooyala/html5-skin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ooyala/html5-skin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ooyala/html5-skin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ooyala/html5-skin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ooyala/html5-skin/statuses/{sha}","languages_url":"https://api.github.com/repos/ooyala/html5-skin/languages","stargazers_url":"https://api.github.com/repos/ooyala/html5-skin/stargazers","contributors_url":"https://api.github.com/repos/ooyala/html5-skin/contributors","subscribers_url":"https://api.github.com/repos/ooyala/html5-skin/subscribers","subscription_url":"https://api.github.com/repos/ooyala/html5-skin/subscription","commits_url":"https://api.github.com/repos/ooyala/html5-skin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ooyala/html5-skin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ooyala/html5-skin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ooyala/html5-skin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ooyala/html5-skin/contents/{+path}","compare_url":"https://api.github.com/repos/ooyala/html5-skin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ooyala/html5-skin/merges","archive_url":"https://api.github.com/repos/ooyala/html5-skin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ooyala/html5-skin/downloads","issues_url":"https://api.github.com/repos/ooyala/html5-skin/issues{/number}","pulls_url":"https://api.github.com/repos/ooyala/html5-skin/pulls{/number}","milestones_url":"https://api.github.com/repos/ooyala/html5-skin/milestones{/number}","notifications_url":"https://api.github.com/repos/ooyala/html5-skin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ooyala/html5-skin/labels{/name}","releases_url":"https://api.github.com/repos/ooyala/html5-skin/releases{/id}","deployments_url":"https://api.github.com/repos/ooyala/html5-skin/deployments","created_at":"2015-03-24T23:20:15Z","updated_at":"2018-06-28T20:42:30Z","pushed_at":"2018-07-02T18:23:55Z","git_url":"git://github.com/ooyala/html5-skin.git","ssh_url":"git@github.com:ooyala/html5-skin.git","clone_url":"https://github.com/ooyala/html5-skin.git","svn_url":"https://github.com/ooyala/html5-skin","homepage":null,"size":5718,"stargazers_count":23,"watchers_count":23,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":14,"license":null,"forks":40,"open_issues":14,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/1095"},"html":{"href":"https://github.com/ooyala/html5-skin/pull/1095"},"issue":{"href":"https://api.github.com/repos/ooyala/html5-skin/issues/1095"},"comments":{"href":"https://api.github.com/repos/ooyala/html5-skin/issues/1095/comments"},"review_comments":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/1095/comments"},"review_comment":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/1095/commits"},"statuses":{"href":"https://api.github.com/repos/ooyala/html5-skin/statuses/298052d451d7947a00e9866676a82b129095e185"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aeng7"}}