{"action":"created","comment":{"url":"https://api.github.com/repos/otavanopisto/muikku/pulls/comments/195942074","pull_request_review_id":129401603,"id":195942074,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTk0MjA3NA==","diff_hunk":"@@ -3,51 +3,52 @@\n @import \"../base/vars\";\n @import \"../base/breakpoints\";\n \n-// TODO: Refactoring needed for form-field elements\n-// Not sure about the naming used here as we should not need classes like form-field-tag-input__field etc.\n+// TODO: Refactoring needed for form-element elements\n+// Not sure about the naming used here as we should not need classes like form-element-tag-input__field etc.\n // Some class names are against BEM also.\n \n-div.form-field-tag-input__field, input:not([type=\"checkbox\"]).form-field, .form-field input, textarea.form-field, .form-field textarea {\n+.form-element-tag-input__field, input:not([type=\"checkbox\"]).form-element, .form-element input, textarea.form-element, .form-element textarea {\n   @include prefix(transition, webkit ms o moz, box-shadow 0.2s ease-in-out, border 0.2s ease-in-out);\n   -webkit-appearance: none;  \n   border-radius: 3px;\n-  border: solid 2px $color-form-field-border;\n+  border: solid 2px $color-form-element-border;\n   font-size: 16px;\n   outline: none;\n   padding: 3px 10px;\n   resize: none;\n   \n   &:focus, &.focus {\n-    border: solid 2px $color-form-field-border-focus;\n+    border: solid 2px $color-form-element-border-focus;\n   }\n }\n \n-input:not([type=\"checkbox\"]).form-field, .form-field input, textarea.form-field, .form-field textarea {\n+\n+input:not([type=\"checkbox\"]).form-element, .form-element input, textarea.form-element, .form-element textarea {\n   height: 34px;\n }\n \n-input[type=\"checkbox\"].form-field {\n+input[type=\"checkbox\"].form-element {","path":"muikku-core-plugins/src/main/resources/META-INF/resources/scripts/src/sass/elements/form_fields.scss","position":35,"original_position":35,"commit_id":"623b334233d4a5cac70080c3f29bde840796f7c8","original_commit_id":"623b334233d4a5cac70080c3f29bde840796f7c8","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Avoid qualifying class selectors with an element.<br>Avoid qualifying attribute selectors with an element.","created_at":"2018-06-17T21:31:40Z","updated_at":"2018-06-17T21:31:43Z","html_url":"https://github.com/otavanopisto/muikku/pull/4080#discussion_r195942074","pull_request_url":"https://api.github.com/repos/otavanopisto/muikku/pulls/4080","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/otavanopisto/muikku/pulls/comments/195942074"},"html":{"href":"https://github.com/otavanopisto/muikku/pull/4080#discussion_r195942074"},"pull_request":{"href":"https://api.github.com/repos/otavanopisto/muikku/pulls/4080"}}},"pull_request":{"url":"https://api.github.com/repos/otavanopisto/muikku/pulls/4080","id":195396235,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1Mzk2MjM1","html_url":"https://github.com/otavanopisto/muikku/pull/4080","diff_url":"https://github.com/otavanopisto/muikku/pull/4080.diff","patch_url":"https://github.com/otavanopisto/muikku/pull/4080.patch","issue_url":"https://api.github.com/repos/otavanopisto/muikku/issues/4080","number":4080,"state":"open","locked":false,"title":"Ftr 3716 form fields refactoring","user":{"login":"avukkonen","id":3994573,"node_id":"MDQ6VXNlcjM5OTQ1NzM=","avatar_url":"https://avatars2.githubusercontent.com/u/3994573?v=4","gravatar_id":"","url":"https://api.github.com/users/avukkonen","html_url":"https://github.com/avukkonen","followers_url":"https://api.github.com/users/avukkonen/followers","following_url":"https://api.github.com/users/avukkonen/following{/other_user}","gists_url":"https://api.github.com/users/avukkonen/gists{/gist_id}","starred_url":"https://api.github.com/users/avukkonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avukkonen/subscriptions","organizations_url":"https://api.github.com/users/avukkonen/orgs","repos_url":"https://api.github.com/users/avukkonen/repos","events_url":"https://api.github.com/users/avukkonen/events{/privacy}","received_events_url":"https://api.github.com/users/avukkonen/received_events","type":"User","site_admin":false},"body":"Closes #3716 \r\nCloses #4024 (Not 100% sure, the basic styles are there)","created_at":"2018-06-17T21:31:31Z","updated_at":"2018-06-17T21:31:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5bd43c863fac6812206089878424884b91ae61d8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":190870172,"node_id":"MDU6TGFiZWwxOTA4NzAxNzI=","url":"https://api.github.com/repos/otavanopisto/muikku/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/otavanopisto/muikku/pulls/4080/commits","review_comments_url":"https://api.github.com/repos/otavanopisto/muikku/pulls/4080/comments","review_comment_url":"https://api.github.com/repos/otavanopisto/muikku/pulls/comments{/number}","comments_url":"https://api.github.com/repos/otavanopisto/muikku/issues/4080/comments","statuses_url":"https://api.github.com/repos/otavanopisto/muikku/statuses/623b334233d4a5cac70080c3f29bde840796f7c8","head":{"label":"otavanopisto:FTR-3716-form-fields-refactoring","ref":"FTR-3716-form-fields-refactoring","sha":"623b334233d4a5cac70080c3f29bde840796f7c8","user":{"login":"otavanopisto","id":3909061,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MDkwNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/3909061?v=4","gravatar_id":"","url":"https://api.github.com/users/otavanopisto","html_url":"https://github.com/otavanopisto","followers_url":"https://api.github.com/users/otavanopisto/followers","following_url":"https://api.github.com/users/otavanopisto/following{/other_user}","gists_url":"https://api.github.com/users/otavanopisto/gists{/gist_id}","starred_url":"https://api.github.com/users/otavanopisto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otavanopisto/subscriptions","organizations_url":"https://api.github.com/users/otavanopisto/orgs","repos_url":"https://api.github.com/users/otavanopisto/repos","events_url":"https://api.github.com/users/otavanopisto/events{/privacy}","received_events_url":"https://api.github.com/users/otavanopisto/received_events","type":"Organization","site_admin":false},"repo":{"id":8877030,"node_id":"MDEwOlJlcG9zaXRvcnk4ODc3MDMw","name":"muikku","full_name":"otavanopisto/muikku","owner":{"login":"otavanopisto","id":3909061,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MDkwNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/3909061?v=4","gravatar_id":"","url":"https://api.github.com/users/otavanopisto","html_url":"https://github.com/otavanopisto","followers_url":"https://api.github.com/users/otavanopisto/followers","following_url":"https://api.github.com/users/otavanopisto/following{/other_user}","gists_url":"https://api.github.com/users/otavanopisto/gists{/gist_id}","starred_url":"https://api.github.com/users/otavanopisto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otavanopisto/subscriptions","organizations_url":"https://api.github.com/users/otavanopisto/orgs","repos_url":"https://api.github.com/users/otavanopisto/repos","events_url":"https://api.github.com/users/otavanopisto/events{/privacy}","received_events_url":"https://api.github.com/users/otavanopisto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/otavanopisto/muikku","description":"Muikku Learning Environment","fork":false,"url":"https://api.github.com/repos/otavanopisto/muikku","forks_url":"https://api.github.com/repos/otavanopisto/muikku/forks","keys_url":"https://api.github.com/repos/otavanopisto/muikku/keys{/key_id}","collaborators_url":"https://api.github.com/repos/otavanopisto/muikku/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/otavanopisto/muikku/teams","hooks_url":"https://api.github.com/repos/otavanopisto/muikku/hooks","issue_events_url":"https://api.github.com/repos/otavanopisto/muikku/issues/events{/number}","events_url":"https://api.github.com/repos/otavanopisto/muikku/events","assignees_url":"https://api.github.com/repos/otavanopisto/muikku/assignees{/user}","branches_url":"https://api.github.com/repos/otavanopisto/muikku/branches{/branch}","tags_url":"https://api.github.com/repos/otavanopisto/muikku/tags","blobs_url":"https://api.github.com/repos/otavanopisto/muikku/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/otavanopisto/muikku/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/otavanopisto/muikku/git/refs{/sha}","trees_url":"https://api.github.com/repos/otavanopisto/muikku/git/trees{/sha}","statuses_url":"https://api.github.com/repos/otavanopisto/muikku/statuses/{sha}","languages_url":"https://api.github.com/repos/otavanopisto/muikku/languages","stargazers_url":"https://api.github.com/repos/otavanopisto/muikku/stargazers","contributors_url":"https://api.github.com/repos/otavanopisto/muikku/contributors","subscribers_url":"https://api.github.com/repos/otavanopisto/muikku/subscribers","subscription_url":"https://api.github.com/repos/otavanopisto/muikku/subscription","commits_url":"https://api.github.com/repos/otavanopisto/muikku/commits{/sha}","git_commits_url":"https://api.github.com/repos/otavanopisto/muikku/git/commits{/sha}","comments_url":"https://api.github.com/repos/otavanopisto/muikku/comments{/number}","issue_comment_url":"https://api.github.com/repos/otavanopisto/muikku/issues/comments{/number}","contents_url":"https://api.github.com/repos/otavanopisto/muikku/contents/{+path}","compare_url":"https://api.github.com/repos/otavanopisto/muikku/compare/{base}...{head}","merges_url":"https://api.github.com/repos/otavanopisto/muikku/merges","archive_url":"https://api.github.com/repos/otavanopisto/muikku/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/otavanopisto/muikku/downloads","issues_url":"https://api.github.com/repos/otavanopisto/muikku/issues{/number}","pulls_url":"https://api.github.com/repos/otavanopisto/muikku/pulls{/number}","milestones_url":"https://api.github.com/repos/otavanopisto/muikku/milestones{/number}","notifications_url":"https://api.github.com/repos/otavanopisto/muikku/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/otavanopisto/muikku/labels{/name}","releases_url":"https://api.github.com/repos/otavanopisto/muikku/releases{/id}","deployments_url":"https://api.github.com/repos/otavanopisto/muikku/deployments","created_at":"2013-03-19T11:30:32Z","updated_at":"2018-06-12T06:56:01Z","pushed_at":"2018-06-17T21:31:32Z","git_url":"git://github.com/otavanopisto/muikku.git","ssh_url":"git@github.com:otavanopisto/muikku.git","clone_url":"https://github.com/otavanopisto/muikku.git","svn_url":"https://github.com/otavanopisto/muikku","homepage":null,"size":271466,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":565,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":565,"watchers":6,"default_branch":"devel"}},"base":{"label":"otavanopisto:FTR-3062_redesign-of-muikku","ref":"FTR-3062_redesign-of-muikku","sha":"3691aa06b4a81b70d0686085e4735f9e7841000e","user":{"login":"otavanopisto","id":3909061,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MDkwNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/3909061?v=4","gravatar_id":"","url":"https://api.github.com/users/otavanopisto","html_url":"https://github.com/otavanopisto","followers_url":"https://api.github.com/users/otavanopisto/followers","following_url":"https://api.github.com/users/otavanopisto/following{/other_user}","gists_url":"https://api.github.com/users/otavanopisto/gists{/gist_id}","starred_url":"https://api.github.com/users/otavanopisto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otavanopisto/subscriptions","organizations_url":"https://api.github.com/users/otavanopisto/orgs","repos_url":"https://api.github.com/users/otavanopisto/repos","events_url":"https://api.github.com/users/otavanopisto/events{/privacy}","received_events_url":"https://api.github.com/users/otavanopisto/received_events","type":"Organization","site_admin":false},"repo":{"id":8877030,"node_id":"MDEwOlJlcG9zaXRvcnk4ODc3MDMw","name":"muikku","full_name":"otavanopisto/muikku","owner":{"login":"otavanopisto","id":3909061,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MDkwNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/3909061?v=4","gravatar_id":"","url":"https://api.github.com/users/otavanopisto","html_url":"https://github.com/otavanopisto","followers_url":"https://api.github.com/users/otavanopisto/followers","following_url":"https://api.github.com/users/otavanopisto/following{/other_user}","gists_url":"https://api.github.com/users/otavanopisto/gists{/gist_id}","starred_url":"https://api.github.com/users/otavanopisto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otavanopisto/subscriptions","organizations_url":"https://api.github.com/users/otavanopisto/orgs","repos_url":"https://api.github.com/users/otavanopisto/repos","events_url":"https://api.github.com/users/otavanopisto/events{/privacy}","received_events_url":"https://api.github.com/users/otavanopisto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/otavanopisto/muikku","description":"Muikku Learning Environment","fork":false,"url":"https://api.github.com/repos/otavanopisto/muikku","forks_url":"https://api.github.com/repos/otavanopisto/muikku/forks","keys_url":"https://api.github.com/repos/otavanopisto/muikku/keys{/key_id}","collaborators_url":"https://api.github.com/repos/otavanopisto/muikku/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/otavanopisto/muikku/teams","hooks_url":"https://api.github.com/repos/otavanopisto/muikku/hooks","issue_events_url":"https://api.github.com/repos/otavanopisto/muikku/issues/events{/number}","events_url":"https://api.github.com/repos/otavanopisto/muikku/events","assignees_url":"https://api.github.com/repos/otavanopisto/muikku/assignees{/user}","branches_url":"https://api.github.com/repos/otavanopisto/muikku/branches{/branch}","tags_url":"https://api.github.com/repos/otavanopisto/muikku/tags","blobs_url":"https://api.github.com/repos/otavanopisto/muikku/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/otavanopisto/muikku/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/otavanopisto/muikku/git/refs{/sha}","trees_url":"https://api.github.com/repos/otavanopisto/muikku/git/trees{/sha}","statuses_url":"https://api.github.com/repos/otavanopisto/muikku/statuses/{sha}","languages_url":"https://api.github.com/repos/otavanopisto/muikku/languages","stargazers_url":"https://api.github.com/repos/otavanopisto/muikku/stargazers","contributors_url":"https://api.github.com/repos/otavanopisto/muikku/contributors","subscribers_url":"https://api.github.com/repos/otavanopisto/muikku/subscribers","subscription_url":"https://api.github.com/repos/otavanopisto/muikku/subscription","commits_url":"https://api.github.com/repos/otavanopisto/muikku/commits{/sha}","git_commits_url":"https://api.github.com/repos/otavanopisto/muikku/git/commits{/sha}","comments_url":"https://api.github.com/repos/otavanopisto/muikku/comments{/number}","issue_comment_url":"https://api.github.com/repos/otavanopisto/muikku/issues/comments{/number}","contents_url":"https://api.github.com/repos/otavanopisto/muikku/contents/{+path}","compare_url":"https://api.github.com/repos/otavanopisto/muikku/compare/{base}...{head}","merges_url":"https://api.github.com/repos/otavanopisto/muikku/merges","archive_url":"https://api.github.com/repos/otavanopisto/muikku/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/otavanopisto/muikku/downloads","issues_url":"https://api.github.com/repos/otavanopisto/muikku/issues{/number}","pulls_url":"https://api.github.com/repos/otavanopisto/muikku/pulls{/number}","milestones_url":"https://api.github.com/repos/otavanopisto/muikku/milestones{/number}","notifications_url":"https://api.github.com/repos/otavanopisto/muikku/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/otavanopisto/muikku/labels{/name}","releases_url":"https://api.github.com/repos/otavanopisto/muikku/releases{/id}","deployments_url":"https://api.github.com/repos/otavanopisto/muikku/deployments","created_at":"2013-03-19T11:30:32Z","updated_at":"2018-06-12T06:56:01Z","pushed_at":"2018-06-17T21:31:32Z","git_url":"git://github.com/otavanopisto/muikku.git","ssh_url":"git@github.com:otavanopisto/muikku.git","clone_url":"https://github.com/otavanopisto/muikku.git","svn_url":"https://github.com/otavanopisto/muikku","homepage":null,"size":271466,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":565,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":565,"watchers":6,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/otavanopisto/muikku/pulls/4080"},"html":{"href":"https://github.com/otavanopisto/muikku/pull/4080"},"issue":{"href":"https://api.github.com/repos/otavanopisto/muikku/issues/4080"},"comments":{"href":"https://api.github.com/repos/otavanopisto/muikku/issues/4080/comments"},"review_comments":{"href":"https://api.github.com/repos/otavanopisto/muikku/pulls/4080/comments"},"review_comment":{"href":"https://api.github.com/repos/otavanopisto/muikku/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/otavanopisto/muikku/pulls/4080/commits"},"statuses":{"href":"https://api.github.com/repos/otavanopisto/muikku/statuses/623b334233d4a5cac70080c3f29bde840796f7c8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}