{"action":"created","comment":{"url":"https://api.github.com/repos/jquery/jquery/pulls/comments/168123071","pull_request_review_id":96435465,"id":168123071,"diff_hunk":"@@ -0,0 +1,10 @@\n+define( function() {\n+\t\"use strict\";\n+\n+\treturn function isAttached( obj ) {\n+\n+      // Replace the use of contains function to check attachment (gh-3504)","path":"src/var/isAttached.js","position":6,"original_position":6,"commit_id":"10715f6e7be6f4f335a4eef36f59132484eb101d","original_commit_id":"10715f6e7be6f4f335a4eef36f59132484eb101d","user":{"login":"mgol","id":1758366,"avatar_url":"https://avatars0.githubusercontent.com/u/1758366?v=4","gravatar_id":"","url":"https://api.github.com/users/mgol","html_url":"https://github.com/mgol","followers_url":"https://api.github.com/users/mgol/followers","following_url":"https://api.github.com/users/mgol/following{/other_user}","gists_url":"https://api.github.com/users/mgol/gists{/gist_id}","starred_url":"https://api.github.com/users/mgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgol/subscriptions","organizations_url":"https://api.github.com/users/mgol/orgs","repos_url":"https://api.github.com/users/mgol/repos","events_url":"https://api.github.com/users/mgol/events{/privacy}","received_events_url":"https://api.github.com/users/mgol/received_events","type":"User","site_admin":false},"body":"This comment is not necessary, at least not in this form. We don't need to describe what the code looked like previously or link to the issue/PR that changed it.","created_at":"2018-02-14T09:51:21Z","updated_at":"2018-02-14T09:51:56Z","html_url":"https://github.com/jquery/jquery/pull/3977#discussion_r168123071","pull_request_url":"https://api.github.com/repos/jquery/jquery/pulls/3977","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery/pulls/comments/168123071"},"html":{"href":"https://github.com/jquery/jquery/pull/3977#discussion_r168123071"},"pull_request":{"href":"https://api.github.com/repos/jquery/jquery/pulls/3977"}}},"pull_request":{"url":"https://api.github.com/repos/jquery/jquery/pulls/3977","id":169048207,"html_url":"https://github.com/jquery/jquery/pull/3977","diff_url":"https://github.com/jquery/jquery/pull/3977.diff","patch_url":"https://github.com/jquery/jquery/pull/3977.patch","issue_url":"https://api.github.com/repos/jquery/jquery/issues/3977","number":3977,"state":"open","locked":false,"title":"Core: Use isAttached to check for attachment of element","user":{"login":"SaptakS","id":9530293,"avatar_url":"https://avatars2.githubusercontent.com/u/9530293?v=4","gravatar_id":"","url":"https://api.github.com/users/SaptakS","html_url":"https://github.com/SaptakS","followers_url":"https://api.github.com/users/SaptakS/followers","following_url":"https://api.github.com/users/SaptakS/following{/other_user}","gists_url":"https://api.github.com/users/SaptakS/gists{/gist_id}","starred_url":"https://api.github.com/users/SaptakS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaptakS/subscriptions","organizations_url":"https://api.github.com/users/SaptakS/orgs","repos_url":"https://api.github.com/users/SaptakS/repos","events_url":"https://api.github.com/users/SaptakS/events{/privacy}","received_events_url":"https://api.github.com/users/SaptakS/received_events","type":"User","site_admin":false},"body":"### Summary ###\r\nThis change replaces the use of `jQuery.contains` to check for attachment of DOM\r\nby `isAttached` function to better communicate what is being done.\r\n\r\nRef gh-3504\r\n\r\n### Checklist ###\r\n<!--\r\nMark an `[x]` for completed items, if you're not sure leave them unchecked and we can assist.\r\n-->\r\n\r\n* [x] All authors have signed the CLA at https://cla.js.foundation/jquery/jquery\r\n* [x] Grunt build and unit tests pass locally with these changes\r\n\r\n<!--\r\nThanks! Bots and humans will be around shortly to check it out.\r\n-->\r\n","created_at":"2018-02-14T08:35:19Z","updated_at":"2018-02-14T09:51:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9966ec25514c9a18a757ff44be8cc3ba9cbcd207","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jquery/jquery/pulls/3977/commits","review_comments_url":"https://api.github.com/repos/jquery/jquery/pulls/3977/comments","review_comment_url":"https://api.github.com/repos/jquery/jquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jquery/jquery/issues/3977/comments","statuses_url":"https://api.github.com/repos/jquery/jquery/statuses/10715f6e7be6f4f335a4eef36f59132484eb101d","head":{"label":"SaptakS:feature/isattached","ref":"feature/isattached","sha":"10715f6e7be6f4f335a4eef36f59132484eb101d","user":{"login":"SaptakS","id":9530293,"avatar_url":"https://avatars2.githubusercontent.com/u/9530293?v=4","gravatar_id":"","url":"https://api.github.com/users/SaptakS","html_url":"https://github.com/SaptakS","followers_url":"https://api.github.com/users/SaptakS/followers","following_url":"https://api.github.com/users/SaptakS/following{/other_user}","gists_url":"https://api.github.com/users/SaptakS/gists{/gist_id}","starred_url":"https://api.github.com/users/SaptakS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaptakS/subscriptions","organizations_url":"https://api.github.com/users/SaptakS/orgs","repos_url":"https://api.github.com/users/SaptakS/repos","events_url":"https://api.github.com/users/SaptakS/events{/privacy}","received_events_url":"https://api.github.com/users/SaptakS/received_events","type":"User","site_admin":false},"repo":{"id":110240146,"name":"jquery","full_name":"SaptakS/jquery","owner":{"login":"SaptakS","id":9530293,"avatar_url":"https://avatars2.githubusercontent.com/u/9530293?v=4","gravatar_id":"","url":"https://api.github.com/users/SaptakS","html_url":"https://github.com/SaptakS","followers_url":"https://api.github.com/users/SaptakS/followers","following_url":"https://api.github.com/users/SaptakS/following{/other_user}","gists_url":"https://api.github.com/users/SaptakS/gists{/gist_id}","starred_url":"https://api.github.com/users/SaptakS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaptakS/subscriptions","organizations_url":"https://api.github.com/users/SaptakS/orgs","repos_url":"https://api.github.com/users/SaptakS/repos","events_url":"https://api.github.com/users/SaptakS/events{/privacy}","received_events_url":"https://api.github.com/users/SaptakS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SaptakS/jquery","description":"jQuery JavaScript Library","fork":true,"url":"https://api.github.com/repos/SaptakS/jquery","forks_url":"https://api.github.com/repos/SaptakS/jquery/forks","keys_url":"https://api.github.com/repos/SaptakS/jquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SaptakS/jquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SaptakS/jquery/teams","hooks_url":"https://api.github.com/repos/SaptakS/jquery/hooks","issue_events_url":"https://api.github.com/repos/SaptakS/jquery/issues/events{/number}","events_url":"https://api.github.com/repos/SaptakS/jquery/events","assignees_url":"https://api.github.com/repos/SaptakS/jquery/assignees{/user}","branches_url":"https://api.github.com/repos/SaptakS/jquery/branches{/branch}","tags_url":"https://api.github.com/repos/SaptakS/jquery/tags","blobs_url":"https://api.github.com/repos/SaptakS/jquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SaptakS/jquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SaptakS/jquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/SaptakS/jquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SaptakS/jquery/statuses/{sha}","languages_url":"https://api.github.com/repos/SaptakS/jquery/languages","stargazers_url":"https://api.github.com/repos/SaptakS/jquery/stargazers","contributors_url":"https://api.github.com/repos/SaptakS/jquery/contributors","subscribers_url":"https://api.github.com/repos/SaptakS/jquery/subscribers","subscription_url":"https://api.github.com/repos/SaptakS/jquery/subscription","commits_url":"https://api.github.com/repos/SaptakS/jquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/SaptakS/jquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/SaptakS/jquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/SaptakS/jquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/SaptakS/jquery/contents/{+path}","compare_url":"https://api.github.com/repos/SaptakS/jquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SaptakS/jquery/merges","archive_url":"https://api.github.com/repos/SaptakS/jquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SaptakS/jquery/downloads","issues_url":"https://api.github.com/repos/SaptakS/jquery/issues{/number}","pulls_url":"https://api.github.com/repos/SaptakS/jquery/pulls{/number}","milestones_url":"https://api.github.com/repos/SaptakS/jquery/milestones{/number}","notifications_url":"https://api.github.com/repos/SaptakS/jquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SaptakS/jquery/labels{/name}","releases_url":"https://api.github.com/repos/SaptakS/jquery/releases{/id}","deployments_url":"https://api.github.com/repos/SaptakS/jquery/deployments","created_at":"2017-11-10T11:31:58Z","updated_at":"2017-11-10T11:32:12Z","pushed_at":"2018-02-14T08:24:40Z","git_url":"git://github.com/SaptakS/jquery.git","ssh_url":"git@github.com:SaptakS/jquery.git","clone_url":"https://github.com/SaptakS/jquery.git","svn_url":"https://github.com/SaptakS/jquery","homepage":"https://jquery.com/","size":27610,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jquery:master","ref":"master","sha":"4a2bcc27f9c3ee24b3effac0fbe1285d1ee23cc5","user":{"login":"jquery","id":70142,"avatar_url":"https://avatars1.githubusercontent.com/u/70142?v=4","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"repo":{"id":167174,"name":"jquery","full_name":"jquery/jquery","owner":{"login":"jquery","id":70142,"avatar_url":"https://avatars1.githubusercontent.com/u/70142?v=4","gravatar_id":"","url":"https://api.github.com/users/jquery","html_url":"https://github.com/jquery","followers_url":"https://api.github.com/users/jquery/followers","following_url":"https://api.github.com/users/jquery/following{/other_user}","gists_url":"https://api.github.com/users/jquery/gists{/gist_id}","starred_url":"https://api.github.com/users/jquery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jquery/subscriptions","organizations_url":"https://api.github.com/users/jquery/orgs","repos_url":"https://api.github.com/users/jquery/repos","events_url":"https://api.github.com/users/jquery/events{/privacy}","received_events_url":"https://api.github.com/users/jquery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jquery/jquery","description":"jQuery JavaScript Library","fork":false,"url":"https://api.github.com/repos/jquery/jquery","forks_url":"https://api.github.com/repos/jquery/jquery/forks","keys_url":"https://api.github.com/repos/jquery/jquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jquery/jquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jquery/jquery/teams","hooks_url":"https://api.github.com/repos/jquery/jquery/hooks","issue_events_url":"https://api.github.com/repos/jquery/jquery/issues/events{/number}","events_url":"https://api.github.com/repos/jquery/jquery/events","assignees_url":"https://api.github.com/repos/jquery/jquery/assignees{/user}","branches_url":"https://api.github.com/repos/jquery/jquery/branches{/branch}","tags_url":"https://api.github.com/repos/jquery/jquery/tags","blobs_url":"https://api.github.com/repos/jquery/jquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jquery/jquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jquery/jquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/jquery/jquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jquery/jquery/statuses/{sha}","languages_url":"https://api.github.com/repos/jquery/jquery/languages","stargazers_url":"https://api.github.com/repos/jquery/jquery/stargazers","contributors_url":"https://api.github.com/repos/jquery/jquery/contributors","subscribers_url":"https://api.github.com/repos/jquery/jquery/subscribers","subscription_url":"https://api.github.com/repos/jquery/jquery/subscription","commits_url":"https://api.github.com/repos/jquery/jquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/jquery/jquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/jquery/jquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/jquery/jquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/jquery/jquery/contents/{+path}","compare_url":"https://api.github.com/repos/jquery/jquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jquery/jquery/merges","archive_url":"https://api.github.com/repos/jquery/jquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jquery/jquery/downloads","issues_url":"https://api.github.com/repos/jquery/jquery/issues{/number}","pulls_url":"https://api.github.com/repos/jquery/jquery/pulls{/number}","milestones_url":"https://api.github.com/repos/jquery/jquery/milestones{/number}","notifications_url":"https://api.github.com/repos/jquery/jquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jquery/jquery/labels{/name}","releases_url":"https://api.github.com/repos/jquery/jquery/releases{/id}","deployments_url":"https://api.github.com/repos/jquery/jquery/deployments","created_at":"2009-04-03T15:20:14Z","updated_at":"2018-02-14T02:50:29Z","pushed_at":"2018-02-14T08:35:20Z","git_url":"git://github.com/jquery/jquery.git","ssh_url":"git@github.com:jquery/jquery.git","clone_url":"https://github.com/jquery/jquery.git","svn_url":"https://github.com/jquery/jquery","homepage":"https://jquery.com/","size":27745,"stargazers_count":48049,"watchers_count":48049,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":14324,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":14324,"open_issues":82,"watchers":48049,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jquery/jquery/pulls/3977"},"html":{"href":"https://github.com/jquery/jquery/pull/3977"},"issue":{"href":"https://api.github.com/repos/jquery/jquery/issues/3977"},"comments":{"href":"https://api.github.com/repos/jquery/jquery/issues/3977/comments"},"review_comments":{"href":"https://api.github.com/repos/jquery/jquery/pulls/3977/comments"},"review_comment":{"href":"https://api.github.com/repos/jquery/jquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jquery/jquery/pulls/3977/commits"},"statuses":{"href":"https://api.github.com/repos/jquery/jquery/statuses/10715f6e7be6f4f335a4eef36f59132484eb101d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mgol"}}