{"action":"created","comment":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments/217086429","pull_request_review_id":154717192,"id":217086429,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzA4NjQyOQ==","diff_hunk":"@@ -0,0 +1,91 @@\n+// Copyright 2018-present the Material Components for iOS authors. All Rights Reserved.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+// http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+import XCTest\n+import MaterialComponents.MDCAlertScheme\n+import MaterialComponents.MDCAlertThemer\n+\n+class MDCAlertControllerAlertThemerTests: XCTestCase {\n+","path":"components/Dialogs/tests/unit/MDCAlertControllerAlertThemerTests.swift","position":20,"original_position":20,"commit_id":"c59c15f13dfcf61400df1a179e1f094d2f50416c","original_commit_id":"c59c15f13dfcf61400df1a179e1f094d2f50416c","user":{"login":"galiak11","id":2329102,"node_id":"MDQ6VXNlcjIzMjkxMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/2329102?v=4","gravatar_id":"","url":"https://api.github.com/users/galiak11","html_url":"https://github.com/galiak11","followers_url":"https://api.github.com/users/galiak11/followers","following_url":"https://api.github.com/users/galiak11/following{/other_user}","gists_url":"https://api.github.com/users/galiak11/gists{/gist_id}","starred_url":"https://api.github.com/users/galiak11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galiak11/subscriptions","organizations_url":"https://api.github.com/users/galiak11/orgs","repos_url":"https://api.github.com/users/galiak11/repos","events_url":"https://api.github.com/users/galiak11/events{/privacy}","received_events_url":"https://api.github.com/users/galiak11/received_events","type":"User","site_admin":false},"body":"A forced unwrapped mutable instance variable seemed like a worse solution than repeating one line in each test which can then be local and immutable. I typically use setup for larger/more-complex initialization logic.\r\n\r\n","created_at":"2018-09-12T15:44:50Z","updated_at":"2018-09-12T15:44:50Z","html_url":"https://github.com/material-components/material-components-ios/pull/5102#discussion_r217086429","pull_request_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/5102","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments/217086429"},"html":{"href":"https://github.com/material-components/material-components-ios/pull/5102#discussion_r217086429"},"pull_request":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/5102"}},"in_reply_to_id":217058000},"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/5102","id":214942411,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0OTQyNDEx","html_url":"https://github.com/material-components/material-components-ios/pull/5102","diff_url":"https://github.com/material-components/material-components-ios/pull/5102.diff","patch_url":"https://github.com/material-components/material-components-ios/pull/5102.patch","issue_url":"https://api.github.com/repos/material-components/material-components-ios/issues/5102","number":5102,"state":"open","locked":false,"title":"[Dialogs] Add a dialog themer","user":{"login":"galiak11","id":2329102,"node_id":"MDQ6VXNlcjIzMjkxMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/2329102?v=4","gravatar_id":"","url":"https://api.github.com/users/galiak11","html_url":"https://github.com/galiak11","followers_url":"https://api.github.com/users/galiak11/followers","following_url":"https://api.github.com/users/galiak11/following{/other_user}","gists_url":"https://api.github.com/users/galiak11/gists{/gist_id}","starred_url":"https://api.github.com/users/galiak11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galiak11/subscriptions","organizations_url":"https://api.github.com/users/galiak11/orgs","repos_url":"https://api.github.com/users/galiak11/repos","events_url":"https://api.github.com/users/galiak11/events{/privacy}","received_events_url":"https://api.github.com/users/galiak11/received_events","type":"User","site_admin":false},"body":"A new Dialog Themer that applies a dialogScheme to a dialog.\r\n\r\nThe dialogScheme includes the color and typography schemes, plus the [dialog's new corner radius property](https://github.com/material-components/material-components-ios/pull/4988) (no themer yet for shapes, so  this property is directly modified by the themer).\r\n\r\nIssue: b/113257098\r\n\r\nNote: See examples using the new themer/scheme in a [followup PR](https://github.com/material-components/material-components-ios/pull/5103).\r\n\r\nBEFORE:\r\n![dialog - before](https://user-images.githubusercontent.com/2329102/45421250-7a4d5380-b65a-11e8-80f4-d677dc5309c1.png)\r\n\r\nAFTER (note the corner radius and themed color & font):\r\n![dialog - after](https://user-images.githubusercontent.com/2329102/45421251-7a4d5380-b65a-11e8-8049-a7c3c9b9249b.png)\r\n","created_at":"2018-09-12T12:27:18Z","updated_at":"2018-09-12T15:44:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e12440843eb81f4528c5754864af589f341f1c80","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":392757587,"node_id":"MDU6TGFiZWwzOTI3NTc1ODc=","url":"https://api.github.com/repos/material-components/material-components-ios/labels/[Dialogs]","name":"[Dialogs]","color":"eeeeee","default":false},{"id":273191333,"node_id":"MDU6TGFiZWwyNzMxOTEzMzM=","url":"https://api.github.com/repos/material-components/material-components-ios/labels/cla:%20yes","name":"cla: yes","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/5102/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/5102/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/issues/5102/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/c59c15f13dfcf61400df1a179e1f094d2f50416c","head":{"label":"galiak11:gk_dialogthemer","ref":"gk_dialogthemer","sha":"c59c15f13dfcf61400df1a179e1f094d2f50416c","user":{"login":"galiak11","id":2329102,"node_id":"MDQ6VXNlcjIzMjkxMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/2329102?v=4","gravatar_id":"","url":"https://api.github.com/users/galiak11","html_url":"https://github.com/galiak11","followers_url":"https://api.github.com/users/galiak11/followers","following_url":"https://api.github.com/users/galiak11/following{/other_user}","gists_url":"https://api.github.com/users/galiak11/gists{/gist_id}","starred_url":"https://api.github.com/users/galiak11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galiak11/subscriptions","organizations_url":"https://api.github.com/users/galiak11/orgs","repos_url":"https://api.github.com/users/galiak11/repos","events_url":"https://api.github.com/users/galiak11/events{/privacy}","received_events_url":"https://api.github.com/users/galiak11/received_events","type":"User","site_admin":false},"repo":{"id":137527649,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc1Mjc2NDk=","name":"material-components-ios","full_name":"galiak11/material-components-ios","owner":{"login":"galiak11","id":2329102,"node_id":"MDQ6VXNlcjIzMjkxMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/2329102?v=4","gravatar_id":"","url":"https://api.github.com/users/galiak11","html_url":"https://github.com/galiak11","followers_url":"https://api.github.com/users/galiak11/followers","following_url":"https://api.github.com/users/galiak11/following{/other_user}","gists_url":"https://api.github.com/users/galiak11/gists{/gist_id}","starred_url":"https://api.github.com/users/galiak11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galiak11/subscriptions","organizations_url":"https://api.github.com/users/galiak11/orgs","repos_url":"https://api.github.com/users/galiak11/repos","events_url":"https://api.github.com/users/galiak11/events{/privacy}","received_events_url":"https://api.github.com/users/galiak11/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/galiak11/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":true,"url":"https://api.github.com/repos/galiak11/material-components-ios","forks_url":"https://api.github.com/repos/galiak11/material-components-ios/forks","keys_url":"https://api.github.com/repos/galiak11/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/galiak11/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/galiak11/material-components-ios/teams","hooks_url":"https://api.github.com/repos/galiak11/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/galiak11/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/galiak11/material-components-ios/events","assignees_url":"https://api.github.com/repos/galiak11/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/galiak11/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/galiak11/material-components-ios/tags","blobs_url":"https://api.github.com/repos/galiak11/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/galiak11/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/galiak11/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/galiak11/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/galiak11/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/galiak11/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/galiak11/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/galiak11/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/galiak11/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/galiak11/material-components-ios/subscription","commits_url":"https://api.github.com/repos/galiak11/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/galiak11/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/galiak11/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/galiak11/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/galiak11/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/galiak11/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/galiak11/material-components-ios/merges","archive_url":"https://api.github.com/repos/galiak11/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/galiak11/material-components-ios/downloads","issues_url":"https://api.github.com/repos/galiak11/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/galiak11/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/galiak11/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/galiak11/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/galiak11/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/galiak11/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/galiak11/material-components-ios/deployments","created_at":"2018-06-15T20:09:08Z","updated_at":"2018-09-12T12:06:24Z","pushed_at":"2018-09-12T12:31:10Z","git_url":"git://github.com/galiak11/material-components-ios.git","ssh_url":"git@github.com:galiak11/material-components-ios.git","clone_url":"https://github.com/galiak11/material-components-ios.git","svn_url":"https://github.com/galiak11/material-components-ios","homepage":"","size":120933,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"material-components:develop","ref":"develop","sha":"fcd70cad6ec577e1fb4033b2fb2f72748bb56cad","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":43820219,"node_id":"MDEwOlJlcG9zaXRvcnk0MzgyMDIxOQ==","name":"material-components-ios","full_name":"material-components/material-components-ios","owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-components/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":false,"url":"https://api.github.com/repos/material-components/material-components-ios","forks_url":"https://api.github.com/repos/material-components/material-components-ios/forks","keys_url":"https://api.github.com/repos/material-components/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-ios/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-ios/events","assignees_url":"https://api.github.com/repos/material-components/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-ios/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-ios/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-ios/merges","archive_url":"https://api.github.com/repos/material-components/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-ios/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-ios/deployments","created_at":"2015-10-07T14:12:39Z","updated_at":"2018-09-12T15:34:56Z","pushed_at":"2018-09-12T15:34:52Z","git_url":"git://github.com/material-components/material-components-ios.git","ssh_url":"git@github.com:material-components/material-components-ios.git","clone_url":"https://github.com/material-components/material-components-ios.git","svn_url":"https://github.com/material-components/material-components-ios","homepage":"","size":121175,"stargazers_count":2752,"watchers_count":2752,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":410,"mirror_url":null,"archived":false,"open_issues_count":721,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":410,"open_issues":721,"watchers":2752,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/5102"},"html":{"href":"https://github.com/material-components/material-components-ios/pull/5102"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/5102"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/5102/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/5102/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/5102/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-ios/statuses/c59c15f13dfcf61400df1a179e1f094d2f50416c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"galiak11"}}