{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/404","repository_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api","labels_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/404/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/404/comments","events_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/404/events","html_url":"https://github.com/kubernetes-sigs/cluster-api/pull/404","id":336000865,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NTU5MTkz","number":404,"title":"Make addons.yaml optional input","user":{"login":"karan","id":3261985,"node_id":"MDQ6VXNlcjMyNjE5ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/3261985?v=4","gravatar_id":"","url":"https://api.github.com/users/karan","html_url":"https://github.com/karan","followers_url":"https://api.github.com/users/karan/followers","following_url":"https://api.github.com/users/karan/following{/other_user}","gists_url":"https://api.github.com/users/karan/gists{/gist_id}","starred_url":"https://api.github.com/users/karan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karan/subscriptions","organizations_url":"https://api.github.com/users/karan/orgs","repos_url":"https://api.github.com/users/karan/repos","events_url":"https://api.github.com/users/karan/events{/privacy}","received_events_url":"https://api.github.com/users/karan/received_events","type":"User","site_admin":false},"labels":[{"id":905052788,"node_id":"MDU6TGFiZWw5MDUwNTI3ODg=","url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":875323571,"node_id":"MDU6TGFiZWw4NzUzMjM1NzE=","url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":904067259,"node_id":"MDU6TGFiZWw5MDQwNjcyNTk=","url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":{"login":"kcoronado","id":10516796,"node_id":"MDQ6VXNlcjEwNTE2Nzk2","avatar_url":"https://avatars1.githubusercontent.com/u/10516796?v=4","gravatar_id":"","url":"https://api.github.com/users/kcoronado","html_url":"https://github.com/kcoronado","followers_url":"https://api.github.com/users/kcoronado/followers","following_url":"https://api.github.com/users/kcoronado/following{/other_user}","gists_url":"https://api.github.com/users/kcoronado/gists{/gist_id}","starred_url":"https://api.github.com/users/kcoronado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcoronado/subscriptions","organizations_url":"https://api.github.com/users/kcoronado/orgs","repos_url":"https://api.github.com/users/kcoronado/repos","events_url":"https://api.github.com/users/kcoronado/events{/privacy}","received_events_url":"https://api.github.com/users/kcoronado/received_events","type":"User","site_admin":false},"assignees":[{"login":"roberthbailey","id":7751204,"node_id":"MDQ6VXNlcjc3NTEyMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7751204?v=4","gravatar_id":"","url":"https://api.github.com/users/roberthbailey","html_url":"https://github.com/roberthbailey","followers_url":"https://api.github.com/users/roberthbailey/followers","following_url":"https://api.github.com/users/roberthbailey/following{/other_user}","gists_url":"https://api.github.com/users/roberthbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/roberthbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roberthbailey/subscriptions","organizations_url":"https://api.github.com/users/roberthbailey/orgs","repos_url":"https://api.github.com/users/roberthbailey/repos","events_url":"https://api.github.com/users/roberthbailey/events{/privacy}","received_events_url":"https://api.github.com/users/roberthbailey/received_events","type":"User","site_admin":false},{"login":"kcoronado","id":10516796,"node_id":"MDQ6VXNlcjEwNTE2Nzk2","avatar_url":"https://avatars1.githubusercontent.com/u/10516796?v=4","gravatar_id":"","url":"https://api.github.com/users/kcoronado","html_url":"https://github.com/kcoronado","followers_url":"https://api.github.com/users/kcoronado/followers","following_url":"https://api.github.com/users/kcoronado/following{/other_user}","gists_url":"https://api.github.com/users/kcoronado/gists{/gist_id}","starred_url":"https://api.github.com/users/kcoronado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcoronado/subscriptions","organizations_url":"https://api.github.com/users/kcoronado/orgs","repos_url":"https://api.github.com/users/kcoronado/repos","events_url":"https://api.github.com/users/kcoronado/events{/privacy}","received_events_url":"https://api.github.com/users/kcoronado/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-06-26T21:39:48Z","updated_at":"2018-06-26T22:11:51Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/pulls/404","html_url":"https://github.com/kubernetes-sigs/cluster-api/pull/404","diff_url":"https://github.com/kubernetes-sigs/cluster-api/pull/404.diff","patch_url":"https://github.com/kubernetes-sigs/cluster-api/pull/404.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\n1. The addons.yaml file is not currently required. Making this a required flag is thus too restrictive.\r\n2. Make some constants package-local.\r\n3. Remove some dead code\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\n\r\n```\r\n\r\n<!-- All reviews default to cc'ing the kube-deploy-reviewers github group. -->\r\n@kubernetes/kube-deploy-reviewers\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/comments/400479595","html_url":"https://github.com/kubernetes-sigs/cluster-api/pull/404#issuecomment-400479595","issue_url":"https://api.github.com/repos/kubernetes-sigs/cluster-api/issues/404","id":400479595,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDQ3OTU5NQ==","user":{"login":"karan","id":3261985,"node_id":"MDQ6VXNlcjMyNjE5ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/3261985?v=4","gravatar_id":"","url":"https://api.github.com/users/karan","html_url":"https://github.com/karan","followers_url":"https://api.github.com/users/karan/followers","following_url":"https://api.github.com/users/karan/following{/other_user}","gists_url":"https://api.github.com/users/karan/gists{/gist_id}","starred_url":"https://api.github.com/users/karan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karan/subscriptions","organizations_url":"https://api.github.com/users/karan/orgs","repos_url":"https://api.github.com/users/karan/repos","events_url":"https://api.github.com/users/karan/events{/privacy}","received_events_url":"https://api.github.com/users/karan/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T22:11:51Z","updated_at":"2018-06-26T22:11:51Z","author_association":"COLLABORATOR","body":"Done"}}
{"actor":{"display_login":"karan"}}