{"action":"created","comment":{"url":"https://api.github.com/repos/aionnetwork/aion/pulls/comments/171358643","pull_request_review_id":100197175,"id":171358643,"diff_hunk":"@@ -241,36 +240,28 @@ private void loadBlockchain() {\n             if (recovered) {\n                 bestBlock = this.repository.getBlockStore().getBestBlock();\n \n-                // checking is the best block has changed since attempting\n-                // recovery\n+                // checking is the best block has changed since attempting recovery\n                 if (bestBlock == null) {\n                     bestBlockShifted = true;\n                 } else {\n-                    bestBlockShifted = !(bestBlockNumber == bestBlock.getNumber()) || // block\n-                                                                                      // number\n-                                                                                      // changed\n-                            !(Arrays.equals(bestBlockRoot, bestBlock.getStateRoot())); // root\n-                                                                                       // hash\n-                                                                                       // changed\n+                    bestBlockShifted = !(bestBlockNumber == bestBlock.getNumber()) || // block number changed\n+                            !(Arrays.equals(bestBlockRoot, bestBlock.getStateRoot())); // root hash changed\n                 }\n \n                 if (bestBlockShifted) {\n-                    LOG.info(\"Rebuilding world state SUCCEEDED. However, the best block CHANGED.\");\n-                    // reinitializing recovery flag in case this is the last\n-                    // attempt\n-                    recovered = false;\n+                    LOG.info(\"Rebuilding world state SUCCEEDED by REVERTING to a previous block.\");\n                 } else {\n                     LOG.info(\"Rebuilding world state SUCCEEDED.\");\n                 }\n             } else {\n-                LOG.info(\"Rebuilding world state FAILED.\");\n+                LOG.error(\"Rebuilding world state FAILED. \"\n+                        + \"Stop the kernel (Ctrl+C) and use the command line --revert option to move back to a valid block.\");","path":"modAionImpl/src/org/aion/zero/impl/AionHub.java","position":null,"original_position":82,"commit_id":"0e340e3bca9d310871838105cc48a772bdd8ab02","original_commit_id":"465977e9362372b86a033b970c66ee84b43a118a","user":{"login":"AlexandraRoatis","id":31413007,"avatar_url":"https://avatars2.githubusercontent.com/u/31413007?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexandraRoatis","html_url":"https://github.com/AlexandraRoatis","followers_url":"https://api.github.com/users/AlexandraRoatis/followers","following_url":"https://api.github.com/users/AlexandraRoatis/following{/other_user}","gists_url":"https://api.github.com/users/AlexandraRoatis/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexandraRoatis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexandraRoatis/subscriptions","organizations_url":"https://api.github.com/users/AlexandraRoatis/orgs","repos_url":"https://api.github.com/users/AlexandraRoatis/repos","events_url":"https://api.github.com/users/AlexandraRoatis/events{/privacy}","received_events_url":"https://api.github.com/users/AlexandraRoatis/received_events","type":"User","site_admin":false},"body":"I improved the message and I will have a tutorial on how to choose the block number when reverting.","created_at":"2018-02-28T19:29:12Z","updated_at":"2018-02-28T19:29:12Z","html_url":"https://github.com/aionnetwork/aion/pull/56#discussion_r171358643","pull_request_url":"https://api.github.com/repos/aionnetwork/aion/pulls/56","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aionnetwork/aion/pulls/comments/171358643"},"html":{"href":"https://github.com/aionnetwork/aion/pull/56#discussion_r171358643"},"pull_request":{"href":"https://api.github.com/repos/aionnetwork/aion/pulls/56"}},"in_reply_to_id":171351819},"pull_request":{"url":"https://api.github.com/repos/aionnetwork/aion/pulls/56","id":172025613,"html_url":"https://github.com/aionnetwork/aion/pull/56","diff_url":"https://github.com/aionnetwork/aion/pull/56.diff","patch_url":"https://github.com/aionnetwork/aion/pull/56.patch","issue_url":"https://api.github.com/repos/aionnetwork/aion/issues/56","number":56,"state":"open","locked":false,"title":"Code clean-up, bug fixes and improved recovery functionality","user":{"login":"AlexandraRoatis","id":31413007,"avatar_url":"https://avatars2.githubusercontent.com/u/31413007?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexandraRoatis","html_url":"https://github.com/AlexandraRoatis","followers_url":"https://api.github.com/users/AlexandraRoatis/followers","following_url":"https://api.github.com/users/AlexandraRoatis/following{/other_user}","gists_url":"https://api.github.com/users/AlexandraRoatis/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexandraRoatis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexandraRoatis/subscriptions","organizations_url":"https://api.github.com/users/AlexandraRoatis/orgs","repos_url":"https://api.github.com/users/AlexandraRoatis/repos","events_url":"https://api.github.com/users/AlexandraRoatis/events{/privacy}","received_events_url":"https://api.github.com/users/AlexandraRoatis/received_events","type":"User","site_admin":false},"body":"Solves:\r\n* https://github.com/gonuco/aion/issues/359\r\n* https://github.com/gonuco/aion/issues/277\r\n* https://github.com/gonuco/aion/issues/364\r\n\r\nProgress towards solving:\r\n* https://github.com/gonuco/aion/issues/369\r\n","created_at":"2018-02-28T17:49:28Z","updated_at":"2018-02-28T19:29:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0fcd56f66fbda4e264650246a9fe87b6b0dfcce1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"qoire","id":4521292,"avatar_url":"https://avatars0.githubusercontent.com/u/4521292?v=4","gravatar_id":"","url":"https://api.github.com/users/qoire","html_url":"https://github.com/qoire","followers_url":"https://api.github.com/users/qoire/followers","following_url":"https://api.github.com/users/qoire/following{/other_user}","gists_url":"https://api.github.com/users/qoire/gists{/gist_id}","starred_url":"https://api.github.com/users/qoire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qoire/subscriptions","organizations_url":"https://api.github.com/users/qoire/orgs","repos_url":"https://api.github.com/users/qoire/repos","events_url":"https://api.github.com/users/qoire/events{/privacy}","received_events_url":"https://api.github.com/users/qoire/received_events","type":"User","site_admin":false},{"login":"yulongaion","id":35706111,"avatar_url":"https://avatars1.githubusercontent.com/u/35706111?v=4","gravatar_id":"","url":"https://api.github.com/users/yulongaion","html_url":"https://github.com/yulongaion","followers_url":"https://api.github.com/users/yulongaion/followers","following_url":"https://api.github.com/users/yulongaion/following{/other_user}","gists_url":"https://api.github.com/users/yulongaion/gists{/gist_id}","starred_url":"https://api.github.com/users/yulongaion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yulongaion/subscriptions","organizations_url":"https://api.github.com/users/yulongaion/orgs","repos_url":"https://api.github.com/users/yulongaion/repos","events_url":"https://api.github.com/users/yulongaion/events{/privacy}","received_events_url":"https://api.github.com/users/yulongaion/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aionnetwork/aion/pulls/56/commits","review_comments_url":"https://api.github.com/repos/aionnetwork/aion/pulls/56/comments","review_comment_url":"https://api.github.com/repos/aionnetwork/aion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aionnetwork/aion/issues/56/comments","statuses_url":"https://api.github.com/repos/aionnetwork/aion/statuses/0e340e3bca9d310871838105cc48a772bdd8ab02","head":{"label":"aionnetwork:dev-db","ref":"dev-db","sha":"0e340e3bca9d310871838105cc48a772bdd8ab02","user":{"login":"aionnetwork","id":35697463,"avatar_url":"https://avatars1.githubusercontent.com/u/35697463?v=4","gravatar_id":"","url":"https://api.github.com/users/aionnetwork","html_url":"https://github.com/aionnetwork","followers_url":"https://api.github.com/users/aionnetwork/followers","following_url":"https://api.github.com/users/aionnetwork/following{/other_user}","gists_url":"https://api.github.com/users/aionnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/aionnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aionnetwork/subscriptions","organizations_url":"https://api.github.com/users/aionnetwork/orgs","repos_url":"https://api.github.com/users/aionnetwork/repos","events_url":"https://api.github.com/users/aionnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/aionnetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":118477931,"name":"aion","full_name":"aionnetwork/aion","owner":{"login":"aionnetwork","id":35697463,"avatar_url":"https://avatars1.githubusercontent.com/u/35697463?v=4","gravatar_id":"","url":"https://api.github.com/users/aionnetwork","html_url":"https://github.com/aionnetwork","followers_url":"https://api.github.com/users/aionnetwork/followers","following_url":"https://api.github.com/users/aionnetwork/following{/other_user}","gists_url":"https://api.github.com/users/aionnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/aionnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aionnetwork/subscriptions","organizations_url":"https://api.github.com/users/aionnetwork/orgs","repos_url":"https://api.github.com/users/aionnetwork/repos","events_url":"https://api.github.com/users/aionnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/aionnetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aionnetwork/aion","description":"aion network","fork":false,"url":"https://api.github.com/repos/aionnetwork/aion","forks_url":"https://api.github.com/repos/aionnetwork/aion/forks","keys_url":"https://api.github.com/repos/aionnetwork/aion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aionnetwork/aion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aionnetwork/aion/teams","hooks_url":"https://api.github.com/repos/aionnetwork/aion/hooks","issue_events_url":"https://api.github.com/repos/aionnetwork/aion/issues/events{/number}","events_url":"https://api.github.com/repos/aionnetwork/aion/events","assignees_url":"https://api.github.com/repos/aionnetwork/aion/assignees{/user}","branches_url":"https://api.github.com/repos/aionnetwork/aion/branches{/branch}","tags_url":"https://api.github.com/repos/aionnetwork/aion/tags","blobs_url":"https://api.github.com/repos/aionnetwork/aion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aionnetwork/aion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aionnetwork/aion/git/refs{/sha}","trees_url":"https://api.github.com/repos/aionnetwork/aion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aionnetwork/aion/statuses/{sha}","languages_url":"https://api.github.com/repos/aionnetwork/aion/languages","stargazers_url":"https://api.github.com/repos/aionnetwork/aion/stargazers","contributors_url":"https://api.github.com/repos/aionnetwork/aion/contributors","subscribers_url":"https://api.github.com/repos/aionnetwork/aion/subscribers","subscription_url":"https://api.github.com/repos/aionnetwork/aion/subscription","commits_url":"https://api.github.com/repos/aionnetwork/aion/commits{/sha}","git_commits_url":"https://api.github.com/repos/aionnetwork/aion/git/commits{/sha}","comments_url":"https://api.github.com/repos/aionnetwork/aion/comments{/number}","issue_comment_url":"https://api.github.com/repos/aionnetwork/aion/issues/comments{/number}","contents_url":"https://api.github.com/repos/aionnetwork/aion/contents/{+path}","compare_url":"https://api.github.com/repos/aionnetwork/aion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aionnetwork/aion/merges","archive_url":"https://api.github.com/repos/aionnetwork/aion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aionnetwork/aion/downloads","issues_url":"https://api.github.com/repos/aionnetwork/aion/issues{/number}","pulls_url":"https://api.github.com/repos/aionnetwork/aion/pulls{/number}","milestones_url":"https://api.github.com/repos/aionnetwork/aion/milestones{/number}","notifications_url":"https://api.github.com/repos/aionnetwork/aion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aionnetwork/aion/labels{/name}","releases_url":"https://api.github.com/repos/aionnetwork/aion/releases{/id}","deployments_url":"https://api.github.com/repos/aionnetwork/aion/deployments","created_at":"2018-01-22T15:46:23Z","updated_at":"2018-02-26T18:16:27Z","pushed_at":"2018-02-28T19:17:44Z","git_url":"git://github.com/aionnetwork/aion.git","ssh_url":"git@github.com:aionnetwork/aion.git","clone_url":"https://github.com/aionnetwork/aion.git","svn_url":"https://github.com/aionnetwork/aion","homepage":"https://aion.network/","size":47832,"stargazers_count":31,"watchers_count":31,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":32,"license":null,"forks":6,"open_issues":32,"watchers":31,"default_branch":"dev"}},"base":{"label":"aionnetwork:dev","ref":"dev","sha":"e64f351a1ea49cfaf521be043aad89665eefee68","user":{"login":"aionnetwork","id":35697463,"avatar_url":"https://avatars1.githubusercontent.com/u/35697463?v=4","gravatar_id":"","url":"https://api.github.com/users/aionnetwork","html_url":"https://github.com/aionnetwork","followers_url":"https://api.github.com/users/aionnetwork/followers","following_url":"https://api.github.com/users/aionnetwork/following{/other_user}","gists_url":"https://api.github.com/users/aionnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/aionnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aionnetwork/subscriptions","organizations_url":"https://api.github.com/users/aionnetwork/orgs","repos_url":"https://api.github.com/users/aionnetwork/repos","events_url":"https://api.github.com/users/aionnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/aionnetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":118477931,"name":"aion","full_name":"aionnetwork/aion","owner":{"login":"aionnetwork","id":35697463,"avatar_url":"https://avatars1.githubusercontent.com/u/35697463?v=4","gravatar_id":"","url":"https://api.github.com/users/aionnetwork","html_url":"https://github.com/aionnetwork","followers_url":"https://api.github.com/users/aionnetwork/followers","following_url":"https://api.github.com/users/aionnetwork/following{/other_user}","gists_url":"https://api.github.com/users/aionnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/aionnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aionnetwork/subscriptions","organizations_url":"https://api.github.com/users/aionnetwork/orgs","repos_url":"https://api.github.com/users/aionnetwork/repos","events_url":"https://api.github.com/users/aionnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/aionnetwork/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aionnetwork/aion","description":"aion network","fork":false,"url":"https://api.github.com/repos/aionnetwork/aion","forks_url":"https://api.github.com/repos/aionnetwork/aion/forks","keys_url":"https://api.github.com/repos/aionnetwork/aion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aionnetwork/aion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aionnetwork/aion/teams","hooks_url":"https://api.github.com/repos/aionnetwork/aion/hooks","issue_events_url":"https://api.github.com/repos/aionnetwork/aion/issues/events{/number}","events_url":"https://api.github.com/repos/aionnetwork/aion/events","assignees_url":"https://api.github.com/repos/aionnetwork/aion/assignees{/user}","branches_url":"https://api.github.com/repos/aionnetwork/aion/branches{/branch}","tags_url":"https://api.github.com/repos/aionnetwork/aion/tags","blobs_url":"https://api.github.com/repos/aionnetwork/aion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aionnetwork/aion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aionnetwork/aion/git/refs{/sha}","trees_url":"https://api.github.com/repos/aionnetwork/aion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aionnetwork/aion/statuses/{sha}","languages_url":"https://api.github.com/repos/aionnetwork/aion/languages","stargazers_url":"https://api.github.com/repos/aionnetwork/aion/stargazers","contributors_url":"https://api.github.com/repos/aionnetwork/aion/contributors","subscribers_url":"https://api.github.com/repos/aionnetwork/aion/subscribers","subscription_url":"https://api.github.com/repos/aionnetwork/aion/subscription","commits_url":"https://api.github.com/repos/aionnetwork/aion/commits{/sha}","git_commits_url":"https://api.github.com/repos/aionnetwork/aion/git/commits{/sha}","comments_url":"https://api.github.com/repos/aionnetwork/aion/comments{/number}","issue_comment_url":"https://api.github.com/repos/aionnetwork/aion/issues/comments{/number}","contents_url":"https://api.github.com/repos/aionnetwork/aion/contents/{+path}","compare_url":"https://api.github.com/repos/aionnetwork/aion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aionnetwork/aion/merges","archive_url":"https://api.github.com/repos/aionnetwork/aion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aionnetwork/aion/downloads","issues_url":"https://api.github.com/repos/aionnetwork/aion/issues{/number}","pulls_url":"https://api.github.com/repos/aionnetwork/aion/pulls{/number}","milestones_url":"https://api.github.com/repos/aionnetwork/aion/milestones{/number}","notifications_url":"https://api.github.com/repos/aionnetwork/aion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aionnetwork/aion/labels{/name}","releases_url":"https://api.github.com/repos/aionnetwork/aion/releases{/id}","deployments_url":"https://api.github.com/repos/aionnetwork/aion/deployments","created_at":"2018-01-22T15:46:23Z","updated_at":"2018-02-26T18:16:27Z","pushed_at":"2018-02-28T19:17:44Z","git_url":"git://github.com/aionnetwork/aion.git","ssh_url":"git@github.com:aionnetwork/aion.git","clone_url":"https://github.com/aionnetwork/aion.git","svn_url":"https://github.com/aionnetwork/aion","homepage":"https://aion.network/","size":47832,"stargazers_count":31,"watchers_count":31,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":32,"license":null,"forks":6,"open_issues":32,"watchers":31,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aionnetwork/aion/pulls/56"},"html":{"href":"https://github.com/aionnetwork/aion/pull/56"},"issue":{"href":"https://api.github.com/repos/aionnetwork/aion/issues/56"},"comments":{"href":"https://api.github.com/repos/aionnetwork/aion/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/aionnetwork/aion/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/aionnetwork/aion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aionnetwork/aion/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/aionnetwork/aion/statuses/0e340e3bca9d310871838105cc48a772bdd8ab02"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"AlexandraRoatis"}}