{"action":"closed","issue":{"url":"https://api.github.com/repos/aiidateam/aiida_core/issues/731","repository_url":"https://api.github.com/repos/aiidateam/aiida_core","labels_url":"https://api.github.com/repos/aiidateam/aiida_core/issues/731/labels{/name}","comments_url":"https://api.github.com/repos/aiidateam/aiida_core/issues/731/comments","events_url":"https://api.github.com/repos/aiidateam/aiida_core/issues/731/events","html_url":"https://github.com/aiidateam/aiida_core/issues/731","id":261028173,"node_id":"MDU6SXNzdWUyNjEwMjgxNzM=","number":731,"title":"Tests for the verdi commands","user":{"login":"szoupanos","id":24694976,"node_id":"MDQ6VXNlcjI0Njk0OTc2","avatar_url":"https://avatars0.githubusercontent.com/u/24694976?v=4","gravatar_id":"","url":"https://api.github.com/users/szoupanos","html_url":"https://github.com/szoupanos","followers_url":"https://api.github.com/users/szoupanos/followers","following_url":"https://api.github.com/users/szoupanos/following{/other_user}","gists_url":"https://api.github.com/users/szoupanos/gists{/gist_id}","starred_url":"https://api.github.com/users/szoupanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szoupanos/subscriptions","organizations_url":"https://api.github.com/users/szoupanos/orgs","repos_url":"https://api.github.com/users/szoupanos/repos","events_url":"https://api.github.com/users/szoupanos/events{/privacy}","received_events_url":"https://api.github.com/users/szoupanos/received_events","type":"User","site_admin":false},"labels":[{"id":522091859,"node_id":"MDU6TGFiZWw1MjIwOTE4NTk=","url":"https://api.github.com/repos/aiidateam/aiida_core/labels/topic/VerdiCommandLine","name":"topic/VerdiCommandLine","color":"eeeeee","default":false}],"state":"closed","locked":false,"assignee":{"login":"sphuber","id":6992332,"node_id":"MDQ6VXNlcjY5OTIzMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/6992332?v=4","gravatar_id":"","url":"https://api.github.com/users/sphuber","html_url":"https://github.com/sphuber","followers_url":"https://api.github.com/users/sphuber/followers","following_url":"https://api.github.com/users/sphuber/following{/other_user}","gists_url":"https://api.github.com/users/sphuber/gists{/gist_id}","starred_url":"https://api.github.com/users/sphuber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphuber/subscriptions","organizations_url":"https://api.github.com/users/sphuber/orgs","repos_url":"https://api.github.com/users/sphuber/repos","events_url":"https://api.github.com/users/sphuber/events{/privacy}","received_events_url":"https://api.github.com/users/sphuber/received_events","type":"User","site_admin":false},"assignees":[{"login":"sphuber","id":6992332,"node_id":"MDQ6VXNlcjY5OTIzMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/6992332?v=4","gravatar_id":"","url":"https://api.github.com/users/sphuber","html_url":"https://github.com/sphuber","followers_url":"https://api.github.com/users/sphuber/followers","following_url":"https://api.github.com/users/sphuber/following{/other_user}","gists_url":"https://api.github.com/users/sphuber/gists{/gist_id}","starred_url":"https://api.github.com/users/sphuber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphuber/subscriptions","organizations_url":"https://api.github.com/users/sphuber/orgs","repos_url":"https://api.github.com/users/sphuber/repos","events_url":"https://api.github.com/users/sphuber/events{/privacy}","received_events_url":"https://api.github.com/users/sphuber/received_events","type":"User","site_admin":false},{"login":"szoupanos","id":24694976,"node_id":"MDQ6VXNlcjI0Njk0OTc2","avatar_url":"https://avatars0.githubusercontent.com/u/24694976?v=4","gravatar_id":"","url":"https://api.github.com/users/szoupanos","html_url":"https://github.com/szoupanos","followers_url":"https://api.github.com/users/szoupanos/followers","following_url":"https://api.github.com/users/szoupanos/following{/other_user}","gists_url":"https://api.github.com/users/szoupanos/gists{/gist_id}","starred_url":"https://api.github.com/users/szoupanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szoupanos/subscriptions","organizations_url":"https://api.github.com/users/szoupanos/orgs","repos_url":"https://api.github.com/users/szoupanos/repos","events_url":"https://api.github.com/users/szoupanos/events{/privacy}","received_events_url":"https://api.github.com/users/szoupanos/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/aiidateam/aiida_core/milestones/7","html_url":"https://github.com/aiidateam/aiida_core/milestone/7","labels_url":"https://api.github.com/repos/aiidateam/aiida_core/milestones/7/labels","id":2825107,"node_id":"MDk6TWlsZXN0b25lMjgyNTEwNw==","number":7,"title":"v1.0.0","description":"","creator":{"login":"ltalirz","id":1053245,"node_id":"MDQ6VXNlcjEwNTMyNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1053245?v=4","gravatar_id":"","url":"https://api.github.com/users/ltalirz","html_url":"https://github.com/ltalirz","followers_url":"https://api.github.com/users/ltalirz/followers","following_url":"https://api.github.com/users/ltalirz/following{/other_user}","gists_url":"https://api.github.com/users/ltalirz/gists{/gist_id}","starred_url":"https://api.github.com/users/ltalirz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltalirz/subscriptions","organizations_url":"https://api.github.com/users/ltalirz/orgs","repos_url":"https://api.github.com/users/ltalirz/repos","events_url":"https://api.github.com/users/ltalirz/events{/privacy}","received_events_url":"https://api.github.com/users/ltalirz/received_events","type":"User","site_admin":false},"open_issues":68,"closed_issues":309,"state":"open","created_at":"2017-10-09T16:23:17Z","updated_at":"2018-10-24T17:10:09Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2017-09-27T15:56:18Z","updated_at":"2018-10-24T17:10:09Z","closed_at":"2018-10-24T17:10:09Z","author_association":"CONTRIBUTOR","body":"Since we discussed a bit with Rico, here are some ideas about the verdi command testing. These came from the discussion that we had on PR #724 \r\n\r\nThere are two levels where a command should be checked:\r\na) it's functionality \r\nb) it's syntax\r\n\r\nFor (a) there are not a lot to be said. Theoretically speaking, everyone who writes a command, should write a test that checks its functionality. Or differently, the functionality should be described by the test and there should be the needed implementation.\r\n\r\nFor (b) there should be an efficient way to check (b1) that the commands receive the expected arguments (no-one changed by accident their signature) and that these are passed correctly to the main code of the command (2b).\r\n\r\n(2b) is click’s job and it is the task of it’s developers that it works as advertised.\r\n\r\nFor (1b) we can get the signature of every command, e.g. the help of the command is updated directly by the defined (click) arguments and then, we can have a test that checks if the currently accepted arguments are those that we initially decided.\r\n\r\nThis test can be easy enough and universal (for all the commands). \r\n"}}
{"actor":{"display_login":"sphuber"}}