{"action":"created","comment":{"url":"https://api.github.com/repos/fluidkeys/fluidkeys/pulls/comments/240167161","pull_request_review_id":183131660,"id":240167161,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDE2NzE2MQ==","diff_hunk":"@@ -85,6 +88,16 @@ func downloadAndDecryptSecrets(key pgpkey.PgpKey) (decryptedSecrets []string, se\n \t\t} else {\n \t\t\tdecryptedSecrets = append(decryptedSecrets, decryptedContent)\n \t\t}\n+\t\tjsonMetadata, err := decrypt(encryptedSecret.EncryptedMetadata, privateKey)","path":"fluidkeys/secretreceive.go","position":91,"original_position":19,"commit_id":"473a517263fcb22726e2574f437f08c895599408","original_commit_id":"473a517263fcb22726e2574f437f08c895599408","user":{"login":"paulfurley","id":254290,"node_id":"MDQ6VXNlcjI1NDI5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/254290?v=4","gravatar_id":"","url":"https://api.github.com/users/paulfurley","html_url":"https://github.com/paulfurley","followers_url":"https://api.github.com/users/paulfurley/followers","following_url":"https://api.github.com/users/paulfurley/following{/other_user}","gists_url":"https://api.github.com/users/paulfurley/gists{/gist_id}","starred_url":"https://api.github.com/users/paulfurley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulfurley/subscriptions","organizations_url":"https://api.github.com/users/paulfurley/orgs","repos_url":"https://api.github.com/users/paulfurley/repos","events_url":"https://api.github.com/users/paulfurley/events{/privacy}","received_events_url":"https://api.github.com/users/paulfurley/received_events","type":"User","site_admin":false},"body":"missing an `err` check here","created_at":"2018-12-10T11:01:55Z","updated_at":"2018-12-10T11:01:55Z","html_url":"https://github.com/fluidkeys/fluidkeys/pull/218#discussion_r240167161","pull_request_url":"https://api.github.com/repos/fluidkeys/fluidkeys/pulls/218","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fluidkeys/fluidkeys/pulls/comments/240167161"},"html":{"href":"https://github.com/fluidkeys/fluidkeys/pull/218#discussion_r240167161"},"pull_request":{"href":"https://api.github.com/repos/fluidkeys/fluidkeys/pulls/218"}}},"pull_request":{"url":"https://api.github.com/repos/fluidkeys/fluidkeys/pulls/218","id":237073480,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MDczNDgw","html_url":"https://github.com/fluidkeys/fluidkeys/pull/218","diff_url":"https://github.com/fluidkeys/fluidkeys/pull/218.diff","patch_url":"https://github.com/fluidkeys/fluidkeys/pull/218.patch","issue_url":"https://api.github.com/repos/fluidkeys/fluidkeys/issues/218","number":218,"state":"open","locked":false,"title":"Delete secrets when downloading","user":{"login":"idrysdale","id":55195,"node_id":"MDQ6VXNlcjU1MTk1","avatar_url":"https://avatars1.githubusercontent.com/u/55195?v=4","gravatar_id":"","url":"https://api.github.com/users/idrysdale","html_url":"https://github.com/idrysdale","followers_url":"https://api.github.com/users/idrysdale/followers","following_url":"https://api.github.com/users/idrysdale/following{/other_user}","gists_url":"https://api.github.com/users/idrysdale/gists{/gist_id}","starred_url":"https://api.github.com/users/idrysdale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idrysdale/subscriptions","organizations_url":"https://api.github.com/users/idrysdale/orgs","repos_url":"https://api.github.com/users/idrysdale/repos","events_url":"https://api.github.com/users/idrysdale/events{/privacy}","received_events_url":"https://api.github.com/users/idrysdale/received_events","type":"User","site_admin":false},"body":"I've decided to delete a secret on the server whether it successfully\ndecrypts or not. I'm not sure what good it'd be to keep it on the server if\nit's failed to decrypt?\n\nAlso, if we fail to either decode the metadata (for the UUID), or to\nactually delete the secret on the server I've opted to log this.\n\n(Rebase after https://github.com/fluidkeys/fluidkeys/pull/217)","created_at":"2018-12-08T15:20:50Z","updated_at":"2018-12-10T11:01:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67c96649a4d02d950d8a19c18375ea0e5a064b2d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fluidkeys/fluidkeys/pulls/218/commits","review_comments_url":"https://api.github.com/repos/fluidkeys/fluidkeys/pulls/218/comments","review_comment_url":"https://api.github.com/repos/fluidkeys/fluidkeys/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fluidkeys/fluidkeys/issues/218/comments","statuses_url":"https://api.github.com/repos/fluidkeys/fluidkeys/statuses/473a517263fcb22726e2574f437f08c895599408","head":{"label":"fluidkeys:delete-received-secrets","ref":"delete-received-secrets","sha":"473a517263fcb22726e2574f437f08c895599408","user":{"login":"fluidkeys","id":40570552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNTcwNTUy","avatar_url":"https://avatars2.githubusercontent.com/u/40570552?v=4","gravatar_id":"","url":"https://api.github.com/users/fluidkeys","html_url":"https://github.com/fluidkeys","followers_url":"https://api.github.com/users/fluidkeys/followers","following_url":"https://api.github.com/users/fluidkeys/following{/other_user}","gists_url":"https://api.github.com/users/fluidkeys/gists{/gist_id}","starred_url":"https://api.github.com/users/fluidkeys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluidkeys/subscriptions","organizations_url":"https://api.github.com/users/fluidkeys/orgs","repos_url":"https://api.github.com/users/fluidkeys/repos","events_url":"https://api.github.com/users/fluidkeys/events{/privacy}","received_events_url":"https://api.github.com/users/fluidkeys/received_events","type":"Organization","site_admin":false},"repo":{"id":143900493,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM5MDA0OTM=","name":"fluidkeys","full_name":"fluidkeys/fluidkeys","private":false,"owner":{"login":"fluidkeys","id":40570552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNTcwNTUy","avatar_url":"https://avatars2.githubusercontent.com/u/40570552?v=4","gravatar_id":"","url":"https://api.github.com/users/fluidkeys","html_url":"https://github.com/fluidkeys","followers_url":"https://api.github.com/users/fluidkeys/followers","following_url":"https://api.github.com/users/fluidkeys/following{/other_user}","gists_url":"https://api.github.com/users/fluidkeys/gists{/gist_id}","starred_url":"https://api.github.com/users/fluidkeys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluidkeys/subscriptions","organizations_url":"https://api.github.com/users/fluidkeys/orgs","repos_url":"https://api.github.com/users/fluidkeys/repos","events_url":"https://api.github.com/users/fluidkeys/events{/privacy}","received_events_url":"https://api.github.com/users/fluidkeys/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fluidkeys/fluidkeys","description":"Fluidkeys supercharges PGP","fork":false,"url":"https://api.github.com/repos/fluidkeys/fluidkeys","forks_url":"https://api.github.com/repos/fluidkeys/fluidkeys/forks","keys_url":"https://api.github.com/repos/fluidkeys/fluidkeys/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fluidkeys/fluidkeys/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fluidkeys/fluidkeys/teams","hooks_url":"https://api.github.com/repos/fluidkeys/fluidkeys/hooks","issue_events_url":"https://api.github.com/repos/fluidkeys/fluidkeys/issues/events{/number}","events_url":"https://api.github.com/repos/fluidkeys/fluidkeys/events","assignees_url":"https://api.github.com/repos/fluidkeys/fluidkeys/assignees{/user}","branches_url":"https://api.github.com/repos/fluidkeys/fluidkeys/branches{/branch}","tags_url":"https://api.github.com/repos/fluidkeys/fluidkeys/tags","blobs_url":"https://api.github.com/repos/fluidkeys/fluidkeys/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fluidkeys/fluidkeys/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fluidkeys/fluidkeys/git/refs{/sha}","trees_url":"https://api.github.com/repos/fluidkeys/fluidkeys/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fluidkeys/fluidkeys/statuses/{sha}","languages_url":"https://api.github.com/repos/fluidkeys/fluidkeys/languages","stargazers_url":"https://api.github.com/repos/fluidkeys/fluidkeys/stargazers","contributors_url":"https://api.github.com/repos/fluidkeys/fluidkeys/contributors","subscribers_url":"https://api.github.com/repos/fluidkeys/fluidkeys/subscribers","subscription_url":"https://api.github.com/repos/fluidkeys/fluidkeys/subscription","commits_url":"https://api.github.com/repos/fluidkeys/fluidkeys/commits{/sha}","git_commits_url":"https://api.github.com/repos/fluidkeys/fluidkeys/git/commits{/sha}","comments_url":"https://api.github.com/repos/fluidkeys/fluidkeys/comments{/number}","issue_comment_url":"https://api.github.com/repos/fluidkeys/fluidkeys/issues/comments{/number}","contents_url":"https://api.github.com/repos/fluidkeys/fluidkeys/contents/{+path}","compare_url":"https://api.github.com/repos/fluidkeys/fluidkeys/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fluidkeys/fluidkeys/merges","archive_url":"https://api.github.com/repos/fluidkeys/fluidkeys/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fluidkeys/fluidkeys/downloads","issues_url":"https://api.github.com/repos/fluidkeys/fluidkeys/issues{/number}","pulls_url":"https://api.github.com/repos/fluidkeys/fluidkeys/pulls{/number}","milestones_url":"https://api.github.com/repos/fluidkeys/fluidkeys/milestones{/number}","notifications_url":"https://api.github.com/repos/fluidkeys/fluidkeys/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fluidkeys/fluidkeys/labels{/name}","releases_url":"https://api.github.com/repos/fluidkeys/fluidkeys/releases{/id}","deployments_url":"https://api.github.com/repos/fluidkeys/fluidkeys/deployments","created_at":"2018-08-07T16:32:18Z","updated_at":"2018-12-06T22:12:45Z","pushed_at":"2018-12-10T10:57:09Z","git_url":"git://github.com/fluidkeys/fluidkeys.git","ssh_url":"git@github.com:fluidkeys/fluidkeys.git","clone_url":"https://github.com/fluidkeys/fluidkeys.git","svn_url":"https://github.com/fluidkeys/fluidkeys","homepage":"https://www.fluidkeys.com","size":6169,"stargazers_count":15,"watchers_count":15,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":1,"open_issues":7,"watchers":15,"default_branch":"master"}},"base":{"label":"fluidkeys:master","ref":"master","sha":"2300bd4c33c5472e8539b413f68557440562f82d","user":{"login":"fluidkeys","id":40570552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNTcwNTUy","avatar_url":"https://avatars2.githubusercontent.com/u/40570552?v=4","gravatar_id":"","url":"https://api.github.com/users/fluidkeys","html_url":"https://github.com/fluidkeys","followers_url":"https://api.github.com/users/fluidkeys/followers","following_url":"https://api.github.com/users/fluidkeys/following{/other_user}","gists_url":"https://api.github.com/users/fluidkeys/gists{/gist_id}","starred_url":"https://api.github.com/users/fluidkeys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluidkeys/subscriptions","organizations_url":"https://api.github.com/users/fluidkeys/orgs","repos_url":"https://api.github.com/users/fluidkeys/repos","events_url":"https://api.github.com/users/fluidkeys/events{/privacy}","received_events_url":"https://api.github.com/users/fluidkeys/received_events","type":"Organization","site_admin":false},"repo":{"id":143900493,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM5MDA0OTM=","name":"fluidkeys","full_name":"fluidkeys/fluidkeys","private":false,"owner":{"login":"fluidkeys","id":40570552,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNTcwNTUy","avatar_url":"https://avatars2.githubusercontent.com/u/40570552?v=4","gravatar_id":"","url":"https://api.github.com/users/fluidkeys","html_url":"https://github.com/fluidkeys","followers_url":"https://api.github.com/users/fluidkeys/followers","following_url":"https://api.github.com/users/fluidkeys/following{/other_user}","gists_url":"https://api.github.com/users/fluidkeys/gists{/gist_id}","starred_url":"https://api.github.com/users/fluidkeys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluidkeys/subscriptions","organizations_url":"https://api.github.com/users/fluidkeys/orgs","repos_url":"https://api.github.com/users/fluidkeys/repos","events_url":"https://api.github.com/users/fluidkeys/events{/privacy}","received_events_url":"https://api.github.com/users/fluidkeys/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fluidkeys/fluidkeys","description":"Fluidkeys supercharges PGP","fork":false,"url":"https://api.github.com/repos/fluidkeys/fluidkeys","forks_url":"https://api.github.com/repos/fluidkeys/fluidkeys/forks","keys_url":"https://api.github.com/repos/fluidkeys/fluidkeys/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fluidkeys/fluidkeys/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fluidkeys/fluidkeys/teams","hooks_url":"https://api.github.com/repos/fluidkeys/fluidkeys/hooks","issue_events_url":"https://api.github.com/repos/fluidkeys/fluidkeys/issues/events{/number}","events_url":"https://api.github.com/repos/fluidkeys/fluidkeys/events","assignees_url":"https://api.github.com/repos/fluidkeys/fluidkeys/assignees{/user}","branches_url":"https://api.github.com/repos/fluidkeys/fluidkeys/branches{/branch}","tags_url":"https://api.github.com/repos/fluidkeys/fluidkeys/tags","blobs_url":"https://api.github.com/repos/fluidkeys/fluidkeys/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fluidkeys/fluidkeys/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fluidkeys/fluidkeys/git/refs{/sha}","trees_url":"https://api.github.com/repos/fluidkeys/fluidkeys/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fluidkeys/fluidkeys/statuses/{sha}","languages_url":"https://api.github.com/repos/fluidkeys/fluidkeys/languages","stargazers_url":"https://api.github.com/repos/fluidkeys/fluidkeys/stargazers","contributors_url":"https://api.github.com/repos/fluidkeys/fluidkeys/contributors","subscribers_url":"https://api.github.com/repos/fluidkeys/fluidkeys/subscribers","subscription_url":"https://api.github.com/repos/fluidkeys/fluidkeys/subscription","commits_url":"https://api.github.com/repos/fluidkeys/fluidkeys/commits{/sha}","git_commits_url":"https://api.github.com/repos/fluidkeys/fluidkeys/git/commits{/sha}","comments_url":"https://api.github.com/repos/fluidkeys/fluidkeys/comments{/number}","issue_comment_url":"https://api.github.com/repos/fluidkeys/fluidkeys/issues/comments{/number}","contents_url":"https://api.github.com/repos/fluidkeys/fluidkeys/contents/{+path}","compare_url":"https://api.github.com/repos/fluidkeys/fluidkeys/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fluidkeys/fluidkeys/merges","archive_url":"https://api.github.com/repos/fluidkeys/fluidkeys/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fluidkeys/fluidkeys/downloads","issues_url":"https://api.github.com/repos/fluidkeys/fluidkeys/issues{/number}","pulls_url":"https://api.github.com/repos/fluidkeys/fluidkeys/pulls{/number}","milestones_url":"https://api.github.com/repos/fluidkeys/fluidkeys/milestones{/number}","notifications_url":"https://api.github.com/repos/fluidkeys/fluidkeys/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fluidkeys/fluidkeys/labels{/name}","releases_url":"https://api.github.com/repos/fluidkeys/fluidkeys/releases{/id}","deployments_url":"https://api.github.com/repos/fluidkeys/fluidkeys/deployments","created_at":"2018-08-07T16:32:18Z","updated_at":"2018-12-06T22:12:45Z","pushed_at":"2018-12-10T10:57:09Z","git_url":"git://github.com/fluidkeys/fluidkeys.git","ssh_url":"git@github.com:fluidkeys/fluidkeys.git","clone_url":"https://github.com/fluidkeys/fluidkeys.git","svn_url":"https://github.com/fluidkeys/fluidkeys","homepage":"https://www.fluidkeys.com","size":6169,"stargazers_count":15,"watchers_count":15,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":1,"open_issues":7,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fluidkeys/fluidkeys/pulls/218"},"html":{"href":"https://github.com/fluidkeys/fluidkeys/pull/218"},"issue":{"href":"https://api.github.com/repos/fluidkeys/fluidkeys/issues/218"},"comments":{"href":"https://api.github.com/repos/fluidkeys/fluidkeys/issues/218/comments"},"review_comments":{"href":"https://api.github.com/repos/fluidkeys/fluidkeys/pulls/218/comments"},"review_comment":{"href":"https://api.github.com/repos/fluidkeys/fluidkeys/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fluidkeys/fluidkeys/pulls/218/commits"},"statuses":{"href":"https://api.github.com/repos/fluidkeys/fluidkeys/statuses/473a517263fcb22726e2574f437f08c895599408"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"paulfurley"}}