{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/pulls/comments/226410004","pull_request_review_id":166225144,"id":226410004,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjQxMDAwNA==","diff_hunk":"@@ -125,15 +140,15 @@ type getCallerIdentityWrapper struct {\n // Generator provides new tokens for the heptio authenticator.\n type Generator interface {\n \t// Get a token using credentials in the default credentials chain.\n-\tGet(string) (string, error)\n+\tGet(string) (*Token, error)","path":"pkg/token/token.go","position":35,"original_position":35,"commit_id":"65ba8eebb620cc1da66fd9ed3a2070d0f38c4e63","original_commit_id":"65ba8eebb620cc1da66fd9ed3a2070d0f38c4e63","user":{"login":"mattlandis","id":708286,"node_id":"MDQ6VXNlcjcwODI4Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/708286?v=4","gravatar_id":"","url":"https://api.github.com/users/mattlandis","html_url":"https://github.com/mattlandis","followers_url":"https://api.github.com/users/mattlandis/followers","following_url":"https://api.github.com/users/mattlandis/following{/other_user}","gists_url":"https://api.github.com/users/mattlandis/gists{/gist_id}","starred_url":"https://api.github.com/users/mattlandis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattlandis/subscriptions","organizations_url":"https://api.github.com/users/mattlandis/orgs","repos_url":"https://api.github.com/users/mattlandis/repos","events_url":"https://api.github.com/users/mattlandis/events{/privacy}","received_events_url":"https://api.github.com/users/mattlandis/received_events","type":"User","site_admin":false},"body":"I would prefer returning an empty struct to nil since we don't use it as a pointer (modify contents etc.)","created_at":"2018-10-18T18:06:36Z","updated_at":"2018-10-18T18:17:42Z","html_url":"https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/160#discussion_r226410004","pull_request_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/pulls/160","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/pulls/comments/226410004"},"html":{"href":"https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/160#discussion_r226410004"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/pulls/160"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/pulls/160","id":222657635,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjU3NjM1","html_url":"https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/160","diff_url":"https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/160.diff","patch_url":"https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/160.patch","issue_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/issues/160","number":160,"state":"open","locked":false,"title":"Add expiration to token creation","user":{"login":"nckturner","id":1205393,"node_id":"MDQ6VXNlcjEyMDUzOTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1205393?v=4","gravatar_id":"","url":"https://api.github.com/users/nckturner","html_url":"https://github.com/nckturner","followers_url":"https://api.github.com/users/nckturner/followers","following_url":"https://api.github.com/users/nckturner/following{/other_user}","gists_url":"https://api.github.com/users/nckturner/gists{/gist_id}","starred_url":"https://api.github.com/users/nckturner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nckturner/subscriptions","organizations_url":"https://api.github.com/users/nckturner/orgs","repos_url":"https://api.github.com/users/nckturner/repos","events_url":"https://api.github.com/users/nckturner/events{/privacy}","received_events_url":"https://api.github.com/users/nckturner/received_events","type":"User","site_admin":false},"body":"STS presigned urls expire after 15 minutes, and are not configurable,\r\nso we refresh tokens after 14 minutes to prevent getting occasional\r\nunauthorized responses.\r\n\r\nFixes #133 ","created_at":"2018-10-13T15:41:35Z","updated_at":"2018-10-18T18:17:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"305c2e0fe63605aaa24b63f14dfa5ebe4ec17250","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mattmoyer","id":3210334,"node_id":"MDQ6VXNlcjMyMTAzMzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3210334?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoyer","html_url":"https://github.com/mattmoyer","followers_url":"https://api.github.com/users/mattmoyer/followers","following_url":"https://api.github.com/users/mattmoyer/following{/other_user}","gists_url":"https://api.github.com/users/mattmoyer/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoyer/subscriptions","organizations_url":"https://api.github.com/users/mattmoyer/orgs","repos_url":"https://api.github.com/users/mattmoyer/repos","events_url":"https://api.github.com/users/mattmoyer/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoyer/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":972792420,"node_id":"MDU6TGFiZWw5NzI3OTI0MjA=","url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":972621891,"node_id":"MDU6TGFiZWw5NzI2MjE4OTE=","url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":972798593,"node_id":"MDU6TGFiZWw5NzI3OTg1OTM=","url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":972791949,"node_id":"MDU6TGFiZWw5NzI3OTE5NDk=","url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/pulls/160/commits","review_comments_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/pulls/160/comments","review_comment_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/issues/160/comments","statuses_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/statuses/65ba8eebb620cc1da66fd9ed3a2070d0f38c4e63","head":{"label":"nckturner:expiration","ref":"expiration","sha":"65ba8eebb620cc1da66fd9ed3a2070d0f38c4e63","user":{"login":"nckturner","id":1205393,"node_id":"MDQ6VXNlcjEyMDUzOTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1205393?v=4","gravatar_id":"","url":"https://api.github.com/users/nckturner","html_url":"https://github.com/nckturner","followers_url":"https://api.github.com/users/nckturner/followers","following_url":"https://api.github.com/users/nckturner/following{/other_user}","gists_url":"https://api.github.com/users/nckturner/gists{/gist_id}","starred_url":"https://api.github.com/users/nckturner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nckturner/subscriptions","organizations_url":"https://api.github.com/users/nckturner/orgs","repos_url":"https://api.github.com/users/nckturner/repos","events_url":"https://api.github.com/users/nckturner/events{/privacy}","received_events_url":"https://api.github.com/users/nckturner/received_events","type":"User","site_admin":false},"repo":{"id":109163273,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkxNjMyNzM=","name":"authenticator","full_name":"nckturner/authenticator","private":false,"owner":{"login":"nckturner","id":1205393,"node_id":"MDQ6VXNlcjEyMDUzOTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1205393?v=4","gravatar_id":"","url":"https://api.github.com/users/nckturner","html_url":"https://github.com/nckturner","followers_url":"https://api.github.com/users/nckturner/followers","following_url":"https://api.github.com/users/nckturner/following{/other_user}","gists_url":"https://api.github.com/users/nckturner/gists{/gist_id}","starred_url":"https://api.github.com/users/nckturner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nckturner/subscriptions","organizations_url":"https://api.github.com/users/nckturner/orgs","repos_url":"https://api.github.com/users/nckturner/repos","events_url":"https://api.github.com/users/nckturner/events{/privacy}","received_events_url":"https://api.github.com/users/nckturner/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nckturner/authenticator","description":"A tool for using AWS IAM credentials to authenticate to a Kubernetes cluster (proof of concept)","fork":true,"url":"https://api.github.com/repos/nckturner/authenticator","forks_url":"https://api.github.com/repos/nckturner/authenticator/forks","keys_url":"https://api.github.com/repos/nckturner/authenticator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nckturner/authenticator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nckturner/authenticator/teams","hooks_url":"https://api.github.com/repos/nckturner/authenticator/hooks","issue_events_url":"https://api.github.com/repos/nckturner/authenticator/issues/events{/number}","events_url":"https://api.github.com/repos/nckturner/authenticator/events","assignees_url":"https://api.github.com/repos/nckturner/authenticator/assignees{/user}","branches_url":"https://api.github.com/repos/nckturner/authenticator/branches{/branch}","tags_url":"https://api.github.com/repos/nckturner/authenticator/tags","blobs_url":"https://api.github.com/repos/nckturner/authenticator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nckturner/authenticator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nckturner/authenticator/git/refs{/sha}","trees_url":"https://api.github.com/repos/nckturner/authenticator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nckturner/authenticator/statuses/{sha}","languages_url":"https://api.github.com/repos/nckturner/authenticator/languages","stargazers_url":"https://api.github.com/repos/nckturner/authenticator/stargazers","contributors_url":"https://api.github.com/repos/nckturner/authenticator/contributors","subscribers_url":"https://api.github.com/repos/nckturner/authenticator/subscribers","subscription_url":"https://api.github.com/repos/nckturner/authenticator/subscription","commits_url":"https://api.github.com/repos/nckturner/authenticator/commits{/sha}","git_commits_url":"https://api.github.com/repos/nckturner/authenticator/git/commits{/sha}","comments_url":"https://api.github.com/repos/nckturner/authenticator/comments{/number}","issue_comment_url":"https://api.github.com/repos/nckturner/authenticator/issues/comments{/number}","contents_url":"https://api.github.com/repos/nckturner/authenticator/contents/{+path}","compare_url":"https://api.github.com/repos/nckturner/authenticator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nckturner/authenticator/merges","archive_url":"https://api.github.com/repos/nckturner/authenticator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nckturner/authenticator/downloads","issues_url":"https://api.github.com/repos/nckturner/authenticator/issues{/number}","pulls_url":"https://api.github.com/repos/nckturner/authenticator/pulls{/number}","milestones_url":"https://api.github.com/repos/nckturner/authenticator/milestones{/number}","notifications_url":"https://api.github.com/repos/nckturner/authenticator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nckturner/authenticator/labels{/name}","releases_url":"https://api.github.com/repos/nckturner/authenticator/releases{/id}","deployments_url":"https://api.github.com/repos/nckturner/authenticator/deployments","created_at":"2017-11-01T17:44:13Z","updated_at":"2018-10-08T20:28:46Z","pushed_at":"2018-10-18T17:19:03Z","git_url":"git://github.com/nckturner/authenticator.git","ssh_url":"git@github.com:nckturner/authenticator.git","clone_url":"https://github.com/nckturner/authenticator.git","svn_url":"https://github.com/nckturner/authenticator","homepage":"","size":19813,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-sigs:master","ref":"master","sha":"77720bd482cd6db4fcf9816301f16a2c844c50f0","user":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"repo":{"id":99036030,"node_id":"MDEwOlJlcG9zaXRvcnk5OTAzNjAzMA==","name":"aws-iam-authenticator","full_name":"kubernetes-sigs/aws-iam-authenticator","private":false,"owner":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes-sigs/aws-iam-authenticator","description":"A tool to use AWS IAM credentials to authenticate to a Kubernetes cluster","fork":false,"url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator","forks_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/forks","keys_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/teams","hooks_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/events","assignees_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/tags","blobs_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/languages","stargazers_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/subscription","commits_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/merges","archive_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/downloads","issues_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/deployments","created_at":"2017-08-01T19:29:39Z","updated_at":"2018-10-18T16:37:12Z","pushed_at":"2018-10-18T17:19:04Z","git_url":"git://github.com/kubernetes-sigs/aws-iam-authenticator.git","ssh_url":"git@github.com:kubernetes-sigs/aws-iam-authenticator.git","clone_url":"https://github.com/kubernetes-sigs/aws-iam-authenticator.git","svn_url":"https://github.com/kubernetes-sigs/aws-iam-authenticator","homepage":"","size":19804,"stargazers_count":736,"watchers_count":736,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":106,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":106,"open_issues":45,"watchers":736,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/pulls/160"},"html":{"href":"https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/160"},"issue":{"href":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/issues/160"},"comments":{"href":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-sigs/aws-iam-authenticator/statuses/65ba8eebb620cc1da66fd9ed3a2070d0f38c4e63"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mattlandis"}}