{"action":"created","comment":{"url":"https://api.github.com/repos/kadena-io/pact/pulls/comments/217849378","pull_request_review_id":155671108,"id":217849378,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzg0OTM3OA==","diff_hunk":"@@ -207,15 +294,22 @@ defconst = do\n   a <- arg\n   v <- term\n   m <- meta\n+  gamma <- contextInfo\n   when (isJust (m ^. mModel)) $ syntaxError \"@model not permitted on defconst\"\n-  TConst a modName (CVRaw v) m <$> contextInfo\n+  return $ TConst a modName (CVRaw v) m gamma\n \n meta :: Compile Meta\n-meta = atPairs <|> try docStr <|> return def\n+meta =  atPairs\n+  <|> try docStr\n+  <|> return def\n   where\n+    docStr :: Compile Meta","path":"src/Pact/Compile.hs","position":383,"original_position":383,"commit_id":"e4135273c7757a24c73bdc9b6a1a3d108d3d78ec","original_commit_id":"e4135273c7757a24c73bdc9b6a1a3d108d3d78ec","user":{"login":"emilypi","id":10459342,"node_id":"MDQ6VXNlcjEwNDU5MzQy","avatar_url":"https://avatars2.githubusercontent.com/u/10459342?v=4","gravatar_id":"","url":"https://api.github.com/users/emilypi","html_url":"https://github.com/emilypi","followers_url":"https://api.github.com/users/emilypi/followers","following_url":"https://api.github.com/users/emilypi/following{/other_user}","gists_url":"https://api.github.com/users/emilypi/gists{/gist_id}","starred_url":"https://api.github.com/users/emilypi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilypi/subscriptions","organizations_url":"https://api.github.com/users/emilypi/orgs","repos_url":"https://api.github.com/users/emilypi/repos","events_url":"https://api.github.com/users/emilypi/events{/privacy}","received_events_url":"https://api.github.com/users/emilypi/received_events","type":"User","site_admin":false},"body":"I prefer to make things explicit in the murky mutable typeland that Pact plays in. Maybe one day, when the mutability is gone, and we're not using `StateT` over parsers as the main abstraction, I'd be okay with this, but without them, it's a very ide-driven task to gather type information at any level of function call.","created_at":"2018-09-14T21:39:50Z","updated_at":"2018-09-14T21:39:51Z","html_url":"https://github.com/kadena-io/pact/pull/219#discussion_r217849378","pull_request_url":"https://api.github.com/repos/kadena-io/pact/pulls/219","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/comments/217849378"},"html":{"href":"https://github.com/kadena-io/pact/pull/219#discussion_r217849378"},"pull_request":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/219"}},"in_reply_to_id":217845334},"pull_request":{"url":"https://api.github.com/repos/kadena-io/pact/pulls/219","id":215708859,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NzA4ODU5","html_url":"https://github.com/kadena-io/pact/pull/219","diff_url":"https://github.com/kadena-io/pact/pull/219.diff","patch_url":"https://github.com/kadena-io/pact/pull/219.patch","issue_url":"https://api.github.com/repos/kadena-io/pact/issues/219","number":219,"state":"open","locked":false,"title":"Signatures Cleanup Session","user":{"login":"emilypi","id":10459342,"node_id":"MDQ6VXNlcjEwNDU5MzQy","avatar_url":"https://avatars2.githubusercontent.com/u/10459342?v=4","gravatar_id":"","url":"https://api.github.com/users/emilypi","html_url":"https://github.com/emilypi","followers_url":"https://api.github.com/users/emilypi/followers","following_url":"https://api.github.com/users/emilypi/following{/other_user}","gists_url":"https://api.github.com/users/emilypi/gists{/gist_id}","starred_url":"https://api.github.com/users/emilypi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilypi/subscriptions","organizations_url":"https://api.github.com/users/emilypi/orgs","repos_url":"https://api.github.com/users/emilypi/repos","events_url":"https://api.github.com/users/emilypi/events{/privacy}","received_events_url":"https://api.github.com/users/emilypi/received_events","type":"User","site_admin":false},"body":"Preparing the environment for working on Signatures. Lots of reformatting/refactoring/making things a a little clearer","created_at":"2018-09-14T20:54:32Z","updated_at":"2018-09-14T21:39:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fff5c7b23a52b69990e9395990794f65728e9eaf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kadena-io/pact/pulls/219/commits","review_comments_url":"https://api.github.com/repos/kadena-io/pact/pulls/219/comments","review_comment_url":"https://api.github.com/repos/kadena-io/pact/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kadena-io/pact/issues/219/comments","statuses_url":"https://api.github.com/repos/kadena-io/pact/statuses/e4135273c7757a24c73bdc9b6a1a3d108d3d78ec","head":{"label":"kadena-io:feat/signatures","ref":"feat/signatures","sha":"e4135273c7757a24c73bdc9b6a1a3d108d3d78ec","user":{"login":"kadena-io","id":19830776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODMwNzc2","avatar_url":"https://avatars1.githubusercontent.com/u/19830776?v=4","gravatar_id":"","url":"https://api.github.com/users/kadena-io","html_url":"https://github.com/kadena-io","followers_url":"https://api.github.com/users/kadena-io/followers","following_url":"https://api.github.com/users/kadena-io/following{/other_user}","gists_url":"https://api.github.com/users/kadena-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kadena-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadena-io/subscriptions","organizations_url":"https://api.github.com/users/kadena-io/orgs","repos_url":"https://api.github.com/users/kadena-io/repos","events_url":"https://api.github.com/users/kadena-io/events{/privacy}","received_events_url":"https://api.github.com/users/kadena-io/received_events","type":"Organization","site_admin":false},"repo":{"id":73597023,"node_id":"MDEwOlJlcG9zaXRvcnk3MzU5NzAyMw==","name":"pact","full_name":"kadena-io/pact","owner":{"login":"kadena-io","id":19830776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODMwNzc2","avatar_url":"https://avatars1.githubusercontent.com/u/19830776?v=4","gravatar_id":"","url":"https://api.github.com/users/kadena-io","html_url":"https://github.com/kadena-io","followers_url":"https://api.github.com/users/kadena-io/followers","following_url":"https://api.github.com/users/kadena-io/following{/other_user}","gists_url":"https://api.github.com/users/kadena-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kadena-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadena-io/subscriptions","organizations_url":"https://api.github.com/users/kadena-io/orgs","repos_url":"https://api.github.com/users/kadena-io/repos","events_url":"https://api.github.com/users/kadena-io/events{/privacy}","received_events_url":"https://api.github.com/users/kadena-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kadena-io/pact","description":"The Pact Smart Contract Language","fork":false,"url":"https://api.github.com/repos/kadena-io/pact","forks_url":"https://api.github.com/repos/kadena-io/pact/forks","keys_url":"https://api.github.com/repos/kadena-io/pact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kadena-io/pact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kadena-io/pact/teams","hooks_url":"https://api.github.com/repos/kadena-io/pact/hooks","issue_events_url":"https://api.github.com/repos/kadena-io/pact/issues/events{/number}","events_url":"https://api.github.com/repos/kadena-io/pact/events","assignees_url":"https://api.github.com/repos/kadena-io/pact/assignees{/user}","branches_url":"https://api.github.com/repos/kadena-io/pact/branches{/branch}","tags_url":"https://api.github.com/repos/kadena-io/pact/tags","blobs_url":"https://api.github.com/repos/kadena-io/pact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kadena-io/pact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kadena-io/pact/git/refs{/sha}","trees_url":"https://api.github.com/repos/kadena-io/pact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kadena-io/pact/statuses/{sha}","languages_url":"https://api.github.com/repos/kadena-io/pact/languages","stargazers_url":"https://api.github.com/repos/kadena-io/pact/stargazers","contributors_url":"https://api.github.com/repos/kadena-io/pact/contributors","subscribers_url":"https://api.github.com/repos/kadena-io/pact/subscribers","subscription_url":"https://api.github.com/repos/kadena-io/pact/subscription","commits_url":"https://api.github.com/repos/kadena-io/pact/commits{/sha}","git_commits_url":"https://api.github.com/repos/kadena-io/pact/git/commits{/sha}","comments_url":"https://api.github.com/repos/kadena-io/pact/comments{/number}","issue_comment_url":"https://api.github.com/repos/kadena-io/pact/issues/comments{/number}","contents_url":"https://api.github.com/repos/kadena-io/pact/contents/{+path}","compare_url":"https://api.github.com/repos/kadena-io/pact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kadena-io/pact/merges","archive_url":"https://api.github.com/repos/kadena-io/pact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kadena-io/pact/downloads","issues_url":"https://api.github.com/repos/kadena-io/pact/issues{/number}","pulls_url":"https://api.github.com/repos/kadena-io/pact/pulls{/number}","milestones_url":"https://api.github.com/repos/kadena-io/pact/milestones{/number}","notifications_url":"https://api.github.com/repos/kadena-io/pact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kadena-io/pact/labels{/name}","releases_url":"https://api.github.com/repos/kadena-io/pact/releases{/id}","deployments_url":"https://api.github.com/repos/kadena-io/pact/deployments","created_at":"2016-11-13T05:16:00Z","updated_at":"2018-09-13T21:17:51Z","pushed_at":"2018-09-14T20:54:33Z","git_url":"git://github.com/kadena-io/pact.git","ssh_url":"git@github.com:kadena-io/pact.git","clone_url":"https://github.com/kadena-io/pact.git","svn_url":"https://github.com/kadena-io/pact","homepage":"http://kadena.io/pact","size":3186,"stargazers_count":214,"watchers_count":214,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":24,"open_issues":49,"watchers":214,"default_branch":"master"}},"base":{"label":"kadena-io:master","ref":"master","sha":"91a9b21fc1d65cf72d46c4018227526324587b3e","user":{"login":"kadena-io","id":19830776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODMwNzc2","avatar_url":"https://avatars1.githubusercontent.com/u/19830776?v=4","gravatar_id":"","url":"https://api.github.com/users/kadena-io","html_url":"https://github.com/kadena-io","followers_url":"https://api.github.com/users/kadena-io/followers","following_url":"https://api.github.com/users/kadena-io/following{/other_user}","gists_url":"https://api.github.com/users/kadena-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kadena-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadena-io/subscriptions","organizations_url":"https://api.github.com/users/kadena-io/orgs","repos_url":"https://api.github.com/users/kadena-io/repos","events_url":"https://api.github.com/users/kadena-io/events{/privacy}","received_events_url":"https://api.github.com/users/kadena-io/received_events","type":"Organization","site_admin":false},"repo":{"id":73597023,"node_id":"MDEwOlJlcG9zaXRvcnk3MzU5NzAyMw==","name":"pact","full_name":"kadena-io/pact","owner":{"login":"kadena-io","id":19830776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5ODMwNzc2","avatar_url":"https://avatars1.githubusercontent.com/u/19830776?v=4","gravatar_id":"","url":"https://api.github.com/users/kadena-io","html_url":"https://github.com/kadena-io","followers_url":"https://api.github.com/users/kadena-io/followers","following_url":"https://api.github.com/users/kadena-io/following{/other_user}","gists_url":"https://api.github.com/users/kadena-io/gists{/gist_id}","starred_url":"https://api.github.com/users/kadena-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadena-io/subscriptions","organizations_url":"https://api.github.com/users/kadena-io/orgs","repos_url":"https://api.github.com/users/kadena-io/repos","events_url":"https://api.github.com/users/kadena-io/events{/privacy}","received_events_url":"https://api.github.com/users/kadena-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kadena-io/pact","description":"The Pact Smart Contract Language","fork":false,"url":"https://api.github.com/repos/kadena-io/pact","forks_url":"https://api.github.com/repos/kadena-io/pact/forks","keys_url":"https://api.github.com/repos/kadena-io/pact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kadena-io/pact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kadena-io/pact/teams","hooks_url":"https://api.github.com/repos/kadena-io/pact/hooks","issue_events_url":"https://api.github.com/repos/kadena-io/pact/issues/events{/number}","events_url":"https://api.github.com/repos/kadena-io/pact/events","assignees_url":"https://api.github.com/repos/kadena-io/pact/assignees{/user}","branches_url":"https://api.github.com/repos/kadena-io/pact/branches{/branch}","tags_url":"https://api.github.com/repos/kadena-io/pact/tags","blobs_url":"https://api.github.com/repos/kadena-io/pact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kadena-io/pact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kadena-io/pact/git/refs{/sha}","trees_url":"https://api.github.com/repos/kadena-io/pact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kadena-io/pact/statuses/{sha}","languages_url":"https://api.github.com/repos/kadena-io/pact/languages","stargazers_url":"https://api.github.com/repos/kadena-io/pact/stargazers","contributors_url":"https://api.github.com/repos/kadena-io/pact/contributors","subscribers_url":"https://api.github.com/repos/kadena-io/pact/subscribers","subscription_url":"https://api.github.com/repos/kadena-io/pact/subscription","commits_url":"https://api.github.com/repos/kadena-io/pact/commits{/sha}","git_commits_url":"https://api.github.com/repos/kadena-io/pact/git/commits{/sha}","comments_url":"https://api.github.com/repos/kadena-io/pact/comments{/number}","issue_comment_url":"https://api.github.com/repos/kadena-io/pact/issues/comments{/number}","contents_url":"https://api.github.com/repos/kadena-io/pact/contents/{+path}","compare_url":"https://api.github.com/repos/kadena-io/pact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kadena-io/pact/merges","archive_url":"https://api.github.com/repos/kadena-io/pact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kadena-io/pact/downloads","issues_url":"https://api.github.com/repos/kadena-io/pact/issues{/number}","pulls_url":"https://api.github.com/repos/kadena-io/pact/pulls{/number}","milestones_url":"https://api.github.com/repos/kadena-io/pact/milestones{/number}","notifications_url":"https://api.github.com/repos/kadena-io/pact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kadena-io/pact/labels{/name}","releases_url":"https://api.github.com/repos/kadena-io/pact/releases{/id}","deployments_url":"https://api.github.com/repos/kadena-io/pact/deployments","created_at":"2016-11-13T05:16:00Z","updated_at":"2018-09-13T21:17:51Z","pushed_at":"2018-09-14T20:54:33Z","git_url":"git://github.com/kadena-io/pact.git","ssh_url":"git@github.com:kadena-io/pact.git","clone_url":"https://github.com/kadena-io/pact.git","svn_url":"https://github.com/kadena-io/pact","homepage":"http://kadena.io/pact","size":3186,"stargazers_count":214,"watchers_count":214,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":24,"open_issues":49,"watchers":214,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/219"},"html":{"href":"https://github.com/kadena-io/pact/pull/219"},"issue":{"href":"https://api.github.com/repos/kadena-io/pact/issues/219"},"comments":{"href":"https://api.github.com/repos/kadena-io/pact/issues/219/comments"},"review_comments":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/219/comments"},"review_comment":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kadena-io/pact/pulls/219/commits"},"statuses":{"href":"https://api.github.com/repos/kadena-io/pact/statuses/e4135273c7757a24c73bdc9b6a1a3d108d3d78ec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"emilypi"}}