{"action":"created","issue":{"url":"https://api.github.com/repos/cilium/cilium/issues/6117","repository_url":"https://api.github.com/repos/cilium/cilium","labels_url":"https://api.github.com/repos/cilium/cilium/issues/6117/labels{/name}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/6117/comments","events_url":"https://api.github.com/repos/cilium/cilium/issues/6117/events","html_url":"https://github.com/cilium/cilium/pull/6117","id":375639437,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MDM5MTg3","number":6117,"title":"Add unit tests for pkg/datapath/loader","user":{"login":"joestringer","id":1243336,"node_id":"MDQ6VXNlcjEyNDMzMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1243336?v=4","gravatar_id":"","url":"https://api.github.com/users/joestringer","html_url":"https://github.com/joestringer","followers_url":"https://api.github.com/users/joestringer/followers","following_url":"https://api.github.com/users/joestringer/following{/other_user}","gists_url":"https://api.github.com/users/joestringer/gists{/gist_id}","starred_url":"https://api.github.com/users/joestringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joestringer/subscriptions","organizations_url":"https://api.github.com/users/joestringer/orgs","repos_url":"https://api.github.com/users/joestringer/repos","events_url":"https://api.github.com/users/joestringer/events{/privacy}","received_events_url":"https://api.github.com/users/joestringer/received_events","type":"User","site_admin":false},"labels":[{"id":709779088,"node_id":"MDU6TGFiZWw3MDk3NzkwODg=","url":"https://api.github.com/repos/cilium/cilium/labels/area/CI","name":"area/CI","color":"bfd4f2","default":false},{"id":605668977,"node_id":"MDU6TGFiZWw2MDU2Njg5Nzc=","url":"https://api.github.com/repos/cilium/cilium/labels/area/loader","name":"area/loader","color":"97d6ed","default":false},{"id":1108973997,"node_id":"MDU6TGFiZWwxMTA4OTczOTk3","url":"https://api.github.com/repos/cilium/cilium/labels/halloween-special","name":"halloween-special","color":"fbca04","default":false},{"id":403244562,"node_id":"MDU6TGFiZWw0MDMyNDQ1NjI=","url":"https://api.github.com/repos/cilium/cilium/labels/wip","name":"wip","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cilium/cilium/milestones/20","html_url":"https://github.com/cilium/cilium/milestone/20","labels_url":"https://api.github.com/repos/cilium/cilium/milestones/20/labels","id":3736769,"node_id":"MDk6TWlsZXN0b25lMzczNjc2OQ==","number":20,"title":"1.4-bugfix","description":"","creator":{"login":"tgraf","id":1417913,"node_id":"MDQ6VXNlcjE0MTc5MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1417913?v=4","gravatar_id":"","url":"https://api.github.com/users/tgraf","html_url":"https://github.com/tgraf","followers_url":"https://api.github.com/users/tgraf/followers","following_url":"https://api.github.com/users/tgraf/following{/other_user}","gists_url":"https://api.github.com/users/tgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/tgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgraf/subscriptions","organizations_url":"https://api.github.com/users/tgraf/orgs","repos_url":"https://api.github.com/users/tgraf/repos","events_url":"https://api.github.com/users/tgraf/events{/privacy}","received_events_url":"https://api.github.com/users/tgraf/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":25,"state":"open","created_at":"2018-10-14T10:00:35Z","updated_at":"2018-11-05T16:55:40Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2018-10-30T18:44:48Z","updated_at":"2018-11-06T22:04:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/6117","html_url":"https://github.com/cilium/cilium/pull/6117","diff_url":"https://github.com/cilium/cilium/pull/6117.diff","patch_url":"https://github.com/cilium/cilium/pull/6117.patch"},"body":"WIP: Based upon https://github.com/cilium/cilium/pull/6180 .\r\n\r\nRe-introduce a Jenkins Job for running the privileged tests.\r\n\r\nIn this job, introduce a new set of tests for the loader package.\r\n\r\n```\r\n$ sudo -E make tests-privileged TESTPKGS=github.com/cilium/cilium/pkg/datapath/loader\r\ncan't load package: package github.com/cilium/cilium/test/bpf: C source files not allowed when not using cgo or SWIG: bpf-event-test.c unit-test.c\r\nStarting key-value store containers...                                              \r\ncilium-etcd-test-container                                                      \r\nc82049bf4918b79499a1d11acbcc24a01099743c2d823b52255b18b17e857928                   \r\ncilium-consul-test-container                                                \r\naa9893473cfc45ed563a3c94a274955a3c71dca63a53a6d5ba18f08cef7e0dd0          \r\n  CHECK contrib/scripts/bindata.sh                                                 \r\n?       github.com/cilium/cilium/pkg/datapath/loader    [no test files]\r\n=== RUN   Test                               \r\nSTART: loader_test.go:123: LoaderTestSuite.TestCompileAndLoad                   \r\nPASS: loader_test.go:123: LoaderTestSuite.TestCompileAndLoad    1.609s         \r\n                                                                                \r\nSTART: loader_test.go:149: LoaderTestSuite.TestCompileFailure               \r\nlevel=error msg=\"Command execution failed\" cmd=\"[llc -march=bpf -mcpu=probe -filetype=obj -o /tmp/cilium_814020965/bpf_lxc.o]\" error=\"signal: killed\" subsys=datapath-loader\r\nlevel=error msg=\"Failed to compile bpf_lxc.o: signal: killed\" compiler-pid=14494 linker-pid=14496 subsys=datapath-loader\r\nlevel=warning msg=\"JoinEP: Failed to compile\" debug=false error=\"Failed to compile bpf_lxc.o: signal: killed\" params=\"&{Source:bpf_lxc.c Output:bpf_lxc.o OutputType:obj}\" subsys=datapath-loader\r\nPASS: loader_test.go:149: LoaderTestSuite.TestCompileFailure    0.103s\r\n                                                                                  \r\nSTART: loader_test.go:132: LoaderTestSuite.TestReload            \r\nPASS: loader_test.go:132: LoaderTestSuite.TestReload    3.637s\r\n                                                                                \r\nOK: 3 passed                                    \r\n--- PASS: Test (5.35s)                             \r\nPASS                                                                   \r\ncoverage: 75.8% of statements                                                      \r\nok      github.com/cilium/cilium/pkg/datapath/loader    5.403s  coverage: 75.8% of statements\r\ncilium-etcd-test-container                                                \r\ncilium-consul-test-container\r\n```\r\n\r\nMost of the remaining coverage is error cases which are hard to properly test.\r\n\r\nThe test `TestCompileFailure` is expected to fail, hence why there are error logs but the test is marked as passed in the above example output.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cilium/cilium/6117)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/cilium/cilium/issues/comments/436425537","html_url":"https://github.com/cilium/cilium/pull/6117#issuecomment-436425537","issue_url":"https://api.github.com/repos/cilium/cilium/issues/6117","id":436425537,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjQyNTUzNw==","user":{"login":"coveralls","id":2354108,"node_id":"MDQ6VXNlcjIzNTQxMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2018-11-06T22:04:30Z","updated_at":"2018-11-06T22:04:30Z","author_association":"NONE","body":"\n[![Coverage Status](https://coveralls.io/builds/19946794/badge)](https://coveralls.io/builds/19946794)\n\nCoverage decreased (-0.3%) to 43.092% when pulling **17f97eef0d9eed8ec670388ec2e944bcc15edcdb on joestringer:submit/loader-tests** into **1695a801aad9a66492779508aed4be11eb08724d on cilium:master**.\n"}}
{"actor":{"display_login":"coveralls"}}