{"action":"opened","number":14759,"pull_request":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/14759","id":201772863,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNzcyODYz","html_url":"https://github.com/brave/browser-laptop/pull/14759","diff_url":"https://github.com/brave/browser-laptop/pull/14759.diff","patch_url":"https://github.com/brave/browser-laptop/pull/14759.patch","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/14759","number":14759,"state":"open","locked":false,"title":"Deletes publisher-data.json when wallet is deleted","user":{"login":"ryanml","id":8732757,"node_id":"MDQ6VXNlcjg3MzI3NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8732757?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanml","html_url":"https://github.com/ryanml","followers_url":"https://api.github.com/users/ryanml/followers","following_url":"https://api.github.com/users/ryanml/following{/other_user}","gists_url":"https://api.github.com/users/ryanml/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanml/subscriptions","organizations_url":"https://api.github.com/users/ryanml/orgs","repos_url":"https://api.github.com/users/ryanml/repos","events_url":"https://api.github.com/users/ryanml/events{/privacy}","received_events_url":"https://api.github.com/users/ryanml/received_events","type":"User","site_admin":false},"body":"Fixes #14758\r\n\r\n## Submitter Checklist:\r\n\r\n- [x] Submitted a [ticket](https://github.com/brave/browser-laptop/issues) for my issue if one did not already exist.\r\n-  [x] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [x] Added/updated tests for this change (for new code or code which already has tests).\r\n- [x] Ran `git rebase -i` to squash commits (if needed).\r\n- [x] Tagged reviewers and labelled the pull request [as needed](https://github.com/brave/browser-laptop/wiki/Pull-request-process).\r\n- [ ] Request a security/privacy review [as needed](https://github.com/brave/handbook/blob/master/development/security.md#how-to-request-a-security-review). (Ask a Brave employee to help if you cannot access this document.)\r\n\r\n## Test Plan:\r\nSee #14758\r\n\r\n## Reviewer Checklist:\r\n\r\n- [ ] Request a security/privacy review [as needed](https://github.com/brave/handbook/blob/master/development/security.md#how-to-request-a-security-review) if one was not already requested.\r\n\r\nTests\r\n\r\n\r\n- [x] Adequate test coverage exists to prevent regressions\r\n- [x] Tests should be independent and work correctly when run individually or as a suite [ref](https://github.com/brave/browser-laptop/wiki/Code-Guidelines#test-dependencies)\r\n- [ ] New files have MPL2 license header\r\n\r\n\r\n","created_at":"2018-07-16T22:04:09Z","updated_at":"2018-07-16T22:04:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"ryanml","id":8732757,"node_id":"MDQ6VXNlcjg3MzI3NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8732757?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanml","html_url":"https://github.com/ryanml","followers_url":"https://api.github.com/users/ryanml/followers","following_url":"https://api.github.com/users/ryanml/following{/other_user}","gists_url":"https://api.github.com/users/ryanml/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanml/subscriptions","organizations_url":"https://api.github.com/users/ryanml/orgs","repos_url":"https://api.github.com/users/ryanml/repos","events_url":"https://api.github.com/users/ryanml/events{/privacy}","received_events_url":"https://api.github.com/users/ryanml/received_events","type":"User","site_admin":false},"assignees":[{"login":"ryanml","id":8732757,"node_id":"MDQ6VXNlcjg3MzI3NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8732757?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanml","html_url":"https://github.com/ryanml","followers_url":"https://api.github.com/users/ryanml/followers","following_url":"https://api.github.com/users/ryanml/following{/other_user}","gists_url":"https://api.github.com/users/ryanml/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanml/subscriptions","organizations_url":"https://api.github.com/users/ryanml/orgs","repos_url":"https://api.github.com/users/ryanml/repos","events_url":"https://api.github.com/users/ryanml/events{/privacy}","received_events_url":"https://api.github.com/users/ryanml/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":714300836,"node_id":"MDU6TGFiZWw3MTQzMDA4MzY=","url":"https://api.github.com/repos/brave/browser-laptop/labels/PR/pending-review","name":"PR/pending-review","color":"006b75","default":false},{"id":408464251,"node_id":"MDU6TGFiZWw0MDg0NjQyNTE=","url":"https://api.github.com/repos/brave/browser-laptop/labels/feature/rewards","name":"feature/rewards","color":"ff5000","default":false}],"milestone":{"url":"https://api.github.com/repos/brave/browser-laptop/milestones/119","html_url":"https://github.com/brave/browser-laptop/milestone/119","labels_url":"https://api.github.com/repos/brave/browser-laptop/milestones/119/labels","id":3486576,"node_id":"MDk6TWlsZXN0b25lMzQ4NjU3Ng==","number":119,"title":"0.23.x Release 4","description":"TBD - we may choose to roll these into 0.24.x?","creator":{"login":"alexwykoff","id":1434040,"node_id":"MDQ6VXNlcjE0MzQwNDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1434040?v=4","gravatar_id":"","url":"https://api.github.com/users/alexwykoff","html_url":"https://github.com/alexwykoff","followers_url":"https://api.github.com/users/alexwykoff/followers","following_url":"https://api.github.com/users/alexwykoff/following{/other_user}","gists_url":"https://api.github.com/users/alexwykoff/gists{/gist_id}","starred_url":"https://api.github.com/users/alexwykoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexwykoff/subscriptions","organizations_url":"https://api.github.com/users/alexwykoff/orgs","repos_url":"https://api.github.com/users/alexwykoff/repos","events_url":"https://api.github.com/users/alexwykoff/events{/privacy}","received_events_url":"https://api.github.com/users/alexwykoff/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":0,"state":"open","created_at":"2018-07-10T17:21:54Z","updated_at":"2018-07-16T22:04:09Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/brave/browser-laptop/pulls/14759/commits","review_comments_url":"https://api.github.com/repos/brave/browser-laptop/pulls/14759/comments","review_comment_url":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/14759/comments","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/ff7c4e39d74c75fb703b86a213b792aef9c99f77","head":{"label":"ryanml:delete-pubs","ref":"delete-pubs","sha":"ff7c4e39d74c75fb703b86a213b792aef9c99f77","user":{"login":"ryanml","id":8732757,"node_id":"MDQ6VXNlcjg3MzI3NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8732757?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanml","html_url":"https://github.com/ryanml","followers_url":"https://api.github.com/users/ryanml/followers","following_url":"https://api.github.com/users/ryanml/following{/other_user}","gists_url":"https://api.github.com/users/ryanml/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanml/subscriptions","organizations_url":"https://api.github.com/users/ryanml/orgs","repos_url":"https://api.github.com/users/ryanml/repos","events_url":"https://api.github.com/users/ryanml/events{/privacy}","received_events_url":"https://api.github.com/users/ryanml/received_events","type":"User","site_admin":false},"repo":{"id":122024874,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIwMjQ4NzQ=","name":"browser-laptop","full_name":"ryanml/browser-laptop","owner":{"login":"ryanml","id":8732757,"node_id":"MDQ6VXNlcjg3MzI3NTc=","avatar_url":"https://avatars2.githubusercontent.com/u/8732757?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanml","html_url":"https://github.com/ryanml","followers_url":"https://api.github.com/users/ryanml/followers","following_url":"https://api.github.com/users/ryanml/following{/other_user}","gists_url":"https://api.github.com/users/ryanml/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanml/subscriptions","organizations_url":"https://api.github.com/users/ryanml/orgs","repos_url":"https://api.github.com/users/ryanml/repos","events_url":"https://api.github.com/users/ryanml/events{/privacy}","received_events_url":"https://api.github.com/users/ryanml/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryanml/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":true,"url":"https://api.github.com/repos/ryanml/browser-laptop","forks_url":"https://api.github.com/repos/ryanml/browser-laptop/forks","keys_url":"https://api.github.com/repos/ryanml/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryanml/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryanml/browser-laptop/teams","hooks_url":"https://api.github.com/repos/ryanml/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/ryanml/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/ryanml/browser-laptop/events","assignees_url":"https://api.github.com/repos/ryanml/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/ryanml/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/ryanml/browser-laptop/tags","blobs_url":"https://api.github.com/repos/ryanml/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryanml/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryanml/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryanml/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryanml/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/ryanml/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/ryanml/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/ryanml/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/ryanml/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/ryanml/browser-laptop/subscription","commits_url":"https://api.github.com/repos/ryanml/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryanml/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryanml/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryanml/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryanml/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/ryanml/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryanml/browser-laptop/merges","archive_url":"https://api.github.com/repos/ryanml/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryanml/browser-laptop/downloads","issues_url":"https://api.github.com/repos/ryanml/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/ryanml/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/ryanml/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/ryanml/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryanml/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/ryanml/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/ryanml/browser-laptop/deployments","created_at":"2018-02-19T06:04:02Z","updated_at":"2018-07-13T19:46:03Z","pushed_at":"2018-07-16T22:02:31Z","git_url":"git://github.com/ryanml/browser-laptop.git","ssh_url":"git@github.com:ryanml/browser-laptop.git","clone_url":"https://github.com/ryanml/browser-laptop.git","svn_url":"https://github.com/ryanml/browser-laptop","homepage":"https://www.brave.com","size":86675,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"d60325000ec274e13c889254034fe33abe618c2d","user":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":46891997,"node_id":"MDEwOlJlcG9zaXRvcnk0Njg5MTk5Nw==","name":"browser-laptop","full_name":"brave/browser-laptop","owner":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":false,"url":"https://api.github.com/repos/brave/browser-laptop","forks_url":"https://api.github.com/repos/brave/browser-laptop/forks","keys_url":"https://api.github.com/repos/brave/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/browser-laptop/teams","hooks_url":"https://api.github.com/repos/brave/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/brave/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/brave/browser-laptop/events","assignees_url":"https://api.github.com/repos/brave/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/brave/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/brave/browser-laptop/tags","blobs_url":"https://api.github.com/repos/brave/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/brave/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/brave/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/brave/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/brave/browser-laptop/subscription","commits_url":"https://api.github.com/repos/brave/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/brave/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/browser-laptop/merges","archive_url":"https://api.github.com/repos/brave/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/browser-laptop/downloads","issues_url":"https://api.github.com/repos/brave/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/brave/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/brave/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/brave/browser-laptop/deployments","created_at":"2015-11-25T22:55:10Z","updated_at":"2018-07-16T16:55:29Z","pushed_at":"2018-07-16T21:25:55Z","git_url":"git://github.com/brave/browser-laptop.git","ssh_url":"git@github.com:brave/browser-laptop.git","clone_url":"https://github.com/brave/browser-laptop.git","svn_url":"https://github.com/brave/browser-laptop","homepage":"https://www.brave.com","size":92318,"stargazers_count":7833,"watchers_count":7833,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1032,"mirror_url":null,"archived":false,"open_issues_count":2725,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1032,"open_issues":2725,"watchers":7833,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/14759"},"html":{"href":"https://github.com/brave/browser-laptop/pull/14759"},"issue":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/14759"},"comments":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/14759/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/14759/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/14759/commits"},"statuses":{"href":"https://api.github.com/repos/brave/browser-laptop/statuses/ff7c4e39d74c75fb703b86a213b792aef9c99f77"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":160,"deletions":96,"changed_files":2}}
{"actor":{"display_login":"ryanml"}}