{"action":"created","comment":{"url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/comments/167855369","pull_request_review_id":96130772,"id":167855369,"diff_hunk":"@@ -1211,10 +1212,14 @@ module VM = struct\n       | HVM hvm_info ->\n         let disks = List.filter_map (fun vbd ->\n             let id = vbd.Vbd.id in\n-            if hvm_info.Vm.qemu_disk_cmdline && (List.mem_assoc id qemu_vbds)\n+            if (List.mem_assoc id qemu_vbds)\n             then\n-              let index, bd = List.assoc id qemu_vbds in\n-              let path = block_device_of_vbd_frontend bd in\n+              let index, bd_opt = List.assoc id qemu_vbds in\n+              let path =\n+                match bd_opt with\n+                | Some bd -> block_device_of_vbd_frontend bd\n+                | None -> \"\"\n+              in","path":"xc/xenops_server_xen.ml","position":42,"original_position":42,"commit_id":"96538a1989d29ba5607e8749cccb7aba77c138c0","original_commit_id":"ffddbbfb414d7a83ecde14f07fa0809941af5c9c","user":{"login":"kc284","id":3705142,"avatar_url":"https://avatars1.githubusercontent.com/u/3705142?v=4","gravatar_id":"","url":"https://api.github.com/users/kc284","html_url":"https://github.com/kc284","followers_url":"https://api.github.com/users/kc284/followers","following_url":"https://api.github.com/users/kc284/following{/other_user}","gists_url":"https://api.github.com/users/kc284/gists{/gist_id}","starred_url":"https://api.github.com/users/kc284/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kc284/subscriptions","organizations_url":"https://api.github.com/users/kc284/orgs","repos_url":"https://api.github.com/users/kc284/repos","events_url":"https://api.github.com/users/kc284/events{/privacy}","received_events_url":"https://api.github.com/users/kc284/received_events","type":"User","site_admin":false},"body":"I tried the following tests on a VM with one hard drive:\r\n* start the VM with empty cdrom, then mount a disk, then shutdown\r\n* start the VM with full cdrom, then eject the disk, then shutdown\r\nIn the first case 1 qemu frontend is created and 1 is destroyed, in the second case 2 are created and 2 are destroyed, so on the surface of it, it seems the mount/eject operations while the VM is running does not create/destroy a frontend.","created_at":"2018-02-13T12:55:59Z","updated_at":"2018-02-13T12:55:59Z","html_url":"https://github.com/xapi-project/xenopsd/pull/447#discussion_r167855369","pull_request_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/447","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/comments/167855369"},"html":{"href":"https://github.com/xapi-project/xenopsd/pull/447#discussion_r167855369"},"pull_request":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/447"}},"in_reply_to_id":167274466},"pull_request":{"url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/447","id":168007718,"html_url":"https://github.com/xapi-project/xenopsd/pull/447","diff_url":"https://github.com/xapi-project/xenopsd/pull/447.diff","patch_url":"https://github.com/xapi-project/xenopsd/pull/447.patch","issue_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/447","number":447,"state":"closed","locked":false,"title":"CP-24770: Xenopsd calls now the qemu-wrapper script passing in the right parameters for disks and CD drives.","user":{"login":"kc284","id":3705142,"avatar_url":"https://avatars1.githubusercontent.com/u/3705142?v=4","gravatar_id":"","url":"https://api.github.com/users/kc284","html_url":"https://github.com/kc284","followers_url":"https://api.github.com/users/kc284/followers","following_url":"https://api.github.com/users/kc284/following{/other_user}","gists_url":"https://api.github.com/users/kc284/gists{/gist_id}","starred_url":"https://api.github.com/users/kc284/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kc284/subscriptions","organizations_url":"https://api.github.com/users/kc284/orgs","repos_url":"https://api.github.com/users/kc284/repos","events_url":"https://api.github.com/users/kc284/events{/privacy}","received_events_url":"https://api.github.com/users/kc284/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-08T15:42:36Z","updated_at":"2018-02-13T12:55:59Z","closed_at":"2018-02-09T14:41:34Z","merged_at":"2018-02-09T14:41:34Z","merge_commit_sha":"c6e30c94a583b660264f1c0f9cbb4f6766b8bb10","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/447/commits","review_comments_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/447/comments","review_comment_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/447/comments","statuses_url":"https://api.github.com/repos/xapi-project/xenopsd/statuses/96538a1989d29ba5607e8749cccb7aba77c138c0","head":{"label":"kc284:CP-24770","ref":"CP-24770","sha":"96538a1989d29ba5607e8749cccb7aba77c138c0","user":{"login":"kc284","id":3705142,"avatar_url":"https://avatars1.githubusercontent.com/u/3705142?v=4","gravatar_id":"","url":"https://api.github.com/users/kc284","html_url":"https://github.com/kc284","followers_url":"https://api.github.com/users/kc284/followers","following_url":"https://api.github.com/users/kc284/following{/other_user}","gists_url":"https://api.github.com/users/kc284/gists{/gist_id}","starred_url":"https://api.github.com/users/kc284/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kc284/subscriptions","organizations_url":"https://api.github.com/users/kc284/orgs","repos_url":"https://api.github.com/users/kc284/repos","events_url":"https://api.github.com/users/kc284/events{/privacy}","received_events_url":"https://api.github.com/users/kc284/received_events","type":"User","site_admin":false},"repo":{"id":63780753,"name":"xenopsd","full_name":"kc284/xenopsd","owner":{"login":"kc284","id":3705142,"avatar_url":"https://avatars1.githubusercontent.com/u/3705142?v=4","gravatar_id":"","url":"https://api.github.com/users/kc284","html_url":"https://github.com/kc284","followers_url":"https://api.github.com/users/kc284/followers","following_url":"https://api.github.com/users/kc284/following{/other_user}","gists_url":"https://api.github.com/users/kc284/gists{/gist_id}","starred_url":"https://api.github.com/users/kc284/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kc284/subscriptions","organizations_url":"https://api.github.com/users/kc284/orgs","repos_url":"https://api.github.com/users/kc284/repos","events_url":"https://api.github.com/users/kc284/events{/privacy}","received_events_url":"https://api.github.com/users/kc284/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kc284/xenopsd","description":"XCP toolstack domain manager","fork":true,"url":"https://api.github.com/repos/kc284/xenopsd","forks_url":"https://api.github.com/repos/kc284/xenopsd/forks","keys_url":"https://api.github.com/repos/kc284/xenopsd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kc284/xenopsd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kc284/xenopsd/teams","hooks_url":"https://api.github.com/repos/kc284/xenopsd/hooks","issue_events_url":"https://api.github.com/repos/kc284/xenopsd/issues/events{/number}","events_url":"https://api.github.com/repos/kc284/xenopsd/events","assignees_url":"https://api.github.com/repos/kc284/xenopsd/assignees{/user}","branches_url":"https://api.github.com/repos/kc284/xenopsd/branches{/branch}","tags_url":"https://api.github.com/repos/kc284/xenopsd/tags","blobs_url":"https://api.github.com/repos/kc284/xenopsd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kc284/xenopsd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kc284/xenopsd/git/refs{/sha}","trees_url":"https://api.github.com/repos/kc284/xenopsd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kc284/xenopsd/statuses/{sha}","languages_url":"https://api.github.com/repos/kc284/xenopsd/languages","stargazers_url":"https://api.github.com/repos/kc284/xenopsd/stargazers","contributors_url":"https://api.github.com/repos/kc284/xenopsd/contributors","subscribers_url":"https://api.github.com/repos/kc284/xenopsd/subscribers","subscription_url":"https://api.github.com/repos/kc284/xenopsd/subscription","commits_url":"https://api.github.com/repos/kc284/xenopsd/commits{/sha}","git_commits_url":"https://api.github.com/repos/kc284/xenopsd/git/commits{/sha}","comments_url":"https://api.github.com/repos/kc284/xenopsd/comments{/number}","issue_comment_url":"https://api.github.com/repos/kc284/xenopsd/issues/comments{/number}","contents_url":"https://api.github.com/repos/kc284/xenopsd/contents/{+path}","compare_url":"https://api.github.com/repos/kc284/xenopsd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kc284/xenopsd/merges","archive_url":"https://api.github.com/repos/kc284/xenopsd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kc284/xenopsd/downloads","issues_url":"https://api.github.com/repos/kc284/xenopsd/issues{/number}","pulls_url":"https://api.github.com/repos/kc284/xenopsd/pulls{/number}","milestones_url":"https://api.github.com/repos/kc284/xenopsd/milestones{/number}","notifications_url":"https://api.github.com/repos/kc284/xenopsd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kc284/xenopsd/labels{/name}","releases_url":"https://api.github.com/repos/kc284/xenopsd/releases{/id}","deployments_url":"https://api.github.com/repos/kc284/xenopsd/deployments","created_at":"2016-07-20T12:46:24Z","updated_at":"2016-07-20T12:46:26Z","pushed_at":"2018-02-13T11:34:47Z","git_url":"git://github.com/kc284/xenopsd.git","ssh_url":"git@github.com:kc284/xenopsd.git","clone_url":"https://github.com/kc284/xenopsd.git","svn_url":"https://github.com/kc284/xenopsd","homepage":null,"size":32636,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xapi-project:qemu-upstream","ref":"qemu-upstream","sha":"04adc521eb1b4975d5c571fc6d923ef4c333213a","user":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars3.githubusercontent.com/u/317268?v=4","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"repo":{"id":7563740,"name":"xenopsd","full_name":"xapi-project/xenopsd","owner":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars3.githubusercontent.com/u/317268?v=4","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xapi-project/xenopsd","description":"XCP toolstack domain manager","fork":false,"url":"https://api.github.com/repos/xapi-project/xenopsd","forks_url":"https://api.github.com/repos/xapi-project/xenopsd/forks","keys_url":"https://api.github.com/repos/xapi-project/xenopsd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xapi-project/xenopsd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xapi-project/xenopsd/teams","hooks_url":"https://api.github.com/repos/xapi-project/xenopsd/hooks","issue_events_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/events{/number}","events_url":"https://api.github.com/repos/xapi-project/xenopsd/events","assignees_url":"https://api.github.com/repos/xapi-project/xenopsd/assignees{/user}","branches_url":"https://api.github.com/repos/xapi-project/xenopsd/branches{/branch}","tags_url":"https://api.github.com/repos/xapi-project/xenopsd/tags","blobs_url":"https://api.github.com/repos/xapi-project/xenopsd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xapi-project/xenopsd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xapi-project/xenopsd/git/refs{/sha}","trees_url":"https://api.github.com/repos/xapi-project/xenopsd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xapi-project/xenopsd/statuses/{sha}","languages_url":"https://api.github.com/repos/xapi-project/xenopsd/languages","stargazers_url":"https://api.github.com/repos/xapi-project/xenopsd/stargazers","contributors_url":"https://api.github.com/repos/xapi-project/xenopsd/contributors","subscribers_url":"https://api.github.com/repos/xapi-project/xenopsd/subscribers","subscription_url":"https://api.github.com/repos/xapi-project/xenopsd/subscription","commits_url":"https://api.github.com/repos/xapi-project/xenopsd/commits{/sha}","git_commits_url":"https://api.github.com/repos/xapi-project/xenopsd/git/commits{/sha}","comments_url":"https://api.github.com/repos/xapi-project/xenopsd/comments{/number}","issue_comment_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/comments{/number}","contents_url":"https://api.github.com/repos/xapi-project/xenopsd/contents/{+path}","compare_url":"https://api.github.com/repos/xapi-project/xenopsd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xapi-project/xenopsd/merges","archive_url":"https://api.github.com/repos/xapi-project/xenopsd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xapi-project/xenopsd/downloads","issues_url":"https://api.github.com/repos/xapi-project/xenopsd/issues{/number}","pulls_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls{/number}","milestones_url":"https://api.github.com/repos/xapi-project/xenopsd/milestones{/number}","notifications_url":"https://api.github.com/repos/xapi-project/xenopsd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xapi-project/xenopsd/labels{/name}","releases_url":"https://api.github.com/repos/xapi-project/xenopsd/releases{/id}","deployments_url":"https://api.github.com/repos/xapi-project/xenopsd/deployments","created_at":"2013-01-11T17:19:31Z","updated_at":"2017-12-30T01:48:39Z","pushed_at":"2018-02-13T11:32:37Z","git_url":"git://github.com/xapi-project/xenopsd.git","ssh_url":"git@github.com:xapi-project/xenopsd.git","clone_url":"https://github.com/xapi-project/xenopsd.git","svn_url":"https://github.com/xapi-project/xenopsd","homepage":null,"size":32936,"stargazers_count":7,"watchers_count":7,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":53,"open_issues":9,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/447"},"html":{"href":"https://github.com/xapi-project/xenopsd/pull/447"},"issue":{"href":"https://api.github.com/repos/xapi-project/xenopsd/issues/447"},"comments":{"href":"https://api.github.com/repos/xapi-project/xenopsd/issues/447/comments"},"review_comments":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/447/comments"},"review_comment":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/447/commits"},"statuses":{"href":"https://api.github.com/repos/xapi-project/xenopsd/statuses/96538a1989d29ba5607e8749cccb7aba77c138c0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kc284"}}