{"action":"closed","number":8,"pull_request":{"url":"https://api.github.com/repos/Zetatango/porky_lib/pulls/8","id":206058586,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDU4NTg2","html_url":"https://github.com/Zetatango/porky_lib/pull/8","diff_url":"https://github.com/Zetatango/porky_lib/pull/8.diff","patch_url":"https://github.com/Zetatango/porky_lib/pull/8.patch","issue_url":"https://api.github.com/repos/Zetatango/porky_lib/issues/8","number":8,"state":"closed","locked":false,"title":"Do not log potentially sensitive data","user":{"login":"gregfletch","id":1878674,"node_id":"MDQ6VXNlcjE4Nzg2NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1878674?v=4","gravatar_id":"","url":"https://api.github.com/users/gregfletch","html_url":"https://github.com/gregfletch","followers_url":"https://api.github.com/users/gregfletch/followers","following_url":"https://api.github.com/users/gregfletch/following{/other_user}","gists_url":"https://api.github.com/users/gregfletch/gists{/gist_id}","starred_url":"https://api.github.com/users/gregfletch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregfletch/subscriptions","organizations_url":"https://api.github.com/users/gregfletch/orgs","repos_url":"https://api.github.com/users/gregfletch/repos","events_url":"https://api.github.com/users/gregfletch/events{/privacy}","received_events_url":"https://api.github.com/users/gregfletch/received_events","type":"User","site_admin":false},"body":"*Related Issue(s) or Task(s)*\r\n\r\n*Why?*\r\n\r\nAvoid logging potentially sensitive data to avoid information disclosure.\r\n\r\n*How?*\r\n\r\nRemove data from log statements to make log messages more generic.\r\n\r\n*Risks*\r\n\r\nNone\r\n\r\n*Requested Reviewers*\r\n\r\n@dragoszt @michellefoy \r\n","created_at":"2018-08-03T15:06:26Z","updated_at":"2018-08-03T15:55:35Z","closed_at":"2018-08-03T15:55:34Z","merged_at":"2018-08-03T15:55:34Z","merge_commit_sha":"5e9ae71e84c50e6c2bb5ec9363b79589898b9f1c","assignee":{"login":"gregfletch","id":1878674,"node_id":"MDQ6VXNlcjE4Nzg2NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1878674?v=4","gravatar_id":"","url":"https://api.github.com/users/gregfletch","html_url":"https://github.com/gregfletch","followers_url":"https://api.github.com/users/gregfletch/followers","following_url":"https://api.github.com/users/gregfletch/following{/other_user}","gists_url":"https://api.github.com/users/gregfletch/gists{/gist_id}","starred_url":"https://api.github.com/users/gregfletch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregfletch/subscriptions","organizations_url":"https://api.github.com/users/gregfletch/orgs","repos_url":"https://api.github.com/users/gregfletch/repos","events_url":"https://api.github.com/users/gregfletch/events{/privacy}","received_events_url":"https://api.github.com/users/gregfletch/received_events","type":"User","site_admin":false},"assignees":[{"login":"gregfletch","id":1878674,"node_id":"MDQ6VXNlcjE4Nzg2NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1878674?v=4","gravatar_id":"","url":"https://api.github.com/users/gregfletch","html_url":"https://github.com/gregfletch","followers_url":"https://api.github.com/users/gregfletch/followers","following_url":"https://api.github.com/users/gregfletch/following{/other_user}","gists_url":"https://api.github.com/users/gregfletch/gists{/gist_id}","starred_url":"https://api.github.com/users/gregfletch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregfletch/subscriptions","organizations_url":"https://api.github.com/users/gregfletch/orgs","repos_url":"https://api.github.com/users/gregfletch/repos","events_url":"https://api.github.com/users/gregfletch/events{/privacy}","received_events_url":"https://api.github.com/users/gregfletch/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"michellefoy","id":12751980,"node_id":"MDQ6VXNlcjEyNzUxOTgw","avatar_url":"https://avatars0.githubusercontent.com/u/12751980?v=4","gravatar_id":"","url":"https://api.github.com/users/michellefoy","html_url":"https://github.com/michellefoy","followers_url":"https://api.github.com/users/michellefoy/followers","following_url":"https://api.github.com/users/michellefoy/following{/other_user}","gists_url":"https://api.github.com/users/michellefoy/gists{/gist_id}","starred_url":"https://api.github.com/users/michellefoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michellefoy/subscriptions","organizations_url":"https://api.github.com/users/michellefoy/orgs","repos_url":"https://api.github.com/users/michellefoy/repos","events_url":"https://api.github.com/users/michellefoy/events{/privacy}","received_events_url":"https://api.github.com/users/michellefoy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Zetatango/porky_lib/pulls/8/commits","review_comments_url":"https://api.github.com/repos/Zetatango/porky_lib/pulls/8/comments","review_comment_url":"https://api.github.com/repos/Zetatango/porky_lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Zetatango/porky_lib/issues/8/comments","statuses_url":"https://api.github.com/repos/Zetatango/porky_lib/statuses/e6fc0d0732f8bbbaf614f9c32d9230475d0f97b2","head":{"label":"Zetatango:fix_gregfletch_logs","ref":"fix_gregfletch_logs","sha":"e6fc0d0732f8bbbaf614f9c32d9230475d0f97b2","user":{"login":"Zetatango","id":26614652,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NjE0NjUy","avatar_url":"https://avatars3.githubusercontent.com/u/26614652?v=4","gravatar_id":"","url":"https://api.github.com/users/Zetatango","html_url":"https://github.com/Zetatango","followers_url":"https://api.github.com/users/Zetatango/followers","following_url":"https://api.github.com/users/Zetatango/following{/other_user}","gists_url":"https://api.github.com/users/Zetatango/gists{/gist_id}","starred_url":"https://api.github.com/users/Zetatango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zetatango/subscriptions","organizations_url":"https://api.github.com/users/Zetatango/orgs","repos_url":"https://api.github.com/users/Zetatango/repos","events_url":"https://api.github.com/users/Zetatango/events{/privacy}","received_events_url":"https://api.github.com/users/Zetatango/received_events","type":"Organization","site_admin":false},"repo":{"id":139725834,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk3MjU4MzQ=","name":"porky_lib","full_name":"Zetatango/porky_lib","owner":{"login":"Zetatango","id":26614652,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NjE0NjUy","avatar_url":"https://avatars3.githubusercontent.com/u/26614652?v=4","gravatar_id":"","url":"https://api.github.com/users/Zetatango","html_url":"https://github.com/Zetatango","followers_url":"https://api.github.com/users/Zetatango/followers","following_url":"https://api.github.com/users/Zetatango/following{/other_user}","gists_url":"https://api.github.com/users/Zetatango/gists{/gist_id}","starred_url":"https://api.github.com/users/Zetatango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zetatango/subscriptions","organizations_url":"https://api.github.com/users/Zetatango/orgs","repos_url":"https://api.github.com/users/Zetatango/repos","events_url":"https://api.github.com/users/Zetatango/events{/privacy}","received_events_url":"https://api.github.com/users/Zetatango/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Zetatango/porky_lib","description":null,"fork":false,"url":"https://api.github.com/repos/Zetatango/porky_lib","forks_url":"https://api.github.com/repos/Zetatango/porky_lib/forks","keys_url":"https://api.github.com/repos/Zetatango/porky_lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zetatango/porky_lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zetatango/porky_lib/teams","hooks_url":"https://api.github.com/repos/Zetatango/porky_lib/hooks","issue_events_url":"https://api.github.com/repos/Zetatango/porky_lib/issues/events{/number}","events_url":"https://api.github.com/repos/Zetatango/porky_lib/events","assignees_url":"https://api.github.com/repos/Zetatango/porky_lib/assignees{/user}","branches_url":"https://api.github.com/repos/Zetatango/porky_lib/branches{/branch}","tags_url":"https://api.github.com/repos/Zetatango/porky_lib/tags","blobs_url":"https://api.github.com/repos/Zetatango/porky_lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zetatango/porky_lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zetatango/porky_lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zetatango/porky_lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zetatango/porky_lib/statuses/{sha}","languages_url":"https://api.github.com/repos/Zetatango/porky_lib/languages","stargazers_url":"https://api.github.com/repos/Zetatango/porky_lib/stargazers","contributors_url":"https://api.github.com/repos/Zetatango/porky_lib/contributors","subscribers_url":"https://api.github.com/repos/Zetatango/porky_lib/subscribers","subscription_url":"https://api.github.com/repos/Zetatango/porky_lib/subscription","commits_url":"https://api.github.com/repos/Zetatango/porky_lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zetatango/porky_lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zetatango/porky_lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zetatango/porky_lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zetatango/porky_lib/contents/{+path}","compare_url":"https://api.github.com/repos/Zetatango/porky_lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zetatango/porky_lib/merges","archive_url":"https://api.github.com/repos/Zetatango/porky_lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zetatango/porky_lib/downloads","issues_url":"https://api.github.com/repos/Zetatango/porky_lib/issues{/number}","pulls_url":"https://api.github.com/repos/Zetatango/porky_lib/pulls{/number}","milestones_url":"https://api.github.com/repos/Zetatango/porky_lib/milestones{/number}","notifications_url":"https://api.github.com/repos/Zetatango/porky_lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zetatango/porky_lib/labels{/name}","releases_url":"https://api.github.com/repos/Zetatango/porky_lib/releases{/id}","deployments_url":"https://api.github.com/repos/Zetatango/porky_lib/deployments","created_at":"2018-07-04T13:27:33Z","updated_at":"2018-07-30T19:12:02Z","pushed_at":"2018-08-03T15:55:34Z","git_url":"git://github.com/Zetatango/porky_lib.git","ssh_url":"git@github.com:Zetatango/porky_lib.git","clone_url":"https://github.com/Zetatango/porky_lib.git","svn_url":"https://github.com/Zetatango/porky_lib","homepage":null,"size":28,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Zetatango:master","ref":"master","sha":"6be20249b19612e12cb4fbb6e79c44011a5764b7","user":{"login":"Zetatango","id":26614652,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NjE0NjUy","avatar_url":"https://avatars3.githubusercontent.com/u/26614652?v=4","gravatar_id":"","url":"https://api.github.com/users/Zetatango","html_url":"https://github.com/Zetatango","followers_url":"https://api.github.com/users/Zetatango/followers","following_url":"https://api.github.com/users/Zetatango/following{/other_user}","gists_url":"https://api.github.com/users/Zetatango/gists{/gist_id}","starred_url":"https://api.github.com/users/Zetatango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zetatango/subscriptions","organizations_url":"https://api.github.com/users/Zetatango/orgs","repos_url":"https://api.github.com/users/Zetatango/repos","events_url":"https://api.github.com/users/Zetatango/events{/privacy}","received_events_url":"https://api.github.com/users/Zetatango/received_events","type":"Organization","site_admin":false},"repo":{"id":139725834,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk3MjU4MzQ=","name":"porky_lib","full_name":"Zetatango/porky_lib","owner":{"login":"Zetatango","id":26614652,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NjE0NjUy","avatar_url":"https://avatars3.githubusercontent.com/u/26614652?v=4","gravatar_id":"","url":"https://api.github.com/users/Zetatango","html_url":"https://github.com/Zetatango","followers_url":"https://api.github.com/users/Zetatango/followers","following_url":"https://api.github.com/users/Zetatango/following{/other_user}","gists_url":"https://api.github.com/users/Zetatango/gists{/gist_id}","starred_url":"https://api.github.com/users/Zetatango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zetatango/subscriptions","organizations_url":"https://api.github.com/users/Zetatango/orgs","repos_url":"https://api.github.com/users/Zetatango/repos","events_url":"https://api.github.com/users/Zetatango/events{/privacy}","received_events_url":"https://api.github.com/users/Zetatango/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Zetatango/porky_lib","description":null,"fork":false,"url":"https://api.github.com/repos/Zetatango/porky_lib","forks_url":"https://api.github.com/repos/Zetatango/porky_lib/forks","keys_url":"https://api.github.com/repos/Zetatango/porky_lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zetatango/porky_lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zetatango/porky_lib/teams","hooks_url":"https://api.github.com/repos/Zetatango/porky_lib/hooks","issue_events_url":"https://api.github.com/repos/Zetatango/porky_lib/issues/events{/number}","events_url":"https://api.github.com/repos/Zetatango/porky_lib/events","assignees_url":"https://api.github.com/repos/Zetatango/porky_lib/assignees{/user}","branches_url":"https://api.github.com/repos/Zetatango/porky_lib/branches{/branch}","tags_url":"https://api.github.com/repos/Zetatango/porky_lib/tags","blobs_url":"https://api.github.com/repos/Zetatango/porky_lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zetatango/porky_lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zetatango/porky_lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zetatango/porky_lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zetatango/porky_lib/statuses/{sha}","languages_url":"https://api.github.com/repos/Zetatango/porky_lib/languages","stargazers_url":"https://api.github.com/repos/Zetatango/porky_lib/stargazers","contributors_url":"https://api.github.com/repos/Zetatango/porky_lib/contributors","subscribers_url":"https://api.github.com/repos/Zetatango/porky_lib/subscribers","subscription_url":"https://api.github.com/repos/Zetatango/porky_lib/subscription","commits_url":"https://api.github.com/repos/Zetatango/porky_lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zetatango/porky_lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zetatango/porky_lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zetatango/porky_lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zetatango/porky_lib/contents/{+path}","compare_url":"https://api.github.com/repos/Zetatango/porky_lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zetatango/porky_lib/merges","archive_url":"https://api.github.com/repos/Zetatango/porky_lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zetatango/porky_lib/downloads","issues_url":"https://api.github.com/repos/Zetatango/porky_lib/issues{/number}","pulls_url":"https://api.github.com/repos/Zetatango/porky_lib/pulls{/number}","milestones_url":"https://api.github.com/repos/Zetatango/porky_lib/milestones{/number}","notifications_url":"https://api.github.com/repos/Zetatango/porky_lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zetatango/porky_lib/labels{/name}","releases_url":"https://api.github.com/repos/Zetatango/porky_lib/releases{/id}","deployments_url":"https://api.github.com/repos/Zetatango/porky_lib/deployments","created_at":"2018-07-04T13:27:33Z","updated_at":"2018-07-30T19:12:02Z","pushed_at":"2018-08-03T15:55:34Z","git_url":"git://github.com/Zetatango/porky_lib.git","ssh_url":"git@github.com:Zetatango/porky_lib.git","clone_url":"https://github.com/Zetatango/porky_lib.git","svn_url":"https://github.com/Zetatango/porky_lib","homepage":null,"size":28,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Zetatango/porky_lib/pulls/8"},"html":{"href":"https://github.com/Zetatango/porky_lib/pull/8"},"issue":{"href":"https://api.github.com/repos/Zetatango/porky_lib/issues/8"},"comments":{"href":"https://api.github.com/repos/Zetatango/porky_lib/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/Zetatango/porky_lib/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/Zetatango/porky_lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Zetatango/porky_lib/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/Zetatango/porky_lib/statuses/e6fc0d0732f8bbbaf614f9c32d9230475d0f97b2"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"gregfletch","id":1878674,"node_id":"MDQ6VXNlcjE4Nzg2NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1878674?v=4","gravatar_id":"","url":"https://api.github.com/users/gregfletch","html_url":"https://github.com/gregfletch","followers_url":"https://api.github.com/users/gregfletch/followers","following_url":"https://api.github.com/users/gregfletch/following{/other_user}","gists_url":"https://api.github.com/users/gregfletch/gists{/gist_id}","starred_url":"https://api.github.com/users/gregfletch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregfletch/subscriptions","organizations_url":"https://api.github.com/users/gregfletch/orgs","repos_url":"https://api.github.com/users/gregfletch/repos","events_url":"https://api.github.com/users/gregfletch/events{/privacy}","received_events_url":"https://api.github.com/users/gregfletch/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":7,"deletions":7,"changed_files":3}}
{"actor":{"display_login":"gregfletch"}}