{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/204004809","pull_request_review_id":139008607,"id":204004809,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDAwNDgwOQ==","diff_hunk":"@@ -79,7 +79,19 @@ def self.database_settings(node, barclamp)\n       Chef::Log.info(\"Database server found at #{@database_settings[instance][:address]} [cached]\")\n     else\n       @database_settings ||= Hash.new\n-      database = get_node(node, \"database-server\", \"database\", instance)\n+      db_roles, = Chef::Search::Query.new.search(\n+                          :role,\n+                          \"name:database-config-#{instance}\"\n+                        )\n+      db_proposal_role = db_roles.first unless db_roles.empty?","path":"chef/cookbooks/crowbar-openstack/libraries/helpers.rb","position":null,"original_position":9,"commit_id":"824658f002ea5311fb6db885f9406df43ad6d864","original_commit_id":"5b23644341613d296bcecb6f8320aa7cb72714f8","user":{"login":"skazi0","id":2458112,"node_id":"MDQ6VXNlcjI0NTgxMTI=","avatar_url":"https://avatars3.githubusercontent.com/u/2458112?v=4","gravatar_id":"","url":"https://api.github.com/users/skazi0","html_url":"https://github.com/skazi0","followers_url":"https://api.github.com/users/skazi0/followers","following_url":"https://api.github.com/users/skazi0/following{/other_user}","gists_url":"https://api.github.com/users/skazi0/gists{/gist_id}","starred_url":"https://api.github.com/users/skazi0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skazi0/subscriptions","organizations_url":"https://api.github.com/users/skazi0/orgs","repos_url":"https://api.github.com/users/skazi0/repos","events_url":"https://api.github.com/users/skazi0/events{/privacy}","received_events_url":"https://api.github.com/users/skazi0/received_events","type":"User","site_admin":false},"body":"I see @jhesketh already marked this.","created_at":"2018-07-20T10:40:11Z","updated_at":"2018-07-20T10:40:12Z","html_url":"https://github.com/crowbar/crowbar-openstack/pull/1691#discussion_r204004809","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1691","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/204004809"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/1691#discussion_r204004809"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1691"}},"in_reply_to_id":203960852},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1691","id":196777602,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2Nzc3NjAy","html_url":"https://github.com/crowbar/crowbar-openstack/pull/1691","diff_url":"https://github.com/crowbar/crowbar-openstack/pull/1691.diff","patch_url":"https://github.com/crowbar/crowbar-openstack/pull/1691.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1691","number":1691,"state":"open","locked":false,"title":"[4.0] WIP: split database-server role into backend specific roles","user":{"login":"rhafer","id":373399,"node_id":"MDQ6VXNlcjM3MzM5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/373399?v=4","gravatar_id":"","url":"https://api.github.com/users/rhafer","html_url":"https://github.com/rhafer","followers_url":"https://api.github.com/users/rhafer/followers","following_url":"https://api.github.com/users/rhafer/following{/other_user}","gists_url":"https://api.github.com/users/rhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhafer/subscriptions","organizations_url":"https://api.github.com/users/rhafer/orgs","repos_url":"https://api.github.com/users/rhafer/repos","events_url":"https://api.github.com/users/rhafer/events{/privacy}","received_events_url":"https://api.github.com/users/rhafer/received_events","type":"User","site_admin":false},"body":"This is still very rough an missing a couple of things:\r\n\r\n- [x] UI changes to allow configuring both backends in parallel: https://github.com/crowbar/crowbar-openstack/pull/1705\r\n- [ ] validation of role assignment (node assigned to the correct role for the selected backend\r\n- [x] Likely needs some update HA\r\n- [ ] database_settings caching is disabled and needs to be fixed\r\n- [ ] related changes on Cloud 8 (maybe just a schema migration back to the \"database-server\" role)\r\n- [ ] ...\r\n\r\n~~Note: The UI is currently broken! Only the \"raw\" mode is displayed for the attributes.~~\r\n\r\nNote: The current implementation only adds the \"mysql-server\" role. postgresql based deployments continue to use the \"database-server\" role. This seems to have a couple of benefits:\r\n* Most of the existing postgresql based ci jobs (especially the \"batch\" jobs) can be used without changes\r\n* Fewer changes will be needed in \"master\". Basically we \"just\" need to rename \"mysql-server\" to database-server. (That would however mean the \"master\" will lose postgresql support)","created_at":"2018-06-22T15:52:07Z","updated_at":"2018-07-20T10:40:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e31174f99459cd340bd3f6028e38785f0a937389","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jhesketh","id":728450,"node_id":"MDQ6VXNlcjcyODQ1MA==","avatar_url":"https://avatars1.githubusercontent.com/u/728450?v=4","gravatar_id":"","url":"https://api.github.com/users/jhesketh","html_url":"https://github.com/jhesketh","followers_url":"https://api.github.com/users/jhesketh/followers","following_url":"https://api.github.com/users/jhesketh/following{/other_user}","gists_url":"https://api.github.com/users/jhesketh/gists{/gist_id}","starred_url":"https://api.github.com/users/jhesketh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhesketh/subscriptions","organizations_url":"https://api.github.com/users/jhesketh/orgs","repos_url":"https://api.github.com/users/jhesketh/repos","events_url":"https://api.github.com/users/jhesketh/events{/privacy}","received_events_url":"https://api.github.com/users/jhesketh/received_events","type":"User","site_admin":false},{"login":"s-t-e-v-e-n-k","id":15225059,"node_id":"MDQ6VXNlcjE1MjI1MDU5","avatar_url":"https://avatars0.githubusercontent.com/u/15225059?v=4","gravatar_id":"","url":"https://api.github.com/users/s-t-e-v-e-n-k","html_url":"https://github.com/s-t-e-v-e-n-k","followers_url":"https://api.github.com/users/s-t-e-v-e-n-k/followers","following_url":"https://api.github.com/users/s-t-e-v-e-n-k/following{/other_user}","gists_url":"https://api.github.com/users/s-t-e-v-e-n-k/gists{/gist_id}","starred_url":"https://api.github.com/users/s-t-e-v-e-n-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-t-e-v-e-n-k/subscriptions","organizations_url":"https://api.github.com/users/s-t-e-v-e-n-k/orgs","repos_url":"https://api.github.com/users/s-t-e-v-e-n-k/repos","events_url":"https://api.github.com/users/s-t-e-v-e-n-k/events{/privacy}","received_events_url":"https://api.github.com/users/s-t-e-v-e-n-k/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":264032978,"node_id":"MDU6TGFiZWwyNjQwMzI5Nzg=","url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels/do%20not%20merge%20yet","name":"do not merge yet","color":"eb6420","default":false},{"id":484279276,"node_id":"MDU6TGFiZWw0ODQyNzkyNzY=","url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels/upgrade","name":"upgrade","color":"d4c5f9","default":false},{"id":264031316,"node_id":"MDU6TGFiZWwyNjQwMzEzMTY=","url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels/wip","name":"wip","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1691/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1691/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1691/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/824658f002ea5311fb6db885f9406df43ad6d864","head":{"label":"rhafer:multi-db-roles","ref":"multi-db-roles","sha":"824658f002ea5311fb6db885f9406df43ad6d864","user":{"login":"rhafer","id":373399,"node_id":"MDQ6VXNlcjM3MzM5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/373399?v=4","gravatar_id":"","url":"https://api.github.com/users/rhafer","html_url":"https://github.com/rhafer","followers_url":"https://api.github.com/users/rhafer/followers","following_url":"https://api.github.com/users/rhafer/following{/other_user}","gists_url":"https://api.github.com/users/rhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhafer/subscriptions","organizations_url":"https://api.github.com/users/rhafer/orgs","repos_url":"https://api.github.com/users/rhafer/repos","events_url":"https://api.github.com/users/rhafer/events{/privacy}","received_events_url":"https://api.github.com/users/rhafer/received_events","type":"User","site_admin":false},"repo":{"id":41904088,"node_id":"MDEwOlJlcG9zaXRvcnk0MTkwNDA4OA==","name":"crowbar-openstack","full_name":"rhafer/crowbar-openstack","owner":{"login":"rhafer","id":373399,"node_id":"MDQ6VXNlcjM3MzM5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/373399?v=4","gravatar_id":"","url":"https://api.github.com/users/rhafer","html_url":"https://github.com/rhafer","followers_url":"https://api.github.com/users/rhafer/followers","following_url":"https://api.github.com/users/rhafer/following{/other_user}","gists_url":"https://api.github.com/users/rhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhafer/subscriptions","organizations_url":"https://api.github.com/users/rhafer/orgs","repos_url":"https://api.github.com/users/rhafer/repos","events_url":"https://api.github.com/users/rhafer/events{/privacy}","received_events_url":"https://api.github.com/users/rhafer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rhafer/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/rhafer/crowbar-openstack","forks_url":"https://api.github.com/repos/rhafer/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/rhafer/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhafer/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhafer/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/rhafer/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/rhafer/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/rhafer/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/rhafer/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/rhafer/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/rhafer/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/rhafer/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhafer/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhafer/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhafer/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhafer/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/rhafer/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/rhafer/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/rhafer/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/rhafer/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/rhafer/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/rhafer/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhafer/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhafer/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhafer/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhafer/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/rhafer/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhafer/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/rhafer/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhafer/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/rhafer/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/rhafer/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/rhafer/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/rhafer/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhafer/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/rhafer/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/rhafer/crowbar-openstack/deployments","created_at":"2015-09-04T07:52:08Z","updated_at":"2015-09-04T07:52:09Z","pushed_at":"2018-07-18T12:47:55Z","git_url":"git://github.com/rhafer/crowbar-openstack.git","ssh_url":"git@github.com:rhafer/crowbar-openstack.git","clone_url":"https://github.com/rhafer/crowbar-openstack.git","svn_url":"https://github.com/rhafer/crowbar-openstack","homepage":null,"size":20919,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:stable/4.0","ref":"stable/4.0","sha":"e0cdb50a8574fcd7e91787e77cc51a310dc785f5","user":{"login":"crowbar","id":2910205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTAyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39006903,"node_id":"MDEwOlJlcG9zaXRvcnkzOTAwNjkwMw==","name":"crowbar-openstack","full_name":"crowbar/crowbar-openstack","owner":{"login":"crowbar","id":2910205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTAyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-openstack","forks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/deployments","created_at":"2015-07-13T10:55:33Z","updated_at":"2018-07-19T18:38:02Z","pushed_at":"2018-07-19T18:37:49Z","git_url":"git://github.com/crowbar/crowbar-openstack.git","ssh_url":"git@github.com:crowbar/crowbar-openstack.git","clone_url":"https://github.com/crowbar/crowbar-openstack.git","svn_url":"https://github.com/crowbar/crowbar-openstack","homepage":null,"size":21106,"stargazers_count":16,"watchers_count":16,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":85,"mirror_url":null,"archived":false,"open_issues_count":74,"license":null,"forks":85,"open_issues":74,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1691"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/1691"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1691"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1691/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1691/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1691/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/824658f002ea5311fb6db885f9406df43ad6d864"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"skazi0"}}