{"action":"created","comment":{"url":"https://api.github.com/repos/mapseed/platform/pulls/comments/226733618","pull_request_review_id":166634444,"id":226733618,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjczMzYxOA==","diff_hunk":"@@ -43,40 +43,21 @@ EditorButton.propTypes = {\n   type: PropTypes.string.isRequired,\n };\n \n-// TODO: Phase this out as we move to CSS-in-JS:\n-const LegacyButton = ({ children, ...props }) => {\n+// Influenced by the material-ui api:\n+// https://material-ui.com/api/button/\n+// NOTE: we may want to consider using material-ui instead","path":"src/base/static/components/atoms/buttons.js","position":8,"original_position":8,"commit_id":"24e2cfe6ca7811a83595e9ae02daf4988f650f20","original_commit_id":"24e2cfe6ca7811a83595e9ae02daf4988f650f20","user":{"login":"jalMogo","id":42042460,"node_id":"MDQ6VXNlcjQyMDQyNDYw","avatar_url":"https://avatars1.githubusercontent.com/u/42042460?v=4","gravatar_id":"","url":"https://api.github.com/users/jalMogo","html_url":"https://github.com/jalMogo","followers_url":"https://api.github.com/users/jalMogo/followers","following_url":"https://api.github.com/users/jalMogo/following{/other_user}","gists_url":"https://api.github.com/users/jalMogo/gists{/gist_id}","starred_url":"https://api.github.com/users/jalMogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalMogo/subscriptions","organizations_url":"https://api.github.com/users/jalMogo/orgs","repos_url":"https://api.github.com/users/jalMogo/repos","events_url":"https://api.github.com/users/jalMogo/events{/privacy}","received_events_url":"https://api.github.com/users/jalMogo/received_events","type":"User","site_admin":false},"body":"They have a reasonable API, so I decided to base our API off of theirs, for now.\r\n\r\nIf we started using their components, it would force us into their look and feel. But it would save us the extra work of building out our own atoms here.","created_at":"2018-10-19T18:00:56Z","updated_at":"2018-10-19T18:00:56Z","html_url":"https://github.com/mapseed/platform/pull/1050#discussion_r226733618","pull_request_url":"https://api.github.com/repos/mapseed/platform/pulls/1050","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mapseed/platform/pulls/comments/226733618"},"html":{"href":"https://github.com/mapseed/platform/pull/1050#discussion_r226733618"},"pull_request":{"href":"https://api.github.com/repos/mapseed/platform/pulls/1050"}},"in_reply_to_id":226728007},"pull_request":{"url":"https://api.github.com/repos/mapseed/platform/pulls/1050","id":223429785,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNDI5Nzg1","html_url":"https://github.com/mapseed/platform/pull/1050","diff_url":"https://github.com/mapseed/platform/pull/1050.diff","patch_url":"https://github.com/mapseed/platform/pull/1050.patch","issue_url":"https://api.github.com/repos/mapseed/platform/issues/1050","number":1050,"state":"open","locked":false,"title":"updates to CSS-in-JS Button component, and right sidebar","user":{"login":"jalMogo","id":42042460,"node_id":"MDQ6VXNlcjQyMDQyNDYw","avatar_url":"https://avatars1.githubusercontent.com/u/42042460?v=4","gravatar_id":"","url":"https://api.github.com/users/jalMogo","html_url":"https://github.com/jalMogo","followers_url":"https://api.github.com/users/jalMogo/followers","following_url":"https://api.github.com/users/jalMogo/following{/other_user}","gists_url":"https://api.github.com/users/jalMogo/gists{/gist_id}","starred_url":"https://api.github.com/users/jalMogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalMogo/subscriptions","organizations_url":"https://api.github.com/users/jalMogo/orgs","repos_url":"https://api.github.com/users/jalMogo/repos","events_url":"https://api.github.com/users/jalMogo/events{/privacy}","received_events_url":"https://api.github.com/users/jalMogo/received_events","type":"User","site_admin":false},"body":"Refactors our Button component so that it is no longer dependent on LegacyButton, and it is using CSS-in-JS.\r\n\r\nThis PR also includes a minor refactor to AppView and RightSidebar, so that we are not relying on Backbone events.","created_at":"2018-10-16T23:50:29Z","updated_at":"2018-10-19T18:00:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cafac06515e5b7da9dabe1e8bcd8d936180c0dd2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapseed/platform/pulls/1050/commits","review_comments_url":"https://api.github.com/repos/mapseed/platform/pulls/1050/comments","review_comment_url":"https://api.github.com/repos/mapseed/platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapseed/platform/issues/1050/comments","statuses_url":"https://api.github.com/repos/mapseed/platform/statuses/24e2cfe6ca7811a83595e9ae02daf4988f650f20","head":{"label":"mapseed:jalmogo/refactor-button","ref":"jalmogo/refactor-button","sha":"24e2cfe6ca7811a83595e9ae02daf4988f650f20","user":{"login":"mapseed","id":7245803,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyNDU4MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/7245803?v=4","gravatar_id":"","url":"https://api.github.com/users/mapseed","html_url":"https://github.com/mapseed","followers_url":"https://api.github.com/users/mapseed/followers","following_url":"https://api.github.com/users/mapseed/following{/other_user}","gists_url":"https://api.github.com/users/mapseed/gists{/gist_id}","starred_url":"https://api.github.com/users/mapseed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapseed/subscriptions","organizations_url":"https://api.github.com/users/mapseed/orgs","repos_url":"https://api.github.com/users/mapseed/repos","events_url":"https://api.github.com/users/mapseed/events{/privacy}","received_events_url":"https://api.github.com/users/mapseed/received_events","type":"Organization","site_admin":false},"repo":{"id":28108305,"node_id":"MDEwOlJlcG9zaXRvcnkyODEwODMwNQ==","name":"platform","full_name":"mapseed/platform","private":false,"owner":{"login":"mapseed","id":7245803,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyNDU4MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/7245803?v=4","gravatar_id":"","url":"https://api.github.com/users/mapseed","html_url":"https://github.com/mapseed","followers_url":"https://api.github.com/users/mapseed/followers","following_url":"https://api.github.com/users/mapseed/following{/other_user}","gists_url":"https://api.github.com/users/mapseed/gists{/gist_id}","starred_url":"https://api.github.com/users/mapseed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapseed/subscriptions","organizations_url":"https://api.github.com/users/mapseed/orgs","repos_url":"https://api.github.com/users/mapseed/repos","events_url":"https://api.github.com/users/mapseed/events{/privacy}","received_events_url":"https://api.github.com/users/mapseed/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mapseed/platform","description":"Mapseed is a simple, beautiful way to collect information and tell geographic stories.","fork":false,"url":"https://api.github.com/repos/mapseed/platform","forks_url":"https://api.github.com/repos/mapseed/platform/forks","keys_url":"https://api.github.com/repos/mapseed/platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapseed/platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapseed/platform/teams","hooks_url":"https://api.github.com/repos/mapseed/platform/hooks","issue_events_url":"https://api.github.com/repos/mapseed/platform/issues/events{/number}","events_url":"https://api.github.com/repos/mapseed/platform/events","assignees_url":"https://api.github.com/repos/mapseed/platform/assignees{/user}","branches_url":"https://api.github.com/repos/mapseed/platform/branches{/branch}","tags_url":"https://api.github.com/repos/mapseed/platform/tags","blobs_url":"https://api.github.com/repos/mapseed/platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapseed/platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapseed/platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapseed/platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapseed/platform/statuses/{sha}","languages_url":"https://api.github.com/repos/mapseed/platform/languages","stargazers_url":"https://api.github.com/repos/mapseed/platform/stargazers","contributors_url":"https://api.github.com/repos/mapseed/platform/contributors","subscribers_url":"https://api.github.com/repos/mapseed/platform/subscribers","subscription_url":"https://api.github.com/repos/mapseed/platform/subscription","commits_url":"https://api.github.com/repos/mapseed/platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapseed/platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapseed/platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapseed/platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapseed/platform/contents/{+path}","compare_url":"https://api.github.com/repos/mapseed/platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapseed/platform/merges","archive_url":"https://api.github.com/repos/mapseed/platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapseed/platform/downloads","issues_url":"https://api.github.com/repos/mapseed/platform/issues{/number}","pulls_url":"https://api.github.com/repos/mapseed/platform/pulls{/number}","milestones_url":"https://api.github.com/repos/mapseed/platform/milestones{/number}","notifications_url":"https://api.github.com/repos/mapseed/platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapseed/platform/labels{/name}","releases_url":"https://api.github.com/repos/mapseed/platform/releases{/id}","deployments_url":"https://api.github.com/repos/mapseed/platform/deployments","created_at":"2014-12-16T21:51:30Z","updated_at":"2018-10-19T00:19:35Z","pushed_at":"2018-10-19T00:19:32Z","git_url":"git://github.com/mapseed/platform.git","ssh_url":"git@github.com:mapseed/platform.git","clone_url":"https://github.com/mapseed/platform.git","svn_url":"https://github.com/mapseed/platform","homepage":"http://mapseed.org","size":60251,"stargazers_count":54,"watchers_count":54,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":89,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":26,"open_issues":89,"watchers":54,"default_branch":"master"}},"base":{"label":"mapseed:master","ref":"master","sha":"f6f824c0406cde1b069bd425a543b136ebd12d4b","user":{"login":"mapseed","id":7245803,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyNDU4MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/7245803?v=4","gravatar_id":"","url":"https://api.github.com/users/mapseed","html_url":"https://github.com/mapseed","followers_url":"https://api.github.com/users/mapseed/followers","following_url":"https://api.github.com/users/mapseed/following{/other_user}","gists_url":"https://api.github.com/users/mapseed/gists{/gist_id}","starred_url":"https://api.github.com/users/mapseed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapseed/subscriptions","organizations_url":"https://api.github.com/users/mapseed/orgs","repos_url":"https://api.github.com/users/mapseed/repos","events_url":"https://api.github.com/users/mapseed/events{/privacy}","received_events_url":"https://api.github.com/users/mapseed/received_events","type":"Organization","site_admin":false},"repo":{"id":28108305,"node_id":"MDEwOlJlcG9zaXRvcnkyODEwODMwNQ==","name":"platform","full_name":"mapseed/platform","private":false,"owner":{"login":"mapseed","id":7245803,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyNDU4MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/7245803?v=4","gravatar_id":"","url":"https://api.github.com/users/mapseed","html_url":"https://github.com/mapseed","followers_url":"https://api.github.com/users/mapseed/followers","following_url":"https://api.github.com/users/mapseed/following{/other_user}","gists_url":"https://api.github.com/users/mapseed/gists{/gist_id}","starred_url":"https://api.github.com/users/mapseed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapseed/subscriptions","organizations_url":"https://api.github.com/users/mapseed/orgs","repos_url":"https://api.github.com/users/mapseed/repos","events_url":"https://api.github.com/users/mapseed/events{/privacy}","received_events_url":"https://api.github.com/users/mapseed/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mapseed/platform","description":"Mapseed is a simple, beautiful way to collect information and tell geographic stories.","fork":false,"url":"https://api.github.com/repos/mapseed/platform","forks_url":"https://api.github.com/repos/mapseed/platform/forks","keys_url":"https://api.github.com/repos/mapseed/platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapseed/platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapseed/platform/teams","hooks_url":"https://api.github.com/repos/mapseed/platform/hooks","issue_events_url":"https://api.github.com/repos/mapseed/platform/issues/events{/number}","events_url":"https://api.github.com/repos/mapseed/platform/events","assignees_url":"https://api.github.com/repos/mapseed/platform/assignees{/user}","branches_url":"https://api.github.com/repos/mapseed/platform/branches{/branch}","tags_url":"https://api.github.com/repos/mapseed/platform/tags","blobs_url":"https://api.github.com/repos/mapseed/platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapseed/platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapseed/platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapseed/platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapseed/platform/statuses/{sha}","languages_url":"https://api.github.com/repos/mapseed/platform/languages","stargazers_url":"https://api.github.com/repos/mapseed/platform/stargazers","contributors_url":"https://api.github.com/repos/mapseed/platform/contributors","subscribers_url":"https://api.github.com/repos/mapseed/platform/subscribers","subscription_url":"https://api.github.com/repos/mapseed/platform/subscription","commits_url":"https://api.github.com/repos/mapseed/platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapseed/platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapseed/platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapseed/platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapseed/platform/contents/{+path}","compare_url":"https://api.github.com/repos/mapseed/platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapseed/platform/merges","archive_url":"https://api.github.com/repos/mapseed/platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapseed/platform/downloads","issues_url":"https://api.github.com/repos/mapseed/platform/issues{/number}","pulls_url":"https://api.github.com/repos/mapseed/platform/pulls{/number}","milestones_url":"https://api.github.com/repos/mapseed/platform/milestones{/number}","notifications_url":"https://api.github.com/repos/mapseed/platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapseed/platform/labels{/name}","releases_url":"https://api.github.com/repos/mapseed/platform/releases{/id}","deployments_url":"https://api.github.com/repos/mapseed/platform/deployments","created_at":"2014-12-16T21:51:30Z","updated_at":"2018-10-19T00:19:35Z","pushed_at":"2018-10-19T00:19:32Z","git_url":"git://github.com/mapseed/platform.git","ssh_url":"git@github.com:mapseed/platform.git","clone_url":"https://github.com/mapseed/platform.git","svn_url":"https://github.com/mapseed/platform","homepage":"http://mapseed.org","size":60251,"stargazers_count":54,"watchers_count":54,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":89,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":26,"open_issues":89,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapseed/platform/pulls/1050"},"html":{"href":"https://github.com/mapseed/platform/pull/1050"},"issue":{"href":"https://api.github.com/repos/mapseed/platform/issues/1050"},"comments":{"href":"https://api.github.com/repos/mapseed/platform/issues/1050/comments"},"review_comments":{"href":"https://api.github.com/repos/mapseed/platform/pulls/1050/comments"},"review_comment":{"href":"https://api.github.com/repos/mapseed/platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapseed/platform/pulls/1050/commits"},"statuses":{"href":"https://api.github.com/repos/mapseed/platform/statuses/24e2cfe6ca7811a83595e9ae02daf4988f650f20"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jalMogo"}}