{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/211082842","pull_request_review_id":147437988,"id":211082842,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTA4Mjg0Mg==","diff_hunk":"@@ -56,7 +56,7 @@ class ReplicaFetcherThread(name: String,\n                                 isInterruptible = false,\n                                 includeLogTruncation = true) {\n \n-  type REQ = FetchRequest\n+  type REQ = kafka.server.ReplicaFetcherThread.FetchRequest","path":"core/src/main/scala/kafka/server/ReplicaFetcherThread.scala","position":5,"original_position":5,"commit_id":"b4a3a207c441a1f7fab9f6d7ed233aedae2a0052","original_commit_id":"b4a3a207c441a1f7fab9f6d7ed233aedae2a0052","user":{"login":"ConcurrencyPractitioner","id":25971966,"node_id":"MDQ6VXNlcjI1OTcxOTY2","avatar_url":"https://avatars2.githubusercontent.com/u/25971966?v=4","gravatar_id":"","url":"https://api.github.com/users/ConcurrencyPractitioner","html_url":"https://github.com/ConcurrencyPractitioner","followers_url":"https://api.github.com/users/ConcurrencyPractitioner/followers","following_url":"https://api.github.com/users/ConcurrencyPractitioner/following{/other_user}","gists_url":"https://api.github.com/users/ConcurrencyPractitioner/gists{/gist_id}","starred_url":"https://api.github.com/users/ConcurrencyPractitioner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConcurrencyPractitioner/subscriptions","organizations_url":"https://api.github.com/users/ConcurrencyPractitioner/orgs","repos_url":"https://api.github.com/users/ConcurrencyPractitioner/repos","events_url":"https://api.github.com/users/ConcurrencyPractitioner/events{/privacy}","received_events_url":"https://api.github.com/users/ConcurrencyPractitioner/received_events","type":"User","site_admin":false},"body":"There was some ambiguity errors in checkstyle which I could not fix without doing this when I am running tests in local. I could revert it later, just before merging.","created_at":"2018-08-18T18:28:36Z","updated_at":"2018-08-18T18:28:36Z","html_url":"https://github.com/apache/kafka/pull/5012#discussion_r211082842","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/5012","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/211082842"},"html":{"href":"https://github.com/apache/kafka/pull/5012#discussion_r211082842"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/5012"}},"in_reply_to_id":211025889},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/5012","id":187634500,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3NjM0NTAw","html_url":"https://github.com/apache/kafka/pull/5012","diff_url":"https://github.com/apache/kafka/pull/5012.diff","patch_url":"https://github.com/apache/kafka/pull/5012.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/5012","number":5012,"state":"open","locked":false,"title":"KAFKA-4696: Streams standby task assignment should be state-store aware","user":{"login":"ConcurrencyPractitioner","id":25971966,"node_id":"MDQ6VXNlcjI1OTcxOTY2","avatar_url":"https://avatars2.githubusercontent.com/u/25971966?v=4","gravatar_id":"","url":"https://api.github.com/users/ConcurrencyPractitioner","html_url":"https://github.com/ConcurrencyPractitioner","followers_url":"https://api.github.com/users/ConcurrencyPractitioner/followers","following_url":"https://api.github.com/users/ConcurrencyPractitioner/following{/other_user}","gists_url":"https://api.github.com/users/ConcurrencyPractitioner/gists{/gist_id}","starred_url":"https://api.github.com/users/ConcurrencyPractitioner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConcurrencyPractitioner/subscriptions","organizations_url":"https://api.github.com/users/ConcurrencyPractitioner/orgs","repos_url":"https://api.github.com/users/ConcurrencyPractitioner/repos","events_url":"https://api.github.com/users/ConcurrencyPractitioner/events{/privacy}","received_events_url":"https://api.github.com/users/ConcurrencyPractitioner/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-12T18:40:11Z","updated_at":"2018-08-18T18:28:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95415425c50eddcac7137768394ab681167c0e80","assignee":null,"assignees":[],"requested_reviewers":[{"login":"guozhangwang","id":10729597,"node_id":"MDQ6VXNlcjEwNzI5NTk3","avatar_url":"https://avatars0.githubusercontent.com/u/10729597?v=4","gravatar_id":"","url":"https://api.github.com/users/guozhangwang","html_url":"https://github.com/guozhangwang","followers_url":"https://api.github.com/users/guozhangwang/followers","following_url":"https://api.github.com/users/guozhangwang/following{/other_user}","gists_url":"https://api.github.com/users/guozhangwang/gists{/gist_id}","starred_url":"https://api.github.com/users/guozhangwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guozhangwang/subscriptions","organizations_url":"https://api.github.com/users/guozhangwang/orgs","repos_url":"https://api.github.com/users/guozhangwang/repos","events_url":"https://api.github.com/users/guozhangwang/events{/privacy}","received_events_url":"https://api.github.com/users/guozhangwang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":820747028,"node_id":"MDU6TGFiZWw4MjA3NDcwMjg=","url":"https://api.github.com/repos/apache/kafka/labels/streams","name":"streams","color":"63edea","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/5012/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/5012/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/5012/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/b4a3a207c441a1f7fab9f6d7ed233aedae2a0052","head":{"label":"ConcurrencyPractitioner:KAFKA-4696","ref":"KAFKA-4696","sha":"b4a3a207c441a1f7fab9f6d7ed233aedae2a0052","user":{"login":"ConcurrencyPractitioner","id":25971966,"node_id":"MDQ6VXNlcjI1OTcxOTY2","avatar_url":"https://avatars2.githubusercontent.com/u/25971966?v=4","gravatar_id":"","url":"https://api.github.com/users/ConcurrencyPractitioner","html_url":"https://github.com/ConcurrencyPractitioner","followers_url":"https://api.github.com/users/ConcurrencyPractitioner/followers","following_url":"https://api.github.com/users/ConcurrencyPractitioner/following{/other_user}","gists_url":"https://api.github.com/users/ConcurrencyPractitioner/gists{/gist_id}","starred_url":"https://api.github.com/users/ConcurrencyPractitioner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConcurrencyPractitioner/subscriptions","organizations_url":"https://api.github.com/users/ConcurrencyPractitioner/orgs","repos_url":"https://api.github.com/users/ConcurrencyPractitioner/repos","events_url":"https://api.github.com/users/ConcurrencyPractitioner/events{/privacy}","received_events_url":"https://api.github.com/users/ConcurrencyPractitioner/received_events","type":"User","site_admin":false},"repo":{"id":133173269,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMxNzMyNjk=","name":"kafka","full_name":"ConcurrencyPractitioner/kafka","owner":{"login":"ConcurrencyPractitioner","id":25971966,"node_id":"MDQ6VXNlcjI1OTcxOTY2","avatar_url":"https://avatars2.githubusercontent.com/u/25971966?v=4","gravatar_id":"","url":"https://api.github.com/users/ConcurrencyPractitioner","html_url":"https://github.com/ConcurrencyPractitioner","followers_url":"https://api.github.com/users/ConcurrencyPractitioner/followers","following_url":"https://api.github.com/users/ConcurrencyPractitioner/following{/other_user}","gists_url":"https://api.github.com/users/ConcurrencyPractitioner/gists{/gist_id}","starred_url":"https://api.github.com/users/ConcurrencyPractitioner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConcurrencyPractitioner/subscriptions","organizations_url":"https://api.github.com/users/ConcurrencyPractitioner/orgs","repos_url":"https://api.github.com/users/ConcurrencyPractitioner/repos","events_url":"https://api.github.com/users/ConcurrencyPractitioner/events{/privacy}","received_events_url":"https://api.github.com/users/ConcurrencyPractitioner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ConcurrencyPractitioner/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka","forks_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/forks","keys_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/teams","hooks_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/hooks","issue_events_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/events","assignees_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/tags","blobs_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/languages","stargazers_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/stargazers","contributors_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/contributors","subscribers_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/subscribers","subscription_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/subscription","commits_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/merges","archive_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/downloads","issues_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/labels{/name}","releases_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/ConcurrencyPractitioner/kafka/deployments","created_at":"2018-05-12T18:30:03Z","updated_at":"2018-07-04T06:10:21Z","pushed_at":"2018-08-15T03:24:16Z","git_url":"git://github.com/ConcurrencyPractitioner/kafka.git","ssh_url":"git@github.com:ConcurrencyPractitioner/kafka.git","clone_url":"https://github.com/ConcurrencyPractitioner/kafka.git","svn_url":"https://github.com/ConcurrencyPractitioner/kafka","homepage":null,"size":71596,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"3e64e5b9c03f13f58e6a049ff1fed039c6a15d69","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"node_id":"MDEwOlJlcG9zaXRvcnkyMjExMjQz","name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2018-08-18T17:19:09Z","pushed_at":"2018-08-18T16:26:21Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":72105,"stargazers_count":9339,"watchers_count":9339,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5315,"mirror_url":null,"archived":false,"open_issues_count":488,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5315,"open_issues":488,"watchers":9339,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/5012"},"html":{"href":"https://github.com/apache/kafka/pull/5012"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/5012"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/5012/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/5012/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/5012/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/b4a3a207c441a1f7fab9f6d7ed233aedae2a0052"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ConcurrencyPractitioner"}}