{"action":"created","comment":{"url":"https://api.github.com/repos/scalecube/scalecube-parent/pulls/comments/208897892","pull_request_review_id":144800950,"id":208897892,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODg5Nzg5Mg==","diff_hunk":"@@ -0,0 +1,35 @@\n+# Setting up development environment\n+\n+## Install the necessary build tools\n+You require to have latest stable [Open JDK 8](http://openjdk.java.net/projects/jdk8u/), latest stable \n+[Apache Maven](http://maven.apache.org/) and [Git](http://git-scm.com/) installed on your machine.\n+\n+## Set up IntelliJ IDEA\n+ScaleCube project team uses [IntelliJ IDEA](http://www.jetbrains.com/idea/) as the primary IDE, although we are fine \n+with using other development environments as long as you adhere to our coding style.\n+\n+### Code style\n+ScaleCube project team uses [Google code style](http://google.github.io/styleguide/javaguide.html)\n+\n+#### Note, in the past, we used an altered version of google code style. We now comply the google style guidelines fully\n+\n+The best way to go is to format your code *before pushing*\n+\n+You can use [google-java-format](https://github.com/google/google-java-format).\n+There are plugins for [IntelliJ](https://github.com/google/google-java-format#intellij) and [Eclipse](https://github.com/google/google-java-format#eclipse) \n+\n+\n+## IntelliJ Users (that doesn't want to install the plugin for some reason) should:\n+0. Download [this code style configuration](https://github.com/google/styleguide/blob/gh-pages/intellij-java-google-style.xml)\n+Apply the configuration:\n+\n+## Eclipse Users (that doesn't want to install the plugin for some reason) should:","path":"DEVELOPMENT.md","position":26,"original_position":26,"commit_id":"8f7693eac80444b67a5ec403dd08abc35df7423b","original_commit_id":"8f7693eac80444b67a5ec403dd08abc35df7423b","user":{"login":"aharonha","id":3862558,"node_id":"MDQ6VXNlcjM4NjI1NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/3862558?v=4","gravatar_id":"","url":"https://api.github.com/users/aharonha","html_url":"https://github.com/aharonha","followers_url":"https://api.github.com/users/aharonha/followers","following_url":"https://api.github.com/users/aharonha/following{/other_user}","gists_url":"https://api.github.com/users/aharonha/gists{/gist_id}","starred_url":"https://api.github.com/users/aharonha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aharonha/subscriptions","organizations_url":"https://api.github.com/users/aharonha/orgs","repos_url":"https://api.github.com/users/aharonha/repos","events_url":"https://api.github.com/users/aharonha/events{/privacy}","received_events_url":"https://api.github.com/users/aharonha/received_events","type":"User","site_admin":false},"body":"As https://google.github.io/styleguide/javaguide.html#s3.3.3-import-ordering-and-spacing suggests, I believe a file like this: \r\n```\r\n0=\\#\r\n```\r\nis good enough","created_at":"2018-08-09T11:41:55Z","updated_at":"2018-08-09T11:41:55Z","html_url":"https://github.com/scalecube/scalecube-parent/pull/21#discussion_r208897892","pull_request_url":"https://api.github.com/repos/scalecube/scalecube-parent/pulls/21","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/scalecube/scalecube-parent/pulls/comments/208897892"},"html":{"href":"https://github.com/scalecube/scalecube-parent/pull/21#discussion_r208897892"},"pull_request":{"href":"https://api.github.com/repos/scalecube/scalecube-parent/pulls/21"}},"in_reply_to_id":208889307},"pull_request":{"url":"https://api.github.com/repos/scalecube/scalecube-parent/pulls/21","id":207260212,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MjYwMjEy","html_url":"https://github.com/scalecube/scalecube-parent/pull/21","diff_url":"https://github.com/scalecube/scalecube-parent/pull/21.diff","patch_url":"https://github.com/scalecube/scalecube-parent/pull/21.patch","issue_url":"https://api.github.com/repos/scalecube/scalecube-parent/issues/21","number":21,"state":"open","locked":false,"title":"updated guidelines","user":{"login":"aharonha","id":3862558,"node_id":"MDQ6VXNlcjM4NjI1NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/3862558?v=4","gravatar_id":"","url":"https://api.github.com/users/aharonha","html_url":"https://github.com/aharonha","followers_url":"https://api.github.com/users/aharonha/followers","following_url":"https://api.github.com/users/aharonha/following{/other_user}","gists_url":"https://api.github.com/users/aharonha/gists{/gist_id}","starred_url":"https://api.github.com/users/aharonha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aharonha/subscriptions","organizations_url":"https://api.github.com/users/aharonha/orgs","repos_url":"https://api.github.com/users/aharonha/repos","events_url":"https://api.github.com/users/aharonha/events{/privacy}","received_events_url":"https://api.github.com/users/aharonha/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-09T09:51:28Z","updated_at":"2018-08-09T11:41:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"535a224cd4595c6edfdcb994127a672b25edbd7d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"snripa","id":1143058,"node_id":"MDQ6VXNlcjExNDMwNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1143058?v=4","gravatar_id":"","url":"https://api.github.com/users/snripa","html_url":"https://github.com/snripa","followers_url":"https://api.github.com/users/snripa/followers","following_url":"https://api.github.com/users/snripa/following{/other_user}","gists_url":"https://api.github.com/users/snripa/gists{/gist_id}","starred_url":"https://api.github.com/users/snripa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snripa/subscriptions","organizations_url":"https://api.github.com/users/snripa/orgs","repos_url":"https://api.github.com/users/snripa/repos","events_url":"https://api.github.com/users/snripa/events{/privacy}","received_events_url":"https://api.github.com/users/snripa/received_events","type":"User","site_admin":false},{"login":"dmytro-lazebnyi","id":19783223,"node_id":"MDQ6VXNlcjE5NzgzMjIz","avatar_url":"https://avatars2.githubusercontent.com/u/19783223?v=4","gravatar_id":"","url":"https://api.github.com/users/dmytro-lazebnyi","html_url":"https://github.com/dmytro-lazebnyi","followers_url":"https://api.github.com/users/dmytro-lazebnyi/followers","following_url":"https://api.github.com/users/dmytro-lazebnyi/following{/other_user}","gists_url":"https://api.github.com/users/dmytro-lazebnyi/gists{/gist_id}","starred_url":"https://api.github.com/users/dmytro-lazebnyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmytro-lazebnyi/subscriptions","organizations_url":"https://api.github.com/users/dmytro-lazebnyi/orgs","repos_url":"https://api.github.com/users/dmytro-lazebnyi/repos","events_url":"https://api.github.com/users/dmytro-lazebnyi/events{/privacy}","received_events_url":"https://api.github.com/users/dmytro-lazebnyi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scalecube/scalecube-parent/pulls/21/commits","review_comments_url":"https://api.github.com/repos/scalecube/scalecube-parent/pulls/21/comments","review_comment_url":"https://api.github.com/repos/scalecube/scalecube-parent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalecube/scalecube-parent/issues/21/comments","statuses_url":"https://api.github.com/repos/scalecube/scalecube-parent/statuses/8f7693eac80444b67a5ec403dd08abc35df7423b","head":{"label":"scalecube:development-md","ref":"development-md","sha":"8f7693eac80444b67a5ec403dd08abc35df7423b","user":{"login":"scalecube","id":12896170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODk2MTcw","avatar_url":"https://avatars2.githubusercontent.com/u/12896170?v=4","gravatar_id":"","url":"https://api.github.com/users/scalecube","html_url":"https://github.com/scalecube","followers_url":"https://api.github.com/users/scalecube/followers","following_url":"https://api.github.com/users/scalecube/following{/other_user}","gists_url":"https://api.github.com/users/scalecube/gists{/gist_id}","starred_url":"https://api.github.com/users/scalecube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalecube/subscriptions","organizations_url":"https://api.github.com/users/scalecube/orgs","repos_url":"https://api.github.com/users/scalecube/repos","events_url":"https://api.github.com/users/scalecube/events{/privacy}","received_events_url":"https://api.github.com/users/scalecube/received_events","type":"Organization","site_admin":false},"repo":{"id":142113412,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIxMTM0MTI=","name":"scalecube-parent","full_name":"scalecube/scalecube-parent","owner":{"login":"scalecube","id":12896170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODk2MTcw","avatar_url":"https://avatars2.githubusercontent.com/u/12896170?v=4","gravatar_id":"","url":"https://api.github.com/users/scalecube","html_url":"https://github.com/scalecube","followers_url":"https://api.github.com/users/scalecube/followers","following_url":"https://api.github.com/users/scalecube/following{/other_user}","gists_url":"https://api.github.com/users/scalecube/gists{/gist_id}","starred_url":"https://api.github.com/users/scalecube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalecube/subscriptions","organizations_url":"https://api.github.com/users/scalecube/orgs","repos_url":"https://api.github.com/users/scalecube/repos","events_url":"https://api.github.com/users/scalecube/events{/privacy}","received_events_url":"https://api.github.com/users/scalecube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalecube/scalecube-parent","description":"a parent project for all Scalecube projects","fork":false,"url":"https://api.github.com/repos/scalecube/scalecube-parent","forks_url":"https://api.github.com/repos/scalecube/scalecube-parent/forks","keys_url":"https://api.github.com/repos/scalecube/scalecube-parent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalecube/scalecube-parent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalecube/scalecube-parent/teams","hooks_url":"https://api.github.com/repos/scalecube/scalecube-parent/hooks","issue_events_url":"https://api.github.com/repos/scalecube/scalecube-parent/issues/events{/number}","events_url":"https://api.github.com/repos/scalecube/scalecube-parent/events","assignees_url":"https://api.github.com/repos/scalecube/scalecube-parent/assignees{/user}","branches_url":"https://api.github.com/repos/scalecube/scalecube-parent/branches{/branch}","tags_url":"https://api.github.com/repos/scalecube/scalecube-parent/tags","blobs_url":"https://api.github.com/repos/scalecube/scalecube-parent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalecube/scalecube-parent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalecube/scalecube-parent/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalecube/scalecube-parent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalecube/scalecube-parent/statuses/{sha}","languages_url":"https://api.github.com/repos/scalecube/scalecube-parent/languages","stargazers_url":"https://api.github.com/repos/scalecube/scalecube-parent/stargazers","contributors_url":"https://api.github.com/repos/scalecube/scalecube-parent/contributors","subscribers_url":"https://api.github.com/repos/scalecube/scalecube-parent/subscribers","subscription_url":"https://api.github.com/repos/scalecube/scalecube-parent/subscription","commits_url":"https://api.github.com/repos/scalecube/scalecube-parent/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalecube/scalecube-parent/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalecube/scalecube-parent/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalecube/scalecube-parent/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalecube/scalecube-parent/contents/{+path}","compare_url":"https://api.github.com/repos/scalecube/scalecube-parent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalecube/scalecube-parent/merges","archive_url":"https://api.github.com/repos/scalecube/scalecube-parent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalecube/scalecube-parent/downloads","issues_url":"https://api.github.com/repos/scalecube/scalecube-parent/issues{/number}","pulls_url":"https://api.github.com/repos/scalecube/scalecube-parent/pulls{/number}","milestones_url":"https://api.github.com/repos/scalecube/scalecube-parent/milestones{/number}","notifications_url":"https://api.github.com/repos/scalecube/scalecube-parent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalecube/scalecube-parent/labels{/name}","releases_url":"https://api.github.com/repos/scalecube/scalecube-parent/releases{/id}","deployments_url":"https://api.github.com/repos/scalecube/scalecube-parent/deployments","created_at":"2018-07-24T06:16:50Z","updated_at":"2018-08-09T08:09:45Z","pushed_at":"2018-08-09T09:57:40Z","git_url":"git://github.com/scalecube/scalecube-parent.git","ssh_url":"git@github.com:scalecube/scalecube-parent.git","clone_url":"https://github.com/scalecube/scalecube-parent.git","svn_url":"https://github.com/scalecube/scalecube-parent","homepage":null,"size":97,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"develop"}},"base":{"label":"scalecube:develop","ref":"develop","sha":"8bcf328ef1260031edba30a2bf7c8e10cb1b663c","user":{"login":"scalecube","id":12896170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODk2MTcw","avatar_url":"https://avatars2.githubusercontent.com/u/12896170?v=4","gravatar_id":"","url":"https://api.github.com/users/scalecube","html_url":"https://github.com/scalecube","followers_url":"https://api.github.com/users/scalecube/followers","following_url":"https://api.github.com/users/scalecube/following{/other_user}","gists_url":"https://api.github.com/users/scalecube/gists{/gist_id}","starred_url":"https://api.github.com/users/scalecube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalecube/subscriptions","organizations_url":"https://api.github.com/users/scalecube/orgs","repos_url":"https://api.github.com/users/scalecube/repos","events_url":"https://api.github.com/users/scalecube/events{/privacy}","received_events_url":"https://api.github.com/users/scalecube/received_events","type":"Organization","site_admin":false},"repo":{"id":142113412,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIxMTM0MTI=","name":"scalecube-parent","full_name":"scalecube/scalecube-parent","owner":{"login":"scalecube","id":12896170,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODk2MTcw","avatar_url":"https://avatars2.githubusercontent.com/u/12896170?v=4","gravatar_id":"","url":"https://api.github.com/users/scalecube","html_url":"https://github.com/scalecube","followers_url":"https://api.github.com/users/scalecube/followers","following_url":"https://api.github.com/users/scalecube/following{/other_user}","gists_url":"https://api.github.com/users/scalecube/gists{/gist_id}","starred_url":"https://api.github.com/users/scalecube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalecube/subscriptions","organizations_url":"https://api.github.com/users/scalecube/orgs","repos_url":"https://api.github.com/users/scalecube/repos","events_url":"https://api.github.com/users/scalecube/events{/privacy}","received_events_url":"https://api.github.com/users/scalecube/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalecube/scalecube-parent","description":"a parent project for all Scalecube projects","fork":false,"url":"https://api.github.com/repos/scalecube/scalecube-parent","forks_url":"https://api.github.com/repos/scalecube/scalecube-parent/forks","keys_url":"https://api.github.com/repos/scalecube/scalecube-parent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalecube/scalecube-parent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalecube/scalecube-parent/teams","hooks_url":"https://api.github.com/repos/scalecube/scalecube-parent/hooks","issue_events_url":"https://api.github.com/repos/scalecube/scalecube-parent/issues/events{/number}","events_url":"https://api.github.com/repos/scalecube/scalecube-parent/events","assignees_url":"https://api.github.com/repos/scalecube/scalecube-parent/assignees{/user}","branches_url":"https://api.github.com/repos/scalecube/scalecube-parent/branches{/branch}","tags_url":"https://api.github.com/repos/scalecube/scalecube-parent/tags","blobs_url":"https://api.github.com/repos/scalecube/scalecube-parent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalecube/scalecube-parent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalecube/scalecube-parent/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalecube/scalecube-parent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalecube/scalecube-parent/statuses/{sha}","languages_url":"https://api.github.com/repos/scalecube/scalecube-parent/languages","stargazers_url":"https://api.github.com/repos/scalecube/scalecube-parent/stargazers","contributors_url":"https://api.github.com/repos/scalecube/scalecube-parent/contributors","subscribers_url":"https://api.github.com/repos/scalecube/scalecube-parent/subscribers","subscription_url":"https://api.github.com/repos/scalecube/scalecube-parent/subscription","commits_url":"https://api.github.com/repos/scalecube/scalecube-parent/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalecube/scalecube-parent/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalecube/scalecube-parent/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalecube/scalecube-parent/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalecube/scalecube-parent/contents/{+path}","compare_url":"https://api.github.com/repos/scalecube/scalecube-parent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalecube/scalecube-parent/merges","archive_url":"https://api.github.com/repos/scalecube/scalecube-parent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalecube/scalecube-parent/downloads","issues_url":"https://api.github.com/repos/scalecube/scalecube-parent/issues{/number}","pulls_url":"https://api.github.com/repos/scalecube/scalecube-parent/pulls{/number}","milestones_url":"https://api.github.com/repos/scalecube/scalecube-parent/milestones{/number}","notifications_url":"https://api.github.com/repos/scalecube/scalecube-parent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalecube/scalecube-parent/labels{/name}","releases_url":"https://api.github.com/repos/scalecube/scalecube-parent/releases{/id}","deployments_url":"https://api.github.com/repos/scalecube/scalecube-parent/deployments","created_at":"2018-07-24T06:16:50Z","updated_at":"2018-08-09T08:09:45Z","pushed_at":"2018-08-09T09:57:40Z","git_url":"git://github.com/scalecube/scalecube-parent.git","ssh_url":"git@github.com:scalecube/scalecube-parent.git","clone_url":"https://github.com/scalecube/scalecube-parent.git","svn_url":"https://github.com/scalecube/scalecube-parent","homepage":null,"size":97,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/scalecube/scalecube-parent/pulls/21"},"html":{"href":"https://github.com/scalecube/scalecube-parent/pull/21"},"issue":{"href":"https://api.github.com/repos/scalecube/scalecube-parent/issues/21"},"comments":{"href":"https://api.github.com/repos/scalecube/scalecube-parent/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/scalecube/scalecube-parent/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/scalecube/scalecube-parent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalecube/scalecube-parent/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/scalecube/scalecube-parent/statuses/8f7693eac80444b67a5ec403dd08abc35df7423b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aharonha"}}