{"action":"created","comment":{"url":"https://api.github.com/repos/vector-im/riot-android/pulls/comments/184662582","pull_request_review_id":115906321,"id":184662582,"diff_hunk":"@@ -358,7 +373,7 @@ public void onSuccess(Void info) {\n         mAlertDialog.setOnCancelListener(new DialogInterface.OnCancelListener() {\n             @Override\n             public void onCancel(DialogInterface dialogInterface) {\n-                onDisplayKeyShareDialogClose(false);\n+                onDisplayKeyShareDialogClose(false, true);","path":"vector/src/main/java/im/vector/KeyRequestHandler.java","position":95,"original_position":95,"commit_id":"2971df85cdb42d5b77f05a9b6d334314064ad672","original_commit_id":"2971df85cdb42d5b77f05a9b6d334314064ad672","user":{"login":"manuroe","id":8418515,"avatar_url":"https://avatars0.githubusercontent.com/u/8418515?v=4","gravatar_id":"","url":"https://api.github.com/users/manuroe","html_url":"https://github.com/manuroe","followers_url":"https://api.github.com/users/manuroe/followers","following_url":"https://api.github.com/users/manuroe/following{/other_user}","gists_url":"https://api.github.com/users/manuroe/gists{/gist_id}","starred_url":"https://api.github.com/users/manuroe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manuroe/subscriptions","organizations_url":"https://api.github.com/users/manuroe/orgs","repos_url":"https://api.github.com/users/manuroe/repos","events_url":"https://api.github.com/users/manuroe/events{/privacy}","received_events_url":"https://api.github.com/users/manuroe/received_events","type":"User","site_admin":false},"body":"Well, I did not know what setOnCancelListener does. Sorry :|\r\nI let you update it if needed.\r\n","created_at":"2018-04-27T11:36:29Z","updated_at":"2018-04-27T11:36:29Z","html_url":"https://github.com/vector-im/riot-android/pull/2192#discussion_r184662582","pull_request_url":"https://api.github.com/repos/vector-im/riot-android/pulls/2192","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vector-im/riot-android/pulls/comments/184662582"},"html":{"href":"https://github.com/vector-im/riot-android/pull/2192#discussion_r184662582"},"pull_request":{"href":"https://api.github.com/repos/vector-im/riot-android/pulls/2192"}},"in_reply_to_id":184629208},"pull_request":{"url":"https://api.github.com/repos/vector-im/riot-android/pulls/2192","id":184378497,"html_url":"https://github.com/vector-im/riot-android/pull/2192","diff_url":"https://github.com/vector-im/riot-android/pull/2192.diff","patch_url":"https://github.com/vector-im/riot-android/pull/2192.patch","issue_url":"https://api.github.com/repos/vector-im/riot-android/issues/2192","number":2192,"state":"open","locked":false,"title":"Bug Fix: E2E: App keeps displaying ignored keyshare requests","user":{"login":"manuroe","id":8418515,"avatar_url":"https://avatars0.githubusercontent.com/u/8418515?v=4","gravatar_id":"","url":"https://api.github.com/users/manuroe","html_url":"https://github.com/manuroe","followers_url":"https://api.github.com/users/manuroe/followers","following_url":"https://api.github.com/users/manuroe/following{/other_user}","gists_url":"https://api.github.com/users/manuroe/gists{/gist_id}","starred_url":"https://api.github.com/users/manuroe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manuroe/subscriptions","organizations_url":"https://api.github.com/users/manuroe/orgs","repos_url":"https://api.github.com/users/manuroe/repos","events_url":"https://api.github.com/users/manuroe/events{/privacy}","received_events_url":"https://api.github.com/users/manuroe/received_events","type":"User","site_admin":false},"body":"Closes #2191.\r\nNeeds https://github.com/matrix-org/matrix-android-sdk/pull/258.\r\n","created_at":"2018-04-26T15:27:18Z","updated_at":"2018-04-27T11:36:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89d2029ebe8f0b1f8e548052184f635fcb31df9c","assignee":{"login":"bmarty","id":3940906,"avatar_url":"https://avatars3.githubusercontent.com/u/3940906?v=4","gravatar_id":"","url":"https://api.github.com/users/bmarty","html_url":"https://github.com/bmarty","followers_url":"https://api.github.com/users/bmarty/followers","following_url":"https://api.github.com/users/bmarty/following{/other_user}","gists_url":"https://api.github.com/users/bmarty/gists{/gist_id}","starred_url":"https://api.github.com/users/bmarty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmarty/subscriptions","organizations_url":"https://api.github.com/users/bmarty/orgs","repos_url":"https://api.github.com/users/bmarty/repos","events_url":"https://api.github.com/users/bmarty/events{/privacy}","received_events_url":"https://api.github.com/users/bmarty/received_events","type":"User","site_admin":false},"assignees":[{"login":"bmarty","id":3940906,"avatar_url":"https://avatars3.githubusercontent.com/u/3940906?v=4","gravatar_id":"","url":"https://api.github.com/users/bmarty","html_url":"https://github.com/bmarty","followers_url":"https://api.github.com/users/bmarty/followers","following_url":"https://api.github.com/users/bmarty/following{/other_user}","gists_url":"https://api.github.com/users/bmarty/gists{/gist_id}","starred_url":"https://api.github.com/users/bmarty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmarty/subscriptions","organizations_url":"https://api.github.com/users/bmarty/orgs","repos_url":"https://api.github.com/users/bmarty/repos","events_url":"https://api.github.com/users/bmarty/events{/privacy}","received_events_url":"https://api.github.com/users/bmarty/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vector-im/riot-android/pulls/2192/commits","review_comments_url":"https://api.github.com/repos/vector-im/riot-android/pulls/2192/comments","review_comment_url":"https://api.github.com/repos/vector-im/riot-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vector-im/riot-android/issues/2192/comments","statuses_url":"https://api.github.com/repos/vector-im/riot-android/statuses/2971df85cdb42d5b77f05a9b6d334314064ad672","head":{"label":"vector-im:riot_2191","ref":"riot_2191","sha":"2971df85cdb42d5b77f05a9b6d334314064ad672","user":{"login":"vector-im","id":13446337,"avatar_url":"https://avatars0.githubusercontent.com/u/13446337?v=4","gravatar_id":"","url":"https://api.github.com/users/vector-im","html_url":"https://github.com/vector-im","followers_url":"https://api.github.com/users/vector-im/followers","following_url":"https://api.github.com/users/vector-im/following{/other_user}","gists_url":"https://api.github.com/users/vector-im/gists{/gist_id}","starred_url":"https://api.github.com/users/vector-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vector-im/subscriptions","organizations_url":"https://api.github.com/users/vector-im/orgs","repos_url":"https://api.github.com/users/vector-im/repos","events_url":"https://api.github.com/users/vector-im/events{/privacy}","received_events_url":"https://api.github.com/users/vector-im/received_events","type":"Organization","site_admin":false},"repo":{"id":48181728,"name":"riot-android","full_name":"vector-im/riot-android","owner":{"login":"vector-im","id":13446337,"avatar_url":"https://avatars0.githubusercontent.com/u/13446337?v=4","gravatar_id":"","url":"https://api.github.com/users/vector-im","html_url":"https://github.com/vector-im","followers_url":"https://api.github.com/users/vector-im/followers","following_url":"https://api.github.com/users/vector-im/following{/other_user}","gists_url":"https://api.github.com/users/vector-im/gists{/gist_id}","starred_url":"https://api.github.com/users/vector-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vector-im/subscriptions","organizations_url":"https://api.github.com/users/vector-im/orgs","repos_url":"https://api.github.com/users/vector-im/repos","events_url":"https://api.github.com/users/vector-im/events{/privacy}","received_events_url":"https://api.github.com/users/vector-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vector-im/riot-android","description":"A glossy Matrix collaboration client for Android","fork":false,"url":"https://api.github.com/repos/vector-im/riot-android","forks_url":"https://api.github.com/repos/vector-im/riot-android/forks","keys_url":"https://api.github.com/repos/vector-im/riot-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vector-im/riot-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vector-im/riot-android/teams","hooks_url":"https://api.github.com/repos/vector-im/riot-android/hooks","issue_events_url":"https://api.github.com/repos/vector-im/riot-android/issues/events{/number}","events_url":"https://api.github.com/repos/vector-im/riot-android/events","assignees_url":"https://api.github.com/repos/vector-im/riot-android/assignees{/user}","branches_url":"https://api.github.com/repos/vector-im/riot-android/branches{/branch}","tags_url":"https://api.github.com/repos/vector-im/riot-android/tags","blobs_url":"https://api.github.com/repos/vector-im/riot-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vector-im/riot-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vector-im/riot-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/vector-im/riot-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vector-im/riot-android/statuses/{sha}","languages_url":"https://api.github.com/repos/vector-im/riot-android/languages","stargazers_url":"https://api.github.com/repos/vector-im/riot-android/stargazers","contributors_url":"https://api.github.com/repos/vector-im/riot-android/contributors","subscribers_url":"https://api.github.com/repos/vector-im/riot-android/subscribers","subscription_url":"https://api.github.com/repos/vector-im/riot-android/subscription","commits_url":"https://api.github.com/repos/vector-im/riot-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/vector-im/riot-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/vector-im/riot-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/vector-im/riot-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/vector-im/riot-android/contents/{+path}","compare_url":"https://api.github.com/repos/vector-im/riot-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vector-im/riot-android/merges","archive_url":"https://api.github.com/repos/vector-im/riot-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vector-im/riot-android/downloads","issues_url":"https://api.github.com/repos/vector-im/riot-android/issues{/number}","pulls_url":"https://api.github.com/repos/vector-im/riot-android/pulls{/number}","milestones_url":"https://api.github.com/repos/vector-im/riot-android/milestones{/number}","notifications_url":"https://api.github.com/repos/vector-im/riot-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vector-im/riot-android/labels{/name}","releases_url":"https://api.github.com/repos/vector-im/riot-android/releases{/id}","deployments_url":"https://api.github.com/repos/vector-im/riot-android/deployments","created_at":"2015-12-17T15:18:05Z","updated_at":"2018-04-27T11:35:28Z","pushed_at":"2018-04-27T09:29:39Z","git_url":"git://github.com/vector-im/riot-android.git","ssh_url":"git@github.com:vector-im/riot-android.git","clone_url":"https://github.com/vector-im/riot-android.git","svn_url":"https://github.com/vector-im/riot-android","homepage":null,"size":848648,"stargazers_count":596,"watchers_count":596,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":216,"mirror_url":null,"archived":false,"open_issues_count":794,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":216,"open_issues":794,"watchers":596,"default_branch":"develop"}},"base":{"label":"vector-im:develop","ref":"develop","sha":"de7f8feaf588255c59cf835940cdd50da7108657","user":{"login":"vector-im","id":13446337,"avatar_url":"https://avatars0.githubusercontent.com/u/13446337?v=4","gravatar_id":"","url":"https://api.github.com/users/vector-im","html_url":"https://github.com/vector-im","followers_url":"https://api.github.com/users/vector-im/followers","following_url":"https://api.github.com/users/vector-im/following{/other_user}","gists_url":"https://api.github.com/users/vector-im/gists{/gist_id}","starred_url":"https://api.github.com/users/vector-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vector-im/subscriptions","organizations_url":"https://api.github.com/users/vector-im/orgs","repos_url":"https://api.github.com/users/vector-im/repos","events_url":"https://api.github.com/users/vector-im/events{/privacy}","received_events_url":"https://api.github.com/users/vector-im/received_events","type":"Organization","site_admin":false},"repo":{"id":48181728,"name":"riot-android","full_name":"vector-im/riot-android","owner":{"login":"vector-im","id":13446337,"avatar_url":"https://avatars0.githubusercontent.com/u/13446337?v=4","gravatar_id":"","url":"https://api.github.com/users/vector-im","html_url":"https://github.com/vector-im","followers_url":"https://api.github.com/users/vector-im/followers","following_url":"https://api.github.com/users/vector-im/following{/other_user}","gists_url":"https://api.github.com/users/vector-im/gists{/gist_id}","starred_url":"https://api.github.com/users/vector-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vector-im/subscriptions","organizations_url":"https://api.github.com/users/vector-im/orgs","repos_url":"https://api.github.com/users/vector-im/repos","events_url":"https://api.github.com/users/vector-im/events{/privacy}","received_events_url":"https://api.github.com/users/vector-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vector-im/riot-android","description":"A glossy Matrix collaboration client for Android","fork":false,"url":"https://api.github.com/repos/vector-im/riot-android","forks_url":"https://api.github.com/repos/vector-im/riot-android/forks","keys_url":"https://api.github.com/repos/vector-im/riot-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vector-im/riot-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vector-im/riot-android/teams","hooks_url":"https://api.github.com/repos/vector-im/riot-android/hooks","issue_events_url":"https://api.github.com/repos/vector-im/riot-android/issues/events{/number}","events_url":"https://api.github.com/repos/vector-im/riot-android/events","assignees_url":"https://api.github.com/repos/vector-im/riot-android/assignees{/user}","branches_url":"https://api.github.com/repos/vector-im/riot-android/branches{/branch}","tags_url":"https://api.github.com/repos/vector-im/riot-android/tags","blobs_url":"https://api.github.com/repos/vector-im/riot-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vector-im/riot-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vector-im/riot-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/vector-im/riot-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vector-im/riot-android/statuses/{sha}","languages_url":"https://api.github.com/repos/vector-im/riot-android/languages","stargazers_url":"https://api.github.com/repos/vector-im/riot-android/stargazers","contributors_url":"https://api.github.com/repos/vector-im/riot-android/contributors","subscribers_url":"https://api.github.com/repos/vector-im/riot-android/subscribers","subscription_url":"https://api.github.com/repos/vector-im/riot-android/subscription","commits_url":"https://api.github.com/repos/vector-im/riot-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/vector-im/riot-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/vector-im/riot-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/vector-im/riot-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/vector-im/riot-android/contents/{+path}","compare_url":"https://api.github.com/repos/vector-im/riot-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vector-im/riot-android/merges","archive_url":"https://api.github.com/repos/vector-im/riot-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vector-im/riot-android/downloads","issues_url":"https://api.github.com/repos/vector-im/riot-android/issues{/number}","pulls_url":"https://api.github.com/repos/vector-im/riot-android/pulls{/number}","milestones_url":"https://api.github.com/repos/vector-im/riot-android/milestones{/number}","notifications_url":"https://api.github.com/repos/vector-im/riot-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vector-im/riot-android/labels{/name}","releases_url":"https://api.github.com/repos/vector-im/riot-android/releases{/id}","deployments_url":"https://api.github.com/repos/vector-im/riot-android/deployments","created_at":"2015-12-17T15:18:05Z","updated_at":"2018-04-27T11:35:28Z","pushed_at":"2018-04-27T09:29:39Z","git_url":"git://github.com/vector-im/riot-android.git","ssh_url":"git@github.com:vector-im/riot-android.git","clone_url":"https://github.com/vector-im/riot-android.git","svn_url":"https://github.com/vector-im/riot-android","homepage":null,"size":848648,"stargazers_count":596,"watchers_count":596,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":216,"mirror_url":null,"archived":false,"open_issues_count":794,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":216,"open_issues":794,"watchers":596,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/vector-im/riot-android/pulls/2192"},"html":{"href":"https://github.com/vector-im/riot-android/pull/2192"},"issue":{"href":"https://api.github.com/repos/vector-im/riot-android/issues/2192"},"comments":{"href":"https://api.github.com/repos/vector-im/riot-android/issues/2192/comments"},"review_comments":{"href":"https://api.github.com/repos/vector-im/riot-android/pulls/2192/comments"},"review_comment":{"href":"https://api.github.com/repos/vector-im/riot-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vector-im/riot-android/pulls/2192/commits"},"statuses":{"href":"https://api.github.com/repos/vector-im/riot-android/statuses/2971df85cdb42d5b77f05a9b6d334314064ad672"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"manuroe"}}