{"action":"closed","number":954,"pull_request":{"url":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/954","id":227701262,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NzAxMjYy","html_url":"https://github.com/elifesciences/elife-xpub/pull/954","diff_url":"https://github.com/elifesciences/elife-xpub/pull/954.diff","patch_url":"https://github.com/elifesciences/elife-xpub/pull/954.patch","issue_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues/954","number":954,"state":"closed","locked":false,"title":"Fix internal page anchor links","user":{"login":"jsms90","id":15656538,"node_id":"MDQ6VXNlcjE1NjU2NTM4","avatar_url":"https://avatars2.githubusercontent.com/u/15656538?v=4","gravatar_id":"","url":"https://api.github.com/users/jsms90","html_url":"https://github.com/jsms90","followers_url":"https://api.github.com/users/jsms90/followers","following_url":"https://api.github.com/users/jsms90/following{/other_user}","gists_url":"https://api.github.com/users/jsms90/gists{/gist_id}","starred_url":"https://api.github.com/users/jsms90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsms90/subscriptions","organizations_url":"https://api.github.com/users/jsms90/orgs","repos_url":"https://api.github.com/users/jsms90/repos","events_url":"https://api.github.com/users/jsms90/events{/privacy}","received_events_url":"https://api.github.com/users/jsms90/received_events","type":"User","site_admin":false},"body":"#### Background\r\nAt the moment we use 2 (or 3) different types of links in our application:\r\n- `ExternalLink` - our own component: an anchor tag with eLife styling applied\r\n- `Link` from pubsweet - which uses react-router's `Link` under the hood & applies styling)\r\n\r\n(Note: elsewhere we also import `Link` directly from react-router, in situations where it's not styled normally i.e. non-blue links in ProfileMenu, DashboardList, etc.)\r\n\r\nUntil now, we had never linked to a heading within the same page (via an id).\r\n\r\n#### What does this PR do?\r\n- Fixes broken links in `EditorialProcess` & `Fees` components by changing `Link` (react-router) to `ExternalLink` (regular anchor tag)\r\n- Renames the `ExternalLink` component to `NativeLink`, to better describe all use cases\r\n- Updates ExternalLInk/Native Link styleguidist description accordingly\r\n\r\n#### Any relevant tickets\r\nFixes #907 \r\nFixes #955\r\n\r\n#### How has this been tested?\r\nManually clicking the links","created_at":"2018-11-01T17:43:12Z","updated_at":"2018-11-02T10:22:55Z","closed_at":"2018-11-02T10:22:55Z","merged_at":"2018-11-02T10:22:55Z","merge_commit_sha":"5e64fd5b6f9f3ccc741ceda8bd1c75558fcc465c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/954/commits","review_comments_url":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/954/comments","review_comment_url":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues/954/comments","statuses_url":"https://api.github.com/repos/elifesciences/elife-xpub/statuses/896bae3f6093a8c86028de25867fc184e6082f21","head":{"label":"elifesciences:fix-faq-link","ref":"fix-faq-link","sha":"896bae3f6093a8c86028de25867fc184e6082f21","user":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":100492246,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA0OTIyNDY=","name":"elife-xpub","full_name":"elifesciences/elife-xpub","private":false,"owner":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elifesciences/elife-xpub","description":"eLife is an open-access journal and technology provider that publishes promising research in the life and biomedical sciences. This is their implementation of a submission and peer review system based on Coko PubSweet and xPub.","fork":false,"url":"https://api.github.com/repos/elifesciences/elife-xpub","forks_url":"https://api.github.com/repos/elifesciences/elife-xpub/forks","keys_url":"https://api.github.com/repos/elifesciences/elife-xpub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/elife-xpub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/elife-xpub/teams","hooks_url":"https://api.github.com/repos/elifesciences/elife-xpub/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/elife-xpub/events","assignees_url":"https://api.github.com/repos/elifesciences/elife-xpub/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/elife-xpub/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/elife-xpub/tags","blobs_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/elife-xpub/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/elife-xpub/languages","stargazers_url":"https://api.github.com/repos/elifesciences/elife-xpub/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/elife-xpub/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/elife-xpub/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/elife-xpub/subscription","commits_url":"https://api.github.com/repos/elifesciences/elife-xpub/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/elife-xpub/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/elife-xpub/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/elife-xpub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/elife-xpub/merges","archive_url":"https://api.github.com/repos/elifesciences/elife-xpub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/elife-xpub/downloads","issues_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/elife-xpub/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/elife-xpub/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/elife-xpub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/elife-xpub/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/elife-xpub/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/elife-xpub/deployments","created_at":"2017-08-16T13:26:53Z","updated_at":"2018-11-02T09:36:17Z","pushed_at":"2018-11-02T10:22:55Z","git_url":"git://github.com/elifesciences/elife-xpub.git","ssh_url":"git@github.com:elifesciences/elife-xpub.git","clone_url":"https://github.com/elifesciences/elife-xpub.git","svn_url":"https://github.com/elifesciences/elife-xpub","homepage":"https://elifesciences.org/","size":5807,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":177,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":177,"watchers":15,"default_branch":"develop"}},"base":{"label":"elifesciences:develop","ref":"develop","sha":"ac135f95bdd4d9f20827aece05483213d6b8eb7b","user":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":100492246,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA0OTIyNDY=","name":"elife-xpub","full_name":"elifesciences/elife-xpub","private":false,"owner":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elifesciences/elife-xpub","description":"eLife is an open-access journal and technology provider that publishes promising research in the life and biomedical sciences. This is their implementation of a submission and peer review system based on Coko PubSweet and xPub.","fork":false,"url":"https://api.github.com/repos/elifesciences/elife-xpub","forks_url":"https://api.github.com/repos/elifesciences/elife-xpub/forks","keys_url":"https://api.github.com/repos/elifesciences/elife-xpub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/elife-xpub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/elife-xpub/teams","hooks_url":"https://api.github.com/repos/elifesciences/elife-xpub/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/elife-xpub/events","assignees_url":"https://api.github.com/repos/elifesciences/elife-xpub/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/elife-xpub/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/elife-xpub/tags","blobs_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/elife-xpub/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/elife-xpub/languages","stargazers_url":"https://api.github.com/repos/elifesciences/elife-xpub/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/elife-xpub/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/elife-xpub/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/elife-xpub/subscription","commits_url":"https://api.github.com/repos/elifesciences/elife-xpub/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/elife-xpub/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/elife-xpub/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/elife-xpub/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/elife-xpub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/elife-xpub/merges","archive_url":"https://api.github.com/repos/elifesciences/elife-xpub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/elife-xpub/downloads","issues_url":"https://api.github.com/repos/elifesciences/elife-xpub/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/elife-xpub/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/elife-xpub/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/elife-xpub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/elife-xpub/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/elife-xpub/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/elife-xpub/deployments","created_at":"2017-08-16T13:26:53Z","updated_at":"2018-11-02T09:36:17Z","pushed_at":"2018-11-02T10:22:55Z","git_url":"git://github.com/elifesciences/elife-xpub.git","ssh_url":"git@github.com:elifesciences/elife-xpub.git","clone_url":"https://github.com/elifesciences/elife-xpub.git","svn_url":"https://github.com/elifesciences/elife-xpub","homepage":"https://elifesciences.org/","size":5807,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":177,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":177,"watchers":15,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/954"},"html":{"href":"https://github.com/elifesciences/elife-xpub/pull/954"},"issue":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/issues/954"},"comments":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/issues/954/comments"},"review_comments":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/954/comments"},"review_comment":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/pulls/954/commits"},"statuses":{"href":"https://api.github.com/repos/elifesciences/elife-xpub/statuses/896bae3f6093a8c86028de25867fc184e6082f21"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"damnhipster","id":2573277,"node_id":"MDQ6VXNlcjI1NzMyNzc=","avatar_url":"https://avatars1.githubusercontent.com/u/2573277?v=4","gravatar_id":"","url":"https://api.github.com/users/damnhipster","html_url":"https://github.com/damnhipster","followers_url":"https://api.github.com/users/damnhipster/followers","following_url":"https://api.github.com/users/damnhipster/following{/other_user}","gists_url":"https://api.github.com/users/damnhipster/gists{/gist_id}","starred_url":"https://api.github.com/users/damnhipster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damnhipster/subscriptions","organizations_url":"https://api.github.com/users/damnhipster/orgs","repos_url":"https://api.github.com/users/damnhipster/repos","events_url":"https://api.github.com/users/damnhipster/events{/privacy}","received_events_url":"https://api.github.com/users/damnhipster/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":392,"deletions":404,"changed_files":20}}
{"actor":{"display_login":"damnhipster"}}