{"action":"closed","number":19,"pull_request":{"url":"https://api.github.com/repos/stevethedev/std-classifier/pulls/19","id":226693878,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NjkzODc4","html_url":"https://github.com/stevethedev/std-classifier/pull/19","diff_url":"https://github.com/stevethedev/std-classifier/pull/19.diff","patch_url":"https://github.com/stevethedev/std-classifier/pull/19.patch","issue_url":"https://api.github.com/repos/stevethedev/std-classifier/issues/19","number":19,"state":"closed","locked":false,"title":"Issue #18: UNCLASSIFIED releasability caveats block C, R, S, TS caveats.","user":{"login":"stevethedev","id":14143771,"node_id":"MDQ6VXNlcjE0MTQzNzcx","avatar_url":"https://avatars2.githubusercontent.com/u/14143771?v=4","gravatar_id":"","url":"https://api.github.com/users/stevethedev","html_url":"https://github.com/stevethedev","followers_url":"https://api.github.com/users/stevethedev/followers","following_url":"https://api.github.com/users/stevethedev/following{/other_user}","gists_url":"https://api.github.com/users/stevethedev/gists{/gist_id}","starred_url":"https://api.github.com/users/stevethedev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevethedev/subscriptions","organizations_url":"https://api.github.com/users/stevethedev/orgs","repos_url":"https://api.github.com/users/stevethedev/repos","events_url":"https://api.github.com/users/stevethedev/events{/privacy}","received_events_url":"https://api.github.com/users/stevethedev/received_events","type":"User","site_admin":false},"body":"<!---\r\n  Thank you for contributing to the Classification Manager!\r\n  To make it easier for me to process this pull request, please provide:\r\n     - A summary of your pull request\r\n     - Any issue(s) your pull request relates to\r\n     - Any manual steps necessary to validate your pull request\r\n-->\r\n\r\n<!--- Please provide a general summary of your pull request in the Title field (above) -->\r\n\r\n### Description\r\n\r\nThis commit fixes the bug reported in Ticket #18. This fix corrects the\r\nissue by checking the classification levels of two Classification\r\nobjects prior to merge, and then caching any relevant REL TO elements\r\nbefore they are merged together. If there are any cached REL TO\r\nelements, then they are mixed back into the classification after the\r\nmerge is complete.\r\n\r\nThis implementation helps prevent the Dissemination class from needing\r\nto be aware of the classification levels of each classification outside\r\nof the class, and sets up a precedent moving forward for where these\r\nkinds of rule-oddities should be handled.\r\n\r\n### Fixed Issues (if relevant)\r\n1. Fixes a bug where UNCLASSIFIED classifications would squash the REL TO caveats. (#18)\r\n\r\n### Manual testing\r\nNo manual testing necessary; two tests added to `./tests/unclassified-reduction.js`.\r\n\r\n### Contribution checklist\r\n - [x] The pull request has a meaningful title and description.\r\n - [x] All commits are accompanied by meaningful commit messages.\r\n - [x] All new or changed code is covered with automated tests (as applicable).\r\n - [ ] All CI validation steps have passed.\r\n","created_at":"2018-10-29T19:58:48Z","updated_at":"2018-10-29T20:39:16Z","closed_at":"2018-10-29T20:39:16Z","merged_at":"2018-10-29T20:39:16Z","merge_commit_sha":"537c5082d65f209b9bc98720beeee545efab47fe","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stevethedev/std-classifier/pulls/19/commits","review_comments_url":"https://api.github.com/repos/stevethedev/std-classifier/pulls/19/comments","review_comment_url":"https://api.github.com/repos/stevethedev/std-classifier/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stevethedev/std-classifier/issues/19/comments","statuses_url":"https://api.github.com/repos/stevethedev/std-classifier/statuses/f7c17b305df7b6b99a0074b67d038073cbf28b22","head":{"label":"stevethedev:issue-18","ref":"issue-18","sha":"f7c17b305df7b6b99a0074b67d038073cbf28b22","user":{"login":"stevethedev","id":14143771,"node_id":"MDQ6VXNlcjE0MTQzNzcx","avatar_url":"https://avatars2.githubusercontent.com/u/14143771?v=4","gravatar_id":"","url":"https://api.github.com/users/stevethedev","html_url":"https://github.com/stevethedev","followers_url":"https://api.github.com/users/stevethedev/followers","following_url":"https://api.github.com/users/stevethedev/following{/other_user}","gists_url":"https://api.github.com/users/stevethedev/gists{/gist_id}","starred_url":"https://api.github.com/users/stevethedev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevethedev/subscriptions","organizations_url":"https://api.github.com/users/stevethedev/orgs","repos_url":"https://api.github.com/users/stevethedev/repos","events_url":"https://api.github.com/users/stevethedev/events{/privacy}","received_events_url":"https://api.github.com/users/stevethedev/received_events","type":"User","site_admin":false},"repo":{"id":148180781,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgxODA3ODE=","name":"std-classifier","full_name":"stevethedev/std-classifier","private":false,"owner":{"login":"stevethedev","id":14143771,"node_id":"MDQ6VXNlcjE0MTQzNzcx","avatar_url":"https://avatars2.githubusercontent.com/u/14143771?v=4","gravatar_id":"","url":"https://api.github.com/users/stevethedev","html_url":"https://github.com/stevethedev","followers_url":"https://api.github.com/users/stevethedev/followers","following_url":"https://api.github.com/users/stevethedev/following{/other_user}","gists_url":"https://api.github.com/users/stevethedev/gists{/gist_id}","starred_url":"https://api.github.com/users/stevethedev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevethedev/subscriptions","organizations_url":"https://api.github.com/users/stevethedev/orgs","repos_url":"https://api.github.com/users/stevethedev/repos","events_url":"https://api.github.com/users/stevethedev/events{/privacy}","received_events_url":"https://api.github.com/users/stevethedev/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stevethedev/std-classifier","description":"A library for building and aggregating US Classifications, according to DoD Manual 5200.01 Vol 1 and EO12958.","fork":false,"url":"https://api.github.com/repos/stevethedev/std-classifier","forks_url":"https://api.github.com/repos/stevethedev/std-classifier/forks","keys_url":"https://api.github.com/repos/stevethedev/std-classifier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevethedev/std-classifier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevethedev/std-classifier/teams","hooks_url":"https://api.github.com/repos/stevethedev/std-classifier/hooks","issue_events_url":"https://api.github.com/repos/stevethedev/std-classifier/issues/events{/number}","events_url":"https://api.github.com/repos/stevethedev/std-classifier/events","assignees_url":"https://api.github.com/repos/stevethedev/std-classifier/assignees{/user}","branches_url":"https://api.github.com/repos/stevethedev/std-classifier/branches{/branch}","tags_url":"https://api.github.com/repos/stevethedev/std-classifier/tags","blobs_url":"https://api.github.com/repos/stevethedev/std-classifier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevethedev/std-classifier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevethedev/std-classifier/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevethedev/std-classifier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevethedev/std-classifier/statuses/{sha}","languages_url":"https://api.github.com/repos/stevethedev/std-classifier/languages","stargazers_url":"https://api.github.com/repos/stevethedev/std-classifier/stargazers","contributors_url":"https://api.github.com/repos/stevethedev/std-classifier/contributors","subscribers_url":"https://api.github.com/repos/stevethedev/std-classifier/subscribers","subscription_url":"https://api.github.com/repos/stevethedev/std-classifier/subscription","commits_url":"https://api.github.com/repos/stevethedev/std-classifier/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevethedev/std-classifier/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevethedev/std-classifier/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevethedev/std-classifier/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevethedev/std-classifier/contents/{+path}","compare_url":"https://api.github.com/repos/stevethedev/std-classifier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevethedev/std-classifier/merges","archive_url":"https://api.github.com/repos/stevethedev/std-classifier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevethedev/std-classifier/downloads","issues_url":"https://api.github.com/repos/stevethedev/std-classifier/issues{/number}","pulls_url":"https://api.github.com/repos/stevethedev/std-classifier/pulls{/number}","milestones_url":"https://api.github.com/repos/stevethedev/std-classifier/milestones{/number}","notifications_url":"https://api.github.com/repos/stevethedev/std-classifier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevethedev/std-classifier/labels{/name}","releases_url":"https://api.github.com/repos/stevethedev/std-classifier/releases{/id}","deployments_url":"https://api.github.com/repos/stevethedev/std-classifier/deployments","created_at":"2018-09-10T15:53:40Z","updated_at":"2018-09-23T20:24:35Z","pushed_at":"2018-10-29T20:39:16Z","git_url":"git://github.com/stevethedev/std-classifier.git","ssh_url":"git@github.com:stevethedev/std-classifier.git","clone_url":"https://github.com/stevethedev/std-classifier.git","svn_url":"https://github.com/stevethedev/std-classifier","homepage":"","size":595,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"stevethedev:master","ref":"master","sha":"c7def5bc0b711aaf2aaac5a61c7d13a2a1d9e05d","user":{"login":"stevethedev","id":14143771,"node_id":"MDQ6VXNlcjE0MTQzNzcx","avatar_url":"https://avatars2.githubusercontent.com/u/14143771?v=4","gravatar_id":"","url":"https://api.github.com/users/stevethedev","html_url":"https://github.com/stevethedev","followers_url":"https://api.github.com/users/stevethedev/followers","following_url":"https://api.github.com/users/stevethedev/following{/other_user}","gists_url":"https://api.github.com/users/stevethedev/gists{/gist_id}","starred_url":"https://api.github.com/users/stevethedev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevethedev/subscriptions","organizations_url":"https://api.github.com/users/stevethedev/orgs","repos_url":"https://api.github.com/users/stevethedev/repos","events_url":"https://api.github.com/users/stevethedev/events{/privacy}","received_events_url":"https://api.github.com/users/stevethedev/received_events","type":"User","site_admin":false},"repo":{"id":148180781,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgxODA3ODE=","name":"std-classifier","full_name":"stevethedev/std-classifier","private":false,"owner":{"login":"stevethedev","id":14143771,"node_id":"MDQ6VXNlcjE0MTQzNzcx","avatar_url":"https://avatars2.githubusercontent.com/u/14143771?v=4","gravatar_id":"","url":"https://api.github.com/users/stevethedev","html_url":"https://github.com/stevethedev","followers_url":"https://api.github.com/users/stevethedev/followers","following_url":"https://api.github.com/users/stevethedev/following{/other_user}","gists_url":"https://api.github.com/users/stevethedev/gists{/gist_id}","starred_url":"https://api.github.com/users/stevethedev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevethedev/subscriptions","organizations_url":"https://api.github.com/users/stevethedev/orgs","repos_url":"https://api.github.com/users/stevethedev/repos","events_url":"https://api.github.com/users/stevethedev/events{/privacy}","received_events_url":"https://api.github.com/users/stevethedev/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stevethedev/std-classifier","description":"A library for building and aggregating US Classifications, according to DoD Manual 5200.01 Vol 1 and EO12958.","fork":false,"url":"https://api.github.com/repos/stevethedev/std-classifier","forks_url":"https://api.github.com/repos/stevethedev/std-classifier/forks","keys_url":"https://api.github.com/repos/stevethedev/std-classifier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevethedev/std-classifier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevethedev/std-classifier/teams","hooks_url":"https://api.github.com/repos/stevethedev/std-classifier/hooks","issue_events_url":"https://api.github.com/repos/stevethedev/std-classifier/issues/events{/number}","events_url":"https://api.github.com/repos/stevethedev/std-classifier/events","assignees_url":"https://api.github.com/repos/stevethedev/std-classifier/assignees{/user}","branches_url":"https://api.github.com/repos/stevethedev/std-classifier/branches{/branch}","tags_url":"https://api.github.com/repos/stevethedev/std-classifier/tags","blobs_url":"https://api.github.com/repos/stevethedev/std-classifier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevethedev/std-classifier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevethedev/std-classifier/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevethedev/std-classifier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevethedev/std-classifier/statuses/{sha}","languages_url":"https://api.github.com/repos/stevethedev/std-classifier/languages","stargazers_url":"https://api.github.com/repos/stevethedev/std-classifier/stargazers","contributors_url":"https://api.github.com/repos/stevethedev/std-classifier/contributors","subscribers_url":"https://api.github.com/repos/stevethedev/std-classifier/subscribers","subscription_url":"https://api.github.com/repos/stevethedev/std-classifier/subscription","commits_url":"https://api.github.com/repos/stevethedev/std-classifier/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevethedev/std-classifier/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevethedev/std-classifier/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevethedev/std-classifier/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevethedev/std-classifier/contents/{+path}","compare_url":"https://api.github.com/repos/stevethedev/std-classifier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevethedev/std-classifier/merges","archive_url":"https://api.github.com/repos/stevethedev/std-classifier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevethedev/std-classifier/downloads","issues_url":"https://api.github.com/repos/stevethedev/std-classifier/issues{/number}","pulls_url":"https://api.github.com/repos/stevethedev/std-classifier/pulls{/number}","milestones_url":"https://api.github.com/repos/stevethedev/std-classifier/milestones{/number}","notifications_url":"https://api.github.com/repos/stevethedev/std-classifier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevethedev/std-classifier/labels{/name}","releases_url":"https://api.github.com/repos/stevethedev/std-classifier/releases{/id}","deployments_url":"https://api.github.com/repos/stevethedev/std-classifier/deployments","created_at":"2018-09-10T15:53:40Z","updated_at":"2018-09-23T20:24:35Z","pushed_at":"2018-10-29T20:39:16Z","git_url":"git://github.com/stevethedev/std-classifier.git","ssh_url":"git@github.com:stevethedev/std-classifier.git","clone_url":"https://github.com/stevethedev/std-classifier.git","svn_url":"https://github.com/stevethedev/std-classifier","homepage":"","size":595,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stevethedev/std-classifier/pulls/19"},"html":{"href":"https://github.com/stevethedev/std-classifier/pull/19"},"issue":{"href":"https://api.github.com/repos/stevethedev/std-classifier/issues/19"},"comments":{"href":"https://api.github.com/repos/stevethedev/std-classifier/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/stevethedev/std-classifier/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/stevethedev/std-classifier/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stevethedev/std-classifier/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/stevethedev/std-classifier/statuses/f7c17b305df7b6b99a0074b67d038073cbf28b22"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"stevethedev","id":14143771,"node_id":"MDQ6VXNlcjE0MTQzNzcx","avatar_url":"https://avatars2.githubusercontent.com/u/14143771?v=4","gravatar_id":"","url":"https://api.github.com/users/stevethedev","html_url":"https://github.com/stevethedev","followers_url":"https://api.github.com/users/stevethedev/followers","following_url":"https://api.github.com/users/stevethedev/following{/other_user}","gists_url":"https://api.github.com/users/stevethedev/gists{/gist_id}","starred_url":"https://api.github.com/users/stevethedev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevethedev/subscriptions","organizations_url":"https://api.github.com/users/stevethedev/orgs","repos_url":"https://api.github.com/users/stevethedev/repos","events_url":"https://api.github.com/users/stevethedev/events{/privacy}","received_events_url":"https://api.github.com/users/stevethedev/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":56,"deletions":2,"changed_files":3}}
{"actor":{"display_login":"stevethedev"}}