{"action":"opened","number":165,"pull_request":{"url":"https://api.github.com/repos/cds-snc/nrcan_api/pulls/165","id":169244846,"html_url":"https://github.com/cds-snc/nrcan_api/pull/165","diff_url":"https://github.com/cds-snc/nrcan_api/pull/165.diff","patch_url":"https://github.com/cds-snc/nrcan_api/pull/165.patch","issue_url":"https://api.github.com/repos/cds-snc/nrcan_api/issues/165","number":165,"state":"open","locked":false,"title":"[DEMO-1] Create /welcome page for demo purposes","user":{"login":"pcraig3","id":2454380,"avatar_url":"https://avatars1.githubusercontent.com/u/2454380?v=4","gravatar_id":"","url":"https://api.github.com/users/pcraig3","html_url":"https://github.com/pcraig3","followers_url":"https://api.github.com/users/pcraig3/followers","following_url":"https://api.github.com/users/pcraig3/following{/other_user}","gists_url":"https://api.github.com/users/pcraig3/gists{/gist_id}","starred_url":"https://api.github.com/users/pcraig3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcraig3/subscriptions","organizations_url":"https://api.github.com/users/pcraig3/orgs","repos_url":"https://api.github.com/users/pcraig3/repos","events_url":"https://api.github.com/users/pcraig3/events{/privacy}","received_events_url":"https://api.github.com/users/pcraig3/received_events","type":"User","site_admin":false},"body":"The diff includes some prettify formatting changes to server.js, but the only functional changes are from lines 38-45 which add a pretty minimal `/welcome` page we can use for the demo.\r\n\r\n## Screenshot\r\n\r\n<img width=\"1312\" alt=\"screen shot 2018-02-14 at 5 43 20 pm\" src=\"https://user-images.githubusercontent.com/2454380/36232534-233aac4a-11b0-11e8-8799-2b5e71650def.png\">\r\n\r\n\r\n### why add code just for demo purposes?\r\n\r\nA few reasons, I think. Other suggestions were to demo a redirect rule or a change to the API output.\r\n\r\n- demoing a redirect is less visual (ie, less impactful during a presentation)\r\n- similarly, demoing an API response change is probably less not very interesting for a non-technical person\r\n- we're agile, so it's easy for us to remove stuff we don't need\r\n\r\n","created_at":"2018-02-14T22:54:58Z","updated_at":"2018-02-14T22:54:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cds-snc/nrcan_api/pulls/165/commits","review_comments_url":"https://api.github.com/repos/cds-snc/nrcan_api/pulls/165/comments","review_comment_url":"https://api.github.com/repos/cds-snc/nrcan_api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cds-snc/nrcan_api/issues/165/comments","statuses_url":"https://api.github.com/repos/cds-snc/nrcan_api/statuses/addf32995cafc8509e0645a82e4b9daa01b64c6c","head":{"label":"cds-snc:do-a-demo","ref":"do-a-demo","sha":"addf32995cafc8509e0645a82e4b9daa01b64c6c","user":{"login":"cds-snc","id":30166251,"avatar_url":"https://avatars1.githubusercontent.com/u/30166251?v=4","gravatar_id":"","url":"https://api.github.com/users/cds-snc","html_url":"https://github.com/cds-snc","followers_url":"https://api.github.com/users/cds-snc/followers","following_url":"https://api.github.com/users/cds-snc/following{/other_user}","gists_url":"https://api.github.com/users/cds-snc/gists{/gist_id}","starred_url":"https://api.github.com/users/cds-snc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cds-snc/subscriptions","organizations_url":"https://api.github.com/users/cds-snc/orgs","repos_url":"https://api.github.com/users/cds-snc/repos","events_url":"https://api.github.com/users/cds-snc/events{/privacy}","received_events_url":"https://api.github.com/users/cds-snc/received_events","type":"Organization","site_admin":false},"repo":{"id":111843247,"name":"nrcan_api","full_name":"cds-snc/nrcan_api","owner":{"login":"cds-snc","id":30166251,"avatar_url":"https://avatars1.githubusercontent.com/u/30166251?v=4","gravatar_id":"","url":"https://api.github.com/users/cds-snc","html_url":"https://github.com/cds-snc","followers_url":"https://api.github.com/users/cds-snc/followers","following_url":"https://api.github.com/users/cds-snc/following{/other_user}","gists_url":"https://api.github.com/users/cds-snc/gists{/gist_id}","starred_url":"https://api.github.com/users/cds-snc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cds-snc/subscriptions","organizations_url":"https://api.github.com/users/cds-snc/orgs","repos_url":"https://api.github.com/users/cds-snc/repos","events_url":"https://api.github.com/users/cds-snc/events{/privacy}","received_events_url":"https://api.github.com/users/cds-snc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cds-snc/nrcan_api","description":"An API for Natural Resources Canada's Energuide data.","fork":false,"url":"https://api.github.com/repos/cds-snc/nrcan_api","forks_url":"https://api.github.com/repos/cds-snc/nrcan_api/forks","keys_url":"https://api.github.com/repos/cds-snc/nrcan_api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cds-snc/nrcan_api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cds-snc/nrcan_api/teams","hooks_url":"https://api.github.com/repos/cds-snc/nrcan_api/hooks","issue_events_url":"https://api.github.com/repos/cds-snc/nrcan_api/issues/events{/number}","events_url":"https://api.github.com/repos/cds-snc/nrcan_api/events","assignees_url":"https://api.github.com/repos/cds-snc/nrcan_api/assignees{/user}","branches_url":"https://api.github.com/repos/cds-snc/nrcan_api/branches{/branch}","tags_url":"https://api.github.com/repos/cds-snc/nrcan_api/tags","blobs_url":"https://api.github.com/repos/cds-snc/nrcan_api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cds-snc/nrcan_api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cds-snc/nrcan_api/git/refs{/sha}","trees_url":"https://api.github.com/repos/cds-snc/nrcan_api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cds-snc/nrcan_api/statuses/{sha}","languages_url":"https://api.github.com/repos/cds-snc/nrcan_api/languages","stargazers_url":"https://api.github.com/repos/cds-snc/nrcan_api/stargazers","contributors_url":"https://api.github.com/repos/cds-snc/nrcan_api/contributors","subscribers_url":"https://api.github.com/repos/cds-snc/nrcan_api/subscribers","subscription_url":"https://api.github.com/repos/cds-snc/nrcan_api/subscription","commits_url":"https://api.github.com/repos/cds-snc/nrcan_api/commits{/sha}","git_commits_url":"https://api.github.com/repos/cds-snc/nrcan_api/git/commits{/sha}","comments_url":"https://api.github.com/repos/cds-snc/nrcan_api/comments{/number}","issue_comment_url":"https://api.github.com/repos/cds-snc/nrcan_api/issues/comments{/number}","contents_url":"https://api.github.com/repos/cds-snc/nrcan_api/contents/{+path}","compare_url":"https://api.github.com/repos/cds-snc/nrcan_api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cds-snc/nrcan_api/merges","archive_url":"https://api.github.com/repos/cds-snc/nrcan_api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cds-snc/nrcan_api/downloads","issues_url":"https://api.github.com/repos/cds-snc/nrcan_api/issues{/number}","pulls_url":"https://api.github.com/repos/cds-snc/nrcan_api/pulls{/number}","milestones_url":"https://api.github.com/repos/cds-snc/nrcan_api/milestones{/number}","notifications_url":"https://api.github.com/repos/cds-snc/nrcan_api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cds-snc/nrcan_api/labels{/name}","releases_url":"https://api.github.com/repos/cds-snc/nrcan_api/releases{/id}","deployments_url":"https://api.github.com/repos/cds-snc/nrcan_api/deployments","created_at":"2017-11-23T19:19:13Z","updated_at":"2018-02-06T16:20:44Z","pushed_at":"2018-02-14T22:47:46Z","git_url":"git://github.com/cds-snc/nrcan_api.git","ssh_url":"git@github.com:cds-snc/nrcan_api.git","clone_url":"https://github.com/cds-snc/nrcan_api.git","svn_url":"https://github.com/cds-snc/nrcan_api","homepage":null,"size":967,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":6,"watchers":2,"default_branch":"master"}},"base":{"label":"cds-snc:master","ref":"master","sha":"2ea7b718843b4ef4e63cb303650b4ab5b59ed297","user":{"login":"cds-snc","id":30166251,"avatar_url":"https://avatars1.githubusercontent.com/u/30166251?v=4","gravatar_id":"","url":"https://api.github.com/users/cds-snc","html_url":"https://github.com/cds-snc","followers_url":"https://api.github.com/users/cds-snc/followers","following_url":"https://api.github.com/users/cds-snc/following{/other_user}","gists_url":"https://api.github.com/users/cds-snc/gists{/gist_id}","starred_url":"https://api.github.com/users/cds-snc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cds-snc/subscriptions","organizations_url":"https://api.github.com/users/cds-snc/orgs","repos_url":"https://api.github.com/users/cds-snc/repos","events_url":"https://api.github.com/users/cds-snc/events{/privacy}","received_events_url":"https://api.github.com/users/cds-snc/received_events","type":"Organization","site_admin":false},"repo":{"id":111843247,"name":"nrcan_api","full_name":"cds-snc/nrcan_api","owner":{"login":"cds-snc","id":30166251,"avatar_url":"https://avatars1.githubusercontent.com/u/30166251?v=4","gravatar_id":"","url":"https://api.github.com/users/cds-snc","html_url":"https://github.com/cds-snc","followers_url":"https://api.github.com/users/cds-snc/followers","following_url":"https://api.github.com/users/cds-snc/following{/other_user}","gists_url":"https://api.github.com/users/cds-snc/gists{/gist_id}","starred_url":"https://api.github.com/users/cds-snc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cds-snc/subscriptions","organizations_url":"https://api.github.com/users/cds-snc/orgs","repos_url":"https://api.github.com/users/cds-snc/repos","events_url":"https://api.github.com/users/cds-snc/events{/privacy}","received_events_url":"https://api.github.com/users/cds-snc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cds-snc/nrcan_api","description":"An API for Natural Resources Canada's Energuide data.","fork":false,"url":"https://api.github.com/repos/cds-snc/nrcan_api","forks_url":"https://api.github.com/repos/cds-snc/nrcan_api/forks","keys_url":"https://api.github.com/repos/cds-snc/nrcan_api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cds-snc/nrcan_api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cds-snc/nrcan_api/teams","hooks_url":"https://api.github.com/repos/cds-snc/nrcan_api/hooks","issue_events_url":"https://api.github.com/repos/cds-snc/nrcan_api/issues/events{/number}","events_url":"https://api.github.com/repos/cds-snc/nrcan_api/events","assignees_url":"https://api.github.com/repos/cds-snc/nrcan_api/assignees{/user}","branches_url":"https://api.github.com/repos/cds-snc/nrcan_api/branches{/branch}","tags_url":"https://api.github.com/repos/cds-snc/nrcan_api/tags","blobs_url":"https://api.github.com/repos/cds-snc/nrcan_api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cds-snc/nrcan_api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cds-snc/nrcan_api/git/refs{/sha}","trees_url":"https://api.github.com/repos/cds-snc/nrcan_api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cds-snc/nrcan_api/statuses/{sha}","languages_url":"https://api.github.com/repos/cds-snc/nrcan_api/languages","stargazers_url":"https://api.github.com/repos/cds-snc/nrcan_api/stargazers","contributors_url":"https://api.github.com/repos/cds-snc/nrcan_api/contributors","subscribers_url":"https://api.github.com/repos/cds-snc/nrcan_api/subscribers","subscription_url":"https://api.github.com/repos/cds-snc/nrcan_api/subscription","commits_url":"https://api.github.com/repos/cds-snc/nrcan_api/commits{/sha}","git_commits_url":"https://api.github.com/repos/cds-snc/nrcan_api/git/commits{/sha}","comments_url":"https://api.github.com/repos/cds-snc/nrcan_api/comments{/number}","issue_comment_url":"https://api.github.com/repos/cds-snc/nrcan_api/issues/comments{/number}","contents_url":"https://api.github.com/repos/cds-snc/nrcan_api/contents/{+path}","compare_url":"https://api.github.com/repos/cds-snc/nrcan_api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cds-snc/nrcan_api/merges","archive_url":"https://api.github.com/repos/cds-snc/nrcan_api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cds-snc/nrcan_api/downloads","issues_url":"https://api.github.com/repos/cds-snc/nrcan_api/issues{/number}","pulls_url":"https://api.github.com/repos/cds-snc/nrcan_api/pulls{/number}","milestones_url":"https://api.github.com/repos/cds-snc/nrcan_api/milestones{/number}","notifications_url":"https://api.github.com/repos/cds-snc/nrcan_api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cds-snc/nrcan_api/labels{/name}","releases_url":"https://api.github.com/repos/cds-snc/nrcan_api/releases{/id}","deployments_url":"https://api.github.com/repos/cds-snc/nrcan_api/deployments","created_at":"2017-11-23T19:19:13Z","updated_at":"2018-02-06T16:20:44Z","pushed_at":"2018-02-14T22:47:46Z","git_url":"git://github.com/cds-snc/nrcan_api.git","ssh_url":"git@github.com:cds-snc/nrcan_api.git","clone_url":"https://github.com/cds-snc/nrcan_api.git","svn_url":"https://github.com/cds-snc/nrcan_api","homepage":null,"size":967,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cds-snc/nrcan_api/pulls/165"},"html":{"href":"https://github.com/cds-snc/nrcan_api/pull/165"},"issue":{"href":"https://api.github.com/repos/cds-snc/nrcan_api/issues/165"},"comments":{"href":"https://api.github.com/repos/cds-snc/nrcan_api/issues/165/comments"},"review_comments":{"href":"https://api.github.com/repos/cds-snc/nrcan_api/pulls/165/comments"},"review_comment":{"href":"https://api.github.com/repos/cds-snc/nrcan_api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cds-snc/nrcan_api/pulls/165/commits"},"statuses":{"href":"https://api.github.com/repos/cds-snc/nrcan_api/statuses/addf32995cafc8509e0645a82e4b9daa01b64c6c"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":29,"deletions":21,"changed_files":1}}
{"actor":{"display_login":"pcraig3"}}