{"action":"closed","number":1937,"pull_request":{"url":"https://api.github.com/repos/xamarin/xamarin-android/pulls/1937","id":200074653,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMDc0NjUz","html_url":"https://github.com/xamarin/xamarin-android/pull/1937","diff_url":"https://github.com/xamarin/xamarin-android/pull/1937.diff","patch_url":"https://github.com/xamarin/xamarin-android/pull/1937.patch","issue_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/1937","number":1937,"state":"closed","locked":false,"title":"Ignore <merge> when generating code-behind source","user":{"login":"grendello","id":184788,"node_id":"MDQ6VXNlcjE4NDc4OA==","avatar_url":"https://avatars1.githubusercontent.com/u/184788?v=4","gravatar_id":"","url":"https://api.github.com/users/grendello","html_url":"https://github.com/grendello","followers_url":"https://api.github.com/users/grendello/followers","following_url":"https://api.github.com/users/grendello/following{/other_user}","gists_url":"https://api.github.com/users/grendello/gists{/gist_id}","starred_url":"https://api.github.com/users/grendello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grendello/subscriptions","organizations_url":"https://api.github.com/users/grendello/orgs","repos_url":"https://api.github.com/users/grendello/repos","events_url":"https://api.github.com/users/grendello/events{/privacy}","received_events_url":"https://api.github.com/users/grendello/received_events","type":"User","site_admin":false},"body":"Fixes: https://github.com/xamarin/xamarin-android/issues/1929\r\n\r\n`<merge>` is an element used by Android to avoid stacking too many view groups\r\nwhen one layout is included into another. In such cases `<merge>` can be used as\r\na place-holder which is replaced by the enclosing view group of the layout that\r\nincludes another layout with `<merge>` as the root element. However, as much as\r\nyou can call `FindViewById` to find an instance of `<merge>` which was given the\r\n`android:id` attribute, Android will always return `null` in such case, as the\r\nelement has no type counterpart in the `Android.Views` collection of views.\r\nTherefore, we must ignore the element whenever we process a layout that contains\r\nit decorated with `android:id` in order to avoid confusion in generated\r\ncode (i.e. the property generated for the element would be of type `merge` which\r\ndoes not exist). We could instead generate a property of type\r\n`Android.Views.View` and always return `null` from it, but that unnecessarily\r\nincreases code size - we'd be adding effectively dead code.","created_at":"2018-07-09T11:49:08Z","updated_at":"2018-07-09T15:19:35Z","closed_at":"2018-07-09T15:19:35Z","merged_at":"2018-07-09T15:19:34Z","merge_commit_sha":"26d7ff3ffdfdb0da732e927b85516803e30f8e9f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jonpryor","id":155958,"node_id":"MDQ6VXNlcjE1NTk1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/155958?v=4","gravatar_id":"","url":"https://api.github.com/users/jonpryor","html_url":"https://github.com/jonpryor","followers_url":"https://api.github.com/users/jonpryor/followers","following_url":"https://api.github.com/users/jonpryor/following{/other_user}","gists_url":"https://api.github.com/users/jonpryor/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpryor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpryor/subscriptions","organizations_url":"https://api.github.com/users/jonpryor/orgs","repos_url":"https://api.github.com/users/jonpryor/repos","events_url":"https://api.github.com/users/jonpryor/events{/privacy}","received_events_url":"https://api.github.com/users/jonpryor/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xamarin/xamarin-android/pulls/1937/commits","review_comments_url":"https://api.github.com/repos/xamarin/xamarin-android/pulls/1937/comments","review_comment_url":"https://api.github.com/repos/xamarin/xamarin-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/1937/comments","statuses_url":"https://api.github.com/repos/xamarin/xamarin-android/statuses/6fe65a8590da4bf4a4c2405ed3aedfd22415884b","head":{"label":"grendello:issue1929","ref":"issue1929","sha":"6fe65a8590da4bf4a4c2405ed3aedfd22415884b","user":{"login":"grendello","id":184788,"node_id":"MDQ6VXNlcjE4NDc4OA==","avatar_url":"https://avatars1.githubusercontent.com/u/184788?v=4","gravatar_id":"","url":"https://api.github.com/users/grendello","html_url":"https://github.com/grendello","followers_url":"https://api.github.com/users/grendello/followers","following_url":"https://api.github.com/users/grendello/following{/other_user}","gists_url":"https://api.github.com/users/grendello/gists{/gist_id}","starred_url":"https://api.github.com/users/grendello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grendello/subscriptions","organizations_url":"https://api.github.com/users/grendello/orgs","repos_url":"https://api.github.com/users/grendello/repos","events_url":"https://api.github.com/users/grendello/events{/privacy}","received_events_url":"https://api.github.com/users/grendello/received_events","type":"User","site_admin":false},"repo":{"id":58048059,"node_id":"MDEwOlJlcG9zaXRvcnk1ODA0ODA1OQ==","name":"xamarin-android","full_name":"grendello/xamarin-android","owner":{"login":"grendello","id":184788,"node_id":"MDQ6VXNlcjE4NDc4OA==","avatar_url":"https://avatars1.githubusercontent.com/u/184788?v=4","gravatar_id":"","url":"https://api.github.com/users/grendello","html_url":"https://github.com/grendello","followers_url":"https://api.github.com/users/grendello/followers","following_url":"https://api.github.com/users/grendello/following{/other_user}","gists_url":"https://api.github.com/users/grendello/gists{/gist_id}","starred_url":"https://api.github.com/users/grendello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grendello/subscriptions","organizations_url":"https://api.github.com/users/grendello/orgs","repos_url":"https://api.github.com/users/grendello/repos","events_url":"https://api.github.com/users/grendello/events{/privacy}","received_events_url":"https://api.github.com/users/grendello/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grendello/xamarin-android","description":null,"fork":true,"url":"https://api.github.com/repos/grendello/xamarin-android","forks_url":"https://api.github.com/repos/grendello/xamarin-android/forks","keys_url":"https://api.github.com/repos/grendello/xamarin-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grendello/xamarin-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grendello/xamarin-android/teams","hooks_url":"https://api.github.com/repos/grendello/xamarin-android/hooks","issue_events_url":"https://api.github.com/repos/grendello/xamarin-android/issues/events{/number}","events_url":"https://api.github.com/repos/grendello/xamarin-android/events","assignees_url":"https://api.github.com/repos/grendello/xamarin-android/assignees{/user}","branches_url":"https://api.github.com/repos/grendello/xamarin-android/branches{/branch}","tags_url":"https://api.github.com/repos/grendello/xamarin-android/tags","blobs_url":"https://api.github.com/repos/grendello/xamarin-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grendello/xamarin-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grendello/xamarin-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/grendello/xamarin-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grendello/xamarin-android/statuses/{sha}","languages_url":"https://api.github.com/repos/grendello/xamarin-android/languages","stargazers_url":"https://api.github.com/repos/grendello/xamarin-android/stargazers","contributors_url":"https://api.github.com/repos/grendello/xamarin-android/contributors","subscribers_url":"https://api.github.com/repos/grendello/xamarin-android/subscribers","subscription_url":"https://api.github.com/repos/grendello/xamarin-android/subscription","commits_url":"https://api.github.com/repos/grendello/xamarin-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/grendello/xamarin-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/grendello/xamarin-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/grendello/xamarin-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/grendello/xamarin-android/contents/{+path}","compare_url":"https://api.github.com/repos/grendello/xamarin-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grendello/xamarin-android/merges","archive_url":"https://api.github.com/repos/grendello/xamarin-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grendello/xamarin-android/downloads","issues_url":"https://api.github.com/repos/grendello/xamarin-android/issues{/number}","pulls_url":"https://api.github.com/repos/grendello/xamarin-android/pulls{/number}","milestones_url":"https://api.github.com/repos/grendello/xamarin-android/milestones{/number}","notifications_url":"https://api.github.com/repos/grendello/xamarin-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grendello/xamarin-android/labels{/name}","releases_url":"https://api.github.com/repos/grendello/xamarin-android/releases{/id}","deployments_url":"https://api.github.com/repos/grendello/xamarin-android/deployments","created_at":"2016-05-04T11:49:45Z","updated_at":"2018-03-01T17:49:36Z","pushed_at":"2018-07-09T11:48:47Z","git_url":"git://github.com/grendello/xamarin-android.git","ssh_url":"git@github.com:grendello/xamarin-android.git","clone_url":"https://github.com/grendello/xamarin-android.git","svn_url":"https://github.com/grendello/xamarin-android","homepage":null,"size":14658,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xamarin:master","ref":"master","sha":"6ce26a0db22326a0973cf24f5f0f803a29fc7295","user":{"login":"xamarin","id":790012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MDAxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":55075302,"node_id":"MDEwOlJlcG9zaXRvcnk1NTA3NTMwMg==","name":"xamarin-android","full_name":"xamarin/xamarin-android","owner":{"login":"xamarin","id":790012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MDAxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xamarin/xamarin-android","description":"Xamarin.Android provides open-source bindings of the Android SDK for use with .NET managed languages such as C#","fork":false,"url":"https://api.github.com/repos/xamarin/xamarin-android","forks_url":"https://api.github.com/repos/xamarin/xamarin-android/forks","keys_url":"https://api.github.com/repos/xamarin/xamarin-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/xamarin-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/xamarin-android/teams","hooks_url":"https://api.github.com/repos/xamarin/xamarin-android/hooks","issue_events_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/xamarin-android/events","assignees_url":"https://api.github.com/repos/xamarin/xamarin-android/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/xamarin-android/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/xamarin-android/tags","blobs_url":"https://api.github.com/repos/xamarin/xamarin-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/xamarin-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/xamarin-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/xamarin-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/xamarin-android/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/xamarin-android/languages","stargazers_url":"https://api.github.com/repos/xamarin/xamarin-android/stargazers","contributors_url":"https://api.github.com/repos/xamarin/xamarin-android/contributors","subscribers_url":"https://api.github.com/repos/xamarin/xamarin-android/subscribers","subscription_url":"https://api.github.com/repos/xamarin/xamarin-android/subscription","commits_url":"https://api.github.com/repos/xamarin/xamarin-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/xamarin-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/xamarin-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/xamarin-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/xamarin-android/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/xamarin-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/xamarin-android/merges","archive_url":"https://api.github.com/repos/xamarin/xamarin-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/xamarin-android/downloads","issues_url":"https://api.github.com/repos/xamarin/xamarin-android/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/xamarin-android/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/xamarin-android/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/xamarin-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/xamarin-android/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/xamarin-android/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/xamarin-android/deployments","created_at":"2016-03-30T15:37:14Z","updated_at":"2018-07-09T13:23:30Z","pushed_at":"2018-07-09T15:19:34Z","git_url":"git://github.com/xamarin/xamarin-android.git","ssh_url":"git@github.com:xamarin/xamarin-android.git","clone_url":"https://github.com/xamarin/xamarin-android.git","svn_url":"https://github.com/xamarin/xamarin-android","homepage":"","size":15301,"stargazers_count":982,"watchers_count":982,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":285,"mirror_url":null,"archived":false,"open_issues_count":191,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":285,"open_issues":191,"watchers":982,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xamarin/xamarin-android/pulls/1937"},"html":{"href":"https://github.com/xamarin/xamarin-android/pull/1937"},"issue":{"href":"https://api.github.com/repos/xamarin/xamarin-android/issues/1937"},"comments":{"href":"https://api.github.com/repos/xamarin/xamarin-android/issues/1937/comments"},"review_comments":{"href":"https://api.github.com/repos/xamarin/xamarin-android/pulls/1937/comments"},"review_comment":{"href":"https://api.github.com/repos/xamarin/xamarin-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xamarin/xamarin-android/pulls/1937/commits"},"statuses":{"href":"https://api.github.com/repos/xamarin/xamarin-android/statuses/6fe65a8590da4bf4a4c2405ed3aedfd22415884b"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dellis1972","id":810617,"node_id":"MDQ6VXNlcjgxMDYxNw==","avatar_url":"https://avatars3.githubusercontent.com/u/810617?v=4","gravatar_id":"","url":"https://api.github.com/users/dellis1972","html_url":"https://github.com/dellis1972","followers_url":"https://api.github.com/users/dellis1972/followers","following_url":"https://api.github.com/users/dellis1972/following{/other_user}","gists_url":"https://api.github.com/users/dellis1972/gists{/gist_id}","starred_url":"https://api.github.com/users/dellis1972/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dellis1972/subscriptions","organizations_url":"https://api.github.com/users/dellis1972/orgs","repos_url":"https://api.github.com/users/dellis1972/repos","events_url":"https://api.github.com/users/dellis1972/events{/privacy}","received_events_url":"https://api.github.com/users/dellis1972/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":112,"deletions":0,"changed_files":5}}
{"actor":{"display_login":"dellis1972"}}