{"action":"created","comment":{"url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/pulls/comments/191659843","pull_request_review_id":124270425,"id":191659843,"diff_hunk":"@@ -4,22 +4,149 @@ import com.amazonaws.services.kinesis.metrics.interfaces.MetricsLevel\n import org.springframework.boot.context.properties.ConfigurationProperties\n import javax.validation.constraints.NotNull\n \n+/**\n+ * This class defines the configuration of this library. Depending\n+ * on the actual use of the library the required configuration might\n+ * look different. Not all properties are needed in all cases. For\n+ * example, if one only wants to send messages, no consumer settings\n+ * are needed and vice versa.\n+ *\n+ * The library provides two ways of configuration:\n+ *\n+ *      (1) The first way is to configure all producers and consumers\n+ *      in the same manner. This means every producer and consumer will\n+ *      run in the same AWS account using the same IAM role. This is a\n+ *      very simple solution and should be suitable for most situations.\n+ *\n+ *      (2) However, all consumers and producers can also be configured\n+ *      individually. It's possible to provide a special configuration for\n+ *      a certain producer or consumer. This makes it possible to use a\n+ *      special AWS account or IAM role for each of those.\n+ *\n+ * Examples:\n+ *\n+ *      - See \"application-consumer.yml\" for a minimal configuration for\n+ *        a dedicated consumer.\n+ *\n+ *      - See \"application-producer.yml\" for a minimal configuration for\n+ *        a dedicated producer.\n+ *\n+ *      - See \"application-minimal.yml\" for a minimal configuration which\n+ *        will allow to start the library, but don't send or receive any\n+ *        message.\n+ *\n+ *      - See \"application-kinesis-local.yml\" for a minimal configuration\n+ *        which allows to send and receive messages.\n+ */\n @ConfigurationProperties(prefix = \"aws.kinesis\")\n class AwsKinesisSettings {\n \n-    var region = \"eu-central-1\"\n-    var kinesisUrl = \"https://kinesis.eu-central-1.amazonaws.com\"\n-\n-    lateinit var consumerGroup: String\n+    /**\n+     * Example: eu-central-1, local\n+     */\n+    @NotNull\n+    var region: String? = null","path":"src/main/kotlin/de/bringmeister/spring/aws/kinesis/AwsKinesisSettings.kt","position":49,"original_position":49,"commit_id":"0a228380efcbb904601ac99e60a164a95067b6dc","original_commit_id":"0a228380efcbb904601ac99e60a164a95067b6dc","user":{"login":"jmatusewicz","id":32563705,"avatar_url":"https://avatars2.githubusercontent.com/u/32563705?v=4","gravatar_id":"","url":"https://api.github.com/users/jmatusewicz","html_url":"https://github.com/jmatusewicz","followers_url":"https://api.github.com/users/jmatusewicz/followers","following_url":"https://api.github.com/users/jmatusewicz/following{/other_user}","gists_url":"https://api.github.com/users/jmatusewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/jmatusewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmatusewicz/subscriptions","organizations_url":"https://api.github.com/users/jmatusewicz/orgs","repos_url":"https://api.github.com/users/jmatusewicz/repos","events_url":"https://api.github.com/users/jmatusewicz/events{/privacy}","received_events_url":"https://api.github.com/users/jmatusewicz/received_events","type":"User","site_admin":false},"body":"why defining an nullable type, assigning null and then annotating it with `@NotNull`? \r\nWhat about `lateinit var region: String` ? ","created_at":"2018-05-30T07:00:41Z","updated_at":"2018-05-30T07:00:41Z","html_url":"https://github.com/bringmeister/aws-kinesis-spring-boot-starter/pull/29#discussion_r191659843","pull_request_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/pulls/29","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/pulls/comments/191659843"},"html":{"href":"https://github.com/bringmeister/aws-kinesis-spring-boot-starter/pull/29#discussion_r191659843"},"pull_request":{"href":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/pulls/29","id":191177377,"html_url":"https://github.com/bringmeister/aws-kinesis-spring-boot-starter/pull/29","diff_url":"https://github.com/bringmeister/aws-kinesis-spring-boot-starter/pull/29.diff","patch_url":"https://github.com/bringmeister/aws-kinesis-spring-boot-starter/pull/29.patch","issue_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/issues/29","number":29,"state":"open","locked":false,"title":"Provide possibility to use a default config","user":{"login":"tuhrig","id":5120537,"avatar_url":"https://avatars0.githubusercontent.com/u/5120537?v=4","gravatar_id":"","url":"https://api.github.com/users/tuhrig","html_url":"https://github.com/tuhrig","followers_url":"https://api.github.com/users/tuhrig/followers","following_url":"https://api.github.com/users/tuhrig/following{/other_user}","gists_url":"https://api.github.com/users/tuhrig/gists{/gist_id}","starred_url":"https://api.github.com/users/tuhrig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuhrig/subscriptions","organizations_url":"https://api.github.com/users/tuhrig/orgs","repos_url":"https://api.github.com/users/tuhrig/repos","events_url":"https://api.github.com/users/tuhrig/events{/privacy}","received_events_url":"https://api.github.com/users/tuhrig/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-29T15:03:37Z","updated_at":"2018-05-30T07:00:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eecc370c202cf5ca101126d7d46bc3b4496c64e1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/pulls/29/commits","review_comments_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/pulls/29/comments","review_comment_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/issues/29/comments","statuses_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/statuses/0a228380efcbb904601ac99e60a164a95067b6dc","head":{"label":"bringmeister:default-config","ref":"default-config","sha":"0a228380efcbb904601ac99e60a164a95067b6dc","user":{"login":"bringmeister","id":7767821,"avatar_url":"https://avatars2.githubusercontent.com/u/7767821?v=4","gravatar_id":"","url":"https://api.github.com/users/bringmeister","html_url":"https://github.com/bringmeister","followers_url":"https://api.github.com/users/bringmeister/followers","following_url":"https://api.github.com/users/bringmeister/following{/other_user}","gists_url":"https://api.github.com/users/bringmeister/gists{/gist_id}","starred_url":"https://api.github.com/users/bringmeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bringmeister/subscriptions","organizations_url":"https://api.github.com/users/bringmeister/orgs","repos_url":"https://api.github.com/users/bringmeister/repos","events_url":"https://api.github.com/users/bringmeister/events{/privacy}","received_events_url":"https://api.github.com/users/bringmeister/received_events","type":"Organization","site_admin":false},"repo":{"id":125221797,"name":"aws-kinesis-spring-boot-starter","full_name":"bringmeister/aws-kinesis-spring-boot-starter","owner":{"login":"bringmeister","id":7767821,"avatar_url":"https://avatars2.githubusercontent.com/u/7767821?v=4","gravatar_id":"","url":"https://api.github.com/users/bringmeister","html_url":"https://github.com/bringmeister","followers_url":"https://api.github.com/users/bringmeister/followers","following_url":"https://api.github.com/users/bringmeister/following{/other_user}","gists_url":"https://api.github.com/users/bringmeister/gists{/gist_id}","starred_url":"https://api.github.com/users/bringmeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bringmeister/subscriptions","organizations_url":"https://api.github.com/users/bringmeister/orgs","repos_url":"https://api.github.com/users/bringmeister/repos","events_url":"https://api.github.com/users/bringmeister/events{/privacy}","received_events_url":"https://api.github.com/users/bringmeister/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bringmeister/aws-kinesis-spring-boot-starter","description":null,"fork":false,"url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter","forks_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/forks","keys_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/teams","hooks_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/hooks","issue_events_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/issues/events{/number}","events_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/events","assignees_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/assignees{/user}","branches_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/branches{/branch}","tags_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/tags","blobs_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/git/refs{/sha}","trees_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/statuses/{sha}","languages_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/languages","stargazers_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/stargazers","contributors_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/contributors","subscribers_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/subscribers","subscription_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/subscription","commits_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/commits{/sha}","git_commits_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/git/commits{/sha}","comments_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/comments{/number}","issue_comment_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/issues/comments{/number}","contents_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/contents/{+path}","compare_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/merges","archive_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/downloads","issues_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/issues{/number}","pulls_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/pulls{/number}","milestones_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/milestones{/number}","notifications_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/labels{/name}","releases_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/releases{/id}","deployments_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/deployments","created_at":"2018-03-14T14:03:36Z","updated_at":"2018-05-23T15:24:31Z","pushed_at":"2018-05-29T15:35:17Z","git_url":"git://github.com/bringmeister/aws-kinesis-spring-boot-starter.git","ssh_url":"git@github.com:bringmeister/aws-kinesis-spring-boot-starter.git","clone_url":"https://github.com/bringmeister/aws-kinesis-spring-boot-starter.git","svn_url":"https://github.com/bringmeister/aws-kinesis-spring-boot-starter","homepage":null,"size":200,"stargazers_count":5,"watchers_count":5,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":3,"watchers":5,"default_branch":"master"}},"base":{"label":"bringmeister:master","ref":"master","sha":"6131407b1ce25f72cad457e6709332d002b263a7","user":{"login":"bringmeister","id":7767821,"avatar_url":"https://avatars2.githubusercontent.com/u/7767821?v=4","gravatar_id":"","url":"https://api.github.com/users/bringmeister","html_url":"https://github.com/bringmeister","followers_url":"https://api.github.com/users/bringmeister/followers","following_url":"https://api.github.com/users/bringmeister/following{/other_user}","gists_url":"https://api.github.com/users/bringmeister/gists{/gist_id}","starred_url":"https://api.github.com/users/bringmeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bringmeister/subscriptions","organizations_url":"https://api.github.com/users/bringmeister/orgs","repos_url":"https://api.github.com/users/bringmeister/repos","events_url":"https://api.github.com/users/bringmeister/events{/privacy}","received_events_url":"https://api.github.com/users/bringmeister/received_events","type":"Organization","site_admin":false},"repo":{"id":125221797,"name":"aws-kinesis-spring-boot-starter","full_name":"bringmeister/aws-kinesis-spring-boot-starter","owner":{"login":"bringmeister","id":7767821,"avatar_url":"https://avatars2.githubusercontent.com/u/7767821?v=4","gravatar_id":"","url":"https://api.github.com/users/bringmeister","html_url":"https://github.com/bringmeister","followers_url":"https://api.github.com/users/bringmeister/followers","following_url":"https://api.github.com/users/bringmeister/following{/other_user}","gists_url":"https://api.github.com/users/bringmeister/gists{/gist_id}","starred_url":"https://api.github.com/users/bringmeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bringmeister/subscriptions","organizations_url":"https://api.github.com/users/bringmeister/orgs","repos_url":"https://api.github.com/users/bringmeister/repos","events_url":"https://api.github.com/users/bringmeister/events{/privacy}","received_events_url":"https://api.github.com/users/bringmeister/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bringmeister/aws-kinesis-spring-boot-starter","description":null,"fork":false,"url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter","forks_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/forks","keys_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/teams","hooks_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/hooks","issue_events_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/issues/events{/number}","events_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/events","assignees_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/assignees{/user}","branches_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/branches{/branch}","tags_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/tags","blobs_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/git/refs{/sha}","trees_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/statuses/{sha}","languages_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/languages","stargazers_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/stargazers","contributors_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/contributors","subscribers_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/subscribers","subscription_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/subscription","commits_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/commits{/sha}","git_commits_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/git/commits{/sha}","comments_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/comments{/number}","issue_comment_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/issues/comments{/number}","contents_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/contents/{+path}","compare_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/merges","archive_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/downloads","issues_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/issues{/number}","pulls_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/pulls{/number}","milestones_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/milestones{/number}","notifications_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/labels{/name}","releases_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/releases{/id}","deployments_url":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/deployments","created_at":"2018-03-14T14:03:36Z","updated_at":"2018-05-23T15:24:31Z","pushed_at":"2018-05-29T15:35:17Z","git_url":"git://github.com/bringmeister/aws-kinesis-spring-boot-starter.git","ssh_url":"git@github.com:bringmeister/aws-kinesis-spring-boot-starter.git","clone_url":"https://github.com/bringmeister/aws-kinesis-spring-boot-starter.git","svn_url":"https://github.com/bringmeister/aws-kinesis-spring-boot-starter","homepage":null,"size":200,"stargazers_count":5,"watchers_count":5,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/pulls/29"},"html":{"href":"https://github.com/bringmeister/aws-kinesis-spring-boot-starter/pull/29"},"issue":{"href":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/issues/29"},"comments":{"href":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/bringmeister/aws-kinesis-spring-boot-starter/statuses/0a228380efcbb904601ac99e60a164a95067b6dc"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jmatusewicz"}}