{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/165834292","pull_request_review_id":93835824,"id":165834292,"diff_hunk":"@@ -214,6 +226,7 @@ protected KinesisDataFetcher(List<String> streams,\n \t\tthis.totalNumberOfConsumerSubtasks = runtimeContext.getNumberOfParallelSubtasks();\n \t\tthis.indexOfThisConsumerSubtask = runtimeContext.getIndexOfThisSubtask();\n \t\tthis.deserializationSchema = checkNotNull(deserializationSchema);\n+\t\tthis.shardAssigner = checkNotNull(shardAssigner);","path":"flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java","position":59,"original_position":59,"commit_id":"a0b9f8746de3575b1feea19e685718dbcf01d705","original_commit_id":"a0b9f8746de3575b1feea19e685718dbcf01d705","user":{"login":"tweise","id":263695,"avatar_url":"https://avatars1.githubusercontent.com/u/263695?v=4","gravatar_id":"","url":"https://api.github.com/users/tweise","html_url":"https://github.com/tweise","followers_url":"https://api.github.com/users/tweise/followers","following_url":"https://api.github.com/users/tweise/following{/other_user}","gists_url":"https://api.github.com/users/tweise/gists{/gist_id}","starred_url":"https://api.github.com/users/tweise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweise/subscriptions","organizations_url":"https://api.github.com/users/tweise/orgs","repos_url":"https://api.github.com/users/tweise/repos","events_url":"https://api.github.com/users/tweise/events{/privacy}","received_events_url":"https://api.github.com/users/tweise/received_events","type":"User","site_admin":false},"body":"adding this in FlinkKinesisConsumer","created_at":"2018-02-04T05:36:06Z","updated_at":"2018-02-04T05:36:06Z","html_url":"https://github.com/apache/flink/pull/5393#discussion_r165834292","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/5393","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/165834292"},"html":{"href":"https://github.com/apache/flink/pull/5393#discussion_r165834292"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/5393"}},"in_reply_to_id":165586994},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/5393","id":166146469,"html_url":"https://github.com/apache/flink/pull/5393","diff_url":"https://github.com/apache/flink/pull/5393.diff","patch_url":"https://github.com/apache/flink/pull/5393.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/5393","number":5393,"state":"open","locked":false,"title":"[FLINK-8516] Allow for custom hash function for shard to subtask mapping in Kinesis consumer","user":{"login":"tweise","id":263695,"avatar_url":"https://avatars1.githubusercontent.com/u/263695?v=4","gravatar_id":"","url":"https://api.github.com/users/tweise","html_url":"https://github.com/tweise","followers_url":"https://api.github.com/users/tweise/followers","following_url":"https://api.github.com/users/tweise/following{/other_user}","gists_url":"https://api.github.com/users/tweise/gists{/gist_id}","starred_url":"https://api.github.com/users/tweise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweise/subscriptions","organizations_url":"https://api.github.com/users/tweise/orgs","repos_url":"https://api.github.com/users/tweise/repos","events_url":"https://api.github.com/users/tweise/events{/privacy}","received_events_url":"https://api.github.com/users/tweise/received_events","type":"User","site_admin":false},"body":"## What is the purpose of the change\r\n\r\nAllow the user to customize Kinesis shard to subtask assignment in the Kinesis consumer.\r\n\r\n## Brief change log\r\n\r\nAdded pluggable shard assigner.\r\n\r\n## Verifying this change\r\n\r\nAdded unit test. \r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n  - Dependencies (does it add or upgrade a dependency): (no)\r\n  - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)\r\n  - The serializers: (no)\r\n  - The runtime per-record code paths (performance sensitive): (no)\r\n  - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)\r\n  - The S3 file system connector: (no)\r\n\r\n## Documentation\r\n\r\nJavadoc","created_at":"2018-01-31T01:48:40Z","updated_at":"2018-02-04T05:36:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82f2e95f16c762bd99ddf6449d877890a1aaeb83","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/5393/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/5393/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/5393/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/a0b9f8746de3575b1feea19e685718dbcf01d705","head":{"label":"tweise:FLINK-8516.shardHashing","ref":"FLINK-8516.shardHashing","sha":"a0b9f8746de3575b1feea19e685718dbcf01d705","user":{"login":"tweise","id":263695,"avatar_url":"https://avatars1.githubusercontent.com/u/263695?v=4","gravatar_id":"","url":"https://api.github.com/users/tweise","html_url":"https://github.com/tweise","followers_url":"https://api.github.com/users/tweise/followers","following_url":"https://api.github.com/users/tweise/following{/other_user}","gists_url":"https://api.github.com/users/tweise/gists{/gist_id}","starred_url":"https://api.github.com/users/tweise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweise/subscriptions","organizations_url":"https://api.github.com/users/tweise/orgs","repos_url":"https://api.github.com/users/tweise/repos","events_url":"https://api.github.com/users/tweise/events{/privacy}","received_events_url":"https://api.github.com/users/tweise/received_events","type":"User","site_admin":false},"repo":{"id":118981569,"name":"flink","full_name":"tweise/flink","owner":{"login":"tweise","id":263695,"avatar_url":"https://avatars1.githubusercontent.com/u/263695?v=4","gravatar_id":"","url":"https://api.github.com/users/tweise","html_url":"https://github.com/tweise","followers_url":"https://api.github.com/users/tweise/followers","following_url":"https://api.github.com/users/tweise/following{/other_user}","gists_url":"https://api.github.com/users/tweise/gists{/gist_id}","starred_url":"https://api.github.com/users/tweise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tweise/subscriptions","organizations_url":"https://api.github.com/users/tweise/orgs","repos_url":"https://api.github.com/users/tweise/repos","events_url":"https://api.github.com/users/tweise/events{/privacy}","received_events_url":"https://api.github.com/users/tweise/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tweise/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/tweise/flink","forks_url":"https://api.github.com/repos/tweise/flink/forks","keys_url":"https://api.github.com/repos/tweise/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tweise/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tweise/flink/teams","hooks_url":"https://api.github.com/repos/tweise/flink/hooks","issue_events_url":"https://api.github.com/repos/tweise/flink/issues/events{/number}","events_url":"https://api.github.com/repos/tweise/flink/events","assignees_url":"https://api.github.com/repos/tweise/flink/assignees{/user}","branches_url":"https://api.github.com/repos/tweise/flink/branches{/branch}","tags_url":"https://api.github.com/repos/tweise/flink/tags","blobs_url":"https://api.github.com/repos/tweise/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tweise/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tweise/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/tweise/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tweise/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/tweise/flink/languages","stargazers_url":"https://api.github.com/repos/tweise/flink/stargazers","contributors_url":"https://api.github.com/repos/tweise/flink/contributors","subscribers_url":"https://api.github.com/repos/tweise/flink/subscribers","subscription_url":"https://api.github.com/repos/tweise/flink/subscription","commits_url":"https://api.github.com/repos/tweise/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/tweise/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/tweise/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/tweise/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/tweise/flink/contents/{+path}","compare_url":"https://api.github.com/repos/tweise/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tweise/flink/merges","archive_url":"https://api.github.com/repos/tweise/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tweise/flink/downloads","issues_url":"https://api.github.com/repos/tweise/flink/issues{/number}","pulls_url":"https://api.github.com/repos/tweise/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/tweise/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/tweise/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tweise/flink/labels{/name}","releases_url":"https://api.github.com/repos/tweise/flink/releases{/id}","deployments_url":"https://api.github.com/repos/tweise/flink/deployments","created_at":"2018-01-25T23:53:05Z","updated_at":"2018-01-25T23:53:30Z","pushed_at":"2018-02-02T06:27:24Z","git_url":"git://github.com/tweise/flink.git","ssh_url":"git@github.com:tweise/flink.git","clone_url":"https://github.com/tweise/flink.git","svn_url":"https://github.com/tweise/flink","homepage":null,"size":144205,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"31e97e57ceeaf37264ab6db078552b73ee5121bf","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2018-02-04T05:21:22Z","pushed_at":"2018-02-03T13:13:19Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":144897,"stargazers_count":3240,"watchers_count":3240,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2225,"mirror_url":null,"archived":false,"open_issues_count":320,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2225,"open_issues":320,"watchers":3240,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/5393"},"html":{"href":"https://github.com/apache/flink/pull/5393"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/5393"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/5393/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/5393/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/5393/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/a0b9f8746de3575b1feea19e685718dbcf01d705"}},"author_association":"NONE"}}
{"actor":{"display_login":"tweise"}}