{"action":"created","comment":{"url":"https://api.github.com/repos/projecttacoma/bonnie/pulls/comments/196415467","pull_request_review_id":129961457,"id":196415467,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjQxNTQ2Nw==","diff_hunk":"@@ -60,7 +60,8 @@ def create\n \n     measure_details = {\n      'type'=>params[:measure_type],\n-     'episode_of_care'=>params[:calculation_type] == 'episode'\n+     'episode_of_care'=>params[:calculation_type] == 'episode',\n+     'calculate_sdes'=>params[:sde_calc]","path":"app/controllers/measures_controller.rb","position":6,"original_position":6,"commit_id":"368b4dd0203bbb8e9a366e6be70fc8ed398f93a8","original_commit_id":"368b4dd0203bbb8e9a366e6be70fc8ed398f93a8","user":{"login":"jbradl11","id":1568999,"node_id":"MDQ6VXNlcjE1Njg5OTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1568999?v=4","gravatar_id":"","url":"https://api.github.com/users/jbradl11","html_url":"https://github.com/jbradl11","followers_url":"https://api.github.com/users/jbradl11/followers","following_url":"https://api.github.com/users/jbradl11/following{/other_user}","gists_url":"https://api.github.com/users/jbradl11/gists{/gist_id}","starred_url":"https://api.github.com/users/jbradl11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbradl11/subscriptions","organizations_url":"https://api.github.com/users/jbradl11/orgs","repos_url":"https://api.github.com/users/jbradl11/repos","events_url":"https://api.github.com/users/jbradl11/events{/privacy}","received_events_url":"https://api.github.com/users/jbradl11/received_events","type":"User","site_admin":false},"body":"Seems like everywhere else you are using variables named \"calcSDEs\" or \"calculate_sdes\" its not a priority but I would suggest changing this to `:calc_sde`","created_at":"2018-06-19T13:07:34Z","updated_at":"2018-06-19T13:07:35Z","html_url":"https://github.com/projecttacoma/bonnie/pull/1013#discussion_r196415467","pull_request_url":"https://api.github.com/repos/projecttacoma/bonnie/pulls/1013","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/projecttacoma/bonnie/pulls/comments/196415467"},"html":{"href":"https://github.com/projecttacoma/bonnie/pull/1013#discussion_r196415467"},"pull_request":{"href":"https://api.github.com/repos/projecttacoma/bonnie/pulls/1013"}}},"pull_request":{"url":"https://api.github.com/repos/projecttacoma/bonnie/pulls/1013","id":194721072,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NzIxMDcy","html_url":"https://github.com/projecttacoma/bonnie/pull/1013","diff_url":"https://github.com/projecttacoma/bonnie/pull/1013.diff","patch_url":"https://github.com/projecttacoma/bonnie/pull/1013.patch","issue_url":"https://api.github.com/repos/projecttacoma/bonnie/issues/1013","number":1013,"state":"open","locked":false,"title":"BONNIE-1455: hybrid measure support to display SDE","user":{"login":"c-monkey","id":22219041,"node_id":"MDQ6VXNlcjIyMjE5MDQx","avatar_url":"https://avatars1.githubusercontent.com/u/22219041?v=4","gravatar_id":"","url":"https://api.github.com/users/c-monkey","html_url":"https://github.com/c-monkey","followers_url":"https://api.github.com/users/c-monkey/followers","following_url":"https://api.github.com/users/c-monkey/following{/other_user}","gists_url":"https://api.github.com/users/c-monkey/gists{/gist_id}","starred_url":"https://api.github.com/users/c-monkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-monkey/subscriptions","organizations_url":"https://api.github.com/users/c-monkey/orgs","repos_url":"https://api.github.com/users/c-monkey/repos","events_url":"https://api.github.com/users/c-monkey/events{/privacy}","received_events_url":"https://api.github.com/users/c-monkey/received_events","type":"User","site_admin":false},"body":"Do not display any SDEs unless measure is specified as hybrid at upload. Otherwise, display all SDEs. This PR also tests the bonnie_bundler change that added the hybrid field: https://github.com/projecttacoma/bonnie_bundler/pull/148\r\n\r\nPull requests into Bonnie require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable (\"N/A\") and :white_check_mark:.\r\n\r\n------\r\n- [ ] **Need to update fixture `CMS529v0` on bonnie.healthit.gov** which can't be added until PR deployed. Then re-export and update fixture in this PR. Use the new version of the Lookback measure in BONNIE-1408: (https://jira.mitre.org/secure/attachment/27515/CCDELookback_v5_4_Artifacts%20%2813%29.zip)\r\n------\r\n\r\n**Submitter:**\r\n- [X] This pull request describes why these changes were made.\r\n- [X] This PR is into the correct branch.\r\n- [X] JIRA ticket for this PR: https://jira.mitre.org/browse/BONNIE-1455\r\n- [x] JIRA ticket links to this PR\r\n- [X] Code diff has been done and been reviewed (it **does not** contain: additional white space, not applicable code changes, debug statements, etc.)\r\n- [X] If UI changes have been made, google WAVE plug-in has been executed to ensure no 508 issues were introduced.\r\n- [X] Tests are included and test edge cases\r\n- [X] Tests have been run locally and pass (remember to update Gemfile when applicable)\r\n- [X] Test fixtures updated and documented as necessary ( see [internal wiki](https://gitlab.mitre.org/bonnie/internal-documentation/wikis/testing#test-fixtures) )\r\n- [X] Code coverage has not gone down and all code touched or added is covered. \r\n     * In rare situations, this may not be possible or applicable to a PR. In those situations:\r\n         1. Note why this could not be done or is not applicable here: \r\n         2. Add TODOs in the code noting that it requires a test\r\n         3. Add a JIRA task to add the test and link it here: \r\n\r\nBranch | Back End Coverage | Front End Coverage\r\n-- | -- | --\r\nbonnie-v2.2 | 1738 / 1950 LOC (89.13%) | Statements   : 58.94% (7134/12104)<br>Branches     : 42.79% ( 1935/4522 )<br>Functions    : 49.19% ( 1178/2395 )<br>Lines        : 56.81% ( 6408/11279 )\r\nbonnie_1454_1455_hybrid_SDE | 1739 / 1951 LOC (89.13%) | Statements   : 58.97% (7138/12104)<br>Branches     : 43.06% ( 1947/4522 )<br>Functions    : 49.21% ( 1178/2394 )<br>Lines        : 56.85% ( 6412/11279 )\r\n\r\n- [X] Automated regression test(s) pass\r\n    * No measures with differences\r\n    * Several measures had covered clauses now uncovered (SDE Ethnicity, Race, Sex, and Payer):\r\n        * rachel@oregonurology.com - CMS771v1\r\n        * epecqmmpr@gmail.com - CMS460v0\r\n        * hmdmnewmeasures@gmail.com - CMS812v2\r\n        * hmdmtjc2@gmail.com - CMS334v1 and CMS334v1\r\n\r\nIf JIRA tests were used to supplement or replace automated tests:\r\n- [X] JIRA test links: N/A\r\n- [X] Justification for using JIRA tests: N/A\r\n- [X] JIRA tests have been added to sprint N/A\r\n\r\n\r\n**Reviewer 1:**\r\n\r\nName: @mayerm94 \r\n- [ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose\r\n- [ ] The tests appropriately test the new code, including edge cases\r\n- [ ] You have tried to break the code\r\n\r\nIf JIRA tests were used to supplement or replace automated tests:\r\n- [X] JIRA tests have been run and pass N/A\r\n- [X] You agree with the justification for use of JIRA tests or have provided input on why you disagree N/A\r\n\r\n\r\n**Reviewer 2:**\r\n\r\nName: @jbradl11 \r\n- [ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose\r\n- [ ] The tests appropriately test the new code, including edge cases\r\n- [ ] You have tried to break the code\r\n\r\nIf JIRA tests were used to supplement or replace automated tests:\r\n- [X] JIRA tests have been run and pass N/A\r\n- [X] You agree with the justification for use of JIRA tests or have provided input on why you disagree N/A\r\n","created_at":"2018-06-13T21:30:57Z","updated_at":"2018-06-19T13:07:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72a643ab14810c8d1e761b0e5c1fced0ae0dcf89","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/projecttacoma/bonnie/pulls/1013/commits","review_comments_url":"https://api.github.com/repos/projecttacoma/bonnie/pulls/1013/comments","review_comment_url":"https://api.github.com/repos/projecttacoma/bonnie/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projecttacoma/bonnie/issues/1013/comments","statuses_url":"https://api.github.com/repos/projecttacoma/bonnie/statuses/368b4dd0203bbb8e9a366e6be70fc8ed398f93a8","head":{"label":"projecttacoma:bonnie_1454_1455_hybrid_SDE","ref":"bonnie_1454_1455_hybrid_SDE","sha":"368b4dd0203bbb8e9a366e6be70fc8ed398f93a8","user":{"login":"projecttacoma","id":5497023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0OTcwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/5497023?v=4","gravatar_id":"","url":"https://api.github.com/users/projecttacoma","html_url":"https://github.com/projecttacoma","followers_url":"https://api.github.com/users/projecttacoma/followers","following_url":"https://api.github.com/users/projecttacoma/following{/other_user}","gists_url":"https://api.github.com/users/projecttacoma/gists{/gist_id}","starred_url":"https://api.github.com/users/projecttacoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecttacoma/subscriptions","organizations_url":"https://api.github.com/users/projecttacoma/orgs","repos_url":"https://api.github.com/users/projecttacoma/repos","events_url":"https://api.github.com/users/projecttacoma/events{/privacy}","received_events_url":"https://api.github.com/users/projecttacoma/received_events","type":"Organization","site_admin":false},"repo":{"id":12958279,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk1ODI3OQ==","name":"bonnie","full_name":"projecttacoma/bonnie","owner":{"login":"projecttacoma","id":5497023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0OTcwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/5497023?v=4","gravatar_id":"","url":"https://api.github.com/users/projecttacoma","html_url":"https://github.com/projecttacoma","followers_url":"https://api.github.com/users/projecttacoma/followers","following_url":"https://api.github.com/users/projecttacoma/following{/other_user}","gists_url":"https://api.github.com/users/projecttacoma/gists{/gist_id}","starred_url":"https://api.github.com/users/projecttacoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecttacoma/subscriptions","organizations_url":"https://api.github.com/users/projecttacoma/orgs","repos_url":"https://api.github.com/users/projecttacoma/repos","events_url":"https://api.github.com/users/projecttacoma/events{/privacy}","received_events_url":"https://api.github.com/users/projecttacoma/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecttacoma/bonnie","description":"Clinical Quality Measure Testing Tool","fork":false,"url":"https://api.github.com/repos/projecttacoma/bonnie","forks_url":"https://api.github.com/repos/projecttacoma/bonnie/forks","keys_url":"https://api.github.com/repos/projecttacoma/bonnie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecttacoma/bonnie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecttacoma/bonnie/teams","hooks_url":"https://api.github.com/repos/projecttacoma/bonnie/hooks","issue_events_url":"https://api.github.com/repos/projecttacoma/bonnie/issues/events{/number}","events_url":"https://api.github.com/repos/projecttacoma/bonnie/events","assignees_url":"https://api.github.com/repos/projecttacoma/bonnie/assignees{/user}","branches_url":"https://api.github.com/repos/projecttacoma/bonnie/branches{/branch}","tags_url":"https://api.github.com/repos/projecttacoma/bonnie/tags","blobs_url":"https://api.github.com/repos/projecttacoma/bonnie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecttacoma/bonnie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecttacoma/bonnie/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecttacoma/bonnie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecttacoma/bonnie/statuses/{sha}","languages_url":"https://api.github.com/repos/projecttacoma/bonnie/languages","stargazers_url":"https://api.github.com/repos/projecttacoma/bonnie/stargazers","contributors_url":"https://api.github.com/repos/projecttacoma/bonnie/contributors","subscribers_url":"https://api.github.com/repos/projecttacoma/bonnie/subscribers","subscription_url":"https://api.github.com/repos/projecttacoma/bonnie/subscription","commits_url":"https://api.github.com/repos/projecttacoma/bonnie/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecttacoma/bonnie/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecttacoma/bonnie/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecttacoma/bonnie/issues/comments{/number}","contents_url":"https://api.github.com/repos/projecttacoma/bonnie/contents/{+path}","compare_url":"https://api.github.com/repos/projecttacoma/bonnie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecttacoma/bonnie/merges","archive_url":"https://api.github.com/repos/projecttacoma/bonnie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecttacoma/bonnie/downloads","issues_url":"https://api.github.com/repos/projecttacoma/bonnie/issues{/number}","pulls_url":"https://api.github.com/repos/projecttacoma/bonnie/pulls{/number}","milestones_url":"https://api.github.com/repos/projecttacoma/bonnie/milestones{/number}","notifications_url":"https://api.github.com/repos/projecttacoma/bonnie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecttacoma/bonnie/labels{/name}","releases_url":"https://api.github.com/repos/projecttacoma/bonnie/releases{/id}","deployments_url":"https://api.github.com/repos/projecttacoma/bonnie/deployments","created_at":"2013-09-19T20:11:14Z","updated_at":"2018-06-14T17:55:33Z","pushed_at":"2018-06-18T21:54:59Z","git_url":"git://github.com/projecttacoma/bonnie.git","ssh_url":"git@github.com:projecttacoma/bonnie.git","clone_url":"https://github.com/projecttacoma/bonnie.git","svn_url":"https://github.com/projecttacoma/bonnie","homepage":null,"size":108620,"stargazers_count":21,"watchers_count":21,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":19,"open_issues":11,"watchers":21,"default_branch":"master"}},"base":{"label":"projecttacoma:bonnie-v2.2","ref":"bonnie-v2.2","sha":"e37d9bfba4224c79c344832f554f21c06736ee3e","user":{"login":"projecttacoma","id":5497023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0OTcwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/5497023?v=4","gravatar_id":"","url":"https://api.github.com/users/projecttacoma","html_url":"https://github.com/projecttacoma","followers_url":"https://api.github.com/users/projecttacoma/followers","following_url":"https://api.github.com/users/projecttacoma/following{/other_user}","gists_url":"https://api.github.com/users/projecttacoma/gists{/gist_id}","starred_url":"https://api.github.com/users/projecttacoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecttacoma/subscriptions","organizations_url":"https://api.github.com/users/projecttacoma/orgs","repos_url":"https://api.github.com/users/projecttacoma/repos","events_url":"https://api.github.com/users/projecttacoma/events{/privacy}","received_events_url":"https://api.github.com/users/projecttacoma/received_events","type":"Organization","site_admin":false},"repo":{"id":12958279,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk1ODI3OQ==","name":"bonnie","full_name":"projecttacoma/bonnie","owner":{"login":"projecttacoma","id":5497023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0OTcwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/5497023?v=4","gravatar_id":"","url":"https://api.github.com/users/projecttacoma","html_url":"https://github.com/projecttacoma","followers_url":"https://api.github.com/users/projecttacoma/followers","following_url":"https://api.github.com/users/projecttacoma/following{/other_user}","gists_url":"https://api.github.com/users/projecttacoma/gists{/gist_id}","starred_url":"https://api.github.com/users/projecttacoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projecttacoma/subscriptions","organizations_url":"https://api.github.com/users/projecttacoma/orgs","repos_url":"https://api.github.com/users/projecttacoma/repos","events_url":"https://api.github.com/users/projecttacoma/events{/privacy}","received_events_url":"https://api.github.com/users/projecttacoma/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projecttacoma/bonnie","description":"Clinical Quality Measure Testing Tool","fork":false,"url":"https://api.github.com/repos/projecttacoma/bonnie","forks_url":"https://api.github.com/repos/projecttacoma/bonnie/forks","keys_url":"https://api.github.com/repos/projecttacoma/bonnie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projecttacoma/bonnie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projecttacoma/bonnie/teams","hooks_url":"https://api.github.com/repos/projecttacoma/bonnie/hooks","issue_events_url":"https://api.github.com/repos/projecttacoma/bonnie/issues/events{/number}","events_url":"https://api.github.com/repos/projecttacoma/bonnie/events","assignees_url":"https://api.github.com/repos/projecttacoma/bonnie/assignees{/user}","branches_url":"https://api.github.com/repos/projecttacoma/bonnie/branches{/branch}","tags_url":"https://api.github.com/repos/projecttacoma/bonnie/tags","blobs_url":"https://api.github.com/repos/projecttacoma/bonnie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projecttacoma/bonnie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projecttacoma/bonnie/git/refs{/sha}","trees_url":"https://api.github.com/repos/projecttacoma/bonnie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projecttacoma/bonnie/statuses/{sha}","languages_url":"https://api.github.com/repos/projecttacoma/bonnie/languages","stargazers_url":"https://api.github.com/repos/projecttacoma/bonnie/stargazers","contributors_url":"https://api.github.com/repos/projecttacoma/bonnie/contributors","subscribers_url":"https://api.github.com/repos/projecttacoma/bonnie/subscribers","subscription_url":"https://api.github.com/repos/projecttacoma/bonnie/subscription","commits_url":"https://api.github.com/repos/projecttacoma/bonnie/commits{/sha}","git_commits_url":"https://api.github.com/repos/projecttacoma/bonnie/git/commits{/sha}","comments_url":"https://api.github.com/repos/projecttacoma/bonnie/comments{/number}","issue_comment_url":"https://api.github.com/repos/projecttacoma/bonnie/issues/comments{/number}","contents_url":"https://api.github.com/repos/projecttacoma/bonnie/contents/{+path}","compare_url":"https://api.github.com/repos/projecttacoma/bonnie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projecttacoma/bonnie/merges","archive_url":"https://api.github.com/repos/projecttacoma/bonnie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projecttacoma/bonnie/downloads","issues_url":"https://api.github.com/repos/projecttacoma/bonnie/issues{/number}","pulls_url":"https://api.github.com/repos/projecttacoma/bonnie/pulls{/number}","milestones_url":"https://api.github.com/repos/projecttacoma/bonnie/milestones{/number}","notifications_url":"https://api.github.com/repos/projecttacoma/bonnie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projecttacoma/bonnie/labels{/name}","releases_url":"https://api.github.com/repos/projecttacoma/bonnie/releases{/id}","deployments_url":"https://api.github.com/repos/projecttacoma/bonnie/deployments","created_at":"2013-09-19T20:11:14Z","updated_at":"2018-06-14T17:55:33Z","pushed_at":"2018-06-18T21:54:59Z","git_url":"git://github.com/projecttacoma/bonnie.git","ssh_url":"git@github.com:projecttacoma/bonnie.git","clone_url":"https://github.com/projecttacoma/bonnie.git","svn_url":"https://github.com/projecttacoma/bonnie","homepage":null,"size":108620,"stargazers_count":21,"watchers_count":21,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":19,"open_issues":11,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projecttacoma/bonnie/pulls/1013"},"html":{"href":"https://github.com/projecttacoma/bonnie/pull/1013"},"issue":{"href":"https://api.github.com/repos/projecttacoma/bonnie/issues/1013"},"comments":{"href":"https://api.github.com/repos/projecttacoma/bonnie/issues/1013/comments"},"review_comments":{"href":"https://api.github.com/repos/projecttacoma/bonnie/pulls/1013/comments"},"review_comment":{"href":"https://api.github.com/repos/projecttacoma/bonnie/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projecttacoma/bonnie/pulls/1013/commits"},"statuses":{"href":"https://api.github.com/repos/projecttacoma/bonnie/statuses/368b4dd0203bbb8e9a366e6be70fc8ed398f93a8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jbradl11"}}