{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/comments/220286776","pull_request_review_id":158660266,"id":220286776,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDI4Njc3Ng==","diff_hunk":"@@ -79,10 +81,12 @@ define({FILE_START},{\n \n define({C_FUNCTION_SYMBOL},_$1)\n \n+define({GLOBAL_SYMBOL},_$1)\n+\n define({START_PROC},{","path":"runtime/oti/xhelpers.m4","position":24,"original_position":24,"commit_id":"6b865a8d685a47bab3a1816f8feaaaffa2220b15","original_commit_id":"6b865a8d685a47bab3a1816f8feaaaffa2220b15","user":{"login":"DanHeidinga","id":8503711,"node_id":"MDQ6VXNlcjg1MDM3MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8503711?v=4","gravatar_id":"","url":"https://api.github.com/users/DanHeidinga","html_url":"https://github.com/DanHeidinga","followers_url":"https://api.github.com/users/DanHeidinga/followers","following_url":"https://api.github.com/users/DanHeidinga/following{/other_user}","gists_url":"https://api.github.com/users/DanHeidinga/gists{/gist_id}","starred_url":"https://api.github.com/users/DanHeidinga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanHeidinga/subscriptions","organizations_url":"https://api.github.com/users/DanHeidinga/orgs","repos_url":"https://api.github.com/users/DanHeidinga/repos","events_url":"https://api.github.com/users/DanHeidinga/events{/privacy}","received_events_url":"https://api.github.com/users/DanHeidinga/received_events","type":"User","site_admin":false},"body":"The two copies of START_PROC (osx and linux) are now identical and can be moved out of the ifdef","created_at":"2018-09-25T17:36:13Z","updated_at":"2018-09-25T17:36:14Z","html_url":"https://github.com/eclipse/openj9/pull/3004#discussion_r220286776","pull_request_url":"https://api.github.com/repos/eclipse/openj9/pulls/3004","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments/220286776"},"html":{"href":"https://github.com/eclipse/openj9/pull/3004#discussion_r220286776"},"pull_request":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/3004"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/3004","id":217808923,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3ODA4OTIz","html_url":"https://github.com/eclipse/openj9/pull/3004","diff_url":"https://github.com/eclipse/openj9/pull/3004.diff","patch_url":"https://github.com/eclipse/openj9/pull/3004.patch","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/3004","number":3004,"state":"open","locked":false,"title":"Fix incorrect global and extern symbol references on OSX","user":{"login":"nbhuiyan","id":23691212,"node_id":"MDQ6VXNlcjIzNjkxMjEy","avatar_url":"https://avatars0.githubusercontent.com/u/23691212?v=4","gravatar_id":"","url":"https://api.github.com/users/nbhuiyan","html_url":"https://github.com/nbhuiyan","followers_url":"https://api.github.com/users/nbhuiyan/followers","following_url":"https://api.github.com/users/nbhuiyan/following{/other_user}","gists_url":"https://api.github.com/users/nbhuiyan/gists{/gist_id}","starred_url":"https://api.github.com/users/nbhuiyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbhuiyan/subscriptions","organizations_url":"https://api.github.com/users/nbhuiyan/orgs","repos_url":"https://api.github.com/users/nbhuiyan/repos","events_url":"https://api.github.com/users/nbhuiyan/events{/privacy}","received_events_url":"https://api.github.com/users/nbhuiyan/received_events","type":"User","site_admin":false},"body":"OSX requires all symbols that are either defined or used in\r\nmodules other than itself to have leading underscores\r\n(only relevant when writing assembly code).\r\nThis fixes linker errors caused due to the missing underscores\r\nin symbol declarations and references in xnathelp.o\r\n\r\nSigned-off-by: Nazim Uddin Bhuiyan <nazimudd@ualberta.ca>\r\n\r\nIssue: #36 ","created_at":"2018-09-24T22:41:34Z","updated_at":"2018-09-25T17:36:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"468183a81915b23508d18c0f033e2e931440bf5f","assignee":{"login":"DanHeidinga","id":8503711,"node_id":"MDQ6VXNlcjg1MDM3MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8503711?v=4","gravatar_id":"","url":"https://api.github.com/users/DanHeidinga","html_url":"https://github.com/DanHeidinga","followers_url":"https://api.github.com/users/DanHeidinga/followers","following_url":"https://api.github.com/users/DanHeidinga/following{/other_user}","gists_url":"https://api.github.com/users/DanHeidinga/gists{/gist_id}","starred_url":"https://api.github.com/users/DanHeidinga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanHeidinga/subscriptions","organizations_url":"https://api.github.com/users/DanHeidinga/orgs","repos_url":"https://api.github.com/users/DanHeidinga/repos","events_url":"https://api.github.com/users/DanHeidinga/events{/privacy}","received_events_url":"https://api.github.com/users/DanHeidinga/received_events","type":"User","site_admin":false},"assignees":[{"login":"DanHeidinga","id":8503711,"node_id":"MDQ6VXNlcjg1MDM3MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8503711?v=4","gravatar_id":"","url":"https://api.github.com/users/DanHeidinga","html_url":"https://github.com/DanHeidinga","followers_url":"https://api.github.com/users/DanHeidinga/followers","following_url":"https://api.github.com/users/DanHeidinga/following{/other_user}","gists_url":"https://api.github.com/users/DanHeidinga/gists{/gist_id}","starred_url":"https://api.github.com/users/DanHeidinga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanHeidinga/subscriptions","organizations_url":"https://api.github.com/users/DanHeidinga/orgs","repos_url":"https://api.github.com/users/DanHeidinga/repos","events_url":"https://api.github.com/users/DanHeidinga/events{/privacy}","received_events_url":"https://api.github.com/users/DanHeidinga/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":697962110,"node_id":"MDU6TGFiZWw2OTc5NjIxMTA=","url":"https://api.github.com/repos/eclipse/openj9/labels/comp:vm","name":"comp:vm","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/openj9/pulls/3004/commits","review_comments_url":"https://api.github.com/repos/eclipse/openj9/pulls/3004/comments","review_comment_url":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/3004/comments","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/6b865a8d685a47bab3a1816f8feaaaffa2220b15","head":{"label":"nbhuiyan:xnathelp-xhelpers","ref":"xnathelp-xhelpers","sha":"6b865a8d685a47bab3a1816f8feaaaffa2220b15","user":{"login":"nbhuiyan","id":23691212,"node_id":"MDQ6VXNlcjIzNjkxMjEy","avatar_url":"https://avatars0.githubusercontent.com/u/23691212?v=4","gravatar_id":"","url":"https://api.github.com/users/nbhuiyan","html_url":"https://github.com/nbhuiyan","followers_url":"https://api.github.com/users/nbhuiyan/followers","following_url":"https://api.github.com/users/nbhuiyan/following{/other_user}","gists_url":"https://api.github.com/users/nbhuiyan/gists{/gist_id}","starred_url":"https://api.github.com/users/nbhuiyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbhuiyan/subscriptions","organizations_url":"https://api.github.com/users/nbhuiyan/orgs","repos_url":"https://api.github.com/users/nbhuiyan/repos","events_url":"https://api.github.com/users/nbhuiyan/events{/privacy}","received_events_url":"https://api.github.com/users/nbhuiyan/received_events","type":"User","site_admin":false},"repo":{"id":111456935,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE0NTY5MzU=","name":"openj9","full_name":"nbhuiyan/openj9","private":false,"owner":{"login":"nbhuiyan","id":23691212,"node_id":"MDQ6VXNlcjIzNjkxMjEy","avatar_url":"https://avatars0.githubusercontent.com/u/23691212?v=4","gravatar_id":"","url":"https://api.github.com/users/nbhuiyan","html_url":"https://github.com/nbhuiyan","followers_url":"https://api.github.com/users/nbhuiyan/followers","following_url":"https://api.github.com/users/nbhuiyan/following{/other_user}","gists_url":"https://api.github.com/users/nbhuiyan/gists{/gist_id}","starred_url":"https://api.github.com/users/nbhuiyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbhuiyan/subscriptions","organizations_url":"https://api.github.com/users/nbhuiyan/orgs","repos_url":"https://api.github.com/users/nbhuiyan/repos","events_url":"https://api.github.com/users/nbhuiyan/events{/privacy}","received_events_url":"https://api.github.com/users/nbhuiyan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nbhuiyan/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":true,"url":"https://api.github.com/repos/nbhuiyan/openj9","forks_url":"https://api.github.com/repos/nbhuiyan/openj9/forks","keys_url":"https://api.github.com/repos/nbhuiyan/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nbhuiyan/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nbhuiyan/openj9/teams","hooks_url":"https://api.github.com/repos/nbhuiyan/openj9/hooks","issue_events_url":"https://api.github.com/repos/nbhuiyan/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/nbhuiyan/openj9/events","assignees_url":"https://api.github.com/repos/nbhuiyan/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/nbhuiyan/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/nbhuiyan/openj9/tags","blobs_url":"https://api.github.com/repos/nbhuiyan/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nbhuiyan/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nbhuiyan/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/nbhuiyan/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nbhuiyan/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/nbhuiyan/openj9/languages","stargazers_url":"https://api.github.com/repos/nbhuiyan/openj9/stargazers","contributors_url":"https://api.github.com/repos/nbhuiyan/openj9/contributors","subscribers_url":"https://api.github.com/repos/nbhuiyan/openj9/subscribers","subscription_url":"https://api.github.com/repos/nbhuiyan/openj9/subscription","commits_url":"https://api.github.com/repos/nbhuiyan/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/nbhuiyan/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/nbhuiyan/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/nbhuiyan/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/nbhuiyan/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/nbhuiyan/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nbhuiyan/openj9/merges","archive_url":"https://api.github.com/repos/nbhuiyan/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nbhuiyan/openj9/downloads","issues_url":"https://api.github.com/repos/nbhuiyan/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/nbhuiyan/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/nbhuiyan/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/nbhuiyan/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nbhuiyan/openj9/labels{/name}","releases_url":"https://api.github.com/repos/nbhuiyan/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/nbhuiyan/openj9/deployments","created_at":"2017-11-20T20:01:42Z","updated_at":"2018-09-24T22:23:19Z","pushed_at":"2018-09-25T17:30:46Z","git_url":"git://github.com/nbhuiyan/openj9.git","ssh_url":"git@github.com:nbhuiyan/openj9.git","clone_url":"https://github.com/nbhuiyan/openj9.git","svn_url":"https://github.com/nbhuiyan/openj9","homepage":"","size":34794,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"c1463b8a4956073e7d1ec7aaf34fb120957cfe53","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":101408117,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE0MDgxMTc=","name":"openj9","full_name":"eclipse/openj9","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":false,"url":"https://api.github.com/repos/eclipse/openj9","forks_url":"https://api.github.com/repos/eclipse/openj9/forks","keys_url":"https://api.github.com/repos/eclipse/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/openj9/teams","hooks_url":"https://api.github.com/repos/eclipse/openj9/hooks","issue_events_url":"https://api.github.com/repos/eclipse/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/openj9/events","assignees_url":"https://api.github.com/repos/eclipse/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/openj9/tags","blobs_url":"https://api.github.com/repos/eclipse/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/openj9/languages","stargazers_url":"https://api.github.com/repos/eclipse/openj9/stargazers","contributors_url":"https://api.github.com/repos/eclipse/openj9/contributors","subscribers_url":"https://api.github.com/repos/eclipse/openj9/subscribers","subscription_url":"https://api.github.com/repos/eclipse/openj9/subscription","commits_url":"https://api.github.com/repos/eclipse/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/openj9/merges","archive_url":"https://api.github.com/repos/eclipse/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/openj9/downloads","issues_url":"https://api.github.com/repos/eclipse/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/openj9/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/openj9/deployments","created_at":"2017-08-25T13:46:07Z","updated_at":"2018-09-25T16:53:14Z","pushed_at":"2018-09-25T17:35:28Z","git_url":"git://github.com/eclipse/openj9.git","ssh_url":"git@github.com:eclipse/openj9.git","clone_url":"https://github.com/eclipse/openj9.git","svn_url":"https://github.com/eclipse/openj9","homepage":"","size":34599,"stargazers_count":1421,"watchers_count":1421,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":280,"mirror_url":null,"archived":false,"open_issues_count":473,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":280,"open_issues":473,"watchers":1421,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/3004"},"html":{"href":"https://github.com/eclipse/openj9/pull/3004"},"issue":{"href":"https://api.github.com/repos/eclipse/openj9/issues/3004"},"comments":{"href":"https://api.github.com/repos/eclipse/openj9/issues/3004/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/3004/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/3004/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/openj9/statuses/6b865a8d685a47bab3a1816f8feaaaffa2220b15"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"DanHeidinga"}}