{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/169550292","pull_request_review_id":98091978,"id":169550292,"diff_hunk":"@@ -31,10 +34,10 @@\n \n     public Producer(String topic, Boolean isAsync) {\n         Properties props = new Properties();\n-        props.put(\"bootstrap.servers\", KafkaProperties.KAFKA_SERVER_URL + \":\" + KafkaProperties.KAFKA_SERVER_PORT);\n-        props.put(\"client.id\", \"DemoProducer\");\n-        props.put(\"key.serializer\", \"org.apache.kafka.common.serialization.IntegerSerializer\");\n-        props.put(\"value.serializer\", \"org.apache.kafka.common.serialization.StringSerializer\");\n+        props.put(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG, KafkaProperties.KAFKA_SERVER_URL + \":\" + KafkaProperties.KAFKA_SERVER_PORT);\n+        props.put(ProducerConfig.CLIENT_ID_CONFIG, \"DemoProducer\");\n+        props.put(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG,IntegerSerializer.class.getName());","path":"examples/src/main/java/kafka/examples/Producer.java","position":20,"original_position":20,"commit_id":"82825ae41b40456e64f3ef09ab92dd43b4a38480","original_commit_id":"82825ae41b40456e64f3ef09ab92dd43b4a38480","user":{"login":"hachikuji","id":12502538,"avatar_url":"https://avatars3.githubusercontent.com/u/12502538?v=4","gravatar_id":"","url":"https://api.github.com/users/hachikuji","html_url":"https://github.com/hachikuji","followers_url":"https://api.github.com/users/hachikuji/followers","following_url":"https://api.github.com/users/hachikuji/following{/other_user}","gists_url":"https://api.github.com/users/hachikuji/gists{/gist_id}","starred_url":"https://api.github.com/users/hachikuji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hachikuji/subscriptions","organizations_url":"https://api.github.com/users/hachikuji/orgs","repos_url":"https://api.github.com/users/hachikuji/repos","events_url":"https://api.github.com/users/hachikuji/events{/privacy}","received_events_url":"https://api.github.com/users/hachikuji/received_events","type":"User","site_admin":false},"body":"Missing a space after the comma, which is causing checkstyle to fail.","created_at":"2018-02-21T07:14:30Z","updated_at":"2018-02-21T07:14:31Z","html_url":"https://github.com/apache/kafka/pull/4601#discussion_r169550292","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/4601","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/169550292"},"html":{"href":"https://github.com/apache/kafka/pull/4601#discussion_r169550292"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/4601"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/4601","id":170237590,"html_url":"https://github.com/apache/kafka/pull/4601","diff_url":"https://github.com/apache/kafka/pull/4601.diff","patch_url":"https://github.com/apache/kafka/pull/4601.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/4601","number":4601,"state":"open","locked":false,"title":"COSMETIC : Reading configuration fields from ProducerConfig class","user":{"login":"VenkataNU","id":15402743,"avatar_url":"https://avatars2.githubusercontent.com/u/15402743?v=4","gravatar_id":"","url":"https://api.github.com/users/VenkataNU","html_url":"https://github.com/VenkataNU","followers_url":"https://api.github.com/users/VenkataNU/followers","following_url":"https://api.github.com/users/VenkataNU/following{/other_user}","gists_url":"https://api.github.com/users/VenkataNU/gists{/gist_id}","starred_url":"https://api.github.com/users/VenkataNU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VenkataNU/subscriptions","organizations_url":"https://api.github.com/users/VenkataNU/orgs","repos_url":"https://api.github.com/users/VenkataNU/repos","events_url":"https://api.github.com/users/VenkataNU/events{/privacy}","received_events_url":"https://api.github.com/users/VenkataNU/received_events","type":"User","site_admin":false},"body":"Reading the configuration field names from ProducerConfig class and taking the key and value serializer names from class name directly instead of hardcoding\r\n\r\n*More detailed description of your change,\r\nif necessary. The PR title and PR message become\r\nthe squashed commit message, so use a separate\r\ncomment to ping reviewers.*\r\n\r\n*Summary of testing strategy (including rationale)\r\nfor the feature or bug fix. Unit and/or integration\r\ntests are expected for any behaviour change and\r\nsystem tests should be considered for larger changes.*\r\n\r\n### Committer Checklist (excluded from commit message)\r\n- [ ] Verify design and implementation \r\n- [ ] Verify test coverage and CI build status\r\n- [ ] Verify documentation (including upgrade notes)\r\n","created_at":"2018-02-20T16:12:37Z","updated_at":"2018-02-21T07:14:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e8efd657f0a195ca3a8ae939380c2aace42140c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/4601/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/4601/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/4601/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/82825ae41b40456e64f3ef09ab92dd43b4a38480","head":{"label":"VenkataNU:patch-1","ref":"patch-1","sha":"82825ae41b40456e64f3ef09ab92dd43b4a38480","user":{"login":"VenkataNU","id":15402743,"avatar_url":"https://avatars2.githubusercontent.com/u/15402743?v=4","gravatar_id":"","url":"https://api.github.com/users/VenkataNU","html_url":"https://github.com/VenkataNU","followers_url":"https://api.github.com/users/VenkataNU/followers","following_url":"https://api.github.com/users/VenkataNU/following{/other_user}","gists_url":"https://api.github.com/users/VenkataNU/gists{/gist_id}","starred_url":"https://api.github.com/users/VenkataNU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VenkataNU/subscriptions","organizations_url":"https://api.github.com/users/VenkataNU/orgs","repos_url":"https://api.github.com/users/VenkataNU/repos","events_url":"https://api.github.com/users/VenkataNU/events{/privacy}","received_events_url":"https://api.github.com/users/VenkataNU/received_events","type":"User","site_admin":false},"repo":{"id":122220156,"name":"kafka","full_name":"VenkataNU/kafka","owner":{"login":"VenkataNU","id":15402743,"avatar_url":"https://avatars2.githubusercontent.com/u/15402743?v=4","gravatar_id":"","url":"https://api.github.com/users/VenkataNU","html_url":"https://github.com/VenkataNU","followers_url":"https://api.github.com/users/VenkataNU/followers","following_url":"https://api.github.com/users/VenkataNU/following{/other_user}","gists_url":"https://api.github.com/users/VenkataNU/gists{/gist_id}","starred_url":"https://api.github.com/users/VenkataNU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VenkataNU/subscriptions","organizations_url":"https://api.github.com/users/VenkataNU/orgs","repos_url":"https://api.github.com/users/VenkataNU/repos","events_url":"https://api.github.com/users/VenkataNU/events{/privacy}","received_events_url":"https://api.github.com/users/VenkataNU/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VenkataNU/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/VenkataNU/kafka","forks_url":"https://api.github.com/repos/VenkataNU/kafka/forks","keys_url":"https://api.github.com/repos/VenkataNU/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VenkataNU/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VenkataNU/kafka/teams","hooks_url":"https://api.github.com/repos/VenkataNU/kafka/hooks","issue_events_url":"https://api.github.com/repos/VenkataNU/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/VenkataNU/kafka/events","assignees_url":"https://api.github.com/repos/VenkataNU/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/VenkataNU/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/VenkataNU/kafka/tags","blobs_url":"https://api.github.com/repos/VenkataNU/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VenkataNU/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VenkataNU/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/VenkataNU/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VenkataNU/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/VenkataNU/kafka/languages","stargazers_url":"https://api.github.com/repos/VenkataNU/kafka/stargazers","contributors_url":"https://api.github.com/repos/VenkataNU/kafka/contributors","subscribers_url":"https://api.github.com/repos/VenkataNU/kafka/subscribers","subscription_url":"https://api.github.com/repos/VenkataNU/kafka/subscription","commits_url":"https://api.github.com/repos/VenkataNU/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/VenkataNU/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/VenkataNU/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/VenkataNU/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/VenkataNU/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/VenkataNU/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VenkataNU/kafka/merges","archive_url":"https://api.github.com/repos/VenkataNU/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VenkataNU/kafka/downloads","issues_url":"https://api.github.com/repos/VenkataNU/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/VenkataNU/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/VenkataNU/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/VenkataNU/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VenkataNU/kafka/labels{/name}","releases_url":"https://api.github.com/repos/VenkataNU/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/VenkataNU/kafka/deployments","created_at":"2018-02-20T15:56:36Z","updated_at":"2018-02-20T15:56:47Z","pushed_at":"2018-02-20T21:29:21Z","git_url":"git://github.com/VenkataNU/kafka.git","ssh_url":"git@github.com:VenkataNU/kafka.git","clone_url":"https://github.com/VenkataNU/kafka.git","svn_url":"https://github.com/VenkataNU/kafka","homepage":null,"size":63134,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"a41373309497da449a1f757e2c24399794d77072","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2018-02-21T06:34:41Z","pushed_at":"2018-02-21T06:29:41Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":63156,"stargazers_count":7449,"watchers_count":7449,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4463,"mirror_url":null,"archived":false,"open_issues_count":438,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4463,"open_issues":438,"watchers":7449,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/4601"},"html":{"href":"https://github.com/apache/kafka/pull/4601"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/4601"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/4601/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/4601/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/4601/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/82825ae41b40456e64f3ef09ab92dd43b4a38480"}},"author_association":"NONE"}}
{"actor":{"display_login":"hachikuji"}}