{"action":"created","comment":{"url":"https://api.github.com/repos/taisei-project/taisei/pulls/comments/187295814","pull_request_review_id":119045036,"id":187295814,"diff_hunk":"@@ -114,6 +137,10 @@ float smooth(float x) attr_const;\n float smoothreclamp(float x, float old_min, float old_max, float new_min, float new_max) attr_const;\n float sanitize_scale(float scale) attr_const;\n \n+bool point_in_ellipse(complex p, Ellipse e) attr_const;\n+double lineseg_circle_intersect(LineSegment seg, Circle c) attr_const;\n+bool lineseg_ellipse_intersect(LineSegment seg, Ellipse e) attr_const;\n+","path":"src/util.h","position":81,"original_position":81,"commit_id":"8baec62915b7cdb506fd61d4006ce88031edc197","original_commit_id":"8baec62915b7cdb506fd61d4006ce88031edc197","user":{"login":"Akaricchi","id":609016,"avatar_url":"https://avatars2.githubusercontent.com/u/609016?v=4","gravatar_id":"","url":"https://api.github.com/users/Akaricchi","html_url":"https://github.com/Akaricchi","followers_url":"https://api.github.com/users/Akaricchi/followers","following_url":"https://api.github.com/users/Akaricchi/following{/other_user}","gists_url":"https://api.github.com/users/Akaricchi/gists{/gist_id}","starred_url":"https://api.github.com/users/Akaricchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akaricchi/subscriptions","organizations_url":"https://api.github.com/users/Akaricchi/orgs","repos_url":"https://api.github.com/users/Akaricchi/repos","events_url":"https://api.github.com/users/Akaricchi/events{/privacy}","received_events_url":"https://api.github.com/users/Akaricchi/received_events","type":"User","site_admin":false},"body":"I do plan to refactor/split up `utils.c` soon™, and I agree these should get their own file. I just didn't want to conflate too many things in this pull request, so I put them there temporarily. I think I'd prefer `geometry.c` or something like that, though.","created_at":"2018-05-10T10:34:50Z","updated_at":"2018-05-10T10:34:50Z","html_url":"https://github.com/taisei-project/taisei/pull/122#discussion_r187295814","pull_request_url":"https://api.github.com/repos/taisei-project/taisei/pulls/122","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/taisei-project/taisei/pulls/comments/187295814"},"html":{"href":"https://github.com/taisei-project/taisei/pull/122#discussion_r187295814"},"pull_request":{"href":"https://api.github.com/repos/taisei-project/taisei/pulls/122"}},"in_reply_to_id":187287778},"pull_request":{"url":"https://api.github.com/repos/taisei-project/taisei/pulls/122","id":187143637,"html_url":"https://github.com/taisei-project/taisei/pull/122","diff_url":"https://github.com/taisei-project/taisei/pull/122.diff","patch_url":"https://github.com/taisei-project/taisei/pull/122.patch","issue_url":"https://api.github.com/repos/taisei-project/taisei/issues/122","number":122,"state":"open","locked":false,"title":"Improve (totally rewrite) projectile collision detection and graze mechanics","user":{"login":"Akaricchi","id":609016,"avatar_url":"https://avatars2.githubusercontent.com/u/609016?v=4","gravatar_id":"","url":"https://api.github.com/users/Akaricchi","html_url":"https://github.com/Akaricchi","followers_url":"https://api.github.com/users/Akaricchi/followers","following_url":"https://api.github.com/users/Akaricchi/following{/other_user}","gists_url":"https://api.github.com/users/Akaricchi/gists{/gist_id}","starred_url":"https://api.github.com/users/Akaricchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akaricchi/subscriptions","organizations_url":"https://api.github.com/users/Akaricchi/orgs","repos_url":"https://api.github.com/users/Akaricchi/repos","events_url":"https://api.github.com/users/Akaricchi/events{/privacy}","received_events_url":"https://api.github.com/users/Akaricchi/received_events","type":"User","site_admin":false},"body":"* Bullets are now *actually* ellipses.\r\n* Player and bullet trajectory is lerped to mitigate phasing through bullets on high velocities\r\n* Some pattern-specific bugs introduced with projectile prototypes fixed.\r\n* You can graze a bullet multiple times now. Each successive graze per bullet reduces the grazing area for that bullet and gives more points.\r\n* Collision areas adjusted for some projectiles.","created_at":"2018-05-10T09:29:03Z","updated_at":"2018-05-10T10:34:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e6cf8cadf498f9dcbd9abaa170a498f40a99adf","assignee":{"login":"Akaricchi","id":609016,"avatar_url":"https://avatars2.githubusercontent.com/u/609016?v=4","gravatar_id":"","url":"https://api.github.com/users/Akaricchi","html_url":"https://github.com/Akaricchi","followers_url":"https://api.github.com/users/Akaricchi/followers","following_url":"https://api.github.com/users/Akaricchi/following{/other_user}","gists_url":"https://api.github.com/users/Akaricchi/gists{/gist_id}","starred_url":"https://api.github.com/users/Akaricchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akaricchi/subscriptions","organizations_url":"https://api.github.com/users/Akaricchi/orgs","repos_url":"https://api.github.com/users/Akaricchi/repos","events_url":"https://api.github.com/users/Akaricchi/events{/privacy}","received_events_url":"https://api.github.com/users/Akaricchi/received_events","type":"User","site_admin":false},"assignees":[{"login":"Akaricchi","id":609016,"avatar_url":"https://avatars2.githubusercontent.com/u/609016?v=4","gravatar_id":"","url":"https://api.github.com/users/Akaricchi","html_url":"https://github.com/Akaricchi","followers_url":"https://api.github.com/users/Akaricchi/followers","following_url":"https://api.github.com/users/Akaricchi/following{/other_user}","gists_url":"https://api.github.com/users/Akaricchi/gists{/gist_id}","starred_url":"https://api.github.com/users/Akaricchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akaricchi/subscriptions","organizations_url":"https://api.github.com/users/Akaricchi/orgs","repos_url":"https://api.github.com/users/Akaricchi/repos","events_url":"https://api.github.com/users/Akaricchi/events{/privacy}","received_events_url":"https://api.github.com/users/Akaricchi/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":734826275,"url":"https://api.github.com/repos/taisei-project/taisei/labels/bug","name":"bug","color":"c8db5c","default":true},{"id":803165001,"url":"https://api.github.com/repos/taisei-project/taisei/labels/engine","name":"engine","color":"edb61e","default":false},{"id":734826357,"url":"https://api.github.com/repos/taisei-project/taisei/labels/gameplay","name":"gameplay","color":"1d76db","default":false}],"milestone":{"url":"https://api.github.com/repos/taisei-project/taisei/milestones/1","html_url":"https://github.com/taisei-project/taisei/milestone/1","labels_url":"https://api.github.com/repos/taisei-project/taisei/milestones/1/labels","id":3032364,"number":1,"title":"v1.3","description":null,"creator":{"login":"Akaricchi","id":609016,"avatar_url":"https://avatars2.githubusercontent.com/u/609016?v=4","gravatar_id":"","url":"https://api.github.com/users/Akaricchi","html_url":"https://github.com/Akaricchi","followers_url":"https://api.github.com/users/Akaricchi/followers","following_url":"https://api.github.com/users/Akaricchi/following{/other_user}","gists_url":"https://api.github.com/users/Akaricchi/gists{/gist_id}","starred_url":"https://api.github.com/users/Akaricchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akaricchi/subscriptions","organizations_url":"https://api.github.com/users/Akaricchi/orgs","repos_url":"https://api.github.com/users/Akaricchi/repos","events_url":"https://api.github.com/users/Akaricchi/events{/privacy}","received_events_url":"https://api.github.com/users/Akaricchi/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":2,"state":"open","created_at":"2018-01-12T20:26:39Z","updated_at":"2018-05-10T09:29:03Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/taisei-project/taisei/pulls/122/commits","review_comments_url":"https://api.github.com/repos/taisei-project/taisei/pulls/122/comments","review_comment_url":"https://api.github.com/repos/taisei-project/taisei/pulls/comments{/number}","comments_url":"https://api.github.com/repos/taisei-project/taisei/issues/122/comments","statuses_url":"https://api.github.com/repos/taisei-project/taisei/statuses/8baec62915b7cdb506fd61d4006ce88031edc197","head":{"label":"taisei-project:collision","ref":"collision","sha":"8baec62915b7cdb506fd61d4006ce88031edc197","user":{"login":"taisei-project","id":32730633,"avatar_url":"https://avatars1.githubusercontent.com/u/32730633?v=4","gravatar_id":"","url":"https://api.github.com/users/taisei-project","html_url":"https://github.com/taisei-project","followers_url":"https://api.github.com/users/taisei-project/followers","following_url":"https://api.github.com/users/taisei-project/following{/other_user}","gists_url":"https://api.github.com/users/taisei-project/gists{/gist_id}","starred_url":"https://api.github.com/users/taisei-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taisei-project/subscriptions","organizations_url":"https://api.github.com/users/taisei-project/orgs","repos_url":"https://api.github.com/users/taisei-project/repos","events_url":"https://api.github.com/users/taisei-project/events{/privacy}","received_events_url":"https://api.github.com/users/taisei-project/received_events","type":"Organization","site_admin":false},"repo":{"id":977986,"name":"taisei","full_name":"taisei-project/taisei","owner":{"login":"taisei-project","id":32730633,"avatar_url":"https://avatars1.githubusercontent.com/u/32730633?v=4","gravatar_id":"","url":"https://api.github.com/users/taisei-project","html_url":"https://github.com/taisei-project","followers_url":"https://api.github.com/users/taisei-project/followers","following_url":"https://api.github.com/users/taisei-project/following{/other_user}","gists_url":"https://api.github.com/users/taisei-project/gists{/gist_id}","starred_url":"https://api.github.com/users/taisei-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taisei-project/subscriptions","organizations_url":"https://api.github.com/users/taisei-project/orgs","repos_url":"https://api.github.com/users/taisei-project/repos","events_url":"https://api.github.com/users/taisei-project/events{/privacy}","received_events_url":"https://api.github.com/users/taisei-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/taisei-project/taisei","description":"A free and open-source Touhou Project clone and fangame","fork":false,"url":"https://api.github.com/repos/taisei-project/taisei","forks_url":"https://api.github.com/repos/taisei-project/taisei/forks","keys_url":"https://api.github.com/repos/taisei-project/taisei/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taisei-project/taisei/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taisei-project/taisei/teams","hooks_url":"https://api.github.com/repos/taisei-project/taisei/hooks","issue_events_url":"https://api.github.com/repos/taisei-project/taisei/issues/events{/number}","events_url":"https://api.github.com/repos/taisei-project/taisei/events","assignees_url":"https://api.github.com/repos/taisei-project/taisei/assignees{/user}","branches_url":"https://api.github.com/repos/taisei-project/taisei/branches{/branch}","tags_url":"https://api.github.com/repos/taisei-project/taisei/tags","blobs_url":"https://api.github.com/repos/taisei-project/taisei/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taisei-project/taisei/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taisei-project/taisei/git/refs{/sha}","trees_url":"https://api.github.com/repos/taisei-project/taisei/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taisei-project/taisei/statuses/{sha}","languages_url":"https://api.github.com/repos/taisei-project/taisei/languages","stargazers_url":"https://api.github.com/repos/taisei-project/taisei/stargazers","contributors_url":"https://api.github.com/repos/taisei-project/taisei/contributors","subscribers_url":"https://api.github.com/repos/taisei-project/taisei/subscribers","subscription_url":"https://api.github.com/repos/taisei-project/taisei/subscription","commits_url":"https://api.github.com/repos/taisei-project/taisei/commits{/sha}","git_commits_url":"https://api.github.com/repos/taisei-project/taisei/git/commits{/sha}","comments_url":"https://api.github.com/repos/taisei-project/taisei/comments{/number}","issue_comment_url":"https://api.github.com/repos/taisei-project/taisei/issues/comments{/number}","contents_url":"https://api.github.com/repos/taisei-project/taisei/contents/{+path}","compare_url":"https://api.github.com/repos/taisei-project/taisei/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taisei-project/taisei/merges","archive_url":"https://api.github.com/repos/taisei-project/taisei/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taisei-project/taisei/downloads","issues_url":"https://api.github.com/repos/taisei-project/taisei/issues{/number}","pulls_url":"https://api.github.com/repos/taisei-project/taisei/pulls{/number}","milestones_url":"https://api.github.com/repos/taisei-project/taisei/milestones{/number}","notifications_url":"https://api.github.com/repos/taisei-project/taisei/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taisei-project/taisei/labels{/name}","releases_url":"https://api.github.com/repos/taisei-project/taisei/releases{/id}","deployments_url":"https://api.github.com/repos/taisei-project/taisei/deployments","created_at":"2010-10-11T07:31:32Z","updated_at":"2018-05-08T16:17:40Z","pushed_at":"2018-05-10T09:29:04Z","git_url":"git://github.com/taisei-project/taisei.git","ssh_url":"git@github.com:taisei-project/taisei.git","clone_url":"https://github.com/taisei-project/taisei.git","svn_url":"https://github.com/taisei-project/taisei","homepage":"https://taisei-project.org/","size":315656,"stargazers_count":130,"watchers_count":130,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":21,"open_issues":8,"watchers":130,"default_branch":"master"}},"base":{"label":"taisei-project:master","ref":"master","sha":"280b0739d819d6a7dc780ddf676c0d07a9b1d894","user":{"login":"taisei-project","id":32730633,"avatar_url":"https://avatars1.githubusercontent.com/u/32730633?v=4","gravatar_id":"","url":"https://api.github.com/users/taisei-project","html_url":"https://github.com/taisei-project","followers_url":"https://api.github.com/users/taisei-project/followers","following_url":"https://api.github.com/users/taisei-project/following{/other_user}","gists_url":"https://api.github.com/users/taisei-project/gists{/gist_id}","starred_url":"https://api.github.com/users/taisei-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taisei-project/subscriptions","organizations_url":"https://api.github.com/users/taisei-project/orgs","repos_url":"https://api.github.com/users/taisei-project/repos","events_url":"https://api.github.com/users/taisei-project/events{/privacy}","received_events_url":"https://api.github.com/users/taisei-project/received_events","type":"Organization","site_admin":false},"repo":{"id":977986,"name":"taisei","full_name":"taisei-project/taisei","owner":{"login":"taisei-project","id":32730633,"avatar_url":"https://avatars1.githubusercontent.com/u/32730633?v=4","gravatar_id":"","url":"https://api.github.com/users/taisei-project","html_url":"https://github.com/taisei-project","followers_url":"https://api.github.com/users/taisei-project/followers","following_url":"https://api.github.com/users/taisei-project/following{/other_user}","gists_url":"https://api.github.com/users/taisei-project/gists{/gist_id}","starred_url":"https://api.github.com/users/taisei-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taisei-project/subscriptions","organizations_url":"https://api.github.com/users/taisei-project/orgs","repos_url":"https://api.github.com/users/taisei-project/repos","events_url":"https://api.github.com/users/taisei-project/events{/privacy}","received_events_url":"https://api.github.com/users/taisei-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/taisei-project/taisei","description":"A free and open-source Touhou Project clone and fangame","fork":false,"url":"https://api.github.com/repos/taisei-project/taisei","forks_url":"https://api.github.com/repos/taisei-project/taisei/forks","keys_url":"https://api.github.com/repos/taisei-project/taisei/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taisei-project/taisei/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taisei-project/taisei/teams","hooks_url":"https://api.github.com/repos/taisei-project/taisei/hooks","issue_events_url":"https://api.github.com/repos/taisei-project/taisei/issues/events{/number}","events_url":"https://api.github.com/repos/taisei-project/taisei/events","assignees_url":"https://api.github.com/repos/taisei-project/taisei/assignees{/user}","branches_url":"https://api.github.com/repos/taisei-project/taisei/branches{/branch}","tags_url":"https://api.github.com/repos/taisei-project/taisei/tags","blobs_url":"https://api.github.com/repos/taisei-project/taisei/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taisei-project/taisei/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taisei-project/taisei/git/refs{/sha}","trees_url":"https://api.github.com/repos/taisei-project/taisei/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taisei-project/taisei/statuses/{sha}","languages_url":"https://api.github.com/repos/taisei-project/taisei/languages","stargazers_url":"https://api.github.com/repos/taisei-project/taisei/stargazers","contributors_url":"https://api.github.com/repos/taisei-project/taisei/contributors","subscribers_url":"https://api.github.com/repos/taisei-project/taisei/subscribers","subscription_url":"https://api.github.com/repos/taisei-project/taisei/subscription","commits_url":"https://api.github.com/repos/taisei-project/taisei/commits{/sha}","git_commits_url":"https://api.github.com/repos/taisei-project/taisei/git/commits{/sha}","comments_url":"https://api.github.com/repos/taisei-project/taisei/comments{/number}","issue_comment_url":"https://api.github.com/repos/taisei-project/taisei/issues/comments{/number}","contents_url":"https://api.github.com/repos/taisei-project/taisei/contents/{+path}","compare_url":"https://api.github.com/repos/taisei-project/taisei/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taisei-project/taisei/merges","archive_url":"https://api.github.com/repos/taisei-project/taisei/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taisei-project/taisei/downloads","issues_url":"https://api.github.com/repos/taisei-project/taisei/issues{/number}","pulls_url":"https://api.github.com/repos/taisei-project/taisei/pulls{/number}","milestones_url":"https://api.github.com/repos/taisei-project/taisei/milestones{/number}","notifications_url":"https://api.github.com/repos/taisei-project/taisei/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taisei-project/taisei/labels{/name}","releases_url":"https://api.github.com/repos/taisei-project/taisei/releases{/id}","deployments_url":"https://api.github.com/repos/taisei-project/taisei/deployments","created_at":"2010-10-11T07:31:32Z","updated_at":"2018-05-08T16:17:40Z","pushed_at":"2018-05-10T09:29:04Z","git_url":"git://github.com/taisei-project/taisei.git","ssh_url":"git@github.com:taisei-project/taisei.git","clone_url":"https://github.com/taisei-project/taisei.git","svn_url":"https://github.com/taisei-project/taisei","homepage":"https://taisei-project.org/","size":315656,"stargazers_count":130,"watchers_count":130,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":21,"open_issues":8,"watchers":130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/taisei-project/taisei/pulls/122"},"html":{"href":"https://github.com/taisei-project/taisei/pull/122"},"issue":{"href":"https://api.github.com/repos/taisei-project/taisei/issues/122"},"comments":{"href":"https://api.github.com/repos/taisei-project/taisei/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/taisei-project/taisei/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/taisei-project/taisei/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/taisei-project/taisei/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/taisei-project/taisei/statuses/8baec62915b7cdb506fd61d4006ce88031edc197"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Akaricchi"}}