{"action":"created","issue":{"url":"https://api.github.com/repos/glinscott/leela-chess/issues/317","repository_url":"https://api.github.com/repos/glinscott/leela-chess","labels_url":"https://api.github.com/repos/glinscott/leela-chess/issues/317/labels{/name}","comments_url":"https://api.github.com/repos/glinscott/leela-chess/issues/317/comments","events_url":"https://api.github.com/repos/glinscott/leela-chess/issues/317/events","html_url":"https://github.com/glinscott/leela-chess/issues/317","id":314353272,"number":317,"title":"cfg_fpu_dynamic_eval mode includes virtual loss","user":{"login":"killerducky","id":64080,"avatar_url":"https://avatars3.githubusercontent.com/u/64080?v=4","gravatar_id":"","url":"https://api.github.com/users/killerducky","html_url":"https://github.com/killerducky","followers_url":"https://api.github.com/users/killerducky/followers","following_url":"https://api.github.com/users/killerducky/following{/other_user}","gists_url":"https://api.github.com/users/killerducky/gists{/gist_id}","starred_url":"https://api.github.com/users/killerducky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killerducky/subscriptions","organizations_url":"https://api.github.com/users/killerducky/orgs","repos_url":"https://api.github.com/users/killerducky/repos","events_url":"https://api.github.com/users/killerducky/events{/privacy}","received_events_url":"https://api.github.com/users/killerducky/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-04-14T19:01:07Z","updated_at":"2018-05-01T17:59:47Z","closed_at":null,"author_association":"COLLABORATOR","body":"`auto fpu_eval = (cfg_fpu_dynamic_eval ? get_eval(color) : net_eval) - fpu_reduction;`\r\n\r\nThis code includes virtual losses in it. There should probably be a get_pure_eval(color) or an argument to get_eval(color, no_virtual_loss) that excludes them. This is making it unclear exactly what is going on because things depend on how many threads are going into the same move etc.\r\n\r\nNot super urgent but we should probably clean this up before tuning other FPU related stuff.\r\n\r\nThanks to crem for finding this.\r\n"},"comment":{"url":"https://api.github.com/repos/glinscott/leela-chess/issues/comments/385741304","html_url":"https://github.com/glinscott/leela-chess/issues/317#issuecomment-385741304","issue_url":"https://api.github.com/repos/glinscott/leela-chess/issues/317","id":385741304,"user":{"login":"jjoshua2","id":15632436,"avatar_url":"https://avatars3.githubusercontent.com/u/15632436?v=4","gravatar_id":"","url":"https://api.github.com/users/jjoshua2","html_url":"https://github.com/jjoshua2","followers_url":"https://api.github.com/users/jjoshua2/followers","following_url":"https://api.github.com/users/jjoshua2/following{/other_user}","gists_url":"https://api.github.com/users/jjoshua2/gists{/gist_id}","starred_url":"https://api.github.com/users/jjoshua2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjoshua2/subscriptions","organizations_url":"https://api.github.com/users/jjoshua2/orgs","repos_url":"https://api.github.com/users/jjoshua2/repos","events_url":"https://api.github.com/users/jjoshua2/events{/privacy}","received_events_url":"https://api.github.com/users/jjoshua2/received_events","type":"User","site_admin":false},"created_at":"2018-05-01T17:59:47Z","updated_at":"2018-05-01T17:59:47Z","author_association":"CONTRIBUTOR","body":"FPU of 0.1 sometimes helps and sometimes hurts elo in my tests, but using .05 seems very conservative. and gaining Using noise and -t=1 should be enough for training to find tactics, so we should probably tune for elo on a variety of nets, instead of tactics puzzles. \r\nBut I do see the point that not getting a single playout will mean t=1 won't ever try it. I think this would be an argument for training with 1600 playouts once we stall at 800, or once we implement resign."}}
{"actor":{"display_login":"jjoshua2"}}