{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/respec/pulls/comments/179649811","pull_request_review_id":109935047,"id":179649811,"diff_hunk":"@@ -0,0 +1,21 @@\n+// Module core/images\n+// This checks for images missing width and height attributes\n+// and adds them if they are missing\n+\n+import { pub } from \"core/pubsubhub\";\n+\n+export const name = \"core/images\";\n+\n+export function run(conf, doc, cb) {\n+  [...doc.querySelectorAll(\"img\")]\n+    .filter(img => !img.hasAttribute(\"width\") || !img.hasAttribute(\"height\"))","path":"src/core/images.js","position":11,"original_position":11,"commit_id":"fd77cbc955ca7bd73af7e13b96f197c73a980ef7","original_commit_id":"fd77cbc955ca7bd73af7e13b96f197c73a980ef7","user":{"login":"marcoscaceres","id":870154,"avatar_url":"https://avatars1.githubusercontent.com/u/870154?v=4","gravatar_id":"","url":"https://api.github.com/users/marcoscaceres","html_url":"https://github.com/marcoscaceres","followers_url":"https://api.github.com/users/marcoscaceres/followers","following_url":"https://api.github.com/users/marcoscaceres/following{/other_user}","gists_url":"https://api.github.com/users/marcoscaceres/gists{/gist_id}","starred_url":"https://api.github.com/users/marcoscaceres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcoscaceres/subscriptions","organizations_url":"https://api.github.com/users/marcoscaceres/orgs","repos_url":"https://api.github.com/users/marcoscaceres/repos","events_url":"https://api.github.com/users/marcoscaceres/events{/privacy}","received_events_url":"https://api.github.com/users/marcoscaceres/received_events","type":"User","site_admin":false},"body":"WE should probably just do \"&&\" here. If someone has set one, but not the other, they probably have a good reason. \r\n\r\nWe should also filter for `srcset` being set - and if `img` is inside a `<picture>` element, we should probably filter it out too.   ","created_at":"2018-04-06T02:53:04Z","updated_at":"2018-04-06T02:53:04Z","html_url":"https://github.com/w3c/respec/pull/1616#discussion_r179649811","pull_request_url":"https://api.github.com/repos/w3c/respec/pulls/1616","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/w3c/respec/pulls/comments/179649811"},"html":{"href":"https://github.com/w3c/respec/pull/1616#discussion_r179649811"},"pull_request":{"href":"https://api.github.com/repos/w3c/respec/pulls/1616"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/respec/pulls/1616","id":179739134,"html_url":"https://github.com/w3c/respec/pull/1616","diff_url":"https://github.com/w3c/respec/pull/1616.diff","patch_url":"https://github.com/w3c/respec/pull/1616.patch","issue_url":"https://api.github.com/repos/w3c/respec/issues/1616","number":1616,"state":"open","locked":false,"title":"feat(core/images): add natural width and height to images(#923)","user":{"login":"himanish-star","id":30361728,"avatar_url":"https://avatars3.githubusercontent.com/u/30361728?v=4","gravatar_id":"","url":"https://api.github.com/users/himanish-star","html_url":"https://github.com/himanish-star","followers_url":"https://api.github.com/users/himanish-star/followers","following_url":"https://api.github.com/users/himanish-star/following{/other_user}","gists_url":"https://api.github.com/users/himanish-star/gists{/gist_id}","starred_url":"https://api.github.com/users/himanish-star/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himanish-star/subscriptions","organizations_url":"https://api.github.com/users/himanish-star/orgs","repos_url":"https://api.github.com/users/himanish-star/repos","events_url":"https://api.github.com/users/himanish-star/events{/privacy}","received_events_url":"https://api.github.com/users/himanish-star/received_events","type":"User","site_admin":false},"body":"fixes: #923 \r\n\r\n@marcoscaceres, I decided to create a new module name `core/images` as I think the code fits into no other existing modules. I may be wrong though","created_at":"2018-04-05T17:04:37Z","updated_at":"2018-04-06T02:53:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c54a5a4c6589e8626f11aa7e3b576d8f355185e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/respec/pulls/1616/commits","review_comments_url":"https://api.github.com/repos/w3c/respec/pulls/1616/comments","review_comment_url":"https://api.github.com/repos/w3c/respec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/respec/issues/1616/comments","statuses_url":"https://api.github.com/repos/w3c/respec/statuses/fd77cbc955ca7bd73af7e13b96f197c73a980ef7","head":{"label":"himanish-star:height-of-images","ref":"height-of-images","sha":"fd77cbc955ca7bd73af7e13b96f197c73a980ef7","user":{"login":"himanish-star","id":30361728,"avatar_url":"https://avatars3.githubusercontent.com/u/30361728?v=4","gravatar_id":"","url":"https://api.github.com/users/himanish-star","html_url":"https://github.com/himanish-star","followers_url":"https://api.github.com/users/himanish-star/followers","following_url":"https://api.github.com/users/himanish-star/following{/other_user}","gists_url":"https://api.github.com/users/himanish-star/gists{/gist_id}","starred_url":"https://api.github.com/users/himanish-star/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himanish-star/subscriptions","organizations_url":"https://api.github.com/users/himanish-star/orgs","repos_url":"https://api.github.com/users/himanish-star/repos","events_url":"https://api.github.com/users/himanish-star/events{/privacy}","received_events_url":"https://api.github.com/users/himanish-star/received_events","type":"User","site_admin":false},"repo":{"id":120054641,"name":"respec","full_name":"himanish-star/respec","owner":{"login":"himanish-star","id":30361728,"avatar_url":"https://avatars3.githubusercontent.com/u/30361728?v=4","gravatar_id":"","url":"https://api.github.com/users/himanish-star","html_url":"https://github.com/himanish-star","followers_url":"https://api.github.com/users/himanish-star/followers","following_url":"https://api.github.com/users/himanish-star/following{/other_user}","gists_url":"https://api.github.com/users/himanish-star/gists{/gist_id}","starred_url":"https://api.github.com/users/himanish-star/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himanish-star/subscriptions","organizations_url":"https://api.github.com/users/himanish-star/orgs","repos_url":"https://api.github.com/users/himanish-star/repos","events_url":"https://api.github.com/users/himanish-star/events{/privacy}","received_events_url":"https://api.github.com/users/himanish-star/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/himanish-star/respec","description":"A tool for creating technical documents and web standards","fork":true,"url":"https://api.github.com/repos/himanish-star/respec","forks_url":"https://api.github.com/repos/himanish-star/respec/forks","keys_url":"https://api.github.com/repos/himanish-star/respec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/himanish-star/respec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/himanish-star/respec/teams","hooks_url":"https://api.github.com/repos/himanish-star/respec/hooks","issue_events_url":"https://api.github.com/repos/himanish-star/respec/issues/events{/number}","events_url":"https://api.github.com/repos/himanish-star/respec/events","assignees_url":"https://api.github.com/repos/himanish-star/respec/assignees{/user}","branches_url":"https://api.github.com/repos/himanish-star/respec/branches{/branch}","tags_url":"https://api.github.com/repos/himanish-star/respec/tags","blobs_url":"https://api.github.com/repos/himanish-star/respec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/himanish-star/respec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/himanish-star/respec/git/refs{/sha}","trees_url":"https://api.github.com/repos/himanish-star/respec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/himanish-star/respec/statuses/{sha}","languages_url":"https://api.github.com/repos/himanish-star/respec/languages","stargazers_url":"https://api.github.com/repos/himanish-star/respec/stargazers","contributors_url":"https://api.github.com/repos/himanish-star/respec/contributors","subscribers_url":"https://api.github.com/repos/himanish-star/respec/subscribers","subscription_url":"https://api.github.com/repos/himanish-star/respec/subscription","commits_url":"https://api.github.com/repos/himanish-star/respec/commits{/sha}","git_commits_url":"https://api.github.com/repos/himanish-star/respec/git/commits{/sha}","comments_url":"https://api.github.com/repos/himanish-star/respec/comments{/number}","issue_comment_url":"https://api.github.com/repos/himanish-star/respec/issues/comments{/number}","contents_url":"https://api.github.com/repos/himanish-star/respec/contents/{+path}","compare_url":"https://api.github.com/repos/himanish-star/respec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/himanish-star/respec/merges","archive_url":"https://api.github.com/repos/himanish-star/respec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/himanish-star/respec/downloads","issues_url":"https://api.github.com/repos/himanish-star/respec/issues{/number}","pulls_url":"https://api.github.com/repos/himanish-star/respec/pulls{/number}","milestones_url":"https://api.github.com/repos/himanish-star/respec/milestones{/number}","notifications_url":"https://api.github.com/repos/himanish-star/respec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/himanish-star/respec/labels{/name}","releases_url":"https://api.github.com/repos/himanish-star/respec/releases{/id}","deployments_url":"https://api.github.com/repos/himanish-star/respec/deployments","created_at":"2018-02-03T03:05:16Z","updated_at":"2018-04-02T18:09:23Z","pushed_at":"2018-04-05T17:09:57Z","git_url":"git://github.com/himanish-star/respec.git","ssh_url":"git@github.com:himanish-star/respec.git","clone_url":"https://github.com/himanish-star/respec.git","svn_url":"https://github.com/himanish-star/respec","homepage":"","size":37236,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"w3c:develop","ref":"develop","sha":"726a7e456032e08b2dc99f701b49d4ca8fa26f01","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":4287066,"name":"respec","full_name":"w3c/respec","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/respec","description":"A tool for creating technical documents and web standards","fork":false,"url":"https://api.github.com/repos/w3c/respec","forks_url":"https://api.github.com/repos/w3c/respec/forks","keys_url":"https://api.github.com/repos/w3c/respec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/respec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/respec/teams","hooks_url":"https://api.github.com/repos/w3c/respec/hooks","issue_events_url":"https://api.github.com/repos/w3c/respec/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/respec/events","assignees_url":"https://api.github.com/repos/w3c/respec/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/respec/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/respec/tags","blobs_url":"https://api.github.com/repos/w3c/respec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/respec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/respec/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/respec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/respec/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/respec/languages","stargazers_url":"https://api.github.com/repos/w3c/respec/stargazers","contributors_url":"https://api.github.com/repos/w3c/respec/contributors","subscribers_url":"https://api.github.com/repos/w3c/respec/subscribers","subscription_url":"https://api.github.com/repos/w3c/respec/subscription","commits_url":"https://api.github.com/repos/w3c/respec/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/respec/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/respec/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/respec/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/respec/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/respec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/respec/merges","archive_url":"https://api.github.com/repos/w3c/respec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/respec/downloads","issues_url":"https://api.github.com/repos/w3c/respec/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/respec/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/respec/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/respec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/respec/labels{/name}","releases_url":"https://api.github.com/repos/w3c/respec/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/respec/deployments","created_at":"2012-05-10T16:39:37Z","updated_at":"2018-04-06T02:22:17Z","pushed_at":"2018-04-06T02:22:29Z","git_url":"git://github.com/w3c/respec.git","ssh_url":"git@github.com:w3c/respec.git","clone_url":"https://github.com/w3c/respec.git","svn_url":"https://github.com/w3c/respec","homepage":"","size":36993,"stargazers_count":231,"watchers_count":231,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":188,"mirror_url":null,"archived":false,"open_issues_count":126,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":188,"open_issues":126,"watchers":231,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/respec/pulls/1616"},"html":{"href":"https://github.com/w3c/respec/pull/1616"},"issue":{"href":"https://api.github.com/repos/w3c/respec/issues/1616"},"comments":{"href":"https://api.github.com/repos/w3c/respec/issues/1616/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/respec/pulls/1616/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/respec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/respec/pulls/1616/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/respec/statuses/fd77cbc955ca7bd73af7e13b96f197c73a980ef7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"marcoscaceres"}}