{"action":"created","issue":{"url":"https://api.github.com/repos/zurb/foundation-sites/issues/11348","repository_url":"https://api.github.com/repos/zurb/foundation-sites","labels_url":"https://api.github.com/repos/zurb/foundation-sites/issues/11348/labels{/name}","comments_url":"https://api.github.com/repos/zurb/foundation-sites/issues/11348/comments","events_url":"https://api.github.com/repos/zurb/foundation-sites/issues/11348/events","html_url":"https://github.com/zurb/foundation-sites/issues/11348","id":334897856,"node_id":"MDU6SXNzdWUzMzQ4OTc4NTY=","number":11348,"title":"Foundation 6.4.3 buttons/links for initialized elements like reveal/toggle are not working until page resources like images etc. finish loading (even with lazy load)","user":{"login":"web-on","id":23358361,"node_id":"MDQ6VXNlcjIzMzU4MzYx","avatar_url":"https://avatars3.githubusercontent.com/u/23358361?v=4","gravatar_id":"","url":"https://api.github.com/users/web-on","html_url":"https://github.com/web-on","followers_url":"https://api.github.com/users/web-on/followers","following_url":"https://api.github.com/users/web-on/following{/other_user}","gists_url":"https://api.github.com/users/web-on/gists{/gist_id}","starred_url":"https://api.github.com/users/web-on/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/web-on/subscriptions","organizations_url":"https://api.github.com/users/web-on/orgs","repos_url":"https://api.github.com/users/web-on/repos","events_url":"https://api.github.com/users/web-on/events{/privacy}","received_events_url":"https://api.github.com/users/web-on/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-06-22T14:25:07Z","updated_at":"2018-06-27T20:28:16Z","closed_at":"2018-06-27T20:27:55Z","author_association":"NONE","body":"<!--- --------------------------------------------------------------------- -->\r\n<!---                 Please fill the following template                    -->\r\n<!---                 Your issue may be ignored otherwise                   -->\r\n<!--- --------------------------------------------------------------------- -->\r\n<!---  Only submit bug reports here. For help or questions to the community -->\r\n<!---  see the forum: https://foundation.zurb.com/forum                     -->\r\n\r\n## What should happen?\r\nWhen the web page is loading, the foundation elements should be available for interaction as soon as possible. When the $(document).foundation() is called, the elements like reveal are initialized and it should be possible to open the reveal with the related button/link. This should not wait until all the images and other page resources load into the page, especially if those resources are loaded by other js modules (e.g. image lazy load)\r\n\r\n## What happens instead?\r\nWhen foundation is initialized e.g. for reveal, the reveal is available, but the buttons/links that trigger it to open are non-clickable.\r\nE.g. on this page: https://foundation.zurb.com/sites/docs/reveal.html#sizing if you hard-refresh the page on slow connection and try clicking any of the \"Click me for a modal\" buttons, the click does nothing until all of the page resources finish loading. But the foundation reveal is already there and can even be called from dev tools console with $('selector').foundation('open').\r\n\r\n## Possible Solution\r\n<!--- Not obligatory, but suggest a fix/reason for the bug,                 -->\r\n<!--- or ideas how to implement the addition or change.                     -->\r\nIt was working as expected in foundation 6.3.1, so, might be that code changes review can help.\r\n\r\n## Test Case and/or Steps to Reproduce\r\n<!--- We highly recommend you to provide a live example of your bug so we   -->\r\n<!--- can reproduce it. You can create a test case with the last Foundation -->\r\n<!--- version by forking https://codepen.io/ncoden/pen/YLzjeq               -->\r\nTest Case:\r\n\r\n<!--- If you cannot provide a test case, provide an unambiguous set of      -->\r\n<!--- steps to reproduce, with your code and configuration.                 -->\r\nHow to reproduce:\r\n1. Go to https://foundation.zurb.com/sites/docs/reveal.html#sizing\r\n2. Open dev tools (in Chrome) -> Network tab, set connection to 'Slow 3G' \r\n3. Hard-refresh the page (e.g. Ctrl+F5) and while the page still loads, try clicking 'Click me for a modal' button.\r\n4. Once the page resources finish loading, you'll see that the button starts behaving.But before that, the clicking does nothing.\r\n\r\n## Context\r\n<!--- How has this issue affected you? What are you trying to accomplish?   -->\r\n<!--- Providing context helps us come up with a solution that is most       -->\r\n<!--- useful in the real world                                              -->\r\nThere are some marketing images on the page, along with the useful info of a product and button to request more info. The button opens the reveal modal with a request form. The marketing images at the top of the page are loaded by the js plugin (galleria). The idea is that the users should be able to make a request right away, without waiting for every single marketing image to finish loading. It  was working before with the foundation 6.3.1\r\n\r\n## Your Environment\r\n<!--- Include as many relevant details about the context and environment    -->\r\n<!--- you experienced the bug in. You can also provide logs if relevant.    -->\r\n- Foundation version(s) used: 6.4.3\r\n- Browser(s) name and version(s): Chrome 67.0.3396.87, Firefox 52.8.1 \r\n- Operating System and version (desktop or mobile): desktop Linux Debian 9, desktop Windows 8\r\n\r\n## Checklist (all required):\r\n<!--- Go over all the following points, and put an `x` in the boxes.        -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask.           -->\r\n- [ x] I have read and follow the CONTRIBUTING.md document.\r\n- [ x] There are no other issues similar to this one.\r\n- [ x] The issue title is descriptive.\r\n- [ x] The template is correctly filled.\r\n\r\n<!--- --------------------------------------------------------------------- -->\r\n<!---       For more information, see the CONTRIBUTING.md document          -->\r\n<!---            Thank you for your issue and happy coding ;)               -->\r\n<!--- --------------------------------------------------------------------- -->\r\n"},"comment":{"url":"https://api.github.com/repos/zurb/foundation-sites/issues/comments/400817950","html_url":"https://github.com/zurb/foundation-sites/issues/11348#issuecomment-400817950","issue_url":"https://api.github.com/repos/zurb/foundation-sites/issues/11348","id":400817950,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDgxNzk1MA==","user":{"login":"ncoden","id":9939075,"node_id":"MDQ6VXNlcjk5MzkwNzU=","avatar_url":"https://avatars2.githubusercontent.com/u/9939075?v=4","gravatar_id":"","url":"https://api.github.com/users/ncoden","html_url":"https://github.com/ncoden","followers_url":"https://api.github.com/users/ncoden/followers","following_url":"https://api.github.com/users/ncoden/following{/other_user}","gists_url":"https://api.github.com/users/ncoden/gists{/gist_id}","starred_url":"https://api.github.com/users/ncoden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncoden/subscriptions","organizations_url":"https://api.github.com/users/ncoden/orgs","repos_url":"https://api.github.com/users/ncoden/repos","events_url":"https://api.github.com/users/ncoden/events{/privacy}","received_events_url":"https://api.github.com/users/ncoden/received_events","type":"User","site_admin":false},"created_at":"2018-06-27T20:28:16Z","updated_at":"2018-06-27T20:28:16Z","author_association":"MEMBER","body":"Hi @web-on. This is a great issue, thanks for the explainations.\r\nThis was already reported in https://github.com/zurb/foundation-sites/issues/10869 and this would be fixed by the pull request https://github.com/zurb/foundation-sites/pull/10877, so i'm closing it.\r\n\r\nDuplicate of #10869"}}
{"actor":{"display_login":"ncoden"}}