{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/website/issues/7289","repository_url":"https://api.github.com/repos/kubernetes/website","labels_url":"https://api.github.com/repos/kubernetes/website/issues/7289/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/website/issues/7289/comments","events_url":"https://api.github.com/repos/kubernetes/website/issues/7289/events","html_url":"https://github.com/kubernetes/website/issues/7289","id":295349837,"number":7289,"title":"Only put people who can /approve into `approvers:` lists","user":{"login":"fejta","id":940341,"avatar_url":"https://avatars2.githubusercontent.com/u/940341?v=4","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"labels":[{"id":513257838,"url":"https://api.github.com/repos/kubernetes/website/labels/Actionable","name":"Actionable","color":"c2e0c6","default":false},{"id":422807565,"url":"https://api.github.com/repos/kubernetes/website/labels/P1","name":"P1","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":{"login":"heckj","id":43388,"avatar_url":"https://avatars0.githubusercontent.com/u/43388?v=4","gravatar_id":"","url":"https://api.github.com/users/heckj","html_url":"https://github.com/heckj","followers_url":"https://api.github.com/users/heckj/followers","following_url":"https://api.github.com/users/heckj/following{/other_user}","gists_url":"https://api.github.com/users/heckj/gists{/gist_id}","starred_url":"https://api.github.com/users/heckj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heckj/subscriptions","organizations_url":"https://api.github.com/users/heckj/orgs","repos_url":"https://api.github.com/users/heckj/repos","events_url":"https://api.github.com/users/heckj/events{/privacy}","received_events_url":"https://api.github.com/users/heckj/received_events","type":"User","site_admin":false},"assignees":[{"login":"heckj","id":43388,"avatar_url":"https://avatars0.githubusercontent.com/u/43388?v=4","gravatar_id":"","url":"https://api.github.com/users/heckj","html_url":"https://github.com/heckj","followers_url":"https://api.github.com/users/heckj/followers","following_url":"https://api.github.com/users/heckj/following{/other_user}","gists_url":"https://api.github.com/users/heckj/gists{/gist_id}","starred_url":"https://api.github.com/users/heckj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heckj/subscriptions","organizations_url":"https://api.github.com/users/heckj/orgs","repos_url":"https://api.github.com/users/heckj/repos","events_url":"https://api.github.com/users/heckj/events{/privacy}","received_events_url":"https://api.github.com/users/heckj/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2018-02-08T01:04:55Z","updated_at":"2018-02-08T07:50:54Z","closed_at":null,"author_association":"NONE","body":"https://github.com/kubernetes/test-infra/issues/6589#issuecomment-363931180 suggests that this repo wants to ensure that docs people approve every PR.\r\n\r\nHowever looking at the OWNERS files in this repo shows that devs (and only devs) are granted approval rights:\r\nhttps://github.com/kubernetes/website/search?utf8=%E2%9C%93&q=filename%3AOWNERS&type=\r\n\r\nA couple concrete examples:\r\nhttps://github.com/kubernetes/website/blob/ceda4025445246e6d0f1d52b0eebdbd82d609787/docs/admin/federation/OWNERS\r\nhttps://github.com/kubernetes/website/blob/ceda4025445246e6d0f1d52b0eebdbd82d609787/docs/admin/OWNERS\r\n\r\nAnyone who is in the `approvers:` list can approve changes to those files. If you do not want this to happen change the `approvers:` list to `reviewers:`\r\n\r\nDetails on how OWNERS files work: https://github.com/kubernetes/community/blob/master/contributors/devel/owners.md"},"comment":{"url":"https://api.github.com/repos/kubernetes/website/issues/comments/364029555","html_url":"https://github.com/kubernetes/website/issues/7289#issuecomment-364029555","issue_url":"https://api.github.com/repos/kubernetes/website/issues/7289","id":364029555,"user":{"login":"fejta","id":940341,"avatar_url":"https://avatars2.githubusercontent.com/u/940341?v=4","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"created_at":"2018-02-08T07:50:54Z","updated_at":"2018-02-08T07:50:54Z","author_association":"NONE","body":"I'd recommend putting your doc team at /OWNERS as approvers so that they can approve all files in the repo and then add dev1 dev2 etc as reviewers at /foo/bar/OWNERS etc\r\n\r\nThat will ensure that when dev1 or dev2 does an /lgtm it will still require someone from the doc team to come in and /approve. \r\n\r\nNote that if a doc person gives an /lgtm it will grant both approval and lgtm, but hopefully the doc team can learn the right behavior (either just /approve or wait until a Dev does /lgtm)."}}
{"actor":{"display_login":"fejta"}}