{"action":"created","issue":{"url":"https://api.github.com/repos/permissions-dispatcher/PermissionsDispatcher/issues/407","repository_url":"https://api.github.com/repos/permissions-dispatcher/PermissionsDispatcher","labels_url":"https://api.github.com/repos/permissions-dispatcher/PermissionsDispatcher/issues/407/labels{/name}","comments_url":"https://api.github.com/repos/permissions-dispatcher/PermissionsDispatcher/issues/407/comments","events_url":"https://api.github.com/repos/permissions-dispatcher/PermissionsDispatcher/issues/407/events","html_url":"https://github.com/permissions-dispatcher/PermissionsDispatcher/issues/407","id":276842840,"number":407,"title":"Lint showing \"Useless @OnShowRationale declaration\"","user":{"login":"silverAndroid","id":5651666,"avatar_url":"https://avatars0.githubusercontent.com/u/5651666?v=4","gravatar_id":"","url":"https://api.github.com/users/silverAndroid","html_url":"https://github.com/silverAndroid","followers_url":"https://api.github.com/users/silverAndroid/followers","following_url":"https://api.github.com/users/silverAndroid/following{/other_user}","gists_url":"https://api.github.com/users/silverAndroid/gists{/gist_id}","starred_url":"https://api.github.com/users/silverAndroid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverAndroid/subscriptions","organizations_url":"https://api.github.com/users/silverAndroid/orgs","repos_url":"https://api.github.com/users/silverAndroid/repos","events_url":"https://api.github.com/users/silverAndroid/events{/privacy}","received_events_url":"https://api.github.com/users/silverAndroid/received_events","type":"User","site_admin":false},"labels":[{"id":248324814,"url":"https://api.github.com/repos/permissions-dispatcher/PermissionsDispatcher/labels/bug","name":"bug","color":"fc2929","default":true},{"id":311504058,"url":"https://api.github.com/repos/permissions-dispatcher/PermissionsDispatcher/labels/contributionwelcome","name":"contributionwelcome","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/permissions-dispatcher/PermissionsDispatcher/milestones/25","html_url":"https://github.com/permissions-dispatcher/PermissionsDispatcher/milestone/25","labels_url":"https://api.github.com/repos/permissions-dispatcher/PermissionsDispatcher/milestones/25/labels","id":3013388,"number":25,"title":"3.2.0","description":"","creator":{"login":"hotchemi","id":471318,"avatar_url":"https://avatars3.githubusercontent.com/u/471318?v=4","gravatar_id":"","url":"https://api.github.com/users/hotchemi","html_url":"https://github.com/hotchemi","followers_url":"https://api.github.com/users/hotchemi/followers","following_url":"https://api.github.com/users/hotchemi/following{/other_user}","gists_url":"https://api.github.com/users/hotchemi/gists{/gist_id}","starred_url":"https://api.github.com/users/hotchemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hotchemi/subscriptions","organizations_url":"https://api.github.com/users/hotchemi/orgs","repos_url":"https://api.github.com/users/hotchemi/repos","events_url":"https://api.github.com/users/hotchemi/events{/privacy}","received_events_url":"https://api.github.com/users/hotchemi/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":0,"state":"open","created_at":"2018-01-04T17:14:31Z","updated_at":"2018-01-13T01:49:03Z","due_on":"2018-01-31T08:00:00Z","closed_at":null},"comments":2,"created_at":"2017-11-26T17:50:49Z","updated_at":"2018-03-03T00:46:38Z","closed_at":null,"author_association":"NONE","body":"___\r\n\r\n## Overview\r\n\r\n- Describe the issue briefly\r\n\r\nI updated the library to 3.0.1 from 2.4.0 and now I'm seeing a Lint error saying \"Useless @OnShowRationale declaration\". It's not stopping me from compiling my code but I'm wondering why it's showing up because when I remove it, the function is no longer being used. Maybe it's because I'm checking for 2 permissions in the same Fragment?\r\n\r\n### Expected\r\n\r\n- What is the expected behavior?\r\n\r\nI guess not for it to show up since it doesn't seem to be useless.\r\n\r\n### Actual\r\n\r\n- What is the actual behavior?\r\n\r\n## Environment\r\n\r\n- Which library version are you using? \r\n\r\n3.0.1\r\n- On which devices do you observe the issue?\r\n- Note any other information that might be useful\r\n\r\n## Reproducible steps\r\n\r\n- While it's not required, it'd be perfect to add a link to a sample project where you encounter the issue\r\n\r\nIt's happening in [this class](https://github.com/silverAndroid/FriendStagram-Android/blob/master/app/src/main/java/rbsoftware/friendstagram/ui/fragment/SelectImageFragment.kt)"},"comment":{"url":"https://api.github.com/repos/permissions-dispatcher/PermissionsDispatcher/issues/comments/370099124","html_url":"https://github.com/permissions-dispatcher/PermissionsDispatcher/issues/407#issuecomment-370099124","issue_url":"https://api.github.com/repos/permissions-dispatcher/PermissionsDispatcher/issues/407","id":370099124,"user":{"login":"imminent","id":833939,"avatar_url":"https://avatars1.githubusercontent.com/u/833939?v=4","gravatar_id":"","url":"https://api.github.com/users/imminent","html_url":"https://github.com/imminent","followers_url":"https://api.github.com/users/imminent/followers","following_url":"https://api.github.com/users/imminent/following{/other_user}","gists_url":"https://api.github.com/users/imminent/gists{/gist_id}","starred_url":"https://api.github.com/users/imminent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imminent/subscriptions","organizations_url":"https://api.github.com/users/imminent/orgs","repos_url":"https://api.github.com/users/imminent/repos","events_url":"https://api.github.com/users/imminent/events{/privacy}","received_events_url":"https://api.github.com/users/imminent/received_events","type":"User","site_admin":false},"created_at":"2018-03-03T00:46:38Z","updated_at":"2018-03-03T00:46:38Z","author_association":"NONE","body":"I have this problem:\r\n```java\r\n@OnShowRationale(Manifest.permission.ACCESS_FINE_LOCATION)\r\nvoid showRationaleForLocationPermission(PermissionRequest request) { }\r\n\r\n@NeedsPermission(Manifest.permission.ACCESS_FINE_LOCATION)\r\nvoid getLocationPermissionAndLaunchMarket() { }\r\n```\r\nI see this same warning for useless OnShowRationale. Using 3.1.0"}}
{"actor":{"display_login":"imminent"}}