{"action":"created","issue":{"url":"https://api.github.com/repos/valyala/fasthttp/issues/472","repository_url":"https://api.github.com/repos/valyala/fasthttp","labels_url":"https://api.github.com/repos/valyala/fasthttp/issues/472/labels{/name}","comments_url":"https://api.github.com/repos/valyala/fasthttp/issues/472/comments","events_url":"https://api.github.com/repos/valyala/fasthttp/issues/472/events","html_url":"https://github.com/valyala/fasthttp/pull/472","id":382114379,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxODk1NDcx","number":472,"title":"reset connection read and write deadline for reuse","user":{"login":"zhaoxy2850","id":1196476,"node_id":"MDQ6VXNlcjExOTY0NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1196476?v=4","gravatar_id":"","url":"https://api.github.com/users/zhaoxy2850","html_url":"https://github.com/zhaoxy2850","followers_url":"https://api.github.com/users/zhaoxy2850/followers","following_url":"https://api.github.com/users/zhaoxy2850/following{/other_user}","gists_url":"https://api.github.com/users/zhaoxy2850/gists{/gist_id}","starred_url":"https://api.github.com/users/zhaoxy2850/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhaoxy2850/subscriptions","organizations_url":"https://api.github.com/users/zhaoxy2850/orgs","repos_url":"https://api.github.com/users/zhaoxy2850/repos","events_url":"https://api.github.com/users/zhaoxy2850/events{/privacy}","received_events_url":"https://api.github.com/users/zhaoxy2850/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-19T08:58:55Z","updated_at":"2018-11-19T11:05:14Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/valyala/fasthttp/pulls/472","html_url":"https://github.com/valyala/fasthttp/pull/472","diff_url":"https://github.com/valyala/fasthttp/pull/472.diff","patch_url":"https://github.com/valyala/fasthttp/pull/472.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/valyala/fasthttp/issues/comments/439855450","html_url":"https://github.com/valyala/fasthttp/pull/472#issuecomment-439855450","issue_url":"https://api.github.com/repos/valyala/fasthttp/issues/472","id":439855450,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTg1NTQ1MA==","user":{"login":"zhaoxy2850","id":1196476,"node_id":"MDQ6VXNlcjExOTY0NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1196476?v=4","gravatar_id":"","url":"https://api.github.com/users/zhaoxy2850","html_url":"https://github.com/zhaoxy2850","followers_url":"https://api.github.com/users/zhaoxy2850/followers","following_url":"https://api.github.com/users/zhaoxy2850/following{/other_user}","gists_url":"https://api.github.com/users/zhaoxy2850/gists{/gist_id}","starred_url":"https://api.github.com/users/zhaoxy2850/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhaoxy2850/subscriptions","organizations_url":"https://api.github.com/users/zhaoxy2850/orgs","repos_url":"https://api.github.com/users/zhaoxy2850/repos","events_url":"https://api.github.com/users/zhaoxy2850/events{/privacy}","received_events_url":"https://api.github.com/users/zhaoxy2850/received_events","type":"User","site_admin":false},"created_at":"2018-11-19T11:05:13Z","updated_at":"2018-11-19T11:05:13Z","author_association":"NONE","body":"> Besides the change I requested I think doing this in the `releaseConn` function is the best place. This makes idle connection not have any deadline and only has `MaxIdleConnDuration` affect idle connections.\r\n\r\nI'm doing this in the `releaseConn` function. Do you mean somewhere else? \r\nIf the `SetReadDeadline` is not called then the connection don't have deadline either. So it seems that setting the connection's deadline to time.Time{} will affect nothing?\r\nAnd I think idle connection don't need deadline because there is no reader or writer on idle connection. :)"}}
{"actor":{"display_login":"zhaoxy2850"}}