{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/comments/210848084","pull_request_review_id":147149452,"id":210848084,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDg0ODA4NA==","diff_hunk":"@@ -75,3 +76,46 @@ echo \"ECS_CLUSTER=${cluster_name}\" >> /etc/ecs/ecs.config\n yum install -y ecs-init\n start ecs\n service docker start\n+\n+case \"$AZ\" in\n+        \"eu-west-1a\")\n+            dns_name=\"mesh-1\"\n+            ;;\n+\n+        \"eu-west-1b\")\n+            dns_name=\"mesh-2\"\n+            ;;\n+\n+        \"eu-west-1c\")\n+            dns_name=\"mesh-3\"\n+            ;;\n+\n+         *)\n+            echo \"no Dns values found\"","path":"terraform/projects/app-ecs-instances/instance-user-data.tpl","position":27,"original_position":27,"commit_id":"8bfbe480a3b62576110538d64f067f006e776933","original_commit_id":"a21dc2185eae05a8efc7d14334a37c8f932f5bd9","user":{"login":"DavidJeche","id":36662109,"node_id":"MDQ6VXNlcjM2NjYyMTA5","avatar_url":"https://avatars2.githubusercontent.com/u/36662109?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidJeche","html_url":"https://github.com/DavidJeche","followers_url":"https://api.github.com/users/DavidJeche/followers","following_url":"https://api.github.com/users/DavidJeche/following{/other_user}","gists_url":"https://api.github.com/users/DavidJeche/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidJeche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidJeche/subscriptions","organizations_url":"https://api.github.com/users/DavidJeche/orgs","repos_url":"https://api.github.com/users/DavidJeche/repos","events_url":"https://api.github.com/users/DavidJeche/events{/privacy}","received_events_url":"https://api.github.com/users/DavidJeche/received_events","type":"User","site_admin":false},"body":"hmmm I believe that is a matter of preference. It is an iffy one. :/\r\n\r\nshould the script fail, I do not know at this stage. these are the last commands, i believe the purpose of this message is to have something in the log file. \r\n\r\nWhy would you want the script to fail as I am currently not sure ? ","created_at":"2018-08-17T09:04:43Z","updated_at":"2018-08-17T09:04:43Z","html_url":"https://github.com/alphagov/prometheus-aws-configuration-beta/pull/96#discussion_r210848084","pull_request_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/96","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/comments/210848084"},"html":{"href":"https://github.com/alphagov/prometheus-aws-configuration-beta/pull/96#discussion_r210848084"},"pull_request":{"href":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/96"}},"in_reply_to_id":210616244},"pull_request":{"url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/96","id":208756748,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NzU2NzQ4","html_url":"https://github.com/alphagov/prometheus-aws-configuration-beta/pull/96","diff_url":"https://github.com/alphagov/prometheus-aws-configuration-beta/pull/96.diff","patch_url":"https://github.com/alphagov/prometheus-aws-configuration-beta/pull/96.patch","issue_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/issues/96","number":96,"state":"open","locked":false,"title":"Alertmnager mesh direct","user":{"login":"DavidJeche","id":36662109,"node_id":"MDQ6VXNlcjM2NjYyMTA5","avatar_url":"https://avatars2.githubusercontent.com/u/36662109?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidJeche","html_url":"https://github.com/DavidJeche","followers_url":"https://api.github.com/users/DavidJeche/followers","following_url":"https://api.github.com/users/DavidJeche/following{/other_user}","gists_url":"https://api.github.com/users/DavidJeche/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidJeche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidJeche/subscriptions","organizations_url":"https://api.github.com/users/DavidJeche/orgs","repos_url":"https://api.github.com/users/DavidJeche/repos","events_url":"https://api.github.com/users/DavidJeche/events{/privacy}","received_events_url":"https://api.github.com/users/DavidJeche/received_events","type":"User","site_admin":false},"body":"# Why I am making this change\r\n\r\nAllow alertmanager's to mesh with each other in order to\r\nprevent duplicate states. Changes that include creating a new task definition.\r\nThis task definition will permit alert managers to mesh and it will also provide a single place\r\nto provide arguments for the task definition. To make it as clean as possible. Please feel\r\nfree to change anything you would like.\r\n\r\n# What approach I took\r\n\r\nOpen up a container port 9094. Dynamically add DNS record via start-up script. Change the way arguments are passed to the task definition to enable mesh system reference.\r\n\r\nVerify that this can function with one instance i.e dev environments.","created_at":"2018-08-16T06:26:25Z","updated_at":"2018-08-17T09:04:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"300e92ddb7939d693644158a1a023bfea32263e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/96/commits","review_comments_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/96/comments","review_comment_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/issues/96/comments","statuses_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/statuses/8bfbe480a3b62576110538d64f067f006e776933","head":{"label":"alphagov:alertmnager-mesh-direct","ref":"alertmnager-mesh-direct","sha":"8bfbe480a3b62576110538d64f067f006e776933","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":131585686,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE1ODU2ODY=","name":"prometheus-aws-configuration-beta","full_name":"alphagov/prometheus-aws-configuration-beta","owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/prometheus-aws-configuration-beta","description":"Terraform configuration to manage a Prometheus server running on AWS.","fork":false,"url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta","forks_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/forks","keys_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/teams","hooks_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/hooks","issue_events_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/events","assignees_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/tags","blobs_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/languages","stargazers_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/stargazers","contributors_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/contributors","subscribers_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/subscribers","subscription_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/subscription","commits_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/merges","archive_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/downloads","issues_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/deployments","created_at":"2018-04-30T11:04:47Z","updated_at":"2018-08-17T08:58:03Z","pushed_at":"2018-08-17T08:58:01Z","git_url":"git://github.com/alphagov/prometheus-aws-configuration-beta.git","ssh_url":"git@github.com:alphagov/prometheus-aws-configuration-beta.git","clone_url":"https://github.com/alphagov/prometheus-aws-configuration-beta.git","svn_url":"https://github.com/alphagov/prometheus-aws-configuration-beta","homepage":null,"size":393,"stargazers_count":3,"watchers_count":3,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"a9a86c571166845643505684261e01ef15ff8e98","user":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":131585686,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE1ODU2ODY=","name":"prometheus-aws-configuration-beta","full_name":"alphagov/prometheus-aws-configuration-beta","owner":{"login":"alphagov","id":596977,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5Njk3Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/prometheus-aws-configuration-beta","description":"Terraform configuration to manage a Prometheus server running on AWS.","fork":false,"url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta","forks_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/forks","keys_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/teams","hooks_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/hooks","issue_events_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/events","assignees_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/tags","blobs_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/languages","stargazers_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/stargazers","contributors_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/contributors","subscribers_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/subscribers","subscription_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/subscription","commits_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/merges","archive_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/downloads","issues_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/deployments","created_at":"2018-04-30T11:04:47Z","updated_at":"2018-08-17T08:58:03Z","pushed_at":"2018-08-17T08:58:01Z","git_url":"git://github.com/alphagov/prometheus-aws-configuration-beta.git","ssh_url":"git@github.com:alphagov/prometheus-aws-configuration-beta.git","clone_url":"https://github.com/alphagov/prometheus-aws-configuration-beta.git","svn_url":"https://github.com/alphagov/prometheus-aws-configuration-beta","homepage":null,"size":393,"stargazers_count":3,"watchers_count":3,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/96"},"html":{"href":"https://github.com/alphagov/prometheus-aws-configuration-beta/pull/96"},"issue":{"href":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/issues/96"},"comments":{"href":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/prometheus-aws-configuration-beta/statuses/8bfbe480a3b62576110538d64f067f006e776933"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"DavidJeche"}}