{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/comments/202800736","pull_request_review_id":137568124,"id":202800736,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjgwMDczNg==","diff_hunk":"@@ -370,8 +372,23 @@ HRESULT HandleMediaClick(\n         EventRegistrationToken mediaOpenedToken;\n         THROW_IF_FAILED(mediaElement->add_MediaOpened(Callback<IRoutedEventHandler>([=](IInspectable* /*sender*/, IRoutedEventArgs* /*args*/) -> HRESULT\n         {\n+            boolean audioOnly;\n+            RETURN_IF_FAILED(localMediaElement->get_IsAudioOnly(&audioOnly));\n+\n+            ComPtr<IImageSource> posterSource;\n+            RETURN_IF_FAILED(localMediaElement->get_PosterSource(&posterSource));\n+\n+            if (audioOnly && posterSource == nullptr)\n+            {\n+                // If this is audio only and there's no poster, set the height so that the \n+                // controls are visible.\n+                ComPtr<IFrameworkElement> mediaAsUiElement;\n+                RETURN_IF_FAILED(localMediaElement.As(&mediaAsUiElement));\n+                RETURN_IF_FAILED(mediaAsUiElement->put_Height(c_audioHeight));","path":"source/uwp/Renderer/lib/MediaHelpers.cpp","position":39,"original_position":39,"commit_id":"ae6c493a020f89bd3a69145bde472a5e6c96dfe1","original_commit_id":"ae6c493a020f89bd3a69145bde472a5e6c96dfe1","user":{"login":"khouzam","id":6656040,"node_id":"MDQ6VXNlcjY2NTYwNDA=","avatar_url":"https://avatars1.githubusercontent.com/u/6656040?v=4","gravatar_id":"","url":"https://api.github.com/users/khouzam","html_url":"https://github.com/khouzam","followers_url":"https://api.github.com/users/khouzam/followers","following_url":"https://api.github.com/users/khouzam/following{/other_user}","gists_url":"https://api.github.com/users/khouzam/gists{/gist_id}","starred_url":"https://api.github.com/users/khouzam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khouzam/subscriptions","organizations_url":"https://api.github.com/users/khouzam/orgs","repos_url":"https://api.github.com/users/khouzam/repos","events_url":"https://api.github.com/users/khouzam/events{/privacy}","received_events_url":"https://api.github.com/users/khouzam/received_events","type":"User","site_admin":false},"body":"Don't we already have a mediaAsUiElement variable above that we could use?","created_at":"2018-07-16T19:43:32Z","updated_at":"2018-07-16T19:43:33Z","html_url":"https://github.com/Microsoft/AdaptiveCards/pull/1713#discussion_r202800736","pull_request_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/1713","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/comments/202800736"},"html":{"href":"https://github.com/Microsoft/AdaptiveCards/pull/1713#discussion_r202800736"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/1713"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/1713","id":201415509,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDE1NTA5","html_url":"https://github.com/Microsoft/AdaptiveCards/pull/1713","diff_url":"https://github.com/Microsoft/AdaptiveCards/pull/1713.diff","patch_url":"https://github.com/Microsoft/AdaptiveCards/pull/1713.patch","issue_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/1713","number":1713,"state":"open","locked":false,"title":"Media fixes","user":{"login":"RebeccaAnne","id":9091833,"node_id":"MDQ6VXNlcjkwOTE4MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/9091833?v=4","gravatar_id":"","url":"https://api.github.com/users/RebeccaAnne","html_url":"https://github.com/RebeccaAnne","followers_url":"https://api.github.com/users/RebeccaAnne/followers","following_url":"https://api.github.com/users/RebeccaAnne/following{/other_user}","gists_url":"https://api.github.com/users/RebeccaAnne/gists{/gist_id}","starred_url":"https://api.github.com/users/RebeccaAnne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RebeccaAnne/subscriptions","organizations_url":"https://api.github.com/users/RebeccaAnne/orgs","repos_url":"https://api.github.com/users/RebeccaAnne/repos","events_url":"https://api.github.com/users/RebeccaAnne/events{/privacy}","received_events_url":"https://api.github.com/users/RebeccaAnne/received_events","type":"User","site_admin":false},"body":"- Fixed a bug which lead to missing posters when interactivity was off\r\n- Made sure the entire touch target was made collapsed rather than just the poster\r\n- Added a height to the media element in the audio case to ensure it was displayed when there is no poster","created_at":"2018-07-13T22:40:52Z","updated_at":"2018-07-16T19:43:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7734a2ab293250cabfd69c78610d7295df00436e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":612522065,"node_id":"MDU6TGFiZWw2MTI1MjIwNjU=","url":"https://api.github.com/repos/Microsoft/AdaptiveCards/labels/Platform-UWP","name":"Platform-UWP","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/1713/commits","review_comments_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/1713/comments","review_comment_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/1713/comments","statuses_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/statuses/ae6c493a020f89bd3a69145bde472a5e6c96dfe1","head":{"label":"Microsoft:rebecch/mediafixes","ref":"rebecch/mediafixes","sha":"ae6c493a020f89bd3a69145bde472a5e6c96dfe1","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":75978731,"node_id":"MDEwOlJlcG9zaXRvcnk3NTk3ODczMQ==","name":"AdaptiveCards","full_name":"Microsoft/AdaptiveCards","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/AdaptiveCards","description":"A new way for developers to exchange card content in a common and consistent way.","fork":false,"url":"https://api.github.com/repos/Microsoft/AdaptiveCards","forks_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/forks","keys_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/teams","hooks_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/events","assignees_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/tags","blobs_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/languages","stargazers_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/subscription","commits_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/merges","archive_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/downloads","issues_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/deployments","created_at":"2016-12-08T22:00:33Z","updated_at":"2018-07-13T18:23:46Z","pushed_at":"2018-07-14T00:22:19Z","git_url":"git://github.com/Microsoft/AdaptiveCards.git","ssh_url":"git@github.com:Microsoft/AdaptiveCards.git","clone_url":"https://github.com/Microsoft/AdaptiveCards.git","svn_url":"https://github.com/Microsoft/AdaptiveCards","homepage":"http://adaptivecards.io","size":74518,"stargazers_count":348,"watchers_count":348,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":371,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":87,"open_issues":371,"watchers":348,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"f8237a7c3ea6616df829f3930d894a896e068594","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":75978731,"node_id":"MDEwOlJlcG9zaXRvcnk3NTk3ODczMQ==","name":"AdaptiveCards","full_name":"Microsoft/AdaptiveCards","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/AdaptiveCards","description":"A new way for developers to exchange card content in a common and consistent way.","fork":false,"url":"https://api.github.com/repos/Microsoft/AdaptiveCards","forks_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/forks","keys_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/teams","hooks_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/events","assignees_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/tags","blobs_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/languages","stargazers_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/subscription","commits_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/merges","archive_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/downloads","issues_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/deployments","created_at":"2016-12-08T22:00:33Z","updated_at":"2018-07-13T18:23:46Z","pushed_at":"2018-07-14T00:22:19Z","git_url":"git://github.com/Microsoft/AdaptiveCards.git","ssh_url":"git@github.com:Microsoft/AdaptiveCards.git","clone_url":"https://github.com/Microsoft/AdaptiveCards.git","svn_url":"https://github.com/Microsoft/AdaptiveCards","homepage":"http://adaptivecards.io","size":74518,"stargazers_count":348,"watchers_count":348,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":371,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":87,"open_issues":371,"watchers":348,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/1713"},"html":{"href":"https://github.com/Microsoft/AdaptiveCards/pull/1713"},"issue":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/1713"},"comments":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/1713/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/1713/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/1713/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/statuses/ae6c493a020f89bd3a69145bde472a5e6c96dfe1"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"khouzam"}}