{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/220256710","pull_request_review_id":158622711,"id":220256710,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDI1NjcxMA==","diff_hunk":"@@ -26,16 +25,14 @@\n     SymSgdClassificationTrainer.LoadNameValue,\n     SymSgdClassificationTrainer.ShortName)]\n \n-[assembly: LoadableClass(typeof(void), typeof(SymSgdClassificationTrainer), null, typeof(SignatureEntryPointModule), \"SymSGD\")]\n+[assembly: LoadableClass(typeof(void), typeof(SymSgdClassificationTrainer), null, typeof(SignatureEntryPointModule), SymSgdClassificationTrainer.LoadNameValue)]\n \n namespace Microsoft.ML.Runtime.SymSgd\n {\n-    using TPredictor = IPredictorWithFeatureWeights<Float>;\n+    using TPredictor = IPredictorWithFeatureWeights<float>;\n \n     /// <include file='doc.xml' path='doc/members/member[@name=\"SymSGD\"]/*' />\n-    public sealed class SymSgdClassificationTrainer :\n-        TrainerBase<TPredictor>,\n-        ITrainer<TPredictor>\n+    public sealed class SymSgdClassificationTrainer : TrainerEstimatorBase<BinaryPredictionTransformer<TPredictor>, TPredictor>","path":"src/Microsoft.ML.HalLearners/SymSgdClassificationTrainer.cs","position":30,"original_position":30,"commit_id":"669725705de6ff7f3b3d932c47d86f7ef228575f","original_commit_id":"669725705de6ff7f3b3d932c47d86f7ef228575f","user":{"login":"artidoro","id":11949572,"node_id":"MDQ6VXNlcjExOTQ5NTcy","avatar_url":"https://avatars1.githubusercontent.com/u/11949572?v=4","gravatar_id":"","url":"https://api.github.com/users/artidoro","html_url":"https://github.com/artidoro","followers_url":"https://api.github.com/users/artidoro/followers","following_url":"https://api.github.com/users/artidoro/following{/other_user}","gists_url":"https://api.github.com/users/artidoro/gists{/gist_id}","starred_url":"https://api.github.com/users/artidoro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artidoro/subscriptions","organizations_url":"https://api.github.com/users/artidoro/orgs","repos_url":"https://api.github.com/users/artidoro/repos","events_url":"https://api.github.com/users/artidoro/events{/privacy}","received_events_url":"https://api.github.com/users/artidoro/received_events","type":"User","site_admin":false},"body":"Sorry I can't find that. what is the name of the base class I \r\nshould derive from?\r\n\r\n---\r\nIn reply to: [220056284](https://github.com/dotnet/machinelearning/pull/1012#discussion_r220056284) [](ancestors = 220056284)","created_at":"2018-09-25T16:07:37Z","updated_at":"2018-09-25T16:07:37Z","html_url":"https://github.com/dotnet/machinelearning/pull/1012#discussion_r220256710","pull_request_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1012","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/220256710"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/1012#discussion_r220256710"},"pull_request":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1012"}},"in_reply_to_id":220056284},"pull_request":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1012","id":217820218,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3ODIwMjE4","html_url":"https://github.com/dotnet/machinelearning/pull/1012","diff_url":"https://github.com/dotnet/machinelearning/pull/1012.diff","patch_url":"https://github.com/dotnet/machinelearning/pull/1012.patch","issue_url":"https://api.github.com/repos/dotnet/machinelearning/issues/1012","number":1012,"state":"open","locked":false,"title":"WIP: Conversion of Parallel Stochastic Gradient Descent (SymSGD) to estimator","user":{"login":"artidoro","id":11949572,"node_id":"MDQ6VXNlcjExOTQ5NTcy","avatar_url":"https://avatars1.githubusercontent.com/u/11949572?v=4","gravatar_id":"","url":"https://api.github.com/users/artidoro","html_url":"https://github.com/artidoro","followers_url":"https://api.github.com/users/artidoro/followers","following_url":"https://api.github.com/users/artidoro/following{/other_user}","gists_url":"https://api.github.com/users/artidoro/gists{/gist_id}","starred_url":"https://api.github.com/users/artidoro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artidoro/subscriptions","organizations_url":"https://api.github.com/users/artidoro/orgs","repos_url":"https://api.github.com/users/artidoro/repos","events_url":"https://api.github.com/users/artidoro/events{/privacy}","received_events_url":"https://api.github.com/users/artidoro/received_events","type":"User","site_admin":false},"body":"Ongoing work on converting the trainers to estimators. This PR converts the Parallel Stochastic Gradient Descent classification trainer (SymSGD).","created_at":"2018-09-24T23:53:50Z","updated_at":"2018-09-25T16:07:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a228b65559250bd8ab64f2c860d74c36466c189","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sfilipi","id":19392467,"node_id":"MDQ6VXNlcjE5MzkyNDY3","avatar_url":"https://avatars1.githubusercontent.com/u/19392467?v=4","gravatar_id":"","url":"https://api.github.com/users/sfilipi","html_url":"https://github.com/sfilipi","followers_url":"https://api.github.com/users/sfilipi/followers","following_url":"https://api.github.com/users/sfilipi/following{/other_user}","gists_url":"https://api.github.com/users/sfilipi/gists{/gist_id}","starred_url":"https://api.github.com/users/sfilipi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfilipi/subscriptions","organizations_url":"https://api.github.com/users/sfilipi/orgs","repos_url":"https://api.github.com/users/sfilipi/repos","events_url":"https://api.github.com/users/sfilipi/events{/privacy}","received_events_url":"https://api.github.com/users/sfilipi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":923215346,"node_id":"MDU6TGFiZWw5MjMyMTUzNDY=","url":"https://api.github.com/repos/dotnet/machinelearning/labels/api","name":"api","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1012/commits","review_comments_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/1012/comments","review_comment_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/issues/1012/comments","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/669725705de6ff7f3b3d932c47d86f7ef228575f","head":{"label":"artidoro:symbolicsgd","ref":"symbolicsgd","sha":"669725705de6ff7f3b3d932c47d86f7ef228575f","user":{"login":"artidoro","id":11949572,"node_id":"MDQ6VXNlcjExOTQ5NTcy","avatar_url":"https://avatars1.githubusercontent.com/u/11949572?v=4","gravatar_id":"","url":"https://api.github.com/users/artidoro","html_url":"https://github.com/artidoro","followers_url":"https://api.github.com/users/artidoro/followers","following_url":"https://api.github.com/users/artidoro/following{/other_user}","gists_url":"https://api.github.com/users/artidoro/gists{/gist_id}","starred_url":"https://api.github.com/users/artidoro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artidoro/subscriptions","organizations_url":"https://api.github.com/users/artidoro/orgs","repos_url":"https://api.github.com/users/artidoro/repos","events_url":"https://api.github.com/users/artidoro/events{/privacy}","received_events_url":"https://api.github.com/users/artidoro/received_events","type":"User","site_admin":false},"repo":{"id":146929905,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY5Mjk5MDU=","name":"machinelearning","full_name":"artidoro/machinelearning","private":false,"owner":{"login":"artidoro","id":11949572,"node_id":"MDQ6VXNlcjExOTQ5NTcy","avatar_url":"https://avatars1.githubusercontent.com/u/11949572?v=4","gravatar_id":"","url":"https://api.github.com/users/artidoro","html_url":"https://github.com/artidoro","followers_url":"https://api.github.com/users/artidoro/followers","following_url":"https://api.github.com/users/artidoro/following{/other_user}","gists_url":"https://api.github.com/users/artidoro/gists{/gist_id}","starred_url":"https://api.github.com/users/artidoro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artidoro/subscriptions","organizations_url":"https://api.github.com/users/artidoro/orgs","repos_url":"https://api.github.com/users/artidoro/repos","events_url":"https://api.github.com/users/artidoro/events{/privacy}","received_events_url":"https://api.github.com/users/artidoro/received_events","type":"User","site_admin":false},"html_url":"https://github.com/artidoro/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":true,"url":"https://api.github.com/repos/artidoro/machinelearning","forks_url":"https://api.github.com/repos/artidoro/machinelearning/forks","keys_url":"https://api.github.com/repos/artidoro/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artidoro/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artidoro/machinelearning/teams","hooks_url":"https://api.github.com/repos/artidoro/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/artidoro/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/artidoro/machinelearning/events","assignees_url":"https://api.github.com/repos/artidoro/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/artidoro/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/artidoro/machinelearning/tags","blobs_url":"https://api.github.com/repos/artidoro/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artidoro/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artidoro/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/artidoro/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artidoro/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/artidoro/machinelearning/languages","stargazers_url":"https://api.github.com/repos/artidoro/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/artidoro/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/artidoro/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/artidoro/machinelearning/subscription","commits_url":"https://api.github.com/repos/artidoro/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/artidoro/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/artidoro/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/artidoro/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/artidoro/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/artidoro/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artidoro/machinelearning/merges","archive_url":"https://api.github.com/repos/artidoro/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artidoro/machinelearning/downloads","issues_url":"https://api.github.com/repos/artidoro/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/artidoro/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/artidoro/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/artidoro/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artidoro/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/artidoro/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/artidoro/machinelearning/deployments","created_at":"2018-08-31T18:37:49Z","updated_at":"2018-09-21T17:43:08Z","pushed_at":"2018-09-25T03:06:34Z","git_url":"git://github.com/artidoro/machinelearning.git","ssh_url":"git@github.com:artidoro/machinelearning.git","clone_url":"https://github.com/artidoro/machinelearning.git","svn_url":"https://github.com/artidoro/machinelearning","homepage":"https://dot.net/ml","size":23113,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"5874e16fd652d93630e0622a756f1b913ca8ea55","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":132021166,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwMjExNjY=","name":"machinelearning","full_name":"dotnet/machinelearning","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":false,"url":"https://api.github.com/repos/dotnet/machinelearning","forks_url":"https://api.github.com/repos/dotnet/machinelearning/forks","keys_url":"https://api.github.com/repos/dotnet/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/machinelearning/teams","hooks_url":"https://api.github.com/repos/dotnet/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/dotnet/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/machinelearning/events","assignees_url":"https://api.github.com/repos/dotnet/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/machinelearning/tags","blobs_url":"https://api.github.com/repos/dotnet/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/machinelearning/languages","stargazers_url":"https://api.github.com/repos/dotnet/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/dotnet/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/dotnet/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/dotnet/machinelearning/subscription","commits_url":"https://api.github.com/repos/dotnet/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/machinelearning/merges","archive_url":"https://api.github.com/repos/dotnet/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/machinelearning/downloads","issues_url":"https://api.github.com/repos/dotnet/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/machinelearning/deployments","created_at":"2018-05-03T16:20:42Z","updated_at":"2018-09-25T15:11:50Z","pushed_at":"2018-09-25T16:07:04Z","git_url":"git://github.com/dotnet/machinelearning.git","ssh_url":"git@github.com:dotnet/machinelearning.git","clone_url":"https://github.com/dotnet/machinelearning.git","svn_url":"https://github.com/dotnet/machinelearning","homepage":"https://dot.net/ml","size":22960,"stargazers_count":3686,"watchers_count":3686,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":607,"mirror_url":null,"archived":false,"open_issues_count":335,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":607,"open_issues":335,"watchers":3686,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1012"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/1012"},"issue":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/1012"},"comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/1012/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1012/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/1012/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/machinelearning/statuses/669725705de6ff7f3b3d932c47d86f7ef228575f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"artidoro"}}