{"action":"created","issue":{"url":"https://api.github.com/repos/folio-org/mod-kb-ebsco/issues/160","repository_url":"https://api.github.com/repos/folio-org/mod-kb-ebsco","labels_url":"https://api.github.com/repos/folio-org/mod-kb-ebsco/issues/160/labels{/name}","comments_url":"https://api.github.com/repos/folio-org/mod-kb-ebsco/issues/160/comments","events_url":"https://api.github.com/repos/folio-org/mod-kb-ebsco/issues/160/events","html_url":"https://github.com/folio-org/mod-kb-ebsco/pull/160","id":330418407,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNDM0MDIy","number":160,"title":"Fix raml-cop issues and modify examples for request payloads","user":{"login":"sduvvuri-ebsco","id":33662516,"node_id":"MDQ6VXNlcjMzNjYyNTE2","avatar_url":"https://avatars3.githubusercontent.com/u/33662516?v=4","gravatar_id":"","url":"https://api.github.com/users/sduvvuri-ebsco","html_url":"https://github.com/sduvvuri-ebsco","followers_url":"https://api.github.com/users/sduvvuri-ebsco/followers","following_url":"https://api.github.com/users/sduvvuri-ebsco/following{/other_user}","gists_url":"https://api.github.com/users/sduvvuri-ebsco/gists{/gist_id}","starred_url":"https://api.github.com/users/sduvvuri-ebsco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sduvvuri-ebsco/subscriptions","organizations_url":"https://api.github.com/users/sduvvuri-ebsco/orgs","repos_url":"https://api.github.com/users/sduvvuri-ebsco/repos","events_url":"https://api.github.com/users/sduvvuri-ebsco/events{/privacy}","received_events_url":"https://api.github.com/users/sduvvuri-ebsco/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-07T20:10:54Z","updated_at":"2018-06-08T01:36:06Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/folio-org/mod-kb-ebsco/pulls/160","html_url":"https://github.com/folio-org/mod-kb-ebsco/pull/160","diff_url":"https://github.com/folio-org/mod-kb-ebsco/pull/160.diff","patch_url":"https://github.com/folio-org/mod-kb-ebsco/pull/160.patch"},"body":"## Purpose\r\nNoticed that raml-cop was showing issues at the latest master for one of the `providers` examples.\r\nAlso, noticed that if we do not have a \"type\" attribute in the request payload, then the request to mod-kb fails. \r\n\r\n## Approach\r\n- Fix raml-cop issue\r\n- Add \"type\" attribute to all request payloads and schema\r\n- Add request example for `providers` and split out examples to follow the new pattern we established.\r\n"},"comment":{"url":"https://api.github.com/repos/folio-org/mod-kb-ebsco/issues/comments/395618026","html_url":"https://github.com/folio-org/mod-kb-ebsco/pull/160#issuecomment-395618026","issue_url":"https://api.github.com/repos/folio-org/mod-kb-ebsco/issues/160","id":395618026,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTYxODAyNg==","user":{"login":"dcrossleyau","id":8520792,"node_id":"MDQ6VXNlcjg1MjA3OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/8520792?v=4","gravatar_id":"","url":"https://api.github.com/users/dcrossleyau","html_url":"https://github.com/dcrossleyau","followers_url":"https://api.github.com/users/dcrossleyau/followers","following_url":"https://api.github.com/users/dcrossleyau/following{/other_user}","gists_url":"https://api.github.com/users/dcrossleyau/gists{/gist_id}","starred_url":"https://api.github.com/users/dcrossleyau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcrossleyau/subscriptions","organizations_url":"https://api.github.com/users/dcrossleyau/orgs","repos_url":"https://api.github.com/users/dcrossleyau/repos","events_url":"https://api.github.com/users/dcrossleyau/events{/privacy}","received_events_url":"https://api.github.com/users/dcrossleyau/received_events","type":"User","site_admin":false},"created_at":"2018-06-08T01:36:06Z","updated_at":"2018-06-08T01:36:06Z","author_association":"CONTRIBUTOR","body":"I noticed that you have some \"example: !include ...\" entries that have a leading slash on the include path and some that do not.\r\n\r\nDo you know what is the best practice (i do not hence the question)?\r\n\r\nAll of our other RAMLs have no leading slash."}}
{"actor":{"display_login":"dcrossleyau"}}