{"action":"created","issue":{"url":"https://api.github.com/repos/gismo/gismo/issues/280","repository_url":"https://api.github.com/repos/gismo/gismo","labels_url":"https://api.github.com/repos/gismo/gismo/issues/280/labels{/name}","comments_url":"https://api.github.com/repos/gismo/gismo/issues/280/comments","events_url":"https://api.github.com/repos/gismo/gismo/issues/280/events","html_url":"https://github.com/gismo/gismo/pull/280","id":392247273,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NTYxNDQw","number":280,"title":"fix for https://github.com/gismo/internal/issues/4","user":{"login":"codewerfer","id":29753931,"node_id":"MDQ6VXNlcjI5NzUzOTMx","avatar_url":"https://avatars2.githubusercontent.com/u/29753931?v=4","gravatar_id":"","url":"https://api.github.com/users/codewerfer","html_url":"https://github.com/codewerfer","followers_url":"https://api.github.com/users/codewerfer/followers","following_url":"https://api.github.com/users/codewerfer/following{/other_user}","gists_url":"https://api.github.com/users/codewerfer/gists{/gist_id}","starred_url":"https://api.github.com/users/codewerfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codewerfer/subscriptions","organizations_url":"https://api.github.com/users/codewerfer/orgs","repos_url":"https://api.github.com/users/codewerfer/repos","events_url":"https://api.github.com/users/codewerfer/events{/privacy}","received_events_url":"https://api.github.com/users/codewerfer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-12-18T16:55:59Z","updated_at":"2019-01-02T13:21:12Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/gismo/gismo/pulls/280","html_url":"https://github.com/gismo/gismo/pull/280","diff_url":"https://github.com/gismo/gismo/pull/280.diff","patch_url":"https://github.com/gismo/gismo/pull/280.patch"},"body":"fix for https://github.com/gismo/internal/issues/4"},"comment":{"url":"https://api.github.com/repos/gismo/gismo/issues/comments/450861583","html_url":"https://github.com/gismo/gismo/pull/280#issuecomment-450861583","issue_url":"https://api.github.com/repos/gismo/gismo/issues/280","id":450861583,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDg2MTU4Mw==","user":{"login":"codewerfer","id":29753931,"node_id":"MDQ6VXNlcjI5NzUzOTMx","avatar_url":"https://avatars2.githubusercontent.com/u/29753931?v=4","gravatar_id":"","url":"https://api.github.com/users/codewerfer","html_url":"https://github.com/codewerfer","followers_url":"https://api.github.com/users/codewerfer/followers","following_url":"https://api.github.com/users/codewerfer/following{/other_user}","gists_url":"https://api.github.com/users/codewerfer/gists{/gist_id}","starred_url":"https://api.github.com/users/codewerfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codewerfer/subscriptions","organizations_url":"https://api.github.com/users/codewerfer/orgs","repos_url":"https://api.github.com/users/codewerfer/repos","events_url":"https://api.github.com/users/codewerfer/events{/privacy}","received_events_url":"https://api.github.com/users/codewerfer/received_events","type":"User","site_admin":false},"created_at":"2019-01-02T13:21:12Z","updated_at":"2019-01-02T13:21:12Z","author_association":"MEMBER","body":"> I would prefer an enum:\r\n> \r\n> class gsCDRAssembler{\r\n> \r\n> //...\r\n> enum stabilizationMethod { noStabilization=0, SUPG=1 };\r\n> \r\n>// ...\r\n> \r\n> };\r\n> \r\n> and take only parameters of that type. The gsOptionList is kept as-is.\r\n> \r\n> That would be consistent with dirichletStrategy and iFaceStrategy.\r\n\r\n> I would not put it to gsAssemblerOptions because its only related to this one assembler\r\n\r\nOK, but to be consistent, this means also to use the enum in `gsVisitorCDR.h`, and that means an include of `gsCDRAssembler.h`, that includes already `gsVisitorCDR.h`. \\\r\nTherefore it makes more sense to add the enum to `gsVisitorCDR.h` instead."}}
{"actor":{"display_login":"codewerfer"}}