{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/2634","repository_url":"https://api.github.com/repos/puppetlabs/puppetdb","labels_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/2634/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/2634/comments","events_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/2634/events","html_url":"https://github.com/puppetlabs/puppetdb/pull/2634","id":367222905,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNzEwNzU0","number":2634,"title":"Add configuration options to the terminus to filter facts out","user":{"login":"nbarrientos","id":131893,"node_id":"MDQ6VXNlcjEzMTg5Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/131893?v=4","gravatar_id":"","url":"https://api.github.com/users/nbarrientos","html_url":"https://github.com/nbarrientos","followers_url":"https://api.github.com/users/nbarrientos/followers","following_url":"https://api.github.com/users/nbarrientos/following{/other_user}","gists_url":"https://api.github.com/users/nbarrientos/gists{/gist_id}","starred_url":"https://api.github.com/users/nbarrientos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbarrientos/subscriptions","organizations_url":"https://api.github.com/users/nbarrientos/orgs","repos_url":"https://api.github.com/users/nbarrientos/repos","events_url":"https://api.github.com/users/nbarrientos/events{/privacy}","received_events_url":"https://api.github.com/users/nbarrientos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-05T13:56:11Z","updated_at":"2018-10-05T13:57:02Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2634","html_url":"https://github.com/puppetlabs/puppetdb/pull/2634","diff_url":"https://github.com/puppetlabs/puppetdb/pull/2634.diff","patch_url":"https://github.com/puppetlabs/puppetdb/pull/2634.patch"},"body":"This changeset adds two configuration options to be consumed by the facts PuppetDB indirector:\r\n\r\n  * fact_names_blacklist\r\n  * fact_names_blacklist_regex\r\n\r\nThey can be used to configure a list of fact names that will never be sent to PuppetDB, based on exact fact names or regular expressions. I'm aware that PuppetDB [supports black listing facts](https://puppet.com/docs/puppetdb/5.1/configure.html#facts-blacklist) but over here we do prefer to filter them in the origin to avoid sending bits over the wire that will be discarded by the other end.\r\n\r\nI'm happy to further develop the change request adding tests and documentation if you're interested."},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/comments/427374828","html_url":"https://github.com/puppetlabs/puppetdb/pull/2634#issuecomment-427374828","issue_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/2634","id":427374828,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzM3NDgyOA==","user":{"login":"puppetlabs-jenkins","id":1050976,"node_id":"MDQ6VXNlcjEwNTA5NzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1050976?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs-jenkins","html_url":"https://github.com/puppetlabs-jenkins","followers_url":"https://api.github.com/users/puppetlabs-jenkins/followers","following_url":"https://api.github.com/users/puppetlabs-jenkins/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs-jenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs-jenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs-jenkins/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs-jenkins/orgs","repos_url":"https://api.github.com/users/puppetlabs-jenkins/repos","events_url":"https://api.github.com/users/puppetlabs-jenkins/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs-jenkins/received_events","type":"User","site_admin":false},"created_at":"2018-10-05T13:57:02Z","updated_at":"2018-10-05T13:57:02Z","author_association":"CONTRIBUTOR","body":"Can one of the admins verify this patch?"}}
{"actor":{"display_login":"puppetlabs-jenkins"}}