{"action":"created","issue":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/12927","repository_url":"https://api.github.com/repos/civicrm/civicrm-core","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/12927/labels{/name}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/12927/comments","events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/12927/events","html_url":"https://github.com/civicrm/civicrm-core/pull/12927","id":369241684,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjMwMDkx","number":12927,"title":"Added further tests for process_membership job: check status for inherited memberships","user":{"login":"davejenx","id":5641482,"node_id":"MDQ6VXNlcjU2NDE0ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/5641482?v=4","gravatar_id":"","url":"https://api.github.com/users/davejenx","html_url":"https://github.com/davejenx","followers_url":"https://api.github.com/users/davejenx/followers","following_url":"https://api.github.com/users/davejenx/following{/other_user}","gists_url":"https://api.github.com/users/davejenx/gists{/gist_id}","starred_url":"https://api.github.com/users/davejenx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davejenx/subscriptions","organizations_url":"https://api.github.com/users/davejenx/orgs","repos_url":"https://api.github.com/users/davejenx/repos","events_url":"https://api.github.com/users/davejenx/events{/privacy}","received_events_url":"https://api.github.com/users/davejenx/received_events","type":"User","site_admin":false},"labels":[{"id":246037889,"node_id":"MDU6TGFiZWwyNDYwMzc4ODk=","url":"https://api.github.com/repos/civicrm/civicrm-core/labels/master","name":"master","color":"0052cc","default":false},{"id":275096971,"node_id":"MDU6TGFiZWwyNzUwOTY5NzE=","url":"https://api.github.com/repos/civicrm/civicrm-core/labels/merge%20on%20pass","name":"merge on pass","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-10-11T18:08:47Z","updated_at":"2018-10-11T20:01:05Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/12927","html_url":"https://github.com/civicrm/civicrm-core/pull/12927","diff_url":"https://github.com/civicrm/civicrm-core/pull/12927.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/12927.patch"},"body":"Overview\r\n----------------------------------------\r\nAdded further checks for process_membership job: check that status is updated correctly for inherited membership. In function testProcessMembershipUpdateStatus.\r\n\r\nBefore\r\n----------------------------------------\r\nNo tests for inherited membership processing.\r\n\r\nAfter\r\n----------------------------------------\r\nTests for inherited membership processing.\r\n\r\nTechnical Details\r\n----------------------------------------\r\nIn existing function testProcessMembershipUpdateStatus.\r\n\r\nComments\r\n----------------------------------------\r\nTest was failing during development with inherited membership being deleted. Tracked this down to a static variable in CRM_Member_BAO_Membership::createRelatedMemberships(). There is a reset parameter for this static, so I used that to work around the problem. The issue should not occur outside tests. An alternative approach would be to replace the static variable with Civi::$statics but note reset facility is used elsewhere: CRM-17723. See CRM-4213, CRM-19735."},"comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments/429098162","html_url":"https://github.com/civicrm/civicrm-core/pull/12927#issuecomment-429098162","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/12927","id":429098162,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTA5ODE2Mg==","user":{"login":"davejenx","id":5641482,"node_id":"MDQ6VXNlcjU2NDE0ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/5641482?v=4","gravatar_id":"","url":"https://api.github.com/users/davejenx","html_url":"https://github.com/davejenx","followers_url":"https://api.github.com/users/davejenx/followers","following_url":"https://api.github.com/users/davejenx/following{/other_user}","gists_url":"https://api.github.com/users/davejenx/gists{/gist_id}","starred_url":"https://api.github.com/users/davejenx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davejenx/subscriptions","organizations_url":"https://api.github.com/users/davejenx/orgs","repos_url":"https://api.github.com/users/davejenx/repos","events_url":"https://api.github.com/users/davejenx/events{/privacy}","received_events_url":"https://api.github.com/users/davejenx/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T20:01:05Z","updated_at":"2018-10-11T20:01:05Z","author_association":"CONTRIBUTOR","body":"@eileenmcnaughton I'm not familiar with how that's done."}}
{"actor":{"display_login":"davejenx"}}