{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/18966","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/18966/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/18966/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/18966/events","html_url":"https://github.com/joomla/joomla-cms/pull/18966","id":278817428,"node_id":"MDExOlB1bGxSZXF1ZXN0MTU2MDc5MTQ3","number":18966,"title":"Only add search module in error page if current JDocument is HtmlDocument","user":{"login":"ggppdk","id":5092940,"node_id":"MDQ6VXNlcjUwOTI5NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/5092940?v=4","gravatar_id":"","url":"https://api.github.com/users/ggppdk","html_url":"https://github.com/ggppdk","followers_url":"https://api.github.com/users/ggppdk/followers","following_url":"https://api.github.com/users/ggppdk/following{/other_user}","gists_url":"https://api.github.com/users/ggppdk/gists{/gist_id}","starred_url":"https://api.github.com/users/ggppdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggppdk/subscriptions","organizations_url":"https://api.github.com/users/ggppdk/orgs","repos_url":"https://api.github.com/users/ggppdk/repos","events_url":"https://api.github.com/users/ggppdk/events{/privacy}","received_events_url":"https://api.github.com/users/ggppdk/received_events","type":"User","site_admin":false},"labels":[{"id":60721348,"node_id":"MDU6TGFiZWw2MDcyMTM0OA==","url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2017-12-03T20:36:59Z","updated_at":"2018-12-07T00:34:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/18966","html_url":"https://github.com/joomla/joomla-cms/pull/18966","diff_url":"https://github.com/joomla/joomla-cms/pull/18966.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/18966.patch"},"body":"Pull Request for Issue #18962 \r\n\r\n### Summary of Changes\r\nIf you try to add a module in error page of any joomla template\r\n- then this module may result in calling methods that only exist if JDocument is of type **HtmlDocument**\r\n\r\nThen in all other document types you will get a new fatal error during error page creation\r\ne.g. addHeadLink() method only exists in HtmlDocument\r\n\r\nIn J3.8.2 the adding of search module into the error was fixed (**templates protostar and beez3**)\r\nby PR #18375\r\nwhich was a good thing, but it results in issue describe in #18962 \r\n\r\n\r\n### Testing Instructions\r\nSee #18962\r\n\r\n\r\n### Expected result\r\nSee #18962\r\n\r\n\r\n### Actual result\r\nSee #18962\r\n\r\n\r\n### Documentation Changes Required\r\nNone\r\n"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/445081216","html_url":"https://github.com/joomla/joomla-cms/pull/18966#issuecomment-445081216","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/18966","id":445081216,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTA4MTIxNg==","user":{"login":"sshcli","id":12942731,"node_id":"MDQ6VXNlcjEyOTQyNzMx","avatar_url":"https://avatars1.githubusercontent.com/u/12942731?v=4","gravatar_id":"","url":"https://api.github.com/users/sshcli","html_url":"https://github.com/sshcli","followers_url":"https://api.github.com/users/sshcli/followers","following_url":"https://api.github.com/users/sshcli/following{/other_user}","gists_url":"https://api.github.com/users/sshcli/gists{/gist_id}","starred_url":"https://api.github.com/users/sshcli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sshcli/subscriptions","organizations_url":"https://api.github.com/users/sshcli/orgs","repos_url":"https://api.github.com/users/sshcli/repos","events_url":"https://api.github.com/users/sshcli/events{/privacy}","received_events_url":"https://api.github.com/users/sshcli/received_events","type":"User","site_admin":false},"created_at":"2018-12-07T00:34:49Z","updated_at":"2018-12-07T00:34:49Z","author_association":"CONTRIBUTOR","body":"I have tested this item :white_check_mark: successfully on 70222c1760003a2e38c86b126d31d25e92d79ef1<hr /><sub>This comment was created with the <a href=\"https://github.com/joomla/jissues\">J!Tracker Application</a> at <a href=\"https://issues.joomla.org/tracker/joomla-cms/18966\">issues.joomla.org/tracker/joomla-cms/18966</a>.</sub>"}}
{"actor":{"display_login":"sshcli"}}