{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/214183415","pull_request_review_id":151185837,"id":214183415,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDE4MzQxNQ==","diff_hunk":"@@ -215,14 +216,20 @@ synchronized void unlockGlobalState() throws IOException {\n     synchronized void unlock(final TaskId taskId) throws IOException {\n         final LockAndOwner lockAndOwner = locks.get(taskId);\n         if (lockAndOwner != null && lockAndOwner.owningThread.equals(Thread.currentThread().getName())) {\n-            locks.remove(taskId);\n-            lockAndOwner.lock.release();\n+            boolean isClosedChannelException = true;\n+            try {\n+                lockAndOwner.lock.release();\n+            } catch (ClosedChannelException cce){\n+                log.error(\"{} Closed Channel Exception Occured supposed to Ignore\", logPrefix(), cce);\n+                isClosedChannelException = false;\n+            }\n             log.debug(\"{} Released state dir lock for task {}\", logPrefix(), taskId);\n \n             final FileChannel fileChannel = channels.remove(taskId);\n-            if (fileChannel != null) {\n+            if (fileChannel != null && isClosedChannelException) {","path":"streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java","position":25,"original_position":25,"commit_id":"d187d64da6c3f5e729e5abe7629ee78bbbeb59ed","original_commit_id":"d187d64da6c3f5e729e5abe7629ee78bbbeb59ed","user":{"login":"vvcephei","id":832787,"node_id":"MDQ6VXNlcjgzMjc4Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/832787?v=4","gravatar_id":"","url":"https://api.github.com/users/vvcephei","html_url":"https://github.com/vvcephei","followers_url":"https://api.github.com/users/vvcephei/followers","following_url":"https://api.github.com/users/vvcephei/following{/other_user}","gists_url":"https://api.github.com/users/vvcephei/gists{/gist_id}","starred_url":"https://api.github.com/users/vvcephei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvcephei/subscriptions","organizations_url":"https://api.github.com/users/vvcephei/orgs","repos_url":"https://api.github.com/users/vvcephei/repos","events_url":"https://api.github.com/users/vvcephei/events{/privacy}","received_events_url":"https://api.github.com/users/vvcephei/received_events","type":"User","site_admin":false},"body":"The javadoc suggests we don't have to handle this condition specially:\r\n> If the channel has already been closed then this method returns immediately.","created_at":"2018-08-30T21:17:12Z","updated_at":"2018-08-30T21:17:12Z","html_url":"https://github.com/apache/kafka/pull/5574#discussion_r214183415","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/5574","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/214183415"},"html":{"href":"https://github.com/apache/kafka/pull/5574#discussion_r214183415"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/5574"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/5574","id":210958579,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTU4NTc5","html_url":"https://github.com/apache/kafka/pull/5574","diff_url":"https://github.com/apache/kafka/pull/5574.diff","patch_url":"https://github.com/apache/kafka/pull/5574.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/5574","number":5574,"state":"open","locked":false,"title":"KAFKA-7345 Added Finally block to execute Closing FileChannel","user":{"login":"asutosh936","id":13191865,"node_id":"MDQ6VXNlcjEzMTkxODY1","avatar_url":"https://avatars3.githubusercontent.com/u/13191865?v=4","gravatar_id":"","url":"https://api.github.com/users/asutosh936","html_url":"https://github.com/asutosh936","followers_url":"https://api.github.com/users/asutosh936/followers","following_url":"https://api.github.com/users/asutosh936/following{/other_user}","gists_url":"https://api.github.com/users/asutosh936/gists{/gist_id}","starred_url":"https://api.github.com/users/asutosh936/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asutosh936/subscriptions","organizations_url":"https://api.github.com/users/asutosh936/orgs","repos_url":"https://api.github.com/users/asutosh936/repos","events_url":"https://api.github.com/users/asutosh936/events{/privacy}","received_events_url":"https://api.github.com/users/asutosh936/received_events","type":"User","site_admin":false},"body":"*More detailed description of your change,\r\nif necessary. The PR title and PR message become\r\nthe squashed commit message, so use a separate\r\ncomment to ping reviewers.*\r\n\r\n*Summary of testing strategy (including rationale)\r\nfor the feature or bug fix. Unit and/or integration\r\ntests are expected for any behaviour change and\r\nsystem tests should be considered for larger changes.*\r\n\r\n### Committer Checklist (excluded from commit message)\r\n- [ ] Verify design and implementation \r\n- [ ] Verify test coverage and CI build status\r\n- [ ] Verify documentation (including upgrade notes)\r\n","created_at":"2018-08-26T16:12:22Z","updated_at":"2018-08-30T21:17:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b629f78accbe6907677fa2487c4b32652d14c826","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/5574/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/5574/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/5574/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/d187d64da6c3f5e729e5abe7629ee78bbbeb59ed","head":{"label":"asutosh936:KAFKA-7345","ref":"KAFKA-7345","sha":"d187d64da6c3f5e729e5abe7629ee78bbbeb59ed","user":{"login":"asutosh936","id":13191865,"node_id":"MDQ6VXNlcjEzMTkxODY1","avatar_url":"https://avatars3.githubusercontent.com/u/13191865?v=4","gravatar_id":"","url":"https://api.github.com/users/asutosh936","html_url":"https://github.com/asutosh936","followers_url":"https://api.github.com/users/asutosh936/followers","following_url":"https://api.github.com/users/asutosh936/following{/other_user}","gists_url":"https://api.github.com/users/asutosh936/gists{/gist_id}","starred_url":"https://api.github.com/users/asutosh936/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asutosh936/subscriptions","organizations_url":"https://api.github.com/users/asutosh936/orgs","repos_url":"https://api.github.com/users/asutosh936/repos","events_url":"https://api.github.com/users/asutosh936/events{/privacy}","received_events_url":"https://api.github.com/users/asutosh936/received_events","type":"User","site_admin":false},"repo":{"id":126108855,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYxMDg4NTU=","name":"kafka","full_name":"asutosh936/kafka","owner":{"login":"asutosh936","id":13191865,"node_id":"MDQ6VXNlcjEzMTkxODY1","avatar_url":"https://avatars3.githubusercontent.com/u/13191865?v=4","gravatar_id":"","url":"https://api.github.com/users/asutosh936","html_url":"https://github.com/asutosh936","followers_url":"https://api.github.com/users/asutosh936/followers","following_url":"https://api.github.com/users/asutosh936/following{/other_user}","gists_url":"https://api.github.com/users/asutosh936/gists{/gist_id}","starred_url":"https://api.github.com/users/asutosh936/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asutosh936/subscriptions","organizations_url":"https://api.github.com/users/asutosh936/orgs","repos_url":"https://api.github.com/users/asutosh936/repos","events_url":"https://api.github.com/users/asutosh936/events{/privacy}","received_events_url":"https://api.github.com/users/asutosh936/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asutosh936/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/asutosh936/kafka","forks_url":"https://api.github.com/repos/asutosh936/kafka/forks","keys_url":"https://api.github.com/repos/asutosh936/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asutosh936/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asutosh936/kafka/teams","hooks_url":"https://api.github.com/repos/asutosh936/kafka/hooks","issue_events_url":"https://api.github.com/repos/asutosh936/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/asutosh936/kafka/events","assignees_url":"https://api.github.com/repos/asutosh936/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/asutosh936/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/asutosh936/kafka/tags","blobs_url":"https://api.github.com/repos/asutosh936/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asutosh936/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asutosh936/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/asutosh936/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asutosh936/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/asutosh936/kafka/languages","stargazers_url":"https://api.github.com/repos/asutosh936/kafka/stargazers","contributors_url":"https://api.github.com/repos/asutosh936/kafka/contributors","subscribers_url":"https://api.github.com/repos/asutosh936/kafka/subscribers","subscription_url":"https://api.github.com/repos/asutosh936/kafka/subscription","commits_url":"https://api.github.com/repos/asutosh936/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/asutosh936/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/asutosh936/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/asutosh936/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/asutosh936/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/asutosh936/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asutosh936/kafka/merges","archive_url":"https://api.github.com/repos/asutosh936/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asutosh936/kafka/downloads","issues_url":"https://api.github.com/repos/asutosh936/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/asutosh936/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/asutosh936/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/asutosh936/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asutosh936/kafka/labels{/name}","releases_url":"https://api.github.com/repos/asutosh936/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/asutosh936/kafka/deployments","created_at":"2018-03-21T02:02:20Z","updated_at":"2018-08-26T15:55:04Z","pushed_at":"2018-08-30T00:30:46Z","git_url":"git://github.com/asutosh936/kafka.git","ssh_url":"git@github.com:asutosh936/kafka.git","clone_url":"https://github.com/asutosh936/kafka.git","svn_url":"https://github.com/asutosh936/kafka","homepage":null,"size":71228,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"93a60ee266a202c0b1e94010ce72ba7eb8d068a5","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"node_id":"MDEwOlJlcG9zaXRvcnkyMjExMjQz","name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2018-08-30T17:26:48Z","pushed_at":"2018-08-30T20:38:30Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":72379,"stargazers_count":9458,"watchers_count":9458,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5359,"mirror_url":null,"archived":false,"open_issues_count":493,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5359,"open_issues":493,"watchers":9458,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/5574"},"html":{"href":"https://github.com/apache/kafka/pull/5574"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/5574"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/5574/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/5574/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/5574/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/d187d64da6c3f5e729e5abe7629ee78bbbeb59ed"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vvcephei"}}