{"action":"created","issue":{"url":"https://api.github.com/repos/learningequality/kolibri/issues/4688","repository_url":"https://api.github.com/repos/learningequality/kolibri","labels_url":"https://api.github.com/repos/learningequality/kolibri/issues/4688/labels{/name}","comments_url":"https://api.github.com/repos/learningequality/kolibri/issues/4688/comments","events_url":"https://api.github.com/repos/learningequality/kolibri/issues/4688/events","html_url":"https://github.com/learningequality/kolibri/pull/4688","id":396135348,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyNDIxNjk0","number":4688,"title":"Fixes exercise detail view issues","user":{"login":"rtibbles","id":1680573,"node_id":"MDQ6VXNlcjE2ODA1NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1680573?v=4","gravatar_id":"","url":"https://api.github.com/users/rtibbles","html_url":"https://github.com/rtibbles","followers_url":"https://api.github.com/users/rtibbles/followers","following_url":"https://api.github.com/users/rtibbles/following{/other_user}","gists_url":"https://api.github.com/users/rtibbles/gists{/gist_id}","starred_url":"https://api.github.com/users/rtibbles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtibbles/subscriptions","organizations_url":"https://api.github.com/users/rtibbles/orgs","repos_url":"https://api.github.com/users/rtibbles/repos","events_url":"https://api.github.com/users/rtibbles/events{/privacy}","received_events_url":"https://api.github.com/users/rtibbles/received_events","type":"User","site_admin":false},"labels":[{"id":410338552,"node_id":"MDU6TGFiZWw0MTAzMzg1NTI=","url":"https://api.github.com/repos/learningequality/kolibri/labels/TODO:%20needs%20review","name":"TODO: needs review","color":"c1e23b","default":false},{"id":831979218,"node_id":"MDU6TGFiZWw4MzE5NzkyMTg=","url":"https://api.github.com/repos/learningequality/kolibri/labels/changelog","name":"changelog","color":"000000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/learningequality/kolibri/milestones/32","html_url":"https://github.com/learningequality/kolibri/milestone/32","labels_url":"https://api.github.com/repos/learningequality/kolibri/milestones/32/labels","id":3683791,"node_id":"MDk6TWlsZXN0b25lMzY4Mzc5MQ==","number":32,"title":"0.11.1","description":"","creator":{"login":"indirectlylit","id":2367265,"node_id":"MDQ6VXNlcjIzNjcyNjU=","avatar_url":"https://avatars2.githubusercontent.com/u/2367265?v=4","gravatar_id":"","url":"https://api.github.com/users/indirectlylit","html_url":"https://github.com/indirectlylit","followers_url":"https://api.github.com/users/indirectlylit/followers","following_url":"https://api.github.com/users/indirectlylit/following{/other_user}","gists_url":"https://api.github.com/users/indirectlylit/gists{/gist_id}","starred_url":"https://api.github.com/users/indirectlylit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indirectlylit/subscriptions","organizations_url":"https://api.github.com/users/indirectlylit/orgs","repos_url":"https://api.github.com/users/indirectlylit/repos","events_url":"https://api.github.com/users/indirectlylit/events{/privacy}","received_events_url":"https://api.github.com/users/indirectlylit/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":16,"state":"open","created_at":"2018-09-24T17:26:41Z","updated_at":"2019-01-05T05:20:45Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2019-01-05T05:20:44Z","updated_at":"2019-01-05T05:43:07Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/learningequality/kolibri/pulls/4688","html_url":"https://github.com/learningequality/kolibri/pull/4688","diff_url":"https://github.com/learningequality/kolibri/pull/4688.diff","patch_url":"https://github.com/learningequality/kolibri/pull/4688.patch"},"body":"### Summary\r\nFixes issues with exercise detail views.\r\nSet channelId on state.\r\nDon't reset state when navigating between instances of the same page.\r\nDo more robust checks to prevent attempt reversal of illegal URLs.\r\n\r\n### Reviewer guidance\r\nDoes the exercise detail view function properly in all circumstances (learner, channel, recent, and lessons).\r\n\r\n### References\r\nFixes #4610, closes #4622, and resolves #4624\r\n\r\n----\r\n\r\n### Contributor Checklist\r\n\r\n\r\nPR process:\r\n\r\n- [x] PR has the correct target branch and milestone\r\n- [x] PR has 'needs review' or 'work-in-progress' label\r\n- [x] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')\r\n- [ ] If this is an important user-facing change, PR or related issue has a 'changelog' label\r\n- [ ] If this includes an internal dependency change, a link to the diff is provided\r\n\r\nTesting:\r\n\r\n- [x] Contributor has fully tested the PR manually\r\n- [ ] If there are any front-end changes, before/after screenshots are included\r\n- [ ] Gherkin stories have been updated\r\n- [ ] Unit tests have been updated\r\n\r\n### Reviewer Checklist\r\n\r\n- Automated test coverage is satisfactory\r\n- PR is fully functional\r\n- PR has been tested for [accessibility regressions](http://kolibri-dev.readthedocs.io/en/develop/manual_testing.html#accessibility-a11y-testing)\r\n- External dependency files were updated if necessary (`yarn` and `pip`)\r\n- Documentation is updated\r\n- Contributor is in AUTHORS.rst\r\n"},"comment":{"url":"https://api.github.com/repos/learningequality/kolibri/issues/comments/451630154","html_url":"https://github.com/learningequality/kolibri/pull/4688#issuecomment-451630154","issue_url":"https://api.github.com/repos/learningequality/kolibri/issues/4688","id":451630154,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTYzMDE1NA==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2019-01-05T05:43:07Z","updated_at":"2019-01-05T05:43:07Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/learningequality/kolibri/pull/4688?src=pr&el=h1) Report\n> Merging [#4688](https://codecov.io/gh/learningequality/kolibri/pull/4688?src=pr&el=desc) into [release-v0.11.x](https://codecov.io/gh/learningequality/kolibri/commit/f54548b8d9dd452e9a076c3fe71d5e13fcc5faa5?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `0%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/learningequality/kolibri/pull/4688/graphs/tree.svg?width=650&token=l3yT7YuBEg&height=150&src=pr)](https://codecov.io/gh/learningequality/kolibri/pull/4688?src=pr&el=tree)\n\n```diff\n@@               Coverage Diff                @@\n##           release-v0.11.x    #4688   +/-   ##\n================================================\n  Coverage            51.98%   51.98%           \n================================================\n  Files                  739      739           \n  Lines                24403    24403           \n  Branches              3308     3308           \n================================================\n  Hits                 12685    12685           \n  Misses               10953    10953           \n  Partials               765      765\n```\n\n\n| [Impacted Files](https://codecov.io/gh/learningequality/kolibri/pull/4688?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [...oach/assets/src/modules/exerciseDetail/handlers.js](https://codecov.io/gh/learningequality/kolibri/pull/4688/diff?src=pr&el=tree#diff-a29saWJyaS9wbHVnaW5zL2NvYWNoL2Fzc2V0cy9zcmMvbW9kdWxlcy9leGVyY2lzZURldGFpbC9oYW5kbGVycy5qcw==) | `0% <ø> (ø)` | :arrow_up: |\n| [.../views/reports/LearnerExerciseDetailPage/index.vue](https://codecov.io/gh/learningequality/kolibri/pull/4688/diff?src=pr&el=tree#diff-a29saWJyaS9wbHVnaW5zL2NvYWNoL2Fzc2V0cy9zcmMvdmlld3MvcmVwb3J0cy9MZWFybmVyRXhlcmNpc2VEZXRhaWxQYWdlL2luZGV4LnZ1ZQ==) | `0% <0%> (ø)` | :arrow_up: |\n| [...gins/coach/assets/src/modules/coreCoach/actions.js](https://codecov.io/gh/learningequality/kolibri/pull/4688/diff?src=pr&el=tree#diff-a29saWJyaS9wbHVnaW5zL2NvYWNoL2Fzc2V0cy9zcmMvbW9kdWxlcy9jb3JlQ29hY2gvYWN0aW9ucy5qcw==) | `23.8% <0%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/learningequality/kolibri/pull/4688?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/learningequality/kolibri/pull/4688?src=pr&el=footer). Last update [f54548b...f9d4dda](https://codecov.io/gh/learningequality/kolibri/pull/4688?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}