{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/32786","repository_url":"https://api.github.com/repos/elastic/elasticsearch","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/32786/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/32786/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/32786/events","html_url":"https://github.com/elastic/elasticsearch/pull/32786","id":349566093,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NjUxODA4","number":32786,"title":"INGEST: Create Index Before Pipeline Execute","user":{"login":"original-brownbear","id":6490959,"node_id":"MDQ6VXNlcjY0OTA5NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6490959?v=4","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"labels":[{"id":268963484,"node_id":"MDU6TGFiZWwyNjg5NjM0ODQ=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Core/Ingest","name":":Core/Ingest","color":"0e8a16","default":false},{"id":23173,"node_id":"MDU6TGFiZWwyMzE3Mw==","url":"https://api.github.com/repos/elastic/elasticsearch/labels/%3Ebug","name":">bug","color":"b60205","default":false},{"id":962378555,"node_id":"MDU6TGFiZWw5NjIzNzg1NTU=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v6.5.0","name":"v6.5.0","color":"Dddddd","default":false},{"id":484855464,"node_id":"MDU6TGFiZWw0ODQ4NTU0NjQ=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v7.0.0","name":"v7.0.0","color":"dddddd","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-10T15:45:52Z","updated_at":"2018-08-13T17:03:40Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/32786","html_url":"https://github.com/elastic/elasticsearch/pull/32786","diff_url":"https://github.com/elastic/elasticsearch/pull/32786.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/32786.patch"},"body":"* Ensures that indices are created before the default pipeline setting is read to correcly handle the case of an index template containing a default pipeline (without the fix the first document does not get the pipeline applied as explained in #32758)\r\n* Wasn't quite sure what a reasonable UT would be here, I can try writing one if we want it but it seems that would be a lot of mocking from where we are at with the test infra here (we are currently just mocking the cluster service, so we'd have to mock the steps for index creation + verify the right order of calls I guess? ... not sure if that's a valuable test but happy to add it :)).\r\n* closes #32758"},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/412590703","html_url":"https://github.com/elastic/elasticsearch/pull/32786#issuecomment-412590703","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/32786","id":412590703,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjU5MDcwMw==","user":{"login":"original-brownbear","id":6490959,"node_id":"MDQ6VXNlcjY0OTA5NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6490959?v=4","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"created_at":"2018-08-13T17:03:40Z","updated_at":"2018-08-13T17:03:40Z","author_association":"MEMBER","body":"@rjernst \r\n\r\nthe problem with a UT (and as a result with leaving the IT out) is that we would basically want to test the the sequence of calling the transport client for setting up the new index, and then only loading the index+pipeline settings (and finally running the pipeline) once that index is up.\r\n\r\nThat's a lot of new test code that our current `org.elasticsearch.action.bulk.TransportBulkActionIngestTests` doesn't provide (it just hard uses a hard coded subclass of `TransportBulkAction` that has the auto create check overriden to false and uses `null` for the transport client).\r\n\r\n... but I guess no time like the present to improve our test infra here :) On it."}}
{"actor":{"display_login":"original-brownbear"}}