{"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/vault/pulls/comments/190079374","pull_request_review_id":122383688,"id":190079374,"diff_hunk":"@@ -0,0 +1,164 @@\n+---\n+layout: \"docs\"\n+page_title: \"Active Directory - Secrets Engines\"\n+sidebar_current: \"docs-secrets-active-directory\"\n+description: |-\n+  The Active Directory secrets engine for Vault generates passwords dynamically based on\n+  roles.\n+---\n+\n+# Active Directory Secrets Engine\n+\n+The Active Directory (AD) secrets engine is a plugin residing [here](https://github.com/hashicorp/vault-plugin-secrets-active-directory).\n+\n+The AD secrets engine rotates AD passwords dynamically,\n+and is designed for a high-load environment where many instances may be accessing\n+a shared password simultaneously. With a simple set up and a simple creds API,\n+it doesn't require instances to be manually registered in advance to gain access. \n+As long as access has been granted to the creds path via a method like \n+[AppRole](https://www.vaultproject.io/api/auth/approle/index.html), they're available.\n+\n+Passwords are lazily rotated based on preset TTLs and can have a length configured to meet \n+your needs.\n+\n+## A Note on Escaping\n+\n+**It is up to the administrator** to provide properly escaped DNs. This\n+includes the user DN, bind DN for search, and so on.\n+\n+The only DN escaping performed by this method is on usernames given at login\n+time when they are inserted into the final bind DN, and uses escaping rules\n+defined in RFC 4514.\n+\n+Additionally, Active Directory has escaping rules that differ slightly from the\n+RFC; in particular it requires escaping of '#' regardless of position in the DN\n+(the RFC only requires it to be escaped when it is the first character), and\n+'=', which the RFC indicates can be escaped with a backslash, but does not\n+contain in its set of required escapes. If you are using Active Directory and\n+these appear in your usernames, please ensure that they are escaped, in\n+addition to being properly escaped in your configured DNs.\n+\n+For reference, see [RFC 4514](https://www.ietf.org/rfc/rfc4514.txt) and this\n+[TechNet post on characters to escape in Active\n+Directory](http://social.technet.microsoft.com/wiki/contents/articles/5312.active-directory-characters-to-escape.aspx).\n+\n+## Quick Setup\n+\n+Most secrets engines must be configured in advance before they can perform their\n+functions. These steps are usually completed by an operator or configuration\n+management tool.\n+\n+0. Add the AD secrets plugin to your catalogue:","path":"website/source/docs/secrets/ad/index.html.md","position":51,"original_position":51,"commit_id":"bfb944a9d48a48cb6877a7d2b867ae598fd0d329","original_commit_id":"bfb944a9d48a48cb6877a7d2b867ae598fd0d329","user":{"login":"tyrannosaurus-becks","id":1152361,"avatar_url":"https://avatars3.githubusercontent.com/u/1152361?v=4","gravatar_id":"","url":"https://api.github.com/users/tyrannosaurus-becks","html_url":"https://github.com/tyrannosaurus-becks","followers_url":"https://api.github.com/users/tyrannosaurus-becks/followers","following_url":"https://api.github.com/users/tyrannosaurus-becks/following{/other_user}","gists_url":"https://api.github.com/users/tyrannosaurus-becks/gists{/gist_id}","starred_url":"https://api.github.com/users/tyrannosaurus-becks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyrannosaurus-becks/subscriptions","organizations_url":"https://api.github.com/users/tyrannosaurus-becks/orgs","repos_url":"https://api.github.com/users/tyrannosaurus-becks/repos","events_url":"https://api.github.com/users/tyrannosaurus-becks/events{/privacy}","received_events_url":"https://api.github.com/users/tyrannosaurus-becks/received_events","type":"User","site_admin":false},"body":"Oh! Good point, I hadn't thought of that. Leave it to a developer to just put a zero in the front. :-)","created_at":"2018-05-22T23:01:09Z","updated_at":"2018-05-22T23:01:09Z","html_url":"https://github.com/hashicorp/vault/pull/4612#discussion_r190079374","pull_request_url":"https://api.github.com/repos/hashicorp/vault/pulls/4612","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/comments/190079374"},"html":{"href":"https://github.com/hashicorp/vault/pull/4612#discussion_r190079374"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/4612"}},"in_reply_to_id":190063369},"pull_request":{"url":"https://api.github.com/repos/hashicorp/vault/pulls/4612","id":189798250,"html_url":"https://github.com/hashicorp/vault/pull/4612","diff_url":"https://github.com/hashicorp/vault/pull/4612.diff","patch_url":"https://github.com/hashicorp/vault/pull/4612.patch","issue_url":"https://api.github.com/repos/hashicorp/vault/issues/4612","number":4612,"state":"open","locked":false,"title":"Docs for the upcoming Active Directory secrets engine","user":{"login":"tyrannosaurus-becks","id":1152361,"avatar_url":"https://avatars3.githubusercontent.com/u/1152361?v=4","gravatar_id":"","url":"https://api.github.com/users/tyrannosaurus-becks","html_url":"https://github.com/tyrannosaurus-becks","followers_url":"https://api.github.com/users/tyrannosaurus-becks/followers","following_url":"https://api.github.com/users/tyrannosaurus-becks/following{/other_user}","gists_url":"https://api.github.com/users/tyrannosaurus-becks/gists{/gist_id}","starred_url":"https://api.github.com/users/tyrannosaurus-becks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyrannosaurus-becks/subscriptions","organizations_url":"https://api.github.com/users/tyrannosaurus-becks/orgs","repos_url":"https://api.github.com/users/tyrannosaurus-becks/repos","events_url":"https://api.github.com/users/tyrannosaurus-becks/events{/privacy}","received_events_url":"https://api.github.com/users/tyrannosaurus-becks/received_events","type":"User","site_admin":false},"body":"The AD secrets engine is almost ready to go. Here are its docs.","created_at":"2018-05-22T21:31:11Z","updated_at":"2018-05-22T23:01:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec91be7471179c2555363d16494dc421d3fa1d93","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/vault/pulls/4612/commits","review_comments_url":"https://api.github.com/repos/hashicorp/vault/pulls/4612/comments","review_comment_url":"https://api.github.com/repos/hashicorp/vault/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/vault/issues/4612/comments","statuses_url":"https://api.github.com/repos/hashicorp/vault/statuses/bfb944a9d48a48cb6877a7d2b867ae598fd0d329","head":{"label":"hashicorp:ad-secrets-docs","ref":"ad-secrets-docs","sha":"bfb944a9d48a48cb6877a7d2b867ae598fd0d329","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":31288958,"name":"vault","full_name":"hashicorp/vault","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/vault","description":"A tool for secrets management, encryption as a service, and privileged access management","fork":false,"url":"https://api.github.com/repos/hashicorp/vault","forks_url":"https://api.github.com/repos/hashicorp/vault/forks","keys_url":"https://api.github.com/repos/hashicorp/vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/vault/teams","hooks_url":"https://api.github.com/repos/hashicorp/vault/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/vault/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/vault/events","assignees_url":"https://api.github.com/repos/hashicorp/vault/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/vault/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/vault/tags","blobs_url":"https://api.github.com/repos/hashicorp/vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/vault/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/vault/languages","stargazers_url":"https://api.github.com/repos/hashicorp/vault/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/vault/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/vault/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/vault/subscription","commits_url":"https://api.github.com/repos/hashicorp/vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/vault/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/vault/merges","archive_url":"https://api.github.com/repos/hashicorp/vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/vault/downloads","issues_url":"https://api.github.com/repos/hashicorp/vault/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/vault/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/vault/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/vault/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/vault/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/vault/deployments","created_at":"2015-02-25T00:15:59Z","updated_at":"2018-05-22T21:52:36Z","pushed_at":"2018-05-22T21:52:28Z","git_url":"git://github.com/hashicorp/vault.git","ssh_url":"git@github.com:hashicorp/vault.git","clone_url":"https://github.com/hashicorp/vault.git","svn_url":"https://github.com/hashicorp/vault","homepage":"https://www.vaultproject.io/","size":52394,"stargazers_count":9225,"watchers_count":9225,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1369,"mirror_url":null,"archived":false,"open_issues_count":248,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":1369,"open_issues":248,"watchers":9225,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"a43143889e7208e50b7bbf177c3a026959e3ef5e","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":31288958,"name":"vault","full_name":"hashicorp/vault","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/vault","description":"A tool for secrets management, encryption as a service, and privileged access management","fork":false,"url":"https://api.github.com/repos/hashicorp/vault","forks_url":"https://api.github.com/repos/hashicorp/vault/forks","keys_url":"https://api.github.com/repos/hashicorp/vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/vault/teams","hooks_url":"https://api.github.com/repos/hashicorp/vault/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/vault/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/vault/events","assignees_url":"https://api.github.com/repos/hashicorp/vault/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/vault/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/vault/tags","blobs_url":"https://api.github.com/repos/hashicorp/vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/vault/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/vault/languages","stargazers_url":"https://api.github.com/repos/hashicorp/vault/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/vault/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/vault/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/vault/subscription","commits_url":"https://api.github.com/repos/hashicorp/vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/vault/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/vault/merges","archive_url":"https://api.github.com/repos/hashicorp/vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/vault/downloads","issues_url":"https://api.github.com/repos/hashicorp/vault/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/vault/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/vault/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/vault/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/vault/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/vault/deployments","created_at":"2015-02-25T00:15:59Z","updated_at":"2018-05-22T21:52:36Z","pushed_at":"2018-05-22T21:52:28Z","git_url":"git://github.com/hashicorp/vault.git","ssh_url":"git@github.com:hashicorp/vault.git","clone_url":"https://github.com/hashicorp/vault.git","svn_url":"https://github.com/hashicorp/vault","homepage":"https://www.vaultproject.io/","size":52394,"stargazers_count":9225,"watchers_count":9225,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1369,"mirror_url":null,"archived":false,"open_issues_count":248,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":1369,"open_issues":248,"watchers":9225,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/4612"},"html":{"href":"https://github.com/hashicorp/vault/pull/4612"},"issue":{"href":"https://api.github.com/repos/hashicorp/vault/issues/4612"},"comments":{"href":"https://api.github.com/repos/hashicorp/vault/issues/4612/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/4612/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/vault/pulls/4612/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/vault/statuses/bfb944a9d48a48cb6877a7d2b867ae598fd0d329"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tyrannosaurus-becks"}}