{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61098","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61098/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61098/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61098/events","html_url":"https://github.com/kubernetes/kubernetes/pull/61098","id":304710678,"number":61098,"title":"Use mktemp instead of static temporary file path in scripts.","user":{"login":"ipuustin","id":998633,"avatar_url":"https://avatars3.githubusercontent.com/u/998633?v=4","gravatar_id":"","url":"https://api.github.com/users/ipuustin","html_url":"https://github.com/ipuustin","followers_url":"https://api.github.com/users/ipuustin/followers","following_url":"https://api.github.com/users/ipuustin/following{/other_user}","gists_url":"https://api.github.com/users/ipuustin/gists{/gist_id}","starred_url":"https://api.github.com/users/ipuustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipuustin/subscriptions","organizations_url":"https://api.github.com/users/ipuustin/orgs","repos_url":"https://api.github.com/users/ipuustin/repos","events_url":"https://api.github.com/users/ipuustin/events{/privacy}","received_events_url":"https://api.github.com/users/ipuustin/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":148225179,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450895,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":{"login":"cblecker","id":1431969,"avatar_url":"https://avatars1.githubusercontent.com/u/1431969?v=4","gravatar_id":"","url":"https://api.github.com/users/cblecker","html_url":"https://github.com/cblecker","followers_url":"https://api.github.com/users/cblecker/followers","following_url":"https://api.github.com/users/cblecker/following{/other_user}","gists_url":"https://api.github.com/users/cblecker/gists{/gist_id}","starred_url":"https://api.github.com/users/cblecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cblecker/subscriptions","organizations_url":"https://api.github.com/users/cblecker/orgs","repos_url":"https://api.github.com/users/cblecker/repos","events_url":"https://api.github.com/users/cblecker/events{/privacy}","received_events_url":"https://api.github.com/users/cblecker/received_events","type":"User","site_admin":false},"assignees":[{"login":"cblecker","id":1431969,"avatar_url":"https://avatars1.githubusercontent.com/u/1431969?v=4","gravatar_id":"","url":"https://api.github.com/users/cblecker","html_url":"https://github.com/cblecker","followers_url":"https://api.github.com/users/cblecker/followers","following_url":"https://api.github.com/users/cblecker/following{/other_user}","gists_url":"https://api.github.com/users/cblecker/gists{/gist_id}","starred_url":"https://api.github.com/users/cblecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cblecker/subscriptions","organizations_url":"https://api.github.com/users/cblecker/orgs","repos_url":"https://api.github.com/users/cblecker/repos","events_url":"https://api.github.com/users/cblecker/events{/privacy}","received_events_url":"https://api.github.com/users/cblecker/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2018-03-13T10:40:09Z","updated_at":"2018-03-21T23:01:57Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61098","html_url":"https://github.com/kubernetes/kubernetes/pull/61098","diff_url":"https://github.com/kubernetes/kubernetes/pull/61098.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/61098.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nUsing static file names in `/tmp` is considered to be a security anti-pattern, even if the modern Linux distributions make it difficult for the attacker to use symbolic link attacks against the `/tmp` directory. We should consider changing to the pattern of safely creating a temporary directory which only the user can access and placing the temporary files there. This assumes that `mktemp` command is installed -- it should be a safe assumption since the command is already widely used in the kubernetes scripts.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/375123978","html_url":"https://github.com/kubernetes/kubernetes/pull/61098#issuecomment-375123978","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61098","id":375123978,"user":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars0.githubusercontent.com/u/13653959?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"created_at":"2018-03-21T23:01:57Z","updated_at":"2018-03-21T23:01:57Z","author_association":"COLLABORATOR","body":"/test all [submit-queue is verifying that this PR is safe to merge]"}}
{"actor":{"display_login":"k8s-merge-robot"}}