{"action":"created","comment":{"url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/pulls/comments/201502482","pull_request_review_id":136018605,"id":201502482,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTUwMjQ4Mg==","diff_hunk":"@@ -0,0 +1,46 @@\n+require 'rails_helper'\n+\n+RSpec.describe 'Editing Teams', type: :feature do\n+  let(:user)            { create(:organizer) }\n+  let(:season)          { Season.current }\n+  let(:other_season)    { create(:season) }\n+  let(:team)            { create(:team, name: 'Team Yay', season: season) }\n+  let(:selection_phase) { season.applications_close_at + 1.day }\n+  let!(:exercism)       { create(:project, :accepted, name: 'Exercism', season: season) }\n+\n+  before do\n+    create(:project, :accepted, name: 'Some Old Project', season: other_season)\n+    create(:project, name: 'Non-Accepted', season: season)\n+    create(:project, :accepted, name: 'Open Source Dropbox', season: season)\n+","path":"spec/features/organizers/teams/edit_spec.rb","position":15,"original_position":15,"commit_id":"66bc0c6388f425aeb2968104b3a1569876a46b06","original_commit_id":"66bc0c6388f425aeb2968104b3a1569876a46b06","user":{"login":"klappradla","id":3491815,"node_id":"MDQ6VXNlcjM0OTE4MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3491815?v=4","gravatar_id":"","url":"https://api.github.com/users/klappradla","html_url":"https://github.com/klappradla","followers_url":"https://api.github.com/users/klappradla/followers","following_url":"https://api.github.com/users/klappradla/following{/other_user}","gists_url":"https://api.github.com/users/klappradla/gists{/gist_id}","starred_url":"https://api.github.com/users/klappradla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klappradla/subscriptions","organizations_url":"https://api.github.com/users/klappradla/orgs","repos_url":"https://api.github.com/users/klappradla/repos","events_url":"https://api.github.com/users/klappradla/events{/privacy}","received_events_url":"https://api.github.com/users/klappradla/received_events","type":"User","site_admin":false},"body":"Haha, well it probably has its usecases somehow. But I usually could archive anything I wanted with `build` alone.","created_at":"2018-07-10T21:33:17Z","updated_at":"2018-07-10T21:33:17Z","html_url":"https://github.com/rails-girls-summer-of-code/rgsoc-teams/pull/1022#discussion_r201502482","pull_request_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/pulls/1022","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/pulls/comments/201502482"},"html":{"href":"https://github.com/rails-girls-summer-of-code/rgsoc-teams/pull/1022#discussion_r201502482"},"pull_request":{"href":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/pulls/1022"}},"in_reply_to_id":201229230},"pull_request":{"url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/pulls/1022","id":199857860,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODU3ODYw","html_url":"https://github.com/rails-girls-summer-of-code/rgsoc-teams/pull/1022","diff_url":"https://github.com/rails-girls-summer-of-code/rgsoc-teams/pull/1022.diff","patch_url":"https://github.com/rails-girls-summer-of-code/rgsoc-teams/pull/1022.patch","issue_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/issues/1022","number":1022,"state":"open","locked":false,"title":"[#892] Migrate `team.project_name` to `team.project_id`","user":{"login":"klappradla","id":3491815,"node_id":"MDQ6VXNlcjM0OTE4MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3491815?v=4","gravatar_id":"","url":"https://api.github.com/users/klappradla","html_url":"https://github.com/klappradla","followers_url":"https://api.github.com/users/klappradla/followers","following_url":"https://api.github.com/users/klappradla/following{/other_user}","gists_url":"https://api.github.com/users/klappradla/gists{/gist_id}","starred_url":"https://api.github.com/users/klappradla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klappradla/subscriptions","organizations_url":"https://api.github.com/users/klappradla/orgs","repos_url":"https://api.github.com/users/klappradla/repos","events_url":"https://api.github.com/users/klappradla/events{/privacy}","received_events_url":"https://api.github.com/users/klappradla/received_events","type":"User","site_admin":false},"body":"This is supposed to fix #892 : replaying `team#project_name` with an actual _(already existing but not used)_ association between `project` and `team`. \r\n\r\nThis includes:\r\n- migrating existing data\r\n- enabling orga to choose the project for a team\r\n  _(one can only a project from the same season as the team)_\r\n- ⚠️ no longer allow teams to change their project\r\n  _(not sure if this was allowed on purpose before - it does not really make sense to me)_\r\n- some new settings for our headless Chrome driver 🤡 \r\n  _(we have to set the window size to something closer to real-world -> otherwise bootstrap will hide certain elements and make expectations harder..)_\r\n\r\nI'm pretty sure this will also require some more changes to where certain links are displayed, etc. But for now I think this simply migrates the existing behavior to a new datamodel.\r\n\r\nOne potential 💣 I found on the way: the `HasSeason` concern does not **require** things to have a season... However, I think in most cases this should actually be enforced in order to not break half of the queries we're doing.\r\n☝️ If anyone knows reason why this was not required - please tell me 🙏 ","created_at":"2018-07-06T22:12:33Z","updated_at":"2018-07-10T21:33:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6e95bd63f2875bd04d5ac63873aaa619dfda1bb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/pulls/1022/commits","review_comments_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/pulls/1022/comments","review_comment_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/issues/1022/comments","statuses_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/statuses/66bc0c6388f425aeb2968104b3a1569876a46b06","head":{"label":"rails-girls-summer-of-code:feature/892-migrate-team-project_name-to-team-project_id","ref":"feature/892-migrate-team-project_name-to-team-project_id","sha":"66bc0c6388f425aeb2968104b3a1569876a46b06","user":{"login":"rails-girls-summer-of-code","id":4704447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MDQ0NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/4704447?v=4","gravatar_id":"","url":"https://api.github.com/users/rails-girls-summer-of-code","html_url":"https://github.com/rails-girls-summer-of-code","followers_url":"https://api.github.com/users/rails-girls-summer-of-code/followers","following_url":"https://api.github.com/users/rails-girls-summer-of-code/following{/other_user}","gists_url":"https://api.github.com/users/rails-girls-summer-of-code/gists{/gist_id}","starred_url":"https://api.github.com/users/rails-girls-summer-of-code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails-girls-summer-of-code/subscriptions","organizations_url":"https://api.github.com/users/rails-girls-summer-of-code/orgs","repos_url":"https://api.github.com/users/rails-girls-summer-of-code/repos","events_url":"https://api.github.com/users/rails-girls-summer-of-code/events{/privacy}","received_events_url":"https://api.github.com/users/rails-girls-summer-of-code/received_events","type":"Organization","site_admin":false},"repo":{"id":10705327,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcwNTMyNw==","name":"rgsoc-teams","full_name":"rails-girls-summer-of-code/rgsoc-teams","owner":{"login":"rails-girls-summer-of-code","id":4704447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MDQ0NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/4704447?v=4","gravatar_id":"","url":"https://api.github.com/users/rails-girls-summer-of-code","html_url":"https://github.com/rails-girls-summer-of-code","followers_url":"https://api.github.com/users/rails-girls-summer-of-code/followers","following_url":"https://api.github.com/users/rails-girls-summer-of-code/following{/other_user}","gists_url":"https://api.github.com/users/rails-girls-summer-of-code/gists{/gist_id}","starred_url":"https://api.github.com/users/rails-girls-summer-of-code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails-girls-summer-of-code/subscriptions","organizations_url":"https://api.github.com/users/rails-girls-summer-of-code/orgs","repos_url":"https://api.github.com/users/rails-girls-summer-of-code/repos","events_url":"https://api.github.com/users/rails-girls-summer-of-code/events{/privacy}","received_events_url":"https://api.github.com/users/rails-girls-summer-of-code/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails-girls-summer-of-code/rgsoc-teams","description":"Teams management and activity ","fork":false,"url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams","forks_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/forks","keys_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/teams","hooks_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/hooks","issue_events_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/issues/events{/number}","events_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/events","assignees_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/assignees{/user}","branches_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/branches{/branch}","tags_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/tags","blobs_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/statuses/{sha}","languages_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/languages","stargazers_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/stargazers","contributors_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/contributors","subscribers_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/subscribers","subscription_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/subscription","commits_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/contents/{+path}","compare_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/merges","archive_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/downloads","issues_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/issues{/number}","pulls_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/pulls{/number}","milestones_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/milestones{/number}","notifications_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/labels{/name}","releases_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/releases{/id}","deployments_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/deployments","created_at":"2013-06-15T11:13:22Z","updated_at":"2018-07-06T11:58:43Z","pushed_at":"2018-07-09T22:16:30Z","git_url":"git://github.com/rails-girls-summer-of-code/rgsoc-teams.git","ssh_url":"git@github.com:rails-girls-summer-of-code/rgsoc-teams.git","clone_url":"https://github.com/rails-girls-summer-of-code/rgsoc-teams.git","svn_url":"https://github.com/rails-girls-summer-of-code/rgsoc-teams","homepage":"https://teams.railsgirlssummerofcode.org","size":8149,"stargazers_count":53,"watchers_count":53,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":131,"mirror_url":null,"archived":false,"open_issues_count":70,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":131,"open_issues":70,"watchers":53,"default_branch":"master"}},"base":{"label":"rails-girls-summer-of-code:master","ref":"master","sha":"05a1f3159403e014d2da1ca532bee1d743584f9e","user":{"login":"rails-girls-summer-of-code","id":4704447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MDQ0NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/4704447?v=4","gravatar_id":"","url":"https://api.github.com/users/rails-girls-summer-of-code","html_url":"https://github.com/rails-girls-summer-of-code","followers_url":"https://api.github.com/users/rails-girls-summer-of-code/followers","following_url":"https://api.github.com/users/rails-girls-summer-of-code/following{/other_user}","gists_url":"https://api.github.com/users/rails-girls-summer-of-code/gists{/gist_id}","starred_url":"https://api.github.com/users/rails-girls-summer-of-code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails-girls-summer-of-code/subscriptions","organizations_url":"https://api.github.com/users/rails-girls-summer-of-code/orgs","repos_url":"https://api.github.com/users/rails-girls-summer-of-code/repos","events_url":"https://api.github.com/users/rails-girls-summer-of-code/events{/privacy}","received_events_url":"https://api.github.com/users/rails-girls-summer-of-code/received_events","type":"Organization","site_admin":false},"repo":{"id":10705327,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcwNTMyNw==","name":"rgsoc-teams","full_name":"rails-girls-summer-of-code/rgsoc-teams","owner":{"login":"rails-girls-summer-of-code","id":4704447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MDQ0NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/4704447?v=4","gravatar_id":"","url":"https://api.github.com/users/rails-girls-summer-of-code","html_url":"https://github.com/rails-girls-summer-of-code","followers_url":"https://api.github.com/users/rails-girls-summer-of-code/followers","following_url":"https://api.github.com/users/rails-girls-summer-of-code/following{/other_user}","gists_url":"https://api.github.com/users/rails-girls-summer-of-code/gists{/gist_id}","starred_url":"https://api.github.com/users/rails-girls-summer-of-code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails-girls-summer-of-code/subscriptions","organizations_url":"https://api.github.com/users/rails-girls-summer-of-code/orgs","repos_url":"https://api.github.com/users/rails-girls-summer-of-code/repos","events_url":"https://api.github.com/users/rails-girls-summer-of-code/events{/privacy}","received_events_url":"https://api.github.com/users/rails-girls-summer-of-code/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails-girls-summer-of-code/rgsoc-teams","description":"Teams management and activity ","fork":false,"url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams","forks_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/forks","keys_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/teams","hooks_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/hooks","issue_events_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/issues/events{/number}","events_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/events","assignees_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/assignees{/user}","branches_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/branches{/branch}","tags_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/tags","blobs_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/statuses/{sha}","languages_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/languages","stargazers_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/stargazers","contributors_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/contributors","subscribers_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/subscribers","subscription_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/subscription","commits_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/contents/{+path}","compare_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/merges","archive_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/downloads","issues_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/issues{/number}","pulls_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/pulls{/number}","milestones_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/milestones{/number}","notifications_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/labels{/name}","releases_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/releases{/id}","deployments_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/deployments","created_at":"2013-06-15T11:13:22Z","updated_at":"2018-07-06T11:58:43Z","pushed_at":"2018-07-09T22:16:30Z","git_url":"git://github.com/rails-girls-summer-of-code/rgsoc-teams.git","ssh_url":"git@github.com:rails-girls-summer-of-code/rgsoc-teams.git","clone_url":"https://github.com/rails-girls-summer-of-code/rgsoc-teams.git","svn_url":"https://github.com/rails-girls-summer-of-code/rgsoc-teams","homepage":"https://teams.railsgirlssummerofcode.org","size":8149,"stargazers_count":53,"watchers_count":53,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":131,"mirror_url":null,"archived":false,"open_issues_count":70,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":131,"open_issues":70,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/pulls/1022"},"html":{"href":"https://github.com/rails-girls-summer-of-code/rgsoc-teams/pull/1022"},"issue":{"href":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/issues/1022"},"comments":{"href":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/issues/1022/comments"},"review_comments":{"href":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/pulls/1022/comments"},"review_comment":{"href":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/pulls/1022/commits"},"statuses":{"href":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/statuses/66bc0c6388f425aeb2968104b3a1569876a46b06"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"klappradla"}}