{"action":"created","issue":{"url":"https://api.github.com/repos/sindresorhus/np/issues/220","repository_url":"https://api.github.com/repos/sindresorhus/np","labels_url":"https://api.github.com/repos/sindresorhus/np/issues/220/labels{/name}","comments_url":"https://api.github.com/repos/sindresorhus/np/issues/220/comments","events_url":"https://api.github.com/repos/sindresorhus/np/issues/220/events","html_url":"https://github.com/sindresorhus/np/pull/220","id":284300951,"number":220,"title":"Attempt to add yarn publish","user":{"login":"ErisDS","id":101513,"avatar_url":"https://avatars1.githubusercontent.com/u/101513?v=4","gravatar_id":"","url":"https://api.github.com/users/ErisDS","html_url":"https://github.com/ErisDS","followers_url":"https://api.github.com/users/ErisDS/followers","following_url":"https://api.github.com/users/ErisDS/following{/other_user}","gists_url":"https://api.github.com/users/ErisDS/gists{/gist_id}","starred_url":"https://api.github.com/users/ErisDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErisDS/subscriptions","organizations_url":"https://api.github.com/users/ErisDS/orgs","repos_url":"https://api.github.com/users/ErisDS/repos","events_url":"https://api.github.com/users/ErisDS/events{/privacy}","received_events_url":"https://api.github.com/users/ErisDS/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2017-12-23T11:10:27Z","updated_at":"2018-02-02T11:51:01Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/sindresorhus/np/pulls/220","html_url":"https://github.com/sindresorhus/np/pull/220","diff_url":"https://github.com/sindresorhus/np/pull/220.diff","patch_url":"https://github.com/sindresorhus/np/pull/220.patch"},"body":"refs #216, #203, etc\r\n\r\nI've genuinely been pulling my hair out with np for the last 3 days. I've done my absolute best to try to contribute a fix because I love this tool, but I'm utterly lost 😭 \r\n\r\nI've tried to fix the npm publish, but I just don't understand how exec/execa/observable are all related.\r\n\r\nInstead I've tried to add yarn publish support, but although the publish happens, the flow of control never returns back to listr it seems, so it sits and hangs forever, and never gets as far as pushing the tags. I am at a loss for how to debug.\r\n\r\nThis PR includes that attempt.\r\n\r\nCan someone who understands listr, execa, etc etc take a look and see if they can find an easy fix?\r\n\r\nI'd also love to know as well:\r\n - what does the streamToObservable wrapper in index.js & observableFromPublish code in `publish.js` achieve? \r\n- how come in publish.js `execa` is used directly, although everywhere else it is `execa.stdout`\r\n\r\nIf someone can point me at some related reading that would make this make sense I'd be grateful!\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/sindresorhus/np/issues/comments/362566316","html_url":"https://github.com/sindresorhus/np/pull/220#issuecomment-362566316","issue_url":"https://api.github.com/repos/sindresorhus/np/issues/220","id":362566316,"user":{"login":"ErisDS","id":101513,"avatar_url":"https://avatars1.githubusercontent.com/u/101513?v=4","gravatar_id":"","url":"https://api.github.com/users/ErisDS","html_url":"https://github.com/ErisDS","followers_url":"https://api.github.com/users/ErisDS/followers","following_url":"https://api.github.com/users/ErisDS/following{/other_user}","gists_url":"https://api.github.com/users/ErisDS/gists{/gist_id}","starred_url":"https://api.github.com/users/ErisDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ErisDS/subscriptions","organizations_url":"https://api.github.com/users/ErisDS/orgs","repos_url":"https://api.github.com/users/ErisDS/repos","events_url":"https://api.github.com/users/ErisDS/events{/privacy}","received_events_url":"https://api.github.com/users/ErisDS/received_events","type":"User","site_admin":false},"created_at":"2018-02-02T11:51:01Z","updated_at":"2018-02-02T11:51:01Z","author_association":"NONE","body":"OK I found my dumb mistake that prevented this working. \r\n\r\nI've also verified that:\r\n\r\n- `np` works with npm for projects that don't use yarn\r\n- `np` works with yarn for projects that do use yarn\r\n- `np --no-yarn` works with npm for projects that use yarn but want to publish with npm\r\n- `np --no-yarn --tag=x` on yarn project works as expected\r\n- `np --tag=x` on yarn project works as expected\r\n\r\nI also tested a few other scenarios e.g. setting `private:true` in package.json and using `np` from a script in package.json - all looks good 😁 \r\n\r\n"}}
{"actor":{"display_login":"ErisDS"}}