{"action":"created","issue":{"url":"https://api.github.com/repos/ga4gh/dockstore/issues/1900","repository_url":"https://api.github.com/repos/ga4gh/dockstore","labels_url":"https://api.github.com/repos/ga4gh/dockstore/issues/1900/labels{/name}","comments_url":"https://api.github.com/repos/ga4gh/dockstore/issues/1900/comments","events_url":"https://api.github.com/repos/ga4gh/dockstore/issues/1900/events","html_url":"https://github.com/ga4gh/dockstore/pull/1900","id":379317752,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODE2MDU4","number":1900,"title":"1850/cwl relative import fix","user":{"login":"agduncan94","id":6331159,"node_id":"MDQ6VXNlcjYzMzExNTk=","avatar_url":"https://avatars2.githubusercontent.com/u/6331159?v=4","gravatar_id":"","url":"https://api.github.com/users/agduncan94","html_url":"https://github.com/agduncan94","followers_url":"https://api.github.com/users/agduncan94/followers","following_url":"https://api.github.com/users/agduncan94/following{/other_user}","gists_url":"https://api.github.com/users/agduncan94/gists{/gist_id}","starred_url":"https://api.github.com/users/agduncan94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agduncan94/subscriptions","organizations_url":"https://api.github.com/users/agduncan94/orgs","repos_url":"https://api.github.com/users/agduncan94/repos","events_url":"https://api.github.com/users/agduncan94/events{/privacy}","received_events_url":"https://api.github.com/users/agduncan94/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"agduncan94","id":6331159,"node_id":"MDQ6VXNlcjYzMzExNTk=","avatar_url":"https://avatars2.githubusercontent.com/u/6331159?v=4","gravatar_id":"","url":"https://api.github.com/users/agduncan94","html_url":"https://github.com/agduncan94","followers_url":"https://api.github.com/users/agduncan94/followers","following_url":"https://api.github.com/users/agduncan94/following{/other_user}","gists_url":"https://api.github.com/users/agduncan94/gists{/gist_id}","starred_url":"https://api.github.com/users/agduncan94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agduncan94/subscriptions","organizations_url":"https://api.github.com/users/agduncan94/orgs","repos_url":"https://api.github.com/users/agduncan94/repos","events_url":"https://api.github.com/users/agduncan94/events{/privacy}","received_events_url":"https://api.github.com/users/agduncan94/received_events","type":"User","site_admin":false},"assignees":[{"login":"agduncan94","id":6331159,"node_id":"MDQ6VXNlcjYzMzExNTk=","avatar_url":"https://avatars2.githubusercontent.com/u/6331159?v=4","gravatar_id":"","url":"https://api.github.com/users/agduncan94","html_url":"https://github.com/agduncan94","followers_url":"https://api.github.com/users/agduncan94/followers","following_url":"https://api.github.com/users/agduncan94/following{/other_user}","gists_url":"https://api.github.com/users/agduncan94/gists{/gist_id}","starred_url":"https://api.github.com/users/agduncan94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agduncan94/subscriptions","organizations_url":"https://api.github.com/users/agduncan94/orgs","repos_url":"https://api.github.com/users/agduncan94/repos","events_url":"https://api.github.com/users/agduncan94/events{/privacy}","received_events_url":"https://api.github.com/users/agduncan94/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-11-09T20:52:59Z","updated_at":"2018-11-13T21:30:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ga4gh/dockstore/pulls/1900","html_url":"https://github.com/ga4gh/dockstore/pull/1900","diff_url":"https://github.com/ga4gh/dockstore/pull/1900.diff","patch_url":"https://github.com/ga4gh/dockstore/pull/1900.patch"},"body":"* Now store absolute path of sourcefile to use for reading from Git\r\n* Solves the issue of not being able to read files from Git since absolute paths are now used\r\n* Solves issue with CWL getSteps() returning either an array or an object.\r\n* Fixes tests and adds some more\r\n\r\nCurrently the migrations is just copying the existing path. I think this is the best and simplest solution since the absolute path only impacts download zip and launch for existing entries. So before a refresh, download zip and launch will work for those entries they already worked for, but also won't work for the entries they do not work for. Once the user refreshes an entry, the proper absolute path will be found and everything should be working as expected. What do you guys think? \r\n\r\nhttps://github.com/ga4gh/dockstore/issues/1850\r\nhttps://github.com/ga4gh/dockstore/issues/1456\r\nhttps://github.com/ga4gh/dockstore/issues/741"},"comment":{"url":"https://api.github.com/repos/ga4gh/dockstore/issues/comments/438444480","html_url":"https://github.com/ga4gh/dockstore/pull/1900#issuecomment-438444480","issue_url":"https://api.github.com/repos/ga4gh/dockstore/issues/1900","id":438444480,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODQ0NDQ4MA==","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"created_at":"2018-11-13T21:30:36Z","updated_at":"2018-11-13T21:30:36Z","author_association":"NONE","body":"\n![Codacy](https://app.codacy.com/assets/images/favicon.png) Here is an overview of what got changed by this pull request:\n\n\n```diff\n\nIssues\n======\n+ Solved 3\n- Added 2\n           \n\nComplexity increasing per file\n==============================\n- dockstore-webservice/src/main/java/io/dockstore/webservice/core/SourceFile.java  2\n- dockstore-webservice/src/main/java/io/dockstore/webservice/languages/CWLHandler.java  1\n         \n```\n\n\nSee the complete overview on [Codacy](https://app.codacy.com/app/dockstore/dockstore/pullRequest?prid=2531546&bid=9671533)\n        "}}
{"actor":{"display_login":"codacy-bot"}}