{"action":"created","comment":{"url":"https://api.github.com/repos/craffael/lehrfempp/pulls/comments/231280026","pull_request_review_id":172217824,"id":231280026,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTI4MDAyNg==","diff_hunk":"@@ -98,6 +98,43 @@ void checkIntegrationElement(const lf::geometry::Geometry &geom,\n   }\n }\n \n+/**\n+ * Checks that SubGeometry and Geometry map the same nodes to the same points\n+ */\n+void checkSubGeometry(const lf::geometry::Geometry &geom) {\n+  // nodeCoords is a (refEl.Dimension, refEl.NumNodes) matrix\n+  const auto refEl = geom.RefEl();\n+  const Eigen::MatrixXd &nodeCoords = refEl.NodeCoords();\n+\n+  // iterate over all relative codimensions\n+  for (size_t codim = 1; codim <= geom.RefEl().Dimension(); ++codim) {","path":"lib/lf/geometry/test/geometry_tests.cc","position":13,"original_position":13,"commit_id":"87633f5a1c922297deed5a27b2961cf7def0559a","original_commit_id":"87633f5a1c922297deed5a27b2961cf7def0559a","user":{"login":"craffael","id":15138672,"node_id":"MDQ6VXNlcjE1MTM4Njcy","avatar_url":"https://avatars1.githubusercontent.com/u/15138672?v=4","gravatar_id":"","url":"https://api.github.com/users/craffael","html_url":"https://github.com/craffael","followers_url":"https://api.github.com/users/craffael/followers","following_url":"https://api.github.com/users/craffael/following{/other_user}","gists_url":"https://api.github.com/users/craffael/gists{/gist_id}","starred_url":"https://api.github.com/users/craffael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craffael/subscriptions","organizations_url":"https://api.github.com/users/craffael/orgs","repos_url":"https://api.github.com/users/craffael/repos","events_url":"https://api.github.com/users/craffael/events{/privacy}","received_events_url":"https://api.github.com/users/craffael/received_events","type":"User","site_admin":false},"body":"special case for codim=0: In this case the geometry object should be \"cloned\", i.e. it should return a new geometry object that represents exactly the same mapping. I think you can just extend the loop to codim=0 and it should test this behavior.","created_at":"2018-11-06T20:28:55Z","updated_at":"2018-11-06T20:52:23Z","html_url":"https://github.com/craffael/lehrfempp/pull/70#discussion_r231280026","pull_request_url":"https://api.github.com/repos/craffael/lehrfempp/pulls/70","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/craffael/lehrfempp/pulls/comments/231280026"},"html":{"href":"https://github.com/craffael/lehrfempp/pull/70#discussion_r231280026"},"pull_request":{"href":"https://api.github.com/repos/craffael/lehrfempp/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/craffael/lehrfempp/pulls/70","id":228780336,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NzgwMzM2","html_url":"https://github.com/craffael/lehrfempp/pull/70","diff_url":"https://github.com/craffael/lehrfempp/pull/70.diff","patch_url":"https://github.com/craffael/lehrfempp/pull/70.patch","issue_url":"https://api.github.com/repos/craffael/lehrfempp/issues/70","number":70,"state":"open","locked":false,"title":"Child- and SubGeometry tests","user":{"login":"anianruoss","id":18675644,"node_id":"MDQ6VXNlcjE4Njc1NjQ0","avatar_url":"https://avatars0.githubusercontent.com/u/18675644?v=4","gravatar_id":"","url":"https://api.github.com/users/anianruoss","html_url":"https://github.com/anianruoss","followers_url":"https://api.github.com/users/anianruoss/followers","following_url":"https://api.github.com/users/anianruoss/following{/other_user}","gists_url":"https://api.github.com/users/anianruoss/gists{/gist_id}","starred_url":"https://api.github.com/users/anianruoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anianruoss/subscriptions","organizations_url":"https://api.github.com/users/anianruoss/orgs","repos_url":"https://api.github.com/users/anianruoss/repos","events_url":"https://api.github.com/users/anianruoss/events{/privacy}","received_events_url":"https://api.github.com/users/anianruoss/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-06T17:50:21Z","updated_at":"2018-11-06T20:52:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"236506b1eba34424c4d2b7c3b1abae02eec7d7fb","assignee":{"login":"anianruoss","id":18675644,"node_id":"MDQ6VXNlcjE4Njc1NjQ0","avatar_url":"https://avatars0.githubusercontent.com/u/18675644?v=4","gravatar_id":"","url":"https://api.github.com/users/anianruoss","html_url":"https://github.com/anianruoss","followers_url":"https://api.github.com/users/anianruoss/followers","following_url":"https://api.github.com/users/anianruoss/following{/other_user}","gists_url":"https://api.github.com/users/anianruoss/gists{/gist_id}","starred_url":"https://api.github.com/users/anianruoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anianruoss/subscriptions","organizations_url":"https://api.github.com/users/anianruoss/orgs","repos_url":"https://api.github.com/users/anianruoss/repos","events_url":"https://api.github.com/users/anianruoss/events{/privacy}","received_events_url":"https://api.github.com/users/anianruoss/received_events","type":"User","site_admin":false},"assignees":[{"login":"anianruoss","id":18675644,"node_id":"MDQ6VXNlcjE4Njc1NjQ0","avatar_url":"https://avatars0.githubusercontent.com/u/18675644?v=4","gravatar_id":"","url":"https://api.github.com/users/anianruoss","html_url":"https://github.com/anianruoss","followers_url":"https://api.github.com/users/anianruoss/followers","following_url":"https://api.github.com/users/anianruoss/following{/other_user}","gists_url":"https://api.github.com/users/anianruoss/gists{/gist_id}","starred_url":"https://api.github.com/users/anianruoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anianruoss/subscriptions","organizations_url":"https://api.github.com/users/anianruoss/orgs","repos_url":"https://api.github.com/users/anianruoss/repos","events_url":"https://api.github.com/users/anianruoss/events{/privacy}","received_events_url":"https://api.github.com/users/anianruoss/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":948976635,"node_id":"MDU6TGFiZWw5NDg5NzY2MzU=","url":"https://api.github.com/repos/craffael/lehrfempp/labels/design","name":"design","color":"93ed9a","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/craffael/lehrfempp/pulls/70/commits","review_comments_url":"https://api.github.com/repos/craffael/lehrfempp/pulls/70/comments","review_comment_url":"https://api.github.com/repos/craffael/lehrfempp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/craffael/lehrfempp/issues/70/comments","statuses_url":"https://api.github.com/repos/craffael/lehrfempp/statuses/87633f5a1c922297deed5a27b2961cf7def0559a","head":{"label":"craffael:child-and-subgeometry-tests","ref":"child-and-subgeometry-tests","sha":"87633f5a1c922297deed5a27b2961cf7def0559a","user":{"login":"craffael","id":15138672,"node_id":"MDQ6VXNlcjE1MTM4Njcy","avatar_url":"https://avatars1.githubusercontent.com/u/15138672?v=4","gravatar_id":"","url":"https://api.github.com/users/craffael","html_url":"https://github.com/craffael","followers_url":"https://api.github.com/users/craffael/followers","following_url":"https://api.github.com/users/craffael/following{/other_user}","gists_url":"https://api.github.com/users/craffael/gists{/gist_id}","starred_url":"https://api.github.com/users/craffael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craffael/subscriptions","organizations_url":"https://api.github.com/users/craffael/orgs","repos_url":"https://api.github.com/users/craffael/repos","events_url":"https://api.github.com/users/craffael/events{/privacy}","received_events_url":"https://api.github.com/users/craffael/received_events","type":"User","site_admin":false},"repo":{"id":128404634,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg0MDQ2MzQ=","name":"lehrfempp","full_name":"craffael/lehrfempp","private":false,"owner":{"login":"craffael","id":15138672,"node_id":"MDQ6VXNlcjE1MTM4Njcy","avatar_url":"https://avatars1.githubusercontent.com/u/15138672?v=4","gravatar_id":"","url":"https://api.github.com/users/craffael","html_url":"https://github.com/craffael","followers_url":"https://api.github.com/users/craffael/followers","following_url":"https://api.github.com/users/craffael/following{/other_user}","gists_url":"https://api.github.com/users/craffael/gists{/gist_id}","starred_url":"https://api.github.com/users/craffael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craffael/subscriptions","organizations_url":"https://api.github.com/users/craffael/orgs","repos_url":"https://api.github.com/users/craffael/repos","events_url":"https://api.github.com/users/craffael/events{/privacy}","received_events_url":"https://api.github.com/users/craffael/received_events","type":"User","site_admin":false},"html_url":"https://github.com/craffael/lehrfempp","description":"Simplistic Finite Element Framework for research and eduction","fork":false,"url":"https://api.github.com/repos/craffael/lehrfempp","forks_url":"https://api.github.com/repos/craffael/lehrfempp/forks","keys_url":"https://api.github.com/repos/craffael/lehrfempp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/craffael/lehrfempp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/craffael/lehrfempp/teams","hooks_url":"https://api.github.com/repos/craffael/lehrfempp/hooks","issue_events_url":"https://api.github.com/repos/craffael/lehrfempp/issues/events{/number}","events_url":"https://api.github.com/repos/craffael/lehrfempp/events","assignees_url":"https://api.github.com/repos/craffael/lehrfempp/assignees{/user}","branches_url":"https://api.github.com/repos/craffael/lehrfempp/branches{/branch}","tags_url":"https://api.github.com/repos/craffael/lehrfempp/tags","blobs_url":"https://api.github.com/repos/craffael/lehrfempp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/craffael/lehrfempp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/craffael/lehrfempp/git/refs{/sha}","trees_url":"https://api.github.com/repos/craffael/lehrfempp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/craffael/lehrfempp/statuses/{sha}","languages_url":"https://api.github.com/repos/craffael/lehrfempp/languages","stargazers_url":"https://api.github.com/repos/craffael/lehrfempp/stargazers","contributors_url":"https://api.github.com/repos/craffael/lehrfempp/contributors","subscribers_url":"https://api.github.com/repos/craffael/lehrfempp/subscribers","subscription_url":"https://api.github.com/repos/craffael/lehrfempp/subscription","commits_url":"https://api.github.com/repos/craffael/lehrfempp/commits{/sha}","git_commits_url":"https://api.github.com/repos/craffael/lehrfempp/git/commits{/sha}","comments_url":"https://api.github.com/repos/craffael/lehrfempp/comments{/number}","issue_comment_url":"https://api.github.com/repos/craffael/lehrfempp/issues/comments{/number}","contents_url":"https://api.github.com/repos/craffael/lehrfempp/contents/{+path}","compare_url":"https://api.github.com/repos/craffael/lehrfempp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/craffael/lehrfempp/merges","archive_url":"https://api.github.com/repos/craffael/lehrfempp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/craffael/lehrfempp/downloads","issues_url":"https://api.github.com/repos/craffael/lehrfempp/issues{/number}","pulls_url":"https://api.github.com/repos/craffael/lehrfempp/pulls{/number}","milestones_url":"https://api.github.com/repos/craffael/lehrfempp/milestones{/number}","notifications_url":"https://api.github.com/repos/craffael/lehrfempp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/craffael/lehrfempp/labels{/name}","releases_url":"https://api.github.com/repos/craffael/lehrfempp/releases{/id}","deployments_url":"https://api.github.com/repos/craffael/lehrfempp/deployments","created_at":"2018-04-06T14:21:27Z","updated_at":"2018-11-06T20:04:33Z","pushed_at":"2018-11-06T20:40:36Z","git_url":"git://github.com/craffael/lehrfempp.git","ssh_url":"git@github.com:craffael/lehrfempp.git","clone_url":"https://github.com/craffael/lehrfempp.git","svn_url":"https://github.com/craffael/lehrfempp","homepage":null,"size":6151,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":16,"watchers":1,"default_branch":"master"}},"base":{"label":"craffael:fix-point-integration-element","ref":"fix-point-integration-element","sha":"4d604ff415e90a66724858f039f86cc09fa69954","user":{"login":"craffael","id":15138672,"node_id":"MDQ6VXNlcjE1MTM4Njcy","avatar_url":"https://avatars1.githubusercontent.com/u/15138672?v=4","gravatar_id":"","url":"https://api.github.com/users/craffael","html_url":"https://github.com/craffael","followers_url":"https://api.github.com/users/craffael/followers","following_url":"https://api.github.com/users/craffael/following{/other_user}","gists_url":"https://api.github.com/users/craffael/gists{/gist_id}","starred_url":"https://api.github.com/users/craffael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craffael/subscriptions","organizations_url":"https://api.github.com/users/craffael/orgs","repos_url":"https://api.github.com/users/craffael/repos","events_url":"https://api.github.com/users/craffael/events{/privacy}","received_events_url":"https://api.github.com/users/craffael/received_events","type":"User","site_admin":false},"repo":{"id":128404634,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg0MDQ2MzQ=","name":"lehrfempp","full_name":"craffael/lehrfempp","private":false,"owner":{"login":"craffael","id":15138672,"node_id":"MDQ6VXNlcjE1MTM4Njcy","avatar_url":"https://avatars1.githubusercontent.com/u/15138672?v=4","gravatar_id":"","url":"https://api.github.com/users/craffael","html_url":"https://github.com/craffael","followers_url":"https://api.github.com/users/craffael/followers","following_url":"https://api.github.com/users/craffael/following{/other_user}","gists_url":"https://api.github.com/users/craffael/gists{/gist_id}","starred_url":"https://api.github.com/users/craffael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craffael/subscriptions","organizations_url":"https://api.github.com/users/craffael/orgs","repos_url":"https://api.github.com/users/craffael/repos","events_url":"https://api.github.com/users/craffael/events{/privacy}","received_events_url":"https://api.github.com/users/craffael/received_events","type":"User","site_admin":false},"html_url":"https://github.com/craffael/lehrfempp","description":"Simplistic Finite Element Framework for research and eduction","fork":false,"url":"https://api.github.com/repos/craffael/lehrfempp","forks_url":"https://api.github.com/repos/craffael/lehrfempp/forks","keys_url":"https://api.github.com/repos/craffael/lehrfempp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/craffael/lehrfempp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/craffael/lehrfempp/teams","hooks_url":"https://api.github.com/repos/craffael/lehrfempp/hooks","issue_events_url":"https://api.github.com/repos/craffael/lehrfempp/issues/events{/number}","events_url":"https://api.github.com/repos/craffael/lehrfempp/events","assignees_url":"https://api.github.com/repos/craffael/lehrfempp/assignees{/user}","branches_url":"https://api.github.com/repos/craffael/lehrfempp/branches{/branch}","tags_url":"https://api.github.com/repos/craffael/lehrfempp/tags","blobs_url":"https://api.github.com/repos/craffael/lehrfempp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/craffael/lehrfempp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/craffael/lehrfempp/git/refs{/sha}","trees_url":"https://api.github.com/repos/craffael/lehrfempp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/craffael/lehrfempp/statuses/{sha}","languages_url":"https://api.github.com/repos/craffael/lehrfempp/languages","stargazers_url":"https://api.github.com/repos/craffael/lehrfempp/stargazers","contributors_url":"https://api.github.com/repos/craffael/lehrfempp/contributors","subscribers_url":"https://api.github.com/repos/craffael/lehrfempp/subscribers","subscription_url":"https://api.github.com/repos/craffael/lehrfempp/subscription","commits_url":"https://api.github.com/repos/craffael/lehrfempp/commits{/sha}","git_commits_url":"https://api.github.com/repos/craffael/lehrfempp/git/commits{/sha}","comments_url":"https://api.github.com/repos/craffael/lehrfempp/comments{/number}","issue_comment_url":"https://api.github.com/repos/craffael/lehrfempp/issues/comments{/number}","contents_url":"https://api.github.com/repos/craffael/lehrfempp/contents/{+path}","compare_url":"https://api.github.com/repos/craffael/lehrfempp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/craffael/lehrfempp/merges","archive_url":"https://api.github.com/repos/craffael/lehrfempp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/craffael/lehrfempp/downloads","issues_url":"https://api.github.com/repos/craffael/lehrfempp/issues{/number}","pulls_url":"https://api.github.com/repos/craffael/lehrfempp/pulls{/number}","milestones_url":"https://api.github.com/repos/craffael/lehrfempp/milestones{/number}","notifications_url":"https://api.github.com/repos/craffael/lehrfempp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/craffael/lehrfempp/labels{/name}","releases_url":"https://api.github.com/repos/craffael/lehrfempp/releases{/id}","deployments_url":"https://api.github.com/repos/craffael/lehrfempp/deployments","created_at":"2018-04-06T14:21:27Z","updated_at":"2018-11-06T20:04:33Z","pushed_at":"2018-11-06T20:40:36Z","git_url":"git://github.com/craffael/lehrfempp.git","ssh_url":"git@github.com:craffael/lehrfempp.git","clone_url":"https://github.com/craffael/lehrfempp.git","svn_url":"https://github.com/craffael/lehrfempp","homepage":null,"size":6151,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":16,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/craffael/lehrfempp/pulls/70"},"html":{"href":"https://github.com/craffael/lehrfempp/pull/70"},"issue":{"href":"https://api.github.com/repos/craffael/lehrfempp/issues/70"},"comments":{"href":"https://api.github.com/repos/craffael/lehrfempp/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/craffael/lehrfempp/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/craffael/lehrfempp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/craffael/lehrfempp/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/craffael/lehrfempp/statuses/87633f5a1c922297deed5a27b2961cf7def0559a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"craffael"}}