{"action":"created","comment":{"url":"https://api.github.com/repos/fbu-team-awesome/social-maps/pulls/comments/204978405","pull_request_review_id":140157555,"id":204978405,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDk3ODQwNQ==","diff_hunk":"@@ -12,78 +12,99 @@\n #import \"HMSegmentedControl.h\"\n #import \"ProfileListCell.h\"\n #import \"DetailsViewController.h\"\n+#import \"NCHelper.h\"\n+\n+static NSString *const kNoFavoriteMsg = @\"You have no favorites!\";\n+static NSString *const kNoWishlistMsg = @\"You have no places in your wishlist!\";\n \n @interface ListViewController ()\n \n @property (weak, nonatomic) IBOutlet UITableView *tableView;\n @property (weak, nonatomic) IBOutlet UIView *defaultView;\n @property (weak, nonatomic) IBOutlet UILabel *defaultViewLabel;\n-@property (strong, nonatomic) NSArray<GMSPlace*>* favorites;\n-@property (strong, nonatomic) NSArray<GMSPlace*>* wishlist;\n+@property (strong, nonatomic) NSArray<GMSPlace *> *favorites;\n+@property (strong, nonatomic) NSArray<GMSPlace *> *wishlist;\n @property (assign, nonatomic) long segmentIndex;\n+@property (weak, nonatomic) IBOutlet UIActivityIndicatorView *progressIndicator;","path":"View Controllers/ListViewController.m","position":19,"original_position":19,"commit_id":"c219e11fcbbc42a58113a59af317de8905de32a8","original_commit_id":"c219e11fcbbc42a58113a59af317de8905de32a8","user":{"login":"stephinphection","id":40803730,"node_id":"MDQ6VXNlcjQwODAzNzMw","avatar_url":"https://avatars0.githubusercontent.com/u/40803730?v=4","gravatar_id":"","url":"https://api.github.com/users/stephinphection","html_url":"https://github.com/stephinphection","followers_url":"https://api.github.com/users/stephinphection/followers","following_url":"https://api.github.com/users/stephinphection/following{/other_user}","gists_url":"https://api.github.com/users/stephinphection/gists{/gist_id}","starred_url":"https://api.github.com/users/stephinphection/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephinphection/subscriptions","organizations_url":"https://api.github.com/users/stephinphection/orgs","repos_url":"https://api.github.com/users/stephinphection/repos","events_url":"https://api.github.com/users/stephinphection/events{/privacy}","received_events_url":"https://api.github.com/users/stephinphection/received_events","type":"User","site_admin":false},"body":"Nit, but i'd group this with the other IBOutlets","created_at":"2018-07-25T04:32:20Z","updated_at":"2018-07-25T04:32:20Z","html_url":"https://github.com/fbu-team-awesome/social-maps/pull/30#discussion_r204978405","pull_request_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/pulls/30","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/fbu-team-awesome/social-maps/pulls/comments/204978405"},"html":{"href":"https://github.com/fbu-team-awesome/social-maps/pull/30#discussion_r204978405"},"pull_request":{"href":"https://api.github.com/repos/fbu-team-awesome/social-maps/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/fbu-team-awesome/social-maps/pulls/30","id":203691683,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNjkxNjgz","html_url":"https://github.com/fbu-team-awesome/social-maps/pull/30","diff_url":"https://github.com/fbu-team-awesome/social-maps/pull/30.diff","patch_url":"https://github.com/fbu-team-awesome/social-maps/pull/30.patch","issue_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/issues/30","number":30,"state":"open","locked":false,"title":"List VC UX Improvements","user":{"login":"cbarrazaa1","id":31463640,"node_id":"MDQ6VXNlcjMxNDYzNjQw","avatar_url":"https://avatars3.githubusercontent.com/u/31463640?v=4","gravatar_id":"","url":"https://api.github.com/users/cbarrazaa1","html_url":"https://github.com/cbarrazaa1","followers_url":"https://api.github.com/users/cbarrazaa1/followers","following_url":"https://api.github.com/users/cbarrazaa1/following{/other_user}","gists_url":"https://api.github.com/users/cbarrazaa1/gists{/gist_id}","starred_url":"https://api.github.com/users/cbarrazaa1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbarrazaa1/subscriptions","organizations_url":"https://api.github.com/users/cbarrazaa1/orgs","repos_url":"https://api.github.com/users/cbarrazaa1/repos","events_url":"https://api.github.com/users/cbarrazaa1/events{/privacy}","received_events_url":"https://api.github.com/users/cbarrazaa1/received_events","type":"User","site_admin":false},"body":"- Now has progress indicator and pull to refresh.\r\n- Had to make some changes to the default label that is shown when there's no favs/wishlist to adapt it to the progress indicator.\r\n- The notification listener for adding favs/wishlist wasn't working properly; fixed.","created_at":"2018-07-25T00:41:28Z","updated_at":"2018-07-25T04:32:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a25a69daebd86d2883df6c4cf1fb893feb129e06","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/pulls/30/commits","review_comments_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/pulls/30/comments","review_comment_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/issues/30/comments","statuses_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/statuses/c219e11fcbbc42a58113a59af317de8905de32a8","head":{"label":"fbu-team-awesome:listVC-ux-improvements","ref":"listVC-ux-improvements","sha":"c219e11fcbbc42a58113a59af317de8905de32a8","user":{"login":"fbu-team-awesome","id":40898098,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODk4MDk4","avatar_url":"https://avatars0.githubusercontent.com/u/40898098?v=4","gravatar_id":"","url":"https://api.github.com/users/fbu-team-awesome","html_url":"https://github.com/fbu-team-awesome","followers_url":"https://api.github.com/users/fbu-team-awesome/followers","following_url":"https://api.github.com/users/fbu-team-awesome/following{/other_user}","gists_url":"https://api.github.com/users/fbu-team-awesome/gists{/gist_id}","starred_url":"https://api.github.com/users/fbu-team-awesome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbu-team-awesome/subscriptions","organizations_url":"https://api.github.com/users/fbu-team-awesome/orgs","repos_url":"https://api.github.com/users/fbu-team-awesome/repos","events_url":"https://api.github.com/users/fbu-team-awesome/events{/privacy}","received_events_url":"https://api.github.com/users/fbu-team-awesome/received_events","type":"Organization","site_admin":false},"repo":{"id":140013508,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAwMTM1MDg=","name":"social-maps","full_name":"fbu-team-awesome/social-maps","owner":{"login":"fbu-team-awesome","id":40898098,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODk4MDk4","avatar_url":"https://avatars0.githubusercontent.com/u/40898098?v=4","gravatar_id":"","url":"https://api.github.com/users/fbu-team-awesome","html_url":"https://github.com/fbu-team-awesome","followers_url":"https://api.github.com/users/fbu-team-awesome/followers","following_url":"https://api.github.com/users/fbu-team-awesome/following{/other_user}","gists_url":"https://api.github.com/users/fbu-team-awesome/gists{/gist_id}","starred_url":"https://api.github.com/users/fbu-team-awesome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbu-team-awesome/subscriptions","organizations_url":"https://api.github.com/users/fbu-team-awesome/orgs","repos_url":"https://api.github.com/users/fbu-team-awesome/repos","events_url":"https://api.github.com/users/fbu-team-awesome/events{/privacy}","received_events_url":"https://api.github.com/users/fbu-team-awesome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fbu-team-awesome/social-maps","description":null,"fork":false,"url":"https://api.github.com/repos/fbu-team-awesome/social-maps","forks_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/forks","keys_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/teams","hooks_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/hooks","issue_events_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/issues/events{/number}","events_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/events","assignees_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/assignees{/user}","branches_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/branches{/branch}","tags_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/tags","blobs_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/git/refs{/sha}","trees_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/statuses/{sha}","languages_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/languages","stargazers_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/stargazers","contributors_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/contributors","subscribers_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/subscribers","subscription_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/subscription","commits_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/commits{/sha}","git_commits_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/git/commits{/sha}","comments_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/comments{/number}","issue_comment_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/issues/comments{/number}","contents_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/contents/{+path}","compare_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/merges","archive_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/downloads","issues_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/issues{/number}","pulls_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/pulls{/number}","milestones_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/milestones{/number}","notifications_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/labels{/name}","releases_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/releases{/id}","deployments_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/deployments","created_at":"2018-07-06T17:32:17Z","updated_at":"2018-07-24T22:58:08Z","pushed_at":"2018-07-25T04:25:48Z","git_url":"git://github.com/fbu-team-awesome/social-maps.git","ssh_url":"git@github.com:fbu-team-awesome/social-maps.git","clone_url":"https://github.com/fbu-team-awesome/social-maps.git","svn_url":"https://github.com/fbu-team-awesome/social-maps","homepage":null,"size":58539,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"fbu-team-awesome:master","ref":"master","sha":"6090502f75ae12cf1054f658e3db99bbc3e30c27","user":{"login":"fbu-team-awesome","id":40898098,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODk4MDk4","avatar_url":"https://avatars0.githubusercontent.com/u/40898098?v=4","gravatar_id":"","url":"https://api.github.com/users/fbu-team-awesome","html_url":"https://github.com/fbu-team-awesome","followers_url":"https://api.github.com/users/fbu-team-awesome/followers","following_url":"https://api.github.com/users/fbu-team-awesome/following{/other_user}","gists_url":"https://api.github.com/users/fbu-team-awesome/gists{/gist_id}","starred_url":"https://api.github.com/users/fbu-team-awesome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbu-team-awesome/subscriptions","organizations_url":"https://api.github.com/users/fbu-team-awesome/orgs","repos_url":"https://api.github.com/users/fbu-team-awesome/repos","events_url":"https://api.github.com/users/fbu-team-awesome/events{/privacy}","received_events_url":"https://api.github.com/users/fbu-team-awesome/received_events","type":"Organization","site_admin":false},"repo":{"id":140013508,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAwMTM1MDg=","name":"social-maps","full_name":"fbu-team-awesome/social-maps","owner":{"login":"fbu-team-awesome","id":40898098,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODk4MDk4","avatar_url":"https://avatars0.githubusercontent.com/u/40898098?v=4","gravatar_id":"","url":"https://api.github.com/users/fbu-team-awesome","html_url":"https://github.com/fbu-team-awesome","followers_url":"https://api.github.com/users/fbu-team-awesome/followers","following_url":"https://api.github.com/users/fbu-team-awesome/following{/other_user}","gists_url":"https://api.github.com/users/fbu-team-awesome/gists{/gist_id}","starred_url":"https://api.github.com/users/fbu-team-awesome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbu-team-awesome/subscriptions","organizations_url":"https://api.github.com/users/fbu-team-awesome/orgs","repos_url":"https://api.github.com/users/fbu-team-awesome/repos","events_url":"https://api.github.com/users/fbu-team-awesome/events{/privacy}","received_events_url":"https://api.github.com/users/fbu-team-awesome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fbu-team-awesome/social-maps","description":null,"fork":false,"url":"https://api.github.com/repos/fbu-team-awesome/social-maps","forks_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/forks","keys_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/teams","hooks_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/hooks","issue_events_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/issues/events{/number}","events_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/events","assignees_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/assignees{/user}","branches_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/branches{/branch}","tags_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/tags","blobs_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/git/refs{/sha}","trees_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/statuses/{sha}","languages_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/languages","stargazers_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/stargazers","contributors_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/contributors","subscribers_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/subscribers","subscription_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/subscription","commits_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/commits{/sha}","git_commits_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/git/commits{/sha}","comments_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/comments{/number}","issue_comment_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/issues/comments{/number}","contents_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/contents/{+path}","compare_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/merges","archive_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/downloads","issues_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/issues{/number}","pulls_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/pulls{/number}","milestones_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/milestones{/number}","notifications_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/labels{/name}","releases_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/releases{/id}","deployments_url":"https://api.github.com/repos/fbu-team-awesome/social-maps/deployments","created_at":"2018-07-06T17:32:17Z","updated_at":"2018-07-24T22:58:08Z","pushed_at":"2018-07-25T04:25:48Z","git_url":"git://github.com/fbu-team-awesome/social-maps.git","ssh_url":"git@github.com:fbu-team-awesome/social-maps.git","clone_url":"https://github.com/fbu-team-awesome/social-maps.git","svn_url":"https://github.com/fbu-team-awesome/social-maps","homepage":null,"size":58539,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fbu-team-awesome/social-maps/pulls/30"},"html":{"href":"https://github.com/fbu-team-awesome/social-maps/pull/30"},"issue":{"href":"https://api.github.com/repos/fbu-team-awesome/social-maps/issues/30"},"comments":{"href":"https://api.github.com/repos/fbu-team-awesome/social-maps/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/fbu-team-awesome/social-maps/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/fbu-team-awesome/social-maps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fbu-team-awesome/social-maps/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/fbu-team-awesome/social-maps/statuses/c219e11fcbbc42a58113a59af317de8905de32a8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"stephinphection"}}