{"action":"created","comment":{"url":"https://api.github.com/repos/solana-labs/solana/pulls/comments/203066278","pull_request_review_id":137883535,"id":203066278,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzA2NjI3OA==","diff_hunk":"@@ -355,6 +359,26 @@ mod tests {\n         let exit = Arc::new(AtomicBool::new(false));\n         let entry = tn.data.clone();\n         let v = FullNode::new_validator(kp, bank, 0, None, tn, &entry, exit);\n+        v.exit();","path":"src/fullnode.rs","position":18,"original_position":18,"commit_id":"0e6be8b054d58c30adf86dc1628a1cd4c7ec2905","original_commit_id":"0e6be8b054d58c30adf86dc1628a1cd4c7ec2905","user":{"login":"garious","id":55449,"node_id":"MDQ6VXNlcjU1NDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/55449?v=4","gravatar_id":"","url":"https://api.github.com/users/garious","html_url":"https://github.com/garious","followers_url":"https://api.github.com/users/garious/followers","following_url":"https://api.github.com/users/garious/following{/other_user}","gists_url":"https://api.github.com/users/garious/gists{/gist_id}","starred_url":"https://api.github.com/users/garious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garious/subscriptions","organizations_url":"https://api.github.com/users/garious/orgs","repos_url":"https://api.github.com/users/garious/repos","events_url":"https://api.github.com/users/garious/events{/privacy}","received_events_url":"https://api.github.com/users/garious/received_events","type":"User","site_admin":false},"body":"This shouldn't be here.","created_at":"2018-07-17T15:22:01Z","updated_at":"2018-07-17T15:24:12Z","html_url":"https://github.com/solana-labs/solana/pull/659#discussion_r203066278","pull_request_url":"https://api.github.com/repos/solana-labs/solana/pulls/659","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/comments/203066278"},"html":{"href":"https://github.com/solana-labs/solana/pull/659#discussion_r203066278"},"pull_request":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/659"}}},"pull_request":{"url":"https://api.github.com/repos/solana-labs/solana/pulls/659","id":201827870,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxODI3ODcw","html_url":"https://github.com/solana-labs/solana/pull/659","diff_url":"https://github.com/solana-labs/solana/pull/659.diff","patch_url":"https://github.com/solana-labs/solana/pull/659.patch","issue_url":"https://api.github.com/repos/solana-labs/solana/issues/659","number":659,"state":"open","locked":false,"title":"Multinode fast exit","user":{"login":"aeyakovenko","id":1029046,"node_id":"MDQ6VXNlcjEwMjkwNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1029046?v=4","gravatar_id":"","url":"https://api.github.com/users/aeyakovenko","html_url":"https://github.com/aeyakovenko","followers_url":"https://api.github.com/users/aeyakovenko/followers","following_url":"https://api.github.com/users/aeyakovenko/following{/other_user}","gists_url":"https://api.github.com/users/aeyakovenko/gists{/gist_id}","starred_url":"https://api.github.com/users/aeyakovenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeyakovenko/subscriptions","organizations_url":"https://api.github.com/users/aeyakovenko/orgs","repos_url":"https://api.github.com/users/aeyakovenko/repos","events_url":"https://api.github.com/users/aeyakovenko/events{/privacy}","received_events_url":"https://api.github.com/users/aeyakovenko/received_events","type":"User","site_admin":false},"body":"Multinode dynamic test was sequentially exiting validators which took over a minute, this allows it to notify all of them to exit before join.  Exit is no longer noticeable.  ","created_at":"2018-07-17T05:27:53Z","updated_at":"2018-07-17T15:24:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b36d0ce93e4a8513c006babc2e47d0c74accc69","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/solana-labs/solana/pulls/659/commits","review_comments_url":"https://api.github.com/repos/solana-labs/solana/pulls/659/comments","review_comment_url":"https://api.github.com/repos/solana-labs/solana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solana-labs/solana/issues/659/comments","statuses_url":"https://api.github.com/repos/solana-labs/solana/statuses/0e6be8b054d58c30adf86dc1628a1cd4c7ec2905","head":{"label":"aeyakovenko:multinode_fast_exit","ref":"multinode_fast_exit","sha":"0e6be8b054d58c30adf86dc1628a1cd4c7ec2905","user":{"login":"aeyakovenko","id":1029046,"node_id":"MDQ6VXNlcjEwMjkwNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1029046?v=4","gravatar_id":"","url":"https://api.github.com/users/aeyakovenko","html_url":"https://github.com/aeyakovenko","followers_url":"https://api.github.com/users/aeyakovenko/followers","following_url":"https://api.github.com/users/aeyakovenko/following{/other_user}","gists_url":"https://api.github.com/users/aeyakovenko/gists{/gist_id}","starred_url":"https://api.github.com/users/aeyakovenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeyakovenko/subscriptions","organizations_url":"https://api.github.com/users/aeyakovenko/orgs","repos_url":"https://api.github.com/users/aeyakovenko/repos","events_url":"https://api.github.com/users/aeyakovenko/events{/privacy}","received_events_url":"https://api.github.com/users/aeyakovenko/received_events","type":"User","site_admin":false},"repo":{"id":124140461,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQxNDA0NjE=","name":"solana","full_name":"aeyakovenko/solana","owner":{"login":"aeyakovenko","id":1029046,"node_id":"MDQ6VXNlcjEwMjkwNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1029046?v=4","gravatar_id":"","url":"https://api.github.com/users/aeyakovenko","html_url":"https://github.com/aeyakovenko","followers_url":"https://api.github.com/users/aeyakovenko/followers","following_url":"https://api.github.com/users/aeyakovenko/following{/other_user}","gists_url":"https://api.github.com/users/aeyakovenko/gists{/gist_id}","starred_url":"https://api.github.com/users/aeyakovenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeyakovenko/subscriptions","organizations_url":"https://api.github.com/users/aeyakovenko/orgs","repos_url":"https://api.github.com/users/aeyakovenko/repos","events_url":"https://api.github.com/users/aeyakovenko/events{/privacy}","received_events_url":"https://api.github.com/users/aeyakovenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aeyakovenko/solana","description":"a high performance blockchain","fork":true,"url":"https://api.github.com/repos/aeyakovenko/solana","forks_url":"https://api.github.com/repos/aeyakovenko/solana/forks","keys_url":"https://api.github.com/repos/aeyakovenko/solana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeyakovenko/solana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeyakovenko/solana/teams","hooks_url":"https://api.github.com/repos/aeyakovenko/solana/hooks","issue_events_url":"https://api.github.com/repos/aeyakovenko/solana/issues/events{/number}","events_url":"https://api.github.com/repos/aeyakovenko/solana/events","assignees_url":"https://api.github.com/repos/aeyakovenko/solana/assignees{/user}","branches_url":"https://api.github.com/repos/aeyakovenko/solana/branches{/branch}","tags_url":"https://api.github.com/repos/aeyakovenko/solana/tags","blobs_url":"https://api.github.com/repos/aeyakovenko/solana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeyakovenko/solana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeyakovenko/solana/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeyakovenko/solana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeyakovenko/solana/statuses/{sha}","languages_url":"https://api.github.com/repos/aeyakovenko/solana/languages","stargazers_url":"https://api.github.com/repos/aeyakovenko/solana/stargazers","contributors_url":"https://api.github.com/repos/aeyakovenko/solana/contributors","subscribers_url":"https://api.github.com/repos/aeyakovenko/solana/subscribers","subscription_url":"https://api.github.com/repos/aeyakovenko/solana/subscription","commits_url":"https://api.github.com/repos/aeyakovenko/solana/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeyakovenko/solana/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeyakovenko/solana/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeyakovenko/solana/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeyakovenko/solana/contents/{+path}","compare_url":"https://api.github.com/repos/aeyakovenko/solana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeyakovenko/solana/merges","archive_url":"https://api.github.com/repos/aeyakovenko/solana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeyakovenko/solana/downloads","issues_url":"https://api.github.com/repos/aeyakovenko/solana/issues{/number}","pulls_url":"https://api.github.com/repos/aeyakovenko/solana/pulls{/number}","milestones_url":"https://api.github.com/repos/aeyakovenko/solana/milestones{/number}","notifications_url":"https://api.github.com/repos/aeyakovenko/solana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeyakovenko/solana/labels{/name}","releases_url":"https://api.github.com/repos/aeyakovenko/solana/releases{/id}","deployments_url":"https://api.github.com/repos/aeyakovenko/solana/deployments","created_at":"2018-03-06T21:24:10Z","updated_at":"2018-07-17T04:55:32Z","pushed_at":"2018-07-17T15:18:48Z","git_url":"git://github.com/aeyakovenko/solana.git","ssh_url":"git@github.com:aeyakovenko/solana.git","clone_url":"https://github.com/aeyakovenko/solana.git","svn_url":"https://github.com/aeyakovenko/solana","homepage":"https://solana.com","size":9982,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solana-labs:master","ref":"master","sha":"d8c9655128b997e691305cd56e22c9bb6fbcb64b","user":{"login":"solana-labs","id":35608259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjA4MjU5","avatar_url":"https://avatars3.githubusercontent.com/u/35608259?v=4","gravatar_id":"","url":"https://api.github.com/users/solana-labs","html_url":"https://github.com/solana-labs","followers_url":"https://api.github.com/users/solana-labs/followers","following_url":"https://api.github.com/users/solana-labs/following{/other_user}","gists_url":"https://api.github.com/users/solana-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/solana-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solana-labs/subscriptions","organizations_url":"https://api.github.com/users/solana-labs/orgs","repos_url":"https://api.github.com/users/solana-labs/repos","events_url":"https://api.github.com/users/solana-labs/events{/privacy}","received_events_url":"https://api.github.com/users/solana-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":121470383,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0NzAzODM=","name":"solana","full_name":"solana-labs/solana","owner":{"login":"solana-labs","id":35608259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjA4MjU5","avatar_url":"https://avatars3.githubusercontent.com/u/35608259?v=4","gravatar_id":"","url":"https://api.github.com/users/solana-labs","html_url":"https://github.com/solana-labs","followers_url":"https://api.github.com/users/solana-labs/followers","following_url":"https://api.github.com/users/solana-labs/following{/other_user}","gists_url":"https://api.github.com/users/solana-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/solana-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solana-labs/subscriptions","organizations_url":"https://api.github.com/users/solana-labs/orgs","repos_url":"https://api.github.com/users/solana-labs/repos","events_url":"https://api.github.com/users/solana-labs/events{/privacy}","received_events_url":"https://api.github.com/users/solana-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solana-labs/solana","description":"Blockchain, Rebuilt for Scale","fork":false,"url":"https://api.github.com/repos/solana-labs/solana","forks_url":"https://api.github.com/repos/solana-labs/solana/forks","keys_url":"https://api.github.com/repos/solana-labs/solana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solana-labs/solana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solana-labs/solana/teams","hooks_url":"https://api.github.com/repos/solana-labs/solana/hooks","issue_events_url":"https://api.github.com/repos/solana-labs/solana/issues/events{/number}","events_url":"https://api.github.com/repos/solana-labs/solana/events","assignees_url":"https://api.github.com/repos/solana-labs/solana/assignees{/user}","branches_url":"https://api.github.com/repos/solana-labs/solana/branches{/branch}","tags_url":"https://api.github.com/repos/solana-labs/solana/tags","blobs_url":"https://api.github.com/repos/solana-labs/solana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solana-labs/solana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solana-labs/solana/git/refs{/sha}","trees_url":"https://api.github.com/repos/solana-labs/solana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solana-labs/solana/statuses/{sha}","languages_url":"https://api.github.com/repos/solana-labs/solana/languages","stargazers_url":"https://api.github.com/repos/solana-labs/solana/stargazers","contributors_url":"https://api.github.com/repos/solana-labs/solana/contributors","subscribers_url":"https://api.github.com/repos/solana-labs/solana/subscribers","subscription_url":"https://api.github.com/repos/solana-labs/solana/subscription","commits_url":"https://api.github.com/repos/solana-labs/solana/commits{/sha}","git_commits_url":"https://api.github.com/repos/solana-labs/solana/git/commits{/sha}","comments_url":"https://api.github.com/repos/solana-labs/solana/comments{/number}","issue_comment_url":"https://api.github.com/repos/solana-labs/solana/issues/comments{/number}","contents_url":"https://api.github.com/repos/solana-labs/solana/contents/{+path}","compare_url":"https://api.github.com/repos/solana-labs/solana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solana-labs/solana/merges","archive_url":"https://api.github.com/repos/solana-labs/solana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solana-labs/solana/downloads","issues_url":"https://api.github.com/repos/solana-labs/solana/issues{/number}","pulls_url":"https://api.github.com/repos/solana-labs/solana/pulls{/number}","milestones_url":"https://api.github.com/repos/solana-labs/solana/milestones{/number}","notifications_url":"https://api.github.com/repos/solana-labs/solana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solana-labs/solana/labels{/name}","releases_url":"https://api.github.com/repos/solana-labs/solana/releases{/id}","deployments_url":"https://api.github.com/repos/solana-labs/solana/deployments","created_at":"2018-02-14T04:26:27Z","updated_at":"2018-07-17T15:20:39Z","pushed_at":"2018-07-17T15:20:36Z","git_url":"git://github.com/solana-labs/solana.git","ssh_url":"git@github.com:solana-labs/solana.git","clone_url":"https://github.com/solana-labs/solana.git","svn_url":"https://github.com/solana-labs/solana","homepage":"https://solana.com","size":9687,"stargazers_count":282,"watchers_count":282,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":45,"open_issues":56,"watchers":282,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/659"},"html":{"href":"https://github.com/solana-labs/solana/pull/659"},"issue":{"href":"https://api.github.com/repos/solana-labs/solana/issues/659"},"comments":{"href":"https://api.github.com/repos/solana-labs/solana/issues/659/comments"},"review_comments":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/659/comments"},"review_comment":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/659/commits"},"statuses":{"href":"https://api.github.com/repos/solana-labs/solana/statuses/0e6be8b054d58c30adf86dc1628a1cd4c7ec2905"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"garious"}}