{"action":"created","comment":{"url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/pulls/comments/240684640","pull_request_review_id":183771359,"id":240684640,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDY4NDY0MA==","diff_hunk":"@@ -35,24 +35,28 @@ class JPetWriter;\n  * with the use of some time window value. This value is given by\n  * default, but it can be provided by the user in parameters file.\n  * Also user can require to save only Events of minimum multiplicity\n+ * and if include Corrupted Hits in the created events.\n  */\n class EventFinder: public JPetUserTask\n {\n public:\n   EventFinder(const char * name);\n-  virtual ~EventFinder(){}\n+  virtual ~EventFinder();\n   virtual bool init() override;\n   virtual bool exec() override;\n   virtual bool terminate() override;\n \n protected:\n-  void saveEvents(const std::vector<JPetEvent>& event);\n   std::vector<JPetEvent> buildEvents(const JPetTimeWindow & hits);\n+  void saveEvents(const std::vector<JPetEvent>& event);\n+  void initialiseHistograms();\n+  const std::string kUseCorruptedHitsParamKey = \"EventFinder_UseCorruptedHits_bool\";\n+  const std::string kEventMinMultiplicity = \"EventFinder_MinEventMultiplicity_int\";\n   const std::string kSaveControlHistosParamKey = \"Save_Cotrol_Histograms_bool\";","path":"LargeBarrelAnalysis/EventFinder.h","position":30,"original_position":30,"commit_id":"2c43813ad07784216c4e9aa19d4ea05a27180a90","original_commit_id":"2c43813ad07784216c4e9aa19d4ea05a27180a90","user":{"login":"wkrzemien","id":11519095,"node_id":"MDQ6VXNlcjExNTE5MDk1","avatar_url":"https://avatars3.githubusercontent.com/u/11519095?v=4","gravatar_id":"","url":"https://api.github.com/users/wkrzemien","html_url":"https://github.com/wkrzemien","followers_url":"https://api.github.com/users/wkrzemien/followers","following_url":"https://api.github.com/users/wkrzemien/following{/other_user}","gists_url":"https://api.github.com/users/wkrzemien/gists{/gist_id}","starred_url":"https://api.github.com/users/wkrzemien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkrzemien/subscriptions","organizations_url":"https://api.github.com/users/wkrzemien/orgs","repos_url":"https://api.github.com/users/wkrzemien/repos","events_url":"https://api.github.com/users/wkrzemien/events{/privacy}","received_events_url":"https://api.github.com/users/wkrzemien/received_events","type":"User","site_admin":false},"body":"Do we leave this typo for the future?","created_at":"2018-12-11T16:25:49Z","updated_at":"2018-12-11T16:25:50Z","html_url":"https://github.com/JPETTomography/j-pet-framework-examples/pull/107#discussion_r240684640","pull_request_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/pulls/107","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/pulls/comments/240684640"},"html":{"href":"https://github.com/JPETTomography/j-pet-framework-examples/pull/107#discussion_r240684640"},"pull_request":{"href":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/pulls/107"}}},"pull_request":{"url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/pulls/107","id":223902265,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzOTAyMjY1","html_url":"https://github.com/JPETTomography/j-pet-framework-examples/pull/107","diff_url":"https://github.com/JPETTomography/j-pet-framework-examples/pull/107.diff","patch_url":"https://github.com/JPETTomography/j-pet-framework-examples/pull/107.patch","issue_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/issues/107","number":107,"state":"open","locked":false,"title":"Changes for LLT case","user":{"login":"kkacprzak","id":4140375,"node_id":"MDQ6VXNlcjQxNDAzNzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4140375?v=4","gravatar_id":"","url":"https://api.github.com/users/kkacprzak","html_url":"https://github.com/kkacprzak","followers_url":"https://api.github.com/users/kkacprzak/followers","following_url":"https://api.github.com/users/kkacprzak/following{/other_user}","gists_url":"https://api.github.com/users/kkacprzak/gists{/gist_id}","starred_url":"https://api.github.com/users/kkacprzak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkacprzak/subscriptions","organizations_url":"https://api.github.com/users/kkacprzak/orgs","repos_url":"https://api.github.com/users/kkacprzak/repos","events_url":"https://api.github.com/users/kkacprzak/events{/privacy}","received_events_url":"https://api.github.com/users/kkacprzak/received_events","type":"User","site_admin":false},"body":"Expansion includes:\r\n- adding TimeWindowCreatorTools class with... tools for time window creation. \r\n- methods were extracted to tools class, including modifications of the Unpacker\r\n- application of flagging Signal Channels with RecoFlags - repeated Leadings are Corrupted\r\n- updating Signal Finder, Signal Transformer, Hit Finder and Event Finder with parameter reading for use/not use corrupted lower class structures\r\n- few new control histograms\r\n- more comments and descriptions  ","created_at":"2018-10-18T10:23:13Z","updated_at":"2018-12-11T16:25:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9df765af2a2e3b13cdf67d649db00f59084679eb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/pulls/107/commits","review_comments_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/pulls/107/comments","review_comment_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/issues/107/comments","statuses_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/statuses/2c43813ad07784216c4e9aa19d4ea05a27180a90","head":{"label":"kkacprzak:newSignalFinder","ref":"newSignalFinder","sha":"2c43813ad07784216c4e9aa19d4ea05a27180a90","user":{"login":"kkacprzak","id":4140375,"node_id":"MDQ6VXNlcjQxNDAzNzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4140375?v=4","gravatar_id":"","url":"https://api.github.com/users/kkacprzak","html_url":"https://github.com/kkacprzak","followers_url":"https://api.github.com/users/kkacprzak/followers","following_url":"https://api.github.com/users/kkacprzak/following{/other_user}","gists_url":"https://api.github.com/users/kkacprzak/gists{/gist_id}","starred_url":"https://api.github.com/users/kkacprzak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkacprzak/subscriptions","organizations_url":"https://api.github.com/users/kkacprzak/orgs","repos_url":"https://api.github.com/users/kkacprzak/repos","events_url":"https://api.github.com/users/kkacprzak/events{/privacy}","received_events_url":"https://api.github.com/users/kkacprzak/received_events","type":"User","site_admin":false},"repo":{"id":115713421,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU3MTM0MjE=","name":"j-pet-framework-examples","full_name":"kkacprzak/j-pet-framework-examples","private":false,"owner":{"login":"kkacprzak","id":4140375,"node_id":"MDQ6VXNlcjQxNDAzNzU=","avatar_url":"https://avatars2.githubusercontent.com/u/4140375?v=4","gravatar_id":"","url":"https://api.github.com/users/kkacprzak","html_url":"https://github.com/kkacprzak","followers_url":"https://api.github.com/users/kkacprzak/followers","following_url":"https://api.github.com/users/kkacprzak/following{/other_user}","gists_url":"https://api.github.com/users/kkacprzak/gists{/gist_id}","starred_url":"https://api.github.com/users/kkacprzak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkacprzak/subscriptions","organizations_url":"https://api.github.com/users/kkacprzak/orgs","repos_url":"https://api.github.com/users/kkacprzak/repos","events_url":"https://api.github.com/users/kkacprzak/events{/privacy}","received_events_url":"https://api.github.com/users/kkacprzak/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kkacprzak/j-pet-framework-examples","description":"Example analyses based on the J-PET Analysis Framework","fork":true,"url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples","forks_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/forks","keys_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/teams","hooks_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/hooks","issue_events_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/issues/events{/number}","events_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/events","assignees_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/assignees{/user}","branches_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/branches{/branch}","tags_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/tags","blobs_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/git/refs{/sha}","trees_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/statuses/{sha}","languages_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/languages","stargazers_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/stargazers","contributors_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/contributors","subscribers_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/subscribers","subscription_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/subscription","commits_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/commits{/sha}","git_commits_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/git/commits{/sha}","comments_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/comments{/number}","issue_comment_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/issues/comments{/number}","contents_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/contents/{+path}","compare_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/merges","archive_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/downloads","issues_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/issues{/number}","pulls_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/pulls{/number}","milestones_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/milestones{/number}","notifications_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/labels{/name}","releases_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/releases{/id}","deployments_url":"https://api.github.com/repos/kkacprzak/j-pet-framework-examples/deployments","created_at":"2017-12-29T10:33:46Z","updated_at":"2017-12-29T10:33:47Z","pushed_at":"2018-12-06T12:50:47Z","git_url":"git://github.com/kkacprzak/j-pet-framework-examples.git","ssh_url":"git@github.com:kkacprzak/j-pet-framework-examples.git","clone_url":"https://github.com/kkacprzak/j-pet-framework-examples.git","svn_url":"https://github.com/kkacprzak/j-pet-framework-examples","homepage":null,"size":1503,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JPETTomography:develop","ref":"develop","sha":"496badb7b17333b4e657911055d72d41ad8b0125","user":{"login":"JPETTomography","id":19532701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzAx","avatar_url":"https://avatars0.githubusercontent.com/u/19532701?v=4","gravatar_id":"","url":"https://api.github.com/users/JPETTomography","html_url":"https://github.com/JPETTomography","followers_url":"https://api.github.com/users/JPETTomography/followers","following_url":"https://api.github.com/users/JPETTomography/following{/other_user}","gists_url":"https://api.github.com/users/JPETTomography/gists{/gist_id}","starred_url":"https://api.github.com/users/JPETTomography/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JPETTomography/subscriptions","organizations_url":"https://api.github.com/users/JPETTomography/orgs","repos_url":"https://api.github.com/users/JPETTomography/repos","events_url":"https://api.github.com/users/JPETTomography/events{/privacy}","received_events_url":"https://api.github.com/users/JPETTomography/received_events","type":"Organization","site_admin":false},"repo":{"id":61399389,"node_id":"MDEwOlJlcG9zaXRvcnk2MTM5OTM4OQ==","name":"j-pet-framework-examples","full_name":"JPETTomography/j-pet-framework-examples","private":false,"owner":{"login":"JPETTomography","id":19532701,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzAx","avatar_url":"https://avatars0.githubusercontent.com/u/19532701?v=4","gravatar_id":"","url":"https://api.github.com/users/JPETTomography","html_url":"https://github.com/JPETTomography","followers_url":"https://api.github.com/users/JPETTomography/followers","following_url":"https://api.github.com/users/JPETTomography/following{/other_user}","gists_url":"https://api.github.com/users/JPETTomography/gists{/gist_id}","starred_url":"https://api.github.com/users/JPETTomography/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JPETTomography/subscriptions","organizations_url":"https://api.github.com/users/JPETTomography/orgs","repos_url":"https://api.github.com/users/JPETTomography/repos","events_url":"https://api.github.com/users/JPETTomography/events{/privacy}","received_events_url":"https://api.github.com/users/JPETTomography/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/JPETTomography/j-pet-framework-examples","description":"Example analyses based on the J-PET Analysis Framework","fork":false,"url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples","forks_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/forks","keys_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/teams","hooks_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/hooks","issue_events_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/issues/events{/number}","events_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/events","assignees_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/assignees{/user}","branches_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/branches{/branch}","tags_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/tags","blobs_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/git/refs{/sha}","trees_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/statuses/{sha}","languages_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/languages","stargazers_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/stargazers","contributors_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/contributors","subscribers_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/subscribers","subscription_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/subscription","commits_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/commits{/sha}","git_commits_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/git/commits{/sha}","comments_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/comments{/number}","issue_comment_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/issues/comments{/number}","contents_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/contents/{+path}","compare_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/merges","archive_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/downloads","issues_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/issues{/number}","pulls_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/pulls{/number}","milestones_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/milestones{/number}","notifications_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/labels{/name}","releases_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/releases{/id}","deployments_url":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/deployments","created_at":"2016-06-17T20:06:04Z","updated_at":"2017-12-12T16:51:06Z","pushed_at":"2018-12-11T15:57:01Z","git_url":"git://github.com/JPETTomography/j-pet-framework-examples.git","ssh_url":"git@github.com:JPETTomography/j-pet-framework-examples.git","clone_url":"https://github.com/JPETTomography/j-pet-framework-examples.git","svn_url":"https://github.com/JPETTomography/j-pet-framework-examples","homepage":null,"size":1393,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/pulls/107"},"html":{"href":"https://github.com/JPETTomography/j-pet-framework-examples/pull/107"},"issue":{"href":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/issues/107"},"comments":{"href":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/issues/107/comments"},"review_comments":{"href":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/pulls/107/comments"},"review_comment":{"href":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/pulls/107/commits"},"statuses":{"href":"https://api.github.com/repos/JPETTomography/j-pet-framework-examples/statuses/2c43813ad07784216c4e9aa19d4ea05a27180a90"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"wkrzemien"}}