{"action":"opened","number":260,"pull_request":{"url":"https://api.github.com/repos/rubyide/vscode-ruby/pulls/260","id":167033713,"html_url":"https://github.com/rubyide/vscode-ruby/pull/260","diff_url":"https://github.com/rubyide/vscode-ruby/pull/260.diff","patch_url":"https://github.com/rubyide/vscode-ruby/pull/260.patch","issue_url":"https://api.github.com/repos/rubyide/vscode-ruby/issues/260","number":260,"state":"open","locked":false,"title":"Fixes to ERB comments","user":{"login":"wingrunr21","id":46283,"avatar_url":"https://avatars1.githubusercontent.com/u/46283?v=4","gravatar_id":"","url":"https://api.github.com/users/wingrunr21","html_url":"https://github.com/wingrunr21","followers_url":"https://api.github.com/users/wingrunr21/followers","following_url":"https://api.github.com/users/wingrunr21/following{/other_user}","gists_url":"https://api.github.com/users/wingrunr21/gists{/gist_id}","starred_url":"https://api.github.com/users/wingrunr21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wingrunr21/subscriptions","organizations_url":"https://api.github.com/users/wingrunr21/orgs","repos_url":"https://api.github.com/users/wingrunr21/repos","events_url":"https://api.github.com/users/wingrunr21/events{/privacy}","received_events_url":"https://api.github.com/users/wingrunr21/received_events","type":"User","site_admin":false},"body":"This PR reverts the changes done in #224 so that commenting in ERB files again works correctly (resolving #255). In addition, it specifies the `embeddedLanguages` key on the ERB language grammar definition that allows VSCode to assign a different language scope for embedded languages. This PR specifies that Ruby, CSS, and JS can be embedded in ERB.\r\n\r\n- [x] Build pass!\r\n- [x] Follow VS Code [Coding Guidelines](https://github.com/Microsoft/vscode/wiki/Coding-Guidelines)","created_at":"2018-02-04T22:24:34Z","updated_at":"2018-02-04T22:24:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/rubyide/vscode-ruby/pulls/260/commits","review_comments_url":"https://api.github.com/repos/rubyide/vscode-ruby/pulls/260/comments","review_comment_url":"https://api.github.com/repos/rubyide/vscode-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubyide/vscode-ruby/issues/260/comments","statuses_url":"https://api.github.com/repos/rubyide/vscode-ruby/statuses/1af8efb72591b575cf7468aa309ae9691632071d","head":{"label":"rubyide:erb_comment_fixes","ref":"erb_comment_fixes","sha":"1af8efb72591b575cf7468aa309ae9691632071d","user":{"login":"rubyide","id":19463480,"avatar_url":"https://avatars3.githubusercontent.com/u/19463480?v=4","gravatar_id":"","url":"https://api.github.com/users/rubyide","html_url":"https://github.com/rubyide","followers_url":"https://api.github.com/users/rubyide/followers","following_url":"https://api.github.com/users/rubyide/following{/other_user}","gists_url":"https://api.github.com/users/rubyide/gists{/gist_id}","starred_url":"https://api.github.com/users/rubyide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubyide/subscriptions","organizations_url":"https://api.github.com/users/rubyide/orgs","repos_url":"https://api.github.com/users/rubyide/repos","events_url":"https://api.github.com/users/rubyide/events{/privacy}","received_events_url":"https://api.github.com/users/rubyide/received_events","type":"Organization","site_admin":false},"repo":{"id":52413659,"name":"vscode-ruby","full_name":"rubyide/vscode-ruby","owner":{"login":"rubyide","id":19463480,"avatar_url":"https://avatars3.githubusercontent.com/u/19463480?v=4","gravatar_id":"","url":"https://api.github.com/users/rubyide","html_url":"https://github.com/rubyide","followers_url":"https://api.github.com/users/rubyide/followers","following_url":"https://api.github.com/users/rubyide/following{/other_user}","gists_url":"https://api.github.com/users/rubyide/gists{/gist_id}","starred_url":"https://api.github.com/users/rubyide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubyide/subscriptions","organizations_url":"https://api.github.com/users/rubyide/orgs","repos_url":"https://api.github.com/users/rubyide/repos","events_url":"https://api.github.com/users/rubyide/events{/privacy}","received_events_url":"https://api.github.com/users/rubyide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rubyide/vscode-ruby","description":"Provides Ruby language and debugging support for Visual Studio Code","fork":false,"url":"https://api.github.com/repos/rubyide/vscode-ruby","forks_url":"https://api.github.com/repos/rubyide/vscode-ruby/forks","keys_url":"https://api.github.com/repos/rubyide/vscode-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubyide/vscode-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubyide/vscode-ruby/teams","hooks_url":"https://api.github.com/repos/rubyide/vscode-ruby/hooks","issue_events_url":"https://api.github.com/repos/rubyide/vscode-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/rubyide/vscode-ruby/events","assignees_url":"https://api.github.com/repos/rubyide/vscode-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/rubyide/vscode-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/rubyide/vscode-ruby/tags","blobs_url":"https://api.github.com/repos/rubyide/vscode-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubyide/vscode-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubyide/vscode-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubyide/vscode-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubyide/vscode-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/rubyide/vscode-ruby/languages","stargazers_url":"https://api.github.com/repos/rubyide/vscode-ruby/stargazers","contributors_url":"https://api.github.com/repos/rubyide/vscode-ruby/contributors","subscribers_url":"https://api.github.com/repos/rubyide/vscode-ruby/subscribers","subscription_url":"https://api.github.com/repos/rubyide/vscode-ruby/subscription","commits_url":"https://api.github.com/repos/rubyide/vscode-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubyide/vscode-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubyide/vscode-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubyide/vscode-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubyide/vscode-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/rubyide/vscode-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubyide/vscode-ruby/merges","archive_url":"https://api.github.com/repos/rubyide/vscode-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubyide/vscode-ruby/downloads","issues_url":"https://api.github.com/repos/rubyide/vscode-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/rubyide/vscode-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/rubyide/vscode-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/rubyide/vscode-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubyide/vscode-ruby/labels{/name}","releases_url":"https://api.github.com/repos/rubyide/vscode-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/rubyide/vscode-ruby/deployments","created_at":"2016-02-24T04:14:24Z","updated_at":"2018-02-03T12:16:02Z","pushed_at":"2018-02-04T22:22:20Z","git_url":"git://github.com/rubyide/vscode-ruby.git","ssh_url":"git@github.com:rubyide/vscode-ruby.git","clone_url":"https://github.com/rubyide/vscode-ruby.git","svn_url":"https://github.com/rubyide/vscode-ruby","homepage":"https://marketplace.visualstudio.com/items?itemName=rebornix.Ruby","size":1000,"stargazers_count":452,"watchers_count":452,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":89,"mirror_url":null,"archived":false,"open_issues_count":107,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":89,"open_issues":107,"watchers":452,"default_branch":"master"}},"base":{"label":"rubyide:master","ref":"master","sha":"ef9244efafd7f59e2052c6b7120e945b3e21e53c","user":{"login":"rubyide","id":19463480,"avatar_url":"https://avatars3.githubusercontent.com/u/19463480?v=4","gravatar_id":"","url":"https://api.github.com/users/rubyide","html_url":"https://github.com/rubyide","followers_url":"https://api.github.com/users/rubyide/followers","following_url":"https://api.github.com/users/rubyide/following{/other_user}","gists_url":"https://api.github.com/users/rubyide/gists{/gist_id}","starred_url":"https://api.github.com/users/rubyide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubyide/subscriptions","organizations_url":"https://api.github.com/users/rubyide/orgs","repos_url":"https://api.github.com/users/rubyide/repos","events_url":"https://api.github.com/users/rubyide/events{/privacy}","received_events_url":"https://api.github.com/users/rubyide/received_events","type":"Organization","site_admin":false},"repo":{"id":52413659,"name":"vscode-ruby","full_name":"rubyide/vscode-ruby","owner":{"login":"rubyide","id":19463480,"avatar_url":"https://avatars3.githubusercontent.com/u/19463480?v=4","gravatar_id":"","url":"https://api.github.com/users/rubyide","html_url":"https://github.com/rubyide","followers_url":"https://api.github.com/users/rubyide/followers","following_url":"https://api.github.com/users/rubyide/following{/other_user}","gists_url":"https://api.github.com/users/rubyide/gists{/gist_id}","starred_url":"https://api.github.com/users/rubyide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubyide/subscriptions","organizations_url":"https://api.github.com/users/rubyide/orgs","repos_url":"https://api.github.com/users/rubyide/repos","events_url":"https://api.github.com/users/rubyide/events{/privacy}","received_events_url":"https://api.github.com/users/rubyide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rubyide/vscode-ruby","description":"Provides Ruby language and debugging support for Visual Studio Code","fork":false,"url":"https://api.github.com/repos/rubyide/vscode-ruby","forks_url":"https://api.github.com/repos/rubyide/vscode-ruby/forks","keys_url":"https://api.github.com/repos/rubyide/vscode-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubyide/vscode-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubyide/vscode-ruby/teams","hooks_url":"https://api.github.com/repos/rubyide/vscode-ruby/hooks","issue_events_url":"https://api.github.com/repos/rubyide/vscode-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/rubyide/vscode-ruby/events","assignees_url":"https://api.github.com/repos/rubyide/vscode-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/rubyide/vscode-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/rubyide/vscode-ruby/tags","blobs_url":"https://api.github.com/repos/rubyide/vscode-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubyide/vscode-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubyide/vscode-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubyide/vscode-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubyide/vscode-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/rubyide/vscode-ruby/languages","stargazers_url":"https://api.github.com/repos/rubyide/vscode-ruby/stargazers","contributors_url":"https://api.github.com/repos/rubyide/vscode-ruby/contributors","subscribers_url":"https://api.github.com/repos/rubyide/vscode-ruby/subscribers","subscription_url":"https://api.github.com/repos/rubyide/vscode-ruby/subscription","commits_url":"https://api.github.com/repos/rubyide/vscode-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubyide/vscode-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubyide/vscode-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubyide/vscode-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubyide/vscode-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/rubyide/vscode-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubyide/vscode-ruby/merges","archive_url":"https://api.github.com/repos/rubyide/vscode-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubyide/vscode-ruby/downloads","issues_url":"https://api.github.com/repos/rubyide/vscode-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/rubyide/vscode-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/rubyide/vscode-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/rubyide/vscode-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubyide/vscode-ruby/labels{/name}","releases_url":"https://api.github.com/repos/rubyide/vscode-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/rubyide/vscode-ruby/deployments","created_at":"2016-02-24T04:14:24Z","updated_at":"2018-02-03T12:16:02Z","pushed_at":"2018-02-04T22:22:20Z","git_url":"git://github.com/rubyide/vscode-ruby.git","ssh_url":"git@github.com:rubyide/vscode-ruby.git","clone_url":"https://github.com/rubyide/vscode-ruby.git","svn_url":"https://github.com/rubyide/vscode-ruby","homepage":"https://marketplace.visualstudio.com/items?itemName=rebornix.Ruby","size":1000,"stargazers_count":452,"watchers_count":452,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":89,"mirror_url":null,"archived":false,"open_issues_count":107,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":89,"open_issues":107,"watchers":452,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rubyide/vscode-ruby/pulls/260"},"html":{"href":"https://github.com/rubyide/vscode-ruby/pull/260"},"issue":{"href":"https://api.github.com/repos/rubyide/vscode-ruby/issues/260"},"comments":{"href":"https://api.github.com/repos/rubyide/vscode-ruby/issues/260/comments"},"review_comments":{"href":"https://api.github.com/repos/rubyide/vscode-ruby/pulls/260/comments"},"review_comment":{"href":"https://api.github.com/repos/rubyide/vscode-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubyide/vscode-ruby/pulls/260/commits"},"statuses":{"href":"https://api.github.com/repos/rubyide/vscode-ruby/statuses/1af8efb72591b575cf7468aa309ae9691632071d"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":7,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"wingrunr21"}}