{"action":"created","comment":{"url":"https://api.github.com/repos/nengo/nengo-loihi/pulls/comments/227410737","pull_request_review_id":167443110,"id":227410737,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzQxMDczNw==","diff_hunk":"@@ -417,6 +417,7 @@ def run_steps(self, steps):\n                     self.sims[\"emulator\"].step()\n                     self.handle_chip2host_communications()\n             else:\n+                raise Exception","path":"nengo_loihi/simulator.py","position":null,"original_position":4,"commit_id":"8665467b0c3fd6594d46fa620f1da4b824b6b0ba","original_commit_id":"587dcee8a0ebf6714bb8cf450924cc7758fc553d","user":{"login":"hunse","id":1952250,"node_id":"MDQ6VXNlcjE5NTIyNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1952250?v=4","gravatar_id":"","url":"https://api.github.com/users/hunse","html_url":"https://github.com/hunse","followers_url":"https://api.github.com/users/hunse/followers","following_url":"https://api.github.com/users/hunse/following{/other_user}","gists_url":"https://api.github.com/users/hunse/gists{/gist_id}","starred_url":"https://api.github.com/users/hunse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hunse/subscriptions","organizations_url":"https://api.github.com/users/hunse/orgs","repos_url":"https://api.github.com/users/hunse/repos","events_url":"https://api.github.com/users/hunse/events{/privacy}","received_events_url":"https://api.github.com/users/hunse/received_events","type":"User","site_admin":false},"body":"Ahh, because these never get hit. In the future, I would put that in the exception comment. These get removed by a later commit, though, so not worth fixing here.","created_at":"2018-10-23T14:12:28Z","updated_at":"2018-10-23T14:28:38Z","html_url":"https://github.com/nengo/nengo-loihi/pull/121#discussion_r227410737","pull_request_url":"https://api.github.com/repos/nengo/nengo-loihi/pulls/121","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nengo/nengo-loihi/pulls/comments/227410737"},"html":{"href":"https://github.com/nengo/nengo-loihi/pull/121#discussion_r227410737"},"pull_request":{"href":"https://api.github.com/repos/nengo/nengo-loihi/pulls/121"}},"in_reply_to_id":226991458},"pull_request":{"url":"https://api.github.com/repos/nengo/nengo-loihi/pulls/121","id":222272582,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjcyNTgy","html_url":"https://github.com/nengo/nengo-loihi/pull/121","diff_url":"https://github.com/nengo/nengo-loihi/pull/121.diff","patch_url":"https://github.com/nengo/nengo-loihi/pull/121.patch","issue_url":"https://api.github.com/repos/nengo/nengo-loihi/issues/121","number":121,"state":"open","locked":false,"title":"Close sub-simulators on close","user":{"login":"drasmuss","id":1952220,"node_id":"MDQ6VXNlcjE5NTIyMjA=","avatar_url":"https://avatars1.githubusercontent.com/u/1952220?v=4","gravatar_id":"","url":"https://api.github.com/users/drasmuss","html_url":"https://github.com/drasmuss","followers_url":"https://api.github.com/users/drasmuss/followers","following_url":"https://api.github.com/users/drasmuss/following{/other_user}","gists_url":"https://api.github.com/users/drasmuss/gists{/gist_id}","starred_url":"https://api.github.com/users/drasmuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drasmuss/subscriptions","organizations_url":"https://api.github.com/users/drasmuss/orgs","repos_url":"https://api.github.com/users/drasmuss/repos","events_url":"https://api.github.com/users/drasmuss/events{/privacy}","received_events_url":"https://api.github.com/users/drasmuss/received_events","type":"User","site_admin":false},"body":"Also adds a close method to the emulator (for consistency).\r\n\r\nFixes #102\r\n\r\nTODO:\r\n- [x] figure out why stopping the n2driverservice is giving an error when running on Loihi","created_at":"2018-10-11T20:40:30Z","updated_at":"2018-10-23T14:28:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e72abfeb748f70c2b7d5cc98dd392f1f09d88d0e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nengo/nengo-loihi/pulls/121/commits","review_comments_url":"https://api.github.com/repos/nengo/nengo-loihi/pulls/121/comments","review_comment_url":"https://api.github.com/repos/nengo/nengo-loihi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nengo/nengo-loihi/issues/121/comments","statuses_url":"https://api.github.com/repos/nengo/nengo-loihi/statuses/8665467b0c3fd6594d46fa620f1da4b824b6b0ba","head":{"label":"nengo:close-sims","ref":"close-sims","sha":"8665467b0c3fd6594d46fa620f1da4b824b6b0ba","user":{"login":"nengo","id":9197486,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxOTc0ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/9197486?v=4","gravatar_id":"","url":"https://api.github.com/users/nengo","html_url":"https://github.com/nengo","followers_url":"https://api.github.com/users/nengo/followers","following_url":"https://api.github.com/users/nengo/following{/other_user}","gists_url":"https://api.github.com/users/nengo/gists{/gist_id}","starred_url":"https://api.github.com/users/nengo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nengo/subscriptions","organizations_url":"https://api.github.com/users/nengo/orgs","repos_url":"https://api.github.com/users/nengo/repos","events_url":"https://api.github.com/users/nengo/events{/privacy}","received_events_url":"https://api.github.com/users/nengo/received_events","type":"Organization","site_admin":false},"repo":{"id":145028118,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwMjgxMTg=","name":"nengo-loihi","full_name":"nengo/nengo-loihi","private":false,"owner":{"login":"nengo","id":9197486,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxOTc0ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/9197486?v=4","gravatar_id":"","url":"https://api.github.com/users/nengo","html_url":"https://github.com/nengo","followers_url":"https://api.github.com/users/nengo/followers","following_url":"https://api.github.com/users/nengo/following{/other_user}","gists_url":"https://api.github.com/users/nengo/gists{/gist_id}","starred_url":"https://api.github.com/users/nengo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nengo/subscriptions","organizations_url":"https://api.github.com/users/nengo/orgs","repos_url":"https://api.github.com/users/nengo/repos","events_url":"https://api.github.com/users/nengo/events{/privacy}","received_events_url":"https://api.github.com/users/nengo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nengo/nengo-loihi","description":"Run Nengo models on Intel's Loihi chip","fork":false,"url":"https://api.github.com/repos/nengo/nengo-loihi","forks_url":"https://api.github.com/repos/nengo/nengo-loihi/forks","keys_url":"https://api.github.com/repos/nengo/nengo-loihi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nengo/nengo-loihi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nengo/nengo-loihi/teams","hooks_url":"https://api.github.com/repos/nengo/nengo-loihi/hooks","issue_events_url":"https://api.github.com/repos/nengo/nengo-loihi/issues/events{/number}","events_url":"https://api.github.com/repos/nengo/nengo-loihi/events","assignees_url":"https://api.github.com/repos/nengo/nengo-loihi/assignees{/user}","branches_url":"https://api.github.com/repos/nengo/nengo-loihi/branches{/branch}","tags_url":"https://api.github.com/repos/nengo/nengo-loihi/tags","blobs_url":"https://api.github.com/repos/nengo/nengo-loihi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nengo/nengo-loihi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nengo/nengo-loihi/git/refs{/sha}","trees_url":"https://api.github.com/repos/nengo/nengo-loihi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nengo/nengo-loihi/statuses/{sha}","languages_url":"https://api.github.com/repos/nengo/nengo-loihi/languages","stargazers_url":"https://api.github.com/repos/nengo/nengo-loihi/stargazers","contributors_url":"https://api.github.com/repos/nengo/nengo-loihi/contributors","subscribers_url":"https://api.github.com/repos/nengo/nengo-loihi/subscribers","subscription_url":"https://api.github.com/repos/nengo/nengo-loihi/subscription","commits_url":"https://api.github.com/repos/nengo/nengo-loihi/commits{/sha}","git_commits_url":"https://api.github.com/repos/nengo/nengo-loihi/git/commits{/sha}","comments_url":"https://api.github.com/repos/nengo/nengo-loihi/comments{/number}","issue_comment_url":"https://api.github.com/repos/nengo/nengo-loihi/issues/comments{/number}","contents_url":"https://api.github.com/repos/nengo/nengo-loihi/contents/{+path}","compare_url":"https://api.github.com/repos/nengo/nengo-loihi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nengo/nengo-loihi/merges","archive_url":"https://api.github.com/repos/nengo/nengo-loihi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nengo/nengo-loihi/downloads","issues_url":"https://api.github.com/repos/nengo/nengo-loihi/issues{/number}","pulls_url":"https://api.github.com/repos/nengo/nengo-loihi/pulls{/number}","milestones_url":"https://api.github.com/repos/nengo/nengo-loihi/milestones{/number}","notifications_url":"https://api.github.com/repos/nengo/nengo-loihi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nengo/nengo-loihi/labels{/name}","releases_url":"https://api.github.com/repos/nengo/nengo-loihi/releases{/id}","deployments_url":"https://api.github.com/repos/nengo/nengo-loihi/deployments","created_at":"2018-08-16T19:01:54Z","updated_at":"2018-10-13T01:14:25Z","pushed_at":"2018-10-23T13:54:51Z","git_url":"git://github.com/nengo/nengo-loihi.git","ssh_url":"git@github.com:nengo/nengo-loihi.git","clone_url":"https://github.com/nengo/nengo-loihi.git","svn_url":"https://github.com/nengo/nengo-loihi","homepage":"https://www.nengo.ai/nengo-loihi/","size":35145,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":76,"watchers":3,"default_branch":"master"}},"base":{"label":"nengo:master","ref":"master","sha":"da81bf0825e6e1e5f4e007d970344dd1830a31fc","user":{"login":"nengo","id":9197486,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxOTc0ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/9197486?v=4","gravatar_id":"","url":"https://api.github.com/users/nengo","html_url":"https://github.com/nengo","followers_url":"https://api.github.com/users/nengo/followers","following_url":"https://api.github.com/users/nengo/following{/other_user}","gists_url":"https://api.github.com/users/nengo/gists{/gist_id}","starred_url":"https://api.github.com/users/nengo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nengo/subscriptions","organizations_url":"https://api.github.com/users/nengo/orgs","repos_url":"https://api.github.com/users/nengo/repos","events_url":"https://api.github.com/users/nengo/events{/privacy}","received_events_url":"https://api.github.com/users/nengo/received_events","type":"Organization","site_admin":false},"repo":{"id":145028118,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUwMjgxMTg=","name":"nengo-loihi","full_name":"nengo/nengo-loihi","private":false,"owner":{"login":"nengo","id":9197486,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxOTc0ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/9197486?v=4","gravatar_id":"","url":"https://api.github.com/users/nengo","html_url":"https://github.com/nengo","followers_url":"https://api.github.com/users/nengo/followers","following_url":"https://api.github.com/users/nengo/following{/other_user}","gists_url":"https://api.github.com/users/nengo/gists{/gist_id}","starred_url":"https://api.github.com/users/nengo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nengo/subscriptions","organizations_url":"https://api.github.com/users/nengo/orgs","repos_url":"https://api.github.com/users/nengo/repos","events_url":"https://api.github.com/users/nengo/events{/privacy}","received_events_url":"https://api.github.com/users/nengo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nengo/nengo-loihi","description":"Run Nengo models on Intel's Loihi chip","fork":false,"url":"https://api.github.com/repos/nengo/nengo-loihi","forks_url":"https://api.github.com/repos/nengo/nengo-loihi/forks","keys_url":"https://api.github.com/repos/nengo/nengo-loihi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nengo/nengo-loihi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nengo/nengo-loihi/teams","hooks_url":"https://api.github.com/repos/nengo/nengo-loihi/hooks","issue_events_url":"https://api.github.com/repos/nengo/nengo-loihi/issues/events{/number}","events_url":"https://api.github.com/repos/nengo/nengo-loihi/events","assignees_url":"https://api.github.com/repos/nengo/nengo-loihi/assignees{/user}","branches_url":"https://api.github.com/repos/nengo/nengo-loihi/branches{/branch}","tags_url":"https://api.github.com/repos/nengo/nengo-loihi/tags","blobs_url":"https://api.github.com/repos/nengo/nengo-loihi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nengo/nengo-loihi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nengo/nengo-loihi/git/refs{/sha}","trees_url":"https://api.github.com/repos/nengo/nengo-loihi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nengo/nengo-loihi/statuses/{sha}","languages_url":"https://api.github.com/repos/nengo/nengo-loihi/languages","stargazers_url":"https://api.github.com/repos/nengo/nengo-loihi/stargazers","contributors_url":"https://api.github.com/repos/nengo/nengo-loihi/contributors","subscribers_url":"https://api.github.com/repos/nengo/nengo-loihi/subscribers","subscription_url":"https://api.github.com/repos/nengo/nengo-loihi/subscription","commits_url":"https://api.github.com/repos/nengo/nengo-loihi/commits{/sha}","git_commits_url":"https://api.github.com/repos/nengo/nengo-loihi/git/commits{/sha}","comments_url":"https://api.github.com/repos/nengo/nengo-loihi/comments{/number}","issue_comment_url":"https://api.github.com/repos/nengo/nengo-loihi/issues/comments{/number}","contents_url":"https://api.github.com/repos/nengo/nengo-loihi/contents/{+path}","compare_url":"https://api.github.com/repos/nengo/nengo-loihi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nengo/nengo-loihi/merges","archive_url":"https://api.github.com/repos/nengo/nengo-loihi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nengo/nengo-loihi/downloads","issues_url":"https://api.github.com/repos/nengo/nengo-loihi/issues{/number}","pulls_url":"https://api.github.com/repos/nengo/nengo-loihi/pulls{/number}","milestones_url":"https://api.github.com/repos/nengo/nengo-loihi/milestones{/number}","notifications_url":"https://api.github.com/repos/nengo/nengo-loihi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nengo/nengo-loihi/labels{/name}","releases_url":"https://api.github.com/repos/nengo/nengo-loihi/releases{/id}","deployments_url":"https://api.github.com/repos/nengo/nengo-loihi/deployments","created_at":"2018-08-16T19:01:54Z","updated_at":"2018-10-13T01:14:25Z","pushed_at":"2018-10-23T13:54:51Z","git_url":"git://github.com/nengo/nengo-loihi.git","ssh_url":"git@github.com:nengo/nengo-loihi.git","clone_url":"https://github.com/nengo/nengo-loihi.git","svn_url":"https://github.com/nengo/nengo-loihi","homepage":"https://www.nengo.ai/nengo-loihi/","size":35145,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":76,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nengo/nengo-loihi/pulls/121"},"html":{"href":"https://github.com/nengo/nengo-loihi/pull/121"},"issue":{"href":"https://api.github.com/repos/nengo/nengo-loihi/issues/121"},"comments":{"href":"https://api.github.com/repos/nengo/nengo-loihi/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/nengo/nengo-loihi/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/nengo/nengo-loihi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nengo/nengo-loihi/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/nengo/nengo-loihi/statuses/8665467b0c3fd6594d46fa620f1da4b824b6b0ba"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hunse"}}