{"action":"opened","number":13,"pull_request":{"url":"https://api.github.com/repos/hmrc/car-tax-calculator/pulls/13","id":170429353,"html_url":"https://github.com/hmrc/car-tax-calculator/pull/13","diff_url":"https://github.com/hmrc/car-tax-calculator/pull/13.diff","patch_url":"https://github.com/hmrc/car-tax-calculator/pull/13.patch","issue_url":"https://api.github.com/repos/hmrc/car-tax-calculator/issues/13","number":13,"state":"open","locked":false,"title":"CCU-65","user":{"login":"daniel-manning","id":25980707,"avatar_url":"https://avatars1.githubusercontent.com/u/25980707?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-manning","html_url":"https://github.com/daniel-manning","followers_url":"https://api.github.com/users/daniel-manning/followers","following_url":"https://api.github.com/users/daniel-manning/following{/other_user}","gists_url":"https://api.github.com/users/daniel-manning/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-manning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-manning/subscriptions","organizations_url":"https://api.github.com/users/daniel-manning/orgs","repos_url":"https://api.github.com/users/daniel-manning/repos","events_url":"https://api.github.com/users/daniel-manning/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-manning/received_events","type":"User","site_admin":false},"body":"So this is more of a conversation than just double checking the code.\r\n\r\nThe api schema we're getting don't contain guarantees about figures coming back as ints, so hello BigDecimal.\r\nThe only thing I'm nervous about is the toInt type conversion being an implicit rounding in the calculation","created_at":"2018-02-21T10:29:32Z","updated_at":"2018-02-21T10:29:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/car-tax-calculator/pulls/13/commits","review_comments_url":"https://api.github.com/repos/hmrc/car-tax-calculator/pulls/13/comments","review_comment_url":"https://api.github.com/repos/hmrc/car-tax-calculator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/car-tax-calculator/issues/13/comments","statuses_url":"https://api.github.com/repos/hmrc/car-tax-calculator/statuses/3d0c4e80442b4511b9ae55434d2e9626dc43b5ef","head":{"label":"hmrc:CCU-65","ref":"CCU-65","sha":"3d0c4e80442b4511b9ae55434d2e9626dc43b5ef","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":31018344,"name":"car-tax-calculator","full_name":"hmrc/car-tax-calculator","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/car-tax-calculator","description":"Car tax calculation library","fork":false,"url":"https://api.github.com/repos/hmrc/car-tax-calculator","forks_url":"https://api.github.com/repos/hmrc/car-tax-calculator/forks","keys_url":"https://api.github.com/repos/hmrc/car-tax-calculator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/car-tax-calculator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/car-tax-calculator/teams","hooks_url":"https://api.github.com/repos/hmrc/car-tax-calculator/hooks","issue_events_url":"https://api.github.com/repos/hmrc/car-tax-calculator/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/car-tax-calculator/events","assignees_url":"https://api.github.com/repos/hmrc/car-tax-calculator/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/car-tax-calculator/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/car-tax-calculator/tags","blobs_url":"https://api.github.com/repos/hmrc/car-tax-calculator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/car-tax-calculator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/car-tax-calculator/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/car-tax-calculator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/car-tax-calculator/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/car-tax-calculator/languages","stargazers_url":"https://api.github.com/repos/hmrc/car-tax-calculator/stargazers","contributors_url":"https://api.github.com/repos/hmrc/car-tax-calculator/contributors","subscribers_url":"https://api.github.com/repos/hmrc/car-tax-calculator/subscribers","subscription_url":"https://api.github.com/repos/hmrc/car-tax-calculator/subscription","commits_url":"https://api.github.com/repos/hmrc/car-tax-calculator/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/car-tax-calculator/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/car-tax-calculator/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/car-tax-calculator/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/car-tax-calculator/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/car-tax-calculator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/car-tax-calculator/merges","archive_url":"https://api.github.com/repos/hmrc/car-tax-calculator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/car-tax-calculator/downloads","issues_url":"https://api.github.com/repos/hmrc/car-tax-calculator/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/car-tax-calculator/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/car-tax-calculator/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/car-tax-calculator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/car-tax-calculator/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/car-tax-calculator/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/car-tax-calculator/deployments","created_at":"2015-02-19T14:17:58Z","updated_at":"2017-02-02T20:03:37Z","pushed_at":"2018-02-20T18:23:24Z","git_url":"git://github.com/hmrc/car-tax-calculator.git","ssh_url":"git@github.com:hmrc/car-tax-calculator.git","clone_url":"https://github.com/hmrc/car-tax-calculator.git","svn_url":"https://github.com/hmrc/car-tax-calculator","homepage":null,"size":1497,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"be27db1d77ebf2451d4a50919651c19ffcb1665b","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":31018344,"name":"car-tax-calculator","full_name":"hmrc/car-tax-calculator","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/car-tax-calculator","description":"Car tax calculation library","fork":false,"url":"https://api.github.com/repos/hmrc/car-tax-calculator","forks_url":"https://api.github.com/repos/hmrc/car-tax-calculator/forks","keys_url":"https://api.github.com/repos/hmrc/car-tax-calculator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/car-tax-calculator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/car-tax-calculator/teams","hooks_url":"https://api.github.com/repos/hmrc/car-tax-calculator/hooks","issue_events_url":"https://api.github.com/repos/hmrc/car-tax-calculator/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/car-tax-calculator/events","assignees_url":"https://api.github.com/repos/hmrc/car-tax-calculator/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/car-tax-calculator/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/car-tax-calculator/tags","blobs_url":"https://api.github.com/repos/hmrc/car-tax-calculator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/car-tax-calculator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/car-tax-calculator/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/car-tax-calculator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/car-tax-calculator/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/car-tax-calculator/languages","stargazers_url":"https://api.github.com/repos/hmrc/car-tax-calculator/stargazers","contributors_url":"https://api.github.com/repos/hmrc/car-tax-calculator/contributors","subscribers_url":"https://api.github.com/repos/hmrc/car-tax-calculator/subscribers","subscription_url":"https://api.github.com/repos/hmrc/car-tax-calculator/subscription","commits_url":"https://api.github.com/repos/hmrc/car-tax-calculator/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/car-tax-calculator/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/car-tax-calculator/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/car-tax-calculator/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/car-tax-calculator/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/car-tax-calculator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/car-tax-calculator/merges","archive_url":"https://api.github.com/repos/hmrc/car-tax-calculator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/car-tax-calculator/downloads","issues_url":"https://api.github.com/repos/hmrc/car-tax-calculator/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/car-tax-calculator/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/car-tax-calculator/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/car-tax-calculator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/car-tax-calculator/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/car-tax-calculator/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/car-tax-calculator/deployments","created_at":"2015-02-19T14:17:58Z","updated_at":"2017-02-02T20:03:37Z","pushed_at":"2018-02-20T18:23:24Z","git_url":"git://github.com/hmrc/car-tax-calculator.git","ssh_url":"git@github.com:hmrc/car-tax-calculator.git","clone_url":"https://github.com/hmrc/car-tax-calculator.git","svn_url":"https://github.com/hmrc/car-tax-calculator","homepage":null,"size":1497,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/car-tax-calculator/pulls/13"},"html":{"href":"https://github.com/hmrc/car-tax-calculator/pull/13"},"issue":{"href":"https://api.github.com/repos/hmrc/car-tax-calculator/issues/13"},"comments":{"href":"https://api.github.com/repos/hmrc/car-tax-calculator/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/car-tax-calculator/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/car-tax-calculator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/car-tax-calculator/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/car-tax-calculator/statuses/3d0c4e80442b4511b9ae55434d2e9626dc43b5ef"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":82,"deletions":82,"changed_files":36}}
{"actor":{"display_login":"daniel-manning"}}