{"action":"created","issue":{"url":"https://api.github.com/repos/project-rig/rig/issues/270","repository_url":"https://api.github.com/repos/project-rig/rig","labels_url":"https://api.github.com/repos/project-rig/rig/issues/270/labels{/name}","comments_url":"https://api.github.com/repos/project-rig/rig/issues/270/comments","events_url":"https://api.github.com/repos/project-rig/rig/issues/270/events","html_url":"https://github.com/project-rig/rig/pull/270","id":321063380,"number":270,"title":"Fix C SA LocationConstraints","user":{"login":"mossblaser","id":193514,"avatar_url":"https://avatars3.githubusercontent.com/u/193514?v=4","gravatar_id":"","url":"https://api.github.com/users/mossblaser","html_url":"https://github.com/mossblaser","followers_url":"https://api.github.com/users/mossblaser/followers","following_url":"https://api.github.com/users/mossblaser/following{/other_user}","gists_url":"https://api.github.com/users/mossblaser/gists{/gist_id}","starred_url":"https://api.github.com/users/mossblaser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossblaser/subscriptions","organizations_url":"https://api.github.com/users/mossblaser/orgs","repos_url":"https://api.github.com/users/mossblaser/repos","events_url":"https://api.github.com/users/mossblaser/events{/privacy}","received_events_url":"https://api.github.com/users/mossblaser/received_events","type":"User","site_admin":false},"labels":[{"id":167946195,"url":"https://api.github.com/repos/project-rig/rig/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":{"login":"mundya","id":3439837,"avatar_url":"https://avatars3.githubusercontent.com/u/3439837?v=4","gravatar_id":"","url":"https://api.github.com/users/mundya","html_url":"https://github.com/mundya","followers_url":"https://api.github.com/users/mundya/followers","following_url":"https://api.github.com/users/mundya/following{/other_user}","gists_url":"https://api.github.com/users/mundya/gists{/gist_id}","starred_url":"https://api.github.com/users/mundya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mundya/subscriptions","organizations_url":"https://api.github.com/users/mundya/orgs","repos_url":"https://api.github.com/users/mundya/repos","events_url":"https://api.github.com/users/mundya/events{/privacy}","received_events_url":"https://api.github.com/users/mundya/received_events","type":"User","site_admin":false},"assignees":[{"login":"mundya","id":3439837,"avatar_url":"https://avatars3.githubusercontent.com/u/3439837?v=4","gravatar_id":"","url":"https://api.github.com/users/mundya","html_url":"https://github.com/mundya","followers_url":"https://api.github.com/users/mundya/followers","following_url":"https://api.github.com/users/mundya/following{/other_user}","gists_url":"https://api.github.com/users/mundya/gists{/gist_id}","starred_url":"https://api.github.com/users/mundya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mundya/subscriptions","organizations_url":"https://api.github.com/users/mundya/orgs","repos_url":"https://api.github.com/users/mundya/repos","events_url":"https://api.github.com/users/mundya/events{/privacy}","received_events_url":"https://api.github.com/users/mundya/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2018-05-08T06:52:41Z","updated_at":"2018-05-10T20:01:07Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/project-rig/rig/pulls/270","html_url":"https://github.com/project-rig/rig/pull/270","diff_url":"https://github.com/project-rig/rig/pull/270.diff","patch_url":"https://github.com/project-rig/rig/pull/270.patch"},"body":"@mundya Hope you don't mind coming \"out of retirement\" to have a quick look over this PR?\r\n\r\nThis PR fixes a (really extremely embarrassing) bug in the Python interface to the C Kernel for the simulated annealing based placement algorithm. The C interface (as clearly documented in its header) requires that vertices are listed such that moveable vertices are listed first. The Python side of this, however, somehow never actually implemented this sorting step... In this PR, the test suite is fixed to find the bug and the implementation is fixed to add the sort.\r\n\r\nThanks very much to @robert-hardwick in project-rig/rig_c_sa#7 for spotting this bug. I'm really sorry it appeared. Its funny that two years on I could remember that \"of course you must sort the vertices\" but somehow didn't while actually writing the software... How very embarrassing.\r\n\r\n@robert-hardwick Would you be able to check out this branch and check it fixes your issue?\r\n\r\n\r\n* [x] Fix test suite to find SA bug\r\n* [x] Fix SA wrapper\r\n* [x] Fix new flake8 errors\r\n* [x] Fix new `machine_controller` test warnings\r\n* [ ] Fix new ordered covering test warnings (assigned @mundya)\r\n* [ ] Run tests against reference hardware setup (@lplana is kindly setting up a machine for this!)"},"comment":{"url":"https://api.github.com/repos/project-rig/rig/issues/comments/388168265","html_url":"https://github.com/project-rig/rig/pull/270#issuecomment-388168265","issue_url":"https://api.github.com/repos/project-rig/rig/issues/270","id":388168265,"user":{"login":"mossblaser","id":193514,"avatar_url":"https://avatars3.githubusercontent.com/u/193514?v=4","gravatar_id":"","url":"https://api.github.com/users/mossblaser","html_url":"https://github.com/mossblaser","followers_url":"https://api.github.com/users/mossblaser/followers","following_url":"https://api.github.com/users/mossblaser/following{/other_user}","gists_url":"https://api.github.com/users/mossblaser/gists{/gist_id}","starred_url":"https://api.github.com/users/mossblaser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossblaser/subscriptions","organizations_url":"https://api.github.com/users/mossblaser/orgs","repos_url":"https://api.github.com/users/mossblaser/repos","events_url":"https://api.github.com/users/mossblaser/events{/privacy}","received_events_url":"https://api.github.com/users/mossblaser/received_events","type":"User","site_admin":false},"created_at":"2018-05-10T20:01:07Z","updated_at":"2018-05-10T20:01:07Z","author_association":"OWNER","body":"@mundya I've fixed the doctest failure but I'm afraid the remaining warnings from the doctest run relate to the same orthogonality warnings so I'll leave those up to you to amend if you don't mind!"}}
{"actor":{"display_login":"mossblaser"}}