{"action":"created","issue":{"url":"https://api.github.com/repos/pawelsalawa/sqlitestudio/issues/3347","repository_url":"https://api.github.com/repos/pawelsalawa/sqlitestudio","labels_url":"https://api.github.com/repos/pawelsalawa/sqlitestudio/issues/3347/labels{/name}","comments_url":"https://api.github.com/repos/pawelsalawa/sqlitestudio/issues/3347/comments","events_url":"https://api.github.com/repos/pawelsalawa/sqlitestudio/issues/3347/events","html_url":"https://github.com/pawelsalawa/sqlitestudio/issues/3347","id":334931645,"node_id":"MDU6SXNzdWUzMzQ5MzE2NDU=","number":3347,"title":"ConstraintPanel and QCheckBox->text issue","user":{"login":"rindeal","id":5360877,"node_id":"MDQ6VXNlcjUzNjA4Nzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5360877?v=4","gravatar_id":"","url":"https://api.github.com/users/rindeal","html_url":"https://github.com/rindeal","followers_url":"https://api.github.com/users/rindeal/followers","following_url":"https://api.github.com/users/rindeal/following{/other_user}","gists_url":"https://api.github.com/users/rindeal/gists{/gist_id}","starred_url":"https://api.github.com/users/rindeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rindeal/subscriptions","organizations_url":"https://api.github.com/users/rindeal/orgs","repos_url":"https://api.github.com/users/rindeal/repos","events_url":"https://api.github.com/users/rindeal/events{/privacy}","received_events_url":"https://api.github.com/users/rindeal/received_events","type":"User","site_admin":false},"labels":[{"id":801836666,"node_id":"MDU6TGFiZWw4MDE4MzY2NjY=","url":"https://api.github.com/repos/pawelsalawa/sqlitestudio/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/pawelsalawa/sqlitestudio/milestones/1","html_url":"https://github.com/pawelsalawa/sqlitestudio/milestone/1","labels_url":"https://api.github.com/repos/pawelsalawa/sqlitestudio/milestones/1/labels","id":3066232,"node_id":"MDk6TWlsZXN0b25lMzA2NjIzMg==","number":1,"title":"3.2","description":"","creator":{"login":"pawelsalawa","id":481846,"node_id":"MDQ6VXNlcjQ4MTg0Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/481846?v=4","gravatar_id":"","url":"https://api.github.com/users/pawelsalawa","html_url":"https://github.com/pawelsalawa","followers_url":"https://api.github.com/users/pawelsalawa/followers","following_url":"https://api.github.com/users/pawelsalawa/following{/other_user}","gists_url":"https://api.github.com/users/pawelsalawa/gists{/gist_id}","starred_url":"https://api.github.com/users/pawelsalawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawelsalawa/subscriptions","organizations_url":"https://api.github.com/users/pawelsalawa/orgs","repos_url":"https://api.github.com/users/pawelsalawa/repos","events_url":"https://api.github.com/users/pawelsalawa/events{/privacy}","received_events_url":"https://api.github.com/users/pawelsalawa/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":56,"state":"open","created_at":"2018-01-26T12:59:42Z","updated_at":"2018-06-24T20:20:05Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2018-06-22T15:56:40Z","updated_at":"2018-06-25T10:41:32Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"`ConstraintPanel` and its derivatives like `TablePrimaryKeyPanel` use the `text` property of `QCheckBox` objects for reading of \"valid data\". This causes numerous issues throughout the program if `text` contains ampersands to generate `QShortcut`s, which on my machine is the case for at least all column names.\r\n\r\nTake for example this code: https://github.com/pawelsalawa/sqlitestudio/blob/2266e39d6ed95ef7d44690532a47e47d76e899c4/SQLiteStudio3/guiSQLiteStudio/constraints/tableprimarykeypanel.cpp#L40-L83\r\n\r\nSince `cb->text()` may contain ampersand somewhere in the column name, `createTable->getColumn(colName)` will fail and return `NULL`, thus https://github.com/pawelsalawa/sqlitestudio/blob/2266e39d6ed95ef7d44690532a47e47d76e899c4/SQLiteStudio3/guiSQLiteStudio/constraints/tableprimarykeypanel.cpp#L66-L73 will always get triggered and execution will never reach https://github.com/pawelsalawa/sqlitestudio/blob/2266e39d6ed95ef7d44690532a47e47d76e899c4/SQLiteStudio3/guiSQLiteStudio/constraints/tableprimarykeypanel.cpp#L82 ."},"comment":{"url":"https://api.github.com/repos/pawelsalawa/sqlitestudio/issues/comments/399908965","html_url":"https://github.com/pawelsalawa/sqlitestudio/issues/3347#issuecomment-399908965","issue_url":"https://api.github.com/repos/pawelsalawa/sqlitestudio/issues/3347","id":399908965,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTkwODk2NQ==","user":{"login":"pawelsalawa","id":481846,"node_id":"MDQ6VXNlcjQ4MTg0Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/481846?v=4","gravatar_id":"","url":"https://api.github.com/users/pawelsalawa","html_url":"https://github.com/pawelsalawa","followers_url":"https://api.github.com/users/pawelsalawa/followers","following_url":"https://api.github.com/users/pawelsalawa/following{/other_user}","gists_url":"https://api.github.com/users/pawelsalawa/gists{/gist_id}","starred_url":"https://api.github.com/users/pawelsalawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawelsalawa/subscriptions","organizations_url":"https://api.github.com/users/pawelsalawa/orgs","repos_url":"https://api.github.com/users/pawelsalawa/repos","events_url":"https://api.github.com/users/pawelsalawa/events{/privacy}","received_events_url":"https://api.github.com/users/pawelsalawa/received_events","type":"User","site_admin":false},"created_at":"2018-06-25T10:41:32Z","updated_at":"2018-06-25T10:41:32Z","author_association":"OWNER","body":"I got it reproduced!\r\n\r\nIn this issue in comments I will keep track on where this problem is observed.\r\n\r\n@rindeal if you notice this problem in a place which I did not list here, please comment too, if you could. I would appreciate it very much!\r\n\r\nMy findings so far:\r\n\r\n- All contraint panels that list columns\r\n- Index dialog\r\n- Populate table dialog"}}
{"actor":{"display_login":"pawelsalawa"}}