{"action":"closed","number":45,"pull_request":{"url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/pulls/45","id":223008444,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMDA4NDQ0","html_url":"https://github.com/Block-Equity/stellar-android-wallet/pull/45","diff_url":"https://github.com/Block-Equity/stellar-android-wallet/pull/45.diff","patch_url":"https://github.com/Block-Equity/stellar-android-wallet/pull/45.patch","issue_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/issues/45","number":45,"state":"closed","locked":false,"title":"Import secret seed","user":{"login":"Daniel-Wang","id":2541326,"node_id":"MDQ6VXNlcjI1NDEzMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/2541326?v=4","gravatar_id":"","url":"https://api.github.com/users/Daniel-Wang","html_url":"https://github.com/Daniel-Wang","followers_url":"https://api.github.com/users/Daniel-Wang/followers","following_url":"https://api.github.com/users/Daniel-Wang/following{/other_user}","gists_url":"https://api.github.com/users/Daniel-Wang/gists{/gist_id}","starred_url":"https://api.github.com/users/Daniel-Wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daniel-Wang/subscriptions","organizations_url":"https://api.github.com/users/Daniel-Wang/orgs","repos_url":"https://api.github.com/users/Daniel-Wang/repos","events_url":"https://api.github.com/users/Daniel-Wang/events{/privacy}","received_events_url":"https://api.github.com/users/Daniel-Wang/received_events","type":"User","site_admin":false},"body":"## Priority\r\nUrgent 👍 \r\n\r\n## Description\r\n* Enables user to import a wallet with their secret seed\r\n* Refactored PIN Activity to enable generating keypair via phrase or seed based on which is used\r\n* Added a local store property for `isRecoveryPhrase` to indicate whether a phrase or seed is used\r\n* Refactored `get` method names in local store to indicate getString or getBoolean (can't overload it :( )\r\n\r\n## Screenshot\r\n\r\n(Highlights UI changes)\r\n\r\nWhen showing phrase from a secret seed generated account\r\n\r\n![screenshot_20181015-145323](https://user-images.githubusercontent.com/2541326/46971647-90e82f80-d08a-11e8-8ba0-1dacc844827a.png)\r\n\r\nAdded new dialog\r\n\r\n![screenshot_20181015-145342](https://user-images.githubusercontent.com/2541326/46971645-8f1e6c00-d08a-11e8-8037-671cdd24ab14.png)\r\n","created_at":"2018-10-15T18:57:49Z","updated_at":"2018-10-15T20:34:39Z","closed_at":"2018-10-15T20:34:39Z","merged_at":"2018-10-15T20:34:39Z","merge_commit_sha":"0ec7ea15b4f4057fee26311cdd3bb115c8c14639","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/pulls/45/commits","review_comments_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/pulls/45/comments","review_comment_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/issues/45/comments","statuses_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/statuses/209bf91900a58a789d50c2a665888278acc8a45d","head":{"label":"Block-Equity:importSecretSeed","ref":"importSecretSeed","sha":"209bf91900a58a789d50c2a665888278acc8a45d","user":{"login":"Block-Equity","id":36420670,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NDIwNjcw","avatar_url":"https://avatars1.githubusercontent.com/u/36420670?v=4","gravatar_id":"","url":"https://api.github.com/users/Block-Equity","html_url":"https://github.com/Block-Equity","followers_url":"https://api.github.com/users/Block-Equity/followers","following_url":"https://api.github.com/users/Block-Equity/following{/other_user}","gists_url":"https://api.github.com/users/Block-Equity/gists{/gist_id}","starred_url":"https://api.github.com/users/Block-Equity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Block-Equity/subscriptions","organizations_url":"https://api.github.com/users/Block-Equity/orgs","repos_url":"https://api.github.com/users/Block-Equity/repos","events_url":"https://api.github.com/users/Block-Equity/events{/privacy}","received_events_url":"https://api.github.com/users/Block-Equity/received_events","type":"Organization","site_admin":false},"repo":{"id":128590362,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg1OTAzNjI=","name":"stellar-android-wallet","full_name":"Block-Equity/stellar-android-wallet","private":false,"owner":{"login":"Block-Equity","id":36420670,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NDIwNjcw","avatar_url":"https://avatars1.githubusercontent.com/u/36420670?v=4","gravatar_id":"","url":"https://api.github.com/users/Block-Equity","html_url":"https://github.com/Block-Equity","followers_url":"https://api.github.com/users/Block-Equity/followers","following_url":"https://api.github.com/users/Block-Equity/following{/other_user}","gists_url":"https://api.github.com/users/Block-Equity/gists{/gist_id}","starred_url":"https://api.github.com/users/Block-Equity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Block-Equity/subscriptions","organizations_url":"https://api.github.com/users/Block-Equity/orgs","repos_url":"https://api.github.com/users/Block-Equity/repos","events_url":"https://api.github.com/users/Block-Equity/events{/privacy}","received_events_url":"https://api.github.com/users/Block-Equity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Block-Equity/stellar-android-wallet","description":"An open source Android wallet for Stellar.","fork":false,"url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet","forks_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/forks","keys_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/teams","hooks_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/hooks","issue_events_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/issues/events{/number}","events_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/events","assignees_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/assignees{/user}","branches_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/branches{/branch}","tags_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/tags","blobs_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/statuses/{sha}","languages_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/languages","stargazers_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/stargazers","contributors_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/contributors","subscribers_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/subscribers","subscription_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/subscription","commits_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/contents/{+path}","compare_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/merges","archive_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/downloads","issues_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/issues{/number}","pulls_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/pulls{/number}","milestones_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/milestones{/number}","notifications_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/labels{/name}","releases_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/releases{/id}","deployments_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/deployments","created_at":"2018-04-08T02:49:58Z","updated_at":"2018-10-12T19:52:31Z","pushed_at":"2018-10-15T20:34:39Z","git_url":"git://github.com/Block-Equity/stellar-android-wallet.git","ssh_url":"git@github.com:Block-Equity/stellar-android-wallet.git","clone_url":"https://github.com/Block-Equity/stellar-android-wallet.git","svn_url":"https://github.com/Block-Equity/stellar-android-wallet","homepage":"https://www.blockeq.com","size":15325,"stargazers_count":9,"watchers_count":9,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":1,"watchers":9,"default_branch":"dev"}},"base":{"label":"Block-Equity:dev","ref":"dev","sha":"37a219a4bf2856347b800360454ac4f132bb162c","user":{"login":"Block-Equity","id":36420670,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NDIwNjcw","avatar_url":"https://avatars1.githubusercontent.com/u/36420670?v=4","gravatar_id":"","url":"https://api.github.com/users/Block-Equity","html_url":"https://github.com/Block-Equity","followers_url":"https://api.github.com/users/Block-Equity/followers","following_url":"https://api.github.com/users/Block-Equity/following{/other_user}","gists_url":"https://api.github.com/users/Block-Equity/gists{/gist_id}","starred_url":"https://api.github.com/users/Block-Equity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Block-Equity/subscriptions","organizations_url":"https://api.github.com/users/Block-Equity/orgs","repos_url":"https://api.github.com/users/Block-Equity/repos","events_url":"https://api.github.com/users/Block-Equity/events{/privacy}","received_events_url":"https://api.github.com/users/Block-Equity/received_events","type":"Organization","site_admin":false},"repo":{"id":128590362,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg1OTAzNjI=","name":"stellar-android-wallet","full_name":"Block-Equity/stellar-android-wallet","private":false,"owner":{"login":"Block-Equity","id":36420670,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NDIwNjcw","avatar_url":"https://avatars1.githubusercontent.com/u/36420670?v=4","gravatar_id":"","url":"https://api.github.com/users/Block-Equity","html_url":"https://github.com/Block-Equity","followers_url":"https://api.github.com/users/Block-Equity/followers","following_url":"https://api.github.com/users/Block-Equity/following{/other_user}","gists_url":"https://api.github.com/users/Block-Equity/gists{/gist_id}","starred_url":"https://api.github.com/users/Block-Equity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Block-Equity/subscriptions","organizations_url":"https://api.github.com/users/Block-Equity/orgs","repos_url":"https://api.github.com/users/Block-Equity/repos","events_url":"https://api.github.com/users/Block-Equity/events{/privacy}","received_events_url":"https://api.github.com/users/Block-Equity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Block-Equity/stellar-android-wallet","description":"An open source Android wallet for Stellar.","fork":false,"url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet","forks_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/forks","keys_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/teams","hooks_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/hooks","issue_events_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/issues/events{/number}","events_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/events","assignees_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/assignees{/user}","branches_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/branches{/branch}","tags_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/tags","blobs_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/statuses/{sha}","languages_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/languages","stargazers_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/stargazers","contributors_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/contributors","subscribers_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/subscribers","subscription_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/subscription","commits_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/contents/{+path}","compare_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/merges","archive_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/downloads","issues_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/issues{/number}","pulls_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/pulls{/number}","milestones_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/milestones{/number}","notifications_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/labels{/name}","releases_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/releases{/id}","deployments_url":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/deployments","created_at":"2018-04-08T02:49:58Z","updated_at":"2018-10-12T19:52:31Z","pushed_at":"2018-10-15T20:34:39Z","git_url":"git://github.com/Block-Equity/stellar-android-wallet.git","ssh_url":"git@github.com:Block-Equity/stellar-android-wallet.git","clone_url":"https://github.com/Block-Equity/stellar-android-wallet.git","svn_url":"https://github.com/Block-Equity/stellar-android-wallet","homepage":"https://www.blockeq.com","size":15325,"stargazers_count":9,"watchers_count":9,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":1,"watchers":9,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/pulls/45"},"html":{"href":"https://github.com/Block-Equity/stellar-android-wallet/pull/45"},"issue":{"href":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/issues/45"},"comments":{"href":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/Block-Equity/stellar-android-wallet/statuses/209bf91900a58a789d50c2a665888278acc8a45d"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Daniel-Wang","id":2541326,"node_id":"MDQ6VXNlcjI1NDEzMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/2541326?v=4","gravatar_id":"","url":"https://api.github.com/users/Daniel-Wang","html_url":"https://github.com/Daniel-Wang","followers_url":"https://api.github.com/users/Daniel-Wang/followers","following_url":"https://api.github.com/users/Daniel-Wang/following{/other_user}","gists_url":"https://api.github.com/users/Daniel-Wang/gists{/gist_id}","starred_url":"https://api.github.com/users/Daniel-Wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daniel-Wang/subscriptions","organizations_url":"https://api.github.com/users/Daniel-Wang/orgs","repos_url":"https://api.github.com/users/Daniel-Wang/repos","events_url":"https://api.github.com/users/Daniel-Wang/events{/privacy}","received_events_url":"https://api.github.com/users/Daniel-Wang/received_events","type":"User","site_admin":false},"comments":0,"review_comments":4,"maintainer_can_modify":false,"commits":9,"additions":131,"deletions":31,"changed_files":7}}
{"actor":{"display_login":"Daniel-Wang"}}