{"action":"created","comment":{"url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/pulls/comments/219454607","pull_request_review_id":157634986,"id":219454607,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTQ1NDYwNw==","diff_hunk":"@@ -27,8 +28,16 @@ export class TitleBar extends Container<TitleBarConfig> {\n       cssClass: 'ui-titlebar',\n       hidden: true,\n       components: [\n-        new MetadataLabel({ content: MetadataLabelContent.Title }),\n-        new MetadataLabel({ content: MetadataLabelContent.Description }),\n+        new Container({","path":"src/ts/components/titlebar.ts","position":18,"original_position":18,"commit_id":"f8414b66a7ec40adb4f053d8401f7bffbaac7830","original_commit_id":"659069c9724893f025a3c2e3f4681b1208c735c0","user":{"login":"stonko1994","id":6216959,"node_id":"MDQ6VXNlcjYyMTY5NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6216959?v=4","gravatar_id":"","url":"https://api.github.com/users/stonko1994","html_url":"https://github.com/stonko1994","followers_url":"https://api.github.com/users/stonko1994/followers","following_url":"https://api.github.com/users/stonko1994/following{/other_user}","gists_url":"https://api.github.com/users/stonko1994/gists{/gist_id}","starred_url":"https://api.github.com/users/stonko1994/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stonko1994/subscriptions","organizations_url":"https://api.github.com/users/stonko1994/orgs","repos_url":"https://api.github.com/users/stonko1994/repos","events_url":"https://api.github.com/users/stonko1994/events{/privacy}","received_events_url":"https://api.github.com/users/stonko1994/received_events","type":"User","site_admin":false},"body":"This allowed me to apply css similar to the `controlbar` also for the `titlebar`. \r\nThis `css` expect the first level of `.#{$prefix}-ui-container` to represent a 'row' in the UI. Maybe it's no good approach.","created_at":"2018-09-21T10:36:43Z","updated_at":"2018-09-21T10:36:43Z","html_url":"https://github.com/bitmovin/bitmovin-player-ui/pull/178#discussion_r219454607","pull_request_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/pulls/178","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/pulls/comments/219454607"},"html":{"href":"https://github.com/bitmovin/bitmovin-player-ui/pull/178#discussion_r219454607"},"pull_request":{"href":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/pulls/178"}},"in_reply_to_id":219437278},"pull_request":{"url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/pulls/178","id":217001206,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MDAxMjA2","html_url":"https://github.com/bitmovin/bitmovin-player-ui/pull/178","diff_url":"https://github.com/bitmovin/bitmovin-player-ui/pull/178.diff","patch_url":"https://github.com/bitmovin/bitmovin-player-ui/pull/178.patch","issue_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/issues/178","number":178,"state":"open","locked":false,"title":"Improving hit-boxes","user":{"login":"stonko1994","id":6216959,"node_id":"MDQ6VXNlcjYyMTY5NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6216959?v=4","gravatar_id":"","url":"https://api.github.com/users/stonko1994","html_url":"https://github.com/stonko1994","followers_url":"https://api.github.com/users/stonko1994/followers","following_url":"https://api.github.com/users/stonko1994/following{/other_user}","gists_url":"https://api.github.com/users/stonko1994/gists{/gist_id}","starred_url":"https://api.github.com/users/stonko1994/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stonko1994/subscriptions","organizations_url":"https://api.github.com/users/stonko1994/orgs","repos_url":"https://api.github.com/users/stonko1994/repos","events_url":"https://api.github.com/users/stonko1994/events{/privacy}","received_events_url":"https://api.github.com/users/stonko1994/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nOur buttons where styled with margins that means that there are dead space between them. This lead to sometimes hard hittable buttons especially on an mobile device. This pull request improve this by working with paddings.\r\n\r\n**Please have a look also on the UI and test it (click through everything)**\r\n\r\n## Discussion\r\nI hope this doesn't change to much for a minor release?\r\n\r\n## TODO\r\n* Issue in live-stream UI","created_at":"2018-09-20T14:50:03Z","updated_at":"2018-09-21T10:36:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c0b3d6157cb0ad27c65fd9b2dee7c31ec256626","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/pulls/178/commits","review_comments_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/pulls/178/comments","review_comment_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/issues/178/comments","statuses_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/statuses/f8414b66a7ec40adb4f053d8401f7bffbaac7830","head":{"label":"bitmovin:feature/jucier-hitboxes","ref":"feature/jucier-hitboxes","sha":"f8414b66a7ec40adb4f053d8401f7bffbaac7830","user":{"login":"bitmovin","id":3273006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzMwMDY=","avatar_url":"https://avatars1.githubusercontent.com/u/3273006?v=4","gravatar_id":"","url":"https://api.github.com/users/bitmovin","html_url":"https://github.com/bitmovin","followers_url":"https://api.github.com/users/bitmovin/followers","following_url":"https://api.github.com/users/bitmovin/following{/other_user}","gists_url":"https://api.github.com/users/bitmovin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitmovin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitmovin/subscriptions","organizations_url":"https://api.github.com/users/bitmovin/orgs","repos_url":"https://api.github.com/users/bitmovin/repos","events_url":"https://api.github.com/users/bitmovin/events{/privacy}","received_events_url":"https://api.github.com/users/bitmovin/received_events","type":"Organization","site_admin":false},"repo":{"id":76945773,"node_id":"MDEwOlJlcG9zaXRvcnk3Njk0NTc3Mw==","name":"bitmovin-player-ui","full_name":"bitmovin/bitmovin-player-ui","private":false,"owner":{"login":"bitmovin","id":3273006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzMwMDY=","avatar_url":"https://avatars1.githubusercontent.com/u/3273006?v=4","gravatar_id":"","url":"https://api.github.com/users/bitmovin","html_url":"https://github.com/bitmovin","followers_url":"https://api.github.com/users/bitmovin/followers","following_url":"https://api.github.com/users/bitmovin/following{/other_user}","gists_url":"https://api.github.com/users/bitmovin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitmovin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitmovin/subscriptions","organizations_url":"https://api.github.com/users/bitmovin/orgs","repos_url":"https://api.github.com/users/bitmovin/repos","events_url":"https://api.github.com/users/bitmovin/events{/privacy}","received_events_url":"https://api.github.com/users/bitmovin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bitmovin/bitmovin-player-ui","description":"The Bitmovin Adaptive Streaming Player UI","fork":false,"url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui","forks_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/forks","keys_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/teams","hooks_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/hooks","issue_events_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/issues/events{/number}","events_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/events","assignees_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/assignees{/user}","branches_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/branches{/branch}","tags_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/tags","blobs_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/languages","stargazers_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/stargazers","contributors_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/contributors","subscribers_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/subscribers","subscription_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/subscription","commits_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/contents/{+path}","compare_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/merges","archive_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/downloads","issues_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/issues{/number}","pulls_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/labels{/name}","releases_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/releases{/id}","deployments_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/deployments","created_at":"2016-12-20T10:09:11Z","updated_at":"2018-09-20T12:55:50Z","pushed_at":"2018-09-21T09:59:00Z","git_url":"git://github.com/bitmovin/bitmovin-player-ui.git","ssh_url":"git@github.com:bitmovin/bitmovin-player-ui.git","clone_url":"https://github.com/bitmovin/bitmovin-player-ui.git","svn_url":"https://github.com/bitmovin/bitmovin-player-ui","homepage":null,"size":13316,"stargazers_count":49,"watchers_count":49,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":23,"open_issues":11,"watchers":49,"default_branch":"master"}},"base":{"label":"bitmovin:develop","ref":"develop","sha":"0b366198612035803523b6f0ae6f5dae1aaea0c4","user":{"login":"bitmovin","id":3273006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzMwMDY=","avatar_url":"https://avatars1.githubusercontent.com/u/3273006?v=4","gravatar_id":"","url":"https://api.github.com/users/bitmovin","html_url":"https://github.com/bitmovin","followers_url":"https://api.github.com/users/bitmovin/followers","following_url":"https://api.github.com/users/bitmovin/following{/other_user}","gists_url":"https://api.github.com/users/bitmovin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitmovin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitmovin/subscriptions","organizations_url":"https://api.github.com/users/bitmovin/orgs","repos_url":"https://api.github.com/users/bitmovin/repos","events_url":"https://api.github.com/users/bitmovin/events{/privacy}","received_events_url":"https://api.github.com/users/bitmovin/received_events","type":"Organization","site_admin":false},"repo":{"id":76945773,"node_id":"MDEwOlJlcG9zaXRvcnk3Njk0NTc3Mw==","name":"bitmovin-player-ui","full_name":"bitmovin/bitmovin-player-ui","private":false,"owner":{"login":"bitmovin","id":3273006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzMwMDY=","avatar_url":"https://avatars1.githubusercontent.com/u/3273006?v=4","gravatar_id":"","url":"https://api.github.com/users/bitmovin","html_url":"https://github.com/bitmovin","followers_url":"https://api.github.com/users/bitmovin/followers","following_url":"https://api.github.com/users/bitmovin/following{/other_user}","gists_url":"https://api.github.com/users/bitmovin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitmovin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitmovin/subscriptions","organizations_url":"https://api.github.com/users/bitmovin/orgs","repos_url":"https://api.github.com/users/bitmovin/repos","events_url":"https://api.github.com/users/bitmovin/events{/privacy}","received_events_url":"https://api.github.com/users/bitmovin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bitmovin/bitmovin-player-ui","description":"The Bitmovin Adaptive Streaming Player UI","fork":false,"url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui","forks_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/forks","keys_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/teams","hooks_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/hooks","issue_events_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/issues/events{/number}","events_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/events","assignees_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/assignees{/user}","branches_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/branches{/branch}","tags_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/tags","blobs_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/languages","stargazers_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/stargazers","contributors_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/contributors","subscribers_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/subscribers","subscription_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/subscription","commits_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/contents/{+path}","compare_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/merges","archive_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/downloads","issues_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/issues{/number}","pulls_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/labels{/name}","releases_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/releases{/id}","deployments_url":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/deployments","created_at":"2016-12-20T10:09:11Z","updated_at":"2018-09-20T12:55:50Z","pushed_at":"2018-09-21T09:59:00Z","git_url":"git://github.com/bitmovin/bitmovin-player-ui.git","ssh_url":"git@github.com:bitmovin/bitmovin-player-ui.git","clone_url":"https://github.com/bitmovin/bitmovin-player-ui.git","svn_url":"https://github.com/bitmovin/bitmovin-player-ui","homepage":null,"size":13316,"stargazers_count":49,"watchers_count":49,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":23,"open_issues":11,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/pulls/178"},"html":{"href":"https://github.com/bitmovin/bitmovin-player-ui/pull/178"},"issue":{"href":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/issues/178"},"comments":{"href":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/issues/178/comments"},"review_comments":{"href":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/pulls/178/comments"},"review_comment":{"href":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/pulls/178/commits"},"statuses":{"href":"https://api.github.com/repos/bitmovin/bitmovin-player-ui/statuses/f8414b66a7ec40adb4f053d8401f7bffbaac7830"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"stonko1994"}}