{"action":"created","issue":{"url":"https://api.github.com/repos/checkstyle/checkstyle/issues/6262","repository_url":"https://api.github.com/repos/checkstyle/checkstyle","labels_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/6262/labels{/name}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/6262/comments","events_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/6262/events","html_url":"https://github.com/checkstyle/checkstyle/issues/6262","id":389022823,"node_id":"MDU6SXNzdWUzODkwMjI4MjM=","number":6262,"title":"XmlLoader: remove incomplete namespaces support","user":{"login":"rnveach","id":5427943,"node_id":"MDQ6VXNlcjU0Mjc5NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/5427943?v=4","gravatar_id":"","url":"https://api.github.com/users/rnveach","html_url":"https://github.com/rnveach","followers_url":"https://api.github.com/users/rnveach/followers","following_url":"https://api.github.com/users/rnveach/following{/other_user}","gists_url":"https://api.github.com/users/rnveach/gists{/gist_id}","starred_url":"https://api.github.com/users/rnveach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnveach/subscriptions","organizations_url":"https://api.github.com/users/rnveach/orgs","repos_url":"https://api.github.com/users/rnveach/repos","events_url":"https://api.github.com/users/rnveach/events{/privacy}","received_events_url":"https://api.github.com/users/rnveach/received_events","type":"User","site_admin":false},"labels":[{"id":59160289,"node_id":"MDU6TGFiZWw1OTE2MDI4OQ==","url":"https://api.github.com/repos/checkstyle/checkstyle/labels/approved","name":"approved","color":"009800","default":false},{"id":283458388,"node_id":"MDU6TGFiZWwyODM0NTgzODg=","url":"https://api.github.com/repos/checkstyle/checkstyle/labels/miscellaneous","name":"miscellaneous","color":"5319e7","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/checkstyle/checkstyle/milestones/52","html_url":"https://github.com/checkstyle/checkstyle/milestone/52","labels_url":"https://api.github.com/repos/checkstyle/checkstyle/milestones/52/labels","id":3860439,"node_id":"MDk6TWlsZXN0b25lMzg2MDQzOQ==","number":52,"title":"8.16","description":"","creator":{"login":"romani","id":812984,"node_id":"MDQ6VXNlcjgxMjk4NA==","avatar_url":"https://avatars3.githubusercontent.com/u/812984?v=4","gravatar_id":"","url":"https://api.github.com/users/romani","html_url":"https://github.com/romani","followers_url":"https://api.github.com/users/romani/followers","following_url":"https://api.github.com/users/romani/following{/other_user}","gists_url":"https://api.github.com/users/romani/gists{/gist_id}","starred_url":"https://api.github.com/users/romani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romani/subscriptions","organizations_url":"https://api.github.com/users/romani/orgs","repos_url":"https://api.github.com/users/romani/repos","events_url":"https://api.github.com/users/romani/events{/privacy}","received_events_url":"https://api.github.com/users/romani/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":3,"state":"open","created_at":"2018-11-30T07:26:55Z","updated_at":"2018-12-09T17:06:01Z","due_on":"2018-12-30T08:00:00Z","closed_at":null},"comments":1,"created_at":"2018-12-09T13:21:42Z","updated_at":"2018-12-09T17:06:01Z","closed_at":"2018-12-09T17:06:01Z","author_association":"MEMBER","body":"Identified at https://github.com/checkstyle/checkstyle/pull/6251#issuecomment-445466617 while working on line https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/XmlLoader.java#L70 ,\r\n\r\nRemoving this code results in no test failures and I don't know how to add a test to keep it. We don't use namespaces and it seems even trying to use it results in a failure anyways so we should just remove it.\r\n\r\n```\r\n/var/tmp$ java -jar checkstyle-8.12-all.jar -c config.xml TestClass.java \r\ncom.puppycrawl.tools.checkstyle.api.CheckstyleException: unable to parse configuration stream - Attribute \"xmlns:xi\" must be declared for element type \"module\".:6:69\r\n\tat com.puppycrawl.tools.checkstyle.ConfigurationLoader.loadConfiguration(ConfigurationLoader.java:447)\r\n\tat com.puppycrawl.tools.checkstyle.ConfigurationLoader.loadConfiguration(ConfigurationLoader.java:392)\r\n\tat com.puppycrawl.tools.checkstyle.Main.runCheckstyle(Main.java:545)\r\n\tat com.puppycrawl.tools.checkstyle.Main.runCli(Main.java:472)\r\n\tat com.puppycrawl.tools.checkstyle.Main.main(Main.java:226)\r\nCaused by: org.xml.sax.SAXParseException; systemId: file:/var/tmp/config.xml; lineNumber: 6; columnNumber: 69; Attribute \"xmlns:xi\" must be declared for element type \"module\".\r\n\tat com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.createSAXParseException(ErrorHandlerWrapper.java:203)\r\n\tat com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.error(ErrorHandlerWrapper.java:134)\r\n\tat com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:396)\r\n\tat com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:327)\r\n\tat com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:284)\r\n\tat com.sun.org.apache.xerces.internal.impl.dtd.XMLDTDValidator.addDTDDefaultAttrsAndValidate(XMLDTDValidator.java:1253)\r\n\tat com.sun.org.apache.xerces.internal.impl.dtd.XMLDTDValidator.handleStartElement(XMLDTDValidator.java:1917)\r\n\tat com.sun.org.apache.xerces.internal.impl.dtd.XMLDTDValidator.startElement(XMLDTDValidator.java:742)\r\n\tat com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.scanStartElement(XMLNSDocumentScannerImpl.java:374)\r\n\tat com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl$NSContentDriver.scanRootElementHook(XMLNSDocumentScannerImpl.java:613)\r\n\tat com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:3132)\r\n\tat com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl$PrologDriver.next(XMLDocumentScannerImpl.java:852)\r\n\tat com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:602)\r\n\tat com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:112)\r\n\tat com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:505)\r\n\tat com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:842)\r\n\tat com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:771)\r\n\tat com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)\r\n\tat com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1213)\r\n\tat com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:643)\r\n\tat com.puppycrawl.tools.checkstyle.XmlLoader.parseInputSource(XmlLoader.java:85)\r\n\tat com.puppycrawl.tools.checkstyle.ConfigurationLoader.parseInputSource(ConfigurationLoader.java:194)\r\n\tat com.puppycrawl.tools.checkstyle.ConfigurationLoader.loadConfiguration(ConfigurationLoader.java:440)\r\n\t... 4 more\r\nCheckstyle ends with 1 errors.\r\n\r\n/var/tmp$ cat config.xml \r\n<?xml version=\"1.0\"?>\r\n<!DOCTYPE module PUBLIC\r\n        \"-//Checkstyle//DTD Checkstyle Configuration 1.3//EN\"\r\n        \"https://checkstyle.org/dtds/configuration_1_3.dtd\">\r\n\r\n<module name = \"Checker\" xmlns:xi=\"http://www.w3.org/2001/XInclude\">\r\n    <xi:include href=\"TreeWalker.xml\" />\r\n    <module name=\"SuppressionFilter\">\r\n      <property name=\"file\" value=\"suppressions.xml\"/>\r\n      <property name=\"optional\" value=\"false\"/>\r\n    </module>\r\n</module>\r\n\r\n```"},"comment":{"url":"https://api.github.com/repos/checkstyle/checkstyle/issues/comments/445554103","html_url":"https://github.com/checkstyle/checkstyle/issues/6262#issuecomment-445554103","issue_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/6262","id":445554103,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTU1NDEwMw==","user":{"login":"rnveach","id":5427943,"node_id":"MDQ6VXNlcjU0Mjc5NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/5427943?v=4","gravatar_id":"","url":"https://api.github.com/users/rnveach","html_url":"https://github.com/rnveach","followers_url":"https://api.github.com/users/rnveach/followers","following_url":"https://api.github.com/users/rnveach/following{/other_user}","gists_url":"https://api.github.com/users/rnveach/gists{/gist_id}","starred_url":"https://api.github.com/users/rnveach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnveach/subscriptions","organizations_url":"https://api.github.com/users/rnveach/orgs","repos_url":"https://api.github.com/users/rnveach/repos","events_url":"https://api.github.com/users/rnveach/events{/privacy}","received_events_url":"https://api.github.com/users/rnveach/received_events","type":"User","site_admin":false},"created_at":"2018-12-09T17:06:01Z","updated_at":"2018-12-09T17:06:01Z","author_association":"MEMBER","body":"Fix was merged"}}
{"actor":{"display_login":"rnveach"}}