{"action":"created","issue":{"url":"https://api.github.com/repos/MiSTer-devel/SMS_MiSTer/issues/7","repository_url":"https://api.github.com/repos/MiSTer-devel/SMS_MiSTer","labels_url":"https://api.github.com/repos/MiSTer-devel/SMS_MiSTer/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/MiSTer-devel/SMS_MiSTer/issues/7/comments","events_url":"https://api.github.com/repos/MiSTer-devel/SMS_MiSTer/issues/7/events","html_url":"https://github.com/MiSTer-devel/SMS_MiSTer/pull/7","id":373686273,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NTU3OTA3","number":7,"title":"Fix lite build","user":{"login":"rattboi","id":166042,"node_id":"MDQ6VXNlcjE2NjA0Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/166042?v=4","gravatar_id":"","url":"https://api.github.com/users/rattboi","html_url":"https://github.com/rattboi","followers_url":"https://api.github.com/users/rattboi/followers","following_url":"https://api.github.com/users/rattboi/following{/other_user}","gists_url":"https://api.github.com/users/rattboi/gists{/gist_id}","starred_url":"https://api.github.com/users/rattboi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rattboi/subscriptions","organizations_url":"https://api.github.com/users/rattboi/orgs","repos_url":"https://api.github.com/users/rattboi/repos","events_url":"https://api.github.com/users/rattboi/events{/privacy}","received_events_url":"https://api.github.com/users/rattboi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-24T21:33:37Z","updated_at":"2018-10-25T18:33:09Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/MiSTer-devel/SMS_MiSTer/pulls/7","html_url":"https://github.com/MiSTer-devel/SMS_MiSTer/pull/7","diff_url":"https://github.com/MiSTer-devel/SMS_MiSTer/pull/7.diff","patch_url":"https://github.com/MiSTer-devel/SMS_MiSTer/pull/7.patch"},"body":"Looks like something was missed from SMS.sv in mister-devel/master.\r\n\r\nWe tried to sync with you, and the result wasn't buildable by our CI. This is just the one-line fix to make the code buildable again. \r\n\r\nhttps://circleci.com/gh/OpenVGS/SMS_MiSTer/23#artifacts/containers/0\r\n\r\nYou can see the results there. If you don't want to pull in the circle-ci stuff, let me know and I'll remove them from the PR. If you don't use it, it'll just sit there, so I don't see the harm, but it's up to you."},"comment":{"url":"https://api.github.com/repos/MiSTer-devel/SMS_MiSTer/issues/comments/433159201","html_url":"https://github.com/MiSTer-devel/SMS_MiSTer/pull/7#issuecomment-433159201","issue_url":"https://api.github.com/repos/MiSTer-devel/SMS_MiSTer/issues/7","id":433159201,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzE1OTIwMQ==","user":{"login":"rattboi","id":166042,"node_id":"MDQ6VXNlcjE2NjA0Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/166042?v=4","gravatar_id":"","url":"https://api.github.com/users/rattboi","html_url":"https://github.com/rattboi","followers_url":"https://api.github.com/users/rattboi/followers","following_url":"https://api.github.com/users/rattboi/following{/other_user}","gists_url":"https://api.github.com/users/rattboi/gists{/gist_id}","starred_url":"https://api.github.com/users/rattboi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rattboi/subscriptions","organizations_url":"https://api.github.com/users/rattboi/orgs","repos_url":"https://api.github.com/users/rattboi/repos","events_url":"https://api.github.com/users/rattboi/events{/privacy}","received_events_url":"https://api.github.com/users/rattboi/received_events","type":"User","site_admin":false},"created_at":"2018-10-25T18:33:09Z","updated_at":"2018-10-25T18:33:09Z","author_association":"NONE","body":"I thought you might say that. I thought of removing the F1 signal from sys_top, but I am hoping we can move to a model where the emu interface is standard across cores, which probably means unused signals in the interface, but at least we don't have these kinds of breakages.\r\n\r\nAbout CircleCi, I get that you're not using it. I was hoping you could include it just to make our merges simpler in the future. But that's fine."}}
{"actor":{"display_login":"rattboi"}}