{"action":"created","comment":{"url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/pulls/comments/245473363","pull_request_review_id":189592554,"id":245473363,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQ3MzM2Mw==","diff_hunk":"@@ -1,16 +1,43 @@\n require 'test_helper'\n \n class SiteLayoutTest < ActionDispatch::IntegrationTest\n+  \n+  def setup\n+    @user = users(:michael)\n+  end\n+\n   test \"layout links\" do\n-    # ルートURL (Homeページ) にGETリクエストを送る.\n     get root_path\n-    # 正しいページテンプレートが描画されているかどうか確かめる.\n     assert_template 'static_pages/home'\n-    # 各ページへのリンクが正しく動くか確かめる.\n     assert_select \"a[href=?]\", root_path, count: 3\n     assert_select \"a[href=?]\", help_path\n     assert_select \"a[href=?]\", about_path, count: 2\n     assert_select \"a[href=?]\", contact_path\n+    assert_select \"a[href=?]\", signup_path\n+    assert_select \"a[href=?]\", login_path\n+    get help_path\n+    assert_select \"title\", full_title(\"Help\")","path":"test/integration/site_layout_test.rb","position":22,"original_position":22,"commit_id":"31d67546b9232cafb7b55ce8a0b1a9ce75a10319","original_commit_id":"31d67546b9232cafb7b55ce8a0b1a9ce75a10319","user":{"login":"MasashiFukuzawa","id":44726460,"node_id":"MDQ6VXNlcjQ0NzI2NDYw","avatar_url":"https://avatars3.githubusercontent.com/u/44726460?v=4","gravatar_id":"","url":"https://api.github.com/users/MasashiFukuzawa","html_url":"https://github.com/MasashiFukuzawa","followers_url":"https://api.github.com/users/MasashiFukuzawa/followers","following_url":"https://api.github.com/users/MasashiFukuzawa/following{/other_user}","gists_url":"https://api.github.com/users/MasashiFukuzawa/gists{/gist_id}","starred_url":"https://api.github.com/users/MasashiFukuzawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MasashiFukuzawa/subscriptions","organizations_url":"https://api.github.com/users/MasashiFukuzawa/orgs","repos_url":"https://api.github.com/users/MasashiFukuzawa/repos","events_url":"https://api.github.com/users/MasashiFukuzawa/events{/privacy}","received_events_url":"https://api.github.com/users/MasashiFukuzawa/received_events","type":"User","site_admin":false},"body":"ヘルパーにて、full_titleメソッドの引数をデフォルト値にして以下のように書き直しました。\r\n\r\ndef full_title(page_title = \"\", base_title = \"Bookshelf App\")\r\n    return base_title if page_title.empty?\r\n    \"#{page_title} | #{base_title}\"\r\n  end","created_at":"2019-01-05T10:11:35Z","updated_at":"2019-01-05T10:11:35Z","html_url":"https://github.com/MasashiFukuzawa/BookshelfApp/pull/19#discussion_r245473363","pull_request_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/pulls/19","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/pulls/comments/245473363"},"html":{"href":"https://github.com/MasashiFukuzawa/BookshelfApp/pull/19#discussion_r245473363"},"pull_request":{"href":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/pulls/19"}},"in_reply_to_id":244494403},"pull_request":{"url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/pulls/19","id":241309374,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMzA5Mzc0","html_url":"https://github.com/MasashiFukuzawa/BookshelfApp/pull/19","diff_url":"https://github.com/MasashiFukuzawa/BookshelfApp/pull/19.diff","patch_url":"https://github.com/MasashiFukuzawa/BookshelfApp/pull/19.patch","issue_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/issues/19","number":19,"state":"open","locked":false,"title":"Following users","user":{"login":"MasashiFukuzawa","id":44726460,"node_id":"MDQ6VXNlcjQ0NzI2NDYw","avatar_url":"https://avatars3.githubusercontent.com/u/44726460?v=4","gravatar_id":"","url":"https://api.github.com/users/MasashiFukuzawa","html_url":"https://github.com/MasashiFukuzawa","followers_url":"https://api.github.com/users/MasashiFukuzawa/followers","following_url":"https://api.github.com/users/MasashiFukuzawa/following{/other_user}","gists_url":"https://api.github.com/users/MasashiFukuzawa/gists{/gist_id}","starred_url":"https://api.github.com/users/MasashiFukuzawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MasashiFukuzawa/subscriptions","organizations_url":"https://api.github.com/users/MasashiFukuzawa/orgs","repos_url":"https://api.github.com/users/MasashiFukuzawa/repos","events_url":"https://api.github.com/users/MasashiFukuzawa/events{/privacy}","received_events_url":"https://api.github.com/users/MasashiFukuzawa/received_events","type":"User","site_admin":false},"body":"＜完了したこと＞\r\n・Userビュー、モデル、コントローラ作成\r\n・新規登録、ログイン機能の実装\r\n・ユーザーの更新、一覧表示、削除機能の実装\r\n・アカウント有効化機能の実装\r\n・パスワードリセット機能の実装\r\n\r\n・本の追加機能の実装\r\n・本の更新、削除機能の実装\r\n・登録した本のタイムラインの作成\r\n\r\n・ユーザーのフォロー機能の実装\r\n\r\n＜上手くできていない箇所＞\r\n・ページネーションのスタイル→bootstrap-will_paginate gemを入れているが上手く機能していない\r\n・Faker::Avatar.imageを使ったサンプル画像のアップロード","created_at":"2018-12-28T10:39:18Z","updated_at":"2019-01-05T10:11:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8287687dd015473c6a9a15dfcfa42f08569c4da1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/pulls/19/commits","review_comments_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/pulls/19/comments","review_comment_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/issues/19/comments","statuses_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/statuses/31d67546b9232cafb7b55ce8a0b1a9ce75a10319","head":{"label":"MasashiFukuzawa:following-users","ref":"following-users","sha":"31d67546b9232cafb7b55ce8a0b1a9ce75a10319","user":{"login":"MasashiFukuzawa","id":44726460,"node_id":"MDQ6VXNlcjQ0NzI2NDYw","avatar_url":"https://avatars3.githubusercontent.com/u/44726460?v=4","gravatar_id":"","url":"https://api.github.com/users/MasashiFukuzawa","html_url":"https://github.com/MasashiFukuzawa","followers_url":"https://api.github.com/users/MasashiFukuzawa/followers","following_url":"https://api.github.com/users/MasashiFukuzawa/following{/other_user}","gists_url":"https://api.github.com/users/MasashiFukuzawa/gists{/gist_id}","starred_url":"https://api.github.com/users/MasashiFukuzawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MasashiFukuzawa/subscriptions","organizations_url":"https://api.github.com/users/MasashiFukuzawa/orgs","repos_url":"https://api.github.com/users/MasashiFukuzawa/repos","events_url":"https://api.github.com/users/MasashiFukuzawa/events{/privacy}","received_events_url":"https://api.github.com/users/MasashiFukuzawa/received_events","type":"User","site_admin":false},"repo":{"id":161585792,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE1ODU3OTI=","name":"BookshelfApp","full_name":"MasashiFukuzawa/BookshelfApp","private":false,"owner":{"login":"MasashiFukuzawa","id":44726460,"node_id":"MDQ6VXNlcjQ0NzI2NDYw","avatar_url":"https://avatars3.githubusercontent.com/u/44726460?v=4","gravatar_id":"","url":"https://api.github.com/users/MasashiFukuzawa","html_url":"https://github.com/MasashiFukuzawa","followers_url":"https://api.github.com/users/MasashiFukuzawa/followers","following_url":"https://api.github.com/users/MasashiFukuzawa/following{/other_user}","gists_url":"https://api.github.com/users/MasashiFukuzawa/gists{/gist_id}","starred_url":"https://api.github.com/users/MasashiFukuzawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MasashiFukuzawa/subscriptions","organizations_url":"https://api.github.com/users/MasashiFukuzawa/orgs","repos_url":"https://api.github.com/users/MasashiFukuzawa/repos","events_url":"https://api.github.com/users/MasashiFukuzawa/events{/privacy}","received_events_url":"https://api.github.com/users/MasashiFukuzawa/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MasashiFukuzawa/BookshelfApp","description":"Portofolio (sub)","fork":false,"url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp","forks_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/forks","keys_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/teams","hooks_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/hooks","issue_events_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/issues/events{/number}","events_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/events","assignees_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/assignees{/user}","branches_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/branches{/branch}","tags_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/tags","blobs_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/git/refs{/sha}","trees_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/statuses/{sha}","languages_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/languages","stargazers_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/stargazers","contributors_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/contributors","subscribers_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/subscribers","subscription_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/subscription","commits_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/commits{/sha}","git_commits_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/git/commits{/sha}","comments_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/comments{/number}","issue_comment_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/issues/comments{/number}","contents_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/contents/{+path}","compare_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/merges","archive_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/downloads","issues_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/issues{/number}","pulls_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/pulls{/number}","milestones_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/milestones{/number}","notifications_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/labels{/name}","releases_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/releases{/id}","deployments_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/deployments","created_at":"2018-12-13T04:53:07Z","updated_at":"2018-12-23T03:20:28Z","pushed_at":"2018-12-28T13:12:06Z","git_url":"git://github.com/MasashiFukuzawa/BookshelfApp.git","ssh_url":"git@github.com:MasashiFukuzawa/BookshelfApp.git","clone_url":"https://github.com/MasashiFukuzawa/BookshelfApp.git","svn_url":"https://github.com/MasashiFukuzawa/BookshelfApp","homepage":null,"size":4687,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":0,"open_issues":9,"watchers":0,"default_branch":"master"}},"base":{"label":"MasashiFukuzawa:master","ref":"master","sha":"306769a2557138da19bb4eafe4a14ceec086bbb4","user":{"login":"MasashiFukuzawa","id":44726460,"node_id":"MDQ6VXNlcjQ0NzI2NDYw","avatar_url":"https://avatars3.githubusercontent.com/u/44726460?v=4","gravatar_id":"","url":"https://api.github.com/users/MasashiFukuzawa","html_url":"https://github.com/MasashiFukuzawa","followers_url":"https://api.github.com/users/MasashiFukuzawa/followers","following_url":"https://api.github.com/users/MasashiFukuzawa/following{/other_user}","gists_url":"https://api.github.com/users/MasashiFukuzawa/gists{/gist_id}","starred_url":"https://api.github.com/users/MasashiFukuzawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MasashiFukuzawa/subscriptions","organizations_url":"https://api.github.com/users/MasashiFukuzawa/orgs","repos_url":"https://api.github.com/users/MasashiFukuzawa/repos","events_url":"https://api.github.com/users/MasashiFukuzawa/events{/privacy}","received_events_url":"https://api.github.com/users/MasashiFukuzawa/received_events","type":"User","site_admin":false},"repo":{"id":161585792,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE1ODU3OTI=","name":"BookshelfApp","full_name":"MasashiFukuzawa/BookshelfApp","private":false,"owner":{"login":"MasashiFukuzawa","id":44726460,"node_id":"MDQ6VXNlcjQ0NzI2NDYw","avatar_url":"https://avatars3.githubusercontent.com/u/44726460?v=4","gravatar_id":"","url":"https://api.github.com/users/MasashiFukuzawa","html_url":"https://github.com/MasashiFukuzawa","followers_url":"https://api.github.com/users/MasashiFukuzawa/followers","following_url":"https://api.github.com/users/MasashiFukuzawa/following{/other_user}","gists_url":"https://api.github.com/users/MasashiFukuzawa/gists{/gist_id}","starred_url":"https://api.github.com/users/MasashiFukuzawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MasashiFukuzawa/subscriptions","organizations_url":"https://api.github.com/users/MasashiFukuzawa/orgs","repos_url":"https://api.github.com/users/MasashiFukuzawa/repos","events_url":"https://api.github.com/users/MasashiFukuzawa/events{/privacy}","received_events_url":"https://api.github.com/users/MasashiFukuzawa/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MasashiFukuzawa/BookshelfApp","description":"Portofolio (sub)","fork":false,"url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp","forks_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/forks","keys_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/teams","hooks_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/hooks","issue_events_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/issues/events{/number}","events_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/events","assignees_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/assignees{/user}","branches_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/branches{/branch}","tags_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/tags","blobs_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/git/refs{/sha}","trees_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/statuses/{sha}","languages_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/languages","stargazers_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/stargazers","contributors_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/contributors","subscribers_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/subscribers","subscription_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/subscription","commits_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/commits{/sha}","git_commits_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/git/commits{/sha}","comments_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/comments{/number}","issue_comment_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/issues/comments{/number}","contents_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/contents/{+path}","compare_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/merges","archive_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/downloads","issues_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/issues{/number}","pulls_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/pulls{/number}","milestones_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/milestones{/number}","notifications_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/labels{/name}","releases_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/releases{/id}","deployments_url":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/deployments","created_at":"2018-12-13T04:53:07Z","updated_at":"2018-12-23T03:20:28Z","pushed_at":"2018-12-28T13:12:06Z","git_url":"git://github.com/MasashiFukuzawa/BookshelfApp.git","ssh_url":"git@github.com:MasashiFukuzawa/BookshelfApp.git","clone_url":"https://github.com/MasashiFukuzawa/BookshelfApp.git","svn_url":"https://github.com/MasashiFukuzawa/BookshelfApp","homepage":null,"size":4687,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":0,"open_issues":9,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/pulls/19"},"html":{"href":"https://github.com/MasashiFukuzawa/BookshelfApp/pull/19"},"issue":{"href":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/issues/19"},"comments":{"href":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/MasashiFukuzawa/BookshelfApp/statuses/31d67546b9232cafb7b55ce8a0b1a9ce75a10319"}},"author_association":"OWNER"}}
{"actor":{"display_login":"MasashiFukuzawa"}}