{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/188425141","pull_request_review_id":120401369,"id":188425141,"diff_hunk":"@@ -29,7 +29,7 @@\n  */\n class UTF8StringValueBuilder\n {\n-    private static final int DEFAULT_SIZE = 8;\n+    private static final int DEFAULT_SIZE = Byte.SIZE;","path":"community/random-values/src/main/java/org/neo4j/values/storable/UTF8StringValueBuilder.java","position":5,"original_position":5,"commit_id":"f5dc6a4ff472c16a2dae33f3e7a1d0170e865b76","original_commit_id":"fab4b27f4a4ba4c0389001331357b0c21cd292d2","user":{"login":"pontusmelke","id":88000,"avatar_url":"https://avatars3.githubusercontent.com/u/88000?v=4","gravatar_id":"","url":"https://api.github.com/users/pontusmelke","html_url":"https://github.com/pontusmelke","followers_url":"https://api.github.com/users/pontusmelke/followers","following_url":"https://api.github.com/users/pontusmelke/following{/other_user}","gists_url":"https://api.github.com/users/pontusmelke/gists{/gist_id}","starred_url":"https://api.github.com/users/pontusmelke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pontusmelke/subscriptions","organizations_url":"https://api.github.com/users/pontusmelke/orgs","repos_url":"https://api.github.com/users/pontusmelke/repos","events_url":"https://api.github.com/users/pontusmelke/events{/privacy}","received_events_url":"https://api.github.com/users/pontusmelke/received_events","type":"User","site_admin":false},"body":"This kind of implies that there is some connection between the size of a byte and the size of the backing array. The default size is more like the \"typical ascii string length\" - I just thought 16 was too big and 4 too small but there is no connection to the size of the individual bytes. ","created_at":"2018-05-15T20:27:16Z","updated_at":"2018-05-15T20:27:16Z","html_url":"https://github.com/neo4j/neo4j/pull/11783#discussion_r188425141","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11783","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/188425141"},"html":{"href":"https://github.com/neo4j/neo4j/pull/11783#discussion_r188425141"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11783"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/11783","id":188209085,"html_url":"https://github.com/neo4j/neo4j/pull/11783","diff_url":"https://github.com/neo4j/neo4j/pull/11783.diff","patch_url":"https://github.com/neo4j/neo4j/pull/11783.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/11783","number":11783,"state":"open","locked":false,"title":" Small cleanup in random-values module","user":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars2.githubusercontent.com/u/12656787?v=4","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-15T17:59:46Z","updated_at":"2018-05-15T20:27:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3971acac438cee3f92f121a0dda59e1f41759bff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":892627553,"url":"https://api.github.com/repos/neo4j/neo4j/labels/3.5","name":"3.5","color":"ad1f3e","default":false},{"id":647068085,"url":"https://api.github.com/repos/neo4j/neo4j/labels/team-kernel","name":"team-kernel","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11783/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11783/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/11783/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/f5dc6a4ff472c16a2dae33f3e7a1d0170e865b76","head":{"label":"MishaDemianenko:3.5-small-randoms-cleanup","ref":"3.5-small-randoms-cleanup","sha":"f5dc6a4ff472c16a2dae33f3e7a1d0170e865b76","user":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars2.githubusercontent.com/u/12656787?v=4","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"repo":{"id":36607274,"name":"neo4j","full_name":"MishaDemianenko/neo4j","owner":{"login":"MishaDemianenko","id":12656787,"avatar_url":"https://avatars2.githubusercontent.com/u/12656787?v=4","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MishaDemianenko/neo4j","description":"Graphs for Everyone","fork":true,"url":"https://api.github.com/repos/MishaDemianenko/neo4j","forks_url":"https://api.github.com/repos/MishaDemianenko/neo4j/forks","keys_url":"https://api.github.com/repos/MishaDemianenko/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MishaDemianenko/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MishaDemianenko/neo4j/teams","hooks_url":"https://api.github.com/repos/MishaDemianenko/neo4j/hooks","issue_events_url":"https://api.github.com/repos/MishaDemianenko/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/MishaDemianenko/neo4j/events","assignees_url":"https://api.github.com/repos/MishaDemianenko/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/MishaDemianenko/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/MishaDemianenko/neo4j/tags","blobs_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MishaDemianenko/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/MishaDemianenko/neo4j/languages","stargazers_url":"https://api.github.com/repos/MishaDemianenko/neo4j/stargazers","contributors_url":"https://api.github.com/repos/MishaDemianenko/neo4j/contributors","subscribers_url":"https://api.github.com/repos/MishaDemianenko/neo4j/subscribers","subscription_url":"https://api.github.com/repos/MishaDemianenko/neo4j/subscription","commits_url":"https://api.github.com/repos/MishaDemianenko/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/MishaDemianenko/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/MishaDemianenko/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/MishaDemianenko/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/MishaDemianenko/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/MishaDemianenko/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MishaDemianenko/neo4j/merges","archive_url":"https://api.github.com/repos/MishaDemianenko/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MishaDemianenko/neo4j/downloads","issues_url":"https://api.github.com/repos/MishaDemianenko/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/MishaDemianenko/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/MishaDemianenko/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/MishaDemianenko/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MishaDemianenko/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/MishaDemianenko/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/MishaDemianenko/neo4j/deployments","created_at":"2015-05-31T14:44:24Z","updated_at":"2015-05-31T14:44:50Z","pushed_at":"2018-05-15T17:58:58Z","git_url":"git://github.com/MishaDemianenko/neo4j.git","ssh_url":"git@github.com:MishaDemianenko/neo4j.git","clone_url":"https://github.com/MishaDemianenko/neo4j.git","svn_url":"https://github.com/MishaDemianenko/neo4j","homepage":"http://neo4j.com","size":412305,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.3"}},"base":{"label":"neo4j:3.5","ref":"3.5","sha":"f29d0c86d51506dd75fdf1963386995a7fc6faf8","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2018-05-15T19:56:24Z","pushed_at":"2018-05-15T17:59:47Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":413766,"stargazers_count":5057,"watchers_count":5057,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1348,"mirror_url":null,"archived":false,"open_issues_count":383,"license":null,"forks":1348,"open_issues":383,"watchers":5057,"default_branch":"3.5"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11783"},"html":{"href":"https://github.com/neo4j/neo4j/pull/11783"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/11783"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/11783/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11783/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11783/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/f5dc6a4ff472c16a2dae33f3e7a1d0170e865b76"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pontusmelke"}}