{"action":"created","comment":{"url":"https://api.github.com/repos/pencil2d/pencil/pulls/comments/174204328","pull_request_review_id":103517474,"id":174204328,"diff_hunk":"@@ -305,7 +305,16 @@ int handleArguments( PencilApplication& app )\n int main(int argc, char* argv[])\n {\n     Q_INIT_RESOURCE(core_lib);\n-    PencilApplication::setAttribute(Qt::AA_EnableHighDpiScaling);\n+\n+    QSettings settings(PENCIL2D, PENCIL2D);\n+    if (settings.value(\"EnableHighDpiScaling\", \"true\").toBool())","path":"app/src/main.cpp","position":null,"original_position":7,"commit_id":"895697de2f714ea280c037ea6ebceea357b93f09","original_commit_id":"895697de2f714ea280c037ea6ebceea357b93f09","user":{"login":"CandyFace","id":1045397,"avatar_url":"https://avatars2.githubusercontent.com/u/1045397?v=4","gravatar_id":"","url":"https://api.github.com/users/CandyFace","html_url":"https://github.com/CandyFace","followers_url":"https://api.github.com/users/CandyFace/followers","following_url":"https://api.github.com/users/CandyFace/following{/other_user}","gists_url":"https://api.github.com/users/CandyFace/gists{/gist_id}","starred_url":"https://api.github.com/users/CandyFace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CandyFace/subscriptions","organizations_url":"https://api.github.com/users/CandyFace/orgs","repos_url":"https://api.github.com/users/CandyFace/repos","events_url":"https://api.github.com/users/CandyFace/events{/privacy}","received_events_url":"https://api.github.com/users/CandyFace/received_events","type":"User","site_admin":false},"body":"Why do you add the EnableHighDpiScaling as a setting and check it if it's always true? Is it not enough to just set the attribute always?","created_at":"2018-03-13T16:47:12Z","updated_at":"2018-03-13T16:47:12Z","html_url":"https://github.com/pencil2d/pencil/pull/922#discussion_r174204328","pull_request_url":"https://api.github.com/repos/pencil2d/pencil/pulls/922","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pencil2d/pencil/pulls/comments/174204328"},"html":{"href":"https://github.com/pencil2d/pencil/pull/922#discussion_r174204328"},"pull_request":{"href":"https://api.github.com/repos/pencil2d/pencil/pulls/922"}}},"pull_request":{"url":"https://api.github.com/repos/pencil2d/pencil/pulls/922","id":174641170,"html_url":"https://github.com/pencil2d/pencil/pull/922","diff_url":"https://github.com/pencil2d/pencil/pull/922.diff","patch_url":"https://github.com/pencil2d/pencil/pull/922.patch","issue_url":"https://api.github.com/repos/pencil2d/pencil/issues/922","number":922,"state":"open","locked":false,"title":"A temporary solution for high dpi displays","user":{"login":"chchwy","id":163800,"avatar_url":"https://avatars3.githubusercontent.com/u/163800?v=4","gravatar_id":"","url":"https://api.github.com/users/chchwy","html_url":"https://github.com/chchwy","followers_url":"https://api.github.com/users/chchwy/followers","following_url":"https://api.github.com/users/chchwy/following{/other_user}","gists_url":"https://api.github.com/users/chchwy/gists{/gist_id}","starred_url":"https://api.github.com/users/chchwy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chchwy/subscriptions","organizations_url":"https://api.github.com/users/chchwy/orgs","repos_url":"https://api.github.com/users/chchwy/repos","events_url":"https://api.github.com/users/chchwy/events{/privacy}","received_events_url":"https://api.github.com/users/chchwy/received_events","type":"User","site_admin":false},"body":"A temporary solution for high DPI displays by setting `Qt::AA_EnableHighDpiScaling`.\r\n\r\nI test it on an 15-inch MacBook Pro with Win 10 installed, resolution 2800x1800, 200% display scaling.\r\n\r\n1. `Qt::AA_EnableHighDpiScaling` On:\r\n\r\nGenerally it's fine, but take a closer look at the play and add-key button, you will see pixelated icons.\r\n\r\n![Imgur](https://i.imgur.com/x4jiRI5.png)\r\n\r\n2. `Qt::AA_EnableHighDpiScaling` Off (as 0.6 official build)\r\n\r\nVery tiny icons, and overlapped font on Timeline\r\n\r\n![Imgur](https://i.imgur.com/alfgn2b.png)\r\n\r\nIt's not a perfect solution but will make the Pencil2D UI *usable* on a 4k monitor.","created_at":"2018-03-13T12:15:00Z","updated_at":"2018-03-13T16:47:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d36aa822baa73dfe048b6939a3f925ebf16c80b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pencil2d/pencil/pulls/922/commits","review_comments_url":"https://api.github.com/repos/pencil2d/pencil/pulls/922/comments","review_comment_url":"https://api.github.com/repos/pencil2d/pencil/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pencil2d/pencil/issues/922/comments","statuses_url":"https://api.github.com/repos/pencil2d/pencil/statuses/895697de2f714ea280c037ea6ebceea357b93f09","head":{"label":"chchwy:fix/high-dpi","ref":"fix/high-dpi","sha":"895697de2f714ea280c037ea6ebceea357b93f09","user":{"login":"chchwy","id":163800,"avatar_url":"https://avatars3.githubusercontent.com/u/163800?v=4","gravatar_id":"","url":"https://api.github.com/users/chchwy","html_url":"https://github.com/chchwy","followers_url":"https://api.github.com/users/chchwy/followers","following_url":"https://api.github.com/users/chchwy/following{/other_user}","gists_url":"https://api.github.com/users/chchwy/gists{/gist_id}","starred_url":"https://api.github.com/users/chchwy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chchwy/subscriptions","organizations_url":"https://api.github.com/users/chchwy/orgs","repos_url":"https://api.github.com/users/chchwy/repos","events_url":"https://api.github.com/users/chchwy/events{/privacy}","received_events_url":"https://api.github.com/users/chchwy/received_events","type":"User","site_admin":false},"repo":{"id":10983723,"name":"pencil2d","full_name":"chchwy/pencil2d","owner":{"login":"chchwy","id":163800,"avatar_url":"https://avatars3.githubusercontent.com/u/163800?v=4","gravatar_id":"","url":"https://api.github.com/users/chchwy","html_url":"https://github.com/chchwy","followers_url":"https://api.github.com/users/chchwy/followers","following_url":"https://api.github.com/users/chchwy/following{/other_user}","gists_url":"https://api.github.com/users/chchwy/gists{/gist_id}","starred_url":"https://api.github.com/users/chchwy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chchwy/subscriptions","organizations_url":"https://api.github.com/users/chchwy/orgs","repos_url":"https://api.github.com/users/chchwy/repos","events_url":"https://api.github.com/users/chchwy/events{/privacy}","received_events_url":"https://api.github.com/users/chchwy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chchwy/pencil2d","description":"Pencil is an animation/drawing software for Mac OS X, Windows, and Linux. It lets you create traditional hand-drawn animation (cartoon) using both bitmap and vector graphics. Pencil is free and open source.","fork":true,"url":"https://api.github.com/repos/chchwy/pencil2d","forks_url":"https://api.github.com/repos/chchwy/pencil2d/forks","keys_url":"https://api.github.com/repos/chchwy/pencil2d/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chchwy/pencil2d/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chchwy/pencil2d/teams","hooks_url":"https://api.github.com/repos/chchwy/pencil2d/hooks","issue_events_url":"https://api.github.com/repos/chchwy/pencil2d/issues/events{/number}","events_url":"https://api.github.com/repos/chchwy/pencil2d/events","assignees_url":"https://api.github.com/repos/chchwy/pencil2d/assignees{/user}","branches_url":"https://api.github.com/repos/chchwy/pencil2d/branches{/branch}","tags_url":"https://api.github.com/repos/chchwy/pencil2d/tags","blobs_url":"https://api.github.com/repos/chchwy/pencil2d/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chchwy/pencil2d/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chchwy/pencil2d/git/refs{/sha}","trees_url":"https://api.github.com/repos/chchwy/pencil2d/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chchwy/pencil2d/statuses/{sha}","languages_url":"https://api.github.com/repos/chchwy/pencil2d/languages","stargazers_url":"https://api.github.com/repos/chchwy/pencil2d/stargazers","contributors_url":"https://api.github.com/repos/chchwy/pencil2d/contributors","subscribers_url":"https://api.github.com/repos/chchwy/pencil2d/subscribers","subscription_url":"https://api.github.com/repos/chchwy/pencil2d/subscription","commits_url":"https://api.github.com/repos/chchwy/pencil2d/commits{/sha}","git_commits_url":"https://api.github.com/repos/chchwy/pencil2d/git/commits{/sha}","comments_url":"https://api.github.com/repos/chchwy/pencil2d/comments{/number}","issue_comment_url":"https://api.github.com/repos/chchwy/pencil2d/issues/comments{/number}","contents_url":"https://api.github.com/repos/chchwy/pencil2d/contents/{+path}","compare_url":"https://api.github.com/repos/chchwy/pencil2d/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chchwy/pencil2d/merges","archive_url":"https://api.github.com/repos/chchwy/pencil2d/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chchwy/pencil2d/downloads","issues_url":"https://api.github.com/repos/chchwy/pencil2d/issues{/number}","pulls_url":"https://api.github.com/repos/chchwy/pencil2d/pulls{/number}","milestones_url":"https://api.github.com/repos/chchwy/pencil2d/milestones{/number}","notifications_url":"https://api.github.com/repos/chchwy/pencil2d/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chchwy/pencil2d/labels{/name}","releases_url":"https://api.github.com/repos/chchwy/pencil2d/releases{/id}","deployments_url":"https://api.github.com/repos/chchwy/pencil2d/deployments","created_at":"2013-06-27T01:13:30Z","updated_at":"2017-12-12T04:20:58Z","pushed_at":"2018-03-13T00:37:49Z","git_url":"git://github.com/chchwy/pencil2d.git","ssh_url":"git@github.com:chchwy/pencil2d.git","clone_url":"https://github.com/chchwy/pencil2d.git","svn_url":"https://github.com/chchwy/pencil2d","homepage":"http://pencil2d.org","size":32236,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"pencil2d:master","ref":"master","sha":"ed560db5ca471a050653d34346dfc5a42691051a","user":{"login":"pencil2d","id":4840320,"avatar_url":"https://avatars3.githubusercontent.com/u/4840320?v=4","gravatar_id":"","url":"https://api.github.com/users/pencil2d","html_url":"https://github.com/pencil2d","followers_url":"https://api.github.com/users/pencil2d/followers","following_url":"https://api.github.com/users/pencil2d/following{/other_user}","gists_url":"https://api.github.com/users/pencil2d/gists{/gist_id}","starred_url":"https://api.github.com/users/pencil2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pencil2d/subscriptions","organizations_url":"https://api.github.com/users/pencil2d/orgs","repos_url":"https://api.github.com/users/pencil2d/repos","events_url":"https://api.github.com/users/pencil2d/events{/privacy}","received_events_url":"https://api.github.com/users/pencil2d/received_events","type":"Organization","site_admin":false},"repo":{"id":10978577,"name":"pencil","full_name":"pencil2d/pencil","owner":{"login":"pencil2d","id":4840320,"avatar_url":"https://avatars3.githubusercontent.com/u/4840320?v=4","gravatar_id":"","url":"https://api.github.com/users/pencil2d","html_url":"https://github.com/pencil2d","followers_url":"https://api.github.com/users/pencil2d/followers","following_url":"https://api.github.com/users/pencil2d/following{/other_user}","gists_url":"https://api.github.com/users/pencil2d/gists{/gist_id}","starred_url":"https://api.github.com/users/pencil2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pencil2d/subscriptions","organizations_url":"https://api.github.com/users/pencil2d/orgs","repos_url":"https://api.github.com/users/pencil2d/repos","events_url":"https://api.github.com/users/pencil2d/events{/privacy}","received_events_url":"https://api.github.com/users/pencil2d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pencil2d/pencil","description":"Pencil2D is an animation/drawing software for Mac OS X, Windows, and Linux. It lets you create traditional hand-drawn animation (cartoon) using both bitmap and vector graphics. Pencil2D is free and open source.","fork":false,"url":"https://api.github.com/repos/pencil2d/pencil","forks_url":"https://api.github.com/repos/pencil2d/pencil/forks","keys_url":"https://api.github.com/repos/pencil2d/pencil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pencil2d/pencil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pencil2d/pencil/teams","hooks_url":"https://api.github.com/repos/pencil2d/pencil/hooks","issue_events_url":"https://api.github.com/repos/pencil2d/pencil/issues/events{/number}","events_url":"https://api.github.com/repos/pencil2d/pencil/events","assignees_url":"https://api.github.com/repos/pencil2d/pencil/assignees{/user}","branches_url":"https://api.github.com/repos/pencil2d/pencil/branches{/branch}","tags_url":"https://api.github.com/repos/pencil2d/pencil/tags","blobs_url":"https://api.github.com/repos/pencil2d/pencil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pencil2d/pencil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pencil2d/pencil/git/refs{/sha}","trees_url":"https://api.github.com/repos/pencil2d/pencil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pencil2d/pencil/statuses/{sha}","languages_url":"https://api.github.com/repos/pencil2d/pencil/languages","stargazers_url":"https://api.github.com/repos/pencil2d/pencil/stargazers","contributors_url":"https://api.github.com/repos/pencil2d/pencil/contributors","subscribers_url":"https://api.github.com/repos/pencil2d/pencil/subscribers","subscription_url":"https://api.github.com/repos/pencil2d/pencil/subscription","commits_url":"https://api.github.com/repos/pencil2d/pencil/commits{/sha}","git_commits_url":"https://api.github.com/repos/pencil2d/pencil/git/commits{/sha}","comments_url":"https://api.github.com/repos/pencil2d/pencil/comments{/number}","issue_comment_url":"https://api.github.com/repos/pencil2d/pencil/issues/comments{/number}","contents_url":"https://api.github.com/repos/pencil2d/pencil/contents/{+path}","compare_url":"https://api.github.com/repos/pencil2d/pencil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pencil2d/pencil/merges","archive_url":"https://api.github.com/repos/pencil2d/pencil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pencil2d/pencil/downloads","issues_url":"https://api.github.com/repos/pencil2d/pencil/issues{/number}","pulls_url":"https://api.github.com/repos/pencil2d/pencil/pulls{/number}","milestones_url":"https://api.github.com/repos/pencil2d/pencil/milestones{/number}","notifications_url":"https://api.github.com/repos/pencil2d/pencil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pencil2d/pencil/labels{/name}","releases_url":"https://api.github.com/repos/pencil2d/pencil/releases{/id}","deployments_url":"https://api.github.com/repos/pencil2d/pencil/deployments","created_at":"2013-06-26T20:40:59Z","updated_at":"2018-03-13T13:53:41Z","pushed_at":"2018-03-13T12:15:01Z","git_url":"git://github.com/pencil2d/pencil.git","ssh_url":"git@github.com:pencil2d/pencil.git","clone_url":"https://github.com/pencil2d/pencil.git","svn_url":"https://github.com/pencil2d/pencil","homepage":"http://pencil2d.org","size":32203,"stargazers_count":437,"watchers_count":437,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":111,"mirror_url":null,"archived":false,"open_issues_count":125,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":111,"open_issues":125,"watchers":437,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pencil2d/pencil/pulls/922"},"html":{"href":"https://github.com/pencil2d/pencil/pull/922"},"issue":{"href":"https://api.github.com/repos/pencil2d/pencil/issues/922"},"comments":{"href":"https://api.github.com/repos/pencil2d/pencil/issues/922/comments"},"review_comments":{"href":"https://api.github.com/repos/pencil2d/pencil/pulls/922/comments"},"review_comment":{"href":"https://api.github.com/repos/pencil2d/pencil/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pencil2d/pencil/pulls/922/commits"},"statuses":{"href":"https://api.github.com/repos/pencil2d/pencil/statuses/895697de2f714ea280c037ea6ebceea357b93f09"}},"author_association":"OWNER"}}
{"actor":{"display_login":"CandyFace"}}