{"action":"created","issue":{"url":"https://api.github.com/repos/LunarG/VulkanTools/issues/653","repository_url":"https://api.github.com/repos/LunarG/VulkanTools","labels_url":"https://api.github.com/repos/LunarG/VulkanTools/issues/653/labels{/name}","comments_url":"https://api.github.com/repos/LunarG/VulkanTools/issues/653/comments","events_url":"https://api.github.com/repos/LunarG/VulkanTools/issues/653/events","html_url":"https://github.com/LunarG/VulkanTools/pull/653","id":375450669,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2ODkxNjMz","number":653,"title":"vktrace: Add option for post process trim","user":{"login":"justuswang","id":5653641,"node_id":"MDQ6VXNlcjU2NTM2NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/5653641?v=4","gravatar_id":"","url":"https://api.github.com/users/justuswang","html_url":"https://github.com/justuswang","followers_url":"https://api.github.com/users/justuswang/followers","following_url":"https://api.github.com/users/justuswang/following{/other_user}","gists_url":"https://api.github.com/users/justuswang/gists{/gist_id}","starred_url":"https://api.github.com/users/justuswang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justuswang/subscriptions","organizations_url":"https://api.github.com/users/justuswang/orgs","repos_url":"https://api.github.com/users/justuswang/repos","events_url":"https://api.github.com/users/justuswang/events{/privacy}","received_events_url":"https://api.github.com/users/justuswang/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-30T11:53:30Z","updated_at":"2018-11-08T18:21:23Z","closed_at":"2018-11-08T18:21:23Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/LunarG/VulkanTools/pulls/653","html_url":"https://github.com/LunarG/VulkanTools/pull/653","diff_url":"https://github.com/LunarG/VulkanTools/pull/653.diff","patch_url":"https://github.com/LunarG/VulkanTools/pull/653.patch"},"body":"This PR adds a environment variable VKTRACE_TRIM_POST_PROCESS and a vktrace option \"-tpp\" to enable/disable trim post processing.\r\nDisable post processing means \"write all referenced object calls\" will happen in the trim start frame.\r\nEnable post processing means \"write all referenced object calls\" will happen in the trim end frame and will NOT save objects NOT referenced in-trim.\r\n\r\n- When VKTRACE_TRIM_POST_PROCESS is set to 1, trim post processing is enabled and the \"write all referenced object calls\" will happen in trim end frame.\r\n- When VKTRACE_TRIM_POST_PROCESS is set to 0, trim post processing is disabled and the \"write all referenced object calls\" will happen in trim start frame.\r\n- When VKTRACE_TRIM_POST_PROCESS is NOT set or set with other value, the \"write all referenced object calls\" will happen in trim start frame.\r\n\r\n(The same as the behavior without this change.)\r\n\r\nThis change helps to reduce the trimmed trace file size.\r\nIt saves around 30% file size in average in our testing but it depends on the number of objects (especially shader modules, images and buffers) NOT referenced in-trim."},"comment":{"url":"https://api.github.com/repos/LunarG/VulkanTools/issues/comments/437103805","html_url":"https://github.com/LunarG/VulkanTools/pull/653#issuecomment-437103805","issue_url":"https://api.github.com/repos/LunarG/VulkanTools/issues/653","id":437103805,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzEwMzgwNQ==","user":{"login":"davidlunarg","id":10409469,"node_id":"MDQ6VXNlcjEwNDA5NDY5","avatar_url":"https://avatars1.githubusercontent.com/u/10409469?v=4","gravatar_id":"","url":"https://api.github.com/users/davidlunarg","html_url":"https://github.com/davidlunarg","followers_url":"https://api.github.com/users/davidlunarg/followers","following_url":"https://api.github.com/users/davidlunarg/following{/other_user}","gists_url":"https://api.github.com/users/davidlunarg/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlunarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlunarg/subscriptions","organizations_url":"https://api.github.com/users/davidlunarg/orgs","repos_url":"https://api.github.com/users/davidlunarg/repos","events_url":"https://api.github.com/users/davidlunarg/events{/privacy}","received_events_url":"https://api.github.com/users/davidlunarg/received_events","type":"User","site_admin":false},"created_at":"2018-11-08T18:21:23Z","updated_at":"2018-11-08T18:21:23Z","author_association":"CONTRIBUTOR","body":"cherry-picked to master"}}
{"actor":{"display_login":"davidlunarg"}}