{"action":"created","comment":{"url":"https://api.github.com/repos/stellar/stellar-core/pulls/comments/234754599","pull_request_review_id":176464151,"id":234754599,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDc1NDU5OQ==","diff_hunk":"@@ -24,28 +24,36 @@ class VerifyLedgerChainWork : public Work\n     TmpDir const& mDownloadDir;\n     LedgerRange mRange;\n     uint32_t mCurrCheckpoint;\n-    bool mManualCatchup;\n     LedgerHeaderHistoryEntry& mFirstVerified;\n-    LedgerHeaderHistoryEntry& mLastVerified;\n+    LedgerHeaderHistoryEntry const& mLastClosedLedger;\n+    optional<Hash> mTrustedHash;\n+\n+    // First ledger of last verified checkpoint. Needed for a checkpoint that\n+    // is being verified: last ledger in current checkpoint must agree with\n+    // mVerifiedAhead\n+    LedgerHeaderHistoryEntry mVerifiedAhead{};\n \n     medida::Meter& mVerifyLedgerSuccessOld;\n     medida::Meter& mVerifyLedgerSuccess;\n     medida::Meter& mVerifyLedgerFailureLedgerVersion;\n     medida::Meter& mVerifyLedgerFailureOvershot;\n+    medida::Meter& mVerifyLedgerFailureUndershot;","path":"src/catchup/VerifyLedgerChainWork.h","position":19,"original_position":19,"commit_id":"59f9cc0f15350b048b7c92f0b84171d64b3e6b6b","original_commit_id":"88b7d1db5a2b1103055b25d1b6e2358a624481cd","user":{"login":"marta-lokhova","id":9428003,"node_id":"MDQ6VXNlcjk0MjgwMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/9428003?v=4","gravatar_id":"","url":"https://api.github.com/users/marta-lokhova","html_url":"https://github.com/marta-lokhova","followers_url":"https://api.github.com/users/marta-lokhova/followers","following_url":"https://api.github.com/users/marta-lokhova/following{/other_user}","gists_url":"https://api.github.com/users/marta-lokhova/gists{/gist_id}","starred_url":"https://api.github.com/users/marta-lokhova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marta-lokhova/subscriptions","organizations_url":"https://api.github.com/users/marta-lokhova/orgs","repos_url":"https://api.github.com/users/marta-lokhova/repos","events_url":"https://api.github.com/users/marta-lokhova/events{/privacy}","received_events_url":"https://api.github.com/users/marta-lokhova/received_events","type":"User","site_admin":false},"body":"Updated this, and kept \"ledger-verify\" success and failure metrics only. ","created_at":"2018-11-19T19:38:21Z","updated_at":"2018-11-19T19:38:22Z","html_url":"https://github.com/stellar/stellar-core/pull/1711#discussion_r234754599","pull_request_url":"https://api.github.com/repos/stellar/stellar-core/pulls/1711","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/comments/234754599"},"html":{"href":"https://github.com/stellar/stellar-core/pull/1711#discussion_r234754599"},"pull_request":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/1711"}},"in_reply_to_id":209807767},"pull_request":{"url":"https://api.github.com/repos/stellar/stellar-core/pulls/1711","id":194361607,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MzYxNjA3","html_url":"https://github.com/stellar/stellar-core/pull/1711","diff_url":"https://github.com/stellar/stellar-core/pull/1711.diff","patch_url":"https://github.com/stellar/stellar-core/pull/1711.patch","issue_url":"https://api.github.com/repos/stellar/stellar-core/issues/1711","number":1711,"state":"open","locked":false,"title":"Reverse ledger chain verification","user":{"login":"marta-lokhova","id":9428003,"node_id":"MDQ6VXNlcjk0MjgwMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/9428003?v=4","gravatar_id":"","url":"https://api.github.com/users/marta-lokhova","html_url":"https://github.com/marta-lokhova","followers_url":"https://api.github.com/users/marta-lokhova/followers","following_url":"https://api.github.com/users/marta-lokhova/following{/other_user}","gists_url":"https://api.github.com/users/marta-lokhova/gists{/gist_id}","starred_url":"https://api.github.com/users/marta-lokhova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marta-lokhova/subscriptions","organizations_url":"https://api.github.com/users/marta-lokhova/orgs","repos_url":"https://api.github.com/users/marta-lokhova/repos","events_url":"https://api.github.com/users/marta-lokhova/events{/privacy}","received_events_url":"https://api.github.com/users/marta-lokhova/received_events","type":"User","site_admin":false},"body":"In this PR, ledger chain verification is updated to verify checkpoint starting from the recent one and working its way back to the beginning of the range. Additionally, ledger chain verification work does not make calls to ledger manager anymore, as the trusted SCP hash is passed into CatchupWork directly. \r\n","created_at":"2018-06-12T18:00:44Z","updated_at":"2018-11-19T19:38:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f61f5a46e8dca7ea031bbb92b6ced8249926af1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stellar/stellar-core/pulls/1711/commits","review_comments_url":"https://api.github.com/repos/stellar/stellar-core/pulls/1711/comments","review_comment_url":"https://api.github.com/repos/stellar/stellar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stellar/stellar-core/issues/1711/comments","statuses_url":"https://api.github.com/repos/stellar/stellar-core/statuses/59f9cc0f15350b048b7c92f0b84171d64b3e6b6b","head":{"label":"marta-lokhova:reverse_ledger_chain_verification","ref":"reverse_ledger_chain_verification","sha":"59f9cc0f15350b048b7c92f0b84171d64b3e6b6b","user":{"login":"marta-lokhova","id":9428003,"node_id":"MDQ6VXNlcjk0MjgwMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/9428003?v=4","gravatar_id":"","url":"https://api.github.com/users/marta-lokhova","html_url":"https://github.com/marta-lokhova","followers_url":"https://api.github.com/users/marta-lokhova/followers","following_url":"https://api.github.com/users/marta-lokhova/following{/other_user}","gists_url":"https://api.github.com/users/marta-lokhova/gists{/gist_id}","starred_url":"https://api.github.com/users/marta-lokhova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marta-lokhova/subscriptions","organizations_url":"https://api.github.com/users/marta-lokhova/orgs","repos_url":"https://api.github.com/users/marta-lokhova/repos","events_url":"https://api.github.com/users/marta-lokhova/events{/privacy}","received_events_url":"https://api.github.com/users/marta-lokhova/received_events","type":"User","site_admin":false},"repo":{"id":120042958,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAwNDI5NTg=","name":"stellar-core","full_name":"marta-lokhova/stellar-core","private":false,"owner":{"login":"marta-lokhova","id":9428003,"node_id":"MDQ6VXNlcjk0MjgwMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/9428003?v=4","gravatar_id":"","url":"https://api.github.com/users/marta-lokhova","html_url":"https://github.com/marta-lokhova","followers_url":"https://api.github.com/users/marta-lokhova/followers","following_url":"https://api.github.com/users/marta-lokhova/following{/other_user}","gists_url":"https://api.github.com/users/marta-lokhova/gists{/gist_id}","starred_url":"https://api.github.com/users/marta-lokhova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marta-lokhova/subscriptions","organizations_url":"https://api.github.com/users/marta-lokhova/orgs","repos_url":"https://api.github.com/users/marta-lokhova/repos","events_url":"https://api.github.com/users/marta-lokhova/events{/privacy}","received_events_url":"https://api.github.com/users/marta-lokhova/received_events","type":"User","site_admin":false},"html_url":"https://github.com/marta-lokhova/stellar-core","description":"stellar-core is the backbone of the Stellar network. It maintains a local copy of the ledger, communicating and staying in sync with other instances of stellar-core on the network. Optionally, stellar-core can store historical records of the ledger and participate in consensus.","fork":true,"url":"https://api.github.com/repos/marta-lokhova/stellar-core","forks_url":"https://api.github.com/repos/marta-lokhova/stellar-core/forks","keys_url":"https://api.github.com/repos/marta-lokhova/stellar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marta-lokhova/stellar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marta-lokhova/stellar-core/teams","hooks_url":"https://api.github.com/repos/marta-lokhova/stellar-core/hooks","issue_events_url":"https://api.github.com/repos/marta-lokhova/stellar-core/issues/events{/number}","events_url":"https://api.github.com/repos/marta-lokhova/stellar-core/events","assignees_url":"https://api.github.com/repos/marta-lokhova/stellar-core/assignees{/user}","branches_url":"https://api.github.com/repos/marta-lokhova/stellar-core/branches{/branch}","tags_url":"https://api.github.com/repos/marta-lokhova/stellar-core/tags","blobs_url":"https://api.github.com/repos/marta-lokhova/stellar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marta-lokhova/stellar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marta-lokhova/stellar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/marta-lokhova/stellar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marta-lokhova/stellar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/marta-lokhova/stellar-core/languages","stargazers_url":"https://api.github.com/repos/marta-lokhova/stellar-core/stargazers","contributors_url":"https://api.github.com/repos/marta-lokhova/stellar-core/contributors","subscribers_url":"https://api.github.com/repos/marta-lokhova/stellar-core/subscribers","subscription_url":"https://api.github.com/repos/marta-lokhova/stellar-core/subscription","commits_url":"https://api.github.com/repos/marta-lokhova/stellar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/marta-lokhova/stellar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/marta-lokhova/stellar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/marta-lokhova/stellar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/marta-lokhova/stellar-core/contents/{+path}","compare_url":"https://api.github.com/repos/marta-lokhova/stellar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marta-lokhova/stellar-core/merges","archive_url":"https://api.github.com/repos/marta-lokhova/stellar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marta-lokhova/stellar-core/downloads","issues_url":"https://api.github.com/repos/marta-lokhova/stellar-core/issues{/number}","pulls_url":"https://api.github.com/repos/marta-lokhova/stellar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/marta-lokhova/stellar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/marta-lokhova/stellar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marta-lokhova/stellar-core/labels{/name}","releases_url":"https://api.github.com/repos/marta-lokhova/stellar-core/releases{/id}","deployments_url":"https://api.github.com/repos/marta-lokhova/stellar-core/deployments","created_at":"2018-02-02T23:38:31Z","updated_at":"2018-11-02T21:13:23Z","pushed_at":"2018-11-16T18:19:24Z","git_url":"git://github.com/marta-lokhova/stellar-core.git","ssh_url":"git@github.com:marta-lokhova/stellar-core.git","clone_url":"https://github.com/marta-lokhova/stellar-core.git","svn_url":"https://github.com/marta-lokhova/stellar-core","homepage":"","size":15580,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stellar:master","ref":"master","sha":"ce5e5d10c1b7fa2229292c0e3b5733a589c78246","user":{"login":"stellar","id":7386716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczODY3MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/7386716?v=4","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"repo":{"id":27085821,"node_id":"MDEwOlJlcG9zaXRvcnkyNzA4NTgyMQ==","name":"stellar-core","full_name":"stellar/stellar-core","private":false,"owner":{"login":"stellar","id":7386716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczODY3MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/7386716?v=4","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stellar/stellar-core","description":"stellar-core is the backbone of the Stellar network. It maintains a local copy of the ledger, communicating and staying in sync with other instances of stellar-core on the network. Optionally, stellar-core can store historical records of the ledger and participate in consensus.","fork":false,"url":"https://api.github.com/repos/stellar/stellar-core","forks_url":"https://api.github.com/repos/stellar/stellar-core/forks","keys_url":"https://api.github.com/repos/stellar/stellar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stellar/stellar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stellar/stellar-core/teams","hooks_url":"https://api.github.com/repos/stellar/stellar-core/hooks","issue_events_url":"https://api.github.com/repos/stellar/stellar-core/issues/events{/number}","events_url":"https://api.github.com/repos/stellar/stellar-core/events","assignees_url":"https://api.github.com/repos/stellar/stellar-core/assignees{/user}","branches_url":"https://api.github.com/repos/stellar/stellar-core/branches{/branch}","tags_url":"https://api.github.com/repos/stellar/stellar-core/tags","blobs_url":"https://api.github.com/repos/stellar/stellar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stellar/stellar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stellar/stellar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/stellar/stellar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stellar/stellar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/stellar/stellar-core/languages","stargazers_url":"https://api.github.com/repos/stellar/stellar-core/stargazers","contributors_url":"https://api.github.com/repos/stellar/stellar-core/contributors","subscribers_url":"https://api.github.com/repos/stellar/stellar-core/subscribers","subscription_url":"https://api.github.com/repos/stellar/stellar-core/subscription","commits_url":"https://api.github.com/repos/stellar/stellar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/stellar/stellar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/stellar/stellar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/stellar/stellar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/stellar/stellar-core/contents/{+path}","compare_url":"https://api.github.com/repos/stellar/stellar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stellar/stellar-core/merges","archive_url":"https://api.github.com/repos/stellar/stellar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stellar/stellar-core/downloads","issues_url":"https://api.github.com/repos/stellar/stellar-core/issues{/number}","pulls_url":"https://api.github.com/repos/stellar/stellar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/stellar/stellar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/stellar/stellar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stellar/stellar-core/labels{/name}","releases_url":"https://api.github.com/repos/stellar/stellar-core/releases{/id}","deployments_url":"https://api.github.com/repos/stellar/stellar-core/deployments","created_at":"2014-11-24T17:11:12Z","updated_at":"2018-11-19T07:42:54Z","pushed_at":"2018-11-17T05:48:12Z","git_url":"git://github.com/stellar/stellar-core.git","ssh_url":"git@github.com:stellar/stellar-core.git","clone_url":"https://github.com/stellar/stellar-core.git","svn_url":"https://github.com/stellar/stellar-core","homepage":"","size":15485,"stargazers_count":1859,"watchers_count":1859,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":545,"mirror_url":null,"archived":false,"open_issues_count":165,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":545,"open_issues":165,"watchers":1859,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/1711"},"html":{"href":"https://github.com/stellar/stellar-core/pull/1711"},"issue":{"href":"https://api.github.com/repos/stellar/stellar-core/issues/1711"},"comments":{"href":"https://api.github.com/repos/stellar/stellar-core/issues/1711/comments"},"review_comments":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/1711/comments"},"review_comment":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/1711/commits"},"statuses":{"href":"https://api.github.com/repos/stellar/stellar-core/statuses/59f9cc0f15350b048b7c92f0b84171d64b3e6b6b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"marta-lokhova"}}