{"action":"created","comment":{"url":"https://api.github.com/repos/Fiware/dataModels/pulls/comments/221952630","pull_request_review_id":160722880,"id":221952630,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTk1MjYzMA==","diff_hunk":"@@ -60,46 +61,46 @@ var openFile = function(filename, suffix) {\n module.exports = {\n \n   //compile schema without remote resolve\n-  compileSchema: function(fullPath, fileSchema, commonSchemas) {\n-    var file = path.join(fullPath, fileSchema);\n-    var schema = openFile(file, 'schema');\n-    var ajv = new Ajv(conf.ajvOptions);\n+  compileSchema(fullPath, fileSchema, commonSchemas) {\n+    const file = path.join(fullPath, fileSchema);\n+    const schema = openFile(file, 'schema');\n+    const ajv = new Ajv(conf.ajvOptions);\n     addSchemas(commonSchemas, ajv.addSchema, 'schema');\n-    var validate;\n+    let validate;\n     try {\n         validate = ajv.compile(schema);\n         /* istanbul ignore else */\n-        if (typeof validate == 'function') {\n+        if (typeof validate === 'function') {\n           debug(\"*compileSchema* - valid schema \" +file+ \" :\" +validate);\n           msg.addValidSchema(fullPath, 'Schema ' + file + ' is valid');\n         } else {\n           debug(\"*compileSchema* - invalid schema \" +file+ \" :\" +validate);\n           msg.addError(fullPath, 'Schema ' + file +\n             ' failed to compile to a function');\n-          if (conf.failErrors) throw new Error(validate.errors);\n+          if (conf.failErrors) {throw new Error(validate.errors);}","path":"validator/libs/schema.js","position":103,"original_position":103,"commit_id":"fd1347aa1c065c820d64b8f0a09b41a83972ea70","original_commit_id":"fd1347aa1c065c820d64b8f0a09b41a83972ea70","user":{"login":"chicco785","id":777218,"node_id":"MDQ6VXNlcjc3NzIxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/777218?v=4","gravatar_id":"","url":"https://api.github.com/users/chicco785","html_url":"https://github.com/chicco785","followers_url":"https://api.github.com/users/chicco785/followers","following_url":"https://api.github.com/users/chicco785/following{/other_user}","gists_url":"https://api.github.com/users/chicco785/gists{/gist_id}","starred_url":"https://api.github.com/users/chicco785/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chicco785/subscriptions","organizations_url":"https://api.github.com/users/chicco785/orgs","repos_url":"https://api.github.com/users/chicco785/repos","events_url":"https://api.github.com/users/chicco785/events{/privacy}","received_events_url":"https://api.github.com/users/chicco785/received_events","type":"User","site_admin":false},"body":"not sure i consider this linting :)","created_at":"2018-10-02T13:36:32Z","updated_at":"2018-10-02T13:36:32Z","html_url":"https://github.com/Fiware/dataModels/pull/294#discussion_r221952630","pull_request_url":"https://api.github.com/repos/Fiware/dataModels/pulls/294","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Fiware/dataModels/pulls/comments/221952630"},"html":{"href":"https://github.com/Fiware/dataModels/pull/294#discussion_r221952630"},"pull_request":{"href":"https://api.github.com/repos/Fiware/dataModels/pulls/294"}}},"pull_request":{"url":"https://api.github.com/repos/Fiware/dataModels/pulls/294","id":219692635,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NjkyNjM1","html_url":"https://github.com/Fiware/dataModels/pull/294","diff_url":"https://github.com/Fiware/dataModels/pull/294.diff","patch_url":"https://github.com/Fiware/dataModels/pull/294.patch","issue_url":"https://api.github.com/repos/Fiware/dataModels/issues/294","number":294,"state":"open","locked":false,"title":"Add prettier","user":{"login":"jason-fox","id":3439249,"node_id":"MDQ6VXNlcjM0MzkyNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/3439249?v=4","gravatar_id":"","url":"https://api.github.com/users/jason-fox","html_url":"https://github.com/jason-fox","followers_url":"https://api.github.com/users/jason-fox/followers","following_url":"https://api.github.com/users/jason-fox/following{/other_user}","gists_url":"https://api.github.com/users/jason-fox/gists{/gist_id}","starred_url":"https://api.github.com/users/jason-fox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason-fox/subscriptions","organizations_url":"https://api.github.com/users/jason-fox/orgs","repos_url":"https://api.github.com/users/jason-fox/repos","events_url":"https://api.github.com/users/jason-fox/events{/privacy}","received_events_url":"https://api.github.com/users/jason-fox/received_events","type":"User","site_admin":false},"body":"* Update `package.json` to use latest `dependencies` and add `devDependencies`.\r\n* Remove old config files\r\n* Update **travis-ci** - linter dependencies are now automatically installed as part `npm install`\r\n* Let **prettier** reformat the code.\r\n* Correct outstanding linting errors","created_at":"2018-10-02T12:54:11Z","updated_at":"2018-10-02T13:36:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3afa397ed25149cd16c42d4472c78accfa09dc49","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jmcanterafonseca","id":694782,"node_id":"MDQ6VXNlcjY5NDc4Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/694782?v=4","gravatar_id":"","url":"https://api.github.com/users/jmcanterafonseca","html_url":"https://github.com/jmcanterafonseca","followers_url":"https://api.github.com/users/jmcanterafonseca/followers","following_url":"https://api.github.com/users/jmcanterafonseca/following{/other_user}","gists_url":"https://api.github.com/users/jmcanterafonseca/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcanterafonseca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcanterafonseca/subscriptions","organizations_url":"https://api.github.com/users/jmcanterafonseca/orgs","repos_url":"https://api.github.com/users/jmcanterafonseca/repos","events_url":"https://api.github.com/users/jmcanterafonseca/events{/privacy}","received_events_url":"https://api.github.com/users/jmcanterafonseca/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Fiware/dataModels/pulls/294/commits","review_comments_url":"https://api.github.com/repos/Fiware/dataModels/pulls/294/comments","review_comment_url":"https://api.github.com/repos/Fiware/dataModels/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Fiware/dataModels/issues/294/comments","statuses_url":"https://api.github.com/repos/Fiware/dataModels/statuses/fd1347aa1c065c820d64b8f0a09b41a83972ea70","head":{"label":"jason-fox:feature/prettier","ref":"feature/prettier","sha":"fd1347aa1c065c820d64b8f0a09b41a83972ea70","user":{"login":"jason-fox","id":3439249,"node_id":"MDQ6VXNlcjM0MzkyNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/3439249?v=4","gravatar_id":"","url":"https://api.github.com/users/jason-fox","html_url":"https://github.com/jason-fox","followers_url":"https://api.github.com/users/jason-fox/followers","following_url":"https://api.github.com/users/jason-fox/following{/other_user}","gists_url":"https://api.github.com/users/jason-fox/gists{/gist_id}","starred_url":"https://api.github.com/users/jason-fox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason-fox/subscriptions","organizations_url":"https://api.github.com/users/jason-fox/orgs","repos_url":"https://api.github.com/users/jason-fox/repos","events_url":"https://api.github.com/users/jason-fox/events{/privacy}","received_events_url":"https://api.github.com/users/jason-fox/received_events","type":"User","site_admin":false},"repo":{"id":144863316,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ4NjMzMTY=","name":"dataModels","full_name":"jason-fox/dataModels","private":false,"owner":{"login":"jason-fox","id":3439249,"node_id":"MDQ6VXNlcjM0MzkyNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/3439249?v=4","gravatar_id":"","url":"https://api.github.com/users/jason-fox","html_url":"https://github.com/jason-fox","followers_url":"https://api.github.com/users/jason-fox/followers","following_url":"https://api.github.com/users/jason-fox/following{/other_user}","gists_url":"https://api.github.com/users/jason-fox/gists{/gist_id}","starred_url":"https://api.github.com/users/jason-fox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason-fox/subscriptions","organizations_url":"https://api.github.com/users/jason-fox/orgs","repos_url":"https://api.github.com/users/jason-fox/repos","events_url":"https://api.github.com/users/jason-fox/events{/privacy}","received_events_url":"https://api.github.com/users/jason-fox/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jason-fox/dataModels","description":"Code and specifications to support harmonized data models ","fork":true,"url":"https://api.github.com/repos/jason-fox/dataModels","forks_url":"https://api.github.com/repos/jason-fox/dataModels/forks","keys_url":"https://api.github.com/repos/jason-fox/dataModels/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jason-fox/dataModels/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jason-fox/dataModels/teams","hooks_url":"https://api.github.com/repos/jason-fox/dataModels/hooks","issue_events_url":"https://api.github.com/repos/jason-fox/dataModels/issues/events{/number}","events_url":"https://api.github.com/repos/jason-fox/dataModels/events","assignees_url":"https://api.github.com/repos/jason-fox/dataModels/assignees{/user}","branches_url":"https://api.github.com/repos/jason-fox/dataModels/branches{/branch}","tags_url":"https://api.github.com/repos/jason-fox/dataModels/tags","blobs_url":"https://api.github.com/repos/jason-fox/dataModels/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jason-fox/dataModels/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jason-fox/dataModels/git/refs{/sha}","trees_url":"https://api.github.com/repos/jason-fox/dataModels/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jason-fox/dataModels/statuses/{sha}","languages_url":"https://api.github.com/repos/jason-fox/dataModels/languages","stargazers_url":"https://api.github.com/repos/jason-fox/dataModels/stargazers","contributors_url":"https://api.github.com/repos/jason-fox/dataModels/contributors","subscribers_url":"https://api.github.com/repos/jason-fox/dataModels/subscribers","subscription_url":"https://api.github.com/repos/jason-fox/dataModels/subscription","commits_url":"https://api.github.com/repos/jason-fox/dataModels/commits{/sha}","git_commits_url":"https://api.github.com/repos/jason-fox/dataModels/git/commits{/sha}","comments_url":"https://api.github.com/repos/jason-fox/dataModels/comments{/number}","issue_comment_url":"https://api.github.com/repos/jason-fox/dataModels/issues/comments{/number}","contents_url":"https://api.github.com/repos/jason-fox/dataModels/contents/{+path}","compare_url":"https://api.github.com/repos/jason-fox/dataModels/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jason-fox/dataModels/merges","archive_url":"https://api.github.com/repos/jason-fox/dataModels/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jason-fox/dataModels/downloads","issues_url":"https://api.github.com/repos/jason-fox/dataModels/issues{/number}","pulls_url":"https://api.github.com/repos/jason-fox/dataModels/pulls{/number}","milestones_url":"https://api.github.com/repos/jason-fox/dataModels/milestones{/number}","notifications_url":"https://api.github.com/repos/jason-fox/dataModels/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jason-fox/dataModels/labels{/name}","releases_url":"https://api.github.com/repos/jason-fox/dataModels/releases{/id}","deployments_url":"https://api.github.com/repos/jason-fox/dataModels/deployments","created_at":"2018-08-15T14:27:03Z","updated_at":"2018-10-02T11:21:11Z","pushed_at":"2018-10-02T12:44:03Z","git_url":"git://github.com/jason-fox/dataModels.git","ssh_url":"git@github.com:jason-fox/dataModels.git","clone_url":"https://github.com/jason-fox/dataModels.git","svn_url":"https://github.com/jason-fox/dataModels","homepage":"http://schema.fiware.org","size":1957,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Fiware:master","ref":"master","sha":"5f849247055a2a47b90cf61588ade928da145434","user":{"login":"Fiware","id":5936803,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MzY4MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/5936803?v=4","gravatar_id":"","url":"https://api.github.com/users/Fiware","html_url":"https://github.com/Fiware","followers_url":"https://api.github.com/users/Fiware/followers","following_url":"https://api.github.com/users/Fiware/following{/other_user}","gists_url":"https://api.github.com/users/Fiware/gists{/gist_id}","starred_url":"https://api.github.com/users/Fiware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fiware/subscriptions","organizations_url":"https://api.github.com/users/Fiware/orgs","repos_url":"https://api.github.com/users/Fiware/repos","events_url":"https://api.github.com/users/Fiware/events{/privacy}","received_events_url":"https://api.github.com/users/Fiware/received_events","type":"Organization","site_admin":false},"repo":{"id":53853819,"node_id":"MDEwOlJlcG9zaXRvcnk1Mzg1MzgxOQ==","name":"dataModels","full_name":"Fiware/dataModels","private":false,"owner":{"login":"Fiware","id":5936803,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MzY4MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/5936803?v=4","gravatar_id":"","url":"https://api.github.com/users/Fiware","html_url":"https://github.com/Fiware","followers_url":"https://api.github.com/users/Fiware/followers","following_url":"https://api.github.com/users/Fiware/following{/other_user}","gists_url":"https://api.github.com/users/Fiware/gists{/gist_id}","starred_url":"https://api.github.com/users/Fiware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fiware/subscriptions","organizations_url":"https://api.github.com/users/Fiware/orgs","repos_url":"https://api.github.com/users/Fiware/repos","events_url":"https://api.github.com/users/Fiware/events{/privacy}","received_events_url":"https://api.github.com/users/Fiware/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Fiware/dataModels","description":"Code and specifications to support harmonized data models ","fork":false,"url":"https://api.github.com/repos/Fiware/dataModels","forks_url":"https://api.github.com/repos/Fiware/dataModels/forks","keys_url":"https://api.github.com/repos/Fiware/dataModels/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fiware/dataModels/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fiware/dataModels/teams","hooks_url":"https://api.github.com/repos/Fiware/dataModels/hooks","issue_events_url":"https://api.github.com/repos/Fiware/dataModels/issues/events{/number}","events_url":"https://api.github.com/repos/Fiware/dataModels/events","assignees_url":"https://api.github.com/repos/Fiware/dataModels/assignees{/user}","branches_url":"https://api.github.com/repos/Fiware/dataModels/branches{/branch}","tags_url":"https://api.github.com/repos/Fiware/dataModels/tags","blobs_url":"https://api.github.com/repos/Fiware/dataModels/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fiware/dataModels/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fiware/dataModels/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fiware/dataModels/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fiware/dataModels/statuses/{sha}","languages_url":"https://api.github.com/repos/Fiware/dataModels/languages","stargazers_url":"https://api.github.com/repos/Fiware/dataModels/stargazers","contributors_url":"https://api.github.com/repos/Fiware/dataModels/contributors","subscribers_url":"https://api.github.com/repos/Fiware/dataModels/subscribers","subscription_url":"https://api.github.com/repos/Fiware/dataModels/subscription","commits_url":"https://api.github.com/repos/Fiware/dataModels/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fiware/dataModels/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fiware/dataModels/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fiware/dataModels/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fiware/dataModels/contents/{+path}","compare_url":"https://api.github.com/repos/Fiware/dataModels/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fiware/dataModels/merges","archive_url":"https://api.github.com/repos/Fiware/dataModels/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fiware/dataModels/downloads","issues_url":"https://api.github.com/repos/Fiware/dataModels/issues{/number}","pulls_url":"https://api.github.com/repos/Fiware/dataModels/pulls{/number}","milestones_url":"https://api.github.com/repos/Fiware/dataModels/milestones{/number}","notifications_url":"https://api.github.com/repos/Fiware/dataModels/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fiware/dataModels/labels{/name}","releases_url":"https://api.github.com/repos/Fiware/dataModels/releases{/id}","deployments_url":"https://api.github.com/repos/Fiware/dataModels/deployments","created_at":"2016-03-14T12:19:01Z","updated_at":"2018-10-02T11:10:57Z","pushed_at":"2018-10-02T12:54:11Z","git_url":"git://github.com/Fiware/dataModels.git","ssh_url":"git@github.com:Fiware/dataModels.git","clone_url":"https://github.com/Fiware/dataModels.git","svn_url":"https://github.com/Fiware/dataModels","homepage":"http://schema.fiware.org","size":1957,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":49,"open_issues":43,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Fiware/dataModels/pulls/294"},"html":{"href":"https://github.com/Fiware/dataModels/pull/294"},"issue":{"href":"https://api.github.com/repos/Fiware/dataModels/issues/294"},"comments":{"href":"https://api.github.com/repos/Fiware/dataModels/issues/294/comments"},"review_comments":{"href":"https://api.github.com/repos/Fiware/dataModels/pulls/294/comments"},"review_comment":{"href":"https://api.github.com/repos/Fiware/dataModels/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Fiware/dataModels/pulls/294/commits"},"statuses":{"href":"https://api.github.com/repos/Fiware/dataModels/statuses/fd1347aa1c065c820d64b8f0a09b41a83972ea70"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chicco785"}}