{"action":"created","issue":{"url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/6539","repository_url":"https://api.github.com/repos/salesagility/SuiteCRM","labels_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/6539/labels{/name}","comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/6539/comments","events_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/6539/events","html_url":"https://github.com/salesagility/SuiteCRM/pull/6539","id":384996041,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MDY3OTk0","number":6539,"title":"Cleanup, Refactoring, and Bug Fixes for Google Sync","user":{"login":"ApatheticCosmos","id":16560296,"node_id":"MDQ6VXNlcjE2NTYwMjk2","avatar_url":"https://avatars3.githubusercontent.com/u/16560296?v=4","gravatar_id":"","url":"https://api.github.com/users/ApatheticCosmos","html_url":"https://github.com/ApatheticCosmos","followers_url":"https://api.github.com/users/ApatheticCosmos/followers","following_url":"https://api.github.com/users/ApatheticCosmos/following{/other_user}","gists_url":"https://api.github.com/users/ApatheticCosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/ApatheticCosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ApatheticCosmos/subscriptions","organizations_url":"https://api.github.com/users/ApatheticCosmos/orgs","repos_url":"https://api.github.com/users/ApatheticCosmos/repos","events_url":"https://api.github.com/users/ApatheticCosmos/events{/privacy}","received_events_url":"https://api.github.com/users/ApatheticCosmos/received_events","type":"User","site_admin":false},"labels":[{"id":1148555079,"node_id":"MDU6TGFiZWwxMTQ4NTU1MDc5","url":"https://api.github.com/repos/salesagility/SuiteCRM/labels/Community%20Contribution","name":"Community Contribution","color":"108bb5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-11-27T21:34:50Z","updated_at":"2018-12-17T13:47:00Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/6539","html_url":"https://github.com/salesagility/SuiteCRM/pull/6539","diff_url":"https://github.com/salesagility/SuiteCRM/pull/6539.diff","patch_url":"https://github.com/salesagility/SuiteCRM/pull/6539.patch"},"body":"A continuation of #6146 \r\nRefactored and broke up some functions. Fixed some bugs.\r\nFollowed review suggestions from @gymad\r\nThis work will be included in 7.11\r\n\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\nThis isn't finished yet, but I wanted to get this PR out so we can start collaborating on it.\r\n<!--- Describe your changes in detail -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here unless your commit contains the issue number -->\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n\r\n## How To Test This\r\n<!--- Please describe in detail how to test your changes. -->\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [X] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n### Final checklist\r\n<!--- Go over all the following points and check all the boxes that apply. --->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --->\r\n- [X] My code follows the code style of this project found [here](https://docs.suitecrm.com/community/contributing-code/coding-standards/).\r\n- [ ] My change requires a change to the documentation.\r\n- [x] I have read the [**How to Contribute**](https://docs.suitecrm.com/community/contributing-code/) guidelines.\r\n\r\n<!--- Your pull request will be tested via Travis CI to automatically indicate that your changes do not prevent compilation. --->\r\n\r\n<!--- If it reports back that there are problems, you can log into the Travis system and check the log report for your pull request to see what the problem was. --->"},"comment":{"url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/comments/447850978","html_url":"https://github.com/salesagility/SuiteCRM/pull/6539#issuecomment-447850978","issue_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/6539","id":447850978,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Nzg1MDk3OA==","user":{"login":"ApatheticCosmos","id":16560296,"node_id":"MDQ6VXNlcjE2NTYwMjk2","avatar_url":"https://avatars3.githubusercontent.com/u/16560296?v=4","gravatar_id":"","url":"https://api.github.com/users/ApatheticCosmos","html_url":"https://github.com/ApatheticCosmos","followers_url":"https://api.github.com/users/ApatheticCosmos/followers","following_url":"https://api.github.com/users/ApatheticCosmos/following{/other_user}","gists_url":"https://api.github.com/users/ApatheticCosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/ApatheticCosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ApatheticCosmos/subscriptions","organizations_url":"https://api.github.com/users/ApatheticCosmos/orgs","repos_url":"https://api.github.com/users/ApatheticCosmos/repos","events_url":"https://api.github.com/users/ApatheticCosmos/events{/privacy}","received_events_url":"https://api.github.com/users/ApatheticCosmos/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T13:47:00Z","updated_at":"2018-12-17T13:47:00Z","author_association":"CONTRIBUTOR","body":"> Code looks much better, only a test failing at this moment.\r\n@gymad I'm trying to figure out why this test is failing:\r\n`1) GoogleSyncTest: Set sync users\r\n Test  tests/unit/include/GoogleSync/GoogleSyncTest.php:testSetSyncUsers\r\nFailed asserting that 0 is equal to 2 or is greater than 2.\r\n#1  /home/travis/build/salesagility/SuiteCRM/tests/unit/include/GoogleSync/GoogleSyncTest.php:879\r\n#2  GoogleSyncTest->testSetSyncUsers`\r\n\r\nIt passes when I run it locally, and I've made sure that the users it's counting are the ones added by the test. Yet when Travis runs it, it fails. It sees zero users. Is there something I don't understand about the Travis environment?\r\n\r\n"}}
{"actor":{"display_login":"ApatheticCosmos"}}