{"action":"created","comment":{"url":"https://api.github.com/repos/istio/proxy/pulls/comments/173515035","pull_request_review_id":102725228,"id":173515035,"diff_hunk":"@@ -120,9 +119,9 @@ class OriginAuthenticatorTest : public testing::TestWithParam<bool> {\n \n  protected:\n   std::unique_ptr<StrictMock<MockAuthenticator>> authenticator_;\n-  StrictMock<TestUtilities::MockFilterContext> filter_context_;\n   StrictMock<MockFunction<void(bool)>> on_done_callback_;\n   Http::TestHeaderMapImpl request_headers_;\n+  StrictMock<FilterContext> filter_context_{&request_headers_, nullptr};","path":"src/envoy/http/authn/origin_authenticator_test.cc","position":null,"original_position":15,"commit_id":"b4d56cce972b559c6a2fd82426ff8f8a7df4af4f","original_commit_id":"673969d083a9db0601e66a0d3e6707736d8b4f32","user":{"login":"qiwzhang","id":11790727,"avatar_url":"https://avatars0.githubusercontent.com/u/11790727?v=4","gravatar_id":"","url":"https://api.github.com/users/qiwzhang","html_url":"https://github.com/qiwzhang","followers_url":"https://api.github.com/users/qiwzhang/followers","following_url":"https://api.github.com/users/qiwzhang/following{/other_user}","gists_url":"https://api.github.com/users/qiwzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiwzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiwzhang/subscriptions","organizations_url":"https://api.github.com/users/qiwzhang/orgs","repos_url":"https://api.github.com/users/qiwzhang/repos","events_url":"https://api.github.com/users/qiwzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qiwzhang/received_events","type":"User","site_admin":false},"body":"I don't think you are mocking FilterContext. ","created_at":"2018-03-09T17:29:05Z","updated_at":"2018-03-09T17:45:06Z","html_url":"https://github.com/istio/proxy/pull/1171#discussion_r173515035","pull_request_url":"https://api.github.com/repos/istio/proxy/pulls/1171","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/istio/proxy/pulls/comments/173515035"},"html":{"href":"https://github.com/istio/proxy/pull/1171#discussion_r173515035"},"pull_request":{"href":"https://api.github.com/repos/istio/proxy/pulls/1171"}}},"pull_request":{"url":"https://api.github.com/repos/istio/proxy/pulls/1171","id":171550279,"html_url":"https://github.com/istio/proxy/pull/1171","diff_url":"https://github.com/istio/proxy/pull/1171.diff","patch_url":"https://github.com/istio/proxy/pull/1171.patch","issue_url":"https://api.github.com/repos/istio/proxy/issues/1171","number":1171,"state":"open","locked":false,"title":"Boilerplate for istio authn filter.","user":{"login":"diemtvu","id":25132401,"avatar_url":"https://avatars0.githubusercontent.com/u/25132401?v=4","gravatar_id":"","url":"https://api.github.com/users/diemtvu","html_url":"https://github.com/diemtvu","followers_url":"https://api.github.com/users/diemtvu/followers","following_url":"https://api.github.com/users/diemtvu/following{/other_user}","gists_url":"https://api.github.com/users/diemtvu/gists{/gist_id}","starred_url":"https://api.github.com/users/diemtvu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diemtvu/subscriptions","organizations_url":"https://api.github.com/users/diemtvu/orgs","repos_url":"https://api.github.com/users/diemtvu/repos","events_url":"https://api.github.com/users/diemtvu/events{/privacy}","received_events_url":"https://api.github.com/users/diemtvu/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\n\r\nHigh level implementation for istio authN filter. The filter is setup to run each (applicable) authentication method in 'sequence', but each method could have remote/asynchronous call(s).\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\nNONE\r\n","created_at":"2018-02-27T02:51:24Z","updated_at":"2018-03-09T17:45:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9368f13fee40a7c9b3d3c655df5c0e6da3c29002","assignee":{"login":"lizan","id":1016047,"avatar_url":"https://avatars1.githubusercontent.com/u/1016047?v=4","gravatar_id":"","url":"https://api.github.com/users/lizan","html_url":"https://github.com/lizan","followers_url":"https://api.github.com/users/lizan/followers","following_url":"https://api.github.com/users/lizan/following{/other_user}","gists_url":"https://api.github.com/users/lizan/gists{/gist_id}","starred_url":"https://api.github.com/users/lizan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizan/subscriptions","organizations_url":"https://api.github.com/users/lizan/orgs","repos_url":"https://api.github.com/users/lizan/repos","events_url":"https://api.github.com/users/lizan/events{/privacy}","received_events_url":"https://api.github.com/users/lizan/received_events","type":"User","site_admin":false},"assignees":[{"login":"lizan","id":1016047,"avatar_url":"https://avatars1.githubusercontent.com/u/1016047?v=4","gravatar_id":"","url":"https://api.github.com/users/lizan","html_url":"https://github.com/lizan","followers_url":"https://api.github.com/users/lizan/followers","following_url":"https://api.github.com/users/lizan/following{/other_user}","gists_url":"https://api.github.com/users/lizan/gists{/gist_id}","starred_url":"https://api.github.com/users/lizan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizan/subscriptions","organizations_url":"https://api.github.com/users/lizan/orgs","repos_url":"https://api.github.com/users/lizan/repos","events_url":"https://api.github.com/users/lizan/events{/privacy}","received_events_url":"https://api.github.com/users/lizan/received_events","type":"User","site_admin":false},{"login":"qiwzhang","id":11790727,"avatar_url":"https://avatars0.githubusercontent.com/u/11790727?v=4","gravatar_id":"","url":"https://api.github.com/users/qiwzhang","html_url":"https://github.com/qiwzhang","followers_url":"https://api.github.com/users/qiwzhang/followers","following_url":"https://api.github.com/users/qiwzhang/following{/other_user}","gists_url":"https://api.github.com/users/qiwzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/qiwzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiwzhang/subscriptions","organizations_url":"https://api.github.com/users/qiwzhang/orgs","repos_url":"https://api.github.com/users/qiwzhang/repos","events_url":"https://api.github.com/users/qiwzhang/events{/privacy}","received_events_url":"https://api.github.com/users/qiwzhang/received_events","type":"User","site_admin":false},{"login":"lei-tang","id":32078630,"avatar_url":"https://avatars1.githubusercontent.com/u/32078630?v=4","gravatar_id":"","url":"https://api.github.com/users/lei-tang","html_url":"https://github.com/lei-tang","followers_url":"https://api.github.com/users/lei-tang/followers","following_url":"https://api.github.com/users/lei-tang/following{/other_user}","gists_url":"https://api.github.com/users/lei-tang/gists{/gist_id}","starred_url":"https://api.github.com/users/lei-tang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lei-tang/subscriptions","organizations_url":"https://api.github.com/users/lei-tang/orgs","repos_url":"https://api.github.com/users/lei-tang/repos","events_url":"https://api.github.com/users/lei-tang/events{/privacy}","received_events_url":"https://api.github.com/users/lei-tang/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":712050392,"url":"https://api.github.com/repos/istio/proxy/labels/cla:%20yes","name":"cla: yes","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/proxy/pulls/1171/commits","review_comments_url":"https://api.github.com/repos/istio/proxy/pulls/1171/comments","review_comment_url":"https://api.github.com/repos/istio/proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/proxy/issues/1171/comments","statuses_url":"https://api.github.com/repos/istio/proxy/statuses/b4d56cce972b559c6a2fd82426ff8f8a7df4af4f","head":{"label":"diemtvu:authn","ref":"authn","sha":"b4d56cce972b559c6a2fd82426ff8f8a7df4af4f","user":{"login":"diemtvu","id":25132401,"avatar_url":"https://avatars0.githubusercontent.com/u/25132401?v=4","gravatar_id":"","url":"https://api.github.com/users/diemtvu","html_url":"https://github.com/diemtvu","followers_url":"https://api.github.com/users/diemtvu/followers","following_url":"https://api.github.com/users/diemtvu/following{/other_user}","gists_url":"https://api.github.com/users/diemtvu/gists{/gist_id}","starred_url":"https://api.github.com/users/diemtvu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diemtvu/subscriptions","organizations_url":"https://api.github.com/users/diemtvu/orgs","repos_url":"https://api.github.com/users/diemtvu/repos","events_url":"https://api.github.com/users/diemtvu/events{/privacy}","received_events_url":"https://api.github.com/users/diemtvu/received_events","type":"User","site_admin":false},"repo":{"id":103309423,"name":"proxy","full_name":"diemtvu/proxy","owner":{"login":"diemtvu","id":25132401,"avatar_url":"https://avatars0.githubusercontent.com/u/25132401?v=4","gravatar_id":"","url":"https://api.github.com/users/diemtvu","html_url":"https://github.com/diemtvu","followers_url":"https://api.github.com/users/diemtvu/followers","following_url":"https://api.github.com/users/diemtvu/following{/other_user}","gists_url":"https://api.github.com/users/diemtvu/gists{/gist_id}","starred_url":"https://api.github.com/users/diemtvu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diemtvu/subscriptions","organizations_url":"https://api.github.com/users/diemtvu/orgs","repos_url":"https://api.github.com/users/diemtvu/repos","events_url":"https://api.github.com/users/diemtvu/events{/privacy}","received_events_url":"https://api.github.com/users/diemtvu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diemtvu/proxy","description":"The Istio proxy components.","fork":true,"url":"https://api.github.com/repos/diemtvu/proxy","forks_url":"https://api.github.com/repos/diemtvu/proxy/forks","keys_url":"https://api.github.com/repos/diemtvu/proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diemtvu/proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diemtvu/proxy/teams","hooks_url":"https://api.github.com/repos/diemtvu/proxy/hooks","issue_events_url":"https://api.github.com/repos/diemtvu/proxy/issues/events{/number}","events_url":"https://api.github.com/repos/diemtvu/proxy/events","assignees_url":"https://api.github.com/repos/diemtvu/proxy/assignees{/user}","branches_url":"https://api.github.com/repos/diemtvu/proxy/branches{/branch}","tags_url":"https://api.github.com/repos/diemtvu/proxy/tags","blobs_url":"https://api.github.com/repos/diemtvu/proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diemtvu/proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diemtvu/proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/diemtvu/proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diemtvu/proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/diemtvu/proxy/languages","stargazers_url":"https://api.github.com/repos/diemtvu/proxy/stargazers","contributors_url":"https://api.github.com/repos/diemtvu/proxy/contributors","subscribers_url":"https://api.github.com/repos/diemtvu/proxy/subscribers","subscription_url":"https://api.github.com/repos/diemtvu/proxy/subscription","commits_url":"https://api.github.com/repos/diemtvu/proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/diemtvu/proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/diemtvu/proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/diemtvu/proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/diemtvu/proxy/contents/{+path}","compare_url":"https://api.github.com/repos/diemtvu/proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diemtvu/proxy/merges","archive_url":"https://api.github.com/repos/diemtvu/proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diemtvu/proxy/downloads","issues_url":"https://api.github.com/repos/diemtvu/proxy/issues{/number}","pulls_url":"https://api.github.com/repos/diemtvu/proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/diemtvu/proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/diemtvu/proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diemtvu/proxy/labels{/name}","releases_url":"https://api.github.com/repos/diemtvu/proxy/releases{/id}","deployments_url":"https://api.github.com/repos/diemtvu/proxy/deployments","created_at":"2017-09-12T18:57:50Z","updated_at":"2017-09-12T18:57:52Z","pushed_at":"2018-03-09T04:48:10Z","git_url":"git://github.com/diemtvu/proxy.git","ssh_url":"git@github.com:diemtvu/proxy.git","clone_url":"https://github.com/diemtvu/proxy.git","svn_url":"https://github.com/diemtvu/proxy","homepage":"","size":2235,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"e442dbdebd3e5645564030d100cb9eb04996d618","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":75322405,"name":"proxy","full_name":"istio/proxy","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/proxy","description":"The Istio proxy components.","fork":false,"url":"https://api.github.com/repos/istio/proxy","forks_url":"https://api.github.com/repos/istio/proxy/forks","keys_url":"https://api.github.com/repos/istio/proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/proxy/teams","hooks_url":"https://api.github.com/repos/istio/proxy/hooks","issue_events_url":"https://api.github.com/repos/istio/proxy/issues/events{/number}","events_url":"https://api.github.com/repos/istio/proxy/events","assignees_url":"https://api.github.com/repos/istio/proxy/assignees{/user}","branches_url":"https://api.github.com/repos/istio/proxy/branches{/branch}","tags_url":"https://api.github.com/repos/istio/proxy/tags","blobs_url":"https://api.github.com/repos/istio/proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/proxy/languages","stargazers_url":"https://api.github.com/repos/istio/proxy/stargazers","contributors_url":"https://api.github.com/repos/istio/proxy/contributors","subscribers_url":"https://api.github.com/repos/istio/proxy/subscribers","subscription_url":"https://api.github.com/repos/istio/proxy/subscription","commits_url":"https://api.github.com/repos/istio/proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/proxy/contents/{+path}","compare_url":"https://api.github.com/repos/istio/proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/proxy/merges","archive_url":"https://api.github.com/repos/istio/proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/proxy/downloads","issues_url":"https://api.github.com/repos/istio/proxy/issues{/number}","pulls_url":"https://api.github.com/repos/istio/proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/proxy/labels{/name}","releases_url":"https://api.github.com/repos/istio/proxy/releases{/id}","deployments_url":"https://api.github.com/repos/istio/proxy/deployments","created_at":"2016-12-01T18:51:04Z","updated_at":"2018-03-06T09:02:10Z","pushed_at":"2018-03-09T04:48:12Z","git_url":"git://github.com/istio/proxy.git","ssh_url":"git@github.com:istio/proxy.git","clone_url":"https://github.com/istio/proxy.git","svn_url":"https://github.com/istio/proxy","homepage":"","size":2184,"stargazers_count":111,"watchers_count":111,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":82,"open_issues":31,"watchers":111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/proxy/pulls/1171"},"html":{"href":"https://github.com/istio/proxy/pull/1171"},"issue":{"href":"https://api.github.com/repos/istio/proxy/issues/1171"},"comments":{"href":"https://api.github.com/repos/istio/proxy/issues/1171/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/proxy/pulls/1171/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/proxy/pulls/1171/commits"},"statuses":{"href":"https://api.github.com/repos/istio/proxy/statuses/b4d56cce972b559c6a2fd82426ff8f8a7df4af4f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"qiwzhang"}}