{"action":"created","comment":{"url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments/188287252","pull_request_review_id":120230932,"id":188287252,"diff_hunk":"@@ -162,7 +162,12 @@ dlgProfilePreferences::dlgProfilePreferences(QWidget* pF, Host* pHost)\n                                                                      \"does not have a needed glyph (a font's individual character/symbol) to represent \"\n                                                                      \"the grapheme (what is to be represented).  Clearing this checkbox will allow \"\n                                                                      \"the best alternative glyph from another font to be used to draw that grapheme.</p>\")));\n-\n+    checkBox_runAllKeyBindings->setToolTip(QStringLiteral(\"<html><head/><body>%1</body></html>\")\n+                                           .arg(tr(\"<p>Check all Key-bindings against key-presses.</p><p><i>Versions of Mudlet prior to <b>3.9.0</b> would \"","path":"src/dlgProfilePreferences.cpp","position":6,"original_position":6,"commit_id":"400e6c0d75d7625057aa290a83ce58adb206da93","original_commit_id":"400e6c0d75d7625057aa290a83ce58adb206da93","user":{"login":"vadi2","id":110988,"avatar_url":"https://avatars1.githubusercontent.com/u/110988?v=4","gravatar_id":"","url":"https://api.github.com/users/vadi2","html_url":"https://github.com/vadi2","followers_url":"https://api.github.com/users/vadi2/followers","following_url":"https://api.github.com/users/vadi2/following{/other_user}","gists_url":"https://api.github.com/users/vadi2/gists{/gist_id}","starred_url":"https://api.github.com/users/vadi2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadi2/subscriptions","organizations_url":"https://api.github.com/users/vadi2/orgs","repos_url":"https://api.github.com/users/vadi2/repos","events_url":"https://api.github.com/users/vadi2/events{/privacy}","received_events_url":"https://api.github.com/users/vadi2/received_events","type":"User","site_admin":false},"body":"Don't need to load users with history. I'd have the option itself be called:\r\n\r\n> Allow duplicate keybindings\r\n\r\nTooltip:\r\n\r\n> Allow multiple keys to match on the same combination. With this off, the only the first keybinding that matches will run","created_at":"2018-05-15T13:31:52Z","updated_at":"2018-05-15T13:33:58Z","html_url":"https://github.com/Mudlet/Mudlet/pull/1656#discussion_r188287252","pull_request_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1656","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments/188287252"},"html":{"href":"https://github.com/Mudlet/Mudlet/pull/1656#discussion_r188287252"},"pull_request":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1656"}}},"pull_request":{"url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1656","id":187365134,"html_url":"https://github.com/Mudlet/Mudlet/pull/1656","diff_url":"https://github.com/Mudlet/Mudlet/pull/1656.diff","patch_url":"https://github.com/Mudlet/Mudlet/pull/1656.patch","issue_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/1656","number":1656,"state":"open","locked":false,"title":"Enhance: add option to allow all Key-bindings that match key-press to run","user":{"login":"SlySven","id":6163092,"avatar_url":"https://avatars3.githubusercontent.com/u/6163092?v=4","gravatar_id":"","url":"https://api.github.com/users/SlySven","html_url":"https://github.com/SlySven","followers_url":"https://api.github.com/users/SlySven/followers","following_url":"https://api.github.com/users/SlySven/following{/other_user}","gists_url":"https://api.github.com/users/SlySven/gists{/gist_id}","starred_url":"https://api.github.com/users/SlySven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlySven/subscriptions","organizations_url":"https://api.github.com/users/SlySven/orgs","repos_url":"https://api.github.com/users/SlySven/repos","events_url":"https://api.github.com/users/SlySven/events{/privacy}","received_events_url":"https://api.github.com/users/SlySven/received_events","type":"User","site_admin":false},"body":"I had previously spotted that the process that checks for a key-binding match on each key-press stops after the first match is found and run. This is, IMHO, counter-intuitive given Mudlet's behaviour with other \"duplicated\" items which it permits to exist - i.e. two triggers set to match on the same text or two timers with the same interval; it is even more suspect when one considers that it is possible to create a temporary key-binding, which although active, may never get run if there happens to be a permanent one with the same key and modifiers combination.  Actually it is also possible that the reverse is true in that a temporary key binding - which is not visible in the GUI editor - can prevent a permanent one that is shown there from activating - with no visible indication that this is occurring!\r\n\r\nAnyhow, this commit adds a per-profile option on the \"Input Line\" tab of the profile preferences dialogue to check every key-binding for a match instead of stopping on the first match.  To maintain backwards\r\ncompatibility with scripts/packages/modules that depend on the previous behaviour this option is not enabled by default.\r\n\r\nSigned-off-by: Stephen Lyons <slysven@virginmedia.com>\r\n\r\n#### Other info (issues closed, discussion etc)\r\n\r\nThis addresses an issue I remark upon in #1643.","created_at":"2018-05-11T04:33:21Z","updated_at":"2018-05-15T13:33:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5efb4a6713a6d5b0b1c53f82e48ca438118e37fd","assignee":{"login":"vadi2","id":110988,"avatar_url":"https://avatars1.githubusercontent.com/u/110988?v=4","gravatar_id":"","url":"https://api.github.com/users/vadi2","html_url":"https://github.com/vadi2","followers_url":"https://api.github.com/users/vadi2/followers","following_url":"https://api.github.com/users/vadi2/following{/other_user}","gists_url":"https://api.github.com/users/vadi2/gists{/gist_id}","starred_url":"https://api.github.com/users/vadi2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadi2/subscriptions","organizations_url":"https://api.github.com/users/vadi2/orgs","repos_url":"https://api.github.com/users/vadi2/repos","events_url":"https://api.github.com/users/vadi2/events{/privacy}","received_events_url":"https://api.github.com/users/vadi2/received_events","type":"User","site_admin":false},"assignees":[{"login":"vadi2","id":110988,"avatar_url":"https://avatars1.githubusercontent.com/u/110988?v=4","gravatar_id":"","url":"https://api.github.com/users/vadi2","html_url":"https://github.com/vadi2","followers_url":"https://api.github.com/users/vadi2/followers","following_url":"https://api.github.com/users/vadi2/following{/other_user}","gists_url":"https://api.github.com/users/vadi2/gists{/gist_id}","starred_url":"https://api.github.com/users/vadi2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadi2/subscriptions","organizations_url":"https://api.github.com/users/vadi2/orgs","repos_url":"https://api.github.com/users/vadi2/repos","events_url":"https://api.github.com/users/vadi2/events{/privacy}","received_events_url":"https://api.github.com/users/vadi2/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":119740317,"url":"https://api.github.com/repos/Mudlet/Mudlet/labels/1%20-%20Ready%20for%20review","name":"1 - Ready for review","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1656/commits","review_comments_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1656/comments","review_comment_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/1656/comments","statuses_url":"https://api.github.com/repos/Mudlet/Mudlet/statuses/400e6c0d75d7625057aa290a83ce58adb206da93","head":{"label":"SlySven:Enhance_addOptionToAllowAllKeyBindingsThatMatchKeyPressToRun","ref":"Enhance_addOptionToAllowAllKeyBindingsThatMatchKeyPressToRun","sha":"400e6c0d75d7625057aa290a83ce58adb206da93","user":{"login":"SlySven","id":6163092,"avatar_url":"https://avatars3.githubusercontent.com/u/6163092?v=4","gravatar_id":"","url":"https://api.github.com/users/SlySven","html_url":"https://github.com/SlySven","followers_url":"https://api.github.com/users/SlySven/followers","following_url":"https://api.github.com/users/SlySven/following{/other_user}","gists_url":"https://api.github.com/users/SlySven/gists{/gist_id}","starred_url":"https://api.github.com/users/SlySven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlySven/subscriptions","organizations_url":"https://api.github.com/users/SlySven/orgs","repos_url":"https://api.github.com/users/SlySven/repos","events_url":"https://api.github.com/users/SlySven/events{/privacy}","received_events_url":"https://api.github.com/users/SlySven/received_events","type":"User","site_admin":false},"repo":{"id":22490921,"name":"Mudlet","full_name":"SlySven/Mudlet","owner":{"login":"SlySven","id":6163092,"avatar_url":"https://avatars3.githubusercontent.com/u/6163092?v=4","gravatar_id":"","url":"https://api.github.com/users/SlySven","html_url":"https://github.com/SlySven","followers_url":"https://api.github.com/users/SlySven/followers","following_url":"https://api.github.com/users/SlySven/following{/other_user}","gists_url":"https://api.github.com/users/SlySven/gists{/gist_id}","starred_url":"https://api.github.com/users/SlySven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlySven/subscriptions","organizations_url":"https://api.github.com/users/SlySven/orgs","repos_url":"https://api.github.com/users/SlySven/repos","events_url":"https://api.github.com/users/SlySven/events{/privacy}","received_events_url":"https://api.github.com/users/SlySven/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SlySven/Mudlet","description":"A modern open source MUD client with a graphical user inteface and full built in Lua scripting support for all major platforms.","fork":true,"url":"https://api.github.com/repos/SlySven/Mudlet","forks_url":"https://api.github.com/repos/SlySven/Mudlet/forks","keys_url":"https://api.github.com/repos/SlySven/Mudlet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SlySven/Mudlet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SlySven/Mudlet/teams","hooks_url":"https://api.github.com/repos/SlySven/Mudlet/hooks","issue_events_url":"https://api.github.com/repos/SlySven/Mudlet/issues/events{/number}","events_url":"https://api.github.com/repos/SlySven/Mudlet/events","assignees_url":"https://api.github.com/repos/SlySven/Mudlet/assignees{/user}","branches_url":"https://api.github.com/repos/SlySven/Mudlet/branches{/branch}","tags_url":"https://api.github.com/repos/SlySven/Mudlet/tags","blobs_url":"https://api.github.com/repos/SlySven/Mudlet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SlySven/Mudlet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SlySven/Mudlet/git/refs{/sha}","trees_url":"https://api.github.com/repos/SlySven/Mudlet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SlySven/Mudlet/statuses/{sha}","languages_url":"https://api.github.com/repos/SlySven/Mudlet/languages","stargazers_url":"https://api.github.com/repos/SlySven/Mudlet/stargazers","contributors_url":"https://api.github.com/repos/SlySven/Mudlet/contributors","subscribers_url":"https://api.github.com/repos/SlySven/Mudlet/subscribers","subscription_url":"https://api.github.com/repos/SlySven/Mudlet/subscription","commits_url":"https://api.github.com/repos/SlySven/Mudlet/commits{/sha}","git_commits_url":"https://api.github.com/repos/SlySven/Mudlet/git/commits{/sha}","comments_url":"https://api.github.com/repos/SlySven/Mudlet/comments{/number}","issue_comment_url":"https://api.github.com/repos/SlySven/Mudlet/issues/comments{/number}","contents_url":"https://api.github.com/repos/SlySven/Mudlet/contents/{+path}","compare_url":"https://api.github.com/repos/SlySven/Mudlet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SlySven/Mudlet/merges","archive_url":"https://api.github.com/repos/SlySven/Mudlet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SlySven/Mudlet/downloads","issues_url":"https://api.github.com/repos/SlySven/Mudlet/issues{/number}","pulls_url":"https://api.github.com/repos/SlySven/Mudlet/pulls{/number}","milestones_url":"https://api.github.com/repos/SlySven/Mudlet/milestones{/number}","notifications_url":"https://api.github.com/repos/SlySven/Mudlet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SlySven/Mudlet/labels{/name}","releases_url":"https://api.github.com/repos/SlySven/Mudlet/releases{/id}","deployments_url":"https://api.github.com/repos/SlySven/Mudlet/deployments","created_at":"2014-08-01T01:05:26Z","updated_at":"2018-05-12T00:23:12Z","pushed_at":"2018-05-13T17:12:07Z","git_url":"git://github.com/SlySven/Mudlet.git","ssh_url":"git@github.com:SlySven/Mudlet.git","clone_url":"https://github.com/SlySven/Mudlet.git","svn_url":"https://github.com/SlySven/Mudlet","homepage":null,"size":33402,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1,"open_issues":2,"watchers":2,"default_branch":"development"}},"base":{"label":"Mudlet:development","ref":"development","sha":"6c77d69b6e88a6085c8f337ca961f8c28023c031","user":{"login":"Mudlet","id":6158612,"avatar_url":"https://avatars3.githubusercontent.com/u/6158612?v=4","gravatar_id":"","url":"https://api.github.com/users/Mudlet","html_url":"https://github.com/Mudlet","followers_url":"https://api.github.com/users/Mudlet/followers","following_url":"https://api.github.com/users/Mudlet/following{/other_user}","gists_url":"https://api.github.com/users/Mudlet/gists{/gist_id}","starred_url":"https://api.github.com/users/Mudlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mudlet/subscriptions","organizations_url":"https://api.github.com/users/Mudlet/orgs","repos_url":"https://api.github.com/users/Mudlet/repos","events_url":"https://api.github.com/users/Mudlet/events{/privacy}","received_events_url":"https://api.github.com/users/Mudlet/received_events","type":"Organization","site_admin":false},"repo":{"id":15108812,"name":"Mudlet","full_name":"Mudlet/Mudlet","owner":{"login":"Mudlet","id":6158612,"avatar_url":"https://avatars3.githubusercontent.com/u/6158612?v=4","gravatar_id":"","url":"https://api.github.com/users/Mudlet","html_url":"https://github.com/Mudlet","followers_url":"https://api.github.com/users/Mudlet/followers","following_url":"https://api.github.com/users/Mudlet/following{/other_user}","gists_url":"https://api.github.com/users/Mudlet/gists{/gist_id}","starred_url":"https://api.github.com/users/Mudlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mudlet/subscriptions","organizations_url":"https://api.github.com/users/Mudlet/orgs","repos_url":"https://api.github.com/users/Mudlet/repos","events_url":"https://api.github.com/users/Mudlet/events{/privacy}","received_events_url":"https://api.github.com/users/Mudlet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Mudlet/Mudlet","description":"A cross-platform, open source, and super fast MUD client with scripting in Lua","fork":false,"url":"https://api.github.com/repos/Mudlet/Mudlet","forks_url":"https://api.github.com/repos/Mudlet/Mudlet/forks","keys_url":"https://api.github.com/repos/Mudlet/Mudlet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mudlet/Mudlet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mudlet/Mudlet/teams","hooks_url":"https://api.github.com/repos/Mudlet/Mudlet/hooks","issue_events_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/events{/number}","events_url":"https://api.github.com/repos/Mudlet/Mudlet/events","assignees_url":"https://api.github.com/repos/Mudlet/Mudlet/assignees{/user}","branches_url":"https://api.github.com/repos/Mudlet/Mudlet/branches{/branch}","tags_url":"https://api.github.com/repos/Mudlet/Mudlet/tags","blobs_url":"https://api.github.com/repos/Mudlet/Mudlet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mudlet/Mudlet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mudlet/Mudlet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mudlet/Mudlet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mudlet/Mudlet/statuses/{sha}","languages_url":"https://api.github.com/repos/Mudlet/Mudlet/languages","stargazers_url":"https://api.github.com/repos/Mudlet/Mudlet/stargazers","contributors_url":"https://api.github.com/repos/Mudlet/Mudlet/contributors","subscribers_url":"https://api.github.com/repos/Mudlet/Mudlet/subscribers","subscription_url":"https://api.github.com/repos/Mudlet/Mudlet/subscription","commits_url":"https://api.github.com/repos/Mudlet/Mudlet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mudlet/Mudlet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mudlet/Mudlet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mudlet/Mudlet/contents/{+path}","compare_url":"https://api.github.com/repos/Mudlet/Mudlet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mudlet/Mudlet/merges","archive_url":"https://api.github.com/repos/Mudlet/Mudlet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mudlet/Mudlet/downloads","issues_url":"https://api.github.com/repos/Mudlet/Mudlet/issues{/number}","pulls_url":"https://api.github.com/repos/Mudlet/Mudlet/pulls{/number}","milestones_url":"https://api.github.com/repos/Mudlet/Mudlet/milestones{/number}","notifications_url":"https://api.github.com/repos/Mudlet/Mudlet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mudlet/Mudlet/labels{/name}","releases_url":"https://api.github.com/repos/Mudlet/Mudlet/releases{/id}","deployments_url":"https://api.github.com/repos/Mudlet/Mudlet/deployments","created_at":"2013-12-11T14:04:21Z","updated_at":"2018-05-15T07:19:15Z","pushed_at":"2018-05-15T10:35:00Z","git_url":"git://github.com/Mudlet/Mudlet.git","ssh_url":"git@github.com:Mudlet/Mudlet.git","clone_url":"https://github.com/Mudlet/Mudlet.git","svn_url":"https://github.com/Mudlet/Mudlet","homepage":"https://mudlet.org","size":29424,"stargazers_count":163,"watchers_count":163,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":89,"mirror_url":null,"archived":false,"open_issues_count":438,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":89,"open_issues":438,"watchers":163,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1656"},"html":{"href":"https://github.com/Mudlet/Mudlet/pull/1656"},"issue":{"href":"https://api.github.com/repos/Mudlet/Mudlet/issues/1656"},"comments":{"href":"https://api.github.com/repos/Mudlet/Mudlet/issues/1656/comments"},"review_comments":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1656/comments"},"review_comment":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Mudlet/Mudlet/pulls/1656/commits"},"statuses":{"href":"https://api.github.com/repos/Mudlet/Mudlet/statuses/400e6c0d75d7625057aa290a83ce58adb206da93"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vadi2"}}