{"action":"created","issue":{"url":"https://api.github.com/repos/hazelcast/hazelcast/issues/10416","repository_url":"https://api.github.com/repos/hazelcast/hazelcast","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/10416/labels{/name}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/10416/comments","events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/10416/events","html_url":"https://github.com/hazelcast/hazelcast/pull/10416","id":223364572,"number":10416,"title":"Eliminate unconditional waiting in node join/shutdown","user":{"login":"mmedenjak","id":17194871,"avatar_url":"https://avatars0.githubusercontent.com/u/17194871?v=4","gravatar_id":"","url":"https://api.github.com/users/mmedenjak","html_url":"https://github.com/mmedenjak","followers_url":"https://api.github.com/users/mmedenjak/followers","following_url":"https://api.github.com/users/mmedenjak/following{/other_user}","gists_url":"https://api.github.com/users/mmedenjak/gists{/gist_id}","starred_url":"https://api.github.com/users/mmedenjak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmedenjak/subscriptions","organizations_url":"https://api.github.com/users/mmedenjak/orgs","repos_url":"https://api.github.com/users/mmedenjak/repos","events_url":"https://api.github.com/users/mmedenjak/events{/privacy}","received_events_url":"https://api.github.com/users/mmedenjak/received_events","type":"User","site_admin":false},"labels":[{"id":137752575,"url":"https://api.github.com/repos/hazelcast/hazelcast/labels/Team:%20Core","name":"Team: Core","color":"109def","default":false},{"id":1740692,"url":"https://api.github.com/repos/hazelcast/hazelcast/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":{"login":"mmedenjak","id":17194871,"avatar_url":"https://avatars0.githubusercontent.com/u/17194871?v=4","gravatar_id":"","url":"https://api.github.com/users/mmedenjak","html_url":"https://github.com/mmedenjak","followers_url":"https://api.github.com/users/mmedenjak/followers","following_url":"https://api.github.com/users/mmedenjak/following{/other_user}","gists_url":"https://api.github.com/users/mmedenjak/gists{/gist_id}","starred_url":"https://api.github.com/users/mmedenjak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmedenjak/subscriptions","organizations_url":"https://api.github.com/users/mmedenjak/orgs","repos_url":"https://api.github.com/users/mmedenjak/repos","events_url":"https://api.github.com/users/mmedenjak/events{/privacy}","received_events_url":"https://api.github.com/users/mmedenjak/received_events","type":"User","site_admin":false},"assignees":[{"login":"mmedenjak","id":17194871,"avatar_url":"https://avatars0.githubusercontent.com/u/17194871?v=4","gravatar_id":"","url":"https://api.github.com/users/mmedenjak","html_url":"https://github.com/mmedenjak","followers_url":"https://api.github.com/users/mmedenjak/followers","following_url":"https://api.github.com/users/mmedenjak/following{/other_user}","gists_url":"https://api.github.com/users/mmedenjak/gists{/gist_id}","starred_url":"https://api.github.com/users/mmedenjak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmedenjak/subscriptions","organizations_url":"https://api.github.com/users/mmedenjak/orgs","repos_url":"https://api.github.com/users/mmedenjak/repos","events_url":"https://api.github.com/users/mmedenjak/events{/privacy}","received_events_url":"https://api.github.com/users/mmedenjak/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/98","html_url":"https://github.com/hazelcast/hazelcast/milestone/98","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/98/labels","id":2624978,"number":98,"title":"3.10","description":null,"creator":{"login":"jerrinot","id":158619,"avatar_url":"https://avatars1.githubusercontent.com/u/158619?v=4","gravatar_id":"","url":"https://api.github.com/users/jerrinot","html_url":"https://github.com/jerrinot","followers_url":"https://api.github.com/users/jerrinot/followers","following_url":"https://api.github.com/users/jerrinot/following{/other_user}","gists_url":"https://api.github.com/users/jerrinot/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrinot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrinot/subscriptions","organizations_url":"https://api.github.com/users/jerrinot/orgs","repos_url":"https://api.github.com/users/jerrinot/repos","events_url":"https://api.github.com/users/jerrinot/events{/privacy}","received_events_url":"https://api.github.com/users/jerrinot/received_events","type":"User","site_admin":false},"open_issues":177,"closed_issues":309,"state":"open","created_at":"2017-07-06T10:25:45Z","updated_at":"2018-02-01T10:58:23Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2017-04-21T12:07:55Z","updated_at":"2018-02-01T13:47:05Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/10416","html_url":"https://github.com/hazelcast/hazelcast/pull/10416","diff_url":"https://github.com/hazelcast/hazelcast/pull/10416.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/10416.patch"},"body":"When joining and shutting the node down there are some places where we\r\nunconditionally wait before checking if we should wait any longer.\r\nThis has been eliminated, the check is done before the first wait as\r\nwell. On node shutdown we always wait for response on pending\r\ninvocations but there might not be any invocations in which case we\r\ncan just finish the invocation system shutdown without waiting.\r\n\r\nNOTE : Currently causes some bugs to appear until https://github.com/hazelcast/hazelcast/pull/10415 is merged. When the fix is merged, we should run the PR builder for this PR a couple of times to see if there are any additional issues that pop up."},"comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments/362270334","html_url":"https://github.com/hazelcast/hazelcast/pull/10416#issuecomment-362270334","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/10416","id":362270334,"user":{"login":"mmedenjak","id":17194871,"avatar_url":"https://avatars0.githubusercontent.com/u/17194871?v=4","gravatar_id":"","url":"https://api.github.com/users/mmedenjak","html_url":"https://github.com/mmedenjak","followers_url":"https://api.github.com/users/mmedenjak/followers","following_url":"https://api.github.com/users/mmedenjak/following{/other_user}","gists_url":"https://api.github.com/users/mmedenjak/gists{/gist_id}","starred_url":"https://api.github.com/users/mmedenjak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmedenjak/subscriptions","organizations_url":"https://api.github.com/users/mmedenjak/orgs","repos_url":"https://api.github.com/users/mmedenjak/repos","events_url":"https://api.github.com/users/mmedenjak/events{/privacy}","received_events_url":"https://api.github.com/users/mmedenjak/received_events","type":"User","site_admin":false},"created_at":"2018-02-01T13:47:05Z","updated_at":"2018-02-01T13:47:05Z","author_association":"CONTRIBUTOR","body":"run-lab-run"}}
{"actor":{"display_login":"mmedenjak"}}