{"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/frontend-documentation/pulls/comments/202788161","pull_request_review_id":137552654,"id":202788161,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjc4ODE2MQ==","diff_hunk":"@@ -0,0 +1,88 @@\n+import React from 'react';\n+import PropTypes from 'prop-types';\n+import classnames from 'classnames';\n+import Icon from '@mapbox/react-icon';\n+\n+class ProductMenuDropdown extends React.PureComponent {\n+  render() {\n+    const categoryLength = this.props.categories.length;\n+    const activeDotStyle = {\n+      content: '',\n+      width: '6px',\n+      height: '6px',\n+      borderRadius: '3px',\n+      background: '#4264fb',\n+      position: 'absolute',\n+      margin: '10px 0 0 -12px',\n+      display: 'none'\n+    };\n+    const allCategories = this.props.categories.map((category, index) => {\n+      const allProducts = category.products.map((product, index) => {\n+        const liClasses = classnames('mt6 relative ', {\n+          'txt-bold': product.url && location.pathname.indexOf(product.url) > -1\n+        });\n+        const dotClasses = classnames({\n+          'inline-block': location.pathname.indexOf(product.url) > -1,\n+          none: location.pathname.indexOf(product.url) < 0\n+        });\n+        return (\n+          <li className={liClasses} key={index}>\n+            <div style={activeDotStyle} className={dotClasses} />\n+            <a href={product.url} className=\"color-blue-on-hover\">\n+              {product.name}\n+            </a>\n+          </li>\n+        );\n+      });\n+      const categoryClasses = classnames('wmin240 py24', {\n+        'border-b border--gray-light': index < categoryLength - 1\n+      });\n+      return (\n+        <div className={categoryClasses} key={index}>\n+          <div className=\"txt-bold color-gray\">\n+            <Icon\n+              name={category.icon}\n+              inline={true}\n+              className=\"icon mb-neg6 mr6 h20 w20 color-gray inline\"","path":"src/components/product-menu-dropdown/product-menu-dropdown.js","position":50,"original_position":46,"commit_id":"366f28e7bbcc03aca3b21046e9ac2be7d04248f1","original_commit_id":"c4d55891f1588a016b6e152ab6fe44aa57f3a22b","user":{"login":"danswick","id":2365503,"node_id":"MDQ6VXNlcjIzNjU1MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/2365503?v=4","gravatar_id":"","url":"https://api.github.com/users/danswick","html_url":"https://github.com/danswick","followers_url":"https://api.github.com/users/danswick/followers","following_url":"https://api.github.com/users/danswick/following{/other_user}","gists_url":"https://api.github.com/users/danswick/gists{/gist_id}","starred_url":"https://api.github.com/users/danswick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danswick/subscriptions","organizations_url":"https://api.github.com/users/danswick/orgs","repos_url":"https://api.github.com/users/danswick/repos","events_url":"https://api.github.com/users/danswick/events{/privacy}","received_events_url":"https://api.github.com/users/danswick/received_events","type":"User","site_admin":false},"body":"@davidtheclark looks like they're both needed: \r\n\r\n- `.inline` sets `display: inline !important`\r\n- `inline={true}` does some math to position the icon vertically: https://github.com/mapbox/mapbox-react-components/blob/master/packages/react-icon/src/icon.js#L19-L28","created_at":"2018-07-16T18:58:53Z","updated_at":"2018-07-16T18:58:54Z","html_url":"https://github.com/mapbox/frontend-documentation/pull/14#discussion_r202788161","pull_request_url":"https://api.github.com/repos/mapbox/frontend-documentation/pulls/14","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mapbox/frontend-documentation/pulls/comments/202788161"},"html":{"href":"https://github.com/mapbox/frontend-documentation/pull/14#discussion_r202788161"},"pull_request":{"href":"https://api.github.com/repos/mapbox/frontend-documentation/pulls/14"}},"in_reply_to_id":202488166},"pull_request":{"url":"https://api.github.com/repos/mapbox/frontend-documentation/pulls/14","id":201414097,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDE0MDk3","html_url":"https://github.com/mapbox/frontend-documentation/pull/14","diff_url":"https://github.com/mapbox/frontend-documentation/pull/14.diff","patch_url":"https://github.com/mapbox/frontend-documentation/pull/14.patch","issue_url":"https://api.github.com/repos/mapbox/frontend-documentation/issues/14","number":14,"state":"open","locked":false,"title":"Add ProductMenu, ProductMenuDropdown components. Add ProductMenuItems data.","user":{"login":"danswick","id":2365503,"node_id":"MDQ6VXNlcjIzNjU1MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/2365503?v=4","gravatar_id":"","url":"https://api.github.com/users/danswick","html_url":"https://github.com/danswick","followers_url":"https://api.github.com/users/danswick/followers","following_url":"https://api.github.com/users/danswick/following{/other_user}","gists_url":"https://api.github.com/users/danswick/gists{/gist_id}","starred_url":"https://api.github.com/users/danswick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danswick/subscriptions","organizations_url":"https://api.github.com/users/danswick/orgs","repos_url":"https://api.github.com/users/danswick/repos","events_url":"https://api.github.com/users/danswick/events{/privacy}","received_events_url":"https://api.github.com/users/danswick/received_events","type":"User","site_admin":false},"body":"closes https://github.com/mapbox/frontend-documentation/issues/3\r\n\r\n![image](https://user-images.githubusercontent.com/2365503/42716650-6388bfaa-86b1-11e8-8501-a57906679b8b.png)\r\n\r\n![image](https://user-images.githubusercontent.com/2365503/42716661-72478530-86b1-11e8-8eac-995d8d71d23b.png)\r\n\r\nAfter chatting with @colleenmcginnis yesterday about the data that populates the ProductMenu, it seems clear that `frontend-documentation` would make a good home for the `truth` about which products should be in the menu. I included the most recent product list I could find in a new `data` directory. I'm not sure if that's the most sensible way to do it! \r\n\r\nI'm also unsure whether it would be better to refactor `ProductMenuDropdown` a bit so it accepts a prop with all of the product data. ","created_at":"2018-07-13T22:29:39Z","updated_at":"2018-07-16T18:58:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"colleenmcginnis","id":10479155,"node_id":"MDQ6VXNlcjEwNDc5MTU1","avatar_url":"https://avatars0.githubusercontent.com/u/10479155?v=4","gravatar_id":"","url":"https://api.github.com/users/colleenmcginnis","html_url":"https://github.com/colleenmcginnis","followers_url":"https://api.github.com/users/colleenmcginnis/followers","following_url":"https://api.github.com/users/colleenmcginnis/following{/other_user}","gists_url":"https://api.github.com/users/colleenmcginnis/gists{/gist_id}","starred_url":"https://api.github.com/users/colleenmcginnis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colleenmcginnis/subscriptions","organizations_url":"https://api.github.com/users/colleenmcginnis/orgs","repos_url":"https://api.github.com/users/colleenmcginnis/repos","events_url":"https://api.github.com/users/colleenmcginnis/events{/privacy}","received_events_url":"https://api.github.com/users/colleenmcginnis/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/frontend-documentation/pulls/14/commits","review_comments_url":"https://api.github.com/repos/mapbox/frontend-documentation/pulls/14/comments","review_comment_url":"https://api.github.com/repos/mapbox/frontend-documentation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/frontend-documentation/issues/14/comments","statuses_url":"https://api.github.com/repos/mapbox/frontend-documentation/statuses/366f28e7bbcc03aca3b21046e9ac2be7d04248f1","head":{"label":"mapbox:product-menu","ref":"product-menu","sha":"366f28e7bbcc03aca3b21046e9ac2be7d04248f1","user":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":140478630,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA0Nzg2MzA=","name":"frontend-documentation","full_name":"mapbox/frontend-documentation","owner":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/frontend-documentation","description":"Frontend tools for Mapbox documentation websites.","fork":false,"url":"https://api.github.com/repos/mapbox/frontend-documentation","forks_url":"https://api.github.com/repos/mapbox/frontend-documentation/forks","keys_url":"https://api.github.com/repos/mapbox/frontend-documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/frontend-documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/frontend-documentation/teams","hooks_url":"https://api.github.com/repos/mapbox/frontend-documentation/hooks","issue_events_url":"https://api.github.com/repos/mapbox/frontend-documentation/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/frontend-documentation/events","assignees_url":"https://api.github.com/repos/mapbox/frontend-documentation/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/frontend-documentation/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/frontend-documentation/tags","blobs_url":"https://api.github.com/repos/mapbox/frontend-documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/frontend-documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/frontend-documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/frontend-documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/frontend-documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/frontend-documentation/languages","stargazers_url":"https://api.github.com/repos/mapbox/frontend-documentation/stargazers","contributors_url":"https://api.github.com/repos/mapbox/frontend-documentation/contributors","subscribers_url":"https://api.github.com/repos/mapbox/frontend-documentation/subscribers","subscription_url":"https://api.github.com/repos/mapbox/frontend-documentation/subscription","commits_url":"https://api.github.com/repos/mapbox/frontend-documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/frontend-documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/frontend-documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/frontend-documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/frontend-documentation/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/frontend-documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/frontend-documentation/merges","archive_url":"https://api.github.com/repos/mapbox/frontend-documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/frontend-documentation/downloads","issues_url":"https://api.github.com/repos/mapbox/frontend-documentation/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/frontend-documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/frontend-documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/frontend-documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/frontend-documentation/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/frontend-documentation/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/frontend-documentation/deployments","created_at":"2018-07-10T19:31:34Z","updated_at":"2018-07-14T00:07:19Z","pushed_at":"2018-07-16T15:39:27Z","git_url":"git://github.com/mapbox/frontend-documentation.git","ssh_url":"git@github.com:mapbox/frontend-documentation.git","clone_url":"https://github.com/mapbox/frontend-documentation.git","svn_url":"https://github.com/mapbox/frontend-documentation","homepage":null,"size":615,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":15,"watchers":0,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"f5a3ea90edf6acd8817a753ca9f6de395cbf8466","user":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":140478630,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA0Nzg2MzA=","name":"frontend-documentation","full_name":"mapbox/frontend-documentation","owner":{"login":"mapbox","id":600935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwMDkzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/frontend-documentation","description":"Frontend tools for Mapbox documentation websites.","fork":false,"url":"https://api.github.com/repos/mapbox/frontend-documentation","forks_url":"https://api.github.com/repos/mapbox/frontend-documentation/forks","keys_url":"https://api.github.com/repos/mapbox/frontend-documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/frontend-documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/frontend-documentation/teams","hooks_url":"https://api.github.com/repos/mapbox/frontend-documentation/hooks","issue_events_url":"https://api.github.com/repos/mapbox/frontend-documentation/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/frontend-documentation/events","assignees_url":"https://api.github.com/repos/mapbox/frontend-documentation/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/frontend-documentation/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/frontend-documentation/tags","blobs_url":"https://api.github.com/repos/mapbox/frontend-documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/frontend-documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/frontend-documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/frontend-documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/frontend-documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/frontend-documentation/languages","stargazers_url":"https://api.github.com/repos/mapbox/frontend-documentation/stargazers","contributors_url":"https://api.github.com/repos/mapbox/frontend-documentation/contributors","subscribers_url":"https://api.github.com/repos/mapbox/frontend-documentation/subscribers","subscription_url":"https://api.github.com/repos/mapbox/frontend-documentation/subscription","commits_url":"https://api.github.com/repos/mapbox/frontend-documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/frontend-documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/frontend-documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/frontend-documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/frontend-documentation/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/frontend-documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/frontend-documentation/merges","archive_url":"https://api.github.com/repos/mapbox/frontend-documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/frontend-documentation/downloads","issues_url":"https://api.github.com/repos/mapbox/frontend-documentation/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/frontend-documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/frontend-documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/frontend-documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/frontend-documentation/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/frontend-documentation/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/frontend-documentation/deployments","created_at":"2018-07-10T19:31:34Z","updated_at":"2018-07-14T00:07:19Z","pushed_at":"2018-07-16T15:39:27Z","git_url":"git://github.com/mapbox/frontend-documentation.git","ssh_url":"git@github.com:mapbox/frontend-documentation.git","clone_url":"https://github.com/mapbox/frontend-documentation.git","svn_url":"https://github.com/mapbox/frontend-documentation","homepage":null,"size":615,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":15,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/frontend-documentation/pulls/14"},"html":{"href":"https://github.com/mapbox/frontend-documentation/pull/14"},"issue":{"href":"https://api.github.com/repos/mapbox/frontend-documentation/issues/14"},"comments":{"href":"https://api.github.com/repos/mapbox/frontend-documentation/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/frontend-documentation/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/frontend-documentation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/frontend-documentation/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/frontend-documentation/statuses/366f28e7bbcc03aca3b21046e9ac2be7d04248f1"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"danswick"}}