{"action":"created","comment":{"url":"https://api.github.com/repos/daostack/arc/pulls/comments/238086760","pull_request_review_id":180549574,"id":238086760,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODA4Njc2MA==","diff_hunk":"@@ -86,9 +86,9 @@ contract Auction4Reputation is Ownable {\n      * @dev redeem reputation function\n      * @param _beneficiary the beneficiary to redeem.\n      * @param _auctionId the auction id to redeem from.\n-     * @return bool\n+     * @return uint reputation rewarded\n      */\n-    function redeem(address _beneficiary, uint _auctionId) public returns(bool) {\n+    function redeem(address _beneficiary, uint _auctionId) public returns(uint) {","path":"contracts/schemes/Auction4Reputation.sol","position":8,"original_position":8,"commit_id":"e1323c8adb6133fdc52889d2442368630f261679","original_commit_id":"e1323c8adb6133fdc52889d2442368630f261679","user":{"login":"orenyodfat","id":5994398,"node_id":"MDQ6VXNlcjU5OTQzOTg=","avatar_url":"https://avatars2.githubusercontent.com/u/5994398?v=4","gravatar_id":"","url":"https://api.github.com/users/orenyodfat","html_url":"https://github.com/orenyodfat","followers_url":"https://api.github.com/users/orenyodfat/followers","following_url":"https://api.github.com/users/orenyodfat/following{/other_user}","gists_url":"https://api.github.com/users/orenyodfat/gists{/gist_id}","starred_url":"https://api.github.com/users/orenyodfat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orenyodfat/subscriptions","organizations_url":"https://api.github.com/users/orenyodfat/orgs","repos_url":"https://api.github.com/users/orenyodfat/repos","events_url":"https://api.github.com/users/orenyodfat/events{/privacy}","received_events_url":"https://api.github.com/users/orenyodfat/received_events","type":"User","site_admin":false},"body":"function redeem(address _beneficiary, uint _auctionId) public returns(uint reputation) ","created_at":"2018-12-02T06:45:00Z","updated_at":"2018-12-02T06:45:01Z","html_url":"https://github.com/daostack/arc/pull/566#discussion_r238086760","pull_request_url":"https://api.github.com/repos/daostack/arc/pulls/566","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/daostack/arc/pulls/comments/238086760"},"html":{"href":"https://github.com/daostack/arc/pull/566#discussion_r238086760"},"pull_request":{"href":"https://api.github.com/repos/daostack/arc/pulls/566"}}},"pull_request":{"url":"https://api.github.com/repos/daostack/arc/pulls/566","id":235208201,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MjA4MjAx","html_url":"https://github.com/daostack/arc/pull/566","diff_url":"https://github.com/daostack/arc/pull/566.diff","patch_url":"https://github.com/daostack/arc/pull/566.patch","issue_url":"https://api.github.com/repos/daostack/arc/issues/566","number":566,"state":"open","locked":false,"title":"return reputation rewarded from Redeem function","user":{"login":"dkent600","id":1821666,"node_id":"MDQ6VXNlcjE4MjE2NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1821666?v=4","gravatar_id":"","url":"https://api.github.com/users/dkent600","html_url":"https://github.com/dkent600","followers_url":"https://api.github.com/users/dkent600/followers","following_url":"https://api.github.com/users/dkent600/following{/other_user}","gists_url":"https://api.github.com/users/dkent600/gists{/gist_id}","starred_url":"https://api.github.com/users/dkent600/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkent600/subscriptions","organizations_url":"https://api.github.com/users/dkent600/orgs","repos_url":"https://api.github.com/users/dkent600/repos","events_url":"https://api.github.com/users/dkent600/events{/privacy}","received_events_url":"https://api.github.com/users/dkent600/received_events","type":"User","site_admin":false},"body":"The dutchx app wants to display to the user how much reputation the user will be rewarded.  This PR change greatly facilitates obtaining this value after the locking period has ended and before the rep has been redeemed, and it keeps within the contract the logic for computing reputation.\r\n\r\n(The amount of reputation rewarded after redeeming will have to come from the Redeem events.)","created_at":"2018-12-01T18:04:42Z","updated_at":"2018-12-02T06:45:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c3161b4c01ade49c82fa7c33419c70ae82ab9c0","assignee":{"login":"dkent600","id":1821666,"node_id":"MDQ6VXNlcjE4MjE2NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1821666?v=4","gravatar_id":"","url":"https://api.github.com/users/dkent600","html_url":"https://github.com/dkent600","followers_url":"https://api.github.com/users/dkent600/followers","following_url":"https://api.github.com/users/dkent600/following{/other_user}","gists_url":"https://api.github.com/users/dkent600/gists{/gist_id}","starred_url":"https://api.github.com/users/dkent600/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkent600/subscriptions","organizations_url":"https://api.github.com/users/dkent600/orgs","repos_url":"https://api.github.com/users/dkent600/repos","events_url":"https://api.github.com/users/dkent600/events{/privacy}","received_events_url":"https://api.github.com/users/dkent600/received_events","type":"User","site_admin":false},"assignees":[{"login":"dkent600","id":1821666,"node_id":"MDQ6VXNlcjE4MjE2NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/1821666?v=4","gravatar_id":"","url":"https://api.github.com/users/dkent600","html_url":"https://github.com/dkent600","followers_url":"https://api.github.com/users/dkent600/followers","following_url":"https://api.github.com/users/dkent600/following{/other_user}","gists_url":"https://api.github.com/users/dkent600/gists{/gist_id}","starred_url":"https://api.github.com/users/dkent600/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkent600/subscriptions","organizations_url":"https://api.github.com/users/dkent600/orgs","repos_url":"https://api.github.com/users/dkent600/repos","events_url":"https://api.github.com/users/dkent600/events{/privacy}","received_events_url":"https://api.github.com/users/dkent600/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/daostack/arc/pulls/566/commits","review_comments_url":"https://api.github.com/repos/daostack/arc/pulls/566/comments","review_comment_url":"https://api.github.com/repos/daostack/arc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/daostack/arc/issues/566/comments","statuses_url":"https://api.github.com/repos/daostack/arc/statuses/e1323c8adb6133fdc52889d2442368630f261679","head":{"label":"daostack:getRedeemableRep","ref":"getRedeemableRep","sha":"e1323c8adb6133fdc52889d2442368630f261679","user":{"login":"daostack","id":22343705,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzQzNzA1","avatar_url":"https://avatars0.githubusercontent.com/u/22343705?v=4","gravatar_id":"","url":"https://api.github.com/users/daostack","html_url":"https://github.com/daostack","followers_url":"https://api.github.com/users/daostack/followers","following_url":"https://api.github.com/users/daostack/following{/other_user}","gists_url":"https://api.github.com/users/daostack/gists{/gist_id}","starred_url":"https://api.github.com/users/daostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daostack/subscriptions","organizations_url":"https://api.github.com/users/daostack/orgs","repos_url":"https://api.github.com/users/daostack/repos","events_url":"https://api.github.com/users/daostack/events{/privacy}","received_events_url":"https://api.github.com/users/daostack/received_events","type":"Organization","site_admin":false},"repo":{"id":68805812,"node_id":"MDEwOlJlcG9zaXRvcnk2ODgwNTgxMg==","name":"arc","full_name":"daostack/arc","private":false,"owner":{"login":"daostack","id":22343705,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzQzNzA1","avatar_url":"https://avatars0.githubusercontent.com/u/22343705?v=4","gravatar_id":"","url":"https://api.github.com/users/daostack","html_url":"https://github.com/daostack","followers_url":"https://api.github.com/users/daostack/followers","following_url":"https://api.github.com/users/daostack/following{/other_user}","gists_url":"https://api.github.com/users/daostack/gists{/gist_id}","starred_url":"https://api.github.com/users/daostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daostack/subscriptions","organizations_url":"https://api.github.com/users/daostack/orgs","repos_url":"https://api.github.com/users/daostack/repos","events_url":"https://api.github.com/users/daostack/events{/privacy}","received_events_url":"https://api.github.com/users/daostack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/daostack/arc","description":"DAOstack is an operating system for DAOs. ","fork":false,"url":"https://api.github.com/repos/daostack/arc","forks_url":"https://api.github.com/repos/daostack/arc/forks","keys_url":"https://api.github.com/repos/daostack/arc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daostack/arc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daostack/arc/teams","hooks_url":"https://api.github.com/repos/daostack/arc/hooks","issue_events_url":"https://api.github.com/repos/daostack/arc/issues/events{/number}","events_url":"https://api.github.com/repos/daostack/arc/events","assignees_url":"https://api.github.com/repos/daostack/arc/assignees{/user}","branches_url":"https://api.github.com/repos/daostack/arc/branches{/branch}","tags_url":"https://api.github.com/repos/daostack/arc/tags","blobs_url":"https://api.github.com/repos/daostack/arc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daostack/arc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daostack/arc/git/refs{/sha}","trees_url":"https://api.github.com/repos/daostack/arc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daostack/arc/statuses/{sha}","languages_url":"https://api.github.com/repos/daostack/arc/languages","stargazers_url":"https://api.github.com/repos/daostack/arc/stargazers","contributors_url":"https://api.github.com/repos/daostack/arc/contributors","subscribers_url":"https://api.github.com/repos/daostack/arc/subscribers","subscription_url":"https://api.github.com/repos/daostack/arc/subscription","commits_url":"https://api.github.com/repos/daostack/arc/commits{/sha}","git_commits_url":"https://api.github.com/repos/daostack/arc/git/commits{/sha}","comments_url":"https://api.github.com/repos/daostack/arc/comments{/number}","issue_comment_url":"https://api.github.com/repos/daostack/arc/issues/comments{/number}","contents_url":"https://api.github.com/repos/daostack/arc/contents/{+path}","compare_url":"https://api.github.com/repos/daostack/arc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daostack/arc/merges","archive_url":"https://api.github.com/repos/daostack/arc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daostack/arc/downloads","issues_url":"https://api.github.com/repos/daostack/arc/issues{/number}","pulls_url":"https://api.github.com/repos/daostack/arc/pulls{/number}","milestones_url":"https://api.github.com/repos/daostack/arc/milestones{/number}","notifications_url":"https://api.github.com/repos/daostack/arc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daostack/arc/labels{/name}","releases_url":"https://api.github.com/repos/daostack/arc/releases{/id}","deployments_url":"https://api.github.com/repos/daostack/arc/deployments","created_at":"2016-09-21T10:22:23Z","updated_at":"2018-12-01T18:58:30Z","pushed_at":"2018-12-01T18:58:28Z","git_url":"git://github.com/daostack/arc.git","ssh_url":"git@github.com:daostack/arc.git","clone_url":"https://github.com/daostack/arc.git","svn_url":"https://github.com/daostack/arc","homepage":"","size":8603,"stargazers_count":143,"watchers_count":143,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":39,"open_issues":23,"watchers":143,"default_branch":"master"}},"base":{"label":"daostack:master","ref":"master","sha":"a46113c586fe894a4974e4cff0afcee8ee348d13","user":{"login":"daostack","id":22343705,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzQzNzA1","avatar_url":"https://avatars0.githubusercontent.com/u/22343705?v=4","gravatar_id":"","url":"https://api.github.com/users/daostack","html_url":"https://github.com/daostack","followers_url":"https://api.github.com/users/daostack/followers","following_url":"https://api.github.com/users/daostack/following{/other_user}","gists_url":"https://api.github.com/users/daostack/gists{/gist_id}","starred_url":"https://api.github.com/users/daostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daostack/subscriptions","organizations_url":"https://api.github.com/users/daostack/orgs","repos_url":"https://api.github.com/users/daostack/repos","events_url":"https://api.github.com/users/daostack/events{/privacy}","received_events_url":"https://api.github.com/users/daostack/received_events","type":"Organization","site_admin":false},"repo":{"id":68805812,"node_id":"MDEwOlJlcG9zaXRvcnk2ODgwNTgxMg==","name":"arc","full_name":"daostack/arc","private":false,"owner":{"login":"daostack","id":22343705,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzQzNzA1","avatar_url":"https://avatars0.githubusercontent.com/u/22343705?v=4","gravatar_id":"","url":"https://api.github.com/users/daostack","html_url":"https://github.com/daostack","followers_url":"https://api.github.com/users/daostack/followers","following_url":"https://api.github.com/users/daostack/following{/other_user}","gists_url":"https://api.github.com/users/daostack/gists{/gist_id}","starred_url":"https://api.github.com/users/daostack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daostack/subscriptions","organizations_url":"https://api.github.com/users/daostack/orgs","repos_url":"https://api.github.com/users/daostack/repos","events_url":"https://api.github.com/users/daostack/events{/privacy}","received_events_url":"https://api.github.com/users/daostack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/daostack/arc","description":"DAOstack is an operating system for DAOs. ","fork":false,"url":"https://api.github.com/repos/daostack/arc","forks_url":"https://api.github.com/repos/daostack/arc/forks","keys_url":"https://api.github.com/repos/daostack/arc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daostack/arc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daostack/arc/teams","hooks_url":"https://api.github.com/repos/daostack/arc/hooks","issue_events_url":"https://api.github.com/repos/daostack/arc/issues/events{/number}","events_url":"https://api.github.com/repos/daostack/arc/events","assignees_url":"https://api.github.com/repos/daostack/arc/assignees{/user}","branches_url":"https://api.github.com/repos/daostack/arc/branches{/branch}","tags_url":"https://api.github.com/repos/daostack/arc/tags","blobs_url":"https://api.github.com/repos/daostack/arc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daostack/arc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daostack/arc/git/refs{/sha}","trees_url":"https://api.github.com/repos/daostack/arc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daostack/arc/statuses/{sha}","languages_url":"https://api.github.com/repos/daostack/arc/languages","stargazers_url":"https://api.github.com/repos/daostack/arc/stargazers","contributors_url":"https://api.github.com/repos/daostack/arc/contributors","subscribers_url":"https://api.github.com/repos/daostack/arc/subscribers","subscription_url":"https://api.github.com/repos/daostack/arc/subscription","commits_url":"https://api.github.com/repos/daostack/arc/commits{/sha}","git_commits_url":"https://api.github.com/repos/daostack/arc/git/commits{/sha}","comments_url":"https://api.github.com/repos/daostack/arc/comments{/number}","issue_comment_url":"https://api.github.com/repos/daostack/arc/issues/comments{/number}","contents_url":"https://api.github.com/repos/daostack/arc/contents/{+path}","compare_url":"https://api.github.com/repos/daostack/arc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daostack/arc/merges","archive_url":"https://api.github.com/repos/daostack/arc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daostack/arc/downloads","issues_url":"https://api.github.com/repos/daostack/arc/issues{/number}","pulls_url":"https://api.github.com/repos/daostack/arc/pulls{/number}","milestones_url":"https://api.github.com/repos/daostack/arc/milestones{/number}","notifications_url":"https://api.github.com/repos/daostack/arc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daostack/arc/labels{/name}","releases_url":"https://api.github.com/repos/daostack/arc/releases{/id}","deployments_url":"https://api.github.com/repos/daostack/arc/deployments","created_at":"2016-09-21T10:22:23Z","updated_at":"2018-12-01T18:58:30Z","pushed_at":"2018-12-01T18:58:28Z","git_url":"git://github.com/daostack/arc.git","ssh_url":"git@github.com:daostack/arc.git","clone_url":"https://github.com/daostack/arc.git","svn_url":"https://github.com/daostack/arc","homepage":"","size":8603,"stargazers_count":143,"watchers_count":143,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":39,"open_issues":23,"watchers":143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/daostack/arc/pulls/566"},"html":{"href":"https://github.com/daostack/arc/pull/566"},"issue":{"href":"https://api.github.com/repos/daostack/arc/issues/566"},"comments":{"href":"https://api.github.com/repos/daostack/arc/issues/566/comments"},"review_comments":{"href":"https://api.github.com/repos/daostack/arc/pulls/566/comments"},"review_comment":{"href":"https://api.github.com/repos/daostack/arc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/daostack/arc/pulls/566/commits"},"statuses":{"href":"https://api.github.com/repos/daostack/arc/statuses/e1323c8adb6133fdc52889d2442368630f261679"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"orenyodfat"}}