{"action":"closed","number":52,"pull_request":{"url":"https://api.github.com/repos/st-h/ember-content-editable/pulls/52","id":188685989,"html_url":"https://github.com/st-h/ember-content-editable/pull/52","diff_url":"https://github.com/st-h/ember-content-editable/pull/52.diff","patch_url":"https://github.com/st-h/ember-content-editable/pull/52.patch","issue_url":"https://api.github.com/repos/st-h/ember-content-editable/issues/52","number":52,"state":"closed","locked":false,"title":"Update dom before initializing MutationObserver","user":{"login":"ctjhoa","id":1716173,"avatar_url":"https://avatars2.githubusercontent.com/u/1716173?v=4","gravatar_id":"","url":"https://api.github.com/users/ctjhoa","html_url":"https://github.com/ctjhoa","followers_url":"https://api.github.com/users/ctjhoa/followers","following_url":"https://api.github.com/users/ctjhoa/following{/other_user}","gists_url":"https://api.github.com/users/ctjhoa/gists{/gist_id}","starred_url":"https://api.github.com/users/ctjhoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctjhoa/subscriptions","organizations_url":"https://api.github.com/users/ctjhoa/orgs","repos_url":"https://api.github.com/users/ctjhoa/repos","events_url":"https://api.github.com/users/ctjhoa/events{/privacy}","received_events_url":"https://api.github.com/users/ctjhoa/received_events","type":"User","site_admin":false},"body":"`updateDom` should be done before initializing `MutationObserver` because `domChanged` function can be immediatly triggered. This seems unneeded and can lead to bug.\r\n\r\nIn my case I use `content-editable` inside a modal and the `value` passed is reset to an empty string during init while content-editable innerText has the good value.\r\n","created_at":"2018-05-17T10:08:17Z","updated_at":"2018-05-20T12:34:34Z","closed_at":"2018-05-20T12:34:34Z","merged_at":"2018-05-20T12:34:34Z","merge_commit_sha":"1d39335619ad5042bd78603c255ba9324eecf836","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/st-h/ember-content-editable/pulls/52/commits","review_comments_url":"https://api.github.com/repos/st-h/ember-content-editable/pulls/52/comments","review_comment_url":"https://api.github.com/repos/st-h/ember-content-editable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/st-h/ember-content-editable/issues/52/comments","statuses_url":"https://api.github.com/repos/st-h/ember-content-editable/statuses/f09d8bf2a3ec074f00066691f00a13888459ec12","head":{"label":"ctjhoa:master","ref":"master","sha":"f09d8bf2a3ec074f00066691f00a13888459ec12","user":{"login":"ctjhoa","id":1716173,"avatar_url":"https://avatars2.githubusercontent.com/u/1716173?v=4","gravatar_id":"","url":"https://api.github.com/users/ctjhoa","html_url":"https://github.com/ctjhoa","followers_url":"https://api.github.com/users/ctjhoa/followers","following_url":"https://api.github.com/users/ctjhoa/following{/other_user}","gists_url":"https://api.github.com/users/ctjhoa/gists{/gist_id}","starred_url":"https://api.github.com/users/ctjhoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctjhoa/subscriptions","organizations_url":"https://api.github.com/users/ctjhoa/orgs","repos_url":"https://api.github.com/users/ctjhoa/repos","events_url":"https://api.github.com/users/ctjhoa/events{/privacy}","received_events_url":"https://api.github.com/users/ctjhoa/received_events","type":"User","site_admin":false},"repo":{"id":133792934,"name":"ember-content-editable","full_name":"ctjhoa/ember-content-editable","owner":{"login":"ctjhoa","id":1716173,"avatar_url":"https://avatars2.githubusercontent.com/u/1716173?v=4","gravatar_id":"","url":"https://api.github.com/users/ctjhoa","html_url":"https://github.com/ctjhoa","followers_url":"https://api.github.com/users/ctjhoa/followers","following_url":"https://api.github.com/users/ctjhoa/following{/other_user}","gists_url":"https://api.github.com/users/ctjhoa/gists{/gist_id}","starred_url":"https://api.github.com/users/ctjhoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctjhoa/subscriptions","organizations_url":"https://api.github.com/users/ctjhoa/orgs","repos_url":"https://api.github.com/users/ctjhoa/repos","events_url":"https://api.github.com/users/ctjhoa/events{/privacy}","received_events_url":"https://api.github.com/users/ctjhoa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ctjhoa/ember-content-editable","description":"A contenteditable component for ember-cli that just works™","fork":true,"url":"https://api.github.com/repos/ctjhoa/ember-content-editable","forks_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/forks","keys_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/teams","hooks_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/hooks","issue_events_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/issues/events{/number}","events_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/events","assignees_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/assignees{/user}","branches_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/branches{/branch}","tags_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/tags","blobs_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/git/refs{/sha}","trees_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/statuses/{sha}","languages_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/languages","stargazers_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/stargazers","contributors_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/contributors","subscribers_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/subscribers","subscription_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/subscription","commits_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/commits{/sha}","git_commits_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/git/commits{/sha}","comments_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/comments{/number}","issue_comment_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/issues/comments{/number}","contents_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/contents/{+path}","compare_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/merges","archive_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/downloads","issues_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/issues{/number}","pulls_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/pulls{/number}","milestones_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/milestones{/number}","notifications_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/labels{/name}","releases_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/releases{/id}","deployments_url":"https://api.github.com/repos/ctjhoa/ember-content-editable/deployments","created_at":"2018-05-17T09:46:20Z","updated_at":"2018-05-17T09:51:27Z","pushed_at":"2018-05-17T09:51:25Z","git_url":"git://github.com/ctjhoa/ember-content-editable.git","ssh_url":"git@github.com:ctjhoa/ember-content-editable.git","clone_url":"https://github.com/ctjhoa/ember-content-editable.git","svn_url":"https://github.com/ctjhoa/ember-content-editable","homepage":"","size":1001,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"st-h:master","ref":"master","sha":"99ca15dcb11d840db02b98efa68819dfac1d3b61","user":{"login":"st-h","id":5768353,"avatar_url":"https://avatars1.githubusercontent.com/u/5768353?v=4","gravatar_id":"","url":"https://api.github.com/users/st-h","html_url":"https://github.com/st-h","followers_url":"https://api.github.com/users/st-h/followers","following_url":"https://api.github.com/users/st-h/following{/other_user}","gists_url":"https://api.github.com/users/st-h/gists{/gist_id}","starred_url":"https://api.github.com/users/st-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/st-h/subscriptions","organizations_url":"https://api.github.com/users/st-h/orgs","repos_url":"https://api.github.com/users/st-h/repos","events_url":"https://api.github.com/users/st-h/events{/privacy}","received_events_url":"https://api.github.com/users/st-h/received_events","type":"User","site_admin":false},"repo":{"id":40017844,"name":"ember-content-editable","full_name":"st-h/ember-content-editable","owner":{"login":"st-h","id":5768353,"avatar_url":"https://avatars1.githubusercontent.com/u/5768353?v=4","gravatar_id":"","url":"https://api.github.com/users/st-h","html_url":"https://github.com/st-h","followers_url":"https://api.github.com/users/st-h/followers","following_url":"https://api.github.com/users/st-h/following{/other_user}","gists_url":"https://api.github.com/users/st-h/gists{/gist_id}","starred_url":"https://api.github.com/users/st-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/st-h/subscriptions","organizations_url":"https://api.github.com/users/st-h/orgs","repos_url":"https://api.github.com/users/st-h/repos","events_url":"https://api.github.com/users/st-h/events{/privacy}","received_events_url":"https://api.github.com/users/st-h/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/st-h/ember-content-editable","description":"A contenteditable component for ember-cli that just works™","fork":false,"url":"https://api.github.com/repos/st-h/ember-content-editable","forks_url":"https://api.github.com/repos/st-h/ember-content-editable/forks","keys_url":"https://api.github.com/repos/st-h/ember-content-editable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/st-h/ember-content-editable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/st-h/ember-content-editable/teams","hooks_url":"https://api.github.com/repos/st-h/ember-content-editable/hooks","issue_events_url":"https://api.github.com/repos/st-h/ember-content-editable/issues/events{/number}","events_url":"https://api.github.com/repos/st-h/ember-content-editable/events","assignees_url":"https://api.github.com/repos/st-h/ember-content-editable/assignees{/user}","branches_url":"https://api.github.com/repos/st-h/ember-content-editable/branches{/branch}","tags_url":"https://api.github.com/repos/st-h/ember-content-editable/tags","blobs_url":"https://api.github.com/repos/st-h/ember-content-editable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/st-h/ember-content-editable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/st-h/ember-content-editable/git/refs{/sha}","trees_url":"https://api.github.com/repos/st-h/ember-content-editable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/st-h/ember-content-editable/statuses/{sha}","languages_url":"https://api.github.com/repos/st-h/ember-content-editable/languages","stargazers_url":"https://api.github.com/repos/st-h/ember-content-editable/stargazers","contributors_url":"https://api.github.com/repos/st-h/ember-content-editable/contributors","subscribers_url":"https://api.github.com/repos/st-h/ember-content-editable/subscribers","subscription_url":"https://api.github.com/repos/st-h/ember-content-editable/subscription","commits_url":"https://api.github.com/repos/st-h/ember-content-editable/commits{/sha}","git_commits_url":"https://api.github.com/repos/st-h/ember-content-editable/git/commits{/sha}","comments_url":"https://api.github.com/repos/st-h/ember-content-editable/comments{/number}","issue_comment_url":"https://api.github.com/repos/st-h/ember-content-editable/issues/comments{/number}","contents_url":"https://api.github.com/repos/st-h/ember-content-editable/contents/{+path}","compare_url":"https://api.github.com/repos/st-h/ember-content-editable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/st-h/ember-content-editable/merges","archive_url":"https://api.github.com/repos/st-h/ember-content-editable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/st-h/ember-content-editable/downloads","issues_url":"https://api.github.com/repos/st-h/ember-content-editable/issues{/number}","pulls_url":"https://api.github.com/repos/st-h/ember-content-editable/pulls{/number}","milestones_url":"https://api.github.com/repos/st-h/ember-content-editable/milestones{/number}","notifications_url":"https://api.github.com/repos/st-h/ember-content-editable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/st-h/ember-content-editable/labels{/name}","releases_url":"https://api.github.com/repos/st-h/ember-content-editable/releases{/id}","deployments_url":"https://api.github.com/repos/st-h/ember-content-editable/deployments","created_at":"2015-07-31T17:57:13Z","updated_at":"2018-05-03T16:45:38Z","pushed_at":"2018-05-20T12:34:34Z","git_url":"git://github.com/st-h/ember-content-editable.git","ssh_url":"git@github.com:st-h/ember-content-editable.git","clone_url":"https://github.com/st-h/ember-content-editable.git","svn_url":"https://github.com/st-h/ember-content-editable","homepage":"","size":1001,"stargazers_count":51,"watchers_count":51,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":22,"open_issues":2,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/st-h/ember-content-editable/pulls/52"},"html":{"href":"https://github.com/st-h/ember-content-editable/pull/52"},"issue":{"href":"https://api.github.com/repos/st-h/ember-content-editable/issues/52"},"comments":{"href":"https://api.github.com/repos/st-h/ember-content-editable/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/st-h/ember-content-editable/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/st-h/ember-content-editable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/st-h/ember-content-editable/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/st-h/ember-content-editable/statuses/f09d8bf2a3ec074f00066691f00a13888459ec12"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"st-h","id":5768353,"avatar_url":"https://avatars1.githubusercontent.com/u/5768353?v=4","gravatar_id":"","url":"https://api.github.com/users/st-h","html_url":"https://github.com/st-h","followers_url":"https://api.github.com/users/st-h/followers","following_url":"https://api.github.com/users/st-h/following{/other_user}","gists_url":"https://api.github.com/users/st-h/gists{/gist_id}","starred_url":"https://api.github.com/users/st-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/st-h/subscriptions","organizations_url":"https://api.github.com/users/st-h/orgs","repos_url":"https://api.github.com/users/st-h/repos","events_url":"https://api.github.com/users/st-h/events{/privacy}","received_events_url":"https://api.github.com/users/st-h/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"st-h"}}