{"action":"created","issue":{"url":"https://api.github.com/repos/OpenMage/magento-lts/issues/443","repository_url":"https://api.github.com/repos/OpenMage/magento-lts","labels_url":"https://api.github.com/repos/OpenMage/magento-lts/issues/443/labels{/name}","comments_url":"https://api.github.com/repos/OpenMage/magento-lts/issues/443/comments","events_url":"https://api.github.com/repos/OpenMage/magento-lts/issues/443/events","html_url":"https://github.com/OpenMage/magento-lts/issues/443","id":293515805,"node_id":"MDU6SXNzdWUyOTM1MTU4MDU=","number":443,"title":"Catalog Price Rules End Date not working as expected","user":{"login":"seansan","id":652395,"node_id":"MDQ6VXNlcjY1MjM5NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/652395?v=4","gravatar_id":"","url":"https://api.github.com/users/seansan","html_url":"https://github.com/seansan","followers_url":"https://api.github.com/users/seansan/followers","following_url":"https://api.github.com/users/seansan/following{/other_user}","gists_url":"https://api.github.com/users/seansan/gists{/gist_id}","starred_url":"https://api.github.com/users/seansan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seansan/subscriptions","organizations_url":"https://api.github.com/users/seansan/orgs","repos_url":"https://api.github.com/users/seansan/repos","events_url":"https://api.github.com/users/seansan/events{/privacy}","received_events_url":"https://api.github.com/users/seansan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-02-01T12:40:33Z","updated_at":"2018-09-28T15:51:05Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Catalog Price Rules End Date not working as expected. M 1934, LTS version\r\n\r\nProblem: When setting a Catalog Price Rule to start 1-12 and end 31-12. For this to work we need to set start date _instead_ as 30-11 and end date to 30-12. Backend adminhtml US language. European Time. Server time (now) = Thu Feb  1 13:38:11 CET 2018 and corresponds with the actual time.\r\n\r\n\r\nProblem also confirmed here:\r\n- https://magento.stackexchange.com/questions/170961/magento-catalog-price-rule-date-not-working-properly#\r\n- https://magento.stackexchange.com/questions/171093/magento-issue-with-dates-for-catalog-price-rule\r\n- (possible solution) https://magento.stackexchange.com/questions/61045/catalog-price-rule-from-today-does-not-apply\r\n\r\n![image](https://user-images.githubusercontent.com/652395/35678805-fe2722c2-0754-11e8-8933-f6a0ec580ce7.png)\r\n\r\nIn file 'Mage/CatalogRule/Model/Resource/Rule.php' I dont know why they are adding 1 day?\r\n\r\n![image](https://user-images.githubusercontent.com/652395/35679011-caabcf64-0755-11e8-887e-d027cba68598.png)\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/OpenMage/magento-lts/issues/comments/425480177","html_url":"https://github.com/OpenMage/magento-lts/issues/443#issuecomment-425480177","issue_url":"https://api.github.com/repos/OpenMage/magento-lts/issues/443","id":425480177,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTQ4MDE3Nw==","user":{"login":"ryangrow","id":28578238,"node_id":"MDQ6VXNlcjI4NTc4MjM4","avatar_url":"https://avatars0.githubusercontent.com/u/28578238?v=4","gravatar_id":"","url":"https://api.github.com/users/ryangrow","html_url":"https://github.com/ryangrow","followers_url":"https://api.github.com/users/ryangrow/followers","following_url":"https://api.github.com/users/ryangrow/following{/other_user}","gists_url":"https://api.github.com/users/ryangrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ryangrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryangrow/subscriptions","organizations_url":"https://api.github.com/users/ryangrow/orgs","repos_url":"https://api.github.com/users/ryangrow/repos","events_url":"https://api.github.com/users/ryangrow/events{/privacy}","received_events_url":"https://api.github.com/users/ryangrow/received_events","type":"User","site_admin":false},"created_at":"2018-09-28T15:51:05Z","updated_at":"2018-09-28T15:51:05Z","author_association":"NONE","body":"In your code you are adding a set amount of extra time (a day -1 sec) to the the rules \"to time\" (which is stored as a date in MySQL) this will work for your time zone, if your before GMT, but not if your after. The real cause of the problem is that the rules are calculated in GMT but should be calculated for the time zone. \r\n\r\nIronically in my magento install I don't calculate price rules in a cron anymore, but I do it on the fly in MySQL when I get the product collection, and I avoid this whole mess, I also gave up on the price index as well. "}}
{"actor":{"display_login":"ryangrow"}}