{"action":"created","comment":{"url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/pulls/comments/224103247","pull_request_review_id":163389353,"id":224103247,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDEwMzI0Nw==","diff_hunk":"@@ -288,9 +296,34 @@ public void fromDefaults() throws Exception\n     }\n \n     @Test\n-    public void validateInclude() throws Exception\n+    public void searchParameterIncludesValidation_validInclude_shouldReturnSuccessfulValidation()\n     {\n+        searchMapper.validateInclude(Arrays.asList(PARAM_INCLUDE_ALLOWABLEOPERATIONS,PARAM_INCLUDE_ASPECTNAMES,\n+                PARAM_INCLUDE_ISLINK, PARAM_INCLUDE_PATH, PARAM_INCLUDE_PROPERTIES,\n+                PARAM_INCLUDE_ASSOCIATION, PARAM_INCLUDE_ISLOCKED, PARAM_INCLUDE_PERMISSIONS));\n+    }\n \n+    \n+    @Test\n+    public void searchParameterIncludesValidation_invalidInclude_shouldThrowInvalidArgumentException() throws Exception","path":"src/test/java/org/alfresco/rest/api/search/SearchMapperTests.java","position":29,"original_position":29,"commit_id":"53ebc2d0e1fd9706973c50eff6690957677e385d","original_commit_id":"53ebc2d0e1fd9706973c50eff6690957677e385d","user":{"login":"tunaaksoy","id":4615249,"node_id":"MDQ6VXNlcjQ2MTUyNDk=","avatar_url":"https://avatars3.githubusercontent.com/u/4615249?v=4","gravatar_id":"","url":"https://api.github.com/users/tunaaksoy","html_url":"https://github.com/tunaaksoy","followers_url":"https://api.github.com/users/tunaaksoy/followers","following_url":"https://api.github.com/users/tunaaksoy/following{/other_user}","gists_url":"https://api.github.com/users/tunaaksoy/gists{/gist_id}","starred_url":"https://api.github.com/users/tunaaksoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tunaaksoy/subscriptions","organizations_url":"https://api.github.com/users/tunaaksoy/orgs","repos_url":"https://api.github.com/users/tunaaksoy/repos","events_url":"https://api.github.com/users/tunaaksoy/events{/privacy}","received_events_url":"https://api.github.com/users/tunaaksoy/received_events","type":"User","site_admin":false},"body":"Is this new test really needed? Is it not already covered with the existing validateInclude method? And maybe the same existing method could have been extended to cover the newly added parameters?","created_at":"2018-10-10T14:34:31Z","updated_at":"2018-10-10T14:34:31Z","html_url":"https://github.com/Alfresco/alfresco-remote-api/pull/85#discussion_r224103247","pull_request_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/pulls/85","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Alfresco/alfresco-remote-api/pulls/comments/224103247"},"html":{"href":"https://github.com/Alfresco/alfresco-remote-api/pull/85#discussion_r224103247"},"pull_request":{"href":"https://api.github.com/repos/Alfresco/alfresco-remote-api/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/pulls/85","id":221810065,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxODEwMDY1","html_url":"https://github.com/Alfresco/alfresco-remote-api/pull/85","diff_url":"https://github.com/Alfresco/alfresco-remote-api/pull/85.diff","patch_url":"https://github.com/Alfresco/alfresco-remote-api/pull/85.patch","issue_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/issues/85","number":85,"state":"open","locked":false,"title":"[MNT-19952] Missing valid includes added (permissions, isLocked)","user":{"login":"alessandrobenedetti","id":513195,"node_id":"MDQ6VXNlcjUxMzE5NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/513195?v=4","gravatar_id":"","url":"https://api.github.com/users/alessandrobenedetti","html_url":"https://github.com/alessandrobenedetti","followers_url":"https://api.github.com/users/alessandrobenedetti/followers","following_url":"https://api.github.com/users/alessandrobenedetti/following{/other_user}","gists_url":"https://api.github.com/users/alessandrobenedetti/gists{/gist_id}","starred_url":"https://api.github.com/users/alessandrobenedetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alessandrobenedetti/subscriptions","organizations_url":"https://api.github.com/users/alessandrobenedetti/orgs","repos_url":"https://api.github.com/users/alessandrobenedetti/repos","events_url":"https://api.github.com/users/alessandrobenedetti/events{/privacy}","received_events_url":"https://api.github.com/users/alessandrobenedetti/received_events","type":"User","site_admin":false},"body":"This PR is meant to add 2 valid includes ('permissions' and 'isLocked') to the allowed includes list.\r\nIt includes a simple unit test associated.\r\nIntegration tests are located in the appropriate external project.","created_at":"2018-10-10T14:24:01Z","updated_at":"2018-10-10T14:34:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c2c5c099a196c7e0082154cff0d60e556355176","assignee":null,"assignees":[],"requested_reviewers":[{"login":"michaelsuzukisagi","id":2110513,"node_id":"MDQ6VXNlcjIxMTA1MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2110513?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelsuzukisagi","html_url":"https://github.com/michaelsuzukisagi","followers_url":"https://api.github.com/users/michaelsuzukisagi/followers","following_url":"https://api.github.com/users/michaelsuzukisagi/following{/other_user}","gists_url":"https://api.github.com/users/michaelsuzukisagi/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelsuzukisagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelsuzukisagi/subscriptions","organizations_url":"https://api.github.com/users/michaelsuzukisagi/orgs","repos_url":"https://api.github.com/users/michaelsuzukisagi/repos","events_url":"https://api.github.com/users/michaelsuzukisagi/events{/privacy}","received_events_url":"https://api.github.com/users/michaelsuzukisagi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/pulls/85/commits","review_comments_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/pulls/85/comments","review_comment_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/issues/85/comments","statuses_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/statuses/53ebc2d0e1fd9706973c50eff6690957677e385d","head":{"label":"SeaseLtd:fix/MNT-19952_permissions_islocked_includes","ref":"fix/MNT-19952_permissions_islocked_includes","sha":"53ebc2d0e1fd9706973c50eff6690957677e385d","user":{"login":"SeaseLtd","id":38129003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTI5MDAz","avatar_url":"https://avatars2.githubusercontent.com/u/38129003?v=4","gravatar_id":"","url":"https://api.github.com/users/SeaseLtd","html_url":"https://github.com/SeaseLtd","followers_url":"https://api.github.com/users/SeaseLtd/followers","following_url":"https://api.github.com/users/SeaseLtd/following{/other_user}","gists_url":"https://api.github.com/users/SeaseLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/SeaseLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeaseLtd/subscriptions","organizations_url":"https://api.github.com/users/SeaseLtd/orgs","repos_url":"https://api.github.com/users/SeaseLtd/repos","events_url":"https://api.github.com/users/SeaseLtd/events{/privacy}","received_events_url":"https://api.github.com/users/SeaseLtd/received_events","type":"Organization","site_admin":false},"repo":{"id":152428363,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI0MjgzNjM=","name":"alfresco-remote-api","full_name":"SeaseLtd/alfresco-remote-api","private":false,"owner":{"login":"SeaseLtd","id":38129003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTI5MDAz","avatar_url":"https://avatars2.githubusercontent.com/u/38129003?v=4","gravatar_id":"","url":"https://api.github.com/users/SeaseLtd","html_url":"https://github.com/SeaseLtd","followers_url":"https://api.github.com/users/SeaseLtd/followers","following_url":"https://api.github.com/users/SeaseLtd/following{/other_user}","gists_url":"https://api.github.com/users/SeaseLtd/gists{/gist_id}","starred_url":"https://api.github.com/users/SeaseLtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeaseLtd/subscriptions","organizations_url":"https://api.github.com/users/SeaseLtd/orgs","repos_url":"https://api.github.com/users/SeaseLtd/repos","events_url":"https://api.github.com/users/SeaseLtd/events{/privacy}","received_events_url":"https://api.github.com/users/SeaseLtd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SeaseLtd/alfresco-remote-api","description":"REST API layer for Alfresco Content Services (Community and Enterprise)","fork":true,"url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api","forks_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/forks","keys_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/teams","hooks_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/hooks","issue_events_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/issues/events{/number}","events_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/events","assignees_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/assignees{/user}","branches_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/branches{/branch}","tags_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/tags","blobs_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/statuses/{sha}","languages_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/languages","stargazers_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/stargazers","contributors_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/contributors","subscribers_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/subscribers","subscription_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/subscription","commits_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/contents/{+path}","compare_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/merges","archive_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/downloads","issues_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/issues{/number}","pulls_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/pulls{/number}","milestones_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/milestones{/number}","notifications_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/labels{/name}","releases_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/releases{/id}","deployments_url":"https://api.github.com/repos/SeaseLtd/alfresco-remote-api/deployments","created_at":"2018-10-10T13:29:59Z","updated_at":"2018-10-10T13:30:07Z","pushed_at":"2018-10-10T13:40:48Z","git_url":"git://github.com/SeaseLtd/alfresco-remote-api.git","ssh_url":"git@github.com:SeaseLtd/alfresco-remote-api.git","clone_url":"https://github.com/SeaseLtd/alfresco-remote-api.git","svn_url":"https://github.com/SeaseLtd/alfresco-remote-api","homepage":"https://www.alfresco.com/platform/content-services-ecm/trial/download","size":39808,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Alfresco:master","ref":"master","sha":"4ebda081942e7a21b1e1b0570d26ca6afbc7cb8c","user":{"login":"Alfresco","id":391127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTEyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/391127?v=4","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"repo":{"id":98433624,"node_id":"MDEwOlJlcG9zaXRvcnk5ODQzMzYyNA==","name":"alfresco-remote-api","full_name":"Alfresco/alfresco-remote-api","private":false,"owner":{"login":"Alfresco","id":391127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTEyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/391127?v=4","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Alfresco/alfresco-remote-api","description":"REST API layer for Alfresco Content Services (Community and Enterprise)","fork":false,"url":"https://api.github.com/repos/Alfresco/alfresco-remote-api","forks_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/forks","keys_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/teams","hooks_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/hooks","issue_events_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/issues/events{/number}","events_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/events","assignees_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/assignees{/user}","branches_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/branches{/branch}","tags_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/tags","blobs_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/statuses/{sha}","languages_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/languages","stargazers_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/stargazers","contributors_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/contributors","subscribers_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/subscribers","subscription_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/subscription","commits_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/contents/{+path}","compare_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/merges","archive_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/downloads","issues_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/issues{/number}","pulls_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/pulls{/number}","milestones_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/milestones{/number}","notifications_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/labels{/name}","releases_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/releases{/id}","deployments_url":"https://api.github.com/repos/Alfresco/alfresco-remote-api/deployments","created_at":"2017-07-26T14:43:20Z","updated_at":"2018-10-10T11:37:19Z","pushed_at":"2018-10-10T14:29:15Z","git_url":"git://github.com/Alfresco/alfresco-remote-api.git","ssh_url":"git@github.com:Alfresco/alfresco-remote-api.git","clone_url":"https://github.com/Alfresco/alfresco-remote-api.git","svn_url":"https://github.com/Alfresco/alfresco-remote-api","homepage":"https://www.alfresco.com/platform/content-services-ecm/trial/download","size":39808,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":6,"open_issues":3,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alfresco/alfresco-remote-api/pulls/85"},"html":{"href":"https://github.com/Alfresco/alfresco-remote-api/pull/85"},"issue":{"href":"https://api.github.com/repos/Alfresco/alfresco-remote-api/issues/85"},"comments":{"href":"https://api.github.com/repos/Alfresco/alfresco-remote-api/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/Alfresco/alfresco-remote-api/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/Alfresco/alfresco-remote-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alfresco/alfresco-remote-api/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/Alfresco/alfresco-remote-api/statuses/53ebc2d0e1fd9706973c50eff6690957677e385d"}},"author_association":"NONE"}}
{"actor":{"display_login":"tunaaksoy"}}