{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/202520298","pull_request_review_id":137243515,"id":202520298,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjUyMDI5OA==","diff_hunk":"@@ -1,5 +1,8 @@\n # make it explicit that we favor the new container-based travis workers\n-sudo: false\n+sudo: required","path":".travis.yml","position":3,"original_position":3,"commit_id":"61733cf4c337c0a0f3a1681aecc35dedd134c65f","original_commit_id":"a0c67b458fe87d0d7c77c16bcf2837c98cbdb6c9","user":{"login":"rth","id":630936,"node_id":"MDQ6VXNlcjYzMDkzNg==","avatar_url":"https://avatars0.githubusercontent.com/u/630936?v=4","gravatar_id":"","url":"https://api.github.com/users/rth","html_url":"https://github.com/rth","followers_url":"https://api.github.com/users/rth/followers","following_url":"https://api.github.com/users/rth/following{/other_user}","gists_url":"https://api.github.com/users/rth/gists{/gist_id}","starred_url":"https://api.github.com/users/rth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rth/subscriptions","organizations_url":"https://api.github.com/users/rth/orgs","repos_url":"https://api.github.com/users/rth/repos","events_url":"https://api.github.com/users/rth/events{/privacy}","received_events_url":"https://api.github.com/users/rth/received_events","type":"User","site_admin":false},"body":"I know this is necessary, but this will negatively impact all the other builds, won't it?\r\n\r\nI wonder if there is a way to conditionally enable docker service and sudo only when it's needed. Another alternative is to use this docker image in CircleCI but it doesn't have a cron functionality..","created_at":"2018-07-14T17:07:58Z","updated_at":"2018-07-14T17:08:01Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/11515#discussion_r202520298","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11515","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/202520298"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/11515#discussion_r202520298"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11515"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11515","id":201459792,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDU5Nzky","html_url":"https://github.com/scikit-learn/scikit-learn/pull/11515","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/11515.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/11515.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11515","number":11515,"state":"open","locked":false,"title":"WIP: Add 32bit testing in travis for scikit-learn","user":{"login":"jrmlhermitte","id":705366,"node_id":"MDQ6VXNlcjcwNTM2Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/705366?v=4","gravatar_id":"","url":"https://api.github.com/users/jrmlhermitte","html_url":"https://github.com/jrmlhermitte","followers_url":"https://api.github.com/users/jrmlhermitte/followers","following_url":"https://api.github.com/users/jrmlhermitte/following{/other_user}","gists_url":"https://api.github.com/users/jrmlhermitte/gists{/gist_id}","starred_url":"https://api.github.com/users/jrmlhermitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrmlhermitte/subscriptions","organizations_url":"https://api.github.com/users/jrmlhermitte/orgs","repos_url":"https://api.github.com/users/jrmlhermitte/repos","events_url":"https://api.github.com/users/jrmlhermitte/events{/privacy}","received_events_url":"https://api.github.com/users/jrmlhermitte/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist\r\n-->\r\nWIP: Not complete yet. Tested locally. 13 tests fail. Now trying to run on Travis.\r\n\r\n\r\n\r\n#### Reference Issues/PRs\r\nAttempt to close #9352 \r\n\r\n#### What does this implement/fix? Explain your changes.\r\n\r\n\r\n#### Any other comments?\r\n\r\n\r\n<!--\r\nPlease be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n\r\nThanks for contributing!\r\n-->\r\n","created_at":"2018-07-14T16:54:55Z","updated_at":"2018-07-14T17:08:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59737eba29616eb7892d128799862bb49acaf0f3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11515/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11515/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11515/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/61733cf4c337c0a0f3a1681aecc35dedd134c65f","head":{"label":"jrmlhermitte:docker-32bit","ref":"docker-32bit","sha":"61733cf4c337c0a0f3a1681aecc35dedd134c65f","user":{"login":"jrmlhermitte","id":705366,"node_id":"MDQ6VXNlcjcwNTM2Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/705366?v=4","gravatar_id":"","url":"https://api.github.com/users/jrmlhermitte","html_url":"https://github.com/jrmlhermitte","followers_url":"https://api.github.com/users/jrmlhermitte/followers","following_url":"https://api.github.com/users/jrmlhermitte/following{/other_user}","gists_url":"https://api.github.com/users/jrmlhermitte/gists{/gist_id}","starred_url":"https://api.github.com/users/jrmlhermitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrmlhermitte/subscriptions","organizations_url":"https://api.github.com/users/jrmlhermitte/orgs","repos_url":"https://api.github.com/users/jrmlhermitte/repos","events_url":"https://api.github.com/users/jrmlhermitte/events{/privacy}","received_events_url":"https://api.github.com/users/jrmlhermitte/received_events","type":"User","site_admin":false},"repo":{"id":140955212,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA5NTUyMTI=","name":"scikit-learn","full_name":"jrmlhermitte/scikit-learn","owner":{"login":"jrmlhermitte","id":705366,"node_id":"MDQ6VXNlcjcwNTM2Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/705366?v=4","gravatar_id":"","url":"https://api.github.com/users/jrmlhermitte","html_url":"https://github.com/jrmlhermitte","followers_url":"https://api.github.com/users/jrmlhermitte/followers","following_url":"https://api.github.com/users/jrmlhermitte/following{/other_user}","gists_url":"https://api.github.com/users/jrmlhermitte/gists{/gist_id}","starred_url":"https://api.github.com/users/jrmlhermitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrmlhermitte/subscriptions","organizations_url":"https://api.github.com/users/jrmlhermitte/orgs","repos_url":"https://api.github.com/users/jrmlhermitte/repos","events_url":"https://api.github.com/users/jrmlhermitte/events{/privacy}","received_events_url":"https://api.github.com/users/jrmlhermitte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrmlhermitte/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/jrmlhermitte/scikit-learn","forks_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/forks","keys_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/teams","hooks_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/events","assignees_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/tags","blobs_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/subscription","commits_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/merges","archive_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/downloads","issues_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/jrmlhermitte/scikit-learn/deployments","created_at":"2018-07-14T15:06:29Z","updated_at":"2018-07-14T15:06:36Z","pushed_at":"2018-07-14T17:07:48Z","git_url":"git://github.com/jrmlhermitte/scikit-learn.git","ssh_url":"git@github.com:jrmlhermitte/scikit-learn.git","clone_url":"https://github.com/jrmlhermitte/scikit-learn.git","svn_url":"https://github.com/jrmlhermitte/scikit-learn","homepage":"http://scikit-learn.org","size":91421,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"eeee6a508550a20a2cac72f32a069bfce4f752a2","user":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"node_id":"MDEwOlJlcG9zaXRvcnk4NDMyMjI=","name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2018-07-14T16:39:17Z","pushed_at":"2018-07-14T17:07:51Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":91421,"stargazers_count":29319,"watchers_count":29319,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14549,"mirror_url":null,"archived":false,"open_issues_count":1678,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14549,"open_issues":1678,"watchers":29319,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11515"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/11515"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11515"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11515/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11515/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11515/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/61733cf4c337c0a0f3a1681aecc35dedd134c65f"}},"author_association":"NONE"}}
{"actor":{"display_login":"rth"}}