{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/168309474","pull_request_review_id":96655867,"id":168309474,"diff_hunk":"@@ -115,3 +118,48 @@ func SplitByAvailablePods(minReadySeconds int32, pods []*v1.Pod) ([]*v1.Pod, []*\n \t}\n \treturn availablePods, unavailablePods\n }\n+\n+// AppendDaemonSetPodNodeAffinity creates NodeAffinity entry for DaemonSet controller\n+func AppendDaemonSetPodNodeAffinity(affinity *v1.Affinity, hostname string) *v1.Affinity {","path":"pkg/controller/daemon/util/daemonset_util.go","position":16,"original_position":16,"commit_id":"4e3d1a2607d2a9756a9507a333f0388fa5d5fac4","original_commit_id":"4e3d1a2607d2a9756a9507a333f0388fa5d5fac4","user":{"login":"bsalamat","id":14308438,"avatar_url":"https://avatars3.githubusercontent.com/u/14308438?v=4","gravatar_id":"","url":"https://api.github.com/users/bsalamat","html_url":"https://github.com/bsalamat","followers_url":"https://api.github.com/users/bsalamat/followers","following_url":"https://api.github.com/users/bsalamat/following{/other_user}","gists_url":"https://api.github.com/users/bsalamat/gists{/gist_id}","starred_url":"https://api.github.com/users/bsalamat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsalamat/subscriptions","organizations_url":"https://api.github.com/users/bsalamat/orgs","repos_url":"https://api.github.com/users/bsalamat/repos","events_url":"https://api.github.com/users/bsalamat/events{/privacy}","received_events_url":"https://api.github.com/users/bsalamat/received_events","type":"User","site_admin":false},"body":"s/hostname/nodeName/\r\nI know that our affinity key for node name is called \"kubernetes.io/hostname\", but that was a bit unfortunate. We should use \"node\" instead of \"host\". \"Node\" is the right word in K8s terminology.","created_at":"2018-02-14T21:06:00Z","updated_at":"2018-02-14T21:07:06Z","html_url":"https://github.com/kubernetes/kubernetes/pull/59798#discussion_r168309474","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59798","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/168309474"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/59798#discussion_r168309474"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59798"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59798","id":168842282,"html_url":"https://github.com/kubernetes/kubernetes/pull/59798","diff_url":"https://github.com/kubernetes/kubernetes/pull/59798.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/59798.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59798","number":59798,"state":"open","locked":false,"title":"Task 2: Helper func to add NodeAffinity to DaemonSet Pod.","user":{"login":"k82cn","id":18107181,"avatar_url":"https://avatars0.githubusercontent.com/u/18107181?v=4","gravatar_id":"","url":"https://api.github.com/users/k82cn","html_url":"https://github.com/k82cn","followers_url":"https://api.github.com/users/k82cn/followers","following_url":"https://api.github.com/users/k82cn/following{/other_user}","gists_url":"https://api.github.com/users/k82cn/gists{/gist_id}","starred_url":"https://api.github.com/users/k82cn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k82cn/subscriptions","organizations_url":"https://api.github.com/users/k82cn/orgs","repos_url":"https://api.github.com/users/k82cn/repos","events_url":"https://api.github.com/users/k82cn/events{/privacy}","received_events_url":"https://api.github.com/users/k82cn/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Da K. Ma <madaxa@cn.ibm.com>\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\npart of #59194\r\n\r\n\r\n**Release note**:\r\n\r\n```release-note\r\nNone\r\n```\r\n","created_at":"2018-02-13T13:19:28Z","updated_at":"2018-02-14T21:07:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"116cf1b79cdc5f9fd7614099d167ebdd399c89b3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars1.githubusercontent.com/u/4876867?v=4","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false},{"login":"kow3ns","id":11380896,"avatar_url":"https://avatars3.githubusercontent.com/u/11380896?v=4","gravatar_id":"","url":"https://api.github.com/users/kow3ns","html_url":"https://github.com/kow3ns","followers_url":"https://api.github.com/users/kow3ns/followers","following_url":"https://api.github.com/users/kow3ns/following{/other_user}","gists_url":"https://api.github.com/users/kow3ns/gists{/gist_id}","starred_url":"https://api.github.com/users/kow3ns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kow3ns/subscriptions","organizations_url":"https://api.github.com/users/kow3ns/orgs","repos_url":"https://api.github.com/users/kow3ns/repos","events_url":"https://api.github.com/users/kow3ns/events{/privacy}","received_events_url":"https://api.github.com/users/kow3ns/received_events","type":"User","site_admin":false},{"login":"tnozicka","id":11869554,"avatar_url":"https://avatars2.githubusercontent.com/u/11869554?v=4","gravatar_id":"","url":"https://api.github.com/users/tnozicka","html_url":"https://github.com/tnozicka","followers_url":"https://api.github.com/users/tnozicka/followers","following_url":"https://api.github.com/users/tnozicka/following{/other_user}","gists_url":"https://api.github.com/users/tnozicka/gists{/gist_id}","starred_url":"https://api.github.com/users/tnozicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnozicka/subscriptions","organizations_url":"https://api.github.com/users/tnozicka/orgs","repos_url":"https://api.github.com/users/tnozicka/repos","events_url":"https://api.github.com/users/tnozicka/events{/privacy}","received_events_url":"https://api.github.com/users/tnozicka/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59798/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59798/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59798/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/4e3d1a2607d2a9756a9507a333f0388fa5d5fac4","head":{"label":"k82cn:k8s_59194_2","ref":"k8s_59194_2","sha":"4e3d1a2607d2a9756a9507a333f0388fa5d5fac4","user":{"login":"k82cn","id":18107181,"avatar_url":"https://avatars0.githubusercontent.com/u/18107181?v=4","gravatar_id":"","url":"https://api.github.com/users/k82cn","html_url":"https://github.com/k82cn","followers_url":"https://api.github.com/users/k82cn/followers","following_url":"https://api.github.com/users/k82cn/following{/other_user}","gists_url":"https://api.github.com/users/k82cn/gists{/gist_id}","starred_url":"https://api.github.com/users/k82cn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k82cn/subscriptions","organizations_url":"https://api.github.com/users/k82cn/orgs","repos_url":"https://api.github.com/users/k82cn/repos","events_url":"https://api.github.com/users/k82cn/events{/privacy}","received_events_url":"https://api.github.com/users/k82cn/received_events","type":"User","site_admin":false},"repo":{"id":54859017,"name":"kubernetes","full_name":"k82cn/kubernetes","owner":{"login":"k82cn","id":18107181,"avatar_url":"https://avatars0.githubusercontent.com/u/18107181?v=4","gravatar_id":"","url":"https://api.github.com/users/k82cn","html_url":"https://github.com/k82cn","followers_url":"https://api.github.com/users/k82cn/followers","following_url":"https://api.github.com/users/k82cn/following{/other_user}","gists_url":"https://api.github.com/users/k82cn/gists{/gist_id}","starred_url":"https://api.github.com/users/k82cn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k82cn/subscriptions","organizations_url":"https://api.github.com/users/k82cn/orgs","repos_url":"https://api.github.com/users/k82cn/repos","events_url":"https://api.github.com/users/k82cn/events{/privacy}","received_events_url":"https://api.github.com/users/k82cn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/k82cn/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/k82cn/kubernetes","forks_url":"https://api.github.com/repos/k82cn/kubernetes/forks","keys_url":"https://api.github.com/repos/k82cn/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/k82cn/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/k82cn/kubernetes/teams","hooks_url":"https://api.github.com/repos/k82cn/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/k82cn/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/k82cn/kubernetes/events","assignees_url":"https://api.github.com/repos/k82cn/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/k82cn/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/k82cn/kubernetes/tags","blobs_url":"https://api.github.com/repos/k82cn/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/k82cn/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/k82cn/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/k82cn/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/k82cn/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/k82cn/kubernetes/languages","stargazers_url":"https://api.github.com/repos/k82cn/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/k82cn/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/k82cn/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/k82cn/kubernetes/subscription","commits_url":"https://api.github.com/repos/k82cn/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/k82cn/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/k82cn/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/k82cn/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/k82cn/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/k82cn/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/k82cn/kubernetes/merges","archive_url":"https://api.github.com/repos/k82cn/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/k82cn/kubernetes/downloads","issues_url":"https://api.github.com/repos/k82cn/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/k82cn/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/k82cn/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/k82cn/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/k82cn/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/k82cn/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/k82cn/kubernetes/deployments","created_at":"2016-03-28T02:16:04Z","updated_at":"2017-07-31T18:42:51Z","pushed_at":"2018-02-14T09:14:48Z","git_url":"git://github.com/k82cn/kubernetes.git","ssh_url":"git@github.com:k82cn/kubernetes.git","clone_url":"https://github.com/k82cn/kubernetes.git","svn_url":"https://github.com/k82cn/kubernetes","homepage":"http://kubernetes.io","size":526588,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"6c91c420b6fd0bbbc3c2d6b29b8ee1b3d1ffdfc2","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-02-14T19:22:57Z","pushed_at":"2018-02-14T21:06:58Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":753286,"stargazers_count":32553,"watchers_count":32553,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11499,"mirror_url":null,"archived":false,"open_issues_count":5049,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":11499,"open_issues":5049,"watchers":32553,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59798"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/59798"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/59798"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/59798/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59798/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59798/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/4e3d1a2607d2a9756a9507a333f0388fa5d5fac4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bsalamat"}}