{"action":"created","comment":{"url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/comments/171694461","pull_request_review_id":100594079,"id":171694461,"diff_hunk":"@@ -961,6 +961,33 @@ json::value KubernetesReader::FindTopLevelOwner(\n   return FindTopLevelOwner(ns, GetOwner(ns, ref->As<json::Object>()));\n }\n \n+bool KubernetesReader::ValidateConfiguration() const {\n+  try {\n+    (void) QueryMaster(std::string(kKubernetesEndpointPath) + \"/nodes?limit=1\");\n+  } catch (const QueryException& e) {\n+    // Already logged.\n+    return false;\n+  }\n+\n+  try {\n+    const std::string pod_label_selector(\n+        config_.KubernetesPodLabelSelector().empty()\n+        ? \"\" : \"&\" + config_.KubernetesPodLabelSelector());\n+\n+    (void) QueryMaster(std::string(kKubernetesEndpointPath) + \"/pods?limit=1\" +\n+                       pod_label_selector);","path":"src/kubernetes.cc","position":18,"original_position":18,"commit_id":"275bfbb490d0bc7989d691b288f8ab2c07735c5d","original_commit_id":"c5fbc290f334129591c059cba728b12dedd8bac8","user":{"login":"bmoyles0117","id":264816,"avatar_url":"https://avatars0.githubusercontent.com/u/264816?v=4","gravatar_id":"","url":"https://api.github.com/users/bmoyles0117","html_url":"https://github.com/bmoyles0117","followers_url":"https://api.github.com/users/bmoyles0117/followers","following_url":"https://api.github.com/users/bmoyles0117/following{/other_user}","gists_url":"https://api.github.com/users/bmoyles0117/gists{/gist_id}","starred_url":"https://api.github.com/users/bmoyles0117/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmoyles0117/subscriptions","organizations_url":"https://api.github.com/users/bmoyles0117/orgs","repos_url":"https://api.github.com/users/bmoyles0117/repos","events_url":"https://api.github.com/users/bmoyles0117/events{/privacy}","received_events_url":"https://api.github.com/users/bmoyles0117/received_events","type":"User","site_admin":false},"body":"`pod_label_selector` does not imply passing a limit, it implies passing labels, if a user is passing a limit there, that's a hack, and should be validated elsewhere.","created_at":"2018-03-01T21:10:12Z","updated_at":"2018-03-01T21:15:22Z","html_url":"https://github.com/Stackdriver/metadata-agent/pull/63#discussion_r171694461","pull_request_url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/63","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/comments/171694461"},"html":{"href":"https://github.com/Stackdriver/metadata-agent/pull/63#discussion_r171694461"},"pull_request":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/63"}},"in_reply_to_id":171690292},"pull_request":{"url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/63","id":171505514,"html_url":"https://github.com/Stackdriver/metadata-agent/pull/63","diff_url":"https://github.com/Stackdriver/metadata-agent/pull/63.diff","patch_url":"https://github.com/Stackdriver/metadata-agent/pull/63.patch","issue_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/63","number":63,"state":"open","locked":false,"title":"Add validation to only start updaters if they're configured properly.","user":{"login":"bmoyles0117","id":264816,"avatar_url":"https://avatars0.githubusercontent.com/u/264816?v=4","gravatar_id":"","url":"https://api.github.com/users/bmoyles0117","html_url":"https://github.com/bmoyles0117","followers_url":"https://api.github.com/users/bmoyles0117/followers","following_url":"https://api.github.com/users/bmoyles0117/following{/other_user}","gists_url":"https://api.github.com/users/bmoyles0117/gists{/gist_id}","starred_url":"https://api.github.com/users/bmoyles0117/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmoyles0117/subscriptions","organizations_url":"https://api.github.com/users/bmoyles0117/orgs","repos_url":"https://api.github.com/users/bmoyles0117/repos","events_url":"https://api.github.com/users/bmoyles0117/events{/privacy}","received_events_url":"https://api.github.com/users/bmoyles0117/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-26T22:06:49Z","updated_at":"2018-03-01T21:15:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b9467c6ce9a9538e22e5d2f19fc35a377d98492","assignee":null,"assignees":[],"requested_reviewers":[{"login":"qingling128","id":5287526,"avatar_url":"https://avatars1.githubusercontent.com/u/5287526?v=4","gravatar_id":"","url":"https://api.github.com/users/qingling128","html_url":"https://github.com/qingling128","followers_url":"https://api.github.com/users/qingling128/followers","following_url":"https://api.github.com/users/qingling128/following{/other_user}","gists_url":"https://api.github.com/users/qingling128/gists{/gist_id}","starred_url":"https://api.github.com/users/qingling128/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qingling128/subscriptions","organizations_url":"https://api.github.com/users/qingling128/orgs","repos_url":"https://api.github.com/users/qingling128/repos","events_url":"https://api.github.com/users/qingling128/events{/privacy}","received_events_url":"https://api.github.com/users/qingling128/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/63/commits","review_comments_url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/63/comments","review_comment_url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/63/comments","statuses_url":"https://api.github.com/repos/Stackdriver/metadata-agent/statuses/275bfbb490d0bc7989d691b288f8ab2c07735c5d","head":{"label":"Stackdriver:bmoyles0117-pollers-inspect-env","ref":"bmoyles0117-pollers-inspect-env","sha":"275bfbb490d0bc7989d691b288f8ab2c07735c5d","user":{"login":"Stackdriver","id":2104369,"avatar_url":"https://avatars3.githubusercontent.com/u/2104369?v=4","gravatar_id":"","url":"https://api.github.com/users/Stackdriver","html_url":"https://github.com/Stackdriver","followers_url":"https://api.github.com/users/Stackdriver/followers","following_url":"https://api.github.com/users/Stackdriver/following{/other_user}","gists_url":"https://api.github.com/users/Stackdriver/gists{/gist_id}","starred_url":"https://api.github.com/users/Stackdriver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stackdriver/subscriptions","organizations_url":"https://api.github.com/users/Stackdriver/orgs","repos_url":"https://api.github.com/users/Stackdriver/repos","events_url":"https://api.github.com/users/Stackdriver/events{/privacy}","received_events_url":"https://api.github.com/users/Stackdriver/received_events","type":"Organization","site_admin":false},"repo":{"id":81396310,"name":"metadata-agent","full_name":"Stackdriver/metadata-agent","owner":{"login":"Stackdriver","id":2104369,"avatar_url":"https://avatars3.githubusercontent.com/u/2104369?v=4","gravatar_id":"","url":"https://api.github.com/users/Stackdriver","html_url":"https://github.com/Stackdriver","followers_url":"https://api.github.com/users/Stackdriver/followers","following_url":"https://api.github.com/users/Stackdriver/following{/other_user}","gists_url":"https://api.github.com/users/Stackdriver/gists{/gist_id}","starred_url":"https://api.github.com/users/Stackdriver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stackdriver/subscriptions","organizations_url":"https://api.github.com/users/Stackdriver/orgs","repos_url":"https://api.github.com/users/Stackdriver/repos","events_url":"https://api.github.com/users/Stackdriver/events{/privacy}","received_events_url":"https://api.github.com/users/Stackdriver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Stackdriver/metadata-agent","description":"Stackdriver metadata agent","fork":false,"url":"https://api.github.com/repos/Stackdriver/metadata-agent","forks_url":"https://api.github.com/repos/Stackdriver/metadata-agent/forks","keys_url":"https://api.github.com/repos/Stackdriver/metadata-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Stackdriver/metadata-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Stackdriver/metadata-agent/teams","hooks_url":"https://api.github.com/repos/Stackdriver/metadata-agent/hooks","issue_events_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/events{/number}","events_url":"https://api.github.com/repos/Stackdriver/metadata-agent/events","assignees_url":"https://api.github.com/repos/Stackdriver/metadata-agent/assignees{/user}","branches_url":"https://api.github.com/repos/Stackdriver/metadata-agent/branches{/branch}","tags_url":"https://api.github.com/repos/Stackdriver/metadata-agent/tags","blobs_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Stackdriver/metadata-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/Stackdriver/metadata-agent/languages","stargazers_url":"https://api.github.com/repos/Stackdriver/metadata-agent/stargazers","contributors_url":"https://api.github.com/repos/Stackdriver/metadata-agent/contributors","subscribers_url":"https://api.github.com/repos/Stackdriver/metadata-agent/subscribers","subscription_url":"https://api.github.com/repos/Stackdriver/metadata-agent/subscription","commits_url":"https://api.github.com/repos/Stackdriver/metadata-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/Stackdriver/metadata-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/Stackdriver/metadata-agent/contents/{+path}","compare_url":"https://api.github.com/repos/Stackdriver/metadata-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Stackdriver/metadata-agent/merges","archive_url":"https://api.github.com/repos/Stackdriver/metadata-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Stackdriver/metadata-agent/downloads","issues_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues{/number}","pulls_url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/Stackdriver/metadata-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/Stackdriver/metadata-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Stackdriver/metadata-agent/labels{/name}","releases_url":"https://api.github.com/repos/Stackdriver/metadata-agent/releases{/id}","deployments_url":"https://api.github.com/repos/Stackdriver/metadata-agent/deployments","created_at":"2017-02-09T01:48:50Z","updated_at":"2018-02-23T23:38:16Z","pushed_at":"2018-03-01T21:15:22Z","git_url":"git://github.com/Stackdriver/metadata-agent.git","ssh_url":"git@github.com:Stackdriver/metadata-agent.git","clone_url":"https://github.com/Stackdriver/metadata-agent.git","svn_url":"https://github.com/Stackdriver/metadata-agent","homepage":"","size":440,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":4,"watchers":4,"default_branch":"master"}},"base":{"label":"Stackdriver:master","ref":"master","sha":"5aa2078ab046adb9c9e7b16c58a52e9db92189f1","user":{"login":"Stackdriver","id":2104369,"avatar_url":"https://avatars3.githubusercontent.com/u/2104369?v=4","gravatar_id":"","url":"https://api.github.com/users/Stackdriver","html_url":"https://github.com/Stackdriver","followers_url":"https://api.github.com/users/Stackdriver/followers","following_url":"https://api.github.com/users/Stackdriver/following{/other_user}","gists_url":"https://api.github.com/users/Stackdriver/gists{/gist_id}","starred_url":"https://api.github.com/users/Stackdriver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stackdriver/subscriptions","organizations_url":"https://api.github.com/users/Stackdriver/orgs","repos_url":"https://api.github.com/users/Stackdriver/repos","events_url":"https://api.github.com/users/Stackdriver/events{/privacy}","received_events_url":"https://api.github.com/users/Stackdriver/received_events","type":"Organization","site_admin":false},"repo":{"id":81396310,"name":"metadata-agent","full_name":"Stackdriver/metadata-agent","owner":{"login":"Stackdriver","id":2104369,"avatar_url":"https://avatars3.githubusercontent.com/u/2104369?v=4","gravatar_id":"","url":"https://api.github.com/users/Stackdriver","html_url":"https://github.com/Stackdriver","followers_url":"https://api.github.com/users/Stackdriver/followers","following_url":"https://api.github.com/users/Stackdriver/following{/other_user}","gists_url":"https://api.github.com/users/Stackdriver/gists{/gist_id}","starred_url":"https://api.github.com/users/Stackdriver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stackdriver/subscriptions","organizations_url":"https://api.github.com/users/Stackdriver/orgs","repos_url":"https://api.github.com/users/Stackdriver/repos","events_url":"https://api.github.com/users/Stackdriver/events{/privacy}","received_events_url":"https://api.github.com/users/Stackdriver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Stackdriver/metadata-agent","description":"Stackdriver metadata agent","fork":false,"url":"https://api.github.com/repos/Stackdriver/metadata-agent","forks_url":"https://api.github.com/repos/Stackdriver/metadata-agent/forks","keys_url":"https://api.github.com/repos/Stackdriver/metadata-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Stackdriver/metadata-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Stackdriver/metadata-agent/teams","hooks_url":"https://api.github.com/repos/Stackdriver/metadata-agent/hooks","issue_events_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/events{/number}","events_url":"https://api.github.com/repos/Stackdriver/metadata-agent/events","assignees_url":"https://api.github.com/repos/Stackdriver/metadata-agent/assignees{/user}","branches_url":"https://api.github.com/repos/Stackdriver/metadata-agent/branches{/branch}","tags_url":"https://api.github.com/repos/Stackdriver/metadata-agent/tags","blobs_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Stackdriver/metadata-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/Stackdriver/metadata-agent/languages","stargazers_url":"https://api.github.com/repos/Stackdriver/metadata-agent/stargazers","contributors_url":"https://api.github.com/repos/Stackdriver/metadata-agent/contributors","subscribers_url":"https://api.github.com/repos/Stackdriver/metadata-agent/subscribers","subscription_url":"https://api.github.com/repos/Stackdriver/metadata-agent/subscription","commits_url":"https://api.github.com/repos/Stackdriver/metadata-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/Stackdriver/metadata-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/Stackdriver/metadata-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/Stackdriver/metadata-agent/contents/{+path}","compare_url":"https://api.github.com/repos/Stackdriver/metadata-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Stackdriver/metadata-agent/merges","archive_url":"https://api.github.com/repos/Stackdriver/metadata-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Stackdriver/metadata-agent/downloads","issues_url":"https://api.github.com/repos/Stackdriver/metadata-agent/issues{/number}","pulls_url":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/Stackdriver/metadata-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/Stackdriver/metadata-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Stackdriver/metadata-agent/labels{/name}","releases_url":"https://api.github.com/repos/Stackdriver/metadata-agent/releases{/id}","deployments_url":"https://api.github.com/repos/Stackdriver/metadata-agent/deployments","created_at":"2017-02-09T01:48:50Z","updated_at":"2018-02-23T23:38:16Z","pushed_at":"2018-03-01T21:15:22Z","git_url":"git://github.com/Stackdriver/metadata-agent.git","ssh_url":"git@github.com:Stackdriver/metadata-agent.git","clone_url":"https://github.com/Stackdriver/metadata-agent.git","svn_url":"https://github.com/Stackdriver/metadata-agent","homepage":"","size":440,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/63"},"html":{"href":"https://github.com/Stackdriver/metadata-agent/pull/63"},"issue":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/63"},"comments":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/Stackdriver/metadata-agent/statuses/275bfbb490d0bc7989d691b288f8ab2c07735c5d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bmoyles0117"}}