{"action":"opened","number":141,"pull_request":{"url":"https://api.github.com/repos/RohanNagar/thunder/pulls/141","id":181972154,"html_url":"https://github.com/RohanNagar/thunder/pull/141","diff_url":"https://github.com/RohanNagar/thunder/pull/141.diff","patch_url":"https://github.com/RohanNagar/thunder/pull/141.patch","issue_url":"https://api.github.com/repos/RohanNagar/thunder/issues/141","number":141,"state":"open","locked":false,"title":"Generalize User Object","user":{"login":"RohanNagar","id":5522930,"avatar_url":"https://avatars3.githubusercontent.com/u/5522930?v=4","gravatar_id":"","url":"https://api.github.com/users/RohanNagar","html_url":"https://github.com/RohanNagar","followers_url":"https://api.github.com/users/RohanNagar/followers","following_url":"https://api.github.com/users/RohanNagar/following{/other_user}","gists_url":"https://api.github.com/users/RohanNagar/gists{/gist_id}","starred_url":"https://api.github.com/users/RohanNagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RohanNagar/subscriptions","organizations_url":"https://api.github.com/users/RohanNagar/orgs","repos_url":"https://api.github.com/users/RohanNagar/repos","events_url":"https://api.github.com/users/RohanNagar/events{/privacy}","received_events_url":"https://api.github.com/users/RohanNagar/received_events","type":"User","site_admin":false},"body":"### This PR addresses:\r\n\r\n<!-- Put a reference to an issue number here,\r\n     or a short description of what this PR addresses if no issue exists -->\r\nAddresses #95\r\n\r\n- Renames `PilotUser` to `User`\r\n- Replaces custom Pilot properties with a `Map<String, Object> properties`. This allows for any number of additional properties to be specified in the JSON, and Thunder will accept it.\r\n\r\n### I have verified that:\r\n\r\n<!-- Ensure all of these boxes are checked -->\r\n- [x] All related unit tests have been updated/created\r\n- [x] Integration tests are passing\r\n\r\n### Additional Notes\r\n\r\n<!-- Put any other additional notes here for reviewers -->\r\nThis is a big refactor, please take your time reviewing.\r\n\r\nThe new user JSON will look like:\r\n\r\n```json\r\n{\r\n  \"email\" : {\r\n    \"address\" : \"test@test.com\",\r\n    \"verified\" : \"true\",\r\n    \"verificationToken\" : \"hashToken\"\r\n  },\r\n  \"password\" : \"12345\",\r\n  \"properties\" : {\r\n    \"facebookAccessToken\" : \"fb\",\r\n    \"myRandomProperty\": 1000,\r\n    \"listsShouldWorkToo\": [\"hello\", \"world\"]\r\n  }\r\n}\r\n```\r\n\r\nTODO in the future: Add more tests for different types of additional properties. Will add an issue once this PR is merged.\r\n","created_at":"2018-04-16T20:00:06Z","updated_at":"2018-04-16T20:00:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":885107756,"url":"https://api.github.com/repos/RohanNagar/thunder/labels/P1","name":"P1","color":"eb6420","default":false},{"id":890288947,"url":"https://api.github.com/repos/RohanNagar/thunder/labels/Size:%20Large","name":"Size: Large","color":"e11d21","default":false},{"id":407188092,"url":"https://api.github.com/repos/RohanNagar/thunder/labels/Type:%20Feature","name":"Type: Feature","color":"8BC34A","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/RohanNagar/thunder/pulls/141/commits","review_comments_url":"https://api.github.com/repos/RohanNagar/thunder/pulls/141/comments","review_comment_url":"https://api.github.com/repos/RohanNagar/thunder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RohanNagar/thunder/issues/141/comments","statuses_url":"https://api.github.com/repos/RohanNagar/thunder/statuses/e38c4c37807f1a4228258fcc857b1efc41ad2b3e","head":{"label":"RohanNagar:general","ref":"general","sha":"e38c4c37807f1a4228258fcc857b1efc41ad2b3e","user":{"login":"RohanNagar","id":5522930,"avatar_url":"https://avatars3.githubusercontent.com/u/5522930?v=4","gravatar_id":"","url":"https://api.github.com/users/RohanNagar","html_url":"https://github.com/RohanNagar","followers_url":"https://api.github.com/users/RohanNagar/followers","following_url":"https://api.github.com/users/RohanNagar/following{/other_user}","gists_url":"https://api.github.com/users/RohanNagar/gists{/gist_id}","starred_url":"https://api.github.com/users/RohanNagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RohanNagar/subscriptions","organizations_url":"https://api.github.com/users/RohanNagar/orgs","repos_url":"https://api.github.com/users/RohanNagar/repos","events_url":"https://api.github.com/users/RohanNagar/events{/privacy}","received_events_url":"https://api.github.com/users/RohanNagar/received_events","type":"User","site_admin":false},"repo":{"id":40055799,"name":"thunder","full_name":"RohanNagar/thunder","owner":{"login":"RohanNagar","id":5522930,"avatar_url":"https://avatars3.githubusercontent.com/u/5522930?v=4","gravatar_id":"","url":"https://api.github.com/users/RohanNagar","html_url":"https://github.com/RohanNagar","followers_url":"https://api.github.com/users/RohanNagar/followers","following_url":"https://api.github.com/users/RohanNagar/following{/other_user}","gists_url":"https://api.github.com/users/RohanNagar/gists{/gist_id}","starred_url":"https://api.github.com/users/RohanNagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RohanNagar/subscriptions","organizations_url":"https://api.github.com/users/RohanNagar/orgs","repos_url":"https://api.github.com/users/RohanNagar/repos","events_url":"https://api.github.com/users/RohanNagar/events{/privacy}","received_events_url":"https://api.github.com/users/RohanNagar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RohanNagar/thunder","description":"REST API application that manages user databases","fork":false,"url":"https://api.github.com/repos/RohanNagar/thunder","forks_url":"https://api.github.com/repos/RohanNagar/thunder/forks","keys_url":"https://api.github.com/repos/RohanNagar/thunder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RohanNagar/thunder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RohanNagar/thunder/teams","hooks_url":"https://api.github.com/repos/RohanNagar/thunder/hooks","issue_events_url":"https://api.github.com/repos/RohanNagar/thunder/issues/events{/number}","events_url":"https://api.github.com/repos/RohanNagar/thunder/events","assignees_url":"https://api.github.com/repos/RohanNagar/thunder/assignees{/user}","branches_url":"https://api.github.com/repos/RohanNagar/thunder/branches{/branch}","tags_url":"https://api.github.com/repos/RohanNagar/thunder/tags","blobs_url":"https://api.github.com/repos/RohanNagar/thunder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RohanNagar/thunder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RohanNagar/thunder/git/refs{/sha}","trees_url":"https://api.github.com/repos/RohanNagar/thunder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RohanNagar/thunder/statuses/{sha}","languages_url":"https://api.github.com/repos/RohanNagar/thunder/languages","stargazers_url":"https://api.github.com/repos/RohanNagar/thunder/stargazers","contributors_url":"https://api.github.com/repos/RohanNagar/thunder/contributors","subscribers_url":"https://api.github.com/repos/RohanNagar/thunder/subscribers","subscription_url":"https://api.github.com/repos/RohanNagar/thunder/subscription","commits_url":"https://api.github.com/repos/RohanNagar/thunder/commits{/sha}","git_commits_url":"https://api.github.com/repos/RohanNagar/thunder/git/commits{/sha}","comments_url":"https://api.github.com/repos/RohanNagar/thunder/comments{/number}","issue_comment_url":"https://api.github.com/repos/RohanNagar/thunder/issues/comments{/number}","contents_url":"https://api.github.com/repos/RohanNagar/thunder/contents/{+path}","compare_url":"https://api.github.com/repos/RohanNagar/thunder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RohanNagar/thunder/merges","archive_url":"https://api.github.com/repos/RohanNagar/thunder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RohanNagar/thunder/downloads","issues_url":"https://api.github.com/repos/RohanNagar/thunder/issues{/number}","pulls_url":"https://api.github.com/repos/RohanNagar/thunder/pulls{/number}","milestones_url":"https://api.github.com/repos/RohanNagar/thunder/milestones{/number}","notifications_url":"https://api.github.com/repos/RohanNagar/thunder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RohanNagar/thunder/labels{/name}","releases_url":"https://api.github.com/repos/RohanNagar/thunder/releases{/id}","deployments_url":"https://api.github.com/repos/RohanNagar/thunder/deployments","created_at":"2015-08-01T18:15:15Z","updated_at":"2018-04-16T19:03:31Z","pushed_at":"2018-04-16T19:55:25Z","git_url":"git://github.com/RohanNagar/thunder.git","ssh_url":"git@github.com:RohanNagar/thunder.git","clone_url":"https://github.com/RohanNagar/thunder.git","svn_url":"https://github.com/RohanNagar/thunder","homepage":"","size":529,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":17,"watchers":8,"default_branch":"master"}},"base":{"label":"RohanNagar:master","ref":"master","sha":"63b5ad93a665fa981e1de27966101ec3df369b16","user":{"login":"RohanNagar","id":5522930,"avatar_url":"https://avatars3.githubusercontent.com/u/5522930?v=4","gravatar_id":"","url":"https://api.github.com/users/RohanNagar","html_url":"https://github.com/RohanNagar","followers_url":"https://api.github.com/users/RohanNagar/followers","following_url":"https://api.github.com/users/RohanNagar/following{/other_user}","gists_url":"https://api.github.com/users/RohanNagar/gists{/gist_id}","starred_url":"https://api.github.com/users/RohanNagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RohanNagar/subscriptions","organizations_url":"https://api.github.com/users/RohanNagar/orgs","repos_url":"https://api.github.com/users/RohanNagar/repos","events_url":"https://api.github.com/users/RohanNagar/events{/privacy}","received_events_url":"https://api.github.com/users/RohanNagar/received_events","type":"User","site_admin":false},"repo":{"id":40055799,"name":"thunder","full_name":"RohanNagar/thunder","owner":{"login":"RohanNagar","id":5522930,"avatar_url":"https://avatars3.githubusercontent.com/u/5522930?v=4","gravatar_id":"","url":"https://api.github.com/users/RohanNagar","html_url":"https://github.com/RohanNagar","followers_url":"https://api.github.com/users/RohanNagar/followers","following_url":"https://api.github.com/users/RohanNagar/following{/other_user}","gists_url":"https://api.github.com/users/RohanNagar/gists{/gist_id}","starred_url":"https://api.github.com/users/RohanNagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RohanNagar/subscriptions","organizations_url":"https://api.github.com/users/RohanNagar/orgs","repos_url":"https://api.github.com/users/RohanNagar/repos","events_url":"https://api.github.com/users/RohanNagar/events{/privacy}","received_events_url":"https://api.github.com/users/RohanNagar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RohanNagar/thunder","description":"REST API application that manages user databases","fork":false,"url":"https://api.github.com/repos/RohanNagar/thunder","forks_url":"https://api.github.com/repos/RohanNagar/thunder/forks","keys_url":"https://api.github.com/repos/RohanNagar/thunder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RohanNagar/thunder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RohanNagar/thunder/teams","hooks_url":"https://api.github.com/repos/RohanNagar/thunder/hooks","issue_events_url":"https://api.github.com/repos/RohanNagar/thunder/issues/events{/number}","events_url":"https://api.github.com/repos/RohanNagar/thunder/events","assignees_url":"https://api.github.com/repos/RohanNagar/thunder/assignees{/user}","branches_url":"https://api.github.com/repos/RohanNagar/thunder/branches{/branch}","tags_url":"https://api.github.com/repos/RohanNagar/thunder/tags","blobs_url":"https://api.github.com/repos/RohanNagar/thunder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RohanNagar/thunder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RohanNagar/thunder/git/refs{/sha}","trees_url":"https://api.github.com/repos/RohanNagar/thunder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RohanNagar/thunder/statuses/{sha}","languages_url":"https://api.github.com/repos/RohanNagar/thunder/languages","stargazers_url":"https://api.github.com/repos/RohanNagar/thunder/stargazers","contributors_url":"https://api.github.com/repos/RohanNagar/thunder/contributors","subscribers_url":"https://api.github.com/repos/RohanNagar/thunder/subscribers","subscription_url":"https://api.github.com/repos/RohanNagar/thunder/subscription","commits_url":"https://api.github.com/repos/RohanNagar/thunder/commits{/sha}","git_commits_url":"https://api.github.com/repos/RohanNagar/thunder/git/commits{/sha}","comments_url":"https://api.github.com/repos/RohanNagar/thunder/comments{/number}","issue_comment_url":"https://api.github.com/repos/RohanNagar/thunder/issues/comments{/number}","contents_url":"https://api.github.com/repos/RohanNagar/thunder/contents/{+path}","compare_url":"https://api.github.com/repos/RohanNagar/thunder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RohanNagar/thunder/merges","archive_url":"https://api.github.com/repos/RohanNagar/thunder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RohanNagar/thunder/downloads","issues_url":"https://api.github.com/repos/RohanNagar/thunder/issues{/number}","pulls_url":"https://api.github.com/repos/RohanNagar/thunder/pulls{/number}","milestones_url":"https://api.github.com/repos/RohanNagar/thunder/milestones{/number}","notifications_url":"https://api.github.com/repos/RohanNagar/thunder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RohanNagar/thunder/labels{/name}","releases_url":"https://api.github.com/repos/RohanNagar/thunder/releases{/id}","deployments_url":"https://api.github.com/repos/RohanNagar/thunder/deployments","created_at":"2015-08-01T18:15:15Z","updated_at":"2018-04-16T19:03:31Z","pushed_at":"2018-04-16T19:55:25Z","git_url":"git://github.com/RohanNagar/thunder.git","ssh_url":"git@github.com:RohanNagar/thunder.git","clone_url":"https://github.com/RohanNagar/thunder.git","svn_url":"https://github.com/RohanNagar/thunder","homepage":"","size":529,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":17,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RohanNagar/thunder/pulls/141"},"html":{"href":"https://github.com/RohanNagar/thunder/pull/141"},"issue":{"href":"https://api.github.com/repos/RohanNagar/thunder/issues/141"},"comments":{"href":"https://api.github.com/repos/RohanNagar/thunder/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/RohanNagar/thunder/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/RohanNagar/thunder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RohanNagar/thunder/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/RohanNagar/thunder/statuses/e38c4c37807f1a4228258fcc857b1efc41ad2b3e"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":231,"deletions":253,"changed_files":15}}
{"actor":{"display_login":"RohanNagar"}}