{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/comments/229863159","pull_request_review_id":170466746,"id":229863159,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTg2MzE1OQ==","diff_hunk":"@@ -50,7 +50,7 @@ func SplitTablesByPartitionType(tables []Relation, tableDefs map[uint32]TableDef\n \tmetadataTables := make([]Relation, 0)\n \tdataTables := make([]Relation, 0)\n \tif MustGetFlagBool(utils.LEAF_PARTITION_DATA) || len(includeList) > 0 {\n-\t\tincludeSet := utils.NewIncludeSet(includeList)\n+\t\tincludeSet := utils.NewSet(includeList)","path":"backup/predata_relations.go","position":5,"original_position":5,"commit_id":"8952bbc79b651825c5f0479e805995b92950bbf4","original_commit_id":"8952bbc79b651825c5f0479e805995b92950bbf4","user":{"login":"chrishajas","id":1610524,"node_id":"MDQ6VXNlcjE2MTA1MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1610524?v=4","gravatar_id":"","url":"https://api.github.com/users/chrishajas","html_url":"https://github.com/chrishajas","followers_url":"https://api.github.com/users/chrishajas/followers","following_url":"https://api.github.com/users/chrishajas/following{/other_user}","gists_url":"https://api.github.com/users/chrishajas/gists{/gist_id}","starred_url":"https://api.github.com/users/chrishajas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrishajas/subscriptions","organizations_url":"https://api.github.com/users/chrishajas/orgs","repos_url":"https://api.github.com/users/chrishajas/repos","events_url":"https://api.github.com/users/chrishajas/events{/privacy}","received_events_url":"https://api.github.com/users/chrishajas/received_events","type":"User","site_admin":false},"body":"I was viewing it from the perspective of `NewIncludeSet` in the previous case could never be empty, so `AlwaysMatchesFilter` could never be set, therefore, it's safe to use a regular set rather than include set. I don't think we can remove `if len(includeList) > 0` without more work as unit tests start failing. ","created_at":"2018-10-31T20:51:32Z","updated_at":"2018-10-31T20:51:32Z","html_url":"https://github.com/greenplum-db/gpbackup/pull/178#discussion_r229863159","pull_request_url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/178","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/comments/229863159"},"html":{"href":"https://github.com/greenplum-db/gpbackup/pull/178#discussion_r229863159"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/178"}},"in_reply_to_id":229802117},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/178","id":226728794,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NzI4Nzk0","html_url":"https://github.com/greenplum-db/gpbackup/pull/178","diff_url":"https://github.com/greenplum-db/gpbackup/pull/178.diff","patch_url":"https://github.com/greenplum-db/gpbackup/pull/178.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/178","number":178,"state":"open","locked":false,"title":"Refactor set implementation","user":{"login":"chrishajas","id":1610524,"node_id":"MDQ6VXNlcjE2MTA1MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1610524?v=4","gravatar_id":"","url":"https://api.github.com/users/chrishajas","html_url":"https://github.com/chrishajas","followers_url":"https://api.github.com/users/chrishajas/followers","following_url":"https://api.github.com/users/chrishajas/following{/other_user}","gists_url":"https://api.github.com/users/chrishajas/gists{/gist_id}","starred_url":"https://api.github.com/users/chrishajas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrishajas/subscriptions","organizations_url":"https://api.github.com/users/chrishajas/orgs","repos_url":"https://api.github.com/users/chrishajas/repos","events_url":"https://api.github.com/users/chrishajas/events{/privacy}","received_events_url":"https://api.github.com/users/chrishajas/received_events","type":"User","site_admin":false},"body":"Previously, we were using sets for two purposes:\r\n  1) As an include or exclude set to match table/schemas that were to be\r\n  included or excluded from the backup or restore\r\n  2) As a regular set\r\n\r\nThe first case uses a modified implementation, where an empty set would\r\nalways return that a object exists. This was done so that the default\r\nbehavior would backup/restore all objects. However, in cases where a\r\ngeneric set without the property was wanted, it could lead to confusing\r\nbehavior.\r\n\r\nThis introduces a NewSet constructor and replaces instances that should\r\nhave been using a regular set with this call.\r\n\r\nAdditionally, this removes the Add and Delete set functionality since\r\nthey weren't being used.\r\n\r\nAuthored-by: Chris Hajas <chajas@pivotal.io>","created_at":"2018-10-29T22:04:01Z","updated_at":"2018-10-31T20:51:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf221ad09b6429066c150dea7060e6c9bb92cb9a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nadeemg","id":6484469,"node_id":"MDQ6VXNlcjY0ODQ0Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/6484469?v=4","gravatar_id":"","url":"https://api.github.com/users/nadeemg","html_url":"https://github.com/nadeemg","followers_url":"https://api.github.com/users/nadeemg/followers","following_url":"https://api.github.com/users/nadeemg/following{/other_user}","gists_url":"https://api.github.com/users/nadeemg/gists{/gist_id}","starred_url":"https://api.github.com/users/nadeemg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadeemg/subscriptions","organizations_url":"https://api.github.com/users/nadeemg/orgs","repos_url":"https://api.github.com/users/nadeemg/repos","events_url":"https://api.github.com/users/nadeemg/events{/privacy}","received_events_url":"https://api.github.com/users/nadeemg/received_events","type":"User","site_admin":false},{"login":"kyeap-pivotal","id":36176870,"node_id":"MDQ6VXNlcjM2MTc2ODcw","avatar_url":"https://avatars0.githubusercontent.com/u/36176870?v=4","gravatar_id":"","url":"https://api.github.com/users/kyeap-pivotal","html_url":"https://github.com/kyeap-pivotal","followers_url":"https://api.github.com/users/kyeap-pivotal/followers","following_url":"https://api.github.com/users/kyeap-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/kyeap-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/kyeap-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyeap-pivotal/subscriptions","organizations_url":"https://api.github.com/users/kyeap-pivotal/orgs","repos_url":"https://api.github.com/users/kyeap-pivotal/repos","events_url":"https://api.github.com/users/kyeap-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/kyeap-pivotal/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/178/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/178/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/178/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpbackup/statuses/8952bbc79b651825c5f0479e805995b92950bbf4","head":{"label":"greenplum-db:refactor_set","ref":"refactor_set","sha":"8952bbc79b651825c5f0479e805995b92950bbf4","user":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":91118401,"node_id":"MDEwOlJlcG9zaXRvcnk5MTExODQwMQ==","name":"gpbackup","full_name":"greenplum-db/gpbackup","private":false,"owner":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/greenplum-db/gpbackup","description":"GPDB Backup Utility","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpbackup","forks_url":"https://api.github.com/repos/greenplum-db/gpbackup/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpbackup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpbackup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpbackup/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpbackup/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpbackup/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpbackup/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpbackup/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpbackup/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpbackup/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpbackup/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpbackup/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpbackup/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpbackup/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpbackup/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpbackup/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpbackup/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpbackup/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpbackup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpbackup/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpbackup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpbackup/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpbackup/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpbackup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpbackup/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpbackup/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpbackup/deployments","created_at":"2017-05-12T18:18:13Z","updated_at":"2018-10-29T20:58:23Z","pushed_at":"2018-10-31T16:57:25Z","git_url":"git://github.com/greenplum-db/gpbackup.git","ssh_url":"git@github.com:greenplum-db/gpbackup.git","clone_url":"https://github.com/greenplum-db/gpbackup.git","svn_url":"https://github.com/greenplum-db/gpbackup","homepage":null,"size":2725,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14,"open_issues":4,"watchers":8,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"8101ef4464d960251eeedb049d7789d02a4997cb","user":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":91118401,"node_id":"MDEwOlJlcG9zaXRvcnk5MTExODQwMQ==","name":"gpbackup","full_name":"greenplum-db/gpbackup","private":false,"owner":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/greenplum-db/gpbackup","description":"GPDB Backup Utility","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpbackup","forks_url":"https://api.github.com/repos/greenplum-db/gpbackup/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpbackup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpbackup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpbackup/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpbackup/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpbackup/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpbackup/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpbackup/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpbackup/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpbackup/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpbackup/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpbackup/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpbackup/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpbackup/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpbackup/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpbackup/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpbackup/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpbackup/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpbackup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpbackup/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpbackup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpbackup/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpbackup/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpbackup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpbackup/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpbackup/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpbackup/deployments","created_at":"2017-05-12T18:18:13Z","updated_at":"2018-10-29T20:58:23Z","pushed_at":"2018-10-31T16:57:25Z","git_url":"git://github.com/greenplum-db/gpbackup.git","ssh_url":"git@github.com:greenplum-db/gpbackup.git","clone_url":"https://github.com/greenplum-db/gpbackup.git","svn_url":"https://github.com/greenplum-db/gpbackup","homepage":null,"size":2725,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14,"open_issues":4,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/178"},"html":{"href":"https://github.com/greenplum-db/gpbackup/pull/178"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/issues/178"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/issues/178/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/178/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/178/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/statuses/8952bbc79b651825c5f0479e805995b92950bbf4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"chrishajas"}}