{"action":"created","issue":{"url":"https://api.github.com/repos/tophatmonocle/yvm/issues/110","repository_url":"https://api.github.com/repos/tophatmonocle/yvm","labels_url":"https://api.github.com/repos/tophatmonocle/yvm/issues/110/labels{/name}","comments_url":"https://api.github.com/repos/tophatmonocle/yvm/issues/110/comments","events_url":"https://api.github.com/repos/tophatmonocle/yvm/issues/110/events","html_url":"https://github.com/tophatmonocle/yvm/pull/110","id":338274785,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MjQ4NDcz","number":110,"title":"The exec command doesn't forward arguments correctly","user":{"login":"dat2","id":3258756,"node_id":"MDQ6VXNlcjMyNTg3NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/3258756?v=4","gravatar_id":"","url":"https://api.github.com/users/dat2","html_url":"https://github.com/dat2","followers_url":"https://api.github.com/users/dat2/followers","following_url":"https://api.github.com/users/dat2/following{/other_user}","gists_url":"https://api.github.com/users/dat2/gists{/gist_id}","starred_url":"https://api.github.com/users/dat2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dat2/subscriptions","organizations_url":"https://api.github.com/users/dat2/orgs","repos_url":"https://api.github.com/users/dat2/repos","events_url":"https://api.github.com/users/dat2/events{/privacy}","received_events_url":"https://api.github.com/users/dat2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-04T13:22:57Z","updated_at":"2018-07-04T14:42:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/tophatmonocle/yvm/pulls/110","html_url":"https://github.com/tophatmonocle/yvm/pull/110","diff_url":"https://github.com/tophatmonocle/yvm/pull/110.diff","patch_url":"https://github.com/tophatmonocle/yvm/pull/110.patch"},"body":"## Description\r\n`commander` has support for git sub commands, which just shell out arguments to a binary filed named `program-command`. `commander` will not try to parse the arguments, it will just call out `program-command` directly. This means in `yvm-exec` we can just call yarn directly with `process.argv` and a little bit of `.yvmrc` support 👍 \r\n\r\n## DevQA\r\n\r\n### DevQA Prep\r\n\r\n### DevQA Steps\r\n<!-- Fill in steps to DevQA this PR here -->\r\n- `yvm rm 1.7.0`\r\n  - cd src\r\n  - `yvm exec tag --help`\r\n  - verify that it installs 1.7.0, prints some nice stuff, then execs it as before.\r\n- verify that `yvm exec` still works as expected\r\n\r\n### Comments:\r\n<!-- Any other comments you want to include for reviewers. -->\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/tophatmonocle/yvm/issues/comments/402498759","html_url":"https://github.com/tophatmonocle/yvm/pull/110#issuecomment-402498759","issue_url":"https://api.github.com/repos/tophatmonocle/yvm/issues/110","id":402498759,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjQ5ODc1OQ==","user":{"login":"jakebolam","id":3534236,"node_id":"MDQ6VXNlcjM1MzQyMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/3534236?v=4","gravatar_id":"","url":"https://api.github.com/users/jakebolam","html_url":"https://github.com/jakebolam","followers_url":"https://api.github.com/users/jakebolam/followers","following_url":"https://api.github.com/users/jakebolam/following{/other_user}","gists_url":"https://api.github.com/users/jakebolam/gists{/gist_id}","starred_url":"https://api.github.com/users/jakebolam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakebolam/subscriptions","organizations_url":"https://api.github.com/users/jakebolam/orgs","repos_url":"https://api.github.com/users/jakebolam/repos","events_url":"https://api.github.com/users/jakebolam/events{/privacy}","received_events_url":"https://api.github.com/users/jakebolam/received_events","type":"User","site_admin":false},"created_at":"2018-07-04T14:42:27Z","updated_at":"2018-07-04T14:42:27Z","author_association":"COLLABORATOR","body":"Invalid version case\r\n```\r\nyvm exec 1.0 lol\r\nError:\r\n            No version supplied, no .yvmrc\r\n            Perhaps you wanted to specify your version like?\r\n            yvm exec 1.2.0 list\r\n\r\n    at execCommand (webpack:///./src/yvm-exec.js?:68:25)\r\n    at Object.eval (webpack:///./src/yvm-exec.js?:86:3)\r\n    at eval (webpack:///./src/yvm-exec.js?:93:30)\r\n    at Object../src/yvm-exec.js (/code/yvm/artifacts/webpack_build/yvm-exec.js:3182:1)\r\n    at __webpack_require__ (/code/yvm/artifacts/webpack_build/yvm-exec.js:20:30)\r\n    at /code/yvm/artifacts/webpack_build/yvm-exec.js:84:18\r\n    at Object.<anonymous> (/code/yvm/artifacts/webpack_build/yvm-exec.js:87:10)\r\n    at Module._compile (module.js:652:30)\r\n    at Object.Module._extensions..js (module.js:663:10)\r\n    at Module.load (module.js:565:32)\r\n```"}}
{"actor":{"display_login":"jakebolam"}}