{"action":"created","comment":{"url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/pulls/comments/234153471","pull_request_review_id":175736163,"id":234153471,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDE1MzQ3MQ==","diff_hunk":"@@ -50,6 +51,7 @@ getent passwd nginx-ldap-auth > /dev/null || \\\n %preun\n /usr/bin/systemctl --no-reload disable nginx-ldap-auth.service >/dev/null 2>&1 ||:\n /usr/bin/systemctl stop nginx-ldap-auth.service >/dev/null 2>&1 ||:\n+rm -f /var/log/nginx-ldap-auth/*","path":"rpm/nginx-ldap-auth.spec","position":37,"original_position":37,"commit_id":"85071bc5040fa120c08a915e2b191803d038e155","original_commit_id":"85071bc5040fa120c08a915e2b191803d038e155","user":{"login":"oxpa","id":1932978,"node_id":"MDQ6VXNlcjE5MzI5Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/1932978?v=4","gravatar_id":"","url":"https://api.github.com/users/oxpa","html_url":"https://github.com/oxpa","followers_url":"https://api.github.com/users/oxpa/followers","following_url":"https://api.github.com/users/oxpa/following{/other_user}","gists_url":"https://api.github.com/users/oxpa/gists{/gist_id}","starred_url":"https://api.github.com/users/oxpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oxpa/subscriptions","organizations_url":"https://api.github.com/users/oxpa/orgs","repos_url":"https://api.github.com/users/oxpa/repos","events_url":"https://api.github.com/users/oxpa/events{/privacy}","received_events_url":"https://api.github.com/users/oxpa/received_events","type":"User","site_admin":false},"body":"There is no check if this is an upgrade or removal. Either way it looks to be a bad idea to purge all logs.","created_at":"2018-11-16T10:16:23Z","updated_at":"2018-11-16T10:16:23Z","html_url":"https://github.com/nginxinc/nginx-ldap-auth/pull/56#discussion_r234153471","pull_request_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/pulls/56","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/pulls/comments/234153471"},"html":{"href":"https://github.com/nginxinc/nginx-ldap-auth/pull/56#discussion_r234153471"},"pull_request":{"href":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/pulls/56","id":231251463,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMjUxNDYz","html_url":"https://github.com/nginxinc/nginx-ldap-auth/pull/56","diff_url":"https://github.com/nginxinc/nginx-ldap-auth/pull/56.diff","patch_url":"https://github.com/nginxinc/nginx-ldap-auth/pull/56.patch","issue_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/issues/56","number":56,"state":"open","locked":false,"title":"Update spec file to work with 0.0.4 release","user":{"login":"alexjfisher","id":146471,"node_id":"MDQ6VXNlcjE0NjQ3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/146471?v=4","gravatar_id":"","url":"https://api.github.com/users/alexjfisher","html_url":"https://github.com/alexjfisher","followers_url":"https://api.github.com/users/alexjfisher/followers","following_url":"https://api.github.com/users/alexjfisher/following{/other_user}","gists_url":"https://api.github.com/users/alexjfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjfisher/subscriptions","organizations_url":"https://api.github.com/users/alexjfisher/orgs","repos_url":"https://api.github.com/users/alexjfisher/repos","events_url":"https://api.github.com/users/alexjfisher/events{/privacy}","received_events_url":"https://api.github.com/users/alexjfisher/received_events","type":"User","site_admin":false},"body":"I think the debian equivalent also needs updating, but with these changes I was able to build a 0.0.4 RPM on CentOS 7.","created_at":"2018-11-15T16:14:07Z","updated_at":"2018-11-16T10:16:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cccf259992dd83a0a10a934f7eebb6682cf9ada0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/pulls/56/commits","review_comments_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/pulls/56/comments","review_comment_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/issues/56/comments","statuses_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/statuses/85071bc5040fa120c08a915e2b191803d038e155","head":{"label":"alexjfisher:fix_spec_file","ref":"fix_spec_file","sha":"85071bc5040fa120c08a915e2b191803d038e155","user":{"login":"alexjfisher","id":146471,"node_id":"MDQ6VXNlcjE0NjQ3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/146471?v=4","gravatar_id":"","url":"https://api.github.com/users/alexjfisher","html_url":"https://github.com/alexjfisher","followers_url":"https://api.github.com/users/alexjfisher/followers","following_url":"https://api.github.com/users/alexjfisher/following{/other_user}","gists_url":"https://api.github.com/users/alexjfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjfisher/subscriptions","organizations_url":"https://api.github.com/users/alexjfisher/orgs","repos_url":"https://api.github.com/users/alexjfisher/repos","events_url":"https://api.github.com/users/alexjfisher/events{/privacy}","received_events_url":"https://api.github.com/users/alexjfisher/received_events","type":"User","site_admin":false},"repo":{"id":157738007,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc3MzgwMDc=","name":"nginx-ldap-auth","full_name":"alexjfisher/nginx-ldap-auth","private":false,"owner":{"login":"alexjfisher","id":146471,"node_id":"MDQ6VXNlcjE0NjQ3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/146471?v=4","gravatar_id":"","url":"https://api.github.com/users/alexjfisher","html_url":"https://github.com/alexjfisher","followers_url":"https://api.github.com/users/alexjfisher/followers","following_url":"https://api.github.com/users/alexjfisher/following{/other_user}","gists_url":"https://api.github.com/users/alexjfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjfisher/subscriptions","organizations_url":"https://api.github.com/users/alexjfisher/orgs","repos_url":"https://api.github.com/users/alexjfisher/repos","events_url":"https://api.github.com/users/alexjfisher/events{/privacy}","received_events_url":"https://api.github.com/users/alexjfisher/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alexjfisher/nginx-ldap-auth","description":"Example of LDAP authentication using ngx_http_auth_request_module","fork":true,"url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth","forks_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/forks","keys_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/teams","hooks_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/hooks","issue_events_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/issues/events{/number}","events_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/events","assignees_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/assignees{/user}","branches_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/branches{/branch}","tags_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/tags","blobs_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/languages","stargazers_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/stargazers","contributors_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/contributors","subscribers_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/subscribers","subscription_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/subscription","commits_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/contents/{+path}","compare_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/merges","archive_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/downloads","issues_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/issues{/number}","pulls_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/labels{/name}","releases_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/releases{/id}","deployments_url":"https://api.github.com/repos/alexjfisher/nginx-ldap-auth/deployments","created_at":"2018-11-15T16:06:44Z","updated_at":"2018-11-15T16:06:46Z","pushed_at":"2018-11-16T09:45:00Z","git_url":"git://github.com/alexjfisher/nginx-ldap-auth.git","ssh_url":"git@github.com:alexjfisher/nginx-ldap-auth.git","clone_url":"https://github.com/alexjfisher/nginx-ldap-auth.git","svn_url":"https://github.com/alexjfisher/nginx-ldap-auth","homepage":"","size":51,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nginxinc:master","ref":"master","sha":"d9a21498253821a2fdec3aaddffca80756f63999","user":{"login":"nginxinc","id":8629072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MjkwNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/8629072?v=4","gravatar_id":"","url":"https://api.github.com/users/nginxinc","html_url":"https://github.com/nginxinc","followers_url":"https://api.github.com/users/nginxinc/followers","following_url":"https://api.github.com/users/nginxinc/following{/other_user}","gists_url":"https://api.github.com/users/nginxinc/gists{/gist_id}","starred_url":"https://api.github.com/users/nginxinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nginxinc/subscriptions","organizations_url":"https://api.github.com/users/nginxinc/orgs","repos_url":"https://api.github.com/users/nginxinc/repos","events_url":"https://api.github.com/users/nginxinc/events{/privacy}","received_events_url":"https://api.github.com/users/nginxinc/received_events","type":"Organization","site_admin":false},"repo":{"id":33192728,"node_id":"MDEwOlJlcG9zaXRvcnkzMzE5MjcyOA==","name":"nginx-ldap-auth","full_name":"nginxinc/nginx-ldap-auth","private":false,"owner":{"login":"nginxinc","id":8629072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MjkwNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/8629072?v=4","gravatar_id":"","url":"https://api.github.com/users/nginxinc","html_url":"https://github.com/nginxinc","followers_url":"https://api.github.com/users/nginxinc/followers","following_url":"https://api.github.com/users/nginxinc/following{/other_user}","gists_url":"https://api.github.com/users/nginxinc/gists{/gist_id}","starred_url":"https://api.github.com/users/nginxinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nginxinc/subscriptions","organizations_url":"https://api.github.com/users/nginxinc/orgs","repos_url":"https://api.github.com/users/nginxinc/repos","events_url":"https://api.github.com/users/nginxinc/events{/privacy}","received_events_url":"https://api.github.com/users/nginxinc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nginxinc/nginx-ldap-auth","description":"Example of LDAP authentication using ngx_http_auth_request_module","fork":false,"url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth","forks_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/forks","keys_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/teams","hooks_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/hooks","issue_events_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/issues/events{/number}","events_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/events","assignees_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/assignees{/user}","branches_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/branches{/branch}","tags_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/tags","blobs_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/languages","stargazers_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/stargazers","contributors_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/contributors","subscribers_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/subscribers","subscription_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/subscription","commits_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/contents/{+path}","compare_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/merges","archive_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/downloads","issues_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/issues{/number}","pulls_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/labels{/name}","releases_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/releases{/id}","deployments_url":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/deployments","created_at":"2015-03-31T15:18:09Z","updated_at":"2018-11-15T14:05:57Z","pushed_at":"2018-11-16T09:45:02Z","git_url":"git://github.com/nginxinc/nginx-ldap-auth.git","ssh_url":"git@github.com:nginxinc/nginx-ldap-auth.git","clone_url":"https://github.com/nginxinc/nginx-ldap-auth.git","svn_url":"https://github.com/nginxinc/nginx-ldap-auth","homepage":"","size":50,"stargazers_count":278,"watchers_count":278,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":88,"open_issues":4,"watchers":278,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/pulls/56"},"html":{"href":"https://github.com/nginxinc/nginx-ldap-auth/pull/56"},"issue":{"href":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/issues/56"},"comments":{"href":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/nginxinc/nginx-ldap-auth/statuses/85071bc5040fa120c08a915e2b191803d038e155"}},"author_association":"NONE"}}
{"actor":{"display_login":"oxpa"}}