{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/192556041","pull_request_review_id":125362134,"id":192556041,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjU1NjA0MQ==","diff_hunk":"@@ -795,6 +795,10 @@ void NVMEDevice::close()\n {\n   dout(1) << __func__ << dendl;\n \n+  if (queue_t) {","path":"src/os/bluestore/NVMEDevice.cc","position":4,"original_position":4,"commit_id":"1cae65ed22969a27aa61e8ce1d2f84c5dbc25afc","original_commit_id":"1cae65ed22969a27aa61e8ce1d2f84c5dbc25afc","user":{"login":"tone-zhang","id":19795045,"node_id":"MDQ6VXNlcjE5Nzk1MDQ1","avatar_url":"https://avatars2.githubusercontent.com/u/19795045?v=4","gravatar_id":"","url":"https://api.github.com/users/tone-zhang","html_url":"https://github.com/tone-zhang","followers_url":"https://api.github.com/users/tone-zhang/followers","following_url":"https://api.github.com/users/tone-zhang/following{/other_user}","gists_url":"https://api.github.com/users/tone-zhang/gists{/gist_id}","starred_url":"https://api.github.com/users/tone-zhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tone-zhang/subscriptions","organizations_url":"https://api.github.com/users/tone-zhang/orgs","repos_url":"https://api.github.com/users/tone-zhang/repos","events_url":"https://api.github.com/users/tone-zhang/events{/privacy}","received_events_url":"https://api.github.com/users/tone-zhang/received_events","type":"User","site_admin":false},"body":"@tchaikov, thanks! I will remove the check of \"queue_t\".","created_at":"2018-06-02T10:15:58Z","updated_at":"2018-06-02T10:15:58Z","html_url":"https://github.com/ceph/ceph/pull/22356#discussion_r192556041","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/22356","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/192556041"},"html":{"href":"https://github.com/ceph/ceph/pull/22356#discussion_r192556041"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/22356"}},"in_reply_to_id":192367846},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/22356","id":191933196,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxOTMzMTk2","html_url":"https://github.com/ceph/ceph/pull/22356","diff_url":"https://github.com/ceph/ceph/pull/22356.diff","patch_url":"https://github.com/ceph/ceph/pull/22356.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/22356","number":22356,"state":"open","locked":false,"title":"spdk: fix ceph-osd crash when activate SPDK","user":{"login":"tone-zhang","id":19795045,"node_id":"MDQ6VXNlcjE5Nzk1MDQ1","avatar_url":"https://avatars2.githubusercontent.com/u/19795045?v=4","gravatar_id":"","url":"https://api.github.com/users/tone-zhang","html_url":"https://github.com/tone-zhang","followers_url":"https://api.github.com/users/tone-zhang/followers","following_url":"https://api.github.com/users/tone-zhang/following{/other_user}","gists_url":"https://api.github.com/users/tone-zhang/gists{/gist_id}","starred_url":"https://api.github.com/users/tone-zhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tone-zhang/subscriptions","organizations_url":"https://api.github.com/users/tone-zhang/orgs","repos_url":"https://api.github.com/users/tone-zhang/repos","events_url":"https://api.github.com/users/tone-zhang/events{/privacy}","received_events_url":"https://api.github.com/users/tone-zhang/received_events","type":"User","site_admin":false},"body":"When activate SPDK in Ceph, observe a Ceph crash.\r\n\r\nIt happened in the case 1) there is a pending IOContext in\r\nNVMEDevice and 2) the lower block device has been recreated and\r\nqueue_t then points to an NVMEDevice that no longer exists.\r\n\r\nThis patch addresses the problem by deleting and zeroing queue_t\r\nwhen NVMEDevice is closed.\r\n\r\nFixes: http://tracker.ceph.com/issues/24371\r\n\r\nSigned-off-by: tone-zhang <tone.zhang@arm.com>","created_at":"2018-06-01T04:45:22Z","updated_at":"2018-06-02T10:15:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"774b5e4998fdec873b677c3eb4f057f6c0c7b09b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"yuyuyu101","id":980577,"node_id":"MDQ6VXNlcjk4MDU3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/980577?v=4","gravatar_id":"","url":"https://api.github.com/users/yuyuyu101","html_url":"https://github.com/yuyuyu101","followers_url":"https://api.github.com/users/yuyuyu101/followers","following_url":"https://api.github.com/users/yuyuyu101/following{/other_user}","gists_url":"https://api.github.com/users/yuyuyu101/gists{/gist_id}","starred_url":"https://api.github.com/users/yuyuyu101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuyuyu101/subscriptions","organizations_url":"https://api.github.com/users/yuyuyu101/orgs","repos_url":"https://api.github.com/users/yuyuyu101/repos","events_url":"https://api.github.com/users/yuyuyu101/events{/privacy}","received_events_url":"https://api.github.com/users/yuyuyu101/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":385981601,"node_id":"MDU6TGFiZWwzODU5ODE2MDE=","url":"https://api.github.com/repos/ceph/ceph/labels/bluestore","name":"bluestore","color":"0066ff","default":false},{"id":134774049,"node_id":"MDU6TGFiZWwxMzQ3NzQwNDk=","url":"https://api.github.com/repos/ceph/ceph/labels/bug%20fix","name":"bug fix","color":"ac0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/22356/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/22356/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/22356/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/1cae65ed22969a27aa61e8ce1d2f84c5dbc25afc","head":{"label":"tone-zhang:wip-bug-24371","ref":"wip-bug-24371","sha":"1cae65ed22969a27aa61e8ce1d2f84c5dbc25afc","user":{"login":"tone-zhang","id":19795045,"node_id":"MDQ6VXNlcjE5Nzk1MDQ1","avatar_url":"https://avatars2.githubusercontent.com/u/19795045?v=4","gravatar_id":"","url":"https://api.github.com/users/tone-zhang","html_url":"https://github.com/tone-zhang","followers_url":"https://api.github.com/users/tone-zhang/followers","following_url":"https://api.github.com/users/tone-zhang/following{/other_user}","gists_url":"https://api.github.com/users/tone-zhang/gists{/gist_id}","starred_url":"https://api.github.com/users/tone-zhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tone-zhang/subscriptions","organizations_url":"https://api.github.com/users/tone-zhang/orgs","repos_url":"https://api.github.com/users/tone-zhang/repos","events_url":"https://api.github.com/users/tone-zhang/events{/privacy}","received_events_url":"https://api.github.com/users/tone-zhang/received_events","type":"User","site_admin":false},"repo":{"id":60598768,"node_id":"MDEwOlJlcG9zaXRvcnk2MDU5ODc2OA==","name":"ceph","full_name":"tone-zhang/ceph","owner":{"login":"tone-zhang","id":19795045,"node_id":"MDQ6VXNlcjE5Nzk1MDQ1","avatar_url":"https://avatars2.githubusercontent.com/u/19795045?v=4","gravatar_id":"","url":"https://api.github.com/users/tone-zhang","html_url":"https://github.com/tone-zhang","followers_url":"https://api.github.com/users/tone-zhang/followers","following_url":"https://api.github.com/users/tone-zhang/following{/other_user}","gists_url":"https://api.github.com/users/tone-zhang/gists{/gist_id}","starred_url":"https://api.github.com/users/tone-zhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tone-zhang/subscriptions","organizations_url":"https://api.github.com/users/tone-zhang/orgs","repos_url":"https://api.github.com/users/tone-zhang/repos","events_url":"https://api.github.com/users/tone-zhang/events{/privacy}","received_events_url":"https://api.github.com/users/tone-zhang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tone-zhang/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/tone-zhang/ceph","forks_url":"https://api.github.com/repos/tone-zhang/ceph/forks","keys_url":"https://api.github.com/repos/tone-zhang/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tone-zhang/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tone-zhang/ceph/teams","hooks_url":"https://api.github.com/repos/tone-zhang/ceph/hooks","issue_events_url":"https://api.github.com/repos/tone-zhang/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/tone-zhang/ceph/events","assignees_url":"https://api.github.com/repos/tone-zhang/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/tone-zhang/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/tone-zhang/ceph/tags","blobs_url":"https://api.github.com/repos/tone-zhang/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tone-zhang/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tone-zhang/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/tone-zhang/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tone-zhang/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/tone-zhang/ceph/languages","stargazers_url":"https://api.github.com/repos/tone-zhang/ceph/stargazers","contributors_url":"https://api.github.com/repos/tone-zhang/ceph/contributors","subscribers_url":"https://api.github.com/repos/tone-zhang/ceph/subscribers","subscription_url":"https://api.github.com/repos/tone-zhang/ceph/subscription","commits_url":"https://api.github.com/repos/tone-zhang/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/tone-zhang/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/tone-zhang/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/tone-zhang/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/tone-zhang/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/tone-zhang/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tone-zhang/ceph/merges","archive_url":"https://api.github.com/repos/tone-zhang/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tone-zhang/ceph/downloads","issues_url":"https://api.github.com/repos/tone-zhang/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/tone-zhang/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/tone-zhang/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/tone-zhang/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tone-zhang/ceph/labels{/name}","releases_url":"https://api.github.com/repos/tone-zhang/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/tone-zhang/ceph/deployments","created_at":"2016-06-07T09:06:17Z","updated_at":"2017-04-01T10:10:47Z","pushed_at":"2018-06-02T10:10:56Z","git_url":"git://github.com/tone-zhang/ceph.git","ssh_url":"git@github.com:tone-zhang/ceph.git","clone_url":"https://github.com/tone-zhang/ceph.git","svn_url":"https://github.com/tone-zhang/ceph","homepage":"http://ceph.com","size":275336,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"eb8c5e552e63a0ad0904cb3ae1bd66dc3c55edae","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-06-02T06:49:09Z","pushed_at":"2018-06-02T10:10:59Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":286373,"stargazers_count":4558,"watchers_count":4558,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2468,"mirror_url":null,"archived":false,"open_issues_count":653,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2468,"open_issues":653,"watchers":4558,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/22356"},"html":{"href":"https://github.com/ceph/ceph/pull/22356"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/22356"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/22356/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/22356/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/22356/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/1cae65ed22969a27aa61e8ce1d2f84c5dbc25afc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tone-zhang"}}