{"action":"created","comment":{"url":"https://api.github.com/repos/rectorphp/rector/pulls/comments/178737414","pull_request_review_id":108842928,"id":178737414,"diff_hunk":"@@ -185,7 +185,7 @@ private function processFile(SplFileInfo $fileInfo): void\n     {\n         $oldContent = $fileInfo->getContents();\n \n-        if ($this->parameterProvider->provideParameter(Option::OPTION_DRY_RUN)) {\n+        if ($this->parameterProvider->provideParameter(Option::OPTION_DRY_RUN) !== null) {","path":"src/Console/Command/ProcessCommand.php","position":5,"original_position":5,"commit_id":"b6d3d7516de02e10bdc145d1ef39e9a0bb90ab37","original_commit_id":"b6d3d7516de02e10bdc145d1ef39e9a0bb90ab37","user":{"login":"TomasVotruba","id":924196,"avatar_url":"https://avatars1.githubusercontent.com/u/924196?v=4","gravatar_id":"","url":"https://api.github.com/users/TomasVotruba","html_url":"https://github.com/TomasVotruba","followers_url":"https://api.github.com/users/TomasVotruba/followers","following_url":"https://api.github.com/users/TomasVotruba/following{/other_user}","gists_url":"https://api.github.com/users/TomasVotruba/gists{/gist_id}","starred_url":"https://api.github.com/users/TomasVotruba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomasVotruba/subscriptions","organizations_url":"https://api.github.com/users/TomasVotruba/orgs","repos_url":"https://api.github.com/users/TomasVotruba/repos","events_url":"https://api.github.com/users/TomasVotruba/events{/privacy}","received_events_url":"https://api.github.com/users/TomasVotruba/received_events","type":"User","site_admin":false},"body":"I don't see point in turning everything `if ($value)` into `if ($value !== null)`\r\nIt the return value would be -5, false, null and some value, it would make sense. Now it only forces more writing and more thinking while reading the code: \"what other false value apart `null` that method returns?\"\r\n\r\nCould you provide some reasoning?","created_at":"2018-04-03T07:42:51Z","updated_at":"2018-04-03T07:48:50Z","html_url":"https://github.com/rectorphp/rector/pull/404#discussion_r178737414","pull_request_url":"https://api.github.com/repos/rectorphp/rector/pulls/404","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/rectorphp/rector/pulls/comments/178737414"},"html":{"href":"https://github.com/rectorphp/rector/pull/404#discussion_r178737414"},"pull_request":{"href":"https://api.github.com/repos/rectorphp/rector/pulls/404"}}},"pull_request":{"url":"https://api.github.com/repos/rectorphp/rector/pulls/404","id":179000547,"html_url":"https://github.com/rectorphp/rector/pull/404","diff_url":"https://github.com/rectorphp/rector/pull/404.diff","patch_url":"https://github.com/rectorphp/rector/pull/404.patch","issue_url":"https://api.github.com/repos/rectorphp/rector/issues/404","number":404,"state":"open","locked":false,"title":"Use phpstan-strict-rules","user":{"login":"carusogabriel","id":16328050,"avatar_url":"https://avatars3.githubusercontent.com/u/16328050?v=4","gravatar_id":"","url":"https://api.github.com/users/carusogabriel","html_url":"https://github.com/carusogabriel","followers_url":"https://api.github.com/users/carusogabriel/followers","following_url":"https://api.github.com/users/carusogabriel/following{/other_user}","gists_url":"https://api.github.com/users/carusogabriel/gists{/gist_id}","starred_url":"https://api.github.com/users/carusogabriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carusogabriel/subscriptions","organizations_url":"https://api.github.com/users/carusogabriel/orgs","repos_url":"https://api.github.com/users/carusogabriel/repos","events_url":"https://api.github.com/users/carusogabriel/events{/privacy}","received_events_url":"https://api.github.com/users/carusogabriel/received_events","type":"User","site_admin":false},"body":"I'd like to propose the usage of PHPStan Strict Rules in Rector. This is a selection of rules to improve strict programming and make the code even more readable.\r\n\r\nAll the rules can be found in its [`README.md`](https://github.com/phpstan/phpstan-strict-rules/blob/master/README.md).","created_at":"2018-04-03T05:58:47Z","updated_at":"2018-04-03T07:48:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8961739d7b2dc58752d5c72909286f74774a5c78","assignee":{"login":"carusogabriel","id":16328050,"avatar_url":"https://avatars3.githubusercontent.com/u/16328050?v=4","gravatar_id":"","url":"https://api.github.com/users/carusogabriel","html_url":"https://github.com/carusogabriel","followers_url":"https://api.github.com/users/carusogabriel/followers","following_url":"https://api.github.com/users/carusogabriel/following{/other_user}","gists_url":"https://api.github.com/users/carusogabriel/gists{/gist_id}","starred_url":"https://api.github.com/users/carusogabriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carusogabriel/subscriptions","organizations_url":"https://api.github.com/users/carusogabriel/orgs","repos_url":"https://api.github.com/users/carusogabriel/repos","events_url":"https://api.github.com/users/carusogabriel/events{/privacy}","received_events_url":"https://api.github.com/users/carusogabriel/received_events","type":"User","site_admin":false},"assignees":[{"login":"carusogabriel","id":16328050,"avatar_url":"https://avatars3.githubusercontent.com/u/16328050?v=4","gravatar_id":"","url":"https://api.github.com/users/carusogabriel","html_url":"https://github.com/carusogabriel","followers_url":"https://api.github.com/users/carusogabriel/followers","following_url":"https://api.github.com/users/carusogabriel/following{/other_user}","gists_url":"https://api.github.com/users/carusogabriel/gists{/gist_id}","starred_url":"https://api.github.com/users/carusogabriel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carusogabriel/subscriptions","organizations_url":"https://api.github.com/users/carusogabriel/orgs","repos_url":"https://api.github.com/users/carusogabriel/repos","events_url":"https://api.github.com/users/carusogabriel/events{/privacy}","received_events_url":"https://api.github.com/users/carusogabriel/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rectorphp/rector/pulls/404/commits","review_comments_url":"https://api.github.com/repos/rectorphp/rector/pulls/404/comments","review_comment_url":"https://api.github.com/repos/rectorphp/rector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rectorphp/rector/issues/404/comments","statuses_url":"https://api.github.com/repos/rectorphp/rector/statuses/b6d3d7516de02e10bdc145d1ef39e9a0bb90ab37","head":{"label":"rectorphp:phpstan-strict-rules","ref":"phpstan-strict-rules","sha":"b6d3d7516de02e10bdc145d1ef39e9a0bb90ab37","user":{"login":"rectorphp","id":32097581,"avatar_url":"https://avatars1.githubusercontent.com/u/32097581?v=4","gravatar_id":"","url":"https://api.github.com/users/rectorphp","html_url":"https://github.com/rectorphp","followers_url":"https://api.github.com/users/rectorphp/followers","following_url":"https://api.github.com/users/rectorphp/following{/other_user}","gists_url":"https://api.github.com/users/rectorphp/gists{/gist_id}","starred_url":"https://api.github.com/users/rectorphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rectorphp/subscriptions","organizations_url":"https://api.github.com/users/rectorphp/orgs","repos_url":"https://api.github.com/users/rectorphp/repos","events_url":"https://api.github.com/users/rectorphp/events{/privacy}","received_events_url":"https://api.github.com/users/rectorphp/received_events","type":"Organization","site_admin":false},"repo":{"id":97311017,"name":"rector","full_name":"rectorphp/rector","owner":{"login":"rectorphp","id":32097581,"avatar_url":"https://avatars1.githubusercontent.com/u/32097581?v=4","gravatar_id":"","url":"https://api.github.com/users/rectorphp","html_url":"https://github.com/rectorphp","followers_url":"https://api.github.com/users/rectorphp/followers","following_url":"https://api.github.com/users/rectorphp/following{/other_user}","gists_url":"https://api.github.com/users/rectorphp/gists{/gist_id}","starred_url":"https://api.github.com/users/rectorphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rectorphp/subscriptions","organizations_url":"https://api.github.com/users/rectorphp/orgs","repos_url":"https://api.github.com/users/rectorphp/repos","events_url":"https://api.github.com/users/rectorphp/events{/privacy}","received_events_url":"https://api.github.com/users/rectorphp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rectorphp/rector","description":"AST-based  Instant Upgrades of PHP Applications ","fork":false,"url":"https://api.github.com/repos/rectorphp/rector","forks_url":"https://api.github.com/repos/rectorphp/rector/forks","keys_url":"https://api.github.com/repos/rectorphp/rector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rectorphp/rector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rectorphp/rector/teams","hooks_url":"https://api.github.com/repos/rectorphp/rector/hooks","issue_events_url":"https://api.github.com/repos/rectorphp/rector/issues/events{/number}","events_url":"https://api.github.com/repos/rectorphp/rector/events","assignees_url":"https://api.github.com/repos/rectorphp/rector/assignees{/user}","branches_url":"https://api.github.com/repos/rectorphp/rector/branches{/branch}","tags_url":"https://api.github.com/repos/rectorphp/rector/tags","blobs_url":"https://api.github.com/repos/rectorphp/rector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rectorphp/rector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rectorphp/rector/git/refs{/sha}","trees_url":"https://api.github.com/repos/rectorphp/rector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rectorphp/rector/statuses/{sha}","languages_url":"https://api.github.com/repos/rectorphp/rector/languages","stargazers_url":"https://api.github.com/repos/rectorphp/rector/stargazers","contributors_url":"https://api.github.com/repos/rectorphp/rector/contributors","subscribers_url":"https://api.github.com/repos/rectorphp/rector/subscribers","subscription_url":"https://api.github.com/repos/rectorphp/rector/subscription","commits_url":"https://api.github.com/repos/rectorphp/rector/commits{/sha}","git_commits_url":"https://api.github.com/repos/rectorphp/rector/git/commits{/sha}","comments_url":"https://api.github.com/repos/rectorphp/rector/comments{/number}","issue_comment_url":"https://api.github.com/repos/rectorphp/rector/issues/comments{/number}","contents_url":"https://api.github.com/repos/rectorphp/rector/contents/{+path}","compare_url":"https://api.github.com/repos/rectorphp/rector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rectorphp/rector/merges","archive_url":"https://api.github.com/repos/rectorphp/rector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rectorphp/rector/downloads","issues_url":"https://api.github.com/repos/rectorphp/rector/issues{/number}","pulls_url":"https://api.github.com/repos/rectorphp/rector/pulls{/number}","milestones_url":"https://api.github.com/repos/rectorphp/rector/milestones{/number}","notifications_url":"https://api.github.com/repos/rectorphp/rector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rectorphp/rector/labels{/name}","releases_url":"https://api.github.com/repos/rectorphp/rector/releases{/id}","deployments_url":"https://api.github.com/repos/rectorphp/rector/deployments","created_at":"2017-07-15T11:16:02Z","updated_at":"2018-04-03T07:39:42Z","pushed_at":"2018-04-03T07:43:46Z","git_url":"git://github.com/rectorphp/rector.git","ssh_url":"git@github.com:rectorphp/rector.git","clone_url":"https://github.com/rectorphp/rector.git","svn_url":"https://github.com/rectorphp/rector","homepage":"https://www.tomasvotruba.cz/blog/2018/02/19/rector-part-1-what-and-how/","size":5532,"stargazers_count":276,"watchers_count":276,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":13,"open_issues":20,"watchers":276,"default_branch":"master"}},"base":{"label":"rectorphp:master","ref":"master","sha":"004be59a484ac058a30d0aaec17619e347595f5c","user":{"login":"rectorphp","id":32097581,"avatar_url":"https://avatars1.githubusercontent.com/u/32097581?v=4","gravatar_id":"","url":"https://api.github.com/users/rectorphp","html_url":"https://github.com/rectorphp","followers_url":"https://api.github.com/users/rectorphp/followers","following_url":"https://api.github.com/users/rectorphp/following{/other_user}","gists_url":"https://api.github.com/users/rectorphp/gists{/gist_id}","starred_url":"https://api.github.com/users/rectorphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rectorphp/subscriptions","organizations_url":"https://api.github.com/users/rectorphp/orgs","repos_url":"https://api.github.com/users/rectorphp/repos","events_url":"https://api.github.com/users/rectorphp/events{/privacy}","received_events_url":"https://api.github.com/users/rectorphp/received_events","type":"Organization","site_admin":false},"repo":{"id":97311017,"name":"rector","full_name":"rectorphp/rector","owner":{"login":"rectorphp","id":32097581,"avatar_url":"https://avatars1.githubusercontent.com/u/32097581?v=4","gravatar_id":"","url":"https://api.github.com/users/rectorphp","html_url":"https://github.com/rectorphp","followers_url":"https://api.github.com/users/rectorphp/followers","following_url":"https://api.github.com/users/rectorphp/following{/other_user}","gists_url":"https://api.github.com/users/rectorphp/gists{/gist_id}","starred_url":"https://api.github.com/users/rectorphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rectorphp/subscriptions","organizations_url":"https://api.github.com/users/rectorphp/orgs","repos_url":"https://api.github.com/users/rectorphp/repos","events_url":"https://api.github.com/users/rectorphp/events{/privacy}","received_events_url":"https://api.github.com/users/rectorphp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rectorphp/rector","description":"AST-based  Instant Upgrades of PHP Applications ","fork":false,"url":"https://api.github.com/repos/rectorphp/rector","forks_url":"https://api.github.com/repos/rectorphp/rector/forks","keys_url":"https://api.github.com/repos/rectorphp/rector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rectorphp/rector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rectorphp/rector/teams","hooks_url":"https://api.github.com/repos/rectorphp/rector/hooks","issue_events_url":"https://api.github.com/repos/rectorphp/rector/issues/events{/number}","events_url":"https://api.github.com/repos/rectorphp/rector/events","assignees_url":"https://api.github.com/repos/rectorphp/rector/assignees{/user}","branches_url":"https://api.github.com/repos/rectorphp/rector/branches{/branch}","tags_url":"https://api.github.com/repos/rectorphp/rector/tags","blobs_url":"https://api.github.com/repos/rectorphp/rector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rectorphp/rector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rectorphp/rector/git/refs{/sha}","trees_url":"https://api.github.com/repos/rectorphp/rector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rectorphp/rector/statuses/{sha}","languages_url":"https://api.github.com/repos/rectorphp/rector/languages","stargazers_url":"https://api.github.com/repos/rectorphp/rector/stargazers","contributors_url":"https://api.github.com/repos/rectorphp/rector/contributors","subscribers_url":"https://api.github.com/repos/rectorphp/rector/subscribers","subscription_url":"https://api.github.com/repos/rectorphp/rector/subscription","commits_url":"https://api.github.com/repos/rectorphp/rector/commits{/sha}","git_commits_url":"https://api.github.com/repos/rectorphp/rector/git/commits{/sha}","comments_url":"https://api.github.com/repos/rectorphp/rector/comments{/number}","issue_comment_url":"https://api.github.com/repos/rectorphp/rector/issues/comments{/number}","contents_url":"https://api.github.com/repos/rectorphp/rector/contents/{+path}","compare_url":"https://api.github.com/repos/rectorphp/rector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rectorphp/rector/merges","archive_url":"https://api.github.com/repos/rectorphp/rector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rectorphp/rector/downloads","issues_url":"https://api.github.com/repos/rectorphp/rector/issues{/number}","pulls_url":"https://api.github.com/repos/rectorphp/rector/pulls{/number}","milestones_url":"https://api.github.com/repos/rectorphp/rector/milestones{/number}","notifications_url":"https://api.github.com/repos/rectorphp/rector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rectorphp/rector/labels{/name}","releases_url":"https://api.github.com/repos/rectorphp/rector/releases{/id}","deployments_url":"https://api.github.com/repos/rectorphp/rector/deployments","created_at":"2017-07-15T11:16:02Z","updated_at":"2018-04-03T07:39:42Z","pushed_at":"2018-04-03T07:43:46Z","git_url":"git://github.com/rectorphp/rector.git","ssh_url":"git@github.com:rectorphp/rector.git","clone_url":"https://github.com/rectorphp/rector.git","svn_url":"https://github.com/rectorphp/rector","homepage":"https://www.tomasvotruba.cz/blog/2018/02/19/rector-part-1-what-and-how/","size":5532,"stargazers_count":276,"watchers_count":276,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":13,"open_issues":20,"watchers":276,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rectorphp/rector/pulls/404"},"html":{"href":"https://github.com/rectorphp/rector/pull/404"},"issue":{"href":"https://api.github.com/repos/rectorphp/rector/issues/404"},"comments":{"href":"https://api.github.com/repos/rectorphp/rector/issues/404/comments"},"review_comments":{"href":"https://api.github.com/repos/rectorphp/rector/pulls/404/comments"},"review_comment":{"href":"https://api.github.com/repos/rectorphp/rector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rectorphp/rector/pulls/404/commits"},"statuses":{"href":"https://api.github.com/repos/rectorphp/rector/statuses/b6d3d7516de02e10bdc145d1ef39e9a0bb90ab37"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"TomasVotruba"}}