{"action":"created","comment":{"url":"https://api.github.com/repos/openMF/mifos-mobile/pulls/comments/228753208","pull_request_review_id":169097131,"id":228753208,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODc1MzIwOA==","diff_hunk":"@@ -75,7 +75,7 @@ public void detachView() {\n      */\n     public void login(final String username, final String password) {\n         checkViewAttached();\n-        if (isCredentialsValid(username, password)) {\n+        if (isUsernameValid(username) & isPasswordValid(password)) {","path":"app/src/main/java/org/mifos/mobilebanking/presenters/LoginPresenter.java","position":5,"original_position":5,"commit_id":"3c4515e992f832ae1ed5f5e2a3651bb530831fe9","original_commit_id":"3c4515e992f832ae1ed5f5e2a3651bb530831fe9","user":{"login":"m-sameer","id":28915865,"node_id":"MDQ6VXNlcjI4OTE1ODY1","avatar_url":"https://avatars1.githubusercontent.com/u/28915865?v=4","gravatar_id":"","url":"https://api.github.com/users/m-sameer","html_url":"https://github.com/m-sameer","followers_url":"https://api.github.com/users/m-sameer/followers","following_url":"https://api.github.com/users/m-sameer/following{/other_user}","gists_url":"https://api.github.com/users/m-sameer/gists{/gist_id}","starred_url":"https://api.github.com/users/m-sameer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-sameer/subscriptions","organizations_url":"https://api.github.com/users/m-sameer/orgs","repos_url":"https://api.github.com/users/m-sameer/repos","events_url":"https://api.github.com/users/m-sameer/events{/privacy}","received_events_url":"https://api.github.com/users/m-sameer/received_events","type":"User","site_admin":false},"body":"The build is failing because I'm using `&` here instead of `&&`. I cannot use **short circuit and** operation because both sides of the condition need to be called to show error on the username as well as the password field. @miPlodder As you said I'm not using any extra variables but this is failing on the **findbugs** check with the warning **NS_DANGEROUS_NON_SHORT_CIRCUIT: Potentially dangerous use of non-short-circuit logic**.","created_at":"2018-10-28T15:30:52Z","updated_at":"2018-10-28T15:30:52Z","html_url":"https://github.com/openMF/mifos-mobile/pull/913#discussion_r228753208","pull_request_url":"https://api.github.com/repos/openMF/mifos-mobile/pulls/913","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/openMF/mifos-mobile/pulls/comments/228753208"},"html":{"href":"https://github.com/openMF/mifos-mobile/pull/913#discussion_r228753208"},"pull_request":{"href":"https://api.github.com/repos/openMF/mifos-mobile/pulls/913"}}},"pull_request":{"url":"https://api.github.com/repos/openMF/mifos-mobile/pulls/913","id":225848219,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1ODQ4MjE5","html_url":"https://github.com/openMF/mifos-mobile/pull/913","diff_url":"https://github.com/openMF/mifos-mobile/pull/913.diff","patch_url":"https://github.com/openMF/mifos-mobile/pull/913.patch","issue_url":"https://api.github.com/repos/openMF/mifos-mobile/issues/913","number":913,"state":"open","locked":false,"title":"Fix #895: Add error text below password EditText in LoginActivity","user":{"login":"m-sameer","id":28915865,"node_id":"MDQ6VXNlcjI4OTE1ODY1","avatar_url":"https://avatars1.githubusercontent.com/u/28915865?v=4","gravatar_id":"","url":"https://api.github.com/users/m-sameer","html_url":"https://github.com/m-sameer","followers_url":"https://api.github.com/users/m-sameer/followers","following_url":"https://api.github.com/users/m-sameer/following{/other_user}","gists_url":"https://api.github.com/users/m-sameer/gists{/gist_id}","starred_url":"https://api.github.com/users/m-sameer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-sameer/subscriptions","organizations_url":"https://api.github.com/users/m-sameer/orgs","repos_url":"https://api.github.com/users/m-sameer/repos","events_url":"https://api.github.com/users/m-sameer/events{/privacy}","received_events_url":"https://api.github.com/users/m-sameer/received_events","type":"User","site_admin":false},"body":"Fixes #895 \r\n\r\n![gifmaker_20181026044642](https://user-images.githubusercontent.com/28915865/47563381-45ae0680-d93f-11e8-9bde-4c28f9cb7f60.gif)\r\n\r\n\r\n\r\nPlease make sure these boxes are checked before submitting your pull request - thanks!\r\n\r\n- [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio.\r\n\r\n- [x] Run the unit tests with `./gradlew check` to make sure you didn't break anything\r\n\r\n- [x] If you have multiple commits please combine them into one commit by squashing them.","created_at":"2018-10-25T17:49:57Z","updated_at":"2018-10-28T15:30:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7b42f891acf9c6fe104fbdbc2944a42eea233f1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openMF/mifos-mobile/pulls/913/commits","review_comments_url":"https://api.github.com/repos/openMF/mifos-mobile/pulls/913/comments","review_comment_url":"https://api.github.com/repos/openMF/mifos-mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openMF/mifos-mobile/issues/913/comments","statuses_url":"https://api.github.com/repos/openMF/mifos-mobile/statuses/3c4515e992f832ae1ed5f5e2a3651bb530831fe9","head":{"label":"m-sameer:issue#895","ref":"issue#895","sha":"3c4515e992f832ae1ed5f5e2a3651bb530831fe9","user":{"login":"m-sameer","id":28915865,"node_id":"MDQ6VXNlcjI4OTE1ODY1","avatar_url":"https://avatars1.githubusercontent.com/u/28915865?v=4","gravatar_id":"","url":"https://api.github.com/users/m-sameer","html_url":"https://github.com/m-sameer","followers_url":"https://api.github.com/users/m-sameer/followers","following_url":"https://api.github.com/users/m-sameer/following{/other_user}","gists_url":"https://api.github.com/users/m-sameer/gists{/gist_id}","starred_url":"https://api.github.com/users/m-sameer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-sameer/subscriptions","organizations_url":"https://api.github.com/users/m-sameer/orgs","repos_url":"https://api.github.com/users/m-sameer/repos","events_url":"https://api.github.com/users/m-sameer/events{/privacy}","received_events_url":"https://api.github.com/users/m-sameer/received_events","type":"User","site_admin":false},"repo":{"id":154545173,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ1NDUxNzM=","name":"mifos-mobile","full_name":"m-sameer/mifos-mobile","private":false,"owner":{"login":"m-sameer","id":28915865,"node_id":"MDQ6VXNlcjI4OTE1ODY1","avatar_url":"https://avatars1.githubusercontent.com/u/28915865?v=4","gravatar_id":"","url":"https://api.github.com/users/m-sameer","html_url":"https://github.com/m-sameer","followers_url":"https://api.github.com/users/m-sameer/followers","following_url":"https://api.github.com/users/m-sameer/following{/other_user}","gists_url":"https://api.github.com/users/m-sameer/gists{/gist_id}","starred_url":"https://api.github.com/users/m-sameer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-sameer/subscriptions","organizations_url":"https://api.github.com/users/m-sameer/orgs","repos_url":"https://api.github.com/users/m-sameer/repos","events_url":"https://api.github.com/users/m-sameer/events{/privacy}","received_events_url":"https://api.github.com/users/m-sameer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/m-sameer/mifos-mobile","description":"Repository for the Mifos Android Self Service App for clients","fork":true,"url":"https://api.github.com/repos/m-sameer/mifos-mobile","forks_url":"https://api.github.com/repos/m-sameer/mifos-mobile/forks","keys_url":"https://api.github.com/repos/m-sameer/mifos-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m-sameer/mifos-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m-sameer/mifos-mobile/teams","hooks_url":"https://api.github.com/repos/m-sameer/mifos-mobile/hooks","issue_events_url":"https://api.github.com/repos/m-sameer/mifos-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/m-sameer/mifos-mobile/events","assignees_url":"https://api.github.com/repos/m-sameer/mifos-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/m-sameer/mifos-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/m-sameer/mifos-mobile/tags","blobs_url":"https://api.github.com/repos/m-sameer/mifos-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m-sameer/mifos-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m-sameer/mifos-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/m-sameer/mifos-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m-sameer/mifos-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/m-sameer/mifos-mobile/languages","stargazers_url":"https://api.github.com/repos/m-sameer/mifos-mobile/stargazers","contributors_url":"https://api.github.com/repos/m-sameer/mifos-mobile/contributors","subscribers_url":"https://api.github.com/repos/m-sameer/mifos-mobile/subscribers","subscription_url":"https://api.github.com/repos/m-sameer/mifos-mobile/subscription","commits_url":"https://api.github.com/repos/m-sameer/mifos-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/m-sameer/mifos-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/m-sameer/mifos-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/m-sameer/mifos-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/m-sameer/mifos-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/m-sameer/mifos-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m-sameer/mifos-mobile/merges","archive_url":"https://api.github.com/repos/m-sameer/mifos-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m-sameer/mifos-mobile/downloads","issues_url":"https://api.github.com/repos/m-sameer/mifos-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/m-sameer/mifos-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/m-sameer/mifos-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/m-sameer/mifos-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m-sameer/mifos-mobile/labels{/name}","releases_url":"https://api.github.com/repos/m-sameer/mifos-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/m-sameer/mifos-mobile/deployments","created_at":"2018-10-24T17:57:47Z","updated_at":"2018-10-24T17:57:51Z","pushed_at":"2018-10-28T09:05:04Z","git_url":"git://github.com/m-sameer/mifos-mobile.git","ssh_url":"git@github.com:m-sameer/mifos-mobile.git","clone_url":"https://github.com/m-sameer/mifos-mobile.git","svn_url":"https://github.com/m-sameer/mifos-mobile","homepage":null,"size":66944,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"openMF:development","ref":"development","sha":"aa20e9f1a30bf951a6aebfeca1e5dd0b13380ee9","user":{"login":"openMF","id":3473607,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzM2MDc=","avatar_url":"https://avatars0.githubusercontent.com/u/3473607?v=4","gravatar_id":"","url":"https://api.github.com/users/openMF","html_url":"https://github.com/openMF","followers_url":"https://api.github.com/users/openMF/followers","following_url":"https://api.github.com/users/openMF/following{/other_user}","gists_url":"https://api.github.com/users/openMF/gists{/gist_id}","starred_url":"https://api.github.com/users/openMF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openMF/subscriptions","organizations_url":"https://api.github.com/users/openMF/orgs","repos_url":"https://api.github.com/users/openMF/repos","events_url":"https://api.github.com/users/openMF/events{/privacy}","received_events_url":"https://api.github.com/users/openMF/received_events","type":"Organization","site_admin":false},"repo":{"id":59611171,"node_id":"MDEwOlJlcG9zaXRvcnk1OTYxMTE3MQ==","name":"mifos-mobile","full_name":"openMF/mifos-mobile","private":false,"owner":{"login":"openMF","id":3473607,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzM2MDc=","avatar_url":"https://avatars0.githubusercontent.com/u/3473607?v=4","gravatar_id":"","url":"https://api.github.com/users/openMF","html_url":"https://github.com/openMF","followers_url":"https://api.github.com/users/openMF/followers","following_url":"https://api.github.com/users/openMF/following{/other_user}","gists_url":"https://api.github.com/users/openMF/gists{/gist_id}","starred_url":"https://api.github.com/users/openMF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openMF/subscriptions","organizations_url":"https://api.github.com/users/openMF/orgs","repos_url":"https://api.github.com/users/openMF/repos","events_url":"https://api.github.com/users/openMF/events{/privacy}","received_events_url":"https://api.github.com/users/openMF/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openMF/mifos-mobile","description":"Repository for the Mifos Android Self Service App for clients","fork":false,"url":"https://api.github.com/repos/openMF/mifos-mobile","forks_url":"https://api.github.com/repos/openMF/mifos-mobile/forks","keys_url":"https://api.github.com/repos/openMF/mifos-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openMF/mifos-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openMF/mifos-mobile/teams","hooks_url":"https://api.github.com/repos/openMF/mifos-mobile/hooks","issue_events_url":"https://api.github.com/repos/openMF/mifos-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/openMF/mifos-mobile/events","assignees_url":"https://api.github.com/repos/openMF/mifos-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/openMF/mifos-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/openMF/mifos-mobile/tags","blobs_url":"https://api.github.com/repos/openMF/mifos-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openMF/mifos-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openMF/mifos-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/openMF/mifos-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openMF/mifos-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/openMF/mifos-mobile/languages","stargazers_url":"https://api.github.com/repos/openMF/mifos-mobile/stargazers","contributors_url":"https://api.github.com/repos/openMF/mifos-mobile/contributors","subscribers_url":"https://api.github.com/repos/openMF/mifos-mobile/subscribers","subscription_url":"https://api.github.com/repos/openMF/mifos-mobile/subscription","commits_url":"https://api.github.com/repos/openMF/mifos-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/openMF/mifos-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/openMF/mifos-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/openMF/mifos-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/openMF/mifos-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/openMF/mifos-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openMF/mifos-mobile/merges","archive_url":"https://api.github.com/repos/openMF/mifos-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openMF/mifos-mobile/downloads","issues_url":"https://api.github.com/repos/openMF/mifos-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/openMF/mifos-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/openMF/mifos-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/openMF/mifos-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openMF/mifos-mobile/labels{/name}","releases_url":"https://api.github.com/repos/openMF/mifos-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/openMF/mifos-mobile/deployments","created_at":"2016-05-24T21:51:53Z","updated_at":"2018-10-26T15:59:59Z","pushed_at":"2018-10-28T13:51:06Z","git_url":"git://github.com/openMF/mifos-mobile.git","ssh_url":"git@github.com:openMF/mifos-mobile.git","clone_url":"https://github.com/openMF/mifos-mobile.git","svn_url":"https://github.com/openMF/mifos-mobile","homepage":null,"size":66943,"stargazers_count":60,"watchers_count":60,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":216,"mirror_url":null,"archived":false,"open_issues_count":130,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":216,"open_issues":130,"watchers":60,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/openMF/mifos-mobile/pulls/913"},"html":{"href":"https://github.com/openMF/mifos-mobile/pull/913"},"issue":{"href":"https://api.github.com/repos/openMF/mifos-mobile/issues/913"},"comments":{"href":"https://api.github.com/repos/openMF/mifos-mobile/issues/913/comments"},"review_comments":{"href":"https://api.github.com/repos/openMF/mifos-mobile/pulls/913/comments"},"review_comment":{"href":"https://api.github.com/repos/openMF/mifos-mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openMF/mifos-mobile/pulls/913/commits"},"statuses":{"href":"https://api.github.com/repos/openMF/mifos-mobile/statuses/3c4515e992f832ae1ed5f5e2a3651bb530831fe9"}},"author_association":"NONE"}}
{"actor":{"display_login":"m-sameer"}}