{"action":"created","comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/226410983","pull_request_review_id":166227240,"id":226410983,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjQxMDk4Mw==","diff_hunk":"@@ -0,0 +1,68 @@\n+// Copyright 2018 The Cockroach Authors.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or\n+// implied. See the License for the specific language governing\n+// permissions and limitations under the License.\n+\n+package limit\n+\n+import (\n+\t\"context\"\n+\t\"runtime\"\n+\t\"sync/atomic\"\n+\t\"testing\"\n+\n+\t\"golang.org/x/sync/errgroup\"\n+\n+\t\"github.com/cockroachdb/cockroach/pkg/util/leaktest\"\n+)\n+\n+func TestConcurrentRequestLimiter(t *testing.T) {","path":"pkg/util/limit/limiter_test.go","position":28,"original_position":28,"commit_id":"e7e35ba6315c7b0407d84af01505359df17ced56","original_commit_id":"e7e35ba6315c7b0407d84af01505359df17ced56","user":{"login":"mjibson","id":41181,"node_id":"MDQ6VXNlcjQxMTgx","avatar_url":"https://avatars1.githubusercontent.com/u/41181?v=4","gravatar_id":"","url":"https://api.github.com/users/mjibson","html_url":"https://github.com/mjibson","followers_url":"https://api.github.com/users/mjibson/followers","following_url":"https://api.github.com/users/mjibson/following{/other_user}","gists_url":"https://api.github.com/users/mjibson/gists{/gist_id}","starred_url":"https://api.github.com/users/mjibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjibson/subscriptions","organizations_url":"https://api.github.com/users/mjibson/orgs","repos_url":"https://api.github.com/users/mjibson/repos","events_url":"https://api.github.com/users/mjibson/events{/privacy}","received_events_url":"https://api.github.com/users/mjibson/received_events","type":"User","site_admin":false},"body":"Do we need to run this test on every CI build? Seems excessive. Maybe skip it if t.Short is on?","created_at":"2018-10-18T18:09:40Z","updated_at":"2018-10-18T18:09:41Z","html_url":"https://github.com/cockroachdb/cockroach/pull/31594#discussion_r226410983","pull_request_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/31594","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/226410983"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/31594#discussion_r226410983"},"pull_request":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/31594"}}},"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/31594","id":224008426,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MDA4NDI2","html_url":"https://github.com/cockroachdb/cockroach/pull/31594","diff_url":"https://github.com/cockroachdb/cockroach/pull/31594.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/31594.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/31594","number":31594,"state":"open","locked":false,"title":"util/limit: always check ctx, add unit test","user":{"login":"dt","id":15615,"node_id":"MDQ6VXNlcjE1NjE1","avatar_url":"https://avatars2.githubusercontent.com/u/15615?v=4","gravatar_id":"","url":"https://api.github.com/users/dt","html_url":"https://github.com/dt","followers_url":"https://api.github.com/users/dt/followers","following_url":"https://api.github.com/users/dt/following{/other_user}","gists_url":"https://api.github.com/users/dt/gists{/gist_id}","starred_url":"https://api.github.com/users/dt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dt/subscriptions","organizations_url":"https://api.github.com/users/dt/orgs","repos_url":"https://api.github.com/users/dt/repos","events_url":"https://api.github.com/users/dt/events{/privacy}","received_events_url":"https://api.github.com/users/dt/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-18T15:49:07Z","updated_at":"2018-10-18T18:09:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce51a1780b4abe5f936474496cb03e15f1a6f547","assignee":null,"assignees":[],"requested_reviewers":[{"login":"petermattis","id":6201335,"node_id":"MDQ6VXNlcjYyMDEzMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/6201335?v=4","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/31594/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/31594/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/31594/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/e7e35ba6315c7b0407d84af01505359df17ced56","head":{"label":"dt:lim","ref":"lim","sha":"e7e35ba6315c7b0407d84af01505359df17ced56","user":{"login":"dt","id":15615,"node_id":"MDQ6VXNlcjE1NjE1","avatar_url":"https://avatars2.githubusercontent.com/u/15615?v=4","gravatar_id":"","url":"https://api.github.com/users/dt","html_url":"https://github.com/dt","followers_url":"https://api.github.com/users/dt/followers","following_url":"https://api.github.com/users/dt/following{/other_user}","gists_url":"https://api.github.com/users/dt/gists{/gist_id}","starred_url":"https://api.github.com/users/dt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dt/subscriptions","organizations_url":"https://api.github.com/users/dt/orgs","repos_url":"https://api.github.com/users/dt/repos","events_url":"https://api.github.com/users/dt/events{/privacy}","received_events_url":"https://api.github.com/users/dt/received_events","type":"User","site_admin":false},"repo":{"id":48062626,"node_id":"MDEwOlJlcG9zaXRvcnk0ODA2MjYyNg==","name":"cockroach","full_name":"dt/cockroach","private":false,"owner":{"login":"dt","id":15615,"node_id":"MDQ6VXNlcjE1NjE1","avatar_url":"https://avatars2.githubusercontent.com/u/15615?v=4","gravatar_id":"","url":"https://api.github.com/users/dt","html_url":"https://github.com/dt","followers_url":"https://api.github.com/users/dt/followers","following_url":"https://api.github.com/users/dt/following{/other_user}","gists_url":"https://api.github.com/users/dt/gists{/gist_id}","starred_url":"https://api.github.com/users/dt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dt/subscriptions","organizations_url":"https://api.github.com/users/dt/orgs","repos_url":"https://api.github.com/users/dt/repos","events_url":"https://api.github.com/users/dt/events{/privacy}","received_events_url":"https://api.github.com/users/dt/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dt/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":true,"url":"https://api.github.com/repos/dt/cockroach","forks_url":"https://api.github.com/repos/dt/cockroach/forks","keys_url":"https://api.github.com/repos/dt/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dt/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dt/cockroach/teams","hooks_url":"https://api.github.com/repos/dt/cockroach/hooks","issue_events_url":"https://api.github.com/repos/dt/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/dt/cockroach/events","assignees_url":"https://api.github.com/repos/dt/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/dt/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/dt/cockroach/tags","blobs_url":"https://api.github.com/repos/dt/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dt/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dt/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/dt/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dt/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/dt/cockroach/languages","stargazers_url":"https://api.github.com/repos/dt/cockroach/stargazers","contributors_url":"https://api.github.com/repos/dt/cockroach/contributors","subscribers_url":"https://api.github.com/repos/dt/cockroach/subscribers","subscription_url":"https://api.github.com/repos/dt/cockroach/subscription","commits_url":"https://api.github.com/repos/dt/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/dt/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/dt/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/dt/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/dt/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/dt/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dt/cockroach/merges","archive_url":"https://api.github.com/repos/dt/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dt/cockroach/downloads","issues_url":"https://api.github.com/repos/dt/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/dt/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/dt/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/dt/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dt/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/dt/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/dt/cockroach/deployments","created_at":"2015-12-15T18:54:23Z","updated_at":"2018-08-30T15:36:43Z","pushed_at":"2018-10-18T17:24:32Z","git_url":"git://github.com/dt/cockroach.git","ssh_url":"git@github.com:dt/cockroach.git","clone_url":"https://github.com/dt/cockroach.git","svn_url":"https://github.com/dt/cockroach","homepage":"http://www.cockroachlabs.com","size":524418,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"1f852af3d3c0f7d227372c80849d4749a324f028","user":{"login":"cockroachdb","id":6748139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NDgxMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU2MzU4Nw==","name":"cockroach","full_name":"cockroachdb/cockroach","private":false,"owner":{"login":"cockroachdb","id":6748139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NDgxMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cockroachdb/cockroach","description":"CockroachDB - the open source, cloud-native SQL database.","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2018-10-18T16:17:07Z","pushed_at":"2018-10-18T17:24:45Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":1043835,"stargazers_count":14511,"watchers_count":14511,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1535,"mirror_url":null,"archived":false,"open_issues_count":1870,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1535,"open_issues":1870,"watchers":14511,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/31594"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/31594"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/31594"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/31594/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/31594/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/31594/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/e7e35ba6315c7b0407d84af01505359df17ced56"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mjibson"}}