{"action":"created","issue":{"url":"https://api.github.com/repos/fastify/fastify/issues/886","repository_url":"https://api.github.com/repos/fastify/fastify","labels_url":"https://api.github.com/repos/fastify/fastify/issues/886/labels{/name}","comments_url":"https://api.github.com/repos/fastify/fastify/issues/886/comments","events_url":"https://api.github.com/repos/fastify/fastify/issues/886/events","html_url":"https://github.com/fastify/fastify/pull/886","id":314448471,"number":886,"title":"Block new incoming requests once close has been called","user":{"login":"delvedor","id":4865608,"avatar_url":"https://avatars0.githubusercontent.com/u/4865608?v=4","gravatar_id":"","url":"https://api.github.com/users/delvedor","html_url":"https://github.com/delvedor","followers_url":"https://api.github.com/users/delvedor/followers","following_url":"https://api.github.com/users/delvedor/following{/other_user}","gists_url":"https://api.github.com/users/delvedor/gists{/gist_id}","starred_url":"https://api.github.com/users/delvedor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delvedor/subscriptions","organizations_url":"https://api.github.com/users/delvedor/orgs","repos_url":"https://api.github.com/users/delvedor/repos","events_url":"https://api.github.com/users/delvedor/events{/privacy}","received_events_url":"https://api.github.com/users/delvedor/received_events","type":"User","site_admin":false},"labels":[{"id":451588688,"url":"https://api.github.com/repos/fastify/fastify/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":764678316,"url":"https://api.github.com/repos/fastify/fastify/labels/semver-minor","name":"semver-minor","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2018-04-15T20:22:40Z","updated_at":"2018-04-17T14:36:28Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/fastify/fastify/pulls/886","html_url":"https://github.com/fastify/fastify/pull/886","diff_url":"https://github.com/fastify/fastify/pull/886.diff","patch_url":"https://github.com/fastify/fastify/pull/886.patch"},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nTip: `npm run bench` to compare branches interactively.\r\n\r\nContributors guide: https://github.com/fastify/fastify/blob/master/CONTRIBUTING.md\r\n-->\r\nCurrently, if a user calls `fastify.close` and the server is under a heavy load, the server will not close until there is an open TCP connection, so every new request will execute the entire request lifecycle.\r\n\r\nWith this change once `fastify.close` is invoked, Fastify will automatically start to respond with a `503` error, closing every new connection as soon as possible.\r\n\r\nThere are not sensible changes in the benchmarks.\r\n\r\n#### Checklist\r\n\r\n- [x] run `npm run test` and `npm run benchmark`\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message and code follows [Code of conduct](https://github.com/fastify/fastify/blob/master/CODE_OF_CONDUCT.md)\r\n"},"comment":{"url":"https://api.github.com/repos/fastify/fastify/issues/comments/382016024","html_url":"https://github.com/fastify/fastify/pull/886#issuecomment-382016024","issue_url":"https://api.github.com/repos/fastify/fastify/issues/886","id":382016024,"user":{"login":"mcollina","id":52195,"avatar_url":"https://avatars0.githubusercontent.com/u/52195?v=4","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"created_at":"2018-04-17T14:36:28Z","updated_at":"2018-04-17T14:36:28Z","author_association":"OWNER","body":"You'll need to increaase that timeout: https://ci.appveyor.com/project/mcollina/fastify/build/job/x2ml3eliuojq3au2#L41."}}
{"actor":{"display_login":"mcollina"}}