{"action":"created","comment":{"url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/pulls/comments/229490491","pull_request_review_id":170005748,"id":229490491,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTQ5MDQ5MQ==","diff_hunk":"@@ -50,6 +51,113 @@ const entry = removeEmpty([\n     resolvePath(\"src/client/index.tsx\"),\n ]);\n \n+/**\n+ * Post CSS fixes\n+ */\n+const postCssPlugin = () => [\n+    require(\"postcss-flexbugs-fixes\"),\n+    autoprefixer({\n+        browsers: [\n+            \">1%\",\n+            \"last 4 versions\",\n+            \"Firefox ESR\",\n+            \"not ie < 9\", // React doesn\"t support IE8 anyway\n+        ],\n+        flexbox: \"no-2009\",\n+    }),\n+];\n+\n+/**\n+ * All other files that aren't caught by the other loaders will go through this one.\n+ * @description \"file\" loader makes sure those assets get served by WebpackDevServer.\n+ * When you `import` an asset, you get its (virtual) filename.\n+ * In production, they would get copied to the `build` folder.\n+ * This loader doesn\"t use a \"test\" so it will catch all modules\n+ * that fall through the other loaders.\n+ */\n+const catchAllRule = {\n+    exclude: [/\\.(js|jsx|mjs)$/, /\\.(ts|tsx)$/, /\\.html$/, /\\.json$/],\n+    loader: require.resolve(\"file-loader\"),\n+    options: {\n+        name: \"[name].[hash:8].[ext]\",\n+        outputPath: \"static/media/\", // TODO config\n+    },\n+};\n+\n+/**\n+ * Handle css/scss\n+ */\n+const scssRule: RuleSetRule = {\n+    test: /\\.(scss|sass|css)$/i,\n+    use: removeEmpty([\n+        ifProduction(MiniCssExtractPlugin.loader),\n+        ifDevelopment({loader: \"style-loader\"}),","path":"lib/app/configs/webpack/client.ts","position":59,"original_position":59,"commit_id":"f1149497828bdfb93cdf6b08c1b7ae8b9c6e5121","original_commit_id":"f1149497828bdfb93cdf6b08c1b7ae8b9c6e5121","user":{"login":"jimmynotjim","id":1280430,"node_id":"MDQ6VXNlcjEyODA0MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1280430?v=4","gravatar_id":"","url":"https://api.github.com/users/jimmynotjim","html_url":"https://github.com/jimmynotjim","followers_url":"https://api.github.com/users/jimmynotjim/followers","following_url":"https://api.github.com/users/jimmynotjim/following{/other_user}","gists_url":"https://api.github.com/users/jimmynotjim/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmynotjim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmynotjim/subscriptions","organizations_url":"https://api.github.com/users/jimmynotjim/orgs","repos_url":"https://api.github.com/users/jimmynotjim/repos","events_url":"https://api.github.com/users/jimmynotjim/events{/privacy}","received_events_url":"https://api.github.com/users/jimmynotjim/received_events","type":"User","site_admin":false},"body":"Nit: break each object onto a new line so it's easier to scan","created_at":"2018-10-30T21:20:15Z","updated_at":"2018-10-30T21:20:15Z","html_url":"https://github.com/pixeloven/typescript-react-component-library/pull/11#discussion_r229490491","pull_request_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/pulls/11","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/pixeloven/typescript-react-component-library/pulls/comments/229490491"},"html":{"href":"https://github.com/pixeloven/typescript-react-component-library/pull/11#discussion_r229490491"},"pull_request":{"href":"https://api.github.com/repos/pixeloven/typescript-react-component-library/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/pulls/11","id":227064893,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MDY0ODkz","html_url":"https://github.com/pixeloven/typescript-react-component-library/pull/11","diff_url":"https://github.com/pixeloven/typescript-react-component-library/pull/11.diff","patch_url":"https://github.com/pixeloven/typescript-react-component-library/pull/11.patch","issue_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/issues/11","number":11,"state":"open","locked":false,"title":"Organize component styles","user":{"login":"jimmynotjim","id":1280430,"node_id":"MDQ6VXNlcjEyODA0MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1280430?v=4","gravatar_id":"","url":"https://api.github.com/users/jimmynotjim","html_url":"https://github.com/jimmynotjim","followers_url":"https://api.github.com/users/jimmynotjim/followers","following_url":"https://api.github.com/users/jimmynotjim/following{/other_user}","gists_url":"https://api.github.com/users/jimmynotjim/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmynotjim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmynotjim/subscriptions","organizations_url":"https://api.github.com/users/jimmynotjim/orgs","repos_url":"https://api.github.com/users/jimmynotjim/repos","events_url":"https://api.github.com/users/jimmynotjim/events{/privacy}","received_events_url":"https://api.github.com/users/jimmynotjim/received_events","type":"User","site_admin":false},"body":"Update the component structure to include custom or imported styles\r\n\r\n- Imports custom styles directly to the component\r\n- Organizes core styles within the \"styles\" component\r\n- Imports the core styles in the main index file\r\n- Adds Logo and Icon components as exmaples\r\n- Update the config, storybook, and tests to accept imported style files","created_at":"2018-10-30T20:11:18Z","updated_at":"2018-10-30T21:20:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cebfb0653f9ca704eef2c3792d4e272d0f030123","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bburrier","id":508672,"node_id":"MDQ6VXNlcjUwODY3Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/508672?v=4","gravatar_id":"","url":"https://api.github.com/users/bburrier","html_url":"https://github.com/bburrier","followers_url":"https://api.github.com/users/bburrier/followers","following_url":"https://api.github.com/users/bburrier/following{/other_user}","gists_url":"https://api.github.com/users/bburrier/gists{/gist_id}","starred_url":"https://api.github.com/users/bburrier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bburrier/subscriptions","organizations_url":"https://api.github.com/users/bburrier/orgs","repos_url":"https://api.github.com/users/bburrier/repos","events_url":"https://api.github.com/users/bburrier/events{/privacy}","received_events_url":"https://api.github.com/users/bburrier/received_events","type":"User","site_admin":false},{"login":"henryrowswell","id":25657382,"node_id":"MDQ6VXNlcjI1NjU3Mzgy","avatar_url":"https://avatars0.githubusercontent.com/u/25657382?v=4","gravatar_id":"","url":"https://api.github.com/users/henryrowswell","html_url":"https://github.com/henryrowswell","followers_url":"https://api.github.com/users/henryrowswell/followers","following_url":"https://api.github.com/users/henryrowswell/following{/other_user}","gists_url":"https://api.github.com/users/henryrowswell/gists{/gist_id}","starred_url":"https://api.github.com/users/henryrowswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henryrowswell/subscriptions","organizations_url":"https://api.github.com/users/henryrowswell/orgs","repos_url":"https://api.github.com/users/henryrowswell/repos","events_url":"https://api.github.com/users/henryrowswell/events{/privacy}","received_events_url":"https://api.github.com/users/henryrowswell/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1007324637,"node_id":"MDU6TGFiZWwxMDA3MzI0NjM3","url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/pulls/11/commits","review_comments_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/pulls/11/comments","review_comment_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/issues/11/comments","statuses_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/statuses/f1149497828bdfb93cdf6b08c1b7ae8b9c6e5121","head":{"label":"pixeloven:organize-component-styles","ref":"organize-component-styles","sha":"f1149497828bdfb93cdf6b08c1b7ae8b9c6e5121","user":{"login":"pixeloven","id":5751260,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTEyNjA=","avatar_url":"https://avatars1.githubusercontent.com/u/5751260?v=4","gravatar_id":"","url":"https://api.github.com/users/pixeloven","html_url":"https://github.com/pixeloven","followers_url":"https://api.github.com/users/pixeloven/followers","following_url":"https://api.github.com/users/pixeloven/following{/other_user}","gists_url":"https://api.github.com/users/pixeloven/gists{/gist_id}","starred_url":"https://api.github.com/users/pixeloven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixeloven/subscriptions","organizations_url":"https://api.github.com/users/pixeloven/orgs","repos_url":"https://api.github.com/users/pixeloven/repos","events_url":"https://api.github.com/users/pixeloven/events{/privacy}","received_events_url":"https://api.github.com/users/pixeloven/received_events","type":"Organization","site_admin":false},"repo":{"id":142645608,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI2NDU2MDg=","name":"typescript-react-component-library","full_name":"pixeloven/typescript-react-component-library","private":false,"owner":{"login":"pixeloven","id":5751260,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTEyNjA=","avatar_url":"https://avatars1.githubusercontent.com/u/5751260?v=4","gravatar_id":"","url":"https://api.github.com/users/pixeloven","html_url":"https://github.com/pixeloven","followers_url":"https://api.github.com/users/pixeloven/followers","following_url":"https://api.github.com/users/pixeloven/following{/other_user}","gists_url":"https://api.github.com/users/pixeloven/gists{/gist_id}","starred_url":"https://api.github.com/users/pixeloven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixeloven/subscriptions","organizations_url":"https://api.github.com/users/pixeloven/orgs","repos_url":"https://api.github.com/users/pixeloven/repos","events_url":"https://api.github.com/users/pixeloven/events{/privacy}","received_events_url":"https://api.github.com/users/pixeloven/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pixeloven/typescript-react-component-library","description":null,"fork":false,"url":"https://api.github.com/repos/pixeloven/typescript-react-component-library","forks_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/forks","keys_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/teams","hooks_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/hooks","issue_events_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/issues/events{/number}","events_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/events","assignees_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/assignees{/user}","branches_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/branches{/branch}","tags_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/tags","blobs_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/statuses/{sha}","languages_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/languages","stargazers_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/stargazers","contributors_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/contributors","subscribers_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/subscribers","subscription_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/subscription","commits_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/contents/{+path}","compare_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/merges","archive_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/downloads","issues_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/issues{/number}","pulls_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/pulls{/number}","milestones_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/milestones{/number}","notifications_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/labels{/name}","releases_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/releases{/id}","deployments_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/deployments","created_at":"2018-07-28T04:07:04Z","updated_at":"2018-10-29T23:18:56Z","pushed_at":"2018-10-30T21:16:08Z","git_url":"git://github.com/pixeloven/typescript-react-component-library.git","ssh_url":"git@github.com:pixeloven/typescript-react-component-library.git","clone_url":"https://github.com/pixeloven/typescript-react-component-library.git","svn_url":"https://github.com/pixeloven/typescript-react-component-library","homepage":null,"size":2869,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"pixeloven:master","ref":"master","sha":"26b22b7f6faa6fb6b09b8be4435227d0cf52f485","user":{"login":"pixeloven","id":5751260,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTEyNjA=","avatar_url":"https://avatars1.githubusercontent.com/u/5751260?v=4","gravatar_id":"","url":"https://api.github.com/users/pixeloven","html_url":"https://github.com/pixeloven","followers_url":"https://api.github.com/users/pixeloven/followers","following_url":"https://api.github.com/users/pixeloven/following{/other_user}","gists_url":"https://api.github.com/users/pixeloven/gists{/gist_id}","starred_url":"https://api.github.com/users/pixeloven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixeloven/subscriptions","organizations_url":"https://api.github.com/users/pixeloven/orgs","repos_url":"https://api.github.com/users/pixeloven/repos","events_url":"https://api.github.com/users/pixeloven/events{/privacy}","received_events_url":"https://api.github.com/users/pixeloven/received_events","type":"Organization","site_admin":false},"repo":{"id":142645608,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI2NDU2MDg=","name":"typescript-react-component-library","full_name":"pixeloven/typescript-react-component-library","private":false,"owner":{"login":"pixeloven","id":5751260,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTEyNjA=","avatar_url":"https://avatars1.githubusercontent.com/u/5751260?v=4","gravatar_id":"","url":"https://api.github.com/users/pixeloven","html_url":"https://github.com/pixeloven","followers_url":"https://api.github.com/users/pixeloven/followers","following_url":"https://api.github.com/users/pixeloven/following{/other_user}","gists_url":"https://api.github.com/users/pixeloven/gists{/gist_id}","starred_url":"https://api.github.com/users/pixeloven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixeloven/subscriptions","organizations_url":"https://api.github.com/users/pixeloven/orgs","repos_url":"https://api.github.com/users/pixeloven/repos","events_url":"https://api.github.com/users/pixeloven/events{/privacy}","received_events_url":"https://api.github.com/users/pixeloven/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pixeloven/typescript-react-component-library","description":null,"fork":false,"url":"https://api.github.com/repos/pixeloven/typescript-react-component-library","forks_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/forks","keys_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/teams","hooks_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/hooks","issue_events_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/issues/events{/number}","events_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/events","assignees_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/assignees{/user}","branches_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/branches{/branch}","tags_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/tags","blobs_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/statuses/{sha}","languages_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/languages","stargazers_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/stargazers","contributors_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/contributors","subscribers_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/subscribers","subscription_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/subscription","commits_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/contents/{+path}","compare_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/merges","archive_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/downloads","issues_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/issues{/number}","pulls_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/pulls{/number}","milestones_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/milestones{/number}","notifications_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/labels{/name}","releases_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/releases{/id}","deployments_url":"https://api.github.com/repos/pixeloven/typescript-react-component-library/deployments","created_at":"2018-07-28T04:07:04Z","updated_at":"2018-10-29T23:18:56Z","pushed_at":"2018-10-30T21:16:08Z","git_url":"git://github.com/pixeloven/typescript-react-component-library.git","ssh_url":"git@github.com:pixeloven/typescript-react-component-library.git","clone_url":"https://github.com/pixeloven/typescript-react-component-library.git","svn_url":"https://github.com/pixeloven/typescript-react-component-library","homepage":null,"size":2869,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pixeloven/typescript-react-component-library/pulls/11"},"html":{"href":"https://github.com/pixeloven/typescript-react-component-library/pull/11"},"issue":{"href":"https://api.github.com/repos/pixeloven/typescript-react-component-library/issues/11"},"comments":{"href":"https://api.github.com/repos/pixeloven/typescript-react-component-library/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/pixeloven/typescript-react-component-library/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/pixeloven/typescript-react-component-library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pixeloven/typescript-react-component-library/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/pixeloven/typescript-react-component-library/statuses/f1149497828bdfb93cdf6b08c1b7ae8b9c6e5121"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jimmynotjim"}}