{"action":"created","comment":{"url":"https://api.github.com/repos/centrifuge/go-centrifuge/pulls/comments/241409209","pull_request_review_id":184672600,"id":241409209,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTQwOTIwOQ==","diff_hunk":"@@ -0,0 +1,271 @@\n+package config\n+\n+import (\n+\t\"encoding/json\"\n+\t\"fmt\"\n+\t\"reflect\"\n+\t\"sync\"\n+\n+\t\"github.com/syndtr/goleveldb/leveldb\"\n+\t\"github.com/syndtr/goleveldb/leveldb/util\"\n+)\n+\n+const (\n+\tConfigPrefix string = \"config\"","path":"config/repository.go","position":null,"original_position":14,"commit_id":"a1434d99110dcfceeaa84e53adc0147978ad1a92","original_commit_id":"c84551a757c477020f01f6325f92824e8c871375","user":{"login":"vedhavyas","id":7549475,"node_id":"MDQ6VXNlcjc1NDk0NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/7549475?v=4","gravatar_id":"","url":"https://api.github.com/users/vedhavyas","html_url":"https://github.com/vedhavyas","followers_url":"https://api.github.com/users/vedhavyas/followers","following_url":"https://api.github.com/users/vedhavyas/following{/other_user}","gists_url":"https://api.github.com/users/vedhavyas/gists{/gist_id}","starred_url":"https://api.github.com/users/vedhavyas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vedhavyas/subscriptions","organizations_url":"https://api.github.com/users/vedhavyas/orgs","repos_url":"https://api.github.com/users/vedhavyas/repos","events_url":"https://api.github.com/users/vedhavyas/events{/privacy}","received_events_url":"https://api.github.com/users/vedhavyas/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n\tConfigPrefix string = \"config-\"\r\n```","created_at":"2018-12-13T14:00:49Z","updated_at":"2018-12-13T14:04:05Z","html_url":"https://github.com/centrifuge/go-centrifuge/pull/560#discussion_r241409209","pull_request_url":"https://api.github.com/repos/centrifuge/go-centrifuge/pulls/560","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/centrifuge/go-centrifuge/pulls/comments/241409209"},"html":{"href":"https://github.com/centrifuge/go-centrifuge/pull/560#discussion_r241409209"},"pull_request":{"href":"https://api.github.com/repos/centrifuge/go-centrifuge/pulls/560"}}},"pull_request":{"url":"https://api.github.com/repos/centrifuge/go-centrifuge/pulls/560","id":238043172,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MDQzMTcy","html_url":"https://github.com/centrifuge/go-centrifuge/pull/560","diff_url":"https://github.com/centrifuge/go-centrifuge/pull/560.diff","patch_url":"https://github.com/centrifuge/go-centrifuge/pull/560.patch","issue_url":"https://api.github.com/repos/centrifuge/go-centrifuge/issues/560","number":560,"state":"open","locked":false,"title":"Config repository ","user":{"login":"mikiquantum","id":14960066,"node_id":"MDQ6VXNlcjE0OTYwMDY2","avatar_url":"https://avatars0.githubusercontent.com/u/14960066?v=4","gravatar_id":"","url":"https://api.github.com/users/mikiquantum","html_url":"https://github.com/mikiquantum","followers_url":"https://api.github.com/users/mikiquantum/followers","following_url":"https://api.github.com/users/mikiquantum/following{/other_user}","gists_url":"https://api.github.com/users/mikiquantum/gists{/gist_id}","starred_url":"https://api.github.com/users/mikiquantum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikiquantum/subscriptions","organizations_url":"https://api.github.com/users/mikiquantum/orgs","repos_url":"https://api.github.com/users/mikiquantum/repos","events_url":"https://api.github.com/users/mikiquantum/events{/privacy}","received_events_url":"https://api.github.com/users/mikiquantum/received_events","type":"User","site_admin":false},"body":"Addressed here: \r\n- Creation of Repository interface with needed methods for TenantConfig and NodeConfig Models\r\n- Moved config dependency out of storage. Keeping storage bootstrapper so we can abstract the DB backend there.\r\n\r\nNOT Addressed here, but will be addressed in a next PR:\r\n- Creating intermediate storage Interface that:\r\n   - Encapsulate DB Backend used\r\n   - Share common base methods across different repositories\r\n\r\n","created_at":"2018-12-12T13:47:45Z","updated_at":"2018-12-13T14:04:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b563f9ca6430a5a5a120f0c0ce5f800273dbad3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/centrifuge/go-centrifuge/pulls/560/commits","review_comments_url":"https://api.github.com/repos/centrifuge/go-centrifuge/pulls/560/comments","review_comment_url":"https://api.github.com/repos/centrifuge/go-centrifuge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/centrifuge/go-centrifuge/issues/560/comments","statuses_url":"https://api.github.com/repos/centrifuge/go-centrifuge/statuses/a1434d99110dcfceeaa84e53adc0147978ad1a92","head":{"label":"mikiquantum:config/db","ref":"config/db","sha":"a1434d99110dcfceeaa84e53adc0147978ad1a92","user":{"login":"mikiquantum","id":14960066,"node_id":"MDQ6VXNlcjE0OTYwMDY2","avatar_url":"https://avatars0.githubusercontent.com/u/14960066?v=4","gravatar_id":"","url":"https://api.github.com/users/mikiquantum","html_url":"https://github.com/mikiquantum","followers_url":"https://api.github.com/users/mikiquantum/followers","following_url":"https://api.github.com/users/mikiquantum/following{/other_user}","gists_url":"https://api.github.com/users/mikiquantum/gists{/gist_id}","starred_url":"https://api.github.com/users/mikiquantum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikiquantum/subscriptions","organizations_url":"https://api.github.com/users/mikiquantum/orgs","repos_url":"https://api.github.com/users/mikiquantum/repos","events_url":"https://api.github.com/users/mikiquantum/events{/privacy}","received_events_url":"https://api.github.com/users/mikiquantum/received_events","type":"User","site_admin":false},"repo":{"id":155191015,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUxOTEwMTU=","name":"go-centrifuge","full_name":"mikiquantum/go-centrifuge","private":false,"owner":{"login":"mikiquantum","id":14960066,"node_id":"MDQ6VXNlcjE0OTYwMDY2","avatar_url":"https://avatars0.githubusercontent.com/u/14960066?v=4","gravatar_id":"","url":"https://api.github.com/users/mikiquantum","html_url":"https://github.com/mikiquantum","followers_url":"https://api.github.com/users/mikiquantum/followers","following_url":"https://api.github.com/users/mikiquantum/following{/other_user}","gists_url":"https://api.github.com/users/mikiquantum/gists{/gist_id}","starred_url":"https://api.github.com/users/mikiquantum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikiquantum/subscriptions","organizations_url":"https://api.github.com/users/mikiquantum/orgs","repos_url":"https://api.github.com/users/mikiquantum/repos","events_url":"https://api.github.com/users/mikiquantum/events{/privacy}","received_events_url":"https://api.github.com/users/mikiquantum/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mikiquantum/go-centrifuge","description":"Golang implementation of Centrifuge Node","fork":true,"url":"https://api.github.com/repos/mikiquantum/go-centrifuge","forks_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/forks","keys_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/teams","hooks_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/hooks","issue_events_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/issues/events{/number}","events_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/events","assignees_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/assignees{/user}","branches_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/branches{/branch}","tags_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/tags","blobs_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/statuses/{sha}","languages_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/languages","stargazers_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/stargazers","contributors_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/contributors","subscribers_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/subscribers","subscription_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/subscription","commits_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/contents/{+path}","compare_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/merges","archive_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/downloads","issues_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/issues{/number}","pulls_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/pulls{/number}","milestones_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/milestones{/number}","notifications_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/labels{/name}","releases_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/releases{/id}","deployments_url":"https://api.github.com/repos/mikiquantum/go-centrifuge/deployments","created_at":"2018-10-29T10:11:49Z","updated_at":"2018-10-30T13:00:38Z","pushed_at":"2018-12-13T13:59:27Z","git_url":"git://github.com/mikiquantum/go-centrifuge.git","ssh_url":"git@github.com:mikiquantum/go-centrifuge.git","clone_url":"https://github.com/mikiquantum/go-centrifuge.git","svn_url":"https://github.com/mikiquantum/go-centrifuge","homepage":"","size":12233,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"centrifuge:develop","ref":"develop","sha":"95fdcbb813013ae4ecebc78ff0640d792975ac70","user":{"login":"centrifuge","id":37558527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NTU4NTI3","avatar_url":"https://avatars1.githubusercontent.com/u/37558527?v=4","gravatar_id":"","url":"https://api.github.com/users/centrifuge","html_url":"https://github.com/centrifuge","followers_url":"https://api.github.com/users/centrifuge/followers","following_url":"https://api.github.com/users/centrifuge/following{/other_user}","gists_url":"https://api.github.com/users/centrifuge/gists{/gist_id}","starred_url":"https://api.github.com/users/centrifuge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/centrifuge/subscriptions","organizations_url":"https://api.github.com/users/centrifuge/orgs","repos_url":"https://api.github.com/users/centrifuge/repos","events_url":"https://api.github.com/users/centrifuge/events{/privacy}","received_events_url":"https://api.github.com/users/centrifuge/received_events","type":"Organization","site_admin":false},"repo":{"id":117913195,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc5MTMxOTU=","name":"go-centrifuge","full_name":"centrifuge/go-centrifuge","private":false,"owner":{"login":"centrifuge","id":37558527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NTU4NTI3","avatar_url":"https://avatars1.githubusercontent.com/u/37558527?v=4","gravatar_id":"","url":"https://api.github.com/users/centrifuge","html_url":"https://github.com/centrifuge","followers_url":"https://api.github.com/users/centrifuge/followers","following_url":"https://api.github.com/users/centrifuge/following{/other_user}","gists_url":"https://api.github.com/users/centrifuge/gists{/gist_id}","starred_url":"https://api.github.com/users/centrifuge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/centrifuge/subscriptions","organizations_url":"https://api.github.com/users/centrifuge/orgs","repos_url":"https://api.github.com/users/centrifuge/repos","events_url":"https://api.github.com/users/centrifuge/events{/privacy}","received_events_url":"https://api.github.com/users/centrifuge/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/centrifuge/go-centrifuge","description":"Golang implementation of Centrifuge Node","fork":false,"url":"https://api.github.com/repos/centrifuge/go-centrifuge","forks_url":"https://api.github.com/repos/centrifuge/go-centrifuge/forks","keys_url":"https://api.github.com/repos/centrifuge/go-centrifuge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/centrifuge/go-centrifuge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/centrifuge/go-centrifuge/teams","hooks_url":"https://api.github.com/repos/centrifuge/go-centrifuge/hooks","issue_events_url":"https://api.github.com/repos/centrifuge/go-centrifuge/issues/events{/number}","events_url":"https://api.github.com/repos/centrifuge/go-centrifuge/events","assignees_url":"https://api.github.com/repos/centrifuge/go-centrifuge/assignees{/user}","branches_url":"https://api.github.com/repos/centrifuge/go-centrifuge/branches{/branch}","tags_url":"https://api.github.com/repos/centrifuge/go-centrifuge/tags","blobs_url":"https://api.github.com/repos/centrifuge/go-centrifuge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/centrifuge/go-centrifuge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/centrifuge/go-centrifuge/git/refs{/sha}","trees_url":"https://api.github.com/repos/centrifuge/go-centrifuge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/centrifuge/go-centrifuge/statuses/{sha}","languages_url":"https://api.github.com/repos/centrifuge/go-centrifuge/languages","stargazers_url":"https://api.github.com/repos/centrifuge/go-centrifuge/stargazers","contributors_url":"https://api.github.com/repos/centrifuge/go-centrifuge/contributors","subscribers_url":"https://api.github.com/repos/centrifuge/go-centrifuge/subscribers","subscription_url":"https://api.github.com/repos/centrifuge/go-centrifuge/subscription","commits_url":"https://api.github.com/repos/centrifuge/go-centrifuge/commits{/sha}","git_commits_url":"https://api.github.com/repos/centrifuge/go-centrifuge/git/commits{/sha}","comments_url":"https://api.github.com/repos/centrifuge/go-centrifuge/comments{/number}","issue_comment_url":"https://api.github.com/repos/centrifuge/go-centrifuge/issues/comments{/number}","contents_url":"https://api.github.com/repos/centrifuge/go-centrifuge/contents/{+path}","compare_url":"https://api.github.com/repos/centrifuge/go-centrifuge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/centrifuge/go-centrifuge/merges","archive_url":"https://api.github.com/repos/centrifuge/go-centrifuge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/centrifuge/go-centrifuge/downloads","issues_url":"https://api.github.com/repos/centrifuge/go-centrifuge/issues{/number}","pulls_url":"https://api.github.com/repos/centrifuge/go-centrifuge/pulls{/number}","milestones_url":"https://api.github.com/repos/centrifuge/go-centrifuge/milestones{/number}","notifications_url":"https://api.github.com/repos/centrifuge/go-centrifuge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/centrifuge/go-centrifuge/labels{/name}","releases_url":"https://api.github.com/repos/centrifuge/go-centrifuge/releases{/id}","deployments_url":"https://api.github.com/repos/centrifuge/go-centrifuge/deployments","created_at":"2018-01-18T01:11:23Z","updated_at":"2018-12-13T14:02:58Z","pushed_at":"2018-12-13T14:02:56Z","git_url":"git://github.com/centrifuge/go-centrifuge.git","ssh_url":"git@github.com:centrifuge/go-centrifuge.git","clone_url":"https://github.com/centrifuge/go-centrifuge.git","svn_url":"https://github.com/centrifuge/go-centrifuge","homepage":"","size":12224,"stargazers_count":10,"watchers_count":10,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":74,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":74,"watchers":10,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/centrifuge/go-centrifuge/pulls/560"},"html":{"href":"https://github.com/centrifuge/go-centrifuge/pull/560"},"issue":{"href":"https://api.github.com/repos/centrifuge/go-centrifuge/issues/560"},"comments":{"href":"https://api.github.com/repos/centrifuge/go-centrifuge/issues/560/comments"},"review_comments":{"href":"https://api.github.com/repos/centrifuge/go-centrifuge/pulls/560/comments"},"review_comment":{"href":"https://api.github.com/repos/centrifuge/go-centrifuge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/centrifuge/go-centrifuge/pulls/560/commits"},"statuses":{"href":"https://api.github.com/repos/centrifuge/go-centrifuge/statuses/a1434d99110dcfceeaa84e53adc0147978ad1a92"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vedhavyas"}}