{"action":"created","comment":{"url":"https://api.github.com/repos/decred/dcrdata/pulls/comments/217806490","pull_request_review_id":155615266,"id":217806490,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzgwNjQ5MA==","diff_hunk":"@@ -960,12 +965,52 @@ func RetrieveVinByID(db *sql.DB, vinDbID uint64) (prevOutHash string, prevOutVou\n \tprevOutTree int8, txHash string, txVinInd uint32, txTree int8, valueIn int64, err error) {\n \tvar blockTime uint64\n \tvar isValid, isMainchain bool\n+\tvar txType uint32\n \terr = db.QueryRow(internal.SelectAllVinInfoByID, vinDbID).\n \t\tScan(&txHash, &txVinInd, &txTree, &isValid, &isMainchain, &blockTime,\n-\t\t\t&prevOutHash, &prevOutVoutInd, &prevOutTree, &valueIn)\n+\t\t\t&prevOutHash, &prevOutVoutInd, &prevOutTree, &valueIn, &txType)","path":"db/dcrpg/queries.go","position":24,"original_position":24,"commit_id":"6c100816655cc5a0ed3cb3e520f9483d02910a9b","original_commit_id":"6c100816655cc5a0ed3cb3e520f9483d02910a9b","user":{"login":"chappjc","id":9373513,"node_id":"MDQ6VXNlcjkzNzM1MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9373513?v=4","gravatar_id":"","url":"https://api.github.com/users/chappjc","html_url":"https://github.com/chappjc","followers_url":"https://api.github.com/users/chappjc/followers","following_url":"https://api.github.com/users/chappjc/following{/other_user}","gists_url":"https://api.github.com/users/chappjc/gists{/gist_id}","starred_url":"https://api.github.com/users/chappjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chappjc/subscriptions","organizations_url":"https://api.github.com/users/chappjc/orgs","repos_url":"https://api.github.com/users/chappjc/repos","events_url":"https://api.github.com/users/chappjc/events{/privacy}","received_events_url":"https://api.github.com/users/chappjc/received_events","type":"User","site_admin":false},"body":"Bug fix to backport.","created_at":"2018-09-14T18:39:27Z","updated_at":"2018-09-14T18:40:24Z","html_url":"https://github.com/decred/dcrdata/pull/676#discussion_r217806490","pull_request_url":"https://api.github.com/repos/decred/dcrdata/pulls/676","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/decred/dcrdata/pulls/comments/217806490"},"html":{"href":"https://github.com/decred/dcrdata/pull/676#discussion_r217806490"},"pull_request":{"href":"https://api.github.com/repos/decred/dcrdata/pulls/676"}}},"pull_request":{"url":"https://api.github.com/repos/decred/dcrdata/pulls/676","id":214464953,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NDY0OTUz","html_url":"https://github.com/decred/dcrdata/pull/676","diff_url":"https://github.com/decred/dcrdata/pull/676.diff","patch_url":"https://github.com/decred/dcrdata/pull/676.patch","issue_url":"https://api.github.com/repos/decred/dcrdata/issues/676","number":676,"state":"open","locked":false,"title":"Invalidated transaction display","user":{"login":"chappjc","id":9373513,"node_id":"MDQ6VXNlcjkzNzM1MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9373513?v=4","gravatar_id":"","url":"https://api.github.com/users/chappjc","html_url":"https://github.com/chappjc","followers_url":"https://api.github.com/users/chappjc/followers","following_url":"https://api.github.com/users/chappjc/following{/other_user}","gists_url":"https://api.github.com/users/chappjc/gists{/gist_id}","starred_url":"https://api.github.com/users/chappjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chappjc/subscriptions","organizations_url":"https://api.github.com/users/chappjc/orgs","repos_url":"https://api.github.com/users/chappjc/repos","events_url":"https://api.github.com/users/chappjc/events{/privacy}","received_events_url":"https://api.github.com/users/chappjc/received_events","type":"User","site_admin":false},"body":"If a transaction is not known to dcrd, it is because it has been orphaned by a reorg, invalidated via stakeholder disapproval, or both. This change will attempt to load details of the transaction from the\r\ndcrpg database, which may have decoded and recorded the transaction.\r\n\r\nAdd a message to the transaction page when the transaction is not found in any valid and mainchain block:\r\n\r\n![image](https://user-images.githubusercontent.com/9373513/45328299-ff345200-b520-11e8-842d-b1aa6f2a7538.png)\r\n\r\nTasks:\r\n- [x] Load transaction details from DB rather than dcrd.\r\n- [x] Handle globally-invalidated/sidechain transactions with a message on the transaction page.\r\n- [x] Pull the vins and vouts from the db too.\r\n\r\nFuture: See if it is easier, more efficient, or feasible to pull the entire block from dcrd instead of checking the database.","created_at":"2018-09-10T22:43:36Z","updated_at":"2018-09-14T18:40:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"648ff2a3335d4b6e2e52338950ce393c127f3056","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":693888256,"node_id":"MDU6TGFiZWw2OTM4ODgyNTY=","url":"https://api.github.com/repos/decred/dcrdata/labels/work%20in%20progress","name":"work in progress","color":"d4c5f9","default":false}],"milestone":{"url":"https://api.github.com/repos/decred/dcrdata/milestones/27","html_url":"https://github.com/decred/dcrdata/milestone/27","labels_url":"https://api.github.com/repos/decred/dcrdata/milestones/27/labels","id":3561187,"node_id":"MDk6TWlsZXN0b25lMzU2MTE4Nw==","number":27,"title":"3.1","description":null,"creator":{"login":"chappjc","id":9373513,"node_id":"MDQ6VXNlcjkzNzM1MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9373513?v=4","gravatar_id":"","url":"https://api.github.com/users/chappjc","html_url":"https://github.com/chappjc","followers_url":"https://api.github.com/users/chappjc/followers","following_url":"https://api.github.com/users/chappjc/following{/other_user}","gists_url":"https://api.github.com/users/chappjc/gists{/gist_id}","starred_url":"https://api.github.com/users/chappjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chappjc/subscriptions","organizations_url":"https://api.github.com/users/chappjc/orgs","repos_url":"https://api.github.com/users/chappjc/repos","events_url":"https://api.github.com/users/chappjc/events{/privacy}","received_events_url":"https://api.github.com/users/chappjc/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":15,"state":"open","created_at":"2018-08-10T15:01:29Z","updated_at":"2018-09-13T17:23:53Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/decred/dcrdata/pulls/676/commits","review_comments_url":"https://api.github.com/repos/decred/dcrdata/pulls/676/comments","review_comment_url":"https://api.github.com/repos/decred/dcrdata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/decred/dcrdata/issues/676/comments","statuses_url":"https://api.github.com/repos/decred/dcrdata/statuses/6c100816655cc5a0ed3cb3e520f9483d02910a9b","head":{"label":"chappjc:invalid-transaction-display","ref":"invalid-transaction-display","sha":"6c100816655cc5a0ed3cb3e520f9483d02910a9b","user":{"login":"chappjc","id":9373513,"node_id":"MDQ6VXNlcjkzNzM1MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9373513?v=4","gravatar_id":"","url":"https://api.github.com/users/chappjc","html_url":"https://github.com/chappjc","followers_url":"https://api.github.com/users/chappjc/followers","following_url":"https://api.github.com/users/chappjc/following{/other_user}","gists_url":"https://api.github.com/users/chappjc/gists{/gist_id}","starred_url":"https://api.github.com/users/chappjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chappjc/subscriptions","organizations_url":"https://api.github.com/users/chappjc/orgs","repos_url":"https://api.github.com/users/chappjc/repos","events_url":"https://api.github.com/users/chappjc/events{/privacy}","received_events_url":"https://api.github.com/users/chappjc/received_events","type":"User","site_admin":false},"repo":{"id":123041252,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMwNDEyNTI=","name":"dcrdata","full_name":"chappjc/dcrdata","owner":{"login":"chappjc","id":9373513,"node_id":"MDQ6VXNlcjkzNzM1MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9373513?v=4","gravatar_id":"","url":"https://api.github.com/users/chappjc","html_url":"https://github.com/chappjc","followers_url":"https://api.github.com/users/chappjc/followers","following_url":"https://api.github.com/users/chappjc/following{/other_user}","gists_url":"https://api.github.com/users/chappjc/gists{/gist_id}","starred_url":"https://api.github.com/users/chappjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chappjc/subscriptions","organizations_url":"https://api.github.com/users/chappjc/orgs","repos_url":"https://api.github.com/users/chappjc/repos","events_url":"https://api.github.com/users/chappjc/events{/privacy}","received_events_url":"https://api.github.com/users/chappjc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chappjc/dcrdata","description":"Decred block explorer, with packages and apps for data collection and storage. Written in Go.","fork":true,"url":"https://api.github.com/repos/chappjc/dcrdata","forks_url":"https://api.github.com/repos/chappjc/dcrdata/forks","keys_url":"https://api.github.com/repos/chappjc/dcrdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chappjc/dcrdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chappjc/dcrdata/teams","hooks_url":"https://api.github.com/repos/chappjc/dcrdata/hooks","issue_events_url":"https://api.github.com/repos/chappjc/dcrdata/issues/events{/number}","events_url":"https://api.github.com/repos/chappjc/dcrdata/events","assignees_url":"https://api.github.com/repos/chappjc/dcrdata/assignees{/user}","branches_url":"https://api.github.com/repos/chappjc/dcrdata/branches{/branch}","tags_url":"https://api.github.com/repos/chappjc/dcrdata/tags","blobs_url":"https://api.github.com/repos/chappjc/dcrdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chappjc/dcrdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chappjc/dcrdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/chappjc/dcrdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chappjc/dcrdata/statuses/{sha}","languages_url":"https://api.github.com/repos/chappjc/dcrdata/languages","stargazers_url":"https://api.github.com/repos/chappjc/dcrdata/stargazers","contributors_url":"https://api.github.com/repos/chappjc/dcrdata/contributors","subscribers_url":"https://api.github.com/repos/chappjc/dcrdata/subscribers","subscription_url":"https://api.github.com/repos/chappjc/dcrdata/subscription","commits_url":"https://api.github.com/repos/chappjc/dcrdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/chappjc/dcrdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/chappjc/dcrdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/chappjc/dcrdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/chappjc/dcrdata/contents/{+path}","compare_url":"https://api.github.com/repos/chappjc/dcrdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chappjc/dcrdata/merges","archive_url":"https://api.github.com/repos/chappjc/dcrdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chappjc/dcrdata/downloads","issues_url":"https://api.github.com/repos/chappjc/dcrdata/issues{/number}","pulls_url":"https://api.github.com/repos/chappjc/dcrdata/pulls{/number}","milestones_url":"https://api.github.com/repos/chappjc/dcrdata/milestones{/number}","notifications_url":"https://api.github.com/repos/chappjc/dcrdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chappjc/dcrdata/labels{/name}","releases_url":"https://api.github.com/repos/chappjc/dcrdata/releases{/id}","deployments_url":"https://api.github.com/repos/chappjc/dcrdata/deployments","created_at":"2018-02-26T22:50:30Z","updated_at":"2018-02-26T22:50:32Z","pushed_at":"2018-09-14T18:34:41Z","git_url":"git://github.com/chappjc/dcrdata.git","ssh_url":"git@github.com:chappjc/dcrdata.git","clone_url":"https://github.com/chappjc/dcrdata.git","svn_url":"https://github.com/chappjc/dcrdata","homepage":"https://explorer.dcrdata.org/","size":8469,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"decred:master","ref":"master","sha":"bb7b637ac218996db99aba96553375c03948d67f","user":{"login":"decred","id":16297194,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjk3MTk0","avatar_url":"https://avatars3.githubusercontent.com/u/16297194?v=4","gravatar_id":"","url":"https://api.github.com/users/decred","html_url":"https://github.com/decred","followers_url":"https://api.github.com/users/decred/followers","following_url":"https://api.github.com/users/decred/following{/other_user}","gists_url":"https://api.github.com/users/decred/gists{/gist_id}","starred_url":"https://api.github.com/users/decred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decred/subscriptions","organizations_url":"https://api.github.com/users/decred/orgs","repos_url":"https://api.github.com/users/decred/repos","events_url":"https://api.github.com/users/decred/events{/privacy}","received_events_url":"https://api.github.com/users/decred/received_events","type":"Organization","site_admin":false},"repo":{"id":82826361,"node_id":"MDEwOlJlcG9zaXRvcnk4MjgyNjM2MQ==","name":"dcrdata","full_name":"decred/dcrdata","owner":{"login":"decred","id":16297194,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjk3MTk0","avatar_url":"https://avatars3.githubusercontent.com/u/16297194?v=4","gravatar_id":"","url":"https://api.github.com/users/decred","html_url":"https://github.com/decred","followers_url":"https://api.github.com/users/decred/followers","following_url":"https://api.github.com/users/decred/following{/other_user}","gists_url":"https://api.github.com/users/decred/gists{/gist_id}","starred_url":"https://api.github.com/users/decred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decred/subscriptions","organizations_url":"https://api.github.com/users/decred/orgs","repos_url":"https://api.github.com/users/decred/repos","events_url":"https://api.github.com/users/decred/events{/privacy}","received_events_url":"https://api.github.com/users/decred/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/decred/dcrdata","description":"Decred block explorer, with packages and apps for data collection and storage. Written in Go.","fork":false,"url":"https://api.github.com/repos/decred/dcrdata","forks_url":"https://api.github.com/repos/decred/dcrdata/forks","keys_url":"https://api.github.com/repos/decred/dcrdata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decred/dcrdata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decred/dcrdata/teams","hooks_url":"https://api.github.com/repos/decred/dcrdata/hooks","issue_events_url":"https://api.github.com/repos/decred/dcrdata/issues/events{/number}","events_url":"https://api.github.com/repos/decred/dcrdata/events","assignees_url":"https://api.github.com/repos/decred/dcrdata/assignees{/user}","branches_url":"https://api.github.com/repos/decred/dcrdata/branches{/branch}","tags_url":"https://api.github.com/repos/decred/dcrdata/tags","blobs_url":"https://api.github.com/repos/decred/dcrdata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decred/dcrdata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decred/dcrdata/git/refs{/sha}","trees_url":"https://api.github.com/repos/decred/dcrdata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decred/dcrdata/statuses/{sha}","languages_url":"https://api.github.com/repos/decred/dcrdata/languages","stargazers_url":"https://api.github.com/repos/decred/dcrdata/stargazers","contributors_url":"https://api.github.com/repos/decred/dcrdata/contributors","subscribers_url":"https://api.github.com/repos/decred/dcrdata/subscribers","subscription_url":"https://api.github.com/repos/decred/dcrdata/subscription","commits_url":"https://api.github.com/repos/decred/dcrdata/commits{/sha}","git_commits_url":"https://api.github.com/repos/decred/dcrdata/git/commits{/sha}","comments_url":"https://api.github.com/repos/decred/dcrdata/comments{/number}","issue_comment_url":"https://api.github.com/repos/decred/dcrdata/issues/comments{/number}","contents_url":"https://api.github.com/repos/decred/dcrdata/contents/{+path}","compare_url":"https://api.github.com/repos/decred/dcrdata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decred/dcrdata/merges","archive_url":"https://api.github.com/repos/decred/dcrdata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decred/dcrdata/downloads","issues_url":"https://api.github.com/repos/decred/dcrdata/issues{/number}","pulls_url":"https://api.github.com/repos/decred/dcrdata/pulls{/number}","milestones_url":"https://api.github.com/repos/decred/dcrdata/milestones{/number}","notifications_url":"https://api.github.com/repos/decred/dcrdata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decred/dcrdata/labels{/name}","releases_url":"https://api.github.com/repos/decred/dcrdata/releases{/id}","deployments_url":"https://api.github.com/repos/decred/dcrdata/deployments","created_at":"2017-02-22T16:24:53Z","updated_at":"2018-09-14T10:35:20Z","pushed_at":"2018-09-14T18:34:42Z","git_url":"git://github.com/decred/dcrdata.git","ssh_url":"git@github.com:decred/dcrdata.git","clone_url":"https://github.com/decred/dcrdata.git","svn_url":"https://github.com/decred/dcrdata","homepage":"https://explorer.dcrdata.org/","size":8399,"stargazers_count":55,"watchers_count":55,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":74,"mirror_url":null,"archived":false,"open_issues_count":88,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":74,"open_issues":88,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/decred/dcrdata/pulls/676"},"html":{"href":"https://github.com/decred/dcrdata/pull/676"},"issue":{"href":"https://api.github.com/repos/decred/dcrdata/issues/676"},"comments":{"href":"https://api.github.com/repos/decred/dcrdata/issues/676/comments"},"review_comments":{"href":"https://api.github.com/repos/decred/dcrdata/pulls/676/comments"},"review_comment":{"href":"https://api.github.com/repos/decred/dcrdata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/decred/dcrdata/pulls/676/commits"},"statuses":{"href":"https://api.github.com/repos/decred/dcrdata/statuses/6c100816655cc5a0ed3cb3e520f9483d02910a9b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"chappjc"}}