{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/force/pulls/comments/191431033","pull_request_review_id":124000504,"id":191431033,"diff_hunk":"@@ -28,8 +30,11 @@ module.exports = class ArtworkBidView extends Backbone.View\n     @$el.append modal.$el\n     modal.insertModalContent pages.$el\n \n-  setupAuctionClock: (sale) ->\n-    @auctionClockView = new AuctionClockView\n-      model: sale\n-      el: @$('.artwork-auction-bid-module__clock')\n-    @auctionClockView.start()\n+  setupDesktopAuctionClock: (sale) ->\n+    if { start_at, end_at, live_start_at } = ARTWORK.auction","path":"src/mobile/apps/artwork/components/bid/view.coffee","position":33,"original_position":33,"commit_id":"175734a7e6239fd49bd09996884941c9e8c6b282","original_commit_id":"175734a7e6239fd49bd09996884941c9e8c6b282","user":{"login":"sweir27","id":2081340,"avatar_url":"https://avatars3.githubusercontent.com/u/2081340?v=4","gravatar_id":"","url":"https://api.github.com/users/sweir27","html_url":"https://github.com/sweir27","followers_url":"https://api.github.com/users/sweir27/followers","following_url":"https://api.github.com/users/sweir27/following{/other_user}","gists_url":"https://api.github.com/users/sweir27/gists{/gist_id}","starred_url":"https://api.github.com/users/sweir27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sweir27/subscriptions","organizations_url":"https://api.github.com/users/sweir27/orgs","repos_url":"https://api.github.com/users/sweir27/repos","events_url":"https://api.github.com/users/sweir27/events{/privacy}","received_events_url":"https://api.github.com/users/sweir27/received_events","type":"User","site_admin":false},"body":"Whoa haven't seen this syntax before! Cool that it works like this.","created_at":"2018-05-29T13:50:41Z","updated_at":"2018-05-29T13:59:49Z","html_url":"https://github.com/artsy/force/pull/2556#discussion_r191431033","pull_request_url":"https://api.github.com/repos/artsy/force/pulls/2556","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/artsy/force/pulls/comments/191431033"},"html":{"href":"https://github.com/artsy/force/pull/2556#discussion_r191431033"},"pull_request":{"href":"https://api.github.com/repos/artsy/force/pulls/2556"}}},"pull_request":{"url":"https://api.github.com/repos/artsy/force/pulls/2556","id":190369713,"html_url":"https://github.com/artsy/force/pull/2556","diff_url":"https://github.com/artsy/force/pull/2556.diff","patch_url":"https://github.com/artsy/force/pull/2556.patch","issue_url":"https://api.github.com/repos/artsy/force/issues/2556","number":2556,"state":"open","locked":false,"title":"Replaces mobile auction clock with desktop","user":{"login":"sepans","id":687513,"avatar_url":"https://avatars3.githubusercontent.com/u/687513?v=4","gravatar_id":"","url":"https://api.github.com/users/sepans","html_url":"https://github.com/sepans","followers_url":"https://api.github.com/users/sepans/followers","following_url":"https://api.github.com/users/sepans/following{/other_user}","gists_url":"https://api.github.com/users/sepans/gists{/gist_id}","starred_url":"https://api.github.com/users/sepans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sepans/subscriptions","organizations_url":"https://api.github.com/users/sepans/orgs","repos_url":"https://api.github.com/users/sepans/repos","events_url":"https://api.github.com/users/sepans/events{/privacy}","received_events_url":"https://api.github.com/users/sepans/received_events","type":"User","site_admin":false},"body":"An attempt to fix this intermittent issue with mobile auction page reload loop: https://artsyproduct.atlassian.net/browse/PURCHASE-152\r\n\r\nAlso documented here: https://trello.com/c/jDdbZkZ9/92-mobile-site-keeps-refereshing\r\n\r\n- [x] Replace mobile auction clock with desktop clock\r\n~Remove mobile auction clock~ The auction clock is being reference from a couple of other places (comments below) which needs a bit more time to clean up.\r\n\r\nThe cause of refresh hasn't been found out yet but if the cause is a race condition triggering the `location.reload()` [here](https://github.com/artsy/force/blob/316894dc4a2ae6aa4723c730fc9635d897f82884/src/mobile/components/auction_clock/view.coffee#L23), replacing that clock with the stable desktop version will fix the problem.\r\n\r\n (like `clockState` being `undefined` **before** the `onChange` event is bound. `clockState` is initially `undefined` but the `sale.updateState` function is being called **before** the `success` callback witch binds the `onChange` [here](https://github.com/artsy/force/blob/316894dc4a2ae6aa4723c730fc9635d897f82884/src/mobile/models/sale.coffee#L45))\r\n\r\n## UI changes:\r\n### Old clock:\r\n<img width=\"375\" alt=\"screen shot 2018-05-24 at 10 23 48 am\" src=\"https://user-images.githubusercontent.com/687513/40502192-3563102e-5f58-11e8-9f53-18606a8fafd3.png\">\r\n\r\n### New  clock:\r\n<img width=\"376\" alt=\"screen shot 2018-05-24 at 10 23 38 am\" src=\"https://user-images.githubusercontent.com/687513/40502206-44bb84f2-5f58-11e8-81c7-ec575b8d333c.png\">\r\n\r\nIt is possible to make the new clock look like the old one with CSS but hasn't done that in favor of making mobile look consistent with the desktop:\r\n\r\n<img width=\"1415\" alt=\"screen shot 2018-05-24 at 1 44 45 pm\" src=\"https://user-images.githubusercontent.com/687513/40502365-bcc4640a-5f58-11e8-9285-cf0cda72c4fe.png\">\r\n\r\nThis is a question for @briansw if we want to keep it this way or make it look the way it was. (got 👍 from @briansw)\r\n\r\n## What else?\r\n\r\nAnother potential cause could be [this](https://github.com/artsy/force/blob/45ccfe251f085e447a7d2c26af3fa129bf0eb038/src/mobile/components/layout/bootstrap.coffee)\r\n\r\n","created_at":"2018-05-24T17:48:07Z","updated_at":"2018-05-29T13:59:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4085798cdcf9ec2d815396b6789e2c6de7e0c6a8","assignee":{"login":"sepans","id":687513,"avatar_url":"https://avatars3.githubusercontent.com/u/687513?v=4","gravatar_id":"","url":"https://api.github.com/users/sepans","html_url":"https://github.com/sepans","followers_url":"https://api.github.com/users/sepans/followers","following_url":"https://api.github.com/users/sepans/following{/other_user}","gists_url":"https://api.github.com/users/sepans/gists{/gist_id}","starred_url":"https://api.github.com/users/sepans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sepans/subscriptions","organizations_url":"https://api.github.com/users/sepans/orgs","repos_url":"https://api.github.com/users/sepans/repos","events_url":"https://api.github.com/users/sepans/events{/privacy}","received_events_url":"https://api.github.com/users/sepans/received_events","type":"User","site_admin":false},"assignees":[{"login":"sepans","id":687513,"avatar_url":"https://avatars3.githubusercontent.com/u/687513?v=4","gravatar_id":"","url":"https://api.github.com/users/sepans","html_url":"https://github.com/sepans","followers_url":"https://api.github.com/users/sepans/followers","following_url":"https://api.github.com/users/sepans/following{/other_user}","gists_url":"https://api.github.com/users/sepans/gists{/gist_id}","starred_url":"https://api.github.com/users/sepans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sepans/subscriptions","organizations_url":"https://api.github.com/users/sepans/orgs","repos_url":"https://api.github.com/users/sepans/repos","events_url":"https://api.github.com/users/sepans/events{/privacy}","received_events_url":"https://api.github.com/users/sepans/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/artsy/force/pulls/2556/commits","review_comments_url":"https://api.github.com/repos/artsy/force/pulls/2556/comments","review_comment_url":"https://api.github.com/repos/artsy/force/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/force/issues/2556/comments","statuses_url":"https://api.github.com/repos/artsy/force/statuses/175734a7e6239fd49bd09996884941c9e8c6b282","head":{"label":"sepans:auction-mobile-clock","ref":"auction-mobile-clock","sha":"175734a7e6239fd49bd09996884941c9e8c6b282","user":{"login":"sepans","id":687513,"avatar_url":"https://avatars3.githubusercontent.com/u/687513?v=4","gravatar_id":"","url":"https://api.github.com/users/sepans","html_url":"https://github.com/sepans","followers_url":"https://api.github.com/users/sepans/followers","following_url":"https://api.github.com/users/sepans/following{/other_user}","gists_url":"https://api.github.com/users/sepans/gists{/gist_id}","starred_url":"https://api.github.com/users/sepans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sepans/subscriptions","organizations_url":"https://api.github.com/users/sepans/orgs","repos_url":"https://api.github.com/users/sepans/repos","events_url":"https://api.github.com/users/sepans/events{/privacy}","received_events_url":"https://api.github.com/users/sepans/received_events","type":"User","site_admin":false},"repo":{"id":114290443,"name":"force","full_name":"sepans/force","owner":{"login":"sepans","id":687513,"avatar_url":"https://avatars3.githubusercontent.com/u/687513?v=4","gravatar_id":"","url":"https://api.github.com/users/sepans","html_url":"https://github.com/sepans","followers_url":"https://api.github.com/users/sepans/followers","following_url":"https://api.github.com/users/sepans/following{/other_user}","gists_url":"https://api.github.com/users/sepans/gists{/gist_id}","starred_url":"https://api.github.com/users/sepans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sepans/subscriptions","organizations_url":"https://api.github.com/users/sepans/orgs","repos_url":"https://api.github.com/users/sepans/repos","events_url":"https://api.github.com/users/sepans/events{/privacy}","received_events_url":"https://api.github.com/users/sepans/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sepans/force","description":"The Artsy.net website:","fork":true,"url":"https://api.github.com/repos/sepans/force","forks_url":"https://api.github.com/repos/sepans/force/forks","keys_url":"https://api.github.com/repos/sepans/force/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sepans/force/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sepans/force/teams","hooks_url":"https://api.github.com/repos/sepans/force/hooks","issue_events_url":"https://api.github.com/repos/sepans/force/issues/events{/number}","events_url":"https://api.github.com/repos/sepans/force/events","assignees_url":"https://api.github.com/repos/sepans/force/assignees{/user}","branches_url":"https://api.github.com/repos/sepans/force/branches{/branch}","tags_url":"https://api.github.com/repos/sepans/force/tags","blobs_url":"https://api.github.com/repos/sepans/force/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sepans/force/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sepans/force/git/refs{/sha}","trees_url":"https://api.github.com/repos/sepans/force/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sepans/force/statuses/{sha}","languages_url":"https://api.github.com/repos/sepans/force/languages","stargazers_url":"https://api.github.com/repos/sepans/force/stargazers","contributors_url":"https://api.github.com/repos/sepans/force/contributors","subscribers_url":"https://api.github.com/repos/sepans/force/subscribers","subscription_url":"https://api.github.com/repos/sepans/force/subscription","commits_url":"https://api.github.com/repos/sepans/force/commits{/sha}","git_commits_url":"https://api.github.com/repos/sepans/force/git/commits{/sha}","comments_url":"https://api.github.com/repos/sepans/force/comments{/number}","issue_comment_url":"https://api.github.com/repos/sepans/force/issues/comments{/number}","contents_url":"https://api.github.com/repos/sepans/force/contents/{+path}","compare_url":"https://api.github.com/repos/sepans/force/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sepans/force/merges","archive_url":"https://api.github.com/repos/sepans/force/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sepans/force/downloads","issues_url":"https://api.github.com/repos/sepans/force/issues{/number}","pulls_url":"https://api.github.com/repos/sepans/force/pulls{/number}","milestones_url":"https://api.github.com/repos/sepans/force/milestones{/number}","notifications_url":"https://api.github.com/repos/sepans/force/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sepans/force/labels{/name}","releases_url":"https://api.github.com/repos/sepans/force/releases{/id}","deployments_url":"https://api.github.com/repos/sepans/force/deployments","created_at":"2017-12-14T19:51:36Z","updated_at":"2017-12-14T19:51:42Z","pushed_at":"2018-05-24T17:31:59Z","git_url":"git://github.com/sepans/force.git","ssh_url":"git@github.com:sepans/force.git","clone_url":"https://github.com/sepans/force.git","svn_url":"https://github.com/sepans/force","homepage":"https://www.artsy.net","size":128558,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"5bb46de7125abc3828d44ed653b2cc1e0093719c","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":22887404,"name":"force","full_name":"artsy/force","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/force","description":"The Artsy.net website:","fork":false,"url":"https://api.github.com/repos/artsy/force","forks_url":"https://api.github.com/repos/artsy/force/forks","keys_url":"https://api.github.com/repos/artsy/force/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/force/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/force/teams","hooks_url":"https://api.github.com/repos/artsy/force/hooks","issue_events_url":"https://api.github.com/repos/artsy/force/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/force/events","assignees_url":"https://api.github.com/repos/artsy/force/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/force/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/force/tags","blobs_url":"https://api.github.com/repos/artsy/force/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/force/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/force/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/force/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/force/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/force/languages","stargazers_url":"https://api.github.com/repos/artsy/force/stargazers","contributors_url":"https://api.github.com/repos/artsy/force/contributors","subscribers_url":"https://api.github.com/repos/artsy/force/subscribers","subscription_url":"https://api.github.com/repos/artsy/force/subscription","commits_url":"https://api.github.com/repos/artsy/force/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/force/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/force/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/force/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/force/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/force/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/force/merges","archive_url":"https://api.github.com/repos/artsy/force/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/force/downloads","issues_url":"https://api.github.com/repos/artsy/force/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/force/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/force/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/force/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/force/labels{/name}","releases_url":"https://api.github.com/repos/artsy/force/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/force/deployments","created_at":"2014-08-12T18:14:34Z","updated_at":"2018-05-29T13:25:30Z","pushed_at":"2018-05-29T05:47:46Z","git_url":"git://github.com/artsy/force.git","ssh_url":"git@github.com:artsy/force.git","clone_url":"https://github.com/artsy/force.git","svn_url":"https://github.com/artsy/force","homepage":"https://www.artsy.net","size":128489,"stargazers_count":229,"watchers_count":229,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":83,"open_issues":49,"watchers":229,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/force/pulls/2556"},"html":{"href":"https://github.com/artsy/force/pull/2556"},"issue":{"href":"https://api.github.com/repos/artsy/force/issues/2556"},"comments":{"href":"https://api.github.com/repos/artsy/force/issues/2556/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/force/pulls/2556/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/force/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/force/pulls/2556/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/force/statuses/175734a7e6239fd49bd09996884941c9e8c6b282"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sweir27"}}