{"action":"created","issue":{"url":"https://api.github.com/repos/unknownbrackets/maxcso/issues/22","repository_url":"https://api.github.com/repos/unknownbrackets/maxcso","labels_url":"https://api.github.com/repos/unknownbrackets/maxcso/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/unknownbrackets/maxcso/issues/22/comments","events_url":"https://api.github.com/repos/unknownbrackets/maxcso/issues/22/events","html_url":"https://github.com/unknownbrackets/maxcso/pull/22","id":383644373,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDY0Mzk3","number":22,"title":"Makefile: Allow setting CFLAGS and CXXFLAGS.","user":{"login":"orbea","id":4204285,"node_id":"MDQ6VXNlcjQyMDQyODU=","avatar_url":"https://avatars2.githubusercontent.com/u/4204285?v=4","gravatar_id":"","url":"https://api.github.com/users/orbea","html_url":"https://github.com/orbea","followers_url":"https://api.github.com/users/orbea/followers","following_url":"https://api.github.com/users/orbea/following{/other_user}","gists_url":"https://api.github.com/users/orbea/gists{/gist_id}","starred_url":"https://api.github.com/users/orbea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbea/subscriptions","organizations_url":"https://api.github.com/users/orbea/orgs","repos_url":"https://api.github.com/users/orbea/repos","events_url":"https://api.github.com/users/orbea/events{/privacy}","received_events_url":"https://api.github.com/users/orbea/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-11-22T19:49:37Z","updated_at":"2018-11-24T21:35:26Z","closed_at":"2018-11-24T21:17:25Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/unknownbrackets/maxcso/pulls/22","html_url":"https://github.com/unknownbrackets/maxcso/pull/22","diff_url":"https://github.com/unknownbrackets/maxcso/pull/22.diff","patch_url":"https://github.com/unknownbrackets/maxcso/pull/22.patch"},"body":"This allows the user to set `CFLAGS` and `CXXFLAGS` without clobbering or conflicting with the default `CFLAGS` and `CXXFLAGS`.\r\n\r\nFor example:\r\n```\r\nCFLAGS=-O3 make\r\n```\r\nWould result in both `-O3` and `-O2` being passed, I think the latter one would take precedence?\r\n\r\nOr\r\n```\r\nmake CFLAGS=-O2\r\n```\r\nThis would result in the default `CFLAGS` vanishing and only `-O2` would be passed.\r\n\r\nWith this change the user can easily override the optimizations without worrying about the default flags."},"comment":{"url":"https://api.github.com/repos/unknownbrackets/maxcso/issues/comments/441397244","html_url":"https://github.com/unknownbrackets/maxcso/pull/22#issuecomment-441397244","issue_url":"https://api.github.com/repos/unknownbrackets/maxcso/issues/22","id":441397244,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTM5NzI0NA==","user":{"login":"orbea","id":4204285,"node_id":"MDQ6VXNlcjQyMDQyODU=","avatar_url":"https://avatars2.githubusercontent.com/u/4204285?v=4","gravatar_id":"","url":"https://api.github.com/users/orbea","html_url":"https://github.com/orbea","followers_url":"https://api.github.com/users/orbea/followers","following_url":"https://api.github.com/users/orbea/following{/other_user}","gists_url":"https://api.github.com/users/orbea/gists{/gist_id}","starred_url":"https://api.github.com/users/orbea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbea/subscriptions","organizations_url":"https://api.github.com/users/orbea/orgs","repos_url":"https://api.github.com/users/orbea/repos","events_url":"https://api.github.com/users/orbea/events{/privacy}","received_events_url":"https://api.github.com/users/orbea/received_events","type":"User","site_admin":false},"created_at":"2018-11-24T21:35:26Z","updated_at":"2018-11-24T21:35:26Z","author_association":"CONTRIBUTOR","body":"No worries :)"}}
{"actor":{"display_login":"orbea"}}