{"action":"created","comment":{"url":"https://api.github.com/repos/jjaniec/42sh/pulls/comments/233171233","pull_request_review_id":174523253,"id":233171233,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzE3MTIzMw==","diff_hunk":"@@ -82,15 +132,10 @@ static void\tchild_process(void **cmd, t_exec *exe, \\\n \t\t\texit(EXIT_FAILURE);\n \t\t}\n \t}\n-\tif (!pipe_fds && (node->parent && node->parent->type == T_REDIR_OPT))\n-\t{\n-\t\thandle_redir_fd(STDIN_FILENO, backup_fds[0]);\n-\t\thandle_redir_fd(STDOUT_FILENO, backup_fds[1]);\n-\t\thandle_redir_fd(STDERR_FILENO, backup_fds[2]);\n-\t\t/*log_close(backup_fds[0]);\n-\t\tlog_close(backup_fds[1]);\n-\t\tlog_close(backup_fds[2]);*/\n-\t}\n+\tif (node && node->left && node->left->type == T_ENV_ASSIGN)\n+\t\tremove_tmp_env_assigns(env_assigns_environ, env_assign_vars);","path":"srcs/exec/exec_thread.c","position":119,"original_position":119,"commit_id":"2e1024911e3200f9912987dcaecf1908f6fca490","original_commit_id":"2e1024911e3200f9912987dcaecf1908f6fca490","user":{"login":"sonarcloud[bot]","id":39514782,"node_id":"MDM6Qm90Mzk1MTQ3ODI=","avatar_url":"https://avatars2.githubusercontent.com/in/12526?v=4","gravatar_id":"","url":"https://api.github.com/users/sonarcloud%5Bbot%5D","html_url":"https://github.com/apps/sonarcloud","followers_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/followers","following_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/repos","events_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"![Bug](https://sonarsource.github.io/sonar-github/bug.png 'Bug') Bug: 2nd function call argument is an uninitialized value ([c:S836](https://sonarcloud.io/organizations/jjaniec-github/rules#rule_key=c%3AS836))\n\n[See it in SonarCloud](https://sonarcloud.io/project/issues?id=jjaniec_42sh&pullRequest=49&issues=AWcOWwpJgA_rbE7wclVB&open=AWcOWwpJgA_rbE7wclVB)\n\n[ISSUE_KEY]: AWcOWwpJgA_rbE7wclVB","created_at":"2018-11-13T18:37:22Z","updated_at":"2018-11-13T18:37:22Z","html_url":"https://github.com/jjaniec/42sh/pull/49#discussion_r233171233","pull_request_url":"https://api.github.com/repos/jjaniec/42sh/pulls/49","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jjaniec/42sh/pulls/comments/233171233"},"html":{"href":"https://github.com/jjaniec/42sh/pull/49#discussion_r233171233"},"pull_request":{"href":"https://api.github.com/repos/jjaniec/42sh/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/jjaniec/42sh/pulls/49","id":229910586,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTEwNTg2","html_url":"https://github.com/jjaniec/42sh/pull/49","diff_url":"https://github.com/jjaniec/42sh/pull/49.diff","patch_url":"https://github.com/jjaniec/42sh/pull/49.patch","issue_url":"https://api.github.com/repos/jjaniec/42sh/issues/49","number":49,"state":"open","locked":false,"title":"Handle env assigns","user":{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false},"body":"- Gestion des T_ENV_ASSIGN\r\n- Petits fix dans les fonctions pour gerer l'env et dans le builtin env","created_at":"2018-11-10T20:09:02Z","updated_at":"2018-11-13T18:37:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c1d61cc4a4aeb8d63397130075c713488ccb99d","assignee":{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false},"assignees":[{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1031952932,"node_id":"MDU6TGFiZWwxMDMxOTUyOTMy","url":"https://api.github.com/repos/jjaniec/42sh/labels/Bug%20Fix","name":"Bug Fix","color":"c2e0c6","default":false},{"id":934078151,"node_id":"MDU6TGFiZWw5MzQwNzgxNTE=","url":"https://api.github.com/repos/jjaniec/42sh/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/jjaniec/42sh/pulls/49/commits","review_comments_url":"https://api.github.com/repos/jjaniec/42sh/pulls/49/comments","review_comment_url":"https://api.github.com/repos/jjaniec/42sh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jjaniec/42sh/issues/49/comments","statuses_url":"https://api.github.com/repos/jjaniec/42sh/statuses/2e1024911e3200f9912987dcaecf1908f6fca490","head":{"label":"jjaniec:handle_env_assigns","ref":"handle_env_assigns","sha":"2e1024911e3200f9912987dcaecf1908f6fca490","user":{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false},"repo":{"id":133548605,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM1NDg2MDU=","name":"42sh","full_name":"jjaniec/42sh","private":false,"owner":{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jjaniec/42sh","description":"Our own shell - wip","fork":false,"url":"https://api.github.com/repos/jjaniec/42sh","forks_url":"https://api.github.com/repos/jjaniec/42sh/forks","keys_url":"https://api.github.com/repos/jjaniec/42sh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjaniec/42sh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjaniec/42sh/teams","hooks_url":"https://api.github.com/repos/jjaniec/42sh/hooks","issue_events_url":"https://api.github.com/repos/jjaniec/42sh/issues/events{/number}","events_url":"https://api.github.com/repos/jjaniec/42sh/events","assignees_url":"https://api.github.com/repos/jjaniec/42sh/assignees{/user}","branches_url":"https://api.github.com/repos/jjaniec/42sh/branches{/branch}","tags_url":"https://api.github.com/repos/jjaniec/42sh/tags","blobs_url":"https://api.github.com/repos/jjaniec/42sh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjaniec/42sh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjaniec/42sh/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjaniec/42sh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjaniec/42sh/statuses/{sha}","languages_url":"https://api.github.com/repos/jjaniec/42sh/languages","stargazers_url":"https://api.github.com/repos/jjaniec/42sh/stargazers","contributors_url":"https://api.github.com/repos/jjaniec/42sh/contributors","subscribers_url":"https://api.github.com/repos/jjaniec/42sh/subscribers","subscription_url":"https://api.github.com/repos/jjaniec/42sh/subscription","commits_url":"https://api.github.com/repos/jjaniec/42sh/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjaniec/42sh/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjaniec/42sh/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjaniec/42sh/issues/comments{/number}","contents_url":"https://api.github.com/repos/jjaniec/42sh/contents/{+path}","compare_url":"https://api.github.com/repos/jjaniec/42sh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjaniec/42sh/merges","archive_url":"https://api.github.com/repos/jjaniec/42sh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjaniec/42sh/downloads","issues_url":"https://api.github.com/repos/jjaniec/42sh/issues{/number}","pulls_url":"https://api.github.com/repos/jjaniec/42sh/pulls{/number}","milestones_url":"https://api.github.com/repos/jjaniec/42sh/milestones{/number}","notifications_url":"https://api.github.com/repos/jjaniec/42sh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjaniec/42sh/labels{/name}","releases_url":"https://api.github.com/repos/jjaniec/42sh/releases{/id}","deployments_url":"https://api.github.com/repos/jjaniec/42sh/deployments","created_at":"2018-05-15T17:10:47Z","updated_at":"2018-11-13T12:19:16Z","pushed_at":"2018-11-13T18:02:48Z","git_url":"git://github.com/jjaniec/42sh.git","ssh_url":"git@github.com:jjaniec/42sh.git","clone_url":"https://github.com/jjaniec/42sh.git","svn_url":"https://github.com/jjaniec/42sh","homepage":"","size":3123,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":3,"default_branch":"develop"}},"base":{"label":"jjaniec:develop","ref":"develop","sha":"284f3987eab8410eb7210d057ee5efd1573edf13","user":{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false},"repo":{"id":133548605,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM1NDg2MDU=","name":"42sh","full_name":"jjaniec/42sh","private":false,"owner":{"login":"jjaniec","id":16088893,"node_id":"MDQ6VXNlcjE2MDg4ODkz","avatar_url":"https://avatars2.githubusercontent.com/u/16088893?v=4","gravatar_id":"","url":"https://api.github.com/users/jjaniec","html_url":"https://github.com/jjaniec","followers_url":"https://api.github.com/users/jjaniec/followers","following_url":"https://api.github.com/users/jjaniec/following{/other_user}","gists_url":"https://api.github.com/users/jjaniec/gists{/gist_id}","starred_url":"https://api.github.com/users/jjaniec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjaniec/subscriptions","organizations_url":"https://api.github.com/users/jjaniec/orgs","repos_url":"https://api.github.com/users/jjaniec/repos","events_url":"https://api.github.com/users/jjaniec/events{/privacy}","received_events_url":"https://api.github.com/users/jjaniec/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jjaniec/42sh","description":"Our own shell - wip","fork":false,"url":"https://api.github.com/repos/jjaniec/42sh","forks_url":"https://api.github.com/repos/jjaniec/42sh/forks","keys_url":"https://api.github.com/repos/jjaniec/42sh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjaniec/42sh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjaniec/42sh/teams","hooks_url":"https://api.github.com/repos/jjaniec/42sh/hooks","issue_events_url":"https://api.github.com/repos/jjaniec/42sh/issues/events{/number}","events_url":"https://api.github.com/repos/jjaniec/42sh/events","assignees_url":"https://api.github.com/repos/jjaniec/42sh/assignees{/user}","branches_url":"https://api.github.com/repos/jjaniec/42sh/branches{/branch}","tags_url":"https://api.github.com/repos/jjaniec/42sh/tags","blobs_url":"https://api.github.com/repos/jjaniec/42sh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjaniec/42sh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjaniec/42sh/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjaniec/42sh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjaniec/42sh/statuses/{sha}","languages_url":"https://api.github.com/repos/jjaniec/42sh/languages","stargazers_url":"https://api.github.com/repos/jjaniec/42sh/stargazers","contributors_url":"https://api.github.com/repos/jjaniec/42sh/contributors","subscribers_url":"https://api.github.com/repos/jjaniec/42sh/subscribers","subscription_url":"https://api.github.com/repos/jjaniec/42sh/subscription","commits_url":"https://api.github.com/repos/jjaniec/42sh/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjaniec/42sh/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjaniec/42sh/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjaniec/42sh/issues/comments{/number}","contents_url":"https://api.github.com/repos/jjaniec/42sh/contents/{+path}","compare_url":"https://api.github.com/repos/jjaniec/42sh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjaniec/42sh/merges","archive_url":"https://api.github.com/repos/jjaniec/42sh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjaniec/42sh/downloads","issues_url":"https://api.github.com/repos/jjaniec/42sh/issues{/number}","pulls_url":"https://api.github.com/repos/jjaniec/42sh/pulls{/number}","milestones_url":"https://api.github.com/repos/jjaniec/42sh/milestones{/number}","notifications_url":"https://api.github.com/repos/jjaniec/42sh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjaniec/42sh/labels{/name}","releases_url":"https://api.github.com/repos/jjaniec/42sh/releases{/id}","deployments_url":"https://api.github.com/repos/jjaniec/42sh/deployments","created_at":"2018-05-15T17:10:47Z","updated_at":"2018-11-13T12:19:16Z","pushed_at":"2018-11-13T18:02:48Z","git_url":"git://github.com/jjaniec/42sh.git","ssh_url":"git@github.com:jjaniec/42sh.git","clone_url":"https://github.com/jjaniec/42sh.git","svn_url":"https://github.com/jjaniec/42sh","homepage":"","size":3123,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/jjaniec/42sh/pulls/49"},"html":{"href":"https://github.com/jjaniec/42sh/pull/49"},"issue":{"href":"https://api.github.com/repos/jjaniec/42sh/issues/49"},"comments":{"href":"https://api.github.com/repos/jjaniec/42sh/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/jjaniec/42sh/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/jjaniec/42sh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jjaniec/42sh/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/jjaniec/42sh/statuses/2e1024911e3200f9912987dcaecf1908f6fca490"}},"author_association":"OWNER"}}
{"actor":{"display_login":"sonarcloud"}}