{"action":"created","comment":{"url":"https://api.github.com/repos/apache/carbondata/pulls/comments/242377558","pull_request_review_id":185871858,"id":242377558,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjM3NzU1OA==","diff_hunk":"@@ -2490,6 +2490,54 @@ class TestNonTransactionalCarbonTable extends QueryTest with BeforeAndAfterAll {\n     FileUtils.deleteDirectory(new File(writerPath))\n   }\n \n+  test(\"check varchar with trailing space\") {","path":"integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala","position":4,"original_position":4,"commit_id":"5b13c15275a7662f869a8f216e2d5930e1743d4a","original_commit_id":"45520c1c2a7c83506febdcf0bc0518306e4bf3b5","user":{"login":"xuchuanyin","id":10445758,"node_id":"MDQ6VXNlcjEwNDQ1NzU4","avatar_url":"https://avatars1.githubusercontent.com/u/10445758?v=4","gravatar_id":"","url":"https://api.github.com/users/xuchuanyin","html_url":"https://github.com/xuchuanyin","followers_url":"https://api.github.com/users/xuchuanyin/followers","following_url":"https://api.github.com/users/xuchuanyin/following{/other_user}","gists_url":"https://api.github.com/users/xuchuanyin/gists{/gist_id}","starred_url":"https://api.github.com/users/xuchuanyin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuchuanyin/subscriptions","organizations_url":"https://api.github.com/users/xuchuanyin/orgs","repos_url":"https://api.github.com/users/xuchuanyin/repos","events_url":"https://api.github.com/users/xuchuanyin/events{/privacy}","received_events_url":"https://api.github.com/users/xuchuanyin/received_events","type":"User","site_admin":false},"body":"besides, this is for varchar columns, why not update the code there?","created_at":"2018-12-18T01:17:51Z","updated_at":"2018-12-18T01:18:29Z","html_url":"https://github.com/apache/carbondata/pull/2988#discussion_r242377558","pull_request_url":"https://api.github.com/repos/apache/carbondata/pulls/2988","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/carbondata/pulls/comments/242377558"},"html":{"href":"https://github.com/apache/carbondata/pull/2988#discussion_r242377558"},"pull_request":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2988"}},"in_reply_to_id":242161063},"pull_request":{"url":"https://api.github.com/repos/apache/carbondata/pulls/2988","id":238660778,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NjYwNzc4","html_url":"https://github.com/apache/carbondata/pull/2988","diff_url":"https://github.com/apache/carbondata/pull/2988.diff","patch_url":"https://github.com/apache/carbondata/pull/2988.patch","issue_url":"https://api.github.com/repos/apache/carbondata/issues/2988","number":2988,"state":"open","locked":false,"title":"[CARBONDATA-3174] Fix trailing space issue with varchar column for SDK","user":{"login":"Shubh18s","id":16817700,"node_id":"MDQ6VXNlcjE2ODE3NzAw","avatar_url":"https://avatars0.githubusercontent.com/u/16817700?v=4","gravatar_id":"","url":"https://api.github.com/users/Shubh18s","html_url":"https://github.com/Shubh18s","followers_url":"https://api.github.com/users/Shubh18s/followers","following_url":"https://api.github.com/users/Shubh18s/following{/other_user}","gists_url":"https://api.github.com/users/Shubh18s/gists{/gist_id}","starred_url":"https://api.github.com/users/Shubh18s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shubh18s/subscriptions","organizations_url":"https://api.github.com/users/Shubh18s/orgs","repos_url":"https://api.github.com/users/Shubh18s/repos","events_url":"https://api.github.com/users/Shubh18s/events{/privacy}","received_events_url":"https://api.github.com/users/Shubh18s/received_events","type":"User","site_admin":false},"body":"What was the issue?\r\nAfter doing SDK Write, Select * was failing for 'long_string_columns' with trailing space.\r\n\r\nWhat has been changed?\r\nRemoved the trailing space in ColumnName. \r\n\r\nBe sure to do all of the following checklist to help us incorporate \r\nyour contribution quickly and easily:\r\n\r\n - [ ] Any interfaces changed?\r\n \r\n - [ ] Any backward compatibility impacted?\r\n \r\n - [ ] Document update required?\r\n\r\n - [x] Testing done\r\n            Added a test case.\r\n       \r\n - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. \r\n\r\n","created_at":"2018-12-14T09:37:12Z","updated_at":"2018-12-18T01:18:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc310935f62cbaeb22685575fd28bf0856b2483e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/carbondata/pulls/2988/commits","review_comments_url":"https://api.github.com/repos/apache/carbondata/pulls/2988/comments","review_comment_url":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/carbondata/issues/2988/comments","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/5b13c15275a7662f869a8f216e2d5930e1743d4a","head":{"label":"Shubh18s:master","ref":"master","sha":"5b13c15275a7662f869a8f216e2d5930e1743d4a","user":{"login":"Shubh18s","id":16817700,"node_id":"MDQ6VXNlcjE2ODE3NzAw","avatar_url":"https://avatars0.githubusercontent.com/u/16817700?v=4","gravatar_id":"","url":"https://api.github.com/users/Shubh18s","html_url":"https://github.com/Shubh18s","followers_url":"https://api.github.com/users/Shubh18s/followers","following_url":"https://api.github.com/users/Shubh18s/following{/other_user}","gists_url":"https://api.github.com/users/Shubh18s/gists{/gist_id}","starred_url":"https://api.github.com/users/Shubh18s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shubh18s/subscriptions","organizations_url":"https://api.github.com/users/Shubh18s/orgs","repos_url":"https://api.github.com/users/Shubh18s/repos","events_url":"https://api.github.com/users/Shubh18s/events{/privacy}","received_events_url":"https://api.github.com/users/Shubh18s/received_events","type":"User","site_admin":false},"repo":{"id":139886285,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk4ODYyODU=","name":"carbondata","full_name":"Shubh18s/carbondata","private":false,"owner":{"login":"Shubh18s","id":16817700,"node_id":"MDQ6VXNlcjE2ODE3NzAw","avatar_url":"https://avatars0.githubusercontent.com/u/16817700?v=4","gravatar_id":"","url":"https://api.github.com/users/Shubh18s","html_url":"https://github.com/Shubh18s","followers_url":"https://api.github.com/users/Shubh18s/followers","following_url":"https://api.github.com/users/Shubh18s/following{/other_user}","gists_url":"https://api.github.com/users/Shubh18s/gists{/gist_id}","starred_url":"https://api.github.com/users/Shubh18s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shubh18s/subscriptions","organizations_url":"https://api.github.com/users/Shubh18s/orgs","repos_url":"https://api.github.com/users/Shubh18s/repos","events_url":"https://api.github.com/users/Shubh18s/events{/privacy}","received_events_url":"https://api.github.com/users/Shubh18s/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Shubh18s/carbondata","description":"Mirror of Apache CarbonData","fork":true,"url":"https://api.github.com/repos/Shubh18s/carbondata","forks_url":"https://api.github.com/repos/Shubh18s/carbondata/forks","keys_url":"https://api.github.com/repos/Shubh18s/carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shubh18s/carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shubh18s/carbondata/teams","hooks_url":"https://api.github.com/repos/Shubh18s/carbondata/hooks","issue_events_url":"https://api.github.com/repos/Shubh18s/carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/Shubh18s/carbondata/events","assignees_url":"https://api.github.com/repos/Shubh18s/carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/Shubh18s/carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/Shubh18s/carbondata/tags","blobs_url":"https://api.github.com/repos/Shubh18s/carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shubh18s/carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shubh18s/carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shubh18s/carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shubh18s/carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/Shubh18s/carbondata/languages","stargazers_url":"https://api.github.com/repos/Shubh18s/carbondata/stargazers","contributors_url":"https://api.github.com/repos/Shubh18s/carbondata/contributors","subscribers_url":"https://api.github.com/repos/Shubh18s/carbondata/subscribers","subscription_url":"https://api.github.com/repos/Shubh18s/carbondata/subscription","commits_url":"https://api.github.com/repos/Shubh18s/carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shubh18s/carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shubh18s/carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shubh18s/carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shubh18s/carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/Shubh18s/carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shubh18s/carbondata/merges","archive_url":"https://api.github.com/repos/Shubh18s/carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shubh18s/carbondata/downloads","issues_url":"https://api.github.com/repos/Shubh18s/carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/Shubh18s/carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/Shubh18s/carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/Shubh18s/carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shubh18s/carbondata/labels{/name}","releases_url":"https://api.github.com/repos/Shubh18s/carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/Shubh18s/carbondata/deployments","created_at":"2018-07-05T18:24:33Z","updated_at":"2018-12-17T14:37:20Z","pushed_at":"2018-12-17T14:37:16Z","git_url":"git://github.com/Shubh18s/carbondata.git","ssh_url":"git@github.com:Shubh18s/carbondata.git","clone_url":"https://github.com/Shubh18s/carbondata.git","svn_url":"https://github.com/Shubh18s/carbondata","homepage":"","size":65490,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8fd449c89a1892d39c110b05e5b1bb1f107799e4","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117818,"node_id":"MDEwOlJlcG9zaXRvcnk2MjExNzgxOA==","name":"carbondata","full_name":"apache/carbondata","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/carbondata","description":"Mirror of Apache CarbonData","fork":false,"url":"https://api.github.com/repos/apache/carbondata","forks_url":"https://api.github.com/repos/apache/carbondata/forks","keys_url":"https://api.github.com/repos/apache/carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/carbondata/teams","hooks_url":"https://api.github.com/repos/apache/carbondata/hooks","issue_events_url":"https://api.github.com/repos/apache/carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/apache/carbondata/events","assignees_url":"https://api.github.com/repos/apache/carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/apache/carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/apache/carbondata/tags","blobs_url":"https://api.github.com/repos/apache/carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/carbondata/languages","stargazers_url":"https://api.github.com/repos/apache/carbondata/stargazers","contributors_url":"https://api.github.com/repos/apache/carbondata/contributors","subscribers_url":"https://api.github.com/repos/apache/carbondata/subscribers","subscription_url":"https://api.github.com/repos/apache/carbondata/subscription","commits_url":"https://api.github.com/repos/apache/carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/apache/carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/carbondata/merges","archive_url":"https://api.github.com/repos/apache/carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/carbondata/downloads","issues_url":"https://api.github.com/repos/apache/carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/apache/carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/carbondata/labels{/name}","releases_url":"https://api.github.com/repos/apache/carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/apache/carbondata/deployments","created_at":"2016-06-28T07:00:06Z","updated_at":"2018-12-17T14:50:44Z","pushed_at":"2018-12-17T17:56:37Z","git_url":"git://github.com/apache/carbondata.git","ssh_url":"git@github.com:apache/carbondata.git","clone_url":"https://github.com/apache/carbondata.git","svn_url":"https://github.com/apache/carbondata","homepage":"","size":65897,"stargazers_count":820,"watchers_count":820,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":494,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":494,"open_issues":106,"watchers":820,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2988"},"html":{"href":"https://github.com/apache/carbondata/pull/2988"},"issue":{"href":"https://api.github.com/repos/apache/carbondata/issues/2988"},"comments":{"href":"https://api.github.com/repos/apache/carbondata/issues/2988/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2988/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2988/commits"},"statuses":{"href":"https://api.github.com/repos/apache/carbondata/statuses/5b13c15275a7662f869a8f216e2d5930e1743d4a"}},"author_association":"NONE"}}
{"actor":{"display_login":"xuchuanyin"}}