{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/218576764","pull_request_review_id":156546916,"id":218576764,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODU3Njc2NA==","diff_hunk":"@@ -5,12 +5,80 @@\n using System.Collections.Generic;\n using System.Diagnostics;\n using System.Globalization;\n+using System.Runtime.CompilerServices;\n using Xunit;\n \n namespace System.Tests\n {\n     public partial class DoubleTests : RemoteExecutorTestBase\n     {\n+        // NOTE: Consider duplicating any tests added here in SingleTests.cs\n+\n+        private static ulong DoubleToUInt64Bits(double value)","path":"src/System.Runtime/tests/System/DoubleTests.cs","position":13,"original_position":13,"commit_id":"3277a433c5defbb89f37d7ef2c56be419c1edcc6","original_commit_id":"3277a433c5defbb89f37d7ef2c56be419c1edcc6","user":{"login":"eerhardt","id":8291187,"node_id":"MDQ6VXNlcjgyOTExODc=","avatar_url":"https://avatars3.githubusercontent.com/u/8291187?v=4","gravatar_id":"","url":"https://api.github.com/users/eerhardt","html_url":"https://github.com/eerhardt","followers_url":"https://api.github.com/users/eerhardt/followers","following_url":"https://api.github.com/users/eerhardt/following{/other_user}","gists_url":"https://api.github.com/users/eerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/eerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eerhardt/subscriptions","organizations_url":"https://api.github.com/users/eerhardt/orgs","repos_url":"https://api.github.com/users/eerhardt/repos","events_url":"https://api.github.com/users/eerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/eerhardt/received_events","type":"User","site_admin":false},"body":"Why not use [https://docs.microsoft.com/en-us/dotnet/api/system.bitconverter.doubletoint64bits?view=netframework-4.7.2](https://docs.microsoft.com/en-us/dotnet/api/system.bitconverter.doubletoint64bits?view=netframework-4.7.2) instead?","created_at":"2018-09-18T20:09:40Z","updated_at":"2018-09-18T20:09:41Z","html_url":"https://github.com/dotnet/corefx/pull/32339#discussion_r218576764","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/32339","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/218576764"},"html":{"href":"https://github.com/dotnet/corefx/pull/32339#discussion_r218576764"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/32339"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/32339","id":216401435,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NDAxNDM1","html_url":"https://github.com/dotnet/corefx/pull/32339","diff_url":"https://github.com/dotnet/corefx/pull/32339.diff","patch_url":"https://github.com/dotnet/corefx/pull/32339.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/32339","number":32339,"state":"open","locked":false,"title":"Updating the System.Double and System.Single tests","user":{"login":"tannergooding","id":10487869,"node_id":"MDQ6VXNlcjEwNDg3ODY5","avatar_url":"https://avatars3.githubusercontent.com/u/10487869?v=4","gravatar_id":"","url":"https://api.github.com/users/tannergooding","html_url":"https://github.com/tannergooding","followers_url":"https://api.github.com/users/tannergooding/followers","following_url":"https://api.github.com/users/tannergooding/following{/other_user}","gists_url":"https://api.github.com/users/tannergooding/gists{/gist_id}","starred_url":"https://api.github.com/users/tannergooding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannergooding/subscriptions","organizations_url":"https://api.github.com/users/tannergooding/orgs","repos_url":"https://api.github.com/users/tannergooding/repos","events_url":"https://api.github.com/users/tannergooding/events{/privacy}","received_events_url":"https://api.github.com/users/tannergooding/received_events","type":"User","site_admin":false},"body":"This adds some new perf test coverage which validates some additional interesting string inputs -- will help in assessing the quality of certain changes being made to the parsing and formatting code.\r\n\r\nThis also cleans up the regular tests to make it easier to compare and ensure that we have sufficient test coverage.","created_at":"2018-09-18T18:27:10Z","updated_at":"2018-09-18T20:09:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74c12b0c12699684ce52d71398055fe8d43a693f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/32339/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/32339/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/32339/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/3277a433c5defbb89f37d7ef2c56be419c1edcc6","head":{"label":"tannergooding:string-tests","ref":"string-tests","sha":"3277a433c5defbb89f37d7ef2c56be419c1edcc6","user":{"login":"tannergooding","id":10487869,"node_id":"MDQ6VXNlcjEwNDg3ODY5","avatar_url":"https://avatars3.githubusercontent.com/u/10487869?v=4","gravatar_id":"","url":"https://api.github.com/users/tannergooding","html_url":"https://github.com/tannergooding","followers_url":"https://api.github.com/users/tannergooding/followers","following_url":"https://api.github.com/users/tannergooding/following{/other_user}","gists_url":"https://api.github.com/users/tannergooding/gists{/gist_id}","starred_url":"https://api.github.com/users/tannergooding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannergooding/subscriptions","organizations_url":"https://api.github.com/users/tannergooding/orgs","repos_url":"https://api.github.com/users/tannergooding/repos","events_url":"https://api.github.com/users/tannergooding/events{/privacy}","received_events_url":"https://api.github.com/users/tannergooding/received_events","type":"User","site_admin":false},"repo":{"id":32347823,"node_id":"MDEwOlJlcG9zaXRvcnkzMjM0NzgyMw==","name":"corefx","full_name":"tannergooding/corefx","private":false,"owner":{"login":"tannergooding","id":10487869,"node_id":"MDQ6VXNlcjEwNDg3ODY5","avatar_url":"https://avatars3.githubusercontent.com/u/10487869?v=4","gravatar_id":"","url":"https://api.github.com/users/tannergooding","html_url":"https://github.com/tannergooding","followers_url":"https://api.github.com/users/tannergooding/followers","following_url":"https://api.github.com/users/tannergooding/following{/other_user}","gists_url":"https://api.github.com/users/tannergooding/gists{/gist_id}","starred_url":"https://api.github.com/users/tannergooding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannergooding/subscriptions","organizations_url":"https://api.github.com/users/tannergooding/orgs","repos_url":"https://api.github.com/users/tannergooding/repos","events_url":"https://api.github.com/users/tannergooding/events{/privacy}","received_events_url":"https://api.github.com/users/tannergooding/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tannergooding/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/tannergooding/corefx","forks_url":"https://api.github.com/repos/tannergooding/corefx/forks","keys_url":"https://api.github.com/repos/tannergooding/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tannergooding/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tannergooding/corefx/teams","hooks_url":"https://api.github.com/repos/tannergooding/corefx/hooks","issue_events_url":"https://api.github.com/repos/tannergooding/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/tannergooding/corefx/events","assignees_url":"https://api.github.com/repos/tannergooding/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/tannergooding/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/tannergooding/corefx/tags","blobs_url":"https://api.github.com/repos/tannergooding/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tannergooding/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tannergooding/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/tannergooding/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tannergooding/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/tannergooding/corefx/languages","stargazers_url":"https://api.github.com/repos/tannergooding/corefx/stargazers","contributors_url":"https://api.github.com/repos/tannergooding/corefx/contributors","subscribers_url":"https://api.github.com/repos/tannergooding/corefx/subscribers","subscription_url":"https://api.github.com/repos/tannergooding/corefx/subscription","commits_url":"https://api.github.com/repos/tannergooding/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/tannergooding/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/tannergooding/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/tannergooding/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/tannergooding/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/tannergooding/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tannergooding/corefx/merges","archive_url":"https://api.github.com/repos/tannergooding/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tannergooding/corefx/downloads","issues_url":"https://api.github.com/repos/tannergooding/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/tannergooding/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/tannergooding/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/tannergooding/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tannergooding/corefx/labels{/name}","releases_url":"https://api.github.com/repos/tannergooding/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/tannergooding/corefx/deployments","created_at":"2015-03-16T19:28:16Z","updated_at":"2018-08-31T21:34:42Z","pushed_at":"2018-09-18T18:24:51Z","git_url":"git://github.com/tannergooding/corefx.git","ssh_url":"git@github.com:tannergooding/corefx.git","clone_url":"https://github.com/tannergooding/corefx.git","svn_url":"https://github.com/tannergooding/corefx","homepage":"","size":179857,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"989984b699211cc3755bb849d8eaf5be4386691c","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI5NTM0NQ==","name":"corefx","full_name":"dotnet/corefx","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-09-18T19:50:35Z","pushed_at":"2018-09-18T18:57:21Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":187745,"stargazers_count":14800,"watchers_count":14800,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4303,"mirror_url":null,"archived":false,"open_issues_count":2498,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4303,"open_issues":2498,"watchers":14800,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/32339"},"html":{"href":"https://github.com/dotnet/corefx/pull/32339"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/32339"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/32339/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/32339/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/32339/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/3277a433c5defbb89f37d7ef2c56be419c1edcc6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"eerhardt"}}