{"action":"created","issue":{"url":"https://api.github.com/repos/u-root/u-root/issues/791","repository_url":"https://api.github.com/repos/u-root/u-root","labels_url":"https://api.github.com/repos/u-root/u-root/issues/791/labels{/name}","comments_url":"https://api.github.com/repos/u-root/u-root/issues/791/comments","events_url":"https://api.github.com/repos/u-root/u-root/issues/791/events","html_url":"https://github.com/u-root/u-root/pull/791","id":339005738,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5Nzk4MzQ4","number":791,"title":"rm: update to use github.com/ogier/pflag","user":{"login":"rminnich","id":74928,"node_id":"MDQ6VXNlcjc0OTI4","avatar_url":"https://avatars0.githubusercontent.com/u/74928?v=4","gravatar_id":"","url":"https://api.github.com/users/rminnich","html_url":"https://github.com/rminnich","followers_url":"https://api.github.com/users/rminnich/followers","following_url":"https://api.github.com/users/rminnich/following{/other_user}","gists_url":"https://api.github.com/users/rminnich/gists{/gist_id}","starred_url":"https://api.github.com/users/rminnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rminnich/subscriptions","organizations_url":"https://api.github.com/users/rminnich/orgs","repos_url":"https://api.github.com/users/rminnich/repos","events_url":"https://api.github.com/users/rminnich/events{/privacy}","received_events_url":"https://api.github.com/users/rminnich/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-06T16:51:48Z","updated_at":"2018-07-07T02:09:41Z","closed_at":"2018-07-07T02:09:21Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/u-root/u-root/pulls/791","html_url":"https://github.com/u-root/u-root/pull/791","diff_url":"https://github.com/u-root/u-root/pull/791.diff","patch_url":"https://github.com/u-root/u-root/pull/791.patch"},"body":"We now get reasonable flag handling for rm without\nthe hack of having a separate \"-rf\" flag.\n\nWe also get long flag names.\n\nIf this seems reasonable we should probably use it for our\nother tools. The Go flag package is not compatible with\npeople's expectations.\n\nHere is the change in sizes with this package in rm, for static and dynamic\n(larger is dynamic)\n\nwithout pflag\n-rwxr-xr-x 1 rminnich rminnich 37311832 Jul  6 09:43 /tmp/initramfs.linux_amd64.cpio\n-rwxr-xr-x 1 rminnich rminnich 12219892 Jul  6 09:43 /tmp/initramfs.linux_amd64.cpio\n\nwith pflag\n-rwxr-xr-x 1 rminnich rminnich 37373948 Jul  6 09:45 /tmp/initramfs.linux_amd64.cpio\n-rwxr-xr-x 1 rminnich rminnich 12355060 Jul  6 09:46 /tmp/initramfs.linux_amd64.cpio\n\nSo about 60k for dynamic, and 135K for static. This is a bit of growth but I think\nthe improvement is worth it.\n\nGiven the last commit to ogier/pflag was over 2 years ago we may want to import\nthis (with history) as pkg/x/pflag, but that's for another commit.\n\nSigned-off-by: Ronald G. Minnich <rminnich@gmail.com>"},"comment":{"url":"https://api.github.com/repos/u-root/u-root/issues/comments/403181561","html_url":"https://github.com/u-root/u-root/pull/791#issuecomment-403181561","issue_url":"https://api.github.com/repos/u-root/u-root/issues/791","id":403181561,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzE4MTU2MQ==","user":{"login":"rminnich","id":74928,"node_id":"MDQ6VXNlcjc0OTI4","avatar_url":"https://avatars0.githubusercontent.com/u/74928?v=4","gravatar_id":"","url":"https://api.github.com/users/rminnich","html_url":"https://github.com/rminnich","followers_url":"https://api.github.com/users/rminnich/followers","following_url":"https://api.github.com/users/rminnich/following{/other_user}","gists_url":"https://api.github.com/users/rminnich/gists{/gist_id}","starred_url":"https://api.github.com/users/rminnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rminnich/subscriptions","organizations_url":"https://api.github.com/users/rminnich/orgs","repos_url":"https://api.github.com/users/rminnich/repos","events_url":"https://api.github.com/users/rminnich/events{/privacy}","received_events_url":"https://api.github.com/users/rminnich/received_events","type":"User","site_admin":false},"created_at":"2018-07-07T02:09:41Z","updated_at":"2018-07-07T02:09:41Z","author_association":"MEMBER","body":"Yeah, I think moving it all to pflag would be worth it, that's coming ..."}}
{"actor":{"display_login":"rminnich"}}