{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/pulls/comments/180195731","pull_request_review_id":110575688,"id":180195731,"diff_hunk":"@@ -36,17 +39,29 @@ public void setCloudSdkBuilderFactory(CloudSdkBuilderFactory cloudSdkBuilderFact\n     this.cloudSdkBuilderFactory = cloudSdkBuilderFactory;\n   }\n \n+  public void setStageDirectory(File stageDirectory) {\n+    this.stageDirectory = stageDirectory;\n+  }\n+\n   /** Task Entrypoint : Deploys the app and all of its config files. */\n   @TaskAction\n   public void deployAllAction() throws AppEngineException {\n-    if (!deployConfig.getDeployables().isEmpty()) {\n-      getLogger().warn(\"appengineDeployAll: Ignoring configured deployables.\");\n-      deployConfig.getDeployables().clear();\n+    List<File> deployables = deployConfig.getDeployables();","path":"src/main/java/com/google/cloud/tools/gradle/appengine/core/DeployAllTask.java","position":31,"original_position":31,"commit_id":"f87a8fc61ae9638292177b6bd55f0a5d96f69808","original_commit_id":"87c0afa42aea0addfdd064d98fb1c73c7103cb1d","user":{"login":"coollog","id":4852522,"avatar_url":"https://avatars3.githubusercontent.com/u/4852522?v=4","gravatar_id":"","url":"https://api.github.com/users/coollog","html_url":"https://github.com/coollog","followers_url":"https://api.github.com/users/coollog/followers","following_url":"https://api.github.com/users/coollog/following{/other_user}","gists_url":"https://api.github.com/users/coollog/gists{/gist_id}","starred_url":"https://api.github.com/users/coollog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coollog/subscriptions","organizations_url":"https://api.github.com/users/coollog/orgs","repos_url":"https://api.github.com/users/coollog/repos","events_url":"https://api.github.com/users/coollog/events{/privacy}","received_events_url":"https://api.github.com/users/coollog/received_events","type":"User","site_admin":false},"body":"Ah okay. There's the [`ArgumentCaptor`](https://static.javadoc.io/org.mockito/mockito-core/2.6.9/org/mockito/ArgumentCaptor.html) thing you could use to capture the argument passed into a mocked method and assert things on that. Otherwise, I'd say probably just change L69 to use `deployables` as well just to keep things consistent.","created_at":"2018-04-09T18:56:46Z","updated_at":"2018-04-09T18:56:47Z","html_url":"https://github.com/GoogleCloudPlatform/app-gradle-plugin/pull/244#discussion_r180195731","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/pulls/244","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/pulls/comments/180195731"},"html":{"href":"https://github.com/GoogleCloudPlatform/app-gradle-plugin/pull/244#discussion_r180195731"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/pulls/244"}},"in_reply_to_id":180181711},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/pulls/244","id":180376417,"html_url":"https://github.com/GoogleCloudPlatform/app-gradle-plugin/pull/244","diff_url":"https://github.com/GoogleCloudPlatform/app-gradle-plugin/pull/244.diff","patch_url":"https://github.com/GoogleCloudPlatform/app-gradle-plugin/pull/244.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/issues/244","number":244,"state":"open","locked":false,"title":"Fix appengineDeployAll for flexible projects","user":{"login":"TadCordle","id":521881,"avatar_url":"https://avatars1.githubusercontent.com/u/521881?v=4","gravatar_id":"","url":"https://api.github.com/users/TadCordle","html_url":"https://github.com/TadCordle","followers_url":"https://api.github.com/users/TadCordle/followers","following_url":"https://api.github.com/users/TadCordle/following{/other_user}","gists_url":"https://api.github.com/users/TadCordle/gists{/gist_id}","starred_url":"https://api.github.com/users/TadCordle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TadCordle/subscriptions","organizations_url":"https://api.github.com/users/TadCordle/orgs","repos_url":"https://api.github.com/users/TadCordle/repos","events_url":"https://api.github.com/users/TadCordle/events{/privacy}","received_events_url":"https://api.github.com/users/TadCordle/received_events","type":"User","site_admin":false},"body":"Fixes #240 ","created_at":"2018-04-09T17:31:37Z","updated_at":"2018-04-09T18:56:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ec421b621cb3cc02d38b4bcfb1a9ac6fbf07a50","assignee":null,"assignees":[],"requested_reviewers":[{"login":"loosebazooka","id":1304826,"avatar_url":"https://avatars2.githubusercontent.com/u/1304826?v=4","gravatar_id":"","url":"https://api.github.com/users/loosebazooka","html_url":"https://github.com/loosebazooka","followers_url":"https://api.github.com/users/loosebazooka/followers","following_url":"https://api.github.com/users/loosebazooka/following{/other_user}","gists_url":"https://api.github.com/users/loosebazooka/gists{/gist_id}","starred_url":"https://api.github.com/users/loosebazooka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loosebazooka/subscriptions","organizations_url":"https://api.github.com/users/loosebazooka/orgs","repos_url":"https://api.github.com/users/loosebazooka/repos","events_url":"https://api.github.com/users/loosebazooka/events{/privacy}","received_events_url":"https://api.github.com/users/loosebazooka/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/pulls/244/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/pulls/244/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/issues/244/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/statuses/f87a8fc61ae9638292177b6bd55f0a5d96f69808","head":{"label":"GoogleCloudPlatform:deploy_all_flex","ref":"deploy_all_flex","sha":"f87a8fc61ae9638292177b6bd55f0a5d96f69808","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":54140467,"name":"app-gradle-plugin","full_name":"GoogleCloudPlatform/app-gradle-plugin","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/app-gradle-plugin","description":"Gradle plugin to build and deploy Google App Engine applications.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/deployments","created_at":"2016-03-17T18:04:54Z","updated_at":"2018-04-05T19:32:18Z","pushed_at":"2018-04-09T18:37:24Z","git_url":"git://github.com/GoogleCloudPlatform/app-gradle-plugin.git","ssh_url":"git@github.com:GoogleCloudPlatform/app-gradle-plugin.git","clone_url":"https://github.com/GoogleCloudPlatform/app-gradle-plugin.git","svn_url":"https://github.com/GoogleCloudPlatform/app-gradle-plugin","homepage":"https://cloud.google.com/appengine/docs/standard/java/tools/gradle-reference","size":471,"stargazers_count":63,"watchers_count":63,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":14,"open_issues":26,"watchers":63,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"c822d877036a130a30f03052e1aa41b2436948b0","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":54140467,"name":"app-gradle-plugin","full_name":"GoogleCloudPlatform/app-gradle-plugin","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/app-gradle-plugin","description":"Gradle plugin to build and deploy Google App Engine applications.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/deployments","created_at":"2016-03-17T18:04:54Z","updated_at":"2018-04-05T19:32:18Z","pushed_at":"2018-04-09T18:37:24Z","git_url":"git://github.com/GoogleCloudPlatform/app-gradle-plugin.git","ssh_url":"git@github.com:GoogleCloudPlatform/app-gradle-plugin.git","clone_url":"https://github.com/GoogleCloudPlatform/app-gradle-plugin.git","svn_url":"https://github.com/GoogleCloudPlatform/app-gradle-plugin","homepage":"https://cloud.google.com/appengine/docs/standard/java/tools/gradle-reference","size":471,"stargazers_count":63,"watchers_count":63,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":14,"open_issues":26,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/pulls/244"},"html":{"href":"https://github.com/GoogleCloudPlatform/app-gradle-plugin/pull/244"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/issues/244"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/app-gradle-plugin/statuses/f87a8fc61ae9638292177b6bd55f0a5d96f69808"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"coollog"}}