{"action":"created","comment":{"url":"https://api.github.com/repos/boundlessgeo/sdk/pulls/comments/174696067","pull_request_review_id":104096810,"id":174696067,"diff_hunk":"@@ -60,11 +60,17 @@ class MapConfigService {\n       return source;\n     }\n     var sourceObj = new ol.source[config.type](props);\n-    var proxyTiles = function(opt_proxy, config) {\n-      return opt_proxy && (config.type === 'TileWMS' ||\n-        (typeof config['use_proxy'] !== \"undefined\" && config['use_proxy'] === true));\n-    };\n-    if (proxyTiles(opt_proxy, config)) {\n+    \n+    // Always proxy if config's use_proxy = True\n+    // otherwise use original conditional\n+    if (opt_proxy && typeof config['use_proxy'] !== \"undefined\" && config['use_proxy'] === true) {\n+      sourceObj.setTileLoadFunction((function() {","path":"src/services/MapConfigService.js","position":13,"original_position":13,"commit_id":"c99f299a5c94fd1eeae9f57f189d3cdae5aafe46","original_commit_id":"c99f299a5c94fd1eeae9f57f189d3cdae5aafe46","user":{"login":"bartvde","id":319678,"avatar_url":"https://avatars3.githubusercontent.com/u/319678?v=4","gravatar_id":"","url":"https://api.github.com/users/bartvde","html_url":"https://github.com/bartvde","followers_url":"https://api.github.com/users/bartvde/followers","following_url":"https://api.github.com/users/bartvde/following{/other_user}","gists_url":"https://api.github.com/users/bartvde/gists{/gist_id}","starred_url":"https://api.github.com/users/bartvde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartvde/subscriptions","organizations_url":"https://api.github.com/users/bartvde/orgs","repos_url":"https://api.github.com/users/bartvde/repos","events_url":"https://api.github.com/users/bartvde/events{/privacy}","received_events_url":"https://api.github.com/users/bartvde/received_events","type":"User","site_admin":false},"body":"instead of copying this function, can you put it into a shared function that can be used by both code blocks instead?","created_at":"2018-03-15T07:34:24Z","updated_at":"2018-03-15T07:34:38Z","html_url":"https://github.com/boundlessgeo/sdk/pull/852#discussion_r174696067","pull_request_url":"https://api.github.com/repos/boundlessgeo/sdk/pulls/852","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/boundlessgeo/sdk/pulls/comments/174696067"},"html":{"href":"https://github.com/boundlessgeo/sdk/pull/852#discussion_r174696067"},"pull_request":{"href":"https://api.github.com/repos/boundlessgeo/sdk/pulls/852"}}},"pull_request":{"url":"https://api.github.com/repos/boundlessgeo/sdk/pulls/852","id":175143398,"html_url":"https://github.com/boundlessgeo/sdk/pull/852","diff_url":"https://github.com/boundlessgeo/sdk/pull/852.diff","patch_url":"https://github.com/boundlessgeo/sdk/pull/852.patch","issue_url":"https://api.github.com/repos/boundlessgeo/sdk/issues/852","number":852,"state":"open","locked":false,"title":"Psbex 119","user":{"login":"travislbrundage","id":8084860,"avatar_url":"https://avatars2.githubusercontent.com/u/8084860?v=4","gravatar_id":"","url":"https://api.github.com/users/travislbrundage","html_url":"https://github.com/travislbrundage","followers_url":"https://api.github.com/users/travislbrundage/followers","following_url":"https://api.github.com/users/travislbrundage/following{/other_user}","gists_url":"https://api.github.com/users/travislbrundage/gists{/gist_id}","starred_url":"https://api.github.com/users/travislbrundage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travislbrundage/subscriptions","organizations_url":"https://api.github.com/users/travislbrundage/orgs","repos_url":"https://api.github.com/users/travislbrundage/repos","events_url":"https://api.github.com/users/travislbrundage/events{/privacy}","received_events_url":"https://api.github.com/users/travislbrundage/received_events","type":"User","site_admin":false},"body":"Fixes wrong logic for proxying remote services in GeoNode client.","created_at":"2018-03-15T04:01:32Z","updated_at":"2018-03-15T07:34:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f908a329158d5577a286b65a5cee3c069472bd2b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/boundlessgeo/sdk/pulls/852/commits","review_comments_url":"https://api.github.com/repos/boundlessgeo/sdk/pulls/852/comments","review_comment_url":"https://api.github.com/repos/boundlessgeo/sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/boundlessgeo/sdk/issues/852/comments","statuses_url":"https://api.github.com/repos/boundlessgeo/sdk/statuses/c99f299a5c94fd1eeae9f57f189d3cdae5aafe46","head":{"label":"travislbrundage:PSBEX-119","ref":"PSBEX-119","sha":"c99f299a5c94fd1eeae9f57f189d3cdae5aafe46","user":{"login":"travislbrundage","id":8084860,"avatar_url":"https://avatars2.githubusercontent.com/u/8084860?v=4","gravatar_id":"","url":"https://api.github.com/users/travislbrundage","html_url":"https://github.com/travislbrundage","followers_url":"https://api.github.com/users/travislbrundage/followers","following_url":"https://api.github.com/users/travislbrundage/following{/other_user}","gists_url":"https://api.github.com/users/travislbrundage/gists{/gist_id}","starred_url":"https://api.github.com/users/travislbrundage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travislbrundage/subscriptions","organizations_url":"https://api.github.com/users/travislbrundage/orgs","repos_url":"https://api.github.com/users/travislbrundage/repos","events_url":"https://api.github.com/users/travislbrundage/events{/privacy}","received_events_url":"https://api.github.com/users/travislbrundage/received_events","type":"User","site_admin":false},"repo":{"id":100676190,"name":"sdk","full_name":"travislbrundage/sdk","owner":{"login":"travislbrundage","id":8084860,"avatar_url":"https://avatars2.githubusercontent.com/u/8084860?v=4","gravatar_id":"","url":"https://api.github.com/users/travislbrundage","html_url":"https://github.com/travislbrundage","followers_url":"https://api.github.com/users/travislbrundage/followers","following_url":"https://api.github.com/users/travislbrundage/following{/other_user}","gists_url":"https://api.github.com/users/travislbrundage/gists{/gist_id}","starred_url":"https://api.github.com/users/travislbrundage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travislbrundage/subscriptions","organizations_url":"https://api.github.com/users/travislbrundage/orgs","repos_url":"https://api.github.com/users/travislbrundage/repos","events_url":"https://api.github.com/users/travislbrundage/events{/privacy}","received_events_url":"https://api.github.com/users/travislbrundage/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/travislbrundage/sdk","description":"Javascript SDK based on React, Redux and OpenLayers","fork":true,"url":"https://api.github.com/repos/travislbrundage/sdk","forks_url":"https://api.github.com/repos/travislbrundage/sdk/forks","keys_url":"https://api.github.com/repos/travislbrundage/sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/travislbrundage/sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/travislbrundage/sdk/teams","hooks_url":"https://api.github.com/repos/travislbrundage/sdk/hooks","issue_events_url":"https://api.github.com/repos/travislbrundage/sdk/issues/events{/number}","events_url":"https://api.github.com/repos/travislbrundage/sdk/events","assignees_url":"https://api.github.com/repos/travislbrundage/sdk/assignees{/user}","branches_url":"https://api.github.com/repos/travislbrundage/sdk/branches{/branch}","tags_url":"https://api.github.com/repos/travislbrundage/sdk/tags","blobs_url":"https://api.github.com/repos/travislbrundage/sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/travislbrundage/sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/travislbrundage/sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/travislbrundage/sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/travislbrundage/sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/travislbrundage/sdk/languages","stargazers_url":"https://api.github.com/repos/travislbrundage/sdk/stargazers","contributors_url":"https://api.github.com/repos/travislbrundage/sdk/contributors","subscribers_url":"https://api.github.com/repos/travislbrundage/sdk/subscribers","subscription_url":"https://api.github.com/repos/travislbrundage/sdk/subscription","commits_url":"https://api.github.com/repos/travislbrundage/sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/travislbrundage/sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/travislbrundage/sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/travislbrundage/sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/travislbrundage/sdk/contents/{+path}","compare_url":"https://api.github.com/repos/travislbrundage/sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/travislbrundage/sdk/merges","archive_url":"https://api.github.com/repos/travislbrundage/sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/travislbrundage/sdk/downloads","issues_url":"https://api.github.com/repos/travislbrundage/sdk/issues{/number}","pulls_url":"https://api.github.com/repos/travislbrundage/sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/travislbrundage/sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/travislbrundage/sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/travislbrundage/sdk/labels{/name}","releases_url":"https://api.github.com/repos/travislbrundage/sdk/releases{/id}","deployments_url":"https://api.github.com/repos/travislbrundage/sdk/deployments","created_at":"2017-08-18T05:31:08Z","updated_at":"2017-08-18T05:31:10Z","pushed_at":"2018-03-15T04:00:54Z","git_url":"git://github.com/travislbrundage/sdk.git","ssh_url":"git@github.com:travislbrundage/sdk.git","clone_url":"https://github.com/travislbrundage/sdk.git","svn_url":"https://github.com/travislbrundage/sdk","homepage":"","size":70326,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"boundlessgeo:1.x","ref":"1.x","sha":"71ca6500f86bbb9107d892caa2da5c006b730734","user":{"login":"boundlessgeo","id":306022,"avatar_url":"https://avatars0.githubusercontent.com/u/306022?v=4","gravatar_id":"","url":"https://api.github.com/users/boundlessgeo","html_url":"https://github.com/boundlessgeo","followers_url":"https://api.github.com/users/boundlessgeo/followers","following_url":"https://api.github.com/users/boundlessgeo/following{/other_user}","gists_url":"https://api.github.com/users/boundlessgeo/gists{/gist_id}","starred_url":"https://api.github.com/users/boundlessgeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boundlessgeo/subscriptions","organizations_url":"https://api.github.com/users/boundlessgeo/orgs","repos_url":"https://api.github.com/users/boundlessgeo/repos","events_url":"https://api.github.com/users/boundlessgeo/events{/privacy}","received_events_url":"https://api.github.com/users/boundlessgeo/received_events","type":"Organization","site_admin":false},"repo":{"id":36792837,"name":"sdk","full_name":"boundlessgeo/sdk","owner":{"login":"boundlessgeo","id":306022,"avatar_url":"https://avatars0.githubusercontent.com/u/306022?v=4","gravatar_id":"","url":"https://api.github.com/users/boundlessgeo","html_url":"https://github.com/boundlessgeo","followers_url":"https://api.github.com/users/boundlessgeo/followers","following_url":"https://api.github.com/users/boundlessgeo/following{/other_user}","gists_url":"https://api.github.com/users/boundlessgeo/gists{/gist_id}","starred_url":"https://api.github.com/users/boundlessgeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boundlessgeo/subscriptions","organizations_url":"https://api.github.com/users/boundlessgeo/orgs","repos_url":"https://api.github.com/users/boundlessgeo/repos","events_url":"https://api.github.com/users/boundlessgeo/events{/privacy}","received_events_url":"https://api.github.com/users/boundlessgeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boundlessgeo/sdk","description":"Javascript SDK based on React, Redux and OpenLayers","fork":false,"url":"https://api.github.com/repos/boundlessgeo/sdk","forks_url":"https://api.github.com/repos/boundlessgeo/sdk/forks","keys_url":"https://api.github.com/repos/boundlessgeo/sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boundlessgeo/sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boundlessgeo/sdk/teams","hooks_url":"https://api.github.com/repos/boundlessgeo/sdk/hooks","issue_events_url":"https://api.github.com/repos/boundlessgeo/sdk/issues/events{/number}","events_url":"https://api.github.com/repos/boundlessgeo/sdk/events","assignees_url":"https://api.github.com/repos/boundlessgeo/sdk/assignees{/user}","branches_url":"https://api.github.com/repos/boundlessgeo/sdk/branches{/branch}","tags_url":"https://api.github.com/repos/boundlessgeo/sdk/tags","blobs_url":"https://api.github.com/repos/boundlessgeo/sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boundlessgeo/sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boundlessgeo/sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/boundlessgeo/sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boundlessgeo/sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/boundlessgeo/sdk/languages","stargazers_url":"https://api.github.com/repos/boundlessgeo/sdk/stargazers","contributors_url":"https://api.github.com/repos/boundlessgeo/sdk/contributors","subscribers_url":"https://api.github.com/repos/boundlessgeo/sdk/subscribers","subscription_url":"https://api.github.com/repos/boundlessgeo/sdk/subscription","commits_url":"https://api.github.com/repos/boundlessgeo/sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/boundlessgeo/sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/boundlessgeo/sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/boundlessgeo/sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/boundlessgeo/sdk/contents/{+path}","compare_url":"https://api.github.com/repos/boundlessgeo/sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boundlessgeo/sdk/merges","archive_url":"https://api.github.com/repos/boundlessgeo/sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boundlessgeo/sdk/downloads","issues_url":"https://api.github.com/repos/boundlessgeo/sdk/issues{/number}","pulls_url":"https://api.github.com/repos/boundlessgeo/sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/boundlessgeo/sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/boundlessgeo/sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boundlessgeo/sdk/labels{/name}","releases_url":"https://api.github.com/repos/boundlessgeo/sdk/releases{/id}","deployments_url":"https://api.github.com/repos/boundlessgeo/sdk/deployments","created_at":"2015-06-03T09:13:14Z","updated_at":"2018-03-14T17:19:13Z","pushed_at":"2018-03-15T04:01:33Z","git_url":"git://github.com/boundlessgeo/sdk.git","ssh_url":"git@github.com:boundlessgeo/sdk.git","clone_url":"https://github.com/boundlessgeo/sdk.git","svn_url":"https://github.com/boundlessgeo/sdk","homepage":"","size":70881,"stargazers_count":45,"watchers_count":45,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":34,"open_issues":11,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/boundlessgeo/sdk/pulls/852"},"html":{"href":"https://github.com/boundlessgeo/sdk/pull/852"},"issue":{"href":"https://api.github.com/repos/boundlessgeo/sdk/issues/852"},"comments":{"href":"https://api.github.com/repos/boundlessgeo/sdk/issues/852/comments"},"review_comments":{"href":"https://api.github.com/repos/boundlessgeo/sdk/pulls/852/comments"},"review_comment":{"href":"https://api.github.com/repos/boundlessgeo/sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/boundlessgeo/sdk/pulls/852/commits"},"statuses":{"href":"https://api.github.com/repos/boundlessgeo/sdk/statuses/c99f299a5c94fd1eeae9f57f189d3cdae5aafe46"}},"author_association":"NONE"}}
{"actor":{"display_login":"bartvde"}}