{"action":"created","issue":{"url":"https://api.github.com/repos/radareorg/radeco-lib/issues/170","repository_url":"https://api.github.com/repos/radareorg/radeco-lib","labels_url":"https://api.github.com/repos/radareorg/radeco-lib/issues/170/labels{/name}","comments_url":"https://api.github.com/repos/radareorg/radeco-lib/issues/170/comments","events_url":"https://api.github.com/repos/radareorg/radeco-lib/issues/170/events","html_url":"https://github.com/radareorg/radeco-lib/pull/170","id":334780236,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NjYyNTIz","number":170,"title":"Recover local variables","user":{"login":"kriw","id":13299299,"node_id":"MDQ6VXNlcjEzMjk5Mjk5","avatar_url":"https://avatars3.githubusercontent.com/u/13299299?v=4","gravatar_id":"","url":"https://api.github.com/users/kriw","html_url":"https://github.com/kriw","followers_url":"https://api.github.com/users/kriw/followers","following_url":"https://api.github.com/users/kriw/following{/other_user}","gists_url":"https://api.github.com/users/kriw/gists{/gist_id}","starred_url":"https://api.github.com/users/kriw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kriw/subscriptions","organizations_url":"https://api.github.com/users/kriw/orgs","repos_url":"https://api.github.com/users/kriw/repos","events_url":"https://api.github.com/users/kriw/events{/privacy}","received_events_url":"https://api.github.com/users/kriw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-06-22T07:50:39Z","updated_at":"2018-06-30T03:28:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/radareorg/radeco-lib/pulls/170","html_url":"https://github.com/radareorg/radeco-lib/pull/170","diff_url":"https://github.com/radareorg/radeco-lib/pull/170.diff","patch_url":"https://github.com/radareorg/radeco-lib/pull/170.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/radareorg/radeco-lib/issues/comments/401514180","html_url":"https://github.com/radareorg/radeco-lib/pull/170#issuecomment-401514180","issue_url":"https://api.github.com/repos/radareorg/radeco-lib/issues/170","id":401514180,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTUxNDE4MA==","user":{"login":"kriw","id":13299299,"node_id":"MDQ6VXNlcjEzMjk5Mjk5","avatar_url":"https://avatars3.githubusercontent.com/u/13299299?v=4","gravatar_id":"","url":"https://api.github.com/users/kriw","html_url":"https://github.com/kriw","followers_url":"https://api.github.com/users/kriw/followers","following_url":"https://api.github.com/users/kriw/following{/other_user}","gists_url":"https://api.github.com/users/kriw/gists{/gist_id}","starred_url":"https://api.github.com/users/kriw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kriw/subscriptions","organizations_url":"https://api.github.com/users/kriw/orgs","repos_url":"https://api.github.com/users/kriw/repos","events_url":"https://api.github.com/users/kriw/events{/privacy}","received_events_url":"https://api.github.com/users/kriw/received_events","type":"User","site_admin":false},"created_at":"2018-06-30T03:28:27Z","updated_at":"2018-06-30T03:28:27Z","author_association":"CONTRIBUTOR","body":"This is ready to be merged.\r\n\r\nCurrently, `inst_combine` modify SSA node(e.g., `rbp - 0x10` to `rsp - 0x8`), so it fails to recover local variables correctly. The information of locals are holded by `RadecoFunction::binding_map: HashMap<NodeIndex, VarBinding>`, so if analyses modify SSA nodes, we have to fix `binding_map` for recover locals correctly. This problem is related to the issue #172, because the problems might be occurred by every analysis which modify SSA."}}
{"actor":{"display_login":"kriw"}}