{"action":"created","comment":{"url":"https://api.github.com/repos/inspec/inspec/pulls/comments/244378067","pull_request_review_id":188343563,"id":244378067,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDM3ODA2Nw==","diff_hunk":"@@ -0,0 +1,12 @@\n+# Functional Testing Area for Plugins\n+\n+## What are functional tests?\n+\n+Functional tests are tests that verify that your plugin works _as would be seen by a user_. Functional tests generally do not have inside knowledge about the inner workings of the plugin.  However a functional test is very interested in changes that you plugin make to the outside world: exit codes, command output, changes to files on the filesystem, etc.\n+\n+To be picked up by the Rake tasks as tests, each test file should end in `_test.rb`.\n+\n+## Unit vs Functional Tests\n+\n+A practical difference between unit tests and functional tests is that unit tests all run within one process, while functional tests might exercise a CLI plugin by shelling out to an inspec command in a subprocess, and examining the results.","path":"lib/plugins/inspec-init/templates/plugins/inspec-plugin-template/test/functional/README.md","position":11,"original_position":11,"commit_id":"a03e86086fe2b2aac158496229041d1b73d42917","original_commit_id":"a03e86086fe2b2aac158496229041d1b73d42917","user":{"login":"clintoncwolfe","id":156460,"node_id":"MDQ6VXNlcjE1NjQ2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/156460?v=4","gravatar_id":"","url":"https://api.github.com/users/clintoncwolfe","html_url":"https://github.com/clintoncwolfe","followers_url":"https://api.github.com/users/clintoncwolfe/followers","following_url":"https://api.github.com/users/clintoncwolfe/following{/other_user}","gists_url":"https://api.github.com/users/clintoncwolfe/gists{/gist_id}","starred_url":"https://api.github.com/users/clintoncwolfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clintoncwolfe/subscriptions","organizations_url":"https://api.github.com/users/clintoncwolfe/orgs","repos_url":"https://api.github.com/users/clintoncwolfe/repos","events_url":"https://api.github.com/users/clintoncwolfe/events{/privacy}","received_events_url":"https://api.github.com/users/clintoncwolfe/received_events","type":"User","site_admin":false},"body":"When referring to the `inspec` executable, the correct spelling is all lowercase.  There is no literal `InSpec` command.\r\n\r\nIf you are going to enforce capitalization standards, I suggest we meet to discuss them.","created_at":"2018-12-28T18:17:17Z","updated_at":"2018-12-28T18:17:17Z","html_url":"https://github.com/inspec/inspec/pull/3629#discussion_r244378067","pull_request_url":"https://api.github.com/repos/inspec/inspec/pulls/3629","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/inspec/inspec/pulls/comments/244378067"},"html":{"href":"https://github.com/inspec/inspec/pull/3629#discussion_r244378067"},"pull_request":{"href":"https://api.github.com/repos/inspec/inspec/pulls/3629"}},"in_reply_to_id":244049894},"pull_request":{"url":"https://api.github.com/repos/inspec/inspec/pulls/3629","id":233445488,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNDQ1NDg4","html_url":"https://github.com/inspec/inspec/pull/3629","diff_url":"https://github.com/inspec/inspec/pull/3629.diff","patch_url":"https://github.com/inspec/inspec/pull/3629.patch","issue_url":"https://api.github.com/repos/inspec/inspec/issues/3629","number":3629,"state":"open","locked":false,"title":"inspec-init plugin: generate inspec plugins","user":{"login":"clintoncwolfe","id":156460,"node_id":"MDQ6VXNlcjE1NjQ2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/156460?v=4","gravatar_id":"","url":"https://api.github.com/users/clintoncwolfe","html_url":"https://github.com/clintoncwolfe","followers_url":"https://api.github.com/users/clintoncwolfe/followers","following_url":"https://api.github.com/users/clintoncwolfe/following{/other_user}","gists_url":"https://api.github.com/users/clintoncwolfe/gists{/gist_id}","starred_url":"https://api.github.com/users/clintoncwolfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clintoncwolfe/subscriptions","organizations_url":"https://api.github.com/users/clintoncwolfe/orgs","repos_url":"https://api.github.com/users/clintoncwolfe/repos","events_url":"https://api.github.com/users/clintoncwolfe/events{/privacy}","received_events_url":"https://api.github.com/users/clintoncwolfe/received_events","type":"User","site_admin":false},"body":"This PR introduces a new subcommand to `inspec init`: `plugin`.  \r\n\r\n`inspec init plugin` features a broad suite of CLI options that are used to parameterize the generated plugin. Additionally, this PR relies on the UI functionality introduced in #3618 to provide a sleek interactive experience, in which the parameters are entered interactively.\r\n\r\nThe generated plugin may be generated at three levels of detail:\r\n\r\n * 'full' - typical for an external project; includes things like a Rakefile, Gemspec, etc.\r\n * 'core' - typical for an InSpec core plugin; includes tests, but omits gemspec, etc.\r\n * 'test-fixture' - typical for a test-fixture plugin - omits all topmatter and all tests.\r\n\r\nThis PR extends the code generator in several ways:\r\n\r\n* Don't assume we're generating a profile\r\n* Allow files to be renamed during the templating process\r\n* Allow files to be omitted during the templating process\r\n\r\nModest functional tests are included.\r\n\r\n\r\n**Note**: in order to use UI functionality, this PR is based on #3618. Once that is merged, the apparent size of this PR will shrink somewhat.","created_at":"2018-11-26T05:52:28Z","updated_at":"2018-12-28T18:17:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01dfe15786c4fe12490439734ec37fa8bcf73e90","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":832497821,"node_id":"MDU6TGFiZWw4MzI0OTc4MjE=","url":"https://api.github.com/repos/inspec/inspec/labels/Aspect:%20UX","name":"Aspect: UX","color":"0bd2ed","default":false},{"id":916301349,"node_id":"MDU6TGFiZWw5MTYzMDEzNDk=","url":"https://api.github.com/repos/inspec/inspec/labels/CLI:%20init","name":"CLI: init","color":"fdffaa","default":false},{"id":988987331,"node_id":"MDU6TGFiZWw5ODg5ODczMzE=","url":"https://api.github.com/repos/inspec/inspec/labels/Component:%20Plugins","name":"Component: Plugins","color":"5de263","default":false},{"id":598262295,"node_id":"MDU6TGFiZWw1OTgyNjIyOTU=","url":"https://api.github.com/repos/inspec/inspec/labels/Type:%20New%20Feature","name":"Type: New Feature","color":"207de5","default":false},{"id":689354010,"node_id":"MDU6TGFiZWw2ODkzNTQwMTA=","url":"https://api.github.com/repos/inspec/inspec/labels/Version:%20Bump%20Minor","name":"Version: Bump Minor","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/inspec/inspec/pulls/3629/commits","review_comments_url":"https://api.github.com/repos/inspec/inspec/pulls/3629/comments","review_comment_url":"https://api.github.com/repos/inspec/inspec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inspec/inspec/issues/3629/comments","statuses_url":"https://api.github.com/repos/inspec/inspec/statuses/a03e86086fe2b2aac158496229041d1b73d42917","head":{"label":"inspec:cw/init-plugin","ref":"cw/init-plugin","sha":"a03e86086fe2b2aac158496229041d1b73d42917","user":{"login":"inspec","id":39202509,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjAyNTA5","avatar_url":"https://avatars3.githubusercontent.com/u/39202509?v=4","gravatar_id":"","url":"https://api.github.com/users/inspec","html_url":"https://github.com/inspec","followers_url":"https://api.github.com/users/inspec/followers","following_url":"https://api.github.com/users/inspec/following{/other_user}","gists_url":"https://api.github.com/users/inspec/gists{/gist_id}","starred_url":"https://api.github.com/users/inspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspec/subscriptions","organizations_url":"https://api.github.com/users/inspec/orgs","repos_url":"https://api.github.com/users/inspec/repos","events_url":"https://api.github.com/users/inspec/events{/privacy}","received_events_url":"https://api.github.com/users/inspec/received_events","type":"Organization","site_admin":false},"repo":{"id":41571541,"node_id":"MDEwOlJlcG9zaXRvcnk0MTU3MTU0MQ==","name":"inspec","full_name":"inspec/inspec","private":false,"owner":{"login":"inspec","id":39202509,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjAyNTA5","avatar_url":"https://avatars3.githubusercontent.com/u/39202509?v=4","gravatar_id":"","url":"https://api.github.com/users/inspec","html_url":"https://github.com/inspec","followers_url":"https://api.github.com/users/inspec/followers","following_url":"https://api.github.com/users/inspec/following{/other_user}","gists_url":"https://api.github.com/users/inspec/gists{/gist_id}","starred_url":"https://api.github.com/users/inspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspec/subscriptions","organizations_url":"https://api.github.com/users/inspec/orgs","repos_url":"https://api.github.com/users/inspec/repos","events_url":"https://api.github.com/users/inspec/events{/privacy}","received_events_url":"https://api.github.com/users/inspec/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/inspec/inspec","description":"InSpec: Auditing and Testing Framework","fork":false,"url":"https://api.github.com/repos/inspec/inspec","forks_url":"https://api.github.com/repos/inspec/inspec/forks","keys_url":"https://api.github.com/repos/inspec/inspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inspec/inspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inspec/inspec/teams","hooks_url":"https://api.github.com/repos/inspec/inspec/hooks","issue_events_url":"https://api.github.com/repos/inspec/inspec/issues/events{/number}","events_url":"https://api.github.com/repos/inspec/inspec/events","assignees_url":"https://api.github.com/repos/inspec/inspec/assignees{/user}","branches_url":"https://api.github.com/repos/inspec/inspec/branches{/branch}","tags_url":"https://api.github.com/repos/inspec/inspec/tags","blobs_url":"https://api.github.com/repos/inspec/inspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inspec/inspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inspec/inspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/inspec/inspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inspec/inspec/statuses/{sha}","languages_url":"https://api.github.com/repos/inspec/inspec/languages","stargazers_url":"https://api.github.com/repos/inspec/inspec/stargazers","contributors_url":"https://api.github.com/repos/inspec/inspec/contributors","subscribers_url":"https://api.github.com/repos/inspec/inspec/subscribers","subscription_url":"https://api.github.com/repos/inspec/inspec/subscription","commits_url":"https://api.github.com/repos/inspec/inspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/inspec/inspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/inspec/inspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/inspec/inspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/inspec/inspec/contents/{+path}","compare_url":"https://api.github.com/repos/inspec/inspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inspec/inspec/merges","archive_url":"https://api.github.com/repos/inspec/inspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inspec/inspec/downloads","issues_url":"https://api.github.com/repos/inspec/inspec/issues{/number}","pulls_url":"https://api.github.com/repos/inspec/inspec/pulls{/number}","milestones_url":"https://api.github.com/repos/inspec/inspec/milestones{/number}","notifications_url":"https://api.github.com/repos/inspec/inspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inspec/inspec/labels{/name}","releases_url":"https://api.github.com/repos/inspec/inspec/releases{/id}","deployments_url":"https://api.github.com/repos/inspec/inspec/deployments","created_at":"2015-08-28T22:16:01Z","updated_at":"2018-12-28T17:05:39Z","pushed_at":"2018-12-28T17:11:35Z","git_url":"git://github.com/inspec/inspec.git","ssh_url":"git@github.com:inspec/inspec.git","clone_url":"https://github.com/inspec/inspec.git","svn_url":"https://github.com/inspec/inspec","homepage":"http://inspec.io","size":15041,"stargazers_count":1551,"watchers_count":1551,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":444,"mirror_url":null,"archived":false,"open_issues_count":591,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":444,"open_issues":591,"watchers":1551,"default_branch":"master"}},"base":{"label":"inspec:master","ref":"master","sha":"d79b6c18d61789a70b95ace8907190b89dc5baef","user":{"login":"inspec","id":39202509,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjAyNTA5","avatar_url":"https://avatars3.githubusercontent.com/u/39202509?v=4","gravatar_id":"","url":"https://api.github.com/users/inspec","html_url":"https://github.com/inspec","followers_url":"https://api.github.com/users/inspec/followers","following_url":"https://api.github.com/users/inspec/following{/other_user}","gists_url":"https://api.github.com/users/inspec/gists{/gist_id}","starred_url":"https://api.github.com/users/inspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspec/subscriptions","organizations_url":"https://api.github.com/users/inspec/orgs","repos_url":"https://api.github.com/users/inspec/repos","events_url":"https://api.github.com/users/inspec/events{/privacy}","received_events_url":"https://api.github.com/users/inspec/received_events","type":"Organization","site_admin":false},"repo":{"id":41571541,"node_id":"MDEwOlJlcG9zaXRvcnk0MTU3MTU0MQ==","name":"inspec","full_name":"inspec/inspec","private":false,"owner":{"login":"inspec","id":39202509,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjAyNTA5","avatar_url":"https://avatars3.githubusercontent.com/u/39202509?v=4","gravatar_id":"","url":"https://api.github.com/users/inspec","html_url":"https://github.com/inspec","followers_url":"https://api.github.com/users/inspec/followers","following_url":"https://api.github.com/users/inspec/following{/other_user}","gists_url":"https://api.github.com/users/inspec/gists{/gist_id}","starred_url":"https://api.github.com/users/inspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspec/subscriptions","organizations_url":"https://api.github.com/users/inspec/orgs","repos_url":"https://api.github.com/users/inspec/repos","events_url":"https://api.github.com/users/inspec/events{/privacy}","received_events_url":"https://api.github.com/users/inspec/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/inspec/inspec","description":"InSpec: Auditing and Testing Framework","fork":false,"url":"https://api.github.com/repos/inspec/inspec","forks_url":"https://api.github.com/repos/inspec/inspec/forks","keys_url":"https://api.github.com/repos/inspec/inspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inspec/inspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inspec/inspec/teams","hooks_url":"https://api.github.com/repos/inspec/inspec/hooks","issue_events_url":"https://api.github.com/repos/inspec/inspec/issues/events{/number}","events_url":"https://api.github.com/repos/inspec/inspec/events","assignees_url":"https://api.github.com/repos/inspec/inspec/assignees{/user}","branches_url":"https://api.github.com/repos/inspec/inspec/branches{/branch}","tags_url":"https://api.github.com/repos/inspec/inspec/tags","blobs_url":"https://api.github.com/repos/inspec/inspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inspec/inspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inspec/inspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/inspec/inspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inspec/inspec/statuses/{sha}","languages_url":"https://api.github.com/repos/inspec/inspec/languages","stargazers_url":"https://api.github.com/repos/inspec/inspec/stargazers","contributors_url":"https://api.github.com/repos/inspec/inspec/contributors","subscribers_url":"https://api.github.com/repos/inspec/inspec/subscribers","subscription_url":"https://api.github.com/repos/inspec/inspec/subscription","commits_url":"https://api.github.com/repos/inspec/inspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/inspec/inspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/inspec/inspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/inspec/inspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/inspec/inspec/contents/{+path}","compare_url":"https://api.github.com/repos/inspec/inspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inspec/inspec/merges","archive_url":"https://api.github.com/repos/inspec/inspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inspec/inspec/downloads","issues_url":"https://api.github.com/repos/inspec/inspec/issues{/number}","pulls_url":"https://api.github.com/repos/inspec/inspec/pulls{/number}","milestones_url":"https://api.github.com/repos/inspec/inspec/milestones{/number}","notifications_url":"https://api.github.com/repos/inspec/inspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inspec/inspec/labels{/name}","releases_url":"https://api.github.com/repos/inspec/inspec/releases{/id}","deployments_url":"https://api.github.com/repos/inspec/inspec/deployments","created_at":"2015-08-28T22:16:01Z","updated_at":"2018-12-28T17:05:39Z","pushed_at":"2018-12-28T17:11:35Z","git_url":"git://github.com/inspec/inspec.git","ssh_url":"git@github.com:inspec/inspec.git","clone_url":"https://github.com/inspec/inspec.git","svn_url":"https://github.com/inspec/inspec","homepage":"http://inspec.io","size":15041,"stargazers_count":1551,"watchers_count":1551,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":444,"mirror_url":null,"archived":false,"open_issues_count":591,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":444,"open_issues":591,"watchers":1551,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inspec/inspec/pulls/3629"},"html":{"href":"https://github.com/inspec/inspec/pull/3629"},"issue":{"href":"https://api.github.com/repos/inspec/inspec/issues/3629"},"comments":{"href":"https://api.github.com/repos/inspec/inspec/issues/3629/comments"},"review_comments":{"href":"https://api.github.com/repos/inspec/inspec/pulls/3629/comments"},"review_comment":{"href":"https://api.github.com/repos/inspec/inspec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inspec/inspec/pulls/3629/commits"},"statuses":{"href":"https://api.github.com/repos/inspec/inspec/statuses/a03e86086fe2b2aac158496229041d1b73d42917"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"clintoncwolfe"}}