{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/177627074","pull_request_review_id":107531359,"id":177627074,"diff_hunk":"@@ -0,0 +1,1552 @@\n+Security\n+========\n+\n+.. contents::\n+    :local:\n+\n+`7.1 Security Overview <#security_overview>`__\n+----------------------------------------------\n+\n+In release 0.9.0.0, the Kafka community added a number of features that,\n+used either separately or together, increases security in a Kafka\n+cluster. The following security measures are currently supported:\n+\n+#. Authentication of connections to brokers from clients (producers and\n+   consumers), other brokers and tools, using either SSL or SASL. Kafka\n+   supports the following SASL mechanisms:\n+\n+   -  SASL/GSSAPI (Kerberos) - starting at version 0.9.0.0","path":"docs/documentation/security.rst","position":18,"original_position":18,"commit_id":"fc9198f4a8e2ad5b424e2f1f6b7c7bf413f4685a","original_commit_id":"dd929b5019f62f60a1f695c40cdcd9c4a155343f","user":{"login":"ewencp","id":47366,"avatar_url":"https://avatars3.githubusercontent.com/u/47366?v=4","gravatar_id":"","url":"https://api.github.com/users/ewencp","html_url":"https://github.com/ewencp","followers_url":"https://api.github.com/users/ewencp/followers","following_url":"https://api.github.com/users/ewencp/following{/other_user}","gists_url":"https://api.github.com/users/ewencp/gists{/gist_id}","starred_url":"https://api.github.com/users/ewencp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewencp/subscriptions","organizations_url":"https://api.github.com/users/ewencp/orgs","repos_url":"https://api.github.com/users/ewencp/repos","events_url":"https://api.github.com/users/ewencp/events{/privacy}","received_events_url":"https://api.github.com/users/ewencp/received_events","type":"User","site_admin":false},"body":"I don't think this is correct, these are \"starting at version\" notes, so an absolute, fixed version is correct here.","created_at":"2018-03-28T02:54:22Z","updated_at":"2018-03-28T02:54:22Z","html_url":"https://github.com/apache/kafka/pull/4536#discussion_r177627074","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/4536","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/177627074"},"html":{"href":"https://github.com/apache/kafka/pull/4536#discussion_r177627074"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/4536"}},"in_reply_to_id":171132076},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/4536","id":167562818,"html_url":"https://github.com/apache/kafka/pull/4536","diff_url":"https://github.com/apache/kafka/pull/4536.diff","patch_url":"https://github.com/apache/kafka/pull/4536.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/4536","number":4536,"state":"open","locked":false,"title":"[WIP] Migrate HTML to RST","user":{"login":"joel-hamill","id":11722533,"avatar_url":"https://avatars0.githubusercontent.com/u/11722533?v=4","gravatar_id":"","url":"https://api.github.com/users/joel-hamill","html_url":"https://github.com/joel-hamill","followers_url":"https://api.github.com/users/joel-hamill/followers","following_url":"https://api.github.com/users/joel-hamill/following{/other_user}","gists_url":"https://api.github.com/users/joel-hamill/gists{/gist_id}","starred_url":"https://api.github.com/users/joel-hamill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joel-hamill/subscriptions","organizations_url":"https://api.github.com/users/joel-hamill/orgs","repos_url":"https://api.github.com/users/joel-hamill/repos","events_url":"https://api.github.com/users/joel-hamill/events{/privacy}","received_events_url":"https://api.github.com/users/joel-hamill/received_events","type":"User","site_admin":false},"body":"This PR migrates the HTML documentation content to restructuredText. \r\n\r\nCC: @ewencp @guozhangwang \r\n","created_at":"2018-02-06T23:56:41Z","updated_at":"2018-03-28T02:54:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2feb8a2c1ba901ef05ad881e8d0f8dcac938927","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":820768376,"url":"https://api.github.com/repos/apache/kafka/labels/docs","name":"docs","color":"017c4f","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/4536/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/4536/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/4536/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/fc9198f4a8e2ad5b424e2f1f6b7c7bf413f4685a","head":{"label":"joel-hamill:migrate-html-to-rst","ref":"migrate-html-to-rst","sha":"fc9198f4a8e2ad5b424e2f1f6b7c7bf413f4685a","user":{"login":"joel-hamill","id":11722533,"avatar_url":"https://avatars0.githubusercontent.com/u/11722533?v=4","gravatar_id":"","url":"https://api.github.com/users/joel-hamill","html_url":"https://github.com/joel-hamill","followers_url":"https://api.github.com/users/joel-hamill/followers","following_url":"https://api.github.com/users/joel-hamill/following{/other_user}","gists_url":"https://api.github.com/users/joel-hamill/gists{/gist_id}","starred_url":"https://api.github.com/users/joel-hamill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joel-hamill/subscriptions","organizations_url":"https://api.github.com/users/joel-hamill/orgs","repos_url":"https://api.github.com/users/joel-hamill/repos","events_url":"https://api.github.com/users/joel-hamill/events{/privacy}","received_events_url":"https://api.github.com/users/joel-hamill/received_events","type":"User","site_admin":false},"repo":{"id":99621265,"name":"kafka","full_name":"joel-hamill/kafka","owner":{"login":"joel-hamill","id":11722533,"avatar_url":"https://avatars0.githubusercontent.com/u/11722533?v=4","gravatar_id":"","url":"https://api.github.com/users/joel-hamill","html_url":"https://github.com/joel-hamill","followers_url":"https://api.github.com/users/joel-hamill/followers","following_url":"https://api.github.com/users/joel-hamill/following{/other_user}","gists_url":"https://api.github.com/users/joel-hamill/gists{/gist_id}","starred_url":"https://api.github.com/users/joel-hamill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joel-hamill/subscriptions","organizations_url":"https://api.github.com/users/joel-hamill/orgs","repos_url":"https://api.github.com/users/joel-hamill/repos","events_url":"https://api.github.com/users/joel-hamill/events{/privacy}","received_events_url":"https://api.github.com/users/joel-hamill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joel-hamill/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/joel-hamill/kafka","forks_url":"https://api.github.com/repos/joel-hamill/kafka/forks","keys_url":"https://api.github.com/repos/joel-hamill/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joel-hamill/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joel-hamill/kafka/teams","hooks_url":"https://api.github.com/repos/joel-hamill/kafka/hooks","issue_events_url":"https://api.github.com/repos/joel-hamill/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/joel-hamill/kafka/events","assignees_url":"https://api.github.com/repos/joel-hamill/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/joel-hamill/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/joel-hamill/kafka/tags","blobs_url":"https://api.github.com/repos/joel-hamill/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joel-hamill/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joel-hamill/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/joel-hamill/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joel-hamill/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/joel-hamill/kafka/languages","stargazers_url":"https://api.github.com/repos/joel-hamill/kafka/stargazers","contributors_url":"https://api.github.com/repos/joel-hamill/kafka/contributors","subscribers_url":"https://api.github.com/repos/joel-hamill/kafka/subscribers","subscription_url":"https://api.github.com/repos/joel-hamill/kafka/subscription","commits_url":"https://api.github.com/repos/joel-hamill/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/joel-hamill/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/joel-hamill/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/joel-hamill/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/joel-hamill/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/joel-hamill/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joel-hamill/kafka/merges","archive_url":"https://api.github.com/repos/joel-hamill/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joel-hamill/kafka/downloads","issues_url":"https://api.github.com/repos/joel-hamill/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/joel-hamill/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/joel-hamill/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/joel-hamill/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joel-hamill/kafka/labels{/name}","releases_url":"https://api.github.com/repos/joel-hamill/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/joel-hamill/kafka/deployments","created_at":"2017-08-07T21:17:15Z","updated_at":"2017-08-07T21:17:25Z","pushed_at":"2018-03-28T02:52:36Z","git_url":"git://github.com/joel-hamill/kafka.git","ssh_url":"git@github.com:joel-hamill/kafka.git","clone_url":"https://github.com/joel-hamill/kafka.git","svn_url":"https://github.com/joel-hamill/kafka","homepage":null,"size":65272,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"9868976747fb4a7a4a9b18e1f4050633c226be7d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2018-03-28T02:38:39Z","pushed_at":"2018-03-28T02:52:38Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":63923,"stargazers_count":7803,"watchers_count":7803,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4619,"mirror_url":null,"archived":false,"open_issues_count":430,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4619,"open_issues":430,"watchers":7803,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/4536"},"html":{"href":"https://github.com/apache/kafka/pull/4536"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/4536"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/4536/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/4536/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/4536/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/fc9198f4a8e2ad5b424e2f1f6b7c7bf413f4685a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ewencp"}}