{"action":"created","comment":{"url":"https://api.github.com/repos/tpope/vim-fugitive/pulls/comments/244063303","pull_request_review_id":187977789,"id":244063303,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDA2MzMwMw==","diff_hunk":"@@ -2386,6 +2413,13 @@ function! s:Merge(cmd, bang, args) abort\n     if !had_merge_msg && filereadable(b:git_dir . '/MERGE_MSG')\n       cclose\n       return 'Gcommit --no-status -n -t '.s:shellesc(b:git_dir . '/MERGE_MSG')\n+    elseif a:cmd =~# '^rebase' && ' '.a:args =~# ' --continue'\n+      if s:has_rebase_commit_cmd()\n+        cclose\n+        return 'Gcommit --amend'\n+      elseif !empty(getqflist())\n+        return 'call fugitive#Copen()'","path":"autoload/fugitive.vim","position":null,"original_position":67,"commit_id":"bf337e34371525646c02ee02b137cf37149b6d2f","original_commit_id":"dd87cc75321693d41c1314ac3d9b0b2e58bcd5d9","user":{"login":"rbong","id":5875706,"node_id":"MDQ6VXNlcjU4NzU3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/5875706?v=4","gravatar_id":"","url":"https://api.github.com/users/rbong","html_url":"https://github.com/rbong","followers_url":"https://api.github.com/users/rbong/followers","following_url":"https://api.github.com/users/rbong/following{/other_user}","gists_url":"https://api.github.com/users/rbong/gists{/gist_id}","starred_url":"https://api.github.com/users/rbong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbong/subscriptions","organizations_url":"https://api.github.com/users/rbong/orgs","repos_url":"https://api.github.com/users/rbong/repos","events_url":"https://api.github.com/users/rbong/events{/privacy}","received_events_url":"https://api.github.com/users/rbong/received_events","type":"User","site_admin":false},"body":"Alright, this fix is back in now.","created_at":"2018-12-27T00:10:46Z","updated_at":"2018-12-27T00:10:46Z","html_url":"https://github.com/tpope/vim-fugitive/pull/1139#discussion_r244063303","pull_request_url":"https://api.github.com/repos/tpope/vim-fugitive/pulls/1139","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/tpope/vim-fugitive/pulls/comments/244063303"},"html":{"href":"https://github.com/tpope/vim-fugitive/pull/1139#discussion_r244063303"},"pull_request":{"href":"https://api.github.com/repos/tpope/vim-fugitive/pulls/1139"}},"in_reply_to_id":244051218},"pull_request":{"url":"https://api.github.com/repos/tpope/vim-fugitive/pulls/1139","id":241029334,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMDI5MzM0","html_url":"https://github.com/tpope/vim-fugitive/pull/1139","diff_url":"https://github.com/tpope/vim-fugitive/pull/1139.diff","patch_url":"https://github.com/tpope/vim-fugitive/pull/1139.patch","issue_url":"https://api.github.com/repos/tpope/vim-fugitive/issues/1139","number":1139,"state":"open","locked":false,"title":"Support Grebase --continue/--edit-todo editor invocation","user":{"login":"rbong","id":5875706,"node_id":"MDQ6VXNlcjU4NzU3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/5875706?v=4","gravatar_id":"","url":"https://api.github.com/users/rbong","html_url":"https://github.com/rbong","followers_url":"https://api.github.com/users/rbong/followers","following_url":"https://api.github.com/users/rbong/following{/other_user}","gists_url":"https://api.github.com/users/rbong/gists{/gist_id}","starred_url":"https://api.github.com/users/rbong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbong/subscriptions","organizations_url":"https://api.github.com/users/rbong/orgs","repos_url":"https://api.github.com/users/rbong/repos","events_url":"https://api.github.com/users/rbong/events{/privacy}","received_events_url":"https://api.github.com/users/rbong/received_events","type":"User","site_admin":false},"body":"As discussed in #797 \r\n\r\n`copen` was decided as the method of feedback for the user on `Grebase --continue` because `cwindow` obfuscates user feedback.\r\n\r\nThe exact method for `--edit-todo` discussed was not used. You don't need to copy the file, edit it, and move it back. You just need to edit the file. The only difference between this and invoking `--edit-todo` via the command line is that the commit hashes are not contracted and expanded. This requires using `git rebase--interactive --expand-ids` and `git rebase--interactive --shorten-ids`, which are internal helpers and can't be relied on to remain publicly accessible.\r\n\r\n`Grebase --edit-todo` does not yet support window mods but it easily can. Let me know if you think this is needed now.\r\n\r\nI also believe that it would be useful to have `--continue` and `--edit-todo` rebase autocompletion. This is another thing that can easily be added if you think it should be part of this PR.","created_at":"2018-12-26T19:59:15Z","updated_at":"2018-12-27T00:10:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe890717eb19f39a5c4a8ea621fc2b6de6ccc965","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tpope/vim-fugitive/pulls/1139/commits","review_comments_url":"https://api.github.com/repos/tpope/vim-fugitive/pulls/1139/comments","review_comment_url":"https://api.github.com/repos/tpope/vim-fugitive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tpope/vim-fugitive/issues/1139/comments","statuses_url":"https://api.github.com/repos/tpope/vim-fugitive/statuses/bf337e34371525646c02ee02b137cf37149b6d2f","head":{"label":"rbong:master","ref":"master","sha":"bf337e34371525646c02ee02b137cf37149b6d2f","user":{"login":"rbong","id":5875706,"node_id":"MDQ6VXNlcjU4NzU3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/5875706?v=4","gravatar_id":"","url":"https://api.github.com/users/rbong","html_url":"https://github.com/rbong","followers_url":"https://api.github.com/users/rbong/followers","following_url":"https://api.github.com/users/rbong/following{/other_user}","gists_url":"https://api.github.com/users/rbong/gists{/gist_id}","starred_url":"https://api.github.com/users/rbong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbong/subscriptions","organizations_url":"https://api.github.com/users/rbong/orgs","repos_url":"https://api.github.com/users/rbong/repos","events_url":"https://api.github.com/users/rbong/events{/privacy}","received_events_url":"https://api.github.com/users/rbong/received_events","type":"User","site_admin":false},"repo":{"id":76804216,"node_id":"MDEwOlJlcG9zaXRvcnk3NjgwNDIxNg==","name":"vim-fugitive","full_name":"rbong/vim-fugitive","private":false,"owner":{"login":"rbong","id":5875706,"node_id":"MDQ6VXNlcjU4NzU3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/5875706?v=4","gravatar_id":"","url":"https://api.github.com/users/rbong","html_url":"https://github.com/rbong","followers_url":"https://api.github.com/users/rbong/followers","following_url":"https://api.github.com/users/rbong/following{/other_user}","gists_url":"https://api.github.com/users/rbong/gists{/gist_id}","starred_url":"https://api.github.com/users/rbong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbong/subscriptions","organizations_url":"https://api.github.com/users/rbong/orgs","repos_url":"https://api.github.com/users/rbong/repos","events_url":"https://api.github.com/users/rbong/events{/privacy}","received_events_url":"https://api.github.com/users/rbong/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rbong/vim-fugitive","description":"fugitive.vim: a Git wrapper so awesome, it should be illegal","fork":true,"url":"https://api.github.com/repos/rbong/vim-fugitive","forks_url":"https://api.github.com/repos/rbong/vim-fugitive/forks","keys_url":"https://api.github.com/repos/rbong/vim-fugitive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rbong/vim-fugitive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rbong/vim-fugitive/teams","hooks_url":"https://api.github.com/repos/rbong/vim-fugitive/hooks","issue_events_url":"https://api.github.com/repos/rbong/vim-fugitive/issues/events{/number}","events_url":"https://api.github.com/repos/rbong/vim-fugitive/events","assignees_url":"https://api.github.com/repos/rbong/vim-fugitive/assignees{/user}","branches_url":"https://api.github.com/repos/rbong/vim-fugitive/branches{/branch}","tags_url":"https://api.github.com/repos/rbong/vim-fugitive/tags","blobs_url":"https://api.github.com/repos/rbong/vim-fugitive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rbong/vim-fugitive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rbong/vim-fugitive/git/refs{/sha}","trees_url":"https://api.github.com/repos/rbong/vim-fugitive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rbong/vim-fugitive/statuses/{sha}","languages_url":"https://api.github.com/repos/rbong/vim-fugitive/languages","stargazers_url":"https://api.github.com/repos/rbong/vim-fugitive/stargazers","contributors_url":"https://api.github.com/repos/rbong/vim-fugitive/contributors","subscribers_url":"https://api.github.com/repos/rbong/vim-fugitive/subscribers","subscription_url":"https://api.github.com/repos/rbong/vim-fugitive/subscription","commits_url":"https://api.github.com/repos/rbong/vim-fugitive/commits{/sha}","git_commits_url":"https://api.github.com/repos/rbong/vim-fugitive/git/commits{/sha}","comments_url":"https://api.github.com/repos/rbong/vim-fugitive/comments{/number}","issue_comment_url":"https://api.github.com/repos/rbong/vim-fugitive/issues/comments{/number}","contents_url":"https://api.github.com/repos/rbong/vim-fugitive/contents/{+path}","compare_url":"https://api.github.com/repos/rbong/vim-fugitive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rbong/vim-fugitive/merges","archive_url":"https://api.github.com/repos/rbong/vim-fugitive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rbong/vim-fugitive/downloads","issues_url":"https://api.github.com/repos/rbong/vim-fugitive/issues{/number}","pulls_url":"https://api.github.com/repos/rbong/vim-fugitive/pulls{/number}","milestones_url":"https://api.github.com/repos/rbong/vim-fugitive/milestones{/number}","notifications_url":"https://api.github.com/repos/rbong/vim-fugitive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rbong/vim-fugitive/labels{/name}","releases_url":"https://api.github.com/repos/rbong/vim-fugitive/releases{/id}","deployments_url":"https://api.github.com/repos/rbong/vim-fugitive/deployments","created_at":"2016-12-18T20:11:09Z","updated_at":"2018-12-27T00:10:10Z","pushed_at":"2018-12-27T00:10:08Z","git_url":"git://github.com/rbong/vim-fugitive.git","ssh_url":"git@github.com:rbong/vim-fugitive.git","clone_url":"https://github.com/rbong/vim-fugitive.git","svn_url":"https://github.com/rbong/vim-fugitive","homepage":"http://www.vim.org/scripts/script.php?script_id=2975","size":1242,"stargazers_count":0,"watchers_count":0,"language":"Vim script","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tpope:master","ref":"master","sha":"a1f9596d2d884e74358bc5017a73f37e34f7b04c","user":{"login":"tpope","id":378,"node_id":"MDQ6VXNlcjM3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/378?v=4","gravatar_id":"","url":"https://api.github.com/users/tpope","html_url":"https://github.com/tpope","followers_url":"https://api.github.com/users/tpope/followers","following_url":"https://api.github.com/users/tpope/following{/other_user}","gists_url":"https://api.github.com/users/tpope/gists{/gist_id}","starred_url":"https://api.github.com/users/tpope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpope/subscriptions","organizations_url":"https://api.github.com/users/tpope/orgs","repos_url":"https://api.github.com/users/tpope/repos","events_url":"https://api.github.com/users/tpope/events{/privacy}","received_events_url":"https://api.github.com/users/tpope/received_events","type":"User","site_admin":false},"repo":{"id":331603,"node_id":"MDEwOlJlcG9zaXRvcnkzMzE2MDM=","name":"vim-fugitive","full_name":"tpope/vim-fugitive","private":false,"owner":{"login":"tpope","id":378,"node_id":"MDQ6VXNlcjM3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/378?v=4","gravatar_id":"","url":"https://api.github.com/users/tpope","html_url":"https://github.com/tpope","followers_url":"https://api.github.com/users/tpope/followers","following_url":"https://api.github.com/users/tpope/following{/other_user}","gists_url":"https://api.github.com/users/tpope/gists{/gist_id}","starred_url":"https://api.github.com/users/tpope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpope/subscriptions","organizations_url":"https://api.github.com/users/tpope/orgs","repos_url":"https://api.github.com/users/tpope/repos","events_url":"https://api.github.com/users/tpope/events{/privacy}","received_events_url":"https://api.github.com/users/tpope/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tpope/vim-fugitive","description":"fugitive.vim: A Git wrapper so awesome, it should be illegal","fork":false,"url":"https://api.github.com/repos/tpope/vim-fugitive","forks_url":"https://api.github.com/repos/tpope/vim-fugitive/forks","keys_url":"https://api.github.com/repos/tpope/vim-fugitive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tpope/vim-fugitive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tpope/vim-fugitive/teams","hooks_url":"https://api.github.com/repos/tpope/vim-fugitive/hooks","issue_events_url":"https://api.github.com/repos/tpope/vim-fugitive/issues/events{/number}","events_url":"https://api.github.com/repos/tpope/vim-fugitive/events","assignees_url":"https://api.github.com/repos/tpope/vim-fugitive/assignees{/user}","branches_url":"https://api.github.com/repos/tpope/vim-fugitive/branches{/branch}","tags_url":"https://api.github.com/repos/tpope/vim-fugitive/tags","blobs_url":"https://api.github.com/repos/tpope/vim-fugitive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tpope/vim-fugitive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tpope/vim-fugitive/git/refs{/sha}","trees_url":"https://api.github.com/repos/tpope/vim-fugitive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tpope/vim-fugitive/statuses/{sha}","languages_url":"https://api.github.com/repos/tpope/vim-fugitive/languages","stargazers_url":"https://api.github.com/repos/tpope/vim-fugitive/stargazers","contributors_url":"https://api.github.com/repos/tpope/vim-fugitive/contributors","subscribers_url":"https://api.github.com/repos/tpope/vim-fugitive/subscribers","subscription_url":"https://api.github.com/repos/tpope/vim-fugitive/subscription","commits_url":"https://api.github.com/repos/tpope/vim-fugitive/commits{/sha}","git_commits_url":"https://api.github.com/repos/tpope/vim-fugitive/git/commits{/sha}","comments_url":"https://api.github.com/repos/tpope/vim-fugitive/comments{/number}","issue_comment_url":"https://api.github.com/repos/tpope/vim-fugitive/issues/comments{/number}","contents_url":"https://api.github.com/repos/tpope/vim-fugitive/contents/{+path}","compare_url":"https://api.github.com/repos/tpope/vim-fugitive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tpope/vim-fugitive/merges","archive_url":"https://api.github.com/repos/tpope/vim-fugitive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tpope/vim-fugitive/downloads","issues_url":"https://api.github.com/repos/tpope/vim-fugitive/issues{/number}","pulls_url":"https://api.github.com/repos/tpope/vim-fugitive/pulls{/number}","milestones_url":"https://api.github.com/repos/tpope/vim-fugitive/milestones{/number}","notifications_url":"https://api.github.com/repos/tpope/vim-fugitive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tpope/vim-fugitive/labels{/name}","releases_url":"https://api.github.com/repos/tpope/vim-fugitive/releases{/id}","deployments_url":"https://api.github.com/repos/tpope/vim-fugitive/deployments","created_at":"2009-10-09T01:09:49Z","updated_at":"2018-12-26T21:24:42Z","pushed_at":"2018-12-27T00:10:10Z","git_url":"git://github.com/tpope/vim-fugitive.git","ssh_url":"git@github.com:tpope/vim-fugitive.git","clone_url":"https://github.com/tpope/vim-fugitive.git","svn_url":"https://github.com/tpope/vim-fugitive","homepage":"https://www.vim.org/scripts/script.php?script_id=2975","size":1245,"stargazers_count":10244,"watchers_count":10244,"language":"Vim script","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":635,"mirror_url":null,"archived":false,"open_issues_count":290,"license":null,"forks":635,"open_issues":290,"watchers":10244,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tpope/vim-fugitive/pulls/1139"},"html":{"href":"https://github.com/tpope/vim-fugitive/pull/1139"},"issue":{"href":"https://api.github.com/repos/tpope/vim-fugitive/issues/1139"},"comments":{"href":"https://api.github.com/repos/tpope/vim-fugitive/issues/1139/comments"},"review_comments":{"href":"https://api.github.com/repos/tpope/vim-fugitive/pulls/1139/comments"},"review_comment":{"href":"https://api.github.com/repos/tpope/vim-fugitive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tpope/vim-fugitive/pulls/1139/commits"},"statuses":{"href":"https://api.github.com/repos/tpope/vim-fugitive/statuses/bf337e34371525646c02ee02b137cf37149b6d2f"}},"author_association":"NONE"}}
{"actor":{"display_login":"rbong"}}