{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular/issues/21623","repository_url":"https://api.github.com/repos/angular/angular","labels_url":"https://api.github.com/repos/angular/angular/issues/21623/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular/issues/21623/comments","events_url":"https://api.github.com/repos/angular/angular/issues/21623/events","html_url":"https://github.com/angular/angular/pull/21623","id":289572483,"node_id":"MDExOlB1bGxSZXF1ZXN0MTYzNjY5NjAz","number":21623,"title":"fix(core): correct the nullability of kvDiffer","user":{"login":"trotyl","id":6059170,"node_id":"MDQ6VXNlcjYwNTkxNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/6059170?v=4","gravatar_id":"","url":"https://api.github.com/users/trotyl","html_url":"https://github.com/trotyl","followers_url":"https://api.github.com/users/trotyl/followers","following_url":"https://api.github.com/users/trotyl/following{/other_user}","gists_url":"https://api.github.com/users/trotyl/gists{/gist_id}","starred_url":"https://api.github.com/users/trotyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trotyl/subscriptions","organizations_url":"https://api.github.com/users/trotyl/orgs","repos_url":"https://api.github.com/users/trotyl/repos","events_url":"https://api.github.com/users/trotyl/events{/privacy}","received_events_url":"https://api.github.com/users/trotyl/received_events","type":"User","site_admin":false},"labels":[{"id":133556520,"node_id":"MDU6TGFiZWwxMzM1NTY1MjA=","url":"https://api.github.com/repos/angular/angular/labels/PR%20action:%20merge","name":"PR action: merge","color":"99ff66","default":false},{"id":149476251,"node_id":"MDU6TGFiZWwxNDk0NzYyNTE=","url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":375501288,"node_id":"MDU6TGFiZWwzNzU1MDEyODg=","url":"https://api.github.com/repos/angular/angular/labels/comp:%20core%20&%20compiler","name":"comp: core & compiler","color":"c7def8","default":false},{"id":221038051,"node_id":"MDU6TGFiZWwyMjEwMzgwNTE=","url":"https://api.github.com/repos/angular/angular/labels/flag:%20breaking%20change","name":"flag: breaking change","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-01-18T10:11:35Z","updated_at":"2018-09-07T18:49:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/21623","html_url":"https://github.com/angular/angular/pull/21623","diff_url":"https://github.com/angular/angular/pull/21623.diff","patch_url":"https://github.com/angular/angular/pull/21623.patch"},"body":"## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n```\r\n[x] Bugfix\r\n[ ] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Documentation content changes\r\n[ ] angular.io application / infrastructure changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->\r\nThe `KeyValueDiffer#diff()` method [is actually returning `null` when nothing changed](https://github.com/angular/angular/blob/be9713c6e241834e45041aed781736a57b9789e7/packages/core/src/change_detection/differs/default_keyvalue_differ.ts#L82), while the type annotation didn't provide this info.\r\n\r\nThe corresponding `IterableDiffer#diff()` method [has been fixed already](https://github.com/angular/angular/pull/15405/files#diff-996e1c9b7c86a9def855e41a1a01a1fb), this should just be an omission.\r\n\r\nIssue Number: N/A\r\n\r\n\r\n## What is the new behavior?\r\nUse typing with correct nullability.\r\n\r\n## Does this PR introduce a breaking change?\r\n```\r\n[ ] Yes\r\n[x] No (Any usage without `null` checking would already break at runtime, so no actual behavior change)\r\n```\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->\r\n\r\n\r\n## Other information\r\n"},"comment":{"url":"https://api.github.com/repos/angular/angular/issues/comments/419531951","html_url":"https://github.com/angular/angular/pull/21623#issuecomment-419531951","issue_url":"https://api.github.com/repos/angular/angular/issues/21623","id":419531951,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTUzMTk1MQ==","user":{"login":"ngbot[bot]","id":33250855,"node_id":"MDM6Qm90MzMyNTA4NTU=","avatar_url":"https://avatars0.githubusercontent.com/in/6359?v=4","gravatar_id":"","url":"https://api.github.com/users/ngbot%5Bbot%5D","html_url":"https://github.com/apps/ngbot","followers_url":"https://api.github.com/users/ngbot%5Bbot%5D/followers","following_url":"https://api.github.com/users/ngbot%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/ngbot%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/ngbot%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngbot%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/ngbot%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/ngbot%5Bbot%5D/repos","events_url":"https://api.github.com/users/ngbot%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/ngbot%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-09-07T18:49:22Z","updated_at":"2018-09-07T18:49:22Z","author_association":"NONE","body":"I see that you just added the `PR action: merge` label, but the following checks are still failing: \n&nbsp;&nbsp;&nbsp;&nbsp;![failure](https://raw.githubusercontent.com/angular/github-robot/master/assets/failing.png) missing required label: \"PR target: *\" \n \n**If you want your PR to be merged, it has to pass all the CI checks.** \n \nIf you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help."}}
{"actor":{"display_login":"ngbot"}}