{"action":"created","comment":{"url":"https://api.github.com/repos/nipy/dipy/pulls/comments/209239862","pull_request_review_id":145216640,"id":209239862,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTIzOTg2Mg==","diff_hunk":"@@ -3009,41 +3014,57 @@ def _setup(self):\n         \"\"\"\n         margin = 10\n         size = self.panel_size\n-        font_size = 20\n-        line_spacing = 1.4\n+        font_size = self.font_size\n+        line_spacing = self.line_spacing\n         # Calculating the number of slots.\n-        slot_height = int(font_size * line_spacing)\n-        nb_slots = int((size[1] - 2 * margin) // slot_height)\n+        self.nb_slots = int((size[1] - 2 * margin) // self.slot_height)\n \n         # This panel facilitates adding slots at the right position.\n         self.panel = Panel2D(size=size, color=(1, 1, 1))\n \n         # Add up and down buttons\n-        arrow_up = read_viz_icons(fname=\"arrow-up.png\")\n-        self.up_button = Button2D([(\"up\", arrow_up)])\n-        pos = self.panel.size - self.up_button.size // 2 - margin\n-        self.panel.add_element(self.up_button, pos, anchor=\"center\")\n-\n-        arrow_down = read_viz_icons(fname=\"arrow-down.png\")\n-        self.down_button = Button2D([(\"down\", arrow_down)])\n-        pos = (pos[0], self.up_button.size[1] // 2 + margin)\n-        self.panel.add_element(self.down_button, pos, anchor=\"center\")\n+        # arrow_up = read_viz_icons(fname=\"arrow-up.png\")\n+        # self.up_button = Button2D([(\"up\", arrow_up)])","path":"dipy/viz/ui.py","position":46,"original_position":46,"commit_id":"31c93b507ff72106979c5817c304873a8bd87d84","original_commit_id":"31c93b507ff72106979c5817c304873a8bd87d84","user":{"login":"MarcCote","id":660004,"node_id":"MDQ6VXNlcjY2MDAwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/660004?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcCote","html_url":"https://github.com/MarcCote","followers_url":"https://api.github.com/users/MarcCote/followers","following_url":"https://api.github.com/users/MarcCote/following{/other_user}","gists_url":"https://api.github.com/users/MarcCote/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcCote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcCote/subscriptions","organizations_url":"https://api.github.com/users/MarcCote/orgs","repos_url":"https://api.github.com/users/MarcCote/repos","events_url":"https://api.github.com/users/MarcCote/events{/privacy}","received_events_url":"https://api.github.com/users/MarcCote/received_events","type":"User","site_admin":false},"body":"Oh, let's remove those commented lines.","created_at":"2018-08-10T12:18:39Z","updated_at":"2018-08-10T12:18:39Z","html_url":"https://github.com/nipy/dipy/pull/1564#discussion_r209239862","pull_request_url":"https://api.github.com/repos/nipy/dipy/pulls/1564","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nipy/dipy/pulls/comments/209239862"},"html":{"href":"https://github.com/nipy/dipy/pull/1564#discussion_r209239862"},"pull_request":{"href":"https://api.github.com/repos/nipy/dipy/pulls/1564"}}},"pull_request":{"url":"https://api.github.com/repos/nipy/dipy/pulls/1564","id":194796104,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0Nzk2MTA0","html_url":"https://github.com/nipy/dipy/pull/1564","diff_url":"https://github.com/nipy/dipy/pull/1564.diff","patch_url":"https://github.com/nipy/dipy/pull/1564.patch","issue_url":"https://api.github.com/repos/nipy/dipy/issues/1564","number":1564,"state":"open","locked":false,"title":"Added scroll bar to ListBox2D","user":{"login":"karandeepSJ","id":24621165,"node_id":"MDQ6VXNlcjI0NjIxMTY1","avatar_url":"https://avatars3.githubusercontent.com/u/24621165?v=4","gravatar_id":"","url":"https://api.github.com/users/karandeepSJ","html_url":"https://github.com/karandeepSJ","followers_url":"https://api.github.com/users/karandeepSJ/followers","following_url":"https://api.github.com/users/karandeepSJ/following{/other_user}","gists_url":"https://api.github.com/users/karandeepSJ/gists{/gist_id}","starred_url":"https://api.github.com/users/karandeepSJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karandeepSJ/subscriptions","organizations_url":"https://api.github.com/users/karandeepSJ/orgs","repos_url":"https://api.github.com/users/karandeepSJ/repos","events_url":"https://api.github.com/users/karandeepSJ/events{/privacy}","received_events_url":"https://api.github.com/users/karandeepSJ/received_events","type":"User","site_admin":false},"body":"This PR adds a scroll bar to the `ListBox2D` in viz.ui. The scroll bar can be moved at different speeds with the mouse. It also moves up or down when the scrolling occurs through the mouse wheel.\r\n![scroll](https://user-images.githubusercontent.com/24621165/41396599-19ab4cde-6fcf-11e8-9e84-7668a946f87b.gif)\r\n","created_at":"2018-06-14T07:03:53Z","updated_at":"2018-08-10T12:18:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d81d09b566d1f9017bf21715775a53ac5f1ca70","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ranveeraggarwal","id":3941281,"node_id":"MDQ6VXNlcjM5NDEyODE=","avatar_url":"https://avatars2.githubusercontent.com/u/3941281?v=4","gravatar_id":"","url":"https://api.github.com/users/ranveeraggarwal","html_url":"https://github.com/ranveeraggarwal","followers_url":"https://api.github.com/users/ranveeraggarwal/followers","following_url":"https://api.github.com/users/ranveeraggarwal/following{/other_user}","gists_url":"https://api.github.com/users/ranveeraggarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/ranveeraggarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranveeraggarwal/subscriptions","organizations_url":"https://api.github.com/users/ranveeraggarwal/orgs","repos_url":"https://api.github.com/users/ranveeraggarwal/repos","events_url":"https://api.github.com/users/ranveeraggarwal/events{/privacy}","received_events_url":"https://api.github.com/users/ranveeraggarwal/received_events","type":"User","site_admin":false},{"login":"dmreagan","id":6951528,"node_id":"MDQ6VXNlcjY5NTE1Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/6951528?v=4","gravatar_id":"","url":"https://api.github.com/users/dmreagan","html_url":"https://github.com/dmreagan","followers_url":"https://api.github.com/users/dmreagan/followers","following_url":"https://api.github.com/users/dmreagan/following{/other_user}","gists_url":"https://api.github.com/users/dmreagan/gists{/gist_id}","starred_url":"https://api.github.com/users/dmreagan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmreagan/subscriptions","organizations_url":"https://api.github.com/users/dmreagan/orgs","repos_url":"https://api.github.com/users/dmreagan/repos","events_url":"https://api.github.com/users/dmreagan/events{/privacy}","received_events_url":"https://api.github.com/users/dmreagan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":901696012,"node_id":"MDU6TGFiZWw5MDE2OTYwMTI=","url":"https://api.github.com/repos/nipy/dipy/labels/gsoc2018","name":"gsoc2018","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nipy/dipy/pulls/1564/commits","review_comments_url":"https://api.github.com/repos/nipy/dipy/pulls/1564/comments","review_comment_url":"https://api.github.com/repos/nipy/dipy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nipy/dipy/issues/1564/comments","statuses_url":"https://api.github.com/repos/nipy/dipy/statuses/31c93b507ff72106979c5817c304873a8bd87d84","head":{"label":"karandeepSJ:ScrollBar","ref":"ScrollBar","sha":"31c93b507ff72106979c5817c304873a8bd87d84","user":{"login":"karandeepSJ","id":24621165,"node_id":"MDQ6VXNlcjI0NjIxMTY1","avatar_url":"https://avatars3.githubusercontent.com/u/24621165?v=4","gravatar_id":"","url":"https://api.github.com/users/karandeepSJ","html_url":"https://github.com/karandeepSJ","followers_url":"https://api.github.com/users/karandeepSJ/followers","following_url":"https://api.github.com/users/karandeepSJ/following{/other_user}","gists_url":"https://api.github.com/users/karandeepSJ/gists{/gist_id}","starred_url":"https://api.github.com/users/karandeepSJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karandeepSJ/subscriptions","organizations_url":"https://api.github.com/users/karandeepSJ/orgs","repos_url":"https://api.github.com/users/karandeepSJ/repos","events_url":"https://api.github.com/users/karandeepSJ/events{/privacy}","received_events_url":"https://api.github.com/users/karandeepSJ/received_events","type":"User","site_admin":false},"repo":{"id":124381644,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQzODE2NDQ=","name":"dipy","full_name":"karandeepSJ/dipy","owner":{"login":"karandeepSJ","id":24621165,"node_id":"MDQ6VXNlcjI0NjIxMTY1","avatar_url":"https://avatars3.githubusercontent.com/u/24621165?v=4","gravatar_id":"","url":"https://api.github.com/users/karandeepSJ","html_url":"https://github.com/karandeepSJ","followers_url":"https://api.github.com/users/karandeepSJ/followers","following_url":"https://api.github.com/users/karandeepSJ/following{/other_user}","gists_url":"https://api.github.com/users/karandeepSJ/gists{/gist_id}","starred_url":"https://api.github.com/users/karandeepSJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karandeepSJ/subscriptions","organizations_url":"https://api.github.com/users/karandeepSJ/orgs","repos_url":"https://api.github.com/users/karandeepSJ/repos","events_url":"https://api.github.com/users/karandeepSJ/events{/privacy}","received_events_url":"https://api.github.com/users/karandeepSJ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/karandeepSJ/dipy","description":"Diffusion MR Imaging in Python","fork":true,"url":"https://api.github.com/repos/karandeepSJ/dipy","forks_url":"https://api.github.com/repos/karandeepSJ/dipy/forks","keys_url":"https://api.github.com/repos/karandeepSJ/dipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karandeepSJ/dipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karandeepSJ/dipy/teams","hooks_url":"https://api.github.com/repos/karandeepSJ/dipy/hooks","issue_events_url":"https://api.github.com/repos/karandeepSJ/dipy/issues/events{/number}","events_url":"https://api.github.com/repos/karandeepSJ/dipy/events","assignees_url":"https://api.github.com/repos/karandeepSJ/dipy/assignees{/user}","branches_url":"https://api.github.com/repos/karandeepSJ/dipy/branches{/branch}","tags_url":"https://api.github.com/repos/karandeepSJ/dipy/tags","blobs_url":"https://api.github.com/repos/karandeepSJ/dipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karandeepSJ/dipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karandeepSJ/dipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/karandeepSJ/dipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karandeepSJ/dipy/statuses/{sha}","languages_url":"https://api.github.com/repos/karandeepSJ/dipy/languages","stargazers_url":"https://api.github.com/repos/karandeepSJ/dipy/stargazers","contributors_url":"https://api.github.com/repos/karandeepSJ/dipy/contributors","subscribers_url":"https://api.github.com/repos/karandeepSJ/dipy/subscribers","subscription_url":"https://api.github.com/repos/karandeepSJ/dipy/subscription","commits_url":"https://api.github.com/repos/karandeepSJ/dipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/karandeepSJ/dipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/karandeepSJ/dipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/karandeepSJ/dipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/karandeepSJ/dipy/contents/{+path}","compare_url":"https://api.github.com/repos/karandeepSJ/dipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karandeepSJ/dipy/merges","archive_url":"https://api.github.com/repos/karandeepSJ/dipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karandeepSJ/dipy/downloads","issues_url":"https://api.github.com/repos/karandeepSJ/dipy/issues{/number}","pulls_url":"https://api.github.com/repos/karandeepSJ/dipy/pulls{/number}","milestones_url":"https://api.github.com/repos/karandeepSJ/dipy/milestones{/number}","notifications_url":"https://api.github.com/repos/karandeepSJ/dipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karandeepSJ/dipy/labels{/name}","releases_url":"https://api.github.com/repos/karandeepSJ/dipy/releases{/id}","deployments_url":"https://api.github.com/repos/karandeepSJ/dipy/deployments","created_at":"2018-03-08T11:25:48Z","updated_at":"2018-08-03T22:14:29Z","pushed_at":"2018-08-10T11:28:34Z","git_url":"git://github.com/karandeepSJ/dipy.git","ssh_url":"git@github.com:karandeepSJ/dipy.git","clone_url":"https://github.com/karandeepSJ/dipy.git","svn_url":"https://github.com/karandeepSJ/dipy","homepage":"http://dipy.org","size":31211,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nipy:master","ref":"master","sha":"5a6aa5a0d5aa1b146c0ed96dcba55bebb6f8f0cf","user":{"login":"nipy","id":233707,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzcwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/233707?v=4","gravatar_id":"","url":"https://api.github.com/users/nipy","html_url":"https://github.com/nipy","followers_url":"https://api.github.com/users/nipy/followers","following_url":"https://api.github.com/users/nipy/following{/other_user}","gists_url":"https://api.github.com/users/nipy/gists{/gist_id}","starred_url":"https://api.github.com/users/nipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipy/subscriptions","organizations_url":"https://api.github.com/users/nipy/orgs","repos_url":"https://api.github.com/users/nipy/repos","events_url":"https://api.github.com/users/nipy/events{/privacy}","received_events_url":"https://api.github.com/users/nipy/received_events","type":"Organization","site_admin":false},"repo":{"id":505209,"node_id":"MDEwOlJlcG9zaXRvcnk1MDUyMDk=","name":"dipy","full_name":"nipy/dipy","owner":{"login":"nipy","id":233707,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMzcwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/233707?v=4","gravatar_id":"","url":"https://api.github.com/users/nipy","html_url":"https://github.com/nipy","followers_url":"https://api.github.com/users/nipy/followers","following_url":"https://api.github.com/users/nipy/following{/other_user}","gists_url":"https://api.github.com/users/nipy/gists{/gist_id}","starred_url":"https://api.github.com/users/nipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipy/subscriptions","organizations_url":"https://api.github.com/users/nipy/orgs","repos_url":"https://api.github.com/users/nipy/repos","events_url":"https://api.github.com/users/nipy/events{/privacy}","received_events_url":"https://api.github.com/users/nipy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nipy/dipy","description":"Diffusion MR Imaging in Python","fork":false,"url":"https://api.github.com/repos/nipy/dipy","forks_url":"https://api.github.com/repos/nipy/dipy/forks","keys_url":"https://api.github.com/repos/nipy/dipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nipy/dipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nipy/dipy/teams","hooks_url":"https://api.github.com/repos/nipy/dipy/hooks","issue_events_url":"https://api.github.com/repos/nipy/dipy/issues/events{/number}","events_url":"https://api.github.com/repos/nipy/dipy/events","assignees_url":"https://api.github.com/repos/nipy/dipy/assignees{/user}","branches_url":"https://api.github.com/repos/nipy/dipy/branches{/branch}","tags_url":"https://api.github.com/repos/nipy/dipy/tags","blobs_url":"https://api.github.com/repos/nipy/dipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nipy/dipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nipy/dipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/nipy/dipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nipy/dipy/statuses/{sha}","languages_url":"https://api.github.com/repos/nipy/dipy/languages","stargazers_url":"https://api.github.com/repos/nipy/dipy/stargazers","contributors_url":"https://api.github.com/repos/nipy/dipy/contributors","subscribers_url":"https://api.github.com/repos/nipy/dipy/subscribers","subscription_url":"https://api.github.com/repos/nipy/dipy/subscription","commits_url":"https://api.github.com/repos/nipy/dipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/nipy/dipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/nipy/dipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/nipy/dipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/nipy/dipy/contents/{+path}","compare_url":"https://api.github.com/repos/nipy/dipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nipy/dipy/merges","archive_url":"https://api.github.com/repos/nipy/dipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nipy/dipy/downloads","issues_url":"https://api.github.com/repos/nipy/dipy/issues{/number}","pulls_url":"https://api.github.com/repos/nipy/dipy/pulls{/number}","milestones_url":"https://api.github.com/repos/nipy/dipy/milestones{/number}","notifications_url":"https://api.github.com/repos/nipy/dipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nipy/dipy/labels{/name}","releases_url":"https://api.github.com/repos/nipy/dipy/releases{/id}","deployments_url":"https://api.github.com/repos/nipy/dipy/deployments","created_at":"2010-02-06T11:43:08Z","updated_at":"2018-08-09T05:47:37Z","pushed_at":"2018-08-10T11:55:27Z","git_url":"git://github.com/nipy/dipy.git","ssh_url":"git@github.com:nipy/dipy.git","clone_url":"https://github.com/nipy/dipy.git","svn_url":"https://github.com/nipy/dipy","homepage":"http://dipy.org","size":32935,"stargazers_count":179,"watchers_count":179,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":219,"mirror_url":null,"archived":false,"open_issues_count":182,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":219,"open_issues":182,"watchers":179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nipy/dipy/pulls/1564"},"html":{"href":"https://github.com/nipy/dipy/pull/1564"},"issue":{"href":"https://api.github.com/repos/nipy/dipy/issues/1564"},"comments":{"href":"https://api.github.com/repos/nipy/dipy/issues/1564/comments"},"review_comments":{"href":"https://api.github.com/repos/nipy/dipy/pulls/1564/comments"},"review_comment":{"href":"https://api.github.com/repos/nipy/dipy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nipy/dipy/pulls/1564/commits"},"statuses":{"href":"https://api.github.com/repos/nipy/dipy/statuses/31c93b507ff72106979c5817c304873a8bd87d84"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"MarcCote"}}