{"action":"created","comment":{"url":"https://api.github.com/repos/poliastro/poliastro/pulls/comments/169633844","pull_request_review_id":98189362,"id":169633844,"diff_hunk":"@@ -294,12 +297,17 @@ def sample(self, values=None, function=propagate):\n \n         elif isinstance(values, int):\n             if self.ecc < 1:\n-                nu_values = np.linspace(0, 2 * np.pi, values) * u.rad\n+                # first sample eccenric anomaly, then transform into true anomaly","path":"src/poliastro/twobody/orbit.py","position":19,"original_position":19,"commit_id":"29a7d72042014b3890c5d788e5191815cc8446e8","original_commit_id":"29a7d72042014b3890c5d788e5191815cc8446e8","user":{"login":"Juanlu001","id":316517,"avatar_url":"https://avatars2.githubusercontent.com/u/316517?v=4","gravatar_id":"","url":"https://api.github.com/users/Juanlu001","html_url":"https://github.com/Juanlu001","followers_url":"https://api.github.com/users/Juanlu001/followers","following_url":"https://api.github.com/users/Juanlu001/following{/other_user}","gists_url":"https://api.github.com/users/Juanlu001/gists{/gist_id}","starred_url":"https://api.github.com/users/Juanlu001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Juanlu001/subscriptions","organizations_url":"https://api.github.com/users/Juanlu001/orgs","repos_url":"https://api.github.com/users/Juanlu001/repos","events_url":"https://api.github.com/users/Juanlu001/events{/privacy}","received_events_url":"https://api.github.com/users/Juanlu001/received_events","type":"User","site_admin":false},"body":"s/eccenric/eccentric/g\r\n\r\nAlso, what about adding a reference to the report in the comment? \"Why sample uniformly on the eccentric anomaly to minimize error in the apocenter, see ...\"","created_at":"2018-02-21T13:23:24Z","updated_at":"2018-02-21T13:24:57Z","html_url":"https://github.com/poliastro/poliastro/pull/320#discussion_r169633844","pull_request_url":"https://api.github.com/repos/poliastro/poliastro/pulls/320","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/poliastro/poliastro/pulls/comments/169633844"},"html":{"href":"https://github.com/poliastro/poliastro/pull/320#discussion_r169633844"},"pull_request":{"href":"https://api.github.com/repos/poliastro/poliastro/pulls/320"}}},"pull_request":{"url":"https://api.github.com/repos/poliastro/poliastro/pulls/320","id":170301068,"html_url":"https://github.com/poliastro/poliastro/pull/320","diff_url":"https://github.com/poliastro/poliastro/pull/320.diff","patch_url":"https://github.com/poliastro/poliastro/pull/320.patch","issue_url":"https://api.github.com/repos/poliastro/poliastro/issues/320","number":320,"state":"open","locked":false,"title":"changed default num_points in OrbitPlotter class","user":{"login":"nikita-astronaut","id":5345808,"avatar_url":"https://avatars0.githubusercontent.com/u/5345808?v=4","gravatar_id":"","url":"https://api.github.com/users/nikita-astronaut","html_url":"https://github.com/nikita-astronaut","followers_url":"https://api.github.com/users/nikita-astronaut/followers","following_url":"https://api.github.com/users/nikita-astronaut/following{/other_user}","gists_url":"https://api.github.com/users/nikita-astronaut/gists{/gist_id}","starred_url":"https://api.github.com/users/nikita-astronaut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikita-astronaut/subscriptions","organizations_url":"https://api.github.com/users/nikita-astronaut/orgs","repos_url":"https://api.github.com/users/nikita-astronaut/repos","events_url":"https://api.github.com/users/nikita-astronaut/events{/privacy}","received_events_url":"https://api.github.com/users/nikita-astronaut/received_events","type":"User","site_admin":false},"body":"Addresses #294 \r\nI simple changed the default num_points in OrbitPlotter class, now orbits in the example look smooth.\r\nStill, this is not the best solution. Nonsmoothness appears in the vicinity of perihelion, cause the speed there is the highest, but the points in time are chosen uniformly, so the difference in position is the largest. \r\n\r\nWhat I think could be done next is to place points non uniformly but with density ~1/current_speed, so that between every two points the position change is the same.\r\n\r\nWhat do you think?\r\n\r\nP.S. I am actually looking to joining your project later in the GSoC18.\r\n\r\n","created_at":"2018-02-20T20:34:13Z","updated_at":"2018-02-21T13:24:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ccf27d7c1086d8e6d2b209499e1584e9f12cc06","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/poliastro/poliastro/pulls/320/commits","review_comments_url":"https://api.github.com/repos/poliastro/poliastro/pulls/320/comments","review_comment_url":"https://api.github.com/repos/poliastro/poliastro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/poliastro/poliastro/issues/320/comments","statuses_url":"https://api.github.com/repos/poliastro/poliastro/statuses/29a7d72042014b3890c5d788e5191815cc8446e8","head":{"label":"nikita-astronaut:iss294","ref":"iss294","sha":"29a7d72042014b3890c5d788e5191815cc8446e8","user":{"login":"nikita-astronaut","id":5345808,"avatar_url":"https://avatars0.githubusercontent.com/u/5345808?v=4","gravatar_id":"","url":"https://api.github.com/users/nikita-astronaut","html_url":"https://github.com/nikita-astronaut","followers_url":"https://api.github.com/users/nikita-astronaut/followers","following_url":"https://api.github.com/users/nikita-astronaut/following{/other_user}","gists_url":"https://api.github.com/users/nikita-astronaut/gists{/gist_id}","starred_url":"https://api.github.com/users/nikita-astronaut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikita-astronaut/subscriptions","organizations_url":"https://api.github.com/users/nikita-astronaut/orgs","repos_url":"https://api.github.com/users/nikita-astronaut/repos","events_url":"https://api.github.com/users/nikita-astronaut/events{/privacy}","received_events_url":"https://api.github.com/users/nikita-astronaut/received_events","type":"User","site_admin":false},"repo":{"id":122199359,"name":"poliastro","full_name":"nikita-astronaut/poliastro","owner":{"login":"nikita-astronaut","id":5345808,"avatar_url":"https://avatars0.githubusercontent.com/u/5345808?v=4","gravatar_id":"","url":"https://api.github.com/users/nikita-astronaut","html_url":"https://github.com/nikita-astronaut","followers_url":"https://api.github.com/users/nikita-astronaut/followers","following_url":"https://api.github.com/users/nikita-astronaut/following{/other_user}","gists_url":"https://api.github.com/users/nikita-astronaut/gists{/gist_id}","starred_url":"https://api.github.com/users/nikita-astronaut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikita-astronaut/subscriptions","organizations_url":"https://api.github.com/users/nikita-astronaut/orgs","repos_url":"https://api.github.com/users/nikita-astronaut/repos","events_url":"https://api.github.com/users/nikita-astronaut/events{/privacy}","received_events_url":"https://api.github.com/users/nikita-astronaut/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nikita-astronaut/poliastro","description":"poliastro - :rocket: Astrodynamics in Python","fork":true,"url":"https://api.github.com/repos/nikita-astronaut/poliastro","forks_url":"https://api.github.com/repos/nikita-astronaut/poliastro/forks","keys_url":"https://api.github.com/repos/nikita-astronaut/poliastro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nikita-astronaut/poliastro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nikita-astronaut/poliastro/teams","hooks_url":"https://api.github.com/repos/nikita-astronaut/poliastro/hooks","issue_events_url":"https://api.github.com/repos/nikita-astronaut/poliastro/issues/events{/number}","events_url":"https://api.github.com/repos/nikita-astronaut/poliastro/events","assignees_url":"https://api.github.com/repos/nikita-astronaut/poliastro/assignees{/user}","branches_url":"https://api.github.com/repos/nikita-astronaut/poliastro/branches{/branch}","tags_url":"https://api.github.com/repos/nikita-astronaut/poliastro/tags","blobs_url":"https://api.github.com/repos/nikita-astronaut/poliastro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nikita-astronaut/poliastro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nikita-astronaut/poliastro/git/refs{/sha}","trees_url":"https://api.github.com/repos/nikita-astronaut/poliastro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nikita-astronaut/poliastro/statuses/{sha}","languages_url":"https://api.github.com/repos/nikita-astronaut/poliastro/languages","stargazers_url":"https://api.github.com/repos/nikita-astronaut/poliastro/stargazers","contributors_url":"https://api.github.com/repos/nikita-astronaut/poliastro/contributors","subscribers_url":"https://api.github.com/repos/nikita-astronaut/poliastro/subscribers","subscription_url":"https://api.github.com/repos/nikita-astronaut/poliastro/subscription","commits_url":"https://api.github.com/repos/nikita-astronaut/poliastro/commits{/sha}","git_commits_url":"https://api.github.com/repos/nikita-astronaut/poliastro/git/commits{/sha}","comments_url":"https://api.github.com/repos/nikita-astronaut/poliastro/comments{/number}","issue_comment_url":"https://api.github.com/repos/nikita-astronaut/poliastro/issues/comments{/number}","contents_url":"https://api.github.com/repos/nikita-astronaut/poliastro/contents/{+path}","compare_url":"https://api.github.com/repos/nikita-astronaut/poliastro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nikita-astronaut/poliastro/merges","archive_url":"https://api.github.com/repos/nikita-astronaut/poliastro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nikita-astronaut/poliastro/downloads","issues_url":"https://api.github.com/repos/nikita-astronaut/poliastro/issues{/number}","pulls_url":"https://api.github.com/repos/nikita-astronaut/poliastro/pulls{/number}","milestones_url":"https://api.github.com/repos/nikita-astronaut/poliastro/milestones{/number}","notifications_url":"https://api.github.com/repos/nikita-astronaut/poliastro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nikita-astronaut/poliastro/labels{/name}","releases_url":"https://api.github.com/repos/nikita-astronaut/poliastro/releases{/id}","deployments_url":"https://api.github.com/repos/nikita-astronaut/poliastro/deployments","created_at":"2018-02-20T13:06:47Z","updated_at":"2018-02-20T13:06:49Z","pushed_at":"2018-02-21T12:01:46Z","git_url":"git://github.com/nikita-astronaut/poliastro.git","ssh_url":"git@github.com:nikita-astronaut/poliastro.git","clone_url":"https://github.com/nikita-astronaut/poliastro.git","svn_url":"https://github.com/nikita-astronaut/poliastro","homepage":"http://docs.poliastro.space","size":9682,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"poliastro:master","ref":"master","sha":"24a9299f01d7c9e8a315c94ba34f16afed4c613a","user":{"login":"poliastro","id":12176396,"avatar_url":"https://avatars3.githubusercontent.com/u/12176396?v=4","gravatar_id":"","url":"https://api.github.com/users/poliastro","html_url":"https://github.com/poliastro","followers_url":"https://api.github.com/users/poliastro/followers","following_url":"https://api.github.com/users/poliastro/following{/other_user}","gists_url":"https://api.github.com/users/poliastro/gists{/gist_id}","starred_url":"https://api.github.com/users/poliastro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poliastro/subscriptions","organizations_url":"https://api.github.com/users/poliastro/orgs","repos_url":"https://api.github.com/users/poliastro/repos","events_url":"https://api.github.com/users/poliastro/events{/privacy}","received_events_url":"https://api.github.com/users/poliastro/received_events","type":"Organization","site_admin":false},"repo":{"id":11178845,"name":"poliastro","full_name":"poliastro/poliastro","owner":{"login":"poliastro","id":12176396,"avatar_url":"https://avatars3.githubusercontent.com/u/12176396?v=4","gravatar_id":"","url":"https://api.github.com/users/poliastro","html_url":"https://github.com/poliastro","followers_url":"https://api.github.com/users/poliastro/followers","following_url":"https://api.github.com/users/poliastro/following{/other_user}","gists_url":"https://api.github.com/users/poliastro/gists{/gist_id}","starred_url":"https://api.github.com/users/poliastro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poliastro/subscriptions","organizations_url":"https://api.github.com/users/poliastro/orgs","repos_url":"https://api.github.com/users/poliastro/repos","events_url":"https://api.github.com/users/poliastro/events{/privacy}","received_events_url":"https://api.github.com/users/poliastro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/poliastro/poliastro","description":"poliastro - :rocket: Astrodynamics in Python","fork":false,"url":"https://api.github.com/repos/poliastro/poliastro","forks_url":"https://api.github.com/repos/poliastro/poliastro/forks","keys_url":"https://api.github.com/repos/poliastro/poliastro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poliastro/poliastro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poliastro/poliastro/teams","hooks_url":"https://api.github.com/repos/poliastro/poliastro/hooks","issue_events_url":"https://api.github.com/repos/poliastro/poliastro/issues/events{/number}","events_url":"https://api.github.com/repos/poliastro/poliastro/events","assignees_url":"https://api.github.com/repos/poliastro/poliastro/assignees{/user}","branches_url":"https://api.github.com/repos/poliastro/poliastro/branches{/branch}","tags_url":"https://api.github.com/repos/poliastro/poliastro/tags","blobs_url":"https://api.github.com/repos/poliastro/poliastro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poliastro/poliastro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poliastro/poliastro/git/refs{/sha}","trees_url":"https://api.github.com/repos/poliastro/poliastro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poliastro/poliastro/statuses/{sha}","languages_url":"https://api.github.com/repos/poliastro/poliastro/languages","stargazers_url":"https://api.github.com/repos/poliastro/poliastro/stargazers","contributors_url":"https://api.github.com/repos/poliastro/poliastro/contributors","subscribers_url":"https://api.github.com/repos/poliastro/poliastro/subscribers","subscription_url":"https://api.github.com/repos/poliastro/poliastro/subscription","commits_url":"https://api.github.com/repos/poliastro/poliastro/commits{/sha}","git_commits_url":"https://api.github.com/repos/poliastro/poliastro/git/commits{/sha}","comments_url":"https://api.github.com/repos/poliastro/poliastro/comments{/number}","issue_comment_url":"https://api.github.com/repos/poliastro/poliastro/issues/comments{/number}","contents_url":"https://api.github.com/repos/poliastro/poliastro/contents/{+path}","compare_url":"https://api.github.com/repos/poliastro/poliastro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poliastro/poliastro/merges","archive_url":"https://api.github.com/repos/poliastro/poliastro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poliastro/poliastro/downloads","issues_url":"https://api.github.com/repos/poliastro/poliastro/issues{/number}","pulls_url":"https://api.github.com/repos/poliastro/poliastro/pulls{/number}","milestones_url":"https://api.github.com/repos/poliastro/poliastro/milestones{/number}","notifications_url":"https://api.github.com/repos/poliastro/poliastro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poliastro/poliastro/labels{/name}","releases_url":"https://api.github.com/repos/poliastro/poliastro/releases{/id}","deployments_url":"https://api.github.com/repos/poliastro/poliastro/deployments","created_at":"2013-07-04T14:14:45Z","updated_at":"2018-02-21T12:05:06Z","pushed_at":"2018-02-21T12:01:48Z","git_url":"git://github.com/poliastro/poliastro.git","ssh_url":"git@github.com:poliastro/poliastro.git","clone_url":"https://github.com/poliastro/poliastro.git","svn_url":"https://github.com/poliastro/poliastro","homepage":"http://docs.poliastro.space","size":9595,"stargazers_count":123,"watchers_count":123,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":43,"open_issues":41,"watchers":123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/poliastro/poliastro/pulls/320"},"html":{"href":"https://github.com/poliastro/poliastro/pull/320"},"issue":{"href":"https://api.github.com/repos/poliastro/poliastro/issues/320"},"comments":{"href":"https://api.github.com/repos/poliastro/poliastro/issues/320/comments"},"review_comments":{"href":"https://api.github.com/repos/poliastro/poliastro/pulls/320/comments"},"review_comment":{"href":"https://api.github.com/repos/poliastro/poliastro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/poliastro/poliastro/pulls/320/commits"},"statuses":{"href":"https://api.github.com/repos/poliastro/poliastro/statuses/29a7d72042014b3890c5d788e5191815cc8446e8"}},"author_association":"NONE"}}
{"actor":{"display_login":"Juanlu001"}}