{"action":"created","comment":{"url":"https://api.github.com/repos/Instagram/IGListKit/pulls/comments/230618915","pull_request_review_id":171395371,"id":230618915,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDYxODkxNQ==","diff_hunk":"@@ -395,5 +395,21 @@ - (void)test_whenUpdating_withMutableArrayObject_thatViewModelsDontMutate {\n     XCTAssertNotEqualObjects(initObjects, section.viewModels);\n }\n \n+- (void)test_viewModelsUpdate_afterCellHasBeenMoved {\n+    [self setupWithObjects:@[\n+                             [[IGTestDiffingObject alloc] initWithKey:@1 objects:@[@7, @\"seven\", @20]],\n+                             ]];\n+    \n+    IGTestDiffingSectionController *section = [self.adapter sectionControllerForObject:self.dataSource.objects.firstObject];\n+    \n+    [section moveObjectFromIndex:0 toIndex:2];\n+    XCTAssertEqual([section.viewModels firstObject], @\"seven\");\n+    XCTAssertEqual([section.viewModels lastObject], @7);\n+    \n+    [section moveObjectFromIndex:2 toIndex:1];\n+    XCTAssertEqual([section.viewModels objectAtIndex: 1], @7);\n+    XCTAssertEqual([section.viewModels lastObject], @20);","path":"Tests/IGListBindingSectionControllerTests.m","position":17,"original_position":17,"commit_id":"78b1a42a17cc41ff0e030846c1571645f6a7d109","original_commit_id":"78b1a42a17cc41ff0e030846c1571645f6a7d109","user":{"login":"rnystrom","id":739696,"node_id":"MDQ6VXNlcjczOTY5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/739696?v=4","gravatar_id":"","url":"https://api.github.com/users/rnystrom","html_url":"https://github.com/rnystrom","followers_url":"https://api.github.com/users/rnystrom/followers","following_url":"https://api.github.com/users/rnystrom/following{/other_user}","gists_url":"https://api.github.com/users/rnystrom/gists{/gist_id}","starred_url":"https://api.github.com/users/rnystrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnystrom/subscriptions","organizations_url":"https://api.github.com/users/rnystrom/orgs","repos_url":"https://api.github.com/users/rnystrom/repos","events_url":"https://api.github.com/users/rnystrom/events{/privacy}","received_events_url":"https://api.github.com/users/rnystrom/received_events","type":"User","site_admin":false},"body":"Just confirming, this fails w/out the patch applied?","created_at":"2018-11-05T02:05:55Z","updated_at":"2018-11-05T02:05:58Z","html_url":"https://github.com/Instagram/IGListKit/pull/1274#discussion_r230618915","pull_request_url":"https://api.github.com/repos/Instagram/IGListKit/pulls/1274","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Instagram/IGListKit/pulls/comments/230618915"},"html":{"href":"https://github.com/Instagram/IGListKit/pull/1274#discussion_r230618915"},"pull_request":{"href":"https://api.github.com/repos/Instagram/IGListKit/pulls/1274"}}},"pull_request":{"url":"https://api.github.com/repos/Instagram/IGListKit/pulls/1274","id":227444659,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NDQ0NjU5","html_url":"https://github.com/Instagram/IGListKit/pull/1274","diff_url":"https://github.com/Instagram/IGListKit/pull/1274.diff","patch_url":"https://github.com/Instagram/IGListKit/pull/1274.patch","issue_url":"https://api.github.com/repos/Instagram/IGListKit/issues/1274","number":1274,"state":"open","locked":false,"title":"Fix - Cell Reordering in IGListBindingSectionController (viewModels array not being updated)","user":{"login":"d3mueller","id":7083109,"node_id":"MDQ6VXNlcjcwODMxMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/7083109?v=4","gravatar_id":"","url":"https://api.github.com/users/d3mueller","html_url":"https://github.com/d3mueller","followers_url":"https://api.github.com/users/d3mueller/followers","following_url":"https://api.github.com/users/d3mueller/following{/other_user}","gists_url":"https://api.github.com/users/d3mueller/gists{/gist_id}","starred_url":"https://api.github.com/users/d3mueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3mueller/subscriptions","organizations_url":"https://api.github.com/users/d3mueller/orgs","repos_url":"https://api.github.com/users/d3mueller/repos","events_url":"https://api.github.com/users/d3mueller/events{/privacy}","received_events_url":"https://api.github.com/users/d3mueller/received_events","type":"User","site_admin":false},"body":"- See #1262 (cell reordering using a binding section controller caused problems)\r\n\r\n## Changes in this pull request\r\n- Added method override in `IGListBindingSectionController` to update the internal `viewModels` array after a cell has been moved\r\n- Subclasses of IGListBindingSectionController require to call super\r\n\r\nIssue fixed: #1262 \r\n\r\nI've added a test for this change. Is this enough? Or should I add more corner cases or something?\r\n\r\n### Checklist\r\n\r\nSome tests fail, but they do seem unrelated. I don't know if this is normal. I haven't changed anything regarding those failing tests.\r\n\r\n- [ ] All tests pass. Demo project builds and runs.\r\n- [x] I added tests, an experiment, or detailed why my change isn't tested.\r\n- [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.\r\n- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md)","created_at":"2018-10-31T21:16:17Z","updated_at":"2018-11-05T02:05:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86040d7b435b920d349ddcbb93f03cbd950a1efd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":438144450,"node_id":"MDU6TGFiZWw0MzgxNDQ0NTA=","url":"https://api.github.com/repos/Instagram/IGListKit/labels/CLA%20Signed","name":"CLA Signed","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Instagram/IGListKit/pulls/1274/commits","review_comments_url":"https://api.github.com/repos/Instagram/IGListKit/pulls/1274/comments","review_comment_url":"https://api.github.com/repos/Instagram/IGListKit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Instagram/IGListKit/issues/1274/comments","statuses_url":"https://api.github.com/repos/Instagram/IGListKit/statuses/78b1a42a17cc41ff0e030846c1571645f6a7d109","head":{"label":"d3mueller:fix/bindingSection_cellReordering","ref":"fix/bindingSection_cellReordering","sha":"78b1a42a17cc41ff0e030846c1571645f6a7d109","user":{"login":"d3mueller","id":7083109,"node_id":"MDQ6VXNlcjcwODMxMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/7083109?v=4","gravatar_id":"","url":"https://api.github.com/users/d3mueller","html_url":"https://github.com/d3mueller","followers_url":"https://api.github.com/users/d3mueller/followers","following_url":"https://api.github.com/users/d3mueller/following{/other_user}","gists_url":"https://api.github.com/users/d3mueller/gists{/gist_id}","starred_url":"https://api.github.com/users/d3mueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3mueller/subscriptions","organizations_url":"https://api.github.com/users/d3mueller/orgs","repos_url":"https://api.github.com/users/d3mueller/repos","events_url":"https://api.github.com/users/d3mueller/events{/privacy}","received_events_url":"https://api.github.com/users/d3mueller/received_events","type":"User","site_admin":false},"repo":{"id":155041126,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUwNDExMjY=","name":"IGListKit","full_name":"d3mueller/IGListKit","private":false,"owner":{"login":"d3mueller","id":7083109,"node_id":"MDQ6VXNlcjcwODMxMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/7083109?v=4","gravatar_id":"","url":"https://api.github.com/users/d3mueller","html_url":"https://github.com/d3mueller","followers_url":"https://api.github.com/users/d3mueller/followers","following_url":"https://api.github.com/users/d3mueller/following{/other_user}","gists_url":"https://api.github.com/users/d3mueller/gists{/gist_id}","starred_url":"https://api.github.com/users/d3mueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3mueller/subscriptions","organizations_url":"https://api.github.com/users/d3mueller/orgs","repos_url":"https://api.github.com/users/d3mueller/repos","events_url":"https://api.github.com/users/d3mueller/events{/privacy}","received_events_url":"https://api.github.com/users/d3mueller/received_events","type":"User","site_admin":false},"html_url":"https://github.com/d3mueller/IGListKit","description":"A data-driven UICollectionView framework for building fast and flexible lists.","fork":true,"url":"https://api.github.com/repos/d3mueller/IGListKit","forks_url":"https://api.github.com/repos/d3mueller/IGListKit/forks","keys_url":"https://api.github.com/repos/d3mueller/IGListKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d3mueller/IGListKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d3mueller/IGListKit/teams","hooks_url":"https://api.github.com/repos/d3mueller/IGListKit/hooks","issue_events_url":"https://api.github.com/repos/d3mueller/IGListKit/issues/events{/number}","events_url":"https://api.github.com/repos/d3mueller/IGListKit/events","assignees_url":"https://api.github.com/repos/d3mueller/IGListKit/assignees{/user}","branches_url":"https://api.github.com/repos/d3mueller/IGListKit/branches{/branch}","tags_url":"https://api.github.com/repos/d3mueller/IGListKit/tags","blobs_url":"https://api.github.com/repos/d3mueller/IGListKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d3mueller/IGListKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d3mueller/IGListKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/d3mueller/IGListKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d3mueller/IGListKit/statuses/{sha}","languages_url":"https://api.github.com/repos/d3mueller/IGListKit/languages","stargazers_url":"https://api.github.com/repos/d3mueller/IGListKit/stargazers","contributors_url":"https://api.github.com/repos/d3mueller/IGListKit/contributors","subscribers_url":"https://api.github.com/repos/d3mueller/IGListKit/subscribers","subscription_url":"https://api.github.com/repos/d3mueller/IGListKit/subscription","commits_url":"https://api.github.com/repos/d3mueller/IGListKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/d3mueller/IGListKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/d3mueller/IGListKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/d3mueller/IGListKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/d3mueller/IGListKit/contents/{+path}","compare_url":"https://api.github.com/repos/d3mueller/IGListKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d3mueller/IGListKit/merges","archive_url":"https://api.github.com/repos/d3mueller/IGListKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d3mueller/IGListKit/downloads","issues_url":"https://api.github.com/repos/d3mueller/IGListKit/issues{/number}","pulls_url":"https://api.github.com/repos/d3mueller/IGListKit/pulls{/number}","milestones_url":"https://api.github.com/repos/d3mueller/IGListKit/milestones{/number}","notifications_url":"https://api.github.com/repos/d3mueller/IGListKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d3mueller/IGListKit/labels{/name}","releases_url":"https://api.github.com/repos/d3mueller/IGListKit/releases{/id}","deployments_url":"https://api.github.com/repos/d3mueller/IGListKit/deployments","created_at":"2018-10-28T06:14:02Z","updated_at":"2018-10-28T06:14:05Z","pushed_at":"2018-10-31T21:11:25Z","git_url":"git://github.com/d3mueller/IGListKit.git","ssh_url":"git@github.com:d3mueller/IGListKit.git","clone_url":"https://github.com/d3mueller/IGListKit.git","svn_url":"https://github.com/d3mueller/IGListKit","homepage":"https://instagram.github.io/IGListKit/","size":6214,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Instagram:master","ref":"master","sha":"1f6eece92cd8b9ecf738f12728645a162d5ce77f","user":{"login":"Instagram","id":549085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0OTA4NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/549085?v=4","gravatar_id":"","url":"https://api.github.com/users/Instagram","html_url":"https://github.com/Instagram","followers_url":"https://api.github.com/users/Instagram/followers","following_url":"https://api.github.com/users/Instagram/following{/other_user}","gists_url":"https://api.github.com/users/Instagram/gists{/gist_id}","starred_url":"https://api.github.com/users/Instagram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Instagram/subscriptions","organizations_url":"https://api.github.com/users/Instagram/orgs","repos_url":"https://api.github.com/users/Instagram/repos","events_url":"https://api.github.com/users/Instagram/events{/privacy}","received_events_url":"https://api.github.com/users/Instagram/received_events","type":"Organization","site_admin":false},"repo":{"id":67588512,"node_id":"MDEwOlJlcG9zaXRvcnk2NzU4ODUxMg==","name":"IGListKit","full_name":"Instagram/IGListKit","private":false,"owner":{"login":"Instagram","id":549085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0OTA4NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/549085?v=4","gravatar_id":"","url":"https://api.github.com/users/Instagram","html_url":"https://github.com/Instagram","followers_url":"https://api.github.com/users/Instagram/followers","following_url":"https://api.github.com/users/Instagram/following{/other_user}","gists_url":"https://api.github.com/users/Instagram/gists{/gist_id}","starred_url":"https://api.github.com/users/Instagram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Instagram/subscriptions","organizations_url":"https://api.github.com/users/Instagram/orgs","repos_url":"https://api.github.com/users/Instagram/repos","events_url":"https://api.github.com/users/Instagram/events{/privacy}","received_events_url":"https://api.github.com/users/Instagram/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Instagram/IGListKit","description":"A data-driven UICollectionView framework for building fast and flexible lists.","fork":false,"url":"https://api.github.com/repos/Instagram/IGListKit","forks_url":"https://api.github.com/repos/Instagram/IGListKit/forks","keys_url":"https://api.github.com/repos/Instagram/IGListKit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Instagram/IGListKit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Instagram/IGListKit/teams","hooks_url":"https://api.github.com/repos/Instagram/IGListKit/hooks","issue_events_url":"https://api.github.com/repos/Instagram/IGListKit/issues/events{/number}","events_url":"https://api.github.com/repos/Instagram/IGListKit/events","assignees_url":"https://api.github.com/repos/Instagram/IGListKit/assignees{/user}","branches_url":"https://api.github.com/repos/Instagram/IGListKit/branches{/branch}","tags_url":"https://api.github.com/repos/Instagram/IGListKit/tags","blobs_url":"https://api.github.com/repos/Instagram/IGListKit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Instagram/IGListKit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Instagram/IGListKit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Instagram/IGListKit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Instagram/IGListKit/statuses/{sha}","languages_url":"https://api.github.com/repos/Instagram/IGListKit/languages","stargazers_url":"https://api.github.com/repos/Instagram/IGListKit/stargazers","contributors_url":"https://api.github.com/repos/Instagram/IGListKit/contributors","subscribers_url":"https://api.github.com/repos/Instagram/IGListKit/subscribers","subscription_url":"https://api.github.com/repos/Instagram/IGListKit/subscription","commits_url":"https://api.github.com/repos/Instagram/IGListKit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Instagram/IGListKit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Instagram/IGListKit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Instagram/IGListKit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Instagram/IGListKit/contents/{+path}","compare_url":"https://api.github.com/repos/Instagram/IGListKit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Instagram/IGListKit/merges","archive_url":"https://api.github.com/repos/Instagram/IGListKit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Instagram/IGListKit/downloads","issues_url":"https://api.github.com/repos/Instagram/IGListKit/issues{/number}","pulls_url":"https://api.github.com/repos/Instagram/IGListKit/pulls{/number}","milestones_url":"https://api.github.com/repos/Instagram/IGListKit/milestones{/number}","notifications_url":"https://api.github.com/repos/Instagram/IGListKit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Instagram/IGListKit/labels{/name}","releases_url":"https://api.github.com/repos/Instagram/IGListKit/releases{/id}","deployments_url":"https://api.github.com/repos/Instagram/IGListKit/deployments","created_at":"2016-09-07T08:39:27Z","updated_at":"2018-11-05T01:12:27Z","pushed_at":"2018-11-02T13:29:14Z","git_url":"git://github.com/Instagram/IGListKit.git","ssh_url":"git@github.com:Instagram/IGListKit.git","clone_url":"https://github.com/Instagram/IGListKit.git","svn_url":"https://github.com/Instagram/IGListKit","homepage":"https://instagram.github.io/IGListKit/","size":6384,"stargazers_count":9052,"watchers_count":9052,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":920,"mirror_url":null,"archived":false,"open_issues_count":102,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":920,"open_issues":102,"watchers":9052,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Instagram/IGListKit/pulls/1274"},"html":{"href":"https://github.com/Instagram/IGListKit/pull/1274"},"issue":{"href":"https://api.github.com/repos/Instagram/IGListKit/issues/1274"},"comments":{"href":"https://api.github.com/repos/Instagram/IGListKit/issues/1274/comments"},"review_comments":{"href":"https://api.github.com/repos/Instagram/IGListKit/pulls/1274/comments"},"review_comment":{"href":"https://api.github.com/repos/Instagram/IGListKit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Instagram/IGListKit/pulls/1274/commits"},"statuses":{"href":"https://api.github.com/repos/Instagram/IGListKit/statuses/78b1a42a17cc41ff0e030846c1571645f6a7d109"}},"author_association":"NONE"}}
{"actor":{"display_login":"rnystrom"}}