{"action":"closed","number":7345,"pull_request":{"url":"https://api.github.com/repos/google/ggrc-core/pulls/7345","id":170167645,"html_url":"https://github.com/google/ggrc-core/pull/7345","diff_url":"https://github.com/google/ggrc-core/pull/7345.diff","patch_url":"https://github.com/google/ggrc-core/pull/7345.patch","issue_url":"https://api.github.com/repos/google/ggrc-core/issues/7345","number":7345,"state":"closed","locked":false,"title":"GGRC-4509 Apply proposal doesn't lead to create revision","user":{"login":"pod2metra","id":2368067,"avatar_url":"https://avatars3.githubusercontent.com/u/2368067?v=4","gravatar_id":"","url":"https://api.github.com/users/pod2metra","html_url":"https://github.com/pod2metra","followers_url":"https://api.github.com/users/pod2metra/followers","following_url":"https://api.github.com/users/pod2metra/following{/other_user}","gists_url":"https://api.github.com/users/pod2metra/gists{/gist_id}","starred_url":"https://api.github.com/users/pod2metra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pod2metra/subscriptions","organizations_url":"https://api.github.com/users/pod2metra/orgs","repos_url":"https://api.github.com/users/pod2metra/repos","events_url":"https://api.github.com/users/pod2metra/events{/privacy}","received_events_url":"https://api.github.com/users/pod2metra/received_events","type":"User","site_admin":false},"body":"<!-- If your PR depends on other tickets or PRs, you can list them here\r\n# Dependencies\r\n\r\nThis PR is `on hold` until the dependencies are merged:\r\n\r\n- [ ] GGRC-1234\r\n- [ ] #1234\r\n-->\r\n\r\n# Issue description\r\n\r\nApply proposal with changed CAVs to empty doesn't lead to create revisions. \r\n\r\n# Steps to test the changes\r\n\r\n1) Create Control/Risk \r\n2) propose to change CAV from empty to some value (remember it)\r\n3) apply created proposal \r\n4) propose to change same CAV from value to empty\r\n5) apply that proposal, revision should be created \r\n6) proposal to change same CAV from empty to remembered value \r\n7) proposal shouldn't be empty\r\n\r\n# Solution description\r\n\r\nUpdate modified_by and updated_at fields if any proposed values will be applied. \r\n\r\n# Sanity checklist\r\n\r\n- [x] I have clicked through the app to make sure my changes work and not break the app.\r\n- [x] I have applied the correct milestone and labels.\r\n- [x] My changes fix the issue described in the description (and do nothing else). 🤞\r\n- [x] My changes are covered by tests.\r\n- [x] My changes follow our [performance guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/performance.rst).\r\n- [x] My changes follow our [js](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/javascript.rst) and/or [python](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/python.rst) guidelines.\r\n- [x] My commits follow our [commit guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/git/how_to_write_a_commit_message.rst).\r\n\r\n<!-- If your PR includes a migration include the additional checklist items\r\n# Migration checklist\r\n- [ ] Migration passes all checks from our [PR review guidelines](https://github.com/google/ggrc-core/blob/dev/docs/source/contributing/git/reviewing_pull_requests.rst#reviewing-a-pr-containing-database-migration-scripts)\r\n-->\r\n\r\n# PR Review checklist\r\n\r\n- [x] The changes fix the issue and don't cause any apparent regressions.\r\n- [x] Labels and milestone are correctly set.\r\n- [x] The solution description matches the changes in the code.\r\n- [x] There is no apparent way to improve the performance & design of the new code.\r\n- [x] The pull request is opened against the correct base branch.\r\n- [x] Upon merging, the Jira ticket's fixversion is correctly set and the ticket is moved to \"QA - In Progress\".\r\n\r\n<!-- If your code is not finished yet can include a TODO check list\r\n# TODO\r\n\r\n- [ ] First item on the TODO\r\n-->\r\n","created_at":"2018-02-20T11:36:29Z","updated_at":"2018-02-22T22:07:51Z","closed_at":"2018-02-22T22:07:51Z","merged_at":"2018-02-22T22:07:51Z","merge_commit_sha":"74a68e606f0eca8cb41f19d8da50097427f23414","assignee":{"login":"zidarsk8","id":566311,"avatar_url":"https://avatars2.githubusercontent.com/u/566311?v=4","gravatar_id":"","url":"https://api.github.com/users/zidarsk8","html_url":"https://github.com/zidarsk8","followers_url":"https://api.github.com/users/zidarsk8/followers","following_url":"https://api.github.com/users/zidarsk8/following{/other_user}","gists_url":"https://api.github.com/users/zidarsk8/gists{/gist_id}","starred_url":"https://api.github.com/users/zidarsk8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zidarsk8/subscriptions","organizations_url":"https://api.github.com/users/zidarsk8/orgs","repos_url":"https://api.github.com/users/zidarsk8/repos","events_url":"https://api.github.com/users/zidarsk8/events{/privacy}","received_events_url":"https://api.github.com/users/zidarsk8/received_events","type":"User","site_admin":false},"assignees":[{"login":"zidarsk8","id":566311,"avatar_url":"https://avatars2.githubusercontent.com/u/566311?v=4","gravatar_id":"","url":"https://api.github.com/users/zidarsk8","html_url":"https://github.com/zidarsk8","followers_url":"https://api.github.com/users/zidarsk8/followers","following_url":"https://api.github.com/users/zidarsk8/following{/other_user}","gists_url":"https://api.github.com/users/zidarsk8/gists{/gist_id}","starred_url":"https://api.github.com/users/zidarsk8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zidarsk8/subscriptions","organizations_url":"https://api.github.com/users/zidarsk8/orgs","repos_url":"https://api.github.com/users/zidarsk8/repos","events_url":"https://api.github.com/users/zidarsk8/events{/privacy}","received_events_url":"https://api.github.com/users/zidarsk8/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":653911749,"url":"https://api.github.com/repos/google/ggrc-core/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false},{"id":358687972,"url":"https://api.github.com/repos/google/ggrc-core/labels/critical","name":"critical","color":"000000","default":false}],"milestone":{"url":"https://api.github.com/repos/google/ggrc-core/milestones/77","html_url":"https://github.com/google/ggrc-core/milestone/77","labels_url":"https://api.github.com/repos/google/ggrc-core/milestones/77/labels","id":3110951,"number":77,"title":"1.5.0-Strawberry","description":null,"creator":{"login":"m-vitaly","id":24203972,"avatar_url":"https://avatars0.githubusercontent.com/u/24203972?v=4","gravatar_id":"","url":"https://api.github.com/users/m-vitaly","html_url":"https://github.com/m-vitaly","followers_url":"https://api.github.com/users/m-vitaly/followers","following_url":"https://api.github.com/users/m-vitaly/following{/other_user}","gists_url":"https://api.github.com/users/m-vitaly/gists{/gist_id}","starred_url":"https://api.github.com/users/m-vitaly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-vitaly/subscriptions","organizations_url":"https://api.github.com/users/m-vitaly/orgs","repos_url":"https://api.github.com/users/m-vitaly/repos","events_url":"https://api.github.com/users/m-vitaly/events{/privacy}","received_events_url":"https://api.github.com/users/m-vitaly/received_events","type":"User","site_admin":false},"open_issues":33,"closed_issues":31,"state":"open","created_at":"2018-02-13T11:29:36Z","updated_at":"2018-02-22T22:07:51Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/google/ggrc-core/pulls/7345/commits","review_comments_url":"https://api.github.com/repos/google/ggrc-core/pulls/7345/comments","review_comment_url":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/ggrc-core/issues/7345/comments","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/799f6c21404f19436da8dd5c89fdfa82990b2f9e","head":{"label":"pod2metra:propsal_apply_cav","ref":"propsal_apply_cav","sha":"799f6c21404f19436da8dd5c89fdfa82990b2f9e","user":{"login":"pod2metra","id":2368067,"avatar_url":"https://avatars3.githubusercontent.com/u/2368067?v=4","gravatar_id":"","url":"https://api.github.com/users/pod2metra","html_url":"https://github.com/pod2metra","followers_url":"https://api.github.com/users/pod2metra/followers","following_url":"https://api.github.com/users/pod2metra/following{/other_user}","gists_url":"https://api.github.com/users/pod2metra/gists{/gist_id}","starred_url":"https://api.github.com/users/pod2metra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pod2metra/subscriptions","organizations_url":"https://api.github.com/users/pod2metra/orgs","repos_url":"https://api.github.com/users/pod2metra/repos","events_url":"https://api.github.com/users/pod2metra/events{/privacy}","received_events_url":"https://api.github.com/users/pod2metra/received_events","type":"User","site_admin":false},"repo":{"id":80205392,"name":"ggrc-core","full_name":"pod2metra/ggrc-core","owner":{"login":"pod2metra","id":2368067,"avatar_url":"https://avatars3.githubusercontent.com/u/2368067?v=4","gravatar_id":"","url":"https://api.github.com/users/pod2metra","html_url":"https://github.com/pod2metra","followers_url":"https://api.github.com/users/pod2metra/followers","following_url":"https://api.github.com/users/pod2metra/following{/other_user}","gists_url":"https://api.github.com/users/pod2metra/gists{/gist_id}","starred_url":"https://api.github.com/users/pod2metra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pod2metra/subscriptions","organizations_url":"https://api.github.com/users/pod2metra/orgs","repos_url":"https://api.github.com/users/pod2metra/repos","events_url":"https://api.github.com/users/pod2metra/events{/privacy}","received_events_url":"https://api.github.com/users/pod2metra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pod2metra/ggrc-core","description":"GGRC Core","fork":true,"url":"https://api.github.com/repos/pod2metra/ggrc-core","forks_url":"https://api.github.com/repos/pod2metra/ggrc-core/forks","keys_url":"https://api.github.com/repos/pod2metra/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pod2metra/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pod2metra/ggrc-core/teams","hooks_url":"https://api.github.com/repos/pod2metra/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/pod2metra/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/pod2metra/ggrc-core/events","assignees_url":"https://api.github.com/repos/pod2metra/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/pod2metra/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/pod2metra/ggrc-core/tags","blobs_url":"https://api.github.com/repos/pod2metra/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pod2metra/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pod2metra/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/pod2metra/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pod2metra/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/pod2metra/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/pod2metra/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/pod2metra/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/pod2metra/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/pod2metra/ggrc-core/subscription","commits_url":"https://api.github.com/repos/pod2metra/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/pod2metra/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/pod2metra/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/pod2metra/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/pod2metra/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/pod2metra/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pod2metra/ggrc-core/merges","archive_url":"https://api.github.com/repos/pod2metra/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pod2metra/ggrc-core/downloads","issues_url":"https://api.github.com/repos/pod2metra/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/pod2metra/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/pod2metra/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/pod2metra/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pod2metra/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/pod2metra/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/pod2metra/ggrc-core/deployments","created_at":"2017-01-27T12:24:36Z","updated_at":"2017-01-27T12:24:42Z","pushed_at":"2018-02-22T13:49:09Z","git_url":"git://github.com/pod2metra/ggrc-core.git","ssh_url":"git@github.com:pod2metra/ggrc-core.git","clone_url":"https://github.com/pod2metra/ggrc-core.git","svn_url":"https://github.com/pod2metra/ggrc-core","homepage":null,"size":72444,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"google:dev","ref":"dev","sha":"80ad71534178f5b397a5538dc6e14a0265e8f9f1","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":9304637,"name":"ggrc-core","full_name":"google/ggrc-core","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/ggrc-core","description":"GGRC Core","fork":false,"url":"https://api.github.com/repos/google/ggrc-core","forks_url":"https://api.github.com/repos/google/ggrc-core/forks","keys_url":"https://api.github.com/repos/google/ggrc-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/ggrc-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/ggrc-core/teams","hooks_url":"https://api.github.com/repos/google/ggrc-core/hooks","issue_events_url":"https://api.github.com/repos/google/ggrc-core/issues/events{/number}","events_url":"https://api.github.com/repos/google/ggrc-core/events","assignees_url":"https://api.github.com/repos/google/ggrc-core/assignees{/user}","branches_url":"https://api.github.com/repos/google/ggrc-core/branches{/branch}","tags_url":"https://api.github.com/repos/google/ggrc-core/tags","blobs_url":"https://api.github.com/repos/google/ggrc-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/ggrc-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/ggrc-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/ggrc-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/ggrc-core/statuses/{sha}","languages_url":"https://api.github.com/repos/google/ggrc-core/languages","stargazers_url":"https://api.github.com/repos/google/ggrc-core/stargazers","contributors_url":"https://api.github.com/repos/google/ggrc-core/contributors","subscribers_url":"https://api.github.com/repos/google/ggrc-core/subscribers","subscription_url":"https://api.github.com/repos/google/ggrc-core/subscription","commits_url":"https://api.github.com/repos/google/ggrc-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/ggrc-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/ggrc-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/ggrc-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/ggrc-core/contents/{+path}","compare_url":"https://api.github.com/repos/google/ggrc-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/ggrc-core/merges","archive_url":"https://api.github.com/repos/google/ggrc-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/ggrc-core/downloads","issues_url":"https://api.github.com/repos/google/ggrc-core/issues{/number}","pulls_url":"https://api.github.com/repos/google/ggrc-core/pulls{/number}","milestones_url":"https://api.github.com/repos/google/ggrc-core/milestones{/number}","notifications_url":"https://api.github.com/repos/google/ggrc-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/ggrc-core/labels{/name}","releases_url":"https://api.github.com/repos/google/ggrc-core/releases{/id}","deployments_url":"https://api.github.com/repos/google/ggrc-core/deployments","created_at":"2013-04-08T19:16:28Z","updated_at":"2018-02-21T20:14:01Z","pushed_at":"2018-02-22T22:07:51Z","git_url":"git://github.com/google/ggrc-core.git","ssh_url":"git@github.com:google/ggrc-core.git","clone_url":"https://github.com/google/ggrc-core.git","svn_url":"https://github.com/google/ggrc-core","homepage":null,"size":74515,"stargazers_count":256,"watchers_count":256,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":191,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":191,"open_issues":38,"watchers":256,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/7345"},"html":{"href":"https://github.com/google/ggrc-core/pull/7345"},"issue":{"href":"https://api.github.com/repos/google/ggrc-core/issues/7345"},"comments":{"href":"https://api.github.com/repos/google/ggrc-core/issues/7345/comments"},"review_comments":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/7345/comments"},"review_comment":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/ggrc-core/pulls/7345/commits"},"statuses":{"href":"https://api.github.com/repos/google/ggrc-core/statuses/799f6c21404f19436da8dd5c89fdfa82990b2f9e"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"zidarsk8","id":566311,"avatar_url":"https://avatars2.githubusercontent.com/u/566311?v=4","gravatar_id":"","url":"https://api.github.com/users/zidarsk8","html_url":"https://github.com/zidarsk8","followers_url":"https://api.github.com/users/zidarsk8/followers","following_url":"https://api.github.com/users/zidarsk8/following{/other_user}","gists_url":"https://api.github.com/users/zidarsk8/gists{/gist_id}","starred_url":"https://api.github.com/users/zidarsk8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zidarsk8/subscriptions","organizations_url":"https://api.github.com/users/zidarsk8/orgs","repos_url":"https://api.github.com/users/zidarsk8/repos","events_url":"https://api.github.com/users/zidarsk8/events{/privacy}","received_events_url":"https://api.github.com/users/zidarsk8/received_events","type":"User","site_admin":false},"comments":4,"review_comments":1,"maintainer_can_modify":false,"commits":3,"additions":780,"deletions":823,"changed_files":10}}
{"actor":{"display_login":"zidarsk8"}}