{"action":"created","comment":{"url":"https://api.github.com/repos/josefs/Gradualizer/pulls/comments/243771854","pull_request_review_id":187628761,"id":243771854,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mzc3MTg1NA==","diff_hunk":"@@ -3510,7 +3510,7 @@ type_check_forms(Forms, Opts) ->\n     StopOnFirstError = proplists:get_bool(stop_on_first_error, Opts),\n     CrashOnError = proplists:get_bool(crash_on_error, Opts),\n     File = proplists:get_value(print_file, Opts),\n-    NoReportErrors = proplists:get_bool(no_report_errors, Opts),\n+    NoReportErrors = not(proplists:get_bool(return_errors, Opts)),","path":"src/typechecker.erl","position":4,"original_position":5,"commit_id":"150b6962366bda6cae850a1e808de17983afa862","original_commit_id":"150b6962366bda6cae850a1e808de17983afa862","user":{"login":"Zalastax","id":908496,"node_id":"MDQ6VXNlcjkwODQ5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/908496?v=4","gravatar_id":"","url":"https://api.github.com/users/Zalastax","html_url":"https://github.com/Zalastax","followers_url":"https://api.github.com/users/Zalastax/followers","following_url":"https://api.github.com/users/Zalastax/following{/other_user}","gists_url":"https://api.github.com/users/Zalastax/gists{/gist_id}","starred_url":"https://api.github.com/users/Zalastax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zalastax/subscriptions","organizations_url":"https://api.github.com/users/Zalastax/orgs","repos_url":"https://api.github.com/users/Zalastax/repos","events_url":"https://api.github.com/users/Zalastax/events{/privacy}","received_events_url":"https://api.github.com/users/Zalastax/received_events","type":"User","site_admin":false},"body":"Haha, yes you're right!","created_at":"2018-12-23T18:07:38Z","updated_at":"2018-12-23T18:07:38Z","html_url":"https://github.com/josefs/Gradualizer/pull/112#discussion_r243771854","pull_request_url":"https://api.github.com/repos/josefs/Gradualizer/pulls/112","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/josefs/Gradualizer/pulls/comments/243771854"},"html":{"href":"https://github.com/josefs/Gradualizer/pull/112#discussion_r243771854"},"pull_request":{"href":"https://api.github.com/repos/josefs/Gradualizer/pulls/112"}},"in_reply_to_id":243749040},"pull_request":{"url":"https://api.github.com/repos/josefs/Gradualizer/pulls/112","id":239649599,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NjQ5NTk5","html_url":"https://github.com/josefs/Gradualizer/pull/112","diff_url":"https://github.com/josefs/Gradualizer/pull/112.diff","patch_url":"https://github.com/josefs/Gradualizer/pull/112.patch","issue_url":"https://api.github.com/repos/josefs/Gradualizer/issues/112","number":112,"state":"open","locked":false,"title":"Return error terms","user":{"login":"Zalastax","id":908496,"node_id":"MDQ6VXNlcjkwODQ5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/908496?v=4","gravatar_id":"","url":"https://api.github.com/users/Zalastax","html_url":"https://github.com/Zalastax","followers_url":"https://api.github.com/users/Zalastax/followers","following_url":"https://api.github.com/users/Zalastax/following{/other_user}","gists_url":"https://api.github.com/users/Zalastax/gists{/gist_id}","starred_url":"https://api.github.com/users/Zalastax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zalastax/subscriptions","organizations_url":"https://api.github.com/users/Zalastax/orgs","repos_url":"https://api.github.com/users/Zalastax/repos","events_url":"https://api.github.com/users/Zalastax/events{/privacy}","received_events_url":"https://api.github.com/users/Zalastax/received_events","type":"User","site_admin":false},"body":"Part of an upcoming series of PR's replacing #59.\r\nThe discussion over there has been great but doing it all in one big bang is not within my reach.\r\nBy keeping working on #59 I believe that I'm hindering progress since others might be avoiding changing things in this area.\r\n\r\nThis PR contains the changes needed to return errors as terms - the change I first set out to do.\r\nI've added a comment cautioning others from depending on the format of these terms - I hope that will be enough of a deterrent.","created_at":"2018-12-18T22:14:21Z","updated_at":"2018-12-23T18:07:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08035fbfddf57026b580383a13f488dda92801b1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"UlfNorell","id":447950,"node_id":"MDQ6VXNlcjQ0Nzk1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/447950?v=4","gravatar_id":"","url":"https://api.github.com/users/UlfNorell","html_url":"https://github.com/UlfNorell","followers_url":"https://api.github.com/users/UlfNorell/followers","following_url":"https://api.github.com/users/UlfNorell/following{/other_user}","gists_url":"https://api.github.com/users/UlfNorell/gists{/gist_id}","starred_url":"https://api.github.com/users/UlfNorell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UlfNorell/subscriptions","organizations_url":"https://api.github.com/users/UlfNorell/orgs","repos_url":"https://api.github.com/users/UlfNorell/repos","events_url":"https://api.github.com/users/UlfNorell/events{/privacy}","received_events_url":"https://api.github.com/users/UlfNorell/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/josefs/Gradualizer/pulls/112/commits","review_comments_url":"https://api.github.com/repos/josefs/Gradualizer/pulls/112/comments","review_comment_url":"https://api.github.com/repos/josefs/Gradualizer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/josefs/Gradualizer/issues/112/comments","statuses_url":"https://api.github.com/repos/josefs/Gradualizer/statuses/150b6962366bda6cae850a1e808de17983afa862","head":{"label":"Zalastax:return-errors","ref":"return-errors","sha":"150b6962366bda6cae850a1e808de17983afa862","user":{"login":"Zalastax","id":908496,"node_id":"MDQ6VXNlcjkwODQ5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/908496?v=4","gravatar_id":"","url":"https://api.github.com/users/Zalastax","html_url":"https://github.com/Zalastax","followers_url":"https://api.github.com/users/Zalastax/followers","following_url":"https://api.github.com/users/Zalastax/following{/other_user}","gists_url":"https://api.github.com/users/Zalastax/gists{/gist_id}","starred_url":"https://api.github.com/users/Zalastax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zalastax/subscriptions","organizations_url":"https://api.github.com/users/Zalastax/orgs","repos_url":"https://api.github.com/users/Zalastax/repos","events_url":"https://api.github.com/users/Zalastax/events{/privacy}","received_events_url":"https://api.github.com/users/Zalastax/received_events","type":"User","site_admin":false},"repo":{"id":149652141,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk2NTIxNDE=","name":"Gradualizer","full_name":"Zalastax/Gradualizer","private":false,"owner":{"login":"Zalastax","id":908496,"node_id":"MDQ6VXNlcjkwODQ5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/908496?v=4","gravatar_id":"","url":"https://api.github.com/users/Zalastax","html_url":"https://github.com/Zalastax","followers_url":"https://api.github.com/users/Zalastax/followers","following_url":"https://api.github.com/users/Zalastax/following{/other_user}","gists_url":"https://api.github.com/users/Zalastax/gists{/gist_id}","starred_url":"https://api.github.com/users/Zalastax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zalastax/subscriptions","organizations_url":"https://api.github.com/users/Zalastax/orgs","repos_url":"https://api.github.com/users/Zalastax/repos","events_url":"https://api.github.com/users/Zalastax/events{/privacy}","received_events_url":"https://api.github.com/users/Zalastax/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Zalastax/Gradualizer","description":null,"fork":true,"url":"https://api.github.com/repos/Zalastax/Gradualizer","forks_url":"https://api.github.com/repos/Zalastax/Gradualizer/forks","keys_url":"https://api.github.com/repos/Zalastax/Gradualizer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zalastax/Gradualizer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zalastax/Gradualizer/teams","hooks_url":"https://api.github.com/repos/Zalastax/Gradualizer/hooks","issue_events_url":"https://api.github.com/repos/Zalastax/Gradualizer/issues/events{/number}","events_url":"https://api.github.com/repos/Zalastax/Gradualizer/events","assignees_url":"https://api.github.com/repos/Zalastax/Gradualizer/assignees{/user}","branches_url":"https://api.github.com/repos/Zalastax/Gradualizer/branches{/branch}","tags_url":"https://api.github.com/repos/Zalastax/Gradualizer/tags","blobs_url":"https://api.github.com/repos/Zalastax/Gradualizer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zalastax/Gradualizer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zalastax/Gradualizer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zalastax/Gradualizer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zalastax/Gradualizer/statuses/{sha}","languages_url":"https://api.github.com/repos/Zalastax/Gradualizer/languages","stargazers_url":"https://api.github.com/repos/Zalastax/Gradualizer/stargazers","contributors_url":"https://api.github.com/repos/Zalastax/Gradualizer/contributors","subscribers_url":"https://api.github.com/repos/Zalastax/Gradualizer/subscribers","subscription_url":"https://api.github.com/repos/Zalastax/Gradualizer/subscription","commits_url":"https://api.github.com/repos/Zalastax/Gradualizer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zalastax/Gradualizer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zalastax/Gradualizer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zalastax/Gradualizer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zalastax/Gradualizer/contents/{+path}","compare_url":"https://api.github.com/repos/Zalastax/Gradualizer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zalastax/Gradualizer/merges","archive_url":"https://api.github.com/repos/Zalastax/Gradualizer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zalastax/Gradualizer/downloads","issues_url":"https://api.github.com/repos/Zalastax/Gradualizer/issues{/number}","pulls_url":"https://api.github.com/repos/Zalastax/Gradualizer/pulls{/number}","milestones_url":"https://api.github.com/repos/Zalastax/Gradualizer/milestones{/number}","notifications_url":"https://api.github.com/repos/Zalastax/Gradualizer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zalastax/Gradualizer/labels{/name}","releases_url":"https://api.github.com/repos/Zalastax/Gradualizer/releases{/id}","deployments_url":"https://api.github.com/repos/Zalastax/Gradualizer/deployments","created_at":"2018-09-20T18:21:39Z","updated_at":"2018-12-19T18:05:05Z","pushed_at":"2018-12-20T21:46:31Z","git_url":"git://github.com/Zalastax/Gradualizer.git","ssh_url":"git@github.com:Zalastax/Gradualizer.git","clone_url":"https://github.com/Zalastax/Gradualizer.git","svn_url":"https://github.com/Zalastax/Gradualizer","homepage":null,"size":661,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"josefs:master","ref":"master","sha":"daecdd38d1e282ced705f13c1c14ff2807df6e3e","user":{"login":"josefs","id":152020,"node_id":"MDQ6VXNlcjE1MjAyMA==","avatar_url":"https://avatars0.githubusercontent.com/u/152020?v=4","gravatar_id":"","url":"https://api.github.com/users/josefs","html_url":"https://github.com/josefs","followers_url":"https://api.github.com/users/josefs/followers","following_url":"https://api.github.com/users/josefs/following{/other_user}","gists_url":"https://api.github.com/users/josefs/gists{/gist_id}","starred_url":"https://api.github.com/users/josefs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josefs/subscriptions","organizations_url":"https://api.github.com/users/josefs/orgs","repos_url":"https://api.github.com/users/josefs/repos","events_url":"https://api.github.com/users/josefs/events{/privacy}","received_events_url":"https://api.github.com/users/josefs/received_events","type":"User","site_admin":false},"repo":{"id":108764455,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg3NjQ0NTU=","name":"Gradualizer","full_name":"josefs/Gradualizer","private":false,"owner":{"login":"josefs","id":152020,"node_id":"MDQ6VXNlcjE1MjAyMA==","avatar_url":"https://avatars0.githubusercontent.com/u/152020?v=4","gravatar_id":"","url":"https://api.github.com/users/josefs","html_url":"https://github.com/josefs","followers_url":"https://api.github.com/users/josefs/followers","following_url":"https://api.github.com/users/josefs/following{/other_user}","gists_url":"https://api.github.com/users/josefs/gists{/gist_id}","starred_url":"https://api.github.com/users/josefs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josefs/subscriptions","organizations_url":"https://api.github.com/users/josefs/orgs","repos_url":"https://api.github.com/users/josefs/repos","events_url":"https://api.github.com/users/josefs/events{/privacy}","received_events_url":"https://api.github.com/users/josefs/received_events","type":"User","site_admin":false},"html_url":"https://github.com/josefs/Gradualizer","description":null,"fork":false,"url":"https://api.github.com/repos/josefs/Gradualizer","forks_url":"https://api.github.com/repos/josefs/Gradualizer/forks","keys_url":"https://api.github.com/repos/josefs/Gradualizer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josefs/Gradualizer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josefs/Gradualizer/teams","hooks_url":"https://api.github.com/repos/josefs/Gradualizer/hooks","issue_events_url":"https://api.github.com/repos/josefs/Gradualizer/issues/events{/number}","events_url":"https://api.github.com/repos/josefs/Gradualizer/events","assignees_url":"https://api.github.com/repos/josefs/Gradualizer/assignees{/user}","branches_url":"https://api.github.com/repos/josefs/Gradualizer/branches{/branch}","tags_url":"https://api.github.com/repos/josefs/Gradualizer/tags","blobs_url":"https://api.github.com/repos/josefs/Gradualizer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josefs/Gradualizer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josefs/Gradualizer/git/refs{/sha}","trees_url":"https://api.github.com/repos/josefs/Gradualizer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josefs/Gradualizer/statuses/{sha}","languages_url":"https://api.github.com/repos/josefs/Gradualizer/languages","stargazers_url":"https://api.github.com/repos/josefs/Gradualizer/stargazers","contributors_url":"https://api.github.com/repos/josefs/Gradualizer/contributors","subscribers_url":"https://api.github.com/repos/josefs/Gradualizer/subscribers","subscription_url":"https://api.github.com/repos/josefs/Gradualizer/subscription","commits_url":"https://api.github.com/repos/josefs/Gradualizer/commits{/sha}","git_commits_url":"https://api.github.com/repos/josefs/Gradualizer/git/commits{/sha}","comments_url":"https://api.github.com/repos/josefs/Gradualizer/comments{/number}","issue_comment_url":"https://api.github.com/repos/josefs/Gradualizer/issues/comments{/number}","contents_url":"https://api.github.com/repos/josefs/Gradualizer/contents/{+path}","compare_url":"https://api.github.com/repos/josefs/Gradualizer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josefs/Gradualizer/merges","archive_url":"https://api.github.com/repos/josefs/Gradualizer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josefs/Gradualizer/downloads","issues_url":"https://api.github.com/repos/josefs/Gradualizer/issues{/number}","pulls_url":"https://api.github.com/repos/josefs/Gradualizer/pulls{/number}","milestones_url":"https://api.github.com/repos/josefs/Gradualizer/milestones{/number}","notifications_url":"https://api.github.com/repos/josefs/Gradualizer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josefs/Gradualizer/labels{/name}","releases_url":"https://api.github.com/repos/josefs/Gradualizer/releases{/id}","deployments_url":"https://api.github.com/repos/josefs/Gradualizer/deployments","created_at":"2017-10-29T19:30:20Z","updated_at":"2018-12-23T00:04:32Z","pushed_at":"2018-12-23T00:04:30Z","git_url":"git://github.com/josefs/Gradualizer.git","ssh_url":"git@github.com:josefs/Gradualizer.git","clone_url":"https://github.com/josefs/Gradualizer.git","svn_url":"https://github.com/josefs/Gradualizer","homepage":null,"size":642,"stargazers_count":143,"watchers_count":143,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":32,"watchers":143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/josefs/Gradualizer/pulls/112"},"html":{"href":"https://github.com/josefs/Gradualizer/pull/112"},"issue":{"href":"https://api.github.com/repos/josefs/Gradualizer/issues/112"},"comments":{"href":"https://api.github.com/repos/josefs/Gradualizer/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/josefs/Gradualizer/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/josefs/Gradualizer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/josefs/Gradualizer/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/josefs/Gradualizer/statuses/150b6962366bda6cae850a1e808de17983afa862"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Zalastax"}}