{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/19084","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/19084/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/19084/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/19084/events","html_url":"https://github.com/nodejs/node/pull/19084","id":301765886,"number":19084,"title":"benchmarks: fix benchmark for url","user":{"login":"daynin","id":825219,"avatar_url":"https://avatars0.githubusercontent.com/u/825219?v=4","gravatar_id":"","url":"https://api.github.com/users/daynin","html_url":"https://github.com/daynin","followers_url":"https://api.github.com/users/daynin/followers","following_url":"https://api.github.com/users/daynin/following{/other_user}","gists_url":"https://api.github.com/users/daynin/gists{/gist_id}","starred_url":"https://api.github.com/users/daynin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daynin/subscriptions","organizations_url":"https://api.github.com/users/daynin/orgs","repos_url":"https://api.github.com/users/daynin/repos","events_url":"https://api.github.com/users/daynin/events{/privacy}","received_events_url":"https://api.github.com/users/daynin/received_events","type":"User","site_admin":false},"labels":[{"id":191708559,"url":"https://api.github.com/repos/nodejs/node/labels/benchmark","name":"benchmark","color":"009800","default":false},{"id":155435992,"url":"https://api.github.com/repos/nodejs/node/labels/url","name":"url","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-02T13:28:03Z","updated_at":"2018-03-02T13:55:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/19084","html_url":"https://github.com/nodejs/node/pull/19084","diff_url":"https://github.com/nodejs/node/pull/19084.diff","patch_url":"https://github.com/nodejs/node/pull/19084.patch"},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\nIt fixes an error which occurs after running this test:\r\n\r\n```bash\r\nnode benchmark/url/url-searchparams-read.js\r\n```\r\n\r\nError:\r\n```                                \r\ninternal/url.js:983\r\n      throw new errors.TypeError('ERR_INVALID_THIS', 'URLSearchParams');\r\n      ^\r\n\r\nTypeError [ERR_INVALID_THIS]: Value of \"this\" must be of type URLSearchParams\r\n    at get (internal/url.js:983:13)\r\n    at main (/Users/daynin/Documents/projects/node/benchmark/url/url-searchparams-read.js:21:5)\r\n    at Benchmark.process.nextTick (/Users/daynin/Documents/projects/node/benchmark/common.js:34:28)\r\n    at _combinedTickCallback (internal/process/next_tick.js:131:7)\r\n    at process._tickCallback (internal/process/next_tick.js:180:9)\r\n    at Function.Module.runMain (module.js:678:11)\r\n    at startup (bootstrap_node.js:187:16)\r\n    at bootstrap_node.js:608:3\r\n```\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [ ] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nbenchmark"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/369926714","html_url":"https://github.com/nodejs/node/pull/19084#issuecomment-369926714","issue_url":"https://api.github.com/repos/nodejs/node/issues/19084","id":369926714,"user":{"login":"daynin","id":825219,"avatar_url":"https://avatars0.githubusercontent.com/u/825219?v=4","gravatar_id":"","url":"https://api.github.com/users/daynin","html_url":"https://github.com/daynin","followers_url":"https://api.github.com/users/daynin/followers","following_url":"https://api.github.com/users/daynin/following{/other_user}","gists_url":"https://api.github.com/users/daynin/gists{/gist_id}","starred_url":"https://api.github.com/users/daynin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daynin/subscriptions","organizations_url":"https://api.github.com/users/daynin/orgs","repos_url":"https://api.github.com/users/daynin/repos","events_url":"https://api.github.com/users/daynin/events{/privacy}","received_events_url":"https://api.github.com/users/daynin/received_events","type":"User","site_admin":false},"created_at":"2018-03-02T13:55:02Z","updated_at":"2018-03-02T13:55:02Z","author_association":"CONTRIBUTOR","body":"@BridgeAR tell me pls, how can I add a test for a benchmark?"}}
{"actor":{"display_login":"daynin"}}