{"action":"closed","number":6893,"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/6893","id":184926167,"html_url":"https://github.com/qgis/QGIS/pull/6893","diff_url":"https://github.com/qgis/QGIS/pull/6893.diff","patch_url":"https://github.com/qgis/QGIS/pull/6893.patch","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/6893","number":6893,"state":"closed","locked":false,"title":"[processing] add help and clarity to the define current projection algorithm","user":{"login":"nirvn","id":1728657,"avatar_url":"https://avatars0.githubusercontent.com/u/1728657?v=4","gravatar_id":"","url":"https://api.github.com/users/nirvn","html_url":"https://github.com/nirvn","followers_url":"https://api.github.com/users/nirvn/followers","following_url":"https://api.github.com/users/nirvn/following{/other_user}","gists_url":"https://api.github.com/users/nirvn/gists{/gist_id}","starred_url":"https://api.github.com/users/nirvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirvn/subscriptions","organizations_url":"https://api.github.com/users/nirvn/orgs","repos_url":"https://api.github.com/users/nirvn/repos","events_url":"https://api.github.com/users/nirvn/events{/privacy}","received_events_url":"https://api.github.com/users/nirvn/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis PR tries to clarify what the 'define current projection' algorithm really is about:\r\n- the algorithm is renamed to define _layer_ projection\r\n- the CRS parameter is renamed from 'Output CRS' to 'CRS' to better highlight fact that there is no output vector layer created\r\n- an help file is added to help users, and hint/warn that, for shapefiles, the .prj / .qpj files are going to be overwritten\r\n\r\nI've also changed the algorithm so it stops creating .prj and .qpj files for non-shapefile datasets.\r\n\r\n@nyalldawson , hope this helps taking care of confusions around this algorithm.\r\n\r\n## Checklist\r\n\r\n> Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.\r\n\r\n- [ ] Commit messages are descriptive and explain the rationale for changes\r\n- [ ] Commits which fix bugs include `fixes #11111` in the commit message next to the description\r\n- [ ] Commits which add new features are tagged with `[FEATURE]` in the commit message\r\n- [ ] Commits which change the UI or existing user workflows are tagged with `[needs-docs]` in the commit message and containt sufficient information in the commit message to be documented\r\n- [ ] I have read the [QGIS Coding Standards](https://docs.qgis.org/testing/en/docs/developers_guide/codingstandards.html) and this PR complies with them\r\n- [ ] This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)\r\n- [ ] New unit tests have been added for core changes\r\n- [ ] I have run [the `scripts/prepare-commit.sh` script](https://github.com/qgis/QGIS/blob/master/.github/CONTRIBUTE.md#contributing-to-qgis) before each commit\r\n","created_at":"2018-04-30T10:45:34Z","updated_at":"2018-05-01T03:14:09Z","closed_at":"2018-05-01T03:14:09Z","merged_at":"2018-05-01T03:14:09Z","merge_commit_sha":"39c6e23c08b4c993e0baf2787b565e85456bc26c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/qgis/QGIS/pulls/6893/commits","review_comments_url":"https://api.github.com/repos/qgis/QGIS/pulls/6893/comments","review_comment_url":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/6893/comments","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/627898233c8e71a9e0694e2ea4073f6bd73c30ec","head":{"label":"nirvn:processing_modeler_svg","ref":"processing_modeler_svg","sha":"627898233c8e71a9e0694e2ea4073f6bd73c30ec","user":{"login":"nirvn","id":1728657,"avatar_url":"https://avatars0.githubusercontent.com/u/1728657?v=4","gravatar_id":"","url":"https://api.github.com/users/nirvn","html_url":"https://github.com/nirvn","followers_url":"https://api.github.com/users/nirvn/followers","following_url":"https://api.github.com/users/nirvn/following{/other_user}","gists_url":"https://api.github.com/users/nirvn/gists{/gist_id}","starred_url":"https://api.github.com/users/nirvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirvn/subscriptions","organizations_url":"https://api.github.com/users/nirvn/orgs","repos_url":"https://api.github.com/users/nirvn/repos","events_url":"https://api.github.com/users/nirvn/events{/privacy}","received_events_url":"https://api.github.com/users/nirvn/received_events","type":"User","site_admin":false},"repo":{"id":16859880,"name":"QGIS","full_name":"nirvn/QGIS","owner":{"login":"nirvn","id":1728657,"avatar_url":"https://avatars0.githubusercontent.com/u/1728657?v=4","gravatar_id":"","url":"https://api.github.com/users/nirvn","html_url":"https://github.com/nirvn","followers_url":"https://api.github.com/users/nirvn/followers","following_url":"https://api.github.com/users/nirvn/following{/other_user}","gists_url":"https://api.github.com/users/nirvn/gists{/gist_id}","starred_url":"https://api.github.com/users/nirvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirvn/subscriptions","organizations_url":"https://api.github.com/users/nirvn/orgs","repos_url":"https://api.github.com/users/nirvn/repos","events_url":"https://api.github.com/users/nirvn/events{/privacy}","received_events_url":"https://api.github.com/users/nirvn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nirvn/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/nirvn/QGIS","forks_url":"https://api.github.com/repos/nirvn/QGIS/forks","keys_url":"https://api.github.com/repos/nirvn/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nirvn/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nirvn/QGIS/teams","hooks_url":"https://api.github.com/repos/nirvn/QGIS/hooks","issue_events_url":"https://api.github.com/repos/nirvn/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/nirvn/QGIS/events","assignees_url":"https://api.github.com/repos/nirvn/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/nirvn/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/nirvn/QGIS/tags","blobs_url":"https://api.github.com/repos/nirvn/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nirvn/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nirvn/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/nirvn/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nirvn/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/nirvn/QGIS/languages","stargazers_url":"https://api.github.com/repos/nirvn/QGIS/stargazers","contributors_url":"https://api.github.com/repos/nirvn/QGIS/contributors","subscribers_url":"https://api.github.com/repos/nirvn/QGIS/subscribers","subscription_url":"https://api.github.com/repos/nirvn/QGIS/subscription","commits_url":"https://api.github.com/repos/nirvn/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/nirvn/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/nirvn/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/nirvn/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/nirvn/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/nirvn/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nirvn/QGIS/merges","archive_url":"https://api.github.com/repos/nirvn/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nirvn/QGIS/downloads","issues_url":"https://api.github.com/repos/nirvn/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/nirvn/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/nirvn/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/nirvn/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nirvn/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/nirvn/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/nirvn/QGIS/deployments","created_at":"2014-02-15T09:27:56Z","updated_at":"2017-11-23T05:15:52Z","pushed_at":"2018-05-01T02:50:09Z","git_url":"git://github.com/nirvn/QGIS.git","ssh_url":"git@github.com:nirvn/QGIS.git","clone_url":"https://github.com/nirvn/QGIS.git","svn_url":"https://github.com/nirvn/QGIS","homepage":"http://qgis.org","size":1294594,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qgis:master","ref":"master","sha":"3228654e5bf99523c273b2e2cb10f66eb0d70bd8","user":{"login":"qgis","id":483444,"avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"repo":{"id":1690480,"name":"QGIS","full_name":"qgis/QGIS","owner":{"login":"qgis","id":483444,"avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qgis/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":false,"url":"https://api.github.com/repos/qgis/QGIS","forks_url":"https://api.github.com/repos/qgis/QGIS/forks","keys_url":"https://api.github.com/repos/qgis/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgis/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgis/QGIS/teams","hooks_url":"https://api.github.com/repos/qgis/QGIS/hooks","issue_events_url":"https://api.github.com/repos/qgis/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/qgis/QGIS/events","assignees_url":"https://api.github.com/repos/qgis/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/qgis/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/qgis/QGIS/tags","blobs_url":"https://api.github.com/repos/qgis/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgis/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgis/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgis/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/qgis/QGIS/languages","stargazers_url":"https://api.github.com/repos/qgis/QGIS/stargazers","contributors_url":"https://api.github.com/repos/qgis/QGIS/contributors","subscribers_url":"https://api.github.com/repos/qgis/QGIS/subscribers","subscription_url":"https://api.github.com/repos/qgis/QGIS/subscription","commits_url":"https://api.github.com/repos/qgis/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgis/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgis/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgis/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgis/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/qgis/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgis/QGIS/merges","archive_url":"https://api.github.com/repos/qgis/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgis/QGIS/downloads","issues_url":"https://api.github.com/repos/qgis/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/qgis/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/qgis/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/qgis/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgis/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/qgis/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/qgis/QGIS/deployments","created_at":"2011-05-02T08:06:26Z","updated_at":"2018-05-01T01:31:06Z","pushed_at":"2018-05-01T03:14:09Z","git_url":"git://github.com/qgis/QGIS.git","ssh_url":"git@github.com:qgis/QGIS.git","clone_url":"https://github.com/qgis/QGIS.git","svn_url":"https://github.com/qgis/QGIS","homepage":"http://qgis.org","size":1412664,"stargazers_count":1985,"watchers_count":1985,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1236,"mirror_url":null,"archived":false,"open_issues_count":137,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1236,"open_issues":137,"watchers":1985,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/6893"},"html":{"href":"https://github.com/qgis/QGIS/pull/6893"},"issue":{"href":"https://api.github.com/repos/qgis/QGIS/issues/6893"},"comments":{"href":"https://api.github.com/repos/qgis/QGIS/issues/6893/comments"},"review_comments":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/6893/comments"},"review_comment":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/6893/commits"},"statuses":{"href":"https://api.github.com/repos/qgis/QGIS/statuses/627898233c8e71a9e0694e2ea4073f6bd73c30ec"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"nirvn","id":1728657,"avatar_url":"https://avatars0.githubusercontent.com/u/1728657?v=4","gravatar_id":"","url":"https://api.github.com/users/nirvn","html_url":"https://github.com/nirvn","followers_url":"https://api.github.com/users/nirvn/followers","following_url":"https://api.github.com/users/nirvn/following{/other_user}","gists_url":"https://api.github.com/users/nirvn/gists{/gist_id}","starred_url":"https://api.github.com/users/nirvn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirvn/subscriptions","organizations_url":"https://api.github.com/users/nirvn/orgs","repos_url":"https://api.github.com/users/nirvn/repos","events_url":"https://api.github.com/users/nirvn/events{/privacy}","received_events_url":"https://api.github.com/users/nirvn/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":17,"deletions":9,"changed_files":2}}
{"actor":{"display_login":"nirvn"}}