{"action":"created","comment":{"url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/comments/224596847","pull_request_review_id":164005638,"id":224596847,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDU5Njg0Nw==","diff_hunk":"@@ -54,7 +54,12 @@ public virtual Task<IEnumerable<TEntity>> GetAsync(Query<TEntity> query)\n \n             entities = ApplyFilters(entities, query);\n             entities = ApplyOrderBys(entities, query);\n-            entities = ApplyPage(entities, query);\n+\n+            if (query.Page != Page.Unlimited)\n+            {\n+                entities = ApplyPage(entities, query);\n+            }\n+","path":"Infra/RDD.Infra/Storage/ReadOnlyRepository.cs","position":10,"original_position":10,"commit_id":"26b3984a8a4bc5ca426d7c18dd3e8739455250ea","original_commit_id":"74cded41712457e8c1c343695d0291a22d59727c","user":{"login":"rducom","id":5228175,"node_id":"MDQ6VXNlcjUyMjgxNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/5228175?v=4","gravatar_id":"","url":"https://api.github.com/users/rducom","html_url":"https://github.com/rducom","followers_url":"https://api.github.com/users/rducom/followers","following_url":"https://api.github.com/users/rducom/following{/other_user}","gists_url":"https://api.github.com/users/rducom/gists{/gist_id}","starred_url":"https://api.github.com/users/rducom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rducom/subscriptions","organizations_url":"https://api.github.com/users/rducom/orgs","repos_url":"https://api.github.com/users/rducom/repos","events_url":"https://api.github.com/users/rducom/events{/privacy}","received_events_url":"https://api.github.com/users/rducom/received_events","type":"User","site_admin":false},"body":"J'y ai pensé, mais la méthode est virtuelle, elle peut donc être overridée. Et je me dit que on doit garantir le comportement du Page.Unlimited même en cas d'override.","created_at":"2018-10-11T20:40:41Z","updated_at":"2018-10-11T20:40:41Z","html_url":"https://github.com/LuccaSA/RestDrivenDomain/pull/217#discussion_r224596847","pull_request_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/217","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/comments/224596847"},"html":{"href":"https://github.com/LuccaSA/RestDrivenDomain/pull/217#discussion_r224596847"},"pull_request":{"href":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/217"}},"in_reply_to_id":224578544},"pull_request":{"url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/217","id":222238364,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjM4MzY0","html_url":"https://github.com/LuccaSA/RestDrivenDomain/pull/217","diff_url":"https://github.com/LuccaSA/RestDrivenDomain/pull/217.diff","patch_url":"https://github.com/LuccaSA/RestDrivenDomain/pull/217.patch","issue_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/issues/217","number":217,"state":"open","locked":false,"title":"Introduce Paging setting from RddOptions","user":{"login":"rducom","id":5228175,"node_id":"MDQ6VXNlcjUyMjgxNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/5228175?v=4","gravatar_id":"","url":"https://api.github.com/users/rducom","html_url":"https://github.com/rducom","followers_url":"https://api.github.com/users/rducom/followers","following_url":"https://api.github.com/users/rducom/following{/other_user}","gists_url":"https://api.github.com/users/rducom/gists{/gist_id}","starred_url":"https://api.github.com/users/rducom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rducom/subscriptions","organizations_url":"https://api.github.com/users/rducom/orgs","repos_url":"https://api.github.com/users/rducom/repos","events_url":"https://api.github.com/users/rducom/events{/privacy}","received_events_url":"https://api.github.com/users/rducom/received_events","type":"User","site_admin":false},"body":"- Suppression de `WebQuery` et `WebPage` qui n'apporte pour l'instant aucune valeur ajoutée. Nous pourront les ré-introduire plus tard si nous trouvons des choses à lui faire porter. Mais pour l'instant, ça ne fait que complexifier le code, je me permet donc de proposer leur suppression.\r\n- Introduction des settings de `Paging` sur `RddOption`\r\n- Génération des `Query` web en utilisant les settings de `RddOption`\r\n- Page deviens immutable pour empêcher toute modification de `Page.Unlimited` et tout effet de bord implicite lors des manipulations","created_at":"2018-10-11T18:37:17Z","updated_at":"2018-10-11T20:40:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6d0b54e7220e745722ca34b62410b584b2c3618","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Poltuu","id":2751539,"node_id":"MDQ6VXNlcjI3NTE1Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2751539?v=4","gravatar_id":"","url":"https://api.github.com/users/Poltuu","html_url":"https://github.com/Poltuu","followers_url":"https://api.github.com/users/Poltuu/followers","following_url":"https://api.github.com/users/Poltuu/following{/other_user}","gists_url":"https://api.github.com/users/Poltuu/gists{/gist_id}","starred_url":"https://api.github.com/users/Poltuu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Poltuu/subscriptions","organizations_url":"https://api.github.com/users/Poltuu/orgs","repos_url":"https://api.github.com/users/Poltuu/repos","events_url":"https://api.github.com/users/Poltuu/events{/privacy}","received_events_url":"https://api.github.com/users/Poltuu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/217/commits","review_comments_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/217/comments","review_comment_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/issues/217/comments","statuses_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/statuses/26b3984a8a4bc5ca426d7c18dd3e8739455250ea","head":{"label":"LuccaSA:Paging.RddOptions","ref":"Paging.RddOptions","sha":"26b3984a8a4bc5ca426d7c18dd3e8739455250ea","user":{"login":"LuccaSA","id":2686158,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODYxNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2686158?v=4","gravatar_id":"","url":"https://api.github.com/users/LuccaSA","html_url":"https://github.com/LuccaSA","followers_url":"https://api.github.com/users/LuccaSA/followers","following_url":"https://api.github.com/users/LuccaSA/following{/other_user}","gists_url":"https://api.github.com/users/LuccaSA/gists{/gist_id}","starred_url":"https://api.github.com/users/LuccaSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuccaSA/subscriptions","organizations_url":"https://api.github.com/users/LuccaSA/orgs","repos_url":"https://api.github.com/users/LuccaSA/repos","events_url":"https://api.github.com/users/LuccaSA/events{/privacy}","received_events_url":"https://api.github.com/users/LuccaSA/received_events","type":"Organization","site_admin":false},"repo":{"id":34167748,"node_id":"MDEwOlJlcG9zaXRvcnkzNDE2Nzc0OA==","name":"RestDrivenDomain","full_name":"LuccaSA/RestDrivenDomain","private":false,"owner":{"login":"LuccaSA","id":2686158,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODYxNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2686158?v=4","gravatar_id":"","url":"https://api.github.com/users/LuccaSA","html_url":"https://github.com/LuccaSA","followers_url":"https://api.github.com/users/LuccaSA/followers","following_url":"https://api.github.com/users/LuccaSA/following{/other_user}","gists_url":"https://api.github.com/users/LuccaSA/gists{/gist_id}","starred_url":"https://api.github.com/users/LuccaSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuccaSA/subscriptions","organizations_url":"https://api.github.com/users/LuccaSA/orgs","repos_url":"https://api.github.com/users/LuccaSA/repos","events_url":"https://api.github.com/users/LuccaSA/events{/privacy}","received_events_url":"https://api.github.com/users/LuccaSA/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LuccaSA/RestDrivenDomain","description":null,"fork":false,"url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain","forks_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/forks","keys_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/teams","hooks_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/hooks","issue_events_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/issues/events{/number}","events_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/events","assignees_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/assignees{/user}","branches_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/branches{/branch}","tags_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/tags","blobs_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/git/refs{/sha}","trees_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/statuses/{sha}","languages_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/languages","stargazers_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/stargazers","contributors_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/contributors","subscribers_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/subscribers","subscription_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/subscription","commits_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/commits{/sha}","git_commits_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/git/commits{/sha}","comments_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/comments{/number}","issue_comment_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/issues/comments{/number}","contents_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/contents/{+path}","compare_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/merges","archive_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/downloads","issues_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/issues{/number}","pulls_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls{/number}","milestones_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/milestones{/number}","notifications_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/labels{/name}","releases_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/releases{/id}","deployments_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/deployments","created_at":"2015-04-18T13:56:51Z","updated_at":"2018-10-11T11:44:21Z","pushed_at":"2018-10-11T20:37:31Z","git_url":"git://github.com/LuccaSA/RestDrivenDomain.git","ssh_url":"git@github.com:LuccaSA/RestDrivenDomain.git","clone_url":"https://github.com/LuccaSA/RestDrivenDomain.git","svn_url":"https://github.com/LuccaSA/RestDrivenDomain","homepage":"http://www.restdrivendomain.fr/","size":1433,"stargazers_count":4,"watchers_count":4,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":57,"license":null,"forks":2,"open_issues":57,"watchers":4,"default_branch":"master"}},"base":{"label":"LuccaSA:addrdd_ref.config","ref":"addrdd_ref.config","sha":"c044a2436ee5e7f4d2ebf16a7fc5f3e5aeed3237","user":{"login":"LuccaSA","id":2686158,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODYxNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2686158?v=4","gravatar_id":"","url":"https://api.github.com/users/LuccaSA","html_url":"https://github.com/LuccaSA","followers_url":"https://api.github.com/users/LuccaSA/followers","following_url":"https://api.github.com/users/LuccaSA/following{/other_user}","gists_url":"https://api.github.com/users/LuccaSA/gists{/gist_id}","starred_url":"https://api.github.com/users/LuccaSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuccaSA/subscriptions","organizations_url":"https://api.github.com/users/LuccaSA/orgs","repos_url":"https://api.github.com/users/LuccaSA/repos","events_url":"https://api.github.com/users/LuccaSA/events{/privacy}","received_events_url":"https://api.github.com/users/LuccaSA/received_events","type":"Organization","site_admin":false},"repo":{"id":34167748,"node_id":"MDEwOlJlcG9zaXRvcnkzNDE2Nzc0OA==","name":"RestDrivenDomain","full_name":"LuccaSA/RestDrivenDomain","private":false,"owner":{"login":"LuccaSA","id":2686158,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODYxNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2686158?v=4","gravatar_id":"","url":"https://api.github.com/users/LuccaSA","html_url":"https://github.com/LuccaSA","followers_url":"https://api.github.com/users/LuccaSA/followers","following_url":"https://api.github.com/users/LuccaSA/following{/other_user}","gists_url":"https://api.github.com/users/LuccaSA/gists{/gist_id}","starred_url":"https://api.github.com/users/LuccaSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuccaSA/subscriptions","organizations_url":"https://api.github.com/users/LuccaSA/orgs","repos_url":"https://api.github.com/users/LuccaSA/repos","events_url":"https://api.github.com/users/LuccaSA/events{/privacy}","received_events_url":"https://api.github.com/users/LuccaSA/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LuccaSA/RestDrivenDomain","description":null,"fork":false,"url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain","forks_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/forks","keys_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/teams","hooks_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/hooks","issue_events_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/issues/events{/number}","events_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/events","assignees_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/assignees{/user}","branches_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/branches{/branch}","tags_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/tags","blobs_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/git/refs{/sha}","trees_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/statuses/{sha}","languages_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/languages","stargazers_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/stargazers","contributors_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/contributors","subscribers_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/subscribers","subscription_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/subscription","commits_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/commits{/sha}","git_commits_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/git/commits{/sha}","comments_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/comments{/number}","issue_comment_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/issues/comments{/number}","contents_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/contents/{+path}","compare_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/merges","archive_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/downloads","issues_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/issues{/number}","pulls_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls{/number}","milestones_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/milestones{/number}","notifications_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/labels{/name}","releases_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/releases{/id}","deployments_url":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/deployments","created_at":"2015-04-18T13:56:51Z","updated_at":"2018-10-11T11:44:21Z","pushed_at":"2018-10-11T20:37:31Z","git_url":"git://github.com/LuccaSA/RestDrivenDomain.git","ssh_url":"git@github.com:LuccaSA/RestDrivenDomain.git","clone_url":"https://github.com/LuccaSA/RestDrivenDomain.git","svn_url":"https://github.com/LuccaSA/RestDrivenDomain","homepage":"http://www.restdrivendomain.fr/","size":1433,"stargazers_count":4,"watchers_count":4,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":57,"license":null,"forks":2,"open_issues":57,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/217"},"html":{"href":"https://github.com/LuccaSA/RestDrivenDomain/pull/217"},"issue":{"href":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/issues/217"},"comments":{"href":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/LuccaSA/RestDrivenDomain/statuses/26b3984a8a4bc5ca426d7c18dd3e8739455250ea"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rducom"}}