{"action":"created","comment":{"url":"https://api.github.com/repos/rook/rook/pulls/comments/237982647","pull_request_review_id":180423415,"id":237982647,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzk4MjY0Nw==","diff_hunk":"@@ -49,9 +49,10 @@ func (c *Cluster) makeDeployment(mgrConfig *mgrConfig, port int) *extensions.Dep\n \t\t\tContainers: []v1.Container{\n \t\t\t\tc.makeMgrDaemonContainer(mgrConfig, port),\n \t\t\t},\n-\t\t\tRestartPolicy: v1.RestartPolicyAlways,\n-\t\t\tVolumes:       opspec.PodVolumes(\"\"),\n-\t\t\tHostNetwork:   c.HostNetwork,\n+\t\t\tServiceAccountName: \"rook-ceph-mgr\",","path":"pkg/operator/ceph/cluster/mgr/spec.go","position":7,"original_position":7,"commit_id":"ba63145edb3e7827106e357b1b800ab5805c35db","original_commit_id":"ba63145edb3e7827106e357b1b800ab5805c35db","user":{"login":"galexrt","id":3718398,"node_id":"MDQ6VXNlcjM3MTgzOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/3718398?v=4","gravatar_id":"","url":"https://api.github.com/users/galexrt","html_url":"https://github.com/galexrt","followers_url":"https://api.github.com/users/galexrt/followers","following_url":"https://api.github.com/users/galexrt/following{/other_user}","gists_url":"https://api.github.com/users/galexrt/gists{/gist_id}","starred_url":"https://api.github.com/users/galexrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galexrt/subscriptions","organizations_url":"https://api.github.com/users/galexrt/orgs","repos_url":"https://api.github.com/users/galexrt/repos","events_url":"https://api.github.com/users/galexrt/events{/privacy}","received_events_url":"https://api.github.com/users/galexrt/received_events","type":"User","site_admin":false},"body":"How about moving this name to a constant even though it is currently \"only\" used here and in tests?","created_at":"2018-11-30T19:50:49Z","updated_at":"2018-11-30T19:53:03Z","html_url":"https://github.com/rook/rook/pull/2001#discussion_r237982647","pull_request_url":"https://api.github.com/repos/rook/rook/pulls/2001","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rook/rook/pulls/comments/237982647"},"html":{"href":"https://github.com/rook/rook/pull/2001#discussion_r237982647"},"pull_request":{"href":"https://api.github.com/repos/rook/rook/pulls/2001"}}},"pull_request":{"url":"https://api.github.com/repos/rook/rook/pulls/2001","id":206673301,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NjczMzAx","html_url":"https://github.com/rook/rook/pull/2001","diff_url":"https://github.com/rook/rook/pull/2001.diff","patch_url":"https://github.com/rook/rook/pull/2001.patch","issue_url":"https://api.github.com/repos/rook/rook/issues/2001","number":2001,"state":"open","locked":false,"title":"Set service account on ceph-mgr pod","user":{"login":"jcsp","id":944640,"node_id":"MDQ6VXNlcjk0NDY0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/944640?v=4","gravatar_id":"","url":"https://api.github.com/users/jcsp","html_url":"https://github.com/jcsp","followers_url":"https://api.github.com/users/jcsp/followers","following_url":"https://api.github.com/users/jcsp/following{/other_user}","gists_url":"https://api.github.com/users/jcsp/gists{/gist_id}","starred_url":"https://api.github.com/users/jcsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcsp/subscriptions","organizations_url":"https://api.github.com/users/jcsp/orgs","repos_url":"https://api.github.com/users/jcsp/repos","events_url":"https://api.github.com/users/jcsp/events{/privacy}","received_events_url":"https://api.github.com/users/jcsp/received_events","type":"User","site_admin":false},"body":"This is to enable the `rook` ceph-mgr module to drive\r\nthe Rook and k8s APIs, exposing functionality via\r\nits own CLI and GUI.\r\n\r\nFor the moment this uses an externally populated\r\nServiceAccount: we'll probably want to auto-create\r\nthis with clusters.\r\n\r\nSigned-off-by: John Spray <john.spray@redhat.com>\r\n\r\nSee design doc: https://github.com/rook/rook/issues/1868\r\n\r\n**Checklist:**\r\n- [ ] Documentation has been updated, if necessary.\r\n- [ ] Pending release notes updated with breaking and/or notable changes, if necessary.\r\n- [ ] Upgrade from previous release is tested and upgrade user guide is updated, if necessary.\r\n- [x] Code generation (`make codegen`) has been run to update object specifications, if necessary.\r\n- [ ] `make vendor` does not cause changes.\r\n","created_at":"2018-08-07T11:57:38Z","updated_at":"2018-11-30T19:53:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e4adaa0c89c1fe60787e75e4f21b28bda5637d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":479456042,"node_id":"MDU6TGFiZWw0Nzk0NTYwNDI=","url":"https://api.github.com/repos/rook/rook/labels/ceph","name":"ceph","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rook/rook/pulls/2001/commits","review_comments_url":"https://api.github.com/repos/rook/rook/pulls/2001/comments","review_comment_url":"https://api.github.com/repos/rook/rook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rook/rook/issues/2001/comments","statuses_url":"https://api.github.com/repos/rook/rook/statuses/ba63145edb3e7827106e357b1b800ab5805c35db","head":{"label":"jcsp:wip-mgr-rbac","ref":"wip-mgr-rbac","sha":"ba63145edb3e7827106e357b1b800ab5805c35db","user":{"login":"jcsp","id":944640,"node_id":"MDQ6VXNlcjk0NDY0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/944640?v=4","gravatar_id":"","url":"https://api.github.com/users/jcsp","html_url":"https://github.com/jcsp","followers_url":"https://api.github.com/users/jcsp/followers","following_url":"https://api.github.com/users/jcsp/following{/other_user}","gists_url":"https://api.github.com/users/jcsp/gists{/gist_id}","starred_url":"https://api.github.com/users/jcsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcsp/subscriptions","organizations_url":"https://api.github.com/users/jcsp/orgs","repos_url":"https://api.github.com/users/jcsp/repos","events_url":"https://api.github.com/users/jcsp/events{/privacy}","received_events_url":"https://api.github.com/users/jcsp/received_events","type":"User","site_admin":false},"repo":{"id":120337675,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAzMzc2NzU=","name":"rook","full_name":"jcsp/rook","private":false,"owner":{"login":"jcsp","id":944640,"node_id":"MDQ6VXNlcjk0NDY0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/944640?v=4","gravatar_id":"","url":"https://api.github.com/users/jcsp","html_url":"https://github.com/jcsp","followers_url":"https://api.github.com/users/jcsp/followers","following_url":"https://api.github.com/users/jcsp/following{/other_user}","gists_url":"https://api.github.com/users/jcsp/gists{/gist_id}","starred_url":"https://api.github.com/users/jcsp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcsp/subscriptions","organizations_url":"https://api.github.com/users/jcsp/orgs","repos_url":"https://api.github.com/users/jcsp/repos","events_url":"https://api.github.com/users/jcsp/events{/privacy}","received_events_url":"https://api.github.com/users/jcsp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jcsp/rook","description":"File, Block, and Object Storage Services for your Cloud-Native Environment","fork":true,"url":"https://api.github.com/repos/jcsp/rook","forks_url":"https://api.github.com/repos/jcsp/rook/forks","keys_url":"https://api.github.com/repos/jcsp/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcsp/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcsp/rook/teams","hooks_url":"https://api.github.com/repos/jcsp/rook/hooks","issue_events_url":"https://api.github.com/repos/jcsp/rook/issues/events{/number}","events_url":"https://api.github.com/repos/jcsp/rook/events","assignees_url":"https://api.github.com/repos/jcsp/rook/assignees{/user}","branches_url":"https://api.github.com/repos/jcsp/rook/branches{/branch}","tags_url":"https://api.github.com/repos/jcsp/rook/tags","blobs_url":"https://api.github.com/repos/jcsp/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcsp/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcsp/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcsp/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcsp/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/jcsp/rook/languages","stargazers_url":"https://api.github.com/repos/jcsp/rook/stargazers","contributors_url":"https://api.github.com/repos/jcsp/rook/contributors","subscribers_url":"https://api.github.com/repos/jcsp/rook/subscribers","subscription_url":"https://api.github.com/repos/jcsp/rook/subscription","commits_url":"https://api.github.com/repos/jcsp/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcsp/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcsp/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcsp/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcsp/rook/contents/{+path}","compare_url":"https://api.github.com/repos/jcsp/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcsp/rook/merges","archive_url":"https://api.github.com/repos/jcsp/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcsp/rook/downloads","issues_url":"https://api.github.com/repos/jcsp/rook/issues{/number}","pulls_url":"https://api.github.com/repos/jcsp/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/jcsp/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/jcsp/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcsp/rook/labels{/name}","releases_url":"https://api.github.com/repos/jcsp/rook/releases{/id}","deployments_url":"https://api.github.com/repos/jcsp/rook/deployments","created_at":"2018-02-05T17:25:29Z","updated_at":"2018-07-11T15:12:33Z","pushed_at":"2018-11-30T17:55:38Z","git_url":"git://github.com/jcsp/rook.git","ssh_url":"git@github.com:jcsp/rook.git","clone_url":"https://github.com/jcsp/rook.git","svn_url":"https://github.com/jcsp/rook","homepage":"https://rook.io","size":6986,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"rook:master","ref":"master","sha":"9654e51db1ada6aecaa6764b05bb85413d9a8bde","user":{"login":"rook","id":22860722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODYwNzIy","avatar_url":"https://avatars1.githubusercontent.com/u/22860722?v=4","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"repo":{"id":62921553,"node_id":"MDEwOlJlcG9zaXRvcnk2MjkyMTU1Mw==","name":"rook","full_name":"rook/rook","private":false,"owner":{"login":"rook","id":22860722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODYwNzIy","avatar_url":"https://avatars1.githubusercontent.com/u/22860722?v=4","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rook/rook","description":"Storage Orchestration for Kubernetes","fork":false,"url":"https://api.github.com/repos/rook/rook","forks_url":"https://api.github.com/repos/rook/rook/forks","keys_url":"https://api.github.com/repos/rook/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rook/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rook/rook/teams","hooks_url":"https://api.github.com/repos/rook/rook/hooks","issue_events_url":"https://api.github.com/repos/rook/rook/issues/events{/number}","events_url":"https://api.github.com/repos/rook/rook/events","assignees_url":"https://api.github.com/repos/rook/rook/assignees{/user}","branches_url":"https://api.github.com/repos/rook/rook/branches{/branch}","tags_url":"https://api.github.com/repos/rook/rook/tags","blobs_url":"https://api.github.com/repos/rook/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rook/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rook/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/rook/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rook/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/rook/rook/languages","stargazers_url":"https://api.github.com/repos/rook/rook/stargazers","contributors_url":"https://api.github.com/repos/rook/rook/contributors","subscribers_url":"https://api.github.com/repos/rook/rook/subscribers","subscription_url":"https://api.github.com/repos/rook/rook/subscription","commits_url":"https://api.github.com/repos/rook/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/rook/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/rook/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/rook/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/rook/rook/contents/{+path}","compare_url":"https://api.github.com/repos/rook/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rook/rook/merges","archive_url":"https://api.github.com/repos/rook/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rook/rook/downloads","issues_url":"https://api.github.com/repos/rook/rook/issues{/number}","pulls_url":"https://api.github.com/repos/rook/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/rook/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/rook/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rook/rook/labels{/name}","releases_url":"https://api.github.com/repos/rook/rook/releases{/id}","deployments_url":"https://api.github.com/repos/rook/rook/deployments","created_at":"2016-07-08T22:45:05Z","updated_at":"2018-11-30T15:54:51Z","pushed_at":"2018-11-30T19:00:36Z","git_url":"git://github.com/rook/rook.git","ssh_url":"git@github.com:rook/rook.git","clone_url":"https://github.com/rook/rook.git","svn_url":"https://github.com/rook/rook","homepage":"https://rook.io","size":7031,"stargazers_count":3828,"watchers_count":3828,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":507,"mirror_url":null,"archived":false,"open_issues_count":188,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":507,"open_issues":188,"watchers":3828,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rook/rook/pulls/2001"},"html":{"href":"https://github.com/rook/rook/pull/2001"},"issue":{"href":"https://api.github.com/repos/rook/rook/issues/2001"},"comments":{"href":"https://api.github.com/repos/rook/rook/issues/2001/comments"},"review_comments":{"href":"https://api.github.com/repos/rook/rook/pulls/2001/comments"},"review_comment":{"href":"https://api.github.com/repos/rook/rook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rook/rook/pulls/2001/commits"},"statuses":{"href":"https://api.github.com/repos/rook/rook/statuses/ba63145edb3e7827106e357b1b800ab5805c35db"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"galexrt"}}