{"action":"created","comment":{"url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/comments/176473578","pull_request_review_id":106182593,"id":176473578,"diff_hunk":"@@ -287,29 +287,6 @@ public String defineNodeSource(final String sessionId, final String nodeSourceNa\n                                                                                              nodesRecoverable));\n     }\n \n-    /*\n-     * (non-Javadoc)\n-     * \n-     * @see\n-     * org.ow2.proactive_grid_cloud_portal.rm.client.RMService#createNodeSource(java.lang.String,\n-     * java.lang.String, java.lang.String, java.lang.String[], java.lang.String[], java.lang.String,\n-     * java.lang.String[], java.lang.String[])\n-     */\n-    public String createNodeSource(final String sessionId, final String nodeSourceName, final String infrastructureType,\n-            final String[] infrastructureParameters, final String[] infrastructureFileParameters,\n-            final String policyType, final String[] policyParameters, final String[] policyFileParameters,\n-            final String nodesRecoverable) throws RestServerException, ServiceException {\n-        return executeFunctionReturnStreamAsString(restClient -> restClient.createnodeSource(sessionId,\n-                                                                                             nodeSourceName,\n-                                                                                             infrastructureType,\n-                                                                                             infrastructureParameters,\n-                                                                                             infrastructureFileParameters,\n-                                                                                             policyType,\n-                                                                                             policyParameters,\n-                                                                                             policyFileParameters,\n-                                                                                             nodesRecoverable));\n-    }\n-\n     @Override\n     public String deployNodeSource(final String sessionId, final String nodeSourceName)\n             throws RestServerException, ServiceException {","path":"rm-portal/src/main/java/org/ow2/proactive_grid_cloud_portal/rm/server/RMServiceImpl.java","position":29,"original_position":29,"commit_id":"58e12321a17080086816aa7b6f9dafae37821839","original_commit_id":"58e12321a17080086816aa7b6f9dafae37821839","user":{"login":"sonarqube-activeeon","id":14940028,"avatar_url":"https://avatars1.githubusercontent.com/u/14940028?v=4","gravatar_id":"","url":"https://api.github.com/users/sonarqube-activeeon","html_url":"https://github.com/sonarqube-activeeon","followers_url":"https://api.github.com/users/sonarqube-activeeon/followers","following_url":"https://api.github.com/users/sonarqube-activeeon/following{/other_user}","gists_url":"https://api.github.com/users/sonarqube-activeeon/gists{/gist_id}","starred_url":"https://api.github.com/users/sonarqube-activeeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonarqube-activeeon/subscriptions","organizations_url":"https://api.github.com/users/sonarqube-activeeon/orgs","repos_url":"https://api.github.com/users/sonarqube-activeeon/repos","events_url":"https://api.github.com/users/sonarqube-activeeon/events{/privacy}","received_events_url":"https://api.github.com/users/sonarqube-activeeon/received_events","type":"User","site_admin":false},"body":"![MINOR](https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR') Remove the redundant '!unknownSymbol!' thrown exception declaration(s). [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3ARedundantThrowsDeclarationCheck)\n","created_at":"2018-03-22T15:53:04Z","updated_at":"2018-03-22T15:53:04Z","html_url":"https://github.com/ow2-proactive/scheduling-portal/pull/431#discussion_r176473578","pull_request_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/431","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/comments/176473578"},"html":{"href":"https://github.com/ow2-proactive/scheduling-portal/pull/431#discussion_r176473578"},"pull_request":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/431"}}},"pull_request":{"url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/431","id":176794799,"html_url":"https://github.com/ow2-proactive/scheduling-portal/pull/431","diff_url":"https://github.com/ow2-proactive/scheduling-portal/pull/431.diff","patch_url":"https://github.com/ow2-proactive/scheduling-portal/pull/431.patch","issue_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/431","number":431,"state":"open","locked":false,"title":"Remove usage of deprecated REST endpoint of RM","user":{"login":"jrochas","id":10711209,"avatar_url":"https://avatars3.githubusercontent.com/u/10711209?v=4","gravatar_id":"","url":"https://api.github.com/users/jrochas","html_url":"https://github.com/jrochas","followers_url":"https://api.github.com/users/jrochas/followers","following_url":"https://api.github.com/users/jrochas/following{/other_user}","gists_url":"https://api.github.com/users/jrochas/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochas/subscriptions","organizations_url":"https://api.github.com/users/jrochas/orgs","repos_url":"https://api.github.com/users/jrochas/repos","events_url":"https://api.github.com/users/jrochas/events{/privacy}","received_events_url":"https://api.github.com/users/jrochas/received_events","type":"User","site_admin":false},"body":"- remove createNodeSource from RestClient\r\n- replace createNodeSource call by defineNodeSource followed by deployNodeSource","created_at":"2018-03-22T14:24:26Z","updated_at":"2018-03-22T15:53:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9c2f24e95a1eb4000a4d4f7c17f5a9189c90069","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/431/commits","review_comments_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/431/comments","review_comment_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/431/comments","statuses_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/statuses/58e12321a17080086816aa7b6f9dafae37821839","head":{"label":"jrochas:remove-create-node-source-usage","ref":"remove-create-node-source-usage","sha":"58e12321a17080086816aa7b6f9dafae37821839","user":{"login":"jrochas","id":10711209,"avatar_url":"https://avatars3.githubusercontent.com/u/10711209?v=4","gravatar_id":"","url":"https://api.github.com/users/jrochas","html_url":"https://github.com/jrochas","followers_url":"https://api.github.com/users/jrochas/followers","following_url":"https://api.github.com/users/jrochas/following{/other_user}","gists_url":"https://api.github.com/users/jrochas/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochas/subscriptions","organizations_url":"https://api.github.com/users/jrochas/orgs","repos_url":"https://api.github.com/users/jrochas/repos","events_url":"https://api.github.com/users/jrochas/events{/privacy}","received_events_url":"https://api.github.com/users/jrochas/received_events","type":"User","site_admin":false},"repo":{"id":93499724,"name":"scheduling-portal","full_name":"jrochas/scheduling-portal","owner":{"login":"jrochas","id":10711209,"avatar_url":"https://avatars3.githubusercontent.com/u/10711209?v=4","gravatar_id":"","url":"https://api.github.com/users/jrochas","html_url":"https://github.com/jrochas","followers_url":"https://api.github.com/users/jrochas/followers","following_url":"https://api.github.com/users/jrochas/following{/other_user}","gists_url":"https://api.github.com/users/jrochas/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochas/subscriptions","organizations_url":"https://api.github.com/users/jrochas/orgs","repos_url":"https://api.github.com/users/jrochas/repos","events_url":"https://api.github.com/users/jrochas/events{/privacy}","received_events_url":"https://api.github.com/users/jrochas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrochas/scheduling-portal","description":null,"fork":true,"url":"https://api.github.com/repos/jrochas/scheduling-portal","forks_url":"https://api.github.com/repos/jrochas/scheduling-portal/forks","keys_url":"https://api.github.com/repos/jrochas/scheduling-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrochas/scheduling-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrochas/scheduling-portal/teams","hooks_url":"https://api.github.com/repos/jrochas/scheduling-portal/hooks","issue_events_url":"https://api.github.com/repos/jrochas/scheduling-portal/issues/events{/number}","events_url":"https://api.github.com/repos/jrochas/scheduling-portal/events","assignees_url":"https://api.github.com/repos/jrochas/scheduling-portal/assignees{/user}","branches_url":"https://api.github.com/repos/jrochas/scheduling-portal/branches{/branch}","tags_url":"https://api.github.com/repos/jrochas/scheduling-portal/tags","blobs_url":"https://api.github.com/repos/jrochas/scheduling-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrochas/scheduling-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrochas/scheduling-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrochas/scheduling-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrochas/scheduling-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/jrochas/scheduling-portal/languages","stargazers_url":"https://api.github.com/repos/jrochas/scheduling-portal/stargazers","contributors_url":"https://api.github.com/repos/jrochas/scheduling-portal/contributors","subscribers_url":"https://api.github.com/repos/jrochas/scheduling-portal/subscribers","subscription_url":"https://api.github.com/repos/jrochas/scheduling-portal/subscription","commits_url":"https://api.github.com/repos/jrochas/scheduling-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrochas/scheduling-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrochas/scheduling-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrochas/scheduling-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrochas/scheduling-portal/contents/{+path}","compare_url":"https://api.github.com/repos/jrochas/scheduling-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrochas/scheduling-portal/merges","archive_url":"https://api.github.com/repos/jrochas/scheduling-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrochas/scheduling-portal/downloads","issues_url":"https://api.github.com/repos/jrochas/scheduling-portal/issues{/number}","pulls_url":"https://api.github.com/repos/jrochas/scheduling-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/jrochas/scheduling-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/jrochas/scheduling-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrochas/scheduling-portal/labels{/name}","releases_url":"https://api.github.com/repos/jrochas/scheduling-portal/releases{/id}","deployments_url":"https://api.github.com/repos/jrochas/scheduling-portal/deployments","created_at":"2017-06-06T09:18:57Z","updated_at":"2018-03-16T15:12:42Z","pushed_at":"2018-03-22T14:23:19Z","git_url":"git://github.com/jrochas/scheduling-portal.git","ssh_url":"git@github.com:jrochas/scheduling-portal.git","clone_url":"https://github.com/jrochas/scheduling-portal.git","svn_url":"https://github.com/jrochas/scheduling-portal","homepage":"http://try.activeeon.com","size":118796,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ow2-proactive:master","ref":"master","sha":"ecbf3f00cd009f38857c781107446d81bdc2de21","user":{"login":"ow2-proactive","id":11553998,"avatar_url":"https://avatars1.githubusercontent.com/u/11553998?v=4","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"repo":{"id":35725080,"name":"scheduling-portal","full_name":"ow2-proactive/scheduling-portal","owner":{"login":"ow2-proactive","id":11553998,"avatar_url":"https://avatars1.githubusercontent.com/u/11553998?v=4","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ow2-proactive/scheduling-portal","description":null,"fork":false,"url":"https://api.github.com/repos/ow2-proactive/scheduling-portal","forks_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/forks","keys_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/teams","hooks_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/hooks","issue_events_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/events{/number}","events_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/events","assignees_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/assignees{/user}","branches_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/branches{/branch}","tags_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/tags","blobs_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/languages","stargazers_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/stargazers","contributors_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/contributors","subscribers_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/subscribers","subscription_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/subscription","commits_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/contents/{+path}","compare_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/merges","archive_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/downloads","issues_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues{/number}","pulls_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/labels{/name}","releases_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/releases{/id}","deployments_url":"https://api.github.com/repos/ow2-proactive/scheduling-portal/deployments","created_at":"2015-05-16T13:38:55Z","updated_at":"2018-03-15T11:35:08Z","pushed_at":"2018-03-22T14:26:08Z","git_url":"git://github.com/ow2-proactive/scheduling-portal.git","ssh_url":"git@github.com:ow2-proactive/scheduling-portal.git","clone_url":"https://github.com/ow2-proactive/scheduling-portal.git","svn_url":"https://github.com/ow2-proactive/scheduling-portal","homepage":"http://try.activeeon.com","size":118812,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":31,"open_issues":59,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/431"},"html":{"href":"https://github.com/ow2-proactive/scheduling-portal/pull/431"},"issue":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/431"},"comments":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/issues/431/comments"},"review_comments":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/431/comments"},"review_comment":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/pulls/431/commits"},"statuses":{"href":"https://api.github.com/repos/ow2-proactive/scheduling-portal/statuses/58e12321a17080086816aa7b6f9dafae37821839"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sonarqube-activeeon"}}