{"action":"created","issue":{"url":"https://api.github.com/repos/Crowd9/IntegrateMeTest/issues/2","repository_url":"https://api.github.com/repos/Crowd9/IntegrateMeTest","labels_url":"https://api.github.com/repos/Crowd9/IntegrateMeTest/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/Crowd9/IntegrateMeTest/issues/2/comments","events_url":"https://api.github.com/repos/Crowd9/IntegrateMeTest/issues/2/events","html_url":"https://github.com/Crowd9/IntegrateMeTest/pull/2","id":305726110,"number":2,"title":"Integrate with Mailchimp","user":{"login":"nsave","id":7858232,"avatar_url":"https://avatars1.githubusercontent.com/u/7858232?v=4","gravatar_id":"","url":"https://api.github.com/users/nsave","html_url":"https://github.com/nsave","followers_url":"https://api.github.com/users/nsave/followers","following_url":"https://api.github.com/users/nsave/following{/other_user}","gists_url":"https://api.github.com/users/nsave/gists{/gist_id}","starred_url":"https://api.github.com/users/nsave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsave/subscriptions","organizations_url":"https://api.github.com/users/nsave/orgs","repos_url":"https://api.github.com/users/nsave/repos","events_url":"https://api.github.com/users/nsave/events{/privacy}","received_events_url":"https://api.github.com/users/nsave/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-15T21:29:25Z","updated_at":"2018-03-16T23:06:42Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Crowd9/IntegrateMeTest/pulls/2","html_url":"https://github.com/Crowd9/IntegrateMeTest/pull/2","diff_url":"https://github.com/Crowd9/IntegrateMeTest/pull/2.diff","patch_url":"https://github.com/Crowd9/IntegrateMeTest/pull/2.patch"},"body":"### New workflow changes\r\n- Push `name` and `email` to Mailchimp on successful entry submission. Keep track of `subscribed_at` time in `entries` table.\r\n- Fallback to searching existing subscriber(via api) if Mailchimp _create_member_ request fails (useful when a user wants to submit entries for different competitions)\r\n\r\n### Possible improvements\r\n- Retry pushing to Mailchimp as a cron job.\r\n- Configure Mailchimp lists on a competition level.\r\n- I'd prefer to add feature specs after the design become stable. Or is it final now?:)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Crowd9/IntegrateMeTest/issues/comments/373868203","html_url":"https://github.com/Crowd9/IntegrateMeTest/pull/2#issuecomment-373868203","issue_url":"https://api.github.com/repos/Crowd9/IntegrateMeTest/issues/2","id":373868203,"user":{"login":"nsave","id":7858232,"avatar_url":"https://avatars1.githubusercontent.com/u/7858232?v=4","gravatar_id":"","url":"https://api.github.com/users/nsave","html_url":"https://github.com/nsave","followers_url":"https://api.github.com/users/nsave/followers","following_url":"https://api.github.com/users/nsave/following{/other_user}","gists_url":"https://api.github.com/users/nsave/gists{/gist_id}","starred_url":"https://api.github.com/users/nsave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nsave/subscriptions","organizations_url":"https://api.github.com/users/nsave/orgs","repos_url":"https://api.github.com/users/nsave/repos","events_url":"https://api.github.com/users/nsave/events{/privacy}","received_events_url":"https://api.github.com/users/nsave/received_events","type":"User","site_admin":false},"created_at":"2018-03-16T23:06:42Z","updated_at":"2018-03-16T23:06:42Z","author_association":"NONE","body":"## Competition creation added (with angular)\r\n\r\n### Notes on api key usage\r\n- Api key input is masked as password + filtered out from rails logs\r\n- For a real project I'd suggest using an oauth api instead\r\n\r\n### A migration adding mailchimp columns\r\n- Since its a breaking change - an exception prevents from running the migration if any competition rows exist\r\n- Maybe it would be better to fill old rows with admin credentials (depends on the initial idea actually)\r\n\r\n### Possible improvements\r\n- Doublecheck `api_key` and `list_id` validity before saving a competition to DB"}}
{"actor":{"display_login":"nsave"}}