{"action":"opened","number":74,"pull_request":{"url":"https://api.github.com/repos/pixelogik/NearPy/pulls/74","id":167431396,"html_url":"https://github.com/pixelogik/NearPy/pull/74","diff_url":"https://github.com/pixelogik/NearPy/pull/74.diff","patch_url":"https://github.com/pixelogik/NearPy/pull/74.patch","issue_url":"https://api.github.com/repos/pixelogik/NearPy/issues/74","number":74,"state":"open","locked":false,"title":"Revert \"add Engine.store_many_vectors() for uploading to Redis using pipeline\"","user":{"login":"pixelogik","id":968919,"avatar_url":"https://avatars1.githubusercontent.com/u/968919?v=4","gravatar_id":"","url":"https://api.github.com/users/pixelogik","html_url":"https://github.com/pixelogik","followers_url":"https://api.github.com/users/pixelogik/followers","following_url":"https://api.github.com/users/pixelogik/following{/other_user}","gists_url":"https://api.github.com/users/pixelogik/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelogik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelogik/subscriptions","organizations_url":"https://api.github.com/users/pixelogik/orgs","repos_url":"https://api.github.com/users/pixelogik/repos","events_url":"https://api.github.com/users/pixelogik/events{/privacy}","received_events_url":"https://api.github.com/users/pixelogik/received_events","type":"User","site_admin":false},"body":"@xieqihui I snap. Same case as in the Mongo pull request. You added a new method to the Redis storage class. All storage class should support the same methods, if possible. A user of the Engine class could use the store_many_vectors method, even when not using the Redis storage, which will crash. I would like to keep the usage of Engine as simple as possible. \r\n\r\nMy suggestion is: In Engine differentiate in store_many_vectors between the Redis case and others. If it is not a Redis storage, use the store_vector method in a loop so that it also works there. \r\n\r\n\r\n","created_at":"2018-02-06T14:38:51Z","updated_at":"2018-02-06T14:38:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/pixelogik/NearPy/pulls/74/commits","review_comments_url":"https://api.github.com/repos/pixelogik/NearPy/pulls/74/comments","review_comment_url":"https://api.github.com/repos/pixelogik/NearPy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pixelogik/NearPy/issues/74/comments","statuses_url":"https://api.github.com/repos/pixelogik/NearPy/statuses/3514eadba134e7a74bcac3f1bb624dda721926c9","head":{"label":"pixelogik:revert-71-redis_multi_vector","ref":"revert-71-redis_multi_vector","sha":"3514eadba134e7a74bcac3f1bb624dda721926c9","user":{"login":"pixelogik","id":968919,"avatar_url":"https://avatars1.githubusercontent.com/u/968919?v=4","gravatar_id":"","url":"https://api.github.com/users/pixelogik","html_url":"https://github.com/pixelogik","followers_url":"https://api.github.com/users/pixelogik/followers","following_url":"https://api.github.com/users/pixelogik/following{/other_user}","gists_url":"https://api.github.com/users/pixelogik/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelogik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelogik/subscriptions","organizations_url":"https://api.github.com/users/pixelogik/orgs","repos_url":"https://api.github.com/users/pixelogik/repos","events_url":"https://api.github.com/users/pixelogik/events{/privacy}","received_events_url":"https://api.github.com/users/pixelogik/received_events","type":"User","site_admin":false},"repo":{"id":9667957,"name":"NearPy","full_name":"pixelogik/NearPy","owner":{"login":"pixelogik","id":968919,"avatar_url":"https://avatars1.githubusercontent.com/u/968919?v=4","gravatar_id":"","url":"https://api.github.com/users/pixelogik","html_url":"https://github.com/pixelogik","followers_url":"https://api.github.com/users/pixelogik/followers","following_url":"https://api.github.com/users/pixelogik/following{/other_user}","gists_url":"https://api.github.com/users/pixelogik/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelogik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelogik/subscriptions","organizations_url":"https://api.github.com/users/pixelogik/orgs","repos_url":"https://api.github.com/users/pixelogik/repos","events_url":"https://api.github.com/users/pixelogik/events{/privacy}","received_events_url":"https://api.github.com/users/pixelogik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pixelogik/NearPy","description":"Python framework for fast (approximated) nearest neighbour search in large, high-dimensional data sets using different locality-sensitive hashes.","fork":false,"url":"https://api.github.com/repos/pixelogik/NearPy","forks_url":"https://api.github.com/repos/pixelogik/NearPy/forks","keys_url":"https://api.github.com/repos/pixelogik/NearPy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pixelogik/NearPy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pixelogik/NearPy/teams","hooks_url":"https://api.github.com/repos/pixelogik/NearPy/hooks","issue_events_url":"https://api.github.com/repos/pixelogik/NearPy/issues/events{/number}","events_url":"https://api.github.com/repos/pixelogik/NearPy/events","assignees_url":"https://api.github.com/repos/pixelogik/NearPy/assignees{/user}","branches_url":"https://api.github.com/repos/pixelogik/NearPy/branches{/branch}","tags_url":"https://api.github.com/repos/pixelogik/NearPy/tags","blobs_url":"https://api.github.com/repos/pixelogik/NearPy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pixelogik/NearPy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pixelogik/NearPy/git/refs{/sha}","trees_url":"https://api.github.com/repos/pixelogik/NearPy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pixelogik/NearPy/statuses/{sha}","languages_url":"https://api.github.com/repos/pixelogik/NearPy/languages","stargazers_url":"https://api.github.com/repos/pixelogik/NearPy/stargazers","contributors_url":"https://api.github.com/repos/pixelogik/NearPy/contributors","subscribers_url":"https://api.github.com/repos/pixelogik/NearPy/subscribers","subscription_url":"https://api.github.com/repos/pixelogik/NearPy/subscription","commits_url":"https://api.github.com/repos/pixelogik/NearPy/commits{/sha}","git_commits_url":"https://api.github.com/repos/pixelogik/NearPy/git/commits{/sha}","comments_url":"https://api.github.com/repos/pixelogik/NearPy/comments{/number}","issue_comment_url":"https://api.github.com/repos/pixelogik/NearPy/issues/comments{/number}","contents_url":"https://api.github.com/repos/pixelogik/NearPy/contents/{+path}","compare_url":"https://api.github.com/repos/pixelogik/NearPy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pixelogik/NearPy/merges","archive_url":"https://api.github.com/repos/pixelogik/NearPy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pixelogik/NearPy/downloads","issues_url":"https://api.github.com/repos/pixelogik/NearPy/issues{/number}","pulls_url":"https://api.github.com/repos/pixelogik/NearPy/pulls{/number}","milestones_url":"https://api.github.com/repos/pixelogik/NearPy/milestones{/number}","notifications_url":"https://api.github.com/repos/pixelogik/NearPy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pixelogik/NearPy/labels{/name}","releases_url":"https://api.github.com/repos/pixelogik/NearPy/releases{/id}","deployments_url":"https://api.github.com/repos/pixelogik/NearPy/deployments","created_at":"2013-04-25T09:10:26Z","updated_at":"2018-02-06T10:31:31Z","pushed_at":"2018-02-06T14:06:57Z","git_url":"git://github.com/pixelogik/NearPy.git","ssh_url":"git@github.com:pixelogik/NearPy.git","clone_url":"https://github.com/pixelogik/NearPy.git","svn_url":"https://github.com/pixelogik/NearPy","homepage":"","size":424,"stargazers_count":410,"watchers_count":410,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":103,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":103,"open_issues":14,"watchers":410,"default_branch":"master"}},"base":{"label":"pixelogik:master","ref":"master","sha":"5ce43911cc88b67d99a9343bb3f8f0743c650d72","user":{"login":"pixelogik","id":968919,"avatar_url":"https://avatars1.githubusercontent.com/u/968919?v=4","gravatar_id":"","url":"https://api.github.com/users/pixelogik","html_url":"https://github.com/pixelogik","followers_url":"https://api.github.com/users/pixelogik/followers","following_url":"https://api.github.com/users/pixelogik/following{/other_user}","gists_url":"https://api.github.com/users/pixelogik/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelogik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelogik/subscriptions","organizations_url":"https://api.github.com/users/pixelogik/orgs","repos_url":"https://api.github.com/users/pixelogik/repos","events_url":"https://api.github.com/users/pixelogik/events{/privacy}","received_events_url":"https://api.github.com/users/pixelogik/received_events","type":"User","site_admin":false},"repo":{"id":9667957,"name":"NearPy","full_name":"pixelogik/NearPy","owner":{"login":"pixelogik","id":968919,"avatar_url":"https://avatars1.githubusercontent.com/u/968919?v=4","gravatar_id":"","url":"https://api.github.com/users/pixelogik","html_url":"https://github.com/pixelogik","followers_url":"https://api.github.com/users/pixelogik/followers","following_url":"https://api.github.com/users/pixelogik/following{/other_user}","gists_url":"https://api.github.com/users/pixelogik/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelogik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelogik/subscriptions","organizations_url":"https://api.github.com/users/pixelogik/orgs","repos_url":"https://api.github.com/users/pixelogik/repos","events_url":"https://api.github.com/users/pixelogik/events{/privacy}","received_events_url":"https://api.github.com/users/pixelogik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pixelogik/NearPy","description":"Python framework for fast (approximated) nearest neighbour search in large, high-dimensional data sets using different locality-sensitive hashes.","fork":false,"url":"https://api.github.com/repos/pixelogik/NearPy","forks_url":"https://api.github.com/repos/pixelogik/NearPy/forks","keys_url":"https://api.github.com/repos/pixelogik/NearPy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pixelogik/NearPy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pixelogik/NearPy/teams","hooks_url":"https://api.github.com/repos/pixelogik/NearPy/hooks","issue_events_url":"https://api.github.com/repos/pixelogik/NearPy/issues/events{/number}","events_url":"https://api.github.com/repos/pixelogik/NearPy/events","assignees_url":"https://api.github.com/repos/pixelogik/NearPy/assignees{/user}","branches_url":"https://api.github.com/repos/pixelogik/NearPy/branches{/branch}","tags_url":"https://api.github.com/repos/pixelogik/NearPy/tags","blobs_url":"https://api.github.com/repos/pixelogik/NearPy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pixelogik/NearPy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pixelogik/NearPy/git/refs{/sha}","trees_url":"https://api.github.com/repos/pixelogik/NearPy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pixelogik/NearPy/statuses/{sha}","languages_url":"https://api.github.com/repos/pixelogik/NearPy/languages","stargazers_url":"https://api.github.com/repos/pixelogik/NearPy/stargazers","contributors_url":"https://api.github.com/repos/pixelogik/NearPy/contributors","subscribers_url":"https://api.github.com/repos/pixelogik/NearPy/subscribers","subscription_url":"https://api.github.com/repos/pixelogik/NearPy/subscription","commits_url":"https://api.github.com/repos/pixelogik/NearPy/commits{/sha}","git_commits_url":"https://api.github.com/repos/pixelogik/NearPy/git/commits{/sha}","comments_url":"https://api.github.com/repos/pixelogik/NearPy/comments{/number}","issue_comment_url":"https://api.github.com/repos/pixelogik/NearPy/issues/comments{/number}","contents_url":"https://api.github.com/repos/pixelogik/NearPy/contents/{+path}","compare_url":"https://api.github.com/repos/pixelogik/NearPy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pixelogik/NearPy/merges","archive_url":"https://api.github.com/repos/pixelogik/NearPy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pixelogik/NearPy/downloads","issues_url":"https://api.github.com/repos/pixelogik/NearPy/issues{/number}","pulls_url":"https://api.github.com/repos/pixelogik/NearPy/pulls{/number}","milestones_url":"https://api.github.com/repos/pixelogik/NearPy/milestones{/number}","notifications_url":"https://api.github.com/repos/pixelogik/NearPy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pixelogik/NearPy/labels{/name}","releases_url":"https://api.github.com/repos/pixelogik/NearPy/releases{/id}","deployments_url":"https://api.github.com/repos/pixelogik/NearPy/deployments","created_at":"2013-04-25T09:10:26Z","updated_at":"2018-02-06T10:31:31Z","pushed_at":"2018-02-06T14:06:57Z","git_url":"git://github.com/pixelogik/NearPy.git","ssh_url":"git@github.com:pixelogik/NearPy.git","clone_url":"https://github.com/pixelogik/NearPy.git","svn_url":"https://github.com/pixelogik/NearPy","homepage":"","size":424,"stargazers_count":410,"watchers_count":410,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":103,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":103,"open_issues":14,"watchers":410,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pixelogik/NearPy/pulls/74"},"html":{"href":"https://github.com/pixelogik/NearPy/pull/74"},"issue":{"href":"https://api.github.com/repos/pixelogik/NearPy/issues/74"},"comments":{"href":"https://api.github.com/repos/pixelogik/NearPy/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/pixelogik/NearPy/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/pixelogik/NearPy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pixelogik/NearPy/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/pixelogik/NearPy/statuses/3514eadba134e7a74bcac3f1bb624dda721926c9"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":0,"deletions":58,"changed_files":2}}
{"actor":{"display_login":"pixelogik"}}