{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/comments/175259971","pull_request_review_id":104768196,"id":175259971,"diff_hunk":"@@ -365,6 +365,24 @@ operand in ``OpSource`` instruction. For ``*s_<major>_<minor>``, the \"Verison\"\n operand in ``OpSource`` will be set as ``<major>`` * 100 + ``<minor>`` * 10.\n For example, ``vs_5_1`` will have 510, ``ps_6_2`` will have 620.\n \n+HLSL Semantic\n+~~~~~~~~~~~~~\n+\n+HLSL semantic strings are by default not emitted into the SPIR-V binary module.\n+If you need them, by specifying ``-fvk-reflect``, the compiler will use\n+the ``Op*DecorateStringGOOGLE`` instruction in ``SPV_GOOGLE_hlsl_funtionality1``\n+extension to emit them.\n+\n+Counter buffers for RW/Append/Consume StructuredBuffer\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+\n+The association between a counter buffer and its main RW/Append/Consume\n+StructuredBuffer is covnveyed by ``OpDecorateId <structured-buffer-id>","path":"docs/SPIR-V.rst","position":null,"original_position":16,"commit_id":"be1a009331627a6194650a0e20eb75f6e4b4ce8b","original_commit_id":"7cf79fb736191471d47b1012377c06b3a4ad8f24","user":{"login":"antiagainst","id":487928,"avatar_url":"https://avatars1.githubusercontent.com/u/487928?v=4","gravatar_id":"","url":"https://api.github.com/users/antiagainst","html_url":"https://github.com/antiagainst","followers_url":"https://api.github.com/users/antiagainst/followers","following_url":"https://api.github.com/users/antiagainst/following{/other_user}","gists_url":"https://api.github.com/users/antiagainst/gists{/gist_id}","starred_url":"https://api.github.com/users/antiagainst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiagainst/subscriptions","organizations_url":"https://api.github.com/users/antiagainst/orgs","repos_url":"https://api.github.com/users/antiagainst/repos","events_url":"https://api.github.com/users/antiagainst/events{/privacy}","received_events_url":"https://api.github.com/users/antiagainst/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-03-17T14:41:35Z","updated_at":"2018-03-17T14:41:35Z","html_url":"https://github.com/Microsoft/DirectXShaderCompiler/pull/1111#discussion_r175259971","pull_request_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/1111","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/comments/175259971"},"html":{"href":"https://github.com/Microsoft/DirectXShaderCompiler/pull/1111#discussion_r175259971"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/1111"}},"in_reply_to_id":175238060},"pull_request":{"url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/1111","id":173005546,"html_url":"https://github.com/Microsoft/DirectXShaderCompiler/pull/1111","diff_url":"https://github.com/Microsoft/DirectXShaderCompiler/pull/1111.diff","patch_url":"https://github.com/Microsoft/DirectXShaderCompiler/pull/1111.patch","issue_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/issues/1111","number":1111,"state":"open","locked":false,"title":"[spirv] Better reflection support via new extensions","user":{"login":"antiagainst","id":487928,"avatar_url":"https://avatars1.githubusercontent.com/u/487928?v=4","gravatar_id":"","url":"https://api.github.com/users/antiagainst","html_url":"https://github.com/antiagainst","followers_url":"https://api.github.com/users/antiagainst/followers","following_url":"https://api.github.com/users/antiagainst/following{/other_user}","gists_url":"https://api.github.com/users/antiagainst/gists{/gist_id}","starred_url":"https://api.github.com/users/antiagainst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiagainst/subscriptions","organizations_url":"https://api.github.com/users/antiagainst/orgs","repos_url":"https://api.github.com/users/antiagainst/repos","events_url":"https://api.github.com/users/antiagainst/events{/privacy}","received_events_url":"https://api.github.com/users/antiagainst/received_events","type":"User","site_admin":false},"body":"This pull request emits HLSL semantics and the association\r\nbetween RW/Append/Consume StructuredBuffers with\r\ntheir counter buffers using two new SPIR-V extensions.","created_at":"2018-03-05T22:29:07Z","updated_at":"2018-03-17T14:41:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ff178b6d06a62e9ef9e1161fc6b0e88c68b1105","assignee":{"login":"antiagainst","id":487928,"avatar_url":"https://avatars1.githubusercontent.com/u/487928?v=4","gravatar_id":"","url":"https://api.github.com/users/antiagainst","html_url":"https://github.com/antiagainst","followers_url":"https://api.github.com/users/antiagainst/followers","following_url":"https://api.github.com/users/antiagainst/following{/other_user}","gists_url":"https://api.github.com/users/antiagainst/gists{/gist_id}","starred_url":"https://api.github.com/users/antiagainst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiagainst/subscriptions","organizations_url":"https://api.github.com/users/antiagainst/orgs","repos_url":"https://api.github.com/users/antiagainst/repos","events_url":"https://api.github.com/users/antiagainst/events{/privacy}","received_events_url":"https://api.github.com/users/antiagainst/received_events","type":"User","site_admin":false},"assignees":[{"login":"antiagainst","id":487928,"avatar_url":"https://avatars1.githubusercontent.com/u/487928?v=4","gravatar_id":"","url":"https://api.github.com/users/antiagainst","html_url":"https://github.com/antiagainst","followers_url":"https://api.github.com/users/antiagainst/followers","following_url":"https://api.github.com/users/antiagainst/following{/other_user}","gists_url":"https://api.github.com/users/antiagainst/gists{/gist_id}","starred_url":"https://api.github.com/users/antiagainst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiagainst/subscriptions","organizations_url":"https://api.github.com/users/antiagainst/orgs","repos_url":"https://api.github.com/users/antiagainst/repos","events_url":"https://api.github.com/users/antiagainst/events{/privacy}","received_events_url":"https://api.github.com/users/antiagainst/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/1111/commits","review_comments_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/1111/comments","review_comment_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/issues/1111/comments","statuses_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/statuses/be1a009331627a6194650a0e20eb75f6e4b4ce8b","head":{"label":"antiagainst:hlsl-decorations","ref":"hlsl-decorations","sha":"be1a009331627a6194650a0e20eb75f6e4b4ce8b","user":{"login":"antiagainst","id":487928,"avatar_url":"https://avatars1.githubusercontent.com/u/487928?v=4","gravatar_id":"","url":"https://api.github.com/users/antiagainst","html_url":"https://github.com/antiagainst","followers_url":"https://api.github.com/users/antiagainst/followers","following_url":"https://api.github.com/users/antiagainst/following{/other_user}","gists_url":"https://api.github.com/users/antiagainst/gists{/gist_id}","starred_url":"https://api.github.com/users/antiagainst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiagainst/subscriptions","organizations_url":"https://api.github.com/users/antiagainst/orgs","repos_url":"https://api.github.com/users/antiagainst/repos","events_url":"https://api.github.com/users/antiagainst/events{/privacy}","received_events_url":"https://api.github.com/users/antiagainst/received_events","type":"User","site_admin":false},"repo":{"id":83722922,"name":"DirectXShaderCompiler","full_name":"antiagainst/DirectXShaderCompiler","owner":{"login":"antiagainst","id":487928,"avatar_url":"https://avatars1.githubusercontent.com/u/487928?v=4","gravatar_id":"","url":"https://api.github.com/users/antiagainst","html_url":"https://github.com/antiagainst","followers_url":"https://api.github.com/users/antiagainst/followers","following_url":"https://api.github.com/users/antiagainst/following{/other_user}","gists_url":"https://api.github.com/users/antiagainst/gists{/gist_id}","starred_url":"https://api.github.com/users/antiagainst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiagainst/subscriptions","organizations_url":"https://api.github.com/users/antiagainst/orgs","repos_url":"https://api.github.com/users/antiagainst/repos","events_url":"https://api.github.com/users/antiagainst/events{/privacy}","received_events_url":"https://api.github.com/users/antiagainst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antiagainst/DirectXShaderCompiler","description":"This repo hosts the source for the DirectX Shader Compiler which is based on LLVM/Clang.","fork":true,"url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler","forks_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/forks","keys_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/teams","hooks_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/hooks","issue_events_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/issues/events{/number}","events_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/events","assignees_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/assignees{/user}","branches_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/branches{/branch}","tags_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/tags","blobs_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/statuses/{sha}","languages_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/languages","stargazers_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/stargazers","contributors_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/contributors","subscribers_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/subscribers","subscription_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/subscription","commits_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/contents/{+path}","compare_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/merges","archive_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/downloads","issues_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/issues{/number}","pulls_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/pulls{/number}","milestones_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/milestones{/number}","notifications_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/labels{/name}","releases_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/releases{/id}","deployments_url":"https://api.github.com/repos/antiagainst/DirectXShaderCompiler/deployments","created_at":"2017-03-02T20:42:49Z","updated_at":"2018-01-05T09:16:17Z","pushed_at":"2018-03-17T14:40:14Z","git_url":"git://github.com/antiagainst/DirectXShaderCompiler.git","ssh_url":"git@github.com:antiagainst/DirectXShaderCompiler.git","clone_url":"https://github.com/antiagainst/DirectXShaderCompiler.git","svn_url":"https://github.com/antiagainst/DirectXShaderCompiler","homepage":null,"size":34477,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":0,"open_issues":8,"watchers":3,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"cfd787a18edc611f5a75a8d38c164d4743282141","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":75787966,"name":"DirectXShaderCompiler","full_name":"Microsoft/DirectXShaderCompiler","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/DirectXShaderCompiler","description":"This repo hosts the source for the DirectX Shader Compiler which is based on LLVM/Clang.","fork":false,"url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler","forks_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/forks","keys_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/teams","hooks_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/events","assignees_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/tags","blobs_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/languages","stargazers_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/subscription","commits_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/merges","archive_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/downloads","issues_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/deployments","created_at":"2016-12-07T01:42:19Z","updated_at":"2018-03-17T00:19:24Z","pushed_at":"2018-03-17T14:40:15Z","git_url":"git://github.com/Microsoft/DirectXShaderCompiler.git","ssh_url":"git@github.com:Microsoft/DirectXShaderCompiler.git","clone_url":"https://github.com/Microsoft/DirectXShaderCompiler.git","svn_url":"https://github.com/Microsoft/DirectXShaderCompiler","homepage":null,"size":34178,"stargazers_count":797,"watchers_count":797,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":105,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":105,"open_issues":77,"watchers":797,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/1111"},"html":{"href":"https://github.com/Microsoft/DirectXShaderCompiler/pull/1111"},"issue":{"href":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/issues/1111"},"comments":{"href":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/issues/1111/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/1111/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/pulls/1111/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/DirectXShaderCompiler/statuses/be1a009331627a6194650a0e20eb75f6e4b4ce8b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"antiagainst"}}