{"action":"created","comment":{"url":"https://api.github.com/repos/google/trillian/pulls/comments/177476593","pull_request_review_id":107353625,"id":177476593,"diff_hunk":"@@ -64,6 +64,21 @@ func ValidateTreeForCreation(ctx context.Context, tree *trillian.Tree) error {\n \treturn validateMutableTreeFields(ctx, tree)\n }\n \n+func validateTreeTypeUpdate(oldTree, newTree *trillian.Tree) error {\n+\tconst prefix = \"changing tree_type\"","path":"storage/tree_validation.go","position":null,"original_position":5,"commit_id":"f928b3b5f27bb5551dc0125657e5936610614718","original_commit_id":"dd5b0288eeccb047d44ba98ad5cfafc391c1f76a","user":{"login":"pavelkalinnikov","id":3757441,"avatar_url":"https://avatars0.githubusercontent.com/u/3757441?v=4","gravatar_id":"","url":"https://api.github.com/users/pavelkalinnikov","html_url":"https://github.com/pavelkalinnikov","followers_url":"https://api.github.com/users/pavelkalinnikov/followers","following_url":"https://api.github.com/users/pavelkalinnikov/following{/other_user}","gists_url":"https://api.github.com/users/pavelkalinnikov/gists{/gist_id}","starred_url":"https://api.github.com/users/pavelkalinnikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavelkalinnikov/subscriptions","organizations_url":"https://api.github.com/users/pavelkalinnikov/orgs","repos_url":"https://api.github.com/users/pavelkalinnikov/repos","events_url":"https://api.github.com/users/pavelkalinnikov/events{/privacy}","received_events_url":"https://api.github.com/users/pavelkalinnikov/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2018-03-27T15:51:04Z","updated_at":"2018-03-27T16:02:26Z","html_url":"https://github.com/google/trillian/pull/1066#discussion_r177476593","pull_request_url":"https://api.github.com/repos/google/trillian/pulls/1066","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/google/trillian/pulls/comments/177476593"},"html":{"href":"https://github.com/google/trillian/pull/1066#discussion_r177476593"},"pull_request":{"href":"https://api.github.com/repos/google/trillian/pulls/1066"}},"in_reply_to_id":177408003},"pull_request":{"url":"https://api.github.com/repos/google/trillian/pulls/1066","id":176810115,"html_url":"https://github.com/google/trillian/pull/1066","diff_url":"https://github.com/google/trillian/pull/1066.diff","patch_url":"https://github.com/google/trillian/pull/1066.patch","issue_url":"https://api.github.com/repos/google/trillian/issues/1066","number":1066,"state":"open","locked":false,"title":"Allow switching TreeType from PREORDERED_LOG to LOG","user":{"login":"pavelkalinnikov","id":3757441,"avatar_url":"https://avatars0.githubusercontent.com/u/3757441?v=4","gravatar_id":"","url":"https://api.github.com/users/pavelkalinnikov","html_url":"https://github.com/pavelkalinnikov","followers_url":"https://api.github.com/users/pavelkalinnikov/followers","following_url":"https://api.github.com/users/pavelkalinnikov/following{/other_user}","gists_url":"https://api.github.com/users/pavelkalinnikov/gists{/gist_id}","starred_url":"https://api.github.com/users/pavelkalinnikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavelkalinnikov/subscriptions","organizations_url":"https://api.github.com/users/pavelkalinnikov/orgs","repos_url":"https://api.github.com/users/pavelkalinnikov/repos","events_url":"https://api.github.com/users/pavelkalinnikov/events{/privacy}","received_events_url":"https://api.github.com/users/pavelkalinnikov/received_events","type":"User","site_admin":false},"body":"This change enables switching from the `Tree` metadata perspective. Additional support in `storage.UpdateTree` is required to avoid the situation when the type is changed while there are pending `SequencedLeafData` entries.","created_at":"2018-03-22T15:09:40Z","updated_at":"2018-03-27T16:02:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59b4bbdaffa442f41299beffb8490bc9a2ebafe5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"AlCutter","id":7648032,"avatar_url":"https://avatars0.githubusercontent.com/u/7648032?v=4","gravatar_id":"","url":"https://api.github.com/users/AlCutter","html_url":"https://github.com/AlCutter","followers_url":"https://api.github.com/users/AlCutter/followers","following_url":"https://api.github.com/users/AlCutter/following{/other_user}","gists_url":"https://api.github.com/users/AlCutter/gists{/gist_id}","starred_url":"https://api.github.com/users/AlCutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlCutter/subscriptions","organizations_url":"https://api.github.com/users/AlCutter/orgs","repos_url":"https://api.github.com/users/AlCutter/repos","events_url":"https://api.github.com/users/AlCutter/events{/privacy}","received_events_url":"https://api.github.com/users/AlCutter/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":389540533,"url":"https://api.github.com/repos/google/trillian/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/trillian/pulls/1066/commits","review_comments_url":"https://api.github.com/repos/google/trillian/pulls/1066/comments","review_comment_url":"https://api.github.com/repos/google/trillian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/trillian/issues/1066/comments","statuses_url":"https://api.github.com/repos/google/trillian/statuses/f928b3b5f27bb5551dc0125657e5936610614718","head":{"label":"pavelkalinnikov:change_log_type","ref":"change_log_type","sha":"f928b3b5f27bb5551dc0125657e5936610614718","user":{"login":"pavelkalinnikov","id":3757441,"avatar_url":"https://avatars0.githubusercontent.com/u/3757441?v=4","gravatar_id":"","url":"https://api.github.com/users/pavelkalinnikov","html_url":"https://github.com/pavelkalinnikov","followers_url":"https://api.github.com/users/pavelkalinnikov/followers","following_url":"https://api.github.com/users/pavelkalinnikov/following{/other_user}","gists_url":"https://api.github.com/users/pavelkalinnikov/gists{/gist_id}","starred_url":"https://api.github.com/users/pavelkalinnikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavelkalinnikov/subscriptions","organizations_url":"https://api.github.com/users/pavelkalinnikov/orgs","repos_url":"https://api.github.com/users/pavelkalinnikov/repos","events_url":"https://api.github.com/users/pavelkalinnikov/events{/privacy}","received_events_url":"https://api.github.com/users/pavelkalinnikov/received_events","type":"User","site_admin":false},"repo":{"id":110741687,"name":"trillian","full_name":"pavelkalinnikov/trillian","owner":{"login":"pavelkalinnikov","id":3757441,"avatar_url":"https://avatars0.githubusercontent.com/u/3757441?v=4","gravatar_id":"","url":"https://api.github.com/users/pavelkalinnikov","html_url":"https://github.com/pavelkalinnikov","followers_url":"https://api.github.com/users/pavelkalinnikov/followers","following_url":"https://api.github.com/users/pavelkalinnikov/following{/other_user}","gists_url":"https://api.github.com/users/pavelkalinnikov/gists{/gist_id}","starred_url":"https://api.github.com/users/pavelkalinnikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavelkalinnikov/subscriptions","organizations_url":"https://api.github.com/users/pavelkalinnikov/orgs","repos_url":"https://api.github.com/users/pavelkalinnikov/repos","events_url":"https://api.github.com/users/pavelkalinnikov/events{/privacy}","received_events_url":"https://api.github.com/users/pavelkalinnikov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pavelkalinnikov/trillian","description":"Trillian implements a Merkle tree whose contents are served from a data storage layer, to allow scalability to extremely large trees.","fork":true,"url":"https://api.github.com/repos/pavelkalinnikov/trillian","forks_url":"https://api.github.com/repos/pavelkalinnikov/trillian/forks","keys_url":"https://api.github.com/repos/pavelkalinnikov/trillian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pavelkalinnikov/trillian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pavelkalinnikov/trillian/teams","hooks_url":"https://api.github.com/repos/pavelkalinnikov/trillian/hooks","issue_events_url":"https://api.github.com/repos/pavelkalinnikov/trillian/issues/events{/number}","events_url":"https://api.github.com/repos/pavelkalinnikov/trillian/events","assignees_url":"https://api.github.com/repos/pavelkalinnikov/trillian/assignees{/user}","branches_url":"https://api.github.com/repos/pavelkalinnikov/trillian/branches{/branch}","tags_url":"https://api.github.com/repos/pavelkalinnikov/trillian/tags","blobs_url":"https://api.github.com/repos/pavelkalinnikov/trillian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pavelkalinnikov/trillian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pavelkalinnikov/trillian/git/refs{/sha}","trees_url":"https://api.github.com/repos/pavelkalinnikov/trillian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pavelkalinnikov/trillian/statuses/{sha}","languages_url":"https://api.github.com/repos/pavelkalinnikov/trillian/languages","stargazers_url":"https://api.github.com/repos/pavelkalinnikov/trillian/stargazers","contributors_url":"https://api.github.com/repos/pavelkalinnikov/trillian/contributors","subscribers_url":"https://api.github.com/repos/pavelkalinnikov/trillian/subscribers","subscription_url":"https://api.github.com/repos/pavelkalinnikov/trillian/subscription","commits_url":"https://api.github.com/repos/pavelkalinnikov/trillian/commits{/sha}","git_commits_url":"https://api.github.com/repos/pavelkalinnikov/trillian/git/commits{/sha}","comments_url":"https://api.github.com/repos/pavelkalinnikov/trillian/comments{/number}","issue_comment_url":"https://api.github.com/repos/pavelkalinnikov/trillian/issues/comments{/number}","contents_url":"https://api.github.com/repos/pavelkalinnikov/trillian/contents/{+path}","compare_url":"https://api.github.com/repos/pavelkalinnikov/trillian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pavelkalinnikov/trillian/merges","archive_url":"https://api.github.com/repos/pavelkalinnikov/trillian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pavelkalinnikov/trillian/downloads","issues_url":"https://api.github.com/repos/pavelkalinnikov/trillian/issues{/number}","pulls_url":"https://api.github.com/repos/pavelkalinnikov/trillian/pulls{/number}","milestones_url":"https://api.github.com/repos/pavelkalinnikov/trillian/milestones{/number}","notifications_url":"https://api.github.com/repos/pavelkalinnikov/trillian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pavelkalinnikov/trillian/labels{/name}","releases_url":"https://api.github.com/repos/pavelkalinnikov/trillian/releases{/id}","deployments_url":"https://api.github.com/repos/pavelkalinnikov/trillian/deployments","created_at":"2017-11-14T20:35:12Z","updated_at":"2018-03-22T10:13:56Z","pushed_at":"2018-03-27T16:02:12Z","git_url":"git://github.com/pavelkalinnikov/trillian.git","ssh_url":"git@github.com:pavelkalinnikov/trillian.git","clone_url":"https://github.com/pavelkalinnikov/trillian.git","svn_url":"https://github.com/pavelkalinnikov/trillian","homepage":"","size":9549,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"812857a30415caf7b87746f60c8a60cc7d36d08f","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":58654489,"name":"trillian","full_name":"google/trillian","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/trillian","description":"Trillian implements a Merkle tree whose contents are served from a data storage layer, to allow scalability to extremely large trees.","fork":false,"url":"https://api.github.com/repos/google/trillian","forks_url":"https://api.github.com/repos/google/trillian/forks","keys_url":"https://api.github.com/repos/google/trillian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/trillian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/trillian/teams","hooks_url":"https://api.github.com/repos/google/trillian/hooks","issue_events_url":"https://api.github.com/repos/google/trillian/issues/events{/number}","events_url":"https://api.github.com/repos/google/trillian/events","assignees_url":"https://api.github.com/repos/google/trillian/assignees{/user}","branches_url":"https://api.github.com/repos/google/trillian/branches{/branch}","tags_url":"https://api.github.com/repos/google/trillian/tags","blobs_url":"https://api.github.com/repos/google/trillian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/trillian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/trillian/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/trillian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/trillian/statuses/{sha}","languages_url":"https://api.github.com/repos/google/trillian/languages","stargazers_url":"https://api.github.com/repos/google/trillian/stargazers","contributors_url":"https://api.github.com/repos/google/trillian/contributors","subscribers_url":"https://api.github.com/repos/google/trillian/subscribers","subscription_url":"https://api.github.com/repos/google/trillian/subscription","commits_url":"https://api.github.com/repos/google/trillian/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/trillian/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/trillian/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/trillian/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/trillian/contents/{+path}","compare_url":"https://api.github.com/repos/google/trillian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/trillian/merges","archive_url":"https://api.github.com/repos/google/trillian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/trillian/downloads","issues_url":"https://api.github.com/repos/google/trillian/issues{/number}","pulls_url":"https://api.github.com/repos/google/trillian/pulls{/number}","milestones_url":"https://api.github.com/repos/google/trillian/milestones{/number}","notifications_url":"https://api.github.com/repos/google/trillian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/trillian/labels{/name}","releases_url":"https://api.github.com/repos/google/trillian/releases{/id}","deployments_url":"https://api.github.com/repos/google/trillian/deployments","created_at":"2016-05-12T15:37:35Z","updated_at":"2018-03-27T15:18:44Z","pushed_at":"2018-03-27T16:02:14Z","git_url":"git://github.com/google/trillian.git","ssh_url":"git@github.com:google/trillian.git","clone_url":"https://github.com/google/trillian.git","svn_url":"https://github.com/google/trillian","homepage":"","size":9560,"stargazers_count":867,"watchers_count":867,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":118,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":118,"open_issues":35,"watchers":867,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/trillian/pulls/1066"},"html":{"href":"https://github.com/google/trillian/pull/1066"},"issue":{"href":"https://api.github.com/repos/google/trillian/issues/1066"},"comments":{"href":"https://api.github.com/repos/google/trillian/issues/1066/comments"},"review_comments":{"href":"https://api.github.com/repos/google/trillian/pulls/1066/comments"},"review_comment":{"href":"https://api.github.com/repos/google/trillian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/trillian/pulls/1066/commits"},"statuses":{"href":"https://api.github.com/repos/google/trillian/statuses/f928b3b5f27bb5551dc0125657e5936610614718"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pavelkalinnikov"}}