{"action":"created","issue":{"url":"https://api.github.com/repos/jquery-validation/jquery-validation/issues/2244","repository_url":"https://api.github.com/repos/jquery-validation/jquery-validation","labels_url":"https://api.github.com/repos/jquery-validation/jquery-validation/issues/2244/labels{/name}","comments_url":"https://api.github.com/repos/jquery-validation/jquery-validation/issues/2244/comments","events_url":"https://api.github.com/repos/jquery-validation/jquery-validation/issues/2244/events","html_url":"https://github.com/jquery-validation/jquery-validation/issues/2244","id":387917407,"node_id":"MDU6SXNzdWUzODc5MTc0MDc=","number":2244,"title":"Crowdin contributor's version of Serbian (Latin) translation of PrestaShopop V1.5.0 and the one displayed on GitHub are extremely different ","user":{"login":"Zoran23","id":45638558,"node_id":"MDQ6VXNlcjQ1NjM4NTU4","avatar_url":"https://avatars3.githubusercontent.com/u/45638558?v=4","gravatar_id":"","url":"https://api.github.com/users/Zoran23","html_url":"https://github.com/Zoran23","followers_url":"https://api.github.com/users/Zoran23/followers","following_url":"https://api.github.com/users/Zoran23/following{/other_user}","gists_url":"https://api.github.com/users/Zoran23/gists{/gist_id}","starred_url":"https://api.github.com/users/Zoran23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zoran23/subscriptions","organizations_url":"https://api.github.com/users/Zoran23/orgs","repos_url":"https://api.github.com/users/Zoran23/repos","events_url":"https://api.github.com/users/Zoran23/events{/privacy}","received_events_url":"https://api.github.com/users/Zoran23/received_events","type":"User","site_admin":false},"labels":[{"id":39397088,"node_id":"MDU6TGFiZWwzOTM5NzA4OA==","url":"https://api.github.com/repos/jquery-validation/jquery-validation/labels/Localization%20(i18n)","name":"Localization (i18n)","color":"006b75","default":false},{"id":680726456,"node_id":"MDU6TGFiZWw2ODA3MjY0NTY=","url":"https://api.github.com/repos/jquery-validation/jquery-validation/labels/NEEDS%20FEEDBACK","name":"NEEDS FEEDBACK","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-05T19:49:00Z","updated_at":"2018-12-17T10:09:34Z","closed_at":null,"author_association":"NONE","body":"To Whom It May Concern  \r\n\r\n### PrestaShop language Serbian latin on Crowdin and GitHub dev don't use the same variant\r\n<!-- Describe your issue here. -->\r\nMy name is Zoran and I took a project to translate PrestaShopop V1.5.0 on Serbian Latin language. \r\nLanguage In prestaShop has a Language code: sr-cs and ISO code : sr \r\nSerbian has two type of languages. \r\n1. Serbian cirilic \r\n2. Serbian Latin\r\nOn crowdin website there is only one type and this is Serbian (Latin) translation. \r\nThis Latin is more popular and I am happy that this one is there.  This language is already translated 62 % and rest of it will come soon. Problem is that someone who started this translation translated one minor part in Cyrillic. \r\nI have found these several wrong translated words and have changed them to correct ones.  Unfortunate everything that I corrected never came with new prestaShop installation. Even some new words that I have translated never showed up on new PrestaShop 1.5.0beta version\r\nI asked prestashop developers for help and this is what they told me: “\r\n“Wen I make the comparison between the Crowdin contributor's version and the one displayed on GitHub, it is extremely different. In fact, I think that there are two variants of this language, Serbian. It seems that the Crowdin contributor and the GitHub dev don't use the same variant.\r\nSo I think the Crowdin contributor needs to do a pull request himself because he will probably have to talk to the guys from jquery-validate about that.\r\nPerhaps it will be needed not to MODIFY this file but to ADD a file in order to have the two Serbian translations available (even if there are two variants of this language). In short, I think he needs to check with the concerned and then more skilled people about this topic.\r\nI see two solutions:\r\n- the easy solution is to open an issue > https://github.com/jquery-validation/jquery-validation/issues/new\r\n- he is motivated and creates a pull request if he knows how to do it, but I don't know when the plugin will be updated\r\nAnd then, we at PrestaShop will have to download this plugin new version and use it to get the \"right translation\" within the next version of the software.\r\n\r\nPlease help me to get this great program on Serbian latin language.\r\nKind regards \r\nZoran\r\n\r\n### Your environment\r\n* version of `jquery-validate`:\r\n* which browser and its version:\r\n\r\n### Steps to reproduce\r\n<!--\r\nTell us how to reproduce this issue. If possible, please provide a working demo in JSFiddle (https://jsfiddle.net) or JSBin (https://jsbin.com/).\r\n-->\r\n\r\n### Expected behaviour\r\n<!-- Tell us what should happen -->\r\n\r\n### Actual behaviour\r\n<!-- Tell us what happens instead -->\r\n"},"comment":{"url":"https://api.github.com/repos/jquery-validation/jquery-validation/issues/comments/447790269","html_url":"https://github.com/jquery-validation/jquery-validation/issues/2244#issuecomment-447790269","issue_url":"https://api.github.com/repos/jquery-validation/jquery-validation/issues/2244","id":447790269,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Nzc5MDI2OQ==","user":{"login":"matks","id":3830050,"node_id":"MDQ6VXNlcjM4MzAwNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3830050?v=4","gravatar_id":"","url":"https://api.github.com/users/matks","html_url":"https://github.com/matks","followers_url":"https://api.github.com/users/matks/followers","following_url":"https://api.github.com/users/matks/following{/other_user}","gists_url":"https://api.github.com/users/matks/gists{/gist_id}","starred_url":"https://api.github.com/users/matks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matks/subscriptions","organizations_url":"https://api.github.com/users/matks/orgs","repos_url":"https://api.github.com/users/matks/repos","events_url":"https://api.github.com/users/matks/events{/privacy}","received_events_url":"https://api.github.com/users/matks/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T10:09:34Z","updated_at":"2018-12-17T10:09:34Z","author_association":"NONE","body":"Hi,\r\n\r\nIf I can help, I am a PrestaShop developer and I had a look at this issue 😄 \r\n\r\nCurrent translation file for Serbian is https://github.com/jquery-validation/jquery-validation/blob/master/src/localization/messages_sr.js\r\n\r\n@Zoran23 suggested to modify this and replace it with this instead:\r\n```\r\n/*\r\n * Translated default messages for the jQuery validation plugin.\r\n * Locale: SR (Serbian; Srpski jezik)\r\n */\r\n(function ($) {\r\n\t$.extend($.validator.messages, {\r\n\t\trequired: \"Polje je obavezno.\",\r\n\t\tremote: \"Sredite ovo polje.\",\r\n\t\temail: \"Unesite ispravnu E-mail adresu\",\r\n\t\turl: \"Unesite ispravan URL.\",\r\n\t\tdate: \"Unesite ispravan datum.\",\r\n\t\tdateISO: \"Unesite ispravna datum (ISO).\",\r\n\t\tnumber: \"Unesite ispravan broj.\",\r\n\t\tdigits: \"Unesite samo brojeve.\",\r\n\t\tcreditcard: \"Unesite ispravan borj kreditne kartice.\",\r\n\t\tequalTo: \"Unesite istu vrednost ponovo.\",\r\n\t\taccept: \"Unesite vrednost sa odgovarajućom ekstenzijom.\",\r\n\t\tmaxlength: $.validator.format(\"Maksimalan broj znakova je {0} .\"),\r\n\t\tminlength: $.validator.format(\"Minimalan broj znakova je {0} .\"),\r\n\t\trangelength: $.validator.format(\"Unesite vrednost izmedju {0} i {1} znakova.\"),\r\n\t\trange: $.validator.format(\"Unesite vrednost izmedju {0} i {1}.\"),\r\n\t\tmax: $.validator.format(\"Unesite vrednost manju ili jednaku {0}.\"),\r\n\t\tmin: $.validator.format(\"Unesite vrednost veću ili jednaku {0}.\")\r\n\t});\r\n}(jQuery));\r\n```\r\n\r\nAs you can see it is very different, and the reason why is there are 2 variants of Serbian: cirilic and latin.\r\nIs there a way to provide users the capability to choose which variant they want ?"}}
{"actor":{"display_login":"matks"}}