{"action":"created","issue":{"url":"https://api.github.com/repos/erlang/otp/issues/1990","repository_url":"https://api.github.com/repos/erlang/otp","labels_url":"https://api.github.com/repos/erlang/otp/issues/1990/labels{/name}","comments_url":"https://api.github.com/repos/erlang/otp/issues/1990/comments","events_url":"https://api.github.com/repos/erlang/otp/issues/1990/events","html_url":"https://github.com/erlang/otp/pull/1990","id":371348089,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzODE1MzY3","number":1990,"title":"ssl: fix timezone-related bug in ssl_pem_cache","user":{"login":"max-au","id":8991837,"node_id":"MDQ6VXNlcjg5OTE4Mzc=","avatar_url":"https://avatars0.githubusercontent.com/u/8991837?v=4","gravatar_id":"","url":"https://api.github.com/users/max-au","html_url":"https://github.com/max-au","followers_url":"https://api.github.com/users/max-au/followers","following_url":"https://api.github.com/users/max-au/following{/other_user}","gists_url":"https://api.github.com/users/max-au/gists{/gist_id}","starred_url":"https://api.github.com/users/max-au/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/max-au/subscriptions","organizations_url":"https://api.github.com/users/max-au/orgs","repos_url":"https://api.github.com/users/max-au/repos","events_url":"https://api.github.com/users/max-au/events{/privacy}","received_events_url":"https://api.github.com/users/max-au/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-18T03:32:38Z","updated_at":"2018-10-18T08:01:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/erlang/otp/pulls/1990","html_url":"https://github.com/erlang/otp/pull/1990","diff_url":"https://github.com/erlang/otp/pull/1990.diff","patch_url":"https://github.com/erlang/otp/pull/1990.patch"},"body":"Caught with unit test in ssl_pem_cache_SUITE.\r\nWhen local timezone is PST (Pacific Standard Time), PEM cache was not evicting\r\nexpired entries due to file time converstion was done using\r\ncalendar:now_to_datetime, while file modification time is actually in local time."},"comment":{"url":"https://api.github.com/repos/erlang/otp/issues/comments/430913562","html_url":"https://github.com/erlang/otp/pull/1990#issuecomment-430913562","issue_url":"https://api.github.com/repos/erlang/otp/issues/1990","id":430913562,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDkxMzU2Mg==","user":{"login":"IngelaAndin","id":294507,"node_id":"MDQ6VXNlcjI5NDUwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/294507?v=4","gravatar_id":"","url":"https://api.github.com/users/IngelaAndin","html_url":"https://github.com/IngelaAndin","followers_url":"https://api.github.com/users/IngelaAndin/followers","following_url":"https://api.github.com/users/IngelaAndin/following{/other_user}","gists_url":"https://api.github.com/users/IngelaAndin/gists{/gist_id}","starred_url":"https://api.github.com/users/IngelaAndin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IngelaAndin/subscriptions","organizations_url":"https://api.github.com/users/IngelaAndin/orgs","repos_url":"https://api.github.com/users/IngelaAndin/repos","events_url":"https://api.github.com/users/IngelaAndin/events{/privacy}","received_events_url":"https://api.github.com/users/IngelaAndin/received_events","type":"User","site_admin":false},"created_at":"2018-10-18T08:01:41Z","updated_at":"2018-10-18T08:01:41Z","author_association":"CONTRIBUTOR","body":"Looks like you changed the some condition, it could be a spec that needs changing\r\n\r\n```\r\nssl_pem_cache.erl:131: Function init/1 has no local return\r\nssl_pem_cache.erl:137: Record construction #state{pem_cache::atom() | ets:tid(),last_pem_check::integer(),clear::non_neg_integer()} violates the declared type of field last_pem_check::{non_neg_integer(),non_neg_integer(),non_neg_integer()}\r\nssl_pem_cache.erl:189: Record construction #state{last_pem_check::integer(),clear::integer()} violates the declared type of field last_pem_check::{non_neg_integer(),non_neg_integer(),non_neg_integer()}\r\n```"}}
{"actor":{"display_login":"IngelaAndin"}}