{"action":"created","comment":{"url":"https://api.github.com/repos/nats-io/cnats/pulls/comments/218155125","pull_request_review_id":156031547,"id":218155125,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODE1NTEyNQ==","diff_hunk":"@@ -33,12 +33,15 @@ add_library(nats SHARED ${SOURCES} ${PS_SOURCES} ${S_SOURCES})\n target_link_libraries(nats ${NATS_OPENSSL_LIBS} ${NATS_EXTRA_LIB} ${NATS_PROTOBUF_LIB})\n add_library(nats_static STATIC ${SOURCES} ${PS_SOURCES} ${S_SOURCES})\n target_link_libraries(nats_static ${NATS_OPENSSL_LIBS} ${NATS_PROTOBUF_LIB})\n+set_target_properties(nats nats_static PROPERTIES\n+  VERSION ${NATS_VERSION_MAJOR}.${NATS_VERSION_MINOR}.${NATS_VERSION_PATCH}\n+  SOVERSION ${NATS_VERSION_MAJOR}.${NATS_VERSION_MINOR})\n \n # --------------------------------------\n # Install the libraries and header files\n # --------------------------------------\n-install(TARGETS nats DESTINATION lib)\n-install(TARGETS nats_static DESTINATION lib)\n-install(FILES deprnats.h DESTINATION include RENAME nats.h)\n-install(FILES nats.h status.h version.h DESTINATION include/nats)\n-install(FILES adapters/libevent.h adapters/libuv.h DESTINATION include/nats/adapters)\n+install(TARGETS nats DESTINATION ${NATS_LIBDIR})","path":"src/CMakeLists.txt","position":16,"original_position":16,"commit_id":"bf79168a4a7e56f18b9b39b63c0c17b5175f4421","original_commit_id":"bf79168a4a7e56f18b9b39b63c0c17b5175f4421","user":{"login":"kozlovic","id":13736691,"node_id":"MDQ6VXNlcjEzNzM2Njkx","avatar_url":"https://avatars3.githubusercontent.com/u/13736691?v=4","gravatar_id":"","url":"https://api.github.com/users/kozlovic","html_url":"https://github.com/kozlovic","followers_url":"https://api.github.com/users/kozlovic/followers","following_url":"https://api.github.com/users/kozlovic/following{/other_user}","gists_url":"https://api.github.com/users/kozlovic/gists{/gist_id}","starred_url":"https://api.github.com/users/kozlovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kozlovic/subscriptions","organizations_url":"https://api.github.com/users/kozlovic/orgs","repos_url":"https://api.github.com/users/kozlovic/repos","events_url":"https://api.github.com/users/kozlovic/events{/privacy}","received_events_url":"https://api.github.com/users/kozlovic/received_events","type":"User","site_admin":false},"body":"I gather than removing `LIBRARY` works (install the shared lib in the appropriate directory) on your platform of choice, right?","created_at":"2018-09-17T17:19:46Z","updated_at":"2018-09-17T17:19:46Z","html_url":"https://github.com/nats-io/cnats/pull/174#discussion_r218155125","pull_request_url":"https://api.github.com/repos/nats-io/cnats/pulls/174","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nats-io/cnats/pulls/comments/218155125"},"html":{"href":"https://github.com/nats-io/cnats/pull/174#discussion_r218155125"},"pull_request":{"href":"https://api.github.com/repos/nats-io/cnats/pulls/174"}}},"pull_request":{"url":"https://api.github.com/repos/nats-io/cnats/pulls/174","id":215403702,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NDAzNzAy","html_url":"https://github.com/nats-io/cnats/pull/174","diff_url":"https://github.com/nats-io/cnats/pull/174.diff","patch_url":"https://github.com/nats-io/cnats/pull/174.patch","issue_url":"https://api.github.com/repos/nats-io/cnats/issues/174","number":174,"state":"open","locked":false,"title":"Use cmake variable for deployment destinations","user":{"login":"dtoubelis","id":336503,"node_id":"MDQ6VXNlcjMzNjUwMw==","avatar_url":"https://avatars1.githubusercontent.com/u/336503?v=4","gravatar_id":"","url":"https://api.github.com/users/dtoubelis","html_url":"https://github.com/dtoubelis","followers_url":"https://api.github.com/users/dtoubelis/followers","following_url":"https://api.github.com/users/dtoubelis/following{/other_user}","gists_url":"https://api.github.com/users/dtoubelis/gists{/gist_id}","starred_url":"https://api.github.com/users/dtoubelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtoubelis/subscriptions","organizations_url":"https://api.github.com/users/dtoubelis/orgs","repos_url":"https://api.github.com/users/dtoubelis/repos","events_url":"https://api.github.com/users/dtoubelis/events{/privacy}","received_events_url":"https://api.github.com/users/dtoubelis/received_events","type":"User","site_admin":false},"body":"Here is the proper fix for the https://github.com/nats-io/cnats/pull/172.\r\n\r\nLocation of libraries and development files may be different when building for different platforms. CMake can handle this just fine, however, the current cmake configuration does not use these facilities. This merge request fixes that.","created_at":"2018-09-13T20:18:47Z","updated_at":"2018-09-17T17:19:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51b6a880bb1fe2047eb5ee4cac0f309828f77311","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nats-io/cnats/pulls/174/commits","review_comments_url":"https://api.github.com/repos/nats-io/cnats/pulls/174/comments","review_comment_url":"https://api.github.com/repos/nats-io/cnats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nats-io/cnats/issues/174/comments","statuses_url":"https://api.github.com/repos/nats-io/cnats/statuses/bf79168a4a7e56f18b9b39b63c0c17b5175f4421","head":{"label":"litmusautomation:master","ref":"master","sha":"bf79168a4a7e56f18b9b39b63c0c17b5175f4421","user":{"login":"litmusautomation","id":7135451,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxMzU0NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/7135451?v=4","gravatar_id":"","url":"https://api.github.com/users/litmusautomation","html_url":"https://github.com/litmusautomation","followers_url":"https://api.github.com/users/litmusautomation/followers","following_url":"https://api.github.com/users/litmusautomation/following{/other_user}","gists_url":"https://api.github.com/users/litmusautomation/gists{/gist_id}","starred_url":"https://api.github.com/users/litmusautomation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/litmusautomation/subscriptions","organizations_url":"https://api.github.com/users/litmusautomation/orgs","repos_url":"https://api.github.com/users/litmusautomation/repos","events_url":"https://api.github.com/users/litmusautomation/events{/privacy}","received_events_url":"https://api.github.com/users/litmusautomation/received_events","type":"Organization","site_admin":false},"repo":{"id":148414800,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg0MTQ4MDA=","name":"cnats","full_name":"litmusautomation/cnats","private":false,"owner":{"login":"litmusautomation","id":7135451,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxMzU0NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/7135451?v=4","gravatar_id":"","url":"https://api.github.com/users/litmusautomation","html_url":"https://github.com/litmusautomation","followers_url":"https://api.github.com/users/litmusautomation/followers","following_url":"https://api.github.com/users/litmusautomation/following{/other_user}","gists_url":"https://api.github.com/users/litmusautomation/gists{/gist_id}","starred_url":"https://api.github.com/users/litmusautomation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/litmusautomation/subscriptions","organizations_url":"https://api.github.com/users/litmusautomation/orgs","repos_url":"https://api.github.com/users/litmusautomation/repos","events_url":"https://api.github.com/users/litmusautomation/events{/privacy}","received_events_url":"https://api.github.com/users/litmusautomation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/litmusautomation/cnats","description":"A C client for NATS","fork":true,"url":"https://api.github.com/repos/litmusautomation/cnats","forks_url":"https://api.github.com/repos/litmusautomation/cnats/forks","keys_url":"https://api.github.com/repos/litmusautomation/cnats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/litmusautomation/cnats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/litmusautomation/cnats/teams","hooks_url":"https://api.github.com/repos/litmusautomation/cnats/hooks","issue_events_url":"https://api.github.com/repos/litmusautomation/cnats/issues/events{/number}","events_url":"https://api.github.com/repos/litmusautomation/cnats/events","assignees_url":"https://api.github.com/repos/litmusautomation/cnats/assignees{/user}","branches_url":"https://api.github.com/repos/litmusautomation/cnats/branches{/branch}","tags_url":"https://api.github.com/repos/litmusautomation/cnats/tags","blobs_url":"https://api.github.com/repos/litmusautomation/cnats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/litmusautomation/cnats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/litmusautomation/cnats/git/refs{/sha}","trees_url":"https://api.github.com/repos/litmusautomation/cnats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/litmusautomation/cnats/statuses/{sha}","languages_url":"https://api.github.com/repos/litmusautomation/cnats/languages","stargazers_url":"https://api.github.com/repos/litmusautomation/cnats/stargazers","contributors_url":"https://api.github.com/repos/litmusautomation/cnats/contributors","subscribers_url":"https://api.github.com/repos/litmusautomation/cnats/subscribers","subscription_url":"https://api.github.com/repos/litmusautomation/cnats/subscription","commits_url":"https://api.github.com/repos/litmusautomation/cnats/commits{/sha}","git_commits_url":"https://api.github.com/repos/litmusautomation/cnats/git/commits{/sha}","comments_url":"https://api.github.com/repos/litmusautomation/cnats/comments{/number}","issue_comment_url":"https://api.github.com/repos/litmusautomation/cnats/issues/comments{/number}","contents_url":"https://api.github.com/repos/litmusautomation/cnats/contents/{+path}","compare_url":"https://api.github.com/repos/litmusautomation/cnats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/litmusautomation/cnats/merges","archive_url":"https://api.github.com/repos/litmusautomation/cnats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/litmusautomation/cnats/downloads","issues_url":"https://api.github.com/repos/litmusautomation/cnats/issues{/number}","pulls_url":"https://api.github.com/repos/litmusautomation/cnats/pulls{/number}","milestones_url":"https://api.github.com/repos/litmusautomation/cnats/milestones{/number}","notifications_url":"https://api.github.com/repos/litmusautomation/cnats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/litmusautomation/cnats/labels{/name}","releases_url":"https://api.github.com/repos/litmusautomation/cnats/releases{/id}","deployments_url":"https://api.github.com/repos/litmusautomation/cnats/deployments","created_at":"2018-09-12T03:18:36Z","updated_at":"2018-09-17T13:35:35Z","pushed_at":"2018-09-17T13:35:33Z","git_url":"git://github.com/litmusautomation/cnats.git","ssh_url":"git@github.com:litmusautomation/cnats.git","clone_url":"https://github.com/litmusautomation/cnats.git","svn_url":"https://github.com/litmusautomation/cnats","homepage":null,"size":4101,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nats-io:master","ref":"master","sha":"cad601ec8459bd7d9489e8d874e0222f0d96f28c","user":{"login":"nats-io","id":10203055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjAzMDU1","avatar_url":"https://avatars2.githubusercontent.com/u/10203055?v=4","gravatar_id":"","url":"https://api.github.com/users/nats-io","html_url":"https://github.com/nats-io","followers_url":"https://api.github.com/users/nats-io/followers","following_url":"https://api.github.com/users/nats-io/following{/other_user}","gists_url":"https://api.github.com/users/nats-io/gists{/gist_id}","starred_url":"https://api.github.com/users/nats-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nats-io/subscriptions","organizations_url":"https://api.github.com/users/nats-io/orgs","repos_url":"https://api.github.com/users/nats-io/repos","events_url":"https://api.github.com/users/nats-io/events{/privacy}","received_events_url":"https://api.github.com/users/nats-io/received_events","type":"Organization","site_admin":false},"repo":{"id":43977215,"node_id":"MDEwOlJlcG9zaXRvcnk0Mzk3NzIxNQ==","name":"cnats","full_name":"nats-io/cnats","private":false,"owner":{"login":"nats-io","id":10203055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjAzMDU1","avatar_url":"https://avatars2.githubusercontent.com/u/10203055?v=4","gravatar_id":"","url":"https://api.github.com/users/nats-io","html_url":"https://github.com/nats-io","followers_url":"https://api.github.com/users/nats-io/followers","following_url":"https://api.github.com/users/nats-io/following{/other_user}","gists_url":"https://api.github.com/users/nats-io/gists{/gist_id}","starred_url":"https://api.github.com/users/nats-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nats-io/subscriptions","organizations_url":"https://api.github.com/users/nats-io/orgs","repos_url":"https://api.github.com/users/nats-io/repos","events_url":"https://api.github.com/users/nats-io/events{/privacy}","received_events_url":"https://api.github.com/users/nats-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nats-io/cnats","description":"A C client for NATS","fork":false,"url":"https://api.github.com/repos/nats-io/cnats","forks_url":"https://api.github.com/repos/nats-io/cnats/forks","keys_url":"https://api.github.com/repos/nats-io/cnats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nats-io/cnats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nats-io/cnats/teams","hooks_url":"https://api.github.com/repos/nats-io/cnats/hooks","issue_events_url":"https://api.github.com/repos/nats-io/cnats/issues/events{/number}","events_url":"https://api.github.com/repos/nats-io/cnats/events","assignees_url":"https://api.github.com/repos/nats-io/cnats/assignees{/user}","branches_url":"https://api.github.com/repos/nats-io/cnats/branches{/branch}","tags_url":"https://api.github.com/repos/nats-io/cnats/tags","blobs_url":"https://api.github.com/repos/nats-io/cnats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nats-io/cnats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nats-io/cnats/git/refs{/sha}","trees_url":"https://api.github.com/repos/nats-io/cnats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nats-io/cnats/statuses/{sha}","languages_url":"https://api.github.com/repos/nats-io/cnats/languages","stargazers_url":"https://api.github.com/repos/nats-io/cnats/stargazers","contributors_url":"https://api.github.com/repos/nats-io/cnats/contributors","subscribers_url":"https://api.github.com/repos/nats-io/cnats/subscribers","subscription_url":"https://api.github.com/repos/nats-io/cnats/subscription","commits_url":"https://api.github.com/repos/nats-io/cnats/commits{/sha}","git_commits_url":"https://api.github.com/repos/nats-io/cnats/git/commits{/sha}","comments_url":"https://api.github.com/repos/nats-io/cnats/comments{/number}","issue_comment_url":"https://api.github.com/repos/nats-io/cnats/issues/comments{/number}","contents_url":"https://api.github.com/repos/nats-io/cnats/contents/{+path}","compare_url":"https://api.github.com/repos/nats-io/cnats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nats-io/cnats/merges","archive_url":"https://api.github.com/repos/nats-io/cnats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nats-io/cnats/downloads","issues_url":"https://api.github.com/repos/nats-io/cnats/issues{/number}","pulls_url":"https://api.github.com/repos/nats-io/cnats/pulls{/number}","milestones_url":"https://api.github.com/repos/nats-io/cnats/milestones{/number}","notifications_url":"https://api.github.com/repos/nats-io/cnats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nats-io/cnats/labels{/name}","releases_url":"https://api.github.com/repos/nats-io/cnats/releases{/id}","deployments_url":"https://api.github.com/repos/nats-io/cnats/deployments","created_at":"2015-10-09T19:57:17Z","updated_at":"2018-09-16T23:08:30Z","pushed_at":"2018-09-17T13:35:34Z","git_url":"git://github.com/nats-io/cnats.git","ssh_url":"git@github.com:nats-io/cnats.git","clone_url":"https://github.com/nats-io/cnats.git","svn_url":"https://github.com/nats-io/cnats","homepage":null,"size":4230,"stargazers_count":110,"watchers_count":110,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":33,"open_issues":3,"watchers":110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nats-io/cnats/pulls/174"},"html":{"href":"https://github.com/nats-io/cnats/pull/174"},"issue":{"href":"https://api.github.com/repos/nats-io/cnats/issues/174"},"comments":{"href":"https://api.github.com/repos/nats-io/cnats/issues/174/comments"},"review_comments":{"href":"https://api.github.com/repos/nats-io/cnats/pulls/174/comments"},"review_comment":{"href":"https://api.github.com/repos/nats-io/cnats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nats-io/cnats/pulls/174/commits"},"statuses":{"href":"https://api.github.com/repos/nats-io/cnats/statuses/bf79168a4a7e56f18b9b39b63c0c17b5175f4421"}},"author_association":"NONE"}}
{"actor":{"display_login":"kozlovic"}}