{"action":"created","issue":{"url":"https://api.github.com/repos/reactioncommerce/reaction/issues/4316","repository_url":"https://api.github.com/repos/reactioncommerce/reaction","labels_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/4316/labels{/name}","comments_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/4316/comments","events_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/4316/events","html_url":"https://github.com/reactioncommerce/reaction/pull/4316","id":331129739,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzOTM2MzQw","number":4316,"title":"added CDN settings to reaction","user":{"login":"Akarshit","id":7762605,"node_id":"MDQ6VXNlcjc3NjI2MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/7762605?v=4","gravatar_id":"","url":"https://api.github.com/users/Akarshit","html_url":"https://github.com/Akarshit","followers_url":"https://api.github.com/users/Akarshit/followers","following_url":"https://api.github.com/users/Akarshit/following{/other_user}","gists_url":"https://api.github.com/users/Akarshit/gists{/gist_id}","starred_url":"https://api.github.com/users/Akarshit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akarshit/subscriptions","organizations_url":"https://api.github.com/users/Akarshit/orgs","repos_url":"https://api.github.com/users/Akarshit/repos","events_url":"https://api.github.com/users/Akarshit/events{/privacy}","received_events_url":"https://api.github.com/users/Akarshit/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-06-11T10:22:32Z","updated_at":"2018-07-02T05:00:56Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/reactioncommerce/reaction/pulls/4316","html_url":"https://github.com/reactioncommerce/reaction/pull/4316","diff_url":"https://github.com/reactioncommerce/reaction/pull/4316.diff","patch_url":"https://github.com/reactioncommerce/reaction/pull/4316.patch"},"body":"Resolves #4315   \r\nImpact: **minor**  \r\nType: **feature**\r\n\r\n## Issue\r\nAfter creating the production bundle from reaction, if the user wants to serve the bundled js and css files, there is no native way to do it.\r\n\r\n## Solution\r\nMeteor provides a function to set the serving URL of the `js` and `css` files, so I am just passing the CDN's URL from setting file to Meteor. \r\n\r\n\r\n## Testing\r\n1. Build the production bundle from reaction using `meteor build --directory \"build dir\"`\r\n1. `cd \"build dir\"/bundle/programs/server`\r\n1. `npm install`\r\n1. `cd \"build dir\"/bundle`\r\n1. `PORT=4000 ROOT_URL=http://localhost.com METEOR_SETTINGS=\"{ \\\"cdnPrefix\\\": \\\"cdnURL\\\" }\" node main.js`\r\n1. Observe from the Network tab in your browser that reaction tries to get the `js` and `css` files from the \"cdnURL\""},"comment":{"url":"https://api.github.com/repos/reactioncommerce/reaction/issues/comments/401672995","html_url":"https://github.com/reactioncommerce/reaction/pull/4316#issuecomment-401672995","issue_url":"https://api.github.com/repos/reactioncommerce/reaction/issues/4316","id":401672995,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTY3Mjk5NQ==","user":{"login":"zenweasel","id":72819,"node_id":"MDQ6VXNlcjcyODE5","avatar_url":"https://avatars1.githubusercontent.com/u/72819?v=4","gravatar_id":"","url":"https://api.github.com/users/zenweasel","html_url":"https://github.com/zenweasel","followers_url":"https://api.github.com/users/zenweasel/followers","following_url":"https://api.github.com/users/zenweasel/following{/other_user}","gists_url":"https://api.github.com/users/zenweasel/gists{/gist_id}","starred_url":"https://api.github.com/users/zenweasel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenweasel/subscriptions","organizations_url":"https://api.github.com/users/zenweasel/orgs","repos_url":"https://api.github.com/users/zenweasel/repos","events_url":"https://api.github.com/users/zenweasel/events{/privacy}","received_events_url":"https://api.github.com/users/zenweasel/received_events","type":"User","site_admin":false},"created_at":"2018-07-02T05:00:56Z","updated_at":"2018-07-02T05:00:56Z","author_association":"MEMBER","body":"I am expecting to get:\r\n\r\n```\r\ncdnURL/5c9381ddcbcae43f804286621e340b1b0d34f882.js?meteor_js_resource=true\r\n```"}}
{"actor":{"display_login":"zenweasel"}}