{"action":"created","issue":{"url":"https://api.github.com/repos/openAVproductions/openAV-Luppp/issues/228","repository_url":"https://api.github.com/repos/openAVproductions/openAV-Luppp","labels_url":"https://api.github.com/repos/openAVproductions/openAV-Luppp/issues/228/labels{/name}","comments_url":"https://api.github.com/repos/openAVproductions/openAV-Luppp/issues/228/comments","events_url":"https://api.github.com/repos/openAVproductions/openAV-Luppp/issues/228/events","html_url":"https://github.com/openAVproductions/openAV-Luppp/issues/228","id":320791905,"number":228,"title":"Input Signal Flow Problems","user":{"login":"georgkrause","id":939889,"avatar_url":"https://avatars0.githubusercontent.com/u/939889?v=4","gravatar_id":"","url":"https://api.github.com/users/georgkrause","html_url":"https://github.com/georgkrause","followers_url":"https://api.github.com/users/georgkrause/followers","following_url":"https://api.github.com/users/georgkrause/following{/other_user}","gists_url":"https://api.github.com/users/georgkrause/gists{/gist_id}","starred_url":"https://api.github.com/users/georgkrause/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgkrause/subscriptions","organizations_url":"https://api.github.com/users/georgkrause/orgs","repos_url":"https://api.github.com/users/georgkrause/repos","events_url":"https://api.github.com/users/georgkrause/events{/privacy}","received_events_url":"https://api.github.com/users/georgkrause/received_events","type":"User","site_admin":false},"labels":[{"id":488340486,"url":"https://api.github.com/repos/openAVproductions/openAV-Luppp/labels/Bug","name":"Bug","color":"fbca04","default":false},{"id":216448,"url":"https://api.github.com/repos/openAVproductions/openAV-Luppp/labels/In%20progress","name":"In progress","color":"0e8a16","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/openAVproductions/openAV-Luppp/milestones/5","html_url":"https://github.com/openAVproductions/openAV-Luppp/milestone/5","labels_url":"https://api.github.com/repos/openAVproductions/openAV-Luppp/milestones/5/labels","id":2504240,"number":5,"title":"Release 1.1.2","description":"Minor improvements and Bugfix release","creator":{"login":"harryhaaren","id":106664,"avatar_url":"https://avatars1.githubusercontent.com/u/106664?v=4","gravatar_id":"","url":"https://api.github.com/users/harryhaaren","html_url":"https://github.com/harryhaaren","followers_url":"https://api.github.com/users/harryhaaren/followers","following_url":"https://api.github.com/users/harryhaaren/following{/other_user}","gists_url":"https://api.github.com/users/harryhaaren/gists{/gist_id}","starred_url":"https://api.github.com/users/harryhaaren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harryhaaren/subscriptions","organizations_url":"https://api.github.com/users/harryhaaren/orgs","repos_url":"https://api.github.com/users/harryhaaren/repos","events_url":"https://api.github.com/users/harryhaaren/events{/privacy}","received_events_url":"https://api.github.com/users/harryhaaren/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":12,"state":"open","created_at":"2017-05-06T12:05:31Z","updated_at":"2018-05-22T13:05:40Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-05-07T12:49:11Z","updated_at":"2018-05-22T13:05:40Z","closed_at":"2018-05-22T13:05:39Z","author_association":"MEMBER","body":"in `looper.cxx` line 121-123:\r\n\r\n```\r\n\t\t\tfloat* inputL = buffers->audio[Buffers::MASTER_INPUT_L];\r\n\t\t\tfloat* inputR = buffers->audio[Buffers::MASTER_INPUT_R];\r\n\t\t\tclips[clip]->record( nframes, inputL, inputR);\r\n```\r\n\r\nWhich means that the input is directly recorded and the input volume fader does not have any effect on the volume of the clips. So this fader is basically useless, because you can control the volume of the input passed to the outputs with another knob. We could remove the fader or record the clips after the fader."},"comment":{"url":"https://api.github.com/repos/openAVproductions/openAV-Luppp/issues/comments/390982411","html_url":"https://github.com/openAVproductions/openAV-Luppp/issues/228#issuecomment-390982411","issue_url":"https://api.github.com/repos/openAVproductions/openAV-Luppp/issues/228","id":390982411,"user":{"login":"georgkrause","id":939889,"avatar_url":"https://avatars0.githubusercontent.com/u/939889?v=4","gravatar_id":"","url":"https://api.github.com/users/georgkrause","html_url":"https://github.com/georgkrause","followers_url":"https://api.github.com/users/georgkrause/followers","following_url":"https://api.github.com/users/georgkrause/following{/other_user}","gists_url":"https://api.github.com/users/georgkrause/gists{/gist_id}","starred_url":"https://api.github.com/users/georgkrause/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgkrause/subscriptions","organizations_url":"https://api.github.com/users/georgkrause/orgs","repos_url":"https://api.github.com/users/georgkrause/repos","events_url":"https://api.github.com/users/georgkrause/events{/privacy}","received_events_url":"https://api.github.com/users/georgkrause/received_events","type":"User","site_admin":false},"created_at":"2018-05-22T13:05:39Z","updated_at":"2018-05-22T13:05:39Z","author_association":"MEMBER","body":"fixed because of #230"}}
{"actor":{"display_login":"georgkrause"}}