{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/20352","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/20352/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/20352/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/20352/events","html_url":"https://github.com/openshift/origin/pull/20352","id":342365043,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMjgxNDc3","number":20352,"title":"Stabilize ingressip controller unit test","user":{"login":"ironcladlou","id":298299,"node_id":"MDQ6VXNlcjI5ODI5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/298299?v=4","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false},"labels":[{"id":640548394,"node_id":"MDU6TGFiZWw2NDA1NDgzOTQ=","url":"https://api.github.com/repos/openshift/origin/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-18T14:55:02Z","updated_at":"2018-07-18T15:38:35Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/20352","html_url":"https://github.com/openshift/origin/pull/20352","diff_url":"https://github.com/openshift/origin/pull/20352.diff","patch_url":"https://github.com/openshift/origin/pull/20352.patch"},"body":"Eliminate flakes in the TestBasicControllerFlow test by polling fake action\r\nstate rather than relying on custom fake watch consumption; the event counts on\r\nthe watch are not deterministic, and so the previous assumption of two events\r\ndoesn't always hold and causes a deadlock in the test's custom controller\r\nhandler.\r\n\r\nRefactor the test to remove unnecessary fake watch and controller setup; just\r\nuse the fake client and its built-in watch capabilities directly.\r\n\r\nAdd stronger update validity assertions.\r\n\r\n/xref https://github.com/openshift/origin/issues/20168\r\n/xref [this flake](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/batch/pull-ci-origin-unit/984/#githubcomopenshiftoriginpkgservicecontrolleringressip-testbasiccontrollerflow)\r\n\r\n/cc @openshift/sig-network-edge \r\n/cc @smarterclayton "},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/405975888","html_url":"https://github.com/openshift/origin/pull/20352#issuecomment-405975888","issue_url":"https://api.github.com/repos/openshift/origin/issues/20352","id":405975888,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTk3NTg4OA==","user":{"login":"openshift-ci-robot","id":30189103,"node_id":"MDQ6VXNlcjMwMTg5MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-07-18T15:38:35Z","updated_at":"2018-07-18T15:38:35Z","author_association":"NONE","body":"@ironcladlou: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nci/openshift-jenkins/cmd | 01792849b14ad0084ef383bfd7917a2b422f75df | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/20352/test_pull_request_origin_cmd/15770/) | `/test cmd`\nci/prow/gcp | 01792849b14ad0084ef383bfd7917a2b422f75df | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/20352/pull-ci-origin-e2e-gcp/1129/) | `/test gcp`\n\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"openshift-ci-robot"}}