{"action":"created","issue":{"url":"https://api.github.com/repos/esi/esi-issues/issues/1005","repository_url":"https://api.github.com/repos/esi/esi-issues","labels_url":"https://api.github.com/repos/esi/esi-issues/issues/1005/labels{/name}","comments_url":"https://api.github.com/repos/esi/esi-issues/issues/1005/comments","events_url":"https://api.github.com/repos/esi/esi-issues/issues/1005/events","html_url":"https://github.com/esi/esi-issues/issues/1005","id":347064360,"node_id":"MDU6SXNzdWUzNDcwNjQzNjA=","number":1005,"title":"[meta] Proposing a non 404 HTML Response Code during ESI Maintenance","user":{"login":"cvweiss","id":739285,"node_id":"MDQ6VXNlcjczOTI4NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/739285?v=4","gravatar_id":"","url":"https://api.github.com/users/cvweiss","html_url":"https://github.com/cvweiss","followers_url":"https://api.github.com/users/cvweiss/followers","following_url":"https://api.github.com/users/cvweiss/following{/other_user}","gists_url":"https://api.github.com/users/cvweiss/gists{/gist_id}","starred_url":"https://api.github.com/users/cvweiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvweiss/subscriptions","organizations_url":"https://api.github.com/users/cvweiss/orgs","repos_url":"https://api.github.com/users/cvweiss/repos","events_url":"https://api.github.com/users/cvweiss/events{/privacy}","received_events_url":"https://api.github.com/users/cvweiss/received_events","type":"User","site_admin":false},"labels":[{"id":478436729,"node_id":"MDU6TGFiZWw0Nzg0MzY3Mjk=","url":"https://api.github.com/repos/esi/esi-issues/labels/esi-router","name":"esi-router","color":"fef2c0","default":false},{"id":478599555,"node_id":"MDU6TGFiZWw0Nzg1OTk1NTU=","url":"https://api.github.com/repos/esi/esi-issues/labels/feature%20request","name":"feature request","color":"0052cc","default":false},{"id":898127539,"node_id":"MDU6TGFiZWw4OTgxMjc1Mzk=","url":"https://api.github.com/repos/esi/esi-issues/labels/meta","name":"meta","color":"f41326","default":false}],"state":"open","locked":false,"assignee":{"login":"a-tal","id":1832772,"node_id":"MDQ6VXNlcjE4MzI3NzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1832772?v=4","gravatar_id":"","url":"https://api.github.com/users/a-tal","html_url":"https://github.com/a-tal","followers_url":"https://api.github.com/users/a-tal/followers","following_url":"https://api.github.com/users/a-tal/following{/other_user}","gists_url":"https://api.github.com/users/a-tal/gists{/gist_id}","starred_url":"https://api.github.com/users/a-tal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-tal/subscriptions","organizations_url":"https://api.github.com/users/a-tal/orgs","repos_url":"https://api.github.com/users/a-tal/repos","events_url":"https://api.github.com/users/a-tal/events{/privacy}","received_events_url":"https://api.github.com/users/a-tal/received_events","type":"User","site_admin":false},"assignees":[{"login":"a-tal","id":1832772,"node_id":"MDQ6VXNlcjE4MzI3NzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1832772?v=4","gravatar_id":"","url":"https://api.github.com/users/a-tal","html_url":"https://github.com/a-tal","followers_url":"https://api.github.com/users/a-tal/followers","following_url":"https://api.github.com/users/a-tal/following{/other_user}","gists_url":"https://api.github.com/users/a-tal/gists{/gist_id}","starred_url":"https://api.github.com/users/a-tal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-tal/subscriptions","organizations_url":"https://api.github.com/users/a-tal/orgs","repos_url":"https://api.github.com/users/a-tal/repos","events_url":"https://api.github.com/users/a-tal/events{/privacy}","received_events_url":"https://api.github.com/users/a-tal/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-08-02T15:31:40Z","updated_at":"2018-08-02T15:35:21Z","closed_at":null,"author_association":"NONE","body":"Currently when ESI is under maintenance it will throw a 404 html response which is a valid response for many endpoints and gets treated as \"X does not exist\", therefore code will remove X.\r\n\r\n1633218082 - Squizz Caphinator, a valid character, will have the following response during ESI maintenance:\r\n\r\n    2018-08-02 15:21:58 > Client error: `GET https://esi.evetech.net/v4/characters/1633218082/` resulted in a `404 Not Found` response:\r\n    {\"error\":\"Not found\"}\r\n\r\nI propose changing the 404 to a 418 instead, to prevent confusion and conflicts between valid 404's and ESI maintenance 404's.\r\n\r\n![2f5s6y](https://user-images.githubusercontent.com/739285/43594026-32845bda-9647-11e8-9533-a0a7b4ee58a9.jpg)\r\n"},"comment":{"url":"https://api.github.com/repos/esi/esi-issues/issues/comments/409969658","html_url":"https://github.com/esi/esi-issues/issues/1005#issuecomment-409969658","issue_url":"https://api.github.com/repos/esi/esi-issues/issues/1005","id":409969658,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTk2OTY1OA==","user":{"login":"BoraVyvorant","id":12691802,"node_id":"MDQ6VXNlcjEyNjkxODAy","avatar_url":"https://avatars3.githubusercontent.com/u/12691802?v=4","gravatar_id":"","url":"https://api.github.com/users/BoraVyvorant","html_url":"https://github.com/BoraVyvorant","followers_url":"https://api.github.com/users/BoraVyvorant/followers","following_url":"https://api.github.com/users/BoraVyvorant/following{/other_user}","gists_url":"https://api.github.com/users/BoraVyvorant/gists{/gist_id}","starred_url":"https://api.github.com/users/BoraVyvorant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BoraVyvorant/subscriptions","organizations_url":"https://api.github.com/users/BoraVyvorant/orgs","repos_url":"https://api.github.com/users/BoraVyvorant/repos","events_url":"https://api.github.com/users/BoraVyvorant/events{/privacy}","received_events_url":"https://api.github.com/users/BoraVyvorant/received_events","type":"User","site_admin":false},"created_at":"2018-08-02T15:35:21Z","updated_at":"2018-08-02T15:35:21Z","author_association":"NONE","body":"Seems to me that `503 Service Unavailable` would be a more obvious response than `418 I'm a teapot`. From RFC 7231 6.6.4:\r\n\r\n>The 503 (Service Unavailable) status code indicates that the server\r\n   is currently unable to handle the request due to a temporary overload\r\n   or scheduled maintenance, which will likely be alleviated after some\r\n   delay."}}
{"actor":{"display_login":"BoraVyvorant"}}