{"action":"created","comment":{"url":"https://api.github.com/repos/google/xi-editor/pulls/comments/189059995","pull_request_review_id":121166234,"id":189059995,"diff_hunk":"@@ -73,20 +69,11 @@ pub struct View {\n     /// description for the invariant.\n     lc_shadow: LineCacheShadow,\n \n-    /// The occurrences, which determine the highlights, have been updated.\n-    hls_dirty: bool,\n-\n     /// New offset to be scrolled into position after an edit.\n     scroll_to: Option<usize>,\n \n-    /// The currently active search string\n-    search_string: Option<String>,\n-    /// The case matching setting for the currently active search\n-    case_matching: CaseMatching,\n-    /// The set of all known find occurrences (highlights)\n-    occurrences: Option<Selection>,\n-    /// Set of ranges that have already been searched for the currently active search string\n-    valid_search: IndexSet,\n+    /// The state for finding text for this view.\n+    find: Find,","path":"rust/core-lib/src/view.rs","position":53,"original_position":53,"commit_id":"9fd91f7052e6589131b43d3c0476feac617719a9","original_commit_id":"9fd91f7052e6589131b43d3c0476feac617719a9","user":{"login":"scholtzan","id":1239705,"avatar_url":"https://avatars2.githubusercontent.com/u/1239705?v=4","gravatar_id":"","url":"https://api.github.com/users/scholtzan","html_url":"https://github.com/scholtzan","followers_url":"https://api.github.com/users/scholtzan/followers","following_url":"https://api.github.com/users/scholtzan/following{/other_user}","gists_url":"https://api.github.com/users/scholtzan/gists{/gist_id}","starred_url":"https://api.github.com/users/scholtzan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholtzan/subscriptions","organizations_url":"https://api.github.com/users/scholtzan/orgs","repos_url":"https://api.github.com/users/scholtzan/repos","events_url":"https://api.github.com/users/scholtzan/events{/privacy}","received_events_url":"https://api.github.com/users/scholtzan/received_events","type":"User","site_admin":false},"body":"If we have one `Find` instance for each query then they would be stored in `Vec` otherwise `Option<Find>`.","created_at":"2018-05-17T18:36:21Z","updated_at":"2018-05-17T18:36:22Z","html_url":"https://github.com/google/xi-editor/pull/649#discussion_r189059995","pull_request_url":"https://api.github.com/repos/google/xi-editor/pulls/649","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/google/xi-editor/pulls/comments/189059995"},"html":{"href":"https://github.com/google/xi-editor/pull/649#discussion_r189059995"},"pull_request":{"href":"https://api.github.com/repos/google/xi-editor/pulls/649"}},"in_reply_to_id":188788043},"pull_request":{"url":"https://api.github.com/repos/google/xi-editor/pulls/649","id":187065365,"html_url":"https://github.com/google/xi-editor/pull/649","diff_url":"https://github.com/google/xi-editor/pull/649.diff","patch_url":"https://github.com/google/xi-editor/pull/649.patch","issue_url":"https://api.github.com/repos/google/xi-editor/issues/649","number":649,"state":"open","locked":false,"title":"[WIP] Find enhancements","user":{"login":"scholtzan","id":1239705,"avatar_url":"https://avatars2.githubusercontent.com/u/1239705?v=4","gravatar_id":"","url":"https://api.github.com/users/scholtzan","html_url":"https://github.com/scholtzan","followers_url":"https://api.github.com/users/scholtzan/followers","following_url":"https://api.github.com/users/scholtzan/following{/other_user}","gists_url":"https://api.github.com/users/scholtzan/gists{/gist_id}","starred_url":"https://api.github.com/users/scholtzan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholtzan/subscriptions","organizations_url":"https://api.github.com/users/scholtzan/orgs","repos_url":"https://api.github.com/users/scholtzan/repos","events_url":"https://api.github.com/users/scholtzan/events{/privacy}","received_events_url":"https://api.github.com/users/scholtzan/received_events","type":"User","site_admin":false},"body":"Outsourced find logic from `view`","created_at":"2018-05-09T23:24:20Z","updated_at":"2018-05-17T18:36:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"329791c1b4aa21aaaaa23ef8d504006b7038a4d1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":365718022,"url":"https://api.github.com/repos/google/xi-editor/labels/cla:%20yes","name":"cla: yes","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/xi-editor/pulls/649/commits","review_comments_url":"https://api.github.com/repos/google/xi-editor/pulls/649/comments","review_comment_url":"https://api.github.com/repos/google/xi-editor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/xi-editor/issues/649/comments","statuses_url":"https://api.github.com/repos/google/xi-editor/statuses/9fd91f7052e6589131b43d3c0476feac617719a9","head":{"label":"scholtzan:find-enhancements","ref":"find-enhancements","sha":"9fd91f7052e6589131b43d3c0476feac617719a9","user":{"login":"scholtzan","id":1239705,"avatar_url":"https://avatars2.githubusercontent.com/u/1239705?v=4","gravatar_id":"","url":"https://api.github.com/users/scholtzan","html_url":"https://github.com/scholtzan","followers_url":"https://api.github.com/users/scholtzan/followers","following_url":"https://api.github.com/users/scholtzan/following{/other_user}","gists_url":"https://api.github.com/users/scholtzan/gists{/gist_id}","starred_url":"https://api.github.com/users/scholtzan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholtzan/subscriptions","organizations_url":"https://api.github.com/users/scholtzan/orgs","repos_url":"https://api.github.com/users/scholtzan/repos","events_url":"https://api.github.com/users/scholtzan/events{/privacy}","received_events_url":"https://api.github.com/users/scholtzan/received_events","type":"User","site_admin":false},"repo":{"id":121591074,"name":"xi-editor","full_name":"scholtzan/xi-editor","owner":{"login":"scholtzan","id":1239705,"avatar_url":"https://avatars2.githubusercontent.com/u/1239705?v=4","gravatar_id":"","url":"https://api.github.com/users/scholtzan","html_url":"https://github.com/scholtzan","followers_url":"https://api.github.com/users/scholtzan/followers","following_url":"https://api.github.com/users/scholtzan/following{/other_user}","gists_url":"https://api.github.com/users/scholtzan/gists{/gist_id}","starred_url":"https://api.github.com/users/scholtzan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholtzan/subscriptions","organizations_url":"https://api.github.com/users/scholtzan/orgs","repos_url":"https://api.github.com/users/scholtzan/repos","events_url":"https://api.github.com/users/scholtzan/events{/privacy}","received_events_url":"https://api.github.com/users/scholtzan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scholtzan/xi-editor","description":"A modern editor with a backend written in Rust.","fork":true,"url":"https://api.github.com/repos/scholtzan/xi-editor","forks_url":"https://api.github.com/repos/scholtzan/xi-editor/forks","keys_url":"https://api.github.com/repos/scholtzan/xi-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scholtzan/xi-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scholtzan/xi-editor/teams","hooks_url":"https://api.github.com/repos/scholtzan/xi-editor/hooks","issue_events_url":"https://api.github.com/repos/scholtzan/xi-editor/issues/events{/number}","events_url":"https://api.github.com/repos/scholtzan/xi-editor/events","assignees_url":"https://api.github.com/repos/scholtzan/xi-editor/assignees{/user}","branches_url":"https://api.github.com/repos/scholtzan/xi-editor/branches{/branch}","tags_url":"https://api.github.com/repos/scholtzan/xi-editor/tags","blobs_url":"https://api.github.com/repos/scholtzan/xi-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scholtzan/xi-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scholtzan/xi-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/scholtzan/xi-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scholtzan/xi-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/scholtzan/xi-editor/languages","stargazers_url":"https://api.github.com/repos/scholtzan/xi-editor/stargazers","contributors_url":"https://api.github.com/repos/scholtzan/xi-editor/contributors","subscribers_url":"https://api.github.com/repos/scholtzan/xi-editor/subscribers","subscription_url":"https://api.github.com/repos/scholtzan/xi-editor/subscription","commits_url":"https://api.github.com/repos/scholtzan/xi-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/scholtzan/xi-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/scholtzan/xi-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/scholtzan/xi-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/scholtzan/xi-editor/contents/{+path}","compare_url":"https://api.github.com/repos/scholtzan/xi-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scholtzan/xi-editor/merges","archive_url":"https://api.github.com/repos/scholtzan/xi-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scholtzan/xi-editor/downloads","issues_url":"https://api.github.com/repos/scholtzan/xi-editor/issues{/number}","pulls_url":"https://api.github.com/repos/scholtzan/xi-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/scholtzan/xi-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/scholtzan/xi-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scholtzan/xi-editor/labels{/name}","releases_url":"https://api.github.com/repos/scholtzan/xi-editor/releases{/id}","deployments_url":"https://api.github.com/repos/scholtzan/xi-editor/deployments","created_at":"2018-02-15T04:29:11Z","updated_at":"2018-05-08T21:52:55Z","pushed_at":"2018-05-17T18:11:28Z","git_url":"git://github.com/scholtzan/xi-editor.git","ssh_url":"git@github.com:scholtzan/xi-editor.git","clone_url":"https://github.com/scholtzan/xi-editor.git","svn_url":"https://github.com/scholtzan/xi-editor","homepage":"","size":4897,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"e4f6a0a8947d34510ff31426a8470faa1dbb698c","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":57167764,"name":"xi-editor","full_name":"google/xi-editor","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/xi-editor","description":"A modern editor with a backend written in Rust. https://google.github.io/xi-editor","fork":false,"url":"https://api.github.com/repos/google/xi-editor","forks_url":"https://api.github.com/repos/google/xi-editor/forks","keys_url":"https://api.github.com/repos/google/xi-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/xi-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/xi-editor/teams","hooks_url":"https://api.github.com/repos/google/xi-editor/hooks","issue_events_url":"https://api.github.com/repos/google/xi-editor/issues/events{/number}","events_url":"https://api.github.com/repos/google/xi-editor/events","assignees_url":"https://api.github.com/repos/google/xi-editor/assignees{/user}","branches_url":"https://api.github.com/repos/google/xi-editor/branches{/branch}","tags_url":"https://api.github.com/repos/google/xi-editor/tags","blobs_url":"https://api.github.com/repos/google/xi-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/xi-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/xi-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/xi-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/xi-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/google/xi-editor/languages","stargazers_url":"https://api.github.com/repos/google/xi-editor/stargazers","contributors_url":"https://api.github.com/repos/google/xi-editor/contributors","subscribers_url":"https://api.github.com/repos/google/xi-editor/subscribers","subscription_url":"https://api.github.com/repos/google/xi-editor/subscription","commits_url":"https://api.github.com/repos/google/xi-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/xi-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/xi-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/xi-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/xi-editor/contents/{+path}","compare_url":"https://api.github.com/repos/google/xi-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/xi-editor/merges","archive_url":"https://api.github.com/repos/google/xi-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/xi-editor/downloads","issues_url":"https://api.github.com/repos/google/xi-editor/issues{/number}","pulls_url":"https://api.github.com/repos/google/xi-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/google/xi-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/google/xi-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/xi-editor/labels{/name}","releases_url":"https://api.github.com/repos/google/xi-editor/releases{/id}","deployments_url":"https://api.github.com/repos/google/xi-editor/deployments","created_at":"2016-04-26T23:03:23Z","updated_at":"2018-05-17T14:30:22Z","pushed_at":"2018-05-17T18:11:30Z","git_url":"git://github.com/google/xi-editor.git","ssh_url":"git@github.com:google/xi-editor.git","clone_url":"https://github.com/google/xi-editor.git","svn_url":"https://github.com/google/xi-editor","homepage":"","size":4857,"stargazers_count":12526,"watchers_count":12526,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":435,"mirror_url":null,"archived":false,"open_issues_count":125,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":435,"open_issues":125,"watchers":12526,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/xi-editor/pulls/649"},"html":{"href":"https://github.com/google/xi-editor/pull/649"},"issue":{"href":"https://api.github.com/repos/google/xi-editor/issues/649"},"comments":{"href":"https://api.github.com/repos/google/xi-editor/issues/649/comments"},"review_comments":{"href":"https://api.github.com/repos/google/xi-editor/pulls/649/comments"},"review_comment":{"href":"https://api.github.com/repos/google/xi-editor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/xi-editor/pulls/649/commits"},"statuses":{"href":"https://api.github.com/repos/google/xi-editor/statuses/9fd91f7052e6589131b43d3c0476feac617719a9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"scholtzan"}}