{"action":"created","comment":{"url":"https://api.github.com/repos/pie-framework/pie-lib/pulls/comments/177161913","pull_request_review_id":106981789,"id":177161913,"diff_hunk":"@@ -0,0 +1,152 @@\n+import React from \"react\";\n+\n+import {configure} from \"enzyme\";\n+import Adapter from \"enzyme-adapter-react-15\";\n+import renderer from 'react-test-renderer';\n+import List from './../../list/index';\n+import Util from '../../utils';\n+\n+configure({adapter : new Adapter() });\n+\n+describe(\"ListPlugin\", () => {\n+  let list, ListPlugin, toolbar;\n+  beforeEach(() => {\n+    list = require('../index');\n+    ListPlugin = list.default;\n+    toolbar = list.toolbar\n+  });\n+\n+  describe(\"deserialize\", () => {\n+    it(\"should deserialize list item\", () => {\n+      let el = {\n+        tagName : 'li',\n+        childNodes : []\n+      }\n+      const next = jest.fn();\n+      const out = list.serialization.deserialize(el, next);\n+\n+      expect(out).toMatchObject({object : 'block', type : 'list_item', nodes: undefined});\n+    });\n+\n+    it(\"should deserialize ul\", () => {\n+      let el = {\n+        tagName : 'ul',\n+        childNodes : []\n+      }\n+      const next = jest.fn();\n+      const out = list.serialization.deserialize(el, next);\n+\n+      expect(out).toMatchObject({object : 'block', type : 'ul_list', nodes: undefined});\n+    });    \n+\n+    it(\"should deserialize ol\", () => {\n+      let el = {\n+        tagName : 'ol',\n+        childNodes : []\n+      }\n+      const next = jest.fn();\n+      const out = list.serialization.deserialize(el, next);\n+\n+      expect(out).toMatchObject({object : 'block', type : 'ol_list', nodes: undefined});\n+    });        \n+  });\n+\n+  describe(\"serialize\", () => {\n+    it(\"should serialize list item\", () => {\n+      let el = {\n+        block : 'block',\n+        type : 'list_item'\n+        \n+      }\n+      const out = list.serialization.serialize(el, {\n+        type:'div',\n+        text : 'hello'\n+      });\n+\n+      expect(out.type).toMatch('li');\n+    });    \n+\n+    it(\"should serialize ul\", () => {\n+      let el = {\n+        block : 'block',\n+        type : 'ul_list'\n+        \n+      }\n+      const out = list.serialization.serialize(el, {\n+        type:'div',\n+        text : 'hello'\n+      });\n+\n+      expect(out.type).toMatch('ul');\n+    });    \n+    \n+    it(\"should serialize ol\", () => {\n+      let el = {\n+        block : 'block',\n+        type : 'ol_list'\n+        \n+      }\n+      const out = list.serialization.serialize(el, {\n+        type:'div',\n+        text : 'hello'\n+      });\n+\n+      expect(out.type).toMatch('ol');\n+    });        \n+  });\n+  describe(\"renderNode\", () => {\n+    it(\"should render list item node\", () => {\n+      let obj = {\n+        node : {\n+          type : 'list_item'\n+        },\n+        attributes : {},\n+        children : 'icon'\n+      }\n+\n+      let plugin = ListPlugin({});\n+      const out = plugin.renderNode(obj);\n+      expect(out.type).toMatch('li');\n+    });\n+\n+    it(\"should render ul node\", () => {\n+      let obj = {\n+        node : {\n+          type : 'ul_list'\n+        },\n+        attributes : {},\n+        children : 'icon'\n+      }\n+\n+      let plugin = ListPlugin({});\n+      const out = plugin.renderNode(obj);\n+      expect(out.type).toMatch('ul');\n+    });\n+    \n+    it(\"should render list item node\", () => {\n+      let obj = {\n+        node : {\n+          type : 'ol_list'\n+        },\n+        attributes : {},\n+        children : 'icon'\n+      }\n+\n+      let plugin = ListPlugin({});\n+      const out = plugin.renderNode(obj);\n+      expect(out.type).toMatch('ol');\n+    });    \n+  });  \n+\n+  describe(\"toolbar\", () => {\n+    describe('onClick toolbar ul', () => {\n+     \n+     it(\"should onClick ul\", () => {\n+      \n+      let plugin = ListPlugin({});","path":"packages/editable-html/src/plugins/list/__test__/index.test.js","position":146,"original_position":146,"commit_id":"87fffadcfe7ac67ad5e7a4bfe883c802e56fae4e","original_commit_id":"87fffadcfe7ac67ad5e7a4bfe883c802e56fae4e","user":{"login":"edeustace","id":101623,"avatar_url":"https://avatars2.githubusercontent.com/u/101623?v=4","gravatar_id":"","url":"https://api.github.com/users/edeustace","html_url":"https://github.com/edeustace","followers_url":"https://api.github.com/users/edeustace/followers","following_url":"https://api.github.com/users/edeustace/following{/other_user}","gists_url":"https://api.github.com/users/edeustace/gists{/gist_id}","starred_url":"https://api.github.com/users/edeustace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edeustace/subscriptions","organizations_url":"https://api.github.com/users/edeustace/orgs","repos_url":"https://api.github.com/users/edeustace/repos","events_url":"https://api.github.com/users/edeustace/events{/privacy}","received_events_url":"https://api.github.com/users/edeustace/received_events","type":"User","site_admin":false},"body":"empty test?\r\nand missing test for `isActive`?","created_at":"2018-03-26T16:54:05Z","updated_at":"2018-03-26T16:56:16Z","html_url":"https://github.com/pie-framework/pie-lib/pull/6#discussion_r177161913","pull_request_url":"https://api.github.com/repos/pie-framework/pie-lib/pulls/6","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pie-framework/pie-lib/pulls/comments/177161913"},"html":{"href":"https://github.com/pie-framework/pie-lib/pull/6#discussion_r177161913"},"pull_request":{"href":"https://api.github.com/repos/pie-framework/pie-lib/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/pie-framework/pie-lib/pulls/6","id":177501668,"html_url":"https://github.com/pie-framework/pie-lib/pull/6","diff_url":"https://github.com/pie-framework/pie-lib/pull/6.diff","patch_url":"https://github.com/pie-framework/pie-lib/pull/6.patch","issue_url":"https://api.github.com/repos/pie-framework/pie-lib/issues/6","number":6,"state":"open","locked":false,"title":"list plugin","user":{"login":"edeustace","id":101623,"avatar_url":"https://avatars2.githubusercontent.com/u/101623?v=4","gravatar_id":"","url":"https://api.github.com/users/edeustace","html_url":"https://github.com/edeustace","followers_url":"https://api.github.com/users/edeustace/followers","following_url":"https://api.github.com/users/edeustace/following{/other_user}","gists_url":"https://api.github.com/users/edeustace/gists{/gist_id}","starred_url":"https://api.github.com/users/edeustace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edeustace/subscriptions","organizations_url":"https://api.github.com/users/edeustace/orgs","repos_url":"https://api.github.com/users/edeustace/repos","events_url":"https://api.github.com/users/edeustace/events{/privacy}","received_events_url":"https://api.github.com/users/edeustace/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-26T16:33:19Z","updated_at":"2018-03-26T16:56:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15e79f340237fa05630be5c4fcf017be929f45de","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pie-framework/pie-lib/pulls/6/commits","review_comments_url":"https://api.github.com/repos/pie-framework/pie-lib/pulls/6/comments","review_comment_url":"https://api.github.com/repos/pie-framework/pie-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pie-framework/pie-lib/issues/6/comments","statuses_url":"https://api.github.com/repos/pie-framework/pie-lib/statuses/87fffadcfe7ac67ad5e7a4bfe883c802e56fae4e","head":{"label":"pie-framework:feature/editable-html","ref":"feature/editable-html","sha":"87fffadcfe7ac67ad5e7a4bfe883c802e56fae4e","user":{"login":"pie-framework","id":37118203,"avatar_url":"https://avatars2.githubusercontent.com/u/37118203?v=4","gravatar_id":"","url":"https://api.github.com/users/pie-framework","html_url":"https://github.com/pie-framework","followers_url":"https://api.github.com/users/pie-framework/followers","following_url":"https://api.github.com/users/pie-framework/following{/other_user}","gists_url":"https://api.github.com/users/pie-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/pie-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pie-framework/subscriptions","organizations_url":"https://api.github.com/users/pie-framework/orgs","repos_url":"https://api.github.com/users/pie-framework/repos","events_url":"https://api.github.com/users/pie-framework/events{/privacy}","received_events_url":"https://api.github.com/users/pie-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":124115073,"name":"pie-lib","full_name":"pie-framework/pie-lib","owner":{"login":"pie-framework","id":37118203,"avatar_url":"https://avatars2.githubusercontent.com/u/37118203?v=4","gravatar_id":"","url":"https://api.github.com/users/pie-framework","html_url":"https://github.com/pie-framework","followers_url":"https://api.github.com/users/pie-framework/followers","following_url":"https://api.github.com/users/pie-framework/following{/other_user}","gists_url":"https://api.github.com/users/pie-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/pie-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pie-framework/subscriptions","organizations_url":"https://api.github.com/users/pie-framework/orgs","repos_url":"https://api.github.com/users/pie-framework/repos","events_url":"https://api.github.com/users/pie-framework/events{/privacy}","received_events_url":"https://api.github.com/users/pie-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pie-framework/pie-lib","description":"Some reusable react libraries","fork":false,"url":"https://api.github.com/repos/pie-framework/pie-lib","forks_url":"https://api.github.com/repos/pie-framework/pie-lib/forks","keys_url":"https://api.github.com/repos/pie-framework/pie-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pie-framework/pie-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pie-framework/pie-lib/teams","hooks_url":"https://api.github.com/repos/pie-framework/pie-lib/hooks","issue_events_url":"https://api.github.com/repos/pie-framework/pie-lib/issues/events{/number}","events_url":"https://api.github.com/repos/pie-framework/pie-lib/events","assignees_url":"https://api.github.com/repos/pie-framework/pie-lib/assignees{/user}","branches_url":"https://api.github.com/repos/pie-framework/pie-lib/branches{/branch}","tags_url":"https://api.github.com/repos/pie-framework/pie-lib/tags","blobs_url":"https://api.github.com/repos/pie-framework/pie-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pie-framework/pie-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pie-framework/pie-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/pie-framework/pie-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pie-framework/pie-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/pie-framework/pie-lib/languages","stargazers_url":"https://api.github.com/repos/pie-framework/pie-lib/stargazers","contributors_url":"https://api.github.com/repos/pie-framework/pie-lib/contributors","subscribers_url":"https://api.github.com/repos/pie-framework/pie-lib/subscribers","subscription_url":"https://api.github.com/repos/pie-framework/pie-lib/subscription","commits_url":"https://api.github.com/repos/pie-framework/pie-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/pie-framework/pie-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/pie-framework/pie-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/pie-framework/pie-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/pie-framework/pie-lib/contents/{+path}","compare_url":"https://api.github.com/repos/pie-framework/pie-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pie-framework/pie-lib/merges","archive_url":"https://api.github.com/repos/pie-framework/pie-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pie-framework/pie-lib/downloads","issues_url":"https://api.github.com/repos/pie-framework/pie-lib/issues{/number}","pulls_url":"https://api.github.com/repos/pie-framework/pie-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/pie-framework/pie-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/pie-framework/pie-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pie-framework/pie-lib/labels{/name}","releases_url":"https://api.github.com/repos/pie-framework/pie-lib/releases{/id}","deployments_url":"https://api.github.com/repos/pie-framework/pie-lib/deployments","created_at":"2018-03-06T17:38:26Z","updated_at":"2018-03-23T15:05:54Z","pushed_at":"2018-03-26T16:38:02Z","git_url":"git://github.com/pie-framework/pie-lib.git","ssh_url":"git@github.com:pie-framework/pie-lib.git","clone_url":"https://github.com/pie-framework/pie-lib.git","svn_url":"https://github.com/pie-framework/pie-lib","homepage":null,"size":1103,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"develop"}},"base":{"label":"pie-framework:develop","ref":"develop","sha":"a9a03f1b170894c65d1b3b6a619f818d8a62a2d6","user":{"login":"pie-framework","id":37118203,"avatar_url":"https://avatars2.githubusercontent.com/u/37118203?v=4","gravatar_id":"","url":"https://api.github.com/users/pie-framework","html_url":"https://github.com/pie-framework","followers_url":"https://api.github.com/users/pie-framework/followers","following_url":"https://api.github.com/users/pie-framework/following{/other_user}","gists_url":"https://api.github.com/users/pie-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/pie-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pie-framework/subscriptions","organizations_url":"https://api.github.com/users/pie-framework/orgs","repos_url":"https://api.github.com/users/pie-framework/repos","events_url":"https://api.github.com/users/pie-framework/events{/privacy}","received_events_url":"https://api.github.com/users/pie-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":124115073,"name":"pie-lib","full_name":"pie-framework/pie-lib","owner":{"login":"pie-framework","id":37118203,"avatar_url":"https://avatars2.githubusercontent.com/u/37118203?v=4","gravatar_id":"","url":"https://api.github.com/users/pie-framework","html_url":"https://github.com/pie-framework","followers_url":"https://api.github.com/users/pie-framework/followers","following_url":"https://api.github.com/users/pie-framework/following{/other_user}","gists_url":"https://api.github.com/users/pie-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/pie-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pie-framework/subscriptions","organizations_url":"https://api.github.com/users/pie-framework/orgs","repos_url":"https://api.github.com/users/pie-framework/repos","events_url":"https://api.github.com/users/pie-framework/events{/privacy}","received_events_url":"https://api.github.com/users/pie-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pie-framework/pie-lib","description":"Some reusable react libraries","fork":false,"url":"https://api.github.com/repos/pie-framework/pie-lib","forks_url":"https://api.github.com/repos/pie-framework/pie-lib/forks","keys_url":"https://api.github.com/repos/pie-framework/pie-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pie-framework/pie-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pie-framework/pie-lib/teams","hooks_url":"https://api.github.com/repos/pie-framework/pie-lib/hooks","issue_events_url":"https://api.github.com/repos/pie-framework/pie-lib/issues/events{/number}","events_url":"https://api.github.com/repos/pie-framework/pie-lib/events","assignees_url":"https://api.github.com/repos/pie-framework/pie-lib/assignees{/user}","branches_url":"https://api.github.com/repos/pie-framework/pie-lib/branches{/branch}","tags_url":"https://api.github.com/repos/pie-framework/pie-lib/tags","blobs_url":"https://api.github.com/repos/pie-framework/pie-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pie-framework/pie-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pie-framework/pie-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/pie-framework/pie-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pie-framework/pie-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/pie-framework/pie-lib/languages","stargazers_url":"https://api.github.com/repos/pie-framework/pie-lib/stargazers","contributors_url":"https://api.github.com/repos/pie-framework/pie-lib/contributors","subscribers_url":"https://api.github.com/repos/pie-framework/pie-lib/subscribers","subscription_url":"https://api.github.com/repos/pie-framework/pie-lib/subscription","commits_url":"https://api.github.com/repos/pie-framework/pie-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/pie-framework/pie-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/pie-framework/pie-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/pie-framework/pie-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/pie-framework/pie-lib/contents/{+path}","compare_url":"https://api.github.com/repos/pie-framework/pie-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pie-framework/pie-lib/merges","archive_url":"https://api.github.com/repos/pie-framework/pie-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pie-framework/pie-lib/downloads","issues_url":"https://api.github.com/repos/pie-framework/pie-lib/issues{/number}","pulls_url":"https://api.github.com/repos/pie-framework/pie-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/pie-framework/pie-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/pie-framework/pie-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pie-framework/pie-lib/labels{/name}","releases_url":"https://api.github.com/repos/pie-framework/pie-lib/releases{/id}","deployments_url":"https://api.github.com/repos/pie-framework/pie-lib/deployments","created_at":"2018-03-06T17:38:26Z","updated_at":"2018-03-23T15:05:54Z","pushed_at":"2018-03-26T16:38:02Z","git_url":"git://github.com/pie-framework/pie-lib.git","ssh_url":"git@github.com:pie-framework/pie-lib.git","clone_url":"https://github.com/pie-framework/pie-lib.git","svn_url":"https://github.com/pie-framework/pie-lib","homepage":null,"size":1103,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/pie-framework/pie-lib/pulls/6"},"html":{"href":"https://github.com/pie-framework/pie-lib/pull/6"},"issue":{"href":"https://api.github.com/repos/pie-framework/pie-lib/issues/6"},"comments":{"href":"https://api.github.com/repos/pie-framework/pie-lib/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/pie-framework/pie-lib/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/pie-framework/pie-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pie-framework/pie-lib/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/pie-framework/pie-lib/statuses/87fffadcfe7ac67ad5e7a4bfe883c802e56fae4e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"edeustace"}}