{"action":"created","comment":{"url":"https://api.github.com/repos/colinoflynn/pico-python/pulls/comments/227348558","pull_request_review_id":167366548,"id":227348558,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzM0ODU1OA==","diff_hunk":"@@ -27,7 +29,13 @@ def LoadLibraryDarwin(library):\n             FileNotFoundError\n         except NameError:\n             FileNotFoundError = IOError\n-        if not Path(PICO_LIB_PATH).is_dir():\n+\n+        PICO_LIB_PATH = None\n+        for path in PICO_LIB_PATHS:\n+            if Path(path).is_dir():\n+                PICO_LIB_PATH = path\n+\n+        if PICO_LIB_PATH is None:","path":"picoscope/darwin_utils.py","position":22,"original_position":22,"commit_id":"5196455fe76ec77e86eab3a187418ce16bd2dc17","original_commit_id":"5196455fe76ec77e86eab3a187418ce16bd2dc17","user":{"login":"hmaarrfk","id":90008,"node_id":"MDQ6VXNlcjkwMDA4","avatar_url":"https://avatars0.githubusercontent.com/u/90008?v=4","gravatar_id":"","url":"https://api.github.com/users/hmaarrfk","html_url":"https://github.com/hmaarrfk","followers_url":"https://api.github.com/users/hmaarrfk/followers","following_url":"https://api.github.com/users/hmaarrfk/following{/other_user}","gists_url":"https://api.github.com/users/hmaarrfk/gists{/gist_id}","starred_url":"https://api.github.com/users/hmaarrfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmaarrfk/subscriptions","organizations_url":"https://api.github.com/users/hmaarrfk/orgs","repos_url":"https://api.github.com/users/hmaarrfk/repos","events_url":"https://api.github.com/users/hmaarrfk/events{/privacy}","received_events_url":"https://api.github.com/users/hmaarrfk/received_events","type":"User","site_admin":false},"body":"The for/else clause is perfect here. \r\n\r\nhttp://book.pythontips.com/en/latest/for_-_else.html","created_at":"2018-10-23T11:35:21Z","updated_at":"2018-10-23T11:58:57Z","html_url":"https://github.com/colinoflynn/pico-python/pull/144#discussion_r227348558","pull_request_url":"https://api.github.com/repos/colinoflynn/pico-python/pulls/144","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/colinoflynn/pico-python/pulls/comments/227348558"},"html":{"href":"https://github.com/colinoflynn/pico-python/pull/144#discussion_r227348558"},"pull_request":{"href":"https://api.github.com/repos/colinoflynn/pico-python/pulls/144"}}},"pull_request":{"url":"https://api.github.com/repos/colinoflynn/pico-python/pulls/144","id":224964322,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0OTY0MzIy","html_url":"https://github.com/colinoflynn/pico-python/pull/144","diff_url":"https://github.com/colinoflynn/pico-python/pull/144.diff","patch_url":"https://github.com/colinoflynn/pico-python/pull/144.patch","issue_url":"https://api.github.com/repos/colinoflynn/pico-python/issues/144","number":144,"state":"open","locked":false,"title":"macos path changes","user":{"login":"bongotrench","id":44370891,"node_id":"MDQ6VXNlcjQ0MzcwODkx","avatar_url":"https://avatars0.githubusercontent.com/u/44370891?v=4","gravatar_id":"","url":"https://api.github.com/users/bongotrench","html_url":"https://github.com/bongotrench","followers_url":"https://api.github.com/users/bongotrench/followers","following_url":"https://api.github.com/users/bongotrench/following{/other_user}","gists_url":"https://api.github.com/users/bongotrench/gists{/gist_id}","starred_url":"https://api.github.com/users/bongotrench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bongotrench/subscriptions","organizations_url":"https://api.github.com/users/bongotrench/orgs","repos_url":"https://api.github.com/users/bongotrench/repos","events_url":"https://api.github.com/users/bongotrench/events{/privacy}","received_events_url":"https://api.github.com/users/bongotrench/received_events","type":"User","site_admin":false},"body":"modified darwin_utils.py to support the new version of the picoscope app where the path has been changed to include a space. Should also work with the old path with no space (not tested).","created_at":"2018-10-23T09:33:27Z","updated_at":"2018-10-23T11:58:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"194faddccbd22619b829e79b746489f337c5afe0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/colinoflynn/pico-python/pulls/144/commits","review_comments_url":"https://api.github.com/repos/colinoflynn/pico-python/pulls/144/comments","review_comment_url":"https://api.github.com/repos/colinoflynn/pico-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/colinoflynn/pico-python/issues/144/comments","statuses_url":"https://api.github.com/repos/colinoflynn/pico-python/statuses/5196455fe76ec77e86eab3a187418ce16bd2dc17","head":{"label":"bongotrench:macos_path","ref":"macos_path","sha":"5196455fe76ec77e86eab3a187418ce16bd2dc17","user":{"login":"bongotrench","id":44370891,"node_id":"MDQ6VXNlcjQ0MzcwODkx","avatar_url":"https://avatars0.githubusercontent.com/u/44370891?v=4","gravatar_id":"","url":"https://api.github.com/users/bongotrench","html_url":"https://github.com/bongotrench","followers_url":"https://api.github.com/users/bongotrench/followers","following_url":"https://api.github.com/users/bongotrench/following{/other_user}","gists_url":"https://api.github.com/users/bongotrench/gists{/gist_id}","starred_url":"https://api.github.com/users/bongotrench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bongotrench/subscriptions","organizations_url":"https://api.github.com/users/bongotrench/orgs","repos_url":"https://api.github.com/users/bongotrench/repos","events_url":"https://api.github.com/users/bongotrench/events{/privacy}","received_events_url":"https://api.github.com/users/bongotrench/received_events","type":"User","site_admin":false},"repo":{"id":154300690,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQzMDA2OTA=","name":"pico-python","full_name":"bongotrench/pico-python","private":false,"owner":{"login":"bongotrench","id":44370891,"node_id":"MDQ6VXNlcjQ0MzcwODkx","avatar_url":"https://avatars0.githubusercontent.com/u/44370891?v=4","gravatar_id":"","url":"https://api.github.com/users/bongotrench","html_url":"https://github.com/bongotrench","followers_url":"https://api.github.com/users/bongotrench/followers","following_url":"https://api.github.com/users/bongotrench/following{/other_user}","gists_url":"https://api.github.com/users/bongotrench/gists{/gist_id}","starred_url":"https://api.github.com/users/bongotrench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bongotrench/subscriptions","organizations_url":"https://api.github.com/users/bongotrench/orgs","repos_url":"https://api.github.com/users/bongotrench/repos","events_url":"https://api.github.com/users/bongotrench/events{/privacy}","received_events_url":"https://api.github.com/users/bongotrench/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bongotrench/pico-python","description":"PicoScope Python Interface","fork":true,"url":"https://api.github.com/repos/bongotrench/pico-python","forks_url":"https://api.github.com/repos/bongotrench/pico-python/forks","keys_url":"https://api.github.com/repos/bongotrench/pico-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bongotrench/pico-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bongotrench/pico-python/teams","hooks_url":"https://api.github.com/repos/bongotrench/pico-python/hooks","issue_events_url":"https://api.github.com/repos/bongotrench/pico-python/issues/events{/number}","events_url":"https://api.github.com/repos/bongotrench/pico-python/events","assignees_url":"https://api.github.com/repos/bongotrench/pico-python/assignees{/user}","branches_url":"https://api.github.com/repos/bongotrench/pico-python/branches{/branch}","tags_url":"https://api.github.com/repos/bongotrench/pico-python/tags","blobs_url":"https://api.github.com/repos/bongotrench/pico-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bongotrench/pico-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bongotrench/pico-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/bongotrench/pico-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bongotrench/pico-python/statuses/{sha}","languages_url":"https://api.github.com/repos/bongotrench/pico-python/languages","stargazers_url":"https://api.github.com/repos/bongotrench/pico-python/stargazers","contributors_url":"https://api.github.com/repos/bongotrench/pico-python/contributors","subscribers_url":"https://api.github.com/repos/bongotrench/pico-python/subscribers","subscription_url":"https://api.github.com/repos/bongotrench/pico-python/subscription","commits_url":"https://api.github.com/repos/bongotrench/pico-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/bongotrench/pico-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/bongotrench/pico-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/bongotrench/pico-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/bongotrench/pico-python/contents/{+path}","compare_url":"https://api.github.com/repos/bongotrench/pico-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bongotrench/pico-python/merges","archive_url":"https://api.github.com/repos/bongotrench/pico-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bongotrench/pico-python/downloads","issues_url":"https://api.github.com/repos/bongotrench/pico-python/issues{/number}","pulls_url":"https://api.github.com/repos/bongotrench/pico-python/pulls{/number}","milestones_url":"https://api.github.com/repos/bongotrench/pico-python/milestones{/number}","notifications_url":"https://api.github.com/repos/bongotrench/pico-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bongotrench/pico-python/labels{/name}","releases_url":"https://api.github.com/repos/bongotrench/pico-python/releases{/id}","deployments_url":"https://api.github.com/repos/bongotrench/pico-python/deployments","created_at":"2018-10-23T09:30:05Z","updated_at":"2018-10-23T09:30:07Z","pushed_at":"2018-10-23T09:37:59Z","git_url":"git://github.com/bongotrench/pico-python.git","ssh_url":"git@github.com:bongotrench/pico-python.git","clone_url":"https://github.com/bongotrench/pico-python.git","svn_url":"https://github.com/bongotrench/pico-python","homepage":null,"size":1100,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"colinoflynn:master","ref":"master","sha":"760e9f45782c99373df1a4dc843d0454bd212f43","user":{"login":"colinoflynn","id":6100154,"node_id":"MDQ6VXNlcjYxMDAxNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6100154?v=4","gravatar_id":"","url":"https://api.github.com/users/colinoflynn","html_url":"https://github.com/colinoflynn","followers_url":"https://api.github.com/users/colinoflynn/followers","following_url":"https://api.github.com/users/colinoflynn/following{/other_user}","gists_url":"https://api.github.com/users/colinoflynn/gists{/gist_id}","starred_url":"https://api.github.com/users/colinoflynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinoflynn/subscriptions","organizations_url":"https://api.github.com/users/colinoflynn/orgs","repos_url":"https://api.github.com/users/colinoflynn/repos","events_url":"https://api.github.com/users/colinoflynn/events{/privacy}","received_events_url":"https://api.github.com/users/colinoflynn/received_events","type":"User","site_admin":false},"repo":{"id":15211810,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIxMTgxMA==","name":"pico-python","full_name":"colinoflynn/pico-python","private":false,"owner":{"login":"colinoflynn","id":6100154,"node_id":"MDQ6VXNlcjYxMDAxNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6100154?v=4","gravatar_id":"","url":"https://api.github.com/users/colinoflynn","html_url":"https://github.com/colinoflynn","followers_url":"https://api.github.com/users/colinoflynn/followers","following_url":"https://api.github.com/users/colinoflynn/following{/other_user}","gists_url":"https://api.github.com/users/colinoflynn/gists{/gist_id}","starred_url":"https://api.github.com/users/colinoflynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinoflynn/subscriptions","organizations_url":"https://api.github.com/users/colinoflynn/orgs","repos_url":"https://api.github.com/users/colinoflynn/repos","events_url":"https://api.github.com/users/colinoflynn/events{/privacy}","received_events_url":"https://api.github.com/users/colinoflynn/received_events","type":"User","site_admin":false},"html_url":"https://github.com/colinoflynn/pico-python","description":"PicoScope Python Interface","fork":false,"url":"https://api.github.com/repos/colinoflynn/pico-python","forks_url":"https://api.github.com/repos/colinoflynn/pico-python/forks","keys_url":"https://api.github.com/repos/colinoflynn/pico-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colinoflynn/pico-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colinoflynn/pico-python/teams","hooks_url":"https://api.github.com/repos/colinoflynn/pico-python/hooks","issue_events_url":"https://api.github.com/repos/colinoflynn/pico-python/issues/events{/number}","events_url":"https://api.github.com/repos/colinoflynn/pico-python/events","assignees_url":"https://api.github.com/repos/colinoflynn/pico-python/assignees{/user}","branches_url":"https://api.github.com/repos/colinoflynn/pico-python/branches{/branch}","tags_url":"https://api.github.com/repos/colinoflynn/pico-python/tags","blobs_url":"https://api.github.com/repos/colinoflynn/pico-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colinoflynn/pico-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colinoflynn/pico-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/colinoflynn/pico-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colinoflynn/pico-python/statuses/{sha}","languages_url":"https://api.github.com/repos/colinoflynn/pico-python/languages","stargazers_url":"https://api.github.com/repos/colinoflynn/pico-python/stargazers","contributors_url":"https://api.github.com/repos/colinoflynn/pico-python/contributors","subscribers_url":"https://api.github.com/repos/colinoflynn/pico-python/subscribers","subscription_url":"https://api.github.com/repos/colinoflynn/pico-python/subscription","commits_url":"https://api.github.com/repos/colinoflynn/pico-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/colinoflynn/pico-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/colinoflynn/pico-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/colinoflynn/pico-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/colinoflynn/pico-python/contents/{+path}","compare_url":"https://api.github.com/repos/colinoflynn/pico-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colinoflynn/pico-python/merges","archive_url":"https://api.github.com/repos/colinoflynn/pico-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colinoflynn/pico-python/downloads","issues_url":"https://api.github.com/repos/colinoflynn/pico-python/issues{/number}","pulls_url":"https://api.github.com/repos/colinoflynn/pico-python/pulls{/number}","milestones_url":"https://api.github.com/repos/colinoflynn/pico-python/milestones{/number}","notifications_url":"https://api.github.com/repos/colinoflynn/pico-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colinoflynn/pico-python/labels{/name}","releases_url":"https://api.github.com/repos/colinoflynn/pico-python/releases{/id}","deployments_url":"https://api.github.com/repos/colinoflynn/pico-python/deployments","created_at":"2013-12-15T22:14:17Z","updated_at":"2018-10-08T02:40:48Z","pushed_at":"2018-10-23T09:38:00Z","git_url":"git://github.com/colinoflynn/pico-python.git","ssh_url":"git@github.com:colinoflynn/pico-python.git","clone_url":"https://github.com/colinoflynn/pico-python.git","svn_url":"https://github.com/colinoflynn/pico-python","homepage":null,"size":1096,"stargazers_count":46,"watchers_count":46,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":51,"open_issues":18,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/colinoflynn/pico-python/pulls/144"},"html":{"href":"https://github.com/colinoflynn/pico-python/pull/144"},"issue":{"href":"https://api.github.com/repos/colinoflynn/pico-python/issues/144"},"comments":{"href":"https://api.github.com/repos/colinoflynn/pico-python/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/colinoflynn/pico-python/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/colinoflynn/pico-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/colinoflynn/pico-python/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/colinoflynn/pico-python/statuses/5196455fe76ec77e86eab3a187418ce16bd2dc17"}},"author_association":"NONE"}}
{"actor":{"display_login":"hmaarrfk"}}