{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/19873","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/19873/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/19873/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/19873/events","html_url":"https://github.com/openshift/origin/pull/19873","id":327503614,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMjgyMzAz","number":19873,"title":"Create systemd services for master components","user":{"login":"ravisantoshgudimetla","id":11657829,"node_id":"MDQ6VXNlcjExNjU3ODI5","avatar_url":"https://avatars3.githubusercontent.com/u/11657829?v=4","gravatar_id":"","url":"https://api.github.com/users/ravisantoshgudimetla","html_url":"https://github.com/ravisantoshgudimetla","followers_url":"https://api.github.com/users/ravisantoshgudimetla/followers","following_url":"https://api.github.com/users/ravisantoshgudimetla/following{/other_user}","gists_url":"https://api.github.com/users/ravisantoshgudimetla/gists{/gist_id}","starred_url":"https://api.github.com/users/ravisantoshgudimetla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravisantoshgudimetla/subscriptions","organizations_url":"https://api.github.com/users/ravisantoshgudimetla/orgs","repos_url":"https://api.github.com/users/ravisantoshgudimetla/repos","events_url":"https://api.github.com/users/ravisantoshgudimetla/events{/privacy}","received_events_url":"https://api.github.com/users/ravisantoshgudimetla/received_events","type":"User","site_admin":false},"labels":[{"id":223479084,"node_id":"MDU6TGFiZWwyMjM0NzkwODQ=","url":"https://api.github.com/repos/openshift/origin/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":640548394,"node_id":"MDU6TGFiZWw2NDA1NDgzOTQ=","url":"https://api.github.com/repos/openshift/origin/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"sjenning","id":493891,"node_id":"MDQ6VXNlcjQ5Mzg5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/493891?v=4","gravatar_id":"","url":"https://api.github.com/users/sjenning","html_url":"https://github.com/sjenning","followers_url":"https://api.github.com/users/sjenning/followers","following_url":"https://api.github.com/users/sjenning/following{/other_user}","gists_url":"https://api.github.com/users/sjenning/gists{/gist_id}","starred_url":"https://api.github.com/users/sjenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjenning/subscriptions","organizations_url":"https://api.github.com/users/sjenning/orgs","repos_url":"https://api.github.com/users/sjenning/repos","events_url":"https://api.github.com/users/sjenning/events{/privacy}","received_events_url":"https://api.github.com/users/sjenning/received_events","type":"User","site_admin":false},"assignees":[{"login":"sjenning","id":493891,"node_id":"MDQ6VXNlcjQ5Mzg5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/493891?v=4","gravatar_id":"","url":"https://api.github.com/users/sjenning","html_url":"https://github.com/sjenning","followers_url":"https://api.github.com/users/sjenning/followers","following_url":"https://api.github.com/users/sjenning/following{/other_user}","gists_url":"https://api.github.com/users/sjenning/gists{/gist_id}","starred_url":"https://api.github.com/users/sjenning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjenning/subscriptions","organizations_url":"https://api.github.com/users/sjenning/orgs","repos_url":"https://api.github.com/users/sjenning/repos","events_url":"https://api.github.com/users/sjenning/events{/privacy}","received_events_url":"https://api.github.com/users/sjenning/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-05-29T22:03:14Z","updated_at":"2018-06-01T06:55:33Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/19873","html_url":"https://github.com/openshift/origin/pull/19873","diff_url":"https://github.com/openshift/origin/pull/19873.diff","patch_url":"https://github.com/openshift/origin/pull/19873.patch"},"body":"Not sure if this is exact repo for these changes\r\n\r\n- Create master and node directories in systemd.\r\n- Create systemd services for master components.\r\n- Moves node components to node directory.\r\n\r\ncc @sjenning @derekwaynecarr @runcom \r\n\r\nIn any case, this PR could be used for reviewing and sharing code for cri-o"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/393781331","html_url":"https://github.com/openshift/origin/pull/19873#issuecomment-393781331","issue_url":"https://api.github.com/repos/openshift/origin/issues/19873","id":393781331,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Mzc4MTMzMQ==","user":{"login":"runcom","id":849915,"node_id":"MDQ6VXNlcjg0OTkxNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/849915?v=4","gravatar_id":"","url":"https://api.github.com/users/runcom","html_url":"https://github.com/runcom","followers_url":"https://api.github.com/users/runcom/followers","following_url":"https://api.github.com/users/runcom/following{/other_user}","gists_url":"https://api.github.com/users/runcom/gists{/gist_id}","starred_url":"https://api.github.com/users/runcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runcom/subscriptions","organizations_url":"https://api.github.com/users/runcom/orgs","repos_url":"https://api.github.com/users/runcom/repos","events_url":"https://api.github.com/users/runcom/events{/privacy}","received_events_url":"https://api.github.com/users/runcom/received_events","type":"User","site_admin":false},"created_at":"2018-06-01T06:55:33Z","updated_at":"2018-06-01T06:55:33Z","author_association":"MEMBER","body":"The following applies on top of this PR for changes from docker to crictl:\r\n```diff\r\ndiff --git a/contrib/systemd/master/atomic-openshift-master-api b/contrib/systemd/master/atomic-openshift-master-api\r\nindex fabb266834..64408e1ee6 100755\r\n--- a/contrib/systemd/master/atomic-openshift-master-api\r\n+++ b/contrib/systemd/master/atomic-openshift-master-api\r\n@@ -11,8 +11,8 @@ static_pod_file=apiserver.yaml\r\n mkdir -p $pods_dir $pods_disabled_dir\r\n \r\n function get_container_values() {\r\n-    child_container=$(docker ps -q --filter \"label=io.kubernetes.container.name=api\")\r\n-    container=$(docker ps -q --filter \"label=openshift.io/component=api\" --filter \"label=io.kubernetes.container.name=POD\")\r\n+    child_container=$(crictl ps -q --label \"io.kubernetes.container.name=api\")\r\n+    container=$(crictl pods -l -q --label \"openshift.io/component=api\" --label \"io.kubernetes.container.name=POD 2>/dev/null\")\r\n }\r\n \r\n \r\n@@ -31,12 +31,12 @@ start)\r\n     sleep 1 # avoid race condition\r\n \r\n     # Wait for the pod to come up\r\n-    while ! docker ps -q --filter \"label=io.kubernetes.container.name=api\" &> /dev/null ; do\r\n+    while ! crictl ps -q --label \"io.kubernetes.container.name=api\" &> /dev/null ; do\r\n         sleep 1\r\n     done\r\n \r\n     get_container_values\r\n-    docker logs --follow \"$child_container\"\r\n+    crictl logs --follow \"$child_container\"\r\n     exit $?\r\n     ;;\r\n \r\n@@ -52,7 +52,7 @@ stop)\r\n     # Start the api server pod\r\n     mv \"${pods_dir}/${static_pod_file}\" \"${pods_disabled_dir}\"\r\n \r\n-    exec timeout 60 docker wait $child_container\r\n+    #exec timeout 60 docker wait $child_container\r\n     ;;\r\n \r\n # No status or restart as systemd handles those for us.\r\ndiff --git a/contrib/systemd/master/atomic-openshift-master-controllers b/contrib/systemd/master/atomic-openshift-master-controllers\r\nindex 7439e8a67c..0eee561406 100755\r\n--- a/contrib/systemd/master/atomic-openshift-master-controllers\r\n+++ b/contrib/systemd/master/atomic-openshift-master-controllers\r\n@@ -11,8 +11,8 @@ static_pod_file=controller.yaml\r\n mkdir -p $pods_dir $pods_disabled_dir\r\n \r\n function get_container_values() {\r\n-    child_container=$(docker ps -q --filter \"label=io.kubernetes.container.name=controllers\")\r\n-    container=$(docker ps -q --filter \"label=openshift.io/component=controllers\" --filter \"label=io.kubernetes.container.name=POD\")\r\n+    child_container=$(crictl ps -q --label \"io.kubernetes.container.name=controllers\")\r\n+    container=$(crictl pods -l -q --label \"openshift.io/component=controllers\" --label \"io.kubernetes.container.name=POD 2>/dev/null\")\r\n }\r\n \r\n \r\n@@ -31,12 +31,12 @@ start)\r\n     sleep 1 # avoid race condition\r\n \r\n     # Wait for the pod to come up\r\n-    while ! docker ps -q --filter \"label=io.kubernetes.container.name=controllers\" &> /dev/null ; do\r\n+    while ! crictl ps -q --label \"io.kubernetes.container.name=controllers\" &> /dev/null ; do\r\n         sleep 1\r\n     done\r\n \r\n     get_container_values\r\n-    docker logs --follow \"$child_container\"\r\n+    crictl logs --follow \"$child_container\"\r\n     exit $?\r\n     ;;\r\n \r\n@@ -52,7 +52,7 @@ stop)\r\n     # Start the controllers pod\r\n     mv \"${pods_dir}/${static_pod_file}\" \"${pods_disabled_dir}\"\r\n \r\n-    exec timeout 60 docker wait $child_container\r\n+    #exec timeout 60 docker wait $child_container\r\n     ;;\r\n \r\n # No status or restart as systemd handles those for us.\r\ndiff --git a/contrib/systemd/master/atomic-openshift-master-etcd b/contrib/systemd/master/atomic-openshift-master-etcd\r\nindex 3b959f7b7c..08a76def0b 100755\r\n--- a/contrib/systemd/master/atomic-openshift-master-etcd\r\n+++ b/contrib/systemd/master/atomic-openshift-master-etcd\r\n@@ -11,8 +11,8 @@ static_pod_file=etcd.yaml\r\n mkdir -p $pods_dir $pods_disabled_dir\r\n \r\n function get_container_values() {\r\n-    child_container=$(docker ps -q --filter \"label=io.kubernetes.container.name=etcd\")\r\n-    container=$(docker ps -q --filter \"label=openshift.io/component=etcd\" --filter \"label=io.kubernetes.container.name=POD\")\r\n+    child_container=$(crictl ps -q --label \"io.kubernetes.container.name=etcd\")\r\n+    container=$(crictl pods -l -q --label \"openshift.io/component=etcd\" --label \"io.kubernetes.container.name=POD 2>/dev/null\")\r\n }\r\n \r\n \r\n@@ -31,12 +31,12 @@ start)\r\n     sleep 1 # avoid race condition\r\n \r\n     # Wait for the pod to come up\r\n-    while ! docker ps -q --filter \"label=io.kubernetes.container.name=etcd\" &> /dev/null ; do\r\n+    while ! crictl ps -q --label \"io.kubernetes.container.name=etcd\" &> /dev/null ; do\r\n         sleep 1\r\n     done\r\n \r\n     get_container_values\r\n-    docker logs --follow \"$child_container\"\r\n+    crictl logs --follow \"$child_container\"\r\n     exit $?\r\n     ;;\r\n \r\n@@ -52,7 +52,7 @@ stop)\r\n     # Start the etcd pod\r\n     mv \"${pods_dir}/${static_pod_file}\" \"${pods_disabled_dir}\"\r\n \r\n-    exec timeout 60 docker wait $child_container\r\n+    #exec timeout 60 docker wait $child_container\r\n     ;;\r\n \r\n # No status or restart as systemd handles those for us.\r\n```"}}
{"actor":{"display_login":"runcom"}}