{"action":"created","issue":{"url":"https://api.github.com/repos/appsembler/edx-theme-customers/issues/42","repository_url":"https://api.github.com/repos/appsembler/edx-theme-customers","labels_url":"https://api.github.com/repos/appsembler/edx-theme-customers/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/appsembler/edx-theme-customers/issues/42/comments","events_url":"https://api.github.com/repos/appsembler/edx-theme-customers/issues/42/events","html_url":"https://github.com/appsembler/edx-theme-customers/pull/42","id":375079401,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NjA5NDAy","number":42,"title":"make email change emails custom domain aware","user":{"login":"melvinsoft","id":1225854,"node_id":"MDQ6VXNlcjEyMjU4NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1225854?v=4","gravatar_id":"","url":"https://api.github.com/users/melvinsoft","html_url":"https://github.com/melvinsoft","followers_url":"https://api.github.com/users/melvinsoft/followers","following_url":"https://api.github.com/users/melvinsoft/following{/other_user}","gists_url":"https://api.github.com/users/melvinsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/melvinsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melvinsoft/subscriptions","organizations_url":"https://api.github.com/users/melvinsoft/orgs","repos_url":"https://api.github.com/users/melvinsoft/repos","events_url":"https://api.github.com/users/melvinsoft/events{/privacy}","received_events_url":"https://api.github.com/users/melvinsoft/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-29T15:39:57Z","updated_at":"2018-10-30T11:21:37Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/appsembler/edx-theme-customers/pulls/42","html_url":"https://github.com/appsembler/edx-theme-customers/pull/42","diff_url":"https://github.com/appsembler/edx-theme-customers/pull/42.diff","patch_url":"https://github.com/appsembler/edx-theme-customers/pull/42.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/appsembler/edx-theme-customers/issues/comments/434263119","html_url":"https://github.com/appsembler/edx-theme-customers/pull/42#issuecomment-434263119","issue_url":"https://api.github.com/repos/appsembler/edx-theme-customers/issues/42","id":434263119,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDI2MzExOQ==","user":{"login":"OmarIthawi","id":645156,"node_id":"MDQ6VXNlcjY0NTE1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/645156?v=4","gravatar_id":"","url":"https://api.github.com/users/OmarIthawi","html_url":"https://github.com/OmarIthawi","followers_url":"https://api.github.com/users/OmarIthawi/followers","following_url":"https://api.github.com/users/OmarIthawi/following{/other_user}","gists_url":"https://api.github.com/users/OmarIthawi/gists{/gist_id}","starred_url":"https://api.github.com/users/OmarIthawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmarIthawi/subscriptions","organizations_url":"https://api.github.com/users/OmarIthawi/orgs","repos_url":"https://api.github.com/users/OmarIthawi/repos","events_url":"https://api.github.com/users/OmarIthawi/events{/privacy}","received_events_url":"https://api.github.com/users/OmarIthawi/received_events","type":"User","site_admin":false},"created_at":"2018-10-30T11:21:37Z","updated_at":"2018-10-30T11:21:37Z","author_association":"MEMBER","body":"@melvinsoft LGTM. I think this is better to be a platform change rather than keeping it here.\r\n\r\nSooner or later we'll get HTML emails, and we'll have to fix this again.\r\n\r\nHaving this in the platform will make git conflicts when we cherry-pick the HTML emails from upstream. Which is great! Since we'll know how to amend those cherry-picks. \r\n\r\nPutting it in the theme will make the bug \"suddenly\" appear \"once in a while\" from the perspective of our customers.\r\n\r\nIn reality, it's just that we forgot to add it in the correct place and didn't use `git` to it's fullest.\r\n\r\nThe other alternative, is to keep a list of hacks we did in the theme, so we can make sure we retain them from one release to another. \r\n\r\nAutomated tests could be a solution, but for now I prefer to have it in the platform and let git do the work for us."}}
{"actor":{"display_login":"OmarIthawi"}}