{"action":"closed","number":4239,"pull_request":{"url":"https://api.github.com/repos/Microsoft/pxt/pulls/4239","id":185551891,"html_url":"https://github.com/Microsoft/pxt/pull/4239","diff_url":"https://github.com/Microsoft/pxt/pull/4239.diff","patch_url":"https://github.com/Microsoft/pxt/pull/4239.patch","issue_url":"https://api.github.com/repos/Microsoft/pxt/issues/4239","number":4239,"state":"closed","locked":false,"title":"Removing attrs from callInfo and adding decompiler flag","user":{"login":"riknoll","id":13754588,"avatar_url":"https://avatars1.githubusercontent.com/u/13754588?v=4","gravatar_id":"","url":"https://api.github.com/users/riknoll","html_url":"https://github.com/riknoll","followers_url":"https://api.github.com/users/riknoll/followers","following_url":"https://api.github.com/users/riknoll/following{/other_user}","gists_url":"https://api.github.com/users/riknoll/gists{/gist_id}","starred_url":"https://api.github.com/users/riknoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riknoll/subscriptions","organizations_url":"https://api.github.com/users/riknoll/orgs","repos_url":"https://api.github.com/users/riknoll/repos","events_url":"https://api.github.com/users/riknoll/events{/privacy}","received_events_url":"https://api.github.com/users/riknoll/received_events","type":"User","site_admin":false},"body":"The emitter shoves a bunch of API info into the AST when compiling so that the decompiler can use it later. One of those things was the comment attributes for the API; however the emitter was only inserting the comment attributes from the value declaration of the function and not the merged comment attributes that we use everywhere else (i.e. the ones generated by `getApiInfo()`). This change removes that and instead uses the API info because it turns out we were passing that along anyways.\r\n\r\nAdditionally, I added a flag to support the image blocks in pxt-common-packages. All it does is allow types that are marked as fixed instance types to decompile APIs on non-fixed-instance expressions.","created_at":"2018-05-02T20:28:11Z","updated_at":"2018-05-02T20:38:47Z","closed_at":"2018-05-02T20:38:47Z","merged_at":"2018-05-02T20:38:47Z","merge_commit_sha":"ba8e91d69b8be03768c909b85070cb973f9b5f09","assignee":null,"assignees":[],"requested_reviewers":[{"login":"samelhusseini","id":16690124,"avatar_url":"https://avatars3.githubusercontent.com/u/16690124?v=4","gravatar_id":"","url":"https://api.github.com/users/samelhusseini","html_url":"https://github.com/samelhusseini","followers_url":"https://api.github.com/users/samelhusseini/followers","following_url":"https://api.github.com/users/samelhusseini/following{/other_user}","gists_url":"https://api.github.com/users/samelhusseini/gists{/gist_id}","starred_url":"https://api.github.com/users/samelhusseini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samelhusseini/subscriptions","organizations_url":"https://api.github.com/users/samelhusseini/orgs","repos_url":"https://api.github.com/users/samelhusseini/repos","events_url":"https://api.github.com/users/samelhusseini/events{/privacy}","received_events_url":"https://api.github.com/users/samelhusseini/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/pxt/pulls/4239/commits","review_comments_url":"https://api.github.com/repos/Microsoft/pxt/pulls/4239/comments","review_comment_url":"https://api.github.com/repos/Microsoft/pxt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/pxt/issues/4239/comments","statuses_url":"https://api.github.com/repos/Microsoft/pxt/statuses/e86c2fad5ad0692ce7ab77c4f979591d4e9d506a","head":{"label":"Microsoft:decompile_images","ref":"decompile_images","sha":"e86c2fad5ad0692ce7ab77c4f979591d4e9d506a","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":50304279,"name":"pxt","full_name":"Microsoft/pxt","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/pxt","description":"Microsoft MakeCode (PXT - Programming eXperience Toolkit)","fork":false,"url":"https://api.github.com/repos/Microsoft/pxt","forks_url":"https://api.github.com/repos/Microsoft/pxt/forks","keys_url":"https://api.github.com/repos/Microsoft/pxt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/pxt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/pxt/teams","hooks_url":"https://api.github.com/repos/Microsoft/pxt/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/pxt/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/pxt/events","assignees_url":"https://api.github.com/repos/Microsoft/pxt/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/pxt/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/pxt/tags","blobs_url":"https://api.github.com/repos/Microsoft/pxt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/pxt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/pxt/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/pxt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/pxt/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/pxt/languages","stargazers_url":"https://api.github.com/repos/Microsoft/pxt/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/pxt/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/pxt/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/pxt/subscription","commits_url":"https://api.github.com/repos/Microsoft/pxt/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/pxt/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/pxt/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/pxt/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/pxt/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/pxt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/pxt/merges","archive_url":"https://api.github.com/repos/Microsoft/pxt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/pxt/downloads","issues_url":"https://api.github.com/repos/Microsoft/pxt/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/pxt/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/pxt/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/pxt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/pxt/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/pxt/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/pxt/deployments","created_at":"2016-01-24T19:35:52Z","updated_at":"2018-05-02T20:38:30Z","pushed_at":"2018-05-02T20:38:47Z","git_url":"git://github.com/Microsoft/pxt.git","ssh_url":"git@github.com:Microsoft/pxt.git","clone_url":"https://github.com/Microsoft/pxt.git","svn_url":"https://github.com/Microsoft/pxt","homepage":"https://makecode.com","size":150392,"stargazers_count":504,"watchers_count":504,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":159,"mirror_url":null,"archived":false,"open_issues_count":460,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":159,"open_issues":460,"watchers":504,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"5c4326898b6f9b7864f1c13f65f6abdaebb76454","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":50304279,"name":"pxt","full_name":"Microsoft/pxt","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/pxt","description":"Microsoft MakeCode (PXT - Programming eXperience Toolkit)","fork":false,"url":"https://api.github.com/repos/Microsoft/pxt","forks_url":"https://api.github.com/repos/Microsoft/pxt/forks","keys_url":"https://api.github.com/repos/Microsoft/pxt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/pxt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/pxt/teams","hooks_url":"https://api.github.com/repos/Microsoft/pxt/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/pxt/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/pxt/events","assignees_url":"https://api.github.com/repos/Microsoft/pxt/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/pxt/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/pxt/tags","blobs_url":"https://api.github.com/repos/Microsoft/pxt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/pxt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/pxt/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/pxt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/pxt/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/pxt/languages","stargazers_url":"https://api.github.com/repos/Microsoft/pxt/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/pxt/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/pxt/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/pxt/subscription","commits_url":"https://api.github.com/repos/Microsoft/pxt/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/pxt/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/pxt/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/pxt/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/pxt/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/pxt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/pxt/merges","archive_url":"https://api.github.com/repos/Microsoft/pxt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/pxt/downloads","issues_url":"https://api.github.com/repos/Microsoft/pxt/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/pxt/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/pxt/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/pxt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/pxt/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/pxt/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/pxt/deployments","created_at":"2016-01-24T19:35:52Z","updated_at":"2018-05-02T20:38:30Z","pushed_at":"2018-05-02T20:38:47Z","git_url":"git://github.com/Microsoft/pxt.git","ssh_url":"git@github.com:Microsoft/pxt.git","clone_url":"https://github.com/Microsoft/pxt.git","svn_url":"https://github.com/Microsoft/pxt","homepage":"https://makecode.com","size":150392,"stargazers_count":504,"watchers_count":504,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":159,"mirror_url":null,"archived":false,"open_issues_count":460,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":159,"open_issues":460,"watchers":504,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/pxt/pulls/4239"},"html":{"href":"https://github.com/Microsoft/pxt/pull/4239"},"issue":{"href":"https://api.github.com/repos/Microsoft/pxt/issues/4239"},"comments":{"href":"https://api.github.com/repos/Microsoft/pxt/issues/4239/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/pxt/pulls/4239/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/pxt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/pxt/pulls/4239/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/pxt/statuses/e86c2fad5ad0692ce7ab77c4f979591d4e9d506a"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"riknoll","id":13754588,"avatar_url":"https://avatars1.githubusercontent.com/u/13754588?v=4","gravatar_id":"","url":"https://api.github.com/users/riknoll","html_url":"https://github.com/riknoll","followers_url":"https://api.github.com/users/riknoll/followers","following_url":"https://api.github.com/users/riknoll/following{/other_user}","gists_url":"https://api.github.com/users/riknoll/gists{/gist_id}","starred_url":"https://api.github.com/users/riknoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riknoll/subscriptions","organizations_url":"https://api.github.com/users/riknoll/orgs","repos_url":"https://api.github.com/users/riknoll/repos","events_url":"https://api.github.com/users/riknoll/events{/privacy}","received_events_url":"https://api.github.com/users/riknoll/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":146,"deletions":72,"changed_files":8}}
{"actor":{"display_login":"riknoll"}}