{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/203730652","pull_request_review_id":138677125,"id":203730652,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzczMDY1Mg==","diff_hunk":"@@ -160,6 +160,13 @@ abstract class Optimizer(sessionCatalog: SessionCatalog)\n       UpdateNullabilityInAttributeReferences)\n   }\n \n+  def nonExcludableBatches: Seq[String] =\n+    \"Eliminate Distinct\" ::\n+      \"Finish Analysis\" ::\n+      \"Replace Operators\" ::\n+      \"Pullup Correlated Expressions\" ::\n+      \"RewriteSubquery\" :: Nil","path":"sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala","position":18,"original_position":18,"commit_id":"84f1a6b5cba08df8684179e9d7195545be655e76","original_commit_id":"84f1a6b5cba08df8684179e9d7195545be655e76","user":{"login":"maryannxue","id":4171904,"node_id":"MDQ6VXNlcjQxNzE5MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4171904?v=4","gravatar_id":"","url":"https://api.github.com/users/maryannxue","html_url":"https://github.com/maryannxue","followers_url":"https://api.github.com/users/maryannxue/followers","following_url":"https://api.github.com/users/maryannxue/following{/other_user}","gists_url":"https://api.github.com/users/maryannxue/gists{/gist_id}","starred_url":"https://api.github.com/users/maryannxue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maryannxue/subscriptions","organizations_url":"https://api.github.com/users/maryannxue/orgs","repos_url":"https://api.github.com/users/maryannxue/repos","events_url":"https://api.github.com/users/maryannxue/events{/privacy}","received_events_url":"https://api.github.com/users/maryannxue/received_events","type":"User","site_admin":false},"body":"I'll change to rule black list.","created_at":"2018-07-19T13:43:38Z","updated_at":"2018-07-19T13:43:38Z","html_url":"https://github.com/apache/spark/pull/21764#discussion_r203730652","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/21764","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/203730652"},"html":{"href":"https://github.com/apache/spark/pull/21764#discussion_r203730652"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/21764"}},"in_reply_to_id":203277729},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/21764","id":201405507,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDA1NTA3","html_url":"https://github.com/apache/spark/pull/21764","diff_url":"https://github.com/apache/spark/pull/21764.diff","patch_url":"https://github.com/apache/spark/pull/21764.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/21764","number":21764,"state":"open","locked":false,"title":"[SPARK-24802] Optimization Rule Exclusion","user":{"login":"maryannxue","id":4171904,"node_id":"MDQ6VXNlcjQxNzE5MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4171904?v=4","gravatar_id":"","url":"https://api.github.com/users/maryannxue","html_url":"https://github.com/maryannxue","followers_url":"https://api.github.com/users/maryannxue/followers","following_url":"https://api.github.com/users/maryannxue/following{/other_user}","gists_url":"https://api.github.com/users/maryannxue/gists{/gist_id}","starred_url":"https://api.github.com/users/maryannxue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maryannxue/subscriptions","organizations_url":"https://api.github.com/users/maryannxue/orgs","repos_url":"https://api.github.com/users/maryannxue/repos","events_url":"https://api.github.com/users/maryannxue/events{/privacy}","received_events_url":"https://api.github.com/users/maryannxue/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nSince Spark has provided fairly clear interfaces for adding user-defined optimization rules, it would be nice to have an easy-to-use interface for excluding an optimization rule from the Spark query optimizer as well.\r\n\r\nThis would make customizing Spark optimizer easier and sometimes could debugging issues too.\r\n\r\n- Add a new config spark.sql.optimizer.excludedRules, with the value being a list of rule names separated by comma.\r\n- Modify the current batches method to remove the excluded rules from the default batches. Log the rules that have been excluded.\r\n- Split the existing default batches into \"post-analysis batches\" and \"optimization batches\" so that only rules in the \"optimization batches\" can be excluded.\r\n\r\n## How was this patch tested?\r\n\r\nAdd a new test suite: OptimizerRuleExclusionSuite","created_at":"2018-07-13T21:34:09Z","updated_at":"2018-07-19T13:43:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"161b4638c17778bb03bc1a96bed2ad9942ae4d14","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/21764/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/21764/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/21764/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/84f1a6b5cba08df8684179e9d7195545be655e76","head":{"label":"maryannxue:rule-exclusion","ref":"rule-exclusion","sha":"84f1a6b5cba08df8684179e9d7195545be655e76","user":{"login":"maryannxue","id":4171904,"node_id":"MDQ6VXNlcjQxNzE5MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4171904?v=4","gravatar_id":"","url":"https://api.github.com/users/maryannxue","html_url":"https://github.com/maryannxue","followers_url":"https://api.github.com/users/maryannxue/followers","following_url":"https://api.github.com/users/maryannxue/following{/other_user}","gists_url":"https://api.github.com/users/maryannxue/gists{/gist_id}","starred_url":"https://api.github.com/users/maryannxue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maryannxue/subscriptions","organizations_url":"https://api.github.com/users/maryannxue/orgs","repos_url":"https://api.github.com/users/maryannxue/repos","events_url":"https://api.github.com/users/maryannxue/events{/privacy}","received_events_url":"https://api.github.com/users/maryannxue/received_events","type":"User","site_admin":false},"repo":{"id":104110775,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQxMTA3NzU=","name":"spark","full_name":"maryannxue/spark","owner":{"login":"maryannxue","id":4171904,"node_id":"MDQ6VXNlcjQxNzE5MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4171904?v=4","gravatar_id":"","url":"https://api.github.com/users/maryannxue","html_url":"https://github.com/maryannxue","followers_url":"https://api.github.com/users/maryannxue/followers","following_url":"https://api.github.com/users/maryannxue/following{/other_user}","gists_url":"https://api.github.com/users/maryannxue/gists{/gist_id}","starred_url":"https://api.github.com/users/maryannxue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maryannxue/subscriptions","organizations_url":"https://api.github.com/users/maryannxue/orgs","repos_url":"https://api.github.com/users/maryannxue/repos","events_url":"https://api.github.com/users/maryannxue/events{/privacy}","received_events_url":"https://api.github.com/users/maryannxue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maryannxue/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/maryannxue/spark","forks_url":"https://api.github.com/repos/maryannxue/spark/forks","keys_url":"https://api.github.com/repos/maryannxue/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maryannxue/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maryannxue/spark/teams","hooks_url":"https://api.github.com/repos/maryannxue/spark/hooks","issue_events_url":"https://api.github.com/repos/maryannxue/spark/issues/events{/number}","events_url":"https://api.github.com/repos/maryannxue/spark/events","assignees_url":"https://api.github.com/repos/maryannxue/spark/assignees{/user}","branches_url":"https://api.github.com/repos/maryannxue/spark/branches{/branch}","tags_url":"https://api.github.com/repos/maryannxue/spark/tags","blobs_url":"https://api.github.com/repos/maryannxue/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maryannxue/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maryannxue/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/maryannxue/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maryannxue/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/maryannxue/spark/languages","stargazers_url":"https://api.github.com/repos/maryannxue/spark/stargazers","contributors_url":"https://api.github.com/repos/maryannxue/spark/contributors","subscribers_url":"https://api.github.com/repos/maryannxue/spark/subscribers","subscription_url":"https://api.github.com/repos/maryannxue/spark/subscription","commits_url":"https://api.github.com/repos/maryannxue/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/maryannxue/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/maryannxue/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/maryannxue/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/maryannxue/spark/contents/{+path}","compare_url":"https://api.github.com/repos/maryannxue/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maryannxue/spark/merges","archive_url":"https://api.github.com/repos/maryannxue/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maryannxue/spark/downloads","issues_url":"https://api.github.com/repos/maryannxue/spark/issues{/number}","pulls_url":"https://api.github.com/repos/maryannxue/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/maryannxue/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/maryannxue/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maryannxue/spark/labels{/name}","releases_url":"https://api.github.com/repos/maryannxue/spark/releases{/id}","deployments_url":"https://api.github.com/repos/maryannxue/spark/deployments","created_at":"2017-09-19T18:13:47Z","updated_at":"2018-07-13T21:49:36Z","pushed_at":"2018-07-18T23:20:19Z","git_url":"git://github.com/maryannxue/spark.git","ssh_url":"git@github.com:maryannxue/spark.git","clone_url":"https://github.com/maryannxue/spark.git","svn_url":"https://github.com/maryannxue/spark","homepage":null,"size":273997,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a75571b46f813005a6d4b076ec39081ffab11844","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTY1OA==","name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-07-19T11:23:03Z","pushed_at":"2018-07-19T12:22:55Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":277309,"stargazers_count":18129,"watchers_count":18129,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16469,"mirror_url":null,"archived":false,"open_issues_count":501,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16469,"open_issues":501,"watchers":18129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/21764"},"html":{"href":"https://github.com/apache/spark/pull/21764"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/21764"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/21764/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/21764/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/21764/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/84f1a6b5cba08df8684179e9d7195545be655e76"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"maryannxue"}}