{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/activity-stream/pulls/comments/177554302","pull_request_review_id":107446385,"id":177554302,"diff_hunk":"@@ -171,8 +176,9 @@ class BookmarksObserver extends Observer {\n \n class PlacesFeed {\n   constructor() {\n-    this.historyObserver = new HistoryObserver(action => this.store.dispatch(ac.BroadcastToContent(action)));\n-    this.bookmarksObserver = new BookmarksObserver(action => this.store.dispatch(ac.BroadcastToContent(action)));\n+    this.placesChangedTimer = null;\n+    this.historyObserver = new HistoryObserver(action => this.customDispatch(action));\n+    this.bookmarksObserver = new BookmarksObserver(action => this.customDispatch(action));","path":"system-addon/lib/PlacesFeed.jsm","position":41,"original_position":41,"commit_id":"2f6864d791909ed6ebce5a755fc4f2c096a43b60","original_commit_id":"2f6864d791909ed6ebce5a755fc4f2c096a43b60","user":{"login":"Mardak","id":438537,"avatar_url":"https://avatars0.githubusercontent.com/u/438537?v=4","gravatar_id":"","url":"https://api.github.com/users/Mardak","html_url":"https://github.com/Mardak","followers_url":"https://api.github.com/users/Mardak/followers","following_url":"https://api.github.com/users/Mardak/following{/other_user}","gists_url":"https://api.github.com/users/Mardak/gists{/gist_id}","starred_url":"https://api.github.com/users/Mardak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mardak/subscriptions","organizations_url":"https://api.github.com/users/Mardak/orgs","repos_url":"https://api.github.com/users/Mardak/repos","events_url":"https://api.github.com/users/Mardak/events{/privacy}","received_events_url":"https://api.github.com/users/Mardak/received_events","type":"User","site_admin":false},"body":"Probably just bind once and pass in:\r\n```js\r\nthis.customDispatch = this.customDispatch.bind(this);\r\n… new HistoryObserver(this.customDispatch);\r\n…\r\n```","created_at":"2018-03-27T20:03:01Z","updated_at":"2018-03-27T20:06:11Z","html_url":"https://github.com/mozilla/activity-stream/pull/4059#discussion_r177554302","pull_request_url":"https://api.github.com/repos/mozilla/activity-stream/pulls/4059","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/comments/177554302"},"html":{"href":"https://github.com/mozilla/activity-stream/pull/4059#discussion_r177554302"},"pull_request":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/4059"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/activity-stream/pulls/4059","id":177527045,"html_url":"https://github.com/mozilla/activity-stream/pull/4059","diff_url":"https://github.com/mozilla/activity-stream/pull/4059.diff","patch_url":"https://github.com/mozilla/activity-stream/pull/4059.patch","issue_url":"https://api.github.com/repos/mozilla/activity-stream/issues/4059","number":4059,"state":"open","locked":false,"title":"[WIP] Debounce bookmark notifications to chill out the thumbnailer","user":{"login":"sarracini","id":7219526,"avatar_url":"https://avatars1.githubusercontent.com/u/7219526?v=4","gravatar_id":"","url":"https://api.github.com/users/sarracini","html_url":"https://github.com/sarracini","followers_url":"https://api.github.com/users/sarracini/followers","following_url":"https://api.github.com/users/sarracini/following{/other_user}","gists_url":"https://api.github.com/users/sarracini/gists{/gist_id}","starred_url":"https://api.github.com/users/sarracini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarracini/subscriptions","organizations_url":"https://api.github.com/users/sarracini/orgs","repos_url":"https://api.github.com/users/sarracini/repos","events_url":"https://api.github.com/users/sarracini/events{/privacy}","received_events_url":"https://api.github.com/users/sarracini/received_events","type":"User","site_admin":false},"body":"@Mardak what do you think about this as a proof of concept for a fix of [Bug 1421682](https://bugzilla.mozilla.org/show_bug.cgi?id=1421682) ? Just debounce the `onItemAdded`/ `onItemRemoved` calls until the last one finishes, so that large amounts of bookmarks don't refresh highlights a bunch and cause the thumbnailer to go crazy. \r\n","created_at":"2018-03-26T18:18:32Z","updated_at":"2018-03-27T20:06:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6d24d257eea26211b37879c8f8509cf1d391aaf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":324828207,"url":"https://api.github.com/repos/mozilla/activity-stream/labels/PR%20/%20In%20progress%20don't%20review%20yet","name":"PR / In progress don't review yet","color":"FFFFFF","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/activity-stream/pulls/4059/commits","review_comments_url":"https://api.github.com/repos/mozilla/activity-stream/pulls/4059/comments","review_comment_url":"https://api.github.com/repos/mozilla/activity-stream/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/activity-stream/issues/4059/comments","statuses_url":"https://api.github.com/repos/mozilla/activity-stream/statuses/2f6864d791909ed6ebce5a755fc4f2c096a43b60","head":{"label":"sarracini:bug_1421682","ref":"bug_1421682","sha":"2f6864d791909ed6ebce5a755fc4f2c096a43b60","user":{"login":"sarracini","id":7219526,"avatar_url":"https://avatars1.githubusercontent.com/u/7219526?v=4","gravatar_id":"","url":"https://api.github.com/users/sarracini","html_url":"https://github.com/sarracini","followers_url":"https://api.github.com/users/sarracini/followers","following_url":"https://api.github.com/users/sarracini/following{/other_user}","gists_url":"https://api.github.com/users/sarracini/gists{/gist_id}","starred_url":"https://api.github.com/users/sarracini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarracini/subscriptions","organizations_url":"https://api.github.com/users/sarracini/orgs","repos_url":"https://api.github.com/users/sarracini/repos","events_url":"https://api.github.com/users/sarracini/events{/privacy}","received_events_url":"https://api.github.com/users/sarracini/received_events","type":"User","site_admin":false},"repo":{"id":63179383,"name":"activity-stream","full_name":"sarracini/activity-stream","owner":{"login":"sarracini","id":7219526,"avatar_url":"https://avatars1.githubusercontent.com/u/7219526?v=4","gravatar_id":"","url":"https://api.github.com/users/sarracini","html_url":"https://github.com/sarracini","followers_url":"https://api.github.com/users/sarracini/followers","following_url":"https://api.github.com/users/sarracini/following{/other_user}","gists_url":"https://api.github.com/users/sarracini/gists{/gist_id}","starred_url":"https://api.github.com/users/sarracini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarracini/subscriptions","organizations_url":"https://api.github.com/users/sarracini/orgs","repos_url":"https://api.github.com/users/sarracini/repos","events_url":"https://api.github.com/users/sarracini/events{/privacy}","received_events_url":"https://api.github.com/users/sarracini/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sarracini/activity-stream","description":" MVP prototype add-on for activity streams","fork":true,"url":"https://api.github.com/repos/sarracini/activity-stream","forks_url":"https://api.github.com/repos/sarracini/activity-stream/forks","keys_url":"https://api.github.com/repos/sarracini/activity-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarracini/activity-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarracini/activity-stream/teams","hooks_url":"https://api.github.com/repos/sarracini/activity-stream/hooks","issue_events_url":"https://api.github.com/repos/sarracini/activity-stream/issues/events{/number}","events_url":"https://api.github.com/repos/sarracini/activity-stream/events","assignees_url":"https://api.github.com/repos/sarracini/activity-stream/assignees{/user}","branches_url":"https://api.github.com/repos/sarracini/activity-stream/branches{/branch}","tags_url":"https://api.github.com/repos/sarracini/activity-stream/tags","blobs_url":"https://api.github.com/repos/sarracini/activity-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarracini/activity-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarracini/activity-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarracini/activity-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarracini/activity-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/sarracini/activity-stream/languages","stargazers_url":"https://api.github.com/repos/sarracini/activity-stream/stargazers","contributors_url":"https://api.github.com/repos/sarracini/activity-stream/contributors","subscribers_url":"https://api.github.com/repos/sarracini/activity-stream/subscribers","subscription_url":"https://api.github.com/repos/sarracini/activity-stream/subscription","commits_url":"https://api.github.com/repos/sarracini/activity-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarracini/activity-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarracini/activity-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarracini/activity-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/sarracini/activity-stream/contents/{+path}","compare_url":"https://api.github.com/repos/sarracini/activity-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarracini/activity-stream/merges","archive_url":"https://api.github.com/repos/sarracini/activity-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarracini/activity-stream/downloads","issues_url":"https://api.github.com/repos/sarracini/activity-stream/issues{/number}","pulls_url":"https://api.github.com/repos/sarracini/activity-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/sarracini/activity-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/sarracini/activity-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarracini/activity-stream/labels{/name}","releases_url":"https://api.github.com/repos/sarracini/activity-stream/releases{/id}","deployments_url":"https://api.github.com/repos/sarracini/activity-stream/deployments","created_at":"2016-07-12T17:38:50Z","updated_at":"2018-03-27T19:48:03Z","pushed_at":"2018-03-27T19:48:02Z","git_url":"git://github.com/sarracini/activity-stream.git","ssh_url":"git@github.com:sarracini/activity-stream.git","clone_url":"https://github.com/sarracini/activity-stream.git","svn_url":"https://github.com/sarracini/activity-stream","homepage":"","size":8625,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"e8ef6e23b38c4eed36c6d0bf3f04516290b86ad9","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":50695589,"name":"activity-stream","full_name":"mozilla/activity-stream","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/activity-stream","description":"A refreshed \"new tab page\" for Firefox","fork":false,"url":"https://api.github.com/repos/mozilla/activity-stream","forks_url":"https://api.github.com/repos/mozilla/activity-stream/forks","keys_url":"https://api.github.com/repos/mozilla/activity-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/activity-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/activity-stream/teams","hooks_url":"https://api.github.com/repos/mozilla/activity-stream/hooks","issue_events_url":"https://api.github.com/repos/mozilla/activity-stream/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/activity-stream/events","assignees_url":"https://api.github.com/repos/mozilla/activity-stream/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/activity-stream/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/activity-stream/tags","blobs_url":"https://api.github.com/repos/mozilla/activity-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/activity-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/activity-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/activity-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/activity-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/activity-stream/languages","stargazers_url":"https://api.github.com/repos/mozilla/activity-stream/stargazers","contributors_url":"https://api.github.com/repos/mozilla/activity-stream/contributors","subscribers_url":"https://api.github.com/repos/mozilla/activity-stream/subscribers","subscription_url":"https://api.github.com/repos/mozilla/activity-stream/subscription","commits_url":"https://api.github.com/repos/mozilla/activity-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/activity-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/activity-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/activity-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/activity-stream/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/activity-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/activity-stream/merges","archive_url":"https://api.github.com/repos/mozilla/activity-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/activity-stream/downloads","issues_url":"https://api.github.com/repos/mozilla/activity-stream/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/activity-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/activity-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/activity-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/activity-stream/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/activity-stream/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/activity-stream/deployments","created_at":"2016-01-29T22:28:26Z","updated_at":"2018-03-27T18:36:07Z","pushed_at":"2018-03-27T19:41:33Z","git_url":"git://github.com/mozilla/activity-stream.git","ssh_url":"git@github.com:mozilla/activity-stream.git","clone_url":"https://github.com/mozilla/activity-stream.git","svn_url":"https://github.com/mozilla/activity-stream","homepage":"","size":9264,"stargazers_count":146,"watchers_count":146,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":95,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":95,"open_issues":12,"watchers":146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/4059"},"html":{"href":"https://github.com/mozilla/activity-stream/pull/4059"},"issue":{"href":"https://api.github.com/repos/mozilla/activity-stream/issues/4059"},"comments":{"href":"https://api.github.com/repos/mozilla/activity-stream/issues/4059/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/4059/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/4059/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/activity-stream/statuses/2f6864d791909ed6ebce5a755fc4f2c096a43b60"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Mardak"}}