{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/220361753","pull_request_review_id":158753259,"id":220361753,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDM2MTc1Mw==","diff_hunk":"@@ -50,4 +50,7 @@ message CircuitBreakers {\n   // :ref:`RoutingPriority<envoy_api_enum_core.RoutingPriority>`, the default values\n   // are used.\n   repeated Thresholds thresholds = 1;\n+\n+  // Whether circuit breaking should be enabled. Defaults to true.\n+  google.protobuf.BoolValue enabled = 2;","path":"api/envoy/api/v2/cluster/circuit_breaker.proto","position":6,"original_position":6,"commit_id":"b51d491cdaadcab7fbb1b159728f1b5741855657","original_commit_id":"b51d491cdaadcab7fbb1b159728f1b5741855657","user":{"login":"rshriram","id":8202871,"node_id":"MDQ6VXNlcjgyMDI4NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/8202871?v=4","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false},"body":"Yeah, but keep in mind that we are not necessarily optimizing for hand configured Envoys. Also, given that this is all YAML, its very easy to simply comment out the entire circuit breaker thing. Often times, the user will *not* configure a circuit breaker (that being her intent - no circuit breaker). So, if not configured, it should not be enabled.. It makes no sense to configure the circuit breaker with all the 100 levels of nesting in a proto, only to set a small boolean field..","created_at":"2018-09-25T21:27:52Z","updated_at":"2018-09-25T21:27:52Z","html_url":"https://github.com/envoyproxy/envoy/pull/4520#discussion_r220361753","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4520","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/220361753"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/4520#discussion_r220361753"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4520"}},"in_reply_to_id":220300251},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4520","id":217795703,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3Nzk1NzAz","html_url":"https://github.com/envoyproxy/envoy/pull/4520","diff_url":"https://github.com/envoyproxy/envoy/pull/4520.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/4520.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4520","number":4520,"state":"open","locked":false,"title":"cluster: add a switch to enable/disable circuit breakers","user":{"login":"venilnoronha","id":1722758,"node_id":"MDQ6VXNlcjE3MjI3NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1722758?v=4","gravatar_id":"","url":"https://api.github.com/users/venilnoronha","html_url":"https://github.com/venilnoronha","followers_url":"https://api.github.com/users/venilnoronha/followers","following_url":"https://api.github.com/users/venilnoronha/following{/other_user}","gists_url":"https://api.github.com/users/venilnoronha/gists{/gist_id}","starred_url":"https://api.github.com/users/venilnoronha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/venilnoronha/subscriptions","organizations_url":"https://api.github.com/users/venilnoronha/orgs","repos_url":"https://api.github.com/users/venilnoronha/repos","events_url":"https://api.github.com/users/venilnoronha/events{/privacy}","received_events_url":"https://api.github.com/users/venilnoronha/received_events","type":"User","site_admin":false},"body":"*Description*:\r\nThis PR adds a configurable flag that allows disabling of circuit breakers.\r\n\r\nSigned-off-by: Venil Noronha <veniln@vmware.com>\r\n\r\n*Risk Level*: Med\r\n*Testing*: Existing tests + a new test\r\n*Docs Changes*: N/A\r\n*Release Notes*: Added a note about this feature\r\nFixes #4337\r\n\r\n/cc @snowp ","created_at":"2018-09-24T21:36:21Z","updated_at":"2018-09-25T21:27:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03365ec9667c37f217d7a64d7cf5eaf32b1ddd80","assignee":{"login":"junr03","id":6007532,"node_id":"MDQ6VXNlcjYwMDc1MzI=","avatar_url":"https://avatars0.githubusercontent.com/u/6007532?v=4","gravatar_id":"","url":"https://api.github.com/users/junr03","html_url":"https://github.com/junr03","followers_url":"https://api.github.com/users/junr03/followers","following_url":"https://api.github.com/users/junr03/following{/other_user}","gists_url":"https://api.github.com/users/junr03/gists{/gist_id}","starred_url":"https://api.github.com/users/junr03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junr03/subscriptions","organizations_url":"https://api.github.com/users/junr03/orgs","repos_url":"https://api.github.com/users/junr03/repos","events_url":"https://api.github.com/users/junr03/events{/privacy}","received_events_url":"https://api.github.com/users/junr03/received_events","type":"User","site_admin":false},"assignees":[{"login":"junr03","id":6007532,"node_id":"MDQ6VXNlcjYwMDc1MzI=","avatar_url":"https://avatars0.githubusercontent.com/u/6007532?v=4","gravatar_id":"","url":"https://api.github.com/users/junr03","html_url":"https://github.com/junr03","followers_url":"https://api.github.com/users/junr03/followers","following_url":"https://api.github.com/users/junr03/following{/other_user}","gists_url":"https://api.github.com/users/junr03/gists{/gist_id}","starred_url":"https://api.github.com/users/junr03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junr03/subscriptions","organizations_url":"https://api.github.com/users/junr03/orgs","repos_url":"https://api.github.com/users/junr03/repos","events_url":"https://api.github.com/users/junr03/events{/privacy}","received_events_url":"https://api.github.com/users/junr03/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4520/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4520/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4520/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/b51d491cdaadcab7fbb1b159728f1b5741855657","head":{"label":"venilnoronha:cb-switch","ref":"cb-switch","sha":"b51d491cdaadcab7fbb1b159728f1b5741855657","user":{"login":"venilnoronha","id":1722758,"node_id":"MDQ6VXNlcjE3MjI3NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1722758?v=4","gravatar_id":"","url":"https://api.github.com/users/venilnoronha","html_url":"https://github.com/venilnoronha","followers_url":"https://api.github.com/users/venilnoronha/followers","following_url":"https://api.github.com/users/venilnoronha/following{/other_user}","gists_url":"https://api.github.com/users/venilnoronha/gists{/gist_id}","starred_url":"https://api.github.com/users/venilnoronha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/venilnoronha/subscriptions","organizations_url":"https://api.github.com/users/venilnoronha/orgs","repos_url":"https://api.github.com/users/venilnoronha/repos","events_url":"https://api.github.com/users/venilnoronha/events{/privacy}","received_events_url":"https://api.github.com/users/venilnoronha/received_events","type":"User","site_admin":false},"repo":{"id":140466161,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA0NjYxNjE=","name":"envoy","full_name":"venilnoronha/envoy","private":false,"owner":{"login":"venilnoronha","id":1722758,"node_id":"MDQ6VXNlcjE3MjI3NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1722758?v=4","gravatar_id":"","url":"https://api.github.com/users/venilnoronha","html_url":"https://github.com/venilnoronha","followers_url":"https://api.github.com/users/venilnoronha/followers","following_url":"https://api.github.com/users/venilnoronha/following{/other_user}","gists_url":"https://api.github.com/users/venilnoronha/gists{/gist_id}","starred_url":"https://api.github.com/users/venilnoronha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/venilnoronha/subscriptions","organizations_url":"https://api.github.com/users/venilnoronha/orgs","repos_url":"https://api.github.com/users/venilnoronha/repos","events_url":"https://api.github.com/users/venilnoronha/events{/privacy}","received_events_url":"https://api.github.com/users/venilnoronha/received_events","type":"User","site_admin":false},"html_url":"https://github.com/venilnoronha/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/venilnoronha/envoy","forks_url":"https://api.github.com/repos/venilnoronha/envoy/forks","keys_url":"https://api.github.com/repos/venilnoronha/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/venilnoronha/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/venilnoronha/envoy/teams","hooks_url":"https://api.github.com/repos/venilnoronha/envoy/hooks","issue_events_url":"https://api.github.com/repos/venilnoronha/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/venilnoronha/envoy/events","assignees_url":"https://api.github.com/repos/venilnoronha/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/venilnoronha/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/venilnoronha/envoy/tags","blobs_url":"https://api.github.com/repos/venilnoronha/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/venilnoronha/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/venilnoronha/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/venilnoronha/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/venilnoronha/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/venilnoronha/envoy/languages","stargazers_url":"https://api.github.com/repos/venilnoronha/envoy/stargazers","contributors_url":"https://api.github.com/repos/venilnoronha/envoy/contributors","subscribers_url":"https://api.github.com/repos/venilnoronha/envoy/subscribers","subscription_url":"https://api.github.com/repos/venilnoronha/envoy/subscription","commits_url":"https://api.github.com/repos/venilnoronha/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/venilnoronha/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/venilnoronha/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/venilnoronha/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/venilnoronha/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/venilnoronha/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/venilnoronha/envoy/merges","archive_url":"https://api.github.com/repos/venilnoronha/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/venilnoronha/envoy/downloads","issues_url":"https://api.github.com/repos/venilnoronha/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/venilnoronha/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/venilnoronha/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/venilnoronha/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/venilnoronha/envoy/labels{/name}","releases_url":"https://api.github.com/repos/venilnoronha/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/venilnoronha/envoy/deployments","created_at":"2018-07-10T17:26:12Z","updated_at":"2018-07-10T17:26:19Z","pushed_at":"2018-09-24T23:03:43Z","git_url":"git://github.com/venilnoronha/envoy.git","ssh_url":"git@github.com:venilnoronha/envoy.git","clone_url":"https://github.com/venilnoronha/envoy.git","svn_url":"https://github.com/venilnoronha/envoy","homepage":"https://www.envoyproxy.io","size":21086,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"7e01342c250b2f1fb407e8996f28b5d852ca6ee4","user":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"node_id":"MDEwOlJlcG9zaXRvcnk2NTIxNDE5MQ==","name":"envoy","full_name":"envoyproxy/envoy","private":false,"owner":{"login":"envoyproxy","id":30125649,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMTI1NjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-09-25T20:13:31Z","pushed_at":"2018-09-25T21:16:01Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":20870,"stargazers_count":6650,"watchers_count":6650,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":893,"mirror_url":null,"archived":false,"open_issues_count":346,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":893,"open_issues":346,"watchers":6650,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4520"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/4520"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/4520"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/4520/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4520/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/4520/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/b51d491cdaadcab7fbb1b159728f1b5741855657"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rshriram"}}