{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65912","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65912/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65912/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65912/events","html_url":"https://github.com/kubernetes/kubernetes/pull/65912","id":339008126,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODAwMjM1","number":65912,"title":"WIP Add finalizer cleanup logic to service controller to support finalizer deletion","user":{"login":"jhorwit2","id":3876739,"node_id":"MDQ6VXNlcjM4NzY3Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/3876739?v=4","gravatar_id":"","url":"https://api.github.com/users/jhorwit2","html_url":"https://github.com/jhorwit2","followers_url":"https://api.github.com/users/jhorwit2/followers","following_url":"https://api.github.com/users/jhorwit2/following{/other_user}","gists_url":"https://api.github.com/users/jhorwit2/gists{/gist_id}","starred_url":"https://api.github.com/users/jhorwit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhorwit2/subscriptions","organizations_url":"https://api.github.com/users/jhorwit2/orgs","repos_url":"https://api.github.com/users/jhorwit2/repos","events_url":"https://api.github.com/users/jhorwit2/events{/privacy}","received_events_url":"https://api.github.com/users/jhorwit2/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":687500047,"node_id":"MDU6TGFiZWw2ODc1MDAwNDc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-06T16:59:49Z","updated_at":"2018-07-06T17:09:40Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/65912","html_url":"https://github.com/kubernetes/kubernetes/pull/65912","diff_url":"https://github.com/kubernetes/kubernetes/pull/65912.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/65912.patch"},"body":"\r\n\r\n**What this PR does / why we need it**:\r\n\r\nThis PR adds finalizer cleanup logic to the service controller which will enable a future release to add finalizer logic to the service controller that ensures that the cloud resources are cleaned up prior to removing the finalizer. This ensures that a rollback to the prior version of Kubernetes does not break services with the finalizer added. \r\n\r\nRef #54569\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nAdd support for cleaning up service load balancer finalizers to enable rollbacks once we release finalizer protection when deleting load balancer services. \r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/403093660","html_url":"https://github.com/kubernetes/kubernetes/pull/65912#issuecomment-403093660","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/65912","id":403093660,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzA5MzY2MA==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-07-06T17:09:39Z","updated_at":"2018-07-06T17:09:39Z","author_association":"COLLABORATOR","body":"@jhorwit2: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-e2e-kops-aws | 09eddfe2b3802dc100fac2e6d91734e8a75a7739 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/65912/pull-kubernetes-e2e-kops-aws/96265/) | `/test pull-kubernetes-e2e-kops-aws`\npull-kubernetes-e2e-gce | 09eddfe2b3802dc100fac2e6d91734e8a75a7739 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/65912/pull-kubernetes-e2e-gce/43578/) | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-e2e-gce-device-plugin-gpu | 7fb2a7f4aa45e07220f82d4e179f82bda0d6e3b4 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/65912/pull-kubernetes-e2e-gce-device-plugin-gpu/39150/) | `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\npull-kubernetes-bazel-build | 7fb2a7f4aa45e07220f82d4e179f82bda0d6e3b4 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/65912/pull-kubernetes-bazel-build/49430/) | `/test pull-kubernetes-bazel-build`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/65912). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/jhorwit2). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}