{"action":"created","comment":{"url":"https://api.github.com/repos/GQCG/gqcp/pulls/comments/242948232","pull_request_review_id":186569036,"id":242948232,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mjk0ODIzMg==","diff_hunk":"@@ -76,19 +76,18 @@ const Eigenpair& DOCINewtonOrbitalOptimizer::get_eigenpair(size_t index) const {\n void DOCINewtonOrbitalOptimizer::solve(BaseSolverOptions& solver_options, const OrbitalOptimizationOptions& oo_options) {\n     this->is_converged = false;\n     auto K = this->ham_par.get_K();\n-\n+    RDMCalculator rdm_calculator(*this->doci.get_fock_space());","path":"src/DOCINewtonOrbitalOptimizer.cpp","position":5,"original_position":5,"commit_id":"2deae7ae8ab1f33e70ccce7ff2ef3fe381a78436","original_commit_id":"2deae7ae8ab1f33e70ccce7ff2ef3fe381a78436","user":{"login":"lelemmen","id":23526798,"node_id":"MDQ6VXNlcjIzNTI2Nzk4","avatar_url":"https://avatars0.githubusercontent.com/u/23526798?v=4","gravatar_id":"","url":"https://api.github.com/users/lelemmen","html_url":"https://github.com/lelemmen","followers_url":"https://api.github.com/users/lelemmen/followers","following_url":"https://api.github.com/users/lelemmen/following{/other_user}","gists_url":"https://api.github.com/users/lelemmen/gists{/gist_id}","starred_url":"https://api.github.com/users/lelemmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lelemmen/subscriptions","organizations_url":"https://api.github.com/users/lelemmen/orgs","repos_url":"https://api.github.com/users/lelemmen/repos","events_url":"https://api.github.com/users/lelemmen/events{/privacy}","received_events_url":"https://api.github.com/users/lelemmen/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n     RDMCalculator rdm_calculator(*this->doci.get_fock_space());  // make the RDMCalculator beforehand, it doesn't have to be constructed in every iteration\r\n```","created_at":"2018-12-19T15:02:53Z","updated_at":"2018-12-19T15:05:52Z","html_url":"https://github.com/GQCG/gqcp/pull/207#discussion_r242948232","pull_request_url":"https://api.github.com/repos/GQCG/gqcp/pulls/207","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GQCG/gqcp/pulls/comments/242948232"},"html":{"href":"https://github.com/GQCG/gqcp/pull/207#discussion_r242948232"},"pull_request":{"href":"https://api.github.com/repos/GQCG/gqcp/pulls/207"}}},"pull_request":{"url":"https://api.github.com/repos/GQCG/gqcp/pulls/207","id":239810378,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5ODEwMzc4","html_url":"https://github.com/GQCG/gqcp/pull/207","diff_url":"https://github.com/GQCG/gqcp/pull/207.diff","patch_url":"https://github.com/GQCG/gqcp/pull/207.patch","issue_url":"https://api.github.com/repos/GQCG/gqcp/issues/207","number":207,"state":"open","locked":false,"title":"Feature/rdm calculator refactor","user":{"login":"tmhuysen","id":33662565,"node_id":"MDQ6VXNlcjMzNjYyNTY1","avatar_url":"https://avatars3.githubusercontent.com/u/33662565?v=4","gravatar_id":"","url":"https://api.github.com/users/tmhuysen","html_url":"https://github.com/tmhuysen","followers_url":"https://api.github.com/users/tmhuysen/followers","following_url":"https://api.github.com/users/tmhuysen/following{/other_user}","gists_url":"https://api.github.com/users/tmhuysen/gists{/gist_id}","starred_url":"https://api.github.com/users/tmhuysen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmhuysen/subscriptions","organizations_url":"https://api.github.com/users/tmhuysen/orgs","repos_url":"https://api.github.com/users/tmhuysen/repos","events_url":"https://api.github.com/users/tmhuysen/events{/privacy}","received_events_url":"https://api.github.com/users/tmhuysen/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-19T11:58:10Z","updated_at":"2018-12-19T15:05:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7728de4c47fb08ec9bba3d3bbf03d052bc2f02ab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GQCG/gqcp/pulls/207/commits","review_comments_url":"https://api.github.com/repos/GQCG/gqcp/pulls/207/comments","review_comment_url":"https://api.github.com/repos/GQCG/gqcp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GQCG/gqcp/issues/207/comments","statuses_url":"https://api.github.com/repos/GQCG/gqcp/statuses/2deae7ae8ab1f33e70ccce7ff2ef3fe381a78436","head":{"label":"tmhuysen:feature/RDMCalculator_Refactor","ref":"feature/RDMCalculator_Refactor","sha":"2deae7ae8ab1f33e70ccce7ff2ef3fe381a78436","user":{"login":"tmhuysen","id":33662565,"node_id":"MDQ6VXNlcjMzNjYyNTY1","avatar_url":"https://avatars3.githubusercontent.com/u/33662565?v=4","gravatar_id":"","url":"https://api.github.com/users/tmhuysen","html_url":"https://github.com/tmhuysen","followers_url":"https://api.github.com/users/tmhuysen/followers","following_url":"https://api.github.com/users/tmhuysen/following{/other_user}","gists_url":"https://api.github.com/users/tmhuysen/gists{/gist_id}","starred_url":"https://api.github.com/users/tmhuysen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmhuysen/subscriptions","organizations_url":"https://api.github.com/users/tmhuysen/orgs","repos_url":"https://api.github.com/users/tmhuysen/repos","events_url":"https://api.github.com/users/tmhuysen/events{/privacy}","received_events_url":"https://api.github.com/users/tmhuysen/received_events","type":"User","site_admin":false},"repo":{"id":155193053,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUxOTMwNTM=","name":"gqcp","full_name":"tmhuysen/gqcp","private":false,"owner":{"login":"tmhuysen","id":33662565,"node_id":"MDQ6VXNlcjMzNjYyNTY1","avatar_url":"https://avatars3.githubusercontent.com/u/33662565?v=4","gravatar_id":"","url":"https://api.github.com/users/tmhuysen","html_url":"https://github.com/tmhuysen","followers_url":"https://api.github.com/users/tmhuysen/followers","following_url":"https://api.github.com/users/tmhuysen/following{/other_user}","gists_url":"https://api.github.com/users/tmhuysen/gists{/gist_id}","starred_url":"https://api.github.com/users/tmhuysen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmhuysen/subscriptions","organizations_url":"https://api.github.com/users/tmhuysen/orgs","repos_url":"https://api.github.com/users/tmhuysen/repos","events_url":"https://api.github.com/users/tmhuysen/events{/privacy}","received_events_url":"https://api.github.com/users/tmhuysen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tmhuysen/gqcp","description":"The Ghent Quantum Chemistry Package for electronic structure calculations","fork":true,"url":"https://api.github.com/repos/tmhuysen/gqcp","forks_url":"https://api.github.com/repos/tmhuysen/gqcp/forks","keys_url":"https://api.github.com/repos/tmhuysen/gqcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmhuysen/gqcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmhuysen/gqcp/teams","hooks_url":"https://api.github.com/repos/tmhuysen/gqcp/hooks","issue_events_url":"https://api.github.com/repos/tmhuysen/gqcp/issues/events{/number}","events_url":"https://api.github.com/repos/tmhuysen/gqcp/events","assignees_url":"https://api.github.com/repos/tmhuysen/gqcp/assignees{/user}","branches_url":"https://api.github.com/repos/tmhuysen/gqcp/branches{/branch}","tags_url":"https://api.github.com/repos/tmhuysen/gqcp/tags","blobs_url":"https://api.github.com/repos/tmhuysen/gqcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmhuysen/gqcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmhuysen/gqcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmhuysen/gqcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmhuysen/gqcp/statuses/{sha}","languages_url":"https://api.github.com/repos/tmhuysen/gqcp/languages","stargazers_url":"https://api.github.com/repos/tmhuysen/gqcp/stargazers","contributors_url":"https://api.github.com/repos/tmhuysen/gqcp/contributors","subscribers_url":"https://api.github.com/repos/tmhuysen/gqcp/subscribers","subscription_url":"https://api.github.com/repos/tmhuysen/gqcp/subscription","commits_url":"https://api.github.com/repos/tmhuysen/gqcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmhuysen/gqcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmhuysen/gqcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmhuysen/gqcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmhuysen/gqcp/contents/{+path}","compare_url":"https://api.github.com/repos/tmhuysen/gqcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmhuysen/gqcp/merges","archive_url":"https://api.github.com/repos/tmhuysen/gqcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmhuysen/gqcp/downloads","issues_url":"https://api.github.com/repos/tmhuysen/gqcp/issues{/number}","pulls_url":"https://api.github.com/repos/tmhuysen/gqcp/pulls{/number}","milestones_url":"https://api.github.com/repos/tmhuysen/gqcp/milestones{/number}","notifications_url":"https://api.github.com/repos/tmhuysen/gqcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmhuysen/gqcp/labels{/name}","releases_url":"https://api.github.com/repos/tmhuysen/gqcp/releases{/id}","deployments_url":"https://api.github.com/repos/tmhuysen/gqcp/deployments","created_at":"2018-10-29T10:28:07Z","updated_at":"2018-12-18T13:26:22Z","pushed_at":"2018-12-19T14:53:57Z","git_url":"git://github.com/tmhuysen/gqcp.git","ssh_url":"git@github.com:tmhuysen/gqcp.git","clone_url":"https://github.com/tmhuysen/gqcp.git","svn_url":"https://github.com/tmhuysen/gqcp","homepage":"","size":4264,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"GQCG:develop","ref":"develop","sha":"5a588077794540b1d4b9ef2e05ec7cca34f71b8a","user":{"login":"GQCG","id":35603937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjAzOTM3","avatar_url":"https://avatars3.githubusercontent.com/u/35603937?v=4","gravatar_id":"","url":"https://api.github.com/users/GQCG","html_url":"https://github.com/GQCG","followers_url":"https://api.github.com/users/GQCG/followers","following_url":"https://api.github.com/users/GQCG/following{/other_user}","gists_url":"https://api.github.com/users/GQCG/gists{/gist_id}","starred_url":"https://api.github.com/users/GQCG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GQCG/subscriptions","organizations_url":"https://api.github.com/users/GQCG/orgs","repos_url":"https://api.github.com/users/GQCG/repos","events_url":"https://api.github.com/users/GQCG/events{/privacy}","received_events_url":"https://api.github.com/users/GQCG/received_events","type":"Organization","site_admin":false},"repo":{"id":145848504,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU4NDg1MDQ=","name":"gqcp","full_name":"GQCG/gqcp","private":false,"owner":{"login":"GQCG","id":35603937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjAzOTM3","avatar_url":"https://avatars3.githubusercontent.com/u/35603937?v=4","gravatar_id":"","url":"https://api.github.com/users/GQCG","html_url":"https://github.com/GQCG","followers_url":"https://api.github.com/users/GQCG/followers","following_url":"https://api.github.com/users/GQCG/following{/other_user}","gists_url":"https://api.github.com/users/GQCG/gists{/gist_id}","starred_url":"https://api.github.com/users/GQCG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GQCG/subscriptions","organizations_url":"https://api.github.com/users/GQCG/orgs","repos_url":"https://api.github.com/users/GQCG/repos","events_url":"https://api.github.com/users/GQCG/events{/privacy}","received_events_url":"https://api.github.com/users/GQCG/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GQCG/gqcp","description":"The Ghent Quantum Chemistry Package for electronic structure calculations","fork":false,"url":"https://api.github.com/repos/GQCG/gqcp","forks_url":"https://api.github.com/repos/GQCG/gqcp/forks","keys_url":"https://api.github.com/repos/GQCG/gqcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GQCG/gqcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GQCG/gqcp/teams","hooks_url":"https://api.github.com/repos/GQCG/gqcp/hooks","issue_events_url":"https://api.github.com/repos/GQCG/gqcp/issues/events{/number}","events_url":"https://api.github.com/repos/GQCG/gqcp/events","assignees_url":"https://api.github.com/repos/GQCG/gqcp/assignees{/user}","branches_url":"https://api.github.com/repos/GQCG/gqcp/branches{/branch}","tags_url":"https://api.github.com/repos/GQCG/gqcp/tags","blobs_url":"https://api.github.com/repos/GQCG/gqcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GQCG/gqcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GQCG/gqcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/GQCG/gqcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GQCG/gqcp/statuses/{sha}","languages_url":"https://api.github.com/repos/GQCG/gqcp/languages","stargazers_url":"https://api.github.com/repos/GQCG/gqcp/stargazers","contributors_url":"https://api.github.com/repos/GQCG/gqcp/contributors","subscribers_url":"https://api.github.com/repos/GQCG/gqcp/subscribers","subscription_url":"https://api.github.com/repos/GQCG/gqcp/subscription","commits_url":"https://api.github.com/repos/GQCG/gqcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/GQCG/gqcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/GQCG/gqcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/GQCG/gqcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/GQCG/gqcp/contents/{+path}","compare_url":"https://api.github.com/repos/GQCG/gqcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GQCG/gqcp/merges","archive_url":"https://api.github.com/repos/GQCG/gqcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GQCG/gqcp/downloads","issues_url":"https://api.github.com/repos/GQCG/gqcp/issues{/number}","pulls_url":"https://api.github.com/repos/GQCG/gqcp/pulls{/number}","milestones_url":"https://api.github.com/repos/GQCG/gqcp/milestones{/number}","notifications_url":"https://api.github.com/repos/GQCG/gqcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GQCG/gqcp/labels{/name}","releases_url":"https://api.github.com/repos/GQCG/gqcp/releases{/id}","deployments_url":"https://api.github.com/repos/GQCG/gqcp/deployments","created_at":"2018-08-23T12:10:29Z","updated_at":"2018-12-19T08:22:48Z","pushed_at":"2018-12-19T14:54:56Z","git_url":"git://github.com/GQCG/gqcp.git","ssh_url":"git@github.com:GQCG/gqcp.git","clone_url":"https://github.com/GQCG/gqcp.git","svn_url":"https://github.com/GQCG/gqcp","homepage":"","size":4162,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":3,"open_issues":49,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/GQCG/gqcp/pulls/207"},"html":{"href":"https://github.com/GQCG/gqcp/pull/207"},"issue":{"href":"https://api.github.com/repos/GQCG/gqcp/issues/207"},"comments":{"href":"https://api.github.com/repos/GQCG/gqcp/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/GQCG/gqcp/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/GQCG/gqcp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GQCG/gqcp/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/GQCG/gqcp/statuses/2deae7ae8ab1f33e70ccce7ff2ef3fe381a78436"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lelemmen"}}