{"action":"created","issue":{"url":"https://api.github.com/repos/pharo-project/pharo/issues/1671","repository_url":"https://api.github.com/repos/pharo-project/pharo","labels_url":"https://api.github.com/repos/pharo-project/pharo/issues/1671/labels{/name}","comments_url":"https://api.github.com/repos/pharo-project/pharo/issues/1671/comments","events_url":"https://api.github.com/repos/pharo-project/pharo/issues/1671/events","html_url":"https://github.com/pharo-project/pharo/pull/1671","id":347716343,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjQ5MzE4","number":1671,"title":"22296-Stdio-file-creation-fixes","user":{"login":"akgrant43","id":2062166,"node_id":"MDQ6VXNlcjIwNjIxNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/2062166?v=4","gravatar_id":"","url":"https://api.github.com/users/akgrant43","html_url":"https://github.com/akgrant43","followers_url":"https://api.github.com/users/akgrant43/followers","following_url":"https://api.github.com/users/akgrant43/following{/other_user}","gists_url":"https://api.github.com/users/akgrant43/gists{/gist_id}","starred_url":"https://api.github.com/users/akgrant43/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akgrant43/subscriptions","organizations_url":"https://api.github.com/users/akgrant43/orgs","repos_url":"https://api.github.com/users/akgrant43/repos","events_url":"https://api.github.com/users/akgrant43/events{/privacy}","received_events_url":"https://api.github.com/users/akgrant43/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-05T17:29:51Z","updated_at":"2018-08-08T10:35:04Z","closed_at":"2018-08-08T09:33:56Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/pharo-project/pharo/pulls/1671","html_url":"https://github.com/pharo-project/pharo/pull/1671","diff_url":"https://github.com/pharo-project/pharo/pull/1671.diff","patch_url":"https://github.com/pharo-project/pharo/pull/1671.patch"},"body":"22296 Stdio file creation fixes\n\nAddress the following issues with stdio file creation:\n\n1. If all three streams are redirected on non-Windows platforms it creates files instead of connecting to the streams.\nReplace #stdioDescriptorIsATTY with #stdioIsAvailable and correct file type comparisons\n\n2. The test on whether stdio streams should be available (#stdioDescriptorIsATTY) is incorrect - tests for a console, not for all valid stream types (console / terminal, file, pipe).\nAs above, replace #stdioDescriptorIsATTY with #stdioIsAvailable and correct file type comparisons\n\n3. The #stdioDescriptorIsATTY shouldn't be necessary in the first place - the VM should flag that no stream is available by returning nil instead of a sqFile handle.  This will be fixed separately, see https://github.com/OpenSmalltalk/opensmalltalk-vm/issues/274\nWhile waiting for the VM fix, and for backward compatibilty, leave the #isWindows block in to create files if no stdio is available.\n\n4. The windows test incorrectly uses #isWin32 instead of #isWindows.\n\nFogbugz: https://pharo.fogbugz.com/f/cases/22296/Stdio-file-creation-fixes"},"comment":{"url":"https://api.github.com/repos/pharo-project/pharo/issues/comments/411362258","html_url":"https://github.com/pharo-project/pharo/pull/1671#issuecomment-411362258","issue_url":"https://api.github.com/repos/pharo-project/pharo/issues/1671","id":411362258,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTM2MjI1OA==","user":{"login":"akgrant43","id":2062166,"node_id":"MDQ6VXNlcjIwNjIxNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/2062166?v=4","gravatar_id":"","url":"https://api.github.com/users/akgrant43","html_url":"https://github.com/akgrant43","followers_url":"https://api.github.com/users/akgrant43/followers","following_url":"https://api.github.com/users/akgrant43/following{/other_user}","gists_url":"https://api.github.com/users/akgrant43/gists{/gist_id}","starred_url":"https://api.github.com/users/akgrant43/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akgrant43/subscriptions","organizations_url":"https://api.github.com/users/akgrant43/orgs","repos_url":"https://api.github.com/users/akgrant43/repos","events_url":"https://api.github.com/users/akgrant43/events{/privacy}","received_events_url":"https://api.github.com/users/akgrant43/received_events","type":"User","site_admin":false},"created_at":"2018-08-08T10:35:04Z","updated_at":"2018-08-08T10:35:04Z","author_association":"COLLABORATOR","body":"Thanks, Marcus, Guille & Damien!"}}
{"actor":{"display_login":"akgrant43"}}