{"action":"created","comment":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/comments/203734328","pull_request_review_id":138680168,"id":203734328,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzczNDMyOA==","diff_hunk":"@@ -829,6 +829,9 @@ func expandStorageAccountBypass(networkRule map[string]interface{}) storage.Bypa\n }\n \n func flattenStorageAccountNetworkRules(input *storage.NetworkRuleSet) []interface{} {\n+\tif len(*input.IPRules) == 0 && len(*input.VirtualNetworkRules) == 0 {","path":"azurerm/resource_arm_storage_account.go","position":13,"original_position":13,"commit_id":"8d71a2a2eebaf75159212f4118cc87cb7bcdd4ee","original_commit_id":"8d71a2a2eebaf75159212f4118cc87cb7bcdd4ee","user":{"login":"tombuildsstuff","id":666005,"node_id":"MDQ6VXNlcjY2NjAwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/666005?v=4","gravatar_id":"","url":"https://api.github.com/users/tombuildsstuff","html_url":"https://github.com/tombuildsstuff","followers_url":"https://api.github.com/users/tombuildsstuff/followers","following_url":"https://api.github.com/users/tombuildsstuff/following{/other_user}","gists_url":"https://api.github.com/users/tombuildsstuff/gists{/gist_id}","starred_url":"https://api.github.com/users/tombuildsstuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tombuildsstuff/subscriptions","organizations_url":"https://api.github.com/users/tombuildsstuff/orgs","repos_url":"https://api.github.com/users/tombuildsstuff/repos","events_url":"https://api.github.com/users/tombuildsstuff/events{/privacy}","received_events_url":"https://api.github.com/users/tombuildsstuff/received_events","type":"User","site_admin":false},"body":"which means this could become\r\n\r\n```\r\nif input == nil {\r\n  return []interface{}{}\r\n}\r\n```","created_at":"2018-07-19T13:53:06Z","updated_at":"2018-07-19T13:55:04Z","html_url":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/1613#discussion_r203734328","pull_request_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/1613","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/comments/203734328"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/1613#discussion_r203734328"},"pull_request":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/1613"}}},"pull_request":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/1613","id":202557091,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNTU3MDkx","html_url":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/1613","diff_url":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/1613.diff","patch_url":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/1613.patch","issue_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/1613","number":1613,"state":"open","locked":false,"title":"Additional checks for network_rules during read","user":{"login":"mbfrahry","id":6515518,"node_id":"MDQ6VXNlcjY1MTU1MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6515518?v=4","gravatar_id":"","url":"https://api.github.com/users/mbfrahry","html_url":"https://github.com/mbfrahry","followers_url":"https://api.github.com/users/mbfrahry/followers","following_url":"https://api.github.com/users/mbfrahry/following{/other_user}","gists_url":"https://api.github.com/users/mbfrahry/gists{/gist_id}","starred_url":"https://api.github.com/users/mbfrahry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbfrahry/subscriptions","organizations_url":"https://api.github.com/users/mbfrahry/orgs","repos_url":"https://api.github.com/users/mbfrahry/repos","events_url":"https://api.github.com/users/mbfrahry/events{/privacy}","received_events_url":"https://api.github.com/users/mbfrahry/received_events","type":"User","site_admin":false},"body":"This PR address #1412. \r\n\r\nThe plan from that users config will no return \r\n```\r\n  ~ azurerm_storage_account.test\r\n      network_rules.#:                                       \"0\" => \"1\"\r\n      network_rules.0.bypass.#:                              \"\" => <computed>\r\n      network_rules.0.virtual_network_subnet_ids.#:          \"0\" => \"1\"\r\n      network_rules.0.virtual_network_subnet_ids.3418614067: \"\" => \"/subscriptions/c0a607b2-6372-4ef3-abdb-dbe52a7b56ba/resourceGroups/test-rg1412/providers/Microsoft.Network/virtualNetworks/test-vnet/subnets/subnet\"\r\n```\r\n\r\nTests still pass \r\n```\r\n=== RUN   TestAccAzureRMStorageAccount_networkRules\r\n--- PASS: TestAccAzureRMStorageAccount_networkRules (123.25s)\r\n=== RUN   TestAccAzureRMStorageAccount_networkRulesDeleted\r\n--- PASS: TestAccAzureRMStorageAccount_networkRulesDeleted (109.85s)\r\n```","created_at":"2018-07-19T13:20:44Z","updated_at":"2018-07-19T13:55:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57fe58a2c62f008a513440d4874ffc9f847b02f0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":717219131,"node_id":"MDU6TGFiZWw3MTcyMTkxMzE=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/labels/service/storage","name":"service/storage","color":"77bb77","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/1613/commits","review_comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/1613/comments","review_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/1613/comments","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/statuses/8d71a2a2eebaf75159212f4118cc87cb7bcdd4ee","head":{"label":"terraform-providers:b-1412","ref":"b-1412","sha":"8d71a2a2eebaf75159212f4118cc87cb7bcdd4ee","user":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"repo":{"id":93446042,"node_id":"MDEwOlJlcG9zaXRvcnk5MzQ0NjA0Mg==","name":"terraform-provider-azurerm","full_name":"terraform-providers/terraform-provider-azurerm","owner":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/terraform-providers/terraform-provider-azurerm","description":"Terraform Azure Resource Manager provider","fork":false,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm","forks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/forks","keys_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/teams","hooks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/hooks","issue_events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/events","assignees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/tags","blobs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/languages","stargazers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/stargazers","contributors_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/contributors","subscribers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/subscribers","subscription_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/subscription","commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/merges","archive_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/downloads","issues_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/labels{/name}","releases_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/deployments","created_at":"2017-06-05T20:53:54Z","updated_at":"2018-07-19T11:44:07Z","pushed_at":"2018-07-19T13:20:44Z","git_url":"git://github.com/terraform-providers/terraform-provider-azurerm.git","ssh_url":"git@github.com:terraform-providers/terraform-provider-azurerm.git","clone_url":"https://github.com/terraform-providers/terraform-provider-azurerm.git","svn_url":"https://github.com/terraform-providers/terraform-provider-azurerm","homepage":"https://www.terraform.io/docs/providers/azurerm/","size":18409,"stargazers_count":395,"watchers_count":395,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":352,"mirror_url":null,"archived":false,"open_issues_count":245,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":352,"open_issues":245,"watchers":395,"default_branch":"master"}},"base":{"label":"terraform-providers:master","ref":"master","sha":"1b1f18aac005984162e28bb166aeaef8f6048756","user":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"repo":{"id":93446042,"node_id":"MDEwOlJlcG9zaXRvcnk5MzQ0NjA0Mg==","name":"terraform-provider-azurerm","full_name":"terraform-providers/terraform-provider-azurerm","owner":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/terraform-providers/terraform-provider-azurerm","description":"Terraform Azure Resource Manager provider","fork":false,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm","forks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/forks","keys_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/teams","hooks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/hooks","issue_events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/events","assignees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/tags","blobs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/languages","stargazers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/stargazers","contributors_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/contributors","subscribers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/subscribers","subscription_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/subscription","commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/merges","archive_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/downloads","issues_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/labels{/name}","releases_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/deployments","created_at":"2017-06-05T20:53:54Z","updated_at":"2018-07-19T11:44:07Z","pushed_at":"2018-07-19T13:20:44Z","git_url":"git://github.com/terraform-providers/terraform-provider-azurerm.git","ssh_url":"git@github.com:terraform-providers/terraform-provider-azurerm.git","clone_url":"https://github.com/terraform-providers/terraform-provider-azurerm.git","svn_url":"https://github.com/terraform-providers/terraform-provider-azurerm","homepage":"https://www.terraform.io/docs/providers/azurerm/","size":18409,"stargazers_count":395,"watchers_count":395,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":352,"mirror_url":null,"archived":false,"open_issues_count":245,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":352,"open_issues":245,"watchers":395,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/1613"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/1613"},"issue":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/1613"},"comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/1613/comments"},"review_comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/1613/comments"},"review_comment":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/1613/commits"},"statuses":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/statuses/8d71a2a2eebaf75159212f4118cc87cb7bcdd4ee"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tombuildsstuff"}}