{"action":"created","comment":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/comments/217899592","pull_request_review_id":155729217,"id":217899592,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzg5OTU5Mg==","diff_hunk":"@@ -1221,6 +1248,57 @@ void lcd_quick_feedback(const bool clear_buttons) {\n     END_MENU();\n   }\n \n+  #if ENABLED(LIN_ADVANCE)\n+    void lcd_linadv_menu(){\n+      START_MENU();\n+      MENU_BACK(MSG_BACK);\n+      #if EXTRUDERS == 1\n+        MENU_ITEM_EDIT(float52, MSG_ADVANCE_K, &planner.extruder_advance_K[0], 0, 999);\n+      #elif EXTRUDERS > 1\n+        MENU_ITEM_EDIT(float52, MSG_ADVANCE_K \" \" MSG_E1, &planner.extruder_advance_K[0], 0, 999);\n+        MENU_ITEM_EDIT(float52, MSG_ADVANCE_K \" \" MSG_E2, &planner.extruder_advance_K[1], 0, 999);\n+        #if EXTRUDERS > 2\n+          MENU_ITEM_EDIT(float52, MSG_ADVANCE_K \" \" MSG_E3, &planner.extruder_advance_K[2], 0, 999);\n+            #if EXTRUDERS > 3\n+              MENU_ITEM_EDIT(float52, MSG_ADVANCE_K \" \" MSG_E4, &planner.extruder_advance_K[3], 0, 999);\n+                #if EXTRUDERS > 4\n+                  MENU_ITEM_EDIT(float52, MSG_ADVANCE_K \" \" MSG_E5, &planner.extruder_advance_K[4], 0, 999);\n+                #endif // EXTRUDERS > 4\n+              #endif // EXTRUDERS > 3\n+        #endif // EXTRUDERS > 2\n+#endif // EXTRUDERS > 1\n+\n+      END_MENU();\n+    }\n+  #endif\n+\n+  #if DISABLED(NO_VOLUMETRIC)\n+    void lcd_filament_width_menu(){\n+      START_MENU();\n+      MENU_BACK(MSG_BACK);\n+        MENU_ITEM_EDIT_CALLBACK(bool, MSG_VOLUMETRIC_ENABLED, &parser.volumetric_enabled, planner.calculate_volumetric_multipliers);\n+\n+        if (parser.volumetric_enabled) {\n+          #if EXTRUDERS == 1\n+            MENU_MULTIPLIER_ITEM_EDIT_CALLBACK(float43, MSG_FILAMENT_DIAM, &planner.filament_size[0], 1.5f, 3.25f, planner.calculate_volumetric_multipliers);\n+          #else // EXTRUDERS > 1\n+            MENU_MULTIPLIER_ITEM_EDIT_CALLBACK(float43, MSG_FILAMENT_DIAM \" \" MSG_ACTIVE, &planner.filament_size[active_extruder], 1.5f, 3.25f, planner.calculate_volumetric_multipliers);","path":"Marlin/src/lcd/ultralcd.cpp","position":163,"original_position":163,"commit_id":"72279db86527e9554fd176c315078c8f1e580adf","original_commit_id":"72279db86527e9554fd176c315078c8f1e580adf","user":{"login":"thinkyhead","id":698003,"node_id":"MDQ6VXNlcjY5ODAwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/698003?v=4","gravatar_id":"","url":"https://api.github.com/users/thinkyhead","html_url":"https://github.com/thinkyhead","followers_url":"https://api.github.com/users/thinkyhead/followers","following_url":"https://api.github.com/users/thinkyhead/following{/other_user}","gists_url":"https://api.github.com/users/thinkyhead/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkyhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkyhead/subscriptions","organizations_url":"https://api.github.com/users/thinkyhead/orgs","repos_url":"https://api.github.com/users/thinkyhead/repos","events_url":"https://api.github.com/users/thinkyhead/events{/privacy}","received_events_url":"https://api.github.com/users/thinkyhead/received_events","type":"User","site_admin":false},"body":"This is not compatible with translations, because different languages use different word orders.","created_at":"2018-09-16T01:30:28Z","updated_at":"2018-09-16T01:30:28Z","html_url":"https://github.com/MarlinFirmware/Marlin/pull/11802#discussion_r217899592","pull_request_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/11802","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/comments/217899592"},"html":{"href":"https://github.com/MarlinFirmware/Marlin/pull/11802#discussion_r217899592"},"pull_request":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/11802"}}},"pull_request":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/11802","id":214586759,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NTg2NzU5","html_url":"https://github.com/MarlinFirmware/Marlin/pull/11802","diff_url":"https://github.com/MarlinFirmware/Marlin/pull/11802.diff","patch_url":"https://github.com/MarlinFirmware/Marlin/pull/11802.patch","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/11802","number":11802,"state":"open","locked":false,"title":"[2.0.x] Added Print-Time Settings Changes to LCD Tune Menu","user":{"login":"SJ-Innovation","id":9569766,"node_id":"MDQ6VXNlcjk1Njk3NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/9569766?v=4","gravatar_id":"","url":"https://api.github.com/users/SJ-Innovation","html_url":"https://github.com/SJ-Innovation","followers_url":"https://api.github.com/users/SJ-Innovation/followers","following_url":"https://api.github.com/users/SJ-Innovation/following{/other_user}","gists_url":"https://api.github.com/users/SJ-Innovation/gists{/gist_id}","starred_url":"https://api.github.com/users/SJ-Innovation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SJ-Innovation/subscriptions","organizations_url":"https://api.github.com/users/SJ-Innovation/orgs","repos_url":"https://api.github.com/users/SJ-Innovation/repos","events_url":"https://api.github.com/users/SJ-Innovation/events{/privacy}","received_events_url":"https://api.github.com/users/SJ-Innovation/received_events","type":"User","site_admin":false},"body":"\r\n### Description\r\n\r\nWhen connected to a PC for a print, editing settings like FWRetract and Linear Advance is simply achieved using a GCode. When printing from SD this functionality was missing from the menus, as well as being convoluted to find even when not printing. \r\n\r\nThis PR adds this functionality to the tune menu, as well as cleans up some other menus that were becoming bloated. \r\n\r\n\r\n\r\n","created_at":"2018-09-11T10:32:51Z","updated_at":"2018-09-16T01:30:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30e7f684e2f3d0da0e044a2c02f98fb2427256a9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/11802/commits","review_comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/11802/comments","review_comment_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/11802/comments","statuses_url":"https://api.github.com/repos/MarlinFirmware/Marlin/statuses/72279db86527e9554fd176c315078c8f1e580adf","head":{"label":"SJ-Innovation:bf2_UltraLCD_Restructure","ref":"bf2_UltraLCD_Restructure","sha":"72279db86527e9554fd176c315078c8f1e580adf","user":{"login":"SJ-Innovation","id":9569766,"node_id":"MDQ6VXNlcjk1Njk3NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/9569766?v=4","gravatar_id":"","url":"https://api.github.com/users/SJ-Innovation","html_url":"https://github.com/SJ-Innovation","followers_url":"https://api.github.com/users/SJ-Innovation/followers","following_url":"https://api.github.com/users/SJ-Innovation/following{/other_user}","gists_url":"https://api.github.com/users/SJ-Innovation/gists{/gist_id}","starred_url":"https://api.github.com/users/SJ-Innovation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SJ-Innovation/subscriptions","organizations_url":"https://api.github.com/users/SJ-Innovation/orgs","repos_url":"https://api.github.com/users/SJ-Innovation/repos","events_url":"https://api.github.com/users/SJ-Innovation/events{/privacy}","received_events_url":"https://api.github.com/users/SJ-Innovation/received_events","type":"User","site_admin":false},"repo":{"id":133145678,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMxNDU2Nzg=","name":"Marlin","full_name":"SJ-Innovation/Marlin","private":false,"owner":{"login":"SJ-Innovation","id":9569766,"node_id":"MDQ6VXNlcjk1Njk3NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/9569766?v=4","gravatar_id":"","url":"https://api.github.com/users/SJ-Innovation","html_url":"https://github.com/SJ-Innovation","followers_url":"https://api.github.com/users/SJ-Innovation/followers","following_url":"https://api.github.com/users/SJ-Innovation/following{/other_user}","gists_url":"https://api.github.com/users/SJ-Innovation/gists{/gist_id}","starred_url":"https://api.github.com/users/SJ-Innovation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SJ-Innovation/subscriptions","organizations_url":"https://api.github.com/users/SJ-Innovation/orgs","repos_url":"https://api.github.com/users/SJ-Innovation/repos","events_url":"https://api.github.com/users/SJ-Innovation/events{/privacy}","received_events_url":"https://api.github.com/users/SJ-Innovation/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SJ-Innovation/Marlin","description":"Optimized firmware for RepRap 3D printers based on the Arduino platform.","fork":true,"url":"https://api.github.com/repos/SJ-Innovation/Marlin","forks_url":"https://api.github.com/repos/SJ-Innovation/Marlin/forks","keys_url":"https://api.github.com/repos/SJ-Innovation/Marlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SJ-Innovation/Marlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SJ-Innovation/Marlin/teams","hooks_url":"https://api.github.com/repos/SJ-Innovation/Marlin/hooks","issue_events_url":"https://api.github.com/repos/SJ-Innovation/Marlin/issues/events{/number}","events_url":"https://api.github.com/repos/SJ-Innovation/Marlin/events","assignees_url":"https://api.github.com/repos/SJ-Innovation/Marlin/assignees{/user}","branches_url":"https://api.github.com/repos/SJ-Innovation/Marlin/branches{/branch}","tags_url":"https://api.github.com/repos/SJ-Innovation/Marlin/tags","blobs_url":"https://api.github.com/repos/SJ-Innovation/Marlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SJ-Innovation/Marlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SJ-Innovation/Marlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/SJ-Innovation/Marlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SJ-Innovation/Marlin/statuses/{sha}","languages_url":"https://api.github.com/repos/SJ-Innovation/Marlin/languages","stargazers_url":"https://api.github.com/repos/SJ-Innovation/Marlin/stargazers","contributors_url":"https://api.github.com/repos/SJ-Innovation/Marlin/contributors","subscribers_url":"https://api.github.com/repos/SJ-Innovation/Marlin/subscribers","subscription_url":"https://api.github.com/repos/SJ-Innovation/Marlin/subscription","commits_url":"https://api.github.com/repos/SJ-Innovation/Marlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/SJ-Innovation/Marlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/SJ-Innovation/Marlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/SJ-Innovation/Marlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/SJ-Innovation/Marlin/contents/{+path}","compare_url":"https://api.github.com/repos/SJ-Innovation/Marlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SJ-Innovation/Marlin/merges","archive_url":"https://api.github.com/repos/SJ-Innovation/Marlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SJ-Innovation/Marlin/downloads","issues_url":"https://api.github.com/repos/SJ-Innovation/Marlin/issues{/number}","pulls_url":"https://api.github.com/repos/SJ-Innovation/Marlin/pulls{/number}","milestones_url":"https://api.github.com/repos/SJ-Innovation/Marlin/milestones{/number}","notifications_url":"https://api.github.com/repos/SJ-Innovation/Marlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SJ-Innovation/Marlin/labels{/name}","releases_url":"https://api.github.com/repos/SJ-Innovation/Marlin/releases{/id}","deployments_url":"https://api.github.com/repos/SJ-Innovation/Marlin/deployments","created_at":"2018-05-12T12:50:56Z","updated_at":"2018-09-11T21:31:03Z","pushed_at":"2018-09-11T21:31:01Z","git_url":"git://github.com/SJ-Innovation/Marlin.git","ssh_url":"git@github.com:SJ-Innovation/Marlin.git","clone_url":"https://github.com/SJ-Innovation/Marlin.git","svn_url":"https://github.com/SJ-Innovation/Marlin","homepage":"http://www.marlinfw.org/","size":79331,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"bf2-myPrinter-i3-ClosedLoop"}},"base":{"label":"MarlinFirmware:bugfix-2.0.x","ref":"bugfix-2.0.x","sha":"b220a825a769955f8df0a929f4a1d582e461fffa","user":{"login":"MarlinFirmware","id":10418365,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDE4MzY1","avatar_url":"https://avatars3.githubusercontent.com/u/10418365?v=4","gravatar_id":"","url":"https://api.github.com/users/MarlinFirmware","html_url":"https://github.com/MarlinFirmware","followers_url":"https://api.github.com/users/MarlinFirmware/followers","following_url":"https://api.github.com/users/MarlinFirmware/following{/other_user}","gists_url":"https://api.github.com/users/MarlinFirmware/gists{/gist_id}","starred_url":"https://api.github.com/users/MarlinFirmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarlinFirmware/subscriptions","organizations_url":"https://api.github.com/users/MarlinFirmware/orgs","repos_url":"https://api.github.com/users/MarlinFirmware/repos","events_url":"https://api.github.com/users/MarlinFirmware/events{/privacy}","received_events_url":"https://api.github.com/users/MarlinFirmware/received_events","type":"Organization","site_admin":false},"repo":{"id":2200856,"node_id":"MDEwOlJlcG9zaXRvcnkyMjAwODU2","name":"Marlin","full_name":"MarlinFirmware/Marlin","private":false,"owner":{"login":"MarlinFirmware","id":10418365,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDE4MzY1","avatar_url":"https://avatars3.githubusercontent.com/u/10418365?v=4","gravatar_id":"","url":"https://api.github.com/users/MarlinFirmware","html_url":"https://github.com/MarlinFirmware","followers_url":"https://api.github.com/users/MarlinFirmware/followers","following_url":"https://api.github.com/users/MarlinFirmware/following{/other_user}","gists_url":"https://api.github.com/users/MarlinFirmware/gists{/gist_id}","starred_url":"https://api.github.com/users/MarlinFirmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarlinFirmware/subscriptions","organizations_url":"https://api.github.com/users/MarlinFirmware/orgs","repos_url":"https://api.github.com/users/MarlinFirmware/repos","events_url":"https://api.github.com/users/MarlinFirmware/events{/privacy}","received_events_url":"https://api.github.com/users/MarlinFirmware/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MarlinFirmware/Marlin","description":"Optimized firmware for RepRap 3D printers based on the Arduino platform.","fork":false,"url":"https://api.github.com/repos/MarlinFirmware/Marlin","forks_url":"https://api.github.com/repos/MarlinFirmware/Marlin/forks","keys_url":"https://api.github.com/repos/MarlinFirmware/Marlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarlinFirmware/Marlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarlinFirmware/Marlin/teams","hooks_url":"https://api.github.com/repos/MarlinFirmware/Marlin/hooks","issue_events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/events{/number}","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/events","assignees_url":"https://api.github.com/repos/MarlinFirmware/Marlin/assignees{/user}","branches_url":"https://api.github.com/repos/MarlinFirmware/Marlin/branches{/branch}","tags_url":"https://api.github.com/repos/MarlinFirmware/Marlin/tags","blobs_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarlinFirmware/Marlin/statuses/{sha}","languages_url":"https://api.github.com/repos/MarlinFirmware/Marlin/languages","stargazers_url":"https://api.github.com/repos/MarlinFirmware/Marlin/stargazers","contributors_url":"https://api.github.com/repos/MarlinFirmware/Marlin/contributors","subscribers_url":"https://api.github.com/repos/MarlinFirmware/Marlin/subscribers","subscription_url":"https://api.github.com/repos/MarlinFirmware/Marlin/subscription","commits_url":"https://api.github.com/repos/MarlinFirmware/Marlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarlinFirmware/Marlin/contents/{+path}","compare_url":"https://api.github.com/repos/MarlinFirmware/Marlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarlinFirmware/Marlin/merges","archive_url":"https://api.github.com/repos/MarlinFirmware/Marlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarlinFirmware/Marlin/downloads","issues_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues{/number}","pulls_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls{/number}","milestones_url":"https://api.github.com/repos/MarlinFirmware/Marlin/milestones{/number}","notifications_url":"https://api.github.com/repos/MarlinFirmware/Marlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels{/name}","releases_url":"https://api.github.com/repos/MarlinFirmware/Marlin/releases{/id}","deployments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/deployments","created_at":"2011-08-13T08:07:20Z","updated_at":"2018-09-16T00:36:03Z","pushed_at":"2018-09-16T01:25:34Z","git_url":"git://github.com/MarlinFirmware/Marlin.git","ssh_url":"git@github.com:MarlinFirmware/Marlin.git","clone_url":"https://github.com/MarlinFirmware/Marlin.git","svn_url":"https://github.com/MarlinFirmware/Marlin","homepage":"http://www.marlinfw.org/","size":83865,"stargazers_count":4257,"watchers_count":4257,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5974,"mirror_url":null,"archived":false,"open_issues_count":837,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":5974,"open_issues":837,"watchers":4257,"default_branch":"1.1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/11802"},"html":{"href":"https://github.com/MarlinFirmware/Marlin/pull/11802"},"issue":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/11802"},"comments":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/11802/comments"},"review_comments":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/11802/comments"},"review_comment":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/11802/commits"},"statuses":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/statuses/72279db86527e9554fd176c315078c8f1e580adf"}},"author_association":"NONE"}}
{"actor":{"display_login":"thinkyhead"}}