{"action":"opened","number":294,"pull_request":{"url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/pulls/294","id":183375369,"html_url":"https://github.com/mozilla-lockbox/lockbox-ios/pull/294","diff_url":"https://github.com/mozilla-lockbox/lockbox-ios/pull/294.diff","patch_url":"https://github.com/mozilla-lockbox/lockbox-ios/pull/294.patch","issue_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/issues/294","number":294,"state":"open","locked":false,"title":"Add confirmation dialog on unlink button","user":{"login":"Descartess","id":3266719,"avatar_url":"https://avatars0.githubusercontent.com/u/3266719?v=4","gravatar_id":"","url":"https://api.github.com/users/Descartess","html_url":"https://github.com/Descartess","followers_url":"https://api.github.com/users/Descartess/followers","following_url":"https://api.github.com/users/Descartess/following{/other_user}","gists_url":"https://api.github.com/users/Descartess/gists{/gist_id}","starred_url":"https://api.github.com/users/Descartess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Descartess/subscriptions","organizations_url":"https://api.github.com/users/Descartess/orgs","repos_url":"https://api.github.com/users/Descartess/repos","events_url":"https://api.github.com/users/Descartess/events{/privacy}","received_events_url":"https://api.github.com/users/Descartess/received_events","type":"User","site_admin":false},"body":"#### What does this PR do ?\r\nThis adds a confirmation dialog box when a user taps the unlink account button. \r\n\r\n#### Background context \r\nRelated to #234 \r\n\r\n#### Blockers\r\nThis is indeed my first attempt on a project using RxSwift and MVP design pattern, There has been a lot of learning on my side 😄 .  I have been unable to bind the `unlinkAccountObserver` to a `UIAlertAction`. We can also discuss my proposed solution in general and ways we can make it better.\r\n\r\nHoping to learn plenty from this project\r\n","created_at":"2018-04-23T09:32:06Z","updated_at":"2018-04-23T09:32:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/pulls/294/commits","review_comments_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/pulls/294/comments","review_comment_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/issues/294/comments","statuses_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/statuses/fba40d50d696e1f1074bd858074f178229129322","head":{"label":"Descartess:ft-confirmation-dialog-for-unlinking-account","ref":"ft-confirmation-dialog-for-unlinking-account","sha":"fba40d50d696e1f1074bd858074f178229129322","user":{"login":"Descartess","id":3266719,"avatar_url":"https://avatars0.githubusercontent.com/u/3266719?v=4","gravatar_id":"","url":"https://api.github.com/users/Descartess","html_url":"https://github.com/Descartess","followers_url":"https://api.github.com/users/Descartess/followers","following_url":"https://api.github.com/users/Descartess/following{/other_user}","gists_url":"https://api.github.com/users/Descartess/gists{/gist_id}","starred_url":"https://api.github.com/users/Descartess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Descartess/subscriptions","organizations_url":"https://api.github.com/users/Descartess/orgs","repos_url":"https://api.github.com/users/Descartess/repos","events_url":"https://api.github.com/users/Descartess/events{/privacy}","received_events_url":"https://api.github.com/users/Descartess/received_events","type":"User","site_admin":false},"repo":{"id":129758456,"name":"lockbox-ios","full_name":"Descartess/lockbox-ios","owner":{"login":"Descartess","id":3266719,"avatar_url":"https://avatars0.githubusercontent.com/u/3266719?v=4","gravatar_id":"","url":"https://api.github.com/users/Descartess","html_url":"https://github.com/Descartess","followers_url":"https://api.github.com/users/Descartess/followers","following_url":"https://api.github.com/users/Descartess/following{/other_user}","gists_url":"https://api.github.com/users/Descartess/gists{/gist_id}","starred_url":"https://api.github.com/users/Descartess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Descartess/subscriptions","organizations_url":"https://api.github.com/users/Descartess/orgs","repos_url":"https://api.github.com/users/Descartess/repos","events_url":"https://api.github.com/users/Descartess/events{/privacy}","received_events_url":"https://api.github.com/users/Descartess/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Descartess/lockbox-ios","description":"Lockbox app for iOS","fork":true,"url":"https://api.github.com/repos/Descartess/lockbox-ios","forks_url":"https://api.github.com/repos/Descartess/lockbox-ios/forks","keys_url":"https://api.github.com/repos/Descartess/lockbox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Descartess/lockbox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Descartess/lockbox-ios/teams","hooks_url":"https://api.github.com/repos/Descartess/lockbox-ios/hooks","issue_events_url":"https://api.github.com/repos/Descartess/lockbox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/Descartess/lockbox-ios/events","assignees_url":"https://api.github.com/repos/Descartess/lockbox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/Descartess/lockbox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/Descartess/lockbox-ios/tags","blobs_url":"https://api.github.com/repos/Descartess/lockbox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Descartess/lockbox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Descartess/lockbox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/Descartess/lockbox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Descartess/lockbox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/Descartess/lockbox-ios/languages","stargazers_url":"https://api.github.com/repos/Descartess/lockbox-ios/stargazers","contributors_url":"https://api.github.com/repos/Descartess/lockbox-ios/contributors","subscribers_url":"https://api.github.com/repos/Descartess/lockbox-ios/subscribers","subscription_url":"https://api.github.com/repos/Descartess/lockbox-ios/subscription","commits_url":"https://api.github.com/repos/Descartess/lockbox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/Descartess/lockbox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/Descartess/lockbox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/Descartess/lockbox-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/Descartess/lockbox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/Descartess/lockbox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Descartess/lockbox-ios/merges","archive_url":"https://api.github.com/repos/Descartess/lockbox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Descartess/lockbox-ios/downloads","issues_url":"https://api.github.com/repos/Descartess/lockbox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/Descartess/lockbox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/Descartess/lockbox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/Descartess/lockbox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Descartess/lockbox-ios/labels{/name}","releases_url":"https://api.github.com/repos/Descartess/lockbox-ios/releases{/id}","deployments_url":"https://api.github.com/repos/Descartess/lockbox-ios/deployments","created_at":"2018-04-16T14:42:31Z","updated_at":"2018-04-16T14:42:34Z","pushed_at":"2018-04-23T09:21:42Z","git_url":"git://github.com/Descartess/lockbox-ios.git","ssh_url":"git@github.com:Descartess/lockbox-ios.git","clone_url":"https://github.com/Descartess/lockbox-ios.git","svn_url":"https://github.com/Descartess/lockbox-ios","homepage":"https://mozilla-lockbox.github.io/lockbox-ios/","size":48848,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-lockbox:master","ref":"master","sha":"5c5d0184647c5d22a7761c56376a1e7ad9cab517","user":{"login":"mozilla-lockbox","id":29802027,"avatar_url":"https://avatars0.githubusercontent.com/u/29802027?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-lockbox","html_url":"https://github.com/mozilla-lockbox","followers_url":"https://api.github.com/users/mozilla-lockbox/followers","following_url":"https://api.github.com/users/mozilla-lockbox/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-lockbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-lockbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-lockbox/subscriptions","organizations_url":"https://api.github.com/users/mozilla-lockbox/orgs","repos_url":"https://api.github.com/users/mozilla-lockbox/repos","events_url":"https://api.github.com/users/mozilla-lockbox/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-lockbox/received_events","type":"Organization","site_admin":false},"repo":{"id":107460673,"name":"lockbox-ios","full_name":"mozilla-lockbox/lockbox-ios","owner":{"login":"mozilla-lockbox","id":29802027,"avatar_url":"https://avatars0.githubusercontent.com/u/29802027?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-lockbox","html_url":"https://github.com/mozilla-lockbox","followers_url":"https://api.github.com/users/mozilla-lockbox/followers","following_url":"https://api.github.com/users/mozilla-lockbox/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-lockbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-lockbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-lockbox/subscriptions","organizations_url":"https://api.github.com/users/mozilla-lockbox/orgs","repos_url":"https://api.github.com/users/mozilla-lockbox/repos","events_url":"https://api.github.com/users/mozilla-lockbox/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-lockbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-lockbox/lockbox-ios","description":"Lockbox app for iOS","fork":false,"url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios","forks_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/forks","keys_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/teams","hooks_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/hooks","issue_events_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/events","assignees_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/tags","blobs_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/languages","stargazers_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/stargazers","contributors_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/contributors","subscribers_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/subscribers","subscription_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/subscription","commits_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/merges","archive_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/downloads","issues_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/deployments","created_at":"2017-10-18T20:42:07Z","updated_at":"2018-04-20T21:20:44Z","pushed_at":"2018-04-20T21:49:55Z","git_url":"git://github.com/mozilla-lockbox/lockbox-ios.git","ssh_url":"git@github.com:mozilla-lockbox/lockbox-ios.git","clone_url":"https://github.com/mozilla-lockbox/lockbox-ios.git","svn_url":"https://github.com/mozilla-lockbox/lockbox-ios","homepage":"https://mozilla-lockbox.github.io/lockbox-ios/","size":49044,"stargazers_count":24,"watchers_count":24,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":6,"open_issues":81,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/pulls/294"},"html":{"href":"https://github.com/mozilla-lockbox/lockbox-ios/pull/294"},"issue":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/issues/294"},"comments":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/issues/294/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/pulls/294/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/pulls/294/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-lockbox/lockbox-ios/statuses/fba40d50d696e1f1074bd858074f178229129322"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":31,"deletions":7,"changed_files":3}}
{"actor":{"display_login":"Descartess"}}