{"action":"created","issue":{"url":"https://api.github.com/repos/flutter/flutter/issues/21154","repository_url":"https://api.github.com/repos/flutter/flutter","labels_url":"https://api.github.com/repos/flutter/flutter/issues/21154/labels{/name}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/21154/comments","events_url":"https://api.github.com/repos/flutter/flutter/issues/21154/events","html_url":"https://github.com/flutter/flutter/issues/21154","id":355103835,"node_id":"MDU6SXNzdWUzNTUxMDM4MzU=","number":21154,"title":"flutter attach should support a detach command and default to detaching (not terminating the app) on SIGINT/SIGTERM","user":{"login":"DanTup","id":1078012,"node_id":"MDQ6VXNlcjEwNzgwMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1078012?v=4","gravatar_id":"","url":"https://api.github.com/users/DanTup","html_url":"https://github.com/DanTup","followers_url":"https://api.github.com/users/DanTup/followers","following_url":"https://api.github.com/users/DanTup/following{/other_user}","gists_url":"https://api.github.com/users/DanTup/gists{/gist_id}","starred_url":"https://api.github.com/users/DanTup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanTup/subscriptions","organizations_url":"https://api.github.com/users/DanTup/orgs","repos_url":"https://api.github.com/users/DanTup/repos","events_url":"https://api.github.com/users/DanTup/events{/privacy}","received_events_url":"https://api.github.com/users/DanTup/received_events","type":"User","site_admin":false},"labels":[{"id":283480100,"node_id":"MDU6TGFiZWwyODM0ODAxMDA=","url":"https://api.github.com/repos/flutter/flutter/labels/tool","name":"tool","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":{"login":"DanTup","id":1078012,"node_id":"MDQ6VXNlcjEwNzgwMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1078012?v=4","gravatar_id":"","url":"https://api.github.com/users/DanTup","html_url":"https://github.com/DanTup","followers_url":"https://api.github.com/users/DanTup/followers","following_url":"https://api.github.com/users/DanTup/following{/other_user}","gists_url":"https://api.github.com/users/DanTup/gists{/gist_id}","starred_url":"https://api.github.com/users/DanTup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanTup/subscriptions","organizations_url":"https://api.github.com/users/DanTup/orgs","repos_url":"https://api.github.com/users/DanTup/repos","events_url":"https://api.github.com/users/DanTup/events{/privacy}","received_events_url":"https://api.github.com/users/DanTup/received_events","type":"User","site_admin":false},"assignees":[{"login":"DanTup","id":1078012,"node_id":"MDQ6VXNlcjEwNzgwMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1078012?v=4","gravatar_id":"","url":"https://api.github.com/users/DanTup","html_url":"https://github.com/DanTup","followers_url":"https://api.github.com/users/DanTup/followers","following_url":"https://api.github.com/users/DanTup/following{/other_user}","gists_url":"https://api.github.com/users/DanTup/gists{/gist_id}","starred_url":"https://api.github.com/users/DanTup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanTup/subscriptions","organizations_url":"https://api.github.com/users/DanTup/orgs","repos_url":"https://api.github.com/users/DanTup/repos","events_url":"https://api.github.com/users/DanTup/events{/privacy}","received_events_url":"https://api.github.com/users/DanTup/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-08-29T10:49:42Z","updated_at":"2018-09-04T07:48:21Z","closed_at":null,"author_association":"MEMBER","body":"Currently when you run `flutter attach`, the only ways of exiting are pressing `q` to quit, or Ctrl+C to sent SIGINT. Both of these result in the Android app terminating. It seems like these should instead of \"detach\" (and that the description of what pressing `q` does should probably be reworded for the attach case).\r\n\r\n(@matthew-carroll I'm making some assumptions here, not sure who is best to confirm this is what we're aiming for?)\r\n\r\n(@devoncarew do we need to add a new `app.detach` command to the daemon, or should we just use `app.stop`? I don't think we'd ever need both together - I don't think it makes sense to terminate an app we only attached to, but the name `stop` seems slightly weird for detaching)."},"comment":{"url":"https://api.github.com/repos/flutter/flutter/issues/comments/418273569","html_url":"https://github.com/flutter/flutter/issues/21154#issuecomment-418273569","issue_url":"https://api.github.com/repos/flutter/flutter/issues/21154","id":418273569,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODI3MzU2OQ==","user":{"login":"DanTup","id":1078012,"node_id":"MDQ6VXNlcjEwNzgwMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1078012?v=4","gravatar_id":"","url":"https://api.github.com/users/DanTup","html_url":"https://github.com/DanTup","followers_url":"https://api.github.com/users/DanTup/followers","following_url":"https://api.github.com/users/DanTup/following{/other_user}","gists_url":"https://api.github.com/users/DanTup/gists{/gist_id}","starred_url":"https://api.github.com/users/DanTup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanTup/subscriptions","organizations_url":"https://api.github.com/users/DanTup/orgs","repos_url":"https://api.github.com/users/DanTup/repos","events_url":"https://api.github.com/users/DanTup/events{/privacy}","received_events_url":"https://api.github.com/users/DanTup/received_events","type":"User","site_admin":false},"created_at":"2018-09-04T07:48:21Z","updated_at":"2018-09-04T07:48:21Z","author_association":"MEMBER","body":"(though now I'm thinking the same thing applies to the `app.start` event.. if we think we should use different events for stop/detach then maybe start/attach should be different, so I think probably leaving the stop might make most sense?)"}}
{"actor":{"display_login":"DanTup"}}