{"action":"created","comment":{"url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/pulls/comments/220891388","pull_request_review_id":159404656,"id":220891388,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDg5MTM4OA==","diff_hunk":"@@ -15,6 +15,12 @@\n     log.addHandler(logging.StreamHandler())\n \n \n+TEST_ROOT_URL = 'https://tc-tests.localhost'","path":"test/base/__init__.py","position":4,"original_position":4,"commit_id":"c57ce3d1bbaa738e9f205056e5d177232b2b12d8","original_commit_id":"c57ce3d1bbaa738e9f205056e5d177232b2b12d8","user":{"login":"jhford","id":607353,"node_id":"MDQ6VXNlcjYwNzM1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/607353?v=4","gravatar_id":"","url":"https://api.github.com/users/jhford","html_url":"https://github.com/jhford","followers_url":"https://api.github.com/users/jhford/followers","following_url":"https://api.github.com/users/jhford/following{/other_user}","gists_url":"https://api.github.com/users/jhford/gists{/gist_id}","starred_url":"https://api.github.com/users/jhford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhford/subscriptions","organizations_url":"https://api.github.com/users/jhford/orgs","repos_url":"https://api.github.com/users/jhford/repos","events_url":"https://api.github.com/users/jhford/events{/privacy}","received_events_url":"https://api.github.com/users/jhford/received_events","type":"User","site_admin":false},"body":"we probably should consider changing it there as well, since it has different behaviour based on the OS that the tests run on.","created_at":"2018-09-27T11:45:39Z","updated_at":"2018-09-27T11:45:39Z","html_url":"https://github.com/taskcluster/taskcluster-client.py/pull/114#discussion_r220891388","pull_request_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/pulls/114","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/taskcluster/taskcluster-client.py/pulls/comments/220891388"},"html":{"href":"https://github.com/taskcluster/taskcluster-client.py/pull/114#discussion_r220891388"},"pull_request":{"href":"https://api.github.com/repos/taskcluster/taskcluster-client.py/pulls/114"}},"in_reply_to_id":220648062},"pull_request":{"url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/pulls/114","id":217406544,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDA2NTQ0","html_url":"https://github.com/taskcluster/taskcluster-client.py/pull/114","diff_url":"https://github.com/taskcluster/taskcluster-client.py/pull/114.diff","patch_url":"https://github.com/taskcluster/taskcluster-client.py/pull/114.patch","issue_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/issues/114","number":114,"state":"open","locked":false,"title":"Remove use of baseUrl","user":{"login":"djmitche","id":28673,"node_id":"MDQ6VXNlcjI4Njcz","avatar_url":"https://avatars3.githubusercontent.com/u/28673?v=4","gravatar_id":"","url":"https://api.github.com/users/djmitche","html_url":"https://github.com/djmitche","followers_url":"https://api.github.com/users/djmitche/followers","following_url":"https://api.github.com/users/djmitche/following{/other_user}","gists_url":"https://api.github.com/users/djmitche/gists{/gist_id}","starred_url":"https://api.github.com/users/djmitche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djmitche/subscriptions","organizations_url":"https://api.github.com/users/djmitche/orgs","repos_url":"https://api.github.com/users/djmitche/repos","events_url":"https://api.github.com/users/djmitche/events{/privacy}","received_events_url":"https://api.github.com/users/djmitche/received_events","type":"User","site_admin":false},"body":"This removes the concept of a baseUrl, requiring a rootUrl instead.  The\r\nserviceName and apiVersion are intuited from the references if not\r\nsupplied directly, using logic based on that in the JS\r\ntaskcluster-client.\r\n\r\nThis is a breaking change, so warrants a major version bump.\r\n\r\nThere was some discussion of retaining the ability to use baseUrls for purposes of injecting services into other clusters (@petemoore's example with purge-caches).  I think we can still support this, but let's not call it baseUrl.  I want to make a clean break with baseUrls, and raising exceptions when they are provided is a robust way to do that.  Also, I think the names \"baseUrl\" and \"rootUrl\" are too easy to confuse. \r\n\r\nSo, let's call it something more specific to the purpose, like `overrideServiceUrlPrefix`, and implement it across the board in all of the clients (once the rootUrl work and new client generation support is done).","created_at":"2018-09-21T21:30:21Z","updated_at":"2018-09-27T11:45:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69c0804d3fce4dbbf280abf3a2e4ca78047ee1cf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/pulls/114/commits","review_comments_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/pulls/114/comments","review_comment_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/pulls/comments{/number}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/issues/114/comments","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/statuses/c57ce3d1bbaa738e9f205056e5d177232b2b12d8","head":{"label":"djmitche:remove-baseUrl","ref":"remove-baseUrl","sha":"c57ce3d1bbaa738e9f205056e5d177232b2b12d8","user":{"login":"djmitche","id":28673,"node_id":"MDQ6VXNlcjI4Njcz","avatar_url":"https://avatars3.githubusercontent.com/u/28673?v=4","gravatar_id":"","url":"https://api.github.com/users/djmitche","html_url":"https://github.com/djmitche","followers_url":"https://api.github.com/users/djmitche/followers","following_url":"https://api.github.com/users/djmitche/following{/other_user}","gists_url":"https://api.github.com/users/djmitche/gists{/gist_id}","starred_url":"https://api.github.com/users/djmitche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djmitche/subscriptions","organizations_url":"https://api.github.com/users/djmitche/orgs","repos_url":"https://api.github.com/users/djmitche/repos","events_url":"https://api.github.com/users/djmitche/events{/privacy}","received_events_url":"https://api.github.com/users/djmitche/received_events","type":"User","site_admin":false},"repo":{"id":45406654,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQwNjY1NA==","name":"taskcluster-client.py","full_name":"djmitche/taskcluster-client.py","private":false,"owner":{"login":"djmitche","id":28673,"node_id":"MDQ6VXNlcjI4Njcz","avatar_url":"https://avatars3.githubusercontent.com/u/28673?v=4","gravatar_id":"","url":"https://api.github.com/users/djmitche","html_url":"https://github.com/djmitche","followers_url":"https://api.github.com/users/djmitche/followers","following_url":"https://api.github.com/users/djmitche/following{/other_user}","gists_url":"https://api.github.com/users/djmitche/gists{/gist_id}","starred_url":"https://api.github.com/users/djmitche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djmitche/subscriptions","organizations_url":"https://api.github.com/users/djmitche/orgs","repos_url":"https://api.github.com/users/djmitche/repos","events_url":"https://api.github.com/users/djmitche/events{/privacy}","received_events_url":"https://api.github.com/users/djmitche/received_events","type":"User","site_admin":false},"html_url":"https://github.com/djmitche/taskcluster-client.py","description":"A python implementation of the Taskcluster Client Library","fork":true,"url":"https://api.github.com/repos/djmitche/taskcluster-client.py","forks_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/forks","keys_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/teams","hooks_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/hooks","issue_events_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/issues/events{/number}","events_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/events","assignees_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/assignees{/user}","branches_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/branches{/branch}","tags_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/tags","blobs_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/git/refs{/sha}","trees_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/statuses/{sha}","languages_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/languages","stargazers_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/stargazers","contributors_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/contributors","subscribers_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/subscribers","subscription_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/subscription","commits_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/commits{/sha}","git_commits_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/git/commits{/sha}","comments_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/comments{/number}","issue_comment_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/issues/comments{/number}","contents_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/contents/{+path}","compare_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/merges","archive_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/downloads","issues_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/issues{/number}","pulls_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/pulls{/number}","milestones_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/milestones{/number}","notifications_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/labels{/name}","releases_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/releases{/id}","deployments_url":"https://api.github.com/repos/djmitche/taskcluster-client.py/deployments","created_at":"2015-11-02T16:27:27Z","updated_at":"2015-11-02T16:27:28Z","pushed_at":"2018-09-21T21:27:00Z","git_url":"git://github.com/djmitche/taskcluster-client.py.git","ssh_url":"git@github.com:djmitche/taskcluster-client.py.git","clone_url":"https://github.com/djmitche/taskcluster-client.py.git","svn_url":"https://github.com/djmitche/taskcluster-client.py","homepage":"https://pypi.python.org/pypi/taskcluster","size":1511,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"taskcluster:master","ref":"master","sha":"86d76044d86f5bf648e2420eef78336ac392fce1","user":{"login":"taskcluster","id":6257436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTc0MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/6257436?v=4","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"repo":{"id":24991592,"node_id":"MDEwOlJlcG9zaXRvcnkyNDk5MTU5Mg==","name":"taskcluster-client.py","full_name":"taskcluster/taskcluster-client.py","private":false,"owner":{"login":"taskcluster","id":6257436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTc0MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/6257436?v=4","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/taskcluster/taskcluster-client.py","description":"A python implementation of the Taskcluster Client Library","fork":false,"url":"https://api.github.com/repos/taskcluster/taskcluster-client.py","forks_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/forks","keys_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/teams","hooks_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/hooks","issue_events_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/issues/events{/number}","events_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/events","assignees_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/assignees{/user}","branches_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/branches{/branch}","tags_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/tags","blobs_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/git/refs{/sha}","trees_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/statuses/{sha}","languages_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/languages","stargazers_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/stargazers","contributors_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/contributors","subscribers_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/subscribers","subscription_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/subscription","commits_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/commits{/sha}","git_commits_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/git/commits{/sha}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/comments{/number}","issue_comment_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/issues/comments{/number}","contents_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/contents/{+path}","compare_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/merges","archive_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/downloads","issues_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/issues{/number}","pulls_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/pulls{/number}","milestones_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/milestones{/number}","notifications_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/labels{/name}","releases_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/releases{/id}","deployments_url":"https://api.github.com/repos/taskcluster/taskcluster-client.py/deployments","created_at":"2014-10-09T13:58:54Z","updated_at":"2018-09-17T07:52:37Z","pushed_at":"2018-09-21T21:30:22Z","git_url":"git://github.com/taskcluster/taskcluster-client.py.git","ssh_url":"git@github.com:taskcluster/taskcluster-client.py.git","clone_url":"https://github.com/taskcluster/taskcluster-client.py.git","svn_url":"https://github.com/taskcluster/taskcluster-client.py","homepage":"https://pypi.python.org/pypi/taskcluster","size":1554,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":28,"open_issues":8,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/taskcluster/taskcluster-client.py/pulls/114"},"html":{"href":"https://github.com/taskcluster/taskcluster-client.py/pull/114"},"issue":{"href":"https://api.github.com/repos/taskcluster/taskcluster-client.py/issues/114"},"comments":{"href":"https://api.github.com/repos/taskcluster/taskcluster-client.py/issues/114/comments"},"review_comments":{"href":"https://api.github.com/repos/taskcluster/taskcluster-client.py/pulls/114/comments"},"review_comment":{"href":"https://api.github.com/repos/taskcluster/taskcluster-client.py/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/taskcluster/taskcluster-client.py/pulls/114/commits"},"statuses":{"href":"https://api.github.com/repos/taskcluster/taskcluster-client.py/statuses/c57ce3d1bbaa738e9f205056e5d177232b2b12d8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jhford"}}