{"action":"created","issue":{"url":"https://api.github.com/repos/coq/coq/issues/8185","repository_url":"https://api.github.com/repos/coq/coq","labels_url":"https://api.github.com/repos/coq/coq/issues/8185/labels{/name}","comments_url":"https://api.github.com/repos/coq/coq/issues/8185/comments","events_url":"https://api.github.com/repos/coq/coq/issues/8185/events","html_url":"https://github.com/coq/coq/pull/8185","id":345720992,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0Nzc2MTYw","number":8185,"title":"Improved grammar and spelling in the remaining chapters of the Reference Manual.","user":{"login":"Zeimer","id":3518202,"node_id":"MDQ6VXNlcjM1MTgyMDI=","avatar_url":"https://avatars1.githubusercontent.com/u/3518202?v=4","gravatar_id":"","url":"https://api.github.com/users/Zeimer","html_url":"https://github.com/Zeimer","followers_url":"https://api.github.com/users/Zeimer/followers","following_url":"https://api.github.com/users/Zeimer/following{/other_user}","gists_url":"https://api.github.com/users/Zeimer/gists{/gist_id}","starred_url":"https://api.github.com/users/Zeimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zeimer/subscriptions","organizations_url":"https://api.github.com/users/Zeimer/orgs","repos_url":"https://api.github.com/users/Zeimer/repos","events_url":"https://api.github.com/users/Zeimer/events{/privacy}","received_events_url":"https://api.github.com/users/Zeimer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-30T11:37:50Z","updated_at":"2018-07-30T16:11:01Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/coq/coq/pulls/8185","html_url":"https://github.com/coq/coq/pull/8185","diff_url":"https://github.com/coq/coq/pull/8185.diff","patch_url":"https://github.com/coq/coq/pull/8185.patch"},"body":"**Kind:** documentation\r\n\r\nMostly grammar and spelling plus some formatting (I changed the very inconsistent use of \":\" in the chapter Generalized Rewriting).\r\n\r\nThere are a few issues:\r\n\r\n1. In the chapter Nsatz, the syntax entry \"nsatz with radicalmax:=num%N strategy:=num%Z parameters:= var* variables:= var*\" looks very bad, not to mention that it is badly explained (no examples).\r\n\r\n2. In the chapter Generalized rewriting, example 9 is not totally clear. For me it does not generate any subgoal. It would be nice it this example was written down explicitly. Try this code:\r\n\r\n```coq\r\nRequire Import Setoid.\r\n\r\nDefinition eq0 (x y : nat) : Prop := x = y /\\ x <> 0.\r\n\r\n(* For [div]. *)\r\nRequire Import Nat.\r\n\r\nAdd Morphism div\r\nwith signature (eq ==> eq0 ==> eq) as div_mor.\r\nProof.\r\n  intros y x. generalize dependent y.\r\n  induction x as [| x']; destruct y0; inversion 1; auto.\r\nQed.\r\n\r\nGoal forall x y n : nat, x = y -> div x n = div y n.\r\nProof.\r\n  intros. rewrite H. auto.\r\nQed.\r\n```\r\nNot to mention that the examples are not using the directive \".. example\". By the way, is it possible to add a title when using this directive?\r\n\r\n3. In the chapter Generalized Rewriting, covariance and contravariance are explained badly. There are some confusing statements, like \"the second occurrence of x occurs covariantly in (x / x)\" (and the confusion is that the (x / x) being referred to is not a standalone expression, but a subexpression of something else)."},"comment":{"url":"https://api.github.com/repos/coq/coq/issues/comments/408919629","html_url":"https://github.com/coq/coq/pull/8185#issuecomment-408919629","issue_url":"https://api.github.com/repos/coq/coq/issues/8185","id":408919629,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODkxOTYyOQ==","user":{"login":"Zimmi48","id":1108325,"node_id":"MDQ6VXNlcjExMDgzMjU=","avatar_url":"https://avatars2.githubusercontent.com/u/1108325?v=4","gravatar_id":"","url":"https://api.github.com/users/Zimmi48","html_url":"https://github.com/Zimmi48","followers_url":"https://api.github.com/users/Zimmi48/followers","following_url":"https://api.github.com/users/Zimmi48/following{/other_user}","gists_url":"https://api.github.com/users/Zimmi48/gists{/gist_id}","starred_url":"https://api.github.com/users/Zimmi48/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zimmi48/subscriptions","organizations_url":"https://api.github.com/users/Zimmi48/orgs","repos_url":"https://api.github.com/users/Zimmi48/repos","events_url":"https://api.github.com/users/Zimmi48/events{/privacy}","received_events_url":"https://api.github.com/users/Zimmi48/received_events","type":"User","site_admin":false},"created_at":"2018-07-30T16:11:01Z","updated_at":"2018-07-30T16:11:01Z","author_association":"MEMBER","body":">Not to mention that the examples are not using the directive \".. example\". By the way, is it possible to add a title when using this directive?\r\n\r\nI don't think so but let's ask @cpitclaudel."}}
{"actor":{"display_login":"Zimmi48"}}