{"action":"created","comment":{"url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments/202059366","pull_request_review_id":136677904,"id":202059366,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjA1OTM2Ng==","diff_hunk":"@@ -0,0 +1,12 @@\n+namespace Playground\n+{\n+    public delegate float CalculateLoadDelegate(float fps);\n+\n+    public static class MetricConfig","path":"workers/unity/Assets/Playground/Config/MetricConfig.cs","position":5,"original_position":5,"commit_id":"f20a212a6b393d08c1b9151d85785861f62282c1","original_commit_id":"f20a212a6b393d08c1b9151d85785861f62282c1","user":{"login":"jared-improbable","id":7712411,"node_id":"MDQ6VXNlcjc3MTI0MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7712411?v=4","gravatar_id":"","url":"https://api.github.com/users/jared-improbable","html_url":"https://github.com/jared-improbable","followers_url":"https://api.github.com/users/jared-improbable/followers","following_url":"https://api.github.com/users/jared-improbable/following{/other_user}","gists_url":"https://api.github.com/users/jared-improbable/gists{/gist_id}","starred_url":"https://api.github.com/users/jared-improbable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jared-improbable/subscriptions","organizations_url":"https://api.github.com/users/jared-improbable/orgs","repos_url":"https://api.github.com/users/jared-improbable/repos","events_url":"https://api.github.com/users/jared-improbable/events{/privacy}","received_events_url":"https://api.github.com/users/jared-improbable/received_events","type":"User","site_admin":false},"body":"I'd rather we chose a different approach than global statics, if we can help it.\r\nMore fundamental than that, however - why are we including this at all? Why isn't the default calculation built into the system enough? Where's the use case?","created_at":"2018-07-12T14:38:13Z","updated_at":"2018-07-12T14:38:23Z","html_url":"https://github.com/spatialos/UnityGDK/pull/83#discussion_r202059366","pull_request_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/83","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments/202059366"},"html":{"href":"https://github.com/spatialos/UnityGDK/pull/83#discussion_r202059366"},"pull_request":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/83","id":200646172,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNjQ2MTcy","html_url":"https://github.com/spatialos/UnityGDK/pull/83","diff_url":"https://github.com/spatialos/UnityGDK/pull/83.diff","patch_url":"https://github.com/spatialos/UnityGDK/pull/83.patch","issue_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/83","number":83,"state":"open","locked":false,"title":"UTY-415: Exporting load metrics from Unity GDK.","user":{"login":"Ivaskovic","id":40765938,"node_id":"MDQ6VXNlcjQwNzY1OTM4","avatar_url":"https://avatars0.githubusercontent.com/u/40765938?v=4","gravatar_id":"","url":"https://api.github.com/users/Ivaskovic","html_url":"https://github.com/Ivaskovic","followers_url":"https://api.github.com/users/Ivaskovic/followers","following_url":"https://api.github.com/users/Ivaskovic/following{/other_user}","gists_url":"https://api.github.com/users/Ivaskovic/gists{/gist_id}","starred_url":"https://api.github.com/users/Ivaskovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ivaskovic/subscriptions","organizations_url":"https://api.github.com/users/Ivaskovic/orgs","repos_url":"https://api.github.com/users/Ivaskovic/repos","events_url":"https://api.github.com/users/Ivaskovic/events{/privacy}","received_events_url":"https://api.github.com/users/Ivaskovic/received_events","type":"User","site_admin":false},"body":"**Contributions**: We are not currently taking public contributions - see our [contributions](CONTRIBUTING.md) policy. However, we are accepting issues and we do want your [feedback](../README.md#give-us-feedback).\r\n\r\n-------\r\n\r\n#### Description\r\nUnityGDK now periodically exports metrics that may be viewed in the inspector. In particular, this means that Load can also be exported, and it is computed as a function of fps.","created_at":"2018-07-11T09:55:50Z","updated_at":"2018-07-12T14:38:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74cd0074ec6920c018b762d1da647b478224cd42","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mattyoung-improbable","id":38857629,"node_id":"MDQ6VXNlcjM4ODU3NjI5","avatar_url":"https://avatars3.githubusercontent.com/u/38857629?v=4","gravatar_id":"","url":"https://api.github.com/users/mattyoung-improbable","html_url":"https://github.com/mattyoung-improbable","followers_url":"https://api.github.com/users/mattyoung-improbable/followers","following_url":"https://api.github.com/users/mattyoung-improbable/following{/other_user}","gists_url":"https://api.github.com/users/mattyoung-improbable/gists{/gist_id}","starred_url":"https://api.github.com/users/mattyoung-improbable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattyoung-improbable/subscriptions","organizations_url":"https://api.github.com/users/mattyoung-improbable/orgs","repos_url":"https://api.github.com/users/mattyoung-improbable/repos","events_url":"https://api.github.com/users/mattyoung-improbable/events{/privacy}","received_events_url":"https://api.github.com/users/mattyoung-improbable/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/83/commits","review_comments_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/83/comments","review_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/83/comments","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/f20a212a6b393d08c1b9151d85785861f62282c1","head":{"label":"spatialos:feature/UTY-415-export-metrics-load","ref":"feature/UTY-415-export-metrics-load","sha":"f20a212a6b393d08c1b9151d85785861f62282c1","user":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"repo":{"id":137235993,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMzU5OTM=","name":"UnityGDK","full_name":"spatialos/UnityGDK","owner":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spatialos/UnityGDK","description":"Unity GDK","fork":false,"url":"https://api.github.com/repos/spatialos/UnityGDK","forks_url":"https://api.github.com/repos/spatialos/UnityGDK/forks","keys_url":"https://api.github.com/repos/spatialos/UnityGDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatialos/UnityGDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatialos/UnityGDK/teams","hooks_url":"https://api.github.com/repos/spatialos/UnityGDK/hooks","issue_events_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/events{/number}","events_url":"https://api.github.com/repos/spatialos/UnityGDK/events","assignees_url":"https://api.github.com/repos/spatialos/UnityGDK/assignees{/user}","branches_url":"https://api.github.com/repos/spatialos/UnityGDK/branches{/branch}","tags_url":"https://api.github.com/repos/spatialos/UnityGDK/tags","blobs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatialos/UnityGDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatialos/UnityGDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/{sha}","languages_url":"https://api.github.com/repos/spatialos/UnityGDK/languages","stargazers_url":"https://api.github.com/repos/spatialos/UnityGDK/stargazers","contributors_url":"https://api.github.com/repos/spatialos/UnityGDK/contributors","subscribers_url":"https://api.github.com/repos/spatialos/UnityGDK/subscribers","subscription_url":"https://api.github.com/repos/spatialos/UnityGDK/subscription","commits_url":"https://api.github.com/repos/spatialos/UnityGDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatialos/UnityGDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatialos/UnityGDK/contents/{+path}","compare_url":"https://api.github.com/repos/spatialos/UnityGDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatialos/UnityGDK/merges","archive_url":"https://api.github.com/repos/spatialos/UnityGDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatialos/UnityGDK/downloads","issues_url":"https://api.github.com/repos/spatialos/UnityGDK/issues{/number}","pulls_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls{/number}","milestones_url":"https://api.github.com/repos/spatialos/UnityGDK/milestones{/number}","notifications_url":"https://api.github.com/repos/spatialos/UnityGDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatialos/UnityGDK/labels{/name}","releases_url":"https://api.github.com/repos/spatialos/UnityGDK/releases{/id}","deployments_url":"https://api.github.com/repos/spatialos/UnityGDK/deployments","created_at":"2018-06-13T15:37:54Z","updated_at":"2018-07-12T14:05:28Z","pushed_at":"2018-07-12T14:27:37Z","git_url":"git://github.com/spatialos/UnityGDK.git","ssh_url":"git@github.com:spatialos/UnityGDK.git","clone_url":"https://github.com/spatialos/UnityGDK.git","svn_url":"https://github.com/spatialos/UnityGDK","homepage":null,"size":65142,"stargazers_count":57,"watchers_count":57,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":15,"watchers":57,"default_branch":"master"}},"base":{"label":"spatialos:master","ref":"master","sha":"7312a33dc3858062fa159a0c4e6597f831036eb6","user":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"repo":{"id":137235993,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMzU5OTM=","name":"UnityGDK","full_name":"spatialos/UnityGDK","owner":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spatialos/UnityGDK","description":"Unity GDK","fork":false,"url":"https://api.github.com/repos/spatialos/UnityGDK","forks_url":"https://api.github.com/repos/spatialos/UnityGDK/forks","keys_url":"https://api.github.com/repos/spatialos/UnityGDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatialos/UnityGDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatialos/UnityGDK/teams","hooks_url":"https://api.github.com/repos/spatialos/UnityGDK/hooks","issue_events_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/events{/number}","events_url":"https://api.github.com/repos/spatialos/UnityGDK/events","assignees_url":"https://api.github.com/repos/spatialos/UnityGDK/assignees{/user}","branches_url":"https://api.github.com/repos/spatialos/UnityGDK/branches{/branch}","tags_url":"https://api.github.com/repos/spatialos/UnityGDK/tags","blobs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatialos/UnityGDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatialos/UnityGDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/{sha}","languages_url":"https://api.github.com/repos/spatialos/UnityGDK/languages","stargazers_url":"https://api.github.com/repos/spatialos/UnityGDK/stargazers","contributors_url":"https://api.github.com/repos/spatialos/UnityGDK/contributors","subscribers_url":"https://api.github.com/repos/spatialos/UnityGDK/subscribers","subscription_url":"https://api.github.com/repos/spatialos/UnityGDK/subscription","commits_url":"https://api.github.com/repos/spatialos/UnityGDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatialos/UnityGDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatialos/UnityGDK/contents/{+path}","compare_url":"https://api.github.com/repos/spatialos/UnityGDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatialos/UnityGDK/merges","archive_url":"https://api.github.com/repos/spatialos/UnityGDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatialos/UnityGDK/downloads","issues_url":"https://api.github.com/repos/spatialos/UnityGDK/issues{/number}","pulls_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls{/number}","milestones_url":"https://api.github.com/repos/spatialos/UnityGDK/milestones{/number}","notifications_url":"https://api.github.com/repos/spatialos/UnityGDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatialos/UnityGDK/labels{/name}","releases_url":"https://api.github.com/repos/spatialos/UnityGDK/releases{/id}","deployments_url":"https://api.github.com/repos/spatialos/UnityGDK/deployments","created_at":"2018-06-13T15:37:54Z","updated_at":"2018-07-12T14:05:28Z","pushed_at":"2018-07-12T14:27:37Z","git_url":"git://github.com/spatialos/UnityGDK.git","ssh_url":"git@github.com:spatialos/UnityGDK.git","clone_url":"https://github.com/spatialos/UnityGDK.git","svn_url":"https://github.com/spatialos/UnityGDK","homepage":null,"size":65142,"stargazers_count":57,"watchers_count":57,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":15,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/83"},"html":{"href":"https://github.com/spatialos/UnityGDK/pull/83"},"issue":{"href":"https://api.github.com/repos/spatialos/UnityGDK/issues/83"},"comments":{"href":"https://api.github.com/repos/spatialos/UnityGDK/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/spatialos/UnityGDK/statuses/f20a212a6b393d08c1b9151d85785861f62282c1"}},"author_association":"NONE"}}
{"actor":{"display_login":"jared-improbable"}}