{"action":"created","issue":{"url":"https://api.github.com/repos/pcdshub/pcdsdaq/issues/28","repository_url":"https://api.github.com/repos/pcdshub/pcdsdaq","labels_url":"https://api.github.com/repos/pcdshub/pcdsdaq/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/pcdshub/pcdsdaq/issues/28/comments","events_url":"https://api.github.com/repos/pcdshub/pcdsdaq/issues/28/events","html_url":"https://github.com/pcdshub/pcdsdaq/pull/28","id":330094540,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTg3NzAy","number":28,"title":"ENH: ScanVars","user":{"login":"ZLLentz","id":10647860,"node_id":"MDQ6VXNlcjEwNjQ3ODYw","avatar_url":"https://avatars3.githubusercontent.com/u/10647860?v=4","gravatar_id":"","url":"https://api.github.com/users/ZLLentz","html_url":"https://github.com/ZLLentz","followers_url":"https://api.github.com/users/ZLLentz/followers","following_url":"https://api.github.com/users/ZLLentz/following{/other_user}","gists_url":"https://api.github.com/users/ZLLentz/gists{/gist_id}","starred_url":"https://api.github.com/users/ZLLentz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZLLentz/subscriptions","organizations_url":"https://api.github.com/users/ZLLentz/orgs","repos_url":"https://api.github.com/users/ZLLentz/repos","events_url":"https://api.github.com/users/ZLLentz/events{/privacy}","received_events_url":"https://api.github.com/users/ZLLentz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ZLLentz","id":10647860,"node_id":"MDQ6VXNlcjEwNjQ3ODYw","avatar_url":"https://avatars3.githubusercontent.com/u/10647860?v=4","gravatar_id":"","url":"https://api.github.com/users/ZLLentz","html_url":"https://github.com/ZLLentz","followers_url":"https://api.github.com/users/ZLLentz/followers","following_url":"https://api.github.com/users/ZLLentz/following{/other_user}","gists_url":"https://api.github.com/users/ZLLentz/gists{/gist_id}","starred_url":"https://api.github.com/users/ZLLentz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZLLentz/subscriptions","organizations_url":"https://api.github.com/users/ZLLentz/orgs","repos_url":"https://api.github.com/users/ZLLentz/repos","events_url":"https://api.github.com/users/ZLLentz/events{/privacy}","received_events_url":"https://api.github.com/users/ZLLentz/received_events","type":"User","site_admin":false},"assignees":[{"login":"ZLLentz","id":10647860,"node_id":"MDQ6VXNlcjEwNjQ3ODYw","avatar_url":"https://avatars3.githubusercontent.com/u/10647860?v=4","gravatar_id":"","url":"https://api.github.com/users/ZLLentz","html_url":"https://github.com/ZLLentz","followers_url":"https://api.github.com/users/ZLLentz/followers","following_url":"https://api.github.com/users/ZLLentz/following{/other_user}","gists_url":"https://api.github.com/users/ZLLentz/gists{/gist_id}","starred_url":"https://api.github.com/users/ZLLentz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZLLentz/subscriptions","organizations_url":"https://api.github.com/users/ZLLentz/orgs","repos_url":"https://api.github.com/users/ZLLentz/repos","events_url":"https://api.github.com/users/ZLLentz/events{/privacy}","received_events_url":"https://api.github.com/users/ZLLentz/received_events","type":"User","site_admin":false},{"login":"teddyrendahl","id":25753048,"node_id":"MDQ6VXNlcjI1NzUzMDQ4","avatar_url":"https://avatars3.githubusercontent.com/u/25753048?v=4","gravatar_id":"","url":"https://api.github.com/users/teddyrendahl","html_url":"https://github.com/teddyrendahl","followers_url":"https://api.github.com/users/teddyrendahl/followers","following_url":"https://api.github.com/users/teddyrendahl/following{/other_user}","gists_url":"https://api.github.com/users/teddyrendahl/gists{/gist_id}","starred_url":"https://api.github.com/users/teddyrendahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teddyrendahl/subscriptions","organizations_url":"https://api.github.com/users/teddyrendahl/orgs","repos_url":"https://api.github.com/users/teddyrendahl/repos","events_url":"https://api.github.com/users/teddyrendahl/events{/privacy}","received_events_url":"https://api.github.com/users/teddyrendahl/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-06-07T02:27:26Z","updated_at":"2018-06-25T21:31:42Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pcdshub/pcdsdaq/pulls/28","html_url":"https://github.com/pcdshub/pcdsdaq/pull/28","diff_url":"https://github.com/pcdshub/pcdsdaq/pull/28.diff","patch_url":"https://github.com/pcdshub/pcdsdaq/pull/28.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nAdd a `ScanVars` class that can be subscribed to by the `RunEngine` to update the scan table PVs. This pulls data from multiple sources as needed, but mostly from the `run_start` document, and from `event` documents to update the step count.\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\nhttps://github.com/pcdshub/hutch-python/issues/90\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nAdded a test. This will need additional field testing in XPP. I also need to consult with others on the indexing: the old python indexed the scan step starting at zero, but `bluesky` has this hard-coded to 1. We will either adopt the `bluesky` convention or we will let the scan pvs and the bluesky seq_num be different... Or we will PR `bluesky` for zero index option. But hopefully nobody really cares enough about this.\r\n\r\n## Where Has This Been Documented?\r\n<!--  Include where the changes made have been documented. -->\r\n<!--  This can simply be  a comment in the code or updating a docstring -->\r\nI forgot, I will add this before the merge.\r\n\r\n<!--\r\n## Screenshots (if appropriate):\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/pcdshub/pcdsdaq/issues/comments/400102536","html_url":"https://github.com/pcdshub/pcdsdaq/pull/28#issuecomment-400102536","issue_url":"https://api.github.com/repos/pcdshub/pcdsdaq/issues/28","id":400102536,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDEwMjUzNg==","user":{"login":"ZLLentz","id":10647860,"node_id":"MDQ6VXNlcjEwNjQ3ODYw","avatar_url":"https://avatars3.githubusercontent.com/u/10647860?v=4","gravatar_id":"","url":"https://api.github.com/users/ZLLentz","html_url":"https://github.com/ZLLentz","followers_url":"https://api.github.com/users/ZLLentz/followers","following_url":"https://api.github.com/users/ZLLentz/following{/other_user}","gists_url":"https://api.github.com/users/ZLLentz/gists{/gist_id}","starred_url":"https://api.github.com/users/ZLLentz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZLLentz/subscriptions","organizations_url":"https://api.github.com/users/ZLLentz/orgs","repos_url":"https://api.github.com/users/ZLLentz/repos","events_url":"https://api.github.com/users/ZLLentz/events{/privacy}","received_events_url":"https://api.github.com/users/ZLLentz/received_events","type":"User","site_admin":false},"created_at":"2018-06-25T21:31:42Z","updated_at":"2018-06-25T21:31:42Z","author_association":"CONTRIBUTOR","body":"- docs written\r\n- switched to zero-index as Silke wanted"}}
{"actor":{"display_login":"ZLLentz"}}