{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/223898127","pull_request_review_id":163139317,"id":223898127,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzg5ODEyNw==","diff_hunk":"@@ -356,6 +356,7 @@ extension DispatchData {\n \t\treturn true\n \t}\n \n+  @_effects(readonly)","path":"stdlib/public/SDK/Dispatch/Data.swift","position":4,"original_position":4,"commit_id":"0a87574b17b953de110c0b5bb4e6ed9f020b0519","original_commit_id":"0a87574b17b953de110c0b5bb4e6ed9f020b0519","user":{"login":"slavapestov","id":66486,"node_id":"MDQ6VXNlcjY2NDg2","avatar_url":"https://avatars1.githubusercontent.com/u/66486?v=4","gravatar_id":"","url":"https://api.github.com/users/slavapestov","html_url":"https://github.com/slavapestov","followers_url":"https://api.github.com/users/slavapestov/followers","following_url":"https://api.github.com/users/slavapestov/following{/other_user}","gists_url":"https://api.github.com/users/slavapestov/gists{/gist_id}","starred_url":"https://api.github.com/users/slavapestov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavapestov/subscriptions","organizations_url":"https://api.github.com/users/slavapestov/orgs","repos_url":"https://api.github.com/users/slavapestov/repos","events_url":"https://api.github.com/users/slavapestov/events{/privacy}","received_events_url":"https://api.github.com/users/slavapestov/received_events","type":"User","site_admin":false},"body":"Bad indent here","created_at":"2018-10-09T23:41:17Z","updated_at":"2018-10-09T23:41:51Z","html_url":"https://github.com/apple/swift/pull/19797#discussion_r223898127","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/19797","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/223898127"},"html":{"href":"https://github.com/apple/swift/pull/19797#discussion_r223898127"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/19797"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/19797","id":221524525,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNTI0NTI1","html_url":"https://github.com/apple/swift/pull/19797","diff_url":"https://github.com/apple/swift/pull/19797.diff","patch_url":"https://github.com/apple/swift/pull/19797.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/19797","number":19797,"state":"open","locked":false,"title":"Remove dead bridging calls for dead parameters","user":{"login":"eeckstein","id":15270291,"node_id":"MDQ6VXNlcjE1MjcwMjkx","avatar_url":"https://avatars0.githubusercontent.com/u/15270291?v=4","gravatar_id":"","url":"https://api.github.com/users/eeckstein","html_url":"https://github.com/eeckstein","followers_url":"https://api.github.com/users/eeckstein/followers","following_url":"https://api.github.com/users/eeckstein/following{/other_user}","gists_url":"https://api.github.com/users/eeckstein/gists{/gist_id}","starred_url":"https://api.github.com/users/eeckstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eeckstein/subscriptions","organizations_url":"https://api.github.com/users/eeckstein/orgs","repos_url":"https://api.github.com/users/eeckstein/repos","events_url":"https://api.github.com/users/eeckstein/events{/privacy}","received_events_url":"https://api.github.com/users/eeckstein/received_events","type":"User","site_admin":false},"body":"This PR consists of 2 changes:\r\n\r\n* lazily emit shared witness tables: This avoids emitting synthesized witness tables if they are not needed.\r\n\r\n* mark all _unconditionallyBridgeFromObjectiveC functions as @_effects(readonly): Read-only lets the optimizer remove such a call if the result is not used.\r\nNote that \"readonly\" means: no observable write operations. It's okay to allocate and initialize new objects.\r\n\r\nrdar://problem/44944094\r\n","created_at":"2018-10-09T17:34:20Z","updated_at":"2018-10-09T23:41:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6bae167cafa13e2708775c0cf78666416d5801c1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"phausler","id":278470,"node_id":"MDQ6VXNlcjI3ODQ3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/278470?v=4","gravatar_id":"","url":"https://api.github.com/users/phausler","html_url":"https://github.com/phausler","followers_url":"https://api.github.com/users/phausler/followers","following_url":"https://api.github.com/users/phausler/following{/other_user}","gists_url":"https://api.github.com/users/phausler/gists{/gist_id}","starred_url":"https://api.github.com/users/phausler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phausler/subscriptions","organizations_url":"https://api.github.com/users/phausler/orgs","repos_url":"https://api.github.com/users/phausler/repos","events_url":"https://api.github.com/users/phausler/events{/privacy}","received_events_url":"https://api.github.com/users/phausler/received_events","type":"User","site_admin":false},{"login":"DougGregor","id":989428,"node_id":"MDQ6VXNlcjk4OTQyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/989428?v=4","gravatar_id":"","url":"https://api.github.com/users/DougGregor","html_url":"https://github.com/DougGregor","followers_url":"https://api.github.com/users/DougGregor/followers","following_url":"https://api.github.com/users/DougGregor/following{/other_user}","gists_url":"https://api.github.com/users/DougGregor/gists{/gist_id}","starred_url":"https://api.github.com/users/DougGregor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DougGregor/subscriptions","organizations_url":"https://api.github.com/users/DougGregor/orgs","repos_url":"https://api.github.com/users/DougGregor/repos","events_url":"https://api.github.com/users/DougGregor/events{/privacy}","received_events_url":"https://api.github.com/users/DougGregor/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/19797/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/19797/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/19797/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/0a87574b17b953de110c0b5bb4e6ed9f020b0519","head":{"label":"eeckstein:remove-dead-bridging-calls","ref":"remove-dead-bridging-calls","sha":"0a87574b17b953de110c0b5bb4e6ed9f020b0519","user":{"login":"eeckstein","id":15270291,"node_id":"MDQ6VXNlcjE1MjcwMjkx","avatar_url":"https://avatars0.githubusercontent.com/u/15270291?v=4","gravatar_id":"","url":"https://api.github.com/users/eeckstein","html_url":"https://github.com/eeckstein","followers_url":"https://api.github.com/users/eeckstein/followers","following_url":"https://api.github.com/users/eeckstein/following{/other_user}","gists_url":"https://api.github.com/users/eeckstein/gists{/gist_id}","starred_url":"https://api.github.com/users/eeckstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eeckstein/subscriptions","organizations_url":"https://api.github.com/users/eeckstein/orgs","repos_url":"https://api.github.com/users/eeckstein/repos","events_url":"https://api.github.com/users/eeckstein/events{/privacy}","received_events_url":"https://api.github.com/users/eeckstein/received_events","type":"User","site_admin":false},"repo":{"id":52555464,"node_id":"MDEwOlJlcG9zaXRvcnk1MjU1NTQ2NA==","name":"swift","full_name":"eeckstein/swift","private":false,"owner":{"login":"eeckstein","id":15270291,"node_id":"MDQ6VXNlcjE1MjcwMjkx","avatar_url":"https://avatars0.githubusercontent.com/u/15270291?v=4","gravatar_id":"","url":"https://api.github.com/users/eeckstein","html_url":"https://github.com/eeckstein","followers_url":"https://api.github.com/users/eeckstein/followers","following_url":"https://api.github.com/users/eeckstein/following{/other_user}","gists_url":"https://api.github.com/users/eeckstein/gists{/gist_id}","starred_url":"https://api.github.com/users/eeckstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eeckstein/subscriptions","organizations_url":"https://api.github.com/users/eeckstein/orgs","repos_url":"https://api.github.com/users/eeckstein/repos","events_url":"https://api.github.com/users/eeckstein/events{/privacy}","received_events_url":"https://api.github.com/users/eeckstein/received_events","type":"User","site_admin":false},"html_url":"https://github.com/eeckstein/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/eeckstein/swift","forks_url":"https://api.github.com/repos/eeckstein/swift/forks","keys_url":"https://api.github.com/repos/eeckstein/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eeckstein/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eeckstein/swift/teams","hooks_url":"https://api.github.com/repos/eeckstein/swift/hooks","issue_events_url":"https://api.github.com/repos/eeckstein/swift/issues/events{/number}","events_url":"https://api.github.com/repos/eeckstein/swift/events","assignees_url":"https://api.github.com/repos/eeckstein/swift/assignees{/user}","branches_url":"https://api.github.com/repos/eeckstein/swift/branches{/branch}","tags_url":"https://api.github.com/repos/eeckstein/swift/tags","blobs_url":"https://api.github.com/repos/eeckstein/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eeckstein/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eeckstein/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/eeckstein/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eeckstein/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/eeckstein/swift/languages","stargazers_url":"https://api.github.com/repos/eeckstein/swift/stargazers","contributors_url":"https://api.github.com/repos/eeckstein/swift/contributors","subscribers_url":"https://api.github.com/repos/eeckstein/swift/subscribers","subscription_url":"https://api.github.com/repos/eeckstein/swift/subscription","commits_url":"https://api.github.com/repos/eeckstein/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/eeckstein/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/eeckstein/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/eeckstein/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/eeckstein/swift/contents/{+path}","compare_url":"https://api.github.com/repos/eeckstein/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eeckstein/swift/merges","archive_url":"https://api.github.com/repos/eeckstein/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eeckstein/swift/downloads","issues_url":"https://api.github.com/repos/eeckstein/swift/issues{/number}","pulls_url":"https://api.github.com/repos/eeckstein/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/eeckstein/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/eeckstein/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eeckstein/swift/labels{/name}","releases_url":"https://api.github.com/repos/eeckstein/swift/releases{/id}","deployments_url":"https://api.github.com/repos/eeckstein/swift/deployments","created_at":"2016-02-25T20:42:45Z","updated_at":"2016-02-25T20:43:11Z","pushed_at":"2018-10-09T17:29:54Z","git_url":"git://github.com/eeckstein/swift.git","ssh_url":"git@github.com:eeckstein/swift.git","clone_url":"https://github.com/eeckstein/swift.git","svn_url":"https://github.com/eeckstein/swift","homepage":"https://swift.org/","size":322032,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"00cc0116215152e59ae992430e86054687dfc585","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-10-09T23:39:15Z","pushed_at":"2018-10-09T23:37:59Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":349349,"stargazers_count":45430,"watchers_count":45430,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7200,"mirror_url":null,"archived":false,"open_issues_count":392,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7200,"open_issues":392,"watchers":45430,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/19797"},"html":{"href":"https://github.com/apple/swift/pull/19797"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/19797"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/19797/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/19797/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/19797/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/0a87574b17b953de110c0b5bb4e6ed9f020b0519"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"slavapestov"}}