{"action":"created","issue":{"url":"https://api.github.com/repos/mojaloop/project/issues/516","repository_url":"https://api.github.com/repos/mojaloop/project","labels_url":"https://api.github.com/repos/mojaloop/project/issues/516/labels{/name}","comments_url":"https://api.github.com/repos/mojaloop/project/issues/516/comments","events_url":"https://api.github.com/repos/mojaloop/project/issues/516/events","html_url":"https://github.com/mojaloop/project/issues/516","id":370778046,"node_id":"MDU6SXNzdWUzNzA3NzgwNDY=","number":516,"title":"Content-Type, Accept Header issue - Transfers","user":{"login":"sri-miriyala","id":38143240,"node_id":"MDQ6VXNlcjM4MTQzMjQw","avatar_url":"https://avatars3.githubusercontent.com/u/38143240?v=4","gravatar_id":"","url":"https://api.github.com/users/sri-miriyala","html_url":"https://github.com/sri-miriyala","followers_url":"https://api.github.com/users/sri-miriyala/followers","following_url":"https://api.github.com/users/sri-miriyala/following{/other_user}","gists_url":"https://api.github.com/users/sri-miriyala/gists{/gist_id}","starred_url":"https://api.github.com/users/sri-miriyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sri-miriyala/subscriptions","organizations_url":"https://api.github.com/users/sri-miriyala/orgs","repos_url":"https://api.github.com/users/sri-miriyala/repos","events_url":"https://api.github.com/users/sri-miriyala/events{/privacy}","received_events_url":"https://api.github.com/users/sri-miriyala/received_events","type":"User","site_admin":false},"labels":[{"id":798057396,"node_id":"MDU6TGFiZWw3OTgwNTczOTY=","url":"https://api.github.com/repos/mojaloop/project/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":{"login":"elnyry","id":10507686,"node_id":"MDQ6VXNlcjEwNTA3Njg2","avatar_url":"https://avatars1.githubusercontent.com/u/10507686?v=4","gravatar_id":"","url":"https://api.github.com/users/elnyry","html_url":"https://github.com/elnyry","followers_url":"https://api.github.com/users/elnyry/followers","following_url":"https://api.github.com/users/elnyry/following{/other_user}","gists_url":"https://api.github.com/users/elnyry/gists{/gist_id}","starred_url":"https://api.github.com/users/elnyry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elnyry/subscriptions","organizations_url":"https://api.github.com/users/elnyry/orgs","repos_url":"https://api.github.com/users/elnyry/repos","events_url":"https://api.github.com/users/elnyry/events{/privacy}","received_events_url":"https://api.github.com/users/elnyry/received_events","type":"User","site_admin":false},"assignees":[{"login":"elnyry","id":10507686,"node_id":"MDQ6VXNlcjEwNTA3Njg2","avatar_url":"https://avatars1.githubusercontent.com/u/10507686?v=4","gravatar_id":"","url":"https://api.github.com/users/elnyry","html_url":"https://github.com/elnyry","followers_url":"https://api.github.com/users/elnyry/followers","following_url":"https://api.github.com/users/elnyry/following{/other_user}","gists_url":"https://api.github.com/users/elnyry/gists{/gist_id}","starred_url":"https://api.github.com/users/elnyry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elnyry/subscriptions","organizations_url":"https://api.github.com/users/elnyry/orgs","repos_url":"https://api.github.com/users/elnyry/repos","events_url":"https://api.github.com/users/elnyry/events{/privacy}","received_events_url":"https://api.github.com/users/elnyry/received_events","type":"User","site_admin":false},{"login":"shashi165","id":33355509,"node_id":"MDQ6VXNlcjMzMzU1NTA5","avatar_url":"https://avatars3.githubusercontent.com/u/33355509?v=4","gravatar_id":"","url":"https://api.github.com/users/shashi165","html_url":"https://github.com/shashi165","followers_url":"https://api.github.com/users/shashi165/followers","following_url":"https://api.github.com/users/shashi165/following{/other_user}","gists_url":"https://api.github.com/users/shashi165/gists{/gist_id}","starred_url":"https://api.github.com/users/shashi165/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashi165/subscriptions","organizations_url":"https://api.github.com/users/shashi165/orgs","repos_url":"https://api.github.com/users/shashi165/repos","events_url":"https://api.github.com/users/shashi165/events{/privacy}","received_events_url":"https://api.github.com/users/shashi165/received_events","type":"User","site_admin":false},{"login":"sri-miriyala","id":38143240,"node_id":"MDQ6VXNlcjM4MTQzMjQw","avatar_url":"https://avatars3.githubusercontent.com/u/38143240?v=4","gravatar_id":"","url":"https://api.github.com/users/sri-miriyala","html_url":"https://github.com/sri-miriyala","followers_url":"https://api.github.com/users/sri-miriyala/followers","following_url":"https://api.github.com/users/sri-miriyala/following{/other_user}","gists_url":"https://api.github.com/users/sri-miriyala/gists{/gist_id}","starred_url":"https://api.github.com/users/sri-miriyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sri-miriyala/subscriptions","organizations_url":"https://api.github.com/users/sri-miriyala/orgs","repos_url":"https://api.github.com/users/sri-miriyala/repos","events_url":"https://api.github.com/users/sri-miriyala/events{/privacy}","received_events_url":"https://api.github.com/users/sri-miriyala/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mojaloop/project/milestones/18","html_url":"https://github.com/mojaloop/project/milestone/18","labels_url":"https://api.github.com/repos/mojaloop/project/milestones/18/labels","id":3740226,"node_id":"MDk6TWlsZXN0b25lMzc0MDIyNg==","number":18,"title":"Sprint 3.8","description":"Sprint 3.8 for the Open Source work items","creator":{"login":"elnyry","id":10507686,"node_id":"MDQ6VXNlcjEwNTA3Njg2","avatar_url":"https://avatars1.githubusercontent.com/u/10507686?v=4","gravatar_id":"","url":"https://api.github.com/users/elnyry","html_url":"https://github.com/elnyry","followers_url":"https://api.github.com/users/elnyry/followers","following_url":"https://api.github.com/users/elnyry/following{/other_user}","gists_url":"https://api.github.com/users/elnyry/gists{/gist_id}","starred_url":"https://api.github.com/users/elnyry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elnyry/subscriptions","organizations_url":"https://api.github.com/users/elnyry/orgs","repos_url":"https://api.github.com/users/elnyry/repos","events_url":"https://api.github.com/users/elnyry/events{/privacy}","received_events_url":"https://api.github.com/users/elnyry/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":0,"state":"open","created_at":"2018-10-15T15:49:17Z","updated_at":"2018-10-21T01:36:40Z","due_on":"2018-10-27T07:00:00Z","closed_at":null},"comments":1,"created_at":"2018-10-16T20:06:39Z","updated_at":"2018-10-21T01:38:22Z","closed_at":null,"author_association":"NONE","body":"Priority: High\r\nEnv : ML AWS\r\n\r\nDescription: \r\nThe current transfers is accepting a Header, content type \"application/json\". But as per the API Spec, the Content type should be \r\nContent-Type=[application/vnd.interoperability.transfers+json;version=1.0]\r\n\r\n\r\nExpected behavior:\r\nTransfers request should take content type \"application/vnd.interoperability.transfers+json;version=1.0\" without errors.\r\n\r\nTasks:\r\n- [x] Change validation of **Content-Type** header from application/json to \"_application/vnd.interoperability.transfers+json;version=1.0_\" as per the API Specification\r\n- [x] Fix code to relay an incoming **Accept** header (as optional for the time-being as that applies to POST, GET requests and not PUT), with value \"_application/vnd.interoperability.transfers+json;version=1_\", as per the Spec\r\n- [x] Update/Fix tests\r\n\r\n**PR**\r\n- [x] https://github.com/mojaloop/ml-api-adapter/pull/65\r\n\r\n**Follow-up tasks**\r\n- [ ] Update scripts in 'postman' repo to use the updated headers\r\n\r\n**Notes**:\r\nThis change is to conform to the Specification (API Definition), so it is nothing out of the ordinary. This would necessitate that the postman scripts need to be updated to use the updated values for these headers.\r\n"},"comment":{"url":"https://api.github.com/repos/mojaloop/project/issues/comments/431631270","html_url":"https://github.com/mojaloop/project/issues/516#issuecomment-431631270","issue_url":"https://api.github.com/repos/mojaloop/project/issues/516","id":431631270,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTYzMTI3MA==","user":{"login":"sri-miriyala","id":38143240,"node_id":"MDQ6VXNlcjM4MTQzMjQw","avatar_url":"https://avatars3.githubusercontent.com/u/38143240?v=4","gravatar_id":"","url":"https://api.github.com/users/sri-miriyala","html_url":"https://github.com/sri-miriyala","followers_url":"https://api.github.com/users/sri-miriyala/followers","following_url":"https://api.github.com/users/sri-miriyala/following{/other_user}","gists_url":"https://api.github.com/users/sri-miriyala/gists{/gist_id}","starred_url":"https://api.github.com/users/sri-miriyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sri-miriyala/subscriptions","organizations_url":"https://api.github.com/users/sri-miriyala/orgs","repos_url":"https://api.github.com/users/sri-miriyala/repos","events_url":"https://api.github.com/users/sri-miriyala/events{/privacy}","received_events_url":"https://api.github.com/users/sri-miriyala/received_events","type":"User","site_admin":false},"created_at":"2018-10-21T01:38:22Z","updated_at":"2018-10-21T01:38:22Z","author_association":"NONE","body":"Had to reopen as the format of the response body is not as per API spec.\r\nAfter the fix,\r\nFor the incorrect Header filed, I'm getting a response code 400-Bad request, and the response body is below.\r\n\r\n{ \"id\": \"BadRequestError\", \"message\": \"Invalid content-type header\" }\r\nScreenshot:\r\n<img width=\"707\" alt=\"screen shot 2018-10-20 at 9 24 40 pm\" src=\"https://user-images.githubusercontent.com/38143240/47262215-54fd0200-d4b0-11e8-84b4-1971b534f6c0.png\">\r\nResponse body is not as per API Spec. \r\nExpected Response body: It shoud mention error code:3101, and error Description: \"Invalid Content-Type Header\"\r\nIt should be like the below one:\r\n{\r\n\"errorInformation\": {\r\n\"errorCode\": 0,\r\n\"errorDescription\": \"string\",\r\n\"extensionList\": {\r\n\"extension\": [\r\n\r\n{ \"key\": \"string\", \"value\": \"string\" }\r\n]\r\n}\r\n}\r\n}\r\n"}}
{"actor":{"display_login":"sri-miriyala"}}