{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/comments/187976634","pull_request_review_id":119862223,"id":187976634,"diff_hunk":"@@ -128,6 +128,7 @@ all: $(TARGETS)\n # Add OMR include paths\n #  Note assumptions about the directory layout of the OMR project.\n UMA_INCLUDES+=$(UMA_PATH_TO_ROOT)nls\n+UMA_INCLUDES+=$(UMA_PATH_TO_ROOT)include","path":"runtime/makelib/targets.mk.ftl","position":4,"original_position":4,"commit_id":"64289061835f6d1c888c98c47981ae3ef2565991","original_commit_id":"5f3006312a0f70d70d96f2ec6559edf2012b1393","user":{"login":"pshipton","id":18122812,"avatar_url":"https://avatars1.githubusercontent.com/u/18122812?v=4","gravatar_id":"","url":"https://api.github.com/users/pshipton","html_url":"https://github.com/pshipton","followers_url":"https://api.github.com/users/pshipton/followers","following_url":"https://api.github.com/users/pshipton/following{/other_user}","gists_url":"https://api.github.com/users/pshipton/gists{/gist_id}","starred_url":"https://api.github.com/users/pshipton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pshipton/subscriptions","organizations_url":"https://api.github.com/users/pshipton/orgs","repos_url":"https://api.github.com/users/pshipton/repos","events_url":"https://api.github.com/users/pshipton/events{/privacy}","received_events_url":"https://api.github.com/users/pshipton/received_events","type":"User","site_admin":false},"body":"Is there an associated omr PR? There is no omr 'include' directory.","created_at":"2018-05-14T14:35:31Z","updated_at":"2018-05-14T14:35:31Z","html_url":"https://github.com/eclipse/openj9/pull/1904#discussion_r187976634","pull_request_url":"https://api.github.com/repos/eclipse/openj9/pulls/1904","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments/187976634"},"html":{"href":"https://github.com/eclipse/openj9/pull/1904#discussion_r187976634"},"pull_request":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/1904"}},"in_reply_to_id":187941750},"pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/1904","id":187583865,"html_url":"https://github.com/eclipse/openj9/pull/1904","diff_url":"https://github.com/eclipse/openj9/pull/1904.diff","patch_url":"https://github.com/eclipse/openj9/pull/1904.patch","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/1904","number":1904,"state":"open","locked":false,"title":"Add steps to compile 32-bit Java8 on Windows","user":{"login":"ChengJin01","id":18036229,"avatar_url":"https://avatars3.githubusercontent.com/u/18036229?v=4","gravatar_id":"","url":"https://api.github.com/users/ChengJin01","html_url":"https://github.com/ChengJin01","followers_url":"https://api.github.com/users/ChengJin01/followers","following_url":"https://api.github.com/users/ChengJin01/following{/other_user}","gists_url":"https://api.github.com/users/ChengJin01/gists{/gist_id}","starred_url":"https://api.github.com/users/ChengJin01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChengJin01/subscriptions","organizations_url":"https://api.github.com/users/ChengJin01/orgs","repos_url":"https://api.github.com/users/ChengJin01/repos","events_url":"https://api.github.com/users/ChengJin01/events{/privacy}","received_events_url":"https://api.github.com/users/ChengJin01/received_events","type":"User","site_admin":false},"body":"The change is to add building steps for\r\n32-bit Java 8 version on Windows platform.\r\n\r\nSigned-off-by: CHENGJin <jincheng@ca.ibm.com>","created_at":"2018-05-11T22:31:20Z","updated_at":"2018-05-14T14:35:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cb98ab2446b3d9668cf273adfc8e0d18884eb26","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":697962661,"url":"https://api.github.com/repos/eclipse/openj9/labels/comp:doc","name":"comp:doc","color":"1d76db","default":false},{"id":697962110,"url":"https://api.github.com/repos/eclipse/openj9/labels/comp:vm","name":"comp:vm","color":"1d76db","default":false},{"id":772794860,"url":"https://api.github.com/repos/eclipse/openj9/labels/depends:openjdk10","name":"depends:openjdk10","color":"d4c5f9","default":false},{"id":847120151,"url":"https://api.github.com/repos/eclipse/openj9/labels/depends:openjdk11","name":"depends:openjdk11","color":"d4c5f9","default":false},{"id":772794658,"url":"https://api.github.com/repos/eclipse/openj9/labels/depends:openjdk8","name":"depends:openjdk8","color":"d4c5f9","default":false},{"id":709764050,"url":"https://api.github.com/repos/eclipse/openj9/labels/depends:openjdk9","name":"depends:openjdk9","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/openj9/pulls/1904/commits","review_comments_url":"https://api.github.com/repos/eclipse/openj9/pulls/1904/comments","review_comment_url":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/1904/comments","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/64289061835f6d1c888c98c47981ae3ef2565991","head":{"label":"ChengJin01:MD_32_BIT_WIN","ref":"MD_32_BIT_WIN","sha":"64289061835f6d1c888c98c47981ae3ef2565991","user":{"login":"ChengJin01","id":18036229,"avatar_url":"https://avatars3.githubusercontent.com/u/18036229?v=4","gravatar_id":"","url":"https://api.github.com/users/ChengJin01","html_url":"https://github.com/ChengJin01","followers_url":"https://api.github.com/users/ChengJin01/followers","following_url":"https://api.github.com/users/ChengJin01/following{/other_user}","gists_url":"https://api.github.com/users/ChengJin01/gists{/gist_id}","starred_url":"https://api.github.com/users/ChengJin01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChengJin01/subscriptions","organizations_url":"https://api.github.com/users/ChengJin01/orgs","repos_url":"https://api.github.com/users/ChengJin01/repos","events_url":"https://api.github.com/users/ChengJin01/events{/privacy}","received_events_url":"https://api.github.com/users/ChengJin01/received_events","type":"User","site_admin":false},"repo":{"id":103943978,"name":"openj9","full_name":"ChengJin01/openj9","owner":{"login":"ChengJin01","id":18036229,"avatar_url":"https://avatars3.githubusercontent.com/u/18036229?v=4","gravatar_id":"","url":"https://api.github.com/users/ChengJin01","html_url":"https://github.com/ChengJin01","followers_url":"https://api.github.com/users/ChengJin01/followers","following_url":"https://api.github.com/users/ChengJin01/following{/other_user}","gists_url":"https://api.github.com/users/ChengJin01/gists{/gist_id}","starred_url":"https://api.github.com/users/ChengJin01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChengJin01/subscriptions","organizations_url":"https://api.github.com/users/ChengJin01/orgs","repos_url":"https://api.github.com/users/ChengJin01/repos","events_url":"https://api.github.com/users/ChengJin01/events{/privacy}","received_events_url":"https://api.github.com/users/ChengJin01/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ChengJin01/openj9","description":"OpenJ9","fork":true,"url":"https://api.github.com/repos/ChengJin01/openj9","forks_url":"https://api.github.com/repos/ChengJin01/openj9/forks","keys_url":"https://api.github.com/repos/ChengJin01/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChengJin01/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChengJin01/openj9/teams","hooks_url":"https://api.github.com/repos/ChengJin01/openj9/hooks","issue_events_url":"https://api.github.com/repos/ChengJin01/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/ChengJin01/openj9/events","assignees_url":"https://api.github.com/repos/ChengJin01/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/ChengJin01/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/ChengJin01/openj9/tags","blobs_url":"https://api.github.com/repos/ChengJin01/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChengJin01/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChengJin01/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChengJin01/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChengJin01/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/ChengJin01/openj9/languages","stargazers_url":"https://api.github.com/repos/ChengJin01/openj9/stargazers","contributors_url":"https://api.github.com/repos/ChengJin01/openj9/contributors","subscribers_url":"https://api.github.com/repos/ChengJin01/openj9/subscribers","subscription_url":"https://api.github.com/repos/ChengJin01/openj9/subscription","commits_url":"https://api.github.com/repos/ChengJin01/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChengJin01/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChengJin01/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChengJin01/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChengJin01/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/ChengJin01/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChengJin01/openj9/merges","archive_url":"https://api.github.com/repos/ChengJin01/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChengJin01/openj9/downloads","issues_url":"https://api.github.com/repos/ChengJin01/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/ChengJin01/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/ChengJin01/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/ChengJin01/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChengJin01/openj9/labels{/name}","releases_url":"https://api.github.com/repos/ChengJin01/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/ChengJin01/openj9/deployments","created_at":"2017-09-18T13:40:00Z","updated_at":"2017-09-18T13:40:28Z","pushed_at":"2018-05-14T14:09:41Z","git_url":"git://github.com/ChengJin01/openj9.git","ssh_url":"git@github.com:ChengJin01/openj9.git","clone_url":"https://github.com/ChengJin01/openj9.git","svn_url":"https://github.com/ChengJin01/openj9","homepage":null,"size":29377,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"046b210be1da1e151a221fe5637e0daad50a61e8","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":101408117,"name":"openj9","full_name":"eclipse/openj9","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":false,"url":"https://api.github.com/repos/eclipse/openj9","forks_url":"https://api.github.com/repos/eclipse/openj9/forks","keys_url":"https://api.github.com/repos/eclipse/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/openj9/teams","hooks_url":"https://api.github.com/repos/eclipse/openj9/hooks","issue_events_url":"https://api.github.com/repos/eclipse/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/openj9/events","assignees_url":"https://api.github.com/repos/eclipse/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/openj9/tags","blobs_url":"https://api.github.com/repos/eclipse/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/openj9/languages","stargazers_url":"https://api.github.com/repos/eclipse/openj9/stargazers","contributors_url":"https://api.github.com/repos/eclipse/openj9/contributors","subscribers_url":"https://api.github.com/repos/eclipse/openj9/subscribers","subscription_url":"https://api.github.com/repos/eclipse/openj9/subscription","commits_url":"https://api.github.com/repos/eclipse/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/openj9/merges","archive_url":"https://api.github.com/repos/eclipse/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/openj9/downloads","issues_url":"https://api.github.com/repos/eclipse/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/openj9/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/openj9/deployments","created_at":"2017-08-25T13:46:07Z","updated_at":"2018-05-14T12:59:37Z","pushed_at":"2018-05-14T14:31:58Z","git_url":"git://github.com/eclipse/openj9.git","ssh_url":"git@github.com:eclipse/openj9.git","clone_url":"https://github.com/eclipse/openj9.git","svn_url":"https://github.com/eclipse/openj9","homepage":"","size":29252,"stargazers_count":1241,"watchers_count":1241,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":253,"mirror_url":null,"archived":false,"open_issues_count":357,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":253,"open_issues":357,"watchers":1241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/1904"},"html":{"href":"https://github.com/eclipse/openj9/pull/1904"},"issue":{"href":"https://api.github.com/repos/eclipse/openj9/issues/1904"},"comments":{"href":"https://api.github.com/repos/eclipse/openj9/issues/1904/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/1904/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/1904/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/openj9/statuses/64289061835f6d1c888c98c47981ae3ef2565991"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pshipton"}}