{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/pulls/comments/237534123","pull_request_review_id":179855213,"id":237534123,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzUzNDEyMw==","diff_hunk":"@@ -46,14 +48,22 @@ For more information on Puppet module installation see [Puppet Labs: Installing\n \r\n PuppetLabs provides NetDev resource support for Cisco Nexus devices with their [`puppetlabs-netdev-stdlib`](https://forge.puppet.com/puppetlabs/netdev_stdlib) module. Installing the `ciscopuppet` module automatically installs both the `ciscopuppet` and `netdev_stdlib` modules.\r\n \r\n-### <a name=\"setup-puppet-agent\">Puppet Agent<a>\r\n+##### The `puppetlabs-resource_api` module\r\n+\r\n+The module has a dependency on the `resource_api` - it will be installed when the module is installed. Alternatively, it can be manually installed by running `puppet module install puppetlabs-resource_api`, or by following the setup instructions in the [Resource API README](https://github.com/puppetlabs/puppetlabs-resource_api#resource_api).\r\n+\r\n+### <a name=\"setup-puppet-agent\">Puppet Agent (LTS)</a>\r\n \r\n The Puppet Agent requires installation and setup on each device. Agent setup can be performed as a manual process or it may be automated. For more information please see the [README-agent-install.md][USER-1] document for detailed instructions on agent installation and configuration on Cisco Nexus devices.\r\n \r\n ##### The `cisco_node_utils` Ruby Gem\r\n \r\n The [`cisco_node_utils`](https://rubygems.org/gems/cisco_node_utils) ruby gem is a required component of the `ciscopuppet` module. This gem contains platform APIs for interfacing between Cisco CLI and Puppet agent resources. The gem can be automatically installed by Puppet agent by simply using the [`ciscopuppet::install`](https://github.com/cisco/cisco-network-puppet-module/blob/master/examples/demo_all_cisco.pp#L19) helper class, or it can be installed manually.\r\n \r\n+##### The `puppet-resource_api` Ruby Gem\r\n+\r\n+The [`puppet-resource_api`](https://rubygems.org/gems/puppet-resource_api) ruby gem is a required component of the `ciscopuppet` module. The gem can be automatically installed by Puppet agent by simply using the [`ciscopuppet::install`](https://github.com/cisco/cisco-network-puppet-module/blob/master/examples/demo_all_cisco.pp#L19) helper class, or it can be installed manually.\r","path":"README.md","position":48,"original_position":48,"commit_id":"b962e4a12afc261b8acca48eae38b94e6fde0dbe","original_commit_id":"b962e4a12afc261b8acca48eae38b94e6fde0dbe","user":{"login":"clairecadman","id":28658680,"node_id":"MDQ6VXNlcjI4NjU4Njgw","avatar_url":"https://avatars0.githubusercontent.com/u/28658680?v=4","gravatar_id":"","url":"https://api.github.com/users/clairecadman","html_url":"https://github.com/clairecadman","followers_url":"https://api.github.com/users/clairecadman/followers","following_url":"https://api.github.com/users/clairecadman/following{/other_user}","gists_url":"https://api.github.com/users/clairecadman/gists{/gist_id}","starred_url":"https://api.github.com/users/clairecadman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clairecadman/subscriptions","organizations_url":"https://api.github.com/users/clairecadman/orgs","repos_url":"https://api.github.com/users/clairecadman/repos","events_url":"https://api.github.com/users/clairecadman/events{/privacy}","received_events_url":"https://api.github.com/users/clairecadman/received_events","type":"User","site_admin":false},"body":"Either: By *a* Puppet agent OR just Puppet. \r\n\r\nOmit \"simply\". \r\n\r\nSuggested rephrase:\r\n\r\n\"Puppet automatically installs the gem using the... etc\" \r\n\r\n\r\n","created_at":"2018-11-29T15:30:25Z","updated_at":"2018-11-29T15:30:25Z","html_url":"https://github.com/puppetlabs/cisco-network-puppet-module/pull/85#discussion_r237534123","pull_request_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/pulls/85","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/pulls/comments/237534123"},"html":{"href":"https://github.com/puppetlabs/cisco-network-puppet-module/pull/85#discussion_r237534123"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/pulls/85","id":234661178,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NjYxMTc4","html_url":"https://github.com/puppetlabs/cisco-network-puppet-module/pull/85","diff_url":"https://github.com/puppetlabs/cisco-network-puppet-module/pull/85.diff","patch_url":"https://github.com/puppetlabs/cisco-network-puppet-module/pull/85.patch","issue_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/issues/85","number":85,"state":"open","locked":false,"title":"(FM-7565) updates to the README to reflect dual mode capabilities","user":{"login":"Thomas-Franklin","id":20070560,"node_id":"MDQ6VXNlcjIwMDcwNTYw","avatar_url":"https://avatars0.githubusercontent.com/u/20070560?v=4","gravatar_id":"","url":"https://api.github.com/users/Thomas-Franklin","html_url":"https://github.com/Thomas-Franklin","followers_url":"https://api.github.com/users/Thomas-Franklin/followers","following_url":"https://api.github.com/users/Thomas-Franklin/following{/other_user}","gists_url":"https://api.github.com/users/Thomas-Franklin/gists{/gist_id}","starred_url":"https://api.github.com/users/Thomas-Franklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thomas-Franklin/subscriptions","organizations_url":"https://api.github.com/users/Thomas-Franklin/orgs","repos_url":"https://api.github.com/users/Thomas-Franklin/repos","events_url":"https://api.github.com/users/Thomas-Franklin/events{/privacy}","received_events_url":"https://api.github.com/users/Thomas-Franklin/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-29T14:37:58Z","updated_at":"2018-11-29T15:30:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c6321555b9d8d256ef77121982aa89ee92ba1c0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"willmeek","id":29575714,"node_id":"MDQ6VXNlcjI5NTc1NzE0","avatar_url":"https://avatars0.githubusercontent.com/u/29575714?v=4","gravatar_id":"","url":"https://api.github.com/users/willmeek","html_url":"https://github.com/willmeek","followers_url":"https://api.github.com/users/willmeek/followers","following_url":"https://api.github.com/users/willmeek/following{/other_user}","gists_url":"https://api.github.com/users/willmeek/gists{/gist_id}","starred_url":"https://api.github.com/users/willmeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willmeek/subscriptions","organizations_url":"https://api.github.com/users/willmeek/orgs","repos_url":"https://api.github.com/users/willmeek/repos","events_url":"https://api.github.com/users/willmeek/events{/privacy}","received_events_url":"https://api.github.com/users/willmeek/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/pulls/85/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/pulls/85/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/issues/85/comments","statuses_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/statuses/b962e4a12afc261b8acca48eae38b94e6fde0dbe","head":{"label":"Thomas-Franklin:readme-changes","ref":"readme-changes","sha":"b962e4a12afc261b8acca48eae38b94e6fde0dbe","user":{"login":"Thomas-Franklin","id":20070560,"node_id":"MDQ6VXNlcjIwMDcwNTYw","avatar_url":"https://avatars0.githubusercontent.com/u/20070560?v=4","gravatar_id":"","url":"https://api.github.com/users/Thomas-Franklin","html_url":"https://github.com/Thomas-Franklin","followers_url":"https://api.github.com/users/Thomas-Franklin/followers","following_url":"https://api.github.com/users/Thomas-Franklin/following{/other_user}","gists_url":"https://api.github.com/users/Thomas-Franklin/gists{/gist_id}","starred_url":"https://api.github.com/users/Thomas-Franklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thomas-Franklin/subscriptions","organizations_url":"https://api.github.com/users/Thomas-Franklin/orgs","repos_url":"https://api.github.com/users/Thomas-Franklin/repos","events_url":"https://api.github.com/users/Thomas-Franklin/events{/privacy}","received_events_url":"https://api.github.com/users/Thomas-Franklin/received_events","type":"User","site_admin":false},"repo":{"id":150561288,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA1NjEyODg=","name":"cisco-network-puppet-module","full_name":"Thomas-Franklin/cisco-network-puppet-module","private":false,"owner":{"login":"Thomas-Franklin","id":20070560,"node_id":"MDQ6VXNlcjIwMDcwNTYw","avatar_url":"https://avatars0.githubusercontent.com/u/20070560?v=4","gravatar_id":"","url":"https://api.github.com/users/Thomas-Franklin","html_url":"https://github.com/Thomas-Franklin","followers_url":"https://api.github.com/users/Thomas-Franklin/followers","following_url":"https://api.github.com/users/Thomas-Franklin/following{/other_user}","gists_url":"https://api.github.com/users/Thomas-Franklin/gists{/gist_id}","starred_url":"https://api.github.com/users/Thomas-Franklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thomas-Franklin/subscriptions","organizations_url":"https://api.github.com/users/Thomas-Franklin/orgs","repos_url":"https://api.github.com/users/Thomas-Franklin/repos","events_url":"https://api.github.com/users/Thomas-Franklin/events{/privacy}","received_events_url":"https://api.github.com/users/Thomas-Franklin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Thomas-Franklin/cisco-network-puppet-module","description":null,"fork":true,"url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module","forks_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/forks","keys_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/teams","hooks_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/hooks","issue_events_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/issues/events{/number}","events_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/events","assignees_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/assignees{/user}","branches_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/branches{/branch}","tags_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/tags","blobs_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/statuses/{sha}","languages_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/languages","stargazers_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/stargazers","contributors_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/contributors","subscribers_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/subscribers","subscription_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/subscription","commits_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/contents/{+path}","compare_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/merges","archive_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/downloads","issues_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/issues{/number}","pulls_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/pulls{/number}","milestones_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/milestones{/number}","notifications_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/labels{/name}","releases_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/releases{/id}","deployments_url":"https://api.github.com/repos/Thomas-Franklin/cisco-network-puppet-module/deployments","created_at":"2018-09-27T09:20:52Z","updated_at":"2018-09-27T09:20:55Z","pushed_at":"2018-11-29T14:37:33Z","git_url":"git://github.com/Thomas-Franklin/cisco-network-puppet-module.git","ssh_url":"git@github.com:Thomas-Franklin/cisco-network-puppet-module.git","clone_url":"https://github.com/Thomas-Franklin/cisco-network-puppet-module.git","svn_url":"https://github.com/Thomas-Franklin/cisco-network-puppet-module","homepage":null,"size":5868,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"puppetlabs:puppet6","ref":"puppet6","sha":"d67114a29391d79d4fe6a4bfb86147f414a6a87a","user":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":99854111,"node_id":"MDEwOlJlcG9zaXRvcnk5OTg1NDExMQ==","name":"cisco-network-puppet-module","full_name":"puppetlabs/cisco-network-puppet-module","private":false,"owner":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/puppetlabs/cisco-network-puppet-module","description":null,"fork":true,"url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module","forks_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/forks","keys_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/teams","hooks_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/events","assignees_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/tags","blobs_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/subscription","commits_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/merges","archive_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/downloads","issues_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/deployments","created_at":"2017-08-09T21:26:12Z","updated_at":"2018-11-29T09:23:00Z","pushed_at":"2018-11-29T14:37:59Z","git_url":"git://github.com/puppetlabs/cisco-network-puppet-module.git","ssh_url":"git@github.com:puppetlabs/cisco-network-puppet-module.git","clone_url":"https://github.com/puppetlabs/cisco-network-puppet-module.git","svn_url":"https://github.com/puppetlabs/cisco-network-puppet-module","homepage":null,"size":5866,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":3,"watchers":0,"default_branch":"puppet6"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/pulls/85"},"html":{"href":"https://github.com/puppetlabs/cisco-network-puppet-module/pull/85"},"issue":{"href":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/issues/85"},"comments":{"href":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/cisco-network-puppet-module/statuses/b962e4a12afc261b8acca48eae38b94e6fde0dbe"}},"author_association":"NONE"}}
{"actor":{"display_login":"clairecadman"}}