{"action":"created","issue":{"url":"https://api.github.com/repos/filerjs/filer/issues/657","repository_url":"https://api.github.com/repos/filerjs/filer","labels_url":"https://api.github.com/repos/filerjs/filer/issues/657/labels{/name}","comments_url":"https://api.github.com/repos/filerjs/filer/issues/657/comments","events_url":"https://api.github.com/repos/filerjs/filer/issues/657/events","html_url":"https://github.com/filerjs/filer/pull/657","id":395617351,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMDI5MzA3","number":657,"title":"Remove src/encodings.js, use Buffer methods instead","user":{"login":"humphd","id":427398,"node_id":"MDQ6VXNlcjQyNzM5OA==","avatar_url":"https://avatars2.githubusercontent.com/u/427398?v=4","gravatar_id":"","url":"https://api.github.com/users/humphd","html_url":"https://github.com/humphd","followers_url":"https://api.github.com/users/humphd/followers","following_url":"https://api.github.com/users/humphd/following{/other_user}","gists_url":"https://api.github.com/users/humphd/gists{/gist_id}","starred_url":"https://api.github.com/users/humphd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humphd/subscriptions","organizations_url":"https://api.github.com/users/humphd/orgs","repos_url":"https://api.github.com/users/humphd/repos","events_url":"https://api.github.com/users/humphd/events{/privacy}","received_events_url":"https://api.github.com/users/humphd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-01-03T15:37:14Z","updated_at":"2019-01-03T15:43:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/filerjs/filer/pulls/657","html_url":"https://github.com/filerjs/filer/pull/657","diff_url":"https://github.com/filerjs/filer/pull/657.diff","patch_url":"https://github.com/filerjs/filer/pull/657.patch"},"body":"We used to need the `encoding` module, since we had to shim browser `TextEncoding`.  However, with `Buffer`, it's built in, so there's no need for this anymore."},"comment":{"url":"https://api.github.com/repos/filerjs/filer/issues/comments/451182020","html_url":"https://github.com/filerjs/filer/pull/657#issuecomment-451182020","issue_url":"https://api.github.com/repos/filerjs/filer/issues/657","id":451182020,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTE4MjAyMA==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2019-01-03T15:43:16Z","updated_at":"2019-01-03T15:43:16Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/filerjs/filer/pull/657?src=pr&el=h1) Report\n> Merging [#657](https://codecov.io/gh/filerjs/filer/pull/657?src=pr&el=desc) into [master](https://codecov.io/gh/filerjs/filer/commit/5f10cc2fde62f36f7c4c7911a3a72243e1c62e08?src=pr&el=desc) will **decrease** coverage by `0.03%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/filerjs/filer/pull/657/graphs/tree.svg?width=650&token=JoQTgz1Un2&height=150&src=pr)](https://codecov.io/gh/filerjs/filer/pull/657?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #657      +/-   ##\n==========================================\n- Coverage   86.74%   86.71%   -0.04%     \n==========================================\n  Files          17       16       -1     \n  Lines        1750     1746       -4     \n==========================================\n- Hits         1518     1514       -4     \n  Misses        232      232\n```\n\n\n| [Impacted Files](https://codecov.io/gh/filerjs/filer/pull/657?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/filesystem/implementation.js](https://codecov.io/gh/filerjs/filer/pull/657/diff?src=pr&el=tree#diff-c3JjL2ZpbGVzeXN0ZW0vaW1wbGVtZW50YXRpb24uanM=) | `83.72% <100%> (-0.02%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/filerjs/filer/pull/657?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/filerjs/filer/pull/657?src=pr&el=footer). Last update [5f10cc2...9d1be57](https://codecov.io/gh/filerjs/filer/pull/657?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}