{"action":"created","comment":{"url":"https://api.github.com/repos/diegohaz/reakit/pulls/comments/202520758","pull_request_review_id":137244053,"id":202520758,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjUyMDc1OA==","diff_hunk":"@@ -1,3 +1,3 @@\n-const getSections = section => [...section.sections, ...section.components];\n+const getSections = section => [].concat(section.sections, section.components);","path":"website/src/utils/getSections.js","position":2,"original_position":2,"commit_id":"02c113882a3f9690cccbd0f41353efc301156ae7","original_commit_id":"02c113882a3f9690cccbd0f41353efc301156ae7","user":{"login":"wordofchristian","id":555044,"node_id":"MDQ6VXNlcjU1NTA0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/555044?v=4","gravatar_id":"","url":"https://api.github.com/users/wordofchristian","html_url":"https://github.com/wordofchristian","followers_url":"https://api.github.com/users/wordofchristian/followers","following_url":"https://api.github.com/users/wordofchristian/following{/other_user}","gists_url":"https://api.github.com/users/wordofchristian/gists{/gist_id}","starred_url":"https://api.github.com/users/wordofchristian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordofchristian/subscriptions","organizations_url":"https://api.github.com/users/wordofchristian/orgs","repos_url":"https://api.github.com/users/wordofchristian/repos","events_url":"https://api.github.com/users/wordofchristian/events{/privacy}","received_events_url":"https://api.github.com/users/wordofchristian/received_events","type":"User","site_admin":false},"body":"The previous syntax here was causing test failures when `section.sections` was undefined. I think the spread syntax may have changed subtly to disallow this `[...undefined]`.","created_at":"2018-07-14T17:29:24Z","updated_at":"2018-07-14T17:29:25Z","html_url":"https://github.com/diegohaz/reakit/pull/146#discussion_r202520758","pull_request_url":"https://api.github.com/repos/diegohaz/reakit/pulls/146","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/diegohaz/reakit/pulls/comments/202520758"},"html":{"href":"https://github.com/diegohaz/reakit/pull/146#discussion_r202520758"},"pull_request":{"href":"https://api.github.com/repos/diegohaz/reakit/pulls/146"}}},"pull_request":{"url":"https://api.github.com/repos/diegohaz/reakit/pulls/146","id":201461106,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDYxMTA2","html_url":"https://github.com/diegohaz/reakit/pull/146","diff_url":"https://github.com/diegohaz/reakit/pull/146.diff","patch_url":"https://github.com/diegohaz/reakit/pull/146.patch","issue_url":"https://api.github.com/repos/diegohaz/reakit/issues/146","number":146,"state":"open","locked":false,"title":"[WIP] Typescript","user":{"login":"wordofchristian","id":555044,"node_id":"MDQ6VXNlcjU1NTA0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/555044?v=4","gravatar_id":"","url":"https://api.github.com/users/wordofchristian","html_url":"https://github.com/wordofchristian","followers_url":"https://api.github.com/users/wordofchristian/followers","following_url":"https://api.github.com/users/wordofchristian/following{/other_user}","gists_url":"https://api.github.com/users/wordofchristian/gists{/gist_id}","starred_url":"https://api.github.com/users/wordofchristian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wordofchristian/subscriptions","organizations_url":"https://api.github.com/users/wordofchristian/orgs","repos_url":"https://api.github.com/users/wordofchristian/repos","events_url":"https://api.github.com/users/wordofchristian/events{/privacy}","received_events_url":"https://api.github.com/users/wordofchristian/received_events","type":"User","site_admin":false},"body":"fixes #142 \r\n\r\n## Background\r\n\r\nThe goal of this branch is to add support for typescript so that it can be incrementally added to the library, eventually the library will be rewritten entirely in typescript but we don't want to do it all in one go to avoid conflicts. \r\n\r\nI'll continue working on this  but the initial impressions look promising, the tests are currently passing and there are only 15 type errors left.\r\n\r\n## Removed support for `babel-plugin-transform-export-extensions`\r\n\r\nThe syntax for `export default from \"./Base\";` is not yet supported by typescript and [won't be until it reaches stage 3 status](https://github.com/Microsoft/TypeScript/issues/4813#issuecomment-369742110)\r\n\r\nWithout this the `type-check` command does not understand that syntax and I couldn't find a good way to add babel plugins before the type-check command. It seemed like the lowest cost solution was to just stop using this syntax.\r\n\r\n## TODO\r\n- [ ] Fix remaining type errors\r\n- [ ] Audit tsconfig and make sure it's correct and nothing essential is missing\r\n- [ ] Add module definition file generation to build/publish process\r\n- [ ] Add `yarn run type-check` to CI","created_at":"2018-07-14T17:26:05Z","updated_at":"2018-07-14T17:29:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e47fe9d3b8c0e685e7ad1509e068e5684e1d6945","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/diegohaz/reakit/pulls/146/commits","review_comments_url":"https://api.github.com/repos/diegohaz/reakit/pulls/146/comments","review_comment_url":"https://api.github.com/repos/diegohaz/reakit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diegohaz/reakit/issues/146/comments","statuses_url":"https://api.github.com/repos/diegohaz/reakit/statuses/02c113882a3f9690cccbd0f41353efc301156ae7","head":{"label":"diegohaz:typescript","ref":"typescript","sha":"02c113882a3f9690cccbd0f41353efc301156ae7","user":{"login":"diegohaz","id":3068563,"node_id":"MDQ6VXNlcjMwNjg1NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/3068563?v=4","gravatar_id":"","url":"https://api.github.com/users/diegohaz","html_url":"https://github.com/diegohaz","followers_url":"https://api.github.com/users/diegohaz/followers","following_url":"https://api.github.com/users/diegohaz/following{/other_user}","gists_url":"https://api.github.com/users/diegohaz/gists{/gist_id}","starred_url":"https://api.github.com/users/diegohaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diegohaz/subscriptions","organizations_url":"https://api.github.com/users/diegohaz/orgs","repos_url":"https://api.github.com/users/diegohaz/repos","events_url":"https://api.github.com/users/diegohaz/events{/privacy}","received_events_url":"https://api.github.com/users/diegohaz/received_events","type":"User","site_admin":false},"repo":{"id":104133653,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQxMzM2NTM=","name":"reakit","full_name":"diegohaz/reakit","owner":{"login":"diegohaz","id":3068563,"node_id":"MDQ6VXNlcjMwNjg1NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/3068563?v=4","gravatar_id":"","url":"https://api.github.com/users/diegohaz","html_url":"https://github.com/diegohaz","followers_url":"https://api.github.com/users/diegohaz/followers","following_url":"https://api.github.com/users/diegohaz/following{/other_user}","gists_url":"https://api.github.com/users/diegohaz/gists{/gist_id}","starred_url":"https://api.github.com/users/diegohaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diegohaz/subscriptions","organizations_url":"https://api.github.com/users/diegohaz/orgs","repos_url":"https://api.github.com/users/diegohaz/repos","events_url":"https://api.github.com/users/diegohaz/events{/privacy}","received_events_url":"https://api.github.com/users/diegohaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diegohaz/reakit","description":"Toolkit for building interactive UIs with React","fork":false,"url":"https://api.github.com/repos/diegohaz/reakit","forks_url":"https://api.github.com/repos/diegohaz/reakit/forks","keys_url":"https://api.github.com/repos/diegohaz/reakit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diegohaz/reakit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diegohaz/reakit/teams","hooks_url":"https://api.github.com/repos/diegohaz/reakit/hooks","issue_events_url":"https://api.github.com/repos/diegohaz/reakit/issues/events{/number}","events_url":"https://api.github.com/repos/diegohaz/reakit/events","assignees_url":"https://api.github.com/repos/diegohaz/reakit/assignees{/user}","branches_url":"https://api.github.com/repos/diegohaz/reakit/branches{/branch}","tags_url":"https://api.github.com/repos/diegohaz/reakit/tags","blobs_url":"https://api.github.com/repos/diegohaz/reakit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diegohaz/reakit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diegohaz/reakit/git/refs{/sha}","trees_url":"https://api.github.com/repos/diegohaz/reakit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diegohaz/reakit/statuses/{sha}","languages_url":"https://api.github.com/repos/diegohaz/reakit/languages","stargazers_url":"https://api.github.com/repos/diegohaz/reakit/stargazers","contributors_url":"https://api.github.com/repos/diegohaz/reakit/contributors","subscribers_url":"https://api.github.com/repos/diegohaz/reakit/subscribers","subscription_url":"https://api.github.com/repos/diegohaz/reakit/subscription","commits_url":"https://api.github.com/repos/diegohaz/reakit/commits{/sha}","git_commits_url":"https://api.github.com/repos/diegohaz/reakit/git/commits{/sha}","comments_url":"https://api.github.com/repos/diegohaz/reakit/comments{/number}","issue_comment_url":"https://api.github.com/repos/diegohaz/reakit/issues/comments{/number}","contents_url":"https://api.github.com/repos/diegohaz/reakit/contents/{+path}","compare_url":"https://api.github.com/repos/diegohaz/reakit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diegohaz/reakit/merges","archive_url":"https://api.github.com/repos/diegohaz/reakit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diegohaz/reakit/downloads","issues_url":"https://api.github.com/repos/diegohaz/reakit/issues{/number}","pulls_url":"https://api.github.com/repos/diegohaz/reakit/pulls{/number}","milestones_url":"https://api.github.com/repos/diegohaz/reakit/milestones{/number}","notifications_url":"https://api.github.com/repos/diegohaz/reakit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diegohaz/reakit/labels{/name}","releases_url":"https://api.github.com/repos/diegohaz/reakit/releases{/id}","deployments_url":"https://api.github.com/repos/diegohaz/reakit/deployments","created_at":"2017-09-19T22:00:42Z","updated_at":"2018-07-14T17:08:11Z","pushed_at":"2018-07-14T17:26:05Z","git_url":"git://github.com/diegohaz/reakit.git","ssh_url":"git@github.com:diegohaz/reakit.git","clone_url":"https://github.com/diegohaz/reakit.git","svn_url":"https://github.com/diegohaz/reakit","homepage":"https://reakit.io","size":5011,"stargazers_count":637,"watchers_count":637,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":47,"open_issues":17,"watchers":637,"default_branch":"master"}},"base":{"label":"diegohaz:master","ref":"master","sha":"250c66ab2838d3dc3a6290b79eed1523a93a0e79","user":{"login":"diegohaz","id":3068563,"node_id":"MDQ6VXNlcjMwNjg1NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/3068563?v=4","gravatar_id":"","url":"https://api.github.com/users/diegohaz","html_url":"https://github.com/diegohaz","followers_url":"https://api.github.com/users/diegohaz/followers","following_url":"https://api.github.com/users/diegohaz/following{/other_user}","gists_url":"https://api.github.com/users/diegohaz/gists{/gist_id}","starred_url":"https://api.github.com/users/diegohaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diegohaz/subscriptions","organizations_url":"https://api.github.com/users/diegohaz/orgs","repos_url":"https://api.github.com/users/diegohaz/repos","events_url":"https://api.github.com/users/diegohaz/events{/privacy}","received_events_url":"https://api.github.com/users/diegohaz/received_events","type":"User","site_admin":false},"repo":{"id":104133653,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQxMzM2NTM=","name":"reakit","full_name":"diegohaz/reakit","owner":{"login":"diegohaz","id":3068563,"node_id":"MDQ6VXNlcjMwNjg1NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/3068563?v=4","gravatar_id":"","url":"https://api.github.com/users/diegohaz","html_url":"https://github.com/diegohaz","followers_url":"https://api.github.com/users/diegohaz/followers","following_url":"https://api.github.com/users/diegohaz/following{/other_user}","gists_url":"https://api.github.com/users/diegohaz/gists{/gist_id}","starred_url":"https://api.github.com/users/diegohaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diegohaz/subscriptions","organizations_url":"https://api.github.com/users/diegohaz/orgs","repos_url":"https://api.github.com/users/diegohaz/repos","events_url":"https://api.github.com/users/diegohaz/events{/privacy}","received_events_url":"https://api.github.com/users/diegohaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/diegohaz/reakit","description":"Toolkit for building interactive UIs with React","fork":false,"url":"https://api.github.com/repos/diegohaz/reakit","forks_url":"https://api.github.com/repos/diegohaz/reakit/forks","keys_url":"https://api.github.com/repos/diegohaz/reakit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diegohaz/reakit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diegohaz/reakit/teams","hooks_url":"https://api.github.com/repos/diegohaz/reakit/hooks","issue_events_url":"https://api.github.com/repos/diegohaz/reakit/issues/events{/number}","events_url":"https://api.github.com/repos/diegohaz/reakit/events","assignees_url":"https://api.github.com/repos/diegohaz/reakit/assignees{/user}","branches_url":"https://api.github.com/repos/diegohaz/reakit/branches{/branch}","tags_url":"https://api.github.com/repos/diegohaz/reakit/tags","blobs_url":"https://api.github.com/repos/diegohaz/reakit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diegohaz/reakit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diegohaz/reakit/git/refs{/sha}","trees_url":"https://api.github.com/repos/diegohaz/reakit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diegohaz/reakit/statuses/{sha}","languages_url":"https://api.github.com/repos/diegohaz/reakit/languages","stargazers_url":"https://api.github.com/repos/diegohaz/reakit/stargazers","contributors_url":"https://api.github.com/repos/diegohaz/reakit/contributors","subscribers_url":"https://api.github.com/repos/diegohaz/reakit/subscribers","subscription_url":"https://api.github.com/repos/diegohaz/reakit/subscription","commits_url":"https://api.github.com/repos/diegohaz/reakit/commits{/sha}","git_commits_url":"https://api.github.com/repos/diegohaz/reakit/git/commits{/sha}","comments_url":"https://api.github.com/repos/diegohaz/reakit/comments{/number}","issue_comment_url":"https://api.github.com/repos/diegohaz/reakit/issues/comments{/number}","contents_url":"https://api.github.com/repos/diegohaz/reakit/contents/{+path}","compare_url":"https://api.github.com/repos/diegohaz/reakit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diegohaz/reakit/merges","archive_url":"https://api.github.com/repos/diegohaz/reakit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diegohaz/reakit/downloads","issues_url":"https://api.github.com/repos/diegohaz/reakit/issues{/number}","pulls_url":"https://api.github.com/repos/diegohaz/reakit/pulls{/number}","milestones_url":"https://api.github.com/repos/diegohaz/reakit/milestones{/number}","notifications_url":"https://api.github.com/repos/diegohaz/reakit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diegohaz/reakit/labels{/name}","releases_url":"https://api.github.com/repos/diegohaz/reakit/releases{/id}","deployments_url":"https://api.github.com/repos/diegohaz/reakit/deployments","created_at":"2017-09-19T22:00:42Z","updated_at":"2018-07-14T17:08:11Z","pushed_at":"2018-07-14T17:26:05Z","git_url":"git://github.com/diegohaz/reakit.git","ssh_url":"git@github.com:diegohaz/reakit.git","clone_url":"https://github.com/diegohaz/reakit.git","svn_url":"https://github.com/diegohaz/reakit","homepage":"https://reakit.io","size":5011,"stargazers_count":637,"watchers_count":637,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":47,"open_issues":17,"watchers":637,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/diegohaz/reakit/pulls/146"},"html":{"href":"https://github.com/diegohaz/reakit/pull/146"},"issue":{"href":"https://api.github.com/repos/diegohaz/reakit/issues/146"},"comments":{"href":"https://api.github.com/repos/diegohaz/reakit/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/diegohaz/reakit/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/diegohaz/reakit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diegohaz/reakit/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/diegohaz/reakit/statuses/02c113882a3f9690cccbd0f41353efc301156ae7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"wordofchristian"}}