{"action":"created","issue":{"url":"https://api.github.com/repos/kubeflow/kubeflow/issues/881","repository_url":"https://api.github.com/repos/kubeflow/kubeflow","labels_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/881/labels{/name}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/881/comments","events_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/881/events","html_url":"https://github.com/kubeflow/kubeflow/pull/881","id":326691804,"number":881,"title":"Update kubeform_spawner.py","user":{"login":"pdmack","id":2380545,"avatar_url":"https://avatars0.githubusercontent.com/u/2380545?v=4","gravatar_id":"","url":"https://api.github.com/users/pdmack","html_url":"https://github.com/pdmack","followers_url":"https://api.github.com/users/pdmack/followers","following_url":"https://api.github.com/users/pdmack/following{/other_user}","gists_url":"https://api.github.com/users/pdmack/gists{/gist_id}","starred_url":"https://api.github.com/users/pdmack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdmack/subscriptions","organizations_url":"https://api.github.com/users/pdmack/orgs","repos_url":"https://api.github.com/users/pdmack/repos","events_url":"https://api.github.com/users/pdmack/events{/privacy}","received_events_url":"https://api.github.com/users/pdmack/received_events","type":"User","site_admin":false},"labels":[{"id":796413694,"url":"https://api.github.com/repos/kubeflow/kubeflow/labels/size/XS","name":"size/XS","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":{"login":"jlewi","id":777219,"avatar_url":"https://avatars3.githubusercontent.com/u/777219?v=4","gravatar_id":"","url":"https://api.github.com/users/jlewi","html_url":"https://github.com/jlewi","followers_url":"https://api.github.com/users/jlewi/followers","following_url":"https://api.github.com/users/jlewi/following{/other_user}","gists_url":"https://api.github.com/users/jlewi/gists{/gist_id}","starred_url":"https://api.github.com/users/jlewi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlewi/subscriptions","organizations_url":"https://api.github.com/users/jlewi/orgs","repos_url":"https://api.github.com/users/jlewi/repos","events_url":"https://api.github.com/users/jlewi/events{/privacy}","received_events_url":"https://api.github.com/users/jlewi/received_events","type":"User","site_admin":false},"assignees":[{"login":"jlewi","id":777219,"avatar_url":"https://avatars3.githubusercontent.com/u/777219?v=4","gravatar_id":"","url":"https://api.github.com/users/jlewi","html_url":"https://github.com/jlewi","followers_url":"https://api.github.com/users/jlewi/followers","following_url":"https://api.github.com/users/jlewi/following{/other_user}","gists_url":"https://api.github.com/users/jlewi/gists{/gist_id}","starred_url":"https://api.github.com/users/jlewi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlewi/subscriptions","organizations_url":"https://api.github.com/users/jlewi/orgs","repos_url":"https://api.github.com/users/jlewi/repos","events_url":"https://api.github.com/users/jlewi/events{/privacy}","received_events_url":"https://api.github.com/users/jlewi/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-05-25T23:55:31Z","updated_at":"2018-05-26T01:08:40Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/881","html_url":"https://github.com/kubeflow/kubeflow/pull/881","diff_url":"https://github.com/kubeflow/kubeflow/pull/881.diff","patch_url":"https://github.com/kubeflow/kubeflow/pull/881.patch"},"body":"Now that this is vendor-ed elsewhere (e.g., kubeflow/testing) we need to guard against pylint failures. A different issue should address pylint corrections.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/kubeflow/881)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/kubeflow/kubeflow/issues/comments/392223982","html_url":"https://github.com/kubeflow/kubeflow/pull/881#issuecomment-392223982","issue_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/881","id":392223982,"user":{"login":"jlewi","id":777219,"avatar_url":"https://avatars3.githubusercontent.com/u/777219?v=4","gravatar_id":"","url":"https://api.github.com/users/jlewi","html_url":"https://github.com/jlewi","followers_url":"https://api.github.com/users/jlewi/followers","following_url":"https://api.github.com/users/jlewi/following{/other_user}","gists_url":"https://api.github.com/users/jlewi/gists{/gist_id}","starred_url":"https://api.github.com/users/jlewi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlewi/subscriptions","organizations_url":"https://api.github.com/users/jlewi/orgs","repos_url":"https://api.github.com/users/jlewi/repos","events_url":"https://api.github.com/users/jlewi/events{/privacy}","received_events_url":"https://api.github.com/users/jlewi/received_events","type":"User","site_admin":false},"created_at":"2018-05-26T01:08:40Z","updated_at":"2018-05-26T01:08:40Z","author_association":"CONTRIBUTOR","body":"Would it be better to configure our lint checks to ignore vendor directories?\r\n\r\nThis is the script we use for lint \r\nhttps://github.com/kubeflow/testing/blob/master/py/kubeflow/testing/test_py_lint.py#L38\r\n\r\nCould we just update that script so we don't recurse into vendor directories?"}}
{"actor":{"display_login":"jlewi"}}