{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/klog/issues/19","repository_url":"https://api.github.com/repos/kubernetes/klog","labels_url":"https://api.github.com/repos/kubernetes/klog/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/klog/issues/19/comments","events_url":"https://api.github.com/repos/kubernetes/klog/issues/19/events","html_url":"https://github.com/kubernetes/klog/issues/19","id":380937736,"node_id":"MDU6SXNzdWUzODA5Mzc3MzY=","number":19,"title":"Interface based approach","user":{"login":"vincepri","id":3118335,"node_id":"MDQ6VXNlcjMxMTgzMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3118335?v=4","gravatar_id":"","url":"https://api.github.com/users/vincepri","html_url":"https://github.com/vincepri","followers_url":"https://api.github.com/users/vincepri/followers","following_url":"https://api.github.com/users/vincepri/following{/other_user}","gists_url":"https://api.github.com/users/vincepri/gists{/gist_id}","starred_url":"https://api.github.com/users/vincepri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincepri/subscriptions","organizations_url":"https://api.github.com/users/vincepri/orgs","repos_url":"https://api.github.com/users/vincepri/repos","events_url":"https://api.github.com/users/vincepri/events{/privacy}","received_events_url":"https://api.github.com/users/vincepri/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-14T23:48:20Z","updated_at":"2018-11-15T00:32:05Z","closed_at":null,"author_association":"MEMBER","body":"We should consider offering interfaces for to allow third-party implementations and allow custom sinks. This issue can serve as umbrella for proposals / thoughts.\r\n\r\n> This issue was initially raised on the mailing list https://groups.google.com/d/msg/kubernetes-sig-architecture/wCWiWf3Juzs/nLtAC41tCwAJ."},"comment":{"url":"https://api.github.com/repos/kubernetes/klog/issues/comments/438870462","html_url":"https://github.com/kubernetes/klog/issues/19#issuecomment-438870462","issue_url":"https://api.github.com/repos/kubernetes/klog/issues/19","id":438870462,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODg3MDQ2Mg==","user":{"login":"munnerz","id":203583,"node_id":"MDQ6VXNlcjIwMzU4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/203583?v=4","gravatar_id":"","url":"https://api.github.com/users/munnerz","html_url":"https://github.com/munnerz","followers_url":"https://api.github.com/users/munnerz/followers","following_url":"https://api.github.com/users/munnerz/following{/other_user}","gists_url":"https://api.github.com/users/munnerz/gists{/gist_id}","starred_url":"https://api.github.com/users/munnerz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munnerz/subscriptions","organizations_url":"https://api.github.com/users/munnerz/orgs","repos_url":"https://api.github.com/users/munnerz/repos","events_url":"https://api.github.com/users/munnerz/events{/privacy}","received_events_url":"https://api.github.com/users/munnerz/received_events","type":"User","site_admin":false},"created_at":"2018-11-15T00:32:05Z","updated_at":"2018-11-15T00:32:05Z","author_association":"MEMBER","body":"I got started on adding a SetLogger function as a PoC for this after talking with @dims earlier.\r\n\r\nThe PR is focused around `github.com/go-logr/log`, and behaves similarly to `klog.SetOutput`.\r\n\r\nI couldn't work out a way to avoid changing the public facing API for the `Verbose` type however, without creating distinct types for each V level (which would mean we couldn't support arbitrary V levels).\r\n\r\nKeen to hear thoughts on the implementation/design. It seems useful to have something like this whilst kubernetes itself doesn't support a more structured log format/is still transitioning to whatever log package comes next."}}
{"actor":{"display_login":"munnerz"}}