{"action":"created","issue":{"url":"https://api.github.com/repos/tensorflow/tensorflow/issues/18293","repository_url":"https://api.github.com/repos/tensorflow/tensorflow","labels_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/18293/labels{/name}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/18293/comments","events_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/18293/events","html_url":"https://github.com/tensorflow/tensorflow/pull/18293","id":311945164,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc5OTI1NDgw","number":18293,"title":"[XLA/AOT] Build LLVM with Bazel on Windows","user":{"login":"rongjiecomputer","id":13115060,"node_id":"MDQ6VXNlcjEzMTE1MDYw","avatar_url":"https://avatars2.githubusercontent.com/u/13115060?v=4","gravatar_id":"","url":"https://api.github.com/users/rongjiecomputer","html_url":"https://github.com/rongjiecomputer","followers_url":"https://api.github.com/users/rongjiecomputer/followers","following_url":"https://api.github.com/users/rongjiecomputer/following{/other_user}","gists_url":"https://api.github.com/users/rongjiecomputer/gists{/gist_id}","starred_url":"https://api.github.com/users/rongjiecomputer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rongjiecomputer/subscriptions","organizations_url":"https://api.github.com/users/rongjiecomputer/orgs","repos_url":"https://api.github.com/users/rongjiecomputer/repos","events_url":"https://api.github.com/users/rongjiecomputer/events{/privacy}","received_events_url":"https://api.github.com/users/rongjiecomputer/received_events","type":"User","site_admin":false},"labels":[{"id":300136587,"node_id":"MDU6TGFiZWwzMDAxMzY1ODc=","url":"https://api.github.com/repos/tensorflow/tensorflow/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":987666414,"node_id":"MDU6TGFiZWw5ODc2NjY0MTQ=","url":"https://api.github.com/repos/tensorflow/tensorflow/labels/ready%20to%20pull","name":"ready to pull","color":"2cd643","default":false}],"state":"open","locked":false,"assignee":{"login":"gunan","id":7946809,"node_id":"MDQ6VXNlcjc5NDY4MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/7946809?v=4","gravatar_id":"","url":"https://api.github.com/users/gunan","html_url":"https://github.com/gunan","followers_url":"https://api.github.com/users/gunan/followers","following_url":"https://api.github.com/users/gunan/following{/other_user}","gists_url":"https://api.github.com/users/gunan/gists{/gist_id}","starred_url":"https://api.github.com/users/gunan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunan/subscriptions","organizations_url":"https://api.github.com/users/gunan/orgs","repos_url":"https://api.github.com/users/gunan/repos","events_url":"https://api.github.com/users/gunan/events{/privacy}","received_events_url":"https://api.github.com/users/gunan/received_events","type":"User","site_admin":false},"assignees":[{"login":"gunan","id":7946809,"node_id":"MDQ6VXNlcjc5NDY4MDk=","avatar_url":"https://avatars3.githubusercontent.com/u/7946809?v=4","gravatar_id":"","url":"https://api.github.com/users/gunan","html_url":"https://github.com/gunan","followers_url":"https://api.github.com/users/gunan/followers","following_url":"https://api.github.com/users/gunan/following{/other_user}","gists_url":"https://api.github.com/users/gunan/gists{/gist_id}","starred_url":"https://api.github.com/users/gunan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunan/subscriptions","organizations_url":"https://api.github.com/users/gunan/orgs","repos_url":"https://api.github.com/users/gunan/repos","events_url":"https://api.github.com/users/gunan/events{/privacy}","received_events_url":"https://api.github.com/users/gunan/received_events","type":"User","site_admin":false}],"milestone":null,"comments":26,"created_at":"2018-04-06T11:44:05Z","updated_at":"2018-08-09T02:51:45Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/18293","html_url":"https://github.com/tensorflow/tensorflow/pull/18293","diff_url":"https://github.com/tensorflow/tensorflow/pull/18293.diff","patch_url":"https://github.com/tensorflow/tensorflow/pull/18293.patch"},"body":"I previously use hacky BUILD file to import prebuilt LLVM binaries from CMake to Bazel so that I can build `tfcompile` with Bazel on Windows, but since Tensorflow updates the LLVM revision used very frequently, this method is too troublesome.\r\n\r\nI am trying to make XLA/AOT to work out-of-the-box on Windows with Bazel, then convince Tensorflow team to create a presubmit so that no one can break XLA/AOT on Windows anymore.\r\n\r\nSummary:\r\n\r\n- Remove unused `llvm_host_triple`.\r\n- Rename `cmake_vars` to `posix_cmake_vars` and create a new `win32_cmake_vars` as Windows is sufficiently different from other platforms.\r\n- Create `LLVM_DEFINES`, `LLVM_COPTS` and `LLVM_LINKOPTS` in `llvm.bzl` to set global compile/link flags for LLVM.\r\n- Create macro `llvm_cc_library` that wrap around `cc_library` to ensure that all targets receive `LLVM_COPTS` consistently. Replace all `cc_library` with `llvm_cc_library`.\r\n- For `support` library, include `lib/Support/Windows/*` for Windows and `lib/Support/Unix/*` for others.\r\n\r\n If `llvm.BUILD` is not to be edited manually no matter what, can the script used to generate `llvm.BUILD` be open-sourced?\r\n\r\n#15213\r\n\r\n/cc @tatatodd "},"comment":{"url":"https://api.github.com/repos/tensorflow/tensorflow/issues/comments/411619826","html_url":"https://github.com/tensorflow/tensorflow/pull/18293#issuecomment-411619826","issue_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/18293","id":411619826,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTYxOTgyNg==","user":{"login":"drpngx","id":20959853,"node_id":"MDQ6VXNlcjIwOTU5ODUz","avatar_url":"https://avatars1.githubusercontent.com/u/20959853?v=4","gravatar_id":"","url":"https://api.github.com/users/drpngx","html_url":"https://github.com/drpngx","followers_url":"https://api.github.com/users/drpngx/followers","following_url":"https://api.github.com/users/drpngx/following{/other_user}","gists_url":"https://api.github.com/users/drpngx/gists{/gist_id}","starred_url":"https://api.github.com/users/drpngx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drpngx/subscriptions","organizations_url":"https://api.github.com/users/drpngx/orgs","repos_url":"https://api.github.com/users/drpngx/repos","events_url":"https://api.github.com/users/drpngx/events{/privacy}","received_events_url":"https://api.github.com/users/drpngx/received_events","type":"User","site_admin":false},"created_at":"2018-08-09T02:51:45Z","updated_at":"2018-08-09T02:51:45Z","author_association":"MEMBER","body":"From the history, it looked like @sanjoy applied it in several commits -- I did not check carefully, but our tools returned an empty diff.\r\n\r\n@rongjiecomputer could you pull rebase and push again?\r\n\r\n@sanjoy maybe you can clarify?"}}
{"actor":{"display_login":"drpngx"}}