{"action":"opened","number":42,"pull_request":{"url":"https://api.github.com/repos/ethereum/eth-abi/pulls/42","id":177160968,"html_url":"https://github.com/ethereum/eth-abi/pull/42","diff_url":"https://github.com/ethereum/eth-abi/pull/42.diff","patch_url":"https://github.com/ethereum/eth-abi/pull/42.patch","issue_url":"https://api.github.com/repos/ethereum/eth-abi/issues/42","number":42,"state":"open","locked":false,"title":"Experimental (crazy) approach to allowing extensible parsing","user":{"login":"davesque","id":791437,"avatar_url":"https://avatars2.githubusercontent.com/u/791437?v=4","gravatar_id":"","url":"https://api.github.com/users/davesque","html_url":"https://github.com/davesque","followers_url":"https://api.github.com/users/davesque/followers","following_url":"https://api.github.com/users/davesque/following{/other_user}","gists_url":"https://api.github.com/users/davesque/gists{/gist_id}","starred_url":"https://api.github.com/users/davesque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davesque/subscriptions","organizations_url":"https://api.github.com/users/davesque/orgs","repos_url":"https://api.github.com/users/davesque/repos","events_url":"https://api.github.com/users/davesque/events{/privacy}","received_events_url":"https://api.github.com/users/davesque/received_events","type":"User","site_admin":false},"body":"Just some ideas for how we could implement extensible parsing.\r\n\r\n### What was wrong?\r\n\r\nWas trying to figure out interesting methods of extensibility for the eth-abi library.\r\n\r\n### How was it fixed?\r\n\r\nAdded a parser defined with `parsimonious` library and included the beginnings of some functionality for extending that parser.\r\n\r\nIt might be possible to allow users to define their own parsing rules for types which can't be parsed with our default grammar.  They could then create a subclass of `ABIType` to handle the processing of parse results for those rules.  The `ABIType.from_node` static method iterates through all subclasses of `ABIType` (the ordering, I believe, goes from most recently defined to least recently defined) to find one which can handle the parsing results for a certain rule (identified by the `expr_name` property on a parsimonious parse node).  `ABIType` subclasses indicate their associated grammar rule via the `expr_name` class property.  They must implement `from_node` as a class method in order to produce an instance of themselves according to the results of their associated parse rule.\r\n\r\n#### Cute Animal Picture\r\n\r\n![Cute animal picture](https://www.zoo.org.au/sites/default/files/styles/zv_carousel_large/public/platypus-dry-animal-profile-web620.jpg)\r\n","created_at":"2018-03-23T19:12:41Z","updated_at":"2018-03-23T19:12:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":858133544,"url":"https://api.github.com/repos/ethereum/eth-abi/labels/Work%20in%20Progress","name":"Work in Progress","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/eth-abi/pulls/42/commits","review_comments_url":"https://api.github.com/repos/ethereum/eth-abi/pulls/42/comments","review_comment_url":"https://api.github.com/repos/ethereum/eth-abi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/eth-abi/issues/42/comments","statuses_url":"https://api.github.com/repos/ethereum/eth-abi/statuses/788e2d51f352f8f1986afe400404edf52a90248d","head":{"label":"davesque:extensible-grammar","ref":"extensible-grammar","sha":"788e2d51f352f8f1986afe400404edf52a90248d","user":{"login":"davesque","id":791437,"avatar_url":"https://avatars2.githubusercontent.com/u/791437?v=4","gravatar_id":"","url":"https://api.github.com/users/davesque","html_url":"https://github.com/davesque","followers_url":"https://api.github.com/users/davesque/followers","following_url":"https://api.github.com/users/davesque/following{/other_user}","gists_url":"https://api.github.com/users/davesque/gists{/gist_id}","starred_url":"https://api.github.com/users/davesque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davesque/subscriptions","organizations_url":"https://api.github.com/users/davesque/orgs","repos_url":"https://api.github.com/users/davesque/repos","events_url":"https://api.github.com/users/davesque/events{/privacy}","received_events_url":"https://api.github.com/users/davesque/received_events","type":"User","site_admin":false},"repo":{"id":125083717,"name":"eth-abi","full_name":"davesque/eth-abi","owner":{"login":"davesque","id":791437,"avatar_url":"https://avatars2.githubusercontent.com/u/791437?v=4","gravatar_id":"","url":"https://api.github.com/users/davesque","html_url":"https://github.com/davesque","followers_url":"https://api.github.com/users/davesque/followers","following_url":"https://api.github.com/users/davesque/following{/other_user}","gists_url":"https://api.github.com/users/davesque/gists{/gist_id}","starred_url":"https://api.github.com/users/davesque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davesque/subscriptions","organizations_url":"https://api.github.com/users/davesque/orgs","repos_url":"https://api.github.com/users/davesque/repos","events_url":"https://api.github.com/users/davesque/events{/privacy}","received_events_url":"https://api.github.com/users/davesque/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davesque/eth-abi","description":"Ethereum ABI utilities for python","fork":true,"url":"https://api.github.com/repos/davesque/eth-abi","forks_url":"https://api.github.com/repos/davesque/eth-abi/forks","keys_url":"https://api.github.com/repos/davesque/eth-abi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davesque/eth-abi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davesque/eth-abi/teams","hooks_url":"https://api.github.com/repos/davesque/eth-abi/hooks","issue_events_url":"https://api.github.com/repos/davesque/eth-abi/issues/events{/number}","events_url":"https://api.github.com/repos/davesque/eth-abi/events","assignees_url":"https://api.github.com/repos/davesque/eth-abi/assignees{/user}","branches_url":"https://api.github.com/repos/davesque/eth-abi/branches{/branch}","tags_url":"https://api.github.com/repos/davesque/eth-abi/tags","blobs_url":"https://api.github.com/repos/davesque/eth-abi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davesque/eth-abi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davesque/eth-abi/git/refs{/sha}","trees_url":"https://api.github.com/repos/davesque/eth-abi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davesque/eth-abi/statuses/{sha}","languages_url":"https://api.github.com/repos/davesque/eth-abi/languages","stargazers_url":"https://api.github.com/repos/davesque/eth-abi/stargazers","contributors_url":"https://api.github.com/repos/davesque/eth-abi/contributors","subscribers_url":"https://api.github.com/repos/davesque/eth-abi/subscribers","subscription_url":"https://api.github.com/repos/davesque/eth-abi/subscription","commits_url":"https://api.github.com/repos/davesque/eth-abi/commits{/sha}","git_commits_url":"https://api.github.com/repos/davesque/eth-abi/git/commits{/sha}","comments_url":"https://api.github.com/repos/davesque/eth-abi/comments{/number}","issue_comment_url":"https://api.github.com/repos/davesque/eth-abi/issues/comments{/number}","contents_url":"https://api.github.com/repos/davesque/eth-abi/contents/{+path}","compare_url":"https://api.github.com/repos/davesque/eth-abi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davesque/eth-abi/merges","archive_url":"https://api.github.com/repos/davesque/eth-abi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davesque/eth-abi/downloads","issues_url":"https://api.github.com/repos/davesque/eth-abi/issues{/number}","pulls_url":"https://api.github.com/repos/davesque/eth-abi/pulls{/number}","milestones_url":"https://api.github.com/repos/davesque/eth-abi/milestones{/number}","notifications_url":"https://api.github.com/repos/davesque/eth-abi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davesque/eth-abi/labels{/name}","releases_url":"https://api.github.com/repos/davesque/eth-abi/releases{/id}","deployments_url":"https://api.github.com/repos/davesque/eth-abi/deployments","created_at":"2018-03-13T16:42:46Z","updated_at":"2018-03-20T23:31:19Z","pushed_at":"2018-03-23T19:01:10Z","git_url":"git://github.com/davesque/eth-abi.git","ssh_url":"git@github.com:davesque/eth-abi.git","clone_url":"https://github.com/davesque/eth-abi.git","svn_url":"https://github.com/davesque/eth-abi","homepage":null,"size":320,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"5c576202fafee3a8bff43be21e36ba9ba615b09a","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":52113942,"name":"eth-abi","full_name":"ethereum/eth-abi","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/eth-abi","description":"Ethereum ABI utilities for python","fork":false,"url":"https://api.github.com/repos/ethereum/eth-abi","forks_url":"https://api.github.com/repos/ethereum/eth-abi/forks","keys_url":"https://api.github.com/repos/ethereum/eth-abi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/eth-abi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/eth-abi/teams","hooks_url":"https://api.github.com/repos/ethereum/eth-abi/hooks","issue_events_url":"https://api.github.com/repos/ethereum/eth-abi/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/eth-abi/events","assignees_url":"https://api.github.com/repos/ethereum/eth-abi/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/eth-abi/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/eth-abi/tags","blobs_url":"https://api.github.com/repos/ethereum/eth-abi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/eth-abi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/eth-abi/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/eth-abi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/eth-abi/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/eth-abi/languages","stargazers_url":"https://api.github.com/repos/ethereum/eth-abi/stargazers","contributors_url":"https://api.github.com/repos/ethereum/eth-abi/contributors","subscribers_url":"https://api.github.com/repos/ethereum/eth-abi/subscribers","subscription_url":"https://api.github.com/repos/ethereum/eth-abi/subscription","commits_url":"https://api.github.com/repos/ethereum/eth-abi/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/eth-abi/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/eth-abi/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/eth-abi/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/eth-abi/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/eth-abi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/eth-abi/merges","archive_url":"https://api.github.com/repos/ethereum/eth-abi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/eth-abi/downloads","issues_url":"https://api.github.com/repos/ethereum/eth-abi/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/eth-abi/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/eth-abi/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/eth-abi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/eth-abi/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/eth-abi/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/eth-abi/deployments","created_at":"2016-02-19T20:18:56Z","updated_at":"2018-03-23T12:32:27Z","pushed_at":"2018-03-22T18:44:50Z","git_url":"git://github.com/ethereum/eth-abi.git","ssh_url":"git@github.com:ethereum/eth-abi.git","clone_url":"https://github.com/ethereum/eth-abi.git","svn_url":"https://github.com/ethereum/eth-abi","homepage":null,"size":303,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":15,"open_issues":7,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/eth-abi/pulls/42"},"html":{"href":"https://github.com/ethereum/eth-abi/pull/42"},"issue":{"href":"https://api.github.com/repos/ethereum/eth-abi/issues/42"},"comments":{"href":"https://api.github.com/repos/ethereum/eth-abi/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/eth-abi/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/eth-abi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/eth-abi/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/eth-abi/statuses/788e2d51f352f8f1986afe400404edf52a90248d"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":117,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"davesque"}}