{"action":"created","issue":{"url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1497","repository_url":"https://api.github.com/repos/kubevirt/kubevirt","labels_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1497/labels{/name}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1497/comments","events_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1497/events","html_url":"https://github.com/kubevirt/kubevirt/pull/1497","id":357309115,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMzU2MTI3","number":1497,"title":"Add Kuryr and Genie CNIs","user":{"login":"yuvalif","id":1798418,"node_id":"MDQ6VXNlcjE3OTg0MTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1798418?v=4","gravatar_id":"","url":"https://api.github.com/users/yuvalif","html_url":"https://github.com/yuvalif","followers_url":"https://api.github.com/users/yuvalif/followers","following_url":"https://api.github.com/users/yuvalif/following{/other_user}","gists_url":"https://api.github.com/users/yuvalif/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvalif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvalif/subscriptions","organizations_url":"https://api.github.com/users/yuvalif/orgs","repos_url":"https://api.github.com/users/yuvalif/repos","events_url":"https://api.github.com/users/yuvalif/events{/privacy}","received_events_url":"https://api.github.com/users/yuvalif/received_events","type":"User","site_admin":false},"labels":[{"id":971140812,"node_id":"MDU6TGFiZWw5NzExNDA4MTI=","url":"https://api.github.com/repos/kubevirt/kubevirt/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":802030280,"node_id":"MDU6TGFiZWw4MDIwMzAyODA=","url":"https://api.github.com/repos/kubevirt/kubevirt/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-05T16:30:20Z","updated_at":"2018-09-06T06:31:19Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1497","html_url":"https://github.com/kubevirt/kubevirt/pull/1497","diff_url":"https://github.com/kubevirt/kubevirt/pull/1497.diff","patch_url":"https://github.com/kubevirt/kubevirt/pull/1497.patch"},"body":"This PR allows the VM to get multiple networks/interfaces via Multus, Kuryr or Genie CNIs.\r\n\r\n**Currently unit and functional tests are missing.**\r\n\r\nRelease Notes:\r\nTo add multiple networks/interfaces to a Virtual Machine Instance, sever options now exists:\r\n* For Multus add the following network definitions:\r\n```yaml\r\ncni:\r\n  multus: {}\r\n  networkName: net-a\r\nname: net-a\r\n```\r\nWhere, \"networkName\" is the name of the NetworkAttachment CRD to be used. In case of Multus, the actual network is provided by another CNI (flannel, weave etc.) that must be deployed beforehand.\r\n* For Genie add the following network definitions:\r\n```yaml\r\ncni:\r\n  genie: {}\r\n  networkName: flannel\r\nname: net-a\r\n```\r\nWhere, \"networkName\" is the name the actual CNI that would provide the network (flannel, weave etc.), and must be deployed beforehand.\r\n* For Kuryr add the following network definitions:\r\n```yaml\r\ncni:\r\n  kuryr: {}\r\n  networkName: net-a\r\nname: net-a\r\n```\r\nWhere, \"networkName\" is the name of the NetworkAttachment CRD to be used. Kuryr does not delegate the network definition to another CNI, and will provide the networking based on an existing openstack networking solution which has to be deployed beforehand.\r\n\r\nNote that only one of the above CNIs (multus, genie, kuryr) could be used.\r\nIn all cases, \"name\" is used as a reference in the \"interface\" definitions\r\n\r\n```release-note\r\nsee above\r\n```"},"comment":{"url":"https://api.github.com/repos/kubevirt/kubevirt/issues/comments/418980342","html_url":"https://github.com/kubevirt/kubevirt/pull/1497#issuecomment-418980342","issue_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1497","id":418980342,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODk4MDM0Mg==","user":{"login":"yuvalif","id":1798418,"node_id":"MDQ6VXNlcjE3OTg0MTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1798418?v=4","gravatar_id":"","url":"https://api.github.com/users/yuvalif","html_url":"https://github.com/yuvalif","followers_url":"https://api.github.com/users/yuvalif/followers","following_url":"https://api.github.com/users/yuvalif/following{/other_user}","gists_url":"https://api.github.com/users/yuvalif/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvalif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvalif/subscriptions","organizations_url":"https://api.github.com/users/yuvalif/orgs","repos_url":"https://api.github.com/users/yuvalif/repos","events_url":"https://api.github.com/users/yuvalif/events{/privacy}","received_events_url":"https://api.github.com/users/yuvalif/received_events","type":"User","site_admin":false},"created_at":"2018-09-06T06:31:19Z","updated_at":"2018-09-06T06:31:19Z","author_association":"CONTRIBUTOR","body":"> Our test matrix is going to explode if we have to have a different provider for each network and k8s/os version. I remember this being brought up briefly during a meeting at one point. Is there a plan for how to handle functional testing?\r\n\r\n@davidvossel for genie, we could probably reuse the multus provider. @SchSeba how difficult would that be?\r\nFor kuryr, I don't see how this could be automatic testing - openstack provider is probably out-of-the question. \r\n\r\nA different option would be to write a CNI simulator that would simulate the behavior for the different providers? Its not ideal, as we will have to make sure that the bugs are not there, but might be an acceptable compromise.\r\n"}}
{"actor":{"display_login":"yuvalif"}}