{"action":"created","issue":{"url":"https://api.github.com/repos/NCAR/VAPOR/issues/802","repository_url":"https://api.github.com/repos/NCAR/VAPOR","labels_url":"https://api.github.com/repos/NCAR/VAPOR/issues/802/labels{/name}","comments_url":"https://api.github.com/repos/NCAR/VAPOR/issues/802/comments","events_url":"https://api.github.com/repos/NCAR/VAPOR/issues/802/events","html_url":"https://github.com/NCAR/VAPOR/pull/802","id":320441637,"number":802,"title":"Issue 643","user":{"login":"shaomeng","id":814885,"avatar_url":"https://avatars0.githubusercontent.com/u/814885?v=4","gravatar_id":"","url":"https://api.github.com/users/shaomeng","html_url":"https://github.com/shaomeng","followers_url":"https://api.github.com/users/shaomeng/followers","following_url":"https://api.github.com/users/shaomeng/following{/other_user}","gists_url":"https://api.github.com/users/shaomeng/gists{/gist_id}","starred_url":"https://api.github.com/users/shaomeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaomeng/subscriptions","organizations_url":"https://api.github.com/users/shaomeng/orgs","repos_url":"https://api.github.com/users/shaomeng/repos","events_url":"https://api.github.com/users/shaomeng/events{/privacy}","received_events_url":"https://api.github.com/users/shaomeng/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-04T21:54:30Z","updated_at":"2018-05-08T02:53:47Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/NCAR/VAPOR/pulls/802","html_url":"https://github.com/NCAR/VAPOR/pull/802","diff_url":"https://github.com/NCAR/VAPOR/pull/802.diff","patch_url":"https://github.com/NCAR/VAPOR/pull/802.patch"},"body":"These changes should address issue #643. "},"comment":{"url":"https://api.github.com/repos/NCAR/VAPOR/issues/comments/387268537","html_url":"https://github.com/NCAR/VAPOR/pull/802#issuecomment-387268537","issue_url":"https://api.github.com/repos/NCAR/VAPOR/issues/802","id":387268537,"user":{"login":"shaomeng","id":814885,"avatar_url":"https://avatars0.githubusercontent.com/u/814885?v=4","gravatar_id":"","url":"https://api.github.com/users/shaomeng","html_url":"https://github.com/shaomeng","followers_url":"https://api.github.com/users/shaomeng/followers","following_url":"https://api.github.com/users/shaomeng/following{/other_user}","gists_url":"https://api.github.com/users/shaomeng/gists{/gist_id}","starred_url":"https://api.github.com/users/shaomeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaomeng/subscriptions","organizations_url":"https://api.github.com/users/shaomeng/orgs","repos_url":"https://api.github.com/users/shaomeng/repos","events_url":"https://api.github.com/users/shaomeng/events{/privacy}","received_events_url":"https://api.github.com/users/shaomeng/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T02:53:47Z","updated_at":"2018-05-08T02:53:47Z","author_association":"COLLABORATOR","body":"\" is there something special about the file dialogs here that warrants special attention? \"\r\n-- Well, the fact that we enforce a certain extension causes complication. This enforcement largely requires our implementation with just a little bit help from QT. This is what you see in this PR. Is this the special attention you're referring to? \r\n\r\n\"Didn't you write a FileOperationChecker class that we could use here?\"\r\n-- The FileOperationChecker class only tells you right or wrong, but does NOT fix any problem for you. The majority of code here is to fix any potential problems. \r\n\r\n\"The _chooseAutoSaveFile() and _autoSaveFileChanged() are largely cut-n-paste. Can't we use a helper function and eliminate code duplication?\" \r\n-- A helper function would be possible; but that helper function is only reused by 2 other functions, which are these two. Is it worth doing so? "}}
{"actor":{"display_login":"shaomeng"}}