{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/gradle-docker/pulls/comments/198670685","pull_request_review_id":132643828,"id":198670685,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODY3MDY4NQ==","diff_hunk":"@@ -0,0 +1,36 @@\n+package com.palantir.gradle.docker\n+\n+import groovy.util.logging.Slf4j\n+import org.gradle.api.DefaultTask\n+import org.gradle.api.artifacts.Configuration\n+import org.gradle.api.tasks.InputFiles\n+import org.gradle.api.tasks.TaskAction\n+\n+@Slf4j\n+class DockerComposeUp extends DefaultTask {","path":"src/main/groovy/com/palantir/gradle/docker/DockerComposeUp.groovy","position":10,"original_position":10,"commit_id":"a3f971b2bd849b26765dc21481e47221b63980c8","original_commit_id":"a3f971b2bd849b26765dc21481e47221b63980c8","user":{"login":"pkoenig10","id":5273164,"node_id":"MDQ6VXNlcjUyNzMxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5273164?v=4","gravatar_id":"","url":"https://api.github.com/users/pkoenig10","html_url":"https://github.com/pkoenig10","followers_url":"https://api.github.com/users/pkoenig10/followers","following_url":"https://api.github.com/users/pkoenig10/following{/other_user}","gists_url":"https://api.github.com/users/pkoenig10/gists{/gist_id}","starred_url":"https://api.github.com/users/pkoenig10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkoenig10/subscriptions","organizations_url":"https://api.github.com/users/pkoenig10/orgs","repos_url":"https://api.github.com/users/pkoenig10/repos","events_url":"https://api.github.com/users/pkoenig10/events{/privacy}","received_events_url":"https://api.github.com/users/pkoenig10/received_events","type":"User","site_admin":false},"body":"Is there best practices regarding defining a task in a separate groovy class vs directly in the plugin class? We do the latter in `PalantirDockerPlugin` although a separate class makes things cleaner.","created_at":"2018-06-27T23:29:33Z","updated_at":"2018-06-27T23:29:33Z","html_url":"https://github.com/palantir/gradle-docker/pull/186#discussion_r198670685","pull_request_url":"https://api.github.com/repos/palantir/gradle-docker/pulls/186","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/palantir/gradle-docker/pulls/comments/198670685"},"html":{"href":"https://github.com/palantir/gradle-docker/pull/186#discussion_r198670685"},"pull_request":{"href":"https://api.github.com/repos/palantir/gradle-docker/pulls/186"}},"in_reply_to_id":198669476},"pull_request":{"url":"https://api.github.com/repos/palantir/gradle-docker/pulls/186","id":197877284,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3ODc3Mjg0","html_url":"https://github.com/palantir/gradle-docker/pull/186","diff_url":"https://github.com/palantir/gradle-docker/pull/186.diff","patch_url":"https://github.com/palantir/gradle-docker/pull/186.patch","issue_url":"https://api.github.com/repos/palantir/gradle-docker/issues/186","number":186,"state":"open","locked":false,"title":"dockerComposeUp task","user":{"login":"samrogerson","id":687928,"node_id":"MDQ6VXNlcjY4NzkyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/687928?v=4","gravatar_id":"","url":"https://api.github.com/users/samrogerson","html_url":"https://github.com/samrogerson","followers_url":"https://api.github.com/users/samrogerson/followers","following_url":"https://api.github.com/users/samrogerson/following{/other_user}","gists_url":"https://api.github.com/users/samrogerson/gists{/gist_id}","starred_url":"https://api.github.com/users/samrogerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samrogerson/subscriptions","organizations_url":"https://api.github.com/users/samrogerson/orgs","repos_url":"https://api.github.com/users/samrogerson/repos","events_url":"https://api.github.com/users/samrogerson/events{/privacy}","received_events_url":"https://api.github.com/users/samrogerson/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-27T23:10:00Z","updated_at":"2018-06-27T23:29:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a197519213386be83bc4c7b173c333c5bb42dc0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/gradle-docker/pulls/186/commits","review_comments_url":"https://api.github.com/repos/palantir/gradle-docker/pulls/186/comments","review_comment_url":"https://api.github.com/repos/palantir/gradle-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/gradle-docker/issues/186/comments","statuses_url":"https://api.github.com/repos/palantir/gradle-docker/statuses/a3f971b2bd849b26765dc21481e47221b63980c8","head":{"label":"samrogerson:sr/docker-compose-up","ref":"sr/docker-compose-up","sha":"a3f971b2bd849b26765dc21481e47221b63980c8","user":{"login":"samrogerson","id":687928,"node_id":"MDQ6VXNlcjY4NzkyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/687928?v=4","gravatar_id":"","url":"https://api.github.com/users/samrogerson","html_url":"https://github.com/samrogerson","followers_url":"https://api.github.com/users/samrogerson/followers","following_url":"https://api.github.com/users/samrogerson/following{/other_user}","gists_url":"https://api.github.com/users/samrogerson/gists{/gist_id}","starred_url":"https://api.github.com/users/samrogerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samrogerson/subscriptions","organizations_url":"https://api.github.com/users/samrogerson/orgs","repos_url":"https://api.github.com/users/samrogerson/repos","events_url":"https://api.github.com/users/samrogerson/events{/privacy}","received_events_url":"https://api.github.com/users/samrogerson/received_events","type":"User","site_admin":false},"repo":{"id":138931468,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg5MzE0Njg=","name":"gradle-docker","full_name":"samrogerson/gradle-docker","owner":{"login":"samrogerson","id":687928,"node_id":"MDQ6VXNlcjY4NzkyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/687928?v=4","gravatar_id":"","url":"https://api.github.com/users/samrogerson","html_url":"https://github.com/samrogerson","followers_url":"https://api.github.com/users/samrogerson/followers","following_url":"https://api.github.com/users/samrogerson/following{/other_user}","gists_url":"https://api.github.com/users/samrogerson/gists{/gist_id}","starred_url":"https://api.github.com/users/samrogerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samrogerson/subscriptions","organizations_url":"https://api.github.com/users/samrogerson/orgs","repos_url":"https://api.github.com/users/samrogerson/repos","events_url":"https://api.github.com/users/samrogerson/events{/privacy}","received_events_url":"https://api.github.com/users/samrogerson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samrogerson/gradle-docker","description":"a Gradle plugin for orchestrating docker builds and pushes.","fork":true,"url":"https://api.github.com/repos/samrogerson/gradle-docker","forks_url":"https://api.github.com/repos/samrogerson/gradle-docker/forks","keys_url":"https://api.github.com/repos/samrogerson/gradle-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samrogerson/gradle-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samrogerson/gradle-docker/teams","hooks_url":"https://api.github.com/repos/samrogerson/gradle-docker/hooks","issue_events_url":"https://api.github.com/repos/samrogerson/gradle-docker/issues/events{/number}","events_url":"https://api.github.com/repos/samrogerson/gradle-docker/events","assignees_url":"https://api.github.com/repos/samrogerson/gradle-docker/assignees{/user}","branches_url":"https://api.github.com/repos/samrogerson/gradle-docker/branches{/branch}","tags_url":"https://api.github.com/repos/samrogerson/gradle-docker/tags","blobs_url":"https://api.github.com/repos/samrogerson/gradle-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samrogerson/gradle-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samrogerson/gradle-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/samrogerson/gradle-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samrogerson/gradle-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/samrogerson/gradle-docker/languages","stargazers_url":"https://api.github.com/repos/samrogerson/gradle-docker/stargazers","contributors_url":"https://api.github.com/repos/samrogerson/gradle-docker/contributors","subscribers_url":"https://api.github.com/repos/samrogerson/gradle-docker/subscribers","subscription_url":"https://api.github.com/repos/samrogerson/gradle-docker/subscription","commits_url":"https://api.github.com/repos/samrogerson/gradle-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/samrogerson/gradle-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/samrogerson/gradle-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/samrogerson/gradle-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/samrogerson/gradle-docker/contents/{+path}","compare_url":"https://api.github.com/repos/samrogerson/gradle-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samrogerson/gradle-docker/merges","archive_url":"https://api.github.com/repos/samrogerson/gradle-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samrogerson/gradle-docker/downloads","issues_url":"https://api.github.com/repos/samrogerson/gradle-docker/issues{/number}","pulls_url":"https://api.github.com/repos/samrogerson/gradle-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/samrogerson/gradle-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/samrogerson/gradle-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samrogerson/gradle-docker/labels{/name}","releases_url":"https://api.github.com/repos/samrogerson/gradle-docker/releases{/id}","deployments_url":"https://api.github.com/repos/samrogerson/gradle-docker/deployments","created_at":"2018-06-27T20:48:23Z","updated_at":"2018-06-27T20:48:25Z","pushed_at":"2018-06-27T23:06:43Z","git_url":"git://github.com/samrogerson/gradle-docker.git","ssh_url":"git@github.com:samrogerson/gradle-docker.git","clone_url":"https://github.com/samrogerson/gradle-docker.git","svn_url":"https://github.com/samrogerson/gradle-docker","homepage":null,"size":582,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"99911af5b35d9333e765d9d5c452c318405978fa","user":{"login":"palantir","id":303157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":42682769,"node_id":"MDEwOlJlcG9zaXRvcnk0MjY4Mjc2OQ==","name":"gradle-docker","full_name":"palantir/gradle-docker","owner":{"login":"palantir","id":303157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzE1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/gradle-docker","description":"a Gradle plugin for orchestrating docker builds and pushes.","fork":false,"url":"https://api.github.com/repos/palantir/gradle-docker","forks_url":"https://api.github.com/repos/palantir/gradle-docker/forks","keys_url":"https://api.github.com/repos/palantir/gradle-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/gradle-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/gradle-docker/teams","hooks_url":"https://api.github.com/repos/palantir/gradle-docker/hooks","issue_events_url":"https://api.github.com/repos/palantir/gradle-docker/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/gradle-docker/events","assignees_url":"https://api.github.com/repos/palantir/gradle-docker/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/gradle-docker/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/gradle-docker/tags","blobs_url":"https://api.github.com/repos/palantir/gradle-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/gradle-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/gradle-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/gradle-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/gradle-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/gradle-docker/languages","stargazers_url":"https://api.github.com/repos/palantir/gradle-docker/stargazers","contributors_url":"https://api.github.com/repos/palantir/gradle-docker/contributors","subscribers_url":"https://api.github.com/repos/palantir/gradle-docker/subscribers","subscription_url":"https://api.github.com/repos/palantir/gradle-docker/subscription","commits_url":"https://api.github.com/repos/palantir/gradle-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/gradle-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/gradle-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/gradle-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/gradle-docker/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/gradle-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/gradle-docker/merges","archive_url":"https://api.github.com/repos/palantir/gradle-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/gradle-docker/downloads","issues_url":"https://api.github.com/repos/palantir/gradle-docker/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/gradle-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/gradle-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/gradle-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/gradle-docker/labels{/name}","releases_url":"https://api.github.com/repos/palantir/gradle-docker/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/gradle-docker/deployments","created_at":"2015-09-17T21:24:35Z","updated_at":"2018-06-27T23:14:14Z","pushed_at":"2018-06-27T23:10:01Z","git_url":"git://github.com/palantir/gradle-docker.git","ssh_url":"git@github.com:palantir/gradle-docker.git","clone_url":"https://github.com/palantir/gradle-docker.git","svn_url":"https://github.com/palantir/gradle-docker","homepage":null,"size":580,"stargazers_count":198,"watchers_count":198,"language":"Groovy","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":61,"open_issues":46,"watchers":198,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/gradle-docker/pulls/186"},"html":{"href":"https://github.com/palantir/gradle-docker/pull/186"},"issue":{"href":"https://api.github.com/repos/palantir/gradle-docker/issues/186"},"comments":{"href":"https://api.github.com/repos/palantir/gradle-docker/issues/186/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/gradle-docker/pulls/186/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/gradle-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/gradle-docker/pulls/186/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/gradle-docker/statuses/a3f971b2bd849b26765dc21481e47221b63980c8"}},"author_association":"NONE"}}
{"actor":{"display_login":"pkoenig10"}}