{"action":"created","comment":{"url":"https://api.github.com/repos/dmlc/nnvm/pulls/comments/187799244","pull_request_review_id":119652975,"id":187799244,"diff_hunk":"@@ -202,6 +202,24 @@ class CompileEngine {\n       Array<Tensor> out = fcompute[inode.source->op()](\n           inode.source->attrs, op_inputs, out_info);\n       CHECK_EQ(out.size(), inode.source->num_outputs());\n+\n+      // check output dimentions also match\n+      // This check is to make sure the NNVM operator Infer match with Compute result.\n+      // Missing this check may pass the build but leads to runtime errors.\n+      for (uint32_t i=0; i < out.size(); i++) {","path":"src/compiler/compile_engine.cc","position":null,"original_position":8,"commit_id":"16f1ef818922bb0d269c922024edefacb8f787bf","original_commit_id":"3f07f13c5bb0c6c3b17ba9439a02d99d56156f38","user":{"login":"srkreddy1238","id":14215163,"avatar_url":"https://avatars2.githubusercontent.com/u/14215163?v=4","gravatar_id":"","url":"https://api.github.com/users/srkreddy1238","html_url":"https://github.com/srkreddy1238","followers_url":"https://api.github.com/users/srkreddy1238/followers","following_url":"https://api.github.com/users/srkreddy1238/following{/other_user}","gists_url":"https://api.github.com/users/srkreddy1238/gists{/gist_id}","starred_url":"https://api.github.com/users/srkreddy1238/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srkreddy1238/subscriptions","organizations_url":"https://api.github.com/users/srkreddy1238/orgs","repos_url":"https://api.github.com/users/srkreddy1238/repos","events_url":"https://api.github.com/users/srkreddy1238/events{/privacy}","received_events_url":"https://api.github.com/users/srkreddy1238/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-05-13T12:32:49Z","updated_at":"2018-05-13T12:32:49Z","html_url":"https://github.com/dmlc/nnvm/pull/476#discussion_r187799244","pull_request_url":"https://api.github.com/repos/dmlc/nnvm/pulls/476","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dmlc/nnvm/pulls/comments/187799244"},"html":{"href":"https://github.com/dmlc/nnvm/pull/476#discussion_r187799244"},"pull_request":{"href":"https://api.github.com/repos/dmlc/nnvm/pulls/476"}},"in_reply_to_id":187787503},"pull_request":{"url":"https://api.github.com/repos/dmlc/nnvm/pulls/476","id":187243628,"html_url":"https://github.com/dmlc/nnvm/pull/476","diff_url":"https://github.com/dmlc/nnvm/pull/476.diff","patch_url":"https://github.com/dmlc/nnvm/pull/476.patch","issue_url":"https://api.github.com/repos/dmlc/nnvm/issues/476","number":476,"state":"open","locked":false,"title":"Compile time sanity check to avoid runtime error.","user":{"login":"srkreddy1238","id":14215163,"avatar_url":"https://avatars2.githubusercontent.com/u/14215163?v=4","gravatar_id":"","url":"https://api.github.com/users/srkreddy1238","html_url":"https://github.com/srkreddy1238","followers_url":"https://api.github.com/users/srkreddy1238/followers","following_url":"https://api.github.com/users/srkreddy1238/following{/other_user}","gists_url":"https://api.github.com/users/srkreddy1238/gists{/gist_id}","starred_url":"https://api.github.com/users/srkreddy1238/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srkreddy1238/subscriptions","organizations_url":"https://api.github.com/users/srkreddy1238/orgs","repos_url":"https://api.github.com/users/srkreddy1238/repos","events_url":"https://api.github.com/users/srkreddy1238/events{/privacy}","received_events_url":"https://api.github.com/users/srkreddy1238/received_events","type":"User","site_admin":false},"body":"Check output dimensions also match\r\nThis check is to make sure the NNVM operator Infer match with Compute result.\r\nThis helps to avoid developers misguided with runtime errors instead of compile time.","created_at":"2018-05-10T16:38:32Z","updated_at":"2018-05-13T12:32:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b77d968bdc14ca2d533f6cc4e058edecb88d52a1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dmlc/nnvm/pulls/476/commits","review_comments_url":"https://api.github.com/repos/dmlc/nnvm/pulls/476/comments","review_comment_url":"https://api.github.com/repos/dmlc/nnvm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmlc/nnvm/issues/476/comments","statuses_url":"https://api.github.com/repos/dmlc/nnvm/statuses/16f1ef818922bb0d269c922024edefacb8f787bf","head":{"label":"srkreddy1238:work","ref":"work","sha":"16f1ef818922bb0d269c922024edefacb8f787bf","user":{"login":"srkreddy1238","id":14215163,"avatar_url":"https://avatars2.githubusercontent.com/u/14215163?v=4","gravatar_id":"","url":"https://api.github.com/users/srkreddy1238","html_url":"https://github.com/srkreddy1238","followers_url":"https://api.github.com/users/srkreddy1238/followers","following_url":"https://api.github.com/users/srkreddy1238/following{/other_user}","gists_url":"https://api.github.com/users/srkreddy1238/gists{/gist_id}","starred_url":"https://api.github.com/users/srkreddy1238/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srkreddy1238/subscriptions","organizations_url":"https://api.github.com/users/srkreddy1238/orgs","repos_url":"https://api.github.com/users/srkreddy1238/repos","events_url":"https://api.github.com/users/srkreddy1238/events{/privacy}","received_events_url":"https://api.github.com/users/srkreddy1238/received_events","type":"User","site_admin":false},"repo":{"id":111079762,"name":"nnvm","full_name":"srkreddy1238/nnvm","owner":{"login":"srkreddy1238","id":14215163,"avatar_url":"https://avatars2.githubusercontent.com/u/14215163?v=4","gravatar_id":"","url":"https://api.github.com/users/srkreddy1238","html_url":"https://github.com/srkreddy1238","followers_url":"https://api.github.com/users/srkreddy1238/followers","following_url":"https://api.github.com/users/srkreddy1238/following{/other_user}","gists_url":"https://api.github.com/users/srkreddy1238/gists{/gist_id}","starred_url":"https://api.github.com/users/srkreddy1238/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srkreddy1238/subscriptions","organizations_url":"https://api.github.com/users/srkreddy1238/orgs","repos_url":"https://api.github.com/users/srkreddy1238/repos","events_url":"https://api.github.com/users/srkreddy1238/events{/privacy}","received_events_url":"https://api.github.com/users/srkreddy1238/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/srkreddy1238/nnvm","description":"Bring deep learning to bare metal","fork":true,"url":"https://api.github.com/repos/srkreddy1238/nnvm","forks_url":"https://api.github.com/repos/srkreddy1238/nnvm/forks","keys_url":"https://api.github.com/repos/srkreddy1238/nnvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/srkreddy1238/nnvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/srkreddy1238/nnvm/teams","hooks_url":"https://api.github.com/repos/srkreddy1238/nnvm/hooks","issue_events_url":"https://api.github.com/repos/srkreddy1238/nnvm/issues/events{/number}","events_url":"https://api.github.com/repos/srkreddy1238/nnvm/events","assignees_url":"https://api.github.com/repos/srkreddy1238/nnvm/assignees{/user}","branches_url":"https://api.github.com/repos/srkreddy1238/nnvm/branches{/branch}","tags_url":"https://api.github.com/repos/srkreddy1238/nnvm/tags","blobs_url":"https://api.github.com/repos/srkreddy1238/nnvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/srkreddy1238/nnvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/srkreddy1238/nnvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/srkreddy1238/nnvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/srkreddy1238/nnvm/statuses/{sha}","languages_url":"https://api.github.com/repos/srkreddy1238/nnvm/languages","stargazers_url":"https://api.github.com/repos/srkreddy1238/nnvm/stargazers","contributors_url":"https://api.github.com/repos/srkreddy1238/nnvm/contributors","subscribers_url":"https://api.github.com/repos/srkreddy1238/nnvm/subscribers","subscription_url":"https://api.github.com/repos/srkreddy1238/nnvm/subscription","commits_url":"https://api.github.com/repos/srkreddy1238/nnvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/srkreddy1238/nnvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/srkreddy1238/nnvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/srkreddy1238/nnvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/srkreddy1238/nnvm/contents/{+path}","compare_url":"https://api.github.com/repos/srkreddy1238/nnvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/srkreddy1238/nnvm/merges","archive_url":"https://api.github.com/repos/srkreddy1238/nnvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/srkreddy1238/nnvm/downloads","issues_url":"https://api.github.com/repos/srkreddy1238/nnvm/issues{/number}","pulls_url":"https://api.github.com/repos/srkreddy1238/nnvm/pulls{/number}","milestones_url":"https://api.github.com/repos/srkreddy1238/nnvm/milestones{/number}","notifications_url":"https://api.github.com/repos/srkreddy1238/nnvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/srkreddy1238/nnvm/labels{/name}","releases_url":"https://api.github.com/repos/srkreddy1238/nnvm/releases{/id}","deployments_url":"https://api.github.com/repos/srkreddy1238/nnvm/deployments","created_at":"2017-11-17T08:43:14Z","updated_at":"2018-05-12T15:16:24Z","pushed_at":"2018-05-13T12:32:31Z","git_url":"git://github.com/srkreddy1238/nnvm.git","ssh_url":"git@github.com:srkreddy1238/nnvm.git","clone_url":"https://github.com/srkreddy1238/nnvm.git","svn_url":"https://github.com/srkreddy1238/nnvm","homepage":"","size":1289,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dmlc:master","ref":"master","sha":"c6294a04fe9592a72a6969c8b469ebff39fb4557","user":{"login":"dmlc","id":11508361,"avatar_url":"https://avatars2.githubusercontent.com/u/11508361?v=4","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"repo":{"id":61771898,"name":"nnvm","full_name":"dmlc/nnvm","owner":{"login":"dmlc","id":11508361,"avatar_url":"https://avatars2.githubusercontent.com/u/11508361?v=4","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dmlc/nnvm","description":"Bring deep learning to bare metal","fork":false,"url":"https://api.github.com/repos/dmlc/nnvm","forks_url":"https://api.github.com/repos/dmlc/nnvm/forks","keys_url":"https://api.github.com/repos/dmlc/nnvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmlc/nnvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmlc/nnvm/teams","hooks_url":"https://api.github.com/repos/dmlc/nnvm/hooks","issue_events_url":"https://api.github.com/repos/dmlc/nnvm/issues/events{/number}","events_url":"https://api.github.com/repos/dmlc/nnvm/events","assignees_url":"https://api.github.com/repos/dmlc/nnvm/assignees{/user}","branches_url":"https://api.github.com/repos/dmlc/nnvm/branches{/branch}","tags_url":"https://api.github.com/repos/dmlc/nnvm/tags","blobs_url":"https://api.github.com/repos/dmlc/nnvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmlc/nnvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmlc/nnvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmlc/nnvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmlc/nnvm/statuses/{sha}","languages_url":"https://api.github.com/repos/dmlc/nnvm/languages","stargazers_url":"https://api.github.com/repos/dmlc/nnvm/stargazers","contributors_url":"https://api.github.com/repos/dmlc/nnvm/contributors","subscribers_url":"https://api.github.com/repos/dmlc/nnvm/subscribers","subscription_url":"https://api.github.com/repos/dmlc/nnvm/subscription","commits_url":"https://api.github.com/repos/dmlc/nnvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmlc/nnvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmlc/nnvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmlc/nnvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmlc/nnvm/contents/{+path}","compare_url":"https://api.github.com/repos/dmlc/nnvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmlc/nnvm/merges","archive_url":"https://api.github.com/repos/dmlc/nnvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmlc/nnvm/downloads","issues_url":"https://api.github.com/repos/dmlc/nnvm/issues{/number}","pulls_url":"https://api.github.com/repos/dmlc/nnvm/pulls{/number}","milestones_url":"https://api.github.com/repos/dmlc/nnvm/milestones{/number}","notifications_url":"https://api.github.com/repos/dmlc/nnvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmlc/nnvm/labels{/name}","releases_url":"https://api.github.com/repos/dmlc/nnvm/releases{/id}","deployments_url":"https://api.github.com/repos/dmlc/nnvm/deployments","created_at":"2016-06-23T03:57:02Z","updated_at":"2018-05-13T03:19:47Z","pushed_at":"2018-05-13T12:32:33Z","git_url":"git://github.com/dmlc/nnvm.git","ssh_url":"git@github.com:dmlc/nnvm.git","clone_url":"https://github.com/dmlc/nnvm.git","svn_url":"https://github.com/dmlc/nnvm","homepage":"","size":1277,"stargazers_count":1482,"watchers_count":1482,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":274,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":274,"open_issues":22,"watchers":1482,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmlc/nnvm/pulls/476"},"html":{"href":"https://github.com/dmlc/nnvm/pull/476"},"issue":{"href":"https://api.github.com/repos/dmlc/nnvm/issues/476"},"comments":{"href":"https://api.github.com/repos/dmlc/nnvm/issues/476/comments"},"review_comments":{"href":"https://api.github.com/repos/dmlc/nnvm/pulls/476/comments"},"review_comment":{"href":"https://api.github.com/repos/dmlc/nnvm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmlc/nnvm/pulls/476/commits"},"statuses":{"href":"https://api.github.com/repos/dmlc/nnvm/statuses/16f1ef818922bb0d269c922024edefacb8f787bf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"srkreddy1238"}}