{"action":"created","comment":{"url":"https://api.github.com/repos/tsdservices/Gravity/pulls/comments/190993977","pull_request_review_id":123491576,"id":190993977,"diff_hunk":"@@ -118,13 +120,15 @@ internal void PopulateChildrenRecursively<T>(BaseDto baseDto, RDO objectRdo, Obj\n \n \t\tprivate object GetChildObjectRecursively(BaseDto baseDto, RDO objectRdo, ObjectFieldsDepthLevel depthLevel, PropertyInfo property)\n \t\t{\n+\t\t\tvar fieldType = property.GetCustomAttribute<RelativityObjectFieldAttribute>()?.FieldType;","path":"Gravity/Gravity/DAL/RSAPI/RsapiDao.Get.cs","position":16,"original_position":16,"commit_id":"8bb2b1c615b92eeaf79bf5deef1f145897126f1c","original_commit_id":"8bb2b1c615b92eeaf79bf5deef1f145897126f1c","user":{"login":"Arithmomaniac","id":654897,"avatar_url":"https://avatars2.githubusercontent.com/u/654897?v=4","gravatar_id":"","url":"https://api.github.com/users/Arithmomaniac","html_url":"https://github.com/Arithmomaniac","followers_url":"https://api.github.com/users/Arithmomaniac/followers","following_url":"https://api.github.com/users/Arithmomaniac/following{/other_user}","gists_url":"https://api.github.com/users/Arithmomaniac/gists{/gist_id}","starred_url":"https://api.github.com/users/Arithmomaniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arithmomaniac/subscriptions","organizations_url":"https://api.github.com/users/Arithmomaniac/orgs","repos_url":"https://api.github.com/users/Arithmomaniac/repos","events_url":"https://api.github.com/users/Arithmomaniac/events{/privacy}","received_events_url":"https://api.github.com/users/Arithmomaniac/received_events","type":"User","site_admin":false},"body":"Instead of this, try and find the `RelativityObjectFieldAttribute` and wrap the next two blocks in an \"if not null\" statement. We shouldn't be looking up the attribute twice in a row (reflection is expensive), and it better communicates intent (the FieldGuid can never be null when the field type is set).","created_at":"2018-05-25T19:48:01Z","updated_at":"2018-05-25T19:59:25Z","html_url":"https://github.com/tsdservices/Gravity/pull/87#discussion_r190993977","pull_request_url":"https://api.github.com/repos/tsdservices/Gravity/pulls/87","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/tsdservices/Gravity/pulls/comments/190993977"},"html":{"href":"https://github.com/tsdservices/Gravity/pull/87#discussion_r190993977"},"pull_request":{"href":"https://api.github.com/repos/tsdservices/Gravity/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/tsdservices/Gravity/pulls/87","id":188500831,"html_url":"https://github.com/tsdservices/Gravity/pull/87","diff_url":"https://github.com/tsdservices/Gravity/pull/87.diff","patch_url":"https://github.com/tsdservices/Gravity/pull/87.patch","issue_url":"https://api.github.com/repos/tsdservices/Gravity/issues/87","number":87,"state":"open","locked":false,"title":"Add multi object test","user":{"login":"mrobustelli","id":23082548,"avatar_url":"https://avatars3.githubusercontent.com/u/23082548?v=4","gravatar_id":"","url":"https://api.github.com/users/mrobustelli","html_url":"https://github.com/mrobustelli","followers_url":"https://api.github.com/users/mrobustelli/followers","following_url":"https://api.github.com/users/mrobustelli/following{/other_user}","gists_url":"https://api.github.com/users/mrobustelli/gists{/gist_id}","starred_url":"https://api.github.com/users/mrobustelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrobustelli/subscriptions","organizations_url":"https://api.github.com/users/mrobustelli/orgs","repos_url":"https://api.github.com/users/mrobustelli/repos","events_url":"https://api.github.com/users/mrobustelli/events{/privacy}","received_events_url":"https://api.github.com/users/mrobustelli/received_events","type":"User","site_admin":false},"body":"I know there are some tab and spacing redos, but I am now using the extension Avi recommended.  The Write test does not pass yet, but I will work on both single and multi object write tests next.","created_at":"2018-05-16T17:07:28Z","updated_at":"2018-05-25T19:59:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6d766cb32b464bd23ef7503f9b626421ddf2acf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tsdservices/Gravity/pulls/87/commits","review_comments_url":"https://api.github.com/repos/tsdservices/Gravity/pulls/87/comments","review_comment_url":"https://api.github.com/repos/tsdservices/Gravity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tsdservices/Gravity/issues/87/comments","statuses_url":"https://api.github.com/repos/tsdservices/Gravity/statuses/8bb2b1c615b92eeaf79bf5deef1f145897126f1c","head":{"label":"tsdservices:AddMultiObjectTest","ref":"AddMultiObjectTest","sha":"8bb2b1c615b92eeaf79bf5deef1f145897126f1c","user":{"login":"tsdservices","id":31893071,"avatar_url":"https://avatars0.githubusercontent.com/u/31893071?v=4","gravatar_id":"","url":"https://api.github.com/users/tsdservices","html_url":"https://github.com/tsdservices","followers_url":"https://api.github.com/users/tsdservices/followers","following_url":"https://api.github.com/users/tsdservices/following{/other_user}","gists_url":"https://api.github.com/users/tsdservices/gists{/gist_id}","starred_url":"https://api.github.com/users/tsdservices/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsdservices/subscriptions","organizations_url":"https://api.github.com/users/tsdservices/orgs","repos_url":"https://api.github.com/users/tsdservices/repos","events_url":"https://api.github.com/users/tsdservices/events{/privacy}","received_events_url":"https://api.github.com/users/tsdservices/received_events","type":"Organization","site_admin":false},"repo":{"id":103377412,"name":"Gravity","full_name":"tsdservices/Gravity","owner":{"login":"tsdservices","id":31893071,"avatar_url":"https://avatars0.githubusercontent.com/u/31893071?v=4","gravatar_id":"","url":"https://api.github.com/users/tsdservices","html_url":"https://github.com/tsdservices","followers_url":"https://api.github.com/users/tsdservices/followers","following_url":"https://api.github.com/users/tsdservices/following{/other_user}","gists_url":"https://api.github.com/users/tsdservices/gists{/gist_id}","starred_url":"https://api.github.com/users/tsdservices/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsdservices/subscriptions","organizations_url":"https://api.github.com/users/tsdservices/orgs","repos_url":"https://api.github.com/users/tsdservices/repos","events_url":"https://api.github.com/users/tsdservices/events{/privacy}","received_events_url":"https://api.github.com/users/tsdservices/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tsdservices/Gravity","description":"CRUDQ Framework for Relativity Custom Development","fork":false,"url":"https://api.github.com/repos/tsdservices/Gravity","forks_url":"https://api.github.com/repos/tsdservices/Gravity/forks","keys_url":"https://api.github.com/repos/tsdservices/Gravity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsdservices/Gravity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsdservices/Gravity/teams","hooks_url":"https://api.github.com/repos/tsdservices/Gravity/hooks","issue_events_url":"https://api.github.com/repos/tsdservices/Gravity/issues/events{/number}","events_url":"https://api.github.com/repos/tsdservices/Gravity/events","assignees_url":"https://api.github.com/repos/tsdservices/Gravity/assignees{/user}","branches_url":"https://api.github.com/repos/tsdservices/Gravity/branches{/branch}","tags_url":"https://api.github.com/repos/tsdservices/Gravity/tags","blobs_url":"https://api.github.com/repos/tsdservices/Gravity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsdservices/Gravity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsdservices/Gravity/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsdservices/Gravity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsdservices/Gravity/statuses/{sha}","languages_url":"https://api.github.com/repos/tsdservices/Gravity/languages","stargazers_url":"https://api.github.com/repos/tsdservices/Gravity/stargazers","contributors_url":"https://api.github.com/repos/tsdservices/Gravity/contributors","subscribers_url":"https://api.github.com/repos/tsdservices/Gravity/subscribers","subscription_url":"https://api.github.com/repos/tsdservices/Gravity/subscription","commits_url":"https://api.github.com/repos/tsdservices/Gravity/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsdservices/Gravity/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsdservices/Gravity/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsdservices/Gravity/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsdservices/Gravity/contents/{+path}","compare_url":"https://api.github.com/repos/tsdservices/Gravity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsdservices/Gravity/merges","archive_url":"https://api.github.com/repos/tsdservices/Gravity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsdservices/Gravity/downloads","issues_url":"https://api.github.com/repos/tsdservices/Gravity/issues{/number}","pulls_url":"https://api.github.com/repos/tsdservices/Gravity/pulls{/number}","milestones_url":"https://api.github.com/repos/tsdservices/Gravity/milestones{/number}","notifications_url":"https://api.github.com/repos/tsdservices/Gravity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsdservices/Gravity/labels{/name}","releases_url":"https://api.github.com/repos/tsdservices/Gravity/releases{/id}","deployments_url":"https://api.github.com/repos/tsdservices/Gravity/deployments","created_at":"2017-09-13T08:59:16Z","updated_at":"2018-05-21T16:53:58Z","pushed_at":"2018-05-25T16:51:19Z","git_url":"git://github.com/tsdservices/Gravity.git","ssh_url":"git@github.com:tsdservices/Gravity.git","clone_url":"https://github.com/tsdservices/Gravity.git","svn_url":"https://github.com/tsdservices/Gravity","homepage":"","size":250,"stargazers_count":10,"watchers_count":10,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":7,"open_issues":27,"watchers":10,"default_branch":"development"}},"base":{"label":"tsdservices:development","ref":"development","sha":"1e8146e2d6cae6dd38fe23d20a3253e006704085","user":{"login":"tsdservices","id":31893071,"avatar_url":"https://avatars0.githubusercontent.com/u/31893071?v=4","gravatar_id":"","url":"https://api.github.com/users/tsdservices","html_url":"https://github.com/tsdservices","followers_url":"https://api.github.com/users/tsdservices/followers","following_url":"https://api.github.com/users/tsdservices/following{/other_user}","gists_url":"https://api.github.com/users/tsdservices/gists{/gist_id}","starred_url":"https://api.github.com/users/tsdservices/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsdservices/subscriptions","organizations_url":"https://api.github.com/users/tsdservices/orgs","repos_url":"https://api.github.com/users/tsdservices/repos","events_url":"https://api.github.com/users/tsdservices/events{/privacy}","received_events_url":"https://api.github.com/users/tsdservices/received_events","type":"Organization","site_admin":false},"repo":{"id":103377412,"name":"Gravity","full_name":"tsdservices/Gravity","owner":{"login":"tsdservices","id":31893071,"avatar_url":"https://avatars0.githubusercontent.com/u/31893071?v=4","gravatar_id":"","url":"https://api.github.com/users/tsdservices","html_url":"https://github.com/tsdservices","followers_url":"https://api.github.com/users/tsdservices/followers","following_url":"https://api.github.com/users/tsdservices/following{/other_user}","gists_url":"https://api.github.com/users/tsdservices/gists{/gist_id}","starred_url":"https://api.github.com/users/tsdservices/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsdservices/subscriptions","organizations_url":"https://api.github.com/users/tsdservices/orgs","repos_url":"https://api.github.com/users/tsdservices/repos","events_url":"https://api.github.com/users/tsdservices/events{/privacy}","received_events_url":"https://api.github.com/users/tsdservices/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tsdservices/Gravity","description":"CRUDQ Framework for Relativity Custom Development","fork":false,"url":"https://api.github.com/repos/tsdservices/Gravity","forks_url":"https://api.github.com/repos/tsdservices/Gravity/forks","keys_url":"https://api.github.com/repos/tsdservices/Gravity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsdservices/Gravity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsdservices/Gravity/teams","hooks_url":"https://api.github.com/repos/tsdservices/Gravity/hooks","issue_events_url":"https://api.github.com/repos/tsdservices/Gravity/issues/events{/number}","events_url":"https://api.github.com/repos/tsdservices/Gravity/events","assignees_url":"https://api.github.com/repos/tsdservices/Gravity/assignees{/user}","branches_url":"https://api.github.com/repos/tsdservices/Gravity/branches{/branch}","tags_url":"https://api.github.com/repos/tsdservices/Gravity/tags","blobs_url":"https://api.github.com/repos/tsdservices/Gravity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsdservices/Gravity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsdservices/Gravity/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsdservices/Gravity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsdservices/Gravity/statuses/{sha}","languages_url":"https://api.github.com/repos/tsdservices/Gravity/languages","stargazers_url":"https://api.github.com/repos/tsdservices/Gravity/stargazers","contributors_url":"https://api.github.com/repos/tsdservices/Gravity/contributors","subscribers_url":"https://api.github.com/repos/tsdservices/Gravity/subscribers","subscription_url":"https://api.github.com/repos/tsdservices/Gravity/subscription","commits_url":"https://api.github.com/repos/tsdservices/Gravity/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsdservices/Gravity/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsdservices/Gravity/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsdservices/Gravity/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsdservices/Gravity/contents/{+path}","compare_url":"https://api.github.com/repos/tsdservices/Gravity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsdservices/Gravity/merges","archive_url":"https://api.github.com/repos/tsdservices/Gravity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsdservices/Gravity/downloads","issues_url":"https://api.github.com/repos/tsdservices/Gravity/issues{/number}","pulls_url":"https://api.github.com/repos/tsdservices/Gravity/pulls{/number}","milestones_url":"https://api.github.com/repos/tsdservices/Gravity/milestones{/number}","notifications_url":"https://api.github.com/repos/tsdservices/Gravity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsdservices/Gravity/labels{/name}","releases_url":"https://api.github.com/repos/tsdservices/Gravity/releases{/id}","deployments_url":"https://api.github.com/repos/tsdservices/Gravity/deployments","created_at":"2017-09-13T08:59:16Z","updated_at":"2018-05-21T16:53:58Z","pushed_at":"2018-05-25T16:51:19Z","git_url":"git://github.com/tsdservices/Gravity.git","ssh_url":"git@github.com:tsdservices/Gravity.git","clone_url":"https://github.com/tsdservices/Gravity.git","svn_url":"https://github.com/tsdservices/Gravity","homepage":"","size":250,"stargazers_count":10,"watchers_count":10,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":7,"open_issues":27,"watchers":10,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/tsdservices/Gravity/pulls/87"},"html":{"href":"https://github.com/tsdservices/Gravity/pull/87"},"issue":{"href":"https://api.github.com/repos/tsdservices/Gravity/issues/87"},"comments":{"href":"https://api.github.com/repos/tsdservices/Gravity/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/tsdservices/Gravity/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/tsdservices/Gravity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tsdservices/Gravity/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/tsdservices/Gravity/statuses/8bb2b1c615b92eeaf79bf5deef1f145897126f1c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Arithmomaniac"}}