{"action":"created","comment":{"url":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/comments/173394811","pull_request_review_id":102579100,"id":173394811,"diff_hunk":"@@ -19,30 +19,16 @@ export class GeneralRepository {\n   }\n \n   public async updateProcessDef(processDef: IProcessDefEntity, xml: string): Promise<any> {\n-\n-    let updateError: Error;\n-    let result: any;\n-\n-    try {\n-      const options: RequestInit = {\n-        method: 'post',\n-        headers: new Headers({\n-          'Content-Type': 'application/json',\n-        }),\n-        body: JSON.stringify({\n-            xml: xml,\n-        }),\n-      };\n-      const url: string = `${environment.processengine.routes.processes}/${processDef.id}/updateBpmn`;\n-      result = await this.httpClient.fetch(url, options);\n-\n-    } catch (error) {\n-      updateError = error;\n-    }\n-\n-    if (updateError) {\n-      throw updateError;\n-    }\n-    return result;\n+    const options: RequestInit = {\n+      method: 'post',\n+      headers: new Headers({\n+        'Content-Type': 'application/json',\n+      }),\n+      body: JSON.stringify({\n+          xml: xml,\n+      }),\n+    };\n+    const url: string = `${environment.processengine.routes.processes}/${processDef.id}/updateBpmn`;\n+    return await this.httpClient.fetch(url, options);","path":"src/modules/property-panel/indextabs/general/repository/general.repository.ts","position":32,"original_position":39,"commit_id":"799dfd5de9435acb95c3510bbd412540a667aba0","original_commit_id":"799dfd5de9435acb95c3510bbd412540a667aba0","user":{"login":"heikomat","id":20770029,"avatar_url":"https://avatars1.githubusercontent.com/u/20770029?v=4","gravatar_id":"","url":"https://api.github.com/users/heikomat","html_url":"https://github.com/heikomat","followers_url":"https://api.github.com/users/heikomat/followers","following_url":"https://api.github.com/users/heikomat/following{/other_user}","gists_url":"https://api.github.com/users/heikomat/gists{/gist_id}","starred_url":"https://api.github.com/users/heikomat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heikomat/subscriptions","organizations_url":"https://api.github.com/users/heikomat/orgs","repos_url":"https://api.github.com/users/heikomat/repos","events_url":"https://api.github.com/users/heikomat/events{/privacy}","received_events_url":"https://api.github.com/users/heikomat/received_events","type":"User","site_admin":false},"body":"you don't need to `return await`, just return the promise that `this.httpClient.fetch` returns to you.\r\n\r\nDoing this also makes the `async`-keyword on this method obsolete","created_at":"2018-03-09T08:57:43Z","updated_at":"2018-03-09T08:57:46Z","html_url":"https://github.com/process-engine/bpmn-studio/pull/194#discussion_r173394811","pull_request_url":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/194","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/comments/173394811"},"html":{"href":"https://github.com/process-engine/bpmn-studio/pull/194#discussion_r173394811"},"pull_request":{"href":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/194"}}},"pull_request":{"url":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/194","id":173740143,"html_url":"https://github.com/process-engine/bpmn-studio/pull/194","diff_url":"https://github.com/process-engine/bpmn-studio/pull/194.diff","patch_url":"https://github.com/process-engine/bpmn-studio/pull/194.patch","issue_url":"https://api.github.com/repos/process-engine/bpmn-studio/issues/194","number":194,"state":"open","locked":false,"title":"✨Call Activity Navigation","user":{"login":"Vyperus","id":17248802,"avatar_url":"https://avatars3.githubusercontent.com/u/17248802?v=4","gravatar_id":"","url":"https://api.github.com/users/Vyperus","html_url":"https://github.com/Vyperus","followers_url":"https://api.github.com/users/Vyperus/followers","following_url":"https://api.github.com/users/Vyperus/following{/other_user}","gists_url":"https://api.github.com/users/Vyperus/gists{/gist_id}","starred_url":"https://api.github.com/users/Vyperus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vyperus/subscriptions","organizations_url":"https://api.github.com/users/Vyperus/orgs","repos_url":"https://api.github.com/users/Vyperus/repos","events_url":"https://api.github.com/users/Vyperus/events{/privacy}","received_events_url":"https://api.github.com/users/Vyperus/received_events","type":"User","site_admin":false},"body":"## What did you change?\r\n\r\nThis branch adds the possibility to navigate directly to the called Process when using a Call Activitiy.\r\n\r\nCloses #192 \r\nCloses #60 \r\n\r\n## How can others test the changes?\r\n\r\n- Checkout this branch & start bpmn-studio\r\n- Create a new process and use a call activity\r\n- See the changes in the property panel section for call activities\r\n\r\n## PR-Checklist\r\n\r\nPlease check the boxes in this list after submitting your PR:\r\n\r\n- [x] You can merge this PR **right now** (if not, please prefix the title with \"WIP: \")\r\n- [x] I've tested **all** changes included in this PR.\r\n- [x] I've also reviewed this PR myself before submitting (e.g. for scrambled letters, typos, etc.)\r\n- [x] I've merged the `develop` branch into my branch before finishing this PR.\r\n- [x] I've **not added any other changes** than the ones described above.\r\n- [x] I've mentioned all **PRs, which relate to this one**\r\n","created_at":"2018-03-08T13:49:06Z","updated_at":"2018-03-09T08:57:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76f676f750703be05f9c4a4fdcd82efd65d86553","assignee":{"login":"Vyperus","id":17248802,"avatar_url":"https://avatars3.githubusercontent.com/u/17248802?v=4","gravatar_id":"","url":"https://api.github.com/users/Vyperus","html_url":"https://github.com/Vyperus","followers_url":"https://api.github.com/users/Vyperus/followers","following_url":"https://api.github.com/users/Vyperus/following{/other_user}","gists_url":"https://api.github.com/users/Vyperus/gists{/gist_id}","starred_url":"https://api.github.com/users/Vyperus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vyperus/subscriptions","organizations_url":"https://api.github.com/users/Vyperus/orgs","repos_url":"https://api.github.com/users/Vyperus/repos","events_url":"https://api.github.com/users/Vyperus/events{/privacy}","received_events_url":"https://api.github.com/users/Vyperus/received_events","type":"User","site_admin":false},"assignees":[{"login":"Vyperus","id":17248802,"avatar_url":"https://avatars3.githubusercontent.com/u/17248802?v=4","gravatar_id":"","url":"https://api.github.com/users/Vyperus","html_url":"https://github.com/Vyperus","followers_url":"https://api.github.com/users/Vyperus/followers","following_url":"https://api.github.com/users/Vyperus/following{/other_user}","gists_url":"https://api.github.com/users/Vyperus/gists{/gist_id}","starred_url":"https://api.github.com/users/Vyperus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vyperus/subscriptions","organizations_url":"https://api.github.com/users/Vyperus/orgs","repos_url":"https://api.github.com/users/Vyperus/repos","events_url":"https://api.github.com/users/Vyperus/events{/privacy}","received_events_url":"https://api.github.com/users/Vyperus/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"5ebastianMeier","id":16539774,"avatar_url":"https://avatars0.githubusercontent.com/u/16539774?v=4","gravatar_id":"","url":"https://api.github.com/users/5ebastianMeier","html_url":"https://github.com/5ebastianMeier","followers_url":"https://api.github.com/users/5ebastianMeier/followers","following_url":"https://api.github.com/users/5ebastianMeier/following{/other_user}","gists_url":"https://api.github.com/users/5ebastianMeier/gists{/gist_id}","starred_url":"https://api.github.com/users/5ebastianMeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/5ebastianMeier/subscriptions","organizations_url":"https://api.github.com/users/5ebastianMeier/orgs","repos_url":"https://api.github.com/users/5ebastianMeier/repos","events_url":"https://api.github.com/users/5ebastianMeier/events{/privacy}","received_events_url":"https://api.github.com/users/5ebastianMeier/received_events","type":"User","site_admin":false},{"login":"MiguelACarballo","id":22176561,"avatar_url":"https://avatars0.githubusercontent.com/u/22176561?v=4","gravatar_id":"","url":"https://api.github.com/users/MiguelACarballo","html_url":"https://github.com/MiguelACarballo","followers_url":"https://api.github.com/users/MiguelACarballo/followers","following_url":"https://api.github.com/users/MiguelACarballo/following{/other_user}","gists_url":"https://api.github.com/users/MiguelACarballo/gists{/gist_id}","starred_url":"https://api.github.com/users/MiguelACarballo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiguelACarballo/subscriptions","organizations_url":"https://api.github.com/users/MiguelACarballo/orgs","repos_url":"https://api.github.com/users/MiguelACarballo/repos","events_url":"https://api.github.com/users/MiguelACarballo/events{/privacy}","received_events_url":"https://api.github.com/users/MiguelACarballo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/194/commits","review_comments_url":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/194/comments","review_comment_url":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/process-engine/bpmn-studio/issues/194/comments","statuses_url":"https://api.github.com/repos/process-engine/bpmn-studio/statuses/799dfd5de9435acb95c3510bbd412540a667aba0","head":{"label":"process-engine:feature/call_actvitiy_navigation","ref":"feature/call_actvitiy_navigation","sha":"799dfd5de9435acb95c3510bbd412540a667aba0","user":{"login":"process-engine","id":32196207,"avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":106867605,"name":"bpmn-studio","full_name":"process-engine/bpmn-studio","owner":{"login":"process-engine","id":32196207,"avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/process-engine/bpmn-studio","description":"The Front-End for Designing Runnable BPMN-Diagrams","fork":false,"url":"https://api.github.com/repos/process-engine/bpmn-studio","forks_url":"https://api.github.com/repos/process-engine/bpmn-studio/forks","keys_url":"https://api.github.com/repos/process-engine/bpmn-studio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/process-engine/bpmn-studio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/process-engine/bpmn-studio/teams","hooks_url":"https://api.github.com/repos/process-engine/bpmn-studio/hooks","issue_events_url":"https://api.github.com/repos/process-engine/bpmn-studio/issues/events{/number}","events_url":"https://api.github.com/repos/process-engine/bpmn-studio/events","assignees_url":"https://api.github.com/repos/process-engine/bpmn-studio/assignees{/user}","branches_url":"https://api.github.com/repos/process-engine/bpmn-studio/branches{/branch}","tags_url":"https://api.github.com/repos/process-engine/bpmn-studio/tags","blobs_url":"https://api.github.com/repos/process-engine/bpmn-studio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/process-engine/bpmn-studio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/process-engine/bpmn-studio/git/refs{/sha}","trees_url":"https://api.github.com/repos/process-engine/bpmn-studio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/process-engine/bpmn-studio/statuses/{sha}","languages_url":"https://api.github.com/repos/process-engine/bpmn-studio/languages","stargazers_url":"https://api.github.com/repos/process-engine/bpmn-studio/stargazers","contributors_url":"https://api.github.com/repos/process-engine/bpmn-studio/contributors","subscribers_url":"https://api.github.com/repos/process-engine/bpmn-studio/subscribers","subscription_url":"https://api.github.com/repos/process-engine/bpmn-studio/subscription","commits_url":"https://api.github.com/repos/process-engine/bpmn-studio/commits{/sha}","git_commits_url":"https://api.github.com/repos/process-engine/bpmn-studio/git/commits{/sha}","comments_url":"https://api.github.com/repos/process-engine/bpmn-studio/comments{/number}","issue_comment_url":"https://api.github.com/repos/process-engine/bpmn-studio/issues/comments{/number}","contents_url":"https://api.github.com/repos/process-engine/bpmn-studio/contents/{+path}","compare_url":"https://api.github.com/repos/process-engine/bpmn-studio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/process-engine/bpmn-studio/merges","archive_url":"https://api.github.com/repos/process-engine/bpmn-studio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/process-engine/bpmn-studio/downloads","issues_url":"https://api.github.com/repos/process-engine/bpmn-studio/issues{/number}","pulls_url":"https://api.github.com/repos/process-engine/bpmn-studio/pulls{/number}","milestones_url":"https://api.github.com/repos/process-engine/bpmn-studio/milestones{/number}","notifications_url":"https://api.github.com/repos/process-engine/bpmn-studio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/process-engine/bpmn-studio/labels{/name}","releases_url":"https://api.github.com/repos/process-engine/bpmn-studio/releases{/id}","deployments_url":"https://api.github.com/repos/process-engine/bpmn-studio/deployments","created_at":"2017-10-13T19:54:48Z","updated_at":"2018-01-24T13:35:10Z","pushed_at":"2018-03-09T08:56:36Z","git_url":"git://github.com/process-engine/bpmn-studio.git","ssh_url":"git@github.com:process-engine/bpmn-studio.git","clone_url":"https://github.com/process-engine/bpmn-studio.git","svn_url":"https://github.com/process-engine/bpmn-studio","homepage":"","size":1415,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":23,"watchers":5,"default_branch":"develop"}},"base":{"label":"process-engine:develop","ref":"develop","sha":"59e710fd94c20b0267c45d697322ccee1c3314fd","user":{"login":"process-engine","id":32196207,"avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":106867605,"name":"bpmn-studio","full_name":"process-engine/bpmn-studio","owner":{"login":"process-engine","id":32196207,"avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/process-engine/bpmn-studio","description":"The Front-End for Designing Runnable BPMN-Diagrams","fork":false,"url":"https://api.github.com/repos/process-engine/bpmn-studio","forks_url":"https://api.github.com/repos/process-engine/bpmn-studio/forks","keys_url":"https://api.github.com/repos/process-engine/bpmn-studio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/process-engine/bpmn-studio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/process-engine/bpmn-studio/teams","hooks_url":"https://api.github.com/repos/process-engine/bpmn-studio/hooks","issue_events_url":"https://api.github.com/repos/process-engine/bpmn-studio/issues/events{/number}","events_url":"https://api.github.com/repos/process-engine/bpmn-studio/events","assignees_url":"https://api.github.com/repos/process-engine/bpmn-studio/assignees{/user}","branches_url":"https://api.github.com/repos/process-engine/bpmn-studio/branches{/branch}","tags_url":"https://api.github.com/repos/process-engine/bpmn-studio/tags","blobs_url":"https://api.github.com/repos/process-engine/bpmn-studio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/process-engine/bpmn-studio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/process-engine/bpmn-studio/git/refs{/sha}","trees_url":"https://api.github.com/repos/process-engine/bpmn-studio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/process-engine/bpmn-studio/statuses/{sha}","languages_url":"https://api.github.com/repos/process-engine/bpmn-studio/languages","stargazers_url":"https://api.github.com/repos/process-engine/bpmn-studio/stargazers","contributors_url":"https://api.github.com/repos/process-engine/bpmn-studio/contributors","subscribers_url":"https://api.github.com/repos/process-engine/bpmn-studio/subscribers","subscription_url":"https://api.github.com/repos/process-engine/bpmn-studio/subscription","commits_url":"https://api.github.com/repos/process-engine/bpmn-studio/commits{/sha}","git_commits_url":"https://api.github.com/repos/process-engine/bpmn-studio/git/commits{/sha}","comments_url":"https://api.github.com/repos/process-engine/bpmn-studio/comments{/number}","issue_comment_url":"https://api.github.com/repos/process-engine/bpmn-studio/issues/comments{/number}","contents_url":"https://api.github.com/repos/process-engine/bpmn-studio/contents/{+path}","compare_url":"https://api.github.com/repos/process-engine/bpmn-studio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/process-engine/bpmn-studio/merges","archive_url":"https://api.github.com/repos/process-engine/bpmn-studio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/process-engine/bpmn-studio/downloads","issues_url":"https://api.github.com/repos/process-engine/bpmn-studio/issues{/number}","pulls_url":"https://api.github.com/repos/process-engine/bpmn-studio/pulls{/number}","milestones_url":"https://api.github.com/repos/process-engine/bpmn-studio/milestones{/number}","notifications_url":"https://api.github.com/repos/process-engine/bpmn-studio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/process-engine/bpmn-studio/labels{/name}","releases_url":"https://api.github.com/repos/process-engine/bpmn-studio/releases{/id}","deployments_url":"https://api.github.com/repos/process-engine/bpmn-studio/deployments","created_at":"2017-10-13T19:54:48Z","updated_at":"2018-01-24T13:35:10Z","pushed_at":"2018-03-09T08:56:36Z","git_url":"git://github.com/process-engine/bpmn-studio.git","ssh_url":"git@github.com:process-engine/bpmn-studio.git","clone_url":"https://github.com/process-engine/bpmn-studio.git","svn_url":"https://github.com/process-engine/bpmn-studio","homepage":"","size":1415,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":23,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/194"},"html":{"href":"https://github.com/process-engine/bpmn-studio/pull/194"},"issue":{"href":"https://api.github.com/repos/process-engine/bpmn-studio/issues/194"},"comments":{"href":"https://api.github.com/repos/process-engine/bpmn-studio/issues/194/comments"},"review_comments":{"href":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/194/comments"},"review_comment":{"href":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/process-engine/bpmn-studio/pulls/194/commits"},"statuses":{"href":"https://api.github.com/repos/process-engine/bpmn-studio/statuses/799dfd5de9435acb95c3510bbd412540a667aba0"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"heikomat"}}