{"action":"closed","issue":{"url":"https://api.github.com/repos/campaignmonitor/createsend-python/issues/62","repository_url":"https://api.github.com/repos/campaignmonitor/createsend-python","labels_url":"https://api.github.com/repos/campaignmonitor/createsend-python/issues/62/labels{/name}","comments_url":"https://api.github.com/repos/campaignmonitor/createsend-python/issues/62/comments","events_url":"https://api.github.com/repos/campaignmonitor/createsend-python/issues/62/events","html_url":"https://github.com/campaignmonitor/createsend-python/issues/62","id":343828021,"node_id":"MDU6SXNzdWUzNDM4MjgwMjE=","number":62,"title":"Upgrading to 6.0.0 breaks existing Subscriber implementations","user":{"login":"xfxf","id":138684,"node_id":"MDQ6VXNlcjEzODY4NA==","avatar_url":"https://avatars2.githubusercontent.com/u/138684?v=4","gravatar_id":"","url":"https://api.github.com/users/xfxf","html_url":"https://github.com/xfxf","followers_url":"https://api.github.com/users/xfxf/followers","following_url":"https://api.github.com/users/xfxf/following{/other_user}","gists_url":"https://api.github.com/users/xfxf/gists{/gist_id}","starred_url":"https://api.github.com/users/xfxf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xfxf/subscriptions","organizations_url":"https://api.github.com/users/xfxf/orgs","repos_url":"https://api.github.com/users/xfxf/repos","events_url":"https://api.github.com/users/xfxf/events{/privacy}","received_events_url":"https://api.github.com/users/xfxf/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-07-23T23:13:33Z","updated_at":"2018-07-25T11:31:21Z","closed_at":"2018-07-25T11:31:21Z","author_association":"NONE","body":"This may be intentional - in which case I'd advise adding some documentation in README.md about this - but it appears a 'consent_to_track' parameter (for GDPR) has been added as a required field (with no default) to the .update() and .add() API's on Subscriber:\r\n\r\nhttps://github.com/campaignmonitor/createsend-python/blob/6283291bba8b56ede95e980305bb718870b5ec58/lib/createsend/subscriber.py#L27\r\n\r\nThis has resulted in our app breaking when doing a routine package upgrade.  The fix is easy, but this is likely going to bite others.\r\n\r\nI'm happy to put in a PR - either for adding some 'beware when upgrading' info to README.md, or having a default for this parameter (with an info.warning() advising the API call should be upgraded)."}}
{"actor":{"display_login":"xfxf"}}