{"action":"created","comment":{"url":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments/191083048","pull_request_review_id":123590439,"id":191083048,"diff_hunk":"@@ -411,7 +411,11 @@ class Crystal::Command\n           compiler.verbose = true\n         end\n         opts.on(\"--static\", \"Link statically\") do\n-          compiler.static = true\n+          {% if flag?(:darwin) %}","path":"src/compiler/crystal/command.cr","position":5,"original_position":5,"commit_id":"a56b5740ba4da1d7f2021ade3aae63b20707e06c","original_commit_id":"a56b5740ba4da1d7f2021ade3aae63b20707e06c","user":{"login":"faustinoaq","id":3067335,"avatar_url":"https://avatars2.githubusercontent.com/u/3067335?v=4","gravatar_id":"","url":"https://api.github.com/users/faustinoaq","html_url":"https://github.com/faustinoaq","followers_url":"https://api.github.com/users/faustinoaq/followers","following_url":"https://api.github.com/users/faustinoaq/following{/other_user}","gists_url":"https://api.github.com/users/faustinoaq/gists{/gist_id}","starred_url":"https://api.github.com/users/faustinoaq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faustinoaq/subscriptions","organizations_url":"https://api.github.com/users/faustinoaq/orgs","repos_url":"https://api.github.com/users/faustinoaq/repos","events_url":"https://api.github.com/users/faustinoaq/events{/privacy}","received_events_url":"https://api.github.com/users/faustinoaq/received_events","type":"User","site_admin":false},"body":"I think we can add source link here:\r\n\r\n```cr\r\n          # https://developer.apple.com/library/content/qa/qa1118/_index.html\r\n          {% if flag?(:darwin) %}\r\n            raise \"macOS doesn't support static linking\"\r\n          {% else %}\r\n            compiler.static = true\r\n          {% end %}\r\n```","created_at":"2018-05-27T17:28:04Z","updated_at":"2018-05-27T17:28:04Z","html_url":"https://github.com/crystal-lang/crystal/pull/6110#discussion_r191083048","pull_request_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/6110","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments/191083048"},"html":{"href":"https://github.com/crystal-lang/crystal/pull/6110#discussion_r191083048"},"pull_request":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/6110"}}},"pull_request":{"url":"https://api.github.com/repos/crystal-lang/crystal/pulls/6110","id":189238979,"html_url":"https://github.com/crystal-lang/crystal/pull/6110","diff_url":"https://github.com/crystal-lang/crystal/pull/6110.diff","patch_url":"https://github.com/crystal-lang/crystal/pull/6110.patch","issue_url":"https://api.github.com/repos/crystal-lang/crystal/issues/6110","number":6110,"state":"open","locked":false,"title":"Remove static linking for macos","user":{"login":"j8r","id":6562667,"avatar_url":"https://avatars0.githubusercontent.com/u/6562667?v=4","gravatar_id":"","url":"https://api.github.com/users/j8r","html_url":"https://github.com/j8r","followers_url":"https://api.github.com/users/j8r/followers","following_url":"https://api.github.com/users/j8r/following{/other_user}","gists_url":"https://api.github.com/users/j8r/gists{/gist_id}","starred_url":"https://api.github.com/users/j8r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j8r/subscriptions","organizations_url":"https://api.github.com/users/j8r/orgs","repos_url":"https://api.github.com/users/j8r/repos","events_url":"https://api.github.com/users/j8r/events{/privacy}","received_events_url":"https://api.github.com/users/j8r/received_events","type":"User","site_admin":false},"body":"[Static linking isn't supported on macos](https://developer.apple.com/library/content/qa/qa1118/_index.html).\r\nFix #5991","created_at":"2018-05-20T15:43:54Z","updated_at":"2018-05-27T17:28:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ded41559a86a90fb5ffe35b6b50439260e1ddd6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":521914109,"url":"https://api.github.com/repos/crystal-lang/crystal/labels/kind:refactor","name":"kind:refactor","color":"c2e0c6","default":false},{"id":253019637,"url":"https://api.github.com/repos/crystal-lang/crystal/labels/topic:compiler","name":"topic:compiler","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/6110/commits","review_comments_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/6110/comments","review_comment_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crystal-lang/crystal/issues/6110/comments","statuses_url":"https://api.github.com/repos/crystal-lang/crystal/statuses/a56b5740ba4da1d7f2021ade3aae63b20707e06c","head":{"label":"j8r:macos-static","ref":"macos-static","sha":"a56b5740ba4da1d7f2021ade3aae63b20707e06c","user":{"login":"j8r","id":6562667,"avatar_url":"https://avatars0.githubusercontent.com/u/6562667?v=4","gravatar_id":"","url":"https://api.github.com/users/j8r","html_url":"https://github.com/j8r","followers_url":"https://api.github.com/users/j8r/followers","following_url":"https://api.github.com/users/j8r/following{/other_user}","gists_url":"https://api.github.com/users/j8r/gists{/gist_id}","starred_url":"https://api.github.com/users/j8r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j8r/subscriptions","organizations_url":"https://api.github.com/users/j8r/orgs","repos_url":"https://api.github.com/users/j8r/repos","events_url":"https://api.github.com/users/j8r/events{/privacy}","received_events_url":"https://api.github.com/users/j8r/received_events","type":"User","site_admin":false},"repo":{"id":109133637,"name":"crystal","full_name":"j8r/crystal","owner":{"login":"j8r","id":6562667,"avatar_url":"https://avatars0.githubusercontent.com/u/6562667?v=4","gravatar_id":"","url":"https://api.github.com/users/j8r","html_url":"https://github.com/j8r","followers_url":"https://api.github.com/users/j8r/followers","following_url":"https://api.github.com/users/j8r/following{/other_user}","gists_url":"https://api.github.com/users/j8r/gists{/gist_id}","starred_url":"https://api.github.com/users/j8r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j8r/subscriptions","organizations_url":"https://api.github.com/users/j8r/orgs","repos_url":"https://api.github.com/users/j8r/repos","events_url":"https://api.github.com/users/j8r/events{/privacy}","received_events_url":"https://api.github.com/users/j8r/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/j8r/crystal","description":"The Crystal Programming Language","fork":true,"url":"https://api.github.com/repos/j8r/crystal","forks_url":"https://api.github.com/repos/j8r/crystal/forks","keys_url":"https://api.github.com/repos/j8r/crystal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/j8r/crystal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/j8r/crystal/teams","hooks_url":"https://api.github.com/repos/j8r/crystal/hooks","issue_events_url":"https://api.github.com/repos/j8r/crystal/issues/events{/number}","events_url":"https://api.github.com/repos/j8r/crystal/events","assignees_url":"https://api.github.com/repos/j8r/crystal/assignees{/user}","branches_url":"https://api.github.com/repos/j8r/crystal/branches{/branch}","tags_url":"https://api.github.com/repos/j8r/crystal/tags","blobs_url":"https://api.github.com/repos/j8r/crystal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/j8r/crystal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/j8r/crystal/git/refs{/sha}","trees_url":"https://api.github.com/repos/j8r/crystal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/j8r/crystal/statuses/{sha}","languages_url":"https://api.github.com/repos/j8r/crystal/languages","stargazers_url":"https://api.github.com/repos/j8r/crystal/stargazers","contributors_url":"https://api.github.com/repos/j8r/crystal/contributors","subscribers_url":"https://api.github.com/repos/j8r/crystal/subscribers","subscription_url":"https://api.github.com/repos/j8r/crystal/subscription","commits_url":"https://api.github.com/repos/j8r/crystal/commits{/sha}","git_commits_url":"https://api.github.com/repos/j8r/crystal/git/commits{/sha}","comments_url":"https://api.github.com/repos/j8r/crystal/comments{/number}","issue_comment_url":"https://api.github.com/repos/j8r/crystal/issues/comments{/number}","contents_url":"https://api.github.com/repos/j8r/crystal/contents/{+path}","compare_url":"https://api.github.com/repos/j8r/crystal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/j8r/crystal/merges","archive_url":"https://api.github.com/repos/j8r/crystal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/j8r/crystal/downloads","issues_url":"https://api.github.com/repos/j8r/crystal/issues{/number}","pulls_url":"https://api.github.com/repos/j8r/crystal/pulls{/number}","milestones_url":"https://api.github.com/repos/j8r/crystal/milestones{/number}","notifications_url":"https://api.github.com/repos/j8r/crystal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/j8r/crystal/labels{/name}","releases_url":"https://api.github.com/repos/j8r/crystal/releases{/id}","deployments_url":"https://api.github.com/repos/j8r/crystal/deployments","created_at":"2017-11-01T13:16:53Z","updated_at":"2018-05-18T09:30:55Z","pushed_at":"2018-05-20T16:23:18Z","git_url":"git://github.com/j8r/crystal.git","ssh_url":"git@github.com:j8r/crystal.git","clone_url":"https://github.com/j8r/crystal.git","svn_url":"https://github.com/j8r/crystal","homepage":"https://crystal-lang.org","size":36881,"stargazers_count":0,"watchers_count":0,"language":"Crystal","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crystal-lang:master","ref":"master","sha":"06e763bf3dd85c242d2d5d391631a72471e1e053","user":{"login":"crystal-lang","id":6539796,"avatar_url":"https://avatars0.githubusercontent.com/u/6539796?v=4","gravatar_id":"","url":"https://api.github.com/users/crystal-lang","html_url":"https://github.com/crystal-lang","followers_url":"https://api.github.com/users/crystal-lang/followers","following_url":"https://api.github.com/users/crystal-lang/following{/other_user}","gists_url":"https://api.github.com/users/crystal-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/crystal-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crystal-lang/subscriptions","organizations_url":"https://api.github.com/users/crystal-lang/orgs","repos_url":"https://api.github.com/users/crystal-lang/repos","events_url":"https://api.github.com/users/crystal-lang/events{/privacy}","received_events_url":"https://api.github.com/users/crystal-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":6887813,"name":"crystal","full_name":"crystal-lang/crystal","owner":{"login":"crystal-lang","id":6539796,"avatar_url":"https://avatars0.githubusercontent.com/u/6539796?v=4","gravatar_id":"","url":"https://api.github.com/users/crystal-lang","html_url":"https://github.com/crystal-lang","followers_url":"https://api.github.com/users/crystal-lang/followers","following_url":"https://api.github.com/users/crystal-lang/following{/other_user}","gists_url":"https://api.github.com/users/crystal-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/crystal-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crystal-lang/subscriptions","organizations_url":"https://api.github.com/users/crystal-lang/orgs","repos_url":"https://api.github.com/users/crystal-lang/repos","events_url":"https://api.github.com/users/crystal-lang/events{/privacy}","received_events_url":"https://api.github.com/users/crystal-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crystal-lang/crystal","description":"The Crystal Programming Language","fork":false,"url":"https://api.github.com/repos/crystal-lang/crystal","forks_url":"https://api.github.com/repos/crystal-lang/crystal/forks","keys_url":"https://api.github.com/repos/crystal-lang/crystal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crystal-lang/crystal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crystal-lang/crystal/teams","hooks_url":"https://api.github.com/repos/crystal-lang/crystal/hooks","issue_events_url":"https://api.github.com/repos/crystal-lang/crystal/issues/events{/number}","events_url":"https://api.github.com/repos/crystal-lang/crystal/events","assignees_url":"https://api.github.com/repos/crystal-lang/crystal/assignees{/user}","branches_url":"https://api.github.com/repos/crystal-lang/crystal/branches{/branch}","tags_url":"https://api.github.com/repos/crystal-lang/crystal/tags","blobs_url":"https://api.github.com/repos/crystal-lang/crystal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crystal-lang/crystal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crystal-lang/crystal/git/refs{/sha}","trees_url":"https://api.github.com/repos/crystal-lang/crystal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crystal-lang/crystal/statuses/{sha}","languages_url":"https://api.github.com/repos/crystal-lang/crystal/languages","stargazers_url":"https://api.github.com/repos/crystal-lang/crystal/stargazers","contributors_url":"https://api.github.com/repos/crystal-lang/crystal/contributors","subscribers_url":"https://api.github.com/repos/crystal-lang/crystal/subscribers","subscription_url":"https://api.github.com/repos/crystal-lang/crystal/subscription","commits_url":"https://api.github.com/repos/crystal-lang/crystal/commits{/sha}","git_commits_url":"https://api.github.com/repos/crystal-lang/crystal/git/commits{/sha}","comments_url":"https://api.github.com/repos/crystal-lang/crystal/comments{/number}","issue_comment_url":"https://api.github.com/repos/crystal-lang/crystal/issues/comments{/number}","contents_url":"https://api.github.com/repos/crystal-lang/crystal/contents/{+path}","compare_url":"https://api.github.com/repos/crystal-lang/crystal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crystal-lang/crystal/merges","archive_url":"https://api.github.com/repos/crystal-lang/crystal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crystal-lang/crystal/downloads","issues_url":"https://api.github.com/repos/crystal-lang/crystal/issues{/number}","pulls_url":"https://api.github.com/repos/crystal-lang/crystal/pulls{/number}","milestones_url":"https://api.github.com/repos/crystal-lang/crystal/milestones{/number}","notifications_url":"https://api.github.com/repos/crystal-lang/crystal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crystal-lang/crystal/labels{/name}","releases_url":"https://api.github.com/repos/crystal-lang/crystal/releases{/id}","deployments_url":"https://api.github.com/repos/crystal-lang/crystal/deployments","created_at":"2012-11-27T17:32:32Z","updated_at":"2018-05-27T07:05:09Z","pushed_at":"2018-05-26T22:43:14Z","git_url":"git://github.com/crystal-lang/crystal.git","ssh_url":"git@github.com:crystal-lang/crystal.git","clone_url":"https://github.com/crystal-lang/crystal.git","svn_url":"https://github.com/crystal-lang/crystal","homepage":"https://crystal-lang.org","size":36810,"stargazers_count":10816,"watchers_count":10816,"language":"Crystal","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":856,"mirror_url":null,"archived":false,"open_issues_count":655,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":856,"open_issues":655,"watchers":10816,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/6110"},"html":{"href":"https://github.com/crystal-lang/crystal/pull/6110"},"issue":{"href":"https://api.github.com/repos/crystal-lang/crystal/issues/6110"},"comments":{"href":"https://api.github.com/repos/crystal-lang/crystal/issues/6110/comments"},"review_comments":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/6110/comments"},"review_comment":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/6110/commits"},"statuses":{"href":"https://api.github.com/repos/crystal-lang/crystal/statuses/a56b5740ba4da1d7f2021ade3aae63b20707e06c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"faustinoaq"}}