{"action":"created","issue":{"url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/654","repository_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator","labels_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/654/labels{/name}","comments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/654/comments","events_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/654/events","html_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/654","id":344519301,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzODk1NzE3","number":654,"title":"Smaller lock timeout","user":{"login":"tombentley","id":879487,"node_id":"MDQ6VXNlcjg3OTQ4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/879487?v=4","gravatar_id":"","url":"https://api.github.com/users/tombentley","html_url":"https://github.com/tombentley","followers_url":"https://api.github.com/users/tombentley/followers","following_url":"https://api.github.com/users/tombentley/following{/other_user}","gists_url":"https://api.github.com/users/tombentley/gists{/gist_id}","starred_url":"https://api.github.com/users/tombentley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tombentley/subscriptions","organizations_url":"https://api.github.com/users/tombentley/orgs","repos_url":"https://api.github.com/users/tombentley/repos","events_url":"https://api.github.com/users/tombentley/events{/privacy}","received_events_url":"https://api.github.com/users/tombentley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-25T16:34:03Z","updated_at":"2018-07-25T16:54:57Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/654","html_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/654","diff_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/654.diff","patch_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/654.patch"},"body":"### Type of change\r\n\r\n_Select the type of your PR_\r\n\r\n- Very minor enhancement\r\n\r\n### Description\r\n\r\nDon't bother waiting upto 1 minute to acquire the lock when we're be reconciling again soon enough anyway. Consequently we should stop considering failure to acquire the lock as a warning log event.\r\n\r\n### Checklist\r\n\r\n_Please go through this checklist and make sure all applicable tasks have been done_\r\n\r\n- [ ] Write tests\r\n- [x] Make sure all tests pass\r\n- [ ] Update documentation\r\n- [ ] Check RBAC rights for Kubernetes / OpenShift roles\r\n- [ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally\r\n- [ ] Reference relevant issue(s) and close them after merging\r\n- [ ] Update CHANGELOG.md\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/comments/407823273","html_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/654#issuecomment-407823273","issue_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/654","id":407823273,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzgyMzI3Mw==","user":{"login":"tombentley","id":879487,"node_id":"MDQ6VXNlcjg3OTQ4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/879487?v=4","gravatar_id":"","url":"https://api.github.com/users/tombentley","html_url":"https://github.com/tombentley","followers_url":"https://api.github.com/users/tombentley/followers","following_url":"https://api.github.com/users/tombentley/following{/other_user}","gists_url":"https://api.github.com/users/tombentley/gists{/gist_id}","starred_url":"https://api.github.com/users/tombentley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tombentley/subscriptions","organizations_url":"https://api.github.com/users/tombentley/orgs","repos_url":"https://api.github.com/users/tombentley/repos","events_url":"https://api.github.com/users/tombentley/events{/privacy}","received_events_url":"https://api.github.com/users/tombentley/received_events","type":"User","site_admin":false},"created_at":"2018-07-25T16:54:57Z","updated_at":"2018-07-25T16:54:57Z","author_association":"MEMBER","body":"I thought we could have a background thread which tries to acquire the lock with a long timeout (30 minutes for example). When it does it just releases it immediately (having proved there is no deadlock). If it timesout on the lock acquision we can infer a deadlock and log at the warn or error level. (We could even potentially go so far as to exit the CO process, but that wouldn't guarantee we wouldn't end up back in a deadlock situation when it restarted.)"}}
{"actor":{"display_login":"tombentley"}}