{"action":"opened","number":320,"pull_request":{"url":"https://api.github.com/repos/dagster-io/dagster/pulls/320","id":235159889,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MTU5ODg5","html_url":"https://github.com/dagster-io/dagster/pull/320","diff_url":"https://github.com/dagster-io/dagster/pull/320.diff","patch_url":"https://github.com/dagster-io/dagster/pull/320.patch","issue_url":"https://api.github.com/repos/dagster-io/dagster/issues/320","number":320,"state":"open","locked":false,"title":"Improve config editor YAML support, highlight errors correctly","user":{"login":"bengotow","id":1037212,"node_id":"MDQ6VXNlcjEwMzcyMTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1037212?v=4","gravatar_id":"","url":"https://api.github.com/users/bengotow","html_url":"https://github.com/bengotow","followers_url":"https://api.github.com/users/bengotow/followers","following_url":"https://api.github.com/users/bengotow/following{/other_user}","gists_url":"https://api.github.com/users/bengotow/gists{/gist_id}","starred_url":"https://api.github.com/users/bengotow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bengotow/subscriptions","organizations_url":"https://api.github.com/users/bengotow/orgs","repos_url":"https://api.github.com/users/bengotow/repos","events_url":"https://api.github.com/users/bengotow/events{/privacy}","received_events_url":"https://api.github.com/users/bengotow/received_events","type":"User","site_admin":false},"body":"This PR revamps the YAML tokenizer pretty significantly to clean up syntax highlighting and collect more metadata we can use for autocomplete, etc. I also went through and commented the code, created some helper methods to improve readability ,etc. \r\n\r\nUpdates:\r\n- Correctly support arbitrarily nested YAML inline arrays and objects (the more JSON-like syntax)\r\n\r\n- Reduce dependency on perfect whitespace (exactly one space after colons, before commas, etc.)\r\n\r\n- Expand state to include \"sibling\" keys in the current dict to avoid auto-completing to existing keys in the common case\r\n\r\n- Correctly parse the YAML error stacks and map them in to JS so we get accurate error highlighting (both dict and array element errors).\r\n\r\n<img width=\"485\" alt=\"image\" src=\"https://user-images.githubusercontent.com/1037212/49322751-2cacee00-f4c7-11e8-9c44-2e443ccaf097.png\">\r\n<img width=\"844\" alt=\"image\" src=\"https://user-images.githubusercontent.com/1037212/49322754-35052900-f4c7-11e8-9858-62f3414bd598.png\">\r\n<img width=\"596\" alt=\"image\" src=\"https://user-images.githubusercontent.com/1037212/49322762-3fbfbe00-f4c7-11e8-8171-88df758cc7c7.png\">\r\n<img width=\"463\" alt=\"image\" src=\"https://user-images.githubusercontent.com/1037212/49322770-58c86f00-f4c7-11e8-94b0-847b4e1893dd.png\">\r\n","created_at":"2018-12-01T01:43:59Z","updated_at":"2018-12-01T01:43:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dagster-io/dagster/pulls/320/commits","review_comments_url":"https://api.github.com/repos/dagster-io/dagster/pulls/320/comments","review_comment_url":"https://api.github.com/repos/dagster-io/dagster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dagster-io/dagster/issues/320/comments","statuses_url":"https://api.github.com/repos/dagster-io/dagster/statuses/cf78f76d5650ffe23da96be99dd8a4f2f83fc215","head":{"label":"dagster-io:bengotow/config-yaml-fixes-rb","ref":"bengotow/config-yaml-fixes-rb","sha":"cf78f76d5650ffe23da96be99dd8a4f2f83fc215","user":{"login":"dagster-io","id":40032576,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMDMyNTc2","avatar_url":"https://avatars0.githubusercontent.com/u/40032576?v=4","gravatar_id":"","url":"https://api.github.com/users/dagster-io","html_url":"https://github.com/dagster-io","followers_url":"https://api.github.com/users/dagster-io/followers","following_url":"https://api.github.com/users/dagster-io/following{/other_user}","gists_url":"https://api.github.com/users/dagster-io/gists{/gist_id}","starred_url":"https://api.github.com/users/dagster-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagster-io/subscriptions","organizations_url":"https://api.github.com/users/dagster-io/orgs","repos_url":"https://api.github.com/users/dagster-io/repos","events_url":"https://api.github.com/users/dagster-io/events{/privacy}","received_events_url":"https://api.github.com/users/dagster-io/received_events","type":"Organization","site_admin":false},"repo":{"id":131619646,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE2MTk2NDY=","name":"dagster","full_name":"dagster-io/dagster","private":false,"owner":{"login":"dagster-io","id":40032576,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMDMyNTc2","avatar_url":"https://avatars0.githubusercontent.com/u/40032576?v=4","gravatar_id":"","url":"https://api.github.com/users/dagster-io","html_url":"https://github.com/dagster-io","followers_url":"https://api.github.com/users/dagster-io/followers","following_url":"https://api.github.com/users/dagster-io/following{/other_user}","gists_url":"https://api.github.com/users/dagster-io/gists{/gist_id}","starred_url":"https://api.github.com/users/dagster-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagster-io/subscriptions","organizations_url":"https://api.github.com/users/dagster-io/orgs","repos_url":"https://api.github.com/users/dagster-io/repos","events_url":"https://api.github.com/users/dagster-io/events{/privacy}","received_events_url":"https://api.github.com/users/dagster-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dagster-io/dagster","description":" Dagster is an opinionated system and programming model for data pipelines.","fork":false,"url":"https://api.github.com/repos/dagster-io/dagster","forks_url":"https://api.github.com/repos/dagster-io/dagster/forks","keys_url":"https://api.github.com/repos/dagster-io/dagster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dagster-io/dagster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dagster-io/dagster/teams","hooks_url":"https://api.github.com/repos/dagster-io/dagster/hooks","issue_events_url":"https://api.github.com/repos/dagster-io/dagster/issues/events{/number}","events_url":"https://api.github.com/repos/dagster-io/dagster/events","assignees_url":"https://api.github.com/repos/dagster-io/dagster/assignees{/user}","branches_url":"https://api.github.com/repos/dagster-io/dagster/branches{/branch}","tags_url":"https://api.github.com/repos/dagster-io/dagster/tags","blobs_url":"https://api.github.com/repos/dagster-io/dagster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dagster-io/dagster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dagster-io/dagster/git/refs{/sha}","trees_url":"https://api.github.com/repos/dagster-io/dagster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dagster-io/dagster/statuses/{sha}","languages_url":"https://api.github.com/repos/dagster-io/dagster/languages","stargazers_url":"https://api.github.com/repos/dagster-io/dagster/stargazers","contributors_url":"https://api.github.com/repos/dagster-io/dagster/contributors","subscribers_url":"https://api.github.com/repos/dagster-io/dagster/subscribers","subscription_url":"https://api.github.com/repos/dagster-io/dagster/subscription","commits_url":"https://api.github.com/repos/dagster-io/dagster/commits{/sha}","git_commits_url":"https://api.github.com/repos/dagster-io/dagster/git/commits{/sha}","comments_url":"https://api.github.com/repos/dagster-io/dagster/comments{/number}","issue_comment_url":"https://api.github.com/repos/dagster-io/dagster/issues/comments{/number}","contents_url":"https://api.github.com/repos/dagster-io/dagster/contents/{+path}","compare_url":"https://api.github.com/repos/dagster-io/dagster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dagster-io/dagster/merges","archive_url":"https://api.github.com/repos/dagster-io/dagster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dagster-io/dagster/downloads","issues_url":"https://api.github.com/repos/dagster-io/dagster/issues{/number}","pulls_url":"https://api.github.com/repos/dagster-io/dagster/pulls{/number}","milestones_url":"https://api.github.com/repos/dagster-io/dagster/milestones{/number}","notifications_url":"https://api.github.com/repos/dagster-io/dagster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dagster-io/dagster/labels{/name}","releases_url":"https://api.github.com/repos/dagster-io/dagster/releases{/id}","deployments_url":"https://api.github.com/repos/dagster-io/dagster/deployments","created_at":"2018-04-30T16:30:04Z","updated_at":"2018-11-30T21:32:00Z","pushed_at":"2018-12-01T01:33:50Z","git_url":"git://github.com/dagster-io/dagster.git","ssh_url":"git@github.com:dagster-io/dagster.git","clone_url":"https://github.com/dagster-io/dagster.git","svn_url":"https://github.com/dagster-io/dagster","homepage":"","size":2180,"stargazers_count":46,"watchers_count":46,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":31,"license":null,"forks":3,"open_issues":31,"watchers":46,"default_branch":"master"}},"base":{"label":"dagster-io:master","ref":"master","sha":"e0d33b0c18ef57d7bf988ec125304107bf957dbd","user":{"login":"dagster-io","id":40032576,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMDMyNTc2","avatar_url":"https://avatars0.githubusercontent.com/u/40032576?v=4","gravatar_id":"","url":"https://api.github.com/users/dagster-io","html_url":"https://github.com/dagster-io","followers_url":"https://api.github.com/users/dagster-io/followers","following_url":"https://api.github.com/users/dagster-io/following{/other_user}","gists_url":"https://api.github.com/users/dagster-io/gists{/gist_id}","starred_url":"https://api.github.com/users/dagster-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagster-io/subscriptions","organizations_url":"https://api.github.com/users/dagster-io/orgs","repos_url":"https://api.github.com/users/dagster-io/repos","events_url":"https://api.github.com/users/dagster-io/events{/privacy}","received_events_url":"https://api.github.com/users/dagster-io/received_events","type":"Organization","site_admin":false},"repo":{"id":131619646,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE2MTk2NDY=","name":"dagster","full_name":"dagster-io/dagster","private":false,"owner":{"login":"dagster-io","id":40032576,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMDMyNTc2","avatar_url":"https://avatars0.githubusercontent.com/u/40032576?v=4","gravatar_id":"","url":"https://api.github.com/users/dagster-io","html_url":"https://github.com/dagster-io","followers_url":"https://api.github.com/users/dagster-io/followers","following_url":"https://api.github.com/users/dagster-io/following{/other_user}","gists_url":"https://api.github.com/users/dagster-io/gists{/gist_id}","starred_url":"https://api.github.com/users/dagster-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagster-io/subscriptions","organizations_url":"https://api.github.com/users/dagster-io/orgs","repos_url":"https://api.github.com/users/dagster-io/repos","events_url":"https://api.github.com/users/dagster-io/events{/privacy}","received_events_url":"https://api.github.com/users/dagster-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dagster-io/dagster","description":" Dagster is an opinionated system and programming model for data pipelines.","fork":false,"url":"https://api.github.com/repos/dagster-io/dagster","forks_url":"https://api.github.com/repos/dagster-io/dagster/forks","keys_url":"https://api.github.com/repos/dagster-io/dagster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dagster-io/dagster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dagster-io/dagster/teams","hooks_url":"https://api.github.com/repos/dagster-io/dagster/hooks","issue_events_url":"https://api.github.com/repos/dagster-io/dagster/issues/events{/number}","events_url":"https://api.github.com/repos/dagster-io/dagster/events","assignees_url":"https://api.github.com/repos/dagster-io/dagster/assignees{/user}","branches_url":"https://api.github.com/repos/dagster-io/dagster/branches{/branch}","tags_url":"https://api.github.com/repos/dagster-io/dagster/tags","blobs_url":"https://api.github.com/repos/dagster-io/dagster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dagster-io/dagster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dagster-io/dagster/git/refs{/sha}","trees_url":"https://api.github.com/repos/dagster-io/dagster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dagster-io/dagster/statuses/{sha}","languages_url":"https://api.github.com/repos/dagster-io/dagster/languages","stargazers_url":"https://api.github.com/repos/dagster-io/dagster/stargazers","contributors_url":"https://api.github.com/repos/dagster-io/dagster/contributors","subscribers_url":"https://api.github.com/repos/dagster-io/dagster/subscribers","subscription_url":"https://api.github.com/repos/dagster-io/dagster/subscription","commits_url":"https://api.github.com/repos/dagster-io/dagster/commits{/sha}","git_commits_url":"https://api.github.com/repos/dagster-io/dagster/git/commits{/sha}","comments_url":"https://api.github.com/repos/dagster-io/dagster/comments{/number}","issue_comment_url":"https://api.github.com/repos/dagster-io/dagster/issues/comments{/number}","contents_url":"https://api.github.com/repos/dagster-io/dagster/contents/{+path}","compare_url":"https://api.github.com/repos/dagster-io/dagster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dagster-io/dagster/merges","archive_url":"https://api.github.com/repos/dagster-io/dagster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dagster-io/dagster/downloads","issues_url":"https://api.github.com/repos/dagster-io/dagster/issues{/number}","pulls_url":"https://api.github.com/repos/dagster-io/dagster/pulls{/number}","milestones_url":"https://api.github.com/repos/dagster-io/dagster/milestones{/number}","notifications_url":"https://api.github.com/repos/dagster-io/dagster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dagster-io/dagster/labels{/name}","releases_url":"https://api.github.com/repos/dagster-io/dagster/releases{/id}","deployments_url":"https://api.github.com/repos/dagster-io/dagster/deployments","created_at":"2018-04-30T16:30:04Z","updated_at":"2018-11-30T21:32:00Z","pushed_at":"2018-12-01T01:33:50Z","git_url":"git://github.com/dagster-io/dagster.git","ssh_url":"git@github.com:dagster-io/dagster.git","clone_url":"https://github.com/dagster-io/dagster.git","svn_url":"https://github.com/dagster-io/dagster","homepage":"","size":2180,"stargazers_count":46,"watchers_count":46,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":31,"license":null,"forks":3,"open_issues":31,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dagster-io/dagster/pulls/320"},"html":{"href":"https://github.com/dagster-io/dagster/pull/320"},"issue":{"href":"https://api.github.com/repos/dagster-io/dagster/issues/320"},"comments":{"href":"https://api.github.com/repos/dagster-io/dagster/issues/320/comments"},"review_comments":{"href":"https://api.github.com/repos/dagster-io/dagster/pulls/320/comments"},"review_comment":{"href":"https://api.github.com/repos/dagster-io/dagster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dagster-io/dagster/pulls/320/commits"},"statuses":{"href":"https://api.github.com/repos/dagster-io/dagster/statuses/cf78f76d5650ffe23da96be99dd8a4f2f83fc215"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":257,"deletions":142,"changed_files":5}}
{"actor":{"display_login":"bengotow"}}