{"action":"created","comment":{"url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/pulls/comments/181272125","pull_request_review_id":111852170,"id":181272125,"diff_hunk":"@@ -80,101 +87,99 @@\n  *     at com.uber.cadence.internal.worker.POJOActivityImplementationFactory$POJOActivityImplementation.execute(POJOActivityImplementationFactory.java:162)\n  *\n  * </pre>\n- * Note that there is only one level of wrapping when crossing logical process boundaries. And that wrapper exception\n- * adds a lot of relevant information about failure.\n- * <p>\n- * {@link IOException} is a checked exception. The standard Java way of adding <code>throws IOException</code> to\n- * activity, child and workflow interfaces is not going to help. It is because at all levels it is never received directly, but\n- * in wrapped form. Propagating it without wrapping would not allow adding additional context information\n- * like activity, child workflow and parent workflow  types and IDs. The Cadence library solution is to provide special\n- * wrapper method {@link Workflow#wrap(Exception)} which wraps a checked exception in a special runtime exception.\n- * It is special because framework strips it when chaining exception across logical process boundaries. In this example\n- * IOException is directly attached to ActivityFailureException besides being wrapped when rethrown.\n- * </p>\n+ *\n+ * Note that there is only one level of wrapping when crossing logical process boundaries. And that\n+ * wrapper exception adds a lot of relevant information about failure.\n+ *\n+ * <p>{@link IOException} is a checked exception. The standard Java way of adding <code>\n+ * throws IOException</code> to activity, child and workflow interfaces is not going to help. It is\n+ * because at all levels it is never received directly, but in wrapped form. Propagating it without\n+ * wrapping would not allow adding additional context information like activity, child workflow and\n+ * parent workflow types and IDs. The Cadence library solution is to provide special wrapper method","path":"src/main/java/com/uber/cadence/samples/hello/HelloException.java","position":70,"original_position":70,"commit_id":"98fe7f5264f02b9e46b214e168bb7e45c87d7980","original_commit_id":"98fe7f5264f02b9e46b214e168bb7e45c87d7980","user":{"login":"purplesusan","id":14284852,"avatar_url":"https://avatars2.githubusercontent.com/u/14284852?v=4","gravatar_id":"","url":"https://api.github.com/users/purplesusan","html_url":"https://github.com/purplesusan","followers_url":"https://api.github.com/users/purplesusan/followers","following_url":"https://api.github.com/users/purplesusan/following{/other_user}","gists_url":"https://api.github.com/users/purplesusan/gists{/gist_id}","starred_url":"https://api.github.com/users/purplesusan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purplesusan/subscriptions","organizations_url":"https://api.github.com/users/purplesusan/orgs","repos_url":"https://api.github.com/users/purplesusan/repos","events_url":"https://api.github.com/users/purplesusan/events{/privacy}","received_events_url":"https://api.github.com/users/purplesusan/received_events","type":"User","site_admin":false},"body":"provide special -> provide a special","created_at":"2018-04-13T02:28:45Z","updated_at":"2018-04-13T03:05:00Z","html_url":"https://github.com/mfateev/uber-java-cadence-samples/pull/14#discussion_r181272125","pull_request_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/pulls/14","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/pulls/comments/181272125"},"html":{"href":"https://github.com/mfateev/uber-java-cadence-samples/pull/14#discussion_r181272125"},"pull_request":{"href":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/pulls/14","id":181350329,"html_url":"https://github.com/mfateev/uber-java-cadence-samples/pull/14","diff_url":"https://github.com/mfateev/uber-java-cadence-samples/pull/14.diff","patch_url":"https://github.com/mfateev/uber-java-cadence-samples/pull/14.patch","issue_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/issues/14","number":14,"state":"open","locked":false,"title":"Added unit tests for all samples.","user":{"login":"mfateev","id":1463622,"avatar_url":"https://avatars1.githubusercontent.com/u/1463622?v=4","gravatar_id":"","url":"https://api.github.com/users/mfateev","html_url":"https://github.com/mfateev","followers_url":"https://api.github.com/users/mfateev/followers","following_url":"https://api.github.com/users/mfateev/following{/other_user}","gists_url":"https://api.github.com/users/mfateev/gists{/gist_id}","starred_url":"https://api.github.com/users/mfateev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfateev/subscriptions","organizations_url":"https://api.github.com/users/mfateev/orgs","repos_url":"https://api.github.com/users/mfateev/repos","events_url":"https://api.github.com/users/mfateev/events{/privacy}","received_events_url":"https://api.github.com/users/mfateev/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-12T23:21:41Z","updated_at":"2018-04-13T03:05:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ee7ae4f897631ff85b013567365373cbc305abb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/pulls/14/commits","review_comments_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/pulls/14/comments","review_comment_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/issues/14/comments","statuses_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/statuses/98fe7f5264f02b9e46b214e168bb7e45c87d7980","head":{"label":"mfateev:unit_tests","ref":"unit_tests","sha":"98fe7f5264f02b9e46b214e168bb7e45c87d7980","user":{"login":"mfateev","id":1463622,"avatar_url":"https://avatars1.githubusercontent.com/u/1463622?v=4","gravatar_id":"","url":"https://api.github.com/users/mfateev","html_url":"https://github.com/mfateev","followers_url":"https://api.github.com/users/mfateev/followers","following_url":"https://api.github.com/users/mfateev/following{/other_user}","gists_url":"https://api.github.com/users/mfateev/gists{/gist_id}","starred_url":"https://api.github.com/users/mfateev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfateev/subscriptions","organizations_url":"https://api.github.com/users/mfateev/orgs","repos_url":"https://api.github.com/users/mfateev/repos","events_url":"https://api.github.com/users/mfateev/events{/privacy}","received_events_url":"https://api.github.com/users/mfateev/received_events","type":"User","site_admin":false},"repo":{"id":122117409,"name":"uber-java-cadence-samples","full_name":"mfateev/uber-java-cadence-samples","owner":{"login":"mfateev","id":1463622,"avatar_url":"https://avatars1.githubusercontent.com/u/1463622?v=4","gravatar_id":"","url":"https://api.github.com/users/mfateev","html_url":"https://github.com/mfateev","followers_url":"https://api.github.com/users/mfateev/followers","following_url":"https://api.github.com/users/mfateev/following{/other_user}","gists_url":"https://api.github.com/users/mfateev/gists{/gist_id}","starred_url":"https://api.github.com/users/mfateev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfateev/subscriptions","organizations_url":"https://api.github.com/users/mfateev/orgs","repos_url":"https://api.github.com/users/mfateev/repos","events_url":"https://api.github.com/users/mfateev/events{/privacy}","received_events_url":"https://api.github.com/users/mfateev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mfateev/uber-java-cadence-samples","description":"Samples for Cadence Java Client","fork":false,"url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples","forks_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/forks","keys_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/teams","hooks_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/hooks","issue_events_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/issues/events{/number}","events_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/events","assignees_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/assignees{/user}","branches_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/branches{/branch}","tags_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/tags","blobs_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/statuses/{sha}","languages_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/languages","stargazers_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/stargazers","contributors_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/contributors","subscribers_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/subscribers","subscription_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/subscription","commits_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/contents/{+path}","compare_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/merges","archive_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/downloads","issues_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/issues{/number}","pulls_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/pulls{/number}","milestones_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/milestones{/number}","notifications_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/labels{/name}","releases_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/releases{/id}","deployments_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/deployments","created_at":"2018-02-19T20:36:11Z","updated_at":"2018-03-16T17:04:49Z","pushed_at":"2018-04-12T23:54:14Z","git_url":"git://github.com/mfateev/uber-java-cadence-samples.git","ssh_url":"git@github.com:mfateev/uber-java-cadence-samples.git","clone_url":"https://github.com/mfateev/uber-java-cadence-samples.git","svn_url":"https://github.com/mfateev/uber-java-cadence-samples","homepage":null,"size":591,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"mfateev:master","ref":"master","sha":"f89cd5d09d43bfba7b43b968d7282ccc275518dd","user":{"login":"mfateev","id":1463622,"avatar_url":"https://avatars1.githubusercontent.com/u/1463622?v=4","gravatar_id":"","url":"https://api.github.com/users/mfateev","html_url":"https://github.com/mfateev","followers_url":"https://api.github.com/users/mfateev/followers","following_url":"https://api.github.com/users/mfateev/following{/other_user}","gists_url":"https://api.github.com/users/mfateev/gists{/gist_id}","starred_url":"https://api.github.com/users/mfateev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfateev/subscriptions","organizations_url":"https://api.github.com/users/mfateev/orgs","repos_url":"https://api.github.com/users/mfateev/repos","events_url":"https://api.github.com/users/mfateev/events{/privacy}","received_events_url":"https://api.github.com/users/mfateev/received_events","type":"User","site_admin":false},"repo":{"id":122117409,"name":"uber-java-cadence-samples","full_name":"mfateev/uber-java-cadence-samples","owner":{"login":"mfateev","id":1463622,"avatar_url":"https://avatars1.githubusercontent.com/u/1463622?v=4","gravatar_id":"","url":"https://api.github.com/users/mfateev","html_url":"https://github.com/mfateev","followers_url":"https://api.github.com/users/mfateev/followers","following_url":"https://api.github.com/users/mfateev/following{/other_user}","gists_url":"https://api.github.com/users/mfateev/gists{/gist_id}","starred_url":"https://api.github.com/users/mfateev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfateev/subscriptions","organizations_url":"https://api.github.com/users/mfateev/orgs","repos_url":"https://api.github.com/users/mfateev/repos","events_url":"https://api.github.com/users/mfateev/events{/privacy}","received_events_url":"https://api.github.com/users/mfateev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mfateev/uber-java-cadence-samples","description":"Samples for Cadence Java Client","fork":false,"url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples","forks_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/forks","keys_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/teams","hooks_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/hooks","issue_events_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/issues/events{/number}","events_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/events","assignees_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/assignees{/user}","branches_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/branches{/branch}","tags_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/tags","blobs_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/git/refs{/sha}","trees_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/statuses/{sha}","languages_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/languages","stargazers_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/stargazers","contributors_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/contributors","subscribers_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/subscribers","subscription_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/subscription","commits_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/commits{/sha}","git_commits_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/git/commits{/sha}","comments_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/comments{/number}","issue_comment_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/issues/comments{/number}","contents_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/contents/{+path}","compare_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/merges","archive_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/downloads","issues_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/issues{/number}","pulls_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/pulls{/number}","milestones_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/milestones{/number}","notifications_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/labels{/name}","releases_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/releases{/id}","deployments_url":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/deployments","created_at":"2018-02-19T20:36:11Z","updated_at":"2018-03-16T17:04:49Z","pushed_at":"2018-04-12T23:54:14Z","git_url":"git://github.com/mfateev/uber-java-cadence-samples.git","ssh_url":"git@github.com:mfateev/uber-java-cadence-samples.git","clone_url":"https://github.com/mfateev/uber-java-cadence-samples.git","svn_url":"https://github.com/mfateev/uber-java-cadence-samples","homepage":null,"size":591,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/pulls/14"},"html":{"href":"https://github.com/mfateev/uber-java-cadence-samples/pull/14"},"issue":{"href":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/issues/14"},"comments":{"href":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/mfateev/uber-java-cadence-samples/statuses/98fe7f5264f02b9e46b214e168bb7e45c87d7980"}},"author_association":"OWNER"}}
{"actor":{"display_login":"purplesusan"}}