{"action":"created","comment":{"url":"https://api.github.com/repos/gosu/gosu/pulls/comments/174175699","pull_request_review_id":103483037,"id":174175699,"diff_hunk":"@@ -80,59 +90,7 @@ namespace Gosu\n         //! or low values. Use 1.0 for normal playback speed.\n         Channel play_pan(double pan, double volume = 1, double speed = 1,\n             bool looping = false) const;\n-    };\n-\n-    //! Songs are less flexible than samples. Only Song can be played at any given time,\n-    //! and there is no way to control its pan (stereo position) or speed.\n-    class Song","path":"Gosu/Audio.hpp","position":75,"original_position":75,"commit_id":"f11564fa716e81ec66f8b8add05714d03ed77e8a","original_commit_id":"f11564fa716e81ec66f8b8add05714d03ed77e8a","user":{"login":"jlnr","id":70772,"avatar_url":"https://avatars1.githubusercontent.com/u/70772?v=4","gravatar_id":"","url":"https://api.github.com/users/jlnr","html_url":"https://github.com/jlnr","followers_url":"https://api.github.com/users/jlnr/followers","following_url":"https://api.github.com/users/jlnr/following{/other_user}","gists_url":"https://api.github.com/users/jlnr/gists{/gist_id}","starred_url":"https://api.github.com/users/jlnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlnr/subscriptions","organizations_url":"https://api.github.com/users/jlnr/orgs","repos_url":"https://api.github.com/users/jlnr/repos","events_url":"https://api.github.com/users/jlnr/events{/privacy}","received_events_url":"https://api.github.com/users/jlnr/received_events","type":"User","site_admin":false},"body":"Hmmm...I would say yes. At least for now :)","created_at":"2018-03-13T15:30:00Z","updated_at":"2018-03-13T15:30:00Z","html_url":"https://github.com/gosu/gosu/pull/441#discussion_r174175699","pull_request_url":"https://api.github.com/repos/gosu/gosu/pulls/441","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/gosu/gosu/pulls/comments/174175699"},"html":{"href":"https://github.com/gosu/gosu/pull/441#discussion_r174175699"},"pull_request":{"href":"https://api.github.com/repos/gosu/gosu/pulls/441"}},"in_reply_to_id":174171917},"pull_request":{"url":"https://api.github.com/repos/gosu/gosu/pulls/441","id":174693627,"html_url":"https://github.com/gosu/gosu/pull/441","diff_url":"https://github.com/gosu/gosu/pull/441.diff","patch_url":"https://github.com/gosu/gosu/pull/441.patch","issue_url":"https://api.github.com/repos/gosu/gosu/issues/441","number":441,"state":"open","locked":false,"title":"[WIP] Audio 2.0","user":{"login":"Kjarrigan","id":310475,"avatar_url":"https://avatars0.githubusercontent.com/u/310475?v=4","gravatar_id":"","url":"https://api.github.com/users/Kjarrigan","html_url":"https://github.com/Kjarrigan","followers_url":"https://api.github.com/users/Kjarrigan/followers","following_url":"https://api.github.com/users/Kjarrigan/following{/other_user}","gists_url":"https://api.github.com/users/Kjarrigan/gists{/gist_id}","starred_url":"https://api.github.com/users/Kjarrigan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kjarrigan/subscriptions","organizations_url":"https://api.github.com/users/Kjarrigan/orgs","repos_url":"https://api.github.com/users/Kjarrigan/repos","events_url":"https://api.github.com/users/Kjarrigan/events{/privacy}","received_events_url":"https://api.github.com/users/Kjarrigan/received_events","type":"User","site_admin":false},"body":"As the Sample-Song-Merge is quite a big thing (at least in my opinion) I already start this PR even if there is not much to show at the moment BUT I think its already worth discussing.\r\n\r\nSo here we are. I basically only changed Audio.hpp and test_audio.rb so far to show how I think the final interface would/should look like after merge.","created_at":"2018-03-13T15:18:33Z","updated_at":"2018-03-13T15:30:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd3bbca4e718a14f2328a9205960c06191d1aa5c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":34107212,"url":"https://api.github.com/repos/gosu/gosu/labels/audio","name":"audio","color":"e102d8","default":false},{"id":34107213,"url":"https://api.github.com/repos/gosu/gosu/labels/enhancement","name":"enhancement","color":"c7def8","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/gosu/gosu/pulls/441/commits","review_comments_url":"https://api.github.com/repos/gosu/gosu/pulls/441/comments","review_comment_url":"https://api.github.com/repos/gosu/gosu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gosu/gosu/issues/441/comments","statuses_url":"https://api.github.com/repos/gosu/gosu/statuses/f11564fa716e81ec66f8b8add05714d03ed77e8a","head":{"label":"gosu:audio-2.0","ref":"audio-2.0","sha":"f11564fa716e81ec66f8b8add05714d03ed77e8a","user":{"login":"gosu","id":12500153,"avatar_url":"https://avatars1.githubusercontent.com/u/12500153?v=4","gravatar_id":"","url":"https://api.github.com/users/gosu","html_url":"https://github.com/gosu","followers_url":"https://api.github.com/users/gosu/followers","following_url":"https://api.github.com/users/gosu/following{/other_user}","gists_url":"https://api.github.com/users/gosu/gists{/gist_id}","starred_url":"https://api.github.com/users/gosu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gosu/subscriptions","organizations_url":"https://api.github.com/users/gosu/orgs","repos_url":"https://api.github.com/users/gosu/repos","events_url":"https://api.github.com/users/gosu/events{/privacy}","received_events_url":"https://api.github.com/users/gosu/received_events","type":"Organization","site_admin":false},"repo":{"id":193464,"name":"gosu","full_name":"gosu/gosu","owner":{"login":"gosu","id":12500153,"avatar_url":"https://avatars1.githubusercontent.com/u/12500153?v=4","gravatar_id":"","url":"https://api.github.com/users/gosu","html_url":"https://github.com/gosu","followers_url":"https://api.github.com/users/gosu/followers","following_url":"https://api.github.com/users/gosu/following{/other_user}","gists_url":"https://api.github.com/users/gosu/gists{/gist_id}","starred_url":"https://api.github.com/users/gosu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gosu/subscriptions","organizations_url":"https://api.github.com/users/gosu/orgs","repos_url":"https://api.github.com/users/gosu/repos","events_url":"https://api.github.com/users/gosu/events{/privacy}","received_events_url":"https://api.github.com/users/gosu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gosu/gosu","description":"2D game development library for Ruby and C++","fork":false,"url":"https://api.github.com/repos/gosu/gosu","forks_url":"https://api.github.com/repos/gosu/gosu/forks","keys_url":"https://api.github.com/repos/gosu/gosu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gosu/gosu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gosu/gosu/teams","hooks_url":"https://api.github.com/repos/gosu/gosu/hooks","issue_events_url":"https://api.github.com/repos/gosu/gosu/issues/events{/number}","events_url":"https://api.github.com/repos/gosu/gosu/events","assignees_url":"https://api.github.com/repos/gosu/gosu/assignees{/user}","branches_url":"https://api.github.com/repos/gosu/gosu/branches{/branch}","tags_url":"https://api.github.com/repos/gosu/gosu/tags","blobs_url":"https://api.github.com/repos/gosu/gosu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gosu/gosu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gosu/gosu/git/refs{/sha}","trees_url":"https://api.github.com/repos/gosu/gosu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gosu/gosu/statuses/{sha}","languages_url":"https://api.github.com/repos/gosu/gosu/languages","stargazers_url":"https://api.github.com/repos/gosu/gosu/stargazers","contributors_url":"https://api.github.com/repos/gosu/gosu/contributors","subscribers_url":"https://api.github.com/repos/gosu/gosu/subscribers","subscription_url":"https://api.github.com/repos/gosu/gosu/subscription","commits_url":"https://api.github.com/repos/gosu/gosu/commits{/sha}","git_commits_url":"https://api.github.com/repos/gosu/gosu/git/commits{/sha}","comments_url":"https://api.github.com/repos/gosu/gosu/comments{/number}","issue_comment_url":"https://api.github.com/repos/gosu/gosu/issues/comments{/number}","contents_url":"https://api.github.com/repos/gosu/gosu/contents/{+path}","compare_url":"https://api.github.com/repos/gosu/gosu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gosu/gosu/merges","archive_url":"https://api.github.com/repos/gosu/gosu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gosu/gosu/downloads","issues_url":"https://api.github.com/repos/gosu/gosu/issues{/number}","pulls_url":"https://api.github.com/repos/gosu/gosu/pulls{/number}","milestones_url":"https://api.github.com/repos/gosu/gosu/milestones{/number}","notifications_url":"https://api.github.com/repos/gosu/gosu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gosu/gosu/labels{/name}","releases_url":"https://api.github.com/repos/gosu/gosu/releases{/id}","deployments_url":"https://api.github.com/repos/gosu/gosu/deployments","created_at":"2009-05-05T22:35:44Z","updated_at":"2018-03-13T01:45:47Z","pushed_at":"2018-03-13T15:18:34Z","git_url":"git://github.com/gosu/gosu.git","ssh_url":"git@github.com:gosu/gosu.git","clone_url":"https://github.com/gosu/gosu.git","svn_url":"https://github.com/gosu/gosu","homepage":"https://www.libgosu.org/","size":49241,"stargazers_count":1387,"watchers_count":1387,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":155,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":155,"open_issues":85,"watchers":1387,"default_branch":"master"}},"base":{"label":"gosu:master","ref":"master","sha":"dd0018d25e18135220febab71632a9f25bd0f99f","user":{"login":"gosu","id":12500153,"avatar_url":"https://avatars1.githubusercontent.com/u/12500153?v=4","gravatar_id":"","url":"https://api.github.com/users/gosu","html_url":"https://github.com/gosu","followers_url":"https://api.github.com/users/gosu/followers","following_url":"https://api.github.com/users/gosu/following{/other_user}","gists_url":"https://api.github.com/users/gosu/gists{/gist_id}","starred_url":"https://api.github.com/users/gosu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gosu/subscriptions","organizations_url":"https://api.github.com/users/gosu/orgs","repos_url":"https://api.github.com/users/gosu/repos","events_url":"https://api.github.com/users/gosu/events{/privacy}","received_events_url":"https://api.github.com/users/gosu/received_events","type":"Organization","site_admin":false},"repo":{"id":193464,"name":"gosu","full_name":"gosu/gosu","owner":{"login":"gosu","id":12500153,"avatar_url":"https://avatars1.githubusercontent.com/u/12500153?v=4","gravatar_id":"","url":"https://api.github.com/users/gosu","html_url":"https://github.com/gosu","followers_url":"https://api.github.com/users/gosu/followers","following_url":"https://api.github.com/users/gosu/following{/other_user}","gists_url":"https://api.github.com/users/gosu/gists{/gist_id}","starred_url":"https://api.github.com/users/gosu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gosu/subscriptions","organizations_url":"https://api.github.com/users/gosu/orgs","repos_url":"https://api.github.com/users/gosu/repos","events_url":"https://api.github.com/users/gosu/events{/privacy}","received_events_url":"https://api.github.com/users/gosu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gosu/gosu","description":"2D game development library for Ruby and C++","fork":false,"url":"https://api.github.com/repos/gosu/gosu","forks_url":"https://api.github.com/repos/gosu/gosu/forks","keys_url":"https://api.github.com/repos/gosu/gosu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gosu/gosu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gosu/gosu/teams","hooks_url":"https://api.github.com/repos/gosu/gosu/hooks","issue_events_url":"https://api.github.com/repos/gosu/gosu/issues/events{/number}","events_url":"https://api.github.com/repos/gosu/gosu/events","assignees_url":"https://api.github.com/repos/gosu/gosu/assignees{/user}","branches_url":"https://api.github.com/repos/gosu/gosu/branches{/branch}","tags_url":"https://api.github.com/repos/gosu/gosu/tags","blobs_url":"https://api.github.com/repos/gosu/gosu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gosu/gosu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gosu/gosu/git/refs{/sha}","trees_url":"https://api.github.com/repos/gosu/gosu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gosu/gosu/statuses/{sha}","languages_url":"https://api.github.com/repos/gosu/gosu/languages","stargazers_url":"https://api.github.com/repos/gosu/gosu/stargazers","contributors_url":"https://api.github.com/repos/gosu/gosu/contributors","subscribers_url":"https://api.github.com/repos/gosu/gosu/subscribers","subscription_url":"https://api.github.com/repos/gosu/gosu/subscription","commits_url":"https://api.github.com/repos/gosu/gosu/commits{/sha}","git_commits_url":"https://api.github.com/repos/gosu/gosu/git/commits{/sha}","comments_url":"https://api.github.com/repos/gosu/gosu/comments{/number}","issue_comment_url":"https://api.github.com/repos/gosu/gosu/issues/comments{/number}","contents_url":"https://api.github.com/repos/gosu/gosu/contents/{+path}","compare_url":"https://api.github.com/repos/gosu/gosu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gosu/gosu/merges","archive_url":"https://api.github.com/repos/gosu/gosu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gosu/gosu/downloads","issues_url":"https://api.github.com/repos/gosu/gosu/issues{/number}","pulls_url":"https://api.github.com/repos/gosu/gosu/pulls{/number}","milestones_url":"https://api.github.com/repos/gosu/gosu/milestones{/number}","notifications_url":"https://api.github.com/repos/gosu/gosu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gosu/gosu/labels{/name}","releases_url":"https://api.github.com/repos/gosu/gosu/releases{/id}","deployments_url":"https://api.github.com/repos/gosu/gosu/deployments","created_at":"2009-05-05T22:35:44Z","updated_at":"2018-03-13T01:45:47Z","pushed_at":"2018-03-13T15:18:34Z","git_url":"git://github.com/gosu/gosu.git","ssh_url":"git@github.com:gosu/gosu.git","clone_url":"https://github.com/gosu/gosu.git","svn_url":"https://github.com/gosu/gosu","homepage":"https://www.libgosu.org/","size":49241,"stargazers_count":1387,"watchers_count":1387,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":155,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":155,"open_issues":85,"watchers":1387,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gosu/gosu/pulls/441"},"html":{"href":"https://github.com/gosu/gosu/pull/441"},"issue":{"href":"https://api.github.com/repos/gosu/gosu/issues/441"},"comments":{"href":"https://api.github.com/repos/gosu/gosu/issues/441/comments"},"review_comments":{"href":"https://api.github.com/repos/gosu/gosu/pulls/441/comments"},"review_comment":{"href":"https://api.github.com/repos/gosu/gosu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gosu/gosu/pulls/441/commits"},"statuses":{"href":"https://api.github.com/repos/gosu/gosu/statuses/f11564fa716e81ec66f8b8add05714d03ed77e8a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jlnr"}}