{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/57213","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/57213/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/57213/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/57213/events","html_url":"https://github.com/rust-lang/rust/pull/57213","id":394865373,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDg3MDcw","number":57213,"title":"submodules: update clippy from f7bdf500 to 39bd8449","user":{"login":"matthiaskrgr","id":476013,"node_id":"MDQ6VXNlcjQ3NjAxMw==","avatar_url":"https://avatars2.githubusercontent.com/u/476013?v=4","gravatar_id":"","url":"https://api.github.com/users/matthiaskrgr","html_url":"https://github.com/matthiaskrgr","followers_url":"https://api.github.com/users/matthiaskrgr/followers","following_url":"https://api.github.com/users/matthiaskrgr/following{/other_user}","gists_url":"https://api.github.com/users/matthiaskrgr/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiaskrgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiaskrgr/subscriptions","organizations_url":"https://api.github.com/users/matthiaskrgr/orgs","repos_url":"https://api.github.com/users/matthiaskrgr/repos","events_url":"https://api.github.com/users/matthiaskrgr/events{/privacy}","received_events_url":"https://api.github.com/users/matthiaskrgr/received_events","type":"User","site_admin":false},"labels":[{"id":583437191,"node_id":"MDU6TGFiZWw1ODM0MzcxOTE=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-bors","name":"S-waiting-on-bors","color":"d3dddd","default":false}],"state":"closed","locked":false,"assignee":{"login":"oli-obk","id":332036,"node_id":"MDQ6VXNlcjMzMjAzNg==","avatar_url":"https://avatars2.githubusercontent.com/u/332036?v=4","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"assignees":[{"login":"oli-obk","id":332036,"node_id":"MDQ6VXNlcjMzMjAzNg==","avatar_url":"https://avatars2.githubusercontent.com/u/332036?v=4","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-12-30T11:39:24Z","updated_at":"2018-12-30T21:38:50Z","closed_at":"2018-12-30T21:37:29Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/57213","html_url":"https://github.com/rust-lang/rust/pull/57213","diff_url":"https://github.com/rust-lang/rust/pull/57213.diff","patch_url":"https://github.com/rust-lang/rust/pull/57213.patch"},"body":"Fixes clippy toolstate\r\n\r\nChanges:\r\n````\r\nUI test cleanup: Extract iter_skip_next from methods.rs\r\nUpdate test output after rebase\r\nRemove false negatives from known problems\r\nImplement use_self for tuple structs\r\nDocument known problems\r\nrustup https://github.com/rust-lang/rust/pull/56225/\r\nRemove unnecessary `use` statements after `cargo fix`\r\nApply cargo fix --edition-idioms fixes\r\nUse match ergonomics for booleans lint\r\nUse match ergonomics for block_in_if_condition lint\r\nUse match ergonomics for bit_mask lint\r\nUse match ergonomics for attrs lint\r\nUse match ergonomics for assign_ops lint\r\nUse match ergonomics for artithmetic lint\r\nUse match ergonomics for approx_const lint\r\nRemove crate:: prefixes from crate paths\r\nSupport array indexing expressions in unused write to a constant\r\nMark writes to constants as side-effect-less\r\nUpdate README local run command to remove syspath\r\nRemove unsafe from consts clippy lints\r\nFix formatting\r\nMerge new_without_default_derive into new_without_default\r\nOnly print out question_mark lint when it actually triggered\r\nAdd failing test\r\nReinserted commata\r\nRecomend `.as_ref()?` in certain situations\r\nDeduplicate some code?\r\n````\r\nr? @oli-obk or anyone else"},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/450588364","html_url":"https://github.com/rust-lang/rust/pull/57213#issuecomment-450588364","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/57213","id":450588364,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDU4ODM2NA==","user":{"login":"rust-highfive","id":7378925,"node_id":"MDQ6VXNlcjczNzg5MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/7378925?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-highfive","html_url":"https://github.com/rust-highfive","followers_url":"https://api.github.com/users/rust-highfive/followers","following_url":"https://api.github.com/users/rust-highfive/following{/other_user}","gists_url":"https://api.github.com/users/rust-highfive/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-highfive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-highfive/subscriptions","organizations_url":"https://api.github.com/users/rust-highfive/orgs","repos_url":"https://api.github.com/users/rust-highfive/repos","events_url":"https://api.github.com/users/rust-highfive/events{/privacy}","received_events_url":"https://api.github.com/users/rust-highfive/received_events","type":"User","site_admin":false},"created_at":"2018-12-30T21:38:50Z","updated_at":"2018-12-30T21:38:50Z","author_association":"COLLABORATOR","body":"📣 Toolstate changed by rust-lang/rust#57213!\n\nTested on commit rust-lang/rust@a2b0f247bf741a1a9729363dda8628a938f1fe58.\nDirect link to PR: <https://github.com/rust-lang/rust/pull/57213>\n\n🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).\n🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).\n🎉 rls on windows: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).\n🎉 rls on linux: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).\n"}}
{"actor":{"display_login":"rust-highfive"}}