{"action":"created","issue":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/12093","repository_url":"https://api.github.com/repos/MarlinFirmware/Marlin","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/12093/labels{/name}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/12093/comments","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/12093/events","html_url":"https://github.com/MarlinFirmware/Marlin/pull/12093","id":369930306,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzM0Mjcz","number":12093,"title":"[HAL][LPC176x] Pull out framework, improve build, fix things","user":{"login":"p3p","id":24342,"node_id":"MDQ6VXNlcjI0MzQy","avatar_url":"https://avatars1.githubusercontent.com/u/24342?v=4","gravatar_id":"","url":"https://api.github.com/users/p3p","html_url":"https://github.com/p3p","followers_url":"https://api.github.com/users/p3p/followers","following_url":"https://api.github.com/users/p3p/following{/other_user}","gists_url":"https://api.github.com/users/p3p/gists{/gist_id}","starred_url":"https://api.github.com/users/p3p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p3p/subscriptions","organizations_url":"https://api.github.com/users/p3p/orgs","repos_url":"https://api.github.com/users/p3p/repos","events_url":"https://api.github.com/users/p3p/events{/privacy}","received_events_url":"https://api.github.com/users/p3p/received_events","type":"User","site_admin":false},"labels":[{"id":92052497,"node_id":"MDU6TGFiZWw5MjA1MjQ5Nw==","url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/PR:%20Improvement","name":"PR: Improvement","color":"c2e0c6","default":false},{"id":493671913,"node_id":"MDU6TGFiZWw0OTM2NzE5MTM=","url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/T:%2032-Bit%20&%20HAL","name":"T: 32-Bit & HAL","color":"763cbc","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-10-14T18:35:23Z","updated_at":"2018-10-17T19:19:39Z","closed_at":"2018-10-14T22:57:22Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/12093","html_url":"https://github.com/MarlinFirmware/Marlin/pull/12093","diff_url":"https://github.com/MarlinFirmware/Marlin/pull/12093.diff","patch_url":"https://github.com/MarlinFirmware/Marlin/pull/12093.patch"},"body":"### Description\r\nThe PR moves the CMSIS framework and other LPC176x specific code into an external repository, implementing a custom PlatformIO platform and arduino framework aiming to be be mostly Arduino API compatible (only the public API tricks used by libraries will still cause many problems as it does with DUE etc). This is still a work in progress but there are so many bugfixes and improvements at this point that I can't really wait any longer to merge, (too many issues coming up that are fixed).\r\n\r\n### Benefits\r\n- Clean up the platforms directory to include only HAL related items\r\n- Clean up the build system, enforcing order of inclusion \r\n- Updates to the USB system (mostly @gloomyandy's work)\r\n  - addresses various timeout issues\r\n  - usb will now always reconnect on board reset\r\n  - fixes cdc serial transmission errors\r\n  - can use onboard sd card for gcode while sharing it with host as usb drive, needs unmounted on Marlin to access with host, Marlin takes priority\r\n- Default to using flash EEPROM emulation as it is more reliable\r\n- PWM is now compatible with all 6 hardware channels on any compatible pin with transparent fallback onto the 20 interrupt driven channels, if hardware channel is busy or not available.\r\n- All the things I've forgotten about\r\n\r\n### Related Issues\r\nThis is a major overhaul of the platform and how it builds, it more than likely fixed things I don't know about and broke other things that I will soon know about.\r\n\r\nI've added a near duplication of the LPC1768 pio build environment for the LPC1769, though I may rethink it if people deem it unnecessary, Marlin code assume F_CPU is a constant and that any calculation it is used in (there are lots) with be optimised away, if F_CPU has to assigned at run-time these calculations (maybe in ISRs) are not optimised."},"comment":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments/430755232","html_url":"https://github.com/MarlinFirmware/Marlin/pull/12093#issuecomment-430755232","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/12093","id":430755232,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDc1NTIzMg==","user":{"login":"p3p","id":24342,"node_id":"MDQ6VXNlcjI0MzQy","avatar_url":"https://avatars1.githubusercontent.com/u/24342?v=4","gravatar_id":"","url":"https://api.github.com/users/p3p","html_url":"https://github.com/p3p","followers_url":"https://api.github.com/users/p3p/followers","following_url":"https://api.github.com/users/p3p/following{/other_user}","gists_url":"https://api.github.com/users/p3p/gists{/gist_id}","starred_url":"https://api.github.com/users/p3p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p3p/subscriptions","organizations_url":"https://api.github.com/users/p3p/orgs","repos_url":"https://api.github.com/users/p3p/repos","events_url":"https://api.github.com/users/p3p/events{/privacy}","received_events_url":"https://api.github.com/users/p3p/received_events","type":"User","site_admin":false},"created_at":"2018-10-17T19:19:39Z","updated_at":"2018-10-17T19:19:39Z","author_association":"MEMBER","body":"^^ no problem, are you going to put a PR in with what you needed changed for your board? I really need to get all the LPC176x boards updated with appropriate default settings for the shared usb ect. "}}
{"actor":{"display_login":"p3p"}}