{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/comments/178053078","pull_request_review_id":108044059,"id":178053078,"diff_hunk":"@@ -87,12 +96,13 @@ task prepare_genbank {\n   Array[File]+ assemblies_fasta\n   Array[File]+ annotations_tbl\n   File         authors_sbt\n-  File?        coverage_table # summary.assembly.txt (from Snakemake)\n-  File?        genbankSourceTable\n-  File?        biosampleMap\n-  String?      sequencingTech\n-  String?      comment\n-  String       out_prefix = \"ncbi_package\"\n+  File         biosampleMap\n+  File         genbankSourceTable\n+  File?        coverage_table # summary.assembly.txt (from Snakemake) -- change this to accept a list of mapped bam files and we can create this table ourselves\n+  String       sequencingTech\n+  String       comment # TO DO: make this optional","path":"pipes/WDL/workflows/tasks/ncbi.wdl","position":57,"original_position":57,"commit_id":"b660097d1212fbd0185288aa1efdd0a5bf827581","original_commit_id":"b660097d1212fbd0185288aa1efdd0a5bf827581","user":{"login":"tomkinsc","id":53064,"avatar_url":"https://avatars3.githubusercontent.com/u/53064?v=4","gravatar_id":"","url":"https://api.github.com/users/tomkinsc","html_url":"https://github.com/tomkinsc","followers_url":"https://api.github.com/users/tomkinsc/followers","following_url":"https://api.github.com/users/tomkinsc/following{/other_user}","gists_url":"https://api.github.com/users/tomkinsc/gists{/gist_id}","starred_url":"https://api.github.com/users/tomkinsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomkinsc/subscriptions","organizations_url":"https://api.github.com/users/tomkinsc/orgs","repos_url":"https://api.github.com/users/tomkinsc/repos","events_url":"https://api.github.com/users/tomkinsc/events{/privacy}","received_events_url":"https://api.github.com/users/tomkinsc/received_events","type":"User","site_admin":false},"body":"What is blocking this from being optional, or having a default placeholder value?","created_at":"2018-03-29T13:22:07Z","updated_at":"2018-03-29T13:43:07Z","html_url":"https://github.com/broadinstitute/viral-ngs/pull/800#discussion_r178053078","pull_request_url":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/800","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/comments/178053078"},"html":{"href":"https://github.com/broadinstitute/viral-ngs/pull/800#discussion_r178053078"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/800"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/800","id":177169797,"html_url":"https://github.com/broadinstitute/viral-ngs/pull/800","diff_url":"https://github.com/broadinstitute/viral-ngs/pull/800.diff","patch_url":"https://github.com/broadinstitute/viral-ngs/pull/800.patch","issue_url":"https://api.github.com/repos/broadinstitute/viral-ngs/issues/800","number":800,"state":"open","locked":false,"title":"genbank and other new WDL workflows","user":{"login":"dpark01","id":8513746,"avatar_url":"https://avatars2.githubusercontent.com/u/8513746?v=4","gravatar_id":"","url":"https://api.github.com/users/dpark01","html_url":"https://github.com/dpark01","followers_url":"https://api.github.com/users/dpark01/followers","following_url":"https://api.github.com/users/dpark01/following{/other_user}","gists_url":"https://api.github.com/users/dpark01/gists{/gist_id}","starred_url":"https://api.github.com/users/dpark01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpark01/subscriptions","organizations_url":"https://api.github.com/users/dpark01/orgs","repos_url":"https://api.github.com/users/dpark01/repos","events_url":"https://api.github.com/users/dpark01/events{/privacy}","received_events_url":"https://api.github.com/users/dpark01/received_events","type":"User","site_admin":false},"body":"Adds WDL workflows for:\r\n- coverage_table: some basic coverage stats on a list of assemblies, similar to Snakemake reports_only\r\n- mafft: multiple alignment of N genomes, possibly multi-segment (produces one alignment per segment)\r\n- genbank: produce a Genbank submission file set with their tbl2asn tool given the proper inputs: assemblies, a reference genome and reference annotations to transfer, and required metadata for submission [fixes #793]\r\n- merge_bams: a simple task for merging bam files and reheadering read group metadata using a flat file mapping table. both the merging and reheadering are optional.","created_at":"2018-03-23T19:55:33Z","updated_at":"2018-03-29T13:43:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93dcf0f9a3a788f94c5d0fb30dd6a06d0029bfe5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/800/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/800/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/viral-ngs/issues/800/comments","statuses_url":"https://api.github.com/repos/broadinstitute/viral-ngs/statuses/b660097d1212fbd0185288aa1efdd0a5bf827581","head":{"label":"broadinstitute:dp-genbank","ref":"dp-genbank","sha":"b660097d1212fbd0185288aa1efdd0a5bf827581","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":24471201,"name":"viral-ngs","full_name":"broadinstitute/viral-ngs","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/viral-ngs","description":"Viral genomics analysis pipelines","fork":false,"url":"https://api.github.com/repos/broadinstitute/viral-ngs","forks_url":"https://api.github.com/repos/broadinstitute/viral-ngs/forks","keys_url":"https://api.github.com/repos/broadinstitute/viral-ngs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/viral-ngs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/viral-ngs/teams","hooks_url":"https://api.github.com/repos/broadinstitute/viral-ngs/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/viral-ngs/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/viral-ngs/events","assignees_url":"https://api.github.com/repos/broadinstitute/viral-ngs/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/viral-ngs/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/viral-ngs/tags","blobs_url":"https://api.github.com/repos/broadinstitute/viral-ngs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/viral-ngs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/viral-ngs/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/viral-ngs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/viral-ngs/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/viral-ngs/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/viral-ngs/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/viral-ngs/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/viral-ngs/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/viral-ngs/subscription","commits_url":"https://api.github.com/repos/broadinstitute/viral-ngs/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/viral-ngs/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/viral-ngs/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/viral-ngs/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/viral-ngs/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/viral-ngs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/viral-ngs/merges","archive_url":"https://api.github.com/repos/broadinstitute/viral-ngs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/viral-ngs/downloads","issues_url":"https://api.github.com/repos/broadinstitute/viral-ngs/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/viral-ngs/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/viral-ngs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/viral-ngs/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/viral-ngs/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/viral-ngs/deployments","created_at":"2014-09-25T19:00:24Z","updated_at":"2018-03-28T18:40:53Z","pushed_at":"2018-03-29T01:24:46Z","git_url":"git://github.com/broadinstitute/viral-ngs.git","ssh_url":"git@github.com:broadinstitute/viral-ngs.git","clone_url":"https://github.com/broadinstitute/viral-ngs.git","svn_url":"https://github.com/broadinstitute/viral-ngs","homepage":"","size":59475,"stargazers_count":66,"watchers_count":66,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":24,"open_issues":41,"watchers":66,"default_branch":"master"}},"base":{"label":"broadinstitute:master","ref":"master","sha":"933667f547cacb97ed4ef1e73014f9ffe9bc3bc5","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":24471201,"name":"viral-ngs","full_name":"broadinstitute/viral-ngs","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/viral-ngs","description":"Viral genomics analysis pipelines","fork":false,"url":"https://api.github.com/repos/broadinstitute/viral-ngs","forks_url":"https://api.github.com/repos/broadinstitute/viral-ngs/forks","keys_url":"https://api.github.com/repos/broadinstitute/viral-ngs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/viral-ngs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/viral-ngs/teams","hooks_url":"https://api.github.com/repos/broadinstitute/viral-ngs/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/viral-ngs/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/viral-ngs/events","assignees_url":"https://api.github.com/repos/broadinstitute/viral-ngs/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/viral-ngs/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/viral-ngs/tags","blobs_url":"https://api.github.com/repos/broadinstitute/viral-ngs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/viral-ngs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/viral-ngs/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/viral-ngs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/viral-ngs/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/viral-ngs/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/viral-ngs/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/viral-ngs/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/viral-ngs/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/viral-ngs/subscription","commits_url":"https://api.github.com/repos/broadinstitute/viral-ngs/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/viral-ngs/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/viral-ngs/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/viral-ngs/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/viral-ngs/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/viral-ngs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/viral-ngs/merges","archive_url":"https://api.github.com/repos/broadinstitute/viral-ngs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/viral-ngs/downloads","issues_url":"https://api.github.com/repos/broadinstitute/viral-ngs/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/viral-ngs/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/viral-ngs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/viral-ngs/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/viral-ngs/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/viral-ngs/deployments","created_at":"2014-09-25T19:00:24Z","updated_at":"2018-03-28T18:40:53Z","pushed_at":"2018-03-29T01:24:46Z","git_url":"git://github.com/broadinstitute/viral-ngs.git","ssh_url":"git@github.com:broadinstitute/viral-ngs.git","clone_url":"https://github.com/broadinstitute/viral-ngs.git","svn_url":"https://github.com/broadinstitute/viral-ngs","homepage":"","size":59475,"stargazers_count":66,"watchers_count":66,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":24,"open_issues":41,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/800"},"html":{"href":"https://github.com/broadinstitute/viral-ngs/pull/800"},"issue":{"href":"https://api.github.com/repos/broadinstitute/viral-ngs/issues/800"},"comments":{"href":"https://api.github.com/repos/broadinstitute/viral-ngs/issues/800/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/800/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/viral-ngs/pulls/800/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/viral-ngs/statuses/b660097d1212fbd0185288aa1efdd0a5bf827581"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tomkinsc"}}