{"action":"created","comment":{"url":"https://api.github.com/repos/rubocop-hq/rubocop/pulls/comments/232685494","pull_request_review_id":173934686,"id":232685494,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjY4NTQ5NA==","diff_hunk":"@@ -0,0 +1,56 @@\n+# frozen_string_literal: true\n+\n+module RuboCop\n+  module Cop\n+    module Naming\n+      # This cop checks whether constant names are written using\n+      # clearer wording.\n+      #\n+      # @example\n+      #   # bad\n+      #   Whitelist = []\n+      #   WhiteList = []\n+      #   Whitelisted = []\n+      #   Blacklist = []\n+      #   BLACKLISTED = []\n+      #\n+      #   # good\n+      #   Allowlist = []\n+      #   PermittedList = []\n+      #   Denylist = []\n+      class ConstantWording < Cop\n+        MSG = 'Please use clearer names for constants.'.freeze\n+\n+        def on_casgn(node)\n+          constant_name = get_constant_name(node)\n+\n+          add_offense(node, location: :name) if not_clear?(constant_name)\n+        end\n+\n+        private\n+\n+        NAME_DENY_LIST = %i[","path":"lib/rubocop/cop/naming/constant_wording.rb","position":32,"original_position":32,"commit_id":"710d2315d0687d1745097f71a01a09e6c6f5de8b","original_commit_id":"710d2315d0687d1745097f71a01a09e6c6f5de8b","user":{"login":"JuanitoFatas","id":1000669,"node_id":"MDQ6VXNlcjEwMDA2Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1000669?v=4","gravatar_id":"","url":"https://api.github.com/users/JuanitoFatas","html_url":"https://github.com/JuanitoFatas","followers_url":"https://api.github.com/users/JuanitoFatas/followers","following_url":"https://api.github.com/users/JuanitoFatas/following{/other_user}","gists_url":"https://api.github.com/users/JuanitoFatas/gists{/gist_id}","starred_url":"https://api.github.com/users/JuanitoFatas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuanitoFatas/subscriptions","organizations_url":"https://api.github.com/users/JuanitoFatas/orgs","repos_url":"https://api.github.com/users/JuanitoFatas/repos","events_url":"https://api.github.com/users/JuanitoFatas/events{/privacy}","received_events_url":"https://api.github.com/users/JuanitoFatas/received_events","type":"User","site_admin":false},"body":"Sounds good to me :) Any existing example of passing in a parameter map?","created_at":"2018-11-12T14:49:12Z","updated_at":"2018-11-12T14:49:12Z","html_url":"https://github.com/rubocop-hq/rubocop/pull/6473#discussion_r232685494","pull_request_url":"https://api.github.com/repos/rubocop-hq/rubocop/pulls/6473","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rubocop-hq/rubocop/pulls/comments/232685494"},"html":{"href":"https://github.com/rubocop-hq/rubocop/pull/6473#discussion_r232685494"},"pull_request":{"href":"https://api.github.com/repos/rubocop-hq/rubocop/pulls/6473"}},"in_reply_to_id":232679419},"pull_request":{"url":"https://api.github.com/repos/rubocop-hq/rubocop/pulls/6473","id":230141588,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMTQxNTg4","html_url":"https://github.com/rubocop-hq/rubocop/pull/6473","diff_url":"https://github.com/rubocop-hq/rubocop/pull/6473.diff","patch_url":"https://github.com/rubocop-hq/rubocop/pull/6473.patch","issue_url":"https://api.github.com/repos/rubocop-hq/rubocop/issues/6473","number":6473,"state":"open","locked":false,"title":"Introducing Naming/ConstantWording cop","user":{"login":"JuanitoFatas","id":1000669,"node_id":"MDQ6VXNlcjEwMDA2Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1000669?v=4","gravatar_id":"","url":"https://api.github.com/users/JuanitoFatas","html_url":"https://github.com/JuanitoFatas","followers_url":"https://api.github.com/users/JuanitoFatas/followers","following_url":"https://api.github.com/users/JuanitoFatas/following{/other_user}","gists_url":"https://api.github.com/users/JuanitoFatas/gists{/gist_id}","starred_url":"https://api.github.com/users/JuanitoFatas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuanitoFatas/subscriptions","organizations_url":"https://api.github.com/users/JuanitoFatas/orgs","repos_url":"https://api.github.com/users/JuanitoFatas/repos","events_url":"https://api.github.com/users/JuanitoFatas/events{/privacy}","received_events_url":"https://api.github.com/users/JuanitoFatas/received_events","type":"User","site_admin":false},"body":"Follow up of https://github.com/rubocop-hq/rubocop/pull/6466#issuecomment-437805394. \r\n\r\nIntroduce this cop to promote clearer and more descriptive constant naming, as some of the [historical words do not convey the meaning well](https://twitter.com/dhh/status/1032050325513940992). Another [example from JavaScript community](https://github.com/facebook/react/issues/13604).\r\n\r\n710d231 fixed a constant naming found by this new cop.\r\n\r\nBefore submitting the PR make sure the following are checked:\r\n\r\n* [x] Wrote [good commit messages][1].\r\n* [ ] Commit message starts with `[Fix #issue-number]` (if the related issue exists).\r\n* [x] Feature branch is up-to-date with `master` (if not - rebase it).\r\n* [x] Squashed related commits together.\r\n* [x] Added tests.\r\n* [x] Added an entry to the [Changelog](../blob/master/CHANGELOG.md) if the new code introduces user-observable changes. See [changelog entry format](../blob/master/CONTRIBUTING.md#changelog-entry-format).\r\n* [x] The PR relates to *only* one subject with a clear title\r\n  and description in grammatically correct, complete sentences.\r\n* [x] Run `bundle exec rake default`. It executes all tests and RuboCop for itself, and generates the documentation.\r\n\r\n[1]: https://chris.beams.io/posts/git-commit/\r\n","created_at":"2018-11-12T13:53:11Z","updated_at":"2018-11-12T14:49:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1de4d3132965435dc38ae0629c7c58acc477bcae","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rubocop-hq/rubocop/pulls/6473/commits","review_comments_url":"https://api.github.com/repos/rubocop-hq/rubocop/pulls/6473/comments","review_comment_url":"https://api.github.com/repos/rubocop-hq/rubocop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubocop-hq/rubocop/issues/6473/comments","statuses_url":"https://api.github.com/repos/rubocop-hq/rubocop/statuses/710d2315d0687d1745097f71a01a09e6c6f5de8b","head":{"label":"JuanitoFatas:cop/wording-constant","ref":"cop/wording-constant","sha":"710d2315d0687d1745097f71a01a09e6c6f5de8b","user":{"login":"JuanitoFatas","id":1000669,"node_id":"MDQ6VXNlcjEwMDA2Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1000669?v=4","gravatar_id":"","url":"https://api.github.com/users/JuanitoFatas","html_url":"https://github.com/JuanitoFatas","followers_url":"https://api.github.com/users/JuanitoFatas/followers","following_url":"https://api.github.com/users/JuanitoFatas/following{/other_user}","gists_url":"https://api.github.com/users/JuanitoFatas/gists{/gist_id}","starred_url":"https://api.github.com/users/JuanitoFatas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuanitoFatas/subscriptions","organizations_url":"https://api.github.com/users/JuanitoFatas/orgs","repos_url":"https://api.github.com/users/JuanitoFatas/repos","events_url":"https://api.github.com/users/JuanitoFatas/events{/privacy}","received_events_url":"https://api.github.com/users/JuanitoFatas/received_events","type":"User","site_admin":false},"repo":{"id":156861960,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY4NjE5NjA=","name":"rubocop","full_name":"JuanitoFatas/rubocop","private":false,"owner":{"login":"JuanitoFatas","id":1000669,"node_id":"MDQ6VXNlcjEwMDA2Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1000669?v=4","gravatar_id":"","url":"https://api.github.com/users/JuanitoFatas","html_url":"https://github.com/JuanitoFatas","followers_url":"https://api.github.com/users/JuanitoFatas/followers","following_url":"https://api.github.com/users/JuanitoFatas/following{/other_user}","gists_url":"https://api.github.com/users/JuanitoFatas/gists{/gist_id}","starred_url":"https://api.github.com/users/JuanitoFatas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuanitoFatas/subscriptions","organizations_url":"https://api.github.com/users/JuanitoFatas/orgs","repos_url":"https://api.github.com/users/JuanitoFatas/repos","events_url":"https://api.github.com/users/JuanitoFatas/events{/privacy}","received_events_url":"https://api.github.com/users/JuanitoFatas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JuanitoFatas/rubocop","description":"A Ruby static code analyzer and formatter, based on the community Ruby style guide.","fork":true,"url":"https://api.github.com/repos/JuanitoFatas/rubocop","forks_url":"https://api.github.com/repos/JuanitoFatas/rubocop/forks","keys_url":"https://api.github.com/repos/JuanitoFatas/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuanitoFatas/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuanitoFatas/rubocop/teams","hooks_url":"https://api.github.com/repos/JuanitoFatas/rubocop/hooks","issue_events_url":"https://api.github.com/repos/JuanitoFatas/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/JuanitoFatas/rubocop/events","assignees_url":"https://api.github.com/repos/JuanitoFatas/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/JuanitoFatas/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/JuanitoFatas/rubocop/tags","blobs_url":"https://api.github.com/repos/JuanitoFatas/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuanitoFatas/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuanitoFatas/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuanitoFatas/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuanitoFatas/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/JuanitoFatas/rubocop/languages","stargazers_url":"https://api.github.com/repos/JuanitoFatas/rubocop/stargazers","contributors_url":"https://api.github.com/repos/JuanitoFatas/rubocop/contributors","subscribers_url":"https://api.github.com/repos/JuanitoFatas/rubocop/subscribers","subscription_url":"https://api.github.com/repos/JuanitoFatas/rubocop/subscription","commits_url":"https://api.github.com/repos/JuanitoFatas/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuanitoFatas/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuanitoFatas/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuanitoFatas/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuanitoFatas/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/JuanitoFatas/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuanitoFatas/rubocop/merges","archive_url":"https://api.github.com/repos/JuanitoFatas/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuanitoFatas/rubocop/downloads","issues_url":"https://api.github.com/repos/JuanitoFatas/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/JuanitoFatas/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/JuanitoFatas/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/JuanitoFatas/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuanitoFatas/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/JuanitoFatas/rubocop/releases{/id}","deployments_url":"https://api.github.com/repos/JuanitoFatas/rubocop/deployments","created_at":"2018-11-09T12:54:34Z","updated_at":"2018-11-09T12:54:40Z","pushed_at":"2018-11-12T14:14:30Z","git_url":"git://github.com/JuanitoFatas/rubocop.git","ssh_url":"git@github.com:JuanitoFatas/rubocop.git","clone_url":"https://github.com/JuanitoFatas/rubocop.git","svn_url":"https://github.com/JuanitoFatas/rubocop","homepage":"https://docs.rubocop.org","size":24101,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rubocop-hq:master","ref":"master","sha":"b83ba76edbb3ce0932db13d96c17f632119d16fa","user":{"login":"rubocop-hq","id":39672756,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NjcyNzU2","avatar_url":"https://avatars3.githubusercontent.com/u/39672756?v=4","gravatar_id":"","url":"https://api.github.com/users/rubocop-hq","html_url":"https://github.com/rubocop-hq","followers_url":"https://api.github.com/users/rubocop-hq/followers","following_url":"https://api.github.com/users/rubocop-hq/following{/other_user}","gists_url":"https://api.github.com/users/rubocop-hq/gists{/gist_id}","starred_url":"https://api.github.com/users/rubocop-hq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubocop-hq/subscriptions","organizations_url":"https://api.github.com/users/rubocop-hq/orgs","repos_url":"https://api.github.com/users/rubocop-hq/repos","events_url":"https://api.github.com/users/rubocop-hq/events{/privacy}","received_events_url":"https://api.github.com/users/rubocop-hq/received_events","type":"Organization","site_admin":false},"repo":{"id":4095287,"node_id":"MDEwOlJlcG9zaXRvcnk0MDk1Mjg3","name":"rubocop","full_name":"rubocop-hq/rubocop","private":false,"owner":{"login":"rubocop-hq","id":39672756,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NjcyNzU2","avatar_url":"https://avatars3.githubusercontent.com/u/39672756?v=4","gravatar_id":"","url":"https://api.github.com/users/rubocop-hq","html_url":"https://github.com/rubocop-hq","followers_url":"https://api.github.com/users/rubocop-hq/followers","following_url":"https://api.github.com/users/rubocop-hq/following{/other_user}","gists_url":"https://api.github.com/users/rubocop-hq/gists{/gist_id}","starred_url":"https://api.github.com/users/rubocop-hq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubocop-hq/subscriptions","organizations_url":"https://api.github.com/users/rubocop-hq/orgs","repos_url":"https://api.github.com/users/rubocop-hq/repos","events_url":"https://api.github.com/users/rubocop-hq/events{/privacy}","received_events_url":"https://api.github.com/users/rubocop-hq/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rubocop-hq/rubocop","description":"A Ruby static code analyzer and formatter, based on the community Ruby style guide.","fork":false,"url":"https://api.github.com/repos/rubocop-hq/rubocop","forks_url":"https://api.github.com/repos/rubocop-hq/rubocop/forks","keys_url":"https://api.github.com/repos/rubocop-hq/rubocop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubocop-hq/rubocop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubocop-hq/rubocop/teams","hooks_url":"https://api.github.com/repos/rubocop-hq/rubocop/hooks","issue_events_url":"https://api.github.com/repos/rubocop-hq/rubocop/issues/events{/number}","events_url":"https://api.github.com/repos/rubocop-hq/rubocop/events","assignees_url":"https://api.github.com/repos/rubocop-hq/rubocop/assignees{/user}","branches_url":"https://api.github.com/repos/rubocop-hq/rubocop/branches{/branch}","tags_url":"https://api.github.com/repos/rubocop-hq/rubocop/tags","blobs_url":"https://api.github.com/repos/rubocop-hq/rubocop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubocop-hq/rubocop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubocop-hq/rubocop/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubocop-hq/rubocop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubocop-hq/rubocop/statuses/{sha}","languages_url":"https://api.github.com/repos/rubocop-hq/rubocop/languages","stargazers_url":"https://api.github.com/repos/rubocop-hq/rubocop/stargazers","contributors_url":"https://api.github.com/repos/rubocop-hq/rubocop/contributors","subscribers_url":"https://api.github.com/repos/rubocop-hq/rubocop/subscribers","subscription_url":"https://api.github.com/repos/rubocop-hq/rubocop/subscription","commits_url":"https://api.github.com/repos/rubocop-hq/rubocop/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubocop-hq/rubocop/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubocop-hq/rubocop/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubocop-hq/rubocop/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubocop-hq/rubocop/contents/{+path}","compare_url":"https://api.github.com/repos/rubocop-hq/rubocop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubocop-hq/rubocop/merges","archive_url":"https://api.github.com/repos/rubocop-hq/rubocop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubocop-hq/rubocop/downloads","issues_url":"https://api.github.com/repos/rubocop-hq/rubocop/issues{/number}","pulls_url":"https://api.github.com/repos/rubocop-hq/rubocop/pulls{/number}","milestones_url":"https://api.github.com/repos/rubocop-hq/rubocop/milestones{/number}","notifications_url":"https://api.github.com/repos/rubocop-hq/rubocop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubocop-hq/rubocop/labels{/name}","releases_url":"https://api.github.com/repos/rubocop-hq/rubocop/releases{/id}","deployments_url":"https://api.github.com/repos/rubocop-hq/rubocop/deployments","created_at":"2012-04-21T10:09:58Z","updated_at":"2018-11-12T10:36:06Z","pushed_at":"2018-11-12T14:14:32Z","git_url":"git://github.com/rubocop-hq/rubocop.git","ssh_url":"git@github.com:rubocop-hq/rubocop.git","clone_url":"https://github.com/rubocop-hq/rubocop.git","svn_url":"https://github.com/rubocop-hq/rubocop","homepage":"https://docs.rubocop.org","size":24279,"stargazers_count":9507,"watchers_count":9507,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1945,"mirror_url":null,"archived":false,"open_issues_count":218,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1945,"open_issues":218,"watchers":9507,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rubocop-hq/rubocop/pulls/6473"},"html":{"href":"https://github.com/rubocop-hq/rubocop/pull/6473"},"issue":{"href":"https://api.github.com/repos/rubocop-hq/rubocop/issues/6473"},"comments":{"href":"https://api.github.com/repos/rubocop-hq/rubocop/issues/6473/comments"},"review_comments":{"href":"https://api.github.com/repos/rubocop-hq/rubocop/pulls/6473/comments"},"review_comment":{"href":"https://api.github.com/repos/rubocop-hq/rubocop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubocop-hq/rubocop/pulls/6473/commits"},"statuses":{"href":"https://api.github.com/repos/rubocop-hq/rubocop/statuses/710d2315d0687d1745097f71a01a09e6c6f5de8b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"JuanitoFatas"}}