{"action":"created","comment":{"url":"https://api.github.com/repos/google/certificate-transparency-monitor/pulls/comments/216629724","pull_request_review_id":154153046,"id":216629724,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjYyOTcyNA==","diff_hunk":"@@ -7,27 +7,30 @@ import (\n \t\"log\"\n \t\"time\"\n \n+\tct \"github.com/google/certificate-transparency-go\"\n \t\"github.com/google/certificate-transparency-monitor/client\"\n+\t\"github.com/google/certificate-transparency-monitor/monitor\"\n+\t\"github.com/google/certificate-transparency-monitor/storage\"\n )\n \n var logStr = \"STH Getter\"\n \n // Run runs an STH Getter, which periodically gets an STH from a Log, checks\n // that each one meets per-STH requirements defined in RFC 6962, and stores\n // them.\n-func Run(ctx context.Context, lc *client.LogClient, url string, period time.Duration) {\n+func Run(ctx context.Context, lc *client.LogClient, st storage.APICallWriter, url string, period time.Duration) {\n \tlog.Printf(\"%s: %s: Started with period %v\", url, logStr, period)\n \n \tt := time.NewTicker(period)\n \tfor {\n \t\tselect {","path":"sthgetter/sthgetter.go","position":21,"original_position":21,"commit_id":"d3cad0f35fb5aad388631abe576f8c4f1ce8faa9","original_commit_id":"d3cad0f35fb5aad388631abe576f8c4f1ce8faa9","user":{"login":"pphaneuf","id":40400,"node_id":"MDQ6VXNlcjQwNDAw","avatar_url":"https://avatars1.githubusercontent.com/u/40400?v=4","gravatar_id":"","url":"https://api.github.com/users/pphaneuf","html_url":"https://github.com/pphaneuf","followers_url":"https://api.github.com/users/pphaneuf/followers","following_url":"https://api.github.com/users/pphaneuf/following{/other_user}","gists_url":"https://api.github.com/users/pphaneuf/gists{/gist_id}","starred_url":"https://api.github.com/users/pphaneuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pphaneuf/subscriptions","organizations_url":"https://api.github.com/users/pphaneuf/orgs","repos_url":"https://api.github.com/users/pphaneuf/repos","events_url":"https://api.github.com/users/pphaneuf/events{/privacy}","received_events_url":"https://api.github.com/users/pphaneuf/received_events","type":"User","site_admin":false},"body":"Maybe not in this PR, but I feel that this \"infinite loop\" that takes a context should abort if the context is done? Add the appropriate clause in the `select`? Optional for this PR, though, could be just a TODO, or a mental note... :smiley: ","created_at":"2018-09-11T11:08:23Z","updated_at":"2018-09-11T11:08:23Z","html_url":"https://github.com/google/certificate-transparency-monitor/pull/5#discussion_r216629724","pull_request_url":"https://api.github.com/repos/google/certificate-transparency-monitor/pulls/5","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency-monitor/pulls/comments/216629724"},"html":{"href":"https://github.com/google/certificate-transparency-monitor/pull/5#discussion_r216629724"},"pull_request":{"href":"https://api.github.com/repos/google/certificate-transparency-monitor/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/google/certificate-transparency-monitor/pulls/5","id":209832610,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5ODMyNjEw","html_url":"https://github.com/google/certificate-transparency-monitor/pull/5","diff_url":"https://github.com/google/certificate-transparency-monitor/pull/5.diff","patch_url":"https://github.com/google/certificate-transparency-monitor/pull/5.patch","issue_url":"https://api.github.com/repos/google/certificate-transparency-monitor/issues/5","number":5,"state":"open","locked":false,"title":"Store API Calls to get-sth","user":{"login":"taknira","id":5446167,"node_id":"MDQ6VXNlcjU0NDYxNjc=","avatar_url":"https://avatars1.githubusercontent.com/u/5446167?v=4","gravatar_id":"","url":"https://api.github.com/users/taknira","html_url":"https://github.com/taknira","followers_url":"https://api.github.com/users/taknira/followers","following_url":"https://api.github.com/users/taknira/following{/other_user}","gists_url":"https://api.github.com/users/taknira/gists{/gist_id}","starred_url":"https://api.github.com/users/taknira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taknira/subscriptions","organizations_url":"https://api.github.com/users/taknira/orgs","repos_url":"https://api.github.com/users/taknira/repos","events_url":"https://api.github.com/users/taknira/events{/privacy}","received_events_url":"https://api.github.com/users/taknira/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-21T13:49:18Z","updated_at":"2018-09-11T11:08:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef505f7d62ca8faec85bc9bdceebd58750207307","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/certificate-transparency-monitor/pulls/5/commits","review_comments_url":"https://api.github.com/repos/google/certificate-transparency-monitor/pulls/5/comments","review_comment_url":"https://api.github.com/repos/google/certificate-transparency-monitor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/certificate-transparency-monitor/issues/5/comments","statuses_url":"https://api.github.com/repos/google/certificate-transparency-monitor/statuses/d3cad0f35fb5aad388631abe576f8c4f1ce8faa9","head":{"label":"taknira:apicalls","ref":"apicalls","sha":"d3cad0f35fb5aad388631abe576f8c4f1ce8faa9","user":{"login":"taknira","id":5446167,"node_id":"MDQ6VXNlcjU0NDYxNjc=","avatar_url":"https://avatars1.githubusercontent.com/u/5446167?v=4","gravatar_id":"","url":"https://api.github.com/users/taknira","html_url":"https://github.com/taknira","followers_url":"https://api.github.com/users/taknira/followers","following_url":"https://api.github.com/users/taknira/following{/other_user}","gists_url":"https://api.github.com/users/taknira/gists{/gist_id}","starred_url":"https://api.github.com/users/taknira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taknira/subscriptions","organizations_url":"https://api.github.com/users/taknira/orgs","repos_url":"https://api.github.com/users/taknira/repos","events_url":"https://api.github.com/users/taknira/events{/privacy}","received_events_url":"https://api.github.com/users/taknira/received_events","type":"User","site_admin":false},"repo":{"id":142311685,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIzMTE2ODU=","name":"certificate-transparency-monitor","full_name":"taknira/certificate-transparency-monitor","owner":{"login":"taknira","id":5446167,"node_id":"MDQ6VXNlcjU0NDYxNjc=","avatar_url":"https://avatars1.githubusercontent.com/u/5446167?v=4","gravatar_id":"","url":"https://api.github.com/users/taknira","html_url":"https://github.com/taknira","followers_url":"https://api.github.com/users/taknira/followers","following_url":"https://api.github.com/users/taknira/following{/other_user}","gists_url":"https://api.github.com/users/taknira/gists{/gist_id}","starred_url":"https://api.github.com/users/taknira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taknira/subscriptions","organizations_url":"https://api.github.com/users/taknira/orgs","repos_url":"https://api.github.com/users/taknira/repos","events_url":"https://api.github.com/users/taknira/events{/privacy}","received_events_url":"https://api.github.com/users/taknira/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/taknira/certificate-transparency-monitor","description":null,"fork":true,"url":"https://api.github.com/repos/taknira/certificate-transparency-monitor","forks_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/forks","keys_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/teams","hooks_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/hooks","issue_events_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/issues/events{/number}","events_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/events","assignees_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/assignees{/user}","branches_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/branches{/branch}","tags_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/tags","blobs_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/git/refs{/sha}","trees_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/statuses/{sha}","languages_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/languages","stargazers_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/stargazers","contributors_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/contributors","subscribers_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/subscribers","subscription_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/subscription","commits_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/commits{/sha}","git_commits_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/git/commits{/sha}","comments_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/comments{/number}","issue_comment_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/issues/comments{/number}","contents_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/contents/{+path}","compare_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/merges","archive_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/downloads","issues_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/issues{/number}","pulls_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/pulls{/number}","milestones_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/milestones{/number}","notifications_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/labels{/name}","releases_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/releases{/id}","deployments_url":"https://api.github.com/repos/taknira/certificate-transparency-monitor/deployments","created_at":"2018-07-25T14:30:11Z","updated_at":"2018-08-20T16:46:05Z","pushed_at":"2018-08-23T11:24:43Z","git_url":"git://github.com/taknira/certificate-transparency-monitor.git","ssh_url":"git@github.com:taknira/certificate-transparency-monitor.git","clone_url":"https://github.com/taknira/certificate-transparency-monitor.git","svn_url":"https://github.com/taknira/certificate-transparency-monitor","homepage":null,"size":17,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"a861514cbb8ad82eb2a23f80e351d15a07ec6b9c","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":123160218,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMxNjAyMTg=","name":"certificate-transparency-monitor","full_name":"google/certificate-transparency-monitor","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/certificate-transparency-monitor","description":null,"fork":false,"url":"https://api.github.com/repos/google/certificate-transparency-monitor","forks_url":"https://api.github.com/repos/google/certificate-transparency-monitor/forks","keys_url":"https://api.github.com/repos/google/certificate-transparency-monitor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/certificate-transparency-monitor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/certificate-transparency-monitor/teams","hooks_url":"https://api.github.com/repos/google/certificate-transparency-monitor/hooks","issue_events_url":"https://api.github.com/repos/google/certificate-transparency-monitor/issues/events{/number}","events_url":"https://api.github.com/repos/google/certificate-transparency-monitor/events","assignees_url":"https://api.github.com/repos/google/certificate-transparency-monitor/assignees{/user}","branches_url":"https://api.github.com/repos/google/certificate-transparency-monitor/branches{/branch}","tags_url":"https://api.github.com/repos/google/certificate-transparency-monitor/tags","blobs_url":"https://api.github.com/repos/google/certificate-transparency-monitor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/certificate-transparency-monitor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/certificate-transparency-monitor/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/certificate-transparency-monitor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/certificate-transparency-monitor/statuses/{sha}","languages_url":"https://api.github.com/repos/google/certificate-transparency-monitor/languages","stargazers_url":"https://api.github.com/repos/google/certificate-transparency-monitor/stargazers","contributors_url":"https://api.github.com/repos/google/certificate-transparency-monitor/contributors","subscribers_url":"https://api.github.com/repos/google/certificate-transparency-monitor/subscribers","subscription_url":"https://api.github.com/repos/google/certificate-transparency-monitor/subscription","commits_url":"https://api.github.com/repos/google/certificate-transparency-monitor/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/certificate-transparency-monitor/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/certificate-transparency-monitor/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/certificate-transparency-monitor/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/certificate-transparency-monitor/contents/{+path}","compare_url":"https://api.github.com/repos/google/certificate-transparency-monitor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/certificate-transparency-monitor/merges","archive_url":"https://api.github.com/repos/google/certificate-transparency-monitor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/certificate-transparency-monitor/downloads","issues_url":"https://api.github.com/repos/google/certificate-transparency-monitor/issues{/number}","pulls_url":"https://api.github.com/repos/google/certificate-transparency-monitor/pulls{/number}","milestones_url":"https://api.github.com/repos/google/certificate-transparency-monitor/milestones{/number}","notifications_url":"https://api.github.com/repos/google/certificate-transparency-monitor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/certificate-transparency-monitor/labels{/name}","releases_url":"https://api.github.com/repos/google/certificate-transparency-monitor/releases{/id}","deployments_url":"https://api.github.com/repos/google/certificate-transparency-monitor/deployments","created_at":"2018-02-27T16:56:10Z","updated_at":"2018-09-11T02:57:09Z","pushed_at":"2018-08-23T11:24:44Z","git_url":"git://github.com/google/certificate-transparency-monitor.git","ssh_url":"git@github.com:google/certificate-transparency-monitor.git","clone_url":"https://github.com/google/certificate-transparency-monitor.git","svn_url":"https://github.com/google/certificate-transparency-monitor","homepage":null,"size":13,"stargazers_count":7,"watchers_count":7,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency-monitor/pulls/5"},"html":{"href":"https://github.com/google/certificate-transparency-monitor/pull/5"},"issue":{"href":"https://api.github.com/repos/google/certificate-transparency-monitor/issues/5"},"comments":{"href":"https://api.github.com/repos/google/certificate-transparency-monitor/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/google/certificate-transparency-monitor/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/google/certificate-transparency-monitor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/certificate-transparency-monitor/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/google/certificate-transparency-monitor/statuses/d3cad0f35fb5aad388631abe576f8c4f1ce8faa9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pphaneuf"}}