{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/230141074","pull_request_review_id":170810893,"id":230141074,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDE0MTA3NA==","diff_hunk":"@@ -87,7 +87,8 @@ type ClientStream interface {\n \t// Context returns the context for this stream.\n \t//\n \t// It should not be called until after Header or RecvMsg has returned. Once\n-\t// called, subsequent client-side retries are disabled.\n+\t// called, subsequent client-side retries are disabled. It is also not safe\n+\t// to call CloseSend concurrently with SendMsg.","path":"stream.go","position":null,"original_position":6,"commit_id":"d71f68140a8acff4dab64f0ad287b5b302d0a94c","original_commit_id":"d2a2a717fd5c04a7d3b5731666ea3551c90101c7","user":{"login":"jadekler","id":3584893,"node_id":"MDQ6VXNlcjM1ODQ4OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/3584893?v=4","gravatar_id":"","url":"https://api.github.com/users/jadekler","html_url":"https://github.com/jadekler","followers_url":"https://api.github.com/users/jadekler/followers","following_url":"https://api.github.com/users/jadekler/following{/other_user}","gists_url":"https://api.github.com/users/jadekler/gists{/gist_id}","starred_url":"https://api.github.com/users/jadekler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadekler/subscriptions","organizations_url":"https://api.github.com/users/jadekler/orgs","repos_url":"https://api.github.com/users/jadekler/repos","events_url":"https://api.github.com/users/jadekler/events{/privacy}","received_events_url":"https://api.github.com/users/jadekler/received_events","type":"User","site_admin":false},"body":"Omg.. Done. ","created_at":"2018-11-01T18:06:07Z","updated_at":"2018-11-01T18:06:08Z","html_url":"https://github.com/grpc/grpc-go/pull/2418#discussion_r230141074","pull_request_url":"https://api.github.com/repos/grpc/grpc-go/pulls/2418","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/230141074"},"html":{"href":"https://github.com/grpc/grpc-go/pull/2418#discussion_r230141074"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/2418"}},"in_reply_to_id":230130565},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/2418","id":227081329,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MDgxMzI5","html_url":"https://github.com/grpc/grpc-go/pull/2418","diff_url":"https://github.com/grpc/grpc-go/pull/2418.diff","patch_url":"https://github.com/grpc/grpc-go/pull/2418.patch","issue_url":"https://api.github.com/repos/grpc/grpc-go/issues/2418","number":2418,"state":"open","locked":false,"title":"docs: clarify SendMsg/CloseSend usage","user":{"login":"jadekler","id":3584893,"node_id":"MDQ6VXNlcjM1ODQ4OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/3584893?v=4","gravatar_id":"","url":"https://api.github.com/users/jadekler","html_url":"https://github.com/jadekler","followers_url":"https://api.github.com/users/jadekler/followers","following_url":"https://api.github.com/users/jadekler/following{/other_user}","gists_url":"https://api.github.com/users/jadekler/gists{/gist_id}","starred_url":"https://api.github.com/users/jadekler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadekler/subscriptions","organizations_url":"https://api.github.com/users/jadekler/orgs","repos_url":"https://api.github.com/users/jadekler/repos","events_url":"https://api.github.com/users/jadekler/events{/privacy}","received_events_url":"https://api.github.com/users/jadekler/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-30T21:05:52Z","updated_at":"2018-11-01T18:06:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77bfde45dca8a2e6246922b9e4e8add9b8e683d7","assignee":{"login":"jadekler","id":3584893,"node_id":"MDQ6VXNlcjM1ODQ4OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/3584893?v=4","gravatar_id":"","url":"https://api.github.com/users/jadekler","html_url":"https://github.com/jadekler","followers_url":"https://api.github.com/users/jadekler/followers","following_url":"https://api.github.com/users/jadekler/following{/other_user}","gists_url":"https://api.github.com/users/jadekler/gists{/gist_id}","starred_url":"https://api.github.com/users/jadekler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadekler/subscriptions","organizations_url":"https://api.github.com/users/jadekler/orgs","repos_url":"https://api.github.com/users/jadekler/repos","events_url":"https://api.github.com/users/jadekler/events{/privacy}","received_events_url":"https://api.github.com/users/jadekler/received_events","type":"User","site_admin":false},"assignees":[{"login":"jadekler","id":3584893,"node_id":"MDQ6VXNlcjM1ODQ4OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/3584893?v=4","gravatar_id":"","url":"https://api.github.com/users/jadekler","html_url":"https://github.com/jadekler","followers_url":"https://api.github.com/users/jadekler/followers","following_url":"https://api.github.com/users/jadekler/following{/other_user}","gists_url":"https://api.github.com/users/jadekler/gists{/gist_id}","starred_url":"https://api.github.com/users/jadekler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadekler/subscriptions","organizations_url":"https://api.github.com/users/jadekler/orgs","repos_url":"https://api.github.com/users/jadekler/repos","events_url":"https://api.github.com/users/jadekler/events{/privacy}","received_events_url":"https://api.github.com/users/jadekler/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"menghanl","id":960845,"node_id":"MDQ6VXNlcjk2MDg0NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/960845?v=4","gravatar_id":"","url":"https://api.github.com/users/menghanl","html_url":"https://github.com/menghanl","followers_url":"https://api.github.com/users/menghanl/followers","following_url":"https://api.github.com/users/menghanl/following{/other_user}","gists_url":"https://api.github.com/users/menghanl/gists{/gist_id}","starred_url":"https://api.github.com/users/menghanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menghanl/subscriptions","organizations_url":"https://api.github.com/users/menghanl/orgs","repos_url":"https://api.github.com/users/menghanl/repos","events_url":"https://api.github.com/users/menghanl/events{/privacy}","received_events_url":"https://api.github.com/users/menghanl/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-go/pulls/2418/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-go/pulls/2418/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-go/issues/2418/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/d71f68140a8acff4dab64f0ad287b5b302d0a94c","head":{"label":"jadekler:clarify_stream_close_docs","ref":"clarify_stream_close_docs","sha":"d71f68140a8acff4dab64f0ad287b5b302d0a94c","user":{"login":"jadekler","id":3584893,"node_id":"MDQ6VXNlcjM1ODQ4OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/3584893?v=4","gravatar_id":"","url":"https://api.github.com/users/jadekler","html_url":"https://github.com/jadekler","followers_url":"https://api.github.com/users/jadekler/followers","following_url":"https://api.github.com/users/jadekler/following{/other_user}","gists_url":"https://api.github.com/users/jadekler/gists{/gist_id}","starred_url":"https://api.github.com/users/jadekler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadekler/subscriptions","organizations_url":"https://api.github.com/users/jadekler/orgs","repos_url":"https://api.github.com/users/jadekler/repos","events_url":"https://api.github.com/users/jadekler/events{/privacy}","received_events_url":"https://api.github.com/users/jadekler/received_events","type":"User","site_admin":false},"repo":{"id":115153337,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUxNTMzMzc=","name":"grpc-go","full_name":"jadekler/grpc-go","private":false,"owner":{"login":"jadekler","id":3584893,"node_id":"MDQ6VXNlcjM1ODQ4OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/3584893?v=4","gravatar_id":"","url":"https://api.github.com/users/jadekler","html_url":"https://github.com/jadekler","followers_url":"https://api.github.com/users/jadekler/followers","following_url":"https://api.github.com/users/jadekler/following{/other_user}","gists_url":"https://api.github.com/users/jadekler/gists{/gist_id}","starred_url":"https://api.github.com/users/jadekler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadekler/subscriptions","organizations_url":"https://api.github.com/users/jadekler/orgs","repos_url":"https://api.github.com/users/jadekler/repos","events_url":"https://api.github.com/users/jadekler/events{/privacy}","received_events_url":"https://api.github.com/users/jadekler/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jadekler/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/jadekler/grpc-go","forks_url":"https://api.github.com/repos/jadekler/grpc-go/forks","keys_url":"https://api.github.com/repos/jadekler/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jadekler/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jadekler/grpc-go/teams","hooks_url":"https://api.github.com/repos/jadekler/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/jadekler/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/jadekler/grpc-go/events","assignees_url":"https://api.github.com/repos/jadekler/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/jadekler/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/jadekler/grpc-go/tags","blobs_url":"https://api.github.com/repos/jadekler/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jadekler/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jadekler/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/jadekler/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jadekler/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/jadekler/grpc-go/languages","stargazers_url":"https://api.github.com/repos/jadekler/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/jadekler/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/jadekler/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/jadekler/grpc-go/subscription","commits_url":"https://api.github.com/repos/jadekler/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/jadekler/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/jadekler/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/jadekler/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/jadekler/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/jadekler/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jadekler/grpc-go/merges","archive_url":"https://api.github.com/repos/jadekler/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jadekler/grpc-go/downloads","issues_url":"https://api.github.com/repos/jadekler/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/jadekler/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/jadekler/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/jadekler/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jadekler/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/jadekler/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/jadekler/grpc-go/deployments","created_at":"2017-12-22T22:05:27Z","updated_at":"2017-12-22T22:05:29Z","pushed_at":"2018-11-01T18:05:38Z","git_url":"git://github.com/jadekler/grpc-go.git","ssh_url":"git@github.com:jadekler/grpc-go.git","clone_url":"https://github.com/jadekler/grpc-go.git","svn_url":"https://github.com/jadekler/grpc-go","homepage":"","size":7073,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"105f61423e7ad35e8295ae6b720f22635f7bee55","user":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729907,"node_id":"MDEwOlJlcG9zaXRvcnkyNzcyOTkwNw==","name":"grpc-go","full_name":"grpc/grpc-go","private":false,"owner":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/grpc/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-go","forks_url":"https://api.github.com/repos/grpc/grpc-go/forks","keys_url":"https://api.github.com/repos/grpc/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-go/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-go/events","assignees_url":"https://api.github.com/repos/grpc/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-go/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-go/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-go/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-go/merges","archive_url":"https://api.github.com/repos/grpc/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-go/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-go/deployments","created_at":"2014-12-08T18:59:34Z","updated_at":"2018-11-01T17:49:40Z","pushed_at":"2018-11-01T18:05:40Z","git_url":"git://github.com/grpc/grpc-go.git","ssh_url":"git@github.com:grpc/grpc-go.git","clone_url":"https://github.com/grpc/grpc-go.git","svn_url":"https://github.com/grpc/grpc-go","homepage":"","size":7481,"stargazers_count":6736,"watchers_count":6736,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1310,"mirror_url":null,"archived":false,"open_issues_count":103,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1310,"open_issues":103,"watchers":6736,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/2418"},"html":{"href":"https://github.com/grpc/grpc-go/pull/2418"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/2418"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/2418/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/2418/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/2418/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-go/statuses/d71f68140a8acff4dab64f0ad287b5b302d0a94c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jadekler"}}