{"action":"created","issue":{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/136","repository_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver","labels_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/136/labels{/name}","comments_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/136/comments","events_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/136/events","html_url":"https://github.com/JoinMarket-Org/joinmarket-clientserver/issues/136","id":318713458,"number":136,"title":"Combining the two split orderbooks","user":{"login":"chris-belcher","id":8398185,"avatar_url":"https://avatars2.githubusercontent.com/u/8398185?v=4","gravatar_id":"","url":"https://api.github.com/users/chris-belcher","html_url":"https://github.com/chris-belcher","followers_url":"https://api.github.com/users/chris-belcher/followers","following_url":"https://api.github.com/users/chris-belcher/following{/other_user}","gists_url":"https://api.github.com/users/chris-belcher/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-belcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-belcher/subscriptions","organizations_url":"https://api.github.com/users/chris-belcher/orgs","repos_url":"https://api.github.com/users/chris-belcher/repos","events_url":"https://api.github.com/users/chris-belcher/events{/privacy}","received_events_url":"https://api.github.com/users/chris-belcher/received_events","type":"User","site_admin":false},"labels":[{"id":486873887,"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-04-29T12:31:57Z","updated_at":"2018-04-30T16:14:47Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Right now we have the p2pkh version of joinmarket, and the p2wpkh-p2sh version. This is suboptimal, we'd like to get all the old users and any potential new users to use only one (most logically the p2wpkh-p2sh segwit version)\r\n\r\nAn added complication is there are two repositories, joinmarket and joinmarket-clientserver. They could be easily combined on a single repository but on different branches. That could be good because then both the URLs `github.com/joinmarket-org/joinmarket` and `github.com/joinmarket-org/joinmarket-clientserver` will both give the p2wpkh-p2sh version.\r\n\r\njoinmarket only supports p2pkh but -clientserver supports both with the segwit flag in joinmarket.cfg (I believe this is correct?)\r\n\r\nWe can do public relations asking people to switch via the twitter, IRC, subreddit, bitcointalk thread and joinmarket alerts which go in the /topic on the pit IRC channels. Those alerts should still work on joinmarket, but I'm not sure about joinmarket-clientserver, but joinmarket is the one we most want to reach so it should be fine.\r\n\r\nI don't see any reason why people would prefer the p2pkh version of joinmarket. So there shouldn't be any opposition, we just need to do the public relations and coding work getting everyone to switch over."},"comment":{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/comments/385448507","html_url":"https://github.com/JoinMarket-Org/joinmarket-clientserver/issues/136#issuecomment-385448507","issue_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket-clientserver/issues/136","id":385448507,"user":{"login":"undeath","id":1469278,"avatar_url":"https://avatars0.githubusercontent.com/u/1469278?v=4","gravatar_id":"","url":"https://api.github.com/users/undeath","html_url":"https://github.com/undeath","followers_url":"https://api.github.com/users/undeath/followers","following_url":"https://api.github.com/users/undeath/following{/other_user}","gists_url":"https://api.github.com/users/undeath/gists{/gist_id}","starred_url":"https://api.github.com/users/undeath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/undeath/subscriptions","organizations_url":"https://api.github.com/users/undeath/orgs","repos_url":"https://api.github.com/users/undeath/repos","events_url":"https://api.github.com/users/undeath/events{/privacy}","received_events_url":"https://api.github.com/users/undeath/received_events","type":"User","site_admin":false},"created_at":"2018-04-30T16:14:47Z","updated_at":"2018-04-30T16:14:47Z","author_association":"CONTRIBUTOR","body":"see #99 where I added support to run a non-segwit maker. I've been running this for months without problems. If this is merged there is no need to retain the old joinmarket.\r\n\r\n#104 would also add support for non-segwit (along with native segwit) but I haven't had time to complete this recently."}}
{"actor":{"display_login":"undeath"}}