{"action":"created","comment":{"url":"https://api.github.com/repos/emberjs/data/pulls/comments/229513313","pull_request_review_id":170030550,"id":229513313,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTUxMzMxMw==","diff_hunk":"@@ -10,7 +18,7 @@\n   @return {Object|null}\n   @for DS\n */\n-export default function _normalizeLink(link) {\n+export default function _normalizeLink(link: Link | string): NormalizedLink {\n   switch (typeof link) {\n     case 'object':\n       return link;","path":"addon/-private/system/normalize-link.ts","position":20,"original_position":20,"commit_id":"0de0cea820eb59dd70f4b78e03eacb0c4aebb99d","original_commit_id":"0de0cea820eb59dd70f4b78e03eacb0c4aebb99d","user":{"login":"mike-north","id":558005,"node_id":"MDQ6VXNlcjU1ODAwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/558005?v=4","gravatar_id":"","url":"https://api.github.com/users/mike-north","html_url":"https://github.com/mike-north","followers_url":"https://api.github.com/users/mike-north/followers","following_url":"https://api.github.com/users/mike-north/following{/other_user}","gists_url":"https://api.github.com/users/mike-north/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-north/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-north/subscriptions","organizations_url":"https://api.github.com/users/mike-north/orgs","repos_url":"https://api.github.com/users/mike-north/repos","events_url":"https://api.github.com/users/mike-north/events{/privacy}","received_events_url":"https://api.github.com/users/mike-north/received_events","type":"User","site_admin":false},"body":"an exhaustive switch should be used here http://ideasintosoftware.com/exhaustive-switch-in-typescript/\r\n\r\n`NormalizedLink` has the potential to be null -- what value for `Link|string` could be passed as an argument, which would result in `null` being returned?","created_at":"2018-10-30T22:46:19Z","updated_at":"2018-10-30T22:48:26Z","html_url":"https://github.com/emberjs/data/pull/5723#discussion_r229513313","pull_request_url":"https://api.github.com/repos/emberjs/data/pulls/5723","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments/229513313"},"html":{"href":"https://github.com/emberjs/data/pull/5723#discussion_r229513313"},"pull_request":{"href":"https://api.github.com/repos/emberjs/data/pulls/5723"}}},"pull_request":{"url":"https://api.github.com/repos/emberjs/data/pulls/5723","id":226311840,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzExODQw","html_url":"https://github.com/emberjs/data/pull/5723","diff_url":"https://github.com/emberjs/data/pull/5723.diff","patch_url":"https://github.com/emberjs/data/pull/5723.patch","issue_url":"https://api.github.com/repos/emberjs/data/issues/5723","number":5723,"state":"open","locked":false,"title":"Convert some system utilities to ts","user":{"login":"NullVoxPopuli","id":199018,"node_id":"MDQ6VXNlcjE5OTAxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/199018?v=4","gravatar_id":"","url":"https://api.github.com/users/NullVoxPopuli","html_url":"https://github.com/NullVoxPopuli","followers_url":"https://api.github.com/users/NullVoxPopuli/followers","following_url":"https://api.github.com/users/NullVoxPopuli/following{/other_user}","gists_url":"https://api.github.com/users/NullVoxPopuli/gists{/gist_id}","starred_url":"https://api.github.com/users/NullVoxPopuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NullVoxPopuli/subscriptions","organizations_url":"https://api.github.com/users/NullVoxPopuli/orgs","repos_url":"https://api.github.com/users/NullVoxPopuli/repos","events_url":"https://api.github.com/users/NullVoxPopuli/events{/privacy}","received_events_url":"https://api.github.com/users/NullVoxPopuli/received_events","type":"User","site_admin":false},"body":"This is just some of the smaller utilities","created_at":"2018-10-27T17:55:03Z","updated_at":"2018-10-30T22:48:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3153cee3efc54824243ea71307e1c76512e1dfa0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/data/pulls/5723/commits","review_comments_url":"https://api.github.com/repos/emberjs/data/pulls/5723/comments","review_comment_url":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/data/issues/5723/comments","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/0de0cea820eb59dd70f4b78e03eacb0c4aebb99d","head":{"label":"NullVoxPopuli:convert-some-system-utilities-to-ts","ref":"convert-some-system-utilities-to-ts","sha":"0de0cea820eb59dd70f4b78e03eacb0c4aebb99d","user":{"login":"NullVoxPopuli","id":199018,"node_id":"MDQ6VXNlcjE5OTAxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/199018?v=4","gravatar_id":"","url":"https://api.github.com/users/NullVoxPopuli","html_url":"https://github.com/NullVoxPopuli","followers_url":"https://api.github.com/users/NullVoxPopuli/followers","following_url":"https://api.github.com/users/NullVoxPopuli/following{/other_user}","gists_url":"https://api.github.com/users/NullVoxPopuli/gists{/gist_id}","starred_url":"https://api.github.com/users/NullVoxPopuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NullVoxPopuli/subscriptions","organizations_url":"https://api.github.com/users/NullVoxPopuli/orgs","repos_url":"https://api.github.com/users/NullVoxPopuli/repos","events_url":"https://api.github.com/users/NullVoxPopuli/events{/privacy}","received_events_url":"https://api.github.com/users/NullVoxPopuli/received_events","type":"User","site_admin":false},"repo":{"id":132819838,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI4MTk4Mzg=","name":"data","full_name":"NullVoxPopuli/data","private":false,"owner":{"login":"NullVoxPopuli","id":199018,"node_id":"MDQ6VXNlcjE5OTAxOA==","avatar_url":"https://avatars1.githubusercontent.com/u/199018?v=4","gravatar_id":"","url":"https://api.github.com/users/NullVoxPopuli","html_url":"https://github.com/NullVoxPopuli","followers_url":"https://api.github.com/users/NullVoxPopuli/followers","following_url":"https://api.github.com/users/NullVoxPopuli/following{/other_user}","gists_url":"https://api.github.com/users/NullVoxPopuli/gists{/gist_id}","starred_url":"https://api.github.com/users/NullVoxPopuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NullVoxPopuli/subscriptions","organizations_url":"https://api.github.com/users/NullVoxPopuli/orgs","repos_url":"https://api.github.com/users/NullVoxPopuli/repos","events_url":"https://api.github.com/users/NullVoxPopuli/events{/privacy}","received_events_url":"https://api.github.com/users/NullVoxPopuli/received_events","type":"User","site_admin":false},"html_url":"https://github.com/NullVoxPopuli/data","description":"A data persistence library for Ember.js.","fork":true,"url":"https://api.github.com/repos/NullVoxPopuli/data","forks_url":"https://api.github.com/repos/NullVoxPopuli/data/forks","keys_url":"https://api.github.com/repos/NullVoxPopuli/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NullVoxPopuli/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NullVoxPopuli/data/teams","hooks_url":"https://api.github.com/repos/NullVoxPopuli/data/hooks","issue_events_url":"https://api.github.com/repos/NullVoxPopuli/data/issues/events{/number}","events_url":"https://api.github.com/repos/NullVoxPopuli/data/events","assignees_url":"https://api.github.com/repos/NullVoxPopuli/data/assignees{/user}","branches_url":"https://api.github.com/repos/NullVoxPopuli/data/branches{/branch}","tags_url":"https://api.github.com/repos/NullVoxPopuli/data/tags","blobs_url":"https://api.github.com/repos/NullVoxPopuli/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NullVoxPopuli/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NullVoxPopuli/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/NullVoxPopuli/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NullVoxPopuli/data/statuses/{sha}","languages_url":"https://api.github.com/repos/NullVoxPopuli/data/languages","stargazers_url":"https://api.github.com/repos/NullVoxPopuli/data/stargazers","contributors_url":"https://api.github.com/repos/NullVoxPopuli/data/contributors","subscribers_url":"https://api.github.com/repos/NullVoxPopuli/data/subscribers","subscription_url":"https://api.github.com/repos/NullVoxPopuli/data/subscription","commits_url":"https://api.github.com/repos/NullVoxPopuli/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/NullVoxPopuli/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/NullVoxPopuli/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/NullVoxPopuli/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/NullVoxPopuli/data/contents/{+path}","compare_url":"https://api.github.com/repos/NullVoxPopuli/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NullVoxPopuli/data/merges","archive_url":"https://api.github.com/repos/NullVoxPopuli/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NullVoxPopuli/data/downloads","issues_url":"https://api.github.com/repos/NullVoxPopuli/data/issues{/number}","pulls_url":"https://api.github.com/repos/NullVoxPopuli/data/pulls{/number}","milestones_url":"https://api.github.com/repos/NullVoxPopuli/data/milestones{/number}","notifications_url":"https://api.github.com/repos/NullVoxPopuli/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NullVoxPopuli/data/labels{/name}","releases_url":"https://api.github.com/repos/NullVoxPopuli/data/releases{/id}","deployments_url":"https://api.github.com/repos/NullVoxPopuli/data/deployments","created_at":"2018-05-09T22:37:39Z","updated_at":"2018-09-20T23:26:20Z","pushed_at":"2018-10-27T17:54:34Z","git_url":"git://github.com/NullVoxPopuli/data.git","ssh_url":"git@github.com:NullVoxPopuli/data.git","clone_url":"https://github.com/NullVoxPopuli/data.git","svn_url":"https://github.com/NullVoxPopuli/data","homepage":"","size":16722,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"7c721dd29e541624fe8144d19ff8a0150ccbd36a","user":{"login":"emberjs","id":1253363,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTMzNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1253363?v=4","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":3016562,"node_id":"MDEwOlJlcG9zaXRvcnkzMDE2NTYy","name":"data","full_name":"emberjs/data","private":false,"owner":{"login":"emberjs","id":1253363,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTMzNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1253363?v=4","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/emberjs/data","description":"A data persistence library for Ember.js.","fork":false,"url":"https://api.github.com/repos/emberjs/data","forks_url":"https://api.github.com/repos/emberjs/data/forks","keys_url":"https://api.github.com/repos/emberjs/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/data/teams","hooks_url":"https://api.github.com/repos/emberjs/data/hooks","issue_events_url":"https://api.github.com/repos/emberjs/data/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/data/events","assignees_url":"https://api.github.com/repos/emberjs/data/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/data/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/data/tags","blobs_url":"https://api.github.com/repos/emberjs/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/data/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/data/languages","stargazers_url":"https://api.github.com/repos/emberjs/data/stargazers","contributors_url":"https://api.github.com/repos/emberjs/data/contributors","subscribers_url":"https://api.github.com/repos/emberjs/data/subscribers","subscription_url":"https://api.github.com/repos/emberjs/data/subscription","commits_url":"https://api.github.com/repos/emberjs/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/data/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/data/merges","archive_url":"https://api.github.com/repos/emberjs/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/data/downloads","issues_url":"https://api.github.com/repos/emberjs/data/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/data/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/data/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/data/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/data/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/data/deployments","created_at":"2011-12-20T01:50:40Z","updated_at":"2018-10-27T00:07:36Z","pushed_at":"2018-10-30T19:17:41Z","git_url":"git://github.com/emberjs/data.git","ssh_url":"git@github.com:emberjs/data.git","clone_url":"https://github.com/emberjs/data.git","svn_url":"https://github.com/emberjs/data","homepage":"","size":16946,"stargazers_count":2894,"watchers_count":2894,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1242,"mirror_url":null,"archived":false,"open_issues_count":143,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1242,"open_issues":143,"watchers":2894,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/data/pulls/5723"},"html":{"href":"https://github.com/emberjs/data/pull/5723"},"issue":{"href":"https://api.github.com/repos/emberjs/data/issues/5723"},"comments":{"href":"https://api.github.com/repos/emberjs/data/issues/5723/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/data/pulls/5723/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/data/pulls/5723/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/data/statuses/0de0cea820eb59dd70f4b78e03eacb0c4aebb99d"}},"author_association":"NONE"}}
{"actor":{"display_login":"mike-north"}}