{"action":"created","comment":{"url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/pulls/comments/226953036","pull_request_review_id":166878961,"id":226953036,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjk1MzAzNg==","diff_hunk":"@@ -0,0 +1,122 @@\n+const BigNumber = require('bn.js');\n+const SafeMathTest = artifacts.require('SafeMathTest');\n+const utils = require('../test_lib/utils');\n+\n+let safeMathInstance;\n+contract('SafeMath', function () {\n+\tconst MAX_UINT = new BigNumber(2).pow(new BigNumber(256)).sub(new BigNumber(1));\n+\t\n+\tbeforeEach(async function () {\n+\t\t\n+\t\tsafeMathInstance = await SafeMathTest.new();","path":"test/safe_math/safe_math.js","position":11,"original_position":11,"commit_id":"840797de1895bc74f4de43613d1b54540515e2ed","original_commit_id":"840797de1895bc74f4de43613d1b54540515e2ed","user":{"login":"jasonklein","id":6839162,"node_id":"MDQ6VXNlcjY4MzkxNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/6839162?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonklein","html_url":"https://github.com/jasonklein","followers_url":"https://api.github.com/users/jasonklein/followers","following_url":"https://api.github.com/users/jasonklein/following{/other_user}","gists_url":"https://api.github.com/users/jasonklein/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonklein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonklein/subscriptions","organizations_url":"https://api.github.com/users/jasonklein/orgs","repos_url":"https://api.github.com/users/jasonklein/repos","events_url":"https://api.github.com/users/jasonklein/events{/privacy}","received_events_url":"https://api.github.com/users/jasonklein/received_events","type":"User","site_admin":false},"body":"Why \"safeMathInstance\" and not simply \"safeMath\"? A quick search through openst-contracts (and mosaic-contracts) suggests this is a departure from our typical practice—for any particular reason (i.e., it is meant to indicate something special in this case)?","created_at":"2018-10-22T10:30:49Z","updated_at":"2018-10-22T10:49:33Z","html_url":"https://github.com/OpenSTFoundation/openst-contracts/pull/64#discussion_r226953036","pull_request_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/pulls/64","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/pulls/comments/226953036"},"html":{"href":"https://github.com/OpenSTFoundation/openst-contracts/pull/64#discussion_r226953036"},"pull_request":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/pulls/64"}}},"pull_request":{"url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/pulls/64","id":221098569,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMDk4NTY5","html_url":"https://github.com/OpenSTFoundation/openst-contracts/pull/64","diff_url":"https://github.com/OpenSTFoundation/openst-contracts/pull/64.diff","patch_url":"https://github.com/OpenSTFoundation/openst-contracts/pull/64.patch","issue_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/issues/64","number":64,"state":"open","locked":false,"title":"Updated SafeMath contract","user":{"login":"gulshanvasnani","id":39480808,"node_id":"MDQ6VXNlcjM5NDgwODA4","avatar_url":"https://avatars1.githubusercontent.com/u/39480808?v=4","gravatar_id":"","url":"https://api.github.com/users/gulshanvasnani","html_url":"https://github.com/gulshanvasnani","followers_url":"https://api.github.com/users/gulshanvasnani/followers","following_url":"https://api.github.com/users/gulshanvasnani/following{/other_user}","gists_url":"https://api.github.com/users/gulshanvasnani/gists{/gist_id}","starred_url":"https://api.github.com/users/gulshanvasnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gulshanvasnani/subscriptions","organizations_url":"https://api.github.com/users/gulshanvasnani/orgs","repos_url":"https://api.github.com/users/gulshanvasnani/repos","events_url":"https://api.github.com/users/gulshanvasnani/events{/privacy}","received_events_url":"https://api.github.com/users/gulshanvasnani/received_events","type":"User","site_admin":false},"body":"It uses same SafeMath contract as :-\r\nhttps://github.com/OpenZeppelin/openzeppelin-solidity/blob/master/contracts/math/SafeMath.sol\r\n\r\nresolves:- #35 ","created_at":"2018-10-08T12:27:24Z","updated_at":"2018-10-22T10:49:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7201f2e215e652404dc158cc49159d5fa84a0054","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/pulls/64/commits","review_comments_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/pulls/64/comments","review_comment_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/issues/64/comments","statuses_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/statuses/840797de1895bc74f4de43613d1b54540515e2ed","head":{"label":"OpenSTFoundation:gulshan/GH_35_update_safemath_library","ref":"gulshan/GH_35_update_safemath_library","sha":"840797de1895bc74f4de43613d1b54540515e2ed","user":{"login":"OpenSTFoundation","id":31754790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzU0Nzkw","avatar_url":"https://avatars2.githubusercontent.com/u/31754790?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSTFoundation","html_url":"https://github.com/OpenSTFoundation","followers_url":"https://api.github.com/users/OpenSTFoundation/followers","following_url":"https://api.github.com/users/OpenSTFoundation/following{/other_user}","gists_url":"https://api.github.com/users/OpenSTFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSTFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSTFoundation/subscriptions","organizations_url":"https://api.github.com/users/OpenSTFoundation/orgs","repos_url":"https://api.github.com/users/OpenSTFoundation/repos","events_url":"https://api.github.com/users/OpenSTFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSTFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":146108578,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYxMDg1Nzg=","name":"openst-contracts","full_name":"OpenSTFoundation/openst-contracts","private":false,"owner":{"login":"OpenSTFoundation","id":31754790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzU0Nzkw","avatar_url":"https://avatars2.githubusercontent.com/u/31754790?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSTFoundation","html_url":"https://github.com/OpenSTFoundation","followers_url":"https://api.github.com/users/OpenSTFoundation/followers","following_url":"https://api.github.com/users/OpenSTFoundation/following{/other_user}","gists_url":"https://api.github.com/users/OpenSTFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSTFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSTFoundation/subscriptions","organizations_url":"https://api.github.com/users/OpenSTFoundation/orgs","repos_url":"https://api.github.com/users/OpenSTFoundation/repos","events_url":"https://api.github.com/users/OpenSTFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSTFoundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenSTFoundation/openst-contracts","description":"OpenST is a framework for building token economies on Ethereum","fork":false,"url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts","forks_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/forks","keys_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/teams","hooks_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/hooks","issue_events_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/events","assignees_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/tags","blobs_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/languages","stargazers_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/stargazers","contributors_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/contributors","subscribers_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/subscribers","subscription_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/subscription","commits_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/merges","archive_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/downloads","issues_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/labels{/name}","releases_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/deployments","created_at":"2018-08-25T15:52:27Z","updated_at":"2018-10-17T06:00:20Z","pushed_at":"2018-10-22T06:30:33Z","git_url":"git://github.com/OpenSTFoundation/openst-contracts.git","ssh_url":"git@github.com:OpenSTFoundation/openst-contracts.git","clone_url":"https://github.com/OpenSTFoundation/openst-contracts.git","svn_url":"https://github.com/OpenSTFoundation/openst-contracts","homepage":null,"size":3142,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":12,"watchers":12,"default_branch":"develop"}},"base":{"label":"OpenSTFoundation:develop","ref":"develop","sha":"43fa71e988aa0b660cf7233cb917ef786ffcd05d","user":{"login":"OpenSTFoundation","id":31754790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzU0Nzkw","avatar_url":"https://avatars2.githubusercontent.com/u/31754790?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSTFoundation","html_url":"https://github.com/OpenSTFoundation","followers_url":"https://api.github.com/users/OpenSTFoundation/followers","following_url":"https://api.github.com/users/OpenSTFoundation/following{/other_user}","gists_url":"https://api.github.com/users/OpenSTFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSTFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSTFoundation/subscriptions","organizations_url":"https://api.github.com/users/OpenSTFoundation/orgs","repos_url":"https://api.github.com/users/OpenSTFoundation/repos","events_url":"https://api.github.com/users/OpenSTFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSTFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":146108578,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYxMDg1Nzg=","name":"openst-contracts","full_name":"OpenSTFoundation/openst-contracts","private":false,"owner":{"login":"OpenSTFoundation","id":31754790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzU0Nzkw","avatar_url":"https://avatars2.githubusercontent.com/u/31754790?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSTFoundation","html_url":"https://github.com/OpenSTFoundation","followers_url":"https://api.github.com/users/OpenSTFoundation/followers","following_url":"https://api.github.com/users/OpenSTFoundation/following{/other_user}","gists_url":"https://api.github.com/users/OpenSTFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSTFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSTFoundation/subscriptions","organizations_url":"https://api.github.com/users/OpenSTFoundation/orgs","repos_url":"https://api.github.com/users/OpenSTFoundation/repos","events_url":"https://api.github.com/users/OpenSTFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSTFoundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenSTFoundation/openst-contracts","description":"OpenST is a framework for building token economies on Ethereum","fork":false,"url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts","forks_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/forks","keys_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/teams","hooks_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/hooks","issue_events_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/events","assignees_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/tags","blobs_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/languages","stargazers_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/stargazers","contributors_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/contributors","subscribers_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/subscribers","subscription_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/subscription","commits_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/merges","archive_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/downloads","issues_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/labels{/name}","releases_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/deployments","created_at":"2018-08-25T15:52:27Z","updated_at":"2018-10-17T06:00:20Z","pushed_at":"2018-10-22T06:30:33Z","git_url":"git://github.com/OpenSTFoundation/openst-contracts.git","ssh_url":"git@github.com:OpenSTFoundation/openst-contracts.git","clone_url":"https://github.com/OpenSTFoundation/openst-contracts.git","svn_url":"https://github.com/OpenSTFoundation/openst-contracts","homepage":null,"size":3142,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6,"open_issues":12,"watchers":12,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/pulls/64"},"html":{"href":"https://github.com/OpenSTFoundation/openst-contracts/pull/64"},"issue":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/issues/64"},"comments":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/OpenSTFoundation/openst-contracts/statuses/840797de1895bc74f4de43613d1b54540515e2ed"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jasonklein"}}