{"action":"created","comment":{"url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/pulls/comments/192594356","pull_request_review_id":125400017,"id":192594356,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjU5NDM1Ng==","diff_hunk":"@@ -0,0 +1,10 @@\n+#cmakedefine PACKAGE_NAME \"@PACKAGE_NAME@\"","path":"config.h.cin","position":1,"original_position":1,"commit_id":"360da28234c5aef0690a115fcf625e06d95470d2","original_commit_id":"360da28234c5aef0690a115fcf625e06d95470d2","user":{"login":"fragglet","id":96821,"node_id":"MDQ6VXNlcjk2ODIx","avatar_url":"https://avatars2.githubusercontent.com/u/96821?v=4","gravatar_id":"","url":"https://api.github.com/users/fragglet","html_url":"https://github.com/fragglet","followers_url":"https://api.github.com/users/fragglet/followers","following_url":"https://api.github.com/users/fragglet/following{/other_user}","gists_url":"https://api.github.com/users/fragglet/gists{/gist_id}","starred_url":"https://api.github.com/users/fragglet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fragglet/subscriptions","organizations_url":"https://api.github.com/users/fragglet/orgs","repos_url":"https://api.github.com/users/fragglet/repos","events_url":"https://api.github.com/users/fragglet/events{/privacy}","received_events_url":"https://api.github.com/users/fragglet/received_events","type":"User","site_admin":false},"body":"Can we place this file in the cmake/ subdirectory?","created_at":"2018-06-03T15:53:30Z","updated_at":"2018-06-03T15:54:11Z","html_url":"https://github.com/chocolate-doom/chocolate-doom/pull/1054#discussion_r192594356","pull_request_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/pulls/1054","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/chocolate-doom/chocolate-doom/pulls/comments/192594356"},"html":{"href":"https://github.com/chocolate-doom/chocolate-doom/pull/1054#discussion_r192594356"},"pull_request":{"href":"https://api.github.com/repos/chocolate-doom/chocolate-doom/pulls/1054"}}},"pull_request":{"url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/pulls/1054","id":192158218,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMTU4MjE4","html_url":"https://github.com/chocolate-doom/chocolate-doom/pull/1054","diff_url":"https://github.com/chocolate-doom/chocolate-doom/pull/1054.diff","patch_url":"https://github.com/chocolate-doom/chocolate-doom/pull/1054.patch","issue_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/1054","number":1054,"state":"open","locked":false,"title":"CMake Build FIles - Visual Studio project replacement","user":{"login":"AlexMax","id":23563,"node_id":"MDQ6VXNlcjIzNTYz","avatar_url":"https://avatars1.githubusercontent.com/u/23563?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexMax","html_url":"https://github.com/AlexMax","followers_url":"https://api.github.com/users/AlexMax/followers","following_url":"https://api.github.com/users/AlexMax/following{/other_user}","gists_url":"https://api.github.com/users/AlexMax/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexMax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexMax/subscriptions","organizations_url":"https://api.github.com/users/AlexMax/orgs","repos_url":"https://api.github.com/users/AlexMax/repos","events_url":"https://api.github.com/users/AlexMax/events{/privacy}","received_events_url":"https://api.github.com/users/AlexMax/received_events","type":"User","site_admin":false},"body":"Here are CMake build files\r\n\r\nThese build files have been designed for creating Visual Studio projects.  They also work well enough to support compiling under Linux as well.  I have not tested these with any flavor of MinGW or on macOS.\r\nThe currently supported targets are:\r\n\r\n* Chocolate Foo and all dependent libraries\r\n* Setup\r\n* midiproc\r\n* Standalone midiread\r\n* Standalone mus2mid\r\n\r\nOther targets have not been implemented, such as manpage building.\r\n\r\nSDL2, SDL2_mixer and SDL2_net are all required libraries.  libpng and libsamplerate are also optionally supported, and will be linked against if you point to them.\r\n\r\nInstructions on how to use these build files are quite simple, and anybody who has ever used CMake before should feel right at home.  For novices, I recommend using CMake GUI.  In-tree builds are not supported, it is suggested that the user create a `build` folder in the checkout (which is also now a part of the `.gitignore`) and point CMake at that directory to create the project files or Makefiles or whatever.\r\n\r\nThe included SDL2 library finders also include specific cache variables called `SDL2_DIR` and similar.  If you download the Visual C++ \"Development Library\" from the SDL website, and unzip it into a specific folder, you can simply point the `SDL2_DIR` and friends at that folder, and CMake will find the proper include and library folders automatically.  On Linux, CMake will check `pkg-config` for hints on where to find the appropriate directories.\r\n\r\nNo external documentation is provided in this pull request.  Please tell me how you would prefer this build system be documented.\r\n\r\nI have also gone out of my way to make the `CMakeLists.txt` files be laid out similarly to the autotools files - at least superficially - to aid with updating these build files at the same time as the autotools build.","created_at":"2018-06-01T22:40:52Z","updated_at":"2018-06-03T15:54:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c513175bd5916d38ad2af77f286c5feacc8227ad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/pulls/1054/commits","review_comments_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/pulls/1054/comments","review_comment_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/1054/comments","statuses_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/statuses/360da28234c5aef0690a115fcf625e06d95470d2","head":{"label":"AlexMax:cmake","ref":"cmake","sha":"360da28234c5aef0690a115fcf625e06d95470d2","user":{"login":"AlexMax","id":23563,"node_id":"MDQ6VXNlcjIzNTYz","avatar_url":"https://avatars1.githubusercontent.com/u/23563?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexMax","html_url":"https://github.com/AlexMax","followers_url":"https://api.github.com/users/AlexMax/followers","following_url":"https://api.github.com/users/AlexMax/following{/other_user}","gists_url":"https://api.github.com/users/AlexMax/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexMax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexMax/subscriptions","organizations_url":"https://api.github.com/users/AlexMax/orgs","repos_url":"https://api.github.com/users/AlexMax/repos","events_url":"https://api.github.com/users/AlexMax/events{/privacy}","received_events_url":"https://api.github.com/users/AlexMax/received_events","type":"User","site_admin":false},"repo":{"id":131780612,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE3ODA2MTI=","name":"chocolate-doom","full_name":"AlexMax/chocolate-doom","owner":{"login":"AlexMax","id":23563,"node_id":"MDQ6VXNlcjIzNTYz","avatar_url":"https://avatars1.githubusercontent.com/u/23563?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexMax","html_url":"https://github.com/AlexMax","followers_url":"https://api.github.com/users/AlexMax/followers","following_url":"https://api.github.com/users/AlexMax/following{/other_user}","gists_url":"https://api.github.com/users/AlexMax/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexMax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexMax/subscriptions","organizations_url":"https://api.github.com/users/AlexMax/orgs","repos_url":"https://api.github.com/users/AlexMax/repos","events_url":"https://api.github.com/users/AlexMax/events{/privacy}","received_events_url":"https://api.github.com/users/AlexMax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlexMax/chocolate-doom","description":"Chocolate Doom is a Doom source port that is minimalist and historically accurate.","fork":true,"url":"https://api.github.com/repos/AlexMax/chocolate-doom","forks_url":"https://api.github.com/repos/AlexMax/chocolate-doom/forks","keys_url":"https://api.github.com/repos/AlexMax/chocolate-doom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlexMax/chocolate-doom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlexMax/chocolate-doom/teams","hooks_url":"https://api.github.com/repos/AlexMax/chocolate-doom/hooks","issue_events_url":"https://api.github.com/repos/AlexMax/chocolate-doom/issues/events{/number}","events_url":"https://api.github.com/repos/AlexMax/chocolate-doom/events","assignees_url":"https://api.github.com/repos/AlexMax/chocolate-doom/assignees{/user}","branches_url":"https://api.github.com/repos/AlexMax/chocolate-doom/branches{/branch}","tags_url":"https://api.github.com/repos/AlexMax/chocolate-doom/tags","blobs_url":"https://api.github.com/repos/AlexMax/chocolate-doom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlexMax/chocolate-doom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlexMax/chocolate-doom/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlexMax/chocolate-doom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlexMax/chocolate-doom/statuses/{sha}","languages_url":"https://api.github.com/repos/AlexMax/chocolate-doom/languages","stargazers_url":"https://api.github.com/repos/AlexMax/chocolate-doom/stargazers","contributors_url":"https://api.github.com/repos/AlexMax/chocolate-doom/contributors","subscribers_url":"https://api.github.com/repos/AlexMax/chocolate-doom/subscribers","subscription_url":"https://api.github.com/repos/AlexMax/chocolate-doom/subscription","commits_url":"https://api.github.com/repos/AlexMax/chocolate-doom/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlexMax/chocolate-doom/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlexMax/chocolate-doom/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlexMax/chocolate-doom/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlexMax/chocolate-doom/contents/{+path}","compare_url":"https://api.github.com/repos/AlexMax/chocolate-doom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlexMax/chocolate-doom/merges","archive_url":"https://api.github.com/repos/AlexMax/chocolate-doom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlexMax/chocolate-doom/downloads","issues_url":"https://api.github.com/repos/AlexMax/chocolate-doom/issues{/number}","pulls_url":"https://api.github.com/repos/AlexMax/chocolate-doom/pulls{/number}","milestones_url":"https://api.github.com/repos/AlexMax/chocolate-doom/milestones{/number}","notifications_url":"https://api.github.com/repos/AlexMax/chocolate-doom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlexMax/chocolate-doom/labels{/name}","releases_url":"https://api.github.com/repos/AlexMax/chocolate-doom/releases{/id}","deployments_url":"https://api.github.com/repos/AlexMax/chocolate-doom/deployments","created_at":"2018-05-02T01:13:30Z","updated_at":"2018-05-10T00:18:05Z","pushed_at":"2018-06-03T14:53:06Z","git_url":"git://github.com/AlexMax/chocolate-doom.git","ssh_url":"git@github.com:AlexMax/chocolate-doom.git","clone_url":"https://github.com/AlexMax/chocolate-doom.git","svn_url":"https://github.com/AlexMax/chocolate-doom","homepage":"https://www.chocolate-doom.org/","size":14529,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"chocolate-doom:master","ref":"master","sha":"774256d67cbbcf1f10bb3cf2ab555b15aa02f2ff","user":{"login":"chocolate-doom","id":6140118,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNDAxMTg=","avatar_url":"https://avatars2.githubusercontent.com/u/6140118?v=4","gravatar_id":"","url":"https://api.github.com/users/chocolate-doom","html_url":"https://github.com/chocolate-doom","followers_url":"https://api.github.com/users/chocolate-doom/followers","following_url":"https://api.github.com/users/chocolate-doom/following{/other_user}","gists_url":"https://api.github.com/users/chocolate-doom/gists{/gist_id}","starred_url":"https://api.github.com/users/chocolate-doom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chocolate-doom/subscriptions","organizations_url":"https://api.github.com/users/chocolate-doom/orgs","repos_url":"https://api.github.com/users/chocolate-doom/repos","events_url":"https://api.github.com/users/chocolate-doom/events{/privacy}","received_events_url":"https://api.github.com/users/chocolate-doom/received_events","type":"Organization","site_admin":false},"repo":{"id":230912,"node_id":"MDEwOlJlcG9zaXRvcnkyMzA5MTI=","name":"chocolate-doom","full_name":"chocolate-doom/chocolate-doom","owner":{"login":"chocolate-doom","id":6140118,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNDAxMTg=","avatar_url":"https://avatars2.githubusercontent.com/u/6140118?v=4","gravatar_id":"","url":"https://api.github.com/users/chocolate-doom","html_url":"https://github.com/chocolate-doom","followers_url":"https://api.github.com/users/chocolate-doom/followers","following_url":"https://api.github.com/users/chocolate-doom/following{/other_user}","gists_url":"https://api.github.com/users/chocolate-doom/gists{/gist_id}","starred_url":"https://api.github.com/users/chocolate-doom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chocolate-doom/subscriptions","organizations_url":"https://api.github.com/users/chocolate-doom/orgs","repos_url":"https://api.github.com/users/chocolate-doom/repos","events_url":"https://api.github.com/users/chocolate-doom/events{/privacy}","received_events_url":"https://api.github.com/users/chocolate-doom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chocolate-doom/chocolate-doom","description":"Chocolate Doom is a Doom source port that is minimalist and historically accurate.","fork":false,"url":"https://api.github.com/repos/chocolate-doom/chocolate-doom","forks_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/forks","keys_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/teams","hooks_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/hooks","issue_events_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/events{/number}","events_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/events","assignees_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/assignees{/user}","branches_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/branches{/branch}","tags_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/tags","blobs_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/git/refs{/sha}","trees_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/statuses/{sha}","languages_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/languages","stargazers_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/stargazers","contributors_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/contributors","subscribers_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/subscribers","subscription_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/subscription","commits_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/commits{/sha}","git_commits_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/git/commits{/sha}","comments_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/comments{/number}","issue_comment_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/comments{/number}","contents_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/contents/{+path}","compare_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/merges","archive_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/downloads","issues_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues{/number}","pulls_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/pulls{/number}","milestones_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/milestones{/number}","notifications_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/labels{/name}","releases_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/releases{/id}","deployments_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/deployments","created_at":"2009-06-18T22:15:53Z","updated_at":"2018-06-03T13:43:12Z","pushed_at":"2018-06-03T14:53:08Z","git_url":"git://github.com/chocolate-doom/chocolate-doom.git","ssh_url":"git@github.com:chocolate-doom/chocolate-doom.git","clone_url":"https://github.com/chocolate-doom/chocolate-doom.git","svn_url":"https://github.com/chocolate-doom/chocolate-doom","homepage":"https://www.chocolate-doom.org/","size":17340,"stargazers_count":464,"watchers_count":464,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":147,"mirror_url":null,"archived":false,"open_issues_count":212,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":147,"open_issues":212,"watchers":464,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chocolate-doom/chocolate-doom/pulls/1054"},"html":{"href":"https://github.com/chocolate-doom/chocolate-doom/pull/1054"},"issue":{"href":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/1054"},"comments":{"href":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/1054/comments"},"review_comments":{"href":"https://api.github.com/repos/chocolate-doom/chocolate-doom/pulls/1054/comments"},"review_comment":{"href":"https://api.github.com/repos/chocolate-doom/chocolate-doom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chocolate-doom/chocolate-doom/pulls/1054/commits"},"statuses":{"href":"https://api.github.com/repos/chocolate-doom/chocolate-doom/statuses/360da28234c5aef0690a115fcf625e06d95470d2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fragglet"}}