{"action":"created","issue":{"url":"https://api.github.com/repos/Web-eWorks/ide-c-cpp/issues/1","repository_url":"https://api.github.com/repos/Web-eWorks/ide-c-cpp","labels_url":"https://api.github.com/repos/Web-eWorks/ide-c-cpp/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/Web-eWorks/ide-c-cpp/issues/1/comments","events_url":"https://api.github.com/repos/Web-eWorks/ide-c-cpp/issues/1/events","html_url":"https://github.com/Web-eWorks/ide-c-cpp/pull/1","id":376134809,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NDIxMjYx","number":1,"title":"Fixes the issue where env is overwritten","user":{"login":"isundaylee","id":1572861,"node_id":"MDQ6VXNlcjE1NzI4NjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1572861?v=4","gravatar_id":"","url":"https://api.github.com/users/isundaylee","html_url":"https://github.com/isundaylee","followers_url":"https://api.github.com/users/isundaylee/followers","following_url":"https://api.github.com/users/isundaylee/following{/other_user}","gists_url":"https://api.github.com/users/isundaylee/gists{/gist_id}","starred_url":"https://api.github.com/users/isundaylee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isundaylee/subscriptions","organizations_url":"https://api.github.com/users/isundaylee/orgs","repos_url":"https://api.github.com/users/isundaylee/repos","events_url":"https://api.github.com/users/isundaylee/events{/privacy}","received_events_url":"https://api.github.com/users/isundaylee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-31T19:53:33Z","updated_at":"2018-11-06T04:48:09Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Web-eWorks/ide-c-cpp/pulls/1","html_url":"https://github.com/Web-eWorks/ide-c-cpp/pull/1","diff_url":"https://github.com/Web-eWorks/ide-c-cpp/pull/1.diff","patch_url":"https://github.com/Web-eWorks/ide-c-cpp/pull/1.patch"},"body":"When the language server is first spawned, `projectPath` is passed in as the `env` parameter. However, the `env` parameter is supposed to be an `Object` containing the key-value pairs of all environment variables (https://nodejs.org/api/child_process.html#child_process_child_process_spawn_command_args_options). In my particular case, passing in `projectPath` as `env` would overwrite the entire environment, and would cause `PATH` to be incorrect. \r\n\r\nI wonder if `projectPath` is meant to be passed in as `cwd` instead? I did the following change and it started to work."},"comment":{"url":"https://api.github.com/repos/Web-eWorks/ide-c-cpp/issues/comments/436129983","html_url":"https://github.com/Web-eWorks/ide-c-cpp/pull/1#issuecomment-436129983","issue_url":"https://api.github.com/repos/Web-eWorks/ide-c-cpp/issues/1","id":436129983,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjEyOTk4Mw==","user":{"login":"Web-eWorks","id":4218491,"node_id":"MDQ6VXNlcjQyMTg0OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/4218491?v=4","gravatar_id":"","url":"https://api.github.com/users/Web-eWorks","html_url":"https://github.com/Web-eWorks","followers_url":"https://api.github.com/users/Web-eWorks/followers","following_url":"https://api.github.com/users/Web-eWorks/following{/other_user}","gists_url":"https://api.github.com/users/Web-eWorks/gists{/gist_id}","starred_url":"https://api.github.com/users/Web-eWorks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Web-eWorks/subscriptions","organizations_url":"https://api.github.com/users/Web-eWorks/orgs","repos_url":"https://api.github.com/users/Web-eWorks/repos","events_url":"https://api.github.com/users/Web-eWorks/events{/privacy}","received_events_url":"https://api.github.com/users/Web-eWorks/received_events","type":"User","site_admin":false},"created_at":"2018-11-06T04:48:09Z","updated_at":"2018-11-06T04:48:09Z","author_association":"OWNER","body":"Seems to work fine for me. Thanks for catching that!"}}
{"actor":{"display_login":"Web-eWorks"}}