{"action":"created","comment":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/comments/165700070","pull_request_review_id":93685702,"id":165700070,"diff_hunk":"@@ -125,12 +125,6 @@ check() {\n package_snapd-git() {\n   export GOPATH=\"$srcdir/go\"\n \n-  # Ensure that we have /var/lib/snapd/{hostfs,lib/gl}/ as they are required by\n-  # snap-confine for constructing some bind mounts around.\n-  install -d -m 755 \\\n-            \"$pkgdir/var/lib/snapd/hostfs/\" \\","path":"packaging/arch/PKGBUILD","position":7,"original_position":7,"commit_id":"01c8e6b9f3877bf716bcda585d5a27ae63113ccf","original_commit_id":"01c8e6b9f3877bf716bcda585d5a27ae63113ccf","user":{"login":"mvo5","id":914418,"avatar_url":"https://avatars3.githubusercontent.com/u/914418?v=4","gravatar_id":"","url":"https://api.github.com/users/mvo5","html_url":"https://github.com/mvo5","followers_url":"https://api.github.com/users/mvo5/followers","following_url":"https://api.github.com/users/mvo5/following{/other_user}","gists_url":"https://api.github.com/users/mvo5/gists{/gist_id}","starred_url":"https://api.github.com/users/mvo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvo5/subscriptions","organizations_url":"https://api.github.com/users/mvo5/orgs","repos_url":"https://api.github.com/users/mvo5/repos","events_url":"https://api.github.com/users/mvo5/events{/privacy}","received_events_url":"https://api.github.com/users/mvo5/received_events","type":"User","site_admin":false},"body":"Is this dropping hostfs? Do we need this?","created_at":"2018-02-02T16:58:57Z","updated_at":"2018-02-02T16:58:57Z","html_url":"https://github.com/snapcore/snapd/pull/4598#discussion_r165700070","pull_request_url":"https://api.github.com/repos/snapcore/snapd/pulls/4598","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments/165700070"},"html":{"href":"https://github.com/snapcore/snapd/pull/4598#discussion_r165700070"},"pull_request":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/4598"}}},"pull_request":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/4598","id":166800471,"html_url":"https://github.com/snapcore/snapd/pull/4598","diff_url":"https://github.com/snapcore/snapd/pull/4598.diff","patch_url":"https://github.com/snapcore/snapd/pull/4598.patch","issue_url":"https://api.github.com/repos/snapcore/snapd/issues/4598","number":4598,"state":"open","locked":false,"title":"packaging: create /var/lib/snapd/lib/{gl,gl32,vulkan} as part of packaging","user":{"login":"bboozzoo","id":41870,"avatar_url":"https://avatars3.githubusercontent.com/u/41870?v=4","gravatar_id":"","url":"https://api.github.com/users/bboozzoo","html_url":"https://github.com/bboozzoo","followers_url":"https://api.github.com/users/bboozzoo/followers","following_url":"https://api.github.com/users/bboozzoo/following{/other_user}","gists_url":"https://api.github.com/users/bboozzoo/gists{/gist_id}","starred_url":"https://api.github.com/users/bboozzoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboozzoo/subscriptions","organizations_url":"https://api.github.com/users/bboozzoo/orgs","repos_url":"https://api.github.com/users/bboozzoo/repos","events_url":"https://api.github.com/users/bboozzoo/events{/privacy}","received_events_url":"https://api.github.com/users/bboozzoo/received_events","type":"User","site_admin":false},"body":"All those dirs are needed for snap-confine when setting up the mount namespace. ` /var/lib/snapd/lib/vulkan` was added recently, but only Ubunt/Debian packaging got updated.\r\n\r\nRelated forum topic: https://forum.snapcraft.io/t/spotify-cannot-create-tmpfs-target/3805\r\n\r\n@Conan-Kudo would it be possible for you to apply a similar change in Fedora package?","created_at":"2018-02-02T13:19:11Z","updated_at":"2018-02-02T16:58:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d0b10d2c7a6b57196c8c1abae3c4f164a431bc0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":{"url":"https://api.github.com/repos/snapcore/snapd/milestones/16","html_url":"https://github.com/snapcore/snapd/milestone/16","labels_url":"https://api.github.com/repos/snapcore/snapd/milestones/16/labels","id":2948406,"number":16,"title":"2.31","description":"","creator":{"login":"mvo5","id":914418,"avatar_url":"https://avatars3.githubusercontent.com/u/914418?v=4","gravatar_id":"","url":"https://api.github.com/users/mvo5","html_url":"https://github.com/mvo5","followers_url":"https://api.github.com/users/mvo5/followers","following_url":"https://api.github.com/users/mvo5/following{/other_user}","gists_url":"https://api.github.com/users/mvo5/gists{/gist_id}","starred_url":"https://api.github.com/users/mvo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvo5/subscriptions","organizations_url":"https://api.github.com/users/mvo5/orgs","repos_url":"https://api.github.com/users/mvo5/repos","events_url":"https://api.github.com/users/mvo5/events{/privacy}","received_events_url":"https://api.github.com/users/mvo5/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":34,"state":"open","created_at":"2017-11-30T07:15:29Z","updated_at":"2018-02-02T16:58:21Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/snapcore/snapd/pulls/4598/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapd/pulls/4598/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapd/issues/4598/comments","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/01c8e6b9f3877bf716bcda585d5a27ae63113ccf","head":{"label":"bboozzoo:bboozzoo/create-lib-vulkan","ref":"bboozzoo/create-lib-vulkan","sha":"01c8e6b9f3877bf716bcda585d5a27ae63113ccf","user":{"login":"bboozzoo","id":41870,"avatar_url":"https://avatars3.githubusercontent.com/u/41870?v=4","gravatar_id":"","url":"https://api.github.com/users/bboozzoo","html_url":"https://github.com/bboozzoo","followers_url":"https://api.github.com/users/bboozzoo/followers","following_url":"https://api.github.com/users/bboozzoo/following{/other_user}","gists_url":"https://api.github.com/users/bboozzoo/gists{/gist_id}","starred_url":"https://api.github.com/users/bboozzoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboozzoo/subscriptions","organizations_url":"https://api.github.com/users/bboozzoo/orgs","repos_url":"https://api.github.com/users/bboozzoo/repos","events_url":"https://api.github.com/users/bboozzoo/events{/privacy}","received_events_url":"https://api.github.com/users/bboozzoo/received_events","type":"User","site_admin":false},"repo":{"id":109232638,"name":"snapd","full_name":"bboozzoo/snapd","owner":{"login":"bboozzoo","id":41870,"avatar_url":"https://avatars3.githubusercontent.com/u/41870?v=4","gravatar_id":"","url":"https://api.github.com/users/bboozzoo","html_url":"https://github.com/bboozzoo","followers_url":"https://api.github.com/users/bboozzoo/followers","following_url":"https://api.github.com/users/bboozzoo/following{/other_user}","gists_url":"https://api.github.com/users/bboozzoo/gists{/gist_id}","starred_url":"https://api.github.com/users/bboozzoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboozzoo/subscriptions","organizations_url":"https://api.github.com/users/bboozzoo/orgs","repos_url":"https://api.github.com/users/bboozzoo/repos","events_url":"https://api.github.com/users/bboozzoo/events{/privacy}","received_events_url":"https://api.github.com/users/bboozzoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bboozzoo/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":true,"url":"https://api.github.com/repos/bboozzoo/snapd","forks_url":"https://api.github.com/repos/bboozzoo/snapd/forks","keys_url":"https://api.github.com/repos/bboozzoo/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bboozzoo/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bboozzoo/snapd/teams","hooks_url":"https://api.github.com/repos/bboozzoo/snapd/hooks","issue_events_url":"https://api.github.com/repos/bboozzoo/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/bboozzoo/snapd/events","assignees_url":"https://api.github.com/repos/bboozzoo/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/bboozzoo/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/bboozzoo/snapd/tags","blobs_url":"https://api.github.com/repos/bboozzoo/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bboozzoo/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bboozzoo/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/bboozzoo/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bboozzoo/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/bboozzoo/snapd/languages","stargazers_url":"https://api.github.com/repos/bboozzoo/snapd/stargazers","contributors_url":"https://api.github.com/repos/bboozzoo/snapd/contributors","subscribers_url":"https://api.github.com/repos/bboozzoo/snapd/subscribers","subscription_url":"https://api.github.com/repos/bboozzoo/snapd/subscription","commits_url":"https://api.github.com/repos/bboozzoo/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/bboozzoo/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/bboozzoo/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/bboozzoo/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/bboozzoo/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/bboozzoo/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bboozzoo/snapd/merges","archive_url":"https://api.github.com/repos/bboozzoo/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bboozzoo/snapd/downloads","issues_url":"https://api.github.com/repos/bboozzoo/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/bboozzoo/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/bboozzoo/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/bboozzoo/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bboozzoo/snapd/labels{/name}","releases_url":"https://api.github.com/repos/bboozzoo/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/bboozzoo/snapd/deployments","created_at":"2017-11-02T07:37:26Z","updated_at":"2017-11-02T07:37:33Z","pushed_at":"2018-02-02T13:16:30Z","git_url":"git://github.com/bboozzoo/snapd.git","ssh_url":"git@github.com:bboozzoo/snapd.git","clone_url":"https://github.com/bboozzoo/snapd.git","svn_url":"https://github.com/bboozzoo/snapd","homepage":"","size":58502,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"687069b7027d4809292b8e9311bcb9b59e03b608","user":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":44672744,"name":"snapd","full_name":"snapcore/snapd","owner":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snapcore/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":false,"url":"https://api.github.com/repos/snapcore/snapd","forks_url":"https://api.github.com/repos/snapcore/snapd/forks","keys_url":"https://api.github.com/repos/snapcore/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapd/teams","hooks_url":"https://api.github.com/repos/snapcore/snapd/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapd/events","assignees_url":"https://api.github.com/repos/snapcore/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapd/tags","blobs_url":"https://api.github.com/repos/snapcore/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapd/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapd/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapd/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapd/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapd/subscription","commits_url":"https://api.github.com/repos/snapcore/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapd/merges","archive_url":"https://api.github.com/repos/snapcore/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapd/downloads","issues_url":"https://api.github.com/repos/snapcore/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapd/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapd/deployments","created_at":"2015-10-21T11:51:46Z","updated_at":"2018-02-02T16:49:12Z","pushed_at":"2018-02-02T16:55:55Z","git_url":"git://github.com/snapcore/snapd.git","ssh_url":"git@github.com:snapcore/snapd.git","clone_url":"https://github.com/snapcore/snapd.git","svn_url":"https://github.com/snapcore/snapd","homepage":"","size":58322,"stargazers_count":871,"watchers_count":871,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":219,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":219,"open_issues":44,"watchers":871,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/4598"},"html":{"href":"https://github.com/snapcore/snapd/pull/4598"},"issue":{"href":"https://api.github.com/repos/snapcore/snapd/issues/4598"},"comments":{"href":"https://api.github.com/repos/snapcore/snapd/issues/4598/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/4598/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/4598/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapd/statuses/01c8e6b9f3877bf716bcda585d5a27ae63113ccf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mvo5"}}