{"action":"opened","number":168,"pull_request":{"url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/pulls/168","id":241588389,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNTg4Mzg5","html_url":"https://github.com/Microsoft/service-fabric-services-and-actors-dotnet/pull/168","diff_url":"https://github.com/Microsoft/service-fabric-services-and-actors-dotnet/pull/168.diff","patch_url":"https://github.com/Microsoft/service-fabric-services-and-actors-dotnet/pull/168.patch","issue_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/issues/168","number":168,"state":"open","locked":false,"title":"RegisterReminderAsync DueTime validation","user":{"login":"arturek","id":381257,"node_id":"MDQ6VXNlcjM4MTI1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/381257?v=4","gravatar_id":"","url":"https://api.github.com/users/arturek","html_url":"https://github.com/arturek","followers_url":"https://api.github.com/users/arturek/followers","following_url":"https://api.github.com/users/arturek/following{/other_user}","gists_url":"https://api.github.com/users/arturek/gists{/gist_id}","starred_url":"https://api.github.com/users/arturek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arturek/subscriptions","organizations_url":"https://api.github.com/users/arturek/orgs","repos_url":"https://api.github.com/users/arturek/repos","events_url":"https://api.github.com/users/arturek/events{/privacy}","received_events_url":"https://api.github.com/users/arturek/received_events","type":"User","site_admin":false},"body":"The RegisterReminderAsync method should accept \"negative one (-1) milliseconds\" as a valid value of its dueTime parameter. This is both specified in the the [documentation](https://docs.microsoft.com/en-us/dotnet/api/microsoft.servicefabric.actors.runtime.actorbase.registerreminderasync?view=azure-dotnet) and in the message of an exception thrown when this validation fails (TimeSpan TotalMilliseconds specified value must be between -1 and 922337203685477, Parameter name: DueTime). Other code which uses the DueTime property seems to be aware of -1 value and handles it correctly.","created_at":"2018-12-31T18:03:50Z","updated_at":"2018-12-31T18:03:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/pulls/168/commits","review_comments_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/pulls/168/comments","review_comment_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/issues/168/comments","statuses_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/statuses/84d7960f19e3d42eb4354d760e11c3800f010c6e","head":{"label":"arturek:patch-1","ref":"patch-1","sha":"84d7960f19e3d42eb4354d760e11c3800f010c6e","user":{"login":"arturek","id":381257,"node_id":"MDQ6VXNlcjM4MTI1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/381257?v=4","gravatar_id":"","url":"https://api.github.com/users/arturek","html_url":"https://github.com/arturek","followers_url":"https://api.github.com/users/arturek/followers","following_url":"https://api.github.com/users/arturek/following{/other_user}","gists_url":"https://api.github.com/users/arturek/gists{/gist_id}","starred_url":"https://api.github.com/users/arturek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arturek/subscriptions","organizations_url":"https://api.github.com/users/arturek/orgs","repos_url":"https://api.github.com/users/arturek/repos","events_url":"https://api.github.com/users/arturek/events{/privacy}","received_events_url":"https://api.github.com/users/arturek/received_events","type":"User","site_admin":false},"repo":{"id":163686923,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM2ODY5MjM=","name":"service-fabric-services-and-actors-dotnet","full_name":"arturek/service-fabric-services-and-actors-dotnet","private":false,"owner":{"login":"arturek","id":381257,"node_id":"MDQ6VXNlcjM4MTI1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/381257?v=4","gravatar_id":"","url":"https://api.github.com/users/arturek","html_url":"https://github.com/arturek","followers_url":"https://api.github.com/users/arturek/followers","following_url":"https://api.github.com/users/arturek/following{/other_user}","gists_url":"https://api.github.com/users/arturek/gists{/gist_id}","starred_url":"https://api.github.com/users/arturek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arturek/subscriptions","organizations_url":"https://api.github.com/users/arturek/orgs","repos_url":"https://api.github.com/users/arturek/repos","events_url":"https://api.github.com/users/arturek/events{/privacy}","received_events_url":"https://api.github.com/users/arturek/received_events","type":"User","site_admin":false},"html_url":"https://github.com/arturek/service-fabric-services-and-actors-dotnet","description":"Reliable Services and Reliable Actors are Service Fabric application frameworks for building highly-scalable distributed cloud applications.","fork":true,"url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet","forks_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/forks","keys_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/teams","hooks_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/hooks","issue_events_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/events","assignees_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/tags","blobs_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/languages","stargazers_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/stargazers","contributors_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/contributors","subscribers_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/subscribers","subscription_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/subscription","commits_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/merges","archive_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/downloads","issues_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/arturek/service-fabric-services-and-actors-dotnet/deployments","created_at":"2018-12-31T17:33:50Z","updated_at":"2018-12-31T17:33:53Z","pushed_at":"2018-12-31T17:46:37Z","git_url":"git://github.com/arturek/service-fabric-services-and-actors-dotnet.git","ssh_url":"git@github.com:arturek/service-fabric-services-and-actors-dotnet.git","clone_url":"https://github.com/arturek/service-fabric-services-and-actors-dotnet.git","svn_url":"https://github.com/arturek/service-fabric-services-and-actors-dotnet","homepage":null,"size":85433,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Microsoft:develop","ref":"develop","sha":"b7cc09992f11c1d754e1f2d4383b6d912589beea","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":83844142,"node_id":"MDEwOlJlcG9zaXRvcnk4Mzg0NDE0Mg==","name":"service-fabric-services-and-actors-dotnet","full_name":"Microsoft/service-fabric-services-and-actors-dotnet","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/service-fabric-services-and-actors-dotnet","description":"Reliable Services and Reliable Actors are Service Fabric application frameworks for building highly-scalable distributed cloud applications.","fork":false,"url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet","forks_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/forks","keys_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/teams","hooks_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/events","assignees_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/tags","blobs_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/languages","stargazers_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/subscription","commits_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/merges","archive_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/downloads","issues_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/deployments","created_at":"2017-03-03T21:44:31Z","updated_at":"2018-12-27T22:55:31Z","pushed_at":"2018-12-18T22:06:14Z","git_url":"git://github.com/Microsoft/service-fabric-services-and-actors-dotnet.git","ssh_url":"git@github.com:Microsoft/service-fabric-services-and-actors-dotnet.git","clone_url":"https://github.com/Microsoft/service-fabric-services-and-actors-dotnet.git","svn_url":"https://github.com/Microsoft/service-fabric-services-and-actors-dotnet","homepage":null,"size":85433,"stargazers_count":192,"watchers_count":192,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":75,"open_issues":8,"watchers":192,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/pulls/168"},"html":{"href":"https://github.com/Microsoft/service-fabric-services-and-actors-dotnet/pull/168"},"issue":{"href":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/issues/168"},"comments":{"href":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/issues/168/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/pulls/168/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/pulls/168/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/service-fabric-services-and-actors-dotnet/statuses/84d7960f19e3d42eb4354d760e11c3800f010c6e"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"arturek"}}