{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/201694203","pull_request_review_id":136244618,"id":201694203,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTY5NDIwMw==","diff_hunk":"@@ -51,18 +55,38 @@ private[akka] class RemoteMetricsOff extends RemoteMetrics {\n   override def logPayloadBytes(msg: Any, payloadBytes: Int): Unit = ()\n }\n \n+/**\n+ * INTERNAL API\n+ */\n+private object RemoteMetricsOn {\n+  val LogFrameSizeExceedingConfigKey = \"akka.remote.log-frame-size-exceeding\"\n+}\n+\n /**\n  * INTERNAL API\n  */\n private[akka] class RemoteMetricsOn(system: ExtendedActorSystem) extends RemoteMetrics {\n \n-  private val logFrameSizeExceeding: Int = system.settings.config.getBytes(\n-    \"akka.remote.log-frame-size-exceeding\").toInt\n   private val log = Logging(system, this.getClass)\n+\n+  private val logFrameSizeExceeding: Int = {\n+    if (system.settings.config.getString(LogFrameSizeExceedingConfigKey) == \"off\") {","path":"akka-remote/src/main/scala/akka/remote/RemoteMetricsExtension.scala","position":42,"original_position":42,"commit_id":"c03febd5c7045bc873784a8e7699004cec8d7b81","original_commit_id":"c03febd5c7045bc873784a8e7699004cec8d7b81","user":{"login":"patriknw","id":336161,"node_id":"MDQ6VXNlcjMzNjE2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/336161?v=4","gravatar_id":"","url":"https://api.github.com/users/patriknw","html_url":"https://github.com/patriknw","followers_url":"https://api.github.com/users/patriknw/followers","following_url":"https://api.github.com/users/patriknw/following{/other_user}","gists_url":"https://api.github.com/users/patriknw/gists{/gist_id}","starred_url":"https://api.github.com/users/patriknw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patriknw/subscriptions","organizations_url":"https://api.github.com/users/patriknw/orgs","repos_url":"https://api.github.com/users/patriknw/repos","events_url":"https://api.github.com/users/patriknw/events{/privacy}","received_events_url":"https://api.github.com/users/patriknw/received_events","type":"User","site_admin":false},"body":"this can be removed, it can't happen, because if \"off\" then `RemoteMetricsOff` is used instead of `RemoteMetricsOn`\r\n\r\n(and it's anyway missing a `toLowerCase`)","created_at":"2018-07-11T13:44:08Z","updated_at":"2018-07-11T13:44:08Z","html_url":"https://github.com/akka/akka/pull/25284#discussion_r201694203","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/25284","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/201694203"},"html":{"href":"https://github.com/akka/akka/pull/25284#discussion_r201694203"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/25284"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/25284","id":198338083,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MzM4MDgz","html_url":"https://github.com/akka/akka/pull/25284","diff_url":"https://github.com/akka/akka/pull/25284.diff","patch_url":"https://github.com/akka/akka/pull/25284.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/25284","number":25284,"state":"open","locked":false,"title":"Log a warning if 'akka.remote.log-frame-size-exceeding' contains a bad value","user":{"login":"danbim","id":300638,"node_id":"MDQ6VXNlcjMwMDYzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/300638?v=4","gravatar_id":"","url":"https://api.github.com/users/danbim","html_url":"https://github.com/danbim","followers_url":"https://api.github.com/users/danbim/followers","following_url":"https://api.github.com/users/danbim/following{/other_user}","gists_url":"https://api.github.com/users/danbim/gists{/gist_id}","starred_url":"https://api.github.com/users/danbim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbim/subscriptions","organizations_url":"https://api.github.com/users/danbim/orgs","repos_url":"https://api.github.com/users/danbim/repos","events_url":"https://api.github.com/users/danbim/events{/privacy}","received_events_url":"https://api.github.com/users/danbim/received_events","type":"User","site_admin":false},"body":"Currently, if 'akka.remote.log-frame-size-exceeding' is accidentally set\r\nto an invalid value (e.g. 'on') the developer does not get warned but\r\nremote communication fails with a not-very-helpful error message:\r\n\r\n```\r\n[INFO] [06/29/2018 15:07:41.657] [run-main-0] [akka.remote.Remoting] Starting remoting\r\n[INFO] [06/29/2018 15:07:41.847] [run-main-0] [akka.remote.Remoting] Remoting started; listening on addresses :[akka.tcp://akkaremotenull@localhost:2553]\r\n[INFO] [06/29/2018 15:07:41.849] [run-main-0] [akka.remote.Remoting] Remoting now listens on addresses: [akka.tcp://akkaremotenull@localhost:2553]\r\n[WARN] [06/29/2018 15:07:41.986] [akkaremotenull-akka.remote.default-remote-dispatcher-5] [akka.tcp://akkaremotenull@localhost:2553/system/endpointManager/reliableEndpointWriter-akka.tcp%3A%2F%2Fakkaremotenull%40localhost%3A2552-0] Association with remote system [akka.tcp://akkaremotenull@localhost:2552] has failed, address is now gated for [5000] ms. Reason: [akka://akkaremotenull/system/endpointManager/reliableEndpointWriter-akka.tcp%3A%2F%2Fakkaremotenull%40localhost%3A2552-0/endpointWriter: exception during creation] Caused by: [null]\r\n[INFO] [06/29/2018 15:07:41.993] [akkaremotenull-akka.actor.default-dispatcher-3] [akka://akkaremotenull/deadLetters] Message [io.ino.akkaremotenull.Greeter$Greet] from Actor[akka://akkaremotenull/temp/$a] to Actor[akka://akkaremotenull/deadLetters] was not delivered. [1] dead letters encountered. If this is not an expected behavior, then [Actor[akka://akkaremotenull/deadLetters]] may have terminated unexpectedly, This logging can be turned off or adjusted with configuration settings 'akka.log-dead-letters' and 'akka.log-dead-letters-during-shutdown'.\r\n```\r\n\r\nThis commit fixes the issue by a) printing a warning message and b)\r\nignoring the config setting.","created_at":"2018-06-29T14:42:23Z","updated_at":"2018-07-11T13:44:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1ccd6cff65c5b1d375eeb2c4a6a3a5405d0d311","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":37797347,"node_id":"MDU6TGFiZWwzNzc5NzM0Nw==","url":"https://api.github.com/repos/akka/akka/labels/tested","name":"tested","color":"d7e102","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/25284/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/25284/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/25284/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/c03febd5c7045bc873784a8e7699004cec8d7b81","head":{"label":"danbim:wip-warn-on-logFrameSizeExceeding-parse-error","ref":"wip-warn-on-logFrameSizeExceeding-parse-error","sha":"c03febd5c7045bc873784a8e7699004cec8d7b81","user":{"login":"danbim","id":300638,"node_id":"MDQ6VXNlcjMwMDYzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/300638?v=4","gravatar_id":"","url":"https://api.github.com/users/danbim","html_url":"https://github.com/danbim","followers_url":"https://api.github.com/users/danbim/followers","following_url":"https://api.github.com/users/danbim/following{/other_user}","gists_url":"https://api.github.com/users/danbim/gists{/gist_id}","starred_url":"https://api.github.com/users/danbim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbim/subscriptions","organizations_url":"https://api.github.com/users/danbim/orgs","repos_url":"https://api.github.com/users/danbim/repos","events_url":"https://api.github.com/users/danbim/events{/privacy}","received_events_url":"https://api.github.com/users/danbim/received_events","type":"User","site_admin":false},"repo":{"id":139151080,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkxNTEwODA=","name":"akka","full_name":"danbim/akka","owner":{"login":"danbim","id":300638,"node_id":"MDQ6VXNlcjMwMDYzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/300638?v=4","gravatar_id":"","url":"https://api.github.com/users/danbim","html_url":"https://github.com/danbim","followers_url":"https://api.github.com/users/danbim/followers","following_url":"https://api.github.com/users/danbim/following{/other_user}","gists_url":"https://api.github.com/users/danbim/gists{/gist_id}","starred_url":"https://api.github.com/users/danbim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbim/subscriptions","organizations_url":"https://api.github.com/users/danbim/orgs","repos_url":"https://api.github.com/users/danbim/repos","events_url":"https://api.github.com/users/danbim/events{/privacy}","received_events_url":"https://api.github.com/users/danbim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danbim/akka","description":"Build highly concurrent, distributed, and resilient message-driven applications on the JVM","fork":true,"url":"https://api.github.com/repos/danbim/akka","forks_url":"https://api.github.com/repos/danbim/akka/forks","keys_url":"https://api.github.com/repos/danbim/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danbim/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danbim/akka/teams","hooks_url":"https://api.github.com/repos/danbim/akka/hooks","issue_events_url":"https://api.github.com/repos/danbim/akka/issues/events{/number}","events_url":"https://api.github.com/repos/danbim/akka/events","assignees_url":"https://api.github.com/repos/danbim/akka/assignees{/user}","branches_url":"https://api.github.com/repos/danbim/akka/branches{/branch}","tags_url":"https://api.github.com/repos/danbim/akka/tags","blobs_url":"https://api.github.com/repos/danbim/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danbim/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danbim/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/danbim/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danbim/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/danbim/akka/languages","stargazers_url":"https://api.github.com/repos/danbim/akka/stargazers","contributors_url":"https://api.github.com/repos/danbim/akka/contributors","subscribers_url":"https://api.github.com/repos/danbim/akka/subscribers","subscription_url":"https://api.github.com/repos/danbim/akka/subscription","commits_url":"https://api.github.com/repos/danbim/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/danbim/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/danbim/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/danbim/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/danbim/akka/contents/{+path}","compare_url":"https://api.github.com/repos/danbim/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danbim/akka/merges","archive_url":"https://api.github.com/repos/danbim/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danbim/akka/downloads","issues_url":"https://api.github.com/repos/danbim/akka/issues{/number}","pulls_url":"https://api.github.com/repos/danbim/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/danbim/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/danbim/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danbim/akka/labels{/name}","releases_url":"https://api.github.com/repos/danbim/akka/releases{/id}","deployments_url":"https://api.github.com/repos/danbim/akka/deployments","created_at":"2018-06-29T13:11:07Z","updated_at":"2018-06-29T13:11:20Z","pushed_at":"2018-07-05T20:41:31Z","git_url":"git://github.com/danbim/akka.git","ssh_url":"git@github.com:danbim/akka.git","clone_url":"https://github.com/danbim/akka.git","svn_url":"https://github.com/danbim/akka","homepage":"http://akka.io","size":211869,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"02f68999520a71fc1c32ee8d6d3385db0ec91ed5","user":{"login":"akka","id":1496237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTYyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAwMTM=","name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTYyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Build highly concurrent, distributed, and resilient message-driven applications on the JVM","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka/deployments","created_at":"2009-02-16T12:51:54Z","updated_at":"2018-07-11T13:37:57Z","pushed_at":"2018-07-11T13:37:53Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":212017,"stargazers_count":8735,"watchers_count":8735,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2775,"mirror_url":null,"archived":false,"open_issues_count":686,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2775,"open_issues":686,"watchers":8735,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/25284"},"html":{"href":"https://github.com/akka/akka/pull/25284"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/25284"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/25284/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/25284/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/25284/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/c03febd5c7045bc873784a8e7699004cec8d7b81"}},"author_association":"NONE"}}
{"actor":{"display_login":"patriknw"}}