{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/21748","repository_url":"https://api.github.com/repos/ceph/ceph","labels_url":"https://api.github.com/repos/ceph/ceph/issues/21748/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/21748/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/21748/events","html_url":"https://github.com/ceph/ceph/pull/21748","id":319067843,"number":21748,"title":"prometheus: Fix prometheus shutdown/restart","user":{"login":"b-ranto","id":8439091,"avatar_url":"https://avatars2.githubusercontent.com/u/8439091?v=4","gravatar_id":"","url":"https://api.github.com/users/b-ranto","html_url":"https://github.com/b-ranto","followers_url":"https://api.github.com/users/b-ranto/followers","following_url":"https://api.github.com/users/b-ranto/following{/other_user}","gists_url":"https://api.github.com/users/b-ranto/gists{/gist_id}","starred_url":"https://api.github.com/users/b-ranto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-ranto/subscriptions","organizations_url":"https://api.github.com/users/b-ranto/orgs","repos_url":"https://api.github.com/users/b-ranto/repos","events_url":"https://api.github.com/users/b-ranto/events{/privacy}","received_events_url":"https://api.github.com/users/b-ranto/received_events","type":"User","site_admin":false},"labels":[{"id":219859248,"url":"https://api.github.com/repos/ceph/ceph/labels/wip-kefu-testing","name":"wip-kefu-testing","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-30T23:18:38Z","updated_at":"2018-05-01T14:25:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/21748","html_url":"https://github.com/ceph/ceph/pull/21748","diff_url":"https://github.com/ceph/ceph/pull/21748.diff","patch_url":"https://github.com/ceph/ceph/pull/21748.patch"},"body":"The prometheus serve method uses block which it should not as it can\r\ncause several problems when shutting down (restarting) ceph-mgr. As a\r\nresult the restart of the ceph-mgr module will block until time-out if\r\nthe prometheus module is enabled. This fixes the problem by using a\r\nsimple simple shutdown_event instead of block() and stopping the server\r\nafterwards.\r\n\r\nSigned-off-by: Boris Ranto <branto@redhat.com>"},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/385683263","html_url":"https://github.com/ceph/ceph/pull/21748#issuecomment-385683263","issue_url":"https://api.github.com/repos/ceph/ceph/issues/21748","id":385683263,"user":{"login":"b-ranto","id":8439091,"avatar_url":"https://avatars2.githubusercontent.com/u/8439091?v=4","gravatar_id":"","url":"https://api.github.com/users/b-ranto","html_url":"https://github.com/b-ranto","followers_url":"https://api.github.com/users/b-ranto/followers","following_url":"https://api.github.com/users/b-ranto/following{/other_user}","gists_url":"https://api.github.com/users/b-ranto/gists{/gist_id}","starred_url":"https://api.github.com/users/b-ranto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-ranto/subscriptions","organizations_url":"https://api.github.com/users/b-ranto/orgs","repos_url":"https://api.github.com/users/b-ranto/repos","events_url":"https://api.github.com/users/b-ranto/events{/privacy}","received_events_url":"https://api.github.com/users/b-ranto/received_events","type":"User","site_admin":false},"created_at":"2018-05-01T14:25:12Z","updated_at":"2018-05-01T14:25:12Z","author_association":"CONTRIBUTOR","body":"@tchaikov Could you test this together with #21749 ? They should both apply cleanly."}}
{"actor":{"display_login":"b-ranto"}}