{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/181223655","pull_request_review_id":111796442,"id":181223655,"diff_hunk":"@@ -466,15 +465,15 @@ func generateProbeConfigForRouter(cfg *RouterConfig, ports []kapi.ContainerPort)\n }\n \n func generateLivenessProbeConfig(cfg *RouterConfig, ports []kapi.ContainerPort) *kapi.Probe {\n-\tprobe := generateProbeConfigForRouter(cfg, ports)\n+\tprobe := generateProbeConfigForRouter(\"/healthz/ready\", cfg, ports)","path":"pkg/oc/admin/router/router.go","position":42,"original_position":42,"commit_id":"2f18e8c7f70b66e6dc6b4c8ae03992f544bfd75b","original_commit_id":"2f18e8c7f70b66e6dc6b4c8ae03992f544bfd75b","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars0.githubusercontent.com/u/1163175?v=4","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"body":"There's no way we can use these names without it being utterly confusing.  Your readiness probe is using our canonical liveness probe path, and your liveness probe is using our canonical readiness path.\r\n\r\nChange the path you added to the router to `/healthz/controller` (the health of the controller) and that mitigates it.\r\n\r\nHowever, this is still not the correct default configuration.  By default we should be using `/healthz` for liveness.  It's only when you want the \"don't bind until loaded\" behavior that these should flip.  Unless we switched to \"don't bind until loaded\" by default in the router and I missed it?","created_at":"2018-04-12T21:13:22Z","updated_at":"2018-04-12T21:13:22Z","html_url":"https://github.com/openshift/origin/pull/19009#discussion_r181223655","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/19009","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/181223655"},"html":{"href":"https://github.com/openshift/origin/pull/19009#discussion_r181223655"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/19009"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/19009","id":175627823,"html_url":"https://github.com/openshift/origin/pull/19009","diff_url":"https://github.com/openshift/origin/pull/19009.diff","patch_url":"https://github.com/openshift/origin/pull/19009.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/19009","number":19009,"state":"open","locked":false,"title":"Differentiate liveness and readiness probes for router pods","user":{"login":"JacobTanenbaum","id":13948445,"avatar_url":"https://avatars0.githubusercontent.com/u/13948445?v=4","gravatar_id":"","url":"https://api.github.com/users/JacobTanenbaum","html_url":"https://github.com/JacobTanenbaum","followers_url":"https://api.github.com/users/JacobTanenbaum/followers","following_url":"https://api.github.com/users/JacobTanenbaum/following{/other_user}","gists_url":"https://api.github.com/users/JacobTanenbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/JacobTanenbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacobTanenbaum/subscriptions","organizations_url":"https://api.github.com/users/JacobTanenbaum/orgs","repos_url":"https://api.github.com/users/JacobTanenbaum/repos","events_url":"https://api.github.com/users/JacobTanenbaum/events{/privacy}","received_events_url":"https://api.github.com/users/JacobTanenbaum/received_events","type":"User","site_admin":false},"body":"Add a backend to the router controller \"/livez\" that always returns true. This differentiates the liveness and\r\nreadiness probes so that a router can be alive and not ready.\r\n\r\nBug [1550007](https://bugzilla.redhat.com/show_bug.cgi?id=1550007)","created_at":"2018-03-16T19:37:50Z","updated_at":"2018-04-12T21:13:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c84db5e55a3a1a5aab7b24b101e8f806694623f1","assignee":{"login":"pravisankar","id":1258630,"avatar_url":"https://avatars0.githubusercontent.com/u/1258630?v=4","gravatar_id":"","url":"https://api.github.com/users/pravisankar","html_url":"https://github.com/pravisankar","followers_url":"https://api.github.com/users/pravisankar/followers","following_url":"https://api.github.com/users/pravisankar/following{/other_user}","gists_url":"https://api.github.com/users/pravisankar/gists{/gist_id}","starred_url":"https://api.github.com/users/pravisankar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravisankar/subscriptions","organizations_url":"https://api.github.com/users/pravisankar/orgs","repos_url":"https://api.github.com/users/pravisankar/repos","events_url":"https://api.github.com/users/pravisankar/events{/privacy}","received_events_url":"https://api.github.com/users/pravisankar/received_events","type":"User","site_admin":false},"assignees":[{"login":"ramr","id":928868,"avatar_url":"https://avatars1.githubusercontent.com/u/928868?v=4","gravatar_id":"","url":"https://api.github.com/users/ramr","html_url":"https://github.com/ramr","followers_url":"https://api.github.com/users/ramr/followers","following_url":"https://api.github.com/users/ramr/following{/other_user}","gists_url":"https://api.github.com/users/ramr/gists{/gist_id}","starred_url":"https://api.github.com/users/ramr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramr/subscriptions","organizations_url":"https://api.github.com/users/ramr/orgs","repos_url":"https://api.github.com/users/ramr/repos","events_url":"https://api.github.com/users/ramr/events{/privacy}","received_events_url":"https://api.github.com/users/ramr/received_events","type":"User","site_admin":false},{"login":"pravisankar","id":1258630,"avatar_url":"https://avatars0.githubusercontent.com/u/1258630?v=4","gravatar_id":"","url":"https://api.github.com/users/pravisankar","html_url":"https://github.com/pravisankar","followers_url":"https://api.github.com/users/pravisankar/followers","following_url":"https://api.github.com/users/pravisankar/following{/other_user}","gists_url":"https://api.github.com/users/pravisankar/gists{/gist_id}","starred_url":"https://api.github.com/users/pravisankar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravisankar/subscriptions","organizations_url":"https://api.github.com/users/pravisankar/orgs","repos_url":"https://api.github.com/users/pravisankar/repos","events_url":"https://api.github.com/users/pravisankar/events{/privacy}","received_events_url":"https://api.github.com/users/pravisankar/received_events","type":"User","site_admin":false},{"login":"knobunc","id":10033853,"avatar_url":"https://avatars1.githubusercontent.com/u/10033853?v=4","gravatar_id":"","url":"https://api.github.com/users/knobunc","html_url":"https://github.com/knobunc","followers_url":"https://api.github.com/users/knobunc/followers","following_url":"https://api.github.com/users/knobunc/following{/other_user}","gists_url":"https://api.github.com/users/knobunc/gists{/gist_id}","starred_url":"https://api.github.com/users/knobunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knobunc/subscriptions","organizations_url":"https://api.github.com/users/knobunc/orgs","repos_url":"https://api.github.com/users/knobunc/repos","events_url":"https://api.github.com/users/knobunc/events{/privacy}","received_events_url":"https://api.github.com/users/knobunc/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"juanvallejo","id":3902875,"avatar_url":"https://avatars2.githubusercontent.com/u/3902875?v=4","gravatar_id":"","url":"https://api.github.com/users/juanvallejo","html_url":"https://github.com/juanvallejo","followers_url":"https://api.github.com/users/juanvallejo/followers","following_url":"https://api.github.com/users/juanvallejo/following{/other_user}","gists_url":"https://api.github.com/users/juanvallejo/gists{/gist_id}","starred_url":"https://api.github.com/users/juanvallejo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanvallejo/subscriptions","organizations_url":"https://api.github.com/users/juanvallejo/orgs","repos_url":"https://api.github.com/users/juanvallejo/repos","events_url":"https://api.github.com/users/juanvallejo/events{/privacy}","received_events_url":"https://api.github.com/users/juanvallejo/received_events","type":"User","site_admin":false},{"login":"knobunc","id":10033853,"avatar_url":"https://avatars1.githubusercontent.com/u/10033853?v=4","gravatar_id":"","url":"https://api.github.com/users/knobunc","html_url":"https://github.com/knobunc","followers_url":"https://api.github.com/users/knobunc/followers","following_url":"https://api.github.com/users/knobunc/following{/other_user}","gists_url":"https://api.github.com/users/knobunc/gists{/gist_id}","starred_url":"https://api.github.com/users/knobunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knobunc/subscriptions","organizations_url":"https://api.github.com/users/knobunc/orgs","repos_url":"https://api.github.com/users/knobunc/repos","events_url":"https://api.github.com/users/knobunc/events{/privacy}","received_events_url":"https://api.github.com/users/knobunc/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":210156239,"url":"https://api.github.com/repos/openshift/origin/labels/component/routing","name":"component/routing","color":"0052cc","default":false},{"id":118251699,"url":"https://api.github.com/repos/openshift/origin/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":223479084,"url":"https://api.github.com/repos/openshift/origin/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":640547984,"url":"https://api.github.com/repos/openshift/origin/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/19009/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/19009/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/19009/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/2f18e8c7f70b66e6dc6b4c8ae03992f544bfd75b","head":{"label":"JacobTanenbaum:BZ1550007","ref":"BZ1550007","sha":"2f18e8c7f70b66e6dc6b4c8ae03992f544bfd75b","user":{"login":"JacobTanenbaum","id":13948445,"avatar_url":"https://avatars0.githubusercontent.com/u/13948445?v=4","gravatar_id":"","url":"https://api.github.com/users/JacobTanenbaum","html_url":"https://github.com/JacobTanenbaum","followers_url":"https://api.github.com/users/JacobTanenbaum/followers","following_url":"https://api.github.com/users/JacobTanenbaum/following{/other_user}","gists_url":"https://api.github.com/users/JacobTanenbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/JacobTanenbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacobTanenbaum/subscriptions","organizations_url":"https://api.github.com/users/JacobTanenbaum/orgs","repos_url":"https://api.github.com/users/JacobTanenbaum/repos","events_url":"https://api.github.com/users/JacobTanenbaum/events{/privacy}","received_events_url":"https://api.github.com/users/JacobTanenbaum/received_events","type":"User","site_admin":false},"repo":{"id":55235618,"name":"origin","full_name":"JacobTanenbaum/origin","owner":{"login":"JacobTanenbaum","id":13948445,"avatar_url":"https://avatars0.githubusercontent.com/u/13948445?v=4","gravatar_id":"","url":"https://api.github.com/users/JacobTanenbaum","html_url":"https://github.com/JacobTanenbaum","followers_url":"https://api.github.com/users/JacobTanenbaum/followers","following_url":"https://api.github.com/users/JacobTanenbaum/following{/other_user}","gists_url":"https://api.github.com/users/JacobTanenbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/JacobTanenbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JacobTanenbaum/subscriptions","organizations_url":"https://api.github.com/users/JacobTanenbaum/orgs","repos_url":"https://api.github.com/users/JacobTanenbaum/repos","events_url":"https://api.github.com/users/JacobTanenbaum/events{/privacy}","received_events_url":"https://api.github.com/users/JacobTanenbaum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JacobTanenbaum/origin","description":"The Continuous Application Platform - build, deploy, and manage cloud-native and legacy applications on Kubernetes and Docker","fork":true,"url":"https://api.github.com/repos/JacobTanenbaum/origin","forks_url":"https://api.github.com/repos/JacobTanenbaum/origin/forks","keys_url":"https://api.github.com/repos/JacobTanenbaum/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JacobTanenbaum/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JacobTanenbaum/origin/teams","hooks_url":"https://api.github.com/repos/JacobTanenbaum/origin/hooks","issue_events_url":"https://api.github.com/repos/JacobTanenbaum/origin/issues/events{/number}","events_url":"https://api.github.com/repos/JacobTanenbaum/origin/events","assignees_url":"https://api.github.com/repos/JacobTanenbaum/origin/assignees{/user}","branches_url":"https://api.github.com/repos/JacobTanenbaum/origin/branches{/branch}","tags_url":"https://api.github.com/repos/JacobTanenbaum/origin/tags","blobs_url":"https://api.github.com/repos/JacobTanenbaum/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JacobTanenbaum/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JacobTanenbaum/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/JacobTanenbaum/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JacobTanenbaum/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/JacobTanenbaum/origin/languages","stargazers_url":"https://api.github.com/repos/JacobTanenbaum/origin/stargazers","contributors_url":"https://api.github.com/repos/JacobTanenbaum/origin/contributors","subscribers_url":"https://api.github.com/repos/JacobTanenbaum/origin/subscribers","subscription_url":"https://api.github.com/repos/JacobTanenbaum/origin/subscription","commits_url":"https://api.github.com/repos/JacobTanenbaum/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/JacobTanenbaum/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/JacobTanenbaum/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/JacobTanenbaum/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/JacobTanenbaum/origin/contents/{+path}","compare_url":"https://api.github.com/repos/JacobTanenbaum/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JacobTanenbaum/origin/merges","archive_url":"https://api.github.com/repos/JacobTanenbaum/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JacobTanenbaum/origin/downloads","issues_url":"https://api.github.com/repos/JacobTanenbaum/origin/issues{/number}","pulls_url":"https://api.github.com/repos/JacobTanenbaum/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/JacobTanenbaum/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/JacobTanenbaum/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JacobTanenbaum/origin/labels{/name}","releases_url":"https://api.github.com/repos/JacobTanenbaum/origin/releases{/id}","deployments_url":"https://api.github.com/repos/JacobTanenbaum/origin/deployments","created_at":"2016-04-01T13:46:55Z","updated_at":"2018-04-12T17:30:51Z","pushed_at":"2018-04-12T17:30:12Z","git_url":"git://github.com/JacobTanenbaum/origin.git","ssh_url":"git@github.com:JacobTanenbaum/origin.git","clone_url":"https://github.com/JacobTanenbaum/origin.git","svn_url":"https://github.com/JacobTanenbaum/origin","homepage":"http://www.openshift.org","size":897695,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"e41a0ac5c3950e28b1238251dfe6f3fe8943d8dc","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2018-04-12T20:10:11Z","pushed_at":"2018-04-12T20:14:41Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":902464,"stargazers_count":4359,"watchers_count":4359,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2710,"mirror_url":null,"archived":false,"open_issues_count":1246,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2710,"open_issues":1246,"watchers":4359,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/19009"},"html":{"href":"https://github.com/openshift/origin/pull/19009"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/19009"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/19009/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/19009/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/19009/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/2f18e8c7f70b66e6dc6b4c8ae03992f544bfd75b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"smarterclayton"}}