{"action":"created","comment":{"url":"https://api.github.com/repos/prebid/prebid-universal-creative/pulls/comments/218946358","pull_request_review_id":156999287,"id":218946358,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODk0NjM1OA==","diff_hunk":"@@ -1,17 +1,24 @@\n-<script src = \"https://cdn.jsdelivr.net/npm/prebid-universal-creative@0.4.0/dist/creative.js\"></script>\n+<script src = \"https://acdn.adnxs.com/prebid/universal-creative/creative.js\"></script>\n <script>\n-var adId = \"%%PATTERN:hb_adid%%\";\n-var cacheHost = \"%%PATTERN:hb_cache_host%%\";\n-var cachePath = \"%%PATTERN:hb_cache_path%%\";\n-var uuid = \"%%PATTERN:hb_cache_id%%\";\n-var mediaType = \"%%PATTERN:hb_format%%\";\n-var pubUrl = \"%%PATTERN:url%%\";\n-var env = \"%%PATTERN:hb_env%%\";\n-var size = \"%%PATTERN:hb_size%%\";\n+  var ucTagData = {};\n+  ucTagData.adServerDomain = \"\";\n+  ucTagData.pubUrl = \"%%PATTERN:url%%\";\n \n-try {    \n-    pbjs.renderAd(document, adId, {cacheHost: cacheHost, cachePath: cachePath, uuid: uuid, mediaType: mediaType, pubUrl: pubUrl, env: env, size: size});\n-} catch(e) {\n+  // if not DFP, use these params\n+  ucTagData.adId = \"%%PATTERN:hb_adid%%\";\n+  ucTagData.cacheHost = \"%%PATTERN:hb_cache_host%%\";\n+  ucTagData.cachePath = \"%%PATTERN:hb_cache_path%%\";\n+  ucTagData.uuid = \"%%PATTERN:hb_cache_id%%\";\n+  ucTagData.mediaType = \"%%PATTERN:hb_format%%\";\n+  ucTagData.env = \"%%PATTERN:hb_env%%\";\n+  ucTagData.size = \"%%PATTERN:hb_size%%\";\n+\n+  // if DFP, use this param","path":"template/amp/dfp-creative.html","position":28,"original_position":28,"commit_id":"e96bcac8fd85a887c944a79cd29abd8e9e70be94","original_commit_id":"e96bcac8fd85a887c944a79cd29abd8e9e70be94","user":{"login":"jaiminpanchal27","id":7393273,"node_id":"MDQ6VXNlcjczOTMyNzM=","avatar_url":"https://avatars2.githubusercontent.com/u/7393273?v=4","gravatar_id":"","url":"https://api.github.com/users/jaiminpanchal27","html_url":"https://github.com/jaiminpanchal27","followers_url":"https://api.github.com/users/jaiminpanchal27/followers","following_url":"https://api.github.com/users/jaiminpanchal27/following{/other_user}","gists_url":"https://api.github.com/users/jaiminpanchal27/gists{/gist_id}","starred_url":"https://api.github.com/users/jaiminpanchal27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaiminpanchal27/subscriptions","organizations_url":"https://api.github.com/users/jaiminpanchal27/orgs","repos_url":"https://api.github.com/users/jaiminpanchal27/repos","events_url":"https://api.github.com/users/jaiminpanchal27/events{/privacy}","received_events_url":"https://api.github.com/users/jaiminpanchal27/received_events","type":"User","site_admin":false},"body":"Should we move this up (after line 5) ? Because most of the time adserver will be DFP. ","created_at":"2018-09-19T20:08:56Z","updated_at":"2018-09-19T20:28:58Z","html_url":"https://github.com/prebid/prebid-universal-creative/pull/25#discussion_r218946358","pull_request_url":"https://api.github.com/repos/prebid/prebid-universal-creative/pulls/25","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/prebid/prebid-universal-creative/pulls/comments/218946358"},"html":{"href":"https://github.com/prebid/prebid-universal-creative/pull/25#discussion_r218946358"},"pull_request":{"href":"https://api.github.com/repos/prebid/prebid-universal-creative/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/prebid/prebid-universal-creative/pulls/25","id":216065991,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MDY1OTkx","html_url":"https://github.com/prebid/prebid-universal-creative/pull/25","diff_url":"https://github.com/prebid/prebid-universal-creative/pull/25.diff","patch_url":"https://github.com/prebid/prebid-universal-creative/pull/25.patch","issue_url":"https://api.github.com/repos/prebid/prebid-universal-creative/issues/25","number":25,"state":"open","locked":false,"title":"Tag 1.0 updates","user":{"login":"jsnellbaker","id":31102355,"node_id":"MDQ6VXNlcjMxMTAyMzU1","avatar_url":"https://avatars1.githubusercontent.com/u/31102355?v=4","gravatar_id":"","url":"https://api.github.com/users/jsnellbaker","html_url":"https://github.com/jsnellbaker","followers_url":"https://api.github.com/users/jsnellbaker/followers","following_url":"https://api.github.com/users/jsnellbaker/following{/other_user}","gists_url":"https://api.github.com/users/jsnellbaker/gists{/gist_id}","starred_url":"https://api.github.com/users/jsnellbaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsnellbaker/subscriptions","organizations_url":"https://api.github.com/users/jsnellbaker/orgs","repos_url":"https://api.github.com/users/jsnellbaker/repos","events_url":"https://api.github.com/users/jsnellbaker/events{/privacy}","received_events_url":"https://api.github.com/users/jsnellbaker/received_events","type":"User","site_admin":false},"body":"The following changes are included:\r\n- add support for `adServerDomain` param in tag for safeframe environments.  This allows the publisher to set a value for the safeframe domain (previously used hard-coded DFP safeframe domain)\r\n- add support to use DFP `%%PATTERN:TARGETINGMAP%%` macro to dynamically pass in the auction keys to the universal creative rendering function.  The macro provides an object map with each auction key used for that DFP creative; the values for each key are stored in a single array string.\r\n- reworked the tag structure/API to support the above TARGETINGMAP approach and the old approach (for non-DFP) ad-servers.  See example in `dfp-example.html` file for reference.\r\n    - renamed global object `pbjs` to `ucTag` when calling the `renderAd` function","created_at":"2018-09-17T18:01:42Z","updated_at":"2018-09-19T20:28:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"458ddfeec2757b78304d883b4c5f0243a10e0382","assignee":{"login":"jaiminpanchal27","id":7393273,"node_id":"MDQ6VXNlcjczOTMyNzM=","avatar_url":"https://avatars2.githubusercontent.com/u/7393273?v=4","gravatar_id":"","url":"https://api.github.com/users/jaiminpanchal27","html_url":"https://github.com/jaiminpanchal27","followers_url":"https://api.github.com/users/jaiminpanchal27/followers","following_url":"https://api.github.com/users/jaiminpanchal27/following{/other_user}","gists_url":"https://api.github.com/users/jaiminpanchal27/gists{/gist_id}","starred_url":"https://api.github.com/users/jaiminpanchal27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaiminpanchal27/subscriptions","organizations_url":"https://api.github.com/users/jaiminpanchal27/orgs","repos_url":"https://api.github.com/users/jaiminpanchal27/repos","events_url":"https://api.github.com/users/jaiminpanchal27/events{/privacy}","received_events_url":"https://api.github.com/users/jaiminpanchal27/received_events","type":"User","site_admin":false},"assignees":[{"login":"jaiminpanchal27","id":7393273,"node_id":"MDQ6VXNlcjczOTMyNzM=","avatar_url":"https://avatars2.githubusercontent.com/u/7393273?v=4","gravatar_id":"","url":"https://api.github.com/users/jaiminpanchal27","html_url":"https://github.com/jaiminpanchal27","followers_url":"https://api.github.com/users/jaiminpanchal27/followers","following_url":"https://api.github.com/users/jaiminpanchal27/following{/other_user}","gists_url":"https://api.github.com/users/jaiminpanchal27/gists{/gist_id}","starred_url":"https://api.github.com/users/jaiminpanchal27/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaiminpanchal27/subscriptions","organizations_url":"https://api.github.com/users/jaiminpanchal27/orgs","repos_url":"https://api.github.com/users/jaiminpanchal27/repos","events_url":"https://api.github.com/users/jaiminpanchal27/events{/privacy}","received_events_url":"https://api.github.com/users/jaiminpanchal27/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/prebid/prebid-universal-creative/pulls/25/commits","review_comments_url":"https://api.github.com/repos/prebid/prebid-universal-creative/pulls/25/comments","review_comment_url":"https://api.github.com/repos/prebid/prebid-universal-creative/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prebid/prebid-universal-creative/issues/25/comments","statuses_url":"https://api.github.com/repos/prebid/prebid-universal-creative/statuses/e96bcac8fd85a887c944a79cd29abd8e9e70be94","head":{"label":"prebid:tag_1.0_updates","ref":"tag_1.0_updates","sha":"e96bcac8fd85a887c944a79cd29abd8e9e70be94","user":{"login":"prebid","id":13242760,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMjQyNzYw","avatar_url":"https://avatars1.githubusercontent.com/u/13242760?v=4","gravatar_id":"","url":"https://api.github.com/users/prebid","html_url":"https://github.com/prebid","followers_url":"https://api.github.com/users/prebid/followers","following_url":"https://api.github.com/users/prebid/following{/other_user}","gists_url":"https://api.github.com/users/prebid/gists{/gist_id}","starred_url":"https://api.github.com/users/prebid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prebid/subscriptions","organizations_url":"https://api.github.com/users/prebid/orgs","repos_url":"https://api.github.com/users/prebid/repos","events_url":"https://api.github.com/users/prebid/events{/privacy}","received_events_url":"https://api.github.com/users/prebid/received_events","type":"Organization","site_admin":false},"repo":{"id":119910963,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk5MTA5NjM=","name":"prebid-universal-creative","full_name":"prebid/prebid-universal-creative","private":false,"owner":{"login":"prebid","id":13242760,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMjQyNzYw","avatar_url":"https://avatars1.githubusercontent.com/u/13242760?v=4","gravatar_id":"","url":"https://api.github.com/users/prebid","html_url":"https://github.com/prebid","followers_url":"https://api.github.com/users/prebid/followers","following_url":"https://api.github.com/users/prebid/following{/other_user}","gists_url":"https://api.github.com/users/prebid/gists{/gist_id}","starred_url":"https://api.github.com/users/prebid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prebid/subscriptions","organizations_url":"https://api.github.com/users/prebid/orgs","repos_url":"https://api.github.com/users/prebid/repos","events_url":"https://api.github.com/users/prebid/events{/privacy}","received_events_url":"https://api.github.com/users/prebid/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/prebid/prebid-universal-creative","description":null,"fork":false,"url":"https://api.github.com/repos/prebid/prebid-universal-creative","forks_url":"https://api.github.com/repos/prebid/prebid-universal-creative/forks","keys_url":"https://api.github.com/repos/prebid/prebid-universal-creative/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prebid/prebid-universal-creative/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prebid/prebid-universal-creative/teams","hooks_url":"https://api.github.com/repos/prebid/prebid-universal-creative/hooks","issue_events_url":"https://api.github.com/repos/prebid/prebid-universal-creative/issues/events{/number}","events_url":"https://api.github.com/repos/prebid/prebid-universal-creative/events","assignees_url":"https://api.github.com/repos/prebid/prebid-universal-creative/assignees{/user}","branches_url":"https://api.github.com/repos/prebid/prebid-universal-creative/branches{/branch}","tags_url":"https://api.github.com/repos/prebid/prebid-universal-creative/tags","blobs_url":"https://api.github.com/repos/prebid/prebid-universal-creative/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prebid/prebid-universal-creative/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prebid/prebid-universal-creative/git/refs{/sha}","trees_url":"https://api.github.com/repos/prebid/prebid-universal-creative/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prebid/prebid-universal-creative/statuses/{sha}","languages_url":"https://api.github.com/repos/prebid/prebid-universal-creative/languages","stargazers_url":"https://api.github.com/repos/prebid/prebid-universal-creative/stargazers","contributors_url":"https://api.github.com/repos/prebid/prebid-universal-creative/contributors","subscribers_url":"https://api.github.com/repos/prebid/prebid-universal-creative/subscribers","subscription_url":"https://api.github.com/repos/prebid/prebid-universal-creative/subscription","commits_url":"https://api.github.com/repos/prebid/prebid-universal-creative/commits{/sha}","git_commits_url":"https://api.github.com/repos/prebid/prebid-universal-creative/git/commits{/sha}","comments_url":"https://api.github.com/repos/prebid/prebid-universal-creative/comments{/number}","issue_comment_url":"https://api.github.com/repos/prebid/prebid-universal-creative/issues/comments{/number}","contents_url":"https://api.github.com/repos/prebid/prebid-universal-creative/contents/{+path}","compare_url":"https://api.github.com/repos/prebid/prebid-universal-creative/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prebid/prebid-universal-creative/merges","archive_url":"https://api.github.com/repos/prebid/prebid-universal-creative/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prebid/prebid-universal-creative/downloads","issues_url":"https://api.github.com/repos/prebid/prebid-universal-creative/issues{/number}","pulls_url":"https://api.github.com/repos/prebid/prebid-universal-creative/pulls{/number}","milestones_url":"https://api.github.com/repos/prebid/prebid-universal-creative/milestones{/number}","notifications_url":"https://api.github.com/repos/prebid/prebid-universal-creative/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prebid/prebid-universal-creative/labels{/name}","releases_url":"https://api.github.com/repos/prebid/prebid-universal-creative/releases{/id}","deployments_url":"https://api.github.com/repos/prebid/prebid-universal-creative/deployments","created_at":"2018-02-02T00:34:47Z","updated_at":"2018-07-10T20:56:39Z","pushed_at":"2018-09-19T18:21:51Z","git_url":"git://github.com/prebid/prebid-universal-creative.git","ssh_url":"git@github.com:prebid/prebid-universal-creative.git","clone_url":"https://github.com/prebid/prebid-universal-creative.git","svn_url":"https://github.com/prebid/prebid-universal-creative","homepage":null,"size":137,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":6,"watchers":2,"default_branch":"master"}},"base":{"label":"prebid:master","ref":"master","sha":"b6fda7b5097121bb52246569fd556e8fb582c250","user":{"login":"prebid","id":13242760,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMjQyNzYw","avatar_url":"https://avatars1.githubusercontent.com/u/13242760?v=4","gravatar_id":"","url":"https://api.github.com/users/prebid","html_url":"https://github.com/prebid","followers_url":"https://api.github.com/users/prebid/followers","following_url":"https://api.github.com/users/prebid/following{/other_user}","gists_url":"https://api.github.com/users/prebid/gists{/gist_id}","starred_url":"https://api.github.com/users/prebid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prebid/subscriptions","organizations_url":"https://api.github.com/users/prebid/orgs","repos_url":"https://api.github.com/users/prebid/repos","events_url":"https://api.github.com/users/prebid/events{/privacy}","received_events_url":"https://api.github.com/users/prebid/received_events","type":"Organization","site_admin":false},"repo":{"id":119910963,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk5MTA5NjM=","name":"prebid-universal-creative","full_name":"prebid/prebid-universal-creative","private":false,"owner":{"login":"prebid","id":13242760,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMjQyNzYw","avatar_url":"https://avatars1.githubusercontent.com/u/13242760?v=4","gravatar_id":"","url":"https://api.github.com/users/prebid","html_url":"https://github.com/prebid","followers_url":"https://api.github.com/users/prebid/followers","following_url":"https://api.github.com/users/prebid/following{/other_user}","gists_url":"https://api.github.com/users/prebid/gists{/gist_id}","starred_url":"https://api.github.com/users/prebid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prebid/subscriptions","organizations_url":"https://api.github.com/users/prebid/orgs","repos_url":"https://api.github.com/users/prebid/repos","events_url":"https://api.github.com/users/prebid/events{/privacy}","received_events_url":"https://api.github.com/users/prebid/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/prebid/prebid-universal-creative","description":null,"fork":false,"url":"https://api.github.com/repos/prebid/prebid-universal-creative","forks_url":"https://api.github.com/repos/prebid/prebid-universal-creative/forks","keys_url":"https://api.github.com/repos/prebid/prebid-universal-creative/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prebid/prebid-universal-creative/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prebid/prebid-universal-creative/teams","hooks_url":"https://api.github.com/repos/prebid/prebid-universal-creative/hooks","issue_events_url":"https://api.github.com/repos/prebid/prebid-universal-creative/issues/events{/number}","events_url":"https://api.github.com/repos/prebid/prebid-universal-creative/events","assignees_url":"https://api.github.com/repos/prebid/prebid-universal-creative/assignees{/user}","branches_url":"https://api.github.com/repos/prebid/prebid-universal-creative/branches{/branch}","tags_url":"https://api.github.com/repos/prebid/prebid-universal-creative/tags","blobs_url":"https://api.github.com/repos/prebid/prebid-universal-creative/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prebid/prebid-universal-creative/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prebid/prebid-universal-creative/git/refs{/sha}","trees_url":"https://api.github.com/repos/prebid/prebid-universal-creative/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prebid/prebid-universal-creative/statuses/{sha}","languages_url":"https://api.github.com/repos/prebid/prebid-universal-creative/languages","stargazers_url":"https://api.github.com/repos/prebid/prebid-universal-creative/stargazers","contributors_url":"https://api.github.com/repos/prebid/prebid-universal-creative/contributors","subscribers_url":"https://api.github.com/repos/prebid/prebid-universal-creative/subscribers","subscription_url":"https://api.github.com/repos/prebid/prebid-universal-creative/subscription","commits_url":"https://api.github.com/repos/prebid/prebid-universal-creative/commits{/sha}","git_commits_url":"https://api.github.com/repos/prebid/prebid-universal-creative/git/commits{/sha}","comments_url":"https://api.github.com/repos/prebid/prebid-universal-creative/comments{/number}","issue_comment_url":"https://api.github.com/repos/prebid/prebid-universal-creative/issues/comments{/number}","contents_url":"https://api.github.com/repos/prebid/prebid-universal-creative/contents/{+path}","compare_url":"https://api.github.com/repos/prebid/prebid-universal-creative/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prebid/prebid-universal-creative/merges","archive_url":"https://api.github.com/repos/prebid/prebid-universal-creative/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prebid/prebid-universal-creative/downloads","issues_url":"https://api.github.com/repos/prebid/prebid-universal-creative/issues{/number}","pulls_url":"https://api.github.com/repos/prebid/prebid-universal-creative/pulls{/number}","milestones_url":"https://api.github.com/repos/prebid/prebid-universal-creative/milestones{/number}","notifications_url":"https://api.github.com/repos/prebid/prebid-universal-creative/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prebid/prebid-universal-creative/labels{/name}","releases_url":"https://api.github.com/repos/prebid/prebid-universal-creative/releases{/id}","deployments_url":"https://api.github.com/repos/prebid/prebid-universal-creative/deployments","created_at":"2018-02-02T00:34:47Z","updated_at":"2018-07-10T20:56:39Z","pushed_at":"2018-09-19T18:21:51Z","git_url":"git://github.com/prebid/prebid-universal-creative.git","ssh_url":"git@github.com:prebid/prebid-universal-creative.git","clone_url":"https://github.com/prebid/prebid-universal-creative.git","svn_url":"https://github.com/prebid/prebid-universal-creative","homepage":null,"size":137,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prebid/prebid-universal-creative/pulls/25"},"html":{"href":"https://github.com/prebid/prebid-universal-creative/pull/25"},"issue":{"href":"https://api.github.com/repos/prebid/prebid-universal-creative/issues/25"},"comments":{"href":"https://api.github.com/repos/prebid/prebid-universal-creative/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/prebid/prebid-universal-creative/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/prebid/prebid-universal-creative/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prebid/prebid-universal-creative/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/prebid/prebid-universal-creative/statuses/e96bcac8fd85a887c944a79cd29abd8e9e70be94"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jaiminpanchal27"}}