{"action":"closed","issue":{"url":"https://api.github.com/repos/buildbot/buildbot/issues/3019","repository_url":"https://api.github.com/repos/buildbot/buildbot","labels_url":"https://api.github.com/repos/buildbot/buildbot/issues/3019/labels{/name}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/3019/comments","events_url":"https://api.github.com/repos/buildbot/buildbot/issues/3019/events","html_url":"https://github.com/buildbot/buildbot/issues/3019","id":213100293,"node_id":"MDU6SXNzdWUyMTMxMDAyOTM=","number":3019,"title":"wth 1382003: unreachable code?","user":{"login":"tardyp","id":109859,"node_id":"MDQ6VXNlcjEwOTg1OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/109859?v=4","gravatar_id":"","url":"https://api.github.com/users/tardyp","html_url":"https://github.com/tardyp","followers_url":"https://api.github.com/users/tardyp/followers","following_url":"https://api.github.com/users/tardyp/following{/other_user}","gists_url":"https://api.github.com/users/tardyp/gists{/gist_id}","starred_url":"https://api.github.com/users/tardyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tardyp/subscriptions","organizations_url":"https://api.github.com/users/tardyp/orgs","repos_url":"https://api.github.com/users/tardyp/repos","events_url":"https://api.github.com/users/tardyp/events{/privacy}","received_events_url":"https://api.github.com/users/tardyp/received_events","type":"User","site_admin":false},"labels":[{"id":557419407,"node_id":"MDU6TGFiZWw1NTc0MTk0MDc=","url":"https://api.github.com/repos/buildbot/buildbot/labels/easy","name":"easy","color":"0e8a16","default":false},{"id":798049821,"node_id":"MDU6TGFiZWw3OTgwNDk4MjE=","url":"https://api.github.com/repos/buildbot/buildbot/labels/good%20first%20issue","name":"good first issue","color":"62f794","default":true},{"id":557386829,"node_id":"MDU6TGFiZWw1NTczODY4Mjk=","url":"https://api.github.com/repos/buildbot/buildbot/labels/latent%20worker","name":"latent worker","color":"bfd4f2","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/buildbot/buildbot/milestones/5","html_url":"https://github.com/buildbot/buildbot/milestone/5","labels_url":"https://api.github.com/repos/buildbot/buildbot/milestones/5/labels","id":2374905,"node_id":"MDk6TWlsZXN0b25lMjM3NDkwNQ==","number":5,"title":"0.9.+","description":null,"creator":{"login":"tardyp","id":109859,"node_id":"MDQ6VXNlcjEwOTg1OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/109859?v=4","gravatar_id":"","url":"https://api.github.com/users/tardyp","html_url":"https://github.com/tardyp","followers_url":"https://api.github.com/users/tardyp/followers","following_url":"https://api.github.com/users/tardyp/following{/other_user}","gists_url":"https://api.github.com/users/tardyp/gists{/gist_id}","starred_url":"https://api.github.com/users/tardyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tardyp/subscriptions","organizations_url":"https://api.github.com/users/tardyp/orgs","repos_url":"https://api.github.com/users/tardyp/repos","events_url":"https://api.github.com/users/tardyp/events{/privacy}","received_events_url":"https://api.github.com/users/tardyp/received_events","type":"User","site_admin":false},"open_issues":123,"closed_issues":59,"state":"open","created_at":"2017-03-09T16:35:26Z","updated_at":"2018-11-05T08:28:42Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2017-03-09T16:57:37Z","updated_at":"2018-11-05T08:28:42Z","closed_at":"2018-11-05T08:28:42Z","author_association":"MEMBER","body":"This ticket is a migrated Trac ticket [3646](http://trac.buildbot.net/ticket/3646)\n\nPeople contributed to the original ticket: @sa2ajj\nTicket created on: `Nov 28 2016`\nTicket last modified on: `Nov 28 2016`\n\n---\n\nwhile reviewing Coverity findings, I found this code:\n\n[[buildbot/worker/ec2.py:293|https://github.com/buildbot/buildbot/blob/master/master/buildbot/worker/ec2.py#L293]]:\n\n        def _convert_deprecated_block_device_mapping(self, mapping_definitions):\n            new_mapping_definitions = []\n            for dev_name, dev_config in iteritems(mapping_definitions):\n                new_dev_config = {}\n                new_dev_config['[[DeviceName]]'] = dev_name\n                if dev_config:\n                    new_dev_config['Ebs'] = {}\n                    new_dev_config['Ebs']['[[DeleteOnTermination]]'] = dev_config.get(\n                        'delete_on_termination', True)\n                    new_dev_config[[                        'Encrypted'|'Ebs'][]] = dev_config.get('encrypted')\n                    new_dev_config['Ebs']['Iops'] = dev_config.get('iops')\n                    new_dev_config[[                        '[[SnapshotId]]'|'Ebs'][]] = dev_config.get('snapshot_id')\n                    new_dev_config['Ebs']['[[VolumeSize]]'] = dev_config.get('size')\n                    new_dev_config[[                        '[[VolumeType]]'|'Ebs'][]] = dev_config.get('volume_type')\n                    new_dev_config['Ebs'] = self._remove_none_opts(\n                        new_dev_config['Ebs'])\n                new_mapping_definitions.append(new_dev_config)\n            return new_mapping_definitions\n            if not mapping_definitions:\n                return None\n    \n            for mapping_definition in mapping_definitions:\n                ebs = mapping_definition.get('Ebs')\n                if ebs:\n                    ebs.setdefault('[[DeleteOnTermination]]', True)\n    \n            return mapping_definitions\n\n\nwhat the heck is going on here?\n\n(the number in the summary is CID (Coverity ID))\n\n\n---\n\n\n"}}
{"actor":{"display_login":"tardyp"}}