{"action":"created","comment":{"url":"https://api.github.com/repos/JabRef/jabref/pulls/comments/209421656","pull_request_review_id":145441502,"id":209421656,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTQyMTY1Ng==","diff_hunk":"@@ -0,0 +1,58 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+\n+<?import javafx.scene.control.*?>\n+<?import javafx.scene.layout.*?>\n+\n+<DialogPane xmlns:fx=\"http://javafx.com/fxml/1\" xmlns=\"http://javafx.com/javafx/8\"\n+            fx:controller=\"org.jabref.gui.ReplaceStringView\">\n+    <content>\n+        <BorderPane>\n+            <center>\n+                <BorderPane BorderPane.alignment=\"CENTER\">\n+                    <center>\n+                        <GridPane>\n+                            <columnConstraints>\n+                                <ColumnConstraints hgrow=\"SOMETIMES\" minWidth=\"10.0\" prefWidth=\"100.0\"/>\n+                                <ColumnConstraints hgrow=\"SOMETIMES\" minWidth=\"10.0\" prefWidth=\"100.0\"/>\n+                                <ColumnConstraints hgrow=\"SOMETIMES\" minWidth=\"10.0\" prefWidth=\"100.0\"/>\n+                                <ColumnConstraints hgrow=\"SOMETIMES\" minWidth=\"10.0\" prefWidth=\"100.0\"/>\n+                                <ColumnConstraints hgrow=\"SOMETIMES\" minWidth=\"10.0\" prefWidth=\"100.0\"/>\n+                            </columnConstraints>\n+                            <rowConstraints>\n+                                <RowConstraints minHeight=\"10.0\" prefHeight=\"30.0\" vgrow=\"SOMETIMES\"/>\n+                                <RowConstraints minHeight=\"10.0\" prefHeight=\"30.0\" vgrow=\"SOMETIMES\"/>\n+                                <RowConstraints minHeight=\"10.0\" prefHeight=\"30.0\" vgrow=\"SOMETIMES\"/>\n+                                <RowConstraints minHeight=\"10.0\" prefHeight=\"30.0\" vgrow=\"SOMETIMES\"/>\n+                                <RowConstraints minHeight=\"10.0\" prefHeight=\"30.0\" vgrow=\"SOMETIMES\"/>\n+                                <RowConstraints minHeight=\"10.0\" prefHeight=\"30.0\" vgrow=\"SOMETIMES\"/>\n+                                <RowConstraints minHeight=\"10.0\" prefHeight=\"30.0\" vgrow=\"SOMETIMES\"/>\n+                                <RowConstraints minHeight=\"10.0\" prefHeight=\"30.0\" vgrow=\"SOMETIMES\"/>\n+                            </rowConstraints>\n+                            <Label text=\"Find and Replace\"/>","path":"src/main/java/org/jabref/gui/ReplaceString.fxml","position":31,"original_position":31,"commit_id":"45152d57ec9bac46d1d409a39191dd8806523cd3","original_commit_id":"45152d57ec9bac46d1d409a39191dd8806523cd3","user":{"login":"Siedlerchr","id":320228,"node_id":"MDQ6VXNlcjMyMDIyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/320228?v=4","gravatar_id":"","url":"https://api.github.com/users/Siedlerchr","html_url":"https://github.com/Siedlerchr","followers_url":"https://api.github.com/users/Siedlerchr/followers","following_url":"https://api.github.com/users/Siedlerchr/following{/other_user}","gists_url":"https://api.github.com/users/Siedlerchr/gists{/gist_id}","starred_url":"https://api.github.com/users/Siedlerchr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Siedlerchr/subscriptions","organizations_url":"https://api.github.com/users/Siedlerchr/orgs","repos_url":"https://api.github.com/users/Siedlerchr/repos","events_url":"https://api.github.com/users/Siedlerchr/events{/privacy}","received_events_url":"https://api.github.com/users/Siedlerchr/received_events","type":"User","site_admin":false},"body":"I think you missed this one ;) But all others look good","created_at":"2018-08-11T09:10:23Z","updated_at":"2018-08-11T09:10:23Z","html_url":"https://github.com/JabRef/jabref/pull/4227#discussion_r209421656","pull_request_url":"https://api.github.com/repos/JabRef/jabref/pulls/4227","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/comments/209421656"},"html":{"href":"https://github.com/JabRef/jabref/pull/4227#discussion_r209421656"},"pull_request":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/4227"}}},"pull_request":{"url":"https://api.github.com/repos/JabRef/jabref/pulls/4227","id":203053376,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDUzMzc2","html_url":"https://github.com/JabRef/jabref/pull/4227","diff_url":"https://github.com/JabRef/jabref/pull/4227.diff","patch_url":"https://github.com/JabRef/jabref/pull/4227.patch","issue_url":"https://api.github.com/repos/JabRef/jabref/issues/4227","number":4227,"state":"open","locked":false,"title":"Fix Part of Issue#3861: Edit->Replace String","user":{"login":"marisuki","id":23026166,"node_id":"MDQ6VXNlcjIzMDI2MTY2","avatar_url":"https://avatars2.githubusercontent.com/u/23026166?v=4","gravatar_id":"","url":"https://api.github.com/users/marisuki","html_url":"https://github.com/marisuki","followers_url":"https://api.github.com/users/marisuki/followers","following_url":"https://api.github.com/users/marisuki/following{/other_user}","gists_url":"https://api.github.com/users/marisuki/gists{/gist_id}","starred_url":"https://api.github.com/users/marisuki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marisuki/subscriptions","organizations_url":"https://api.github.com/users/marisuki/orgs","repos_url":"https://api.github.com/users/marisuki/repos","events_url":"https://api.github.com/users/marisuki/events{/privacy}","received_events_url":"https://api.github.com/users/marisuki/received_events","type":"User","site_admin":false},"body":"Hi, we fixed part of the Issue[#3861](https://github.com/JabRef/jabref/issues/3861), change the Swing Dialog to the JavaFx Dialog: the Edit -> Replace String Dialog, we add 3 files and modified the general control to link the Replace String controller of JavaFX Dialog, and we did not delete the old dialog logic (ReplaceStringDialog.java). The outlook of Dialog hasn't change a lot, and the previous logic is inherited.\r\n\r\nThe Screenshot is pasted below, just like the design before. \r\n\r\n![githubjabrefreplacestring](https://user-images.githubusercontent.com/23026166/43776187-a2e8d052-9a81-11e8-9082-134586a94bda.png)\r\n\r\n\r\n----\r\n\r\n- [ ] Change in CHANGELOG.md described\r\n- [ ] Tests created for changes\r\n- [x] Manually tested changed features in running JabRef\r\n- [x] Screenshots added in PR description (for bigger UI changes)\r\n- [x] Ensured that [the git commit message is a good one](https://github.com/joelparkerhenderson/git_commit_message)\r\n- [ ] Check documentation status (Issue created for outdated help page at [help.jabref.org](https://github.com/JabRef/help.jabref.org/issues)?)\r\n\r\n","created_at":"2018-07-22T11:51:30Z","updated_at":"2018-08-11T09:10:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2eefd21179d77448354086cacb1f1e5155e5b49f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JabRef/jabref/pulls/4227/commits","review_comments_url":"https://api.github.com/repos/JabRef/jabref/pulls/4227/comments","review_comment_url":"https://api.github.com/repos/JabRef/jabref/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JabRef/jabref/issues/4227/comments","statuses_url":"https://api.github.com/repos/JabRef/jabref/statuses/45152d57ec9bac46d1d409a39191dd8806523cd3","head":{"label":"marisuki:ReplaceStringJFX","ref":"ReplaceStringJFX","sha":"45152d57ec9bac46d1d409a39191dd8806523cd3","user":{"login":"marisuki","id":23026166,"node_id":"MDQ6VXNlcjIzMDI2MTY2","avatar_url":"https://avatars2.githubusercontent.com/u/23026166?v=4","gravatar_id":"","url":"https://api.github.com/users/marisuki","html_url":"https://github.com/marisuki","followers_url":"https://api.github.com/users/marisuki/followers","following_url":"https://api.github.com/users/marisuki/following{/other_user}","gists_url":"https://api.github.com/users/marisuki/gists{/gist_id}","starred_url":"https://api.github.com/users/marisuki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marisuki/subscriptions","organizations_url":"https://api.github.com/users/marisuki/orgs","repos_url":"https://api.github.com/users/marisuki/repos","events_url":"https://api.github.com/users/marisuki/events{/privacy}","received_events_url":"https://api.github.com/users/marisuki/received_events","type":"User","site_admin":false},"repo":{"id":140091824,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAwOTE4MjQ=","name":"jabref","full_name":"marisuki/jabref","owner":{"login":"marisuki","id":23026166,"node_id":"MDQ6VXNlcjIzMDI2MTY2","avatar_url":"https://avatars2.githubusercontent.com/u/23026166?v=4","gravatar_id":"","url":"https://api.github.com/users/marisuki","html_url":"https://github.com/marisuki","followers_url":"https://api.github.com/users/marisuki/followers","following_url":"https://api.github.com/users/marisuki/following{/other_user}","gists_url":"https://api.github.com/users/marisuki/gists{/gist_id}","starred_url":"https://api.github.com/users/marisuki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marisuki/subscriptions","organizations_url":"https://api.github.com/users/marisuki/orgs","repos_url":"https://api.github.com/users/marisuki/repos","events_url":"https://api.github.com/users/marisuki/events{/privacy}","received_events_url":"https://api.github.com/users/marisuki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marisuki/jabref","description":"Graphical Java application for managing BibTeX and biblatex (.bib) databases","fork":true,"url":"https://api.github.com/repos/marisuki/jabref","forks_url":"https://api.github.com/repos/marisuki/jabref/forks","keys_url":"https://api.github.com/repos/marisuki/jabref/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marisuki/jabref/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marisuki/jabref/teams","hooks_url":"https://api.github.com/repos/marisuki/jabref/hooks","issue_events_url":"https://api.github.com/repos/marisuki/jabref/issues/events{/number}","events_url":"https://api.github.com/repos/marisuki/jabref/events","assignees_url":"https://api.github.com/repos/marisuki/jabref/assignees{/user}","branches_url":"https://api.github.com/repos/marisuki/jabref/branches{/branch}","tags_url":"https://api.github.com/repos/marisuki/jabref/tags","blobs_url":"https://api.github.com/repos/marisuki/jabref/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marisuki/jabref/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marisuki/jabref/git/refs{/sha}","trees_url":"https://api.github.com/repos/marisuki/jabref/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marisuki/jabref/statuses/{sha}","languages_url":"https://api.github.com/repos/marisuki/jabref/languages","stargazers_url":"https://api.github.com/repos/marisuki/jabref/stargazers","contributors_url":"https://api.github.com/repos/marisuki/jabref/contributors","subscribers_url":"https://api.github.com/repos/marisuki/jabref/subscribers","subscription_url":"https://api.github.com/repos/marisuki/jabref/subscription","commits_url":"https://api.github.com/repos/marisuki/jabref/commits{/sha}","git_commits_url":"https://api.github.com/repos/marisuki/jabref/git/commits{/sha}","comments_url":"https://api.github.com/repos/marisuki/jabref/comments{/number}","issue_comment_url":"https://api.github.com/repos/marisuki/jabref/issues/comments{/number}","contents_url":"https://api.github.com/repos/marisuki/jabref/contents/{+path}","compare_url":"https://api.github.com/repos/marisuki/jabref/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marisuki/jabref/merges","archive_url":"https://api.github.com/repos/marisuki/jabref/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marisuki/jabref/downloads","issues_url":"https://api.github.com/repos/marisuki/jabref/issues{/number}","pulls_url":"https://api.github.com/repos/marisuki/jabref/pulls{/number}","milestones_url":"https://api.github.com/repos/marisuki/jabref/milestones{/number}","notifications_url":"https://api.github.com/repos/marisuki/jabref/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marisuki/jabref/labels{/name}","releases_url":"https://api.github.com/repos/marisuki/jabref/releases{/id}","deployments_url":"https://api.github.com/repos/marisuki/jabref/deployments","created_at":"2018-07-07T14:37:48Z","updated_at":"2018-08-10T12:51:26Z","pushed_at":"2018-08-11T06:52:10Z","git_url":"git://github.com/marisuki/jabref.git","ssh_url":"git@github.com:marisuki/jabref.git","clone_url":"https://github.com/marisuki/jabref.git","svn_url":"https://github.com/marisuki/jabref","homepage":"https://www.jabref.org","size":105860,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JabRef:master","ref":"master","sha":"ce0e3b103eebbecc7be6250861f51151bfac4b71","user":{"login":"JabRef","id":3914421,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTQ0MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/3914421?v=4","gravatar_id":"","url":"https://api.github.com/users/JabRef","html_url":"https://github.com/JabRef","followers_url":"https://api.github.com/users/JabRef/followers","following_url":"https://api.github.com/users/JabRef/following{/other_user}","gists_url":"https://api.github.com/users/JabRef/gists{/gist_id}","starred_url":"https://api.github.com/users/JabRef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabRef/subscriptions","organizations_url":"https://api.github.com/users/JabRef/orgs","repos_url":"https://api.github.com/users/JabRef/repos","events_url":"https://api.github.com/users/JabRef/events{/privacy}","received_events_url":"https://api.github.com/users/JabRef/received_events","type":"Organization","site_admin":false},"repo":{"id":17634071,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYzNDA3MQ==","name":"jabref","full_name":"JabRef/jabref","owner":{"login":"JabRef","id":3914421,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTQ0MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/3914421?v=4","gravatar_id":"","url":"https://api.github.com/users/JabRef","html_url":"https://github.com/JabRef","followers_url":"https://api.github.com/users/JabRef/followers","following_url":"https://api.github.com/users/JabRef/following{/other_user}","gists_url":"https://api.github.com/users/JabRef/gists{/gist_id}","starred_url":"https://api.github.com/users/JabRef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabRef/subscriptions","organizations_url":"https://api.github.com/users/JabRef/orgs","repos_url":"https://api.github.com/users/JabRef/repos","events_url":"https://api.github.com/users/JabRef/events{/privacy}","received_events_url":"https://api.github.com/users/JabRef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JabRef/jabref","description":"Graphical Java application for managing BibTeX and biblatex (.bib) databases","fork":false,"url":"https://api.github.com/repos/JabRef/jabref","forks_url":"https://api.github.com/repos/JabRef/jabref/forks","keys_url":"https://api.github.com/repos/JabRef/jabref/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JabRef/jabref/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JabRef/jabref/teams","hooks_url":"https://api.github.com/repos/JabRef/jabref/hooks","issue_events_url":"https://api.github.com/repos/JabRef/jabref/issues/events{/number}","events_url":"https://api.github.com/repos/JabRef/jabref/events","assignees_url":"https://api.github.com/repos/JabRef/jabref/assignees{/user}","branches_url":"https://api.github.com/repos/JabRef/jabref/branches{/branch}","tags_url":"https://api.github.com/repos/JabRef/jabref/tags","blobs_url":"https://api.github.com/repos/JabRef/jabref/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JabRef/jabref/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JabRef/jabref/git/refs{/sha}","trees_url":"https://api.github.com/repos/JabRef/jabref/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JabRef/jabref/statuses/{sha}","languages_url":"https://api.github.com/repos/JabRef/jabref/languages","stargazers_url":"https://api.github.com/repos/JabRef/jabref/stargazers","contributors_url":"https://api.github.com/repos/JabRef/jabref/contributors","subscribers_url":"https://api.github.com/repos/JabRef/jabref/subscribers","subscription_url":"https://api.github.com/repos/JabRef/jabref/subscription","commits_url":"https://api.github.com/repos/JabRef/jabref/commits{/sha}","git_commits_url":"https://api.github.com/repos/JabRef/jabref/git/commits{/sha}","comments_url":"https://api.github.com/repos/JabRef/jabref/comments{/number}","issue_comment_url":"https://api.github.com/repos/JabRef/jabref/issues/comments{/number}","contents_url":"https://api.github.com/repos/JabRef/jabref/contents/{+path}","compare_url":"https://api.github.com/repos/JabRef/jabref/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JabRef/jabref/merges","archive_url":"https://api.github.com/repos/JabRef/jabref/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JabRef/jabref/downloads","issues_url":"https://api.github.com/repos/JabRef/jabref/issues{/number}","pulls_url":"https://api.github.com/repos/JabRef/jabref/pulls{/number}","milestones_url":"https://api.github.com/repos/JabRef/jabref/milestones{/number}","notifications_url":"https://api.github.com/repos/JabRef/jabref/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JabRef/jabref/labels{/name}","releases_url":"https://api.github.com/repos/JabRef/jabref/releases{/id}","deployments_url":"https://api.github.com/repos/JabRef/jabref/deployments","created_at":"2014-03-11T14:48:42Z","updated_at":"2018-08-10T12:30:08Z","pushed_at":"2018-08-11T06:52:11Z","git_url":"git://github.com/JabRef/jabref.git","ssh_url":"git@github.com:JabRef/jabref.git","clone_url":"https://github.com/JabRef/jabref.git","svn_url":"https://github.com/JabRef/jabref","homepage":"https://www.jabref.org","size":106007,"stargazers_count":1027,"watchers_count":1027,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":737,"mirror_url":null,"archived":false,"open_issues_count":220,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":737,"open_issues":220,"watchers":1027,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/4227"},"html":{"href":"https://github.com/JabRef/jabref/pull/4227"},"issue":{"href":"https://api.github.com/repos/JabRef/jabref/issues/4227"},"comments":{"href":"https://api.github.com/repos/JabRef/jabref/issues/4227/comments"},"review_comments":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/4227/comments"},"review_comment":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/4227/commits"},"statuses":{"href":"https://api.github.com/repos/JabRef/jabref/statuses/45152d57ec9bac46d1d409a39191dd8806523cd3"}},"author_association":"NONE"}}
{"actor":{"display_login":"Siedlerchr"}}